[Libreoffice-commits] core.git: scp2/source
scp2/source/draw/registryitem_draw.scp |1 + scp2/source/draw/registryitem_draw.ulf |2 ++ 2 files changed, 3 insertions(+) New commits: commit 35702fd6781542f5eefbd3710304ab9a25ac61fe Author: Samuel Mehrbrodt AuthorDate: Mon Sep 12 15:54:47 2022 +0200 Commit: Samuel Mehrbrodt CommitDate: Thu Sep 15 07:29:42 2022 +0200 Add pdf file association to Windows installer Draw can handle PDF files, so offer them in "Open with" menu Change-Id: I1c8f9af8e38ee15490371074d02a2ccf35933076 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139802 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt diff --git a/scp2/source/draw/registryitem_draw.scp b/scp2/source/draw/registryitem_draw.scp index 79440c00653b..515b55fb58f7 100644 --- a/scp2/source/draw/registryitem_draw.scp +++ b/scp2/source/draw/registryitem_draw.scp @@ -1093,6 +1093,7 @@ CONDITIONAL_REGISTER_DOC_EXTENSION( Xbm, gid_Module_Prg_Draw_Other_Reg, xbm, X CONDITIONAL_REGISTER_DOC_EXTENSION( Xpm, gid_Module_Prg_Draw_Other_Reg, xpm, XPM, X_PIXMAP, 5, sdraw.exe, open, Draw ) CONDITIONAL_REGISTER_DOC_EXTENSION( PCD, gid_Module_Prg_Draw_Other_Reg, pcd, PCD, KODAK_PHOTO_CD_IMAGE, 5, sdraw.exe, open, Draw ) CONDITIONAL_REGISTER_DOC_EXTENSION( Webp, gid_Module_Prg_Draw_Other_Reg, webp, WEBP, WEBP, 5, sdraw.exe, open, Draw ) +CONDITIONAL_REGISTER_DOC_EXTENSION( Pdf, gid_Module_Prg_Draw_Other_Reg, pdf, PDF, PDF, 5, sdraw.exe, open, Draw ) // registering ms-visio URI scheme handler CONDITIONAL_REGISTER_URI_HANDLER( ms-visio, ms_visio, gid_Module_Prg_Draw_MSO_Reg, SELECT_VISIO ) diff --git a/scp2/source/draw/registryitem_draw.ulf b/scp2/source/draw/registryitem_draw.ulf index f122dc7daf6d..5d1335bb8b25 100644 --- a/scp2/source/draw/registryitem_draw.ulf +++ b/scp2/source/draw/registryitem_draw.ulf @@ -115,3 +115,5 @@ en-US = "X Pixmap File" [STR_REG_VAL_KODAK_PHOTO_CD_IMAGE] en-US = "Kodak Photo CD Image File" +[STR_REG_VAL_PDF] +en-US = "PDF (Portable Document Format)"
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
3 new defect(s) introduced to LibreOffice found with Coverity Scan.
6 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)
** CID 1514678: Uninitialized variables (UNINIT)
*** CID 1514678: Uninitialized variables (UNINIT)
/chart2/source/controller/main/ChartController_Properties.cxx: 783 in
chart::ChartController::executeDlg_ObjectProperties_withoutUndoGuard(const
rtl::OUString &, bool)()
777 SfxItemSet
aSymbolShapeProperties(aSymbolItemConverter.CreateEmptyItemSet() );
778 aSymbolItemConverter.FillItemSet( aSymbolShapeProperties );
779
780 sal_Int32 const nStandardSymbol=0;//@todo get from somewhere
781 std::optional oAutoSymbolGraphic(std::in_place,
aViewElementListProvider.GetSymbolGraphic( nStandardSymbol,
) );
782 // note: the dialog takes the ownership of
pSymbolShapeProperties and pAutoSymbolGraphic
>>> CID 1514678: Uninitialized variables (UNINIT)
>>> Using uninitialized value "._M_payload._M_payload" when
>>> calling "~optional".
783 aDlg.setSymbolInformation(
std::move(aSymbolShapeProperties), std::move(oAutoSymbolGraphic) );
784 }
785 if( aDialogParameter.HasStatisticProperties() )
786 {
787 aDlg.SetAxisMinorStepWidthForErrorBarDecimals(
788
InsertErrorBarsDialog::getAxisMinorStepWidthForErrorBarDecimals(
getChartModel(), m_xChartView, rObjectCID ) );
** CID 1514677: Uninitialized variables (UNINIT)
*** CID 1514677: Uninitialized variables (UNINIT)
/sw/source/core/undo/unins.cxx: 802 in
SwUndoReRead::SetAndSave(sw::UndoRedoContext &)()
796 }
797
798 if( MirrorGraph::Dont != nOldMirr )
799 pGrfNd->SetAttr( SwMirrorGrf() );
800
801 rContext.SetSelections(pGrfNd->GetFlyFormat(), nullptr);
>>> CID 1514677: Uninitialized variables (UNINIT)
>>> Using uninitialized value "oOldGrf._M_payload._M_payload" when calling
>>> "~optional".
802 }
803
804 void SwUndoReRead::UndoImpl(::sw::UndoRedoContext & rContext)
805 {
806 SetAndSave(rContext);
807 }
** CID 1514676: Control flow issues (DEADCODE)
/sw/source/uibase/utlui/content.cxx: 1881 in SwContentTree::CommandHdl(const
CommandEvent &)()
*** CID 1514676: Control flow issues (DEADCODE)
/sw/source/uibase/utlui/content.cxx: 1881 in SwContentTree::CommandHdl(const
CommandEvent &)()
1875 xPop->remove("deletecomment");
1876 if (bRemoveDeleteDrawingObjectEntry)
1877 xPop->remove("deletedrawingobject");
1878 if (bRemoveDeleteFieldEntry)
1879 xPop->remove("deletefield");
1880
>>> CID 1514676: Control flow issues (DEADCODE)
>>> Execution cannot reach the expression "bRemoveDeleteFrameEntry" inside
>>> this statement: "bRemoveDeleteEntry = bRemov...".
1881 bool bRemoveDeleteEntry =
1882 bRemoveDeleteChapterEntry ||
1883 bRemoveDeleteTableEntry ||
1884 bRemoveDeleteFrameEntry ||
1885 bRemoveDeleteImageEntry ||
1886 bRemoveDeleteOLEObjectEntry ||
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3Dw6zE_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJie9E2imSmL2Gy9BojteQAZyiyIGUjhCelincsysknQX-2Bt2UEHV4OsjqCnwZJ79jY8s-2BUZfQ67wBJs6h0Yezlwhg3g8JweqQYgwOoij7xrXb-2FbwLMPZ-2BotzRXKVuIW1ihc3QKbIF6g6g2bKq-2B9ryXUvyKmoLNnsb7mqSybZPlIgKo-3D
[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - sc/inc sc/source
sc/inc/addincol.hxx |4 +++-
sc/source/core/tool/addincol.cxx |8 +---
sc/source/core/tool/interpr4.cxx |2 +-
3 files changed, 9 insertions(+), 5 deletions(-)
New commits:
commit 32da7faefc6568bf07f27eedaae5488fdf68cb65
Author: Eike Rathke
AuthorDate: Wed Sep 14 00:19:04 2022 +0200
Commit: Mike Kaganski
CommitDate: Thu Sep 15 07:04:51 2022 +0200
Resolves: tdf#150926 Add-In result svl::SharedString needs to be interned
Change-Id: If582e7e1bf818dcf9eaddd5313aa21f5768a578f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139886
Reviewed-by: Eike Rathke
Tested-by: Jenkins
(cherry picked from commit a56e5434a4ed453b55b8f060ed18404d77a9fb10)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139842
Reviewed-by: Mike Kaganski
diff --git a/sc/inc/addincol.hxx b/sc/inc/addincol.hxx
index 9366e31b68ff..05ceea273c91 100644
--- a/sc/inc/addincol.hxx
+++ b/sc/inc/addincol.hxx
@@ -42,6 +42,7 @@ namespace com::sun::star::uno { class XInterface; }
class SfxObjectShell;
class ScUnoAddInFuncData;
class ScFuncDesc;
+class ScDocument;
typedef std::unordered_map< OUString, const ScUnoAddInFuncData* >
ScAddInHashMap;
@@ -188,6 +189,7 @@ private:
css::uno::Sequence aArgs;
css::uno::Sequence aVarArg;
css::uno::Reference xCaller;
+ScDocument& mrDoc;
boolbValidCount;
// result:
FormulaErrornErrCode;
@@ -201,7 +203,7 @@ private:
public:
// exact name
-ScUnoAddInCall( ScUnoAddInCollection& rColl, const
OUString& rName,
+ScUnoAddInCall( ScDocument& rDoc, ScUnoAddInCollection&
rColl, const OUString& rName,
tools::Long nParamCount );
~ScUnoAddInCall();
diff --git a/sc/source/core/tool/addincol.cxx b/sc/source/core/tool/addincol.cxx
index 126a0f915c7a..b0cadc33c89b 100644
--- a/sc/source/core/tool/addincol.cxx
+++ b/sc/source/core/tool/addincol.cxx
@@ -58,6 +58,7 @@
#include
#include
#include
+#include
#include
using namespace com::sun::star;
@@ -1228,8 +1229,9 @@ bool ScUnoAddInCollection::FillFunctionDescFromData(
const ScUnoAddInFuncData& r
return true;
}
-ScUnoAddInCall::ScUnoAddInCall( ScUnoAddInCollection& rColl, const OUString&
rName,
+ScUnoAddInCall::ScUnoAddInCall( ScDocument& rDoc, ScUnoAddInCollection& rColl,
const OUString& rName,
tools::Long nParamCount ) :
+mrDoc( rDoc ),
bValidCount( false ),
nErrCode( FormulaError::NoCode ), // before function was called
bHasString( true ),
@@ -1582,13 +1584,13 @@ void ScUnoAddInCall::SetResult( const uno::Any& rNewRes
)
for (sal_Int32 nCol=0; nColPutString(
-svl::SharedString(pColArr[nCol]),
+
mrDoc.GetSharedStringPool().intern(pColArr[nCol]),
static_cast(nCol),
static_cast(nRow));
}
for (sal_Int32 nCol=nColCount; nColPutString(
-svl::SharedString(OUString()),
+svl::SharedString::getEmptyString(),
static_cast(nCol),
static_cast(nRow));
}
}
diff --git a/sc/source/core/tool/interpr4.cxx b/sc/source/core/tool/interpr4.cxx
index 1a0eed81302f..f0dee4b21b63 100644
--- a/sc/source/core/tool/interpr4.cxx
+++ b/sc/source/core/tool/interpr4.cxx
@@ -2710,7 +2710,7 @@ void ScInterpreter::ScExternal()
// bLocalFirst=false in FindFunction, cFunc should be the stored
// internal name
-ScUnoAddInCall aCall( *ScGlobal::GetAddInCollection(), aUnoName,
nParamCount );
+ScUnoAddInCall aCall( mrDoc, *ScGlobal::GetAddInCollection(),
aUnoName, nParamCount );
if ( !aCall.ValidParamCount() )
SetError( FormulaError::IllegalParameter );
[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - sc/inc sc/source
sc/inc/addincol.hxx |4 +++- sc/source/core/tool/addincol.cxx |8 +--- sc/source/core/tool/interpr4.cxx |2 +- 3 files changed, 9 insertions(+), 5 deletions(-) New commits: commit 2919441c102122455b7b9967885a0a8a342eff56 Author: Eike Rathke AuthorDate: Wed Sep 14 00:19:04 2022 +0200 Commit: Mike Kaganski CommitDate: Thu Sep 15 07:04:31 2022 +0200 Resolves: tdf#150926 Add-In result svl::SharedString needs to be interned Change-Id: If582e7e1bf818dcf9eaddd5313aa21f5768a578f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139886 Reviewed-by: Eike Rathke Tested-by: Jenkins (cherry picked from commit 4a702b978384bf733363a64cd9ec64014675d515) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139841 Reviewed-by: Mike Kaganski diff --git a/sc/inc/addincol.hxx b/sc/inc/addincol.hxx index bb89f8d3c87a..a319b31b0132 100644 --- a/sc/inc/addincol.hxx +++ b/sc/inc/addincol.hxx @@ -43,6 +43,7 @@ class SfxObjectShell; class ScUnoAddInFuncData; class ScFuncDesc; class LanguageTag; +class ScDocument; typedef std::unordered_map< OUString, const ScUnoAddInFuncData* > ScAddInHashMap; @@ -197,6 +198,7 @@ private: css::uno::Sequence aArgs; css::uno::Sequence aVarArg; css::uno::Reference xCaller; +ScDocument& mrDoc; boolbValidCount; // result: FormulaErrornErrCode; @@ -210,7 +212,7 @@ private: public: // exact name -ScUnoAddInCall( ScUnoAddInCollection& rColl, const OUString& rName, +ScUnoAddInCall( ScDocument& rDoc, ScUnoAddInCollection& rColl, const OUString& rName, tools::Long nParamCount ); ~ScUnoAddInCall(); diff --git a/sc/source/core/tool/addincol.cxx b/sc/source/core/tool/addincol.cxx index 9027f0456ff4..3100a09833e6 100644 --- a/sc/source/core/tool/addincol.cxx +++ b/sc/source/core/tool/addincol.cxx @@ -60,6 +60,7 @@ #include #include #include +#include #include using namespace com::sun::star; @@ -1282,8 +1283,9 @@ bool ScUnoAddInCollection::FillFunctionDescFromData( const ScUnoAddInFuncData& r return true; } -ScUnoAddInCall::ScUnoAddInCall( ScUnoAddInCollection& rColl, const OUString& rName, +ScUnoAddInCall::ScUnoAddInCall( ScDocument& rDoc, ScUnoAddInCollection& rColl, const OUString& rName, tools::Long nParamCount ) : +mrDoc( rDoc ), bValidCount( false ), nErrCode( FormulaError::NoCode ), // before function was called bHasString( true ), @@ -1636,13 +1638,13 @@ void ScUnoAddInCall::SetResult( const uno::Any& rNewRes ) for (sal_Int32 nCol=0; nColPutString( -svl::SharedString(pColArr[nCol]), + mrDoc.GetSharedStringPool().intern(pColArr[nCol]), static_cast(nCol), static_cast(nRow)); } for (sal_Int32 nCol=nColCount; nColPutString( -svl::SharedString(OUString()), +svl::SharedString::getEmptyString(), static_cast(nCol), static_cast(nRow)); } } diff --git a/sc/source/core/tool/interpr4.cxx b/sc/source/core/tool/interpr4.cxx index c123374c745d..0895c75b5cc9 100644 --- a/sc/source/core/tool/interpr4.cxx +++ b/sc/source/core/tool/interpr4.cxx @@ -2734,7 +2734,7 @@ void ScInterpreter::ScExternal() // bLocalFirst=false in FindFunction, cFunc should be the stored // internal name -ScUnoAddInCall aCall( *ScGlobal::GetAddInCollection(), aUnoName, nParamCount ); +ScUnoAddInCall aCall( mrDoc, *ScGlobal::GetAddInCollection(), aUnoName, nParamCount ); if ( !aCall.ValidParamCount() ) SetError( FormulaError::IllegalParameter );
[Libreoffice-bugs] [Bug 150966] FILESAVE Editing this MSO file in LO Writer causes the header and footer contents to be corrupted
https://bugs.documentfoundation.org/show_bug.cgi?id=150966 --- Comment #2 from tom1willi...@yandex.com --- Created attachment 182458 --> https://bugs.documentfoundation.org/attachment.cgi?id=182458=edit before and after .DOCX files showing the problem -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150966] FILESAVE Editing this MSO file in LO Writer causes the header and footer contents to be corrupted
https://bugs.documentfoundation.org/show_bug.cgi?id=150966 --- Comment #1 from tom1willi...@yandex.com --- Created attachment 182457 --> https://bugs.documentfoundation.org/attachment.cgi?id=182457=edit before and after .DOCX files demonstrating the problem -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150966] New: FILESAVE Editing this MSO file in LO Writer causes the header and footer contents to be corrupted
https://bugs.documentfoundation.org/show_bug.cgi?id=150966 Bug ID: 150966 Summary: FILESAVE Editing this MSO file in LO Writer causes the header and footer contents to be corrupted Product: LibreOffice Version: 7.3.5.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tom1willi...@yandex.com Description: Editing this MSO file in LO Writer causes the header and footer contents to be corrupted having zero height. Before and after example files are attached. Steps to Reproduce: 1.I open the file labeled BEFORE 2.I deleted one character of text in the main body, not the header or footer, then type that same character again. 3.I save the file as a docx file 4.After reopening the text in the header and footer has zero height and appears to be "gone" to my MSO using colleagues who then get upset. Actual Results: After reopening the text in the header and footer has zero height and appears to be "gone" to my MSO using colleagues who then get upset. Expected Results: After reopening the text in the header and footer should look as they do in the file labeled BEFORE opening in LO Writer. Reproducible: Always User Profile Reset: No Additional Info: This problem has only started happening in the last couple of weeks. So something has changed recently. The colleagues use MSO365 and can be assumed to be up to date. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148511] Dragging top handle of the table border to increase the size of table refuses
https://bugs.documentfoundation.org/show_bug.cgi?id=148511 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150734] Filter to exclude empty cells on Pivot Table still shows empty cells when deselected
https://bugs.documentfoundation.org/show_bug.cgi?id=150734 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147882] Asking for the "original size" of a PDF inserted image delivers weird results
https://bugs.documentfoundation.org/show_bug.cgi?id=147882 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147882] Asking for the "original size" of a PDF inserted image delivers weird results
https://bugs.documentfoundation.org/show_bug.cgi?id=147882 --- Comment #4 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147120] Repairs document to old version and no clue about new document.
https://bugs.documentfoundation.org/show_bug.cgi?id=147120 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147120] Repairs document to old version and no clue about new document.
https://bugs.documentfoundation.org/show_bug.cgi?id=147120 --- Comment #3 from QA Administrators --- Dear rackaitis, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 135932] Open File option in front screen does nothing
https://bugs.documentfoundation.org/show_bug.cgi?id=135932 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 135932] Open File option in front screen does nothing
https://bugs.documentfoundation.org/show_bug.cgi?id=135932 --- Comment #6 from QA Administrators --- Dear Dan Essin, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148064] Crash in: libgobject-2.0.so.0.5000.3
https://bugs.documentfoundation.org/show_bug.cgi?id=148064 --- Comment #3 from QA Administrators --- Dear iusa...@gmail.com, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 49641] Fileopen DOC: Tables lost in a frame (per Comment 6)
https://bugs.documentfoundation.org/show_bug.cgi?id=49641 --- Comment #9 from QA Administrators --- Dear Andries van Tonder, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 119803] FILEOPEN Table in frame in DOC not displayed in Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=119803 --- Comment #5 from QA Administrators --- Dear Aron Budea, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 113404] ODF: wrong element after reducing symbol size in chart
https://bugs.documentfoundation.org/show_bug.cgi?id=113404 --- Comment #5 from QA Administrators --- Dear Regina Henschel, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 112246] Global changes of text attributes not work correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=112246 --- Comment #10 from QA Administrators --- Dear Zbynek Burget, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150910] [EDITING] Protected status only is pasted if the source cells belong to one row.
https://bugs.documentfoundation.org/show_bug.cgi?id=150910 --- Comment #10 from n gibson --- (In reply to Timur from comment #8) > n gibson, thanks for commenting. > Please do not change the status set by a member of QA team, and that was > wrong change, see > https://bugs.documentfoundation.org/page.cgi?id=fields.html#bug_status. > > *** This bug has been marked as a duplicate of bug 123974 *** Apologies for wrong protocol. I'm quite unfamiliar with the process. > Note that you didn't write exact expected results, with regard to already > defined bug 123974. > Please do. Not sure where to add expected results, other than right here, so in case this helps: IN regards to bug 123974, the expected behavior is the same as the current behavior of Calc as described -- in other words, the behavior is not a bug. It requires no correction. IN regards to *this* bug 150910, the expected behavior is that when any cell or cell range is copied, then its protected status is fully retained when it is pasted into another valid cell or cell range regardless of the protection status of the sheet as a whole. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 150910] [EDITING] Protected status only is pasted if the source cells belong to one row.
https://bugs.documentfoundation.org/show_bug.cgi?id=150910 --- Comment #10 from n gibson --- (In reply to Timur from comment #8) > n gibson, thanks for commenting. > Please do not change the status set by a member of QA team, and that was > wrong change, see > https://bugs.documentfoundation.org/page.cgi?id=fields.html#bug_status. > > *** This bug has been marked as a duplicate of bug 123974 *** Apologies for wrong protocol. I'm quite unfamiliar with the process. > Note that you didn't write exact expected results, with regard to already > defined bug 123974. > Please do. Not sure where to add expected results, other than right here, so in case this helps: IN regards to bug 123974, the expected behavior is the same as the current behavior of Calc as described -- in other words, the behavior is not a bug. It requires no correction. IN regards to *this* bug 150910, the expected behavior is that when any cell or cell range is copied, then its protected status is fully retained when it is pasted into another valid cell or cell range regardless of the protection status of the sheet as a whole. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 45884] LibreOffice does not understand "scale" value with style:rel-width and style:rel-height
https://bugs.documentfoundation.org/show_bug.cgi?id=45884 --- Comment #19 from João Vidal --- It's still present on LO 7.2.7 (my Linux distribution uses pacman, I can't install latest 7.4 with rpm or deb). Using style:rel-width="scale" svg:height="1.499cm" the images have a very small width. See attachment 'test_with_scale.odt'. Using something like svg:width="1.438cm" svg:height="1.499cm" the images have the expected size.. See attachment 'test_with_dimensions.odt'. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 45884] LibreOffice does not understand "scale" value with style:rel-width and style:rel-height
https://bugs.documentfoundation.org/show_bug.cgi?id=45884 --- Comment #18 from João Vidal --- Created attachment 182456 --> https://bugs.documentfoundation.org/attachment.cgi?id=182456=edit odt with dimensions, showing no problems on image sizes -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 45884] LibreOffice does not understand "scale" value with style:rel-width and style:rel-height
https://bugs.documentfoundation.org/show_bug.cgi?id=45884 --- Comment #17 from João Vidal --- Created attachment 182455 --> https://bugs.documentfoundation.org/attachment.cgi?id=182455=edit odt with scale, showing the effects of the bug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143557] docx 16-color char highlight lost in round trip through odt format
https://bugs.documentfoundation.org/show_bug.cgi?id=143557 --- Comment #11 from Luke Deller --- (In reply to Justin L from comment #7) > ODF doesn't (and hopefully never will) have a concept of a 16-color > highlight character property. So not much can be done here unless someone > does that evil thing. Which element did you feel was evil: supporting the concept of character highlighting as distinct from background shading, or the fact that Word only offers 16 choices for the highlight colour? I agree the limitation of colour choice is quite evil, probably a relic of the past. The same limitation used to exist elsewhere, eg table border colour was limited to 16 colours until MS Word 2000. However the concept of highlighting might have merit: I have seen it employed by Word users differently than background shading, with semantics matching a physical highlighter pen. Indeed the online Word documentation says: > Word contains many highlighters to make your text pop off the screen just > as if you were highlighting paper with a fluorescent marker ( from https://support.microsoft.com/en-us/office/apply-or-remove-highlighting-1747d808-6db7-4d49-86ac-1f0c3cc87e2e ) What do you think of adding a loext: (extension) attribute to persist the highlighting information that LibreOffice currently holds in memory in this case? I could maybe look at a patch for that if the concept sounds reasonable. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150965] CALC sort by one column changes cell numbers in formulae not involved in the sort range
https://bugs.documentfoundation.org/show_bug.cgi?id=150965 --- Comment #1 from van.sny...@sbcglobal.net --- Created attachment 182454 --> https://bugs.documentfoundation.org/attachment.cgi?id=182454=edit Test case. Sort rows 4-23 on column G to demonstrate the problem described in the report. Examine the formulae in rows 4-23 of columns D and F before and after sorting. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150965] New: CALC sort by one column changes cell numbers in formulae not involved in the sort range
https://bugs.documentfoundation.org/show_bug.cgi?id=150965 Bug ID: 150965 Summary: CALC sort by one column changes cell numbers in formulae not involved in the sort range Product: LibreOffice Version: 7.0.4.2 release Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: van.sny...@sbcglobal.net Description: References to cells that are not included within the range of rows being sorted are changed but should not be. The results of the calculations become incorrect. Steps to Reproduce: 1.In the first column of a spreadsheet, enter identifiers, such as chemical compound names. For example, use ten rows. 2.In the second column, enter a property of the name in the first column, such as amount 3.After all the rows are entered, compute the sum of the second column in a new row, for example row 11. 4.In the third column, compute the percentage that the second column accounts for, for example, compute C1 as =$B1/$B11*100, C2 as $B2/B11*100, etc. 5.Enter a fourth column, such as a melting point. 6. Sort a subset of the rows, definitely not including the total row (B11 in the example), on the fourth column in either ascending or descending order. Actual Results: The references to cells in the denominators of the formulae in the third column are changed, even though the rows specified by those references are outside the range to be sorted. Expected Results: References to cells within the range of rows being sorted should be changed according to the sorting result. References to cells not within the range of rows being sorted should not be changed. Reproducible: Always User Profile Reset: No Additional Info: Version: 7.0.4.2 Environment: CPU threads 4; OS: Linux 5.1.10 User Interface: UI render; default; VCL; kf5 Locale: en-US (en_US.UTF-8); UI: en-US Misc: Debian package version: 1:7.004-4+deb11u1 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150804] The strings "Top of baseline" and "Bottom of baseline" should be changed
https://bugs.documentfoundation.org/show_bug.cgi?id=150804 Regina Henschel changed: What|Removed |Added CC||rb.hensc...@t-online.de --- Comment #5 from Regina Henschel --- When trying to find better wording please keep in mind, that the file format has no wording "From bottom". The setting "From bottom by -10mm to Base line" is written in file markup as style:vertical-pos="from-top" together with svg:y="10mm". It moves the object so, that the top edge of the object is 10mm below the baseline. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 150804] The strings "Top of baseline" and "Bottom of baseline" should be changed
https://bugs.documentfoundation.org/show_bug.cgi?id=150804 Regina Henschel changed: What|Removed |Added CC||rb.hensc...@t-online.de --- Comment #5 from Regina Henschel --- When trying to find better wording please keep in mind, that the file format has no wording "From bottom". The setting "From bottom by -10mm to Base line" is written in file markup as style:vertical-pos="from-top" together with svg:y="10mm". It moves the object so, that the top edge of the object is 10mm below the baseline. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 150964] New: FILEOPEN: HTM file with extension XLS partially imported using default filter by Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=150964 Bug ID: 150964 Summary: FILEOPEN: HTM file with extension XLS partially imported using default filter by Calc Product: LibreOffice Version: 7.4.0.0 beta1+ Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: saywel...@gmail.com Created attachment 182453 --> https://bugs.documentfoundation.org/attachment.cgi?id=182453=edit HTML Excel Workbook An HTML file (labelled internally as ExcelWorksheet) with an xls extension opened in Calc does not import all the table data unless the filter "HTML Document (Calc) (.html, .xhtml, .htm)" is explicitly chosen. Double-clicking the file opens in Calc with only one cell visible. If the extension is renamed .odt it opens in Writer with all data visible. The same file opens correctly in Excel 2010 although with warning about incorrect extensions; apparently later versions of Excel open it without complaint. This problem arises in Ask.LibreOffice https://ask.libreoffice.org/t/xls-file-does-not-open-in-libre-calc-but-opens-in-google-sheets/81770 An average user is unlikely to investigate every filter option, especially not to the 70th filter in the list. The original questioner in Ask.LibreOffice appears to have not found the filter although it is explicitly mentioned in one comment and in one answer. Can the filter selection be made easier? Or made automatic as the name Excel Worksheet is included inside the file? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sc/source
sc/source/filter/xml/xmlexprt.cxx | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
New commits:
commit a7589f621fcbe6305335730d2dd86b9230a18594
Author: Justin Luth
AuthorDate: Sat Sep 10 21:04:48 2022 -0400
Commit: Justin Luth
CommitDate: Thu Sep 15 01:47:29 2022 +0200
tdf#103829 ods export: output when CELLTYPE_EDIT
regression since LO 4.2
Change-Id: Ic9b6c00af9f1cccdb58ac3eede59268d1c83c767
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139761
Tested-by: Jenkins
Reviewed-by: Justin Luth
diff --git a/sc/source/filter/xml/xmlexprt.cxx
b/sc/source/filter/xml/xmlexprt.cxx
index 77a45ab9b284..3f88b3c88acb 100644
--- a/sc/source/filter/xml/xmlexprt.cxx
+++ b/sc/source/filter/xml/xmlexprt.cxx
@@ -3114,7 +3114,19 @@ void flushParagraph(
std::vector aPropStates;
const SvxFieldData* pField = toXMLPropertyStates(rExport, aPropStates,
rSec.maAttributes, xMapper, rAttrMap);
OUString aStyleName = xStylePool->Find(XmlStyleFamily::TEXT_TEXT,
OUString(), aPropStates);
-writeContent(rExport, aStyleName, aContent, pField);
+if (aContent == "\x001" && !pField)
+{
+for (const SfxPoolItem* p : rSec.maAttributes)
+{
+if (p->Which() == EE_FEATURE_TAB)
+{
+SvXMLElementExport Tab(rExport, XML_NAMESPACE_TEXT,
XML_TAB, false, false);
+break;
+}
+}
+}
+else
+writeContent(rExport, aStyleName, aContent, pField);
}
}
[Libreoffice-bugs] [Bug 32950] FORMATTING Cell height and word wrapping can be wrong (when changing) xls-files because 'Optimal height" of rows is not set (automatically?)
https://bugs.documentfoundation.org/show_bug.cgi?id=32950 --- Comment #27 from Justin L --- repro 7.5+ Based on comment 5, I'd guess this is the XLS version bug 62268 and needs something like the controversial patch 693953dd4699887bd3f5bca2c3582b5fae1d6992 that explicitly called Calc to re-calculate rows after ODS load. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 123026] LibreOffice ignore xlsxwriter 'text_wrap' formatting option, seems optimal height for row is not being set to hold cells with wrapped text
https://bugs.documentfoundation.org/show_bug.cgi?id=123026 --- Comment #5 from Justin L --- repro 7.5+ See bug 62268 and the controversial patch 693953dd4699887bd3f5bca2c3582b5fae1d6992 that explicitly called Calc to re-calculate rows after ODS load. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145951] Image anchored as 'as character' moves to different spot on DOCX/DOC/RTF export
https://bugs.documentfoundation.org/show_bug.cgi?id=145951 Regina Henschel changed: What|Removed |Added CC||rb.hensc...@t-online.de --- Comment #5 from Regina Henschel --- (In reply to Justin L from comment #3) > > Please provide proof that MS formats can specify a similar anchor setting. > Assuming DOCX-Limitations. The UI of Word has no setting for the vertical position of the shape in case it is anchored 'inline'. But Word treats such image as character and you can use the character properties of subscript and superscript to set the image to the desired vertical position. So a solution could be to convert vertical position to character subscript/superscript on export and the other way round on import. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sc/qa
sc/qa/extras/vba-macro-test.cxx | 130 +---
1 file changed, 71 insertions(+), 59 deletions(-)
New commits:
commit c7e876f4eacab1ff4d735cc591718510452a0f09
Author: Xisco Fauli
AuthorDate: Wed Sep 14 18:24:04 2022 +0200
Commit: Xisco Fauli
CommitDate: Thu Sep 15 00:34:04 2022 +0200
CppunitTest_sc_vba_macro_test: unify the way tests are setup and teardown
Some tests were using mxComponent and some other
tests where using their own xComponent
Hopefully this will fix the CppunitTest_sc_vba_macro_test
failures on windows
Change-Id: I75fa51edf273582057201f50847b2c1a3ed1fcc9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139948
Tested-by: Xisco Fauli
Reviewed-by: Xisco Fauli
diff --git a/sc/qa/extras/vba-macro-test.cxx b/sc/qa/extras/vba-macro-test.cxx
index 24f8ddb996c6..dd887fe86528 100644
--- a/sc/qa/extras/vba-macro-test.cxx
+++ b/sc/qa/extras/vba-macro-test.cxx
@@ -37,24 +37,11 @@ using namespace ooo::vba;
class VBAMacroTest : public UnoApiTest
{
public:
-uno::Reference mxComponent;
-
VBAMacroTest()
: UnoApiTest("/sc/qa/extras/testdocuments")
{
}
-virtual void tearDown() override
-{
-if (mxComponent.is())
-{
-mxComponent->dispose();
-mxComponent.set(nullptr);
-}
-
-test::BootstrapFixture::tearDown();
-}
-
void testSimpleCopyAndPaste();
void testMultiDocumentCopyAndPaste();
void testSheetAndColumnSelectAndHide();
@@ -110,14 +97,15 @@ void VBAMacroTest::testSimpleCopyAndPaste()
OUString aFileName;
createFileURL(u"SimpleCopyPaste.xlsm", aFileName);
-mxComponent = loadFromDesktop(aFileName,
"com.sun.star.sheet.SpreadsheetDocument");
+uno::Reference xComponent
+= loadFromDesktop(aFileName, "com.sun.star.sheet.SpreadsheetDocument");
uno::Any aRet;
uno::Sequence aOutParamIndex;
uno::Sequence aOutParam;
uno::Sequence aParams;
-SfxObjectShell* pFoundShell =
SfxObjectShell::GetShellFromComponent(mxComponent);
+SfxObjectShell* pFoundShell =
SfxObjectShell::GetShellFromComponent(xComponent);
CPPUNIT_ASSERT_MESSAGE("Failed to access document shell", pFoundShell);
ScDocShell* pDocSh = static_cast(pFoundShell);
@@ -133,7 +121,7 @@ void VBAMacroTest::testSimpleCopyAndPaste()
CPPUNIT_ASSERT_EQUAL(0.0, rDoc.GetValue(ScAddress(1, 5, 0)));
SfxObjectShell::CallXScript(
-mxComponent,
"vnd.sun.Star.script:VBAProject.Module1.test?language=Basic=document",
+xComponent,
"vnd.sun.Star.script:VBAProject.Module1.test?language=Basic=document",
aParams, aRet, aOutParamIndex, aOutParam);
// Copy from C4-C6
@@ -145,6 +133,8 @@ void VBAMacroTest::testSimpleCopyAndPaste()
CPPUNIT_ASSERT_EQUAL(10.0, rDoc.GetValue(ScAddress(1, 3, 0)));
CPPUNIT_ASSERT_EQUAL(20.0, rDoc.GetValue(ScAddress(1, 4, 0)));
CPPUNIT_ASSERT_EQUAL(30.0, rDoc.GetValue(ScAddress(1, 5, 0)));
+
+pDocSh->DoClose();
}
void VBAMacroTest::testMultiDocumentCopyAndPaste()
@@ -165,14 +155,15 @@ void VBAMacroTest::testMultiDocumentCopyAndPaste()
OUString aFileName;
createFileURL(u"MultiDocumentCopyPaste.xlsm", aFileName);
-mxComponent = loadFromDesktop(aFileName,
"com.sun.star.sheet.SpreadsheetDocument");
+uno::Reference xComponent
+= loadFromDesktop(aFileName, "com.sun.star.sheet.SpreadsheetDocument");
uno::Any aRet;
uno::Sequence aOutParamIndex;
uno::Sequence aOutParam;
uno::Sequence aParams;
-SfxObjectShell* pFoundShell =
SfxObjectShell::GetShellFromComponent(mxComponent);
+SfxObjectShell* pFoundShell =
SfxObjectShell::GetShellFromComponent(xComponent);
CPPUNIT_ASSERT_MESSAGE("Failed to access document shell", pFoundShell);
ScDocShell* pDocSh = static_cast(pFoundShell);
@@ -183,21 +174,24 @@ void VBAMacroTest::testMultiDocumentCopyAndPaste()
CPPUNIT_ASSERT_EQUAL(0.0, rDoc.GetValue(ScAddress(1, 3, 0)));
SfxObjectShell::CallXScript(
-mxComponent,
"vnd.sun.Star.script:VBAProject.Module1.test?language=Basic=document",
+xComponent,
"vnd.sun.Star.script:VBAProject.Module1.test?language=Basic=document",
aParams, aRet, aOutParamIndex, aOutParam);
CPPUNIT_ASSERT_EQUAL(200.0, rDoc.GetValue(ScAddress(1, 1, 0)));
CPPUNIT_ASSERT_EQUAL(100.0, rDoc.GetValue(ScAddress(1, 2, 0)));
CPPUNIT_ASSERT_EQUAL(0.0, rDoc.GetValue(ScAddress(1, 3, 0)));
+
+pDocSh->DoClose();
}
void VBAMacroTest::testSheetAndColumnSelectAndHide()
{
OUString aFileName;
createFileURL(u"SheetAndColumnSelectAndHide.xlsm", aFileName);
-mxComponent = loadFromDesktop(aFileName,
"com.sun.star.sheet.SpreadsheetDocument");
+uno::Reference xComponent
+= loadFromDesktop(aFileName, "com.sun.star.sheet.SpreadsheetDocument");
-SfxObjectShell* pFoundShell =
SfxObjectShell::GetShellFromComponent(mxComponent);
+
[Libreoffice-commits] core.git: sc/qa
sc/qa/extras/macros-test.cxx | 42 ++
1 file changed, 14 insertions(+), 28 deletions(-)
New commits:
commit 158344c57e661ffc5f4f44dbe1ef3760a64269ac
Author: Xisco Fauli
AuthorDate: Wed Sep 14 17:51:13 2022 +0200
Commit: Xisco Fauli
CommitDate: Thu Sep 15 00:33:24 2022 +0200
CppunitTest_sc_macros_test: simplify code a bit
Change-Id: Ie0b685dbcbc3504de10372b9c0127781171f8fb8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139946
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
diff --git a/sc/qa/extras/macros-test.cxx b/sc/qa/extras/macros-test.cxx
index 6ad5a6d4aa7a..69e494d31434 100644
--- a/sc/qa/extras/macros-test.cxx
+++ b/sc/qa/extras/macros-test.cxx
@@ -151,12 +151,6 @@ void ScMacrosTest::testMSP()
Sequence< Any > aOutParam;
Sequence< uno::Any > aParams;
-SfxObjectShell* pFoundShell =
SfxObjectShell::GetShellFromComponent(xComponent);
-
-CPPUNIT_ASSERT_MESSAGE("Failed to access document shell", pFoundShell);
-ScDocShell* pDocSh = dynamic_cast(pFoundShell);
-CPPUNIT_ASSERT(pDocSh != nullptr);
-
SfxObjectShell::CallXScript(
xComponent,
"vnd.sun.Star.script:Standard.Module1.TestMSP?language=Basic=document",
@@ -166,7 +160,9 @@ void ScMacrosTest::testMSP()
SAL_INFO("sc.qa", "Result is " << sResult );
CPPUNIT_ASSERT_EQUAL_MESSAGE("TestMSP ( for fdo#67547) failed",
OUString("OK"), sResult);
-pDocSh->DoClose();
+
+css::uno::Reference xCloseable(xComponent,
css::uno::UNO_QUERY_THROW);
+xCloseable->close(true);
}
void ScMacrosTest::testPasswordProtectedStarBasic()
@@ -186,7 +182,6 @@ void ScMacrosTest::testPasswordProtectedStarBasic()
ScDocShell* pDocSh = static_cast(pFoundShell);
ScDocument& rDoc = pDocSh->GetDocument();
-
// User defined types
SfxObjectShell::CallXScript(
@@ -217,7 +212,6 @@ void ScMacrosTest::testPasswordProtectedStarBasic()
aValue = rDoc.GetString(2,0,0);
CPPUNIT_ASSERT_EQUAL_MESSAGE("Far Method script did not change the value
of Sheet1.C1", OUString("success"), aValue);
-
pDocSh->DoClose();
}
@@ -306,8 +300,7 @@ void ScMacrosTest::testTdf146742()
// - Actual : TRUE
CPPUNIT_ASSERT_EQUAL(OUString("FALSE"), rDoc.GetString(ScAddress(1,1,0)));
-css::uno::Reference xCloseable(xComponent,
css::uno::UNO_QUERY_THROW);
-xCloseable->close(true);
+pDocSh->DoClose();
}
void ScMacrosTest::testMacroButtonFormControlXlsxExport()
@@ -375,8 +368,7 @@ void ScMacrosTest::testTdf104902()
// - Actual : string withnewlines
CPPUNIT_ASSERT_EQUAL(OUString(u"string with" + OUStringChar(u'\xA') +
u"newlines"), rDoc.GetString(ScAddress(0, 1, 0)));
-css::uno::Reference xCloseable(xComponent,
css::uno::UNO_QUERY_THROW);
-xCloseable->close(true);
+pDocSh->DoClose();
}
void ScMacrosTest::testTdf64639()
@@ -420,8 +412,7 @@ void ScMacrosTest::testTdf64639()
CPPUNIT_ASSERT_EQUAL(static_cast(0), pPage->GetObjCount());
}
-css::uno::Reference xCloseable(xComponent,
css::uno::UNO_QUERY_THROW);
-xCloseable->close(true);
+pDocSh->DoClose();
}
void ScMacrosTest::testTdf142033()
@@ -460,8 +451,7 @@ void ScMacrosTest::testTdf142033()
CPPUNIT_ASSERT_EQUAL(OUString(u"string with" + OUStringChar(u'\xA') +
u"newlines"), rDoc.GetString(ScAddress(1,0,0)));
CPPUNIT_ASSERT_EQUAL(OUString(u"string with" + OUStringChar(u'\xA') +
u"newlines"), rDoc.GetString(ScAddress(1,1,0)));
-css::uno::Reference xCloseable(xComponent,
css::uno::UNO_QUERY_THROW);
-xCloseable->close(true);
+pDocSh->DoClose();
}
void ScMacrosTest::testPasswordProtectedUnicodeString()
@@ -727,8 +717,7 @@ void ScMacrosTest::testTdf46119()
CPPUNIT_ASSERT_EQUAL(OUString("0.386"), rDoc.GetString(ScAddress(4, 26,
0)));
CPPUNIT_ASSERT_EQUAL(OUString("0.366"), rDoc.GetString(ScAddress(4, 27,
0)));
-css::uno::Reference xCloseable(xComponent,
css::uno::UNO_QUERY_THROW);
-xCloseable->close(true);
+pDocSh->DoClose();
}
void ScMacrosTest::testTdf128218()
@@ -1007,8 +996,7 @@ void ScMacrosTest::testTdf125800()
const ScCondFormatEntry* pCondition = static_cast(pEntry);
CPPUNIT_ASSERT_EQUAL(ScConditionMode::Direct, pCondition->GetOperation());
-css::uno::Reference xCloseable(xComponent,
css::uno::UNO_QUERY_THROW);
-xCloseable->close(true);
+pDocSh->DoClose();
}
void ScMacrosTest::testTdf130307()
@@ -1074,8 +1062,7 @@ void ScMacrosTest::testTdf144970()
CPPUNIT_ASSERT_EQUAL(static_cast(1), pPage->GetObjCount());
-css::uno::Reference xCloseable(xComponent,
css::uno::UNO_QUERY_THROW);
-xCloseable->close(true);
+pDocSh->DoClose();
}
void ScMacrosTest::testTdf138646()
@@ -1235,10 +1222,6 @@ void ScMacrosTest::testShapeLayerId()
Sequence aOutParamIndex;
Sequence aOutParam;
-SfxObjectShell* pFoundShell =
SfxObjectShell::GetShellFromComponent(xComponent);
-
[Libreoffice-commits] core.git: external/zlib
external/zlib/1eb7682f845ac9e9bf9ae35bbfb3bad5dacbd91d.patch | 29 +
external/zlib/UnpackedTarball_zlib.mk|7 ++
external/zlib/eff308af425b67093bab25f80f1ae950166bece1.patch | 32 +++
3 files changed, 67 insertions(+), 1 deletion(-)
New commits:
commit 521e920dda79f44a0ad637b6062f3dcb574f884b
Author: Michael Stahl
AuthorDate: Wed Sep 14 11:10:57 2022 +0200
Commit: Michael Stahl
CommitDate: Thu Sep 15 00:11:48 2022 +0200
zlib: add patch for CVE-2022-37434
Change-Id: If09c419ba00fc9be021249e4d4da27d1650b9080
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139913
Tested-by: Jenkins
Reviewed-by: Michael Stahl
diff --git a/external/zlib/1eb7682f845ac9e9bf9ae35bbfb3bad5dacbd91d.patch
b/external/zlib/1eb7682f845ac9e9bf9ae35bbfb3bad5dacbd91d.patch
new file mode 100644
index ..c5c95a92b28a
--- /dev/null
+++ b/external/zlib/1eb7682f845ac9e9bf9ae35bbfb3bad5dacbd91d.patch
@@ -0,0 +1,29 @@
+From 1eb7682f845ac9e9bf9ae35bbfb3bad5dacbd91d Mon Sep 17 00:00:00 2001
+From: Mark Adler
+Date: Mon, 8 Aug 2022 10:50:09 -0700
+Subject: [PATCH] Fix extra field processing bug that dereferences NULL
+ state->head.
+
+The recent commit to fix a gzip header extra field processing bug
+introduced the new bug fixed here.
+---
+ inflate.c | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/inflate.c b/inflate.c
+index 7a7289749..2a3c4fe98 100644
+--- a/inflate.c
b/inflate.c
+@@ -763,10 +763,10 @@ int flush;
+ copy = state->length;
+ if (copy > have) copy = have;
+ if (copy) {
+-len = state->head->extra_len - state->length;
+ if (state->head != Z_NULL &&
+ state->head->extra != Z_NULL &&
+-len < state->head->extra_max) {
++(len = state->head->extra_len - state->length) <
++state->head->extra_max) {
+ zmemcpy(state->head->extra + len, next,
+ len + copy > state->head->extra_max ?
+ state->head->extra_max - len : copy);
diff --git a/external/zlib/UnpackedTarball_zlib.mk
b/external/zlib/UnpackedTarball_zlib.mk
index dd9fc1c31445..10ee74b9568a 100644
--- a/external/zlib/UnpackedTarball_zlib.mk
+++ b/external/zlib/UnpackedTarball_zlib.mk
@@ -16,6 +16,11 @@ $(eval $(call gb_UnpackedTarball_set_post_action,zlib,\
cp $(addsuffix .c,adler32 compress crc32 deflate inffast inflate
inftrees trees zutil) x64 \
))
-$(eval $(call gb_UnpackedTarball_set_patchlevel,zlib,0))
+$(eval $(call gb_UnpackedTarball_set_patchlevel,zlib,1))
+
+$(eval $(call gb_UnpackedTarball_add_patches,zlib,\
+ external/zlib/eff308af425b67093bab25f80f1ae950166bece1.patch \
+ external/zlib/1eb7682f845ac9e9bf9ae35bbfb3bad5dacbd91d.patch \
+))
# vim: set noet sw=4 ts=4:
diff --git a/external/zlib/eff308af425b67093bab25f80f1ae950166bece1.patch
b/external/zlib/eff308af425b67093bab25f80f1ae950166bece1.patch
new file mode 100644
index ..dc84d3a1d385
--- /dev/null
+++ b/external/zlib/eff308af425b67093bab25f80f1ae950166bece1.patch
@@ -0,0 +1,32 @@
+From eff308af425b67093bab25f80f1ae950166bece1 Mon Sep 17 00:00:00 2001
+From: Mark Adler
+Date: Sat, 30 Jul 2022 15:51:11 -0700
+Subject: [PATCH] Fix a bug when getting a gzip header extra field with
+ inflate().
+
+If the extra field was larger than the space the user provided with
+inflateGetHeader(), and if multiple calls of inflate() delivered
+the extra header data, then there could be a buffer overflow of the
+provided space. This commit assures that provided space is not
+exceeded.
+---
+ inflate.c | 5 +++--
+ 1 file changed, 3 insertions(+), 2 deletions(-)
+
+diff --git a/inflate.c b/inflate.c
+index 7be8c6366..7a7289749 100644
+--- a/inflate.c
b/inflate.c
+@@ -763,9 +763,10 @@ int flush;
+ copy = state->length;
+ if (copy > have) copy = have;
+ if (copy) {
++len = state->head->extra_len - state->length;
+ if (state->head != Z_NULL &&
+-state->head->extra != Z_NULL) {
+-len = state->head->extra_len - state->length;
++state->head->extra != Z_NULL &&
++len < state->head->extra_max) {
+ zmemcpy(state->head->extra + len, next,
+ len + copy > state->head->extra_max ?
+ state->head->extra_max - len : copy);
[Libreoffice-bugs] [Bug 45147] right-to-left words appear in the wrong order in the CSV import dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=45147 Eyal Rozenberg changed: What|Removed |Added CC||eyalr...@gmx.com Severity|major |normal --- Comment #15 from Eyal Rozenberg --- Bug still manifests with: Version: 7.5.0.0.alpha0+ / LibreOffice Community Build ID: 6c81a09e3ef239a2d7a991d00fe3620a67298b99 CPU threads: 4; OS: Linux 5.18; UI render: default; VCL: gtk3 Locale: en-IL (en_IL); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150950] line numbering ON/OFF indication in Tools menu
https://bugs.documentfoundation.org/show_bug.cgi?id=150950 Hossein changed: What|Removed |Added Keywords||needsUXEval --- Comment #1 from Hossein --- Heiko, what do you think? The menu item that is discussed here is: "Tools > Line Numbering...". The difference between this item and the "Automatic Spell Checking" in the "Tools" menu is that this one opens a dialog box. I searched for the menu bar items that end with "...", which shows they are going to open a dialog box, and also check-able. I could not find any. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144583] Blurry icon on HiDPI
https://bugs.documentfoundation.org/show_bug.cgi?id=144583 --- Comment #13 from Hossein --- (In reply to Caolán McNamara from comment #10) > https://gerrit.libreoffice.org/c/core/+/139944 + > https://gerrit.libreoffice.org/c/core/+/139945 > give me good results Thank you for the quick fix, Caolán! It worked fine for me on HiDPI and 2x integer scaling, after you have merged the above two patches: Version: 7.5.0.0.alpha0+ / LibreOffice Community Build ID: d480af79c6d67341e650a5b920bf66c2865309e0 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded Note: I haven't tested the fixes extensively with fractional scaling. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 50044] FILEOPEN partiular .xls shows too small row height
https://bugs.documentfoundation.org/show_bug.cgi?id=50044 --- Comment #5 from Justin L --- If I first round-trip the file with MS Word 2003, it opens fine in LO. It is calling XclImpColRowSettings::SetRowSettings twice - first for rows 1-627 and then again for rows 1-116. I don't know how to stop that because ImportExcel8::Read() is really generic. I'd guess you would have to understand xls internals pretty good to figure out where to identify and stop a duplicate. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 90796] [META] HiDPI / Retina bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=90796 Hossein changed: What|Removed |Added Depends on||150960 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=150960 [Bug 150960] Use platform look and feel (plaf) and scaling for Java windows -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150960] Use platform look and feel (plaf) and scaling for Java windows
https://bugs.documentfoundation.org/show_bug.cgi?id=150960 Hossein changed: What|Removed |Added Blocks||90796 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=90796 [Bug 90796] [META] HiDPI / Retina bugs -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150403] Inconsistency in dynamically applying font substitutions
https://bugs.documentfoundation.org/show_bug.cgi?id=150403 Eyal Rozenberg changed: What|Removed |Added Summary|Font substitutions |Inconsistency in |dynamically-apply |dynamically applying font |inconsistently |substitutions -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 90796] [META] HiDPI / Retina bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=90796 Hossein changed: What|Removed |Added Depends on||144583 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=144583 [Bug 144583] Blurry icon on HiDPI -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144583] Blurry icon on HiDPI
https://bugs.documentfoundation.org/show_bug.cgi?id=144583 Hossein changed: What|Removed |Added Blocks||90796 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=90796 [Bug 90796] [META] HiDPI / Retina bugs -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143547] LO Writer: navigator should stand still on promoting and demoting
https://bugs.documentfoundation.org/show_bug.cgi?id=143547 Jim Raykowski changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |rayk...@gmail.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/source
sw/source/uibase/utlui/content.cxx |7 +++ 1 file changed, 7 insertions(+) New commits: commit a33b8ec923b4e86a2ca2075f9541e79a729b2ed7 Author: Jim Raykowski AuthorDate: Mon Sep 12 15:27:11 2022 -0800 Commit: Jim Raykowski CommitDate: Wed Sep 14 23:21:26 2022 +0200 tdf#143547 SwNavigator: restore content tree scroll position after promote, demote, and move chapter Change-Id: Ie165fadf6154a019ad79a0fed489f63aa768c8f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139823 Tested-by: Jenkins Reviewed-by: Jim Raykowski diff --git a/sw/source/uibase/utlui/content.cxx b/sw/source/uibase/utlui/content.cxx index 68691799573f..55e51b52d51b 100644 --- a/sw/source/uibase/utlui/content.cxx +++ b/sw/source/uibase/utlui/content.cxx @@ -3419,9 +3419,16 @@ void SwContentTree::ExecCommand(std::string_view rCmd, bool bOutlineWithChildren if (m_aActiveContentArr[ContentTypeId::OUTLINE]) m_aActiveContentArr[ContentTypeId::OUTLINE]->Invalidate(); +// tdf#143547 LO Writer: navigator should stand still on promoting and demoting +// In addition to m_bIgnoreDocChange being true, selections are cleared before the Display +// call. Either of these conditions disable restore of scroll position happening in the +// Display function so it needs to be done here. +auto nOldScrollPos = m_xTreeView->vadjustment_get_value(); + // clear all selections to prevent the Display function from trying to reselect selected entries m_xTreeView->unselect_all(); Display(true); +m_xTreeView->vadjustment_set_value(nOldScrollPos); // reselect entries const SwOutlineNodes::size_type nCurrPos = pShell->GetOutlinePos(MAXLEVEL);
[Libreoffice-bugs] [Bug 150963] "Freeze Rows and Columns" should be accessible not just through the view menu
https://bugs.documentfoundation.org/show_bug.cgi?id=150963 m.a.riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #1 from m.a.riosv --- Have you tried customizing the right-click?, Menu/Tools/Customize - Context Menu -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150804] The strings "Top of baseline" and "Bottom of baseline" should be changed
https://bugs.documentfoundation.org/show_bug.cgi?id=150804 --- Comment #4 from Telesto --- (In reply to Tuomas Hietala from comment #2) > Well, 99% of users probably wouldn't notice if these options were removed > altogether. But since they exist, I thought the texts could be improved a > bit. Slightly off-topic I want to mention a compatibility issue. Apply: Bottom of baseline and export the file to DOCX and File-> Reload. Apparently the feature is unsupported by Word. Bug 145951 comment 3. Another argument to drop those settings, IMHO. However those are used on multiple dialogs, and actually used.. Insert in image. Anchor it to character, drag it somewhere else.. Bottom of baseline will be set. See again bug 145951 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 150804] The strings "Top of baseline" and "Bottom of baseline" should be changed
https://bugs.documentfoundation.org/show_bug.cgi?id=150804 --- Comment #4 from Telesto --- (In reply to Tuomas Hietala from comment #2) > Well, 99% of users probably wouldn't notice if these options were removed > altogether. But since they exist, I thought the texts could be improved a > bit. Slightly off-topic I want to mention a compatibility issue. Apply: Bottom of baseline and export the file to DOCX and File-> Reload. Apparently the feature is unsupported by Word. Bug 145951 comment 3. Another argument to drop those settings, IMHO. However those are used on multiple dialogs, and actually used.. Insert in image. Anchor it to character, drag it somewhere else.. Bottom of baseline will be set. See again bug 145951 -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 150963] New: "Freeze Rows and Columns" should be accessible not just through the view menu
https://bugs.documentfoundation.org/show_bug.cgi?id=150963 Bug ID: 150963 Summary: "Freeze Rows and Columns" should be accessible not just through the view menu Product: LibreOffice Version: 7.5.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: eyalr...@gmx.com One can split the view in Calc by dragging the top of the scroll bar - without using the menus. I believe it should then be possible somehow - e.g. by a right-click context menu or some other way - to freeze the resulting split, without going through the view menu. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 133942] Crash ucrtbase!abort+0x4b: after Reject All tracked changes
https://bugs.documentfoundation.org/show_bug.cgi?id=133942 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||7507 --- Comment #8 from Telesto --- (In reply to Julien Nabet from comment #6) > Created attachment 182450 [details] > bt with debug symbols BT is the same as for bug 147507. This bug apparently didn't crash at step 6 in the past; so might be different, might be the same thing.. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147507] Crash swlo!SwRedlineExtraData_FormatColl::Reject+0x1b6 (comment 7)
https://bugs.documentfoundation.org/show_bug.cgi?id=147507 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||3942 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: configure.ac
configure.ac |7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
New commits:
commit d480af79c6d67341e650a5b920bf66c2865309e0
Author: Rene Engelhard
AuthorDate: Wed Sep 14 18:29:39 2022 +0200
Commit: René Engelhard
CommitDate: Wed Sep 14 22:50:46 2022 +0200
fix system-abseil build
after c97c60f70e9e6de594f7e0e0b85f17944c640dcf
"external: update pdfium to 5298"
Change-Id: I4a0a37ebf6cbc070d2fc5e17c89fd307a53de7fb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139949
Tested-by: René Engelhard
Tested-by: Jenkins
Reviewed-by: René Engelhard
diff --git a/configure.ac b/configure.ac
index 12cc87525782..340e87d75b55 100644
--- a/configure.ac
+++ b/configure.ac
@@ -12044,8 +12044,13 @@ if test "$ENABLE_PDFIUM" = "TRUE"; then
AC_LANG_PUSH([C++])
AC_CHECK_HEADER(absl/types/bad_optional_access.h, [],
[AC_MSG_ERROR(abseil headers not found.)], [])
-AC_CHECK_LIB([absl_bad_optional_access], [main],
[ABSEIL_LIBS=-labsl_bad_optional_access],
+AC_CHECK_HEADER(absl/types/bad_variant_access.h, [],
+[AC_MSG_ERROR(abseil headers not found.)], [])
+AC_CHECK_LIB([absl_bad_optional_access], [main], [],
[AC_MSG_ERROR([libabsl_bad_optional_access library not
found.])])
+AC_CHECK_LIB([absl_bad_variant_access], [main], [],
+ [AC_MSG_ERROR([libabsl_bad_variant_access library not
found.])])
+ ABSEIL_LIBS="-labsl_bad_optional_access -labsl_bad_variant_access"
AC_LANG_POP([C++])
ABSEIL_CFLAGS=$(printf '%s' "$ABSEIL_CFLAGS" | sed -e
"s/-I/${ISYSTEM?}/g")
FilterLibs "${ABSEIL_LIBS}"
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 0233b69dd1265d41321040c567f9d6da14fcdf71 Author: Olivier Hallot AuthorDate: Wed Sep 14 17:44:11 2022 -0300 Commit: Gerrit Code Review CommitDate: Wed Sep 14 22:44:11 2022 +0200 Update git submodules * Update helpcontent2 from branch 'master' to dfa442b3d862539a7b10af5281a080acaef7e73d - tdf#150909 workaround for bad renderring of help page Change-Id: I6d33eb8fd9787cc36837cb4c10c93695d834ed26 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/139770 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index 130638cf417a..dfa442b3d862 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 130638cf417ad37c42c7da8c47f552ba791fe3a7 +Subproject commit dfa442b3d862539a7b10af5281a080acaef7e73d
[Libreoffice-bugs] [Bug 150909] Regression: HTML entities badly rendered
https://bugs.documentfoundation.org/show_bug.cgi?id=150909 --- Comment #1 from Commit Notification --- Olivier Hallot committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/help/commit/dfa442b3d862539a7b10af5281a080acaef7e73d tdf#150909 workaround for bad renderring of help page -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] help.git: source/text
source/text/shared/00/0002.xhp |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit dfa442b3d862539a7b10af5281a080acaef7e73d Author: Olivier Hallot AuthorDate: Sun Sep 11 09:23:47 2022 -0300 Commit: Olivier Hallot CommitDate: Wed Sep 14 22:44:10 2022 +0200 tdf#150909 workaround for bad renderring of help page Change-Id: I6d33eb8fd9787cc36837cb4c10c93695d834ed26 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/139770 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/source/text/shared/00/0002.xhp b/source/text/shared/00/0002.xhp index 0cfbc9b60..b54a974f9 100644 --- a/source/text/shared/00/0002.xhp +++ b/source/text/shared/00/0002.xhp @@ -190,7 +190,7 @@ Tags -HTML pages contain certain structural and formatting instructions called tags. Tags are code words enclosed by brackets in the document description language HTML. Many tags contain text or hyperlink references between the opening and closing brackets. For example, titles are marked by the tags h1 at the beginning and /h1 at the end of the title. Some tags only appear on their own such as br for a line break or img ... to link a graphic. +HTML pages contain certain structural and formatting instructions called tags. Tags are code words enclosed by brackets in the document description language HTML. Many tags contain text or hyperlink references between the opening and closing brackets. For example, titles are marked by the tags h1 at the beginning and /h1 at the end of the title. Some tags only appear on their own such as br for a line break or img ... to link a graphic.
[Libreoffice-bugs] [Bug 150909] Regression: HTML entities badly rendered
https://bugs.documentfoundation.org/show_bug.cgi?id=150909 Commit Notification changed: What|Removed |Added Whiteboard||target:7.5.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144583] Blurry icon on HiDPI
https://bugs.documentfoundation.org/show_bug.cgi?id=144583 --- Comment #12 from Commit Notification --- Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/ce4e3d6f39cb4db138ff2445b27d7af7ad01ff33 Resolves: tdf#144583 reuse lok hidpi icon scheme for gtk It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: vcl/headless vcl/inc
vcl/headless/svpgdi.cxx |9 +
vcl/inc/headless/svpgdi.hxx |2 ++
2 files changed, 11 insertions(+)
New commits:
commit ce4e3d6f39cb4db138ff2445b27d7af7ad01ff33
Author: Caolán McNamara
AuthorDate: Wed Sep 14 16:44:03 2022 +0100
Commit: Caolán McNamara
CommitDate: Wed Sep 14 22:19:18 2022 +0200
Resolves: tdf#144583 reuse lok hidpi icon scheme for gtk
Change-Id: I91dc9f7123b878e49a1ad57e5f40b6741ab04487
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139945
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/vcl/headless/svpgdi.cxx b/vcl/headless/svpgdi.cxx
index c97048dada12..322dab644f2a 100644
--- a/vcl/headless/svpgdi.cxx
+++ b/vcl/headless/svpgdi.cxx
@@ -51,6 +51,15 @@ void SvpSalGraphics::GetResolution( sal_Int32& rDPIX,
sal_Int32& rDPIY )
rDPIX = rDPIY = 96;
}
+bool SvpSalGraphics::ShouldDownscaleIconsAtSurface(double* pScaleOut) const
+{
+if (comphelper::LibreOfficeKit::isActive())
+return SalGraphics::ShouldDownscaleIconsAtSurface(pScaleOut);
+if (pScaleOut)
+*pScaleOut = m_aCairoCommon.m_fScale;
+return true;
+}
+
#if ENABLE_CAIRO_CANVAS
bool SvpSalGraphics::SupportsCairo() const
{
diff --git a/vcl/inc/headless/svpgdi.hxx b/vcl/inc/headless/svpgdi.hxx
index 04e6bfa3eddf..7158a020eb6b 100644
--- a/vcl/inc/headless/svpgdi.hxx
+++ b/vcl/inc/headless/svpgdi.hxx
@@ -83,6 +83,8 @@ public:
GetTextLayout(int nFallbackLevel) override;
virtual voidDrawTextLayout( const GenericSalLayout& ) override;
+virtual boolShouldDownscaleIconsAtSurface(double* pScaleOut)
const override;
+
virtual SystemGraphicsData GetGraphicsData() const override;
#if ENABLE_CAIRO_CANVAS
[Libreoffice-commits] core.git: sc/inc sc/qa sc/source
sc/inc/stringutil.hxx |2 +-
sc/qa/unit/ucalc.cxx|4 ++--
sc/source/core/data/column3.cxx | 22 +-
sc/source/ui/view/tabvwsha.cxx | 17 +
4 files changed, 17 insertions(+), 28 deletions(-)
New commits:
commit 939724fe6abd16015dbef6c476f7f57a2dc466d8
Author: Eike Rathke
AuthorDate: Wed Sep 14 15:01:47 2022 +0200
Commit: Eike Rathke
CommitDate: Wed Sep 14 21:44:32 2022 +0200
Related: tdf#149665 Unify input of a leading ' apostrophe in non-Text cell
If a cell is not formatted as Text and
ScSetStringParam::mbHandleApostrophe is true, all input (except
one single apostrophe that otherwise would lead to an empty cell
string) now is treated the same and the leading apostrophe is
removed and the remainder is set as text content. The Input Line
and editing a cell get an apostrophe prepended for the cases
needed to generate such escaped string again.
This made it necessary to adapt a unit test that exactly checked
the old behaviour.
Change-Id: I07b35d33f3704970784dc6de1322bda28903bb97
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139934
Reviewed-by: Eike Rathke
Tested-by: Jenkins
diff --git a/sc/inc/stringutil.hxx b/sc/inc/stringutil.hxx
index 150a3ede269e..b2b58f60fc5a 100644
--- a/sc/inc/stringutil.hxx
+++ b/sc/inc/stringutil.hxx
@@ -84,7 +84,7 @@ struct SAL_WARN_UNUSED SC_DLLPUBLIC ScSetStringParam
/**
* When true, treat input with a leading apostrophe as an escape character
- * for a numeric value content, to treat the numeric value as a text. When
+ * for all content, to treat also numeric value as a text. When
* false, the whole string input including the leading apostrophe will be
* entered literally as string.
*/
diff --git a/sc/qa/unit/ucalc.cxx b/sc/qa/unit/ucalc.cxx
index 87ab1c55155e..a63519f41224 100644
--- a/sc/qa/unit/ucalc.cxx
+++ b/sc/qa/unit/ucalc.cxx
@@ -626,8 +626,8 @@ void Test::testInput()
CPPUNIT_ASSERT_MESSAGE("String number should have the first apostrophe
stripped.", bTest);
m_pDoc->SetString(0, 0, 0, "'apple'");
test = m_pDoc->GetString(0, 0, 0);
-bTest = test == "'apple'";
-CPPUNIT_ASSERT_MESSAGE("Text content should have retained the first
apostrophe.", bTest);
+bTest = test == "apple'";
+CPPUNIT_ASSERT_MESSAGE("Text content should have the first apostrophe
stripped.", bTest);
// Customized string handling policy.
ScSetStringParam aParam;
diff --git a/sc/source/core/data/column3.cxx b/sc/source/core/data/column3.cxx
index e144a0334036..d92318134098 100644
--- a/sc/source/core/data/column3.cxx
+++ b/sc/source/core/data/column3.cxx
@@ -2125,32 +2125,20 @@ bool ScColumn::ParseString(
}
else if ( cFirstChar == '\'') // 'Text
{
-bool bNumeric = false;
if (aParam.mbHandleApostrophe)
{
// Cell format is not 'Text', and the first char is an apostrophe.
-// Check if the input is considered a number with all leading
-// apostrophes removed. All because ''1 should produce '1 not ''1,
-// thus '''1 be ''1 and so on.
+// Strip it and set text content.
// NOTE: this corresponds with sc/source/ui/view/tabvwsha.cxx
// ScTabViewShell::UpdateInputHandler() prepending an apostrophe if
// necessary.
-sal_Int32 i = 1;
-while (i < rString.getLength() && rString[i] == '\'')
-++i;
-if (i < rString.getLength())
-{
-OUString aTest = rString.copy(i);
-double fTest;
-bNumeric = aParam.mpNumFormatter->IsNumberFormat(aTest,
nIndex, fTest);
-if (bNumeric)
-// This is a number. Strip out the first apostrophe.
-rCell.set(rPool.intern(rString.copy(1)));
-}
+rCell.set(rPool.intern(rString.copy(1)));
}
-if (!bNumeric)
+else
+{
// This is normal text. Take it as-is.
rCell.set(rPool.intern(rString));
+}
}
else
{
diff --git a/sc/source/ui/view/tabvwsha.cxx b/sc/source/ui/view/tabvwsha.cxx
index dc389eb70723..9e86e5319de9 100644
--- a/sc/source/ui/view/tabvwsha.cxx
+++ b/sc/source/ui/view/tabvwsha.cxx
@@ -722,19 +722,20 @@ void ScTabViewShell::UpdateInputHandler( bool bForce /* =
sal_False */, bool bSt
aString = ScCellFormat::GetInputString( rCell, nNumFmt,
*pFormatter, rDoc );
if (rCell.getType() == CELLTYPE_STRING)
{
-sal_Int32 i = 0;
-while (i < aString.getLength() && aString[i] == '\'')
-++i;
-OUString aTest((i && i < aString.getLength()) ?
aString.copy(i) : aString);
// Put a ' in front if necessary, so that the
[Libreoffice-bugs] [Bug 50044] FILEOPEN partiular .xls shows too small row height
https://bugs.documentfoundation.org/show_bug.cgi?id=50044 --- Comment #4 from Justin L --- (In reply to Justin L from comment #2) > A1: not sure why this row was so small. Bad testing. It actually seems fine in master. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Changes to 'refs/tags/co-21.06.33-1'
Tag 'co-21.06.33-1' created by Andras Timar at 2022-09-14 19:43 + co-21.06.33-1 Changes since cp-21.06.32-1-39: --- 0 files changed ---
[Libreoffice-commits] translations.git: Changes to 'refs/tags/co-21.06.33-1'
Tag 'co-21.06.33-1' created by Andras Timar at 2022-09-14 19:43 + co-21.06.33-1 Changes since cp-21.06.13-1-1: --- 0 files changed ---
[Libreoffice-commits] help.git: Changes to 'refs/tags/co-21.06.33-1'
Tag 'co-21.06.33-1' created by Andras Timar at 2022-09-14 19:43 + co-21.06.33-1 Changes since co-2021-branch-point-10: --- 0 files changed ---
[Libreoffice-commits] dictionaries.git: Changes to 'refs/tags/co-21.06.33-1'
Tag 'co-21.06.33-1' created by Andras Timar at 2022-09-14 19:43 + co-21.06.33-1 Changes since libreoffice-7-1-branch-point-5: --- 0 files changed ---
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - configure.ac
configure.ac |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 368d234f50debe5d4cafc139764c383c92276f72 Author: Andras Timar AuthorDate: Wed Sep 14 21:42:17 2022 +0200 Commit: Andras Timar CommitDate: Wed Sep 14 21:42:17 2022 +0200 Bump version to 21.06.33.1 Change-Id: I6e05aadb9b0afc02414275d1a532250befda03b2 diff --git a/configure.ac b/configure.ac index 627f1dcdfffe..0a690fb6dd0f 100644 --- a/configure.ac +++ b/configure.ac @@ -9,7 +9,7 @@ dnl in order to create a configure script. # several non-alphanumeric characters, those are split off and used only for the # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no idea. -AC_INIT([Collabora Office],[21.06.32.1],[],[],[https://collaboraoffice.com/]) +AC_INIT([Collabora Office],[21.06.33.1],[],[],[https://collaboraoffice.com/]) dnl libnumbertext needs autoconf 2.68, but that can pick up autoconf268 just fine if it is installed dnl whereas aclocal (as run by autogen.sh) insists on using autoconf and fails hard
[Libreoffice-bugs] [Bug 150804] The strings "Top of baseline" and "Bottom of baseline" should be changed
https://bugs.documentfoundation.org/show_bug.cgi?id=150804 --- Comment #3 from Eyal Rozenberg --- With that drop-down we actually select two different parameters: What entity to align with, and how the entities are aligned. So, it may make sense to split this into two selections. This should make it easier to have options in the drop down lists which are both exact and easy to understand. As I've said in the design meeting today - the way things stand now, I would want the list items to be clearer and easier to understand at the expense of brevity. So, w.r.t. the baseline, I would hope to see: "Align top with baseline", "Align center with baseline", "Align bottom with baseline". With other entities, it might be something like "Align bottoms with line", "Align centers with line" etc. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 150804] The strings "Top of baseline" and "Bottom of baseline" should be changed
https://bugs.documentfoundation.org/show_bug.cgi?id=150804 --- Comment #3 from Eyal Rozenberg --- With that drop-down we actually select two different parameters: What entity to align with, and how the entities are aligned. So, it may make sense to split this into two selections. This should make it easier to have options in the drop down lists which are both exact and easy to understand. As I've said in the design meeting today - the way things stand now, I would want the list items to be clearer and easier to understand at the expense of brevity. So, w.r.t. the baseline, I would hope to see: "Align top with baseline", "Align center with baseline", "Align bottom with baseline". With other entities, it might be something like "Align bottoms with line", "Align centers with line" etc. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-commits] core.git: download.lst external/libxml2 sc/source test/source unoxml/source
download.lst|6 +++--- external/libxml2/ExternalPackage_libxml2.mk |2 +- external/libxml2/libxml2-android.patch |6 +++--- sc/source/core/tool/interpr7.cxx|2 ++ test/source/xmltesttools.cxx|2 ++ unoxml/source/xpath/xpathobject.cxx |2 ++ 6 files changed, 13 insertions(+), 7 deletions(-) New commits: commit d621a8839cebf96fe3ac374026f344f8e68bf011 Author: Michael Stahl AuthorDate: Wed Sep 14 10:27:02 2022 +0200 Commit: Michael Stahl CommitDate: Wed Sep 14 21:35:59 2022 +0200 libxml2: upgrade to release 2.10.2 Fixes CVE-2022-2309 Change-Id: I180218be275d3b6d38f8f74aa51c57e50d2734ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139911 Tested-by: Jenkins Reviewed-by: Michael Stahl diff --git a/download.lst b/download.lst index 1bb6fb4b80bd..d87d1608c62b 100644 --- a/download.lst +++ b/download.lst @@ -162,9 +162,9 @@ export LIBWEBP_SHA256SUM := 7656532f837af5f4cec3ff6bafe552c044dc39bf453587bd5b77 export LIBWEBP_TARBALL := libwebp-1.2.2.tar.gz export XMLSEC_SHA256SUM := 52ced4943f35bd7d0818a38298c1528ca4ac8a54440fd71134a07d2d1370a262 export XMLSEC_TARBALL := xmlsec1-1.2.34.tar.gz -export LIBXML_SHA256SUM := 60d74a257d1ccec0475e749cba2f21559e48139efba6ff28224357c7c798dfee -export LIBXML_VERSION_MICRO := 14 -export LIBXML_TARBALL := libxml2-2.9.$(LIBXML_VERSION_MICRO).tar.xz +export LIBXML_SHA256SUM := d240abe6da9c65cb1900dd9bf3a3501ccf88b3c2a1cb98317d03f272dda5b265 +export LIBXML_VERSION_MICRO := 2 +export LIBXML_TARBALL := libxml2-2.10.$(LIBXML_VERSION_MICRO).tar.xz export LIBXSLT_SHA256SUM := 8247f33e9a872c6ac859aa45018bc4c4d00b97e2feac9eebc10c93ce1f34dd79 export LIBXSLT_VERSION_MICRO := 35 export LIBXSLT_TARBALL := libxslt-1.1.$(LIBXSLT_VERSION_MICRO).tar.xz diff --git a/external/libxml2/ExternalPackage_libxml2.mk b/external/libxml2/ExternalPackage_libxml2.mk index d38eb68df0cb..6338fb20b9df 100644 --- a/external/libxml2/ExternalPackage_libxml2.mk +++ b/external/libxml2/ExternalPackage_libxml2.mk @@ -21,7 +21,7 @@ else # COM=MSC $(eval $(call gb_ExternalPackage_add_file,libxml2,$(LIBO_URE_LIB_FOLDER)/libxml2.dll,win32/bin.msvc/libxml2.dll)) endif else # OS!=WNT -$(eval $(call gb_ExternalPackage_add_file,libxml2,$(LIBO_URE_LIB_FOLDER)/libxml2.so.2,.libs/libxml2.so.2.9.$(LIBXML_VERSION_MICRO))) +$(eval $(call gb_ExternalPackage_add_file,libxml2,$(LIBO_URE_LIB_FOLDER)/libxml2.so.2,.libs/libxml2.so.2.10.$(LIBXML_VERSION_MICRO))) endif endif # DISABLE_DYNLOADING diff --git a/external/libxml2/libxml2-android.patch b/external/libxml2/libxml2-android.patch index 42af83274026..acf9b17e02db 100644 --- a/external/libxml2/libxml2-android.patch +++ b/external/libxml2/libxml2-android.patch @@ -2,9 +2,9 @@ +++ misc/build/libxml2-2.7.6/Makefile.in @@ -1635,7 +1635,7 @@ $(MAKE) $(AM_MAKEFLAGS) $(check_PROGRAMS) - check: $(BUILT_SOURCES) - $(MAKE) $(AM_MAKEFLAGS) check-recursive --all-am: Makefile $(PROGRAMS) $(LTLIBRARIES) $(SCRIPTS) $(MANS) $(DATA) \ + $(MAKE) $(AM_MAKEFLAGS) check-local + check: check-recursive +-all-am: Makefile $(PROGRAMS) $(LTLIBRARIES) $(SCRIPTS) $(DATA) \ +all-am: Makefile $(LTLIBRARIES) \ config.h install-binPROGRAMS: install-libLTLIBRARIES diff --git a/sc/source/core/tool/interpr7.cxx b/sc/source/core/tool/interpr7.cxx index 315afed32284..352c7cf70e45 100644 --- a/sc/source/core/tool/interpr7.cxx +++ b/sc/source/core/tool/interpr7.cxx @@ -219,6 +219,7 @@ void ScInterpreter::ScFilterXML() case XPATH_STRING: PushString(OUString::createFromAscii(reinterpret_cast(pXPathObj->stringval))); break; +#if LIBXML_VERSION < 21000 || defined(LIBXML_XPTR_LOCS_ENABLED) case XPATH_POINT: PushNoValue(); break; @@ -228,6 +229,7 @@ void ScInterpreter::ScFilterXML() case XPATH_LOCATIONSET: PushNoValue(); break; +#endif case XPATH_USERS: PushNoValue(); break; diff --git a/test/source/xmltesttools.cxx b/test/source/xmltesttools.cxx index ab9e5dcff8b8..07dc1f1f59f2 100644 --- a/test/source/xmltesttools.cxx +++ b/test/source/xmltesttools.cxx @@ -148,9 +148,11 @@ OUString XmlTestTools::getXPathContent(const xmlDocUniquePtr& pXmlDoc, const OSt xmlXPathFreeObject(pXmlObj); return convertedVal; } +#if LIBXML_VERSION < 21000 || defined(LIBXML_XPTR_LOCS_ENABLED) case XPATH_POINT: case XPATH_RANGE: case XPATH_LOCATIONSET: +#endif case XPATH_USERS: case XPATH_XSLT_TREE: xmlXPathFreeObject(pXmlObj); diff --git a/unoxml/source/xpath/xpathobject.cxx b/unoxml/source/xpath/xpathobject.cxx index 037a097ae046..c33e6a330f86 100644 --- a/unoxml/source/xpath/xpathobject.cxx +++ b/unoxml/source/xpath/xpathobject.cxx @@ -46,12 +46,14 @@ namespace XPath return
Minutes from the UX/design meeting 2022-Sep-14
Present: Eyal, (Shegs,) Rizal, Heiko Comments: Stuart, Tomaz, Tuomas, Mike, Eyal Tickets/Topics * Rename the "Search Commands" menu item + https://bugs.documentfoundation.org/show_bug.cgi?id=150812 + duplicate bug 148073 resolved NAB + "Search for commands" is catchy (Mike) + "Find Command" (Eyal) => go with "Search for Commands..." * The strings "Top of baseline" and "Bottom of baseline" should be changed + https://bugs.documentfoundation.org/show_bug.cgi?id=150804 + "Above baseline" and "Below baseline" shorter and more accurate than "Top of baseline" and "Bottom of baseline" (Tuomas) + "Align top/bottom with baseline" (Eyal) + not much improvement as it just adds "Align" and changes of to with; and it fits not well to other options (Heiko) + so suggest to change just "of" to "with" (Eyal) + maybe split the field into two top/center/bottom and baseline/character/line (Eyal) => comment and let the doer decide * Search Commands should also search commands _not_ on the menus + https://bugs.documentfoundation.org/show_bug.cgi?id=150814 + unclear in case of commands with input and configuration requirements (Stuart) + contextual disabled commands are not added to the list (Tomaz) + results should be separated from those that are in the main menu a) change the appearance like italic font, or gray color b) use some textual indicator like brackets c) label like "Not in menu: <...>" d) positional indicator, ie. use a horizontal ruler and list the non-menu commands below + prefer a) or b) and dislike d) as it might be distracting (Eyal) + prefer d), dislike a) as it is a different indicator and c) is too long (Heiko) => command and go ahead * Support flags in Search Commands: whole-word, case-sensitive, regexp + https://bugs.documentfoundation.org/show_bug.cgi?id=150811 + if ICU regex libs can be used (Stuart) + against this (Tomaz) + weak use case in comment 6, academic and far-fetched (Heiko) + admittedly, and in the end it's not that much we search for (Eyal) => resolve WF * Insert->Image inconsistent behavior when graphic objects are selected + https://bugs.documentfoundation.org/show_bug.cgi?id=150889 + inserting an image onto a selected shapes puts the bitmap into the background, but this works not anymore for Draw/Impress to avoid replacement + inserting something should consistently delete selected objects (Eyal) + disagree with the deletion (Heiko) but in fact when some text is selected and you insert a chart the text is deleted - and inconsistencies are worse than inconveniences + possible solutions a) change Draw/Impress to behave like Writer (insert Image as background) b) change Writer and Calc and never apply as background c) make all insertions behaving the same and _replace_ selections + MSO Word and Powerpoint deselect the shape and insert the image => go with a) for now for sake of easy implementation (sounds as the easiest to implement) but on the long run do c) OpenPGP_signature Description: OpenPGP digital signature
[Libreoffice-qa] Minutes from the UX/design meeting 2022-Sep-14
Present: Eyal, (Shegs,) Rizal, Heiko Comments: Stuart, Tomaz, Tuomas, Mike, Eyal Tickets/Topics * Rename the "Search Commands" menu item + https://bugs.documentfoundation.org/show_bug.cgi?id=150812 + duplicate bug 148073 resolved NAB + "Search for commands" is catchy (Mike) + "Find Command" (Eyal) => go with "Search for Commands..." * The strings "Top of baseline" and "Bottom of baseline" should be changed + https://bugs.documentfoundation.org/show_bug.cgi?id=150804 + "Above baseline" and "Below baseline" shorter and more accurate than "Top of baseline" and "Bottom of baseline" (Tuomas) + "Align top/bottom with baseline" (Eyal) + not much improvement as it just adds "Align" and changes of to with; and it fits not well to other options (Heiko) + so suggest to change just "of" to "with" (Eyal) + maybe split the field into two top/center/bottom and baseline/character/line (Eyal) => comment and let the doer decide * Search Commands should also search commands _not_ on the menus + https://bugs.documentfoundation.org/show_bug.cgi?id=150814 + unclear in case of commands with input and configuration requirements (Stuart) + contextual disabled commands are not added to the list (Tomaz) + results should be separated from those that are in the main menu a) change the appearance like italic font, or gray color b) use some textual indicator like brackets c) label like "Not in menu: <...>" d) positional indicator, ie. use a horizontal ruler and list the non-menu commands below + prefer a) or b) and dislike d) as it might be distracting (Eyal) + prefer d), dislike a) as it is a different indicator and c) is too long (Heiko) => command and go ahead * Support flags in Search Commands: whole-word, case-sensitive, regexp + https://bugs.documentfoundation.org/show_bug.cgi?id=150811 + if ICU regex libs can be used (Stuart) + against this (Tomaz) + weak use case in comment 6, academic and far-fetched (Heiko) + admittedly, and in the end it's not that much we search for (Eyal) => resolve WF * Insert->Image inconsistent behavior when graphic objects are selected + https://bugs.documentfoundation.org/show_bug.cgi?id=150889 + inserting an image onto a selected shapes puts the bitmap into the background, but this works not anymore for Draw/Impress to avoid replacement + inserting something should consistently delete selected objects (Eyal) + disagree with the deletion (Heiko) but in fact when some text is selected and you insert a chart the text is deleted - and inconsistencies are worse than inconveniences + possible solutions a) change Draw/Impress to behave like Writer (insert Image as background) b) change Writer and Calc and never apply as background c) make all insertions behaving the same and _replace_ selections + MSO Word and Powerpoint deselect the shape and insert the image => go with a) for now for sake of easy implementation (sounds as the easiest to implement) but on the long run do c) OpenPGP_signature Description: OpenPGP digital signature
[Libreoffice-bugs] [Bug 133942] Crash ucrtbase!abort+0x4b: after Reject All tracked changes
https://bugs.documentfoundation.org/show_bug.cgi?id=133942 Julien Nabet changed: What|Removed |Added CC||nem...@numbertext.org --- Comment #7 from Julien Nabet --- László: thought you might be interested in this one since it's related to tracked changes -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 133942] Crash ucrtbase!abort+0x4b: after Reject All tracked changes
https://bugs.documentfoundation.org/show_bug.cgi?id=133942 Julien Nabet changed: What|Removed |Added Keywords||haveBacktrace -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 133942] Crash ucrtbase!abort+0x4b: after Reject All tracked changes
https://bugs.documentfoundation.org/show_bug.cgi?id=133942 Julien Nabet changed: What|Removed |Added CC||serval2...@yahoo.fr --- Comment #6 from Julien Nabet --- Created attachment 182450 --> https://bugs.documentfoundation.org/attachment.cgi?id=182450=edit bt with debug symbols On pc Debian x86-64 with master sources updated today (3592c2e1af98b3fad00c43a4e886c29f3a4bb934) + gen rendering, I got a crash at the step "Reject all". I attached bt with some info from gdb. Also, there are still a lot of: warn:legacy.osl:274315:274315:sw/source/core/doc/DocumentRedlineManager.cxx:94: redline table corrupted: empty redline So either it's a real pb and it should be fixed or it's a false positive and we should remove this log. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 115449] Add Tooltips to the Horizontal Ruler in Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=115449 --- Comment #10 from Stephen Leibowitz --- Collabora has partially departed from the LO monochrome ruler by coloring the indents blue. Adopting this for LO would not require changing the location, size, or shape of ruler elements. This limited use of color on the LO ruler need not delay an implementation of ruler tooltips. And it would not close the door to a more extensive use of color on the ruler in the future. I think that the specific color is not very important if coloring is limited to the indents. But giving users a choice of color would be desirable if coloring is extended to other ruler elements. In the latter case, an option might be added for the ruler here: Tools > Options > LibreOffice > Application Colors It has been 4½ years since I reported this issue, which initially was limited to ruler tooltips. Is there anything that can be done to advance it? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 125205] Spreadsheet cell Horizontal alignment (Left) indent is not saved/preserved round trip to OOXML
https://bugs.documentfoundation.org/show_bug.cgi?id=125205 --- Comment #7 from stde...@gmail.com --- I know you'll hate my response - but add a converting function maybe? Libre opens X file, converts it (if needed) to a "standard" format in-memory, and, if needed, writing it in Excel units on save? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108392] [META] Master slide bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108392 Bug 108392 depends on bug 135060, which changed state. Bug 135060 Summary: Clicking a template in Master Slide Sidebar changes color https://bugs.documentfoundation.org/show_bug.cgi?id=135060 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144583] Blurry icon on HiDPI
https://bugs.documentfoundation.org/show_bug.cgi?id=144583 --- Comment #11 from Commit Notification --- Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/cc2a6787446f1ae6492a41c405f45a9cc8cc7d4e Related: tdf#144583 move current lok hidpi icon thing into SalGraphics It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144583] Blurry icon on HiDPI
https://bugs.documentfoundation.org/show_bug.cgi?id=144583 Commit Notification changed: What|Removed |Added Whiteboard||target:7.5.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: vcl/inc vcl/source
vcl/inc/image.h |6 --
vcl/inc/salgdi.hxx |8
vcl/source/gdi/salgdilayout.cxx |7 +++
vcl/source/image/Image.cxx |2 +-
vcl/source/image/ImplImage.cxx | 18 ++
5 files changed, 30 insertions(+), 11 deletions(-)
New commits:
commit cc2a6787446f1ae6492a41c405f45a9cc8cc7d4e
Author: Caolán McNamara
AuthorDate: Wed Sep 14 16:05:38 2022 +0100
Commit: Caolán McNamara
CommitDate: Wed Sep 14 20:34:23 2022 +0200
Related: tdf#144583 move current lok hidpi icon thing into SalGraphics
Change-Id: If34a2b15aebc5316783d72564ede23e02db04302
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139944
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/vcl/inc/image.h b/vcl/inc/image.h
index c049e27072e7..5d0cc9fcb671 100644
--- a/vcl/inc/image.h
+++ b/vcl/inc/image.h
@@ -22,6 +22,8 @@
#include
+class SalGraphics;
+
class ImplImage
{
private:
@@ -36,7 +38,7 @@ private:
BitmapEx maBitmapEx;
BitmapEx maDisabledBitmapEx;
-bool loadStockAtScale(double fScale, BitmapEx );
+bool loadStockAtScale(SalGraphics* pGraphics, BitmapEx );
public:
ImplImage(const BitmapEx& rBitmapEx);
@@ -57,7 +59,7 @@ public:
/// Legacy - the original bitmap
BitmapEx const & getBitmapEx(bool bDisabled = false);
/// Taking account of HiDPI scaling
-BitmapEx const & getBitmapExForHiDPI(bool bDisabled = false);
+BitmapEx const & getBitmapExForHiDPI(bool bDisabled, SalGraphics*
pGraphics);
bool isEqual(const ImplImage ) const;
bool isSizeEmpty() const
diff --git a/vcl/inc/salgdi.hxx b/vcl/inc/salgdi.hxx
index a0f8a22df7b3..acbfd1fa73e5 100644
--- a/vcl/inc/salgdi.hxx
+++ b/vcl/inc/salgdi.hxx
@@ -409,6 +409,14 @@ public:
virtual SystemGraphicsData GetGraphicsData() const = 0;
+// Backends like the svp/gtk ones use cairo and hidpi scale at the surface
+// but bitmaps aren't hidpi, so if this returns true for the case that the
+// surface is hidpi then pScaleOut contains the scaling factor. So we can
+// create larger hires bitmaps which we know will be logically scaled down
+// by this factor but physically just copied
+virtual bool ShouldDownscaleIconsAtSurface(double* pScaleOut) const;
+
+
#if ENABLE_CAIRO_CANVAS
/// Check whether cairo will work
diff --git a/vcl/source/gdi/salgdilayout.cxx b/vcl/source/gdi/salgdilayout.cxx
index 07757614b087..91419779d871 100644
--- a/vcl/source/gdi/salgdilayout.cxx
+++ b/vcl/source/gdi/salgdilayout.cxx
@@ -926,4 +926,11 @@ OUString SalGraphics::getRenderBackendName() const
return OUString();
}
+bool SalGraphics::ShouldDownscaleIconsAtSurface(double* pScaleOut) const
+{
+if (pScaleOut)
+*pScaleOut = comphelper::LibreOfficeKit::getDPIScale();
+return comphelper::LibreOfficeKit::isActive();
+}
+
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/source/image/Image.cxx b/vcl/source/image/Image.cxx
index e32f7e54df22..2b0a9521c8c1 100644
--- a/vcl/source/image/Image.cxx
+++ b/vcl/source/image/Image.cxx
@@ -120,7 +120,7 @@ void Image::Draw(OutputDevice* pOutDev, const Point& rPos,
DrawImageFlags nStyle
Size aOutSize = pSize ? *pSize :
pOutDev->PixelToLogic(mpImplData->getSizePixel());
-BitmapEx aRenderBmp = mpImplData->getBitmapExForHiDPI(bool(nStyle &
DrawImageFlags::Disable));
+BitmapEx aRenderBmp = mpImplData->getBitmapExForHiDPI(bool(nStyle &
DrawImageFlags::Disable), pOutDev->GetGraphics());
if (!(nStyle & DrawImageFlags::Disable) &&
(nStyle & (DrawImageFlags::ColorTransform | DrawImageFlags::Highlight |
diff --git a/vcl/source/image/ImplImage.cxx b/vcl/source/image/ImplImage.cxx
index 65ce3ca0c441..7883c3b1e6f6 100644
--- a/vcl/source/image/ImplImage.cxx
+++ b/vcl/source/image/ImplImage.cxx
@@ -28,6 +28,7 @@
#include
#include
+#include
ImplImage::ImplImage(const BitmapEx )
: maBitmapChecksum(0)
@@ -42,14 +43,15 @@ ImplImage::ImplImage(OUString aStockName)
{
}
-bool ImplImage::loadStockAtScale(double fScale, BitmapEx )
+bool ImplImage::loadStockAtScale(SalGraphics* pGraphics, BitmapEx )
{
BitmapEx aBitmapEx;
ImageLoadFlags eScalingFlags = ImageLoadFlags::NONE;
sal_Int32 nScalePercentage = -1;
-if (comphelper::LibreOfficeKit::isActive()) // scale at the surface
+double fScale(1.0);
+if (pGraphics && pGraphics->ShouldDownscaleIconsAtSurface()) //
scale at the surface
{
nScalePercentage = fScale * 100.0;
eScalingFlags = ImageLoadFlags::IgnoreScalingFactor;
@@ -94,7 +96,7 @@ Size ImplImage::getSizePixel()
aRet = maSizePixel;
else if (isStock())
{
-if (loadStockAtScale(1.0, maBitmapEx))
+if (loadStockAtScale(nullptr, maBitmapEx))
{
assert(maDisabledBitmapEx.IsEmpty());
assert(maBitmapChecksum == 0);
@@ -138,16 +140,16 @@ bool ImplImage::isEqual(const ImplImage )
[Libreoffice-commits] core.git: sc/qa
sc/qa/uitest/calc_tests8/navigator.py |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
New commits:
commit 434f6a1b5a5089ff276918f9756501c91e146759
Author: Caolán McNamara
AuthorDate: Wed Sep 14 14:01:20 2022 +0100
Commit: Caolán McNamara
CommitDate: Wed Sep 14 20:34:01 2022 +0200
try wait_until_property_is_updated in test_tdf134390
==
FAIL: test_tdf134390 (navigator.navigator)
--
Traceback (most recent call last):
File
"/home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/sc/qa/uitest/calc_tests8/navigator.py",
line 143, in test_tdf134390
self.assertEqual(get_state_as_dict(xColumn)['Value'], '2')
AssertionError: '1' != '2'
- 1
+ 2
Change-Id: I7c781191facd10abbb25f895cb0d2bacb72d92ab
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139933
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/sc/qa/uitest/calc_tests8/navigator.py
b/sc/qa/uitest/calc_tests8/navigator.py
index 226e54749a02..574d73c72b41 100644
--- a/sc/qa/uitest/calc_tests8/navigator.py
+++ b/sc/qa/uitest/calc_tests8/navigator.py
@@ -140,7 +140,9 @@ class navigator(UITestCase):
# Use return to update the current cell
xColumn.executeAction("TYPE",
mkPropertyValues({"KEYCODE":"RETURN"}))
+self.ui_test.wait_until_property_is_updated(xColumn, "Value", "2")
self.assertEqual(get_state_as_dict(xColumn)['Value'], '2')
+self.ui_test.wait_until_property_is_updated(xRow, "Value", "2")
self.assertEqual(get_state_as_dict(xRow)['Value'], '2')
self.assertEqual(get_state_as_dict(xGridWin)["CurrentRow"], "1")
@@ -169,4 +171,4 @@ class navigator(UITestCase):
self.xUITest.executeCommand(".uno:Sidebar")
-# vim: set shiftwidth=4 softtabstop=4 expandtab:
\ No newline at end of file
+# vim: set shiftwidth=4 softtabstop=4 expandtab:
[Libreoffice-commits] core.git: sd/inc sd/source
sd/inc/sdfilter.hxx|4 +++-
sd/source/filter/ppt/pptin.cxx |2 +-
sd/source/filter/sdfilter.cxx |5 -
sd/source/filter/sdpptwrp.cxx | 14 +-
sd/source/ui/app/sddll.cxx |1 -
5 files changed, 5 insertions(+), 21 deletions(-)
New commits:
commit 572c2ee4c4f4b8e53f2fa4398a5600f1468f3a38
Author: Noel Grandin
AuthorDate: Wed Sep 14 12:56:39 2022 +0200
Commit: Noel Grandin
CommitDate: Wed Sep 14 20:31:29 2022 +0200
no need to load ImportPPT symbol at runtime
Change-Id: I4b50822183d9752d6a413b0308e1d661785fb10e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139937
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sd/inc/sdfilter.hxx b/sd/inc/sdfilter.hxx
index 707679642dee..928a1c0575d4 100644
--- a/sd/inc/sdfilter.hxx
+++ b/sd/inc/sdfilter.hxx
@@ -45,7 +45,6 @@ public:
virtual boolExport() = 0;
#ifndef DISABLE_DYNLOADING
-static void Preload();
/// Open library @rLibraryName and lookup symbol @rFnSymbol
static oslGenericFunction GetLibrarySymbol( const OUString& rLibraryName,
const OUString );
#endif
@@ -73,5 +72,8 @@ SD_DLLPUBLIC bool ExportPPT( const std::vector<
css::beans::PropertyValue >& rMe
SvMemoryStream* pVBA,
sal_uInt32 nCnvrtFlags );
+// exported function
+SD_DLLPUBLIC bool ImportPPT(
+SdDrawDocument* pDocument, SvStream& rDocStream, SotStorage& rStorage,
SfxMedium& rMedium );
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sd/source/filter/ppt/pptin.cxx b/sd/source/filter/ppt/pptin.cxx
index 7fd3a903dcd4..c2673ef4ce44 100644
--- a/sd/source/filter/ppt/pptin.cxx
+++ b/sd/source/filter/ppt/pptin.cxx
@@ -2766,7 +2766,7 @@ ImplSdPPTImport::ReadFormControl(
tools::SvRef& rSrc1, css::uno::Ref
}
// exported function
-extern "C" SAL_DLLPUBLIC_EXPORT sal_Bool ImportPPT(
+SAL_DLLPUBLIC_EXPORT bool ImportPPT(
SdDrawDocument* pDocument, SvStream& rDocStream, SotStorage& rStorage,
SfxMedium& rMedium )
{
std::unique_ptr pImport( new SdPPTImport( pDocument,
rDocStream, rStorage, rMedium ));
diff --git a/sd/source/filter/sdfilter.cxx b/sd/source/filter/sdfilter.cxx
index 24aa42a7ec9d..af001e611883 100644
--- a/sd/source/filter/sdfilter.cxx
+++ b/sd/source/filter/sdfilter.cxx
@@ -86,11 +86,6 @@ oslGenericFunction SdFilter::GetLibrarySymbol( const
OUString& rLibraryName, con
return pMod->getFunctionSymbol(rFnSymbol);
}
-void SdFilter::Preload()
-{
-(void)GetLibrarySymbol("sd", "ImportPPT");
-}
-
#endif
void SdFilter::CreateStatusIndicator()
diff --git a/sd/source/filter/sdpptwrp.cxx b/sd/source/filter/sdpptwrp.cxx
index 6dd1964b2b73..0f9e2f4a38fc 100644
--- a/sd/source/filter/sdpptwrp.cxx
+++ b/sd/source/filter/sdpptwrp.cxx
@@ -40,14 +40,10 @@ using namespace ::com::sun::star::beans;
using namespace ::com::sun::star::task;
using namespace ::com::sun::star::frame;
-typedef sal_Bool ( *ImportPPTPointer )( SdDrawDocument*, SvStream&,
SotStorage&, SfxMedium& );
-
typedef sal_Bool ( *SaveVBAPointer )( SfxObjectShell&, SvMemoryStream*& );
#ifdef DISABLE_DYNLOADING
-extern "C" sal_Bool ImportPPT( SdDrawDocument*, SvStream&, SotStorage&,
SfxMedium& );
-
extern "C" sal_Bool SaveVBA( SfxObjectShell&, SvMemoryStream*& );
#endif
@@ -186,15 +182,7 @@ bool SdPPTFilter::Import()
mrMedium.SetError(ERRCODE_SVX_READ_FILTER_PPOINT);
else
{
-#ifdef DISABLE_DYNLOADING
-ImportPPTPointer pPPTImport = ImportPPT;
-#else
-ImportPPTPointer pPPTImport = reinterpret_cast<
ImportPPTPointer >(
-
SdFilter::GetLibrarySymbol(mrMedium.GetFilter()->GetUserData(), "ImportPPT"));
-#endif
-
-if ( pPPTImport )
-bRet = pPPTImport( , *pDocStream, *pStorage,
mrMedium );
+bRet = ImportPPT( , *pDocStream, *pStorage,
mrMedium );
if ( !bRet )
mrMedium.SetError(SVSTREAM_WRONGVERSION);
diff --git a/sd/source/ui/app/sddll.cxx b/sd/source/ui/app/sddll.cxx
index 4e20d0997fb8..c195869b790e 100644
--- a/sd/source/ui/app/sddll.cxx
+++ b/sd/source/ui/app/sddll.cxx
@@ -260,7 +260,6 @@ void SdDLL::Init()
extern "C" SAL_DLLPUBLIC_EXPORT
void lok_preload_hook()
{
-SdFilter::Preload();
SdAbstractDialogFactory::Create();
}
[Libreoffice-commits] core.git: bin/find-can-be-private-symbols.py sd/inc sd/source
bin/find-can-be-private-symbols.py |1
sd/inc/sdfilter.hxx| 23 ++-
sd/source/filter/eppt/eppt.cxx |3
sd/source/filter/sdpptwrp.cxx | 216 -
4 files changed, 117 insertions(+), 126 deletions(-)
New commits:
commit 412ec9ec100fb377791b9bced8bc61ce75870e10
Author: Noel Grandin
AuthorDate: Wed Sep 14 12:52:35 2022 +0200
Commit: Noel Grandin
CommitDate: Wed Sep 14 20:31:04 2022 +0200
no need to load ExportPPT symbol at runtime
Change-Id: I01e06fe89f95141a177298e400ccd0f54c2a05db
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139936
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/bin/find-can-be-private-symbols.py
b/bin/find-can-be-private-symbols.py
index 2ac7619d9026..b45dd181caf7 100755
--- a/bin/find-can-be-private-symbols.py
+++ b/bin/find-can-be-private-symbols.py
@@ -183,7 +183,6 @@ with
open("bin/find-can-be-private-symbols.functions.results", "wt") as f:
elif sym == "CreateDialogFactory": continue
elif sym == "CreateUnoWrapper": continue
elif sym == "ExportDOC": continue
-elif sym == "ExportPPT": continue
elif sym == "ExportRTF": continue
elif sym == "GetSaveWarningOfMSVBAStorage_ww8": continue
elif sym == "GetSpecialCharsForEdit": continue
diff --git a/sd/inc/sdfilter.hxx b/sd/inc/sdfilter.hxx
index 8d7782e4fc92..707679642dee 100644
--- a/sd/inc/sdfilter.hxx
+++ b/sd/inc/sdfilter.hxx
@@ -21,16 +21,19 @@
#include
#include
+#include
+#include
#include
#include
+#include "sddllapi.h"
+#include
-// SdFilter
-class SfxMedium;
-namespace sd {
-class DrawDocShell;
-}
-class SdDrawDocument;
namespace osl { class Module; }
+namespace sd { class DrawDocShell; }
+class SdDrawDocument;
+class SfxMedium;
+class SotStorage;
+class SvMemoryStream;
class SdFilter
{
@@ -63,4 +66,12 @@ private:
};
+SD_DLLPUBLIC bool ExportPPT( const std::vector< css::beans::PropertyValue >&
rMediaData,
+tools::SvRef const & rSvStorage,
+css::uno::Reference< css::frame::XModel > const & rXModel,
+css::uno::Reference< css::task::XStatusIndicator > const &
rXStatInd,
+SvMemoryStream* pVBA,
+sal_uInt32 nCnvrtFlags );
+
+
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sd/source/filter/eppt/eppt.cxx b/sd/source/filter/eppt/eppt.cxx
index d243496946a2..34f85553e8bf 100644
--- a/sd/source/filter/eppt/eppt.cxx
+++ b/sd/source/filter/eppt/eppt.cxx
@@ -50,6 +50,7 @@
#include
#include
#include
+#include
#include
#include
@@ -1417,7 +1418,7 @@ void PPTWriter::ImplWriteAtomEnding()
// - exported function -
-extern "C" SAL_DLLPUBLIC_EXPORT sal_Bool ExportPPT( const std::vector<
css::beans::PropertyValue >& rMediaData,
+SAL_DLLPUBLIC_EXPORT bool ExportPPT( const std::vector<
css::beans::PropertyValue >& rMediaData,
tools::SvRef const & rSvStorage,
css::uno::Reference< css::frame::XModel > const & rXModel,
css::uno::Reference< css::task::XStatusIndicator > const &
rXStatInd,
diff --git a/sd/source/filter/sdpptwrp.cxx b/sd/source/filter/sdpptwrp.cxx
index 59829f854ef8..6dd1964b2b73 100644
--- a/sd/source/filter/sdpptwrp.cxx
+++ b/sd/source/filter/sdpptwrp.cxx
@@ -40,22 +40,12 @@ using namespace ::com::sun::star::beans;
using namespace ::com::sun::star::task;
using namespace ::com::sun::star::frame;
-typedef sal_Bool ( *ExportPPTPointer )( const std::vector<
css::beans::PropertyValue >&, tools::SvRef const&,
- Reference< XModel > const &,
- Reference< XStatusIndicator >
const &,
- SvMemoryStream*, sal_uInt32
nCnvrtFlags );
-
typedef sal_Bool ( *ImportPPTPointer )( SdDrawDocument*, SvStream&,
SotStorage&, SfxMedium& );
typedef sal_Bool ( *SaveVBAPointer )( SfxObjectShell&, SvMemoryStream*& );
#ifdef DISABLE_DYNLOADING
-extern "C" sal_Bool ExportPPT( const std::vector< css::beans::PropertyValue
>&, tools::SvRef const&,
- Reference< XModel > const &,
- Reference< XStatusIndicator > const &,
- SvMemoryStream*, sal_uInt32 nCnvrtFlags );
-
extern "C" sal_Bool ImportPPT( SdDrawDocument*, SvStream&, SotStorage&,
SfxMedium& );
extern "C" sal_Bool SaveVBA( SfxObjectShell&, SvMemoryStream*& );
@@ -221,136 +211,126 @@ bool SdPPTFilter::Export()
if( mxModel.is() )
{
-#ifdef DISABLE_DYNLOADING
-ExportPPTPointer PPTExport = ExportPPT;
-#else
-ExportPPTPointer PPTExport = reinterpret_cast< ExportPPTPointer >(
-SdFilter::GetLibrarySymbol(mrMedium.GetFilter()->GetUserData(),
"ExportPPT"));
-#endif
-
-if( PPTExport)
+sal_uInt32 nCnvrtFlags = 0;
+
[Libreoffice-commits] core.git: vcl/win
vcl/win/app/salinfo.cxx |1 +
1 file changed, 1 insertion(+)
New commits:
commit 970b87bb7b7d77ef12dbcad6ed7caa8edd92e413
Author: Noel Grandin
AuthorDate: Wed Sep 14 15:09:05 2022 +0200
Commit: Noel Grandin
CommitDate: Wed Sep 14 20:30:42 2022 +0200
should be releasing the DC here
Change-Id: If2460da367356ef04ca344542c2c82f8283c9e67
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139935
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/vcl/win/app/salinfo.cxx b/vcl/win/app/salinfo.cxx
index 2787797a6ce5..c028939fd65a 100644
--- a/vcl/win/app/salinfo.cxx
+++ b/vcl/win/app/salinfo.cxx
@@ -133,6 +133,7 @@ bool WinSalSystem::initMonitors()
m_aMonitors[ i ].m_aName = rDev + " (" + OUString::number(
nInstance ) + ")";
}
}
+ReleaseDC(nullptr, aDesktopRC);
}
return m_aMonitors.size() > 0;
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 7864d1f24c31c993c800340ceb305ad15faec43e Author: Adolfo Jayme Barrientos AuthorDate: Wed Sep 14 13:29:55 2022 -0500 Commit: Gerrit Code Review CommitDate: Wed Sep 14 20:29:55 2022 +0200 Update git submodules * Update helpcontent2 from branch 'master' to 130638cf417ad37c42c7da8c47f552ba791fe3a7 - Related: tdf#131136 Don’t mention obsolescent “Use printer metrics” option in Help Change-Id: Idfe7f76bef4c48fc4d4762544cbe4439760b1a17 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/139953 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos diff --git a/helpcontent2 b/helpcontent2 index 420d0094490b..130638cf417a 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 420d0094490be80dc2cc019bb7bfe2b2b79fe4c1 +Subproject commit 130638cf417ad37c42c7da8c47f552ba791fe3a7
[Libreoffice-commits] help.git: source/text
source/text/shared/optionen/01041000.xhp |9 - source/text/shared/optionen/01060300.xhp |3 --- 2 files changed, 12 deletions(-) New commits: commit 130638cf417ad37c42c7da8c47f552ba791fe3a7 Author: Adolfo Jayme Barrientos AuthorDate: Wed Sep 14 13:27:52 2022 -0500 Commit: Adolfo Jayme Barrientos CommitDate: Wed Sep 14 20:29:44 2022 +0200 Related: tdf#131136 Don’t mention obsolescent “Use printer metrics” option in Help Change-Id: Idfe7f76bef4c48fc4d4762544cbe4439760b1a17 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/139953 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos diff --git a/source/text/shared/optionen/01041000.xhp b/source/text/shared/optionen/01041000.xhp index 4fa9aadb4..d77ad09e0 100644 --- a/source/text/shared/optionen/01041000.xhp +++ b/source/text/shared/optionen/01041000.xhp @@ -33,9 +33,6 @@ compatibility settings for MS Word import Microsoft Office;importing Word documents layout;importing Word documents - formatting;printer metrics (Writer) - metrics;document formatting (Writer) - printer metrics for document formatting (Writer) @@ -48,12 +45,6 @@ Some of the settings defined here are only valid for the current document and must be defined separately for each document. - - -Use printer metrics for document formatting -Specifies that printer metrics are applied for printing and also for formatting the display on the screen. If this box is not checked, a printer independent layout will be used for screen display and printing. -If you set this option for the current document and then save the document, for example, in an older binary format, this option will not be saved. If you later open the file from the older format, this option will be set by default. - Add spacing between paragraphs and tables In $[officename] Writer, paragraph spacing is defined differently than in Microsoft Word documents. If you have defined spacing between two paragraphs or tables, spacing is also added in the corresponding Word documents. Specifies whether to add Microsoft Word-compatible spacing between paragraphs and tables in $[officename] Writer text documents. diff --git a/source/text/shared/optionen/01060300.xhp b/source/text/shared/optionen/01060300.xhp index a1d1e8ceb..e069df80b 100644 --- a/source/text/shared/optionen/01060300.xhp +++ b/source/text/shared/optionen/01060300.xhp @@ -90,9 +90,6 @@ Specifies whether to highlight column and row headers in the selected columns or rows. - -Use printer metrics for text formatting -Specifies that printer metrics are applied for printing and also for formatting the display on the screen. If this box is not checked, a printer independent layout will be used for screen display and printing. Show overwrite warning when pasting data
[Libreoffice-bugs] [Bug 150961] Pivot table sorting option is gone after resaving in LO in xlsx format
https://bugs.documentfoundation.org/show_bug.cgi?id=150961 --- Comment #2 from Thomas Jiang --- Created attachment 182449 --> https://bugs.documentfoundation.org/attachment.cgi?id=182449=edit The xlsx file resaved using LO In this file, even though in the pivot table is still there, but sorting option is gone. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150961] Pivot table sorting option is gone after resaving in LO in xlsx format
https://bugs.documentfoundation.org/show_bug.cgi?id=150961 --- Comment #1 from Thomas Jiang --- Created attachment 182448 --> https://bugs.documentfoundation.org/attachment.cgi?id=182448=edit The xlsx file with pivot table option created by Office Excel -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 95247] Borders accesibility
https://bugs.documentfoundation.org/show_bug.cgi?id=95247 --- Comment #6 from MichelleHernandez --- Glad to find the help about the coding on your blog is quite useful and wise. I’m sure numerous people are getting great help on https://www.flokii.com/questions/view/113/what-are-the-effects-of-kala-sarpa-yoga your blog that would work to everyone. I admire your helping material please continue sharing the trusted updates. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144583] Blurry icon on HiDPI
https://bugs.documentfoundation.org/show_bug.cgi?id=144583 Adolfo Jayme Barrientos changed: What|Removed |Added Component|LibreOffice |UI -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: extras/source
extras/source/templates/presnt/Vivid/styles.xml |8 1 file changed, 4 insertions(+), 4 deletions(-) New commits: commit 3274fd1b9bfd04ca018c98084689cb9a810a350b Author: Laurent BP AuthorDate: Sun Sep 11 18:14:19 2022 +0200 Commit: Adolfo Jayme Barrientos CommitDate: Wed Sep 14 20:11:27 2022 +0200 tdf#135060 Modify Vivid template Remove language (to get automaticaly user language) Restore same font size for Asian and complex font When using template as master page, styles Accent_x are not imported This patch add direct formating to keep format when using template as master page. Change-Id: Iea38c1e235967c7f8d47d6a4419aec62ff4e9a33 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139779 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos diff --git a/extras/source/templates/presnt/Vivid/styles.xml b/extras/source/templates/presnt/Vivid/styles.xml index 1419f7b50420..b080b561b2b9 100644 --- a/extras/source/templates/presnt/Vivid/styles.xml +++ b/extras/source/templates/presnt/Vivid/styles.xml @@ -23,7 +23,7 @@ - + @@ -369,7 +369,7 @@ - + @@ -797,8 +797,8 @@ - - + +
[Libreoffice-commits] core.git: sysui/desktop
sysui/desktop/menus/startcenter.desktop |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit cee678f028e2f819414152770032e90fc777cc4a
Author: Adolfo Jayme Barrientos
AuthorDate: Mon Sep 12 09:08:48 2022 -0500
Commit: Adolfo Jayme Barrientos
CommitDate: Wed Sep 14 20:10:39 2022 +0200
tdf#149990 Remove unwarranted, unlocalizable term from main launcher
This change was added in commit 6ed597a7dd1da40248236e7a71843c2d76d6173e
for unclear reasons (that wasn’t asked for in the bug report), and,
besides, it solves an inexistent problem. No one has been confused on their
expectations after clicking this launcher on their app selector or Start
menu.
For anyone looking, it is an obvious thing that, if presented with a set of
launchers like:
LibreOffice
LibreOffice Writer
LibreOffice Calc
...
... the option that isn’t specific will launch a general interface. That’s
just simple.
“Start Center” is not the brand name of an application. Although,
technically, it is
a module, for users, it’s just a welcome screen, to which OOo has added a
glorified
name (it seems we’re experts on inventing weird terms for everyday UI
paradigms…
just see “NotebookBar”, which is just a ribbon; deal with it).
It shouldn’t be present in the main launcher for the same reason we don’t
add
the word “Dialog” to the title of every dialog.
Change-Id: I3703299fcb8a8244c721631c3107c9f9d3264d83
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139805
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos
diff --git a/sysui/desktop/menus/startcenter.desktop
b/sysui/desktop/menus/startcenter.desktop
index 042fa79d247c..d2423094d6aa 100644
--- a/sysui/desktop/menus/startcenter.desktop
+++ b/sysui/desktop/menus/startcenter.desktop
@@ -24,7 +24,7 @@ Type=Application
Categories=Office;X-Red-Hat-Base;X-SuSE-Core-Office;X-MandrivaLinux-Office-Other;
Exec=${UNIXBASISROOTNAME} %%FILE%%
MimeType=application/vnd.openofficeorg.extension;x-scheme-handler/vnd.libreoffice.cmis;x-scheme-handler/vnd.sun.star.webdav;x-scheme-handler/vnd.sun.star.webdavs;x-scheme-handler/vnd.libreoffice.command;x-scheme-handler/ms-word;x-scheme-handler/ms-powerpoint;x-scheme-handler/ms-excel;x-scheme-handler/ms-visio;x-scheme-handler/ms-access;
-Name=%PRODUCTNAME Start Center
+Name=%PRODUCTNAME
GenericName=Office
Comment=Launch applications to create text documents, spreadsheets,
presentations, drawings, formulas, and databases, or open recently used
documents.
StartupNotify=true
[Libreoffice-commits] core.git: extras/source
extras/source/templates/presnt/Sunset/styles.xml | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) New commits: commit 84cfd8c856e5d564e33b93cf3f8cf6ffe3df3793 Author: Laurent BP AuthorDate: Sun Sep 11 17:27:45 2022 +0200 Commit: Adolfo Jayme Barrientos CommitDate: Wed Sep 14 20:09:59 2022 +0200 tdf#135060 Modify Sunset template Remove gradient of hidden rectangle When using template as master page, styles Accent_x are not imported This patch add direct formating to keep format when using template as master page. Change-Id: I06c85be58593b63f55b3f61100a431f5ccf8c0c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139776 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos diff --git a/extras/source/templates/presnt/Sunset/styles.xml b/extras/source/templates/presnt/Sunset/styles.xml index 37439484cc5b..5cced0cab123 100644 --- a/extras/source/templates/presnt/Sunset/styles.xml +++ b/extras/source/templates/presnt/Sunset/styles.xml @@ -387,14 +387,14 @@ - - + + - - + + - - + +
[Libreoffice-bugs] [Bug 150962] LibreOffice CALC hangs or crashes on different standard situations without any message ( sorting, saving, fill out fields )
https://bugs.documentfoundation.org/show_bug.cgi?id=150962 --- Comment #1 from Rainer Primosch --- It crashed 80-90%, so unfortunately i had to work on the documents with an other application. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 80467] UI: "Element anchor" appears RTL aligned, with bad bidi braces in Hebrew UI version and possibly other RTL languages.
https://bugs.documentfoundation.org/show_bug.cgi?id=80467 Eyal Rozenberg changed: What|Removed |Added Blocks||43808 CC||eyalr...@gmx.com --- Comment #8 from Eyal Rozenberg --- Seeing this with build: Version: 7.5.0.0.alpha0+ / LibreOffice Community Build ID: 6c81a09e3ef239a2d7a991d00fe3620a67298b99 CPU threads: 4; OS: Linux 5.18; UI render: default; VCL: gtk3 Locale: en-IL (en_IL); UI: he-IL but - inconsistently. First, the examples seem laid out properly for me, despite the rest of the elements having their direction RTL'ed. Also, after seeing the what Avishay described, when I resize the window, and re-dock the undocked formula elements region - the rendering seems to be corrected, i.e. an LTRed equation; and the font size which seemed smaller than it should be (not something Avishay described) grows to match the text next to the formula I've created. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=43808 [Bug 43808] [META] Right-To-Left and Complex Text Layout language issues (RTL/CTL) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 43808] [META] Right-To-Left and Complex Text Layout language issues (RTL/CTL)
https://bugs.documentfoundation.org/show_bug.cgi?id=43808 Eyal Rozenberg changed: What|Removed |Added Depends on||80467 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=80467 [Bug 80467] UI: "Element anchor" appears RTL aligned, with bad bidi braces in Hebrew UI version and possibly other RTL languages. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150962] New: LibreOffice CALC hangs or crashes on different standard situations without any message ( sorting, saving, fill out fields )
https://bugs.documentfoundation.org/show_bug.cgi?id=150962 Bug ID: 150962 Summary: LibreOffice CALC hangs or crashes on different standard situations without any message ( sorting, saving, fill out fields ) Product: LibreOffice Version: 7.4.0.3 release Hardware: All OS: macOS (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rainer.primo...@aon.at Description: I work with LibreOffice Calc with a sheet. If i make changes, add a new row odr change a field and i klick save the document, LibreOffice crashes and try to save changes. Also if i try to sort the data in alphabetical order, LibreOffice also crash often. The sav data tialog, newer is finished. Si i have to stop LibreOffice immediate. With the same document i can work on Windows10 without any problem! The document is a sheet with names, mail adresses and some additional fields. Only 40 rows of data The problem occures on 80% of tryes! Had to install OpenOffice again that i can handle that document. Steps to Reproduce: 1. open a CALC document 2. add some new data in an empty row 3. save the document or 1. open a CALC document 2. sort the list in alphabetical order Actual Results: LibreOffice crashes and is closing. LibreOffice try to save the changes, but never will finished. So had to close the application immidiate. Expected Results: Save the file without crashing! Sorting the file without a crash! Reproducible: Always User Profile Reset: Yes Additional Info: Version: 7.4.0.3 / LibreOffice Community Build ID: f85e47c08ddd19c015c0114a68350214f7066f5a CPU threads: 20; OS: Mac OS X 12.5.1; UI render: default; VCL: osx Locale: de-AT (de_AT.UTF-8); UI: de-DE Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
