[Libreoffice-bugs] [Bug 138625] FILEOPEN DOCX: The footnote/endnote number in an imported word text is not in a superscript (non-English UI only), because its formatting loaded in a new character styl
https://bugs.documentfoundation.org/show_bug.cgi?id=138625 --- Comment #21 from Commit Notification --- László Németh committed a patch related to this issue. It has been pushed to "libreoffice-7-3": https://git.libreoffice.org/core/commit/26e323976cc29b549eeb3c0f586e007045a3206e tdf#138625 DOCX import: fix superscript footnote numbering in l10n It will be available in 7.3.7. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 138625] FILEOPEN DOCX: The footnote/endnote number in an imported word text is not in a superscript (non-English UI only), because its formatting loaded in a new character styl
https://bugs.documentfoundation.org/show_bug.cgi?id=138625 Commit Notification changed: What|Removed |Added Whiteboard|non-English-UI-needed |non-English-UI-needed |target:7.5.0 target:7.4.3 |target:7.5.0 target:7.4.3 ||target:7.3.7 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - writerfilter/source
writerfilter/source/dmapper/StyleSheetTable.cxx |8
1 file changed, 4 insertions(+), 4 deletions(-)
New commits:
commit 26e323976cc29b549eeb3c0f586e007045a3206e
Author: László Németh
AuthorDate: Mon Oct 3 17:15:04 2022 +0200
Commit: Adolfo Jayme Barrientos
CommitDate: Wed Oct 5 07:14:04 2022 +0200
tdf#138625 DOCX import: fix superscript footnote numbering in l10n
Footnote/endnote numbers in the footnote area didn't get
superscript etc. formatting in non-English locale
settings because of the writerfilter mapping to
the English localization ("Footnote Characters" and
"Endnote Characters") instead of the correct
programmatic character style names ("Footnote Symbol"
and "Endnote Symbol") according to
SwStyleNameMapper::GetChrFormatProgNameArray().
Testing: unit test of tdf#82173. Manual: e.g. open test
document of tdf#138625 in an Italian build, after setting
Italian locale in it in Tools->Options...->Language Settings->
Languages->Language of user interface.
Follow-up to commit 707eb4db1918658e0c2c2c2033c6a69f80c4eafd
"tdf#82173 writerfilter: charStyle XnoteReference->Xnote Characters".
Change-Id: I36b3c5ff065e9f80289d051e27f618b40e0c9355
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140918
Tested-by: László Németh
Reviewed-by: László Németh
(cherry picked from commit 5a1c668747f3495ddc7567ae95f2145663565647)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140891
Reviewed-by: Michael Stahl
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos
diff --git a/writerfilter/source/dmapper/StyleSheetTable.cxx
b/writerfilter/source/dmapper/StyleSheetTable.cxx
index fe5d718827f0..8b3bc02b44a6 100644
--- a/writerfilter/source/dmapper/StyleSheetTable.cxx
+++ b/writerfilter/source/dmapper/StyleSheetTable.cxx
@@ -1493,13 +1493,13 @@ OUString StyleSheetTable::ConvertStyleName( const
OUString& rWWName, bool bExten
//{ "Table of Figures", "" },
{ "Envelope Address", "Addressee" },
{ "Envelope Return", "Sender" },
-{ "footnote reference", "Footnote Characters" },
-{ "Footnote Reference", "Footnote Characters" },
+{ "footnote reference", "Footnote Symbol" },
+{ "Footnote Reference", "Footnote Symbol" },
//{ "Annotation Reference", "" },
{ "Line Number", "Line numbering" },
{ "Page Number", "Page Number" },
-{ "endnote reference", "Endnote Characters" },
-{ "Endnote Reference", "Endnote Characters" },
+{ "endnote reference", "Endnote Symbol" },
+{ "Endnote Reference", "Endnote Symbol" },
{ "endnote text", "Endnote" },
{ "Endnote Text", "Endnote" },
//{ "Table of Authorities", "" },
[Libreoffice-bugs] [Bug 106568] [META] Text Grid Issues
https://bugs.documentfoundation.org/show_bug.cgi?id=106568 Dieter changed: What|Removed |Added Depends on||149534 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=149534 [Bug 149534] Japanese character spacing does not work correctly when grid is enabled -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149534] Japanese character spacing does not work correctly when grid is enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=149534 Dieter changed: What|Removed |Added Ever confirmed|0 |1 Blocks||106568 Status|UNCONFIRMED |NEW --- Comment #5 from Dieter --- I confirm it with Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community Build ID: c3b5eea4304ad6815b491f549fce008a9630c213 CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL threaded Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=106568 [Bug 106568] [META] Text Grid Issues -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 109072] [META] XLS (binary) format bug tracker
https://bugs.documentfoundation.org/show_bug.cgi?id=109072 Bug 109072 depends on bug 151283, which changed state. Bug 151283 Summary: LO Calc hangs when try to open XLS file https://bugs.documentfoundation.org/show_bug.cgi?id=151283 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151283] LO Calc hangs when try to open XLS file
https://bugs.documentfoundation.org/show_bug.cgi?id=151283 Noel Grandin changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151283] LO Calc hangs when try to open XLS file
https://bugs.documentfoundation.org/show_bug.cgi?id=151283 --- Comment #6 from Commit Notification --- Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/a36173359d4614a8935e2f764acadfcf736e091c tdf#151283 calc hangs when try to open XLS file It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151283] LO Calc hangs when try to open XLS file
https://bugs.documentfoundation.org/show_bug.cgi?id=151283 Commit Notification changed: What|Removed |Added Whiteboard||target:7.5.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: chart2/source
chart2/source/view/main/VLegend.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit a36173359d4614a8935e2f764acadfcf736e091c Author: Noel Grandin AuthorDate: Tue Oct 4 18:35:17 2022 +0200 Commit: Noel Grandin CommitDate: Wed Oct 5 07:02:24 2022 +0200 tdf#151283 calc hangs when try to open XLS file regression from commit 258a8d133d0548c7af51f4852260e9969df288fc Author: Noel Grandin tdf#150034 very slow opening pathological chart if nNewLen is < 10, we can get stuck in an infinite loop because the calculation will not actually decrement nNewLen Change-Id: I98920deaa087713c44531a7f6506d1d5d32b2e98 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140949 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/chart2/source/view/main/VLegend.cxx b/chart2/source/view/main/VLegend.cxx index 1cfa1848d024..061cbb39976d 100644 --- a/chart2/source/view/main/VLegend.cxx +++ b/chart2/source/view/main/VLegend.cxx @@ -448,7 +448,7 @@ awt::Size lcl_placeLegendEntries( DrawModelWrapper::removeShape(xEntry); // The intention here is to make pathological cases with extremely large labels // converge a little faster -if (std::abs(nRemainingSpace) > nSumHeight / 10) +if (nNewLen > 10 && std::abs(nRemainingSpace) > nSumHeight / 10) nNewLen -= nNewLen / 10; else --nNewLen;
[Libreoffice-commits] core.git: chart2/uiconfig dbaccess/uiconfig extensions/uiconfig reportdesign/uiconfig sc/uiconfig sd/uiconfig starmath/uiconfig sw/uiconfig
chart2/uiconfig/menubar/menubar.xml |3 +-- dbaccess/uiconfig/dbapp/menubar/menubar.xml |3 +-- dbaccess/uiconfig/dbquery/menubar/menubar.xml |3 +-- dbaccess/uiconfig/dbrelation/menubar/menubar.xml |3 +-- dbaccess/uiconfig/dbtable/menubar/menubar.xml |3 +-- dbaccess/uiconfig/dbtdata/menubar/menubar.xml |3 +-- extensions/uiconfig/sbibliography/menubar/menubar.xml |3 +-- reportdesign/uiconfig/dbreport/menubar/menubar.xml|3 +-- sc/uiconfig/scalc/menubar/menubar.xml |3 +-- sd/uiconfig/sdraw/menubar/menubar.xml |5 ++--- sd/uiconfig/simpress/menubar/menubar.xml |3 +-- starmath/uiconfig/smath/menubar/menubar.xml |3 +-- sw/uiconfig/sglobal/menubar/menubar.xml |3 +-- sw/uiconfig/sweb/menubar/menubar.xml |3 +-- sw/uiconfig/swform/menubar/menubar.xml|3 +-- sw/uiconfig/swreport/menubar/menubar.xml |3 +-- sw/uiconfig/swriter/menubar/menubar.xml |3 +-- sw/uiconfig/swxform/menubar/menubar.xml |3 +-- 18 files changed, 19 insertions(+), 37 deletions(-) New commits: commit 0ab5a5ee6e7cafa0c0d3e5ffee809e6b77af3796 Author: Justin Luth AuthorDate: Thu Sep 29 09:08:37 2022 -0400 Commit: Adolfo Jayme Barrientos CommitDate: Wed Oct 5 06:59:36 2022 +0200 tdf#126917 menu: OpenXMLFilterSettings != Macros OpenXMLFilterSettings has nothing to do with macros, but was moved there in LO 6.3. In 6.2 it was placed just before Extension Manager, so that is where I returned it. Change-Id: Id80b5984c785dc66e66aeb3215d8f1ef8c837442 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140739 Tested-by: Justin Luth Reviewed-by: Justin Luth Reviewed-by: Adolfo Jayme Barrientos diff --git a/chart2/uiconfig/menubar/menubar.xml b/chart2/uiconfig/menubar/menubar.xml index a48cd77d47de..58c84d6cbc33 100644 --- a/chart2/uiconfig/menubar/menubar.xml +++ b/chart2/uiconfig/menubar/menubar.xml @@ -140,10 +140,9 @@ - - + diff --git a/dbaccess/uiconfig/dbapp/menubar/menubar.xml b/dbaccess/uiconfig/dbapp/menubar/menubar.xml index 7038a63608a7..29e65762524c 100644 --- a/dbaccess/uiconfig/dbapp/menubar/menubar.xml +++ b/dbaccess/uiconfig/dbapp/menubar/menubar.xml @@ -127,10 +127,9 @@ - - + diff --git a/dbaccess/uiconfig/dbquery/menubar/menubar.xml b/dbaccess/uiconfig/dbquery/menubar/menubar.xml index 8227446b4b89..762a5533de74 100644 --- a/dbaccess/uiconfig/dbquery/menubar/menubar.xml +++ b/dbaccess/uiconfig/dbquery/menubar/menubar.xml @@ -82,10 +82,9 @@ - - + diff --git a/dbaccess/uiconfig/dbrelation/menubar/menubar.xml b/dbaccess/uiconfig/dbrelation/menubar/menubar.xml index 6e3df781eca9..0c2a73ec31d5 100644 --- a/dbaccess/uiconfig/dbrelation/menubar/menubar.xml +++ b/dbaccess/uiconfig/dbrelation/menubar/menubar.xml @@ -66,10 +66,9 @@ - - + diff --git a/dbaccess/uiconfig/dbtable/menubar/menubar.xml b/dbaccess/uiconfig/dbtable/menubar/menubar.xml index bbd4a7428f74..80511e8ea4d6 100644 --- a/dbaccess/uiconfig/dbtable/menubar/menubar.xml +++ b/dbaccess/uiconfig/dbtable/menubar/menubar.xml @@ -66,10 +66,9 @@ - - + diff --git a/dbaccess/uiconfig/dbtdata/menubar/menubar.xml b/dbaccess/uiconfig/dbtdata/menubar/menubar.xml index bbf379953e85..e787d60d7355 100644 --- a/dbaccess/uiconfig/dbtdata/menubar/menubar.xml +++ b/dbaccess/uiconfig/dbtdata/menubar/menubar.xml @@ -91,10 +91,9 @@ - - + diff --git a/extensions/uiconfig/sbibliography/menubar/menubar.xml b/extensions/uiconfig/sbibliography/menubar/menubar.xml index 3604c1b760a1..9b449072ac32 100644 --- a/extensions/uiconfig/sbibliography/menubar/menubar.xml +++ b/extensions/uiconfig/sbibliography/menubar/menubar.xml @@ -39,10 +39,9 @@ - - + diff --git a/reportdesign/uiconfig/dbreport/menubar/menubar.xml b/reportdesign/uiconfig/dbreport/menubar/menubar.xml index 2ca14f363a5d..e95054ed7889 100644 --- a/reportdesign/uiconfig/dbreport/menubar/menubar.xml +++ b/reportdesign/uiconfig/dbreport/menubar/menubar.xml @@ -256,10 +256,9 @@
[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - cui/source sfx2/source svx/source
cui/source/dialogs/cuicharmap.cxx |4
sfx2/source/control/charwin.cxx |2 ++
svx/source/dialog/charmap.cxx | 16 +---
svx/source/dialog/searchcharmap.cxx | 16 +---
4 files changed, 24 insertions(+), 14 deletions(-)
New commits:
commit 19b650dd49620f699b695fb95679284be509ef2e
Author: Rafael Lima
AuthorDate: Fri Sep 30 19:05:10 2022 +0200
Commit: Adolfo Jayme Barrientos
CommitDate: Wed Oct 5 06:54:53 2022 +0200
tdf#151232 Fix lines in Special Characters dialog in dark mode
This patch makes the lines in the Special Characters dialog visible in dark
mode. The Insert Symbols widget is also fixed with this patch.
Tested in gen, gtk3 and kf5.
Change-Id: Id1ee21557f2a0ea4ad8b60973d3de71e4d6d5d09
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140759
Tested-by: Jenkins
Reviewed-by: V, Stuart Foote
Reviewed-by: Adolfo Jayme Barrientos
(cherry picked from commit be8a83767bed2a9107c5407ebb9fbc0d44772075)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140957
diff --git a/cui/source/dialogs/cuicharmap.cxx
b/cui/source/dialogs/cuicharmap.cxx
index 7effeb4462cf..684186e25a6b 100644
--- a/cui/source/dialogs/cuicharmap.cxx
+++ b/cui/source/dialogs/cuicharmap.cxx
@@ -1163,10 +1163,12 @@ void SvxShowText::Paint(vcl::RenderContext&
rRenderContext, const tools::Rectang
Color aTextCol = rRenderContext.GetTextColor();
Color aFillCol = rRenderContext.GetFillColor();
+Color aLineCol = rRenderContext.GetFillColor();
const StyleSettings& rStyleSettings =
Application::GetSettings().GetStyleSettings();
const Color aWindowTextColor(rStyleSettings.GetDialogTextColor());
const Color aWindowColor(rStyleSettings.GetWindowColor());
+const Color aShadowColor(rStyleSettings.GetShadowColor());
rRenderContext.SetTextColor(aWindowTextColor);
rRenderContext.SetFillColor(aWindowColor);
@@ -1237,10 +1239,12 @@ void SvxShowText::Paint(vcl::RenderContext&
rRenderContext, const tools::Rectang
}
}
+rRenderContext.SetLineColor(aShadowColor);
rRenderContext.DrawRect(tools::Rectangle(Point(0, 0), aSize));
rRenderContext.DrawText(aPoint, aText);
rRenderContext.SetTextColor(aTextCol);
rRenderContext.SetFillColor(aFillCol);
+rRenderContext.SetLineColor(aLineCol);
if (bShrankFont)
rRenderContext.SetFont(aOrigFont);
}
diff --git a/sfx2/source/control/charwin.cxx b/sfx2/source/control/charwin.cxx
index 6b7c8cd8b514..567f365e6b32 100644
--- a/sfx2/source/control/charwin.cxx
+++ b/sfx2/source/control/charwin.cxx
@@ -135,6 +135,7 @@ void SvxCharView::Paint(vcl::RenderContext& rRenderContext,
const tools::Rectang
Color aHighlightTextColor(rStyleSettings.GetHighlightTextColor());
Color aFillColor(rStyleSettings.GetWindowColor());
Color aTextColor(rStyleSettings.GetWindowTextColor());
+Color aShadowColor(rStyleSettings.GetShadowColor());
const OUString aText = GetText();
@@ -201,6 +202,7 @@ void SvxCharView::Paint(vcl::RenderContext& rRenderContext,
const tools::Rectang
else
{
rRenderContext.SetFillColor(aFillColor);
+rRenderContext.SetLineColor(aShadowColor);
rRenderContext.DrawRect(tools::Rectangle(Point(0, 0), aSize));
rRenderContext.SetTextColor(aWindowTextColor);
diff --git a/svx/source/dialog/charmap.cxx b/svx/source/dialog/charmap.cxx
index 6eb9745c8233..4d8dd07b5031 100644
--- a/svx/source/dialog/charmap.cxx
+++ b/svx/source/dialog/charmap.cxx
@@ -509,7 +509,16 @@ void SvxShowCharSet::DrawChars_Impl(vcl::RenderContext&
rRenderContext, int n1,
Size aOutputSize(GetOutputSizePixel());
+const StyleSettings& rStyleSettings =
Application::GetSettings().GetStyleSettings();
+const Color aWindowTextColor(rStyleSettings.GetFieldTextColor());
+Color aHighlightColor(rStyleSettings.GetHighlightColor());
+Color aHighlightTextColor(rStyleSettings.GetHighlightTextColor());
+Color aFaceColor(rStyleSettings.GetFaceColor());
+Color aLightColor(rStyleSettings.GetLightColor());
+Color aShadowColor(rStyleSettings.GetShadowColor());
+
int i;
+rRenderContext.SetLineColor(aShadowColor);
for (i = 1; i < COLUMN_COUNT; ++i)
{
rRenderContext.DrawLine(Point(nX * i + m_nXGap, 0),
@@ -520,13 +529,6 @@ void SvxShowCharSet::DrawChars_Impl(vcl::RenderContext&
rRenderContext, int n1,
rRenderContext.DrawLine(Point(0, nY * i + m_nYGap),
Point(aOutputSize.Width(), nY * i + m_nYGap));
}
-const StyleSettings& rStyleSettings =
Application::GetSettings().GetStyleSettings();
-const Color aWindowTextColor(rStyleSettings.GetFieldTextColor());
-Color aHighlightColor(rStyleSettings.GetHighlightColor());
-Color aHighlightTextColor(rStyleSettings.GetHighlightTextColor());
-Color aFaceColor(rStyleSettings.GetFaceColor());
-Color
[Libreoffice-bugs] [Bug 150915] [META] Windows Dark Mode bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=150915 Bug 150915 depends on bug 151232, which changed state. Bug 151232 Summary: Lines in Special Characters dialog do not respect dark mode https://bugs.documentfoundation.org/show_bug.cgi?id=151232 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143344] [META] Linux Dark Mode bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=143344 Bug 143344 depends on bug 151232, which changed state. Bug 151232 Summary: Lines in Special Characters dialog do not respect dark mode https://bugs.documentfoundation.org/show_bug.cgi?id=151232 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: cui/source sfx2/source svx/source
cui/source/dialogs/cuicharmap.cxx |4
sfx2/source/control/charwin.cxx |2 ++
svx/source/dialog/charmap.cxx | 16 +---
svx/source/dialog/searchcharmap.cxx | 16 +---
4 files changed, 24 insertions(+), 14 deletions(-)
New commits:
commit 3e4697c7675430f5e4e2221c951971caee0bdeb8
Author: Rafael Lima
AuthorDate: Fri Sep 30 19:05:10 2022 +0200
Commit: Adolfo Jayme Barrientos
CommitDate: Wed Oct 5 05:43:42 2022 +0200
tdf#151232 Fix lines in Special Characters dialog in dark mode
This patch makes the lines in the Special Characters dialog visible in dark
mode. The Insert Symbols widget is also fixed with this patch.
Tested in gen, gtk3 and kf5.
Change-Id: Id1ee21557f2a0ea4ad8b60973d3de71e4d6d5d09
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140759
Tested-by: Jenkins
Reviewed-by: V, Stuart Foote
Reviewed-by: Adolfo Jayme Barrientos
diff --git a/cui/source/dialogs/cuicharmap.cxx
b/cui/source/dialogs/cuicharmap.cxx
index 7effeb4462cf..684186e25a6b 100644
--- a/cui/source/dialogs/cuicharmap.cxx
+++ b/cui/source/dialogs/cuicharmap.cxx
@@ -1163,10 +1163,12 @@ void SvxShowText::Paint(vcl::RenderContext&
rRenderContext, const tools::Rectang
Color aTextCol = rRenderContext.GetTextColor();
Color aFillCol = rRenderContext.GetFillColor();
+Color aLineCol = rRenderContext.GetFillColor();
const StyleSettings& rStyleSettings =
Application::GetSettings().GetStyleSettings();
const Color aWindowTextColor(rStyleSettings.GetDialogTextColor());
const Color aWindowColor(rStyleSettings.GetWindowColor());
+const Color aShadowColor(rStyleSettings.GetShadowColor());
rRenderContext.SetTextColor(aWindowTextColor);
rRenderContext.SetFillColor(aWindowColor);
@@ -1237,10 +1239,12 @@ void SvxShowText::Paint(vcl::RenderContext&
rRenderContext, const tools::Rectang
}
}
+rRenderContext.SetLineColor(aShadowColor);
rRenderContext.DrawRect(tools::Rectangle(Point(0, 0), aSize));
rRenderContext.DrawText(aPoint, aText);
rRenderContext.SetTextColor(aTextCol);
rRenderContext.SetFillColor(aFillCol);
+rRenderContext.SetLineColor(aLineCol);
if (bShrankFont)
rRenderContext.SetFont(aOrigFont);
}
diff --git a/sfx2/source/control/charwin.cxx b/sfx2/source/control/charwin.cxx
index 6b7c8cd8b514..567f365e6b32 100644
--- a/sfx2/source/control/charwin.cxx
+++ b/sfx2/source/control/charwin.cxx
@@ -135,6 +135,7 @@ void SvxCharView::Paint(vcl::RenderContext& rRenderContext,
const tools::Rectang
Color aHighlightTextColor(rStyleSettings.GetHighlightTextColor());
Color aFillColor(rStyleSettings.GetWindowColor());
Color aTextColor(rStyleSettings.GetWindowTextColor());
+Color aShadowColor(rStyleSettings.GetShadowColor());
const OUString aText = GetText();
@@ -201,6 +202,7 @@ void SvxCharView::Paint(vcl::RenderContext& rRenderContext,
const tools::Rectang
else
{
rRenderContext.SetFillColor(aFillColor);
+rRenderContext.SetLineColor(aShadowColor);
rRenderContext.DrawRect(tools::Rectangle(Point(0, 0), aSize));
rRenderContext.SetTextColor(aWindowTextColor);
diff --git a/svx/source/dialog/charmap.cxx b/svx/source/dialog/charmap.cxx
index a48d26b67954..b268fff518d1 100644
--- a/svx/source/dialog/charmap.cxx
+++ b/svx/source/dialog/charmap.cxx
@@ -510,7 +510,16 @@ void SvxShowCharSet::DrawChars_Impl(vcl::RenderContext&
rRenderContext, int n1,
Size aOutputSize(GetOutputSizePixel());
+const StyleSettings& rStyleSettings =
Application::GetSettings().GetStyleSettings();
+const Color aWindowTextColor(rStyleSettings.GetFieldTextColor());
+Color aHighlightColor(rStyleSettings.GetHighlightColor());
+Color aHighlightTextColor(rStyleSettings.GetHighlightTextColor());
+Color aFaceColor(rStyleSettings.GetFaceColor());
+Color aLightColor(rStyleSettings.GetLightColor());
+Color aShadowColor(rStyleSettings.GetShadowColor());
+
int i;
+rRenderContext.SetLineColor(aShadowColor);
for (i = 1; i < COLUMN_COUNT; ++i)
{
rRenderContext.DrawLine(Point(nX * i + m_nXGap, 0),
@@ -521,13 +530,6 @@ void SvxShowCharSet::DrawChars_Impl(vcl::RenderContext&
rRenderContext, int n1,
rRenderContext.DrawLine(Point(0, nY * i + m_nYGap),
Point(aOutputSize.Width(), nY * i + m_nYGap));
}
-const StyleSettings& rStyleSettings =
Application::GetSettings().GetStyleSettings();
-const Color aWindowTextColor(rStyleSettings.GetFieldTextColor());
-Color aHighlightColor(rStyleSettings.GetHighlightColor());
-Color aHighlightTextColor(rStyleSettings.GetHighlightTextColor());
-Color aFaceColor(rStyleSettings.GetFaceColor());
-Color aLightColor(rStyleSettings.GetLightColor());
-Color aShadowColor(rStyleSettings.GetShadowColor());
int nTextHeight = rRenderContext.GetTextHeight();
[Libreoffice-bugs] [Bug 151341] Slow macOS install caused by bzip2 dmg
https://bugs.documentfoundation.org/show_bug.cgi?id=151341 Telesto changed: What|Removed |Added CC||cl...@documentfoundation.or ||g, tele...@surfxs.nl --- Comment #2 from Telesto --- >From bug 114679 comment 13 Chat conversation with Cloph: Nothing we can do about it as it is mac that is copying the files from dmg to target disk. Nothing special about that / LibreOffice package has no say in that / is not involved at all. So the complaint is rather: macOS is slow at copying files from a mounted diskimage (dmg). Type of compression could be changed, but I doubt this would make any difference. If someone does research on why it is slow, I'm willing to have another look, but as it stands now: I don't see any way to improve it. Is not the signing/notarization, since the daily builds are not signed or notarized and apparently suffer from the same slowdowns. So leaves only the compression used as a potential candidate, but then again I cannot really imagine that would change things. Potential starting point: play with how the dmg is created, search for the hdiutil invocations in the code etc: https://opengrok.libreoffice.org/xref/core/solenv/bin/modules/installer/simplepackage.pm?r=443f65e9#458 As per above remarks setting to NOTOURBUG -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - sfx2/source
sfx2/source/doc/doctempl.cxx |8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
New commits:
commit e2b9f3ea1ba70f07c3db56a331d6b926c8facb81
Author: Kevin Suo
AuthorDate: Fri Sep 30 14:21:10 2022 +0800
Commit: Adolfo Jayme Barrientos
CommitDate: Wed Oct 5 05:34:34 2022 +0200
Templates: Make localized names for "Simple" and "BPMN" show on the UI
Currently there are 32 localized template name strings defined in:
include/sfx2/strings.hrc. However, in sfx2/source/doc/doctempl.cxx
only 30 were used. This makes STR_TEMPLATE_NAME31 ("Simple") and
STR_TEMPLATE_NAME32 ("BPMN"), although already localized, not show up
on the Template Manager UI.
This patch adds these two strings in the sfx2/source/doc/doctempl.cxx,
so that they properly show as localized strings on the UI.
Change-Id: I64bb28cfe0a4d3b4b41c9114de7223014f6a3cfe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140785
Tested-by: Jenkins
Reviewed-by: Rafael Lima
Reviewed-by: Laurent Balland
(cherry picked from commit 244063d03117119d048376c84e22cf47c4abd250)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140956
Reviewed-by: Adolfo Jayme Barrientos
Tested-by: Adolfo Jayme Barrientos
diff --git a/sfx2/source/doc/doctempl.cxx b/sfx2/source/doc/doctempl.cxx
index f464ab66f4a3..ebf2ddce4a1f 100644
--- a/sfx2/source/doc/doctempl.cxx
+++ b/sfx2/source/doc/doctempl.cxx
@@ -492,7 +492,9 @@ OUString SfxDocumentTemplates::ConvertResourceString(const
OUString& rString)
STR_TEMPLATE_NAME27_DEF,
STR_TEMPLATE_NAME28_DEF,
STR_TEMPLATE_NAME29_DEF,
-STR_TEMPLATE_NAME30_DEF
+STR_TEMPLATE_NAME30_DEF,
+STR_TEMPLATE_NAME31_DEF,
+STR_TEMPLATE_NAME32_DEF,
};
TranslateId STR_TEMPLATE_NAME[] =
@@ -526,7 +528,9 @@ OUString SfxDocumentTemplates::ConvertResourceString(const
OUString& rString)
STR_TEMPLATE_NAME27,
STR_TEMPLATE_NAME28,
STR_TEMPLATE_NAME29,
-STR_TEMPLATE_NAME30
+STR_TEMPLATE_NAME30,
+STR_TEMPLATE_NAME31,
+STR_TEMPLATE_NAME32,
};
static_assert(SAL_N_ELEMENTS(aTemplateNames) ==
SAL_N_ELEMENTS(STR_TEMPLATE_NAME));
[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - sfx2/source
sfx2/source/doc/doctempl.cxx |8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
New commits:
commit ddd45141f5d20dcba22a379797be62eab7b93d73
Author: Kevin Suo
AuthorDate: Fri Sep 30 14:21:10 2022 +0800
Commit: Adolfo Jayme Barrientos
CommitDate: Wed Oct 5 05:33:44 2022 +0200
Templates: Make localized names for "Simple" and "BPMN" show on the UI
Currently there are 32 localized template name strings defined in:
include/sfx2/strings.hrc. However, in sfx2/source/doc/doctempl.cxx
only 30 were used. This makes STR_TEMPLATE_NAME31 ("Simple") and
STR_TEMPLATE_NAME32 ("BPMN"), although already localized, not show up
on the Template Manager UI.
This patch adds these two strings in the sfx2/source/doc/doctempl.cxx,
so that they properly show as localized strings on the UI.
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140785
Tested-by: Jenkins
Reviewed-by: Rafael Lima
Reviewed-by: Laurent Balland
(cherry picked from commit 244063d03117119d048376c84e22cf47c4abd250)
Conflicts:
sfx2/source/doc/doctempl.cxx
Change-Id: I64bb28cfe0a4d3b4b41c9114de7223014f6a3cfe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140945
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos
diff --git a/sfx2/source/doc/doctempl.cxx b/sfx2/source/doc/doctempl.cxx
index a7fcb4c8b3fd..edb401aa7363 100644
--- a/sfx2/source/doc/doctempl.cxx
+++ b/sfx2/source/doc/doctempl.cxx
@@ -492,7 +492,9 @@ OUString SfxDocumentTemplates::ConvertResourceString(const
OUString& rString)
u"" STR_TEMPLATE_NAME27_DEF,
u"" STR_TEMPLATE_NAME28_DEF,
u"" STR_TEMPLATE_NAME29_DEF,
-u"" STR_TEMPLATE_NAME30_DEF
+u"" STR_TEMPLATE_NAME30_DEF,
+u"" STR_TEMPLATE_NAME31_DEF,
+u"" STR_TEMPLATE_NAME32_DEF,
};
TranslateId STR_TEMPLATE_NAME[] =
@@ -526,7 +528,9 @@ OUString SfxDocumentTemplates::ConvertResourceString(const
OUString& rString)
STR_TEMPLATE_NAME27,
STR_TEMPLATE_NAME28,
STR_TEMPLATE_NAME29,
-STR_TEMPLATE_NAME30
+STR_TEMPLATE_NAME30,
+STR_TEMPLATE_NAME31,
+STR_TEMPLATE_NAME32,
};
static_assert(SAL_N_ELEMENTS(aTemplateNames) ==
SAL_N_ELEMENTS(STR_TEMPLATE_NAME));
[Libreoffice-bugs] [Bug 151148] Finding KATAKANA which has voice consonant mark returns incorrect results.
https://bugs.documentfoundation.org/show_bug.cgi?id=151148 Adolfo Jayme Barrientos changed: What|Removed |Added Whiteboard|target:7.5.0 target:7.4.3 |target:7.5.0 target:7.4.2 |target:7.3.7 target:7.4.2 |target:7.3.7 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150715] Animations in LO Impress do not work properly
https://bugs.documentfoundation.org/show_bug.cgi?id=150715 Adolfo Jayme Barrientos changed: What|Removed |Added Whiteboard|target:7.5.0 target:7.4.3 |target:7.5.0 target:7.4.2 |target:7.4.2| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150915] [META] Windows Dark Mode bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=150915 Rafael Lima changed: What|Removed |Added Depends on||150564 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=150564 [Bug 150564] Background color of drop down menus change after resume -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150564] Background color of drop down menus change after resume
https://bugs.documentfoundation.org/show_bug.cgi?id=150564 Rafael Lima changed: What|Removed |Added Blocks||150915 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=150915 [Bug 150915] [META] Windows Dark Mode bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150564] Background color of drop down menus change after resume
https://bugs.documentfoundation.org/show_bug.cgi?id=150564 Rafael Lima changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||1331 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151331] Using "Dark colours" in Windows leads to drop-down menus having dark text on dark backgrounds after I un-sleep my laptop
https://bugs.documentfoundation.org/show_bug.cgi?id=151331 Rafael Lima changed: What|Removed |Added Blocks||150915 See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||0564 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=150915 [Bug 150915] [META] Windows Dark Mode bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150915] [META] Windows Dark Mode bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=150915 Rafael Lima changed: What|Removed |Added Depends on||151331 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=151331 [Bug 151331] Using "Dark colours" in Windows leads to drop-down menus having dark text on dark backgrounds after I un-sleep my laptop -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151347] Incorrect referral as "Slide Sorter" for the sd LEFT PANE "Slide pane" (Impress) "Page pane" (Draw)
https://bugs.documentfoundation.org/show_bug.cgi?id=151347 V Stuart Foote changed: What|Removed |Added Summary|Incorrect use of "Slide |Incorrect referral as |Sorter" for the sd LEFT |"Slide Sorter" for the sd |PANE "Slide pane" (Impress) |LEFT PANE "Slide pane" |"Page pane" (Draw) |(Impress) "Page pane" ||(Draw) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151332] odt from LibreOffice are not opened correctly by MS Office.
https://bugs.documentfoundation.org/show_bug.cgi?id=151332 --- Comment #2 from diekuhran...@web.de --- Hello Eike Rathke thanks, your info helped me a lot. So if LO does everything right, I am very relieved. Yes, I have since learned that the odt can be opened with MS-Office 2016 without any problems. That coincides with your assessment. Shall we delete my bug message? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151349] very slow open calc document
https://bugs.documentfoundation.org/show_bug.cgi?id=151349 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Ever confirmed|0 |1 Summary|very slow |very slow open calc ||document CC||79045_79...@mail.ru Status|UNCONFIRMED |NEEDINFO --- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> --- Please attach your document here -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: vcl/source
vcl/source/gdi/CommonSalLayout.cxx |6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
New commits:
commit cc038c471e96d766db404388b140364614898bf2
Author: Khaled Hosny
AuthorDate: Tue Oct 4 15:30:40 2022 +0200
Commit: خالد حسني
CommitDate: Tue Oct 4 23:14:44 2022 +0200
vcl: Fix thinko from recent commit
From:
commit 29de4d6e1afcf2ad79056e4ad4403c3d4bdda4a0
Author: Khaled Hosny
Date: Mon Oct 3 21:53:38 2022 +0200
tdf#150665: Fix justifying spacing marks
Change-Id: Ic312db0080526e66b918d6ca9edb09c6a669e449
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140944
Tested-by: Jenkins
Reviewed-by: خالد حسني
diff --git a/vcl/source/gdi/CommonSalLayout.cxx
b/vcl/source/gdi/CommonSalLayout.cxx
index ca7e1cd42f55..fa023d496af8 100644
--- a/vcl/source/gdi/CommonSalLayout.cxx
+++ b/vcl/source/gdi/CommonSalLayout.cxx
@@ -529,12 +529,8 @@ bool
GenericSalLayout::LayoutText(vcl::text::ImplLayoutArgs& rArgs, const SalLay
// For our purposes, a mark glyph is part of cluster as well.
hb_face_t* pHbFace = hb_font_get_face(pHbFont);
-if (hb_ot_layout_get_glyph_class(pHbFace, nGlyphIndex) ==
HB_OT_LAYOUT_GLYPH_CLASS_MARK
-&& nCharPos != mnMinCharPos)
-{
-bClusterStart = false;
+if (hb_ot_layout_get_glyph_class(pHbFace, nGlyphIndex) ==
HB_OT_LAYOUT_GLYPH_CLASS_MARK)
bInCluster = true;
-}
GlyphItemFlags nGlyphFlags = GlyphItemFlags::NONE;
if (bRightToLeft)
[Libreoffice-bugs] [Bug 151335] Can't find info about "Comment" in Helpfile
https://bugs.documentfoundation.org/show_bug.cgi?id=151335 Olivier Hallot changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |WORKSFORME --- Comment #1 from Olivier Hallot --- Version 7.1.5.2 is a bit outdated, we recommend to update your version at your earliest convenience. Document comments in LibreOffice are common to Writer, Calc, Impress and Draw, so it is listed under the "LibreOffice" section of the Index on the right. https://help.libreoffice.org/7.4/en-US/text/shared/01/0405.html?=WRITER=UNIX -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 123167] BASIC: Pictures in buttons are not persistent in a dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=123167 raal changed: What|Removed |Added CC||eei...@inbox.ru --- Comment #7 from raal --- *** Bug 147944 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147944] A dialog control (e.g., button) does not save an icon
https://bugs.documentfoundation.org/show_bug.cgi?id=147944 raal changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||r...@post.cz Resolution|--- |DUPLICATE --- Comment #5 from raal --- *** This bug has been marked as a duplicate of bug 123167 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148287] Scrolling not possible when mouse pointer over row/column index
https://bugs.documentfoundation.org/show_bug.cgi?id=148287 raal changed: What|Removed |Added CC||r...@post.cz --- Comment #7 from raal --- Reproducible with Version: 7.5.0.0.alpha0+ / LibreOffice Community Build ID: a0bc0cc81b597aa81189355a8125753d6b873cce CPU threads: 4; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US Calc: threaded and Version 4.1.0.0.alpha0+ (Build ID: efca6f15609322f62a35619619a6d5fe5c9bd5a) Not sure it's a bug or not, but for instance a Gnumeric support this - scroll over row index. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103381] [META] Pivot table (aka Data Pilot) bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103381 Bug 103381 depends on bug 149526, which changed state. Bug 149526 Summary: Calc Pivot Table where the range includes many empty rows takes 30 minutes and 9GB of Ram before crashing https://bugs.documentfoundation.org/show_bug.cgi?id=149526 What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149526] Calc Pivot Table where the range includes many empty rows takes 30 minutes and 9GB of Ram before crashing
https://bugs.documentfoundation.org/show_bug.cgi?id=149526 raal changed: What|Removed |Added CC||r...@post.cz Resolution|--- |WORKSFORME Status|UNCONFIRMED |RESOLVED --- Comment #3 from raal --- closing per comment 2 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140071] Too long to get data when it get 'Refresh' on pivot table option
https://bugs.documentfoundation.org/show_bug.cgi?id=140071 --- Comment #8 from m.a.riosv --- Menu/Edit/Database - Properties, should give access to database connection. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150096] when I type NEGATIVE red integer it is not accepting decimal places ex: -12.00
https://bugs.documentfoundation.org/show_bug.cgi?id=150096 raal changed: What|Removed |Added CC||r...@post.cz Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO --- Comment #3 from raal --- @Taumaturgo, please see comment 2 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151349] New: very slow
https://bugs.documentfoundation.org/show_bug.cgi?id=151349 Bug ID: 151349 Summary: very slow Product: LibreOffice Version: 7.4.1.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jmmasso...@gmail.com Description: very slow to open calc document. Steps to Reproduce: 1.double clic on document 2.40 sec 3.then it open Actual Results: the document is correct Expected Results: open the doc faster Reproducible: Always User Profile Reset: Yes OpenGL enabled: Yes Additional Info: no -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143049] Crash in: ScDocument::GetPool()
https://bugs.documentfoundation.org/show_bug.cgi?id=143049 --- Comment #16 from raal --- (In reply to Colin from comment #7) > > With sheet 2 of the attached file > > Verify >Format>condional>manage displays only one contiguous range E3:E89 > D22 Enter 4 > Select and copy E24 > Paste to E22 > Modify E22 to read 01/01/2022 > Verify >Format>condional>manage displays an orphan E22 and an almost > contiguous range E23:E89;E3:E21 > Remove the orphan > Edit the range to read E3:E89 > Confirm & Exit > > I can't predict that it will crash first time for the tester but repeating > the steps AND also the earlier steps to insert a few cells in the left table > should have the (un)desired effect. No repro with Version: 7.5.0.0.alpha0+ / LibreOffice Community Build ID: a0bc0cc81b597aa81189355a8125753d6b873cce CPU threads: 4; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149055] Embedded chart no longer works properly
https://bugs.documentfoundation.org/show_bug.cgi?id=149055 raal changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO Version|unspecified |7.3.2.2 release --- Comment #10 from raal --- Looks good in Version: 7.5.0.0.alpha0+ / LibreOffice Community Build ID: a0bc0cc81b597aa81189355a8125753d6b873cce CPU threads: 4; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US Calc: threaded and Version: 7.3.6.2 / LibreOffice Community Build ID: 30(Build:2) CPU threads: 4; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: cs-CZ (cs_CZ.UTF-8); UI: cs-CZ Ubuntu package version: 1:7.3.6-0ubuntu0.22.04.1 Calc: threaded @John, please, can you retest with newer version? Thank you. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150501] Flying windows Border lines and Border lines Stil doesnt work any more in Ver 7...
https://bugs.documentfoundation.org/show_bug.cgi?id=150501 raal changed: What|Removed |Added CC||r...@post.cz --- Comment #1 from raal --- I'm sorry, I don't understand. Please can you make a video of your steps from version 6? Thank you. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151135] Print Dialog Print Preview: Row missing in print preview (and print) after changing orientation
https://bugs.documentfoundation.org/show_bug.cgi?id=151135 raal changed: What|Removed |Added Blocks||108804 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108804 [Bug 108804] [META] Print preview bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108804] [META] Print preview bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108804 raal changed: What|Removed |Added Depends on||151135 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=151135 [Bug 151135] Print Dialog Print Preview: Row missing in print preview (and print) after changing orientation -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151135] Print Dialog Print Preview: Row missing in print preview (and print) after changing orientation
https://bugs.documentfoundation.org/show_bug.cgi?id=151135 --- Comment #3 from raal --- in linux-64-7.2 it works OK, in linux-64-7.3 doesn't works change portrait->landscape in print dialog, in linux-64-7.5 change portrait->landscape in print dialog works and bug occurs. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151316] CRASH in SwTextGridPage::CharorLineChangedHdl (gen)
https://bugs.documentfoundation.org/show_bug.cgi?id=151316 Caolán McNamara changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |caol...@redhat.com |desktop.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151135] Print Dialog Print Preview: Row missing in print preview (and print) after changing orientation
https://bugs.documentfoundation.org/show_bug.cgi?id=151135 raal changed: What|Removed |Added CC||r...@post.cz Keywords||regression Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #2 from raal --- Confirm with Version: 7.5.0.0.alpha0+ / LibreOffice Community Build ID: a0bc0cc81b597aa81189355a8125753d6b873cce CPU threads: 4; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US Calc: threaded not in Version: 7.0.0.0.alpha1+ Build ID: 574c57090642347980d2395e1e183cc7b5c171ad CPU threads: 4; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150648] EAN13 function works in spreadsheet with LibreOffice 7.3 not 7.4
https://bugs.documentfoundation.org/show_bug.cgi?id=150648 --- Comment #4 from raal --- Created attachment 182836 --> https://bugs.documentfoundation.org/attachment.cgi?id=182836=edit LO 7.5 Looks correct with Version: 7.5.0.0.alpha0+ / LibreOffice Community Build ID: a0bc0cc81b597aa81189355a8125753d6b873cce CPU threads: 4; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151314] Please support e-mail client Betterbird (Thunderbird fork) for sending documents
https://bugs.documentfoundation.org/show_bug.cgi?id=151314 --- Comment #9 from Jorg K --- (In reply to Timur from comment #8) > From bug 149895: If email program is not specified in "Tools > Options > > Internet > Email", default system email program is used via xdg-email or > kde-open. So the "Tools > Options > Internet > Email" setting is respected, well, maybe in later versions, not in my ancient 6.4.7.2. > Apart from that, there's a bug of not adding attachment. Do you have a number for that? Is that for TB 102 (https://bugzilla.mozilla.org/show_bug.cgi?id=1793323)? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150768] Hang on opening and converting a DOCX file
https://bugs.documentfoundation.org/show_bug.cgi?id=150768 Michael Stahl (allotropia) changed: What|Removed |Added Regression By|Michael Stahl | -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 104450] [META] DOCX (OOXML) file opening issues
https://bugs.documentfoundation.org/show_bug.cgi?id=104450 Michael Stahl (allotropia) changed: What|Removed |Added Depends on|150768 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=150768 [Bug 150768] Hang on opening and converting a DOCX file -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 101280] [META] Layout loops
https://bugs.documentfoundation.org/show_bug.cgi?id=101280 Michael Stahl (allotropia) changed: What|Removed |Added Depends on||150768 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=150768 [Bug 150768] Hang on opening and converting a DOCX file -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150768] Hang on opening and converting a DOCX file
https://bugs.documentfoundation.org/show_bug.cgi?id=150768 Michael Stahl (allotropia) changed: What|Removed |Added Component|LibreOffice |Writer Blocks|104450 |101280 Keywords|bibisected, bisected, |bibisectRequest |filter:docx, regression | --- Comment #5 from Michael Stahl (allotropia) --- please test again with ODT file if it's really a regression Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=101280 [Bug 101280] [META] Layout loops https://bugs.documentfoundation.org/show_bug.cgi?id=104450 [Bug 104450] [META] DOCX (OOXML) file opening issues -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150768] Hang on opening and converting a DOCX file
https://bugs.documentfoundation.org/show_bug.cgi?id=150768 --- Comment #4 from Michael Stahl (allotropia) --- Created attachment 182835 --> https://bugs.documentfoundation.org/attachment.cgi?id=182835=edit file converted to ODT with recent master if i convert the attachment to ODT and then run 6.3 with --convert-to pdf i get an infinite loop as well. the identified commit only affects DOCX import, but the loop is in the layout code. => this is not really a regression from that commit -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151345] Consider adding "Move to Top" and "Move to Bottom" buttons under effects list
https://bugs.documentfoundation.org/show_bug.cgi?id=151345 --- Comment #2 from Eyal Rozenberg --- (In reply to V Stuart Foote from comment #1) > No, there is no requirement. I didn't suggest there's a requirement - it would be a convenience feature. Trade-off is a little bit more clutter vs avoiding the need to click the up or down buttons repeatedly. > The Animation listing is the sequence in which > the elements on the slide will be presented. It does not affect the > placement on the slide in any way I didn't suggest that it does. Perhaps my earlier comments were not phrased well enough? > Given that adjustments to a single slide's animations are done > incrementally--moving up by one or down by one in the sequence is common. At first, you add animations incrementally, but then when you insert a new item into a slide with animations and want to time its effects - it's not just one-up or one-down. Also, if you created your animations sequence by selecting multiple elements and adding an effect for each of them, this is useful for "max-sorting" the effect timings. I filed this bug because I find myself using this functionality relatively frequently. But of course that may not be the case for everyone. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 151345] Consider adding "Move to Top" and "Move to Bottom" buttons under effects list
https://bugs.documentfoundation.org/show_bug.cgi?id=151345 --- Comment #2 from Eyal Rozenberg --- (In reply to V Stuart Foote from comment #1) > No, there is no requirement. I didn't suggest there's a requirement - it would be a convenience feature. Trade-off is a little bit more clutter vs avoiding the need to click the up or down buttons repeatedly. > The Animation listing is the sequence in which > the elements on the slide will be presented. It does not affect the > placement on the slide in any way I didn't suggest that it does. Perhaps my earlier comments were not phrased well enough? > Given that adjustments to a single slide's animations are done > incrementally--moving up by one or down by one in the sequence is common. At first, you add animations incrementally, but then when you insert a new item into a slide with animations and want to time its effects - it's not just one-up or one-down. Also, if you created your animations sequence by selecting multiple elements and adding an effect for each of them, this is useful for "max-sorting" the effect timings. I filed this bug because I find myself using this functionality relatively frequently. But of course that may not be the case for everyone. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 143344] [META] Linux Dark Mode bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=143344 Bug 143344 depends on bug 150886, which changed state. Bug 150886 Summary: Text in Exported Writer Forms is Hidden/Light and Form dark if OS Dark mode https://bugs.documentfoundation.org/show_bug.cgi?id=150886 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103378] [META] PDF export bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103378 Bug 103378 depends on bug 150616, which changed state. Bug 150616 Summary: FILESAVE PDF Table row disappears from complex table after CLI PDF export https://bugs.documentfoundation.org/show_bug.cgi?id=150616 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150616] FILESAVE PDF Table row disappears from complex table after CLI PDF export
https://bugs.documentfoundation.org/show_bug.cgi?id=150616 Michael Stahl (allotropia) changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED Assignee|libreoffice-b...@lists.free |michael.st...@allotropia.de |desktop.org | --- Comment #8 from Michael Stahl (allotropia) --- forgot to set this to FIXED i'd rather not backport the fix to 7.3 shortly before EOL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151216] LibreOffice set cell formatting up to 40x slower in v7.3 and v7.4
https://bugs.documentfoundation.org/show_bug.cgi?id=151216 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||79045_79...@mail.ru --- Comment #5 from Roman Kuznetsov <79045_79...@mail.ru> --- Funny: 0 3 23 sec in Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 85353c42de80e7492f5c80499e18375f942c75c9 CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Vulkan; VCL: win Locale: ru-RU (ru_RU); UI: ru-RU Calc: threaded but 15 27 168 sec in Version: 7.4.0.0.alpha1+ (x64) / LibreOffice Community Build ID: f3b5cb5a17a451c9e7d9b47b5e8854c5e126801f CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win Locale: ru-RU (ru_RU); UI: ru-RU Calc: threaded I would wait to 7.4.2 release and retest it. It seems already fixed in master. Or we can search the commit if it will still not fixed in 7.4.2. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: forms/source
forms/source/richtext/richtextmodel.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit ca46afebb7dc0ec4375e995fa90edccbed6c2530 Author: Caolán McNamara AuthorDate: Tue Oct 4 16:22:51 2022 +0100 Commit: Caolán McNamara CommitDate: Tue Oct 4 21:18:15 2022 +0200 default to 'flat' instead of '3D Look' for form controls better matches what the pdf/print output will be. Change-Id: I86869024768877f8345c4a0c320eb24d48b35f13 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140947 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/forms/source/richtext/richtextmodel.cxx b/forms/source/richtext/richtextmodel.cxx index 57207e440133..c07dcb451cac 100644 --- a/forms/source/richtext/richtextmodel.cxx +++ b/forms/source/richtext/richtextmodel.cxx @@ -506,7 +506,7 @@ namespace frm break; case PROPERTY_ID_BORDER: -aDefault <<= sal_Int16(1); +aDefault <<= sal_Int16(2); break; default:
[Libreoffice-commits] core.git: forms/source include/svx sc/source sd/source svx/source sw/source toolkit/source
forms/source/component/Edit.cxx |1 forms/source/component/FormComponent.cxx | 18 ++- forms/source/inc/FormComponent.hxx |1 forms/source/inc/frm_strings.hxx |2 + forms/source/inc/property.hxx|2 - include/svx/svdmodel.hxx |2 + sc/source/core/data/drwlayer.cxx |1 sd/source/core/drawdoc.cxx |2 + svx/source/sdr/contact/viewobjectcontactofunocontrol.cxx |8 ++ svx/source/svdraw/svdmodel.cxx |1 sw/source/core/draw/drawdoc.cxx |1 toolkit/source/controls/unocontrol.cxx | 18 +++ 12 files changed, 55 insertions(+), 2 deletions(-) New commits: commit ea36e0502c0bc381577cfa1b1a7fedf0f05d1d72 Author: Caolán McNamara AuthorDate: Tue Oct 4 12:42:33 2022 +0100 Commit: Caolán McNamara CommitDate: Tue Oct 4 21:17:46 2022 +0200 tdf#150786 use a 'standard' theme for form controls i.e. ignore system theme so we get the same results on export to pdf regardless of the theme (esp dark) and don't follow the system theme when hosted with a writer/calc/impress document (do continue to use system theme for StarBasic dialogs as seen in BasicIDE) Didn't reuse 'NativeWidgetLook' for this because is currently defaults off, while we currently do use the colors derived from the system theme even when this is off, its really the NWF flag to render using the platform theming engine Change-Id: I816d7ebaf793e5eac7bd937d44c1db0371145199 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140942 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/forms/source/component/Edit.cxx b/forms/source/component/Edit.cxx index 27ea6cc9982d..580e4f3a9f0e 100644 --- a/forms/source/component/Edit.cxx +++ b/forms/source/component/Edit.cxx @@ -382,6 +382,7 @@ void OEditModel::describeAggregateProperties( Sequence< Property >& _rAggregateP RemoveProperty( _rAggregateProps, PROPERTY_NAME ); RemoveProperty( _rAggregateProps, PROPERTY_TAG ); RemoveProperty( _rAggregateProps, PROPERTY_NATIVE_LOOK ); +RemoveProperty( _rAggregateProps, PROPERTY_STANDARD_THEME ); } diff --git a/forms/source/component/FormComponent.cxx b/forms/source/component/FormComponent.cxx index 2c882145ffd1..9b5558eed5e6 100644 --- a/forms/source/component/FormComponent.cxx +++ b/forms/source/component/FormComponent.cxx @@ -496,6 +496,7 @@ OControlModel::OControlModel( ,m_nTabIndex(FRM_DEFAULT_TABINDEX) ,m_nClassId(FormComponentType::CONTROL) ,m_bNativeLook( false ) +,m_bStandardTheme( false ) ,m_bGenerateVbEvents( false ) ,m_nControlTypeinMSO(0) // 0 : default value is create from AOO ,m_nObjIDinMSO(INVALID_OBJ_ID_IN_MSO) @@ -548,6 +549,7 @@ OControlModel::OControlModel( const OControlModel* _pOriginal, const Reference< m_nTabIndex = _pOriginal->m_nTabIndex; m_nClassId = _pOriginal->m_nClassId; m_bNativeLook = _pOriginal->m_bNativeLook; +m_bStandardTheme = _pOriginal->m_bStandardTheme; m_bGenerateVbEvents = _pOriginal->m_bGenerateVbEvents; m_nControlTypeinMSO = _pOriginal->m_nControlTypeinMSO; m_nObjIDinMSO = _pOriginal->m_nObjIDinMSO; @@ -871,6 +873,9 @@ Any OControlModel::getPropertyDefaultByHandle( sal_Int32 _nHandle ) const case PROPERTY_ID_NATIVE_LOOK: aReturn <<= true; break; +case PROPERTY_ID_STANDARD_THEME: +aReturn <<= false; +break; case PROPERTY_ID_GENERATEVBAEVENTS: aReturn <<= false; break; @@ -909,6 +914,9 @@ void OControlModel::getFastPropertyValue( Any& _rValue, sal_Int32 _nHandle ) con case PROPERTY_ID_NATIVE_LOOK: _rValue <<= m_bNativeLook; break; +case PROPERTY_ID_STANDARD_THEME: +_rValue <<= m_bStandardTheme; +break; case PROPERTY_ID_GENERATEVBAEVENTS: _rValue <<= m_bGenerateVbEvents; break; @@ -946,6 +954,9 @@ sal_Bool OControlModel::convertFastPropertyValue( case PROPERTY_ID_NATIVE_LOOK: bModified = tryPropertyValue(_rConvertedValue, _rOldValue, _rValue, m_bNativeLook); break; +case PROPERTY_ID_STANDARD_THEME: +bModified = tryPropertyValue(_rConvertedValue, _rOldValue, _rValue, m_bStandardTheme); +break; case PROPERTY_ID_GENERATEVBAEVENTS: bModified = tryPropertyValue(_rConvertedValue, _rOldValue, _rValue, m_bGenerateVbEvents); break; @@ -988,6 +999,9 @@ void OControlModel::setFastPropertyValue_NoBroadcast(sal_Int32 _nHandle, const A case PROPERTY_ID_NATIVE_LOOK: OSL_VERIFY( _rValue >>= m_bNativeLook );
[Libreoffice-bugs] [Bug 151348] New: EDITING: Showing track changes moves cursor to last deleted comment
https://bugs.documentfoundation.org/show_bug.cgi?id=151348 Bug ID: 151348 Summary: EDITING: Showing track changes moves cursor to last deleted comment Product: LibreOffice Version: 7.0.4.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rubberche...@riseup.net If I create a new document, add some text, add a marginal comment or two, save it as .docx, close the LO session, start a new one and open the saved .docx again, go to Tools > Options > User Data and change the profile name, switch on track changes, and delete one of the comments inserted under the old profile name, then the comment persists (as deleted, i.e. with a cross through it; cf. https://bugs.documentfoundation.org/show_bug.cgi?id=105485, which however is marked as fixed). Moreover, if I now place the cursor in the main body of the document and toggle "show track changes" until it is on, Writer will move the cursor into from the body of the document into the deleted comment. I would expect toggling track changes to leave the cursor in the body of the document. I've found this behavior particularly unfortunate when working on long documents with multiple editors; every time I toggle "show track changes" I'm shot off to a totally different part of the document. Fwiw, I've checked this with a colleague who runs a similar setup (same Linux distro/version so probably same LO version) and they were able to reproduce. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151335] Can't find info about "Comment" in Helpfile
https://bugs.documentfoundation.org/show_bug.cgi?id=151335 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Component|Writer |Documentation CC||79045_79...@mail.ru, ||olivier.hallot@libreoffice. ||org -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 138625] FILEOPEN DOCX: The footnote/endnote number in an imported word text is not in a superscript (non-English UI only), because its formatting loaded in a new character styl
https://bugs.documentfoundation.org/show_bug.cgi?id=138625 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Status|RESOLVED|VERIFIED --- Comment #20 from Roman Kuznetsov <79045_79...@mail.ru> --- Verified the fix in Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 85353c42de80e7492f5c80499e18375f942c75c9 CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Vulkan; VCL: win Locale: ru-RU (ru_RU); UI: ru-RU Calc: threaded Thank you László! -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140650] DOCUMENTATION: Improve description on how to select a collection of shapes at once
https://bugs.documentfoundation.org/show_bug.cgi?id=140650 Dieter changed: What|Removed |Added Summary|Hard to select a collection |DOCUMENTATION: Improve |of shapes at once for |description on how to |grouping|select a collection of ||shapes at once -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140650] Hard to select a collection of shapes at once for grouping
https://bugs.documentfoundation.org/show_bug.cgi?id=140650 --- Comment #10 from Telesto --- (In reply to Dieter from comment #9) > So again I propose to change component to documentation Already done.. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140650] Hard to select a collection of shapes at once for grouping
https://bugs.documentfoundation.org/show_bug.cgi?id=140650 --- Comment #9 from Dieter --- (In reply to Telesto from comment #8) > ** I some point I started Shift+ Clicking elements (but well those elements > are not evenly distributed.. So not really an option.. For me this works very well. Help about grouping objects: https://help.libreoffice.org/7.4/en-GB/text/sdraw/guide/groups.html?=WRITER=WIN but perhaps its need to be updated. So again I propose to change component to documentation -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151342] Animation sidebar rendering cut off in a displeasing manner
https://bugs.documentfoundation.org/show_bug.cgi?id=151342 V Stuart Foote changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org Keywords||needsUXEval --- Comment #9 from V Stuart Foote --- I'll throw it on the UX-Advise pile, but it remains that having the content of each textbox or list element receiving an animation Effect *NOT* fully exposed is preferred. Only the Animation effect, and enough of the start of the text run for identification is required, the rest can be pruned or allowed to run off screen. The UI is suitable to task (organizing the Animation Effects of elements on a single slide). IMHO => NAB and WF -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 151342] Animation sidebar rendering cut off in a displeasing manner
https://bugs.documentfoundation.org/show_bug.cgi?id=151342 V Stuart Foote changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org Keywords||needsUXEval --- Comment #9 from V Stuart Foote --- I'll throw it on the UX-Advise pile, but it remains that having the content of each textbox or list element receiving an animation Effect *NOT* fully exposed is preferred. Only the Animation effect, and enough of the start of the text run for identification is required, the rest can be pruned or allowed to run off screen. The UI is suitable to task (organizing the Animation Effects of elements on a single slide). IMHO => NAB and WF -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 140650] Hard to select a collection of shapes at once for grouping
https://bugs.documentfoundation.org/show_bug.cgi?id=140650 Telesto changed: What|Removed |Added Resolution|INSUFFICIENTDATA|--- Status|RESOLVED|UNCONFIRMED --- Comment #8 from Telesto --- * I attempted to drag around the shapes (assuming those be selected). This wasn't the case. ** I some point I started Shift+ Clicking elements (but well those elements are not evenly distributed.. So not really an option.. *** Ultimate I found that select an Item and drag would work (what I actually tried was Shift drag square after clicking. Not simple drag after clicking an object. I agree that the way to group shapes should be improved. I've also searched for hlp about it, but couldn't find anything. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151345] Consider adding "Move to Top" and "Move to Bottom" buttons under effects list
https://bugs.documentfoundation.org/show_bug.cgi?id=151345 V Stuart Foote changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org, ||vstuart.fo...@utsa.edu --- Comment #1 from V Stuart Foote --- No, there is no requirement. The Animation listing is the sequence in which the elements on the slide will be presented. It does not affect the placement on the slide in any way--only the order in which each element is exposed--so not a layout tool. Given that adjustments to a single slide's animations are done incrementally--moving up by one or down by one in the sequence is common. Moving an element to be the First or the Last element exposed would be a very low percentage requirement and not worth the work it would require to establish a new UNO control to implement or the UI tweaks needed to fit it in the Effects Content panel. Leave it alone. IMHO => WF -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 151345] Consider adding "Move to Top" and "Move to Bottom" buttons under effects list
https://bugs.documentfoundation.org/show_bug.cgi?id=151345 V Stuart Foote changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org, ||vstuart.fo...@utsa.edu --- Comment #1 from V Stuart Foote --- No, there is no requirement. The Animation listing is the sequence in which the elements on the slide will be presented. It does not affect the placement on the slide in any way--only the order in which each element is exposed--so not a layout tool. Given that adjustments to a single slide's animations are done incrementally--moving up by one or down by one in the sequence is common. Moving an element to be the First or the Last element exposed would be a very low percentage requirement and not worth the work it would require to establish a new UNO control to implement or the UI tweaks needed to fit it in the Effects Content panel. Leave it alone. IMHO => WF -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 151340] ODF Validator does not accept new mimetype "text-master-template"
https://bugs.documentfoundation.org/show_bug.cgi?id=151340 --- Comment #2 from Michael Stahl (allotropia) --- there was this commit which was not merged into the 0.9 branch, in branch 0.9-ODF1.3: https://github.com/tdf/odftoolkit/commit/b07c4fd40aab18730fb9aa9c100e2095ae50d238 there was this commit which was not merged into the master branch, in branch 1.0-ODF1.3: https://github.com/tdf/odftoolkit/commit/69de3770cf0a7e0c5942e9af475d4b5b5c7ccc27 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151342] Animation sidebar rendering cut off in a displeasing manner
https://bugs.documentfoundation.org/show_bug.cgi?id=151342 --- Comment #8 from Eyal Rozenberg --- (In reply to V Stuart Foote from comment #6) > No need (undesirable) to wrap or show the full textbox content. Rather just > expose the animation effect assigned to the element which is done correctly, > even at reduced widths. Even when there are no animation effect, I think it looks bad to users when text boxes are just cut off like that. Breaks the metaphor of the sidebar - that none of it belong beyond the edge of the screen. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151342] Animation sidebar rendering cut off in a displeasing manner
https://bugs.documentfoundation.org/show_bug.cgi?id=151342 --- Comment #7 from Eyal Rozenberg --- (In reply to V Stuart Foote from comment #5) > Once you start, the animation listing panel makes more sense I'm concerned about the fact that text boxes and the list boxes end off-window, and the sidebar seems like it continues to the side of the window. > You can also set "false" the UI.Sidebar 'MinimumWidth' in Tools -> Options > -> Advanced Expert Configuration. That will allow the different decks on the > Sidebar to shrink as you like. My concern is with the default settings and most users. Should the sidebar in the case I'm describing not be either collapsed or expanded to the minimum width? When the window is created, I mean? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 151170] Need mechanism for re-centering "Slides pane" onto current slide with edit focus
https://bugs.documentfoundation.org/show_bug.cgi?id=151170 --- Comment #17 from V Stuart Foote --- (In reply to Eyal Rozenberg from comment #16) > (In reply to V Stuart Foote from comment #2) > > The Left Pane is incorrectly referred to as the 'Slide Sorter'. That > > labeling is for a specific editing "view mode" of the Impress workspace--not > > available in Draw. > > > > And the LO help even has the toggle article named "slidesorter.html" adding > > to the confusion, and that all could probably be clarified. @Olvier, Seth? > > It seems like you want to file a separate bug about this point? Sure, done as bug 151347 -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 151170] Need mechanism for re-centering "Slides pane" onto current slide with edit focus
https://bugs.documentfoundation.org/show_bug.cgi?id=151170 --- Comment #17 from V Stuart Foote --- (In reply to Eyal Rozenberg from comment #16) > (In reply to V Stuart Foote from comment #2) > > The Left Pane is incorrectly referred to as the 'Slide Sorter'. That > > labeling is for a specific editing "view mode" of the Impress workspace--not > > available in Draw. > > > > And the LO help even has the toggle article named "slidesorter.html" adding > > to the confusion, and that all could probably be clarified. @Olvier, Seth? > > It seems like you want to file a separate bug about this point? Sure, done as bug 151347 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 120200] [META] Update or correct help for features
https://bugs.documentfoundation.org/show_bug.cgi?id=120200 V Stuart Foote changed: What|Removed |Added Depends on||151347 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=151347 [Bug 151347] Incorrect use of "Slide Sorter" for the sd LEFT PANE "Slide pane" (Impress) "Page pane" (Draw) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 151170] Need mechanism for re-centering "Slides pane" onto current slide with edit focus
https://bugs.documentfoundation.org/show_bug.cgi?id=151170 V Stuart Foote changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||1347 -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 151170] Need mechanism for re-centering "Slides pane" onto current slide with edit focus
https://bugs.documentfoundation.org/show_bug.cgi?id=151170 V Stuart Foote changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||1347 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151347] Incorrect use of "Slide Sorter" for the sd LEFT PANE "Slide pane" (Impress) "Page pane" (Draw)
https://bugs.documentfoundation.org/show_bug.cgi?id=151347 V Stuart Foote changed: What|Removed |Added CC||vstuart.fo...@utsa.edu See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||1170 Blocks||120200 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=120200 [Bug 120200] [META] Update or correct help for features -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151347] New: Incorrect use of "Slide Sorter" for the sd LEFT PANE "Slide pane" (Impress) "Page pane" (Draw)
https://bugs.documentfoundation.org/show_bug.cgi?id=151347 Bug ID: 151347 Summary: Incorrect use of "Slide Sorter" for the sd LEFT PANE "Slide pane" (Impress) "Page pane" (Draw) Product: LibreOffice Version: Inherited From OOo Hardware: All OS: All Status: UNCONFIRMED Severity: trivial Priority: medium Component: Documentation Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: vstuart.fo...@utsa.edu CC: olivier.hal...@libreoffice.org Lifted from bug 151170, I gues just need some editorial magic. At the least the help article should be changed from slidesorter.html As an aside for documentation: > I never get the name of this part of the window right... do we call it the > slide sorter? The slide pane? The slide side-bar? It is the sd "LEFT PANE", with UNO cmds available to toggle it inactive. In Impress it is uno.leftPaneImpress and menu labeled 'Slide Pane' In Draw it is uno.leftPaneDraw and menu labeled 'Page Pane' But in the Impress UI it is labeled 'Slides', and in Draw UI it is labeled 'Pages' Functionally the sd Left Pane, aka "Slides pane" or "Pages pane" in the module guides documentation, can be used to manage slides/pages, e.g. add, duplicate, hide, delete, move for the listed slide/page objects. The Left Pane is incorrectly referred to as the 'Slide Sorter'. That labeling is for a specific editing "view mode" of the Impress workspace--not available in Draw. And the LO help even has the toggle article named "slidesorter.html" adding to the confusion, and that all could probably be clarified. @Olvier, Seth? <\clip> -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: editeng/source i18nlangtag/qa i18nlangtag/source include/i18nlangtag
editeng/source/misc/acorrcfg.cxx | 16
i18nlangtag/qa/cppunit/test_languagetag.cxx|2 ++
i18nlangtag/source/isolang/isolang.cxx |2 ++
i18nlangtag/source/isolang/mslangid.cxx|6 +++---
i18nlangtag/source/languagetag/languagetag.cxx |6 +++---
include/i18nlangtag/mslangid.hxx |5 +++--
6 files changed, 21 insertions(+), 16 deletions(-)
New commits:
commit 437abb3abbc506c1e20c6fec8e574abfe3487842
Author: Eike Rathke
AuthorDate: Tue Oct 4 11:14:38 2022 +0200
Commit: Eike Rathke
CommitDate: Tue Oct 4 19:15:45 2022 +0200
Check acor_langtag for language-script fallback instead of only language
A tag with script could be added for which we don't have locale
data but for the same language in another script. Do not fall back
to that.
With that the share/autocorr/acor_zh-{CN,TW}.dat files created
additional Asian language listbox entries
"Chinese (Simplified, China) {zh-Hans-CN}"
"Chinese (Traditional, Taiwan) {zh-Hant-TW}"
because those are the canonicalized language tags.
Prefer the known legacy zh-CN and zh-TW tags instead.
Could also had happened with any document import.
Which again revealed a flaw in the handling of mapping overrides
where converting from a LanguageType LCID to Locale could yield a
different mapping than from BCP47 to LCID, which in the case of
a fallback for locale data lead to odd side effects.
Change-Id: I1e2aaa8e9f99b6b3bc2c9a661215cb00bddd33d6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140939
Reviewed-by: Eike Rathke
Tested-by: Jenkins
diff --git a/editeng/source/misc/acorrcfg.cxx b/editeng/source/misc/acorrcfg.cxx
index 5806179bc5f0..53a43cff3f22 100644
--- a/editeng/source/misc/acorrcfg.cxx
+++ b/editeng/source/misc/acorrcfg.cxx
@@ -75,20 +75,20 @@ static void scanAutoCorrectDirForLanguageTags( const
OUString& rURL )
if (SvtLanguageTable::HasLanguageType(
aLanguageTag.getLanguageType()))
continue;
-// Insert language-only tags only if there is no known
-// matching fallback locale, otherwise we'd end up with
-// unwanted entries where a language autocorrection
-// file covers several locales. We do know a few
-// art-x-... though so exclude those and any other
-// private-use tag (which should not fallback, but
-// avoid).
+// Insert language(-script)-only tags only if there is
+// no known matching fallback locale, otherwise we'd
+// end up with unwanted entries where a language
+// autocorrection file covers several locales. We do
+// know a few art-x-... though so exclude those and any
+// other private-use tag (which should not fallback,
+// but avoid).
if (aLanguageTag.getCountry().isEmpty()
&& LanguageTag::isValidBcp47( aCanonicalized,
nullptr,
LanguageTag::PrivateUse::DISALLOW))
{
LanguageTag aFallback( aLanguageTag);
aFallback.makeFallback();
-if (aFallback.getLanguage() ==
aLanguageTag.getLanguage())
+if (aFallback.getLanguageAndScript() ==
aLanguageTag.getLanguageAndScript())
continue;
}
diff --git a/i18nlangtag/qa/cppunit/test_languagetag.cxx
b/i18nlangtag/qa/cppunit/test_languagetag.cxx
index 4a211012e80d..f7864d6104fd 100644
--- a/i18nlangtag/qa/cppunit/test_languagetag.cxx
+++ b/i18nlangtag/qa/cppunit/test_languagetag.cxx
@@ -753,6 +753,8 @@ bool checkMapping( std::u16string_view rStr1,
std::u16string_view rStr2 )
if (rStr1 == u"kw-UK" ) return rStr2 == u"kw-GB";
if (rStr1 == u"oc-FR" ) return rStr2 == u"oc-FR-lengadoc";
if (rStr1 == u"oc-ES" ) return rStr2 == u"oc-ES-aranes";
+if (rStr1 == u"zh-Hans-CN" ) return rStr2 == u"zh-CN";
+if (rStr1 == u"zh-Hant-TW" ) return rStr2 == u"zh-TW";
return rStr1 == rStr2;
}
diff --git a/i18nlangtag/source/isolang/isolang.cxx
b/i18nlangtag/source/isolang/isolang.cxx
index d20014e67f4b..4287fe247cb4 100644
--- a/i18nlangtag/source/isolang/isolang.cxx
+++ b/i18nlangtag/source/isolang/isolang.cxx
@@ -754,6 +754,8 @@ IsoLanguageScriptCountryEntry const
aImplIsoLangScriptEntries[] =
{ LANGUAGE_BOSNIAN_LATIN_BOSNIA_HERZEGOVINA,"bs-Latn", "BA", kSAME },
// MS, though Latn is suppress-script
{ LANGUAGE_BOSNIAN_LATIN_LSO, "bs-Latn", "" ,
LANGUAGE_BOSNIAN_LSO }, // MS,
[Libreoffice-bugs] [Bug 140650] Hard to select a collection of shapes at once for grouping
https://bugs.documentfoundation.org/show_bug.cgi?id=140650 Olivier Hallot changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|UNCONFIRMED |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151283] LO Calc hangs when try to open XLS file
https://bugs.documentfoundation.org/show_bug.cgi?id=151283 --- Comment #5 from Noel Grandin --- fix here: https://gerrit.libreoffice.org/c/core/+/140949 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151341] Slow macOS install caused by bzip2 dmg
https://bugs.documentfoundation.org/show_bug.cgi?id=151341 Alex Thurgood changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #1 from Alex Thurgood --- Confirming. Anecdotally, I see the problem as having actually worsened over time and through the release versions of LibreOffice. If you use the release from the AppStore, you don't actually see all this, but you still have to sit through the download. -- You are receiving this mail because: You are the assignee for the bug.
Nalini Prasad Dash License Statement
All of my past & future contributions to LibreOffice may be licensed under the MPLv2/LGPLv3+ dual license.
[Libreoffice-bugs] [Bug 151342] Animation sidebar rendering cut off in a displeasing manner
https://bugs.documentfoundation.org/show_bug.cgi?id=151342 V Stuart Foote changed: What|Removed |Added CC||vstuart.fo...@utsa.edu --- Comment #6 from V Stuart Foote --- Created attachment 182834 --> https://bugs.documentfoundation.org/attachment.cgi?id=182834=edit the Impress Sidebar Animation deck for a slide with elements assigned animation No need (undesirable) to wrap or show the full textbox content. Rather just expose the animation effect assigned to the element which is done correctly, even at reduced widths. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151342] Animation sidebar rendering cut off in a displeasing manner
https://bugs.documentfoundation.org/show_bug.cgi?id=151342 --- Comment #5 from V Stuart Foote --- The Animation listing panel in attachment is empty--so just shows the starting "hint". You have yet to select an element on current slide, and apply an animation effect to it. Once you start, the animation listing panel makes more sense and does not need to be full width of the textbox content, or allow it to wrap as single line keeps the outline/sequence intelligible. IMHO => NAB (In reply to Eyal Rozenberg from comment #3) > Getting the same result with kf5. > > However - when I press the width adjustment handle, the sidebar snaps to its > minimum legitimate size and won't let me reduce the size to what it just was > (which is a good thing I suppose). You can also set "false" the UI.Sidebar 'MinimumWidth' in Tools -> Options -> Advanced Expert Configuration. That will allow the different decks on the Sidebar to shrink as you like. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 113136] [META] Find & Replace Dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=113136 Eyal Rozenberg changed: What|Removed |Added Depends on||151346 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=151346 [Bug 151346] Support searching current slide only -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151346] Support searching current slide only
https://bugs.documentfoundation.org/show_bug.cgi?id=151346 Eyal Rozenberg changed: What|Removed |Added Blocks||113136 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=113136 [Bug 113136] [META] Find & Replace Dialog -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151346] Support searching current slide only
https://bugs.documentfoundation.org/show_bug.cgi?id=151346 Eyal Rozenberg changed: What|Removed |Added Keywords||needsUXEval -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151346] New: Support searching current slide only
https://bugs.documentfoundation.org/show_bug.cgi?id=151346 Bug ID: 151346 Summary: Support searching current slide only Product: LibreOffice Version: 7.5.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: eyalr...@gmx.com In Impress' Find-Replace dialog, one can search either the whole presentation or the current selection. This is good, but - one also needs to be able to search the current slide. So, I suggest the "current selection only" toggle be replaced with a three-value field, e.g.: Scope: [Presentation V] which expands to present the three options "Presentation", "Slide" and "Selection" (or "Current Slide" and "Current Selection"). -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151332] odt from LibreOffice are not opened correctly by MS Office.
https://bugs.documentfoundation.org/show_bug.cgi?id=151332 --- Comment #1 from Eike Rathke --- And why would that be a LibreOffice bug if MS-Office refuses to open it? IIRC MS-Office implements proper ODF only since 2013 (or 2016? I don't exactly remember), AFAIK 2007 does not support ODF at all and 2010 only partly for an old ODF version. Maybe Textmaker and OnlyOffice still write those old versions. You could try to set (under Tools -> Options -> Load/Save -> General) the ODF format version to 1.2 or even 1.0/1.1 for MS-Office 2010, but that would restrict the set of stored features to a minimum you'd probably not be satisfied with. Rather use export to OOXML .docx if you want to pass on documents to old MS-Office versions, but keep storing your working copy in .odt ODF 1.3 extended for all features. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151344] Firebird LIST function (aka GROUP_CONCAT) gives #NA when linked to sheet
https://bugs.documentfoundation.org/show_bug.cgi?id=151344 --- Comment #1 from Andreas Säger --- P.S. I get the correct strings into the sheet when I right-click>Copy the top-left corner in the data source window's record set and paste into sheet. However, this gives a copy instead of a link. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103437] [META] Animation deck/tab of the sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=103437 Eyal Rozenberg changed: What|Removed |Added Depends on||151345 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=151345 [Bug 151345] Consider adding "Move to Top" and "Move to Bottom" buttons under effects list -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151345] Consider adding "Move to Top" and "Move to Bottom" buttons under effects list
https://bugs.documentfoundation.org/show_bug.cgi?id=151345 Eyal Rozenberg changed: What|Removed |Added Keywords||needsUXEval Blocks||103437 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103437 [Bug 103437] [META] Animation deck/tab of the sidebar -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151345] New: Consider adding "Move to Top" and "Move to Bottom" buttons under effects list
https://bugs.documentfoundation.org/show_bug.cgi?id=151345 Bug ID: 151345 Summary: Consider adding "Move to Top" and "Move to Bottom" buttons under effects list Product: LibreOffice Version: 7.5.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: eyalr...@gmx.com The animation effects list in the animation sidebar is followed by a row with four buttons: Add, remove, move up, move down. I suggest that buttons be added for "move to top" and "move to bottom". In terms of real-estate, it seems there is enough horizontal space for them. The icons would be pretty easy to make to - up and down arrows like for "Move Up" and "Move Down", with bounding lines above and below respectively. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151344] New: Firebird LIST function (aka GROUP_CONCAT) gives #NA when linked to sheet
https://bugs.documentfoundation.org/show_bug.cgi?id=151344 Bug ID: 151344 Summary: Firebird LIST function (aka GROUP_CONCAT) gives #NA when linked to sheet Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Base Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ville...@t-online.de Created attachment 182833 --> https://bugs.documentfoundation.org/attachment.cgi?id=182833=edit Embedded Firebird, no Macros Register the attached database. Drag queries "qGroup_T_List_P" and "qGroup_P_List_T" into the sheet. The concatenated field gets #NA! errors instead of strings. An ordinary aggregation query with Count, Sum, Min, Max etc. works as expected. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'feature/cib_contract57d' - sw/qa sw/source
sw/qa/extras/layout/data/in_056132_mod.odt |binary
sw/qa/extras/layout/layout.cxx | 49 +
sw/source/core/layout/calcmove.cxx |7
3 files changed, 49 insertions(+), 7 deletions(-)
New commits:
commit d69b8f711f06d24994b43161fe034d742b31788a
Author: Michael Stahl
AuthorDate: Wed Sep 21 18:33:43 2022 +0200
Commit: Michael Stahl
CommitDate: Tue Oct 4 17:56:01 2022 +0200
tdf#150616 sw: fix bad 0 height of SwTextFrame in table cell
The bugdoc has a text frame 42 immediately following a section which
contains a nested table, both inside a table cell 29.
The problem is that with soffice --convert-to pdf, the height of frame
42 ends up as 0, after a single layout action; this does not happen when
loading it from UI.
When the frame 42 is formatted, it calculates the needed height, and
grows, but in SwTextFrame::AdjustFrame() it doesn't fit into its upper
cell frame with a negative nRstHeight at this point, and the text frame
is reduced to height 0.
The odd code in SwContentFrame::MakeAll() exists unchanged since CVS
initial import and is poorly motivated. It is highly suspicious that it
simply grows the upper frame, without invalidating the size of the
current one (which was already shrunk), and/or clearing the
m_bUndersized flag.
If this code is removed, on formatting the next frame 43, it goes up and
formats the cell frame, which grows and at the same time importantly
invalidates the text frame 42, so it will be formatted again and full
height.
At the point when the frame 42 was formatted, its upper cell frame was
size-invalid, so it looks like that will be formatted eventually in any
case and then invalidate 42.
(regression from commit e7874c936dd1ff9b3423eb7477cbee2494535176
but unclear why)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140355
Tested-by: Jenkins
Reviewed-by: Michael Stahl
(cherry picked from commit 3acd80a030707b3c4795c0f828f953ac0ae24d97)
Change-Id: I1ac0999a8fda39f7717bc183a10e3b513fbb8911
diff --git a/sw/qa/extras/layout/data/in_056132_mod.odt
b/sw/qa/extras/layout/data/in_056132_mod.odt
new file mode 100644
index ..548401063bdd
Binary files /dev/null and b/sw/qa/extras/layout/data/in_056132_mod.odt differ
diff --git a/sw/qa/extras/layout/layout.cxx b/sw/qa/extras/layout/layout.cxx
index de540b8e4834..9747090b6581 100644
--- a/sw/qa/extras/layout/layout.cxx
+++ b/sw/qa/extras/layout/layout.cxx
@@ -3189,6 +3189,55 @@ CPPUNIT_TEST_FIXTURE(SwLayoutWriter,
testTdf122607_regression)
aTempFile.EnableKillingFile();
}
+CPPUNIT_TEST_FIXTURE(SwLayoutWriter, TestTdf150616)
+{
+discardDumpedLayout();
+if (mxComponent.is())
+mxComponent->dispose();
+
+OUString const pName("in_056132_mod.odt");
+
+OUString const url(m_directories.getURLFromSrc(DATA_DIRECTORY) + pName);
+
+// note: must set Hidden property, so that
SfxFrameViewWindow_Impl::Resize()
+// does *not* forward initial VCL Window Resize and thereby triggers a
+// layout which does not happen on soffice --convert-to pdf.
+std::vector aFilterOptions = {
+{ beans::PropertyValue("Hidden", -1, uno::Any(true),
beans::PropertyState_DIRECT_VALUE) },
+};
+
+std::cout << pName << ":\n";
+
+// inline the loading because currently properties can't be passed...
+mxComponent = loadFromDesktop(url, "com.sun.star.text.TextDocument",
+
comphelper::containerToSequence(aFilterOptions));
+uno::Sequence
props(comphelper::InitPropertySequence({
+{ "FilterName", uno::Any(OUString("writer_pdf_Export")) },
+}));
+utl::TempFile aTempFile;
+uno::Reference xStorable(mxComponent, uno::UNO_QUERY);
+xStorable->storeToURL(aTempFile.GetURL(), props);
+
+xmlDocPtr pXmlDoc = parseLayoutDump();
+CPPUNIT_ASSERT(pXmlDoc);
+
+// this one was 0 height
+assertXPath(pXmlDoc,
"/root/page[1]/body/tab[3]/row[2]/cell[2]/txt[2]/LineBreak", "Line",
+"Important information here!");
+assertXPath(pXmlDoc,
"/root/page[1]/body/tab[3]/row[2]/cell[2]/txt[2]/infos/bounds", "height",
+"253");
+assertXPath(pXmlDoc,
"/root/page[1]/body/tab[3]/row[2]/cell[2]/txt[2]/infos/bounds", "top",
+"7925");
+assertXPath(pXmlDoc,
"/root/page[1]/body/tab[3]/row[2]/cell[2]/txt[3]/LineBreak", "Line",
+"xxx 111 ");
+assertXPath(pXmlDoc,
"/root/page[1]/body/tab[3]/row[2]/cell[2]/txt[3]/infos/bounds", "height",
+"697");
+assertXPath(pXmlDoc,
"/root/page[1]/body/tab[3]/row[2]/cell[2]/txt[3]/infos/bounds", "top",
+"8178");
+
+aTempFile.EnableKillingFile();
+}
+
CPPUNIT_TEST_FIXTURE(SwLayoutWriter, testBtlrCell)
{
SwDoc* pDoc = createDoc("btlr-cell.odt");
diff --git
