[Libreoffice-bugs] [Bug 151477] Writer crashes when using Find/Replace dialog with japanese character.
https://bugs.documentfoundation.org/show_bug.cgi?id=151477 --- Comment #1 from yuri.musashi.miwa.tam...@gmail.com --- Created attachment 182986 --> https://bugs.documentfoundation.org/attachment.cgi?id=182986=edit screenshot -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151477] New: Writer crashes when using Find/Replace dialog with japanese character.
https://bugs.documentfoundation.org/show_bug.cgi?id=151477 Bug ID: 151477 Summary: Writer crashes when using Find/Replace dialog with japanese character. Product: LibreOffice Version: 7.3.6.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: yuri.musashi.miwa.tam...@gmail.com Description: Writer crashes when using Find/Replace dialog with japanese character. Steps to Reproduce: 1. New Writer document 2. Type one japanese katakana character with dakuten or handakuten (e.g. ガ) 3. Open Find and Replace dialog (Ctrl+H) 4. Type same as in step 2 in the Find textbox 5. Uncheck "Match character width" if checked 6. Click "Find Next" several times Actual Results: Crash or freeze Expected Results: No crash Reproducible: Always User Profile Reset: Yes Additional Info: Version: 7.3.6.2 (x86) / LibreOffice Community Build ID: c28ca90fd6e1a19e189fc16c05f8f8924961e12e CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: ja-JP (ja_JP); UI: en-US Calc: threaded This bug is also in 7.4.1 7.2.7 works well -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-qa] Live streaming LibreOffice bug triaging (week 41)
I will be live streaming a 1 hour LibreOffice bug triaging session in the Jitsi room https://jitsi.documentfoundation.org/ilmaritriages on Thu, 13 October 2022 at 10:00 UTC (day) Anyone is welcome to interrupt me during the session and ask questions about the process or request me to test something specific. Ilmari
[Libreoffice-bugs] [Bug 151476] mu faculty
https://bugs.documentfoundation.org/show_bug.cgi?id=151476 naazimshaikh0...@gmail.com changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151476] New: mu faculty
https://bugs.documentfoundation.org/show_bug.cgi?id=151476 Bug ID: 151476 Summary: mu faculty Product: LibreOffice Version: 4.0.3.3 release Hardware: All URL: http://mu.in OS: Windows (All) Status: UNCONFIRMED Keywords: patch Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: naazimshaikh0...@gmail.com Created attachment 182985 --> https://bugs.documentfoundation.org/attachment.cgi?id=182985=edit image of bug error in website load... -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142446] In folding outlines, enable specifying, document-wide, the level to which text should be collapsed.
https://bugs.documentfoundation.org/show_bug.cgi?id=142446 --- Comment #7 from j.a.sw...@gmail.com --- Well, first we need to make sure we all have the same understanding of what the function is supposed to do. So let’s check. First: I think we agree about what the existing UNO function is supposed to do (“Show / Hide content below”). So that only leaves. . . Second: “▪ Hide all content below level [X].” This is my understanding of what we want to have happen: 1. As shown in the demo, the user clicks the context-menu option now labeled “"Fold All Content Of Outline Level.” 2. Again as in the demo, a dialogue appears, offering the user the chance to specify any level, 0-10. 3. The user specifies a level – let’s say “3.” 4. Throughout the entire document, all the subheads for levels 3 and above (1, 2, and 3) will be visible. And – again, throughout-- the subheads for levels 4 and below (5, 6, 7. . .) will be hidden. Now, thinking further: We need to decide what will happen with content that doesn’t *have* a level. Beneath a subhead we might have some text, a chart, or what have you. And this, from what I understand, is all “no-level content.” Before, I was thinking that when we show a subhead we should show the content beneath it. But on further thought I think a better behavior would be to hide all such content in the document and just show the subheads, to the level specified. So when I specify a level—1, 2, 3, or whatever—all content other than subheads, throughout the document, is hidden. Then all I see is an outline of subheads, at whatever depth I specify. (And wherever I want to see underlying content, I can show it, using the already-existing UNO command.) This approach would give a clean outline to look at. It’s simple and intuitive. And it’s what users migrating to LO from elsewhere may already be used to. So that seems the best approach me. How does it seem to you? Also, the folks at Redmond (bless their profit-seeking hearts) have assigned to the command an eminently simple label: “Show Level” (followed by a choice box). Brilliant PS: Jim Raykowski wrote: >'...to level' gives me the impression all outline content currently folded >should be made visible/unfolded before the new fold to level is applied. As mentioned above, I suggest we hide *all* content – everything apart from subheads. and >As the patch stands now, the level specified does not affect outline content >currently folded. Understood. Again, I suggest that all non-subhead content be folded. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: extras/CustomTarget_tplwizard.mk
extras/CustomTarget_tplwizard.mk |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 575ff25cc338a35821e9dcea2d77ad6e85aa1407 Author: Andrea Gelmini AuthorDate: Tue Oct 11 22:18:38 2022 +0200 Commit: Julien Nabet CommitDate: Wed Oct 12 06:45:23 2022 +0200 Fix typo Change-Id: I4d8dbdf6752ec06f1a7047a89776d719d15742b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141240 Tested-by: Julien Nabet Reviewed-by: Julien Nabet diff --git a/extras/CustomTarget_tplwizard.mk b/extras/CustomTarget_tplwizard.mk index a44de417a436..5d73663ed423 100644 --- a/extras/CustomTarget_tplwizard.mk +++ b/extras/CustomTarget_tplwizard.mk @@ -10,7 +10,7 @@ $(eval $(call gb_CustomTarget_CustomTarget,extras/source/templates/wizard)) # mimetype, content.xml, settings.xml, styles.xml, META-INF/manifest.xml and -# Thumbnails/thumbnail.png files are automaticaly added for each template +# Thumbnails/thumbnail.png files are automatically added for each template # list of meta.xml files (one per template) + other files (manifest.rdf, pictures...) extras_WIZARD_XMLFILES := \ agenda/10grey/meta.xml \
[Libreoffice-bugs] [Bug 151475] Libre Office Calc Fails to auto calc cells after adding new column
https://bugs.documentfoundation.org/show_bug.cgi?id=151475 --- Comment #1 from Trey --- Created attachment 182984 --> https://bugs.documentfoundation.org/attachment.cgi?id=182984=edit The bug is in column V -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151475] New: Libre Office Calc Fails to auto calc cells after adding new column
https://bugs.documentfoundation.org/show_bug.cgi?id=151475 Bug ID: 151475 Summary: Libre Office Calc Fails to auto calc cells after adding new column Product: LibreOffice Version: 7.3.0.3 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: trey.bea...@yahoo.com Description: I have a finance spreadsheet that I use to manage my personal finances. All data cells are formatted as numbers. Each column represents a paycheck and starts with a total row followed by category rows and finally a total expense row and net row. The first row and each category row are set manually, but the total expense row should be calculated by the SUM of all category cells in that column, and the net row should be that column's total - total expense (e.g. A4-A24). I needed to insert a new column for September, so I did and copied my formatting and equations from the previous column. Unfortunately, the autocalc feature does not work on this new column. When I change the values of the manually entered cells (V4 through V23) the cells that reference them do not update. Steps to Reproduce: 1. Create table with dummy data formatted as numbers and a row at the bottom to sum the data above 2. insert a new column 3.Copy function over to new column and change data in the new column's cells Actual Results: The function cells did not register changes to the cells the referenced. Expected Results: The autocalc feature should have automatically updated my SUM cell to reflect changes to my data Reproducible: Didn't try User Profile Reset: No Additional Info: I tried disabling and re-enabling autocalc for all related cells. It did not work. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151474] Allow formatting footnotes in columns or separated by spaces
https://bugs.documentfoundation.org/show_bug.cgi?id=151474 --- Comment #2 from Seán Ó Séaghdha --- Created attachment 182983 --> https://bugs.documentfoundation.org/attachment.cgi?id=182983=edit Example: part of same document formatted in Writer Combining facing pages, but wasting a lot of space -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151474] Allow formatting footnotes in columns or separated by spaces
https://bugs.documentfoundation.org/show_bug.cgi?id=151474 --- Comment #1 from Seán Ó Séaghdha --- Created attachment 182982 --> https://bugs.documentfoundation.org/attachment.cgi?id=182982=edit Example: critical edition of fragment of Sanas Cormac Spaced footnotes -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151474] New: Allow formatting footnotes in columns or separated by spaces
https://bugs.documentfoundation.org/show_bug.cgi?id=151474 Bug ID: 151474 Summary: Allow formatting footnotes in columns or separated by spaces Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: sean.an...@gmail.com Description: It’s extremely common in critical editions of historical documents & manuscripts to have lots of short footnotes showing textual variations. Sometimes these might be one word plus a one-letter identifier for a manuscript. It’s a huge waste of space to format these all on separate lines and the ratio of text space to footnote space quickly becomes unworkable in Writer. Actual Results: Writer becomes impractical Expected Results: Writer should allow standard printing practices Reproducible: Always User Profile Reset: No Additional Info: The footnote area should be a distinct object/section that can be formatted, e.g. into columns. Footnotes should not be forced to paragraphs, but equivalent to s that could be floated with padding. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 104597] RTL script text runs are reversed on PDF import, PDFIProcessor::mirrorString misbehaving
https://bugs.documentfoundation.org/show_bug.cgi?id=104597 --- Comment #80 from Kevin Suo --- Created attachment 182981 --> https://bugs.documentfoundation.org/attachment.cgi?id=182981=edit output.xml xml output of unit test testTdf104597_textrun. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148043] Non-functioning 'check updates' panel displays immediately after LibreOffice is updated
https://bugs.documentfoundation.org/show_bug.cgi?id=148043 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142617] FILEOPEN PPTX First line indent and hanging indent incorrectly imported in bulleted paragraphs
https://bugs.documentfoundation.org/show_bug.cgi?id=142617 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151200] LibreOffice freezes when opening the SAVE dialog in a Text Document in Mac
https://bugs.documentfoundation.org/show_bug.cgi?id=151200 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147984] Crash in: SwNodeIndex::SwNodeIndex(SwNodeIndex const &, o3tl::strong_int)
https://bugs.documentfoundation.org/show_bug.cgi?id=147984 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147984] Crash in: SwNodeIndex::SwNodeIndex(SwNodeIndex const &, o3tl::strong_int)
https://bugs.documentfoundation.org/show_bug.cgi?id=147984 --- Comment #3 from QA Administrators --- Dear Eigil Wiwe, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148452] In Writer, selecting text turns on superscript mode
https://bugs.documentfoundation.org/show_bug.cgi?id=148452 --- Comment #2 from QA Administrators --- Dear Rike Carmack, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142066] Writer crashes if attempt to open insert special characters
https://bugs.documentfoundation.org/show_bug.cgi?id=142066 --- Comment #3 from QA Administrators --- Dear Kris Roberts, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148278] LibreOffice Writer does not retain IgnoreAllList beween editing sessions/
https://bugs.documentfoundation.org/show_bug.cgi?id=148278 --- Comment #2 from QA Administrators --- Dear hlavac, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142013] It claims that a previously opened file does not exist.
https://bugs.documentfoundation.org/show_bug.cgi?id=142013 --- Comment #3 from QA Administrators --- Dear Attila Pogány, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141741] Memory usage still 448 MB after closing all documents
https://bugs.documentfoundation.org/show_bug.cgi?id=141741 --- Comment #4 from QA Administrators --- Dear Telesto, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141734] Multiple Errors. OpenOffice not responding Strict XML docx document recovery review track changes
https://bugs.documentfoundation.org/show_bug.cgi?id=141734 --- Comment #3 from QA Administrators --- Dear Shane, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 131932] Using OFFSET function makes Calc open file with changes to save although not edited
https://bugs.documentfoundation.org/show_bug.cgi?id=131932 --- Comment #11 from QA Administrators --- Dear tom, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141597] Since some days when I close the last file of any LibreOffice application using X in the top right corner libreOffice does not respond any more
https://bugs.documentfoundation.org/show_bug.cgi?id=141597 --- Comment #2 from QA Administrators --- Dear Piero, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 107230] File property "Save preview image with this document" not restored from disk (see comment 1)
https://bugs.documentfoundation.org/show_bug.cgi?id=107230 --- Comment #8 from QA Administrators --- Dear sebalis, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151473] Draw PDF import: ASCII brackets (e.g. (), [] etc) are reversed when the paragraph is RTL
https://bugs.documentfoundation.org/show_bug.cgi?id=151473 Kevin Suo changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=10 ||4597 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 104597] RTL script text runs are reversed on PDF import, PDFIProcessor::mirrorString misbehaving
https://bugs.documentfoundation.org/show_bug.cgi?id=104597 Kevin Suo changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||1473 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151473] New: Draw PDF import: ASCII brackets (e.g. (), [] etc) are reversed when the paragraph is RTL
https://bugs.documentfoundation.org/show_bug.cgi?id=151473 Bug ID: 151473 Summary: Draw PDF import: ASCII brackets (e.g. (), [] etc) are reversed when the paragraph is RTL Product: LibreOffice Version: 7.3.6.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Draw Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: suokunl...@126.com Steps to Reproduce: 1. Export attachment 182980 to PDF (which is identical to the unit test file in sdext/source/pdfimport/test/testdocs/tdf104597_textrun.pdf as added in https://gerrit.libreoffice.org/c/core/+/141231) 2. Open the PDF in Draw. Current Result: The 2nd paragraph shows as: ")ABC) DEF ]..." Expected Result: "(ABC) DEF [..." Further information: When open the pdf with pdf reader, if you copy paste the text the brackets would also be reversed. But anyway it shows fine on the UI of the PDF reader. Reproduced in 7.6.2, also in 7.4.1.2, also on master with the change in https://gerrit.libreoffice.org/c/core/+/141231 (which is for the fix of bug 104597). As a result, this is not a regression caused by that change. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 104597] RTL script text runs are reversed on PDF import, PDFIProcessor::mirrorString misbehaving
https://bugs.documentfoundation.org/show_bug.cgi?id=104597 --- Comment #79 from Kevin Suo --- Created attachment 182980 --> https://bugs.documentfoundation.org/attachment.cgi?id=182980=edit tdf104597_textrun.odt I upload the odt file (used to generate the sdext/source/pdfimport/test/testdocs/tdf104597_textrun.pdf) here for the record, so that someone, when revising the unit test "testTdf104597_textrun", can regenerate the PDF file using this ODT. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151464] The find function doesn't distinguish between the vowels in នាម់ and នើម
https://bugs.documentfoundation.org/show_bug.cgi?id=151464 V Stuart Foote changed: What|Removed |Added CC||vstuart.fo...@utsa.edu --- Comment #2 from V Stuart Foote --- Confirm with the STR when using the Find bar, i.e. by +F launch. However, the Find bar +F does not set the 'diacritic sensitive' mode for searches. Using the full "Find and Replace" dialog +H where 'diacritic sensitive' is set by default in the "Other options" section--it in general works best for CTL and CJK search use. IHMO => NAB as the Khmer script's vowel signs are handled similar to combining diacritics requiring the use of the more functional Find and Replace dialog. =-testing-= Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community Build ID: a7683a16e98def4198e1f74a93fecdaacbf639e7 CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded using Windows "Leelawadee UI" font for the Khmer script of the sample text. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150682] bad shortcut in french langage
https://bugs.documentfoundation.org/show_bug.cgi?id=150682 --- Comment #8 from Aron Budea --- The only idea I can think of that can be implemented quickly is to switch to a different combination: Alt+Shift+E. https://gerrit.libreoffice.org/c/core/+/141227 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - config_host/config_buildconfig.h.in configure.ac desktop/source
config_host/config_buildconfig.h.in |8 configure.ac|3 +++ desktop/source/lib/init.cxx |4 +++- 3 files changed, 14 insertions(+), 1 deletion(-) New commits: commit 4eab641ae38d3d91c6beb50ddbb77b1fa7ec0be2 Author: Andras Timar AuthorDate: Mon Oct 10 23:38:56 2022 +0200 Commit: Aron Budea CommitDate: Wed Oct 12 02:02:45 2022 +0200 Send build config (configure options) in LOKit version info JSON Change-Id: I29a6cca467e5f1e9ba59528edefbb397ceb81780 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141197 Tested-by: Jenkins CollaboraOffice Reviewed-by: Aron Budea diff --git a/config_host/config_buildconfig.h.in b/config_host/config_buildconfig.h.in new file mode 100644 index ..0c93d6e02f84 --- /dev/null +++ b/config_host/config_buildconfig.h.in @@ -0,0 +1,8 @@ +/* Options passed to configure script */ + +#ifndef CONFIG_BUILDCONFIG_H +#define CONFIG_BUILDCONFIG_H + +#define BUILDCONFIG "" + +#endif diff --git a/configure.ac b/configure.ac index 7b855a5e89a3..65126c1caee5 100644 --- a/configure.ac +++ b/configure.ac @@ -463,6 +463,8 @@ AC_DEFINE_UNQUOTED(LIBO_VERSION_PATCH,$LIBO_VERSION_PATCH) LIBO_THIS_YEAR=`date +%Y` AC_DEFINE_UNQUOTED(LIBO_THIS_YEAR,$LIBO_THIS_YEAR) +AC_DEFINE_UNQUOTED([BUILDCONFIG],[["$ac_configure_args"]],[Options passed to configure script]) + dnl === dnl Product version dnl === @@ -14706,6 +14708,7 @@ AC_CONFIG_FILES([config_host.mk instsetoo_native/util/openoffice.lst sysui/desktop/macosx/Info.plist vs-code-template.code-workspace:.vscode/vs-code-template.code-workspace.in]) +AC_CONFIG_HEADERS([config_host/config_buildconfig.h]) AC_CONFIG_HEADERS([config_host/config_buildid.h]) AC_CONFIG_HEADERS([config_host/config_box2d.h]) AC_CONFIG_HEADERS([config_host/config_clang.h]) diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx index 4eed88331948..559c8fe9cd1b 100644 --- a/desktop/source/lib/init.cxx +++ b/desktop/source/lib/init.cxx @@ -7,6 +7,7 @@ * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ +#include #include #include @@ -6504,7 +6505,8 @@ static char* lo_getVersionInfo(SAL_UNUSED_PARAMETER LibreOfficeKit* /*pThis*/) "\"ProductName\": \"%PRODUCTNAME\", " "\"ProductVersion\": \"%PRODUCTVERSION\", " "\"ProductExtension\": \"%PRODUCTEXTENSION\", " -"\"BuildId\": \"%BUILDID\" " +"\"BuildId\": \"%BUILDID\", " +"\"BuildConfig\": \"" BUILDCONFIG "\" " "}")); }
Re: high contrast accessibility application guidelines?
[Adding the accessibility mailing list, somebody on that list might have
more insights]
On 10/10/2022 22.02, Caolán McNamara wrote:
Is there a set of guidelines as to the intent of high contrast within
documents?
Not sure I grasp the context of this question (s. below), but from a
quick search: WCAG has a criterion 1.4.3 about contrast for (primarily
web) documents:
https://www.w3.org/WAI/WCAG21/quickref/?tags=contrast#contrast-minimum
The "Understanding Success Criterion 1.4.3: Contrast (Minimum)" page has
some more details on the intent, etc.:
https://www.w3.org/WAI/WCAG21/Understanding/contrast-minimum.html
As far as I can see in impress/draw/shapes we ignore/force-highcontrast
text color, line color and fill colors, and there's a certain logic to
that. And in general in documents we use a high contrast text selection
mode. >
On the other hand in writer we do show the real text color and fill
color in the normal document content, but do the opposite for shapes
and for the content of frames. If we use the insert, table UI, then we
have forced colors in the preview of what the table will look like, but
the final inserted table then doesn't have forced colors.
Is that with any explicit high-contrast settings either in the desktop
environment or OS (like a specific theme) or LibreOffice explicitly applied?
In a quick test of mine *without* having taken any explicit settings, it
behaved like this for me (LO master as of
221d76260096b9e6b4c4479b1b89c95af8b05774, gtk3 with Adwaita theme and
kf5 with Breeze theme):
Impress:
1) With the font color in character settings set to "Automatic" (the
default), font color seems to be chosen automatically to provide
contrast to the slide background ("Slide properties" -> "Background" ->
"Color"), e.g. changing slide background from white to black makes the
text be shown in white.
2) Character highlighting color doesn't seem to be taken into account,
though. (Setting black highlighting color for text in a new presentation
results in black text on black background.)
3) If any explicit color is set in the character settings, that one is
used, regardless of the background, nothing is forced then (i.e. if
slide background is set to black and font color is explicitly set to
black, text is unreadable).
Other than Impress, in Writer, "Automatic" text color seems to take into
account the character highlighting color and page background. (Changing
the character highlighting color or page background to black results in
white text, and character background takes precedence over page
background, which seems reasonable.) Explicitly setting font color to
black in addition results in black text on black on black background,
nothing is automatically adapted.
In a quick test on Windows 10 (with an older LO master as of commit
349e3af0c5dd5ed495ed61aab526f63c16f0e215), enabling "Use high contrast"
in the Windows settings results in unreadable text in Impress in a new
presentation (both, font and background use the same dark color).
OpenPGP_signature
Description: OpenPGP digital signature
[Libreoffice-bugs] [Bug 151393] Auto_Open should not run from ThisWorkbook
https://bugs.documentfoundation.org/show_bug.cgi?id=151393 Justin L changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |jl...@mail.com |desktop.org | Resolution|--- |FIXED Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108908] [META] Visual Basic for Applications (VBA) macro issues
https://bugs.documentfoundation.org/show_bug.cgi?id=108908 Bug 108908 depends on bug 151393, which changed state. Bug 151393 Summary: Auto_Open should not run from ThisWorkbook https://bugs.documentfoundation.org/show_bug.cgi?id=151393 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: offapi/com sw/source vbahelper/source
offapi/com/sun/star/script/vba/VBAEventId.idl |5 --
sw/source/ui/vba/vbaeventshelper.cxx | 23 -
sw/source/uibase/app/docsh2.cxx|6 +-
vbahelper/source/vbahelper/vbaeventshelperbase.cxx | 50 +
4 files changed, 37 insertions(+), 47 deletions(-)
New commits:
commit 73911ed8d35294a9e15771d8aaa1e9121ef10309
Author: Justin Luth
AuthorDate: Tue Oct 11 12:14:34 2022 -0400
Commit: Justin Luth
CommitDate: Wed Oct 12 01:12:17 2022 +0200
tdf#148806 doc vba: highest priority is ThisDocument AutoOpen V2
A review by Stephan Bergmann made me re-think adding a separate
event for this. It really is only one event and not two
(or three as I initially imagined). In the end, I like this better
because it highlights the difference between Excel and Word
by keeping all the differentiating logic in one place.
The inability to properly document the purpose of these new events
was the impetus to redesign this. Thanks Stephan for the prompt.
Change-Id: Ic2d461c13c4a52e279224cb485d2b6c4a3c57b54
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141233
Tested-by: Justin Luth
Reviewed-by: Justin Luth
diff --git a/offapi/com/sun/star/script/vba/VBAEventId.idl
b/offapi/com/sun/star/script/vba/VBAEventId.idl
index 00a524a1ef3b..00989fccd053 100644
--- a/offapi/com/sun/star/script/vba/VBAEventId.idl
+++ b/offapi/com/sun/star/script/vba/VBAEventId.idl
@@ -58,11 +58,6 @@ constants VBAEventId
const long DOCUMENT_OPEN= 1002;
/** Document about to be closed. No arguments. */
const long DOCUMENT_CLOSE = 1003;
-// auto* subroutines in ThisDocument have highest priority
-const long DOCUMENT_AUTO_NEW = 1004;
-const long DOCUMENT_AUTO_OPEN = 1005;
-const long DOCUMENT_AUTO_CLOSE = 1006;
-
// MS Excel (identifiers from 2001 to 2999)
diff --git a/sw/source/ui/vba/vbaeventshelper.cxx
b/sw/source/ui/vba/vbaeventshelper.cxx
index d083940106b5..d928eaba16f2 100644
--- a/sw/source/ui/vba/vbaeventshelper.cxx
+++ b/sw/source/ui/vba/vbaeventshelper.cxx
@@ -32,13 +32,10 @@ SwVbaEventsHelper::SwVbaEventsHelper( uno::Sequence<
css::uno::Any > const& aArg
{
using namespace ::com::sun::star::script::ModuleType;
registerEventHandler( DOCUMENT_NEW, DOCUMENT, "Document_New" );
-registerEventHandler(DOCUMENT_AUTO_NEW, DOCUMENT, "AutoNew");
registerEventHandler( AUTO_NEW, NORMAL, "AutoNew" );
registerEventHandler( DOCUMENT_OPEN,DOCUMENT, "Document_Open" );
-registerEventHandler(DOCUMENT_AUTO_OPEN, DOCUMENT, "AutoOpen");
registerEventHandler( AUTO_OPEN,NORMAL, "AutoOpen" );
registerEventHandler( DOCUMENT_CLOSE, DOCUMENT, "Document_Close" );
-registerEventHandler(DOCUMENT_AUTO_CLOSE, DOCUMENT, "AutoClose");
registerEventHandler( AUTO_CLOSE, NORMAL, "AutoClose" );
}
@@ -46,25 +43,9 @@ SwVbaEventsHelper::~SwVbaEventsHelper()
{
}
-bool SwVbaEventsHelper::implPrepareEvent( EventQueue& rEventQueue,
-const EventHandlerInfo& rInfo, const uno::Sequence< uno::Any >& rArgs)
+bool SwVbaEventsHelper::implPrepareEvent(EventQueue& /*rEventQueue*/,
+const EventHandlerInfo& /*rInfo*/, const uno::Sequence&
/*rArgs*/)
{
-switch( rInfo.mnEventId )
-{
-case DOCUMENT_AUTO_NEW:
-// Only one "AutoNew" subroutine can run. ThisDocument is highest
priority.
-if (!hasVbaEventHandler(rInfo.mnEventId, rArgs))
-rEventQueue.emplace_back(AUTO_NEW);
-break;
-case DOCUMENT_AUTO_OPEN:
-if (!hasVbaEventHandler(rInfo.mnEventId, rArgs))
-rEventQueue.emplace_back(AUTO_OPEN);
-break;
-case DOCUMENT_AUTO_CLOSE:
-if (!hasVbaEventHandler(rInfo.mnEventId, rArgs))
-rEventQueue.emplace_back(AUTO_CLOSE);
-break;
-}
return true;
}
diff --git a/sw/source/uibase/app/docsh2.cxx b/sw/source/uibase/app/docsh2.cxx
index 51082a682c2d..a5e79881e342 100644
--- a/sw/source/uibase/app/docsh2.cxx
+++ b/sw/source/uibase/app/docsh2.cxx
@@ -221,11 +221,11 @@ static void lcl_processCompatibleSfxHint( const
uno::Reference< script::vba::XVB
switch( pSfxEventHint->GetEventId() )
{
case SfxEventHintId::CreateDoc:
-xVbaEvents->processVbaEvent(DOCUMENT_AUTO_NEW, aArgs);
+xVbaEvents->processVbaEvent(AUTO_NEW, aArgs);
xVbaEvents->processVbaEvent(DOCUMENT_NEW, aArgs);
break;
case SfxEventHintId::OpenDoc:
-xVbaEvents->processVbaEvent(DOCUMENT_AUTO_OPEN, aArgs);
+xVbaEvents->processVbaEvent(AUTO_OPEN, aArgs);
xVbaEvents->processVbaEvent(DOCUMENT_OPEN, aArgs);
break;
default: break;
@@ -387,7 +387,7 @@ bool SwDocShell::PrepareClose( bool bUI )
{
using namespace
[Libreoffice-commits] core.git: vcl/headless
vcl/headless/CairoCommon.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit f518928c322d45cdec4163c0182b0008da0da729
Author: Caolán McNamara
AuthorDate: Tue Oct 11 20:18:20 2022 +0100
Commit: Caolán McNamara
CommitDate: Wed Oct 12 00:15:27 2022 +0200
only interested in genuinely bizarely thick lines
Change-Id: I107a46cc11127910f28977b88152c41e8b6c6467
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141239
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/vcl/headless/CairoCommon.cxx b/vcl/headless/CairoCommon.cxx
index fb6888bc91c9..b0f93c1eaf41 100644
--- a/vcl/headless/CairoCommon.cxx
+++ b/vcl/headless/CairoCommon.cxx
@@ -708,7 +708,7 @@ bool CairoCommon::drawPolyLine(cairo_t* cr,
basegfx::B2DRange* pExtents, const C
cairo_set_line_join(cr, eCairoLineJoin);
cairo_set_line_cap(cr, eCairoLineCap);
constexpr int MaxNormalLineWidth = 128;
-if (fLineWidth > MaxNormalLineWidth)
+if (bObjectToDeviceIsIdentity && fLineWidth > MaxNormalLineWidth)
{
SAL_WARN("vcl.gdi", "drawPolyLine, suspicious line width of: " <<
fLineWidth);
static const bool bFuzzing = utl::ConfigManager::IsFuzzing();
[Libreoffice-bugs] [Bug 42082] [META] Make LibreOffice shine and glow on macOS
https://bugs.documentfoundation.org/show_bug.cgi?id=42082 Bug 42082 depends on bug 150525, which changed state. Bug 150525 Summary: Check for Updates bug https://bugs.documentfoundation.org/show_bug.cgi?id=150525 What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150525] Check for Updates bug
https://bugs.documentfoundation.org/show_bug.cgi?id=150525 V Stuart Foote changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |WORKSFORME CC||vstuart.fo...@utsa.edu -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: vcl/win
vcl/win/gdi/salfont.cxx | 68
1 file changed, 68 deletions(-)
New commits:
commit 8815ae462f32915209c838688b7cc86f57e280d4
Author: Stephan Bergmann
AuthorDate: Tue Oct 11 15:47:49 2022 +0200
Commit: Stephan Bergmann
CommitDate: Tue Oct 11 22:59:58 2022 +0200
loplugin:unreffun
...after the last use of that RawFontData got removed in
112d07027c4484dd571519911596d11eae897524 "vcl: Use
PhysicalFontFace::GetRawFontData() for font embedding"
Change-Id: Id85eb39b6fd946da132d53ba937032f3c58b061d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141225
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/vcl/win/gdi/salfont.cxx b/vcl/win/gdi/salfont.cxx
index 9d618c6b9c81..75080dae4261 100644
--- a/vcl/win/gdi/salfont.cxx
+++ b/vcl/win/gdi/salfont.cxx
@@ -85,74 +85,6 @@ static int IntTimes256FromFixed(FIXED f)
return nFixedTimes256;
}
-namespace {
-
-// raw font data with a scoped lifetime
-class RawFontData
-{
-public:
-explicitRawFontData( HDC, DWORD nTableTag=0 );
-const unsigned char*get() const { return mpRawBytes.get(); }
-const unsigned char*steal() { return mpRawBytes.release(); }
-int size() const { return mnByteCount; }
-
-private:
-std::unique_ptr mpRawBytes;
-unsignedmnByteCount;
-};
-
-}
-
-RawFontData::RawFontData( HDC hDC, DWORD nTableTag )
-: mnByteCount( 0 )
-{
-// get required size in bytes
-mnByteCount = ::GetFontData( hDC, nTableTag, 0, nullptr, 0 );
-if (mnByteCount == GDI_ERROR)
-mnByteCount = 0;
-if (!mnByteCount)
-return;
-
-// allocate the array
-mpRawBytes.reset(new unsigned char[ mnByteCount ]);
-
-// get raw data in chunks small enough for GetFontData()
-unsigned nRawDataOfs = 0;
-DWORD nMaxChunkSize = 0x10;
-for(;;)
-{
-// calculate remaining raw data to get
-DWORD nFDGet = mnByteCount - nRawDataOfs;
-if( nFDGet <= 0 )
-break;
-// #i56745# limit GetFontData requests
-if( nFDGet > nMaxChunkSize )
-nFDGet = nMaxChunkSize;
-const DWORD nFDGot = ::GetFontData( hDC, nTableTag, nRawDataOfs,
-mpRawBytes.get() + nRawDataOfs, nFDGet );
-if( !nFDGot )
-break;
-else if( nFDGot != GDI_ERROR )
-nRawDataOfs += nFDGot;
-else
-{
-// was the chunk too big? reduce it
-nMaxChunkSize /= 2;
-if( nMaxChunkSize < 0x1 )
-break;
-}
-}
-
-// cleanup if the raw data is incomplete
-if( nRawDataOfs != mnByteCount )
-{
-mpRawBytes.reset();
-// mnByteCount must correspond to mpRawBytes length
-SAL_WARN( "vcl", "Raw data of font is incomplete: " << nRawDataOfs <<
" byte(s) found whereas " << mnByteCount << " byte(s) expected!" );
-mnByteCount = 0;
-}
-}
-
// platform specific font substitution hooks for glyph fallback enhancement
namespace {
[Libreoffice-bugs] [Bug 151456] AnimatedImages in Basic Dialog : StepTime is ignored
https://bugs.documentfoundation.org/show_bug.cgi?id=151456 --- Comment #2 from Julien Nabet --- Created attachment 182979 --> https://bugs.documentfoundation.org/attachment.cgi?id=182979=edit bt with debug symbols Just for the record, here's a bt from the constructor of Throbber. Indeed, I don't know how the StepTime may be taken into account. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151368] Collabora Office for Android: Dialog Boxes Lack Scroll Bars
https://bugs.documentfoundation.org/show_bug.cgi?id=151368 Dieter changed: What|Removed |Added Component|Writer |Android Editor -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - oox/source
oox/source/vml/vmlinputstream.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit eac884bc84327621498ca2fb9a2a3d67d49d5c91
Author: Caolán McNamara
AuthorDate: Tue Oct 11 15:10:43 2022 +0100
Commit: Xisco Fauli
CommitDate: Tue Oct 11 21:14:17 2022 +0200
vml whitespace-check mangled Částečně to ste n
Change-Id: Ib77ca39a5e17c7fb27c8d5204120fb261b885f16
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141185
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
diff --git a/oox/source/vml/vmlinputstream.cxx
b/oox/source/vml/vmlinputstream.cxx
index 93204ac50710..4f94207619f2 100644
--- a/oox/source/vml/vmlinputstream.cxx
+++ b/oox/source/vml/vmlinputstream.cxx
@@ -42,7 +42,7 @@ const char* lclFindCharacter( const char* pcBeg, const char*
pcEnd, char cChar )
bool lclIsWhiteSpace( char cChar )
{
-return cChar <= 32;
+return cChar >= 0 && cChar <= 32;
}
const char* lclFindWhiteSpace( const char* pcBeg, const char* pcEnd )
[Libreoffice-bugs] [Bug 151472] FORMATTING: Style change breaks direct formatting (bold, italic, underline)
https://bugs.documentfoundation.org/show_bug.cgi?id=151472 Peter Gervai changed: What|Removed |Added Component|Calc|UI --- Comment #1 from Peter Gervai --- It seems that this is not Calc related: same effect is observable in Writer. Please reassign to the proper component, thank you! It may be related to the actual fonts, since it doesn't seem to happen with FreeSerif, but happens with multiple custom fonts. For example it is OK with "Linux Libertine G" but broken with "Linux Libertine Display O". Bold broken with "Lato Medium" but works with "Lato". Italic may work with those where bold was broken while not with others. Possibly related to font attributes? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151472] New: FORMATTING: Style change breaks direct formatting (bold, italic, underline)
https://bugs.documentfoundation.org/show_bug.cgi?id=151472 Bug ID: 151472 Summary: FORMATTING: Style change breaks direct formatting (bold, italic, underline) Product: LibreOffice Version: 7.4.1.2 release Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: g...@grin.hu Description: Afte changing Default style font the direct formatting styles stop working, or work erratically on zoom change or in combinations. Steps to Reproduce: 1.open calc 2.type "hello world" in A1 3.press F11, right click on Default, change font to Linux Libertine or Lato Medium or probably any custom font, OK 4. click on A1, press Ctrl-B several times, and see no result. 5. try Ctrl-I, or Ctrl-U, and try to change the zoom. Actual Results: Bold icon gets selected but font stays regular. Changing zoom level may change behaviour, and Italic may or may not work, and underline may or may not change bold and/or italic as well. Expected Results: Bold, Italic and Underline works as intended. Reproducible: Always User Profile Reset: No Additional Info: Probably broken for quite a while now, I kind of remember seeing it already. Version: 7.4.1.2 / LibreOffice Community Build ID: 40(Build:2) CPU threads: 8; OS: Linux 5.18; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF8); UI: en-US Debian package version: 1:7.4.1-1 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103314] [META] Templates bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103314 Bug 103314 depends on bug 143956, which changed state. Bug 143956 Summary: Writer Templates are in Format Size A4 instead of Letter for Default - English (USA) https://bugs.documentfoundation.org/show_bug.cgi?id=143956 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151455] SQLError Event fails with Python
https://bugs.documentfoundation.org/show_bug.cgi?id=151455 --- Comment #6 from Andreas Säger --- (In reply to Alex Thurgood from comment #2) > @Andreas : does this require the APSO extension to be installed in order to > test? It would require APSO if it reached the point where it shows a user defined msgbox. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151393] Auto_Open should not run from ThisWorkbook
https://bugs.documentfoundation.org/show_bug.cgi?id=151393 Commit Notification changed: What|Removed |Added Whiteboard||target:7.5.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: filter/source include/filter vbahelper/source
filter/source/msfilter/msvbahelper.cxx | 13 ++
include/filter/msfilter/msvbahelper.hxx|3 +-
vbahelper/source/vbahelper/vbaeventshelperbase.cxx | 25 +++--
3 files changed, 33 insertions(+), 8 deletions(-)
New commits:
commit ffc15725b58d0988b4e2ed836c5751223ad00984
Author: Justin Luth
AuthorDate: Sat Oct 8 12:15:35 2022 -0400
Commit: Justin Luth
CommitDate: Tue Oct 11 20:39:04 2022 +0200
tdf#148806 tdf#151393 xls vba: no Auto_Open from ThisWorksheet
Unlike Word, ThisWorksheet cannot hold auto-running
subroutines for Open/Close/New.
This fixes a LO 7.4 regression caused by
commit beb6c62e990599d91ac5d9183164c94d269027d3.
Change-Id: Idb8f72775d9392b306cb924ee776821272b12f3b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141127
Tested-by: Jenkins
Reviewed-by: Justin Luth
diff --git a/filter/source/msfilter/msvbahelper.cxx
b/filter/source/msfilter/msvbahelper.cxx
index 59d34ca5cec1..c7e84138f8dd 100644
--- a/filter/source/msfilter/msvbahelper.cxx
+++ b/filter/source/msfilter/msvbahelper.cxx
@@ -172,7 +172,7 @@ static SfxObjectShell* findShellForUrl( const OUString&
sMacroURLOrPath )
// if sMod is empty and a macro is found then sMod is updated
// if sMod is empty, only standard modules will be searched (no class,
document, form modules)
static bool hasMacro(SfxObjectShell const* pShell, const OUString& sLibrary,
OUString& sMod,
- const OUString& sMacro, bool bOnlyPublic)
+ const OUString& sMacro, bool bOnlyPublic, const OUString&
sSkipModule)
{
#if !HAVE_FEATURE_SCRIPTING
(void) pShell;
@@ -180,6 +180,7 @@ static bool hasMacro(SfxObjectShell const* pShell, const
OUString& sLibrary, OUS
(void) sMod;
(void) sMacro;
(void) bOnlyPublic;
+(void) sSkipModule;
#else
if (sLibrary.isEmpty() || sMacro.isEmpty())
return false;
@@ -212,7 +213,8 @@ static bool hasMacro(SfxObjectShell const* pShell, const
OUString& sLibrary, OUS
SbMethod* pMeth = rModuleRef->FindMethod(sMacro, SbxClassType::Method);
if (pMeth)
{
-if (bOnlyPublic && pMeth->IsSet(SbxFlagBits::Private))
+if ((bOnlyPublic && pMeth->IsSet(SbxFlagBits::Private))
+|| rModuleRef->GetName() == sSkipModule)
continue;
sMod = rModuleRef->GetName();
return true;
@@ -263,7 +265,7 @@ static void parseMacro( const OUString& sMacro, OUString&
sContainer, OUString&
OUString resolveVBAMacro(SfxObjectShell const* pShell, const OUString&
rLibName,
const OUString& rModuleName, const OUString&
rMacroName,
- bool bOnlyPublic)
+ bool bOnlyPublic, const OUString& sSkipModule)
{
#if !HAVE_FEATURE_SCRIPTING
(void) pShell;
@@ -271,12 +273,13 @@ OUString resolveVBAMacro(SfxObjectShell const* pShell,
const OUString& rLibName,
(void) rModuleName;
(void) rMacroName;
(void) bOnlyPublic;
+(void) sSkipModule;
#else
if( pShell )
{
OUString aLibName = rLibName.isEmpty() ? getDefaultProjectName(
pShell ) : rLibName ;
OUString aModuleName = rModuleName;
-if (hasMacro( pShell, aLibName, aModuleName, rMacroName, bOnlyPublic))
+if (hasMacro(pShell, aLibName, aModuleName, rMacroName, bOnlyPublic,
sSkipModule))
return aLibName + "." + aModuleName + "." + rMacroName;
}
#endif
@@ -447,7 +450,7 @@ MacroResolvedInfo resolveVBAMacro( SfxObjectShell* pShell,
const OUString& Macro
for (auto const& search : sSearchList)
{
-aRes.mbFound = hasMacro(pShell, search, sModule, sProcedure,
/*bOnlyPublic=*/false);
+aRes.mbFound = hasMacro(pShell, search, sModule, sProcedure,
/*bOnlyPublic=*/false, "");
if ( aRes.mbFound )
{
sContainer = search;
diff --git a/include/filter/msfilter/msvbahelper.hxx
b/include/filter/msfilter/msvbahelper.hxx
index c1ad7fdae3a2..90f1f8a2b90f 100644
--- a/include/filter/msfilter/msvbahelper.hxx
+++ b/include/filter/msfilter/msvbahelper.hxx
@@ -60,7 +60,8 @@ MSFILTER_DLLPUBLIC OUString extractMacroName(
std::u16string_view rMacroUrl );
MSFILTER_DLLPUBLIC OUString getDefaultProjectName( SfxObjectShell const *
pShell );
MSFILTER_DLLPUBLIC OUString resolveVBAMacro(SfxObjectShell const* pShell,
const OUString& rLibName,
const OUString& rModuleName,
-const OUString& rMacroName, bool
bOnlyPublic);
+const OUString& rMacroName, bool
bOnlyPublic,
+const OUString& sSkipModule);
MSFILTER_DLLPUBLIC MacroResolvedInfo resolveVBAMacro( SfxObjectShell* pShell,
const OUString& rMacroName, bool bSearchGlobalTemplates = false );
MSFILTER_DLLPUBLIC bool executeMacro(
[Libreoffice-bugs] [Bug 151393] Auto_Open should not run from ThisWorkbook
https://bugs.documentfoundation.org/show_bug.cgi?id=151393 --- Comment #3 from Commit Notification --- Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/ffc15725b58d0988b4e2ed836c5751223ad00984 tdf#148806 tdf#151393 xls vba: no Auto_Open from ThisWorksheet It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151471] comment hyperlink eliminates accented letters
https://bugs.documentfoundation.org/show_bug.cgi?id=151471 --- Comment #3 from Mike Kaganski --- Created attachment 182978 --> https://bugs.documentfoundation.org/attachment.cgi?id=182978=edit A screencast - no repro Can't repro using Version: 7.4.2.2 (x64) / LibreOffice Community Build ID: 1726efbecd001a1fe871cba3e00e71283688f34d CPU threads: 12; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: ru-RU (ru_RU); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: oox/source
oox/source/vml/vmlinputstream.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit b320ef30977144c52de9b39bc4db0db540727c79
Author: Caolán McNamara
AuthorDate: Tue Oct 11 15:10:43 2022 +0100
Commit: Caolán McNamara
CommitDate: Tue Oct 11 20:34:05 2022 +0200
vml whitespace-check mangled Částečně to ste n
Change-Id: Ib77ca39a5e17c7fb27c8d5204120fb261b885f16
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141228
Tested-by: Caolán McNamara
Reviewed-by: Caolán McNamara
diff --git a/oox/source/vml/vmlinputstream.cxx
b/oox/source/vml/vmlinputstream.cxx
index 93204ac50710..4f94207619f2 100644
--- a/oox/source/vml/vmlinputstream.cxx
+++ b/oox/source/vml/vmlinputstream.cxx
@@ -42,7 +42,7 @@ const char* lclFindCharacter( const char* pcBeg, const char*
pcEnd, char cChar )
bool lclIsWhiteSpace( char cChar )
{
-return cChar <= 32;
+return cChar >= 0 && cChar <= 32;
}
const char* lclFindWhiteSpace( const char* pcBeg, const char* pcEnd )
[Libreoffice-bugs] [Bug 97356] implement fallback export of Math object in PPTX
https://bugs.documentfoundation.org/show_bug.cgi?id=97356 Hossein changed: What|Removed |Added Keywords|difficultyMedium, easyHack, | |skillCpp| Whiteboard||reviewed:2022 --- Comment #3 from Hossein --- Re-evaluating the EasyHack in 2022 This issue is not suitable for a newcomer, as it needs MS Office 2007 (end of support: 2012/2017*) and MS Office 2010 (end of support: 2015/2020) for testing, in which both are no longer supported. See mainstream support/extended support: * https://en.wikipedia.org/wiki/Microsoft_Office_2007 ** https://en.wikipedia.org/wiki/Microsoft_Office_2010 I am removing the EasyHack tag from this issue. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: include/sax sax/source
include/sax/fshelper.hxx |2 +-
sax/source/tools/fshelper.cxx |1 -
2 files changed, 1 insertion(+), 2 deletions(-)
New commits:
commit 2241ce64b29e87e0c654ab529b71aa98f71b4a14
Author: Caolán McNamara
AuthorDate: Tue Oct 11 10:16:08 2022 +0100
Commit: Caolán McNamara
CommitDate: Tue Oct 11 20:33:01 2022 +0200
use std::unique_ptr
Change-Id: Ibb3d71c8d50e1ad7236a6fe01ff83d3cd1a866f3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141214
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/include/sax/fshelper.hxx b/include/sax/fshelper.hxx
index 79f0e1a0f30f..115a3f912ca5 100644
--- a/include/sax/fshelper.hxx
+++ b/include/sax/fshelper.hxx
@@ -156,7 +156,7 @@ private:
void pushAttributeValue( sal_Int32 attribute, const char* value );
void pushAttributeValue( sal_Int32 attribute, const OString& value );
-FastSaxSerializer* mpSerializer;
+std::unique_ptr mpSerializer;
};
typedef std::shared_ptr< FastSerializerHelper > FSHelperPtr;
diff --git a/sax/source/tools/fshelper.cxx b/sax/source/tools/fshelper.cxx
index a560e5bd1bad..7cbd3c36abc1 100644
--- a/sax/source/tools/fshelper.cxx
+++ b/sax/source/tools/fshelper.cxx
@@ -35,7 +35,6 @@ FastSerializerHelper::FastSerializerHelper(const Reference<
io::XOutputStream >&
FastSerializerHelper::~FastSerializerHelper()
{
mpSerializer->endDocument();
-delete mpSerializer;
}
void FastSerializerHelper::startElement(sal_Int32 elementTokenId)
[Libreoffice-bugs] [Bug 151471] comment hyperlink eliminates accented letters
https://bugs.documentfoundation.org/show_bug.cgi?id=151471 --- Comment #2 from tor...@yahoo.com --- Created attachment 182977 --> https://bugs.documentfoundation.org/attachment.cgi?id=182977=edit file with hyperlink -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151471] comment hyperlink eliminates accented letters
https://bugs.documentfoundation.org/show_bug.cgi?id=151471 --- Comment #1 from tor...@yahoo.com --- Created attachment 182976 --> https://bugs.documentfoundation.org/attachment.cgi?id=182976=edit file with hyperlinked word & accent -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151471] New: comment hyperlink eliminates accented letters
https://bugs.documentfoundation.org/show_bug.cgi?id=151471 Bug ID: 151471 Summary: comment hyperlink eliminates accented letters Product: LibreOffice Version: 7.4.0.0 beta1+ Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tor...@yahoo.com Description: In cmtAccent.odt, the word ‘système’, which has a hyperlink, was copied as a comment, lost its ‘è’ to become ‘systme’; inside the hyperlink, ‘système’ also was changed to ‘systme’. This happens also with other accented letters, like ‘é’. Steps to Reproduce: 1.copy word with accent & hyperlink 2. 3. Actual Results: accent disappears Expected Results: good copy Reproducible: Always User Profile Reset: No Additional Info: Version: 7.4.0.1 (x64) / LibreOffice Community Build ID: 43e5fcfbbadd18fccee5a6f42ddd533e40151bcf CPU threads: 4; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win Locale: en-CA (en_CA); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 137414] VERTICAL toolbars do NOT use background of internal preinstalled theme
https://bugs.documentfoundation.org/show_bug.cgi?id=137414 Rafael Lima changed: What|Removed |Added CC||rafael.palma.l...@gmail.com --- Comment #5 from Rafael Lima --- Can we consider this as WFM since LO 7.4 now supports dark mode in Windows? I wonder if we should drop the "Personalization/LibreOffice themes" feature. At least in Linux it does not look good. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150975] invoking navigation pane summons a second undockable pane, leading to confusion
https://bugs.documentfoundation.org/show_bug.cgi?id=150975 --- Comment #7 from Aleix --- Hi, trying to revive the issue. My navigation pane called by f5 does not dock to the main writer window, even trying 3 differents ways to do so. I found the same issue described here: https://ask.libreoffice.org/t/dock-navigator-in-writer/74242/6 which probably means I am not the only one experiencing this issue. I am using LO 7.3.6.2 in ubuntu 22.04 with wayland. Any help will be more than welcome. I can do some testing if you tell me which commands to run since I am not a programmer. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103184] [META] UI theming bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103184 Bug 103184 depends on bug 140747, which changed state. Bug 140747 Summary: Text Color Does Not Invert/lighten in LibreOffice Startup Screen for Dark Mode in Ubuntu 20.04 https://bugs.documentfoundation.org/show_bug.cgi?id=140747 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140747] Text Color Does Not Invert/lighten in LibreOffice Startup Screen for Dark Mode in Ubuntu 20.04
https://bugs.documentfoundation.org/show_bug.cgi?id=140747 Rafael Lima changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |WORKSFORME CC||rafael.palma.l...@gmail.com --- Comment #3 from Rafael Lima --- The Start Center now works in dark mode using kf5, gtk3 and gen. Many fixes have bee made since LO 7.0, which is the version used in the original report. Currently I can't reproduce this issue. I'm setting this as WFM. Feel free to change it back if you still experience this problem. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142888] UI - View menu - the same hotkeys for two items ("Toolbars" and "Show Tracked Changes")
https://bugs.documentfoundation.org/show_bug.cgi?id=142888 Hossein changed: What|Removed |Added Whiteboard||reviewed:2022 --- Comment #15 from Hossein --- Re-evaluating the EasyHack in 2022 This issue is still relevant. The accelerator (here referred as hotkeys) for these two menu items should become different. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sc/source
sc/source/core/data/table3.cxx | 16
1 file changed, 16 deletions(-)
New commits:
commit a6ec933d0fe2150a6b83cd54a0de30b252c9a600
Author: Mike Kaganski
AuthorDate: Tue Oct 11 14:18:16 2022 +0300
Commit: Mike Kaganski
CommitDate: Tue Oct 11 19:36:45 2022 +0200
tdf#91305 related: Drop redundant only-one-column/row check
This check was introduced in commit 4cd9e45a439b654c8e1ff7983fe7e4bd073b9c92
Author Yan Pashkovsky
Date Fri Aug 12 23:39:30 2016 +0300
tdf#91305 fix sort calc
Then commit 63592999a067d76c896ed79204330e1a4b934c80
Author Eike Rathke
Date Thu Aug 18 17:16:50 2016 +0200
refine HasColHeader()/HasRowHeader() conditions, tdf#91305 related
made the "not only one column/row" case check the same.
Change-Id: I25ce867e1c64d7b89a617021de9a5e4f1c89d2a9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141219
Tested-by: Mike Kaganski
Reviewed-by: Mike Kaganski
diff --git a/sc/source/core/data/table3.cxx b/sc/source/core/data/table3.cxx
index 5a128152ad46..bdf16a69aad4 100644
--- a/sc/source/core/data/table3.cxx
+++ b/sc/source/core/data/table3.cxx
@@ -2905,14 +2905,6 @@ bool ScTable::HasColHeader( SCCOL nStartCol, SCROW
nStartRow, SCCOL nEndCol, SCR
* evaluate it has header row, but that doesn't make much sense. */
return false;
-if (nStartCol == nEndCol)
-{
-CellType eFirstCellType = GetCellType(nStartCol, nStartRow);
-CellType eSecondCellType = GetCellType(nStartCol, nStartRow+1);
-return ((eFirstCellType == CELLTYPE_STRING || eFirstCellType ==
CELLTYPE_EDIT) &&
-(eSecondCellType != CELLTYPE_STRING && eSecondCellType !=
CELLTYPE_EDIT));
-}
-
for (SCCOL nCol=nStartCol; nCol<=nEndCol; nCol++)
{
CellType eType = GetCellType( nCol, nStartRow );
@@ -2942,14 +2934,6 @@ bool ScTable::HasRowHeader( SCCOL nStartCol, SCROW
nStartRow, SCCOL nEndCol, SCR
* evaluate it has header column, but that doesn't make much sense. */
return false;
-if (nStartRow == nEndRow)
-{
-CellType eFirstCellType = GetCellType(nStartCol, nStartRow);
-CellType eSecondCellType = GetCellType(nStartCol+1, nStartRow);
-return ((eFirstCellType == CELLTYPE_STRING || eFirstCellType ==
CELLTYPE_EDIT) &&
-(eSecondCellType != CELLTYPE_STRING && eSecondCellType !=
CELLTYPE_EDIT));
-}
-
for (SCROW nRow=nStartRow; nRow<=nEndRow; nRow++)
{
CellType eType = GetCellType( nStartCol, nRow );
[Libreoffice-bugs] [Bug 142695] Add info about double-click making commands sticky to all affected commands' tooltips
https://bugs.documentfoundation.org/show_bug.cgi?id=142695 Hossein changed: What|Removed |Added Whiteboard||reviewed:2022 --- Comment #2 from Hossein --- Re-evaluating the EasyHack in 2022 This enhancement is still relevant. It is suitable for the newcomers. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/source
sw/source/core/doc/tblcpy.cxx |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 8e39704b597fda9e3ef442252defed16a0a07b03
Author: Noel Grandin
AuthorDate: Tue Oct 11 12:22:03 2022 +0200
Commit: Noel Grandin
CommitDate: Tue Oct 11 19:07:56 2022 +0200
use more SwPosition::SetContent
part of the process of hiding the internals of SwPosition
Change-Id: I8a0de56c9e42adda71cffe8b79daca5a8e7a23a3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141213
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sw/source/core/doc/tblcpy.cxx b/sw/source/core/doc/tblcpy.cxx
index bf9200cb0623..808f0ac3d8bb 100644
--- a/sw/source/core/doc/tblcpy.cxx
+++ b/sw/source/core/doc/tblcpy.cxx
@@ -533,9 +533,9 @@ static void lcl_CpyBox( const SwTable& rCpyTable, const
SwTableBox* pCpyBox,
// Move Bookmarks
{
SwPosition aMvPos( aInsIdx );
-SwContentNode* pCNd = SwNodes::GoPrevious( );
+SwContentNode* pCNd = SwNodes::GoPrevious( );
assert(pCNd); // keep coverity happy
-aMvPos.nContent.Assign( pCNd, pCNd->Len() );
+aMvPos.SetContent( pCNd->Len() );
SwDoc::CorrAbs( aInsIdx, aEndNdIdx, aMvPos );
}
[Libreoffice-bugs] [Bug 119745] Scrolling with a laptop touchpad in Libreoffice way too fast
https://bugs.documentfoundation.org/show_bug.cgi?id=119745 jeremy.jarr...@gmail.com changed: What|Removed |Added CC||jeremy.jarr...@gmail.com --- Comment #48 from jeremy.jarr...@gmail.com --- I'm experiencing this problem on an ASUS VivoBook 17 / Win10 (everything system- and driver- and LO-wise up to date), with a wireless Logitech M185 mouse. In the year of our lord two thousand and twenty-two, this should not still be a problem for so many users. -- You are receiving this mail because: You are the assignee for the bug.
Re: [libreoffice-accessibility] Re: high contrast accessibility application guidelines?
Caolán, * These Microsoft notes are helpful in general with some specifics for Windows os/DE implementors: https://learn.microsoft.com/en-us/windows/win32/winauto/high-contrast-parameter https://learn.microsoft.com/en-us/windows/win32/controls/supporting-high-contrast-themes Stuart From: Michael Weghorn Sent: Tuesday, October 11, 2022 10:20 AM To: libreoffice@lists.freedesktop.org ; accessibil...@global.libreoffice.org Subject: [libreoffice-accessibility] Re: high contrast accessibility application guidelines? **EXTERNAL EMAIL** This email originated outside of The University of Texas at San Antonio. Please exercise caution when clicking on links or opening attachments. [Adding the accessibility mailing list, somebody on that list might have more insights] On 10/10/2022 22.02, Caolán McNamara wrote: > Is there a set of guidelines as to the intent of high contrast within > documents?
[Libreoffice-commits] core.git: svtools/source
svtools/source/misc/embedhlp.cxx | 35 ++-
1 file changed, 34 insertions(+), 1 deletion(-)
New commits:
commit 0bd83ba4c40bd7c3ebd3f098421c23bc9ced7b9e
Author: Miklos Vajna
AuthorDate: Tue Oct 11 16:56:24 2022 +0200
Commit: Miklos Vajna
CommitDate: Tue Oct 11 18:49:32 2022 +0200
tdf#151470 svtools: prevent storing broken graphic of embedded objects
Updating the preview of the embedded PDF object in the bugdoc leads to
Acrobat generating a new preview, we throw away the old one, write the
new one to the document, and next time the document is opened, we can't
parse it, so the preview is lost for the user.
The reason for this seems to be that sometimes Acrobat generates a
broken WMF: the first 4 bytes is 0x0002 (DISKMETAFILE from the
MetafileType enum), but the next 4 bytes is 0x6f43, which means that the
header size is 56966 bytes long, but the whole preview is 29291, so this
WMF looks broken.
Fix the problem by adding error handling before we insert the WMF we get
from Acrobat as a graphic stream to the document storage: don't update
the graphic stream if the data is something that can't be handled by
VCL's graphic filters. svt::EmbeddedObjectRef::GetReplacement() has a
similar error handling, which is why the preview only gets broken on
document reload.
No testcase, this only happens on Windows and only in case a problematic
handler for PDF is installed, which is hard to test from 'make check'.
Change-Id: I9e1ce979e58a155fa5e72e31cd9ea38258bb8b6a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141229
Reviewed-by: Miklos Vajna
Tested-by: Jenkins
diff --git a/svtools/source/misc/embedhlp.cxx b/svtools/source/misc/embedhlp.cxx
index c3e13a551b44..053a30835d2d 100644
--- a/svtools/source/misc/embedhlp.cxx
+++ b/svtools/source/misc/embedhlp.cxx
@@ -680,7 +680,40 @@ std::unique_ptr
EmbeddedObjectRef::GetGraphicStream( bool bUpdate ) co
if(xStream.is())
{
if (mpImpl->pContainer)
-
mpImpl->pContainer->InsertGraphicStream(xStream,mpImpl->aPersistName,mpImpl->aMediaType);
+{
+bool bInsertGraphicStream = true;
+uno::Reference xSeekable(xStream,
uno::UNO_QUERY);
+std::optional oPosition;
+if (xSeekable.is())
+{
+oPosition = xSeekable->getPosition();
+}
+if (bUpdate)
+{
+std::unique_ptr pResult =
utl::UcbStreamHelper::CreateStream(xStream);
+if (pResult)
+{
+GraphicFilter& rGF =
GraphicFilter::GetGraphicFilter();
+Graphic aGraphic;
+rGF.ImportGraphic(aGraphic, u"", *pResult);
+if (aGraphic.IsNone())
+{
+// The graphic is not something we can
understand, don't overwrite a
+// potentially working previous graphic.
+SAL_WARN("svtools.misc",
"EmbeddedObjectRef::GetGraphicStream: failed to parse xStream");
+bInsertGraphicStream = false;
+}
+}
+}
+if (xSeekable.is() && oPosition.has_value())
+{
+xSeekable->seek(*oPosition);
+}
+if (bInsertGraphicStream)
+{
+
mpImpl->pContainer->InsertGraphicStream(xStream,mpImpl->aPersistName,mpImpl->aMediaType);
+}
+}
std::unique_ptr pResult =
::utl::UcbStreamHelper::CreateStream( xStream );
if (pResult && bUpdate)
[Libreoffice-bugs] [Bug 151264] Support proper table styles in Impress (and express them in ODF)
https://bugs.documentfoundation.org/show_bug.cgi?id=151264 --- Comment #15 from Rafael Lima --- (In reply to Maxim Monastirsky from comment #14) > Turns out I was mistaken, and table templates actually allow setting a > paragraph style (in addition to the paragraph settings specified in the cell > style), see: > https://docs.oasis-open.org/office/OpenDocument/v1.3/os/part3-schema/ > OpenDocument-v1.3-os-part3-schema.html#attribute-table_paragraph-style-name This is good to know... At least it is supported in ODF. It seems ODF allows to define cell styles and paragraph styles, both at the table level and at the cell level. I just don't know how much is actually implemented in LibreOffice. There's no UI to create paragraph styles in Impress. However, I don't know if we could create styles using the API and assign them to tables. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 133123] Python module uno.py overrides import, resulting in failure of subsequent import cairosvg module
https://bugs.documentfoundation.org/show_bug.cgi?id=133123 --- Comment #5 from Werner Tietz --- the Patch committed by @Niko Fink works also for: Version: 7.0.4.2 Build ID: 00(Build:2) CPU threads: 4; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: de-DE (de_DE.UTF-8); UI: de-DE Raspbian package version: 1:7.0.4-4+rpi1+deb11u3 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - sw/source
sw/source/uibase/app/docst.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 8debd8b675bad760f9dbeb822cc80f0b91b5c89e
Author: Aron Budea
AuthorDate: Sat Oct 8 00:58:12 2022 +0200
Commit: Xisco Fauli
CommitDate: Tue Oct 11 18:26:22 2022 +0200
"No List" option in Styles Sidebar doesn't remove list in non-English UI
In a list, with Styles sidebar open and List Styles selected,
the No List option did not remove the list if the UI language
was other than English.
No List entry exists since
a56aa46fcc62227df7dc9a8fa04205e8ff5ed2a1 .
Change-Id: I5210c07c811d08489c1b9a199f6756273153e05d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141092
Tested-by: Jenkins
Reviewed-by: Aron Budea
(cherry picked from commit 6a97ccad4a5d2a0d97bfe023aedf7a0146cd9782)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141066
Reviewed-by: Xisco Fauli
diff --git a/sw/source/uibase/app/docst.cxx b/sw/source/uibase/app/docst.cxx
index a891a53daa90..2d34c0e51e3a 100644
--- a/sw/source/uibase/app/docst.cxx
+++ b/sw/source/uibase/app/docst.cxx
@@ -1178,7 +1178,7 @@ SfxStyleFamily SwDocShell::ApplyStyles(const OUString
, SfxStyleFamily nFa
// reset indent attribute on applying list style
// continue list of list style
const SwNumRule* pNumRule = pStyle->GetNumRule();
-if (pNumRule->GetName() == "No List")
+if (pNumRule->GetName() == SwResId(STR_POOLNUMRULE_NOLIST))
{
SfxViewFrame::Current()->GetDispatcher()->Execute(FN_NUM_BULLET_OFF);
break;
[Libreoffice-bugs] [Bug 104597] RTL script text runs are reversed on PDF import, PDFIProcessor::mirrorString misbehaving
https://bugs.documentfoundation.org/show_bug.cgi?id=104597 --- Comment #78 from Kevin Suo --- The proposed patch in: https://gerrit.libreoffice.org/c/core/+/141231 should be a fix. Could someone review and test. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/source
sw/source/core/doc/docredln.cxx |5 + 1 file changed, 1 insertion(+), 4 deletions(-) New commits: commit ce9273e72f31ac3834fc6cf13f6dccc341d5fb8e Author: Noel Grandin AuthorDate: Tue Oct 11 10:52:22 2022 +0200 Commit: Noel Grandin CommitDate: Tue Oct 11 18:03:16 2022 +0200 avoid accessing SwPosition.nContent part of the process of hiding the internals of SwPosition Change-Id: I3a32cc601983313c29805603b1c0aa3f990d6b08 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141208 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/sw/source/core/doc/docredln.cxx b/sw/source/core/doc/docredln.cxx index 37e869b8f7af..9749c94331fb 100644 --- a/sw/source/core/doc/docredln.cxx +++ b/sw/source/core/doc/docredln.cxx @@ -569,12 +569,9 @@ std::vector> GetAllValidRanges(std::unique_ptr= *pEnd ) break; -pC = rNds.GoNext( ); +pC = rNds.GoNext( ); if( !pC ) break; - -aNewStt.nContent.Assign( pC, 0 ); - } while( aNewStt < *pEnd ); return ret;
[Libreoffice-commits] core.git: sw/source
sw/source/core/doc/docnum.cxx | 44 --
1 file changed, 21 insertions(+), 23 deletions(-)
New commits:
commit 5f986951c92f6314fa05f87164c48fd51f20d501
Author: Noel Grandin
AuthorDate: Tue Oct 11 10:50:52 2022 +0200
Commit: Noel Grandin
CommitDate: Tue Oct 11 18:02:52 2022 +0200
avoid accessing SwPosition.nContent
part of the process of hiding the internals of SwPosition
Change-Id: Ie6bc1822ac2a4e5c601ba2a94a0d287fdf989c19
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141207
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sw/source/core/doc/docnum.cxx b/sw/source/core/doc/docnum.cxx
index 4827dfb75d94..b4d32ea25b61 100644
--- a/sw/source/core/doc/docnum.cxx
+++ b/sw/source/core/doc/docnum.cxx
@@ -2118,7 +2118,7 @@ bool SwDoc::MoveParagraphImpl(SwPaM& rPam, SwNodeOffset
const nOffset,
// First the Insert, then the Delete
SwPosition aInsPos( aIdx );
-SwPaM aPam( pStt->GetNode(), 0, aMvRg.aEnd.GetNode(), 0 );
+std::optional oPam( std::in_place, pStt->GetNode(), 0,
aMvRg.aEnd.GetNode(), 0 );
SwPaM& rOrigPam(rPam);
rOrigPam.DeleteMark();
@@ -2160,35 +2160,35 @@ bool SwDoc::MoveParagraphImpl(SwPaM& rPam, SwNodeOffset
const nOffset,
: aIdx.GetNode().GetTextNode());
bool bIsEmptyNode = pIsEmptyNode && pIsEmptyNode->Len() == 0;
-getIDocumentContentOperations().CopyRange(aPam, aInsPos,
SwCopyFlags::CheckPosInFly);
+getIDocumentContentOperations().CopyRange(*oPam, aInsPos,
SwCopyFlags::CheckPosInFly);
// now delete all the delete redlines that were copied
#ifndef NDEBUG
size_t
nRedlines(getIDocumentRedlineAccess().GetRedlineTable().size());
#endif
if (nOffset > SwNodeOffset(0))
-assert(aPam.End()->GetNodeIndex() -
aPam.Start()->GetNodeIndex() + nOffset == aInsPos.GetNodeIndex() -
aPam.End()->GetNodeIndex());
+assert(oPam->End()->GetNodeIndex() -
oPam->Start()->GetNodeIndex() + nOffset == aInsPos.GetNodeIndex() -
oPam->End()->GetNodeIndex());
else
-assert(aPam.Start()->GetNodeIndex() -
aPam.End()->GetNodeIndex() + nOffset == aInsPos.GetNodeIndex() -
aPam.End()->GetNodeIndex());
+assert(oPam->Start()->GetNodeIndex() -
oPam->End()->GetNodeIndex() + nOffset == aInsPos.GetNodeIndex() -
oPam->End()->GetNodeIndex());
SwRedlineTable::size_type i;
-getIDocumentRedlineAccess().GetRedline(*aPam.End(), );
+getIDocumentRedlineAccess().GetRedline(*oPam->End(), );
for ( ; 0 < i; --i)
{ // iterate backwards and offset via the start nodes difference
SwRangeRedline const*const pRedline =
getIDocumentRedlineAccess().GetRedlineTable()[i - 1];
-if (*pRedline->End() < *aPam.Start())
+if (*pRedline->End() < *oPam->Start())
{
break;
}
if (pRedline->GetType() == RedlineType::Delete &&
// tdf#145066 skip full-paragraph deletion which was
jumped over
// in Show Changes mode to avoid of deleting an extra row
-*aPam.Start() <= *pRedline->Start())
+*oPam->Start() <= *pRedline->Start())
{
SwRangeRedline* pNewRedline;
{
SwPaM pam(*pRedline, nullptr);
SwNodeOffset const nCurrentOffset(
-nOrigIdx - aPam.Start()->GetNodeIndex());
+nOrigIdx - oPam->Start()->GetNodeIndex());
pam.GetPoint()->Assign(pam.GetPoint()->GetNodeIndex()
+ nCurrentOffset,
pam.GetPoint()->GetContentIndex());
pam.GetMark()->Assign(pam.GetMark()->GetNodeIndex() +
nCurrentOffset,
@@ -2232,13 +2232,13 @@ bool SwDoc::MoveParagraphImpl(SwPaM& rPam, SwNodeOffset
const nOffset,
}
rOrigPam.GetPoint()->Adjust(SwNodeOffset(1));
-assert(*aPam.GetMark() < *aPam.GetPoint());
-if (aPam.GetPoint()->GetNode().IsEndNode())
+assert(*oPam->GetMark() < *oPam->GetPoint());
+if (oPam->GetPoint()->GetNode().IsEndNode())
{ // ensure redline ends on content node
-aPam.GetPoint()->Adjust(SwNodeOffset(-1));
-assert(aPam.GetPoint()->GetNode().IsTextNode());
-SwTextNode *const
pNode(aPam.GetPoint()->GetNode().GetTextNode());
-aPam.GetPoint()->SetContent(pNode->Len());
+oPam->GetPoint()->Adjust(SwNodeOffset(-1));
+assert(oPam->GetPoint()->GetNode().IsTextNode());
+SwTextNode *const
[Libreoffice-commits] core.git: sd/inc sd/qa sd/source
sd/inc/drawdoc.hxx |2 +-
sd/qa/unit/export-tests-ooxml2.cxx |4 ++--
sd/source/core/drawdoc2.cxx | 16
sd/source/filter/eppt/eppt.hxx |4 ++--
sd/source/filter/eppt/epptso.cxx | 24
sd/source/filter/eppt/pptexanimations.cxx| 19 +--
sd/source/filter/eppt/pptexanimations.hxx|4 ++--
sd/source/filter/eppt/pptx-epptooxml.cxx | 10 +-
sd/source/filter/sdpptwrp.cxx|6 +++---
sd/source/ui/presenter/PresenterTextView.cxx | 12 ++--
10 files changed, 50 insertions(+), 51 deletions(-)
New commits:
commit 429e327d143a913b93b5788129b33bd26a43
Author: Noel Grandin
AuthorDate: Mon Oct 10 11:49:26 2022 +0200
Commit: Noel Grandin
CommitDate: Tue Oct 11 18:02:11 2022 +0200
use more string_view in sd
Change-Id: Iafcab8d5b21f9562838c3494cbfd75090dd6e010
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141152
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sd/inc/drawdoc.hxx b/sd/inc/drawdoc.hxx
index a99c27c49bd1..9637e8f26cc2 100644
--- a/sd/inc/drawdoc.hxx
+++ b/sd/inc/drawdoc.hxx
@@ -598,7 +598,7 @@ public:
SdStyleSheetPool* GetSdStyleSheetPool() const;
SAL_DLLPRIVATE void UpdatePageRelativeURLs(
-const OUString& rOldName, std::u16string_view rNewName);
+std::u16string_view aOldName, std::u16string_view aNewName);
SAL_DLLPRIVATE static void SetCalcFieldValueHdl( ::Outliner* pOutliner);
diff --git a/sd/qa/unit/export-tests-ooxml2.cxx
b/sd/qa/unit/export-tests-ooxml2.cxx
index 4366d26fddd1..928ecab95997 100644
--- a/sd/qa/unit/export-tests-ooxml2.cxx
+++ b/sd/qa/unit/export-tests-ooxml2.cxx
@@ -33,9 +33,9 @@ using namespace css::animations;
namespace {
-bool checkBeginWithNumber(const OUString& rStr)
+bool checkBeginWithNumber(std::u16string_view aStr)
{
-sal_Unicode aChar = (rStr.getLength() > 1) ? rStr[0] : '\0';
+sal_Unicode aChar = (aStr.size() > 1) ? aStr[0] : '\0';
return aChar == '.' || aChar == '-' || rtl::isAsciiDigit(aChar);
}
diff --git a/sd/source/core/drawdoc2.cxx b/sd/source/core/drawdoc2.cxx
index d0187bab0f8c..d591113fcca9 100644
--- a/sd/source/core/drawdoc2.cxx
+++ b/sd/source/core/drawdoc2.cxx
@@ -264,9 +264,9 @@ void SdDrawDocument::UpdatePageObjectsInNotes(sal_uInt16
nStartPos)
}
}
-void SdDrawDocument::UpdatePageRelativeURLs(const OUString& rOldName,
std::u16string_view rNewName)
+void SdDrawDocument::UpdatePageRelativeURLs(std::u16string_view aOldName,
std::u16string_view aNewName)
{
-if (rNewName.empty())
+if (aNewName.empty())
return;
SfxItemPool& rPool(GetPool());
@@ -282,22 +282,22 @@ void SdDrawDocument::UpdatePageRelativeURLs(const
OUString& rOldName, std::u16st
{
OUString aURL = pURLField->GetURL();
-if (!aURL.isEmpty() && (aURL[0] == 35) &&
(aURL.indexOf(rOldName, 1) == 1))
+if (!aURL.isEmpty() && (aURL[0] == 35) &&
(aURL.indexOf(aOldName, 1) == 1))
{
-if (aURL.getLength() == rOldName.getLength() + 1) //
standard page name
+if (aURL.getLength() == sal_Int32(aOldName.size() + 1)) //
standard page name
{
aURL = aURL.replaceAt(1, aURL.getLength() - 1, u"") +
-rNewName;
+aNewName;
pURLField->SetURL(aURL);
}
else
{
const OUString sNotes(SdResId(STR_NOTES));
-if (aURL.getLength() == rOldName.getLength() + 2 +
sNotes.getLength()
-&& aURL.indexOf(sNotes, rOldName.getLength() + 2)
== rOldName.getLength() + 2)
+if (aURL.getLength() == sal_Int32(aOldName.size()) + 2
+ sNotes.getLength()
+&& aURL.indexOf(sNotes, aOldName.size() + 2) ==
sal_Int32(aOldName.size() + 2))
{
aURL = aURL.replaceAt(1, aURL.getLength() - 1,
u"") +
-rNewName + " " + sNotes;
+aNewName + " " + sNotes;
pURLField->SetURL(aURL);
}
}
diff --git a/sd/source/filter/eppt/eppt.hxx b/sd/source/filter/eppt/eppt.hxx
index ee2219ddd316..635d5a2223a1 100644
--- a/sd/source/filter/eppt/eppt.hxx
+++ b/sd/source/filter/eppt/eppt.hxx
@@ -164,7 +164,7 @@ class PPTWriter final : public PPTWriterBase, public
PPTExBulletProvider
sal_uInt32 ImplMasterSlideListContainer( SvStream* pOutStrm );
public:
-static void WriteCString( SvStream&, const OUString&,
sal_uInt32 nInstance = 0 );
+static void
[Libreoffice-bugs] [Bug 148947] RTF document styles lost in V7.3.2
https://bugs.documentfoundation.org/show_bug.cgi?id=148947 raal changed: What|Removed |Added CC||r...@post.cz Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #7 from raal --- Reproducible Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 07aa8138db9bbaf222f2b7cea12a9f7d0a8192d7 CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: cs-CZ (cs_CZ); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150522] default dialog box size for Options cuts off fields on the right of the dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=150522 raal changed: What|Removed |Added CC||r...@post.cz --- Comment #4 from raal --- No repro with Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 07aa8138db9bbaf222f2b7cea12a9f7d0a8192d7 CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: cs-CZ (cs_CZ); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150222] REPORTBUILDER - Starting to set font for a text box crashes whole LO
https://bugs.documentfoundation.org/show_bug.cgi?id=150222 --- Comment #10 from Commit Notification --- Xisco Fauli committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/86a80403c68d433b81b8d8a35b2e71fb9f8cd3d6 tdf#150222: Use static_assert to check contiguous item ids It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: reportdesign/source
reportdesign/source/ui/misc/UITools.cxx |2 ++ 1 file changed, 2 insertions(+) New commits: commit 86a80403c68d433b81b8d8a35b2e71fb9f8cd3d6 Author: Xisco Fauli AuthorDate: Tue Oct 11 15:55:58 2022 +0200 Commit: Xisco Fauli CommitDate: Tue Oct 11 17:26:32 2022 +0200 tdf#150222: Use static_assert to check contiguous item ids Similar to 5e29b084eb0bfcfbc82622df5c445a6148531989 "tdf#151260, tdf#84930: Use static_assert to check contiguous item ids" Change-Id: I02836514b6904b79a16c2cd82200b9038d566731 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141226 Tested-by: Jenkins Reviewed-by: Xisco Fauli diff --git a/reportdesign/source/ui/misc/UITools.cxx b/reportdesign/source/ui/misc/UITools.cxx index 99f79ff217d7..ae54ed3a6c56 100644 --- a/reportdesign/source/ui/misc/UITools.cxx +++ b/reportdesign/source/ui/misc/UITools.cxx @@ -165,6 +165,8 @@ #define ITEMID_POSTURE_COMPLEX TypedWhichId(ITEMID_FIRST + 35) #define ITEMID_WEIGHT_COMPLEX TypedWhichId(ITEMID_FIRST + 36) +static_assert((ITEMID_WEIGHT_COMPLEX - XATTR_FILL_FIRST) == 56, "Item ids are not contiguous"); + #define WESTERN 0 #define ASIAN 1 #define COMPLEX 2
[Libreoffice-bugs] [Bug 148256] Deadlocks while typing (macOS only?)
https://bugs.documentfoundation.org/show_bug.cgi?id=148256 --- Comment #14 from frank.tsi...@yahoo.com --- @Steve No I am not using any window manager. However, I do have some more information on this issue. Deadlocks would occur for various activities, however under certain test environments (see end of post) certain actions would trigger the deadlock with high probability. Environment A would show this for typing text in a table consistently. However, I think that typing text into a table is just a red herring for the deadlock issue. I think it maybe related to toolbar state. Process What I did try to do was to make LibreOffice the same for all 3 testing environments since there was some discussion that it may be an OS version issue. This included completely clearing out "~/Library/Application Support/libreoffice/4/" files and reinstalling from the same install image. Dead Lock Observations ~~ Running with a clean install and default setup in general reduced the frequency of deadlocks. However after copying my desired setting files back the frequency of deadlocks increase. Staring from the default setup and making changes manually it seems like increasing the number of visible toolbars and increasing the number of tools on the tool bar increased deadlock. So it is not likely a corrupt settings file. When selecting "User Interface \ Single Tool bar" it was much more difficult to reproduce deadlock in all 3 environments. With lots a tool bars showing just losing focus could trigger a dead-lock (spinning ball would briefly appear before libreoffice lost focus then when clicking on libreoffice again it would be in deadlock). I could get this to occur in environments A and B pretty consistently. It would happen in environment C intermittently and often took a lot of work / time to trigger. I also noticed that toolbar state would change (grey-out tools) when losing focus to another application. Unstable Versions ~ Both libreoffice version 7.2.6 and version 7.2.7 suffers from deadlock. In environments A and B I would get a deadlocks with my preferred toolbar settings consistently for certain actions (get deadlock, restart, perform same action and get deadlock again) and randomly maybe every hour of usage. In environment C I would get deadlock maybe once a day sometimes less when using it all day. Stable Version ~ I have now been using version 6.2.8.2 daily on large documents for over 3 months without a single dead-lock. It seams like version 6.2.8.2 does not suffer from this issue. Testing Environments (A, B, C) ~~~ A) On MacOS (10.11.6) running very old hardware dead locks were easily reproducible when editing table text. B) On MacOS (10.14.6) running on old hardware dead locks occurred but sporadically. C) On MacOS (12.6) running on newer hardware dead locks occurred but where harder to reproduce (hours). Not sure if the differences in dead lock reproducibility is due to the OS version or hardware or a combination of the two. I'm guessing it is a timing thing which would be affected by both hardware and software. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142617] FILEOPEN PPTX First line indent and hanging indent incorrectly imported in bulleted paragraphs
https://bugs.documentfoundation.org/show_bug.cgi?id=142617 raal changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 CC||r...@post.cz --- Comment #11 from raal --- Confirm with Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 07aa8138db9bbaf222f2b7cea12a9f7d0a8192d7 CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: cs-CZ (cs_CZ); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 113189] Asian phonetic guide for Chinese (Taiwan) zh_TW locale should behave as in mono ruby by default due to Bopomofo
https://bugs.documentfoundation.org/show_bug.cgi?id=113189 Julien Nabet changed: What|Removed |Added CC|serval2...@yahoo.fr | --- Comment #5 from Julien Nabet --- (In reply to Julien Nabet from comment #4) > I gave a start with https://gerrit.libreoffice.org/c/core/+/141143 > Not sure it's finished. > > To test it, you must select "Chinese (traditional)" in Locale setting. > I expected to find "Chinese (Taiwan)" since there's already "Chinese > (Singapore)", "Chinese (Hong-Kong)" or "Chinese (Macau)". Since the patch was wrong, I abandoned it. I can't help here=>uncc myself. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148754] bug - libreoffice portable math [Polish] - bad characters
https://bugs.documentfoundation.org/show_bug.cgi?id=148754 raal changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO --- Comment #5 from raal --- Hello, probably missing font at your PC. See https://bugs.documentfoundation.org/show_bug.cgi?id=94979 Try to install the font. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103100] [META] Writer table bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=103100 Rafael Lima changed: What|Removed |Added Depends on||151459 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=151459 [Bug 151459] LO Writer TABLE VIEWING: Table cells with vertical text orientation are not displayed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151459] LO Writer TABLE VIEWING: Table cells with vertical text orientation are not displayed
https://bugs.documentfoundation.org/show_bug.cgi?id=151459 Rafael Lima changed: What|Removed |Added Blocks||103100 CC||rafael.palma.l...@gmail.com --- Comment #8 from Rafael Lima --- Opens fine with Version: 7.2.7.2 / LibreOffice Community Build ID: 8d71d29d553c0f7dcbfa38fbfda25ee34cce99a2 CPU threads: 16; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb) Locale: pt-BR (pt_BR.UTF-8); UI: en-US Calc: CL Also fine in Version: 7.3.6.2 / LibreOffice Community Build ID: c28ca90fd6e1a19e189fc16c05f8f8924961e12e CPU threads: 16; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb) Locale: pt-BR (pt_BR.UTF-8); UI: en-US Calc: CL NOT FINE in Version: 7.4.1.2 / LibreOffice Community Build ID: 40(Build:2) CPU threads: 16; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb) Locale: pt-BR (pt_BR.UTF-8); UI: en-US Ubuntu package version: 1:7.4.1~rc2-0ubuntu0.22.04.1~lo1 Calc: threaded Fine again in Version: 7.5.0.0.alpha0+ / LibreOffice Community Build ID: d1707bc31261d16893c1f5240c803d283e293ec1 CPU threads: 16; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb) Locale: pt-BR (pt_BR.UTF-8); UI: en-US Calc: CL threaded So it seems to be a bug that appeared and was fixed along the way. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103100 [Bug 103100] [META] Writer table bugs -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150154] Axis Format in Libre Office Calc Does Not Change
https://bugs.documentfoundation.org/show_bug.cgi?id=150154 raal changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149925] Changes color of text in Excel files from "Red" to "Orange".
https://bugs.documentfoundation.org/show_bug.cgi?id=149925 raal changed: What|Removed |Added CC||r...@post.cz Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO --- Comment #5 from raal --- Thank you for reporting the bug. Please attach a sample document, as this makes it easier for us to verify the bug. I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' once the requested document is provided. (Please note that the attachment will be public, remove any sensitive information before attaching it. See https://wiki.documentfoundation.org/QA/FAQ#How_can_I_eliminate_confidential_data_from_a_sample_document.3F for help on how to do so.) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/source
sw/source/core/doc/docredln.cxx |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) New commits: commit 95933b725ff4f8f909fa5520f3e7fe0215715edb Author: Noel Grandin AuthorDate: Tue Oct 11 12:19:36 2022 +0200 Commit: Noel Grandin CommitDate: Tue Oct 11 16:49:29 2022 +0200 no need to touch nContent here part of the process of hiding the internals of SwPosition Change-Id: I15ed83739b12aebe7c7cd7fbdd528fa0cd282582 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141212 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/sw/source/core/doc/docredln.cxx b/sw/source/core/doc/docredln.cxx index cfd77733e331..37e869b8f7af 100644 --- a/sw/source/core/doc/docredln.cxx +++ b/sw/source/core/doc/docredln.cxx @@ -1712,9 +1712,8 @@ void SwRangeRedline::DelCopyOfSection(size_t nMyPos) *GetMark() = *pEnd; DeleteMark(); -aPam.GetBound().nContent.Assign( nullptr, 0 ); -aPam.GetBound( false ).nContent.Assign( nullptr, 0 ); aPam.DeleteMark(); +aPam.GetPoint()->SetContent(0);; rDoc.getIDocumentContentOperations().DelFullPara( aPam ); } }
[Libreoffice-bugs] [Bug 151470] OLE preview images are getting lost after opening
https://bugs.documentfoundation.org/show_bug.cgi?id=151470 Miklos Vajna changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |vmik...@collabora.com |desktop.org | Status|UNCONFIRMED |ASSIGNED Ever confirmed|0 |1 --- Comment #1 from Miklos Vajna --- Created attachment 182975 --> https://bugs.documentfoundation.org/attachment.cgi?id=182975=edit Corrupted document after save. How it looks after saving. The documents can be checked also on Linux, but the problematic codepath to corrupt it is Windows-specific. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151462] sub-indexes do not update
https://bugs.documentfoundation.org/show_bug.cgi?id=151462 Rafael Lima changed: What|Removed |Added Blocks||89606 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=89606 [Bug 89606] [META] Table of Contents and Indexes bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 89606] [META] Table of Contents and Indexes bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=89606 Rafael Lima changed: What|Removed |Added Depends on||151462 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=151462 [Bug 151462] sub-indexes do not update -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151470] New: OLE preview images are getting lost after opening
https://bugs.documentfoundation.org/show_bug.cgi?id=151470 Bug ID: 151470 Summary: OLE preview images are getting lost after opening Product: LibreOffice Version: unspecified Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: vmik...@collabora.com Created attachment 182974 --> https://bugs.documentfoundation.org/attachment.cgi?id=182974=edit Original bugdoc Steps to reproduce the problem: 1) Open the attached document on Windows. It contains an embedded object (PDF), so make sure that Adobe Acrobat Reader is installed. 2) Double-click on the embedded object to open it in Adobe Acrobat. 3) Close Acrobat. 4) Save the document. 5) Close & open the document. Expected result: the preview is similar to the initial one, since no change was made. Actual result: the preview is broken. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151462] sub-indexes do not update
https://bugs.documentfoundation.org/show_bug.cgi?id=151462 Rafael Lima changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW Keywords||bibisectRequest, regression CC||rafael.palma.l...@gmail.com --- Comment #2 from Rafael Lima --- Indeed this seems to work in Version: 7.3.6.2 / LibreOffice Community Build ID: c28ca90fd6e1a19e189fc16c05f8f8924961e12e CPU threads: 16; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb) Locale: pt-BR (pt_BR.UTF-8); UI: en-US Calc: CL But it does not work in Version: 7.4.1.2 / LibreOffice Community Build ID: 40(Build:2) CPU threads: 16; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb) Locale: pt-BR (pt_BR.UTF-8); UI: en-US Ubuntu package version: 1:7.4.1~rc2-0ubuntu0.22.04.1~lo1 Calc: threaded So it's a regression. Up until LO 7.3.6 if you right click the second index and select "Update Index", all entries are shown. In LO 7.4.1 this no longer works. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: filter/source
filter/source/msfilter/msvbahelper.cxx |1 +
1 file changed, 1 insertion(+)
New commits:
commit 195cb01573cbc92545cbc84cbb7dd09bbb4ae692
Author: Justin Luth
AuthorDate: Mon Oct 10 22:39:27 2022 -0400
Commit: Justin Luth
CommitDate: Tue Oct 11 16:44:39 2022 +0200
tdf#148806 fix build for !HAVE_FEATURE_SCRIPTING
I noticed this on one function, but completely
missed it on the second one.
Change-Id: I6ca74485b0c40cec2b04003fe894159198186ebf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141220
Tested-by: Jenkins
Reviewed-by: Justin Luth
diff --git a/filter/source/msfilter/msvbahelper.cxx
b/filter/source/msfilter/msvbahelper.cxx
index a4e954531155..59d34ca5cec1 100644
--- a/filter/source/msfilter/msvbahelper.cxx
+++ b/filter/source/msfilter/msvbahelper.cxx
@@ -270,6 +270,7 @@ OUString resolveVBAMacro(SfxObjectShell const* pShell,
const OUString& rLibName,
(void) rLibName;
(void) rModuleName;
(void) rMacroName;
+(void) bOnlyPublic;
#else
if( pShell )
{
[Libreoffice-bugs] [Bug 136615] Re-consider date/time parts calculation for functions and formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=136615 --- Comment #17 from Nenad Antic --- Created attachment 182973 --> https://bugs.documentfoundation.org/attachment.cgi?id=182973=edit Showing date calc results including between different dates In response to comment 15. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - sc/source sw/source
sc/source/ui/docshell/impex.cxx | 22 --
sw/source/core/fields/ddefld.cxx | 10 +++---
2 files changed, 23 insertions(+), 9 deletions(-)
New commits:
commit 2df4bd1dda0b233aadd8e09012df7b8530fa631c
Author: Mike Kaganski
AuthorDate: Sat Oct 8 22:10:44 2022 +0300
Commit: Xisco Fauli
CommitDate: Tue Oct 11 16:34:54 2022 +0200
tdf#151429: don't convert OUStrings to system encoding
... just to convert back to OUString in the end.
Change-Id: I727d5e4c03d1a49f64bd5ca3d64157a9149cd9ef
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141125
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
(cherry picked from commit 94df17f58fe6269452b7252b712a89978c444bec)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141073
Reviewed-by: Xisco Fauli
diff --git a/sc/source/ui/docshell/impex.cxx b/sc/source/ui/docshell/impex.cxx
index 9c43453f2fc3..3be11884ca72 100644
--- a/sc/source/ui/docshell/impex.cxx
+++ b/sc/source/ui/docshell/impex.cxx
@@ -288,14 +288,24 @@ bool ScImportExport::ExportData( const OUString&
rMimeType,
css::uno::Any & rValue )
{
SvMemoryStream aStrm;
+SotClipboardFormatId fmtId =
SotExchange::GetFormatIdFromMimeType(rMimeType);
+if (fmtId == SotClipboardFormatId::STRING)
+aStrm.SetStreamCharSet(RTL_TEXTENCODING_UNICODE);
// mba: no BaseURL for data exchange
-if( ExportStream( aStrm, OUString(),
-SotExchange::GetFormatIdFromMimeType( rMimeType ) ))
+if (ExportStream(aStrm, OUString(), fmtId))
{
-aStrm.WriteUChar( 0 );
-rValue <<= css::uno::Sequence< sal_Int8 >(
-static_cast(aStrm.GetData()),
-aStrm.TellEnd() );
+if (fmtId == SotClipboardFormatId::STRING)
+{
+assert(aStrm.TellEnd() % sizeof(sal_Unicode) == 0);
+rValue <<= OUString(static_cast(aStrm.GetData()),
+aStrm.TellEnd() / sizeof(sal_Unicode));
+}
+else
+{
+aStrm.WriteUChar(0);
+rValue <<= css::uno::Sequence(static_cast(aStrm.GetData()),
+aStrm.TellEnd());
+}
return true;
}
return false;
diff --git a/sw/source/core/fields/ddefld.cxx b/sw/source/core/fields/ddefld.cxx
index 8b326d02cd62..f73a2b641820 100644
--- a/sw/source/core/fields/ddefld.cxx
+++ b/sw/source/core/fields/ddefld.cxx
@@ -69,9 +69,13 @@ public:
case SotClipboardFormatId::STRING:
if( !IsNoDataFlag() )
{
-uno::Sequence< sal_Int8 > aSeq;
-rValue >>= aSeq;
-OUString sStr( reinterpret_cast(aSeq.getConstArray()), aSeq.getLength(), osl_getThreadTextEncoding() );
+OUString sStr;
+if (!(rValue >>= sStr))
+{
+uno::Sequence< sal_Int8 > aSeq;
+rValue >>= aSeq;
+sStr = OUString(reinterpret_cast(aSeq.getConstArray()), aSeq.getLength(), osl_getThreadTextEncoding());
+}
// remove not needed CR-LF at the end
sal_Int32 n = sStr.getLength();
[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - writerfilter/qa writerfilter/source
writerfilter/qa/cppunittests/dmapper/DomainMapper.cxx |
34 ++
writerfilter/qa/cppunittests/dmapper/data/sdt-dropdown-no-display-text.docx
|binary
writerfilter/source/dmapper/DomainMapper.cxx|
15
3 files changed, 49 insertions(+)
New commits:
commit e2095410b00b8a374ba35ea5fab584a79a46cfe2
Author: Miklos Vajna
AuthorDate: Mon Oct 10 10:07:10 2022 +0200
Commit: Xisco Fauli
CommitDate: Tue Oct 11 16:33:43 2022 +0200
tdf#151261 DOCX import: fix dropdown SDT when the item display text is
missing
Dropdown content controls have list items, and each list item can have a
display text and a value. These are optional, and the bugdoc has a list
item where the value is set, but not the display text.
The trouble is that later in DomainMapper_Impl::PopSdt() we check if the
length of the display texts and values array match and if not, then we
throw away these arrays to avoid creating an inconsistent document
model.
Fix the problem by checking what display text and value we got at the end
of each list item; if any of them is missing, we add an empty string,
which matches the internal representation in SwContentControlListItem.
This also helps in case these array sizes matched by accident, but
display texts and values from different list items were mixed
previously.
Change-Id: Ib1eeabd2479963af4a84d4229d4f0ce4572e0f01
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141151
Reviewed-by: Miklos Vajna
Tested-by: Jenkins
(cherry picked from commit f726fbc2699b05199a8dec3055710a7131e0aad6)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141071
Reviewed-by: Xisco Fauli
diff --git a/writerfilter/qa/cppunittests/dmapper/DomainMapper.cxx
b/writerfilter/qa/cppunittests/dmapper/DomainMapper.cxx
index 21d5c84cae4e..639c8e9e0303 100644
--- a/writerfilter/qa/cppunittests/dmapper/DomainMapper.cxx
+++ b/writerfilter/qa/cppunittests/dmapper/DomainMapper.cxx
@@ -13,6 +13,7 @@
#include
#include
#include
+#include
#include
@@ -95,6 +96,39 @@ CPPUNIT_TEST_FIXTURE(Test, testSdtRunInPara)
// i.e. the block-SDT-only string was lost.
CPPUNIT_ASSERT_EQUAL(OUString("first-second"), xPara->getString());
}
+
+CPPUNIT_TEST_FIXTURE(Test, testSdtDropdownNoDisplayText)
+{
+// Given a document with (no display text):
+OUString aURL
+= m_directories.getURLFromSrc(DATA_DIRECTORY) +
"sdt-dropdown-no-display-text.docx";
+
+// When loading that document:
+getComponent() = loadFromDesktop(aURL);
+
+// Then make sure we create a dropdown content control, not a rich text
one:
+uno::Reference xTextDocument(getComponent(),
uno::UNO_QUERY);
+uno::Reference
xParagraphsAccess(xTextDocument->getText(),
+
uno::UNO_QUERY);
+uno::Reference xParagraphs =
xParagraphsAccess->createEnumeration();
+uno::Reference
xParagraph(xParagraphs->nextElement(),
+ uno::UNO_QUERY);
+uno::Reference xPortions =
xParagraph->createEnumeration();
+uno::Reference xTextPortion(xPortions->nextElement(),
uno::UNO_QUERY);
+OUString aPortionType;
+xTextPortion->getPropertyValue("TextPortionType") >>= aPortionType;
+CPPUNIT_ASSERT_EQUAL(OUString("ContentControl"), aPortionType);
+uno::Reference xContentControl;
+xTextPortion->getPropertyValue("ContentControl") >>= xContentControl;
+uno::Reference xContentControlProps(xContentControl,
uno::UNO_QUERY);
+uno::Sequence aListItems;
+xContentControlProps->getPropertyValue("ListItems") >>= aListItems;
+// Without the accompanying fix in place, this test would have failed with:
+// - Expected: 1
+// - Actual : 0
+// i.e. the list item was lost on import.
+CPPUNIT_ASSERT_EQUAL(static_cast(1), aListItems.getLength());
+}
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git
a/writerfilter/qa/cppunittests/dmapper/data/sdt-dropdown-no-display-text.docx
b/writerfilter/qa/cppunittests/dmapper/data/sdt-dropdown-no-display-text.docx
new file mode 100644
index ..ed6d7ac54052
Binary files /dev/null and
b/writerfilter/qa/cppunittests/dmapper/data/sdt-dropdown-no-display-text.docx
differ
diff --git a/writerfilter/source/dmapper/DomainMapper.cxx
b/writerfilter/source/dmapper/DomainMapper.cxx
index c0689b4e2ac5..bfe9769e6293 100644
--- a/writerfilter/source/dmapper/DomainMapper.cxx
+++ b/writerfilter/source/dmapper/DomainMapper.cxx
@@ -2708,8 +2708,23 @@ void DomainMapper::sprmWithProps( Sprm& rSprm, const
PropertyMapPtr& rContext )
case NS_ooxml::LN_CT_SdtDropDownList_listItem:
{
writerfilter::Reference::Pointer_t pProperties =
rSprm.getProps();
+
+size_t nDropDownDisplayTexts =
m_pImpl->m_pSdtHelper->getDropDownDisplayTexts().size();
+
[Libreoffice-bugs] [Bug 136615] Re-consider date/time parts calculation for functions and formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=136615 --- Comment #16 from Nenad Antic --- (In reply to Eike Rathke from comment #15) > simply use > > =IF(AND(ISBLANK(D11),ISBLANK(E11)),"",ROUND((E11-D11)*24,2)) > > to subtract start from end date+time and express the difference as hours of > duration. Thank you for this tip. I'll try it. > > You'll also notice that most of your results will be unexpected because > starting at row 14 date+time in column D and E are of different days and the > result is a duration of 33 hours instead of 9 hours. This is strange. I have used it like this for years and it works. Please see my new attachment. If it's showing 33 hours at your end it seems like it's platform dependent. -- You are receiving this mail because: You are the assignee for the bug.
