[Libreoffice-bugs] [Bug 132657] UI: Compress Image, reducing image resolution actually increases resolution
https://bugs.documentfoundation.org/show_bug.cgi?id=132657 Heiko Tietze changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||5161 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145161] Writer Impress : the image compression form should change the image resolution only if it decreases
https://bugs.documentfoundation.org/show_bug.cgi?id=145161 Heiko Tietze changed: What|Removed |Added Keywords|needsUXEval |difficultyBeginner, ||easyHack, skillDesign, ||topicUI Ever confirmed|0 |1 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda |.freedesktop.org|tion.org, ||mentoring@documentfoundatio ||n.org, ||stephane.guillou@libreoffic ||e.org See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||2657 Status|UNCONFIRMED |NEW --- Comment #9 from Heiko Tietze --- We discussed the topic in the design meeting. While I commented before that limiting the resolution to the source dpi could be done it's not possible since we also allow to change width/height (or we set a maximum here too). And changing the image size affects the resolution (whether this is necessary is a different question). So it's actually just the label that doesn't fit the current situation. And we propose to change it to "Change image resolution to:". We also pondered quickly over the dialog title (and command name) "Compress Image" but better keep this familiar term. Code pointer: svx/uiconfig/ui/compressgraphicdialog.ui This ticket kind of duplicates bug 132657, up to QA. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 145161] Writer Impress : the image compression form should change the image resolution only if it decreases
https://bugs.documentfoundation.org/show_bug.cgi?id=145161 Heiko Tietze changed: What|Removed |Added Keywords|needsUXEval |difficultyBeginner, ||easyHack, skillDesign, ||topicUI Ever confirmed|0 |1 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda |.freedesktop.org|tion.org, ||mentoring@documentfoundatio ||n.org, ||stephane.guillou@libreoffic ||e.org See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||2657 Status|UNCONFIRMED |NEW --- Comment #9 from Heiko Tietze --- We discussed the topic in the design meeting. While I commented before that limiting the resolution to the source dpi could be done it's not possible since we also allow to change width/height (or we set a maximum here too). And changing the image size affects the resolution (whether this is necessary is a different question). So it's actually just the label that doesn't fit the current situation. And we propose to change it to "Change image resolution to:". We also pondered quickly over the dialog title (and command name) "Compress Image" but better keep this familiar term. Code pointer: svx/uiconfig/ui/compressgraphicdialog.ui This ticket kind of duplicates bug 132657, up to QA. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - sw/source
sw/source/uibase/uiview/viewsrch.cxx | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) New commits: commit 137ffafbf43a07446835539a4e17b199d06e3aa7 Author: Caolán McNamara AuthorDate: Thu Dec 15 16:20:31 2022 + Commit: Xisco Fauli CommitDate: Fri Dec 16 07:56:02 2022 + likely fix for frequent SfxViewFrame::GetChildWindow() crash crash report id: 58e9a91e-9feb-4eb4-a28e-27921d3e1b99 Change-Id: I110d96f1c73f95025918ccc4043dac40c5e1dc4f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144188 Tested-by: Jenkins Reviewed-by: Xisco Fauli diff --git a/sw/source/uibase/uiview/viewsrch.cxx b/sw/source/uibase/uiview/viewsrch.cxx index 7559b7bf2fb8..269bce441ed8 100644 --- a/sw/source/uibase/uiview/viewsrch.cxx +++ b/sw/source/uibase/uiview/viewsrch.cxx @@ -830,9 +830,13 @@ SvxSearchDialog* SwView::GetSearchDialog() { #if HAVE_FEATURE_DESKTOP const sal_uInt16 nId = SvxSearchDialogWrapper::GetChildWindowId(); -SvxSearchDialogWrapper *pWrp = static_cast( SfxViewFrame::Current()->GetChildWindow(nId) ); -auto pSrchDlg = pWrp ? pWrp->getDialog() : nullptr; -return pSrchDlg; +SfxViewFrame* pFrame = SfxViewFrame::Current(); +if (!pFrame) +return nullptr; +SvxSearchDialogWrapper *pWrp = static_cast(pFrame->GetChildWindow(nId)); +if (!pWrp) +return nullptr; +return pWrp->getDialog(); #else return nullptr; #endif
[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - sw/source
sw/source/ui/fldui/fldtdlg.cxx |7 - sw/source/ui/index/swuiidxmrk.cxx | 15 sw/source/uibase/app/docst.cxx |3 +- sw/source/uibase/envelp/syncbtn.cxx |3 +- sw/source/uibase/ribbar/workctrl.cxx| 14 +++ sw/source/uibase/shells/translatehelper.cxx |2 - sw/source/uibase/sidebar/PageOrientationControl.cxx | 25 +++- 7 files changed, 44 insertions(+), 25 deletions(-) New commits: commit 223c5b7fe5e2a967f8b6067ba435410b57faa49a Author: Caolán McNamara AuthorDate: Thu Dec 15 16:48:09 2022 + Commit: Xisco Fauli CommitDate: Fri Dec 16 07:54:12 2022 + sw: check SfxViewFrame::Current() these ones looks potentially worth backporting Change-Id: I294fa029b53fa9d43cb738f07278301e2a06c210 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144254 Tested-by: Jenkins Reviewed-by: Xisco Fauli diff --git a/sw/source/ui/fldui/fldtdlg.cxx b/sw/source/ui/fldui/fldtdlg.cxx index a3886591a4c2..3c83365a206f 100644 --- a/sw/source/ui/fldui/fldtdlg.cxx +++ b/sw/source/ui/fldui/fldtdlg.cxx @@ -180,8 +180,11 @@ void SwFieldDlg::ReInitDlg() if (bNewMode != m_bHtmlMode) { -SfxViewFrame::Current()->GetDispatcher()-> -Execute(FN_INSERT_FIELD, SfxCallMode::ASYNCHRON|SfxCallMode::RECORD); +if (SfxViewFrame* pViewFrm = SfxViewFrame::Current()) +{ +pViewFrm->GetDispatcher()-> +Execute(FN_INSERT_FIELD, SfxCallMode::ASYNCHRON|SfxCallMode::RECORD); +} Close(); } diff --git a/sw/source/ui/index/swuiidxmrk.cxx b/sw/source/ui/index/swuiidxmrk.cxx index 8166b4713c7e..fe3fa2b67282 100644 --- a/sw/source/ui/index/swuiidxmrk.cxx +++ b/sw/source/ui/index/swuiidxmrk.cxx @@ -686,8 +686,11 @@ IMPL_LINK_NOARG(SwIndexMarkPane, CloseHdl, weld::Button&, void) { if (m_bNewMark) { - SfxViewFrame::Current()->GetDispatcher()->Execute(FN_INSERT_IDX_ENTRY_DLG, -SfxCallMode::ASYNCHRON|SfxCallMode::RECORD); +if (SfxViewFrame* pViewFrm = SfxViewFrame::Current()) +{ +pViewFrm->GetDispatcher()->Execute(FN_INSERT_IDX_ENTRY_DLG, +SfxCallMode::ASYNCHRON|SfxCallMode::RECORD); +} } else { @@ -819,7 +822,8 @@ IMPL_LINK_NOARG(SwIndexMarkPane, DelHdl, weld::Button&, void) else { CloseHdl(*m_xCloseBT); - SfxViewFrame::Current()->GetBindings().Invalidate(FN_EDIT_IDX_ENTRY_DLG); +if (SfxViewFrame* pViewFrm = SfxViewFrame::Current()) +pViewFrm->GetBindings().Invalidate(FN_EDIT_IDX_ENTRY_DLG); } } @@ -1218,8 +1222,11 @@ IMPL_LINK_NOARG(SwAuthorMarkPane, CloseHdl, weld::Button&, void) { if(m_bNewEntry) { - SfxViewFrame::Current()->GetDispatcher()->Execute(FN_INSERT_AUTH_ENTRY_DLG, +if (SfxViewFrame* pViewFrm = SfxViewFrame::Current()) +{ +pViewFrm->GetDispatcher()->Execute(FN_INSERT_AUTH_ENTRY_DLG, SfxCallMode::ASYNCHRON|SfxCallMode::RECORD); +} } else { diff --git a/sw/source/uibase/app/docst.cxx b/sw/source/uibase/app/docst.cxx index baa2a4ca74ef..f13b90b70af6 100644 --- a/sw/source/uibase/app/docst.cxx +++ b/sw/source/uibase/app/docst.cxx @@ -1186,7 +1186,8 @@ SfxStyleFamily SwDocShell::ApplyStyles(const OUString , SfxStyleFamily nFa const SwNumRule* pNumRule = pStyle->GetNumRule(); if (pNumRule->GetName() == SwResId(STR_POOLNUMRULE_NOLIST)) { - SfxViewFrame::Current()->GetDispatcher()->Execute(FN_NUM_BULLET_OFF); +if (SfxViewFrame* pViewFrm = SfxViewFrame::Current()) +pViewFrm->GetDispatcher()->Execute(FN_NUM_BULLET_OFF); break; } const OUString sListIdForStyle =pNumRule->GetDefaultListId(); diff --git a/sw/source/uibase/envelp/syncbtn.cxx b/sw/source/uibase/envelp/syncbtn.cxx index 0b61ff8a6c72..0b30c494b044 100644 --- a/sw/source/uibase/envelp/syncbtn.cxx +++ b/sw/source/uibase/envelp/syncbtn.cxx @@ -80,7 +80,8 @@ SwSyncBtnDlg::~SwSyncBtnDlg() IMPL_STATIC_LINK_NOARG(SwSyncBtnDlg, BtnHdl, weld::Button&, void) { -SfxViewFrame::Current()->GetDispatcher()->Execute(FN_UPDATE_ALL_LINKS, SfxCallMode::ASYNCHRON); +if (SfxViewFrame* pViewFrm = SfxViewFrame::Current()) +pViewFrm->GetDispatcher()->Execute(FN_UPDATE_ALL_LINKS, SfxCallMode::ASYNCHRON); } /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/sw/source/uibase/ribbar/workctrl.cxx b/sw/source/uibase/ribbar/workctrl.cxx index 8d7338281a42..53c747e478ed 100644 --- a/sw/source/uibase/ribbar/workctrl.cxx +++ b/sw/source/uibase/ribbar/workctrl.cxx @@ -420,10 +420,11 @@ void SwZoomBox_Impl::Select() m_xWidget->set_entry_text(m_xWidget->get_saved_value()); } -
[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - sd/source
sd/source/ui/view/unmodpg.cxx | 16 1 file changed, 12 insertions(+), 4 deletions(-) New commits: commit 2f3cf8afa905a83cd3b24a6ae35b164ed10cba44 Author: Xisco Fauli AuthorDate: Thu Dec 15 17:20:20 2022 +0100 Commit: Xisco Fauli CommitDate: Fri Dec 16 07:53:18 2022 + sd: fix null deref in ModifyPageUndoAction::Undo/Redo See https://crashreport.libreoffice.org/stats/signature/SfxViewFrame::GetDispatcher() Change-Id: Iaf14ad8fd5dab878ea5e3d6997371c2d8a4beac6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144192 Tested-by: Jenkins Reviewed-by: Xisco Fauli diff --git a/sd/source/ui/view/unmodpg.cxx b/sd/source/ui/view/unmodpg.cxx index 2fdfbd13a9bb..afd454a5f183 100644 --- a/sd/source/ui/view/unmodpg.cxx +++ b/sd/source/ui/view/unmodpg.cxx @@ -118,8 +118,12 @@ void ModifyPageUndoAction::Undo() } // Redisplay -SfxViewFrame::Current()->GetDispatcher()->Execute( -SID_SWITCHPAGE, SfxCallMode::ASYNCHRON | SfxCallMode::RECORD ); +SfxViewFrame* pCurrent = SfxViewFrame::Current(); +if( pCurrent ) +{ +pCurrent->GetDispatcher()->Execute( +SID_SWITCHPAGE, SfxCallMode::ASYNCHRON | SfxCallMode::RECORD ); +} } void ModifyPageUndoAction::Redo() @@ -161,8 +165,12 @@ void ModifyPageUndoAction::Redo() } // Redisplay -SfxViewFrame::Current()->GetDispatcher()->Execute( -SID_SWITCHPAGE, SfxCallMode::ASYNCHRON | SfxCallMode::RECORD ); +SfxViewFrame* pCurrent = SfxViewFrame::Current(); +if( pCurrent ) +{ +pCurrent->GetDispatcher()->Execute( +SID_SWITCHPAGE, SfxCallMode::ASYNCHRON | SfxCallMode::RECORD ); +} } ModifyPageUndoAction::~ModifyPageUndoAction()
[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - sfx2/source
sfx2/source/appl/app.cxx |2 +- sfx2/source/commandpopup/CommandPopup.cxx |2 ++ sfx2/source/control/charmapcontrol.cxx|7 +-- sfx2/source/control/request.cxx |8 +++- 4 files changed, 15 insertions(+), 4 deletions(-) New commits: commit c70c85b67c5f5e046eacfcabcde37edc58653f35 Author: Caolán McNamara AuthorDate: Thu Dec 15 20:00:26 2022 + Commit: Xisco Fauli CommitDate: Fri Dec 16 07:53:00 2022 + sfx2: check SfxViewFrame::Current() these ones look potentially worth backporting Change-Id: I9391f266b08e3842f9686db6113b61fa814f3fbb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144257 Tested-by: Jenkins Reviewed-by: Xisco Fauli diff --git a/sfx2/source/appl/app.cxx b/sfx2/source/appl/app.cxx index 4b5adbdf8a2b..3d3adb84bfe4 100644 --- a/sfx2/source/appl/app.cxx +++ b/sfx2/source/appl/app.cxx @@ -410,7 +410,7 @@ IMPL_STATIC_LINK( SfxApplication, GlobalBasicErrorHdl_Impl, StarBASIC*, pStarBas const SfxViewFrame* pViewFrame = SfxViewFrame::Current(); std::shared_ptr xBox; xBox.reset(Application::CreateMessageDialog( - pViewFrame->GetFrameWeld(), + pViewFrame ? pViewFrame->GetFrameWeld() : nullptr, VclMessageType::Error, VclButtonsType::Ok, aError, diff --git a/sfx2/source/commandpopup/CommandPopup.cxx b/sfx2/source/commandpopup/CommandPopup.cxx index 47df143a889b..f4cdf92436c7 100644 --- a/sfx2/source/commandpopup/CommandPopup.cxx +++ b/sfx2/source/commandpopup/CommandPopup.cxx @@ -152,6 +152,8 @@ void MenuContentHandler::addCommandIfPossible( return; auto* pViewFrame = SfxViewFrame::Current(); +if (!pViewFrame) +return; SfxSlotPool& rSlotPool = SfxSlotPool::GetSlotPool(pViewFrame); const SfxSlot* pSlot = rSlotPool.GetUnoSlot(aCommandURL.Path); diff --git a/sfx2/source/control/charmapcontrol.cxx b/sfx2/source/control/charmapcontrol.cxx index 032306b8a85f..a79da745be26 100644 --- a/sfx2/source/control/charmapcontrol.cxx +++ b/sfx2/source/control/charmapcontrol.cxx @@ -207,8 +207,11 @@ IMPL_LINK_NOARG(SfxCharmapCtrl, OpenDlgHdl, weld::Button&, void) { m_xControl->EndPopupMode(); -uno::Reference xFrame = SfxViewFrame::Current()->GetFrame().GetFrameInterface(); -comphelper::dispatchCommand(".uno:InsertSymbol", xFrame, {}); +if (SfxViewFrame* pViewFrm = SfxViewFrame::Current()) +{ +uno::Reference xFrame = pViewFrm->GetFrame().GetFrameInterface(); +comphelper::dispatchCommand(".uno:InsertSymbol", xFrame, {}); +} } void SfxCharmapCtrl::GrabFocus() diff --git a/sfx2/source/control/request.cxx b/sfx2/source/control/request.cxx index 964a256b19a7..b43d1dd991bc 100644 --- a/sfx2/source/control/request.cxx +++ b/sfx2/source/control/request.cxx @@ -687,8 +687,14 @@ css::uno::Reference< css::frame::XDispatchRecorder > SfxRequest::GetMacroRecorde { css::uno::Reference< css::frame::XDispatchRecorder > xRecorder; +if (!pView) +pView = SfxViewFrame::Current(); + +if (!pView) +return xRecorder; + css::uno::Reference< css::beans::XPropertySet > xSet( -(pView ? pView : SfxViewFrame::Current())->GetFrame().GetFrameInterface(), +pView->GetFrame().GetFrameInterface(), css::uno::UNO_QUERY); if(xSet.is())
[Libreoffice-ux-advise] [Bug 152481] Dedicated sidebar deck for table-related functions
https://bugs.documentfoundation.org/show_bug.cgi?id=152481 Heiko Tietze changed: What|Removed |Added Keywords|needsUXEval | CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda |.freedesktop.org|tion.org Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #2 from Heiko Tietze --- We discussed the topic in the design meeting. A special tab requires a reasonable number of controls and a distinctive workflow so switching between properties (or another tab) and the to be introduced table tab is not needed too often. We think it's the fact here. (Automatically switching depending on the context would be a mistake.) (In reply to Stéphane Guillou (stragu) from comment #0) > - Will Table Designs replace (/ be merged with) the table styles / > AutoFormats Writer has? > - Are we fracturing the styles UI, that should all belong in the Styles deck? The table style is part of the manipulation and should be placed together with the other commands on the new tab, perhaps in an extra deck. And bug 101802 requests to "Consolidate Writer and Draw/Impress sidebar table design content panel". > - Are we fracturing the Properties deck, that should contain all the > formatting options? Properties should remain as it is for text editing. The supposed workflow is to create and style a table in the dedicated tab and work on the content with the properties tab open. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 152481] Dedicated sidebar deck for table-related functions
https://bugs.documentfoundation.org/show_bug.cgi?id=152481 Heiko Tietze changed: What|Removed |Added Keywords|needsUXEval | CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda |.freedesktop.org|tion.org Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #2 from Heiko Tietze --- We discussed the topic in the design meeting. A special tab requires a reasonable number of controls and a distinctive workflow so switching between properties (or another tab) and the to be introduced table tab is not needed too often. We think it's the fact here. (Automatically switching depending on the context would be a mistake.) (In reply to Stéphane Guillou (stragu) from comment #0) > - Will Table Designs replace (/ be merged with) the table styles / > AutoFormats Writer has? > - Are we fracturing the styles UI, that should all belong in the Styles deck? The table style is part of the manipulation and should be placed together with the other commands on the new tab, perhaps in an extra deck. And bug 101802 requests to "Consolidate Writer and Draw/Impress sidebar table design content panel". > - Are we fracturing the Properties deck, that should contain all the > formatting options? Properties should remain as it is for text editing. The supposed workflow is to create and style a table in the dedicated tab and work on the content with the properties tab open. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152512] Text document status bar reporting incorrect number of pages briefly then after a few seconds display the correct number of pages
https://bugs.documentfoundation.org/show_bug.cgi?id=152512 Stéphane Guillou (stragu) changed: What|Removed |Added Status|RESOLVED|UNCONFIRMED Resolution|INSUFFICIENTDATA|--- --- Comment #5 from Stéphane Guillou (stragu) --- If not sensitive, sharing the document that demonstrates the issue is a very big help! I thought that wasn't an option for you, but if you are able to, please do. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - sd/source
sd/source/ui/sidebar/SlideBackground.cxx | 28 1 file changed, 20 insertions(+), 8 deletions(-) New commits: commit 17852f4b6964a65f778863c197dfa3a924929195 Author: Caolán McNamara AuthorDate: Thu Dec 15 21:21:44 2022 + Commit: Xisco Fauli CommitDate: Fri Dec 16 07:51:53 2022 + likely fix for frequent mpGradientItem->GetName() crash crash report id: ec5a64d7-b354-457e-92a3-1bd51208e7c7 Change-Id: Ie64993190baa5e3ea9228214bea1ee4d82044c51 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144266 Tested-by: Jenkins Reviewed-by: Xisco Fauli diff --git a/sd/source/ui/sidebar/SlideBackground.cxx b/sd/source/ui/sidebar/SlideBackground.cxx index bcd564e7bbc1..11f49dff67eb 100644 --- a/sd/source/ui/sidebar/SlideBackground.cxx +++ b/sd/source/ui/sidebar/SlideBackground.cxx @@ -1023,30 +1023,42 @@ IMPL_LINK_NOARG(SlideBackground, FillStyleModifyHdl, weld::ComboBox&, void) case SOLID: { -const XFillColorItem aItem( OUString(), mpColorItem->GetColorValue() ); -GetBindings()->GetDispatcher()->ExecuteList(SID_ATTR_PAGE_COLOR, SfxCallMode::RECORD, { }); +if (mpColorItem) +{ +const XFillColorItem aItem( OUString(), mpColorItem->GetColorValue() ); + GetBindings()->GetDispatcher()->ExecuteList(SID_ATTR_PAGE_COLOR, SfxCallMode::RECORD, { }); +} } break; case GRADIENT: { -const XFillGradientItem aItem( mpGradientItem->GetName(), mpGradientItem->GetGradientValue() ); - GetBindings()->GetDispatcher()->ExecuteList(SID_ATTR_PAGE_GRADIENT, SfxCallMode::RECORD, { }); +if (mpGradientItem) +{ +const XFillGradientItem aItem( mpGradientItem->GetName(), mpGradientItem->GetGradientValue() ); + GetBindings()->GetDispatcher()->ExecuteList(SID_ATTR_PAGE_GRADIENT, SfxCallMode::RECORD, { }); +} } break; case HATCH: { -const XFillHatchItem aItem( mpHatchItem->GetName(), mpHatchItem->GetHatchValue() ); -GetBindings()->GetDispatcher()->ExecuteList(SID_ATTR_PAGE_HATCH, SfxCallMode::RECORD, { }); +if (mpHatchItem) +{ +const XFillHatchItem aItem( mpHatchItem->GetName(), mpHatchItem->GetHatchValue() ); + GetBindings()->GetDispatcher()->ExecuteList(SID_ATTR_PAGE_HATCH, SfxCallMode::RECORD, { }); +} } break; case BITMAP: case PATTERN: { -const XFillBitmapItem aItem( mpBitmapItem->GetName(), mpBitmapItem->GetGraphicObject() ); -GetBindings()->GetDispatcher()->ExecuteList(SID_ATTR_PAGE_BITMAP, SfxCallMode::RECORD, { }); +if (mpBitmapItem) +{ +const XFillBitmapItem aItem( mpBitmapItem->GetName(), mpBitmapItem->GetGraphicObject() ); + GetBindings()->GetDispatcher()->ExecuteList(SID_ATTR_PAGE_BITMAP, SfxCallMode::RECORD, { }); +} } break;
[Libreoffice-bugs] [Bug 142971] LibreOffice crashes if I click or mouseover on the toolbar
https://bugs.documentfoundation.org/show_bug.cgi?id=142971 Dieter changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #6 from Dieter --- Gustav, is the problem still present in actual version of LO (LO 7.4). Does it only happen in Writer or in every component of LO? => NEEDINFO BTW: I've never heard, that there is a possibility to run desktop version of LO with android. So why sould it work? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - sd/source
sd/source/core/drawdoc4.cxx | 10 -- sd/source/ui/func/undoheaderfooter.cxx|6 -- sd/source/ui/view/Outliner.cxx| 10 ++ sd/source/ui/view/ViewShellImplementation.cxx | 14 +- 4 files changed, 27 insertions(+), 13 deletions(-) New commits: commit 39e1dbdd2e012eff64855de56c0b3a49245d12c4 Author: Caolán McNamara AuthorDate: Thu Dec 15 20:25:18 2022 + Commit: Xisco Fauli CommitDate: Fri Dec 16 07:50:49 2022 + sd: check SfxViewFrame::Current() these ones look potentially worth backporting Change-Id: I6153b0f9ead7caef9f228a5724f51823bcf87c07 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144281 Tested-by: Jenkins Reviewed-by: Xisco Fauli diff --git a/sd/source/core/drawdoc4.cxx b/sd/source/core/drawdoc4.cxx index 3c75dd4315e1..59045056853e 100644 --- a/sd/source/core/drawdoc4.cxx +++ b/sd/source/core/drawdoc4.cxx @@ -1068,9 +1068,15 @@ void SdDrawDocument::ImpOnlineSpellCallback(SpellCallbackInfo const * pInfo, Sdr StartOnlineSpelling(); } else if (nCommand == SpellCallbackCommand::STARTSPELLDLG) -SfxViewFrame::Current()->GetDispatcher()->Execute( SID_SPELL_DIALOG, SfxCallMode::ASYNCHRON ); +{ +if (SfxViewFrame* pViewFrame = SfxViewFrame::Current()) +pViewFrame->GetDispatcher()->Execute( SID_SPELL_DIALOG, SfxCallMode::ASYNCHRON ); +} else if (nCommand == SpellCallbackCommand::AUTOCORRECT_OPTIONS) -SfxViewFrame::Current()->GetDispatcher()->Execute( SID_AUTO_CORRECT_DLG, SfxCallMode::ASYNCHRON ); +{ +if (SfxViewFrame* pViewFrame = SfxViewFrame::Current()) +pViewFrame->GetDispatcher()->Execute( SID_AUTO_CORRECT_DLG, SfxCallMode::ASYNCHRON ); +} } // Return formatted page number (1, I, i, a, etc.) diff --git a/sd/source/ui/func/undoheaderfooter.cxx b/sd/source/ui/func/undoheaderfooter.cxx index 648a2dd35842..e0183dac3142 100644 --- a/sd/source/ui/func/undoheaderfooter.cxx +++ b/sd/source/ui/func/undoheaderfooter.cxx @@ -39,13 +39,15 @@ SdHeaderFooterUndoAction::~SdHeaderFooterUndoAction() void SdHeaderFooterUndoAction::Undo() { mpPage->setHeaderFooterSettings( maOldSettings ); -SfxViewFrame::Current()->GetDispatcher()->Execute( SID_SWITCHPAGE, SfxCallMode::ASYNCHRON | SfxCallMode::RECORD ); +if (SfxViewFrame* pViewFrm = SfxViewFrame::Current()) +pViewFrm->GetDispatcher()->Execute( SID_SWITCHPAGE, SfxCallMode::ASYNCHRON | SfxCallMode::RECORD ); } void SdHeaderFooterUndoAction::Redo() { mpPage->setHeaderFooterSettings( maNewSettings ); -SfxViewFrame::Current()->GetDispatcher()->Execute( SID_SWITCHPAGE, SfxCallMode::ASYNCHRON | SfxCallMode::RECORD ); +if (SfxViewFrame* pViewFrm = SfxViewFrame::Current()) +pViewFrm->GetDispatcher()->Execute( SID_SWITCHPAGE, SfxCallMode::ASYNCHRON | SfxCallMode::RECORD ); } /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/sd/source/ui/view/Outliner.cxx b/sd/source/ui/view/Outliner.cxx index 342b01b050dc..a633376926a6 100644 --- a/sd/source/ui/view/Outliner.cxx +++ b/sd/source/ui/view/Outliner.cxx @@ -1925,13 +1925,15 @@ weld::Window* SdOutliner::GetMessageBoxParent() switch (meMode) { case SEARCH: -pChildWindow = SfxViewFrame::Current()->GetChildWindow( -SvxSearchDialogWrapper::GetChildWindowId()); +if (SfxViewFrame* pViewFrm = SfxViewFrame::Current()) +pChildWindow = pViewFrm->GetChildWindow( +SvxSearchDialogWrapper::GetChildWindowId()); break; case SPELL: -pChildWindow = SfxViewFrame::Current()->GetChildWindow( -sd::SpellDialogChildWindow::GetChildWindowId()); +if (SfxViewFrame* pViewFrm = SfxViewFrame::Current()) +pChildWindow = pViewFrm->GetChildWindow( +sd::SpellDialogChildWindow::GetChildWindowId()); break; case TEXT_CONVERSION: diff --git a/sd/source/ui/view/ViewShellImplementation.cxx b/sd/source/ui/view/ViewShellImplementation.cxx index 5725feb2cc4f..a0c025ce5acf 100644 --- a/sd/source/ui/view/ViewShellImplementation.cxx +++ b/sd/source/ui/view/ViewShellImplementation.cxx @@ -304,12 +304,16 @@ SfxInterfaceId ViewShell::Implementation::GetViewId() const SvxIMapDlg* ViewShell::Implementation::GetImageMapDialog() { -SvxIMapDlg* pDialog = nullptr; -SfxChildWindow* pChildWindow = SfxViewFrame::Current()->GetChildWindow( +SfxViewFrame* pViewFrm = SfxViewFrame::Current(); +if (!pViewFrm) +return nullptr; + +SfxChildWindow* pChildWindow = pViewFrm->GetChildWindow( SvxIMapDlgChildWindow::GetChildWindowId()); -if (pChildWindow != nullptr) -pDialog = dynamic_cast(pChildWindow->GetController().get()); -return pDialog; +if (pChildWindow == nullptr) +return nullptr; + +return
[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - sd/source
sd/source/core/drawdoc4.cxx | 10 -- sd/source/ui/func/undoheaderfooter.cxx|6 -- sd/source/ui/view/Outliner.cxx| 10 ++ sd/source/ui/view/ViewShellImplementation.cxx | 14 +- 4 files changed, 27 insertions(+), 13 deletions(-) New commits: commit cdb03edf09a704e8f7b67e3982e9e7d83e97d358 Author: Caolán McNamara AuthorDate: Thu Dec 15 20:25:18 2022 + Commit: Xisco Fauli CommitDate: Fri Dec 16 07:50:42 2022 + sd: check SfxViewFrame::Current() these ones look potentially worth backporting Change-Id: I6153b0f9ead7caef9f228a5724f51823bcf87c07 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144262 Tested-by: Jenkins Reviewed-by: Xisco Fauli diff --git a/sd/source/core/drawdoc4.cxx b/sd/source/core/drawdoc4.cxx index 907b4163e500..c487c041c75a 100644 --- a/sd/source/core/drawdoc4.cxx +++ b/sd/source/core/drawdoc4.cxx @@ -948,9 +948,15 @@ void SdDrawDocument::ImpOnlineSpellCallback(SpellCallbackInfo const * pInfo, Sdr StartOnlineSpelling(); } else if (nCommand == SpellCallbackCommand::STARTSPELLDLG) -SfxViewFrame::Current()->GetDispatcher()->Execute( SID_SPELL_DIALOG, SfxCallMode::ASYNCHRON ); +{ +if (SfxViewFrame* pViewFrame = SfxViewFrame::Current()) +pViewFrame->GetDispatcher()->Execute( SID_SPELL_DIALOG, SfxCallMode::ASYNCHRON ); +} else if (nCommand == SpellCallbackCommand::AUTOCORRECT_OPTIONS) -SfxViewFrame::Current()->GetDispatcher()->Execute( SID_AUTO_CORRECT_DLG, SfxCallMode::ASYNCHRON ); +{ +if (SfxViewFrame* pViewFrame = SfxViewFrame::Current()) +pViewFrame->GetDispatcher()->Execute( SID_AUTO_CORRECT_DLG, SfxCallMode::ASYNCHRON ); +} } // Return formatted page number (1, I, i, a, etc.) diff --git a/sd/source/ui/func/undoheaderfooter.cxx b/sd/source/ui/func/undoheaderfooter.cxx index 18a89d4ca8f5..6f386a42fd11 100644 --- a/sd/source/ui/func/undoheaderfooter.cxx +++ b/sd/source/ui/func/undoheaderfooter.cxx @@ -40,13 +40,15 @@ SdHeaderFooterUndoAction::~SdHeaderFooterUndoAction() void SdHeaderFooterUndoAction::Undo() { mpPage->setHeaderFooterSettings( maOldSettings ); -SfxViewFrame::Current()->GetDispatcher()->Execute( SID_SWITCHPAGE, SfxCallMode::ASYNCHRON | SfxCallMode::RECORD ); +if (SfxViewFrame* pViewFrm = SfxViewFrame::Current()) +pViewFrm->GetDispatcher()->Execute( SID_SWITCHPAGE, SfxCallMode::ASYNCHRON | SfxCallMode::RECORD ); } void SdHeaderFooterUndoAction::Redo() { mpPage->setHeaderFooterSettings( maNewSettings ); -SfxViewFrame::Current()->GetDispatcher()->Execute( SID_SWITCHPAGE, SfxCallMode::ASYNCHRON | SfxCallMode::RECORD ); +if (SfxViewFrame* pViewFrm = SfxViewFrame::Current()) +pViewFrm->GetDispatcher()->Execute( SID_SWITCHPAGE, SfxCallMode::ASYNCHRON | SfxCallMode::RECORD ); } /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/sd/source/ui/view/Outliner.cxx b/sd/source/ui/view/Outliner.cxx index 4773b3badf4f..6384f1ee58d7 100644 --- a/sd/source/ui/view/Outliner.cxx +++ b/sd/source/ui/view/Outliner.cxx @@ -1925,13 +1925,15 @@ weld::Window* SdOutliner::GetMessageBoxParent() switch (meMode) { case SEARCH: -pChildWindow = SfxViewFrame::Current()->GetChildWindow( -SvxSearchDialogWrapper::GetChildWindowId()); +if (SfxViewFrame* pViewFrm = SfxViewFrame::Current()) +pChildWindow = pViewFrm->GetChildWindow( +SvxSearchDialogWrapper::GetChildWindowId()); break; case SPELL: -pChildWindow = SfxViewFrame::Current()->GetChildWindow( -sd::SpellDialogChildWindow::GetChildWindowId()); +if (SfxViewFrame* pViewFrm = SfxViewFrame::Current()) +pChildWindow = pViewFrm->GetChildWindow( +sd::SpellDialogChildWindow::GetChildWindowId()); break; case TEXT_CONVERSION: diff --git a/sd/source/ui/view/ViewShellImplementation.cxx b/sd/source/ui/view/ViewShellImplementation.cxx index 2f81d5be9b3e..fb4598e048c0 100644 --- a/sd/source/ui/view/ViewShellImplementation.cxx +++ b/sd/source/ui/view/ViewShellImplementation.cxx @@ -305,12 +305,16 @@ SfxInterfaceId ViewShell::Implementation::GetViewId() const SvxIMapDlg* ViewShell::Implementation::GetImageMapDialog() { -SvxIMapDlg* pDialog = nullptr; -SfxChildWindow* pChildWindow = SfxViewFrame::Current()->GetChildWindow( +SfxViewFrame* pViewFrm = SfxViewFrame::Current(); +if (!pViewFrm) +return nullptr; + +SfxChildWindow* pChildWindow = pViewFrm->GetChildWindow( SvxIMapDlgChildWindow::GetChildWindowId()); -if (pChildWindow != nullptr) -pDialog = dynamic_cast(pChildWindow->GetController().get()); -return pDialog; +if (pChildWindow == nullptr) +return nullptr; + +return
[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - cui/source desktop/source
cui/source/customize/CustomNotebookbarGenerator.cxx | 13 - desktop/source/lib/init.cxx | 12 2 files changed, 16 insertions(+), 9 deletions(-) New commits: commit c53083fed88e979a55f1cf3cdc9de2628738c073 Author: Caolán McNamara AuthorDate: Thu Dec 15 20:15:45 2022 + Commit: Xisco Fauli CommitDate: Fri Dec 16 07:50:17 2022 + misc: check SfxViewFrame::Current() these ones look potentially worth backporting Change-Id: Ie01c0b598c3408f4766318267de8438e997dd1a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144260 Tested-by: Jenkins Reviewed-by: Xisco Fauli diff --git a/cui/source/customize/CustomNotebookbarGenerator.cxx b/cui/source/customize/CustomNotebookbarGenerator.cxx index 9fb71562160a..bae85525ebd6 100644 --- a/cui/source/customize/CustomNotebookbarGenerator.cxx +++ b/cui/source/customize/CustomNotebookbarGenerator.cxx @@ -74,11 +74,14 @@ static OUString lcl_getAppName(vcl::EnumContext::Application eApp) static OUString getAppNameRegistryPath() { vcl::EnumContext::Application eApp = vcl::EnumContext::Application::Any; -const Reference& xFrame -= SfxViewFrame::Current()->GetFrame().GetFrameInterface(); -const Reference xModuleManager -= frame::ModuleManager::create(::comphelper::getProcessComponentContext()); -eApp = vcl::EnumContext::GetApplicationEnum(xModuleManager->identify(xFrame)); + +if (SfxViewFrame* pViewFrame = SfxViewFrame::Current()) +{ +const Reference& xFrame = pViewFrame->GetFrame().GetFrameInterface(); +const Reference xModuleManager += frame::ModuleManager::create(::comphelper::getProcessComponentContext()); +eApp = vcl::EnumContext::GetApplicationEnum(xModuleManager->identify(xFrame)); +} OUString sAppName(lcl_getAppName(eApp)); return "org.openoffice.Office.UI.ToolbarMode/Applications/" + sAppName; diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx index c777bc7bb731..fd99214e6daa 100644 --- a/desktop/source/lib/init.cxx +++ b/desktop/source/lib/init.cxx @@ -792,6 +792,10 @@ void ExecuteMarginULChange( // Main function which toggles page orientation of the Writer doc. Needed by ToggleOrientation void ExecuteOrientationChange() { +SfxViewFrame* pViewFrm = SfxViewFrame::Current(); +if (!pViewFrm) +return; + std::unique_ptr pPageItem(new SvxPageItem(SID_ATTR_PAGE)); // 1mm in twips rounded @@ -799,22 +803,22 @@ void ExecuteOrientationChange() constexpr tools::Long MINBODY = o3tl::toTwips(1, o3tl::Length::mm); css::uno::Reference< css::document::XUndoManager > mxUndoManager( -getUndoManager( SfxViewFrame::Current()->GetFrame().GetFrameInterface() ) ); +getUndoManager( pViewFrm->GetFrame().GetFrameInterface() ) ); if ( mxUndoManager.is() ) mxUndoManager->enterUndoContext( "" ); const SvxSizeItem* pSizeItem; - SfxViewFrame::Current()->GetBindings().GetDispatcher()->QueryState(SID_ATTR_PAGE_SIZE, pSizeItem); +pViewFrm->GetBindings().GetDispatcher()->QueryState(SID_ATTR_PAGE_SIZE, pSizeItem); std::unique_ptr pPageSizeItem(pSizeItem->Clone()); const SvxLongLRSpaceItem* pLRSpaceItem; - SfxViewFrame::Current()->GetBindings().GetDispatcher()->QueryState(SID_ATTR_PAGE_LRSPACE, pLRSpaceItem); +pViewFrm->GetBindings().GetDispatcher()->QueryState(SID_ATTR_PAGE_LRSPACE, pLRSpaceItem); std::unique_ptr pPageLRMarginItem(pLRSpaceItem->Clone()); const SvxLongULSpaceItem* pULSpaceItem; - SfxViewFrame::Current()->GetBindings().GetDispatcher()->QueryState(SID_ATTR_PAGE_ULSPACE, pULSpaceItem); +pViewFrm->GetBindings().GetDispatcher()->QueryState(SID_ATTR_PAGE_ULSPACE, pULSpaceItem); std::unique_ptr pPageULMarginItem(pULSpaceItem->Clone()); {
[Libreoffice-bugs] [Bug 83946] [META] Tracking changes issues
https://bugs.documentfoundation.org/show_bug.cgi?id=83946 Dieter changed: What|Removed |Added Depends on||152340 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=152340 [Bug 152340] Capitalize Every Word operation creates gazillion undo entries, when change tracking is enabled -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152340] Capitalize Every Word operation creates gazillion undo entries, when change tracking is enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=152340 Dieter changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW Whiteboard| QA:needsComment| Blocks||83946 CC||dgp-m...@gmx.de --- Comment #1 from Dieter --- I confirm it with Version: 7.5.0.0.beta1 (X86_64) / LibreOffice Community Build ID: 3aca23eec42e9d6fbe57071d7633ae1fc4bc5fcc CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: en-US (de_DE); UI: en-GB Calc: CL threaded Works as expected without recording changes. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=83946 [Bug 83946] [META] Tracking changes issues -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152517] Navigator: Ctrl+Minus collapses the whole Headings tree, not the selected node
https://bugs.documentfoundation.org/show_bug.cgi?id=152517 --- Comment #6 from Jim Raykowski --- (In reply to Mike Kaganski from comment #5) > Interesting, why the styles list behaves as expected - does it duplicate the > code? Yes, very interesting. It seems the styles list uses nullptr as the parent for all entries[1] which makes[2] work as expected because of[3]. [1] https://opengrok.libreoffice.org/xref/core/sfx2/source/dialog/StyleList.cxx?r=ef862ba4#949 [2] https://opengrok.libreoffice.org/xref/core/vcl/source/treelist/svimpbox.cxx?r=5f9cd841#2393 [3] https://opengrok.libreoffice.org/xref/core/vcl/source/treelist/treelist.cxx?r=6e2bd112=29042=1020#1020 -- You are receiving this mail because: You are the assignee for the bug.
Re: Master build fail
On 15/12/2022 23:28, Jean-Baptiste Faure wrote: When building the current master, I get the following error message (translated from French): /home/[...]/helpcontent2/CustomTarget_html.mk:49: *** insufficient number of arguments (1) for the function « if ». Stop. make[1]: *** Waiting for unfinished tasks make: *** [Makefile:289 : build] Error 2 That's presumably... commit 5daaa3e440b17505d644273a7305f073d6d5834d Author: Christian Lohmaier Date: Thu Dec 15 16:35:31 2022 +0100 cd to helpcontent2/source/text & drop it from filenames for larger batches On the Jenkins Windows builder only 40~45 of the ~2500 helpfiles can be processed at once when not stripping that prefix. With the shortened filenames the build needs less than half of the xsltproc invocations. Also prevent a trailing carriage return to be interpreted as part of the filename on windows and drop the abbreviate_dir wrapper around the command since there's nothing left to shorten anymore. Change-Id: Ifaff26f73f262bd1d7cb4f813bf081782661ba17 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/144236 Tested-by: Jenkins Reviewed-by: Christian Lohmaier diff --git a/CustomTarget_html.mk b/CustomTarget_html.mk index 8db68cf8c1..e8fd4b439d 100644 --- a/CustomTarget_html.mk +++ b/CustomTarget_html.mk @@ -38,21 +38,21 @@ $(eval $(call gb_CustomTarget_register_targets,helpcontent2/help3xsl,\ ) \ )) +# trailing space for Windows so that xargs doesn't interpret the final CR (that +# win-make adds as the newline character) as part of the last filename $(call gb_CustomTarget_get_workdir,helpcontent2/help3xsl)/hid2file.js : \ $(SRCDIR)/helpcontent2/help3xsl/generate_hid2file.xsl \ $(call gb_ExternalExecutable_get_dependencies,xsltproc) \ $(foreach module,$(html_TEXT_MODULES),$(call gb_AllLangHelp_get_helpfiles_target,$(module))) \ $(SRCDIR)/helpcontent2/CustomTarget_html.mk $(call gb_Output_announce,$(subst $(WORKDIR)/,,$@),$(true),XSL,1) - $(call gb_Helper_abbreviate_dirs,\ - ( \ - RESPONSEFILE=$(call gb_var2file,$(shell $(gb_MKTEMP)),$(foreach module,$(html_TEXT_MODULES),$(gb_AllLangHelp_$(module)_HELPFILES))) && \ - echo 'var hid2fileMap = {' \ - && cd $(SRCDIR) && $(call gb_ExternalExecutable_get_command,xsltproc,xargs) $< <$$RESPONSEFILE || { rm $$RESPONSEFILE; exit 1 ; } \ - && rm "$$RESPONSEFILE" \ - && echo '};' \ - ) > $@ \ - ) + ( \ + RESPONSEFILE=$(call gb_var2file,$(shell $(gb_MKTEMP)),$(subst helpcontent2/source/text/,,$(foreach module,$(html_TEXT_MODULES),$(gb_AllLangHelp_$(module)_HELPFILES))$(if $(filter WNT,$(OS), ))) && \ ^^^ this part + echo 'var hid2fileMap = {' \ + && cd $(SRCDIR)/helpcontent2/source/text && $(call gb_ExternalExecutable_get_command,xsltproc,xargs) $< <$$RESPONSEFILE || { rm $$RESPONSEFILE; exit 1 ; } \ + && rm "$$RESPONSEFILE" \ + && echo '};' \ + ) > $@ [...]
[Libreoffice-bugs] [Bug 152537] Changing Default Paragraph Style does not update Character Styles
https://bugs.documentfoundation.org/show_bug.cgi?id=152537 --- Comment #5 from Seán Ó Séaghdha --- It may not be a bug in the strict sense of a malfunction, but it certainly looks and functions like a bug to the end user. Having mysterious external defaults just makes Writer look unpredictable. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 102187] [META] Options dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102187 Heiko Tietze changed: What|Removed |Added Depends on||152453 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=152453 [Bug 152453] Improve the wording of "JREs already installed" list title, to remove confusion -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152453] Improve the wording of "JREs already installed" list title, to remove confusion
https://bugs.documentfoundation.org/show_bug.cgi?id=152453 Heiko Tietze changed: What|Removed |Added CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda |.freedesktop.org|tion.org, ||mentoring@documentfoundatio ||n.org Blocks||102187 Keywords|needsUXEval |difficultyBeginner, ||easyHack, skillDesign --- Comment #6 from Heiko Tietze --- We discussed the topic in the design meeting. The options are "Installed in the system, select one for use with LibreOffice:" "Select the JRE/JDK you want to use with LibreOffice:" "Java runtime environments (JRE) already installed. Please select one:" and the doer should decide. Code pointer: cui/uiconfig/ui/optadvancedpage.ui Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=102187 [Bug 102187] [META] Options dialog bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 152453] Improve the wording of "JREs already installed" list title, to remove confusion
https://bugs.documentfoundation.org/show_bug.cgi?id=152453 Heiko Tietze changed: What|Removed |Added CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda |.freedesktop.org|tion.org, ||mentoring@documentfoundatio ||n.org Blocks||102187 Keywords|needsUXEval |difficultyBeginner, ||easyHack, skillDesign --- Comment #6 from Heiko Tietze --- We discussed the topic in the design meeting. The options are "Installed in the system, select one for use with LibreOffice:" "Select the JRE/JDK you want to use with LibreOffice:" "Java runtime environments (JRE) already installed. Please select one:" and the doer should decide. Code pointer: cui/uiconfig/ui/optadvancedpage.ui Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=102187 [Bug 102187] [META] Options dialog bugs and enhancements -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 152537] Changing Default Paragraph Style does not update Character Styles
https://bugs.documentfoundation.org/show_bug.cgi?id=152537 --- Comment #4 from Mike Kaganski --- (In reply to Mike Kaganski from comment #3) > thus it depends on a *global default*, not defined through styles in any > document. Or rather, defined by a special setting in documents, that is not exposed in the UI other than by the mentioned Options->Writer->Basic Fonts, which combines setting the *three* things: global application default used for new documents, 'style:default-style' for current document, and also "Default Paragraph Style" of the current document. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151548] No access to FormField controls in StarBASIC/VBA
https://bugs.documentfoundation.org/show_bug.cgi?id=151548 --- Comment #24 from Commit Notification --- Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/88d4e7416921d4c3c71d9effa04ff56a541b169d tdf#151548 vba FormFields: implement Range It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: oovbaapi/ooo sw/qa sw/source
oovbaapi/ooo/vba/word/XFormField.idl |3 ++- sw/qa/core/data/docm/testVBA.docm|binary sw/source/ui/vba/vbadocument.cxx |2 +- sw/source/ui/vba/vbaformfield.cxx| 29 - sw/source/ui/vba/vbaformfield.hxx|7 --- sw/source/ui/vba/vbaformfields.cxx | 25 + sw/source/ui/vba/vbaformfields.hxx |3 ++- 7 files changed, 42 insertions(+), 27 deletions(-) New commits: commit 88d4e7416921d4c3c71d9effa04ff56a541b169d Author: Justin Luth AuthorDate: Tue Dec 13 18:52:09 2022 -0500 Commit: Miklos Vajna CommitDate: Fri Dec 16 07:39:43 2022 + tdf#151548 vba FormFields: implement Range Msgbox (FormFields("text1").Range.Text) Change-Id: Iac195e09bd3f9619890b336a0cb537a1acd00049 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144136 Tested-by: Jenkins Reviewed-by: Justin Luth Reviewed-by: Miklos Vajna diff --git a/oovbaapi/ooo/vba/word/XFormField.idl b/oovbaapi/ooo/vba/word/XFormField.idl index 3d51fcd263cd..06543067c6eb 100644 --- a/oovbaapi/ooo/vba/word/XFormField.idl +++ b/oovbaapi/ooo/vba/word/XFormField.idl @@ -19,6 +19,7 @@ module ooo { module vba { module word { +interface XRange; interface XFormField { interface ooo::vba::XHelperInterface; @@ -75,7 +76,7 @@ interface XFormField * Represents a contiguous area in a document. * Each Range object is defined by a starting and ending character position. */ -any Range(); +XRange Range(); }; }; }; }; diff --git a/sw/qa/core/data/docm/testVBA.docm b/sw/qa/core/data/docm/testVBA.docm index 839c8dd9f73c..44e59f03a753 100644 Binary files a/sw/qa/core/data/docm/testVBA.docm and b/sw/qa/core/data/docm/testVBA.docm differ diff --git a/sw/source/ui/vba/vbadocument.cxx b/sw/source/ui/vba/vbadocument.cxx index c7e9731001bf..52907477dcff 100644 --- a/sw/source/ui/vba/vbadocument.cxx +++ b/sw/source/ui/vba/vbadocument.cxx @@ -327,7 +327,7 @@ SwVbaDocument::TablesOfContents( const uno::Any& index ) uno::Any SAL_CALL SwVbaDocument::FormFields(const uno::Any& index) { -uno::Reference xCol(new SwVbaFormFields(this, mxContext, mxModel)); +uno::Reference xCol(new SwVbaFormFields(this, mxContext, mxTextDocument)); if (index.hasValue()) return xCol->Item(index, uno::Any()); return uno::Any(xCol); diff --git a/sw/source/ui/vba/vbaformfield.cxx b/sw/source/ui/vba/vbaformfield.cxx index 8afaeb9d9480..0c8a8644e990 100644 --- a/sw/source/ui/vba/vbaformfield.cxx +++ b/sw/source/ui/vba/vbaformfield.cxx @@ -13,11 +13,13 @@ #include #include +#include #include "vbaformfield.hxx" #include "vbaformfieldcheckbox.hxx" #include "vbaformfielddropdown.hxx" #include "vbaformfieldtextinput.hxx" +#include "vbarange.hxx" #include "wordvbahelper.hxx" using namespace ::ooo::vba; @@ -34,10 +36,10 @@ using namespace ::com::sun::star; */ SwVbaFormField::SwVbaFormField(const uno::Reference& rParent, const uno::Reference& rContext, - const uno::Reference& xModel, + const uno::Reference& xTextDocument, sw::mark::IFieldmark& rFormField) : SwVbaFormField_BASE(rParent, rContext) -, mxModel(xModel) +, m_xTextDocument(xTextDocument) , m_rFormField(rFormField) { } @@ -64,7 +66,7 @@ uno::Any SAL_CALL SwVbaFormField::TextInput() uno::Any SAL_CALL SwVbaFormField::Previous() { -SwDoc* pDoc = word::getDocShell(mxModel)->GetDoc(); +SwDoc* pDoc = word::getDocShell(m_xTextDocument)->GetDoc(); if (!pDoc) return uno::Any(); @@ -86,12 +88,12 @@ uno::Any SAL_CALL SwVbaFormField::Previous() return uno::Any(); return uno::Any(uno::Reference( -new SwVbaFormField(mxParent, mxContext, mxModel, *pFieldMark))); +new SwVbaFormField(mxParent, mxContext, m_xTextDocument, *pFieldMark))); } uno::Any SAL_CALL SwVbaFormField::Next() { -SwDoc* pDoc = word::getDocShell(mxModel)->GetDoc(); +SwDoc* pDoc = word::getDocShell(m_xTextDocument)->GetDoc(); if (!pDoc) return uno::Any(); @@ -113,13 +115,22 @@ uno::Any SAL_CALL SwVbaFormField::Next() return uno::Any(); return uno::Any(uno::Reference( -new SwVbaFormField(mxParent, mxContext, mxModel, *pFieldMark))); +new SwVbaFormField(mxParent, mxContext, m_xTextDocument, *pFieldMark))); } -uno::Any SAL_CALL SwVbaFormField::Range() +uno::Reference SwVbaFormField::Range() { -SAL_INFO("sw.vba", "SwVbaFormField::getRange stub"); -return uno::Any(); +uno::Reference xRet; +SwDoc* pDoc = word::getDocShell(m_xTextDocument)->GetDoc(); +if (pDoc) +{ +uno::Reference xText(SwXTextRange::CreateXTextRange( +*pDoc, m_rFormField.GetMarkStart(), _rFormField.GetMarkEnd())); +if (xText.is()) +xRet = new SwVbaRange(mxParent, mxContext,
[Libreoffice-bugs] [Bug 152341] Page background pick-up color display is wrong
https://bugs.documentfoundation.org/show_bug.cgi?id=152341 Dieter changed: What|Removed |Added Status|NEW |NEEDINFO -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: offapi/com schema/libreoffice sw/qa sw/source writerfilter/qa writerfilter/source xmloff/qa xmloff/source
offapi/com/sun/star/text/ContentControl.idl |2 + schema/libreoffice/OpenDocument-v1.3+libreoffice-schema.rng |5 ++ sw/qa/core/unocore/unocore.cxx |2 + sw/qa/extras/ooxmlexport/ooxmlexport17.cxx |2 + sw/qa/extras/ooxmlexport/ooxmlexport18.cxx |6 +++ sw/source/filter/ww8/docxattributeoutput.cxx | 19 +- sw/source/filter/ww8/docxattributeoutput.hxx |4 +- writerfilter/qa/cppunittests/dmapper/SdtHelper.cxx |4 ++ writerfilter/qa/cppunittests/dmapper/data/sdt-run-rich-text.docx |binary writerfilter/source/dmapper/DomainMapper.cxx |4 +- xmloff/qa/unit/data/content-control-alias.fodt |2 - xmloff/qa/unit/text.cxx |5 ++ xmloff/source/text/txtparae.cxx |7 +++ xmloff/source/text/xmlcontentcontrolcontext.cxx | 13 ++ xmloff/source/text/xmlcontentcontrolcontext.hxx |1 15 files changed, 64 insertions(+), 12 deletions(-) New commits: commit 54599383a2f86b83c237a10f7d9fce492e798487 Author: Justin Luth AuthorDate: Wed Nov 16 21:56:51 2022 -0500 Commit: Miklos Vajna CommitDate: Fri Dec 16 07:34:20 2022 + sw content controls: enhance preserve id Follow-up to 100c914d44ae8f362924fe567d7d41d0033ae8ad which added the initial id preservation for DOCX. adding DOCX block SDT grabbaging, ODF import/export [content controls can't exist in DOC format] The ID field is CRITICAL to preserve for VBA purposes. This patch adjusts BlockSDT to also round-trip the id instead of just creating a random one. m_nRunSdtPrToken FSNS(XML_w, XML_id) since 2021 with 5f3af56b2c0ef6c628a7cfe5ce6e86f8e1765f5f, so I removed that part of the clause. I had thought about changing the ID to use a string instead of an int, but then the integer version was adopted to fix a regression in the commit mentioned earlier. I think it is AWFUL to have a number as the identifier when it will be used in StarBASIC. The VBA guys have to deal with it, but it would be nice to do something reasonable for LO native access to content controls. However, the concern would be if we allow VBA macro content created in LO to be exported to DOCX format - that would cause problems converting from a string ID to a number ID. VBA editing already is happening to some extent, and mmeeks seems interested in enabling it. So over-all it seems best to just stick with an integer ID. I used the commits for and to compose this patch. XML_ID already existed in include/xmloff/xmltoken.hxx and "id" already exists in xmloff/source/token/tokens.txt The ID can be used in VBA to select a specific control. The id (which is a positive or negative integer in DOCX) specifies a unique control - either by passing the number as a string (of the UNSIGNED value) or by passing as a float (specified with #). For example: msgbox ActiveDocument.ContentControls(2587720202#).ID msgbox ActiveDocument.ContentControls("2587720202").ID but not as an integer since that is used for index access. dim index as integer index = 1 msgbox ActiveDocument.ContentControls(index).ID make CppunitTest_writerfilter_dmapper CPPUNIT_TEST_NAME=testSdtRunRichText make CppunitTest_sw_ooxmlexport17 CPPUNIT_TEST_NAME=testDateContentControlExport make CppunitTest_sw_ooxmlexport18 CPPUNIT_TEST_NAME=testTdf151912 make CppunitTest_sw_core_unocore CPPUNIT_TEST_NAME=testContentControlDate make CppunitTest_xmloff_text CPPUNIT_TEST_NAME=testAliasContentControlExport make CppunitTest_xmloff_text CPPUNIT_TEST_NAME=testAliasContentControlImport Change-Id: I5c4022dc932d941fad9da6d75ce899ee1ff66ff5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142818 Tested-by: Jenkins Reviewed-by: Justin Luth Reviewed-by: Miklos Vajna diff --git a/offapi/com/sun/star/text/ContentControl.idl b/offapi/com/sun/star/text/ContentControl.idl index ce741d9b2926..cb980a24b0ff 100644 --- a/offapi/com/sun/star/text/ContentControl.idl +++ b/offapi/com/sun/star/text/ContentControl.idl @@ -105,12 +105,14 @@ service ContentControl [optional, property] boolean DropDown; /** The alias: kind of a human-readable title / description, show up on the UI. + -also used by VBA to group controls into a smaller, indexed collection @since LibreOffice 7.5 */ [optional, property] string Alias; /** The tag: similar to Alias, but is meant to be machine-readable. + -also used by VBA to group controls into a smaller, indexed collection @since LibreOffice 7.5
[Libreoffice-bugs] [Bug 106188] Unused colors not removed from document colors list (works now after save and reload)
https://bugs.documentfoundation.org/show_bug.cgi?id=106188 Dieter changed: What|Removed |Added Severity|normal |minor Priority|medium |low Summary|Unused colors not removed |Unused colors not removed |from document colors list |from document colors list ||(works now after save and ||reload) --- Comment #5 from Dieter --- Little progress in Version: 7.5.0.0.beta1 (X86_64) / LibreOffice Community Build ID: 3aca23eec42e9d6fbe57071d7633ae1fc4bc5fcc CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: en-US (de_DE); UI: en-GB Calc: CL threaded Colour is still present in the colour widget after redo or changing text to automatic, but after saving and reloading colour has been removed. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152537] Changing Default Paragraph Style does not update Character Styles
https://bugs.documentfoundation.org/show_bug.cgi?id=152537 --- Comment #3 from Mike Kaganski --- (In reply to Seán Ó Séaghdha from comment #2) > The ‘duplicate’ bug does not mention the wrong font being used for line > numbers. Character styles do *not* depend on the Default Paragraph Style. Instead, when they do not define a property (directly or through inheritance), the used property value is taken from the *actual* paragraph properties where the character style is applied (be it a direct paragraph-level formatting, or *any* paragraph style used there). And in the *Line Numbering* very special case, the character style is *not* applied to any paragraph in the text, with some paragraph-level properties. Instead, it is used in a special area (generated aside from the text), and thus it depends on a *global default*, not defined through styles in any document. In LibreOffice, the global default is defined through Options->Writer->Basic Fonts. That setting page, unfortunately, has a *separate* effect of *also* defining the Default Paragraph Style (and other styles) font, but that is the unfortunate and is tracked elsewhere. This is not a bug. A possible improvement could add an explicit font definition to this specific character style, because of its special usage, so that user would not face some global defaults. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152341] Page background pick-up color display is wrong
https://bugs.documentfoundation.org/show_bug.cgi?id=152341 Dieter changed: What|Removed |Added OS|macOS (All) |All CC||dgp-m...@gmx.de Ever confirmed|0 |1 Whiteboard| QA:needsComment| Status|UNCONFIRMED |NEW Blocks||87064 --- Comment #3 from Dieter --- Dhina, thank you for the report. but I don't see a problem here: If you change settings of "Background" to "Color" page background displays default color "Lightblue 2". If I open pick up color dialog actual value is #729fcf. Press OK. Background color still the same as expected. The only thing I can see, that display of vertical bar is wrong (red area is mared where it should be the blue) So could you please specify the problem? => NEEDINFO Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=87064 [Bug 87064] [META] Color picker dialog bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 87064] [META] Color picker dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=87064 Dieter changed: What|Removed |Added Depends on||152341 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=152341 [Bug 152341] Page background pick-up color display is wrong -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151341] Slow macOS install caused by bzip2 dmg
https://bugs.documentfoundation.org/show_bug.cgi?id=151341 --- Comment #13 from Stephan Bergmann --- (In reply to Patrick Luby from comment #11) > Can anyone tell me how to actually build the .dmg in the LibreOffice build? that's configure option --with-package-format=dmg -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 136433] Font in character style should 'inherited' font/fontsize etc if it's defined by paragraph style (instead of showing a 'random' font/font size)
https://bugs.documentfoundation.org/show_bug.cgi?id=136433 --- Comment #8 from Seán Ó Séaghdha --- Bug 152537 was also about the *wrong* font being used for line numbers. It keeps the previous font from Default Paragraph Style. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152537] Changing Default Paragraph Style does not update Character Styles
https://bugs.documentfoundation.org/show_bug.cgi?id=152537 --- Comment #2 from Seán Ó Séaghdha --- The ‘duplicate’ bug does not mention the wrong font being used for line numbers. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 136433] Font in character style should 'inherited' font/fontsize etc if it's defined by paragraph style (instead of showing a 'random' font/font size)
https://bugs.documentfoundation.org/show_bug.cgi?id=136433 Mike Kaganski changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=88 ||559 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 88559] Display of inherited attributes from parent styles in Styles dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=88559 Mike Kaganski changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||6433 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 136433] Font in character style should 'inherited' font/fontsize etc if it's defined by paragraph style (instead of showing a 'random' font/font size)
https://bugs.documentfoundation.org/show_bug.cgi?id=136433 Mike Kaganski changed: What|Removed |Added CC||sean.an...@gmail.com --- Comment #7 from Mike Kaganski --- *** Bug 152537 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152537] Changing Default Paragraph Style does not update Character Styles
https://bugs.documentfoundation.org/show_bug.cgi?id=152537 Mike Kaganski changed: What|Removed |Added Resolution|--- |DUPLICATE Status|UNCONFIRMED |RESOLVED --- Comment #1 from Mike Kaganski --- *** This bug has been marked as a duplicate of bug 136433 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152517] Navigator: Ctrl+Minus collapses the whole Headings tree, not the selected node
https://bugs.documentfoundation.org/show_bug.cgi?id=152517 --- Comment #5 from Mike Kaganski --- (In reply to Jim Raykowski from comment #4) > https://gerrit.libreoffice.org/c/core/+/144286 Thanks! Interesting, why the styles list behaves as expected - does it duplicate the code? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152538] Content of tables isn't shown
https://bugs.documentfoundation.org/show_bug.cgi?id=152538 Robert Großkopf changed: What|Removed |Added Keywords||regression -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152538] Content of tables isn't shown
https://bugs.documentfoundation.org/show_bug.cgi?id=152538 Robert Großkopf changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||2516 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152516] Crash pressing edit table in Base
https://bugs.documentfoundation.org/show_bug.cgi?id=152516 Robert Großkopf changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||2538 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152538] Content of tables isn't shown
https://bugs.documentfoundation.org/show_bug.cgi?id=152538 Robert Großkopf changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||2507 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152507] MySQL database table content not read or displayed in UI with an existing connection to ODB file
https://bugs.documentfoundation.org/show_bug.cgi?id=152507 Robert Großkopf changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||2538 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152514] Save icon in old high contrast theme extension disappears after any changes
https://bugs.documentfoundation.org/show_bug.cgi?id=152514 Stéphane Guillou (stragu) changed: What|Removed |Added Summary|Save icon on hicontrast |Save icon in old high |theme disappears after any |contrast theme extension |changes |disappears after any ||changes -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152538] New: Content of tables isn't shown
https://bugs.documentfoundation.org/show_bug.cgi?id=152538 Bug ID: 152538 Summary: Content of tables isn't shown Product: LibreOffice Version: 7.5.0.0 beta1+ Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Base Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rob...@familiegrosskopf.de Open a database file in LO 7.5.0.0.beta1. Click on a table. No grid will be shown, no field. This bug appears with all embedded databases, also MySQL … Tested with Version: 7.5.0.0.beta1 (X86_64) / LibreOffice Community Build ID: 3aca23eec42e9d6fbe57071d7633ae1fc4bc5fcc CPU threads: 6; OS: Linux 5.3; UI render: default; VCL: kf5 (cairo+xcb) Locale: de-DE (de_DE.UTF-8); UI: en-US Calc: threaded No problem in LO 7.4.3.2 under OpenSUSE 15.3 64bit rpm Linux. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103537] [META] High contrast mode bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103537 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||152514 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=152514 [Bug 152514] Save icon on hicontrast theme disappears after any changes -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152514] Save icon on hicontrast theme disappears after any changes
https://bugs.documentfoundation.org/show_bug.cgi?id=152514 Stéphane Guillou (stragu) changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 Blocks||103537 --- Comment #4 from Stéphane Guillou (stragu) --- So you are using this specific theme? https://extensions.libreoffice.org/en/extensions/show/high-contrast-icon-theme - Please attach a screenshot to show the issue. - There were many improvements for dark mode and high contrast in the upcoming 7.5 release. It would be great if you could test it to see if you still reproduce the issue: https://dev-builds.libreoffice.org/daily/master/current.html But I'm wondering if the issue lies in the old icon theme extension and not in LO... Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103537 [Bug 103537] [META] High contrast mode bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152507] MySQL database table content not read or displayed in UI with an existing connection to ODB file
https://bugs.documentfoundation.org/show_bug.cgi?id=152507 Robert Großkopf changed: What|Removed |Added CC||rob...@familiegrosskopf.de --- Comment #8 from Robert Großkopf --- That's not a special MySQL-bug. Opened a HSQLDB embedded and a Firebird embedded. No grid is shown, no field. Will report a new bug for this. Did you really doesn't get this behavior with ODBC? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152517] Navigator: Ctrl+Minus collapses the whole Headings tree, not the selected node
https://bugs.documentfoundation.org/show_bug.cgi?id=152517 --- Comment #4 from Jim Raykowski --- (In reply to Mike Kaganski from comment #3) > The currently selected node must stay selected, but all its children must be > collapsed *recursively*, so that the selected node must get the [+] icon at > the left, and all its (now hidden) children also must have [+] if they have > subchildren - so when you later press [+] at the parent, the previously > expanded children show collapsed. I think effort here does this: https://gerrit.libreoffice.org/c/core/+/144286 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: extensions/source
extensions/source/update/check/updatecheckjob.cxx |4 1 file changed, 4 insertions(+) New commits: commit 73e062be1ff10e2dd889d9ec9c2d07b692077f62 Author: Noel Grandin AuthorDate: Thu Dec 15 19:28:12 2022 +0200 Commit: Noel Grandin CommitDate: Fri Dec 16 06:34:35 2022 + blind fix for some 7.4.3.2 crashes in UpdateCheckJob I am guessing that state in this object is being touched from multiple threads (since it is an UNO service object), and one or more of the threads are consequently seeing inconsistent state. Change-Id: Ib925740d3b8db2713c4f132d0367b794a412a269 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144248 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/extensions/source/update/check/updatecheckjob.cxx b/extensions/source/update/check/updatecheckjob.cxx index 7fabb98bff4c..bf30c1686842 100644 --- a/extensions/source/update/check/updatecheckjob.cxx +++ b/extensions/source/update/check/updatecheckjob.cxx @@ -96,6 +96,7 @@ public: virtual void SAL_CALL notifyTermination( lang::EventObject const & evt ) override; private: +std::mutex m_mutex; uno::Reference m_xContext; uno::Reference< frame::XDesktop2 > m_xDesktop; std::unique_ptr< InitUpdateCheckJobThread > m_pInitThread; @@ -174,6 +175,7 @@ UpdateCheckJob::~UpdateCheckJob() uno::Any UpdateCheckJob::execute(const uno::Sequence& namedValues) { +std::scoped_lock l(m_mutex); for ( sal_Int32 n=namedValues.getLength(); n-- > 0; ) { if ( namedValues[ n ].Name == "DynamicData" ) @@ -274,6 +276,7 @@ UpdateCheckJob::supportsService( OUString const & serviceName ) // XEventListener void SAL_CALL UpdateCheckJob::disposing( lang::EventObject const & rEvt ) { +std::scoped_lock l(m_mutex); bool shutDown = ( rEvt.Source == m_xDesktop ); if ( shutDown && m_xDesktop.is() ) @@ -292,6 +295,7 @@ void SAL_CALL UpdateCheckJob::queryTermination( lang::EventObject const & ) void UpdateCheckJob::terminateAndJoinThread() { +std::scoped_lock l(m_mutex); if (m_pInitThread != nullptr) { m_pInitThread->setTerminating();
[Libreoffice-bugs] [Bug 114293] [META] Address Book Data Source bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=114293 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||70641 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=70641 [Bug 70641] No connection to KDE address book possible (see comment 10) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 70641] No connection to KDE address book possible (see comment 10)
https://bugs.documentfoundation.org/show_bug.cgi?id=70641 Stéphane Guillou (stragu) changed: What|Removed |Added Blocks||114293 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=114293 [Bug 114293] [META] Address Book Data Source bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152517] Navigator: Ctrl+Minus collapses the whole Headings tree, not the selected node
https://bugs.documentfoundation.org/show_bug.cgi?id=152517 --- Comment #3 from Mike Kaganski --- (In reply to Jim Raykowski from comment #2) > So, what is the recommended behavior for [Ctrl]+[-]? Perhaps collapse all > sub nodes along with the current node? The currently selected node must stay selected, but all its children must be collapsed *recursively*, so that the selected node must get the [+] icon at the left, and all its (now hidden) children also must have [+] if they have subchildren - so when you later press [+] at the parent, the previously expanded children show collapsed. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 115081] Data validity restriction can be violated by copying value into a cell
https://bugs.documentfoundation.org/show_bug.cgi?id=115081 --- Comment #10 from grofaty --- Tested in LibreOffice Calc 7.4.3.2 and problem remains. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152537] New: Changing Default Paragraph Style does not update Character Styles
https://bugs.documentfoundation.org/show_bug.cgi?id=152537 Bug ID: 152537 Summary: Changing Default Paragraph Style does not update Character Styles Product: LibreOffice Version: 7.4.3.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: sean.an...@gmail.com Description: If you start a new document & change the Default Paragraph Style, the font apparently applied to Character Styles does not change, i.e. in the list box and dialogs they appear with the previous Default Paragraph Style font. Mostly this is not actually applied, but for line numbers the previous font is used. For other character styles this just leads to confusing UI. If a font is not actually defined, then it should be shown in the dialog as ‘undefined’ not as a font that is otherwise not used in the document. Steps to Reproduce: 1. Open new document 2. Change font in Default Paragraph Style 3. Add some lines of text 4. Enable Line Numbers Actual Results: Line numbers are shown in the font of the previous Default Paragraph Style Expected Results: Line numbers should be shown in the font defined in the current Default Paragraph Style, or the Character Style if defined. Reproducible: Always User Profile Reset: No Additional Info: The UI for Character Styles should also show the actual font that will be used and dialogs should accurately report that a font has not been defined for a style, not default to some font that may have once been applied. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 107328] [META] Style preview bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107328 Bug 107328 depends on bug 152460, which changed state. Bug 152460 Summary: Numeral to right of RTL style name in sidebar and dropdown style previews https://bugs.documentfoundation.org/show_bug.cgi?id=152460 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 43808] [META] Right-To-Left and Complex Text Layout language issues (RTL/CTL)
https://bugs.documentfoundation.org/show_bug.cgi?id=43808 Bug 43808 depends on bug 152460, which changed state. Bug 152460 Summary: Numeral to right of RTL style name in sidebar and dropdown style previews https://bugs.documentfoundation.org/show_bug.cgi?id=152460 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108736] [META] Font text preview bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108736 Bug 108736 depends on bug 152533, which changed state. Bug 152533 Summary: Font preview in Characters dialog uses the wrong font for common characters https://bugs.documentfoundation.org/show_bug.cgi?id=152533 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 43808] [META] Right-To-Left and Complex Text Layout language issues (RTL/CTL)
https://bugs.documentfoundation.org/show_bug.cgi?id=43808 Bug 43808 depends on bug 152533, which changed state. Bug 152533 Summary: Font preview in Characters dialog uses the wrong font for common characters https://bugs.documentfoundation.org/show_bug.cgi?id=152533 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: svx/source
svx/source/dialog/fntctrl.cxx | 119 +- 1 file changed, 49 insertions(+), 70 deletions(-) New commits: commit 718af940435ae9d2ac90374e5880ecb38e96252c Author: Khaled Hosny AuthorDate: Fri Dec 16 00:10:34 2022 +0200 Commit: خالد حسني CommitDate: Fri Dec 16 06:05:48 2022 + tdf#152533: Improve script handling in font preview Use Edit Engine to get the script types instead of trying to duplicate (poorly) its behaviour. This has the advantage of handling weak characters and digits properly and is closer to what would happen in the document itself. We probably should go further and render the preview entirely using Edit Engine (since the current code fails short of proper bidi handling), but this is a bigger change. Change-Id: I975cb2d96a4a18dbd8110686ca09649cab0ec2f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144284 Tested-by: Jenkins Reviewed-by: خالد حسني diff --git a/svx/source/dialog/fntctrl.cxx b/svx/source/dialog/fntctrl.cxx index 393fc4e68103..0712bbe92496 100644 --- a/svx/source/dialog/fntctrl.cxx +++ b/svx/source/dialog/fntctrl.cxx @@ -23,10 +23,6 @@ #include #include #include -#include -#include -#include -#include #include @@ -46,6 +42,7 @@ #include #include +#include #include #include #include @@ -72,8 +69,6 @@ using namespace ::com::sun::star::uno; using namespace ::com::sun::star::lang; -using ::com::sun::star::i18n::XBreakIterator; -using ::com::sun::star::i18n::BreakIterator; // small helper functions to set fonts @@ -127,6 +122,19 @@ OUString removeCRLF(const OUString& rText) return rText.replace(0xa, ' ').replace(0xd, ' ').trim(); } +struct ScriptInfo +{ +tools::Long textWidth; +SvtScriptType scriptType; +sal_Int32 changePos; +ScriptInfo(SvtScriptType scrptType, sal_Int32 position) +: textWidth(0) +, scriptType(scrptType) +, changePos(position) +{ +} +}; + } // end anonymous namespace class FontPrevWin_Impl @@ -137,10 +145,7 @@ class FontPrevWin_Impl VclPtr mpPrinter; bool mbDelPrinter; -Reference mxBreak; -std::vector maTextWidth; -std::deque maScriptChg; -std::vector maScriptType; +std::vector maScriptChanges; SvxFont maCJKFont; SvxFont maCTLFont; OUString maText; @@ -236,45 +241,18 @@ void FontPrevWin_Impl::CheckScript() } maScriptText = maText; +maScriptChanges.clear(); -maScriptChg.clear(); -maScriptType.clear(); -maTextWidth.clear(); +auto aEditEngine = EditEngine(nullptr); +aEditEngine.SetText(maScriptText); -if (!mxBreak.is()) +auto aScript = aEditEngine.GetScriptType({ 0, 0, 0, 0 }); +for (sal_Int32 i = 1; i <= maScriptText.getLength(); i++) { -Reference xContext = ::comphelper::getProcessComponentContext(); -mxBreak = BreakIterator::create(xContext); -} - -sal_uInt16 nScript = 0; -sal_Int32 nChg = 0; - -while (nChg < maText.getLength()) -{ -nScript = mxBreak->getScriptType(maText, nChg); -nChg = mxBreak->endOfScript(maText, nChg, nScript); -if (nChg < maText.getLength() && nChg > 0 && -(css::i18n::ScriptType::WEAK == - mxBreak->getScriptType(maText, nChg - 1))) -{ -int8_t nType = u_charType(maText[nChg]); -if (nType == U_NON_SPACING_MARK || nType == U_ENCLOSING_MARK || -nType == U_COMBINING_SPACING_MARK) -{ -maScriptChg.push_back(nChg - 1); -} -else -{ -maScriptChg.push_back(nChg); -} -} -else -{ -maScriptChg.push_back(nChg); -} -maScriptType.push_back(nScript); -maTextWidth.push_back(0); +auto aNextScript = aEditEngine.GetScriptType({ 0, i, 0, i }); +if (aNextScript != aScript || i == maScriptText.getLength()) +maScriptChanges.emplace_back(aScript, i); +aScript = aNextScript; } } @@ -290,21 +268,21 @@ void FontPrevWin_Impl::CheckScript() Size FontPrevWin_Impl::CalcTextSize(vcl::RenderContext& rRenderContext, OutputDevice const * _pPrinter, const SvxFont& rInFont) { -sal_uInt16 nScript; +SvtScriptType aScript; sal_uInt16 nIdx = 0; sal_Int32 nStart = 0; sal_Int32 nEnd; -size_t nCnt = maScriptChg.size(); +size_t nCnt = maScriptChanges.size(); if (nCnt) { -nEnd = maScriptChg[nIdx]; -nScript = maScriptType[nIdx]; +nEnd = maScriptChanges[nIdx].changePos; +aScript = maScriptChanges[nIdx].scriptType; } else { nEnd = maText.getLength(); -nScript = css::i18n::ScriptType::LATIN; +aScript = SvtScriptType::LATIN; } tools::Long nTxtWidth = 0; tools::Long nCJKHeight = 0; @@ -316,24 +294,24 @@ Size
[Libreoffice-commits] core.git: svx/inc svx/source
svx/inc/CommonStylePreviewRenderer.hxx |9 -- svx/source/styles/CommonStylePreviewRenderer.cxx | 58 ++-- svx/source/tbxctrls/tbcontrl.cxx | 79 +-- 3 files changed, 56 insertions(+), 90 deletions(-) New commits: commit bfecacb2487ba9470600e6f64056d9b1816ee96b Author: Khaled Hosny AuthorDate: Thu Dec 15 22:51:54 2022 +0200 Commit: خالد حسني CommitDate: Fri Dec 16 06:04:25 2022 + tdf#152460: Improve script handling in style previews Use Edit Engine to get the script types instead of trying to duplicate (poorly) its behaviour. This has the advantage of handling weak characters and digits properly and is closer to what would happen in the document itself. We probably should go further and render the preview entirely using Edit Engine (since the current code fails short of proper bidi handling), but this is a bigger change. Change-Id: I79b28067d80f66087e1d5e9399ba1a513de96c8a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144283 Tested-by: Jenkins Reviewed-by: خالد حسني diff --git a/svx/inc/CommonStylePreviewRenderer.hxx b/svx/inc/CommonStylePreviewRenderer.hxx index cb0563be15c4..0e99421b4bfe 100644 --- a/svx/inc/CommonStylePreviewRenderer.hxx +++ b/svx/inc/CommonStylePreviewRenderer.hxx @@ -12,6 +12,7 @@ #include #include +#include #include #include #include @@ -19,9 +20,6 @@ #include #include -#include -#include - class OutputDevice; class SfxStyleSheetBase; @@ -41,13 +39,12 @@ class CommonStylePreviewRenderer final : public sfx2::StylePreviewRenderer tools::Long mnBaseLine; OUString maStyleName; OUString maScriptText; -css::uno::Reference mxBreak; struct ScriptInfo { tools::Long textWidth; -sal_uInt16 scriptType; +SvtScriptType scriptType; sal_Int32 changePos; -ScriptInfo(sal_uInt16 scrptType, sal_Int32 position) +ScriptInfo(SvtScriptType scrptType, sal_Int32 position) : textWidth(0) , scriptType(scrptType) , changePos(position) diff --git a/svx/source/styles/CommonStylePreviewRenderer.cxx b/svx/source/styles/CommonStylePreviewRenderer.cxx index 5f12d209f0bf..9ddf3cf15017 100644 --- a/svx/source/styles/CommonStylePreviewRenderer.cxx +++ b/svx/source/styles/CommonStylePreviewRenderer.cxx @@ -29,6 +29,7 @@ #include #include #include +#include #include #include #include @@ -39,9 +40,6 @@ #include -#include -#include - using namespace css; namespace svx @@ -235,7 +233,7 @@ void CommonStylePreviewRenderer::CalcRenderSize() mnBaseLine = 0; mnHeight = 0; -sal_uInt16 nScript; +SvtScriptType aScript; sal_uInt16 nIdx = 0; sal_Int32 nStart = 0; sal_Int32 nEnd; @@ -244,19 +242,19 @@ void CommonStylePreviewRenderer::CalcRenderSize() if (nCnt) { nEnd = maScriptChanges[nIdx].changePos; -nScript = maScriptChanges[nIdx].scriptType; +aScript = maScriptChanges[nIdx].scriptType; } else { nEnd = rText.getLength(); -nScript = css::i18n::ScriptType::LATIN; +aScript = SvtScriptType::LATIN; } do { -auto oFont = (nScript == css::i18n::ScriptType::ASIAN) ? +auto oFont = (aScript == SvtScriptType::ASIAN) ? m_oCJKFont : - ((nScript == css::i18n::ScriptType::COMPLEX) ? + ((aScript == SvtScriptType::COMPLEX) ? m_oCTLFont : m_oFont); @@ -287,7 +285,7 @@ void CommonStylePreviewRenderer::CalcRenderSize() { nStart = nEnd; nEnd = maScriptChanges[nIdx].changePos; -nScript = maScriptChanges[nIdx].scriptType; +aScript = maScriptChanges[nIdx].scriptType; } else break; @@ -351,7 +349,7 @@ bool CommonStylePreviewRenderer::render(const tools::Rectangle& aRectangle, Rend aFontDrawPosition.AdjustY((aRectangle.GetHeight() - mnHeight) / 2 ); } -sal_uInt16 nScript; +SvtScriptType aScript; sal_uInt16 nIdx = 0; sal_Int32 nStart = 0; sal_Int32 nEnd; @@ -359,19 +357,19 @@ bool CommonStylePreviewRenderer::render(const tools::Rectangle& aRectangle, Rend if (nCnt) { nEnd = maScriptChanges[nIdx].changePos; -nScript = maScriptChanges[nIdx].scriptType; +aScript = maScriptChanges[nIdx].scriptType; } else { nEnd = rText.getLength(); -nScript = css::i18n::ScriptType::LATIN; +aScript = SvtScriptType::LATIN; } do { -auto oFont = (nScript == css::i18n::ScriptType::ASIAN) +auto oFont = (aScript == SvtScriptType::ASIAN) ? m_oCJKFont - : ((nScript == css::i18n::ScriptType::COMPLEX) +
[Libreoffice-bugs] [Bug 152517] Navigator: Ctrl+Minus collapses the whole Headings tree, not the selected node
https://bugs.documentfoundation.org/show_bug.cgi?id=152517 --- Comment #2 from Jim Raykowski --- I should have checked the history there. It's seems I made this behavior. So, what is the recommended behavior for [Ctrl]+[-]? Perhaps collapse all sub nodes along with the current node? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152517] Navigator: Ctrl+Minus collapses the whole Headings tree, not the selected node
https://bugs.documentfoundation.org/show_bug.cgi?id=152517 Jim Raykowski changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #1 from Jim Raykowski --- [Ctrl]+[+] and [Ctrl]+[-] aren't handled by SwContentTree directly but are passed through to welded TreeView backends. Gtk3 doesn't do anything for these. For gen type backends, [Ctrl]+[-] is handled here[1]. [1] https://opengrok.libreoffice.org/xref/core/vcl/source/treelist/svimpbox.cxx?r=5f9cd841#2393 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152518] With an image set as a page background with specific size, changing page properties (e.g., margins) changes the image size unexpectedly
https://bugs.documentfoundation.org/show_bug.cgi?id=152518 --- Comment #2 from Mike Kaganski --- (In reply to Stéphane Guillou (stragu) from comment #1) > Is that correct, Mike? Yes you are correct - now testing it, I see that unless I activate the area tab, it works OK. I must accidentally have activated it always in my prior testing. Thanks! > (Full background fills were introduced in 7.2, could be an implementation > error? Michael?) ... but actually, the error is not specific to that mode - also if you disable the full page background (and decrease the size accordingly to 10x17 cm), it also behaves like this. Not saying it necessarily is unrelated to that implementation, everything is possible, just mentioning. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151341] Slow macOS install caused by bzip2 dmg
https://bugs.documentfoundation.org/show_bug.cgi?id=151341 --- Comment #12 from Telesto --- @Patrick Luby See comment 2 > Potential starting point: play with how the dmg is created, search for the > hdiutil invocations in the code etc: > https://opengrok.libreoffice.org/xref/core/solenv/bin/modules/installer/ > simplepackage.pm?r=443f65e9#458 Other question can probably be answered by Cloph. LibreOffice’s release manager. Quickest why to contact: LibreOffice IRC# libreoffice-dev https://blog.documentfoundation.org/blog/2017/04/13/cloph-written-interview/ -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152515] PrintOut Unlike the display, some characters are rotated.(Windows Only)
https://bugs.documentfoundation.org/show_bug.cgi?id=152515 --- Comment #12 from V Stuart Foote --- Created attachment 184174 --> https://bugs.documentfoundation.org/attachment.cgi?id=184174=edit screen clip of sample doc (attachment 184150) opened in LO 7.4.3.2 and then exported to PDF, clip from Adobe Acrobat Seems correct for me with LO 7.4.3.2, though all three fonts showed they'd received system font fall backs for this install. So is this maybe a font issue for OPs system--partial font? Or a bracket glyph without the vertical alternates (that seems unlikely). Version: 7.4.3.2 (x64) / LibreOffice Community Build ID: 1048a8393ae2eeec98dff31b5c133c5f1d08b890 CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152515] PrintOut Unlike the display, some characters are rotated.(Windows Only)
https://bugs.documentfoundation.org/show_bug.cgi?id=152515 V Stuart Foote changed: What|Removed |Added Version|7.2.7.2 release |7.4.3.2 release -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103718] FORMATTING: brackets rotates depending on surrounding text in vertical layout
https://bugs.documentfoundation.org/show_bug.cgi?id=103718 V Stuart Foote changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||2515 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 106045] [META] Vertical and rotated text direction issues
https://bugs.documentfoundation.org/show_bug.cgi?id=106045 V Stuart Foote changed: What|Removed |Added Depends on||152515 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=152515 [Bug 152515] PrintOut Unlike the display, some characters are rotated.(Windows Only) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 83066] [META] CJK (Chinese, Japanese, Korean, and Vietnamese) language issues
https://bugs.documentfoundation.org/show_bug.cgi?id=83066 V Stuart Foote changed: What|Removed |Added Depends on||152515 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=152515 [Bug 152515] PrintOut Unlike the display, some characters are rotated.(Windows Only) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152515] PrintOut Unlike the display, some characters are rotated.(Windows Only)
https://bugs.documentfoundation.org/show_bug.cgi?id=152515 V Stuart Foote changed: What|Removed |Added Component|Writer |Printing and PDF export CC||kha...@aliftype.com Blocks||106045, 83066 Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=10 ||3718 --- Comment #11 from V Stuart Foote --- Can not confirm with current nightly against 7.6.0. I can't spot an exact patch in gerrit but Khaled has done a lot of work recently on the hb font handling for PDF export. Now looks like all the CJK brackets are correctly rotating to the vertical variant--on Windows at least. Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 9b46020c262045aed0beace4708565235c2523cc CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded The issue appears to be PDF export only, with OP testing with 7.4.3 but showing OK print previews. For me the rotated bracket vertical alternates in PDF export work correctly with a build of Nightly against 7.6.0; or if I use a ghostscript based "print to PDF" print path. So, please retest PDF export with current nightly build found here: https://dev-builds.libreoffice.org/daily/master/Win-x86_64@tb77-TDF/ Then install in parallel [1] You can also check for font/LibreOffice support of the full set of rotated alternates as listed in ICU UAX #50 [2] =-ref-= [1] https://wiki.documentfoundation.org/Installing_in_parallel/Windows/ja [2] UAX 50 -- http://www.unicode.org/reports/tr50/ Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=83066 [Bug 83066] [META] CJK (Chinese, Japanese, Korean, and Vietnamese) language issues https://bugs.documentfoundation.org/show_bug.cgi?id=106045 [Bug 106045] [META] Vertical and rotated text direction issues -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152516] Crash pressing edit table in Base
https://bugs.documentfoundation.org/show_bug.cgi?id=152516 QA Administrators changed: What|Removed |Added Keywords||bibisectRequest -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152340] Capitalize Every Word operation creates gazillion undo entries, when change tracking is enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=152340 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152341] Page background pick-up color display is wrong
https://bugs.documentfoundation.org/show_bug.cgi?id=152341 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152334] Autofilter doesn't work on a custom array function range
https://bugs.documentfoundation.org/show_bug.cgi?id=152334 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152333] Crash opening saved spreadsheet which was modified with macro
https://bugs.documentfoundation.org/show_bug.cgi?id=152333 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152515] PrintOut Unlike the display, some characters are rotated.(Windows Only)
https://bugs.documentfoundation.org/show_bug.cgi?id=152515 --- Comment #10 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152515] PrintOut Unlike the display, some characters are rotated.(Windows Only)
https://bugs.documentfoundation.org/show_bug.cgi?id=152515 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152452] Libreoffice crash (macOS)
https://bugs.documentfoundation.org/show_bug.cgi?id=152452 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152514] Save icon on hicontrast theme disappears after any changes
https://bugs.documentfoundation.org/show_bug.cgi?id=152514 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152514] Save icon on hicontrast theme disappears after any changes
https://bugs.documentfoundation.org/show_bug.cgi?id=152514 --- Comment #3 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152452] Libreoffice crash (macOS)
https://bugs.documentfoundation.org/show_bug.cgi?id=152452 --- Comment #11 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151634] Impress SLIDESHOW Presentation mode Speaker Notes not displaying on Primary (Main) display with 3 monitor configuration
https://bugs.documentfoundation.org/show_bug.cgi?id=151634 --- Comment #7 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151634] Impress SLIDESHOW Presentation mode Speaker Notes not displaying on Primary (Main) display with 3 monitor configuration
https://bugs.documentfoundation.org/show_bug.cgi?id=151634 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148774] Autofilter confusing input search with Standard filter (UX)
https://bugs.documentfoundation.org/show_bug.cgi?id=148774 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148774] Autofilter confusing input search with Standard filter (UX)
https://bugs.documentfoundation.org/show_bug.cgi?id=148774 --- Comment #6 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143693] LO should be able to load files from HTTP
https://bugs.documentfoundation.org/show_bug.cgi?id=143693 --- Comment #9 from QA Administrators --- Dear tripleo, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 114220] [META] Drag and drop bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=114220 Bug 114220 depends on bug 142569, which changed state. Bug 142569 Summary: Drag dangerously broken under linux/wayland: unpredictable errors occur https://bugs.documentfoundation.org/show_bug.cgi?id=142569 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142569] Drag dangerously broken under linux/wayland: unpredictable errors occur
https://bugs.documentfoundation.org/show_bug.cgi?id=142569 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 100156] [META] Wayland-related bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=100156 Bug 100156 depends on bug 142569, which changed state. Bug 142569 Summary: Drag dangerously broken under linux/wayland: unpredictable errors occur https://bugs.documentfoundation.org/show_bug.cgi?id=142569 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142569] Drag dangerously broken under linux/wayland: unpredictable errors occur
https://bugs.documentfoundation.org/show_bug.cgi?id=142569 --- Comment #7 from QA Administrators --- Dear thomas.engels, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 94947] MotionPath animation of type Curve shows as Appear animation in the UI
https://bugs.documentfoundation.org/show_bug.cgi?id=94947 --- Comment #8 from QA Administrators --- Dear Ofir, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 43459] Opening document fails when on samba mount with mixed OS windows/linux
https://bugs.documentfoundation.org/show_bug.cgi?id=43459 --- Comment #9 from QA Administrators --- Dear luis.public.mail, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 138882] Search in the Template Manager should not find non-template documents
https://bugs.documentfoundation.org/show_bug.cgi?id=138882 --- Comment #3 from QA Administrators --- Dear sdc.blanco, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 136638] Table style formatting not dynamic anymore after docx export
https://bugs.documentfoundation.org/show_bug.cgi?id=136638 --- Comment #6 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 122046] Data provider - crash when cancel merge columns (gen)
https://bugs.documentfoundation.org/show_bug.cgi?id=122046 --- Comment #9 from QA Administrators --- Dear raal, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 115081] Data validity restriction can be violated by copying value into a cell
https://bugs.documentfoundation.org/show_bug.cgi?id=115081 --- Comment #9 from QA Administrators --- Dear grofaty, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 107897] EDITING: Some images are not loaded after HTML table paste
https://bugs.documentfoundation.org/show_bug.cgi?id=107897 --- Comment #8 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.