[Libreoffice-bugs] [Bug 116022] Bullets not aligned with indents triangles in writer

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=116022

Buovjaga  changed:

   What|Removed |Added

 Resolution|FIXED   |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152805] indirekt() works incorrectly after Excel import

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152805

--- Comment #4 from lean...@wein-hilgert.de  ---
Created attachment 184493
  --> https://bugs.documentfoundation.org/attachment.cgi?id=184493=edit
ODS file with bug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152882] Draw freezes after copying object into clipboard

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152882

--- Comment #1 from monochro...@gmail.com ---
I cannot reproduce this on a nightly (I tried
LibreOfficeDev_7.6.0.0.alpha0_MacOS_aarch64).

I let the triaging people decide if this can be closed and if it's worth
backporting this to 7.4 :-).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152805] indirekt() works incorrectly after Excel import

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152805

--- Comment #3 from lean...@wein-hilgert.de  ---
Created attachment 184492
  --> https://bugs.documentfoundation.org/attachment.cgi?id=184492=edit
Excel file which was converted into an ods file

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 56973] UI: Copy / Paste sole sheet of a spreadsheet wrongly looks inactive

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=56973

Andreas Heinisch  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |andreas.heini...@yahoo.de
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: download.lst external/boost

2023-01-04 Thread Stephan Bergmann (via logerrit)
 download.lst   
  |4 
 
external/boost/0001-Avoid-boost-phoenix-placeholders-uarg1.10-ODR-violat.patch.2
 |   27 ++
 
external/boost/0001-Change-mpl-integral_c-to-boost-integral_constant-to-.patch.2
 |   91 --
 external/boost/UnpackedTarball_boost.mk
  |   10 -
 external/boost/boost.between.warning.patch 
  |   16 -
 external/boost/boost.fallback.encoding.patch   
  |4 
 external/boost/boost.noiconv.patch 
  |   78 
 external/boost/libc++.patch.0  
  |   12 -
 external/boost/windows-no-utf8-locales.patch.0 
  |   20 --
 9 files changed, 81 insertions(+), 181 deletions(-)

New commits:
commit ed259e5efe432386b54c553cbc644b3b64976852
Author: Stephan Bergmann 
AuthorDate: Wed Jan 4 17:57:45 2023 +0100
Commit: Stephan Bergmann 
CommitDate: Thu Jan 5 07:14:18 2023 +

Upgrade external/boost to latest Boost 1.81.0

 has been 
generated (on
Fedora 37) with

> $ wget 
https://boostorg.jfrog.io/artifactory/main/release/1.81.0/source/boost_1_81_0.tar.bz2
> $ printf 
'71feeed900fbccca04a3b4f2f84a7c217186f28a940ed8b7ed4725986baf99fa 
boost_1_81_0.tar.bz2' | sha256sum -c # cf. 

> boost_1_81_0.tar.bz2: OK
> $ external/boost/repack_tarball.sh boost_1_81_0.tar.bz2
> Unpacking boost_1_81_0.tar.bz2 ...
> Removing unnecessary files ...
> Creating boost_1_81_0.tar.xz ...
> Cleaning up ...
> 1deb0a5a9e33a6626fcaa1d2efd4c0e74ca2b0eea87c1559e3917f3066b633d6  
boost_1_81_0.tar.xz
> Done.

* external/boost/windows-no-utf8-locales.patch.0, introduced with
  f046fed2782f0d4244aff719ba70a56399a2583a "Don't ever attempt to 
initialise a
  std::locale with a UTF-8 locale on Windows", was presumably obsoleted by
  

  "Use UTF-16 <-> UTF-8 codecvt on Windows".

* external/boost/libc++.patch.0 was obsoleted by
  

  "The std lib unary/binary_function base classes are deprecated/removed 
from
  libcpp15."

* 
external/boost/0001-Change-mpl-integral_c-to-boost-integral_constant-to-.patch.2
  was obsoleted by
  

  "Change mpl::integral_c to boost::integral_constant to avoid Clang 16 
errors
  when constructing out of range enums (refs #24, boostorg/mpl#69)".

* 
external/boost/0001-Avoid-boost-phoenix-placeholders-uarg1.10-ODR-violat.patch.2
  is needed to e.g. avoid
> 
./.libs/libetonyek_internal.a(libetonyek_internal_la-KEY1DivElement.o):(.bss+0x3e):
 multiple definition of `boost::phoenix::placeholders::uarg1'; 
./.libs/libetonyek_internal.a(libetonyek_internal_la-IWORKFormula.o):(.bss+0x3e):
 first defined here
  etc. while building ExternalProject_libetonyek, caused by
  

  "std::tuple support (Resolving #103) (#104)".

Change-Id: I48773166d0c50f2850d8bb37fa6215d9e5c0d51d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145044
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist 

diff --git a/download.lst b/download.lst
index 6cfc19a0573b..c41e59d336fb 100644
--- a/download.lst
+++ b/download.lst
@@ -9,8 +9,8 @@ ABW_TARBALL := libabw-0.1.3.tar.xz
 # so that git cherry-pick
 # will not run into conflicts
 # please repack the tarball using external/boost/repack_tarball.sh
-BOOST_SHA256SUM := 
322e567e98c466c0aa0e380ed8c647552fe4af48998648428f1b5f0c8eff4666
-BOOST_TARBALL := boost_1_80_0.tar.xz
+BOOST_SHA256SUM := 
1deb0a5a9e33a6626fcaa1d2efd4c0e74ca2b0eea87c1559e3917f3066b633d6
+BOOST_TARBALL := boost_1_81_0.tar.xz
 # three static lines
 # so that git cherry-pick
 # will not run into conflicts
diff --git 
a/external/boost/0001-Avoid-boost-phoenix-placeholders-uarg1.10-ODR-violat.patch.2
 
b/external/boost/0001-Avoid-boost-phoenix-placeholders-uarg1.10-ODR-violat.patch.2
new file mode 100644
index ..e0989727fb5a
--- /dev/null
+++ 
b/external/boost/0001-Avoid-boost-phoenix-placeholders-uarg1.10-ODR-violat.patch.2
@@ -0,0 +1,27 @@
+From 50973dc10ea16931245ea61a00b2ce9041acc5ba Mon Sep 17 00:00:00 2001
+From: Stephan Bergmann 
+Date: Wed, 4 Jan 2023 17:33:31 +0100
+Subject: [PATCH] Avoid boost::phoenix::placeholders::uarg1..10 ODR violations
+
+Those variables, defined in an include file, had external linkage, causing ODR
+violations.  Make them const to implicitly give them 

[Libreoffice-commits] core.git: sw/inc sw/source

2023-01-04 Thread Miklos Vajna (via logerrit)
 sw/inc/fchrfmt.hxx  |2 ++
 sw/source/core/txtnode/chrfmt.cxx   |1 +
 sw/source/core/txtnode/fmtatr2.cxx  |   11 +++
 sw/source/core/txtnode/txatbase.cxx |7 ---
 4 files changed, 14 insertions(+), 7 deletions(-)

New commits:
commit 795a02b719a86dd128b10a867036a26450536c95
Author: Miklos Vajna 
AuthorDate: Wed Jan 4 20:04:35 2023 +0100
Commit: Miklos Vajna 
CommitDate: Thu Jan 5 07:12:03 2023 +

sw doc model xml dump: extract part of SwTextAttr::dumpAsXml() ...

... into SwFormatCharFormat().

This allows searching for a style name like Emphasis and search for all
uses, even if you're not confident wrt the name due to style name
collisions.

This also means that the impl details of SwFormatCharFormat now leak
less into SwTextAttr.

Change-Id: Ifb208d04c938b7070ec94ebe727309bab96266dc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145046
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/sw/inc/fchrfmt.hxx b/sw/inc/fchrfmt.hxx
index ef8719103f7c..87508596013b 100644
--- a/sw/inc/fchrfmt.hxx
+++ b/sw/inc/fchrfmt.hxx
@@ -68,6 +68,8 @@ public:
 pFormat->Add(this);
 }
 SwCharFormat* GetCharFormat() const { return 
const_cast(static_cast(GetRegisteredIn())); 
}
+
+void dumpAsXml(xmlTextWriterPtr pWriter) const override;
 };
 #endif
 
diff --git a/sw/source/core/txtnode/chrfmt.cxx 
b/sw/source/core/txtnode/chrfmt.cxx
index ea2bb5a45511..e22b6bab0421 100644
--- a/sw/source/core/txtnode/chrfmt.cxx
+++ b/sw/source/core/txtnode/chrfmt.cxx
@@ -26,6 +26,7 @@
 void SwCharFormat::dumpAsXml(xmlTextWriterPtr pWriter) const
 {
 (void)xmlTextWriterStartElement(pWriter, BAD_CAST("SwCharFormat"));
+(void)xmlTextWriterWriteFormatAttribute(pWriter, BAD_CAST("ptr"), "%p", 
this);
 (void)xmlTextWriterWriteAttribute(pWriter, BAD_CAST("name"),
   BAD_CAST(GetName().toUtf8().getStr()));
 
diff --git a/sw/source/core/txtnode/fmtatr2.cxx 
b/sw/source/core/txtnode/fmtatr2.cxx
index d3843f4db1e8..c776116a4ecc 100644
--- a/sw/source/core/txtnode/fmtatr2.cxx
+++ b/sw/source/core/txtnode/fmtatr2.cxx
@@ -113,6 +113,17 @@ bool SwFormatCharFormat::PutValue( const uno::Any& , 
sal_uInt8   )
 return false;
 }
 
+void SwFormatCharFormat::dumpAsXml(xmlTextWriterPtr pWriter) const
+{
+(void)xmlTextWriterStartElement(pWriter, BAD_CAST("SwFormatCharFormat"));
+(void)xmlTextWriterWriteFormatAttribute(pWriter, BAD_CAST("ptr"), "%p", 
this);
+(void)xmlTextWriterWriteFormatAttribute(pWriter, 
BAD_CAST("text-attribute"), "%p", m_pTextAttribute);
+(void)xmlTextWriterWriteFormatAttribute(pWriter, BAD_CAST("char-format"), 
"%p", GetCharFormat());
+(void)xmlTextWriterWriteAttribute(pWriter, BAD_CAST("char-format-name"),
+  
BAD_CAST(GetCharFormat()->GetName().toUtf8().getStr()));
+(void)xmlTextWriterEndElement(pWriter);
+}
+
 SwFormatAutoFormat::SwFormatAutoFormat( sal_uInt16 nInitWhich )
 : SfxPoolItem( nInitWhich )
 {
diff --git a/sw/source/core/txtnode/txatbase.cxx 
b/sw/source/core/txtnode/txatbase.cxx
index 011abccb4a71..1b65cf793448 100644
--- a/sw/source/core/txtnode/txatbase.cxx
+++ b/sw/source/core/txtnode/txatbase.cxx
@@ -113,13 +113,6 @@ void SwTextAttr::dumpAsXml(xmlTextWriterPtr pWriter) const
 case RES_TXTATR_FLYCNT:
 pWhich = "fly content";
 break;
-case RES_TXTATR_CHARFMT:
-{
-pWhich = "character format";
-if (SwCharFormat* pCharFormat = GetCharFormat().GetCharFormat())
-oValue = OString("name: " + 
OUStringToOString(pCharFormat->GetName(), RTL_TEXTENCODING_UTF8));
-break;
-}
 case RES_TXTATR_INETFMT:
 {
 pWhich = "inet format";


[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - 2 commits - desktop/source sw/qa sw/source

2023-01-04 Thread Miklos Vajna (via logerrit)
 desktop/source/lib/init.cxx |3 +-
 sw/qa/uibase/shells/shells.cxx  |   30 
 sw/qa/uibase/uno/uno.cxx|   29 +++
 sw/source/uibase/shells/textfld.cxx |   10 ++
 sw/source/uibase/uno/loktxdoc.cxx   |   53 
 5 files changed, 124 insertions(+), 1 deletion(-)

New commits:
commit 519ead63478a66f907c477dd15dba214d2b59f90
Author: Miklos Vajna 
AuthorDate: Tue Jan 3 11:28:04 2023 +0100
Commit: Miklos Vajna 
CommitDate: Thu Jan 5 07:11:15 2023 +

sw, lok: implement a getCommandValues(Fields)

There was no LOK API to get a list of all fields of a given type where
the name matches a certain prefix.

This is useful in case the API cilent wants to know what previously
inserted refmarks were deleted by the user as part of deleting text
content.

Add a new getCommandValues(".uno:Fields") that returns the names of
matching refmarks. Do not return the refmark text, assuming that would
be updated by the API client anyway.

In practice this is needed by Zotero in case it wants to model its
citations with refmarks.

(cherry picked from commit 3585d0414ffe08890856e5c09f453b9f566323df)

Change-Id: Ie469253891896aa8ab00d434c9ab116adbe3864b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144989
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Justin Luth 

diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index 617d5926dc0b..0c3be4b25743 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -5729,7 +5729,8 @@ static char* doc_getCommandValues(LibreOfficeKitDocument* 
pThis, const char* pCo
 static const std::initializer_list vForward = {
 u"TextFormFields",
 u"SetDocumentProperties",
-u"Bookmarks"
+u"Bookmarks",
+u"Fields"
 };
 
 if (!strcmp(pCommand, ".uno:LanguageStatus"))
diff --git a/sw/qa/uibase/uno/uno.cxx b/sw/qa/uibase/uno/uno.cxx
index 1664f18c5dda..41866636a969 100644
--- a/sw/qa/uibase/uno/uno.cxx
+++ b/sw/qa/uibase/uno/uno.cxx
@@ -214,6 +214,35 @@ CPPUNIT_TEST_FIXTURE(SwUibaseUnoTest, testGetBookmarks)
 CPPUNIT_ASSERT_EQUAL(static_cast(2), 
aTree.get_child("bookmarks").count(""));
 }
 
+CPPUNIT_TEST_FIXTURE(SwUibaseUnoTest, testGetFields)
+{
+// Given a document with a refmark:
+createSwDoc();
+uno::Sequence aArgs = {
+comphelper::makePropertyValue("TypeName", 
uno::Any(OUString("SetRef"))),
+comphelper::makePropertyValue(
+"Name", uno::Any(OUString("ZOTERO_ITEM CSL_CITATION {} 
RNDpyJknp173F"))),
+comphelper::makePropertyValue("Content", 
uno::Any(OUString("mycontent"))),
+};
+dispatchCommand(mxComponent, ".uno:InsertField", aArgs);
+
+// When getting the refmarks:
+tools::JsonWriter aJsonWriter;
+OString 
aCommand(".uno:Fields?typeName=SetRef=ZOTERO_ITEM%20CSL_CITATION");
+auto pXTextDocument = dynamic_cast(mxComponent.get());
+pXTextDocument->getCommandValues(aJsonWriter, aCommand);
+
+// Then make sure we get the 1 refmark:
+std::unique_ptr 
pJSON(aJsonWriter.extractData());
+std::stringstream aStream(pJSON.get());
+boost::property_tree::ptree aTree;
+boost::property_tree::read_json(aStream, aTree);
+// Without the accompanying fix in place, this test would have failed with:
+// - No such node (setRefs)
+// i.e. the returned JSON was just empty.
+CPPUNIT_ASSERT_EQUAL(static_cast(1), 
aTree.get_child("setRefs").count(""));
+}
+
 CPPUNIT_PLUGIN_IMPLEMENT();
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/uibase/uno/loktxdoc.cxx 
b/sw/source/uibase/uno/loktxdoc.cxx
index fd6d05eef132..ffcd967a6496 100644
--- a/sw/source/uibase/uno/loktxdoc.cxx
+++ b/sw/source/uibase/uno/loktxdoc.cxx
@@ -34,6 +34,7 @@
 #include 
 #include 
 #include 
+#include 
 
 using namespace ::com::sun::star;
 
@@ -170,6 +171,53 @@ void GetBookmarks(tools::JsonWriter& rJsonWriter, 
SwDocShell* pDocShell,
 rJsonWriter.put("name", pMark->GetName());
 }
 }
+
+/// Implements getCommandValues(".uno:Fields").
+///
+/// Parameters:
+///
+/// - typeName: field type condition to not return all fields
+/// - namePrefix: field name prefix to not return all fields
+void GetFields(tools::JsonWriter& rJsonWriter, SwDocShell* pDocShell,
+   const std::map& rArguments)
+{
+OUString aTypeName;
+{
+auto it = rArguments.find("typeName");
+if (it != rArguments.end())
+{
+aTypeName = it->second;
+}
+}
+// See SwFieldTypeFromString().
+if (aTypeName != "SetRef")
+{
+return;
+}
+
+OUString aNamePrefix;
+{
+auto it = rArguments.find("namePrefix");
+if (it != rArguments.end())
+{
+aNamePrefix = it->second;
+}
+}
+
+SwDoc* pDoc = pDocShell->GetDoc();
+

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - sw/inc sw/qa sw/sdi sw/source

2023-01-04 Thread Miklos Vajna (via logerrit)
 sw/inc/fldbas.hxx   |1 +
 sw/qa/uibase/fldui/fldui.cxx|   27 +++
 sw/sdi/swriter.sdi  |2 +-
 sw/source/core/fields/fldbas.cxx|   31 +++
 sw/source/uibase/fldui/fldmgr.cxx   |   35 +++
 sw/source/uibase/shells/textfld.cxx |5 +
 6 files changed, 100 insertions(+), 1 deletion(-)

New commits:
commit eb67d771af370465cb194ba6cfbda138ece9bb25
Author: Miklos Vajna 
AuthorDate: Wed Dec 21 14:51:08 2022 +0100
Commit: Miklos Vajna 
CommitDate: Thu Jan 5 07:10:49 2023 +

sw, field insert: handle the Content param for refmarks and accept HTML 
there

Creating a bookmark just to refer to it is a bit hacky, refmarks are the
proper solution to that.

But while .uno:InsertBookmark allows specifying custom HTML for the
content of the created bookmark, there is no matching UNO command that
would do the same for refmarks.

Fix the problem by extending .uno:InsertField:

- add a TypeName parameter, so TypeName=SetRef can be used in macros,
  which is more readable than Type=12

- handle the previously ignored Content parameter when creating a
  refmark and accept HTML there to allow rich formatting

Note that unlike bookmarks, refmarks are text attributes in a text node,
so in case multi-paragraph HTML would be provided, the created refmark
will only cover the content till the end of the first paragraph. Also
not that unlike fieldmarks and bookmarks, a refmark can only represent a
reference, not a bibliography, we'll need sections for that.

(cherry picked from commit 16075474819696f920979969474aa8300f4af530)

Conflicts:
sw/source/uibase/shells/textfld.cxx

Change-Id: I4d95f0a6e5618f1b611f7431e9189a63ee75d349
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144941
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Justin Luth 
Reviewed-by: Miklos Vajna 

diff --git a/sw/inc/fldbas.hxx b/sw/inc/fldbas.hxx
index 0251ba1f9a23..37e3d871ca0e 100644
--- a/sw/inc/fldbas.hxx
+++ b/sw/inc/fldbas.hxx
@@ -234,6 +234,7 @@ enum SwDateTimeSubType {
 
 /// General tools.
 OUString  FormatNumber(sal_uInt32 nNum, SvxNumType nFormat, LanguageType nLang 
= LANGUAGE_NONE);
+SwFieldTypesEnum SwFieldTypeFromString(std::u16string_view rString);
 
 /** Instances of SwFields and those derived from it occur 0 to n times.
  For each class there is one instance of the associated type class.
diff --git a/sw/qa/uibase/fldui/fldui.cxx b/sw/qa/uibase/fldui/fldui.cxx
index b3785f5ee072..b9a69936bd50 100644
--- a/sw/qa/uibase/fldui/fldui.cxx
+++ b/sw/qa/uibase/fldui/fldui.cxx
@@ -19,6 +19,7 @@
 #include 
 #include 
 #include 
+#include 
 
 using namespace com::sun::star;
 
@@ -91,6 +92,32 @@ CPPUNIT_TEST_FIXTURE(Test, testBiblioPageNumberUpdate)
 // i.e. the second biblio field's URL was not updated.
 CPPUNIT_ASSERT_EQUAL(aNewUrl, pEntry->GetAuthorField(AUTH_FIELD_URL));
 }
+
+CPPUNIT_TEST_FIXTURE(Test, testInsertRefmark)
+{
+// Given an empty document:
+SwDoc* pDoc = createSwDoc();
+
+// When inserting a refmark with text:
+uno::Sequence aArgs = {
+comphelper::makePropertyValue("TypeName", 
uno::Any(OUString("SetRef"))),
+comphelper::makePropertyValue(
+"Name", uno::Any(OUString("ZOTERO_ITEM CSL_CITATION {} 
RNDpyJknp173F"))),
+comphelper::makePropertyValue("Content", 
uno::Any(OUString("aaabbbccc"))),
+};
+dispatchCommand(mxComponent, ".uno:InsertField", aArgs);
+
+// Then make sure that we create a refmark that covers that text:
+SwWrtShell* pWrtShell = pDoc->GetDocShell()->GetWrtShell();
+SwTextNode* pTextNode = pWrtShell->GetCursor()->GetNode().GetTextNode();
+std::vector aAttrs = pTextNode->GetTextAttrsAt(0, 
RES_TXTATR_REFMARK);
+// Without the accompanying fix in place, this test would have failed with:
+// - Expected: 1
+// - Actual  : 0
+// i.e. no refmark was created, only the hard to read Type=12 created a 
refmark.
+CPPUNIT_ASSERT_EQUAL(static_cast(1), aAttrs.size());
+CPPUNIT_ASSERT_EQUAL(OUString("aaabbbccc"), pTextNode->GetText());
+}
 }
 
 CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/sw/sdi/swriter.sdi b/sw/sdi/swriter.sdi
index bc58977788a4..11ecc7c465e1 100644
--- a/sw/sdi/swriter.sdi
+++ b/sw/sdi/swriter.sdi
@@ -2855,7 +2855,7 @@ SfxVoidItem InsertEnvelope FN_ENVELOP
 ]
 
 SfxVoidItem InsertField FN_INSERT_FIELD
-(SfxUInt16Item Type FN_PARAM_FIELD_TYPE,SfxUInt16Item SubType 
FN_PARAM_FIELD_SUBTYPE,SfxStringItem Name FN_INSERT_FIELD,SfxStringItem Content 
FN_PARAM_FIELD_CONTENT,SfxUInt32Item Format FN_PARAM_FIELD_FORMAT,SfxStringItem 
Separator FN_PARAM_3)
+(SfxUInt16Item Type FN_PARAM_FIELD_TYPE,SfxUInt16Item SubType 
FN_PARAM_FIELD_SUBTYPE,SfxStringItem Name FN_INSERT_FIELD,SfxStringItem Content 
FN_PARAM_FIELD_CONTENT,SfxUInt32Item Format 

[Libreoffice-bugs] [Bug 132959] Save Image to PNG has no DPI written into the file

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132959

--- Comment #10 from Robert Großkopf  ---
Bug is still the same in LO 7.4.3.2 on OpenSUSE 15.3 64bit rpm Linux.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143987] Stylist: Merge PS and CS into one Text Styles view

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143987

--- Comment #19 from Mike Kaganski  ---
(In reply to David from comment #18)
> if a pane would have the ability to be undocked from the sidebar then it
> wouldn't show as part of the sidebar until it was re-docked back into it?

Exactly; and that means that there would be only a single instance of
Navigator, just as it was the case before introduction of the sidebar.

(Note that this discussion around Navigator and sidebar panels' undocking is
off-topic here; it was mentioned only to describe why the current situation
shouldn't be the model for other UI elements, and if a discussion is wanted, it
should happen in bug 85905 or another related issue; thus, I mark the unrelated
comments, including this my answer, as off-topic, to collapse them.)

-- 
You are receiving this mail because:
You are the assignee for the bug.

build failure on musl libc (linux) since 7.4

2023-01-04 Thread alice
starting from 7.4, building libreoffice fails with something like


[AWK] CustomTarget/postprocess/registry/fcfg_langpack_en-US.list
[CFG] registry
make[1]: /bin/sh: Argument list too long


a more full (still trimmed; it's huge) make -d output is available:
https://img.ayaya.dev/Ii6L84rHzXfv

i would assume this is a recent bug in the build system, as afaict the relevant
part of the length of the argument list there in that log is about 800k.
meanwhile:

$ getconf ARG_MAX # glibc
2097152
$ getconf ARG_MAX # musl
131072

and that has not changed for a long time for either (afaik). so, it would have
to be something changed since 7.3.7.2 (which builds fine).

i also reproduced this on latest master (around
d3a5a97f77378421f17b1fa43d0b88dde8bc686a) without any system libraries or fancy
configure arguments (just default ./configure), so i don't think any other
information is necessary, aside from it being with make 4.4.


[Libreoffice-bugs] [Bug 152879] Problems with the repeat rows / repeat columns

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152879

--- Comment #5 from Lehmeier  ---
What you write is correct. However, it also does not work if I insert $1 in the
repeat rows and $A in the repeat columns.

Because then only the field A1 (which contains the text for the connected
cells) should be repeated.
In the cross-printing, with the confirmations, there are no problems.
And this should also not occur if I enter $1 as the repeating columns$A:$I and
$1 as the repeating rows. 
Then only the cells $A1:I1 should be repeated and not whole columns, here the
error seems to have crept in that the repeat rows are not taken into account in
portrait format, while it is the case in landscape format.
Also, the result seems to be influenced by whether I join the cells concerned
or not.

P.S. 
The modified file with the pages formatted by hand and provided with a heading
is certainly also a solution to the problem - even if not the desired one.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152781] Format - Character: too many warnings in console with debug LO

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152781

--- Comment #10 from BogdanB  ---
> 
> The Spanish 'es' entry probably gets generated because you have
> /share/extensions/dict-es/es.{aff,dic} files on your
> system. Similar the "Spanish (United States) {es-US}" for
> /share/extensions/dict-es/es_US.{aff,dic} and "Spanish
> (Equatorial Guinea) {es-GQ}" for
> /share/extensions/dict-es/es_GQ.{aff,dic} and "Spanish
> (Philippines) {es-PH}" for
> /share/extensions/dict-es/es_PH.{aff,dic}
> 
> Though for es-GQ 0x7e0 and es-PH 0x7e1 we should probably have a better
> mapping involving the 0x00a primary language ID for Spanish instead of the
> on-the-fly IDs.

I reset to Factory Settings, so no user profile.
Also on my system I don't use and I don't have Spanish.
If someone else can confirm this languages appears no matter we are using
Spanish or not, this mean this languages should be added in langtab, and they
don't need to be shown if they are not used by user.

I have seen your recently commits, but I can't test them until next week.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: include/svx svx/source sw/source

2023-01-04 Thread Tomaž Vajngerl (via logerrit)
 include/svx/ColorSets.hxx   |2 ++
 svx/source/styles/ColorSets.cxx |5 +
 sw/source/uibase/sidebar/ThemePanel.cxx |   15 +++
 3 files changed, 22 insertions(+)

New commits:
commit 7c10e3b120ba75a2db75342fdc68040a179404b8
Author: Tomaž Vajngerl 
AuthorDate: Mon Dec 12 22:26:41 2022 +0900
Commit: Tomaž Vajngerl 
CommitDate: Thu Jan 5 05:55:51 2023 +

sw: add the ColorSet from SdrPage into ColorSets in ThemePanel

Change-Id: I7c4ef103b2be65a8adbad5d4f00304ee22be668f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143997
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl 

diff --git a/include/svx/ColorSets.hxx b/include/svx/ColorSets.hxx
index 718b79b3e66c..3d345b20c1b3 100644
--- a/include/svx/ColorSets.hxx
+++ b/include/svx/ColorSets.hxx
@@ -99,6 +99,8 @@ public:
 }
 
 const ColorSet& getColorSet(std::u16string_view rName);
+
+void insert(ColorSet const& rColorSet);
 };
 
 struct SVXCORE_DLLPUBLIC ThemeSupplementalFont
diff --git a/svx/source/styles/ColorSets.cxx b/svx/source/styles/ColorSets.cxx
index bb8009fdc5be..5511253f3d03 100644
--- a/svx/source/styles/ColorSets.cxx
+++ b/svx/source/styles/ColorSets.cxx
@@ -238,6 +238,11 @@ const ColorSet& ColorSets::getColorSet(std::u16string_view 
rName)
 return maColorSets[0];
 }
 
+void ColorSets::insert(ColorSet const& rColorSet)
+{
+maColorSets.push_back(rColorSet);
+}
+
 Theme::Theme(OUString const& rName)
 : maName(rName)
 {
diff --git a/sw/source/uibase/sidebar/ThemePanel.cxx 
b/sw/source/uibase/sidebar/ThemePanel.cxx
index 14a58b236d91..ad0d74e2b678 100644
--- a/sw/source/uibase/sidebar/ThemePanel.cxx
+++ b/sw/source/uibase/sidebar/ThemePanel.cxx
@@ -30,6 +30,11 @@
 #include 
 #include 
 #include 
+#include 
+#include 
+#include 
+#include 
+
 
 namespace
 {
@@ -442,6 +447,16 @@ ThemePanel::ThemePanel(weld::Widget* pParent)
 
 maColorSets.init();
 
+SwDocShell* pDocSh = static_cast(SfxObjectShell::Current());
+SwDoc* pDocument = pDocSh->GetDoc();
+if (pDocument)
+{
+SdrPage* pPage = 
pDocument->getIDocumentDrawModelAccess().GetDrawModel()->GetPage(0);
+svx::Theme* pTheme = pPage->getSdrPageProperties().GetTheme();
+if (pTheme)
+maColorSets.insert(*pTheme->GetColorSet());
+}
+
 const std::vector& aColorSets = maColorSets.getColorSets();
 for (size_t i = 0; i < aColorSets.size(); ++i)
 {


[Libreoffice-bugs] [Bug 135628] SendSimpleMailMessage bodytext ends up as multiple recipients

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135628

--- Comment #15 from dailyak77  ---
You will always need one recipient in the 'TO' field so in order for the mass
email to get sent, simply type your own email address there.
https://routerlogin.ltd/
https://pikashow.ltd/

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152626] libreoffice-draw: When I open LibreOffice Draw, I'm taken to the document recovery window.

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152626

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152613] Macro Basic: RAM isn't deallocated when macro is finished

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152613

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146934] Dedicated Crop Mark Tool is Needed

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=146934

QA Administrators  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146934] Dedicated Crop Mark Tool is Needed

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=146934

--- Comment #6 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149469] Install Windows 10 64 bit fails with version 7.3.3.2 with MSI error 1324 "The path Program Files contains an invalid character"

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149469

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149469] Install Windows 10 64 bit fails with version 7.3.3.2 with MSI error 1324 "The path Program Files contains an invalid character"

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149469

--- Comment #5 from QA Administrators  ---
Dear Jim Willis,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149257] Reduce jaggedness on right side of left justified paragraphs.

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149257

--- Comment #4 from QA Administrators  ---
Dear Charles Tivendale,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149257] Reduce jaggedness on right side of left justified paragraphs.

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149257

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 99986] EDITING: formula use in LO and save as XSLX give error in excel (function IF accept invalid reference)

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=99986

--- Comment #10 from QA Administrators  ---
Dear VLB,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 139961] Options dialog in Spelling and in Options - Language Settings - Writing Aids should distinguish between user-defined and shared dictionaries

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=139961

--- Comment #3 from QA Administrators  ---
Dear sdc.blanco,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 61424] CONFIGURATION: Normal view not possible with custom short cut key

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=61424

--- Comment #26 from QA Administrators  ---
Dear bugquestcontri,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 134725] Erratic behaviors in Basic IDE with mulitple controls selection

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=134725

--- Comment #7 from QA Administrators  ---
Dear blank15927,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 132959] Save Image to PNG has no DPI written into the file

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132959

--- Comment #9 from QA Administrators  ---
Dear Telesto,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 120911] Data Provider: Right size can be scrolled with no need

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120911

--- Comment #6 from QA Administrators  ---
Dear Xisco Faulí,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 119459] copy sections will fail in special cases: sections at beginning/end of document are lost

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=119459

--- Comment #3 from QA Administrators  ---
Dear Oliver Brinzing,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 101463] insert HyperLink fails for selections longer than 255 chars

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=101463

--- Comment #5 from QA Administrators  ---
Dear Björn Michaelsen,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152867] database range column names in formulae are converted to A1 notation

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152867

m.a.riosv  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1
 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #1 from m.a.riosv  ---
If I'm not wrong you are using structured references (from excel), it only can
be saved in xlsx file format, they are no implemented in ods file format.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152886] Setting:"Use english function names" changes valid decimal separator to dot despite set different in local settings

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152886

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg
 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from m.a.riosv  ---


*** This bug has been marked as a duplicate of bug 151886 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152879] Problems with the repeat rows / repeat columns

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152879

--- Comment #4 from m.a.riosv  ---
Created attachment 184491
  --> https://bugs.documentfoundation.org/attachment.cgi?id=184491=edit
Modified sample file

If you select Repeat columns : $A :$I, they are repeated on every page, and
there is no space for the other data.
If you set up the first column with what you need to be on every page it works
fine and more columns are allowed on the same page.
But seems there are not columns to repeat, so set up the rows to repeat and put
the page breaks by hand, easily with Menu/View/Page break, as in the attached
sample.
BTW and strange way to put that data, IMO every year should be one column, even
if for print, you cannot have all the data of one year in the same page, but
looks that the relevant it's having the last number of every year.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 130786] Bug in Text to Column function

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=130786

e688...@urhen.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152879] Problems with the repeat rows / repeat columns

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152879

--- Comment #3 from m.a.riosv  ---
Sorry, please forget the comment, it was for other thread.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152649] Crash with activated SKIA Option

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152649

--- Comment #12 from m.a.riosv  ---
In windows, you can't run directly soffice.bin it is not an executable for the
system.

You must run soffice.exe or soffice.com.
https://mikekaganski.wordpress.com/2018/11/21/proper-console-mode-for-libreoffice-on-windows/

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152879] Problems with the repeat rows / repeat columns

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152879

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #2 from m.a.riosv  ---
In windows, you can't run directly soffice.bin it is not an executable for the
system.

You must run soffice.exe or soffice.com.
https://mikekaganski.wordpress.com/2018/11/21/proper-console-mode-for-libreoffice-on-windows/

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152886] New: Setting:"Use english function names" changes valid decimal separator to dot despite set different in local settings

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152886

Bug ID: 152886
   Summary: Setting:"Use english function names" changes valid
decimal separator to dot despite set different in
local settings
   Product: LibreOffice
   Version: 7.4.3.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: e688...@urhen.com

Description:
Since this version the "Use english function names" settings changes the
decimal separator to dot despite set different in local settings.






This should not be happening. Decimal separator should be set with local
settings and english function names should have no impact on the separator 



Steps to Reproduce:
- Set local settings to any language that uses , as decimal separator. 

- Add formula  =1,1+1 and formula =1.1+1 to the sheet.

- First formular works, second doesn't as it should be.

- Now set the setting "Use english function names" under Libre Calc -> Formula
and observe the calculated formular change. 

- The , formula throws a #name error now while the . formula gets calculated
now.

Actual Results:
The "Use english function names" setting changes the valid decimal separator

Expected Results:
The "Use english function names" setting should NOT change the valid decimal
separator


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 7.4.2.3 (x64) / LibreOffice Community
Build ID: 382eef1f22670f7f4118c8c2dd222ec7ad009daf
CPU threads: 12; OS: Windows 10.0 Build 19042; UI render: default; VCL: win
Locale: de-DE (de_DE); UI: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: svtools/source

2023-01-04 Thread Eike Rathke (via logerrit)
 svtools/source/misc/langtab.cxx |6 ++
 1 file changed, 2 insertions(+), 4 deletions(-)

New commits:
commit cb4c33ef88a0ef252383e7a12678f28c4432347e
Author: Eike Rathke 
AuthorDate: Wed Jan 4 21:35:08 2023 +0100
Commit: Eike Rathke 
CommitDate: Thu Jan 5 00:29:39 2023 +

Related: tdf#152781 Add also non-on-the-fly IDs to language list

Generating names more than once is unnecessary.
This may happen for defined mappings that have no explicitly
predefined language list entry.

Change-Id: I278e6d77181b661a90d0fb133cb3ca30c2a9b721
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145049
Reviewed-by: Eike Rathke 
Tested-by: Jenkins

diff --git a/svtools/source/misc/langtab.cxx b/svtools/source/misc/langtab.cxx
index 0341e54949cc..0f5f15257856 100644
--- a/svtools/source/misc/langtab.cxx
+++ b/svtools/source/misc/langtab.cxx
@@ -243,10 +243,8 @@ OUString SvtLanguageTableImpl::GetString( const 
LanguageType eType ) const
 << " with unknown name, so returning generated: "
 << sLangTag);
 
-// And add it to the table if it is an on-the-fly-id, which it usually is,
-// so it is available in all subsequent language boxes.
-if (LanguageTag::isOnTheFlyID( nLang))
-const_cast(this)->AddEntry( sLangTag, nLang);
+// And add it to the table, so it is available in all subsequent language 
boxes.
+const_cast(this)->AddEntry( sLangTag, nLang);
 
 return sLangTag;
 }


[Libreoffice-bugs] [Bug 152781] Format - Character: too many warnings in console with debug LO

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152781

--- Comment #9 from Commit Notification 
 ---
Eike Rathke committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/cb4c33ef88a0ef252383e7a12678f28c4432347e

Related: tdf#152781 Add also non-on-the-fly IDs to language list

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152885] FILEOPEN RTF Page break and section break result in extra paragraph

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152885

--- Comment #2 from Gabor Kelemen (allotropia)  ---
Created attachment 184490
  --> https://bugs.documentfoundation.org/attachment.cgi?id=184490=edit
The example file saved as docx by Word

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152885] FILEOPEN RTF Page break and section break result in extra paragraph

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152885

--- Comment #1 from Gabor Kelemen (allotropia)  ---
Created attachment 184489
  --> https://bugs.documentfoundation.org/attachment.cgi?id=184489=edit
The example file in Word 2016 and Writer

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 81234] [META] RTF filter issues

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=81234

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

 Depends on||152885


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=152885
[Bug 152885] FILEOPEN RTF Page break and section break result in extra
paragraph
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152885] New: FILEOPEN RTF Page break and section break result in extra paragraph

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152885

Bug ID: 152885
   Summary: FILEOPEN RTF Page break and section break result in
extra paragraph
   Product: LibreOffice
   Version: 5.3.0.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kelem...@ubuntu.com
Blocks: 81234

Created attachment 184488
  --> https://bugs.documentfoundation.org/attachment.cgi?id=184488=edit
Example file from Word 2016

Attached RTF example file contains a page break and a continous section break
after each other.
In Word this results in a two pages document, with a paragraph at the very top
of the second page.
In Writer the document is two pages and there is an extra empty paragraph at
the very top of the second page, changing page layout.

1. Open attached file in Writer
2. Notice there is an empty paragraph before "Second page".

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 44355a90b3450111ad87ad4b6607a564e41d7b54
CPU threads: 14; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: de-DE (hu_HU); UI: en-US
Calc: threaded

Works like this since 5.3, before this commit it was worse (there was an extra
empty page):

https://git.libreoffice.org/core/+/50bf96d31ab2eb546f6c71cc93c1fa5dd4bf3044

author  Justin LuthSat Jun 25 22:21:08 2016 +0300
committer   Miklos Vajna   Wed Jun 29 07:35:54
2016 +

tdf#90697 docx - don't change continuous break into page break

Before that in 4.3 there were 2 pages but an extra empty paragraph before the
page break, so not exactly good either.

If the example file is saved as docx, it is displayed correctly in Writer since
6.0 commit:

https://git.libreoffice.org/core/+/cee02e81cd3b55fb46eacf5db5713e8bf4363bcd%5E%21/#F5

author  Justin LuthTue Apr 11 21:01:45 2017 +0300
committer   Justin LuthFri May 19 13:31:27
2017 +0200

ooxmlexport: roundtrip tdf#103975's unit tests


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=81234
[Bug 81234] [META] RTF filter issues
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152781] Format - Character: too many warnings in console with debug LO

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152781

--- Comment #8 from Commit Notification 
 ---
Eike Rathke committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/8343376c10eef50a022f600e0bd03f1384e9a288

Related: tdf#152781 s/lang-tag of/generated/ in SAL_WARN

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152781] Format - Character: too many warnings in console with debug LO

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152781

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.6.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: svtools/source

2023-01-04 Thread Eike Rathke (via logerrit)
 svtools/source/misc/langtab.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 8343376c10eef50a022f600e0bd03f1384e9a288
Author: Eike Rathke 
AuthorDate: Wed Jan 4 21:14:03 2023 +0100
Commit: Eike Rathke 
CommitDate: Wed Jan 4 23:13:52 2023 +

Related: tdf#152781 s/lang-tag of/generated/ in SAL_WARN

Only cosmetical to clarify, if possible a complete UI name is
generated, not just the language tag as before.

Change-Id: Id38e397793807762c2698948c325e6eeda989cc0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145048
Reviewed-by: Eike Rathke 
Tested-by: Jenkins

diff --git a/svtools/source/misc/langtab.cxx b/svtools/source/misc/langtab.cxx
index 18099a828f27..0341e54949cc 100644
--- a/svtools/source/misc/langtab.cxx
+++ b/svtools/source/misc/langtab.cxx
@@ -240,7 +240,7 @@ OUString SvtLanguageTableImpl::GetString( const 
LanguageType eType ) const
 OUString sLangTag( lcl_getDescription( LanguageTag(nLang)));
 SAL_WARN("svtools.misc", "Language: 0x"
 << std::hex << nLang
-<< " with unknown name, so returning lang-tag of: "
+<< " with unknown name, so returning generated: "
 << sLangTag);
 
 // And add it to the table if it is an on-the-fly-id, which it usually is,


[Libreoffice-bugs] [Bug 146598] Freezing when using cut, copy, or paste on macOS

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=146598

sco...@myfastmail.com changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEEDINFO|RESOLVED

--- Comment #27 from sco...@myfastmail.com ---
Just wanted to add my thanks!  This issue normally appeared when I had two (I
never was able to open more than two) documents at the same time -- normally a
Calc and a Writer document.  I didn't isolate it to when I did a Cut/Paste, but
I did a number of Cut/Pastes with 7.4.4.1 RC and the problem is completely
gone.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152805] indirekt() works incorrectly after Excel import

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152805

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 CC||79045_79...@mail.ru
 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #2 from Roman Kuznetsov <79045_79...@mail.ru> ---
PLease attach here your Excel (XLSX) document for testing

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152869] LibreOffice Writer crashes, when typing the document (macOS)

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152869

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

Summary|LibreOffice Writer crashes, |LibreOffice Writer crashes,
   |when typing the document|when typing the document
   ||(macOS)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 138786] PS formatting gets lost, if you paste text into an new document with same name of PS, but different settings (see comment 5)

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=138786

--- Comment #9 from Dieter  ---
I agree with your reasoning, Mike.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 138786] PS formatting gets lost, if you paste text into an new document with same name of PS, but different settings (see comment 5)

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=138786

--- Comment #9 from Dieter  ---
I agree with your reasoning, Mike.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 152878] FILEOPEN RTF Grouped shape opens with ghost shape and frame

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152878

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||79045_79...@mail.ru
 Status|UNCONFIRMED |NEW

--- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> ---
repro in

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: ec2f1d73936c9d8cee83c0887170e9ecb8f044ba
CPU threads: 16; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: ru-RU (ru_RU); UI: en-US
Calc: CL threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 94720] After merging the cells in the table containing the last row and selecting as column you can not format the cell contents (as if read-only)

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=94720

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||108816


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108816
[Bug 108816] [META] Writer toolbar bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 108816] [META] Writer toolbar bugs and enhancements

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108816

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||94720


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=94720
[Bug 94720] After merging the cells in the table containing the last row and
selecting as column you can not format the cell contents (as if read-only)
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 94720] After merging the cells in the table containing the last row and selecting as column you can not format the cell contents (as if read-only)

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=94720

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 CC||79045_79...@mail.ru

--- Comment #14 from Roman Kuznetsov <79045_79...@mail.ru> ---
Still repro in

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: ec2f1d73936c9d8cee83c0887170e9ecb8f044ba
CPU threads: 16; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: ru-RU (ru_RU); UI: en-US
Calc: CL threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143987] Stylist: Merge PS and CS into one Text Styles view

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143987

--- Comment #18 from David  ---
(In reply to Mike Kaganski from comment #16)
> (In reply to David from comment #15)
> 
> > exception *for the transitional period*, until the proper undocking will be
> implemented for sidebar panels - see bug 73151. 

I guess that means that if a pane would have the ability to be undocked from
the sidebar then it wouldn't show as part of the sidebar until it was re-docked
back into it? Am I understanding correctly?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152868] In Calc, a cell with a function returns a string to the active cell, but the string can not yet be pushed into a Designated Cell by a standard function. [1] Status "NEW

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152868

Bruce McCoy  changed:

   What|Removed |Added

Summary|In Calc, a cell with a  |In Calc, a cell with a
   |function returns a string   |function returns a string
   |to the active cell, but the |to the active cell, but the
   |string can not yet be   |string can not yet be
   |pushed into a Designated|pushed into a Designated
   |Cell by a standard  |Cell by a standard
   |function. [1]  Status "NEW" |function. [1]  Status "NEW"
   ||.cxx .hxx

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143987] Stylist: Merge PS and CS into one Text Styles view

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143987

--- Comment #17 from David  ---
(In reply to Mike Kaganski from comment #16)
> (In reply to David from comment #15)

> "How the navigator pane already functions" is not something that we can try
> to reproduce in new UI elements, because "how the navigator pane already
> functions" is just an artifact of transition from separate windows to
> sidebar, with the sidebar's current inability to undock separate panes -
> which, when Navigator was initially removed as a separate window, caused
> strong pushback, after which it was decided, that Navigator will be an
> exception *for the transitional period*, until the proper undocking will be
> implemented for sidebar panels - see bug 73151. So this curiosity is
> destined to be removed at some point (of course, it takes long, but this
> doesn't change things).

I depend heavily on having the navigator as a independent pane. I hope it
doesn't get removed. It saves me a tremendous amount of extra clicking.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152868] In Calc, a cell with a function returns a string to the active cell, but the string can not yet be pushed into a Designated Cell by a standard function. [1] Status "NEW

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152868

--- Comment #3 from Bruce McCoy  ---
Thanks to each of the kind people who graciously added valuable information to
help this Enhancement Request succeed.
.
ask.libreoffice.org:  Villeroy, Lupp, DanniStories, erAck.de, mikekaganski,
EarnestAl, JohnSUN, parsely
Libera.Chat:  @cloph, IZBot, intp, @mikekaganski, erAck 
#libera:  buZz, nckx, thumbs  
#libreoffice:  erAck

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103369] [META] Bullet, numbered, and outline list bugs and enhancements

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103369
Bug 103369 depends on bug 116022, which changed state.

Bug 116022 Summary: Bullets not aligned with indents triangles in writer
https://bugs.documentfoundation.org/show_bug.cgi?id=116022

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 116022] Bullets not aligned with indents triangles in writer

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=116022

m...@disroot.org changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #8 from m...@disroot.org ---
Fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 142801] Support partial transparency in table cell backgrounds

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=142801

--- Comment #5 from Eyal Rozenberg  ---
(In reply to Heiko Tietze from comment #3)
(In reply to Regina Henschel from comment #4)

So, we're all in agreement then... :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152836] Sort date

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152836

csyu@gmail.com changed:

   What|Removed |Added

 CC||csyu@gmail.com

--- Comment #1 from csyu@gmail.com ---
Could you provide an example, I was unable to reproduce the bug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: helpcontent2

2023-01-04 Thread Olivier Hallot (via logerrit)
 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 8d65f85fe61778ebc5ec82eba19990c502a0066e
Author: Olivier Hallot 
AuthorDate: Wed Jan 4 17:50:24 2023 -0300
Commit: Gerrit Code Review 
CommitDate: Wed Jan 4 20:50:24 2023 +

Update git submodules

* Update helpcontent2 from branch 'master'
  to 555355c795f9333735ae897b2eaace4b2ca88534
  - Refactor help page

Change-Id: I21f37ec313acf91a6e20ae9f1dd828556150a635
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/145019
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index fa2f89b91f8f..555355c795f9 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit fa2f89b91f8f06c44c50b800762ee47006402ddd
+Subproject commit 555355c795f9333735ae897b2eaace4b2ca88534


[Libreoffice-commits] help.git: source/text

2023-01-04 Thread Olivier Hallot (via logerrit)
 source/text/swriter/guide/form_letters_main.xhp |8 
 1 file changed, 4 insertions(+), 4 deletions(-)

New commits:
commit 555355c795f9333735ae897b2eaace4b2ca88534
Author: Olivier Hallot 
AuthorDate: Tue Jan 3 15:39:10 2023 -0300
Commit: Olivier Hallot 
CommitDate: Wed Jan 4 20:50:24 2023 +

Refactor help page

Change-Id: I21f37ec313acf91a6e20ae9f1dd828556150a635
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/145019
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/source/text/swriter/guide/form_letters_main.xhp 
b/source/text/swriter/guide/form_letters_main.xhp
index 4871a616d9..6db8693a89 100644
--- a/source/text/swriter/guide/form_letters_main.xhp
+++ b/source/text/swriter/guide/form_letters_main.xhp
@@ -30,13 +30,13 @@
   letters; creating form letters
   wizards;form letters
 mw added "serial letters"
-Creating a Form Letter
+Creating a Form Letter
 
-
+
   To 
create a form letter, you need a text document that contains fields for address 
data, and an address database. Then you combine or merge the address data and 
the text document to either print the letters or send them by email.
-  If 
the document is in HTML format, any embedded or linked images will not be sent 
with the email.
+  If the document is in HTML format, any 
embedded or linked images will not be sent with the email.
   The Mail Merge Wizard helps you to 
create form letters.
-  To create a form letter
+  To create a form letter
   
  
 Choose Tools - Mail Merge Wizard.


[Libreoffice-commits] core.git: helpcontent2

2023-01-04 Thread Olivier Hallot (via logerrit)
 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 0935d75a863d3ae3689a3c314b7f82bcbe2d7368
Author: Olivier Hallot 
AuthorDate: Wed Jan 4 17:49:58 2023 -0300
Commit: Gerrit Code Review 
CommitDate: Wed Jan 4 20:49:58 2023 +

Update git submodules

* Update helpcontent2 from branch 'master'
  to fa2f89b91f8f06c44c50b800762ee47006402ddd
  - tdf#152296 Content Controls Help Pages reviewed

- Added content control user guide
- Merged control properties pages
- New menu commands
- Entry in Contents tree

Change-Id: If4b550317c1d4cae3a06d8363058a7f3214621a9
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/144992
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 068fa934185d..fa2f89b91f8f 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 068fa934185da6e9e6f93a7abddd02b6f22572d7
+Subproject commit fa2f89b91f8f06c44c50b800762ee47006402ddd


[Libreoffice-commits] help.git: AllLangHelp_swriter.mk source/auxiliary source/text

2023-01-04 Thread Olivier Hallot (via logerrit)
 AllLangHelp_swriter.mk  |4 
 source/auxiliary/swriter.tree   |1 
 source/text/swriter/00/formmenu.xhp |   28 +++
 source/text/swriter/01/contentcontrol00.xhp |  114 
 source/text/swriter/01/contentcontrol01.xhp |   38 
 source/text/swriter/guide/contentcontrols.xhp   |  181 
 source/text/swriter/main0120.xhp|2 
 source/text/swriter/menu/contentcontrol_submenu.xhp |   59 ++
 8 files changed, 348 insertions(+), 79 deletions(-)

New commits:
commit fa2f89b91f8f06c44c50b800762ee47006402ddd
Author: Olivier Hallot 
AuthorDate: Tue Jan 3 15:01:26 2023 -0300
Commit: Olivier Hallot 
CommitDate: Wed Jan 4 20:49:57 2023 +

tdf#152296 Content Controls Help Pages reviewed

- Added content control user guide
- Merged control properties pages
- New menu commands
- Entry in Contents tree

Change-Id: If4b550317c1d4cae3a06d8363058a7f3214621a9
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/144992
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/AllLangHelp_swriter.mk b/AllLangHelp_swriter.mk
index 0805145d64..11cd361484 100644
--- a/AllLangHelp_swriter.mk
+++ b/AllLangHelp_swriter.mk
@@ -24,6 +24,7 @@ $(eval $(call gb_AllLangHelp_add_helpfiles,swriter,\
 helpcontent2/source/text/swriter/00/0404 \
 helpcontent2/source/text/swriter/00/0405 \
 helpcontent2/source/text/swriter/00/0406 \
+helpcontent2/source/text/swriter/00/formmenu \
 helpcontent2/source/text/swriter/00/stylesmenu \
 helpcontent2/source/text/swriter/01/0112 \
 helpcontent2/source/text/swriter/01/0115 \
@@ -207,7 +208,6 @@ $(eval $(call gb_AllLangHelp_add_helpfiles,swriter,\
 helpcontent2/source/text/swriter/01/title_page \
 helpcontent2/source/text/swriter/01/watermark \
 helpcontent2/source/text/swriter/01/contentcontrol00 \
-helpcontent2/source/text/swriter/01/contentcontrol01 \
 helpcontent2/source/text/swriter/02/0211 \
 helpcontent2/source/text/swriter/02/0321 \
 helpcontent2/source/text/swriter/02/0322 \
@@ -282,6 +282,7 @@ $(eval $(call gb_AllLangHelp_add_helpfiles,swriter,\
 helpcontent2/source/text/swriter/guide/chapter_numbering \
 helpcontent2/source/text/swriter/guide/conditional_text \
 helpcontent2/source/text/swriter/guide/conditional_text2 \
+helpcontent2/source/text/swriter/guide/contentcontrols \
 helpcontent2/source/text/swriter/guide/delete_from_dict \
 helpcontent2/source/text/swriter/guide/dragdroptext \
 helpcontent2/source/text/swriter/guide/even_odd_sdw \
@@ -423,6 +424,7 @@ $(eval $(call gb_AllLangHelp_add_helpfiles,swriter,\
 helpcontent2/source/text/swriter/menu/insert_footnote_endnote \
 helpcontent2/source/text/swriter/menu/insert_frame \
 helpcontent2/source/text/swriter/menu/submenu_more_breaks \
+helpcontent2/source/text/swriter/menu/contentcontrol_submenu \
 helpcontent2/source/text/swriter/mailmergetoolbar \
 helpcontent2/source/text/swriter/track_changes_toolbar \
 helpcontent2/source/text/swriter/navigate_toolbar \
diff --git a/source/auxiliary/swriter.tree b/source/auxiliary/swriter.tree
index 9c1433ce6a..879dea2898 100644
--- a/source/auxiliary/swriter.tree
+++ b/source/auxiliary/swriter.tree
@@ -149,6 +149,7 @@
   About Fields
   Inserting a Fixed 
or Variable Date Field
   Converting a 
Field into Text
+  Using Content 
Controls
 
 
   Calculating Across 
Tables
diff --git a/source/text/swriter/00/formmenu.xhp 
b/source/text/swriter/00/formmenu.xhp
new file mode 100644
index 00..bec090d72f
--- /dev/null
+++ b/source/text/swriter/00/formmenu.xhp
@@ -0,0 +1,28 @@
+
+
+
+
+
+
+The Form Menu
+/text/swriter/00/formmenu.xhp
+
+
+
+Choose Form - Content Control 
- Insert Rich Text.
+Choose Form - Content Control - Insert Plain 
Text.
+Choose Form - Content Control - Insert 
Picture.
+Choose Form - Content Control - Insert Check 
Box.
+Choose Form - Content Control - Insert Combo 
Box.
+Choose Form - Content Control - Insert Drop-down 
List.
+Choose Form - Content Control - Insert 
Date.
+Choose Form - Content Control - Content Control 
Properties.
+
+
diff --git a/source/text/swriter/01/contentcontrol00.xhp 
b/source/text/swriter/01/contentcontrol00.xhp
index 46ccac8266..82cd1bd365 100644
--- a/source/text/swriter/01/contentcontrol00.xhp
+++ b/source/text/swriter/01/contentcontrol00.xhp
@@ -1,44 +1,80 @@
 
 
+* This file is part of the LibreOffice project.
+*
+* This Source Code Form is subject to the terms of the Mozilla Public
+* License, v. 2.0. If a copy of the MPL was not distributed with this
+* file, You can obtain one at http://mozilla.org/MPL/2.0/.
+*
+* This file incorporates work covered by the following license notice:
+*
+*   Licensed to the 

[Libreoffice-bugs] [Bug 143987] Stylist: Merge PS and CS into one Text Styles view

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143987

--- Comment #16 from Mike Kaganski  ---
(In reply to David from comment #15)

IUUC, your comments then meant a vote for WONTFIX for the proposal here, based
on existing solution for the stated problem that the proposal intended to
solve.

The toolbar in question is not a solution at all. It is unavailable in some UI
configurations; it doesn't (and can't, because of limited space) have controls
for all character styles (only some are represented there as buttons) - or it
would then need even more space for page styles, frame styles, etc...

The proposal in comment 5 is intended to provide the maximum usability for
those who prefer a large window for the "active" style category, and at the
same time, providing immediate display of *all* active style names in
always-visible headings of collapsed categories. Indeed, this still requires
switching between the categories, which original proposal intended to avoid;
yet, comment 5 is expected to address the "current implementation of the
Stylist makes it unnecessarily difficult" piece of original description.

"How the navigator pane already functions" is not something that we can try to
reproduce in new UI elements, because "how the navigator pane already
functions" is just an artifact of transition from separate windows to sidebar,
with the sidebar's current inability to undock separate panes - which, when
Navigator was initially removed as a separate window, caused strong pushback,
after which it was decided, that Navigator will be an exception *for the
transitional period*, until the proper undocking will be implemented for
sidebar panels - see bug 73151. So this curiosity is destined to be removed at
some point (of course, it takes long, but this doesn't change things).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: oox/source sd/qa

2023-01-04 Thread Attila Szűcs (via logerrit)
 oox/source/drawingml/shape.cxx   |6 
 sd/qa/unit/data/pptx/tdf149588_transparentSolidFill.pptx |binary
 sd/qa/unit/import-tests2.cxx |   20 +++
 3 files changed, 26 insertions(+)

New commits:
commit 0cc9aaae5dc6655490513e8e4a93967f6248e23c
Author: Attila Szűcs 
AuthorDate: Wed Jan 4 00:40:23 2023 +0100
Commit: Andras Timar 
CommitDate: Wed Jan 4 20:38:38 2023 +

tdf#149588 pptx import: transparency at SolidFill

When copied color (RGB) property from text content to shape,
copy alpha component as well. (If text color have alpha component)

Change-Id: Ib86c48ab7b2d3c5f9491a2211b05e90b2c2ea10f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145031
Tested-by: Jenkins
Reviewed-by: Andras Timar 

diff --git a/oox/source/drawingml/shape.cxx b/oox/source/drawingml/shape.cxx
index fcc1e9016170..7cd02f77f91f 100644
--- a/oox/source/drawingml/shape.cxx
+++ b/oox/source/drawingml/shape.cxx
@@ -708,6 +708,12 @@ static void lcl_copyCharPropsToShape(const 
uno::Reference& xSha
 aFillColor = static_cast(
 
rCharProps.maFillProperties.maFillColor.getColor(rFilter.getGraphicHelper())
 .GetRGBColor());
+if (rCharProps.maFillProperties.maFillColor.hasTransparency())
+{
+const sal_Int16 aTransparence
+= 
rCharProps.maFillProperties.maFillColor.getTransparency();
+xSet->setPropertyValue(UNO_NAME_FILL_TRANSPARENCE, 
uno::Any(aTransparence));
+}
 }
 xSet->setPropertyValue(UNO_NAME_FILLCOLOR, uno::Any(aFillColor));
 
diff --git a/sd/qa/unit/data/pptx/tdf149588_transparentSolidFill.pptx 
b/sd/qa/unit/data/pptx/tdf149588_transparentSolidFill.pptx
new file mode 100644
index ..8967590b9284
Binary files /dev/null and 
b/sd/qa/unit/data/pptx/tdf149588_transparentSolidFill.pptx differ
diff --git a/sd/qa/unit/import-tests2.cxx b/sd/qa/unit/import-tests2.cxx
index b258c535e2c6..5d5864a2891e 100644
--- a/sd/qa/unit/import-tests2.cxx
+++ b/sd/qa/unit/import-tests2.cxx
@@ -145,6 +145,7 @@ public:
 void testTdf89928BlackWhiteThreshold();
 void testTdf151547TransparentWhiteText();
 void testTdf149961AutofitIndentation();
+void testTdf149588TransparentSolidFill();
 
 CPPUNIT_TEST_SUITE(SdImportTest2);
 
@@ -223,6 +224,7 @@ public:
 CPPUNIT_TEST(testTdf89928BlackWhiteThreshold);
 CPPUNIT_TEST(testTdf151547TransparentWhiteText);
 CPPUNIT_TEST(testTdf149961AutofitIndentation);
+CPPUNIT_TEST(testTdf149588TransparentSolidFill);
 
 CPPUNIT_TEST_SUITE_END();
 };
@@ -2009,6 +2011,24 @@ void SdImportTest2::testTdf149961AutofitIndentation()
 }
 }
 
+void SdImportTest2::testTdf149588TransparentSolidFill()
+{
+createSdImpressDoc("pptx/tdf149588_transparentSolidFill.pptx");
+saveAndReload("Impress MS PowerPoint 2007 XML");
+
+uno::Reference xShape(getShapeFromPage(6, 0));
+uno::Reference xParagraph(getParagraphFromShape(0, 
xShape));
+uno::Reference xRun(getRunFromParagraph(0, xParagraph));
+uno::Reference xPropSet(xRun, uno::UNO_QUERY_THROW);
+
+Color nCharColor;
+xPropSet->getPropertyValue("CharColor") >>= nCharColor;
+// Without the accompanying fix in place, this test would have failed with:
+// - Expected: Color: R:99 G:99 B:99 A   51  (T:204)
+// - Actual  : Color: R:99 G:99 B:99 A: 255  (T:  0)
+CPPUNIT_ASSERT_EQUAL(Color(ColorTransparency, 0xCC636363), nCharColor);
+}
+
 CPPUNIT_TEST_SUITE_REGISTRATION(SdImportTest2);
 
 CPPUNIT_PLUGIN_IMPLEMENT();


[Libreoffice-commits] core.git: sw/qa

2023-01-04 Thread Andrea Gelmini (via logerrit)
 sw/qa/extras/htmlimport/htmlimport.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit e2c3f00b37ec2d4e9bd36058b3cc5e0e5b5b0e02
Author: Andrea Gelmini 
AuthorDate: Wed Jan 4 20:06:05 2023 +0100
Commit: Julien Nabet 
CommitDate: Wed Jan 4 20:16:06 2023 +

Fix typo

Change-Id: Ic5e25545aecc6630da18d4b61217dab11f48470e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145047
Tested-by: Julien Nabet 
Reviewed-by: Julien Nabet 

diff --git a/sw/qa/extras/htmlimport/htmlimport.cxx 
b/sw/qa/extras/htmlimport/htmlimport.cxx
index c97d4e4cbde4..0bb761647904 100644
--- a/sw/qa/extras/htmlimport/htmlimport.cxx
+++ b/sw/qa/extras/htmlimport/htmlimport.cxx
@@ -569,7 +569,7 @@ CPPUNIT_TEST_FIXTURE(HtmlImportTest, testRGBAColor)
 const uno::Reference xRun(getRun(xPara,1), 
uno::UNO_QUERY);
 const Color nBackColor(0xaed89a);
 
-// Without the accompanying fix in place, this test would have failed, the 
backround
+// Without the accompanying fix in place, this test would have failed, the 
background
 // color was not imported at all, when it was in hex RGBA format in HTML.
 CPPUNIT_ASSERT_EQUAL(nBackColor, getProperty(xRun, 
"CharBackColor"));
 }


[Libreoffice-bugs] [Bug 152781] Format - Character: too many warnings in console with debug LO

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152781

--- Comment #7 from Eike Rathke  ---
(In reply to BogdanB from comment #5)
> Could be upper case the reason for error?
No. First, it's not an error, just an informational warning. Second, it's
simply that for the es-US language/locale we don't have a predefined entry in
the UI language list
svtools/inc/langtab.hrc
and the entry gets generated as "Spanish (United States) {es-US}" when
encountered.
There is no harm.


(In reply to BogdanB from comment #4)
>  in the list from description is
> just Spanish. So, I supose something is not well detected about Spanish
> language. ("Language: 0x7e0 with unknown name").
It's almost perfectly fine. Again, the reason is we don't have a predefined UI
language list entry.

The Spanish 'es' entry probably gets generated because you have
/share/extensions/dict-es/es.{aff,dic} files on your
system. Similar the "Spanish (United States) {es-US}" for
/share/extensions/dict-es/es_US.{aff,dic} and "Spanish
(Equatorial Guinea) {es-GQ}" for
/share/extensions/dict-es/es_GQ.{aff,dic} and "Spanish
(Philippines) {es-PH}" for
/share/extensions/dict-es/es_PH.{aff,dic}

Though for es-GQ 0x7e0 and es-PH 0x7e1 we should probably have a better mapping
involving the 0x00a primary language ID for Spanish instead of the on-the-fly
IDs.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152499] UI Variants dialog should have a Help button and a corresponding Help page

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152499

--- Comment #3 from Martin Srebotnjak  ---
This is a really special among LO dialogs - in itself it is very graphic and
includes an explanations for each option.
So, I don't know what a help page in this special case will bring - even more
extensive explanations and more pictures for every option?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152397] The explanation of the help page about Calc Input settings is not appropriate.

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152397

--- Comment #3 from Martin Srebotnjak  ---
each time Enter is pressed will select -> each time
Enter is pressed it will select

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152480] Writer hangs when opening dialogs for paragraph and character formatting.

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152480

--- Comment #4 from Julien Nabet  ---
(In reply to Stian from comment #3)
> Thank you for looking into my bug   : - )
> 
> My Libre Office is 64 bit. Latest stable version from December 2022.
> My Java is also 64-bit. I downloaded Java and installed it on Dec. 8 2022.
> I do not know if L-o detected Java automatically - as you are asking. This
> was not a topic during setup, and I know nothing about it. I registered Java
> in L-o according to a Mozilla article.
> I did not install a Java editor. It is not mentioned as a requirement, and I
> know nothing about it.
I meant the different "vendors" (see
https://dzone.com/articles/an-overview-on-jdk-vendors).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: vcl/headless vcl/inc vcl/unx

2023-01-04 Thread Caolán McNamara (via logerrit)
 vcl/headless/CairoCommon.cxx|   35 
 vcl/headless/SvpGraphicsBackend.cxx |   29 ++-
 vcl/inc/headless/CairoCommon.hxx|6 
 vcl/unx/generic/gdi/X11CairoSalGraphicsImpl.cxx |   14 +
 vcl/unx/generic/gdi/X11CairoSalGraphicsImpl.hxx |3 ++
 vcl/unx/generic/gdi/gdiimpl.cxx |5 ---
 vcl/unx/generic/gdi/gdiimpl.hxx |1 
 7 files changed, 62 insertions(+), 31 deletions(-)

New commits:
commit dcde0b2e640c0fe36dceb49bfed5426842a6fa0a
Author: Caolán McNamara 
AuthorDate: Mon Jan 2 21:29:01 2023 +
Commit: Caolán McNamara 
CommitDate: Wed Jan 4 19:25:42 2023 +

move implDrawGradient into CairoCommon and reuse from 
X11CairoSalGraphicsImpl

Change-Id: I341e0b1e3cccd18193c3f9798b875a709fe4871f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144975
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/vcl/headless/CairoCommon.cxx b/vcl/headless/CairoCommon.cxx
index b79d942709b6..cfd463da41e3 100644
--- a/vcl/headless/CairoCommon.cxx
+++ b/vcl/headless/CairoCommon.cxx
@@ -20,6 +20,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -887,6 +888,40 @@ bool CairoCommon::drawPolyLine(cairo_t* cr, 
basegfx::B2DRange* pExtents, const C
 return true;
 }
 
+bool CairoCommon::implDrawGradient(cairo_t* cr, basegfx::B2DRange* pExtents, 
bool bAntiAlias,
+   basegfx::B2DPolyPolygon const& rPolyPolygon,
+   SalGradient const& rGradient)
+{
+basegfx::B2DHomMatrix rObjectToDevice;
+
+for (auto const& rPolygon : rPolyPolygon)
+AddPolygonToPath(cr, rPolygon, rObjectToDevice, !bAntiAlias, false);
+
+cairo_pattern_t* pattern
+= cairo_pattern_create_linear(rGradient.maPoint1.getX(), 
rGradient.maPoint1.getY(),
+  rGradient.maPoint2.getX(), 
rGradient.maPoint2.getY());
+
+for (SalGradientStop const& rStop : rGradient.maStops)
+{
+double r = rStop.maColor.GetRed() / 255.0;
+double g = rStop.maColor.GetGreen() / 255.0;
+double b = rStop.maColor.GetBlue() / 255.0;
+double a = rStop.maColor.GetAlpha() / 255.0;
+double offset = rStop.mfOffset;
+
+cairo_pattern_add_color_stop_rgba(pattern, offset, r, g, b, a);
+}
+cairo_set_source(cr, pattern);
+cairo_pattern_destroy(pattern);
+
+if (pExtents)
+*pExtents = getClippedFillDamage(cr);
+
+cairo_fill_preserve(cr);
+
+return true;
+}
+
 namespace
 {
 basegfx::B2DRange renderWithOperator(cairo_t* cr, const SalTwoRect& rTR, 
cairo_surface_t* source,
diff --git a/vcl/headless/SvpGraphicsBackend.cxx 
b/vcl/headless/SvpGraphicsBackend.cxx
index 63e66d9a31e2..6f527f350760 100644
--- a/vcl/headless/SvpGraphicsBackend.cxx
+++ b/vcl/headless/SvpGraphicsBackend.cxx
@@ -959,36 +959,15 @@ bool 
SvpGraphicsBackend::implDrawGradient(basegfx::B2DPolyPolygon const& rPolyPo
   SalGradient const& rGradient)
 {
 cairo_t* cr = m_rCairoCommon.getCairoContext(true, getAntiAlias());
+basegfx::B2DRange extents;
 m_rCairoCommon.clipRegion(cr);
 
-basegfx::B2DHomMatrix rObjectToDevice;
-
-for (auto const& rPolygon : rPolyPolygon)
-AddPolygonToPath(cr, rPolygon, rObjectToDevice, !getAntiAlias(), 
false);
-
-cairo_pattern_t* pattern
-= cairo_pattern_create_linear(rGradient.maPoint1.getX(), 
rGradient.maPoint1.getY(),
-  rGradient.maPoint2.getX(), 
rGradient.maPoint2.getY());
-
-for (SalGradientStop const& rStop : rGradient.maStops)
-{
-double r = rStop.maColor.GetRed() / 255.0;
-double g = rStop.maColor.GetGreen() / 255.0;
-double b = rStop.maColor.GetBlue() / 255.0;
-double a = rStop.maColor.GetAlpha() / 255.0;
-double offset = rStop.mfOffset;
-
-cairo_pattern_add_color_stop_rgba(pattern, offset, r, g, b, a);
-}
-cairo_set_source(cr, pattern);
-cairo_pattern_destroy(pattern);
-
-basegfx::B2DRange extents = getClippedFillDamage(cr);
-cairo_fill_preserve(cr);
+bool bRetVal(
+CairoCommon::implDrawGradient(cr, , getAntiAlias(), 
rPolyPolygon, rGradient));
 
 m_rCairoCommon.releaseCairoContext(cr, true, extents);
 
-return true;
+return bRetVal;
 }
 
 bool SvpGraphicsBackend::supportsOperation(OutDevSupportType eType) const
diff --git a/vcl/inc/headless/CairoCommon.hxx b/vcl/inc/headless/CairoCommon.hxx
index e232d2167380..dfee58b1a9f2 100644
--- a/vcl/inc/headless/CairoCommon.hxx
+++ b/vcl/inc/headless/CairoCommon.hxx
@@ -45,6 +45,8 @@ typedef struct _cairo cairo_t;
 typedef struct _cairo_surface cairo_surface_t;
 typedef struct _cairo_user_data_key cairo_user_data_key_t;
 
+struct SalGradient;
+
 VCL_DLLPUBLIC void dl_cairo_surface_set_device_scale(cairo_surface_t* surface, 

[Libreoffice-commits] core.git: 2 commits - vcl/headless vcl/inc vcl/unx

2023-01-04 Thread Caolán McNamara (via logerrit)
 vcl/headless/CairoCommon.cxx|   11 +++
 vcl/headless/SvpGraphicsBackend.cxx |8 +---
 vcl/inc/headless/CairoCommon.hxx|3 +++
 vcl/unx/generic/gdi/X11CairoSalGraphicsImpl.cxx |5 +
 vcl/unx/generic/gdi/X11CairoSalGraphicsImpl.hxx |2 ++
 vcl/unx/generic/gdi/gdiimpl.cxx |   24 
 vcl/unx/generic/gdi/gdiimpl.hxx |2 --
 7 files changed, 22 insertions(+), 33 deletions(-)

New commits:
commit 06c0b13cbbd1672861ebd898e0e11981c5bb82a8
Author: Caolán McNamara 
AuthorDate: Mon Jan 2 21:11:38 2023 +
Commit: Caolán McNamara 
CommitDate: Wed Jan 4 19:25:29 2023 +

move supportsOperation to CairoCommon

Change-Id: I754080c322ec76ec8e218f8c97b1649eaf922c74
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144974
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/vcl/headless/CairoCommon.cxx b/vcl/headless/CairoCommon.cxx
index 3a8010f21b59..b79d942709b6 100644
--- a/vcl/headless/CairoCommon.cxx
+++ b/vcl/headless/CairoCommon.cxx
@@ -1112,6 +1112,17 @@ cairo_surface_t* CairoCommon::createCairoSurface(const 
BitmapBuffer* pBuffer)
 return target;
 }
 
+bool CairoCommon::supportsOperation(OutDevSupportType eType)
+{
+switch (eType)
+{
+case OutDevSupportType::TransparentRect:
+case OutDevSupportType::B2DDraw:
+return true;
+}
+return false;
+}
+
 std::unique_ptr FastConvert24BitRgbTo32BitCairo(const 
BitmapBuffer* pSrc)
 {
 if (pSrc == nullptr)
diff --git a/vcl/headless/SvpGraphicsBackend.cxx 
b/vcl/headless/SvpGraphicsBackend.cxx
index 355a971b9b01..63e66d9a31e2 100644
--- a/vcl/headless/SvpGraphicsBackend.cxx
+++ b/vcl/headless/SvpGraphicsBackend.cxx
@@ -993,13 +993,7 @@ bool 
SvpGraphicsBackend::implDrawGradient(basegfx::B2DPolyPolygon const& rPolyPo
 
 bool SvpGraphicsBackend::supportsOperation(OutDevSupportType eType) const
 {
-switch (eType)
-{
-case OutDevSupportType::TransparentRect:
-case OutDevSupportType::B2DDraw:
-return true;
-}
-return false;
+return CairoCommon::supportsOperation(eType);
 }
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/inc/headless/CairoCommon.hxx b/vcl/inc/headless/CairoCommon.hxx
index 3bf132c95894..e232d2167380 100644
--- a/vcl/inc/headless/CairoCommon.hxx
+++ b/vcl/inc/headless/CairoCommon.hxx
@@ -27,6 +27,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 
 #include 
@@ -172,6 +173,8 @@ struct VCL_DLLPUBLIC CairoCommon
 
 static cairo_surface_t* createCairoSurface(const BitmapBuffer* pBuffer);
 
+static bool supportsOperation(OutDevSupportType eType);
+
 private:
 void doXorOnRelease(sal_Int32 nExtentsLeft, sal_Int32 nExtentsTop, 
sal_Int32 nExtentsRight,
 sal_Int32 nExtentsBottom, cairo_surface_t* const 
surface,
diff --git a/vcl/unx/generic/gdi/X11CairoSalGraphicsImpl.cxx 
b/vcl/unx/generic/gdi/X11CairoSalGraphicsImpl.cxx
index fd030b112f38..a4ea13a63079 100644
--- a/vcl/unx/generic/gdi/X11CairoSalGraphicsImpl.cxx
+++ b/vcl/unx/generic/gdi/X11CairoSalGraphicsImpl.cxx
@@ -153,13 +153,7 @@ bool X11CairoSalGraphicsImpl::drawPolyLine(const 
basegfx::B2DHomMatrix& rObjectT
 
 bool X11CairoSalGraphicsImpl::supportsOperation(OutDevSupportType eType) const
 {
-switch (eType)
-{
-case OutDevSupportType::TransparentRect:
-case OutDevSupportType::B2DDraw:
-return true;
-}
-return false;
+return CairoCommon::supportsOperation(eType);
 }
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
commit 0ec1a28b4d43fc78cb5cc4c23dd0e76fd62d5e69
Author: Caolán McNamara 
AuthorDate: Mon Jan 2 21:07:14 2023 +
Commit: Caolán McNamara 
CommitDate: Wed Jan 4 19:25:18 2023 +

move supportsOperation to X11CairoSalGraphicsImpl

Change-Id: Ic5a8652857d0104310d1aead8a55d0f053852c6d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144973
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/vcl/unx/generic/gdi/X11CairoSalGraphicsImpl.cxx 
b/vcl/unx/generic/gdi/X11CairoSalGraphicsImpl.cxx
index 438aaf46b455..fd030b112f38 100644
--- a/vcl/unx/generic/gdi/X11CairoSalGraphicsImpl.cxx
+++ b/vcl/unx/generic/gdi/X11CairoSalGraphicsImpl.cxx
@@ -151,4 +151,15 @@ bool X11CairoSalGraphicsImpl::drawPolyLine(const 
basegfx::B2DHomMatrix& rObjectT
 return bRetval;
 }
 
+bool X11CairoSalGraphicsImpl::supportsOperation(OutDevSupportType eType) const
+{
+switch (eType)
+{
+case OutDevSupportType::TransparentRect:
+case OutDevSupportType::B2DDraw:
+return true;
+}
+return false;
+}
+
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/unx/generic/gdi/X11CairoSalGraphicsImpl.hxx 
b/vcl/unx/generic/gdi/X11CairoSalGraphicsImpl.hxx
index 2c7ab449a97c..ae47dc061ae0 100644
--- 

[Libreoffice-commits] core.git: vcl/headless vcl/unx

2023-01-04 Thread Caolán McNamara (via logerrit)
 vcl/headless/SvpGraphicsBackend.cxx |2 --
 vcl/unx/generic/gdi/X11CairoSalGraphicsImpl.cxx |   14 --
 2 files changed, 4 insertions(+), 12 deletions(-)

New commits:
commit b62e3e164ef6af83e03e106e188c06eb5b91f51d
Author: Caolán McNamara 
AuthorDate: Mon Jan 2 21:03:45 2023 +
Commit: Caolán McNamara 
CommitDate: Wed Jan 4 19:24:24 2023 +

sync drawPolyLine impls early returns

Change-Id: I9b7c49d0e4286245979043e1cb21f8b577676f87
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144972
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 

diff --git a/vcl/headless/SvpGraphicsBackend.cxx 
b/vcl/headless/SvpGraphicsBackend.cxx
index a47332173676..355a971b9b01 100644
--- a/vcl/headless/SvpGraphicsBackend.cxx
+++ b/vcl/headless/SvpGraphicsBackend.cxx
@@ -360,9 +360,7 @@ bool SvpGraphicsBackend::drawPolyLine(const 
basegfx::B2DHomMatrix& rObjectToDevi
 {
 // short circuit if there is nothing to do
 if (0 == rPolyLine.count() || fTransparency < 0.0 || fTransparency >= 1.0)
-{
 return true;
-}
 
 // Wrap call to static version of ::drawPolyLine by
 // preparing/getting some local data and parameters
diff --git a/vcl/unx/generic/gdi/X11CairoSalGraphicsImpl.cxx 
b/vcl/unx/generic/gdi/X11CairoSalGraphicsImpl.cxx
index 874bf4bd4cf8..438aaf46b455 100644
--- a/vcl/unx/generic/gdi/X11CairoSalGraphicsImpl.cxx
+++ b/vcl/unx/generic/gdi/X11CairoSalGraphicsImpl.cxx
@@ -126,22 +126,16 @@ bool X11CairoSalGraphicsImpl::drawPolyPolygon(const 
basegfx::B2DHomMatrix& rObje
 }
 
 bool X11CairoSalGraphicsImpl::drawPolyLine(const basegfx::B2DHomMatrix& 
rObjectToDevice,
-   const basegfx::B2DPolygon& rPolygon,
+   const basegfx::B2DPolygon& 
rPolyLine,
double fTransparency, double 
fLineWidth,
const std::vector* pStroke,
basegfx::B2DLineJoin eLineJoin,
css::drawing::LineCap eLineCap,
double fMiterMinimumAngle, bool 
bPixelSnapHairline)
 {
-if (0 == rPolygon.count())
-{
+// short circuit if there is nothing to do
+if (0 == rPolyLine.count() || fTransparency < 0.0 || fTransparency >= 1.0)
 return true;
-}
-
-if (fTransparency >= 1.0)
-{
-return true;
-}
 
 cairo_t* cr = mrX11Common.getCairoContext();
 clipRegion(cr);
@@ -149,7 +143,7 @@ bool X11CairoSalGraphicsImpl::drawPolyLine(const 
basegfx::B2DHomMatrix& rObjectT
 // Use the now available static drawPolyLine from the 
Cairo-Headless-Fallback
 // that will take care of all needed stuff
 const bool bRetval(CairoCommon::drawPolyLine(
-cr, nullptr, mnPenColor, getAntiAlias(), rObjectToDevice, rPolygon, 
fTransparency,
+cr, nullptr, mnPenColor, getAntiAlias(), rObjectToDevice, rPolyLine, 
fTransparency,
 fLineWidth, pStroke, eLineJoin, eLineCap, fMiterMinimumAngle, 
bPixelSnapHairline));
 
 X11Common::releaseCairoContext(cr);


[Libreoffice-commits] core.git: vcl/unx

2023-01-04 Thread Caolán McNamara (via logerrit)
 vcl/unx/generic/gdi/X11CairoSalGraphicsImpl.cxx |4 
 vcl/unx/generic/gdi/X11CairoSalGraphicsImpl.hxx |7 ---
 vcl/unx/generic/gdi/salgdi.cxx  |6 --
 3 files changed, 17 deletions(-)

New commits:
commit ae8c40abd2e1af063a4d199e4f198b3d78964f34
Author: Caolán McNamara 
AuthorDate: Mon Jan 2 20:48:07 2023 +
Commit: Caolán McNamara 
CommitDate: Wed Jan 4 19:23:50 2023 +

always use X11CairoSalGraphicsImpl

Change-Id: I7971e17eb7eb9778fcc2d3e7c98028c6cd438004
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144971
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/vcl/unx/generic/gdi/X11CairoSalGraphicsImpl.cxx 
b/vcl/unx/generic/gdi/X11CairoSalGraphicsImpl.cxx
index 0a1e8fe02200..874bf4bd4cf8 100644
--- a/vcl/unx/generic/gdi/X11CairoSalGraphicsImpl.cxx
+++ b/vcl/unx/generic/gdi/X11CairoSalGraphicsImpl.cxx
@@ -19,8 +19,6 @@
 
 #include "X11CairoSalGraphicsImpl.hxx"
 
-#if ENABLE_CAIRO_CANVAS
-
 #include 
 #include 
 
@@ -159,6 +157,4 @@ bool X11CairoSalGraphicsImpl::drawPolyLine(const 
basegfx::B2DHomMatrix& rObjectT
 return bRetval;
 }
 
-#endif
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/unx/generic/gdi/X11CairoSalGraphicsImpl.hxx 
b/vcl/unx/generic/gdi/X11CairoSalGraphicsImpl.hxx
index 41a3d945f607..2c7ab449a97c 100644
--- a/vcl/unx/generic/gdi/X11CairoSalGraphicsImpl.hxx
+++ b/vcl/unx/generic/gdi/X11CairoSalGraphicsImpl.hxx
@@ -17,11 +17,6 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#include 
-#include 
-
-#if ENABLE_CAIRO_CANVAS
-
 #include 
 #include 
 #include "gdiimpl.hxx"
@@ -92,6 +87,4 @@ public:
   bool bPixelSnapHairline) override;
 };
 
-#endif
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/unx/generic/gdi/salgdi.cxx b/vcl/unx/generic/gdi/salgdi.cxx
index d6eecfecb1e8..7ee133d2c87f 100644
--- a/vcl/unx/generic/gdi/salgdi.cxx
+++ b/vcl/unx/generic/gdi/salgdi.cxx
@@ -57,9 +57,7 @@
 #include "cairo_xlib_cairo.hxx"
 #include 
 
-#if ENABLE_CAIRO_CANVAS
 #include "X11CairoSalGraphicsImpl.hxx"
-#endif
 
 
 // X11Common
@@ -121,11 +119,7 @@ X11SalGraphics::X11SalGraphics():
 #endif
 {
 mxTextRenderImpl.reset(new X11CairoTextRender(*this));
-#if ENABLE_CAIRO_CANVAS
 mxImpl.reset(new X11CairoSalGraphicsImpl(*this, maX11Common));
-#else
-mxImpl.reset(new X11SalGraphicsImpl(*this));
-#endif
 }
 }
 


[Libreoffice-bugs] [Bug 143987] Stylist: Merge PS and CS into one Text Styles view

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143987

--- Comment #15 from David  ---


(In reply to Mike Kaganski from comment #14)
> (In reply to David from comment #13)
> 
> Hmm, I'm sorry how comments 11-13 relate to the problem discussed here, and
> wonder why have they appeared here: I presume, they intend to help decide on
> something?

The first paragraph of the original request described the difficulty switching
between style categories

The second paragraph of the request gave a proposed solution.

My point is that the styles toolbar already gives the capability of displaying
a customizable core subset of styles from multiple categories thereby possibly
alleviating the need for the proposed solution, which if implemented might
disrupt the workflow of others.

Another solution would be to make the styles pane consistent with how the
navigator pane already functions. The navigator can be an independent pane
while also being in the sidebar. As an independent pane the styles pane could
be docked below the sidebar or wherever the user chooses while still being
included in the sidebar, just as the navigator currently operates. That would
also have the added benefit of UI consistency.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152880] Some submenu from Form - Content Controls need removal for Insert term

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152880

BogdanB  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |buzea.bog...@libreoffice.or
   |desktop.org |g
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: extras/source

2023-01-04 Thread Julien Nabet (via logerrit)
 extras/source/autocorr/lang/tr/DocumentList.xml |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit d804a251026ec435626226c54b7af172b37314f1
Author: Julien Nabet 
AuthorDate: Sun Jan 1 13:02:20 2023 +0100
Commit: Julien Nabet 
CommitDate: Wed Jan 4 18:59:36 2023 +

Remove "tr" autocorr entries that correct to itself

Change-Id: I969026e5847852a59e429ce5b0bbf491452302c3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144921
Reviewed-by: Caolán McNamara 
Reviewed-by: Muhammet Kara 
Tested-by: Julien Nabet 

diff --git a/extras/source/autocorr/lang/tr/DocumentList.xml 
b/extras/source/autocorr/lang/tr/DocumentList.xml
index 4b1de91dfd48..fe767b23aa30 100644
--- a/extras/source/autocorr/lang/tr/DocumentList.xml
+++ b/extras/source/autocorr/lang/tr/DocumentList.xml
@@ -567,7 +567,7 @@
   
   
   
-  
+  
   
   
   


[Libreoffice-bugs] [Bug 152703] Skia - resizing StartCenter window with mouse leaves black undrawn areas until mouse button released

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152703

--- Comment #10 from Commit Notification 
 ---
Patrick Luby committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/3f7406bc4df3c7d6cc618312607bff1ec36a12f7

tdf#152703 Force relayout during live resizing of window

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: vcl/inc vcl/osx

2023-01-04 Thread Patrick Luby (via logerrit)
 vcl/inc/osx/salframeview.h |1 +
 vcl/osx/salframeview.mm|   39 ++-
 2 files changed, 31 insertions(+), 9 deletions(-)

New commits:
commit 3f7406bc4df3c7d6cc618312607bff1ec36a12f7
Author: Patrick Luby 
AuthorDate: Wed Jan 4 10:10:30 2023 -0500
Commit: Noel Grandin 
CommitDate: Wed Jan 4 18:49:55 2023 +

tdf#152703 Force relayout during live resizing of window

During a live resize, macOS floods the application with windowDidResize:
notifications so sending a paint event does not trigger redrawing with
the new size. Instead, force relayout by dispatching all pending internal
events and firing any pending timers.

Also, force a repaint of the window after live resizing ends by reposting
this notification so that [self windowDidResize:] will be called at least
once after live resizing ends.

Change-Id: I9d93108c989418bab6d80c7f6afaccc1daaa746e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145042
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/vcl/inc/osx/salframeview.h b/vcl/inc/osx/salframeview.h
index 2fcff0d1c1e5..7ec995b26c18 100644
--- a/vcl/inc/osx/salframeview.h
+++ b/vcl/inc/osx/salframeview.h
@@ -28,6 +28,7 @@ enum class SalEvent;
 {
 AquaSalFrame*   mpFrame;
 id mDraggingDestinationHandler;
+BOOLmbInLiveResize;
 }
 -(id)initWithSalFrame: (AquaSalFrame*)pFrame;
 -(BOOL)canBecomeKeyWindow;
diff --git a/vcl/osx/salframeview.mm b/vcl/osx/salframeview.mm
index 5a28f647c451..61061253a2da 100644
--- a/vcl/osx/salframeview.mm
+++ b/vcl/osx/salframeview.mm
@@ -169,6 +169,7 @@ static AquaSalFrame* getMouseContainerFrame()
 -(id)initWithSalFrame: (AquaSalFrame*)pFrame
 {
 mDraggingDestinationHandler = nil;
+mbInLiveResize = NO;
 mpFrame = pFrame;
 NSRect aRect = { { static_cast(pFrame->maGeometry.x()), 
static_cast(pFrame->maGeometry.y()) },
  { static_cast(pFrame->maGeometry.width()), 
static_cast(pFrame->maGeometry.height()) } };
@@ -226,6 +227,7 @@ static AquaSalFrame* getMouseContainerFrame()
 // explicitly flush the Skia graphics to the window during live
 // resizing or else nothing will be drawn until after live resizing
 // has ended.
+// TODO: See if flickering when flushing can be eliminated somehow.
 if ( [self inLiveResize] && SkiaHelper::isVCLSkiaEnabled() && mpFrame 
&& AquaSalFrame::isAlive( mpFrame ) )
 {
 AquaSalGraphics* pGraphics = mpFrame->mpGraphics;
@@ -337,16 +339,35 @@ static AquaSalFrame* getMouseContainerFrame()
 mpFrame->UpdateFrameGeometry();
 mpFrame->CallCallback( SalEvent::Resize, nullptr );
 
-// Related: tdf#152703 Stop flicker with Skia/Metal while resizing
-// When Skia/Metal is enabled, rapidly resizing a window has a
-// noticeable amount of flicker so don't send any paint events during
-// live resizing.
-// Also, it appears that most of the LibreOffice layouts do not change
-// their layout much during live resizing so apply this change when
-// Skia is not enabled to ensure consistent behavior whether Skia is
-// enabled or not.
-if ( ![self inLiveResize] )
+if ( [self inLiveResize] )
+{
+mbInLiveResize = YES;
+
+// tdf#152703 Force relayout during live resizing of window
+// During a live resize, macOS floods the application with
+// windowDidResize: notifications so sending a paint event does
+// not trigger redrawing with the new size.
+// Instead, force relayout by dispatching all pending internal
+// events and firing any pending timers.
+Application::Reschedule( true );
+
+// tdf#152703 Force repaint after live resizing ends
+// Repost this notification so that this selector will be called
+// at least once after live resizing ends. Pass nil for withObject:
+// since it is unused and makes it easier to cancel all pending
+// selector execution when live resizing ends.
+[self performSelector:@selector(windowDidResize:) withObject:nil 
afterDelay:0.1f];
+}
+else
+{
+if ( mbInLiveResize )
+{
+mbInLiveResize = NO;
+[NSObject cancelPreviousPerformRequestsWithTarget:self 
selector:@selector(windowDidResize:) object:nil];
+}
+
 mpFrame->SendPaintEvent();
+}
 }
 }
 


Regarding GSoC Idea: Improving Zoner Draw import filter

2023-01-04 Thread Siddharth Khattar
Hello,

I had recently been checking out the GSOC 2022 Ideas list at:
https://wiki.documentfoundation.org/Development/GSoC/Ideas (as there isn't
a list yet for 2023), and one idea, in particular, caught my attention:
Improve Zoner Draw import filter.
As I researched the idea further, I found out that it had been implemented
the libzmf library for LibreOffice as a GSOC 2016 project and I would need
to build further on top of this project.
Are there any foreseeable roadblocks or challenges to the execution of this
idea?
In which area should I start focusing my research in to start working on
the document to successfully implement this idea as part of GSoC 2023?
I have already sent e-mails asking for help/tips regarding this particular
idea to David Tardon at dtar...@redhat.com (who is listed as a potential
mentor) and Alex P at alex.pan...@gmail.com (who did the initial
implementation for libzmf library). I haven't received a reply from either
yet though so just in case are there other mentors available at LibreOffice
who could help me accomplish this task?
Also, Is anyone else currently aiming to implement this idea at LibreOffice
or in the LibreOffice open-source community?
Lastly, are there any other tips or thoughts regarding this that you would
like to give me?

Thanking for your time and consideration,
Siddharth K


[Libreoffice-bugs] [Bug 152868] In Calc, a cell with a function returns a string to the active cell, but the string can not yet be pushed into a Designated Cell by a standard function. [1] Status "NEW

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152868

Bruce McCoy  changed:

   What|Removed |Added

  Alias||String2Push

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151210] 7-4-2-1 calc commas in decimal numbers are not converted to decimal-point, German surround

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151210

Eike Rathke  changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151210] 7-4-2-1 calc commas in decimal numbers are not converted to decimal-point, German surround

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151210

Eike Rathke  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #8 from Eike Rathke  ---


*** This bug has been marked as a duplicate of bug 151886 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - vcl/source

2023-01-04 Thread Szymon Kłos (via logerrit)
 vcl/source/treelist/svtabbx.cxx |   13 ++---
 1 file changed, 10 insertions(+), 3 deletions(-)

New commits:
commit 0ae6d51e720ea66ef6efb52d0d96f8a5fb60b595
Author: Szymon Kłos 
AuthorDate: Wed Jan 4 15:28:34 2023 +0100
Commit: Szymon Kłos 
CommitDate: Wed Jan 4 18:31:13 2023 +

jsdialog: don't export collapsed/expanded icons when empty

Change-Id: Iec56c11fdba066f9b62b2d5d56ad011a821e4087
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145040
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Szymon Kłos 

diff --git a/vcl/source/treelist/svtabbx.cxx b/vcl/source/treelist/svtabbx.cxx
index 9d989eb8382d..ccc5c1cd2491 100644
--- a/vcl/source/treelist/svtabbx.cxx
+++ b/vcl/source/treelist/svtabbx.cxx
@@ -75,9 +75,16 @@ static void lcl_DumpEntryAndSiblings(tools::JsonWriter& 
rJsonWriter,
 const SvLBoxContextBmp* pBmpItem = dynamic_cast();
 if (pBmpItem)
 {
-auto aColumn = rJsonWriter.startStruct();
-rJsonWriter.put("collapsed", 
pBmpItem->GetBitmap1().GetStock());
-rJsonWriter.put("expanded", 
pBmpItem->GetBitmap2().GetStock());
+const OUString& rCollapsed = 
pBmpItem->GetBitmap1().GetStock();
+const OUString& rExpanded = 
pBmpItem->GetBitmap2().GetStock();
+if (!rCollapsed.trim().isEmpty() || 
!rExpanded.trim().isEmpty())
+{
+auto aColumn = rJsonWriter.startStruct();
+if (!rCollapsed.trim().isEmpty())
+rJsonWriter.put("collapsed", rCollapsed);
+if (!rExpanded.trim().isEmpty())
+rJsonWriter.put("expanded", rExpanded);
+}
 }
 }
 }


[Libreoffice-bugs] [Bug 152884] New: FILEOPEN DOCX character transparency is not set in case of theme colors

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152884

Bug ID: 152884
   Summary: FILEOPEN DOCX character transparency is not set in
case of theme colors
   Product: LibreOffice
   Version: 7.6.0.0 alpha0+ Master
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rb.hensc...@t-online.de

Created attachment 184487
  --> https://bugs.documentfoundation.org/attachment.cgi?id=184487=edit
Example characters with transparency

Open attached document. It contains three characters, left is original, middle
has 74% and right has 29% transparency. The rounded rectangles have the same
color and transparency so you can see how it should look. The upper ABC row
uses a theme color, the lower ABC row uses a direct color.

Error: The transparency is not imported in case of theme color.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 122394] changing named ranges content via vba macro will not update cell formula

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122394

--- Comment #7 from Oliver Brinzing  ---
reproducible with

Version: 7.4.2.3 (x64) / LibreOffice Community
Build ID: 382eef1f22670f7f4118c8c2dd222ec7ad009daf
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: default

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - sw/qa sw/source

2023-01-04 Thread Andras Timar (via logerrit)
 sw/qa/extras/htmlimport/data/green-highlight.html |1 
 sw/qa/extras/htmlimport/htmlimport.cxx|   12 ++
 sw/source/filter/html/parcss1.cxx |   26 +++---
 3 files changed, 36 insertions(+), 3 deletions(-)

New commits:
commit 81c6e01e5ba9d46963ae3323804ab8379b864cc3
Author: Andras Timar 
AuthorDate: Wed Jan 4 14:34:49 2023 +0100
Commit: Andras Timar 
CommitDate: Wed Jan 4 18:17:54 2023 +

import colors with transparency from html

The support is limited, but better than before.
Before: the color was not imported.
After: the color is imported as RGB, as if the background color was white.
It is pretty much common in Writer that the background is white. On the
other hand, transparency is not supported in many use cases, such as
character background in this example green-highlight.html.

Change-Id: Ia9449e2535ddfd8cd8c2672cb3bd32987083fdbb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145041
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Andras Timar 

diff --git a/sw/qa/extras/htmlimport/data/green-highlight.html 
b/sw/qa/extras/htmlimport/data/green-highlight.html
new file mode 100644
index ..b8986e78ffd8
--- /dev/null
+++ b/sw/qa/extras/htmlimport/data/green-highlight.html
@@ -0,0 +1 @@
+Highlight green (transparency: 
0.5)
diff --git a/sw/qa/extras/htmlimport/htmlimport.cxx 
b/sw/qa/extras/htmlimport/htmlimport.cxx
index 00e2ec99191f..e4547d02a008 100644
--- a/sw/qa/extras/htmlimport/htmlimport.cxx
+++ b/sw/qa/extras/htmlimport/htmlimport.cxx
@@ -536,6 +536,18 @@ CPPUNIT_TEST_FIXTURE(HtmlImportTest, testUTF16_nonBMP)
  getParagraph(1)->getString());
 }
 
+CPPUNIT_TEST_FIXTURE(HtmlImportTest, testRGBAColor)
+{
+load(mpTestDocumentPath, "green-highlight.html");
+const uno::Reference xPara = getParagraph(1);
+const uno::Reference xRun(getRun(xPara,1), 
uno::UNO_QUERY);
+const Color nBackColor(0xaed89a);
+
+// Without the accompanying fix in place, this test would have failed, the 
backround
+// color was not imported at all, when it was in hex RGBA format in HTML.
+CPPUNIT_ASSERT_EQUAL(nBackColor, getProperty(xRun, 
"CharBackColor"));
+}
+
 CPPUNIT_PLUGIN_IMPLEMENT();
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/filter/html/parcss1.cxx 
b/sw/source/filter/html/parcss1.cxx
index e0b20ef4168e..518604bc1bc5 100644
--- a/sw/source/filter/html/parcss1.cxx
+++ b/sw/source/filter/html/parcss1.cxx
@@ -529,11 +529,11 @@ CSS1Token CSS1Parser::GetNextToken()
 bool bEOFSave = m_bEOF;
 
 // first try to parse a hex digit
-OUStringBuffer sTmpBuffer(6);
+OUStringBuffer sTmpBuffer(8);
 do {
 sTmpBuffer.append( m_cNextCh );
 m_cNextCh = GetNextChar();
-} while( sTmpBuffer.getLength() < 7 &&
+} while( sTmpBuffer.getLength() < 9 &&
  ( ('0'<=m_cNextCh && '9'>=m_cNextCh) ||
('A'<=m_cNextCh && 'F'>=m_cNextCh) ||
('a'<=m_cNextCh && 'f'>=m_cNextCh) ) &&
@@ -541,7 +541,7 @@ CSS1Token CSS1Parser::GetNextToken()
 
 if( sTmpBuffer.getLength()==6 || sTmpBuffer.getLength()==3 )
 {
-// we found a color in hex
+// we found a color in hex (RGB)
 m_aToken += sTmpBuffer;
 nRet = CSS1_HEXCOLOR;
 bNextCh = false;
@@ -549,6 +549,26 @@ CSS1Token CSS1Parser::GetNextToken()
 break;
 }
 
+if( sTmpBuffer.getLength()==8 )
+{
+// we found a color in hex (RGBA)
+// we convert it to RGB assuming white background
+sal_uInt32 nColor = 
sTmpBuffer.makeStringAndClear().toUInt32(16);
+sal_uInt32 nRed = (nColor & 0xff00) >> 24;
+sal_uInt32 nGreen = (nColor & 0xff) >> 16;
+sal_uInt32 nBlue = (nColor & 0xff00) >> 8;
+double nAlpha = (nColor & 0xff) / 255.0;
+nRed = (1 - nAlpha) * 255 + nAlpha * nRed;
+nGreen = (1 - nAlpha) * 255 + nAlpha * nGreen;
+nBlue = (1 - nAlpha) * 255 + nAlpha * nBlue;
+nColor = (nRed << 16) + (nGreen << 8) + nBlue;
+m_aToken += OUString::number(nColor, 16);
+nRet = CSS1_HEXCOLOR;
+bNextCh = false;
+
+break;
+}
+
 // otherwise we try a number
 m_nInPos = nInPosSave;
 m_cNextCh = cNextChSave;


[Libreoffice-ux-advise] [Bug 138786] PS formatting gets lost, if you paste text into an new document with same name of PS, but different settings (see comment 5)

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=138786

--- Comment #8 from Mike Kaganski  ---
(In reply to Heiko Tietze from comment #6)
> We can
> a) silently apply the target style (current situation)
> b) silently copy/rename of source style ("Caption_1", for example)
> c) show a dialog to resolve the conflict 

(In reply to Dieter from comment #7)
> So in the case you paste text from another document I would at least expect
> a message like: "You paste content from another document. Copied style
> formatting will be overwritten by styles with the same name." OK | Cancel |
> Don't show message again (Of course you can use a better English)

There are three actual cases usability-wise:

1. The user pastes as plain text - i.e., the current Ctrl+Alt+Shift+V behavior;
2. The user would want the pasted rich text to follow the styling of target
document (i.e., the same-name styles get the meaning they have in the target
document; absent styles are added; direct formatting is applied as in the
source) - i.e., the current Ctrl+V behavior;
3. The user wants the pasted text to look as it looked in the source. This is
what this issue is about.

The #3 indeed must *not* be implemented by modifying the existing styles
(because that would re-format existing text); and I would tell that renaming
styles would also be poor, because it would proliferate automatically generated
styles - consider a document, into which you copy some text from other source
many times - will it generate new style_1, style_2, ... style_N each time?

The reasonable implementation of "keep source formatting" paste option would be
to use the target styles, *but* additionally apply direct formatting atop, to
override any formatting in the target document which does not match what was in
the source. The "I want the text to look the same as in the source" case is a
clear sign of unstructured approach (at least locally), and DF is IMO
absolutely fine.

And IMO, some improvement of the paste process would be nice. A dialog is a
no-go; but we already have a drop-down paste toolbar button; and we could try
to implement more convenience tools - see e.g. how MS Word does that, by
displaying a floating toolbar on paste, with buttons allowing to change the
formatting of the pasted text *retroactively*. I don't suggest to copy that
approach, but I suppose that some improvement is possible without intrusive
(blocking) UI (which is a dialog).

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 138786] PS formatting gets lost, if you paste text into an new document with same name of PS, but different settings (see comment 5)

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=138786

--- Comment #8 from Mike Kaganski  ---
(In reply to Heiko Tietze from comment #6)
> We can
> a) silently apply the target style (current situation)
> b) silently copy/rename of source style ("Caption_1", for example)
> c) show a dialog to resolve the conflict 

(In reply to Dieter from comment #7)
> So in the case you paste text from another document I would at least expect
> a message like: "You paste content from another document. Copied style
> formatting will be overwritten by styles with the same name." OK | Cancel |
> Don't show message again (Of course you can use a better English)

There are three actual cases usability-wise:

1. The user pastes as plain text - i.e., the current Ctrl+Alt+Shift+V behavior;
2. The user would want the pasted rich text to follow the styling of target
document (i.e., the same-name styles get the meaning they have in the target
document; absent styles are added; direct formatting is applied as in the
source) - i.e., the current Ctrl+V behavior;
3. The user wants the pasted text to look as it looked in the source. This is
what this issue is about.

The #3 indeed must *not* be implemented by modifying the existing styles
(because that would re-format existing text); and I would tell that renaming
styles would also be poor, because it would proliferate automatically generated
styles - consider a document, into which you copy some text from other source
many times - will it generate new style_1, style_2, ... style_N each time?

The reasonable implementation of "keep source formatting" paste option would be
to use the target styles, *but* additionally apply direct formatting atop, to
override any formatting in the target document which does not match what was in
the source. The "I want the text to look the same as in the source" case is a
clear sign of unstructured approach (at least locally), and DF is IMO
absolutely fine.

And IMO, some improvement of the paste process would be nice. A dialog is a
no-go; but we already have a drop-down paste toolbar button; and we could try
to implement more convenience tools - see e.g. how MS Word does that, by
displaying a floating toolbar on paste, with buttons allowing to change the
formatting of the pasted text *retroactively*. I don't suggest to copy that
approach, but I suppose that some improvement is possible without intrusive
(blocking) UI (which is a dialog).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: vcl/unx

2023-01-04 Thread Caolán McNamara (via logerrit)
 vcl/unx/generic/gdi/X11CairoSalGraphicsImpl.cxx |  106 +++-
 1 file changed, 49 insertions(+), 57 deletions(-)

New commits:
commit 5cc0b3adf6c1550105b2137dd182168a9231bd7a
Author: Caolán McNamara 
AuthorDate: Mon Jan 2 20:43:36 2023 +
Commit: Caolán McNamara 
CommitDate: Wed Jan 4 17:10:56 2023 +

enable SAL_ENABLE_USE_CAIRO_FOR_POLYGONS path

Change-Id: Id2c8f94986aea0dd7e50b7b3aeaae7770b3e5bbd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144970
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/vcl/unx/generic/gdi/X11CairoSalGraphicsImpl.cxx 
b/vcl/unx/generic/gdi/X11CairoSalGraphicsImpl.cxx
index 9f2fcb988697..0a1e8fe02200 100644
--- a/vcl/unx/generic/gdi/X11CairoSalGraphicsImpl.cxx
+++ b/vcl/unx/generic/gdi/X11CairoSalGraphicsImpl.cxx
@@ -55,84 +55,76 @@ bool X11CairoSalGraphicsImpl::drawPolyPolygon(const 
basegfx::B2DHomMatrix& rObje
 return true;
 }
 
-// enable by setting to something
-static const char* 
pUseCairoForPolygons(getenv("SAL_ENABLE_USE_CAIRO_FOR_POLYGONS"));
+// snap to raster if requested
+const bool bSnapPoints(!getAntiAlias());
 
-if (nullptr != pUseCairoForPolygons && mrX11Common.SupportsCairo())
+if (bSnapPoints)
 {
-// snap to raster if requested
-const bool bSnapPoints(!getAntiAlias());
+aPolyPolygon = 
basegfx::utils::snapPointsOfHorizontalOrVerticalEdges(aPolyPolygon);
+}
 
-if (bSnapPoints)
-{
-aPolyPolygon = 
basegfx::utils::snapPointsOfHorizontalOrVerticalEdges(aPolyPolygon);
-}
+cairo_t* cr = mrX11Common.getCairoContext();
+clipRegion(cr);
 
-cairo_t* cr = mrX11Common.getCairoContext();
-clipRegion(cr);
+for (auto const& rPolygon : std::as_const(aPolyPolygon))
+{
+const sal_uInt32 nPointCount(rPolygon.count());
 
-for (auto const& rPolygon : std::as_const(aPolyPolygon))
+if (nPointCount)
 {
-const sal_uInt32 nPointCount(rPolygon.count());
+const sal_uInt32 nEdgeCount(rPolygon.isClosed() ? nPointCount : 
nPointCount - 1);
 
-if (nPointCount)
+if (nEdgeCount)
 {
-const sal_uInt32 nEdgeCount(rPolygon.isClosed() ? nPointCount 
: nPointCount - 1);
+basegfx::B2DCubicBezier aEdge;
 
-if (nEdgeCount)
+for (sal_uInt32 b = 0; b < nEdgeCount; ++b)
 {
-basegfx::B2DCubicBezier aEdge;
+rPolygon.getBezierSegment(b, aEdge);
 
-for (sal_uInt32 b = 0; b < nEdgeCount; ++b)
+if (!b)
 {
-rPolygon.getBezierSegment(b, aEdge);
-
-if (!b)
-{
-const basegfx::B2DPoint 
aStart(aEdge.getStartPoint());
-cairo_move_to(cr, aStart.getX(), aStart.getY());
-}
-
-const basegfx::B2DPoint aEnd(aEdge.getEndPoint());
-
-if (aEdge.isBezier())
-{
-const basegfx::B2DPoint 
aCP1(aEdge.getControlPointA());
-const basegfx::B2DPoint 
aCP2(aEdge.getControlPointB());
-cairo_curve_to(cr, aCP1.getX(), aCP1.getY(), 
aCP2.getX(), aCP2.getY(),
-   aEnd.getX(), aEnd.getY());
-}
-else
-{
-cairo_line_to(cr, aEnd.getX(), aEnd.getY());
-}
+const basegfx::B2DPoint aStart(aEdge.getStartPoint());
+cairo_move_to(cr, aStart.getX(), aStart.getY());
 }
 
-cairo_close_path(cr);
+const basegfx::B2DPoint aEnd(aEdge.getEndPoint());
+
+if (aEdge.isBezier())
+{
+const basegfx::B2DPoint aCP1(aEdge.getControlPointA());
+const basegfx::B2DPoint aCP2(aEdge.getControlPointB());
+cairo_curve_to(cr, aCP1.getX(), aCP1.getY(), 
aCP2.getX(), aCP2.getY(),
+   aEnd.getX(), aEnd.getY());
+}
+else
+{
+cairo_line_to(cr, aEnd.getX(), aEnd.getY());
+}
 }
-}
-}
 
-if (SALCOLOR_NONE != mnFillColor)
-{
-cairo_set_source_rgba(cr, mnFillColor.GetRed() / 255.0, 
mnFillColor.GetGreen() / 255.0,
-  mnFillColor.GetBlue() / 255.0, 1.0 - 
fTransparency);
-cairo_set_fill_rule(cr, CAIRO_FILL_RULE_EVEN_ODD);
-cairo_fill_preserve(cr);
+

[Libreoffice-bugs] [Bug 152883] New: New Shape Request (Several, Based on Existing Shapes)

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152883

Bug ID: 152883
   Summary: New Shape Request (Several, Based on Existing Shapes)
   Product: LibreOffice
   Version: 7.3.7.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Draw
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: brianjheis...@gmail.com

Description:
As a consequence of bug 132050, flipping shapes horizontally/vertically is
broken, resulting in several shapes being unusable in many circumstances (where
their flipped dimension is stored as an odd integer). It seems that there is no
way to fix this bug so, to work around it, I'm requesting that several new
shapes be created, providing mirrored versions of asymmetrical shapes. *Some*
flipped shapes are already present (e.g. 'Right Arrow Callout', 'Left Arrow
Callout', etc.). *Some* examples of needed shapes are the horizontally and/or
vertically mirrored version(s) of 'Cylinder', 'Cube', 'Lightning Bolt',
'Circular Arrow', 'S-Shaped Arrow', 'Corner Right Arrow', 'Striped Right
Arrow', 'Notched Right Arrow', 'Up and Right Arrow', 'Chevron', 'Pentagon', 'Up
and Right Arrow Callout', etc.

Actual Results:
New feature request.

Expected Results:
New feature request.


Reproducible: Always


User Profile Reset: Yes

Additional Info:
Thank you.

Version: 7.3.7.2 (x64) / LibreOffice Community
Build ID: e114eadc50a9ff8d8c8a0567d6da8f454beeb84f
CPU threads: 8; OS: Windows 6.1 Service Pack 1 Build 7601; UI render:
Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152882] New: Draw freezes after copying object into clipboard

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152882

Bug ID: 152882
   Summary: Draw freezes after copying object into clipboard
   Product: LibreOffice
   Version: 7.4.3.2 release
  Hardware: ARM
OS: macOS (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Draw
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: monochro...@gmail.com

Description:
Copying an object from one document to another causes Draw to lock up.

Steps to Reproduce:
1. Open Draw document and select an object
2. Changing windows, place cursor to insert copied object
3. Draw lock up / freezes

Actual Results:
Unusable application

Expected Results:
Ability to insert object


Reproducible: Always


User Profile Reset: No

Additional Info:
Crash report at
https://gist.github.com/monochromec/624fe89462aa2663641bc8c0562217b4

OS is Ventura (OSX 1.1) running on Apple Silicon

Please let me know if more info is required.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152881] New: Crash when installing new font on windows

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152881

Bug ID: 152881
   Summary: Crash when installing new font on windows
   Product: LibreOffice
   Version: 7.4.3.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ja...@appmeas.co.uk

Description:
Libreoffice Crashes if a new font is installed while libreoffice is open.
Windows 10 x64

Steps to Reproduce:
1. On a windows 10 x64 PC, Open any Libreoffice application
2. Open a new font (.ttf or .otf)
3. Click install on the font viewer

Actual Results:
Libreoffice Crashes

Expected Results:
Crash should not occure (I would expect to close and re-open libreoffice to
show the newly installed fonts)


Reproducible: Always


User Profile Reset: Yes

Additional Info:
Version: 7.4.3.2 (x64) / LibreOffice Community
Build ID: 1048a8393ae2eeec98dff31b5c133c5f1d08b890
CPU threads: 12; OS: Windows 10.0 Build 19045; UI render: Skia/Vulkan; VCL: win
Locale: en-GB (en_GB); UI: en-GB
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.

  1   2   3   >