[Libreoffice-bugs] [Bug 153003] Copying a query and pasting as table in same database impossible

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=153003

Robert Großkopf  changed:

   What|Removed |Added

   Keywords||regression

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153003] New: Copying a query and pasting as table in same database impossible

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=153003

Bug ID: 153003
   Summary: Copying a query and pasting as table in same database
impossible
   Product: LibreOffice
   Version: 7.4.4.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Base
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rob...@familiegrosskopf.de

Created attachment 184626
  --> https://bugs.documentfoundation.org/attachment.cgi?id=184626=edit
Database for testing: Copy the query and try to insert as new table - error and
no content copied

Open the attached database file.
Switch to Queries, right mouse click on qry_Name → Copy
Switch to Tables, right mouse click under tbl_Name (hint: If tbl_Name has been
marked you would run in a already posted bug of the wizard)
There will appear a dialog "Copy table".
Table name is "qry_Name". Change it to "qry_Name1"
Options → Definitions and data is chosen.
Type 'Next' and take all existing columns from left to right.
Type 'Next and right mouse click on "ID". Chose "Primary key".
Type 'Create'.

An Error will appear. Type 'More' and the error details will give:

SQL Status: 07009
Internal error: invalid column type index. at
/home/buildslave/source/libo-core/connectivity/source/commontools/dbexception.cxx:462

Type 'OK' and try to continue ('Yes').
You have to type it two times (for every row of the query).

Table has been created without any content.
There is something going wrong with content of the columns of the query while
trying to insert. You could see this when trying to insert the content in
"tbl_Auto".
Copy query → Tables  → mark tbl_Auto → right mouse click Insert
Option "append data" will be chosen → 'Next' → deselect "ID" in source Table
'continue' and the content will be pasted. But if you open the table tbl_Auto
the content form field "ID" will have been pasted to the field "Name".

This bug appears in LO 7.4.4.2, doesn't appear in LO 7.1.5.2 on OpenSUSE 15.3
64bit rpm Linux. So it's a regression.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: compilerplugins/clang cppuhelper/source

[Stephan Bergmann (via logerrit)]

 compilerplugins/clang/mergeclasses.results |1 
 cppuhelper/source/factory.cxx  |  327 +++--
 2 files changed, 127 insertions(+), 201 deletions(-)

New commits:
commit e001703df46d601a9ba21512a259c1caf266edac
Author: Stephan Bergmann 
AuthorDate: Thu Jan 12 22:39:58 2023 +0100
Commit: Stephan Bergmann 
CommitDate: Fri Jan 13 07:50:57 2023 +

Merge OSingleFactoryHelper into OFactoryComponentHelper

Change-Id: I7faf7a3ad54c80bd3c53525c92c26c0f980110f9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145423
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/compilerplugins/clang/mergeclasses.results 
b/compilerplugins/clang/mergeclasses.results
index 1682b3ea21bf..7b002c436974 100644
--- a/compilerplugins/clang/mergeclasses.results
+++ b/compilerplugins/clang/mergeclasses.results
@@ -289,7 +289,6 @@ merge cppcanvas::PolyPolygon with 
cppcanvas::internal::ImplPolyPolygon
 merge cppcanvas::Renderer with cppcanvas::internal::ImplRenderer
 merge cppcanvas::SpriteCanvas with cppcanvas::internal::ImplSpriteCanvas
 merge cppcanvas::internal::ImplSprite with 
cppcanvas::internal::ImplCustomSprite
-merge cppu::(anonymous namespace)::OSingleFactoryHelper with cppu::(anonymous 
namespace)::OFactoryComponentHelper
 merge cppu::PropertySetMixinImpl with cppu::PropertySetMixin
 merge dbaccess::IPropertyContainer with dbaccess::OColumn
 merge dbaccess::IRefreshListener with dbaccess::OConnection
diff --git a/cppuhelper/source/factory.cxx b/cppuhelper/source/factory.cxx
index 37ac44ffa1a5..6d5cdc7b23bc 100644
--- a/cppuhelper/source/factory.cxx
+++ b/cppuhelper/source/factory.cxx
@@ -58,192 +58,6 @@ namespace cppu
 
 namespace {
 
-class OSingleFactoryHelper
-: public XServiceInfo
-, public XSingleServiceFactory
-, public lang::XSingleComponentFactory
-, public XUnloadingPreference
-{
-public:
-OSingleFactoryHelper(
-const Reference & rServiceManager,
-OUString aImplementationName_,
-ComponentInstantiation pCreateFunction_,
-ComponentFactoryFunc fptr,
-const Sequence< OUString > * pServiceNames_ )
-: xSMgr( rServiceManager )
-, pCreateFunction( pCreateFunction_ )
-, m_fptr( fptr )
-, aImplementationName(std::move( aImplementationName_ ))
-{
-if( pServiceNames_ )
-aServiceNames = *pServiceNames_;
-}
-
-virtual ~OSingleFactoryHelper();
-
-// XInterface
-Any SAL_CALL queryInterface( const Type & rType ) override;
-
-// XSingleServiceFactory
-Reference SAL_CALL createInstance() override;
-virtual Reference SAL_CALL createInstanceWithArguments(const 
Sequence& Arguments) override;
-// XSingleComponentFactory
-virtual Reference< XInterface > SAL_CALL createInstanceWithContext(
-Reference< XComponentContext > const & xContext ) override;
-virtual Reference< XInterface > SAL_CALL 
createInstanceWithArgumentsAndContext(
-Sequence< Any > const & rArguments,
-Reference< XComponentContext > const & xContext ) override;
-
-// XServiceInfo
-OUString SAL_CALL getImplementationName() override;
-sal_Bool SAL_CALL supportsService(const OUString& ServiceName) override;
-Sequence< OUString > SAL_CALL getSupportedServiceNames() override;
-
-protected:
-/**
- * Create an instance specified by the factory. The one instance logic is 
implemented
- * in the createInstance and createInstanceWithArguments methods.
- * @return the newly created instance. Do not return a previous (one 
instance) instance.
- * @throw css::uno::Exception
- * @throw css::uno::RuntimeException
- */
-virtual Reference  createInstanceEveryTime(
-Reference< XComponentContext > const & xContext );
-
-Reference xSMgr;
-ComponentInstantiation   pCreateFunction;
-ComponentFactoryFunc m_fptr;
-Sequence< OUString > aServiceNames;
-OUString aImplementationName;
-
-private:
-css::uno::Reference 
createInstanceWithArgumentsEveryTime(
-css::uno::Sequence const & rArguments,
-css::uno::Reference const & xContext);
-};
-
-}
-
-OSingleFactoryHelper::~OSingleFactoryHelper()
-{
-}
-
-
-Any OSingleFactoryHelper::queryInterface( const Type & rType )
-{
-return ::cppu::queryInterface(
-rType,
-static_cast< XSingleComponentFactory * >( this ),
-static_cast< XSingleServiceFactory * >( this ),
-static_cast< XServiceInfo * >( this ) ,
-static_cast< XUnloadingPreference * >( this ));
-}
-
-// OSingleFactoryHelper
-Reference OSingleFactoryHelper::createInstanceEveryTime(
-Reference< XComponentContext > const & xContext )
-{
-if (m_fptr)
-{
-return (*m_fptr)( xContext );
-}
-if( pCreateFunction )
-{
-if (xContext.is())
-{
-Reference< lang::XMultiServiceFactory > 

[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - sw/qa sw/source

[Miklos Vajna (via logerrit)]

 sw/qa/filter/html/html.cxx |   36 ++-
 sw/source/filter/html/htmltabw.cxx |   49 +++--
 2 files changed, 77 insertions(+), 8 deletions(-)

New commits:
commit ddf4ff31f075e00ca4cbb623b596eabf62ab4758
Author: Miklos Vajna 
AuthorDate: Thu Jan 12 13:57:16 2023 +0100
Commit: Xisco Fauli 
CommitDate: Fri Jan 13 07:36:45 2023 +

sw HTML export: fix invalid HTML when all cells of a row have the same 
rowspan

The bugdoc has a table with 2 columns and 2 rows, but both the A1 and
the A2 cell has rowspan=2, so there are only covered cells in the second
row. It seems there is no valid HTML markup to express this Writer doc
model.

What HTML seems to suggest instead is to simply decrease the amount of
rowspan attribute values and then the empty  elements can be simply
skipped.

This fixes the

Row 2 of a row group established by a tbody element has no cells 
beginning on it.

from the w3c HTML validator.

Note that you can't create such problematic tables on the UI: the UI
will delete the row only containing covered cells for you when the last
cell gets merged. Such documents can be created by importers, though.

Change-Id: Ice4fa3636e8b780d374f3d319b198da9f5e0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145402
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins
(cherry picked from commit a2fb3a135425bbc14375e1edfcc1e09a41d760f9)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145434
Reviewed-by: Xisco Fauli 

diff --git a/sw/qa/filter/html/html.cxx b/sw/qa/filter/html/html.cxx
index 4ec815da0c56..537b437c4bdb 100644
--- a/sw/qa/filter/html/html.cxx
+++ b/sw/qa/filter/html/html.cxx
@@ -8,6 +8,7 @@
  */
 
 #include 
+#include 
 
 #include 
 
@@ -30,7 +31,7 @@ namespace
  * Keep using the various sw_import/export suites for multiple filter 
calls inside a single
  * test.
  */
-class Test : public SwModelTestBase
+class Test : public SwModelTestBase, public HtmlTestTools
 {
 public:
 Test()
@@ -162,6 +163,39 @@ CPPUNIT_TEST_FIXTURE(Test, testTableCellFloatValueType)
 assertXPathNoAttribute(pXmlDoc, "//reqif-xhtml:td", "sdval");
 assertXPathNoAttribute(pXmlDoc, "//reqif-xhtml:td", "sdnum");
 }
+
+CPPUNIT_TEST_FIXTURE(Test, testTableRowSpanInAllCells)
+{
+// Given a document with a 2x2 table, A1:A2 and B1:B2 is merged:
+createSwDoc();
+SwDoc* pDoc = getSwDoc();
+SwWrtShell* pWrtShell = pDoc->GetDocShell()->GetWrtShell();
+SwInsertTableOptions aTableOptions(SwInsertTableFlags::DefaultBorder, 0);
+pWrtShell->InsertTable(aTableOptions, /*nRows=*/2, /*nCols=*/2);
+pWrtShell->MoveTable(GotoPrevTable, fnTableStart);
+SwTableNode* pTableNode = 
pWrtShell->GetCursor()->GetPointNode().FindTableNode();
+SwTable& rTable = pTableNode->GetTable();
+auto pBox = const_cast(rTable.GetTableBox("A1"));
+pBox->setRowSpan(2);
+pBox = const_cast(rTable.GetTableBox("B1"));
+pBox->setRowSpan(2);
+pBox = const_cast(rTable.GetTableBox("A2"));
+pBox->setRowSpan(-1);
+pBox = const_cast(rTable.GetTableBox("B2"));
+pBox->setRowSpan(-1);
+
+// When exporting to HTML:
+save("HTML (StarWriter)");
+
+// Then make sure that the output is simplified to valid HTML, by omitting 
the rowspan attribute
+// & the empty  element:
+htmlDocUniquePtr pHtmlDoc = parseHtml(maTempFile);
+// Without the accompanying fix in place, this test would have failed with:
+// - XPath '//tr[1]/td[1]' unexpected 'rowspan' attribute
+// i.e. a combination of rowspan + empty  was emitted.
+assertXPathNoAttribute(pHtmlDoc, "//tr[1]/td[1]", "rowspan");
+assertXPath(pHtmlDoc, "//tr", 1);
+}
 }
 
 CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/sw/source/filter/html/htmltabw.cxx 
b/sw/source/filter/html/htmltabw.cxx
index 43e9ebf97328..ddb8c8eb5f10 100644
--- a/sw/source/filter/html/htmltabw.cxx
+++ b/sw/source/filter/html/htmltabw.cxx
@@ -63,12 +63,20 @@ class SwHTMLWrtTable : public SwWriteTable
 static void Pixelize( sal_uInt16& rValue );
 void PixelizeBorders();
 
+/// Writes a single table cell.
+///
+/// bCellRowSpan decides if the cell's row span should be written or not.
 void OutTableCell( SwHTMLWriter& rWrt, const SwWriteTableCell *pCell,
-   bool bOutVAlign ) const;
+   bool bOutVAlign,
+   bool bCellRowSpan ) const;
 
+/// Writes a single table row.
+///
+/// rSkipRows decides if the next N rows should be skipped or written.
 void OutTableCells( SwHTMLWriter& rWrt,
 const SwWriteTableCells& rCells,
-const SvxBrushItem *pBrushItem ) const;
+const SvxBrushItem *pBrushItem,
+sal_uInt16& rSkipRows ) const;
 
 virtual bool ShouldExpandSub( const SwTableBox *pBox,
  

[Libreoffice-bugs] [Bug 153002] New: Improve keybinding system of Libreoffice

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=153002

Bug ID: 153002
   Summary: Improve keybinding system of Libreoffice
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: avidseek...@protonmail.com

Description:
Libreoffice binding system is limited and impractical. Let keybinds be detected
on user input rather than having a list of every possible combination.

Despite it's long size, it's still limited too.

For example, can’t bind Alt+/ to "Run command".

Related discussion: https://wiki.documentfoundation.org/ReleaseNotes/7.2#GUI.



Actual Results:
can't bind Alt+/

Expected Results:
bind Alt+/


Reproducible: Always


User Profile Reset: Yes

Additional Info:
Inability to bind is reproducible on all systems.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: download.lst

[Miklos Vajna (via logerrit)]

 download.lst |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 04fd7d0f53faa08c608034707ca4a459a162712d
Author: Miklos Vajna 
AuthorDate: Thu Jan 12 20:12:37 2023 +0100
Commit: Miklos Vajna 
CommitDate: Fri Jan 13 07:14:15 2023 +

Update pdfium to 5522

The internal libpng 1.6 is now dropped, but that doesn't really affect
us.

Change-Id: I777c024c76c17689c20bbe6453467ba5fb22baba
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145417
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/download.lst b/download.lst
index cd75552a37f0..fce2df44bf18 100644
--- a/download.lst
+++ b/download.lst
@@ -429,8 +429,8 @@ PAGEMAKER_TARBALL := libpagemaker-0.0.4.tar.xz
 # three static lines
 # so that git cherry-pick
 # will not run into conflicts
-PDFIUM_SHA256SUM := 
7db59b1e91f2bc0ab4c5e19d1a4f881e6a47dbb0d3b7e980a7358225b12a0f35
-PDFIUM_TARBALL := pdfium-5408.tar.bz2
+PDFIUM_SHA256SUM := 
9fae5f8b3b90a4f7ca663f741e232e1e4c3f098fb7a18b0ad52e74ae172cf16c
+PDFIUM_TARBALL := pdfium-5522.tar.bz2
 # three static lines
 # so that git cherry-pick
 # will not run into conflicts

[Libreoffice-commits] core.git: sw/inc sw/source

[Miklos Vajna (via logerrit)]

 sw/inc/IDocumentMarkAccess.hxx  |2 +-
 sw/source/core/doc/docbm.cxx|6 +-
 sw/source/core/inc/MarkManager.hxx  |2 +-
 sw/source/uibase/shells/textsh1.cxx |2 +-
 sw/source/uibase/uno/loktxdoc.cxx   |2 +-
 5 files changed, 9 insertions(+), 5 deletions(-)

New commits:
commit 04d50fa627faabb9211bd9fa9eb134599fb01982
Author: Miklos Vajna 
AuthorDate: Thu Jan 12 16:57:48 2023 +0100
Commit: Miklos Vajna 
CommitDate: Fri Jan 13 07:13:39 2023 +

sw: rename getBookmarkFor() to getInnerBookmarkFor()

Because otherwise it's quite confusing that we have a For() and an At()
variant as well, and it would be less clear what happens in For() when
there are multiple matches.

Also improve getInnerBookmarkFor() a tiny little, so we process the
first hit only once.

Suggested at

.

Change-Id: If068f93e6934c9fc042760c03aac866fe5b50bd2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145412
Reviewed-by: Justin Luth 
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/sw/inc/IDocumentMarkAccess.hxx b/sw/inc/IDocumentMarkAccess.hxx
index 20f876d16495..f07a6b6e1fe7 100644
--- a/sw/inc/IDocumentMarkAccess.hxx
+++ b/sw/inc/IDocumentMarkAccess.hxx
@@ -314,7 +314,7 @@ class IDocumentMarkAccess
 virtual const_iterator_t findFirstBookmarkStartsAfter(const 
SwPosition& rPos) const =0;
 
 /// Get the innermost bookmark that contains rPos.
-virtual sw::mark::IMark* getBookmarkFor(const SwPosition& rPos) const 
= 0;
+virtual sw::mark::IMark* getInnerBookmarkFor(const SwPosition& rPos) 
const = 0;
 
 // Fieldmarks
 /** returns a STL-like random access iterator to the begin of the 
sequence of fieldmarks.
diff --git a/sw/source/core/doc/docbm.cxx b/sw/source/core/doc/docbm.cxx
index 7152c2a2314a..468b5a2e3b11 100644
--- a/sw/source/core/doc/docbm.cxx
+++ b/sw/source/core/doc/docbm.cxx
@@ -1437,7 +1437,7 @@ namespace sw::mark
 return dynamic_cast(pFieldmark);
 }
 
-IMark* MarkManager::getBookmarkFor(const SwPosition& rPos) const
+IMark* MarkManager::getInnerBookmarkFor(const SwPosition& rPos) const
 {
 auto it = std::find_if(m_vBookmarks.begin(), m_vBookmarks.end(),
[](const sw::mark::MarkBase* pMark)
@@ -1447,6 +1447,10 @@ namespace sw::mark
 return nullptr;
 }
 sw::mark::IMark* pBookmark = *it;
+
+// See if any bookmarks after the first hit are closer to rPos.
+++it;
+
 for (; it != m_vBookmarks.end() && (*it)->GetMarkStart() <= rPos; ++it)
 {
 // Find the innermost bookmark.
diff --git a/sw/source/core/inc/MarkManager.hxx 
b/sw/source/core/inc/MarkManager.hxx
index 156ae055..0b3f6d7df37d 100644
--- a/sw/source/core/inc/MarkManager.hxx
+++ b/sw/source/core/inc/MarkManager.hxx
@@ -88,7 +88,7 @@ namespace sw::mark {
 virtual sal_Int32 getBookmarksCount() const override;
 virtual const_iterator_t findBookmark(const OUString& rName) const 
override;
 virtual const_iterator_t findFirstBookmarkStartsAfter(const 
SwPosition& rPos) const override;
-virtual ::sw::mark::IMark* getBookmarkFor(const SwPosition& rPos) 
const override;
+virtual ::sw::mark::IMark* getInnerBookmarkFor(const SwPosition& 
rPos) const override;
 
 // Fieldmarks
 virtual const_iterator_t getFieldmarksBegin() const override;
diff --git a/sw/source/uibase/shells/textsh1.cxx 
b/sw/source/uibase/shells/textsh1.cxx
index 7e8edb2fc508..bb5acfc9f47d 100644
--- a/sw/source/uibase/shells/textsh1.cxx
+++ b/sw/source/uibase/shells/textsh1.cxx
@@ -569,7 +569,7 @@ void UpdateBookmark(SfxRequest& rReq, SwWrtShell& rWrtSh)
 
 IDocumentMarkAccess& rIDMA = *rWrtSh.GetDoc()->getIDocumentMarkAccess();
 SwPosition& rCursor = *rWrtSh.GetCursor()->GetPoint();
-auto pBookmark = 
dynamic_cast(rIDMA.getBookmarkFor(rCursor));
+auto pBookmark = 
dynamic_cast(rIDMA.getInnerBookmarkFor(rCursor));
 if (!pBookmark || !pBookmark->GetName().startsWith(aBookmarkNamePrefix))
 {
 return;
diff --git a/sw/source/uibase/uno/loktxdoc.cxx 
b/sw/source/uibase/uno/loktxdoc.cxx
index 6742c819c899..875384d1f307 100644
--- a/sw/source/uibase/uno/loktxdoc.cxx
+++ b/sw/source/uibase/uno/loktxdoc.cxx
@@ -250,7 +250,7 @@ void GetBookmark(tools::JsonWriter& rJsonWriter, 
SwDocShell* pDocShell,
 IDocumentMarkAccess& rIDMA = 
*pDocShell->GetDoc()->getIDocumentMarkAccess();
 SwWrtShell* pWrtShell = pDocShell->GetWrtShell();
 SwPosition& rCursor = *pWrtShell->GetCursor()->GetPoint();
-sw::mark::IMark* pBookmark = rIDMA.getBookmarkFor(rCursor);
+sw::mark::IMark* pBookmark = rIDMA.getInnerBookmarkFor(rCursor);
 tools::ScopedJsonWriterNode aBookmark = rJsonWriter.startNode("bookmark");
  

[Libreoffice-commits] core.git: sw/source

[Miklos Vajna (via logerrit)]

 sw/source/uibase/shells/textfld.cxx |   21 -
 1 file changed, 12 insertions(+), 9 deletions(-)

New commits:
commit 60be9811555b935d6860157ebf26fac6b48327ac
Author: Miklos Vajna 
AuthorDate: Thu Jan 12 15:49:03 2023 +0100
Commit: Miklos Vajna 
CommitDate: Fri Jan 13 07:13:24 2023 +

sw, FN_DELETE_TEXT_FORMFIELDS: allow deleting all fieldmarks

As suggested at

,
in case the provided prefix is empty, then don't try to look up
ODF_CODE_PARAM and don't compare it with the provided prefix.

This allows deleting all fieldmarks in the document, which is probably
intended with an empty prefix.

Change-Id: Ic3015925165a9abc13a30889c36c667b10996c4d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145409
Reviewed-by: Justin Luth 
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/sw/source/uibase/shells/textfld.cxx 
b/sw/source/uibase/shells/textfld.cxx
index d4b9e92c5416..77d68cddf3d7 100644
--- a/sw/source/uibase/shells/textfld.cxx
+++ b/sw/source/uibase/shells/textfld.cxx
@@ -962,17 +962,20 @@ FIELD_INSERT:
 continue;
 }
 
-auto itParam = pFieldmark->GetParameters()->find(ODF_CODE_PARAM);
-if (itParam == pFieldmark->GetParameters()->end())
+if (!aFieldCommandPrefix.isEmpty())
 {
-continue;
-}
+auto itParam = 
pFieldmark->GetParameters()->find(ODF_CODE_PARAM);
+if (itParam == pFieldmark->GetParameters()->end())
+{
+continue;
+}
 
-OUString aCommand;
-itParam->second >>= aCommand;
-if (!aCommand.startsWith(aFieldCommandPrefix))
-{
-continue;
+OUString aCommand;
+itParam->second >>= aCommand;
+if (!aCommand.startsWith(aFieldCommandPrefix))
+{
+continue;
+}
 }
 
 aRemovals.push_back(pFieldmark);

[Libreoffice-commits] core.git: sw/qa sw/source

[Miklos Vajna (via logerrit)]

 sw/qa/uibase/uno/uno.cxx  |   35 +
 sw/source/uibase/uno/loktxdoc.cxx |   62 --
 2 files changed, 95 insertions(+), 2 deletions(-)

New commits:
commit 81f690ec0cb2a6dc0d6ca0f6de3adcc07eb7bc12
Author: Miklos Vajna 
AuthorDate: Thu Jan 12 15:13:00 2023 +0100
Commit: Miklos Vajna 
CommitDate: Fri Jan 13 07:13:00 2023 +

sw lok: expose name of refmark under cursor

This is similar to commit 4bcb66ec7b417fbe113267f2615e78fe47eb55ca (sw
lok: expose name of bookmark under cursor, 2023-01-11), but that was for
the bookmark under the cursor and this is for refmarks.

Change-Id: I0acf0181d0acfdc087e1ed737b3c18ab3736031a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145405
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/sw/qa/uibase/uno/uno.cxx b/sw/qa/uibase/uno/uno.cxx
index d2be66457b81..7a1b731634bd 100644
--- a/sw/qa/uibase/uno/uno.cxx
+++ b/sw/qa/uibase/uno/uno.cxx
@@ -475,6 +475,41 @@ CPPUNIT_TEST_FIXTURE(SwUibaseUnoTest, testGetBookmark)
 CPPUNIT_ASSERT_EQUAL(std::string("ZOTERO_BREF_1"), 
aBookmark.get("name"));
 }
 
+CPPUNIT_TEST_FIXTURE(SwUibaseUnoTest, testGetField)
+{
+// Given a document with a refmark:
+createSwDoc();
+uno::Sequence aArgs = {
+comphelper::makePropertyValue("TypeName", 
uno::Any(OUString("SetRef"))),
+comphelper::makePropertyValue("Name",
+  uno::Any(OUString("ZOTERO_ITEM 
CSL_CITATION {} refmark"))),
+comphelper::makePropertyValue("Content", 
uno::Any(OUString("content"))),
+};
+dispatchCommand(mxComponent, ".uno:InsertField", aArgs);
+
+// When in the refmark with the cursor and getting the command value for 
.uno:Field:
+SwDoc* pDoc = getSwDoc();
+SwWrtShell* pWrtShell = pDoc->GetDocShell()->GetWrtShell();
+pWrtShell->SttEndDoc(/*bStt=*/false);
+pWrtShell->Left(SwCursorSkipMode::Chars, /*bSelect=*/false, 1, 
/*bBasicCall=*/false);
+tools::JsonWriter aJsonWriter;
+std::string_view 
aCommand(".uno:Field?typeName=SetRef=ZOTERO_ITEM%20CSL_CITATION");
+auto pXTextDocument = dynamic_cast(mxComponent.get());
+pXTextDocument->getCommandValues(aJsonWriter, aCommand);
+
+// Then make sure we find the inserted refmark:
+std::unique_ptr 
pJSON(aJsonWriter.extractData());
+std::stringstream aStream(pJSON.get());
+boost::property_tree::ptree aTree;
+boost::property_tree::read_json(aStream, aTree);
+boost::property_tree::ptree aBookmark = aTree.get_child("setRef");
+// Without the accompanying fix in place, this test would have failed with:
+// - No such node (setRef)
+// i.e. the returned JSON was an empty object.
+CPPUNIT_ASSERT_EQUAL(std::string("ZOTERO_ITEM CSL_CITATION {} refmark"),
+ aBookmark.get("name"));
+}
+
 CPPUNIT_PLUGIN_IMPLEMENT();
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/uibase/uno/loktxdoc.cxx 
b/sw/source/uibase/uno/loktxdoc.cxx
index 44b72d4f1eae..6742c819c899 100644
--- a/sw/source/uibase/uno/loktxdoc.cxx
+++ b/sw/source/uibase/uno/loktxdoc.cxx
@@ -326,6 +326,58 @@ void GetFields(tools::JsonWriter& rJsonWriter, SwDocShell* 
pDocShell,
 }
 }
 
+/// Implements getCommandValues(".uno:Field").
+///
+/// Parameters:
+///
+/// - typeName: field type condition to not return all fields
+/// - namePrefix: field name prefix to not return all fields
+void GetField(tools::JsonWriter& rJsonWriter, SwDocShell* pDocShell,
+  const std::map& rArguments)
+{
+OUString aTypeName;
+{
+auto it = rArguments.find("typeName");
+if (it != rArguments.end())
+{
+aTypeName = it->second;
+}
+}
+// See SwFieldTypeFromString().
+if (aTypeName != "SetRef")
+{
+return;
+}
+
+OUString aNamePrefix;
+{
+auto it = rArguments.find("namePrefix");
+if (it != rArguments.end())
+{
+aNamePrefix = it->second;
+}
+}
+
+SwWrtShell* pWrtShell = pDocShell->GetWrtShell();
+SwPosition& rCursor = *pWrtShell->GetCursor()->GetPoint();
+SwTextNode* pTextNode = rCursor.GetNode().GetTextNode();
+std::vector aAttrs
+= pTextNode->GetTextAttrsAt(rCursor.GetContentIndex(), 
RES_TXTATR_REFMARK);
+tools::ScopedJsonWriterNode aRefmark = rJsonWriter.startNode("setRef");
+if (aAttrs.empty())
+{
+return;
+}
+
+const SwFormatRefMark& rRefmark = aAttrs[0]->GetRefMark();
+if (!rRefmark.GetRefName().startsWith(aNamePrefix))
+{
+return;
+}
+
+rJsonWriter.put("name", rRefmark.GetRefName());
+}
+
 /// Implements getCommandValues(".uno:Sections").
 ///
 /// Parameters:
@@ -361,8 +413,9 @@ void GetSections(tools::JsonWriter& rJsonWriter, 
SwDocShell* pDocShell,
 bool SwXTextDocument::supportsCommand(std::u16string_view rCommand)
 {
 static const std::initializer_list 

[Libreoffice-bugs] [Bug 153001] New: Search for commands: add more styling commands

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=153001

Bug ID: 153001
   Summary: Search for commands: add more styling commands
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: avidseek...@protonmail.com

There’s support for bold, italic, but no support for changing borders,
highlight, colors through "Search and run commands" menu.

Examples: https://imgur.com/a/maRLEik

Related discussion:
https://ask.libreoffice.org/t/support-for-search-and-run-commands/86366/7

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: comphelper/source include/comphelper include/unotools package/source ucb/source unotools/source

[Noel Grandin (via logerrit)]

 comphelper/source/misc/storagehelper.cxx |   11 ++-
 comphelper/source/streaming/basicio.cxx  |   13 -
 comphelper/source/streaming/memorystream.cxx |   12 +---
 comphelper/source/streaming/seqstream.cxx|7 ---
 include/comphelper/bytereader.hxx|9 +++--
 include/comphelper/seqstream.hxx |5 +
 include/unotools/streamwrap.hxx  |5 +
 package/source/xstor/owriteablestream.cxx|   19 +++
 package/source/xstor/owriteablestream.hxx|4 
 package/source/zipapi/ZipFile.cxx|5 +
 ucb/source/ucp/file/filstr.cxx   |7 ---
 ucb/source/ucp/file/filstr.hxx   |6 +-
 unotools/source/streaming/streamwrap.cxx |8 
 unotools/source/ucbhelper/ucblockbytes.cxx   |6 +-
 14 files changed, 14 insertions(+), 103 deletions(-)

New commits:
commit 14df26ac57696c11fd344bb16ec22738e42377fc
Author: Noel Grandin 
AuthorDate: Thu Jan 12 11:49:29 2023 +0200
Commit: Noel Grandin 
CommitDate: Fri Jan 13 06:15:21 2023 +

XUnoTunnel->dynamic_cast in comphelper::ByteReader and 
comphelper::ByteWriter

Change-Id: I1f8c864a939dff1252ba15f517f63b62d1a1e1fc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145393
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/comphelper/source/misc/storagehelper.cxx 
b/comphelper/source/misc/storagehelper.cxx
index 934261b0c500..7b41eafbf9f1 100644
--- a/comphelper/source/misc/storagehelper.cxx
+++ b/comphelper/source/misc/storagehelper.cxx
@@ -175,17 +175,10 @@ void OStorageHelper::CopyInputToOutput(
 {
 static const sal_Int32 nConstBufferSize = 32000;
 
-uno::Reference< css::lang::XUnoTunnel > xInputTunnel( xInput, 
uno::UNO_QUERY );
-comphelper::ByteReader* pByteReader = nullptr;
+comphelper::ByteReader* pByteReader = dynamic_cast< 
comphelper::ByteReader* >( xInput.get() );
 comphelper::ByteWriter* pByteWriter = nullptr;
-if (xInputTunnel)
-pByteReader = reinterpret_cast< comphelper::ByteReader* >( 
xInputTunnel->getSomething( comphelper::ByteReader::getUnoTunnelId() ) );
 if (pByteReader)
-{
-uno::Reference< css::lang::XUnoTunnel > xOutputTunnel( xOutput, 
uno::UNO_QUERY );
-if (xOutputTunnel)
-pByteWriter = reinterpret_cast< comphelper::ByteWriter* >( 
xOutputTunnel->getSomething( comphelper::ByteWriter::getUnoTunnelId() ) );
-}
+   pByteWriter = dynamic_cast< comphelper::ByteWriter* >( xOutput.get() );
 
 if (pByteWriter)
 {
diff --git a/comphelper/source/streaming/basicio.cxx 
b/comphelper/source/streaming/basicio.cxx
index b8c0c96e2cfa..534d8b4cd0a1 100644
--- a/comphelper/source/streaming/basicio.cxx
+++ b/comphelper/source/streaming/basicio.cxx
@@ -161,21 +161,8 @@ const css::uno::Reference& 
operator << (const css:
 
 ByteReader::~ByteReader() {}
 
-const css::uno::Sequence< sal_Int8 > & ByteReader::getUnoTunnelId()
-{
-static const comphelper::UnoIdInit implId;
-return implId.getSeq();
-}
-
 ByteWriter::~ByteWriter() {}
 
-const css::uno::Sequence< sal_Int8 > & ByteWriter::getUnoTunnelId()
-{
-static const comphelper::UnoIdInit implId;
-return implId.getSeq();
-}
-
-
 }   // namespace comphelper
 
 
diff --git a/comphelper/source/streaming/memorystream.cxx 
b/comphelper/source/streaming/memorystream.cxx
index 97480a3aad64..dc2a39d9e5b1 100644
--- a/comphelper/source/streaming/memorystream.cxx
+++ b/comphelper/source/streaming/memorystream.cxx
@@ -55,7 +55,7 @@ namespace comphelper
 namespace {
 
 class UNOMemoryStream :
-public WeakImplHelper,
+public WeakImplHelper,
 public comphelper::ByteWriter
 {
 public:
@@ -90,9 +90,6 @@ public:
 // XTruncate
 virtual void SAL_CALL truncate() override;
 
-// XUnoTunnel
-virtual sal_Int64 SAL_CALL getSomething( const css::uno::Sequence< 
sal_Int8 >& aIdentifier ) override;
-
 // comphelper::ByteWriter
 virtual void writeBytes(const sal_Int8* aData, sal_Int32 nBytesToWrite) 
override;
 
@@ -248,13 +245,6 @@ void SAL_CALL UNOMemoryStream::truncate()
 mnCursor = 0;
 }
 
-sal_Int64 SAL_CALL UNOMemoryStream::getSomething( const css::uno::Sequence< 
sal_Int8 >& rIdentifier )
-{
-if (rIdentifier == comphelper::ByteWriter::getUnoTunnelId())
-return 
reinterpret_cast(static_cast(this));
-return 0;
-}
-
 } // namespace comphelper
 
 extern "C" SAL_DLLPUBLIC_EXPORT css::uno::XInterface *
diff --git a/comphelper/source/streaming/seqstream.cxx 
b/comphelper/source/streaming/seqstream.cxx
index 1f37a7967b04..9626484f62d4 100644
--- a/comphelper/source/streaming/seqstream.cxx
+++ b/comphelper/source/streaming/seqstream.cxx
@@ -92,13 +92,6 @@ sal_Int32 SequenceInputStream::readSomeBytes( sal_Int8* 
pData, sal_Int32 nBytesT
 return nBytesToRead;
 }
 
-sal_Int64 SAL_CALL SequenceInputStream::getSomething( const 
css::uno::Sequence< sal_Int8 >& rIdentifier )

[Libreoffice-bugs] [Bug 152984] FORMATTING: support formatted paste from Google Sheets

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=152984

--- Comment #2 from AvidSeeker  ---
[Google Sheets template
gallery](https://docs.google.com/spreadsheets/u/0/?ftv=1) can be used as test
cases.


Here are examples from "monthly budget" templates:

Google Sheet screenshot: https://i.imgur.com/OepYKBa.png

Libreoffice Calc screenshot: https://i.imgur.com/wss0uhA.png

As I said, attributes are style (bold, italic, color, highlight, border, etc.)
and merged cells. 

Relevant discussion:
https://ask.libreoffice.org/t/support-formatted-paste-from-google-sheets/86358/10?u=avidseeker

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/source

[Mike Kaganski (via logerrit)]

 sw/source/filter/ww8/docxattributeoutput.cxx |   20 
 sw/source/filter/ww8/wrtw8sty.cxx|3 ++-
 sw/source/filter/ww8/wrtww8.hxx  |3 ---
 3 files changed, 14 insertions(+), 12 deletions(-)

New commits:
commit 20adf4683c7d38ad41edac586b897757393c8029
Author: Mike Kaganski 
AuthorDate: Thu Jan 12 15:41:38 2023 +0300
Commit: Mike Kaganski 
CommitDate: Fri Jan 13 05:16:58 2023 +

tdf#152425 related: don't generate style ids in DocxAttributeOutput::Redline

If the style id is unavailable from MSWordStyles::GetStyleId at this point,
it is a bug (meaning that we failed to output the style to styles.xml).
Local style generation here would skip the "make it unique" step anyway,
so the id would be unreliable / useless.

Change-Id: I32c3c6a2581a7aaa6c5b1bb3d48f09b90fb65f73
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145401
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/sw/source/filter/ww8/docxattributeoutput.cxx 
b/sw/source/filter/ww8/docxattributeoutput.cxx
index db4299d582b3..0a95e6c44cd6 100644
--- a/sw/source/filter/ww8/docxattributeoutput.cxx
+++ b/sw/source/filter/ww8/docxattributeoutput.cxx
@@ -3874,14 +3874,18 @@ void DocxAttributeOutput::Redline( const SwRedlineData* 
pRedlineData)
 
 m_pSerializer->startElementNS(XML_w, XML_pPr);
 
-OString sStyleName;
-if (auto format = 
m_rExport.m_rDoc.FindTextFormatCollByName(sParaStyleName))
-if (auto slot = m_rExport.m_pStyles->GetSlot(format); 
slot != 0xfff)
-sStyleName = m_rExport.m_pStyles->GetStyleId(slot);
-if (sStyleName.isEmpty())
-sStyleName = 
MSWordStyles::CreateStyleId(sParaStyleName);
-if ( !sStyleName.isEmpty() )
-m_pSerializer->singleElementNS(XML_w, XML_pStyle, 
FSNS(XML_w, XML_val), sStyleName);
+if (!sParaStyleName.isEmpty())
+{
+OString sStyleName;
+if (auto format = 
m_rExport.m_rDoc.FindTextFormatCollByName(sParaStyleName))
+if (auto slot = 
m_rExport.m_pStyles->GetSlot(format); slot != 0xfff)
+sStyleName = 
m_rExport.m_pStyles->GetStyleId(slot);
+// If the style name is empty at this point, this is a 
bug, meaning that we
+// failed to output the style to styles.xml properly
+assert(!sStyleName.isEmpty());
+if (!sStyleName.isEmpty())
+m_pSerializer->singleElementNS(XML_w, XML_pStyle, 
FSNS(XML_w, XML_val), sStyleName);
+}
 
 // The 'm_rExport.SdrExporter().getFlyAttrList()', 
'm_pParagraphSpacingAttrList' are used to hold information
 // that should be collected by different properties in the 
core, and are all flushed together
diff --git a/sw/source/filter/ww8/wrtw8sty.cxx 
b/sw/source/filter/ww8/wrtw8sty.cxx
index 72fca1b3696f..21d11894f2d5 100644
--- a/sw/source/filter/ww8/wrtw8sty.cxx
+++ b/sw/source/filter/ww8/wrtw8sty.cxx
@@ -381,7 +381,8 @@ void MSWordStyles::BuildWwNames()
 }
 }
 
-OString MSWordStyles::CreateStyleId(std::u16string_view aName)
+/// create style id using only ASCII characters of the style name
+static OString CreateStyleId(std::u16string_view aName)
 {
 OStringBuffer aStyleIdBuf(aName.size());
 for (size_t i = 0; i < aName.size(); ++i)
diff --git a/sw/source/filter/ww8/wrtww8.hxx b/sw/source/filter/ww8/wrtww8.hxx
index cf5d0bfa104b..b44575a89bab 100644
--- a/sw/source/filter/ww8/wrtww8.hxx
+++ b/sw/source/filter/ww8/wrtww8.hxx
@@ -1633,9 +1633,6 @@ public:
 /// Get slot of the style (rFormat).
 sal_uInt16 GetSlot( const SwFormat* pFormat ) const;
 
-/// create style id using only ASCII characters of the style name
-static OString CreateStyleId(std::u16string_view aName);
-
 /// Get styleId of the nSlot-th style (nSlot is its position in m_aStyles).
 OString const & GetStyleId(sal_uInt16 nSlot) const;
 

[Libreoffice-bugs] [Bug 152718] Curve auto numbering on merged cells

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=152718

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152715] I was hovering over a grouped set of objects, when a faulty tool tip appeared

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=152715

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152742] Writer tells me I'm writing Afrikaans - but I never chose that

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=152742

QA Administrators  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152742] Writer tells me I'm writing Afrikaans - but I never chose that

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=152742

--- Comment #4 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149721] LO doesn't jump to last edited page

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149721

--- Comment #3 from QA Administrators  ---
Dear Stu Corpe,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144919] Crash if I export a dialog-screen and click the 'Save' button.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144919

--- Comment #12 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144919] Crash if I export a dialog-screen and click the 'Save' button.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144919

QA Administrators  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 84467] Searching for font size does not always work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=84467

--- Comment #12 from QA Administrators  ---
Dear Axel Niedenhoff,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 81969] EDITING: Find and Replace does not replace text inside object with text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=81969

--- Comment #6 from QA Administrators  ---
Dear Jonata,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 49428] Broken cross references to inserted sections - EDITING

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=49428

--- Comment #14 from QA Administrators  ---
Dear jrdegan,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 139253] CROSS REFERENCE: Undo "insert section" corrupts all cross references, if anchor was in section.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139253

--- Comment #3 from QA Administrators  ---
Dear DarkTrick,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 114870] Field "Slide Title" does not work on master

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114870

--- Comment #3 from QA Administrators  ---
Dear Regina Henschel,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 107021] WindowServer memory leak when performing mail merge in Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107021

--- Comment #11 from QA Administrators  ---
Dear allen,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 113133] Cannot revert to selection cursor in Impress

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113133

--- Comment #5 from QA Administrators  ---
Dear mattreecebentley,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - sw/qa sw/source

[Aron Budea (via logerrit)]

 dev/null   |binary
 sw/qa/extras/tiledrendering/tiledrendering.cxx |   16 
 sw/source/uibase/uno/unotxdoc.cxx  |   16 +---
 3 files changed, 1 insertion(+), 31 deletions(-)

New commits:
commit ffb5c5e771f46d7bad9e39b547d40de7dca825ce
Author: Aron Budea 
AuthorDate: Fri Jan 13 01:43:29 2023 +0100
Commit: Aron Budea 
CommitDate: Fri Jan 13 03:00:17 2023 +

Revert "sw: lok: use redline author for saved author fields"

Causes unit test failures in online: unit-wopi-lock, unit-crash,
unit-wopi-fail-upload, unit-wopi-save-on-exit,
unit-wopi-documentconflict.

This reverts commit c33e60dd5d5aa8dd585afc9498f87d17ab22fb27.

Change-Id: Ib2a29ded0d3f7c2c2ba4ba4d192a3a0099b8023c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145424
Tested-by: Aron Budea 
Reviewed-by: Aron Budea 

diff --git a/sw/qa/extras/tiledrendering/data/savedauthorfield.odt 
b/sw/qa/extras/tiledrendering/data/savedauthorfield.odt
deleted file mode 100644
index a060c5892f12..
Binary files a/sw/qa/extras/tiledrendering/data/savedauthorfield.odt and 
/dev/null differ
diff --git a/sw/qa/extras/tiledrendering/tiledrendering.cxx 
b/sw/qa/extras/tiledrendering/tiledrendering.cxx
index 3330e419dc8b..88b4dcc95d7f 100644
--- a/sw/qa/extras/tiledrendering/tiledrendering.cxx
+++ b/sw/qa/extras/tiledrendering/tiledrendering.cxx
@@ -3791,22 +3791,6 @@ CPPUNIT_TEST_FIXTURE(SwTiledRenderingTest, 
testAuthorField)
 assertXPath(pXmlDoc, "/root/page[1]/body/txt[1]/Special[1]", "rText", 
sAuthor);
 }
 
-CPPUNIT_TEST_FIXTURE(SwTiledRenderingTest, testSavedAuthorField)
-{
-SwXTextDocument* pXTextDocument = createDoc("savedauthorfield.odt");
-const OUString sAuthor("XYZ ABCD");
-uno::Sequence 
aPropertyValues1(comphelper::InitPropertySequence(
-{
-{".uno:Author", uno::makeAny(sAuthor)},
-}));
-pXTextDocument->initializeForTiledRendering(aPropertyValues1);
-
-Scheduler::ProcessEventsToIdle();
-
-xmlDocUniquePtr pXmlDoc = parseLayoutDump();
-assertXPath(pXmlDoc, "/root/page[1]/body/txt[1]/Special[1]", "rText", 
sAuthor);
-}
-
 CPPUNIT_PLUGIN_IMPLEMENT();
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/uibase/uno/unotxdoc.cxx 
b/sw/source/uibase/uno/unotxdoc.cxx
index 05bddd1f5747..f91fe5626f1b 100644
--- a/sw/source/uibase/uno/unotxdoc.cxx
+++ b/sw/source/uibase/uno/unotxdoc.cxx
@@ -3570,9 +3570,6 @@ void SwXTextDocument::initializeForTiledRendering(const 
css::uno::SequenceGetRedlineAuthor(SW_MOD()->GetRedlineAuthor());
-OUString sAuthor;
-
 for (const beans::PropertyValue& rValue : rArguments)
 {
 if (rValue.Name == ".uno:HideWhitespace" && rValue.Value.has())
@@ -3581,9 +3578,8 @@ void SwXTextDocument::initializeForTiledRendering(const 
css::uno::Sequence());
 else if (rValue.Name == ".uno:Author" && rValue.Value.has())
 {
-sAuthor = rValue.Value.get();
 // Store the author name in the view.
-pView->SetRedlineAuthor(sAuthor);
+pView->SetRedlineAuthor(rValue.Value.get());
 // Let the actual author name pick up the value from the current
 // view, which would normally happen only during the next view
 // switch.
@@ -3593,16 +3589,6 @@ void SwXTextDocument::initializeForTiledRendering(const 
css::uno::Sequence());
 }
 
-if (!sAuthor.isEmpty() && sAuthor != sOrigAuthor)
-{
-SwView* pFirstView = static_cast(SfxViewShell::GetFirst());
-if (pFirstView && SfxViewShell::GetNext(*pFirstView) == nullptr)
-{
-if (SwViewShell* pShell = >GetWrtShell())
-pShell->UpdateFields(true);
-}
-}
-
 // Set the initial zoom value to 1; usually it is set in setClientZoom and
 // SwViewShell::PaintTile; zoom value is used for chart in place
 // editing, see postMouseEvent and setGraphicSelection methods.

[Libreoffice-bugs] [Bug 152996] Link in Help for Regular expressions to: ICU Regular Expressions documentation, times out.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=152996

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED
 CC||vsfo...@libreoffice.org

--- Comment #2 from V Stuart Foote  ---
Fixed by https://gerrit.libreoffice.org/c/help/+/103330

And can not confirm with 7.4 builds where the RegEx Help article [1] links to
URL:

https://unicode-org.github.io/icu/userguide/strings/regexp.html#regular-expression-metacharacters

which resolves correctly, as does the link for Calc [2] which resolves to

https://unicode-org.github.io/icu/userguide/strings/regexp.html

=-ref-=

[1]
https://help.libreoffice.org/7.4/en-US/text/shared/01/0211.html?=SHARED

[2]
https://help.libreoffice.org/7.4/en-US/text/scalc/01/func_regex.html?=SHARED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: editeng/source forms/qa include/editeng include/svx oox/Library_oox.mk oox/qa oox/source sd/qa sd/source svx/qa svx/source sw/qa sw/source writerfilter/Library_writerfi

[Tomaž Vajngerl (via logerrit)]

 editeng/source/items/textitem.cxx |   19 +++
 editeng/source/uno/unotext.cxx|6 +
 forms/qa/unoapi/knownissues.xcl   |2 
 include/editeng/memberids.h   |1 
 include/editeng/unoprnms.hxx  |3 
 include/editeng/unotext.hxx   |1 
 include/svx/unoshprp.hxx  |1 
 oox/Library_oox.mk|1 
 oox/qa/unit/drawingml.cxx |   71 +++--
 oox/qa/unit/shape.cxx |   11 +-
 oox/source/drawingml/fillproperties.cxx   |   21 +++
 oox/source/drawingml/textcharacterproperties.cxx  |   23 +++-
 oox/source/export/drawingml.cxx   |   99 --
 oox/source/token/properties.txt   |2 
 sd/qa/unit/uiimpress.cxx  |   61 +--
 sd/source/core/stlsheet.cxx   |9 +
 svx/qa/unit/styles.cxx|   43 ---
 svx/qa/unit/xoutdev.cxx   |   47 
 svx/source/styles/ColorSets.cxx   |   62 ---
 svx/source/table/cell.cxx |9 +
 svx/source/unodraw/unoprov.cxx|1 
 svx/source/unodraw/unoshap2.cxx   |1 
 svx/source/unodraw/unoshape.cxx   |9 +
 svx/source/xoutdev/xattr.cxx  |   15 ++
 sw/qa/core/theme/ThemeTest.cxx|9 +
 sw/source/core/unocore/unomap.cxx |1 
 sw/source/core/unocore/unomap1.cxx|2 
 sw/source/core/unocore/unomapproperties.hxx   |3 
 writerfilter/Library_writerfilter.mk  |1 
 writerfilter/source/dmapper/DomainMapper.cxx  |  119 --
 writerfilter/source/dmapper/PropertyIds.cxx   |3 
 writerfilter/source/dmapper/PropertyIds.hxx   |3 
 writerfilter/source/dmapper/TDefTableHandler.cxx  |   38 +++
 writerfilter/source/dmapper/TDefTableHandler.hxx  |4 
 writerfilter/source/dmapper/ThemeColorHandler.hxx |   68 
 35 files changed, 488 insertions(+), 281 deletions(-)

New commits:
commit 197e5f81213d14fdcbff40edf73385ecd4cd9815
Author: Tomaž Vajngerl 
AuthorDate: Sun Jan 1 23:25:38 2023 +0900
Commit: Tomaž Vajngerl 
CommitDate: Fri Jan 13 00:49:24 2023 +

introduce {Char,Fill}ColorThemeReference which uses XThemeColor

Adds a unified UNO property for theme colors *ColorTheme
(CharColorTheme and FillColorTheme) which uses XThemeColor, that
replaces the properties *Theme, *TintOrShade, *LumOff, *LumMod.
The properties are still present for backwards compatibility and
to keep ODF support working in tests as that needs a bigger change.

Reactor the code and tests to accomodate for this change.

Change-Id: If7983decb4ba528b49fe7b5968aa9efc696a9efc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144783
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl 

diff --git a/editeng/source/items/textitem.cxx 
b/editeng/source/items/textitem.cxx
index bf6017cdcf6d..5a53d6a8e14c 100644
--- a/editeng/source/items/textitem.cxx
+++ b/editeng/source/items/textitem.cxx
@@ -77,6 +77,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 
 using namespace ::com::sun::star;
@@ -1435,6 +1436,12 @@ bool SvxColorItem::QueryValue( uno::Any& rVal, sal_uInt8 
nMemberId ) const
 rVal <<= nValue;
 break;
 }
+   case MID_COLOR_THEME_REFERENCE:
+{
+auto xThemeColor = model::theme::createXThemeColor(maThemeColor);
+rVal <<= xThemeColor;
+break;
+}
 default:
 {
 rVal <<= mColor;
@@ -1509,6 +1516,18 @@ bool SvxColorItem::PutValue( const uno::Any& rVal, 
sal_uInt8 nMemberId )
 maThemeColor.addTransformation({model::TransformationType::LumOff, 
nLumOff});
 }
 break;
+case MID_COLOR_THEME_REFERENCE:
+{
+css::uno::Reference xThemeColor;
+if (!(rVal >>= xThemeColor))
+return false;
+
+if (xThemeColor.is())
+{
+model::theme::setFromXThemeColor(maThemeColor, xThemeColor);
+}
+}
+break;
 default:
 {
 return rVal >>= mColor;
diff --git a/editeng/source/uno/unotext.cxx b/editeng/source/uno/unotext.cxx
index e5877a7d2e5a..82a399f00e26 100644
--- a/editeng/source/uno/unotext.cxx
+++ b/editeng/source/uno/unotext.cxx
@@ -1175,6 +1175,12 @@ bool SvxUnoTextRangeBase::_getOnePropertyStates(const 
SfxItemSet* pSet, const Sf
 }
 break;
 }
+case MID_COLOR_THEME_REFERENCE:
+if (pColor->GetThemeColor().getType() == 
model::ThemeColorType::Unknown)
+

[Libreoffice-bugs] [Bug 153000] New: FILEOPEN DOCX file types MSO_SPT=25 to 31 are wrongly rendered

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=153000

Bug ID: 153000
   Summary: FILEOPEN DOCX file types MSO_SPT=25 to 31 are wrongly
rendered
   Product: LibreOffice
   Version: 7.6.0.0 alpha0+ Master
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Keywords: implementationError
  Severity: minor
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rb.hensc...@t-online.de

Created attachment 184625
  --> https://bugs.documentfoundation.org/attachment.cgi?id=184625=edit
shapes and screenshots

Open attached files. It contains the preset text warp shapes from index 24 to
31 and to each one a screenshot how it looks in Word.

The shapes are imported with a correct Type value, but they are wrongly
rendered. The error is likely in mso_CustomShape* GetCustomShapeContent(
MSO_SPT eSpType ) method in
https://opengrok.libreoffice.org/xref/core/svx/source/customshapes/EnhancedCustomShapeGeometry.cxx?r=4cfe4699#8350
That method maps the MSO_SPT number to the mso_CustomShape shape description.
For the shapes in question you see the comment
// Don't know, simply mapping to TextSimple

The shapes are specified in
https://learn.microsoft.com/en-us/openspecs/office_file_formats/ms-odraw/9c0c5c01-9e90-41aa-ba15-477dacb4cc8e
The shapes here are special, as they will not be correctly rendered in Word
2010 and earlier, see the comments in the above given link for these shapes.

The specification shows only images but has no exact path description.
Comparing the results in Word shows, that Word maps these shapes in this way:
(24) msosptTextSimple -> (136) msosptTextPlainText
(25) msosptTextOctagon -> (137) msosptTextStop
(26) msosptTextHexagon -> (138) msosptTextTriangle 
(27) msosptTextCurve -> (175) msosptTextCanDown 
(28) msosptTextWave -> (156) msosptTextWave1
(29) msosptTextRing -> (148) msosptTextArchUpPour
(30) msosptTextOnCurve -> (175) msosptTextCanDown
(31) msosptTextOnRing ->(144) msosptTextArchUpCurve

So we should do the same.

The shapes (24)..(31) are not available in the UI. Therefore "Minor" severity.
But they can be created with XEnhancedCustomShapeDefaulter interface.

The attached file was created by Word from a manually changed .rtf file.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 118614] When a form showing a date field containing a valid date is exported as a PDF file with "Create PDF form" checked, the resultant PDF file shows an empty field.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=118614

--- Comment #9 from Alan Wheeler  ---
Still present in LibreOffice 7.4.4

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sc/qa

[Xisco Fauli (via logerrit)]

 sc/qa/uitest/calc_tests/autosum.py |  214 -
 sc/qa/unit/uicalc/data/autosum.ods |binary
 sc/qa/unit/uicalc/uicalc.cxx   |  179 +-
 3 files changed, 170 insertions(+), 223 deletions(-)

New commits:
commit c82fa434dab8744c548db166cd24ee82e8759e1f
Author: Xisco Fauli 
AuthorDate: Thu Jan 12 23:07:53 2023 +0100
Commit: Xisco Fauli 
CommitDate: Thu Jan 12 23:33:45 2023 +

sc: move different UItests to CppUnittest

it seems Jenkins fails sometimes with this test
https://ci.libreoffice.org/job/gerrit_linux_clang_dbgutil/131248/
this commit might help

TODO: convert the remaining test
Change-Id: Ib3fb48e2e457a9168fa16c8f9f2ac9f98beabcf3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145422
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 

diff --git a/sc/qa/uitest/calc_tests/autosum.py 
b/sc/qa/uitest/calc_tests/autosum.py
index cc67bae05d80..db3334c36725 100644
--- a/sc/qa/uitest/calc_tests/autosum.py
+++ b/sc/qa/uitest/calc_tests/autosum.py
@@ -15,132 +15,6 @@ from libreoffice.uno.propertyvalue import mkPropertyValues
 
 class calcAutosum(UITestCase):
 
-def test_autosum_test1(self):
-#Sum on range and Sum on Sum's
-with self.ui_test.load_file(get_url_for_data_file("autosum.ods")) as 
calc_doc:
-xCalcDoc = self.xUITest.getTopFocusWindow()
-gridwin = xCalcDoc.getChild("grid_window")
-#Place the cell cursor on the gray cells located under Point 1.
-#(Multiselection is not possible at this place) and press the Sum 
Icon in the formula bar.
-#Now hit the enter key and the result should be shown. Do so for 
each gray cell in this part of the document.
-gridwin.executeAction("SELECT", mkPropertyValues({"CELL": "B10"}))
-self.xUITest.executeCommand(".uno:AutoSum")
-gridwin.executeAction("SELECT", mkPropertyValues({"CELL": "B13"}))
-self.xUITest.executeCommand(".uno:AutoSum")
-gridwin.executeAction("SELECT", mkPropertyValues({"CELL": "B14"}))
-self.xUITest.executeCommand(".uno:AutoSum")
-self.assertEqual(get_cell_by_position(calc_doc, 0, 1, 
9).getValue(), 2)
-self.assertEqual(get_cell_by_position(calc_doc, 0, 1, 
9).getFormula(), "=SUM(B8:B9)")
-self.assertEqual(get_cell_by_position(calc_doc, 0, 1, 
12).getValue(), 2)
-self.assertEqual(get_cell_by_position(calc_doc, 0, 1, 
12).getFormula(), "=SUM(B11:B12)")
-self.assertEqual(get_cell_by_position(calc_doc, 0, 1, 
13).getValue(), 4)
-self.assertEqual(get_cell_by_position(calc_doc, 0, 1, 
13).getFormula(), "=SUM(B13:B13;B10:B10)")
-
-gridwin.executeAction("SELECT", mkPropertyValues({"RANGE": 
"F8:F14"}))
-self.xUITest.executeCommand(".uno:AutoSum")
-self.assertEqual(get_cell_by_position(calc_doc, 0, 5, 
13).getValue(), 4)
-self.assertEqual(get_cell_by_position(calc_doc, 0, 5, 
13).getFormula(), "=SUM(F13:F13;F10:F10)")
-
-def test_autosum_test2(self):
-#Sum on Row and Column
-with self.ui_test.load_file(get_url_for_data_file("autosum.ods")) as 
calc_doc:
-xCalcDoc = self.xUITest.getTopFocusWindow()
-gridwin = xCalcDoc.getChild("grid_window")
-
-gridwin.executeAction("SELECT", mkPropertyValues({"CELL": "E25"}))
-self.xUITest.executeCommand(".uno:AutoSum")
-gridwin.executeAction("SELECT", mkPropertyValues({"CELL": "E26"}))
-self.xUITest.executeCommand(".uno:AutoSum")
-gridwin.executeAction("SELECT", mkPropertyValues({"CELL": "E27"}))
-self.xUITest.executeCommand(".uno:AutoSum")
-gridwin.executeAction("SELECT", mkPropertyValues({"CELL": "E28"}))
-self.xUITest.executeCommand(".uno:AutoSum")
-gridwin.executeAction("SELECT", mkPropertyValues({"CELL": "E29"}))
-self.xUITest.executeCommand(".uno:AutoSum")
-gridwin.executeAction("SELECT", mkPropertyValues({"CELL": "E30"}))
-self.xUITest.executeCommand(".uno:AutoSum")
-
-self.assertEqual(get_cell_by_position(calc_doc, 0, 4, 
24).getValue(), 3)
-self.assertEqual(get_cell_by_position(calc_doc, 0, 4, 
24).getFormula(), "=SUM(E22:E24)")
-self.assertEqual(get_cell_by_position(calc_doc, 0, 4, 
25).getValue(), 3)
-self.assertEqual(get_cell_by_position(calc_doc, 0, 4, 
25).getFormula(), "=SUM(B26:D26)")
-self.assertEqual(get_cell_by_position(calc_doc, 0, 4, 
26).getValue(), 3)
-self.assertEqual(get_cell_by_position(calc_doc, 0, 4, 
26).getFormula(), "=SUM(B27:D27)")
-self.assertEqual(get_cell_by_position(calc_doc, 0, 4, 
27).getValue(), 3)
-self.assertEqual(get_cell_by_position(calc_doc, 0, 4, 
27).getFormula(), "=SUM(B28:D28)")
-

[Libreoffice-bugs] [Bug 152553] Spell Check Dialog Box Fails to Automatically Close When Done

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=152553

--- Comment #5 from kit...@tutanota.com ---
As I already pointed out, that is just short-sighted, and actually sort of sad.
 After starting a project, to just stop improving it is a waste and indicates
it should never have been started in the first place.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 152655] Introduce a Slide/Page style category in Impress

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=152655

Eyal Rozenberg  changed:

   What|Removed |Added

   Keywords||needsDevAdvice

--- Comment #5 from Eyal Rozenberg  ---
(In reply to Heiko Tietze from comment #4)
>
> Introducing a style requires standardization and implementation everywhere.
> There should be a very good reason to do so. And since most of the mentioned
> attributes are already available via master slides, the request is invalid.

I'll start by saying that this is not merely a design issue. So, a discussion
in the design committee (even ignoring the fact that I couldn't attend) is not
sufficient IMHO to mark this INVALID. Nor would it be sufficient to decide that
this is a good idea, either; I'm guessing whoever works on the master slides
and slide layout code might have an opinion about the possibility of expression
some/most of that via a proper style. (For which reason I've marked
needsDevAdvice, which I should have done earlier.) And this all is doubly the
case considering the meta-bug, i.e. the fact that there seems to be agreement
about the need to standardize and implement several new kinds of styles in
Impress.

Now, to your objection itself... 

the latter clause of your last sentence does not follow from the former.
Indeed, many of what would be the attributes of a page/slide are available via
master slides. But - this overlap does not make it harder or more complex to
standardize or implement. In fact, it might even simplify the existing
implementation and/or the standardization. I'm no ODF expert, but - element
styles are very natural to represent in XML. I would even guess that the
relation between a slide and its master in the ODF is already somewhat like
that of a writer page and its style. I'm just suggesting that this relation be
split into a proper style (which would be filled out with additional features),
and whatever aspects of the relation are non-style-like.



PS - Where is "everywhere"? We're talking about Impress and Draw.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 152655] Introduce a Slide/Page style category in Impress

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=152655

Eyal Rozenberg  changed:

   What|Removed |Added

   Keywords||needsDevAdvice

--- Comment #5 from Eyal Rozenberg  ---
(In reply to Heiko Tietze from comment #4)
>
> Introducing a style requires standardization and implementation everywhere.
> There should be a very good reason to do so. And since most of the mentioned
> attributes are already available via master slides, the request is invalid.

I'll start by saying that this is not merely a design issue. So, a discussion
in the design committee (even ignoring the fact that I couldn't attend) is not
sufficient IMHO to mark this INVALID. Nor would it be sufficient to decide that
this is a good idea, either; I'm guessing whoever works on the master slides
and slide layout code might have an opinion about the possibility of expression
some/most of that via a proper style. (For which reason I've marked
needsDevAdvice, which I should have done earlier.) And this all is doubly the
case considering the meta-bug, i.e. the fact that there seems to be agreement
about the need to standardize and implement several new kinds of styles in
Impress.

Now, to your objection itself... 

the latter clause of your last sentence does not follow from the former.
Indeed, many of what would be the attributes of a page/slide are available via
master slides. But - this overlap does not make it harder or more complex to
standardize or implement. In fact, it might even simplify the existing
implementation and/or the standardization. I'm no ODF expert, but - element
styles are very natural to represent in XML. I would even guess that the
relation between a slide and its master in the ODF is already somewhat like
that of a writer page and its style. I'm just suggesting that this relation be
split into a proper style (which would be filled out with additional features),
and whatever aspects of the relation are non-style-like.



PS - Where is "everywhere"? We're talking about Impress and Draw.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: bin/update_pch cui/inc cui/Library_cui.mk cui/source docmodel/inc docmodel/Library_docmodel.mk docmodel/Makefile docmodel/Module_docmodel.mk docmodel/README.md docmodel

[Tomaž Vajngerl (via logerrit)]

 Repository.mk  |1 
 RepositoryModule_build.mk  |1 
 RepositoryModule_host.mk   |1 
 bin/update_pch |   31 ++---
 cui/Library_cui.mk |1 
 cui/inc/pch/precompiled_cui.hxx|   14 +-
 cui/source/tabpages/chardlg.cxx|   12 +-
 cui/source/tabpages/tpcolor.cxx|   10 +
 docmodel/Library_docmodel.mk   |   39 ++
 docmodel/Makefile  |7 +
 docmodel/Module_docmodel.mk|   18 +++
 docmodel/README.md |5 
 docmodel/inc/pch/precompiled_docmodel.cxx  |   12 ++
 docmodel/inc/pch/precompiled_docmodel.hxx  |   34 +
 docmodel/source/uno/UnoThemeColor.cxx  |   40 ++
 editeng/CppunitTest_editeng_core.mk|1 
 editeng/Library_editeng.mk |1 
 editeng/inc/pch/precompiled_editeng.hxx|7 -
 editeng/source/items/textitem.cxx  |  105 ++---
 editeng/source/uno/unotext.cxx |   22 +++
 include/docmodel/dllapi.h  |   21 +++
 include/docmodel/theme/ThemeColor.hxx  |  146 +
 include/docmodel/theme/ThemeColorType.hxx  |   42 +++
 include/docmodel/uno/UnoThemeColor.hxx |   55 +
 include/editeng/colritem.hxx   |   54 -
 include/svx/ColorSets.hxx  |   32 -
 include/svx/xcolit.hxx |9 -
 offapi/UnoApi_offapi.mk|1 
 offapi/com/sun/star/util/XThemeColor.idl   |   26 
 oox/CppunitTest_oox_drawingml.mk   |1 
 oox/CppunitTest_oox_shape.mk   |1 
 oox/CppunitTest_oox_tokenmap.mk|1 
 oox/Library_oox.mk |1 
 oox/inc/pch/precompiled_oox.hxx|   69 ---
 oox/source/export/ThemeExport.cxx  |   28 ++--
 sd/CppunitTest_sd_uiimpress.mk |1 
 sd/CppunitTest_sd_uimpress.mk  |1 
 sd/Library_sd.mk   |1 
 sd/inc/pch/precompiled_sd.hxx  |   68 ++-
 sd/source/core/stlsheet.cxx|   18 ++-
 sd/source/filter/eppt/pptx-epptooxml.cxx   |2 
 sd/source/ui/func/fuconstr.cxx |4 
 sd/source/ui/view/drtxtob1.cxx |   29 ++--
 sd/source/ui/view/drviews2.cxx |7 -
 solenv/gbuild/extensions/pre_MergedLibsList.mk |1 
 solenv/qa/python/gbuildtojson.py   |2 
 svx/CppunitTest_svx_removewhichrange.mk|1 
 svx/CppunitTest_svx_styles.mk  |1 
 svx/CppunitTest_svx_unit.mk|1 
 svx/Library_svxcore.mk |1 
 svx/inc/pch/precompiled_svx.hxx|   29 ++--
 svx/source/styles/ColorSets.cxx|   14 +-
 svx/source/table/cell.cxx  |   19 ++-
 svx/source/unodraw/unoshape.cxx|   18 ++-
 svx/source/xoutdev/xattr.cxx   |   47 ++--
 sw/CppunitTest_sw_apitests.mk  |1 
 sw/CppunitTest_sw_core_draw.mk |1 
 sw/CppunitTest_sw_core_theme.mk|1 
 sw/CppunitTest_sw_macros_test.mk   |1 
 sw/CppunitTest_sw_ooxmlimport.mk   |1 
 sw/CppunitTest_sw_ooxmlimport2.mk  |1 
 sw/CppunitTest_sw_tiledrendering.mk|1 
 sw/CppunitTest_sw_uwriter.mk   |1 
 sw/Library_sw.mk   |1 
 sw/layoutwriter_setup.mk   |1 
 sw/ooxmlexport_setup.mk|1 
 sw/qa/core/theme/ThemeTest.cxx |   20 +--
 sw/source/uibase/sidebar/ThemePanel.cxx|   13 +-
 sw/uiwriter_setup.mk   |1 
 sw/ww8export_setup.mk  |1 
 70 files changed, 883 insertions(+), 277 deletions(-)

New commits:
commit bd0f526f2d3e1ffe43a74672485815768eee6e9e
Author: Tomaž Vajngerl 
AuthorDate: Wed Dec 28 09:43:46 2022 +0900
Commit: Tomaž Vajngerl 
CommitDate: Thu Jan 12 23:15:58 2023 +

introduce docmodel comp., model::ThemeColor, use it in SvxColorItem

Added a new component docmodel, that has the document model types,
which only depend on other basic components. This is needed so the
types can be used in every relevant component - xmloff, oox, svx,
editeng,...

Introduces model::ThemeColor, which is a class used to store the
theme color data, including transformations (svx::Transformation).
For UNO use XThemeColor is added, and the implementation UnoThemeColor
which wraps svx::ThemeColor, so it can be tranported around.

Reactor all the code and tests to 

[Libreoffice-bugs] [Bug 152371] Hidden cells create a new empty page

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=152371

m.a.riosv  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

--- Comment #3 from m.a.riosv  ---
With your sample file, I can only view one page, on Print preview/Print.
Version: 7.4.4.2 (x64) / LibreOffice Community
Build ID: 85569322deea74ec9134968a29af2df5663baa21
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Vulkan; VCL: win
Locale: es-ES (es_ES); UI: en-US Calc: CL

And the 'Menu/Tools/Options/LibreOffice Calc/Print - Pages - Suppress output of
empty pages' doesn't change the behavior.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152742] Writer tells me I'm writing Afrikaans - but I never chose that

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=152742

--- Comment #3 from Eyal Rozenberg  ---
(In reply to Stéphane Guillou (stragu) from comment #2)
> Does it still happen in safe mode?

Not exactly. When I start in Safe Mode, the Western language is "English
(Israel)", and the RTL-CTL language is Hindi - which I never chose.

My locale info:

$ locale
LANG=en_IL
LANGUAGE=en_IL:en
LC_CTYPE="en_IL"
LC_NUMERIC="en_IL"
LC_TIME="en_IL"
LC_COLLATE="en_IL"
LC_MONETARY="en_IL"
LC_MESSAGES="en_IL"
LC_PAPER="en_IL"
LC_NAME="en_IL"
LC_ADDRESS="en_IL"
LC_TELEPHONE="en_IL"
LC_MEASUREMENT="en_IL"
LC_IDENTIFICATION="en_IL"
LC_ALL=

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: cppuhelper/source

[Stephan Bergmann (via logerrit)]

 cppuhelper/source/factory.cxx |   19 ---
 1 file changed, 16 insertions(+), 3 deletions(-)

New commits:
commit c945eafc99856f0bcd0a99195e2c5164c2a6d24a
Author: Stephan Bergmann 
AuthorDate: Thu Jan 12 20:44:10 2023 +0100
Commit: Stephan Bergmann 
CommitDate: Thu Jan 12 22:19:36 2023 +

Don't let OSingleFactoryHelper delegate to derived classes' virtual 
overrides

...as it doesn't make sense that e.g. 
OFactoryComponentHelper::createInstance
checked for bOneInstance, called OSingleFactoryHelper::createInstance, which
called [OFactoryComponentHelper::]createInstanceWithContext, which checked 
for
bOneInstance again

Change-Id: I53f54079a2ac1af18a6e95f0cb9d7b75c1e46ceb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145418
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/cppuhelper/source/factory.cxx b/cppuhelper/source/factory.cxx
index c4797f85504a..37ac44ffa1a5 100644
--- a/cppuhelper/source/factory.cxx
+++ b/cppuhelper/source/factory.cxx
@@ -116,6 +116,11 @@ protected:
 ComponentFactoryFunc m_fptr;
 Sequence< OUString > aServiceNames;
 OUString aImplementationName;
+
+private:
+css::uno::Reference 
createInstanceWithArgumentsEveryTime(
+css::uno::Sequence const & rArguments,
+css::uno::Reference const & xContext);
 };
 
 }
@@ -160,14 +165,14 @@ Reference 
OSingleFactoryHelper::createInstanceEveryTime(
 // XSingleServiceFactory
 Reference OSingleFactoryHelper::createInstance()
 {
-return createInstanceWithContext( Reference< XComponentContext >() );
+return createInstanceEveryTime( Reference< XComponentContext >() );
 }
 
 // XSingleServiceFactory
 Reference OSingleFactoryHelper::createInstanceWithArguments(
 const Sequence& Arguments )
 {
-return createInstanceWithArgumentsAndContext(
+return createInstanceWithArgumentsEveryTime(
 Arguments, Reference< XComponentContext >() );
 }
 
@@ -183,7 +188,15 @@ Reference< XInterface > 
OSingleFactoryHelper::createInstanceWithArgumentsAndCont
 Sequence< Any > const & rArguments,
 Reference< XComponentContext > const & xContext )
 {
-Reference< XInterface > xRet( createInstanceWithContext( xContext ) );
+return createInstanceWithArgumentsEveryTime(rArguments, xContext);
+}
+
+css::uno::Reference
+OSingleFactoryHelper::createInstanceWithArgumentsEveryTime(
+css::uno::Sequence const & rArguments,
+css::uno::Reference const & xContext)
+{
+Reference< XInterface > xRet( createInstanceEveryTime( xContext ) );
 
 Reference< lang::XInitialization > xInit( xRet, UNO_QUERY );
 // always call initialize, even if there are no arguments. #i63511#

[Libreoffice-bugs] [Bug 120663] No impress remote: Impress incompatible with current bluetooth stack on linux (RFCOMM server failed for LibreOffice Impress Remote: rfcomm_bind: Address already in use)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=120663

--- Comment #17 from Callegar  ---
Noticed that among the many tips of the day, LibO also suggests to use Android
or IPhone to remotely control an Impress presentation.  The "more info" page
then excplicitly declares that the feature is cross platform "GNU/Linux,
Windows or macOS." either via Bluetooth or Wifi.

However to use the feature with bluetooth on linux has been impossible for the
last 5 years, because the feature is broken on this platform (this bug provides
a diagnosis of the underlying issue). Using the feature with wifi is equally
problematic, because those places where you need to deliver a presentation are
typically those very places where you do not control the wifi network that may
make it impossible for the computer and the phone to communicate.

As a consequence, this tip of the day looks inappropriate on linux, making many
users waste a significant amount of time trying to use a feature that simply
cannot work. May I suggest removing this tip of the day on linux?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152999] New: UI: Document background color in settings overrides cell background colors in Calc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=152999

Bug ID: 152999
   Summary: UI: Document background color in settings overrides
cell background colors in Calc
   Product: LibreOffice
   Version: 7.4.3.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: jens-libreoff...@spamfreemail.de

Description:
I am using a dark theme (Breeze dark) on KDE Neon (Ubuntu based) and until
recently (7.4?) Libreoffice applied this to the UI, but not to the document
area, which was fine to me.

Now the dark theme is also applied to the document background (previously this
was always white), which *would* be fine it Libreoffice *also* inverted the
text and text/cell/object background brightnesses so that documents stayed
legible even with a dark document canvas. (This is roughly what Microsoft does
when using a dark theme in Office and it makes a lot of sense.)

Even worse, if I set a manual document background in the settings, this is
applied, but then *overrides* any cell background or font background defined in
documents.

IMHO, at least the last thing is a bug:
LibreOffice's theme/color settings should not override colors defined within
documents. Either this should be fixed or we need two more checkboxes in the
style settings:

[x] These settings override colors defined within documents
and
[x] Invert brightness of colors defined within documents (use this for dark
document backgrounds)

Steps to Reproduce:
1. Configure dark theme on KDE Neon (Breeze dark)
1a. Configure "Document background color" to be "white", not auto
2. Open Libreoffice, also configure dark theme
3. Open a Calc document which has cell background colors defined

Actual Results:
Cell background colors are not visible in the document. Other colors are
visible.

Expected Results:
Cell background colors should be applied and visible.
(Possibly as an option, but as the default option.)


Reproducible: Always


User Profile Reset: No

Additional Info:
[Information automatically included from LibreOffice]
Locale: de
Module: SpreadsheetDocument
[Information guessed from browser]
OS: Linux (All)
OS is 64bit: yes

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152998] Bottom of Print Dialog Is Cut Off on 13" MacBook Pro

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=152998

--- Comment #1 from mvarne...@yahoo.com ---
Created attachment 184624
  --> https://bugs.documentfoundation.org/attachment.cgi?id=184624=edit
Print dialog box with bottom controls cut off.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152998] New: Bottom of Print Dialog Is Cut Off on 13" MacBook Pro

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=152998

Bug ID: 152998
   Summary: Bottom of Print Dialog Is Cut Off on 13" MacBook Pro
   Product: LibreOffice
   Version: 7.3.0.3 release
  Hardware: x86-64 (AMD64)
OS: macOS (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: mvarne...@yahoo.com

Description:
On my 2015 MacBook Pro Retina 13", the bottom of the print dialog box is cut
off while in the "LibreOffice" options panel. This started a few versions back,
presumably when more options were added to the panel. One can almost click on
the buttons on the bottom, but they cannot be read without going into the
drop-down menu and changing to one of the other panels.

This display has a scaled interface size of 1280x800, so this likely affects
numerous laptops and other small monitors. Perhaps the LibreOffice options
panel needs a scroll bar?

Steps to Reproduce:
1. Open a Writer document.
2. Choose File -> Print.
3. LibreOffice panel is displayed by default.

Actual Results:
The bottom row of buttons are displayed outside the screen area.

Expected Results:
The bottom row of buttons, as well as the entire Print dialog box, should be
visible.


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 7.3.7.2 / LibreOffice Community
Build ID: e114eadc50a9ff8d8c8a0567d6da8f454beeb84f
CPU threads: 4; OS: Mac OS X 11.7.2; UI render: default; VCL: osx
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 138142] Draw should have an option to export to PDF keeping separate layers

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=138142

--- Comment #7 from jack_sprat  ---
This seems like a clear opportunity for showcasing one of the key advantages of
Draw over the frequent use of e.g. Powerpoint, for producing diagrams by MSO
aficionados.

(I came here because I was looking for this exact feature)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: cppuhelper/source

[Stephan Bergmann (via logerrit)]

 cppuhelper/source/factory.cxx |6 --
 1 file changed, 6 deletions(-)

New commits:
commit ca3ba86fe17227089d797f4f46cf228af97de3b3
Author: Stephan Bergmann 
AuthorDate: Thu Jan 12 21:39:16 2023 +0100
Commit: Stephan Bergmann 
CommitDate: Thu Jan 12 21:38:06 2023 +

Fix aggregating OFactoryComponentHelper::queryInterface

4bfc00aca2441082842f91dfba15886258674227 "#67468# factories support
XUnloadingPreference now" had added the check for XUnloadingPreference 
there,
but that's already covered by OFactoryComponentHelper::queryAggregation
delegating to OSingleFactoryHelper::queryInterface.  (And as
OFactoryComponentHelper is inheriting XAggregation via OComponentHelper, the
only thing that OFactoryComponentHelper::queryInterface shall do is 
delegate to
OComponentHelper::queryInterface.)

Change-Id: Iebe507e88791d1e2390d042a8a9c152512ce212a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145420
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/cppuhelper/source/factory.cxx b/cppuhelper/source/factory.cxx
index c8efcab0e604..c4797f85504a 100644
--- a/cppuhelper/source/factory.cxx
+++ b/cppuhelper/source/factory.cxx
@@ -298,12 +298,6 @@ protected:
 
 Any SAL_CALL OFactoryComponentHelper::queryInterface( const Type & rType )
 {
-if( rType == cppu::UnoType::get() )
-{
-return Any(
-Reference< XUnloadingPreference >(
-static_cast< XUnloadingPreference * >(this) ) );
-}
 return OComponentHelper::queryInterface( rType );
 }
 

[Libreoffice-bugs] [Bug 152997] New: SVG: circle based upon combination of solid lines + dashes, only renders as solid line

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=152997

Bug ID: 152997
   Summary: SVG: circle based upon combination of solid lines +
dashes, only renders as solid line
   Product: LibreOffice
   Version: 7.0.0.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: filters and storage
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tele...@surfxs.nl

Description:
SVG: circle based upon combination of solid lines + dashes, only renders as
solid line

Steps to Reproduce:
1. Download
https://upload.wikimedia.org/wikipedia/commons/c/ce/Plutchik-wheel.svg
2. insert the image in draw/writer

Actual Results:
Solid circles

Expected Results:
It's solid + dashes (see web browser rendering or older version of LibreOffice)


Reproducible: Always


User Profile Reset: No

Additional Info:
Found in
Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 12e8d57e791bb1befc0716d4d02af7d1d1ccb4ae
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL threaded

also in
Version: 7.0.7.0.0+ (x64)
Build ID: 626ea4e62a3e5005fe9825923a1c0c5bdb61cc08
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL

dashes + solid lines properly rendered with
Version: 6.1.6.3
Build ID: 5896ab1714085361c45cf540f76f60673dd96a72
CPU threads: 4; OS: Windows 6.3; UI render: default; 
Locale: nl-NL (nl_NL); Calc: CL
also in
Versie: 4.4.7.2 
Build ID: f3153a8b245191196a4b6b9abd1d0da16eead600
Locale: nl_NL

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Changes to 'refs/tags/libreoffice-7.5.0.2'

[Christian Lohmaier (via logerrit)]

Tag 'libreoffice-7.5.0.2' created by Christian Lohmaier 
 at 2023-01-12 21:06 +

Tag libreoffice-7.5.0.2
-BEGIN PGP SIGNATURE-

iQIzBAABCAAdFiEEwoOeytlAj76VMcPp9DSh76/urqMFAmPAdkkACgkQ9DSh76/u
rqNDxBAAvbemCF9kRoPEpA9FNUBWucBs1Jm+gv0Mwt0yOsj8L6/H2it86ur4LiBT
cjP1zC03HMk1mwSVWqcW6raCoE6wJtW9Lt34B8VPG0ze9TYhDLF3qCRmQVn8Oa5B
nkbBwGvPSEAGWhDvrYGiqA3xM4w8Dgz7QPHHdkmCSL/7Q1HpZIII8FIWNPL81uck
lDJX3zhcy1LKU/SaD4uA22F9vfwG2gaAR3Mwd9Az3GJAqXw7JEwHoVAbM5nsd/uX
XdpuEraWwc49UaYqtzj8OTGoC6VWnvusg/L2UmZDhsNaeCeicACOFCVB5MyuHwUH
BFxaoNIWCcQKBWkxPJZiFZhsDoZpowGX9rVZJOinnn/mXd8AFwRAJlTVZFFmcpbv
+AILcANWiy+oCvANRJOwdVYjIznYQZ8jDOLNgR6hlIMHm6ABnL8Z1lkiN/h+TDXe
xRQ6xT3pDtrLMxK5EEgIE34oT/aWT4k74UDWeGsgdVVliuJywIqRvD+qprnDWTo4
utZ5qsFUyhfZohJQhClAfH1WxxqdeV+z5XhV4m0S8B+f7oQutqCA6eTNQLv64Xvl
+uBV3zRxOJ3L4BXLpaAXLh39AEJz7TI8cK4cLJQzBcZsTJGKR+p7f4JrYcsQrcWC
+vsC1Eal0jS1MeysVk+qC7TjIcmu+dUv0U9LH3ow+O0pD/wHnwU=
=lOiw
-END PGP SIGNATURE-

Changes since libreoffice-7-5-branch-point-300:
---
 0 files changed
---

[Libreoffice-commits] translations.git: Changes to 'refs/tags/libreoffice-7.5.0.2'

[Christian Lohmaier (via logerrit)]

Tag 'libreoffice-7.5.0.2' created by Christian Lohmaier 
 at 2023-01-12 21:06 +

Tag libreoffice-7.5.0.2
-BEGIN PGP SIGNATURE-

iQIzBAABCAAdFiEEwoOeytlAj76VMcPp9DSh76/urqMFAmPAdkkACgkQ9DSh76/u
rqPcwQ/+OcKoAwnqXSa6IbFSPr79g9+0GeXoGvc/EfkeGRUhLm9wCl/C1x9OZERe
PCBBUTRJmHJvVZn2dIOEKKYRgKZb3aMUSjCSGQU2TqiEclZaOUBBwtS2d2nnOfbN
wXgwqP+JFQoE3PAa7946LjazbuCfLiP7B2OaotDxuqAJhmuK0f3WCTvScRpmfP7f
SQP2DlvgT95TzSvROctAev7sQIvbnrp3cNyfj4CPvOb1a3q8ITzk/wyU3m0Y6N7B
kNyoXGEAltY3kr4jOvk0y16j77B9NxTpkP97GInpl9Hzb0Dy8wc/fUVMBfpRlM+p
Ghagfp175dB7maYO7RZP4M/SU9h6iqecA5NXWDhzH9NmKJ0XTxynuuh57HxoD4nG
Pq/ZMHYganqEiQiYRUiW0PJwsaQh8Fv7O5pgQCWgdi6K41QRue7klHRmRt5mc0jk
5D9jTFXHgNYLZ9/KoFZtYc31WHtlkcvIZ30z5lAJcuSU5AZJYzX4p8I4oTpVw+eX
XVExGlIyk8iujrA9YldlBxE1xyiuqkvkNwJ53FACM0LACfoFTabMdBrLEJuZOGsh
xkr59VsQlAUC2XOKVd4ZqSIlvIOHmvPdI6JQvifiz5JlteCKViOywBNU4guRSok2
E3itoNHOs0RtMhBe8aIhWhvh1lizCR/x0b/ahtDI4FvOFp/EP5g=
=EErA
-END PGP SIGNATURE-

Changes since libreoffice-7-5-branch-point-13:
---
 0 files changed
---

[Libreoffice-commits] help.git: Changes to 'refs/tags/libreoffice-7.5.0.2'

[Christian Lohmaier (via logerrit)]

Tag 'libreoffice-7.5.0.2' created by Christian Lohmaier 
 at 2023-01-12 21:06 +

Tag libreoffice-7.5.0.2
-BEGIN PGP SIGNATURE-

iQIzBAABCAAdFiEEwoOeytlAj76VMcPp9DSh76/urqMFAmPAdkkACgkQ9DSh76/u
rqO/UA/+IsPZynMv1KI5wmnpzv/c0DetKdFvDIVI1YLCPwCDl2B1A4v/kTEItYYH
jp/wr1hWPafMv8Tkq6nfouvtq+rdQ+ozHPmd56TDXgTAoIFFx6KFEhWI25QWpPfn
ncPUBE94j5hq9RMLO3mUw6OgPuL0IUn/Ec14tugryZRgAUGZhit10fRkIQlzy6da
A4VbAegSAuAdINWt1wK65gVFG9fL2r9EctwIJA5liD34Ykue1Ddy2E9hFQSt/2a/
CwzyhuyQFWmb9edrzGrG3a53VsQlZpDaWOC59ixM8oDUoHcqvvvJxpKFm4vOndb6
tC2PwP+i5ecgDpj/mR0z4H3X8EJ5Hzsl3Qmms0a6pzF7STmAgUZtxwbv5uJPTv0R
uhOI9t1yPBY/8nuB1EjYKuZdGL6A0rOgnneumZFrSI9p8suC0AgsxuA21kiseZ/9
dG0Lw+BONbYxnZHEsS0DkR93jMr3KK5IE5YNMIHQ8Jv0btUyCJCfrWp6XlZFWheI
VDUgwFAaqd65xsLG7gwFL/bmC/kp7AHVfdkud9XVC/mOvtA3RzDX6xXKrOSqw8bF
kFrFrz9XxJ9GjFzd4iGMw5GcGvNvTlIKkEoQ6q+D15G/dM6MZpQJtST0lAkGHonl
aQ8YEoWQGB/L+UpgO7tR6xK7UCq3N3neAmosEinrTg3oocba31o=
=Z43D
-END PGP SIGNATURE-

Changes since libreoffice-7-5-branch-point-23:
---
 0 files changed
---

[Libreoffice-commits] dictionaries.git: Changes to 'refs/tags/libreoffice-7.5.0.2'

[Christian Lohmaier (via logerrit)]

Tag 'libreoffice-7.5.0.2' created by Christian Lohmaier 
 at 2023-01-12 21:06 +

Tag libreoffice-7.5.0.2
-BEGIN PGP SIGNATURE-

iQIzBAABCAAdFiEEwoOeytlAj76VMcPp9DSh76/urqMFAmPAdkQACgkQ9DSh76/u
rqMvdw//UTOu7rNxJ/qXSMmuqWggkldi0FA8oRLM5hoRHgXdZHIFeTLyqB8t9hQK
+LS8SKQ5s70aTzvcEGlVBYOsgzFi44fTHc8GmPT/aftjWMOHHwuCY2mJMbH8jqFV
uS0Zvao0ZXlkAg6s2ihGYRORmoeniRXxWoJZyvU/iL/Io7Mwoo3NAt1ZhK23NcCV
ILVjdKkqkDBEKUCaU4NJNOOasZRCi9ahws9uQnV5SdocnSsqYWjfFd5F/FQzPSPk
+ZDGOSuR5ksqrgQETodzo7fELluHdbjwtOnsWfkF8t37+/oH2YgjUgGYvE+VdUrC
oxRFRaaVQ9n3uzOu5AG4iFjOj6TTsj/x2VZk7ixKz1IyGfX21xIcEyzKwCfRFofZ
tGM7hGuN6HhfXmctv9ISp8bEh8/FsJ4k72ZWu7wnYTmzv454i4WulGygyAZNZVC8
edM80RfLF7EDK1BB8JRn43dKHSPA7OG+2kPlfF0slNuoPPUYNtXwNDfxDeLlIuIn
kHfmLs3kyFW2fZAsy/pFkiqciF+X5+1vYSOomHRCK2AxcvUO4lcFnPSyfib3FRS+
i1qcxrE4dJwdkwYDl52/NMco4bw0xDwGBg5clMGxYX8IZbm/nW2YP9wMQVNiwkO9
X9crXboYN4WJKCz5suWC78uM3W3WxUHxKQRN7n/VzGrsJmUwH3c=
=tv1t
-END PGP SIGNATURE-

Changes since libreoffice-7-5-branch-point-3:
---
 0 files changed
---

[Libreoffice-commits] core.git: Branch 'libreoffice-7-5-0' - configure.ac

[Christian Lohmaier (via logerrit)]

 configure.ac |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 80dc634ea68a5f2cbdcd344042de262bfd033a3b
Author: Christian Lohmaier 
AuthorDate: Thu Jan 12 22:06:38 2023 +0100
Commit: Christian Lohmaier 
CommitDate: Thu Jan 12 22:06:38 2023 +0100

bump product version to 7.5.0.2.0+

Change-Id: I7f1048d229a0dadfa0a78d7208826c264d261b03

diff --git a/configure.ac b/configure.ac
index b31c6b7f68da..db37f61449ec 100644
--- a/configure.ac
+++ b/configure.ac
@@ -9,7 +9,7 @@ dnl in order to create a configure script.
 # several non-alphanumeric characters, those are split off and used only for 
the
 # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no 
idea.
 
-AC_INIT([LibreOffice],[7.5.0.1.0+],[],[],[http://documentfoundation.org/])
+AC_INIT([LibreOffice],[7.5.0.2.0+],[],[],[http://documentfoundation.org/])
 
 dnl libnumbertext needs autoconf 2.68, but that can pick up autoconf268 just 
fine if it is installed
 dnl whereas aclocal (as run by autogen.sh) insists on using autoconf and fails 
hard

[Libreoffice-bugs] [Bug 131386] Hidden linebreaks are ignored on creating pdf from rtf document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=131386

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||2872

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - configure.ac

[Christian Lohmaier (via logerrit)]

 configure.ac |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit c8851caa9bc3fe7965cbf4a19662d14e9f61eb42
Author: Christian Lohmaier 
AuthorDate: Thu Jan 12 22:05:01 2023 +0100
Commit: Christian Lohmaier 
CommitDate: Thu Jan 12 22:05:01 2023 +0100

bump product version to 7.5.1.0.0+

Change-Id: I94eae5b5468787b2b57248c3cff39fb35b62f511

diff --git a/configure.ac b/configure.ac
index b31c6b7f68da..b6d09d4a8b83 100644
--- a/configure.ac
+++ b/configure.ac
@@ -9,7 +9,7 @@ dnl in order to create a configure script.
 # several non-alphanumeric characters, those are split off and used only for 
the
 # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no 
idea.
 
-AC_INIT([LibreOffice],[7.5.0.1.0+],[],[],[http://documentfoundation.org/])
+AC_INIT([LibreOffice],[7.5.1.0.0+],[],[],[http://documentfoundation.org/])
 
 dnl libnumbertext needs autoconf 2.68, but that can pick up autoconf268 just 
fine if it is installed
 dnl whereas aclocal (as run by autogen.sh) insists on using autoconf and fails 
hard

[Libreoffice-commits] core.git: Changes to 'libreoffice-7-5-0'

[Christian Lohmaier (via logerrit)]

New branch 'libreoffice-7-5-0' available with the following commits:
commit 8fe627e849953dec3b7fb17aceb34b8613dc1c12
Author: Christian Lohmaier 
Date:   Thu Jan 12 22:04:05 2023 +0100

Branch libreoffice-7-5-0

This is 'libreoffice-7-5-0' - the stable branch for the 7.5.0 release.
Only very safe changes, reviewed by three people are allowed.

If you want to commit more complicated fix for the next 7.5.x release,
please use the 'libreoffice-7-5' branch.

If you want to build something cool, unstable, and risky, use master.

[Libreoffice-commits] translations.git: Changes to 'libreoffice-7-5-0'

[Christian Lohmaier (via logerrit)]

New branch 'libreoffice-7-5-0' available with the following commits:
commit 5c532ddbf43503991cde374bd430544d5d32efee
Author: Christian Lohmaier 
Date:   Thu Jan 12 22:03:54 2023 +0100

Branch libreoffice-7-5-0

This is 'libreoffice-7-5-0' - the stable branch for the 7.5.0 release.
Only very safe changes, reviewed by three people are allowed.

If you want to commit more complicated fix for the next 7.5.x release,
please use the 'libreoffice-7-5' branch.

If you want to build something cool, unstable, and risky, use master.

Change-Id: I18c19f85bae0e0150e403f8699fa755aec38c291

[Libreoffice-commits] help.git: Changes to 'libreoffice-7-5-0'

[Christian Lohmaier (via logerrit)]

New branch 'libreoffice-7-5-0' available with the following commits:
commit abdc1b515185991ca88e907962ba3dcd1ce4aee8
Author: Christian Lohmaier 
Date:   Thu Jan 12 22:03:54 2023 +0100

Branch libreoffice-7-5-0

This is 'libreoffice-7-5-0' - the stable branch for the 7.5.0 release.
Only very safe changes, reviewed by three people are allowed.

If you want to commit more complicated fix for the next 7.5.x release,
please use the 'libreoffice-7-5' branch.

If you want to build something cool, unstable, and risky, use master.

Change-Id: Idf24caa7c0fd8b93b623d8f017ff8a12e5fd3ff0

[Libreoffice-commits] dictionaries.git: Changes to 'libreoffice-7-5-0'

[Christian Lohmaier (via logerrit)]

New branch 'libreoffice-7-5-0' available with the following commits:
commit 998bb33776cfc81bd02ae6d35803511193b79bb4
Author: Christian Lohmaier 
Date:   Thu Jan 12 22:03:54 2023 +0100

Branch libreoffice-7-5-0

This is 'libreoffice-7-5-0' - the stable branch for the 7.5.0 release.
Only very safe changes, reviewed by three people are allowed.

If you want to commit more complicated fix for the next 7.5.x release,
please use the 'libreoffice-7-5' branch.

If you want to build something cool, unstable, and risky, use master.

Change-Id: I45397a3f303dd8e32bc3dede0327d48cff39356a

[Libreoffice-commits] core.git: sc/qa

[Xisco Fauli (via logerrit)]

 sc/qa/unit/uicalc/uicalc.cxx |   12 
 1 file changed, 12 deletions(-)

New commits:
commit c925ad4b1be66bf9cb94fbda0873c1da26f28aa1
Author: Xisco Fauli 
AuthorDate: Thu Jan 12 14:18:02 2023 +0100
Commit: Xisco Fauli 
CommitDate: Thu Jan 12 20:47:37 2023 +

CppunitTest_sc_uicalc: remove leftover

from commit 3756e3145c39ace4454d2569709c2c0d64ad389a
"CppunitTest_sc_uicalc: combine external reference tests"

Change-Id: I0c34ae8bd1668aa6ecc02d420aa767f7d631bef4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145404
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 

diff --git a/sc/qa/unit/uicalc/uicalc.cxx b/sc/qa/unit/uicalc/uicalc.cxx
index 4b424308593a..767bc23e740b 100644
--- a/sc/qa/unit/uicalc/uicalc.cxx
+++ b/sc/qa/unit/uicalc/uicalc.cxx
@@ -131,18 +131,6 @@ void ScUiCalcTest::insertNewSheet(ScDocument& rDoc)
 CPPUNIT_ASSERT_EQUAL(static_cast(nTabs + 1), rDoc.GetTableCount());
 }
 
-CPPUNIT_TEST_FIXTURE(ScUiCalcTest, testTdf100847)
-{
-createScDoc();
-
-// Save the document
-save("calc8");
-
-// Open a new document
-createScDoc();
-getScDoc();
-}
-
 CPPUNIT_TEST_FIXTURE(ScUiCalcTest, 
testTdf142854_GridVisibilityImportXlsxInHeadlessMode)
 {
 // Tests are running in Headless mode

[Libreoffice-bugs] [Bug 103250] Autocorrect does not recognise Greek punctuation characters « and »

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103250

Jordi  changed:

   What|Removed |Added

Version|5.0.5.2 release |Inherited From OOo

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103250] Autocorrect does not recognise Greek punctuation characters « and »

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103250

--- Comment #6 from Jordi  ---
Version: 7.4.2.3 (x64) / LibreOffice Community
Build ID: 382eef1f22670f7f4118c8c2dd222ec7ad009daf
CPU threads: 12; OS: Windows 10.0 Build 19044; UI render: default; VCL: win
Locale: en-AU (en_AU); UI: en-US
Calc: CL

Still happening...

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104468] [META] DOCX (OOXML) image-related issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104468

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

 Depends on||98823


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=98823
[Bug 98823] FILEOPEN: 3-pages .docx with images in table shown incorrect
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 98823] FILEOPEN: 3-pages .docx with images in table shown incorrect

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98823

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

Summary|FILEOPEN: 3-pages .docx |FILEOPEN: 3-pages .docx
   |with table shown incorrect, |with images in table shown
   |hangs   |incorrect
 Blocks||104468


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=104468
[Bug 104468] [META] DOCX (OOXML) image-related issues
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 127071] FILEOPEN DOCX: Image moves as Below Line is read as From bottom to Line of text (comment 7)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127071

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=98
   ||823

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 98823] FILEOPEN: 3-pages .docx with table shown incorrect, hangs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98823

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||7071

--- Comment #13 from Gabor Kelemen (allotropia)  ---
Another issue is the vertical positioning of images is defined as below Line,
which is incorrectly imported (as Writer does not have exactly that kind of
positioning), see bug 127071

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - vcl/qa

[Stephan Bergmann (via logerrit)]

 vcl/qa/cppunit/text.cxx |   13 ++---
 1 file changed, 10 insertions(+), 3 deletions(-)

New commits:
commit c21cf015dc913713dcd4c343e2562c80b6469303
Author: Stephan Bergmann 
AuthorDate: Thu Jan 12 16:42:39 2023 +0100
Commit: Christian Lohmaier 
CommitDate: Thu Jan 12 20:24:18 2023 +

Fix VclTextTest with colorized antialiasing

The Flathub build for


"Merge pull request #206 from flathub/lo-7.4.4" on 2023-01-12 at
 consistently 
failed for
both aarch64 and x86_64 builds with

> text.cxx:260:Assertion
> Test name: VclTextTest::testSimpleText
> double equality assertion failed
> - Expected: 28
> - Actual  : -1
> - Delta   : 2

during CppunitTest_vcl_text.  The reason (as seen with a temporary build 
setting
mbExportBitmap = true and looking at the resulting
workdir/CppunitTest/vcl_text.test.core/simple-text-36-50pct.png) is that the
stem of the "L" doesn't contain any COL_BLACK pixels, so
getCharacterLeftSideHeight returns early with -1.  The stem is drawn as 
three
vertical lines of pixels, a yellow (RGB 255/195/111), a black-ish (RGB 
23/0/0),
and a blue (RGB 31/155/199) one.  In comparison, when running the same test 
on
Fedora 37, the three vertical lines use gray-scale instead of colors,
RGB 195/195/195, then true black (RGB 0/0/0), and RGB 115/115/115.

An earlier test build of
 "Update to
LibreOffice 7.4.4" for the same libreoffice-7.4.4.2 tag on 2023-01-02 at
 succeeded, so I 
assume
that it must be some change in the meantime to the underlying
org.fedoraproject.sdk//22.08 that started to cause colorized antialiasing 
here.

Change-Id: I7059268eabcfe8e501d0be4f38746707def7bb35
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145411
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 
(cherry picked from commit 933519505aee0e91ca99af0ed860e4a0f148f922)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145313
Reviewed-by: Christian Lohmaier 

diff --git a/vcl/qa/cppunit/text.cxx b/vcl/qa/cppunit/text.cxx
index 69365f98a00e..833022ee2204 100644
--- a/vcl/qa/cppunit/text.cxx
+++ b/vcl/qa/cppunit/text.cxx
@@ -99,6 +99,13 @@ public:
 CPPUNIT_TEST_SUITE_END();
 };
 
+// Avoid issues when colorized antialiasing generates slightly tinted rather 
than truly black
+// pixels:
+static bool isBlack(Color col)
+{
+return col.GetRed() < 25 && col.GetGreen() < 25 && col.GetBlue() < 25;
+}
+
 // Return pixel width of the base of the given character located above
 // the starting position.
 // In other words, go up in y direction until a black pixel is found,
@@ -109,7 +116,7 @@ static tools::Long getCharacterBaseWidth(VirtualDevice* 
device, const Point& sta
 Bitmap bitmap = device->GetBitmap(Point(), device->GetOutputSizePixel());
 Bitmap::ScopedReadAccess access(bitmap);
 tools::Long y = start.Y();
-while (y >= 0 && access->GetColor(y, start.X()) != COL_BLACK)
+while (y >= 0 && !isBlack(access->GetColor(y, start.X(
 --y;
 if (y < 0)
 return -1;
@@ -128,7 +135,7 @@ static tools::Long getCharacterTopWidth(VirtualDevice* 
device, const Point& star
 Bitmap bitmap = device->GetBitmap(Point(), device->GetOutputSizePixel());
 Bitmap::ScopedReadAccess access(bitmap);
 tools::Long y = start.Y();
-while (y < bitmap.GetSizePixel().Height() && access->GetColor(y, 
start.X()) != COL_BLACK)
+while (y < bitmap.GetSizePixel().Height() && !isBlack(access->GetColor(y, 
start.X(
 ++y;
 if (y >= bitmap.GetSizePixel().Height())
 return -1;
@@ -149,7 +156,7 @@ static tools::Long 
getCharacterLeftSideHeight(VirtualDevice* device, const Point
 Bitmap bitmap = device->GetBitmap(Point(), device->GetOutputSizePixel());
 Bitmap::ScopedReadAccess access(bitmap);
 tools::Long x = start.X();
-while (x < bitmap.GetSizePixel().Width() && access->GetColor(start.Y(), x) 
!= COL_BLACK)
+while (x < bitmap.GetSizePixel().Width() && 
!isBlack(access->GetColor(start.Y(), x)))
 ++x;
 if (x >= bitmap.GetSizePixel().Width())
 return -1;

[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - desktop/source extensions/source

[Julien Nabet (via logerrit)]

 desktop/source/app/updater.cxx  |6 +++---
 extensions/source/update/check/download.cxx |6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)

New commits:
commit fc4b3cf771499b7f333ed7ec4779d0cfaa2c875a
Author: Julien Nabet 
AuthorDate: Wed Jan 11 11:28:27 2023 +0100
Commit: Christian Lohmaier 
CommitDate: Thu Jan 12 20:22:41 2023 +

Curl:CURLOPT_REDIR_PROTOCOLS(_STR): use only "https", not "http"

Change-Id: If615503b598f6823d7978f12e666832c82b63ece
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145334
Tested-by: Jenkins
Reviewed-by: Michael Stahl 
(cherry picked from commit e78859005b632860c9464335fdf6836c4fd41807)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145310
Reviewed-by: Christian Lohmaier 

diff --git a/desktop/source/app/updater.cxx b/desktop/source/app/updater.cxx
index f74dfbeceb6e..5fb18dfad0bf 100644
--- a/desktop/source/app/updater.cxx
+++ b/desktop/source/app/updater.cxx
@@ -562,11 +562,11 @@ std::string download_content(const OString& rURL, bool 
bFile, OUString& rHash)
 headerlist = curl_slist_append(headerlist, buf);
 curl_easy_setopt(curl.get(), CURLOPT_HTTPHEADER, headerlist);
 curl_easy_setopt(curl.get(), CURLOPT_FOLLOWLOCATION, 1); // follow 
redirects
-// only allow redirect to http:// and https://
+// only allow redirect to https://
 #if (LIBCURL_VERSION_MAJOR > 7) || (LIBCURL_VERSION_MAJOR == 7 && 
LIBCURL_VERSION_MINOR >= 85)
-curl_easy_setopt(curl.get(), CURLOPT_REDIR_PROTOCOLS_STR, "http,https");
+curl_easy_setopt(curl.get(), CURLOPT_REDIR_PROTOCOLS_STR, "https");
 #else
-curl_easy_setopt(curl.get(), CURLOPT_REDIR_PROTOCOLS, CURLPROTO_HTTP | 
CURLPROTO_HTTPS);
+curl_easy_setopt(curl.get(), CURLOPT_REDIR_PROTOCOLS, CURLPROTO_HTTPS);
 #endif
 
 std::string response_body;
diff --git a/extensions/source/update/check/download.cxx 
b/extensions/source/update/check/download.cxx
index 4ba5863930ba..ba371bdee570 100644
--- a/extensions/source/update/check/download.cxx
+++ b/extensions/source/update/check/download.cxx
@@ -232,11 +232,11 @@ static bool curl_run(std::u16string_view rURL, OutData& 
out, const OString& aPro
 
 // enable redirection
 (void)curl_easy_setopt(pCURL, CURLOPT_FOLLOWLOCATION, 1);
-// only allow redirect to http:// and https://
+// only allow redirect to https://
 #if (LIBCURL_VERSION_MAJOR > 7) || (LIBCURL_VERSION_MAJOR == 7 && 
LIBCURL_VERSION_MINOR >= 85)
-curl_easy_setopt(pCURL, CURLOPT_REDIR_PROTOCOLS_STR, "http,https");
+curl_easy_setopt(pCURL, CURLOPT_REDIR_PROTOCOLS_STR, "https");
 #else
-curl_easy_setopt(pCURL, CURLOPT_REDIR_PROTOCOLS, CURLPROTO_HTTP | 
CURLPROTO_HTTPS);
+curl_easy_setopt(pCURL, CURLOPT_REDIR_PROTOCOLS, CURLPROTO_HTTPS);
 #endif
 
 // write function

[Libreoffice-commits] core.git: sw/source

[Jim Raykowski (via logerrit)]

 sw/source/uibase/inc/conttree.hxx  |5 
 sw/source/uibase/utlui/content.cxx |  670 ++---
 2 files changed, 335 insertions(+), 340 deletions(-)

New commits:
commit d784da48de7c9ecccf39cea55f49d8d4758cab58
Author: Jim Raykowski 
AuthorDate: Sun Jan 1 17:47:11 2023 -0900
Commit: Jim Raykowski 
CommitDate: Thu Jan 12 20:22:26 2023 +

SwNavigator: Improve mouse move handler for bringing objects to

attention in the document view

Fixes crash that happens in SalInstanceTreeView iter_compare when the
mouse enters the content tree at a point that has no tree entry and
is then moved over an entry.

Moves code to bring entry content to attention in the document view
from the mouse move handler to it's own function.

Renames the overlay timer handler function and moves it to the area
of the code having related functions.

Checks added for visible content and if the type has any content to
bring to attention.

Change-Id: I381eed6ffcf7ddb095c4c09650578a7f7fd874b0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145168
Tested-by: Jenkins
Reviewed-by: Jim Raykowski 

diff --git a/sw/source/uibase/inc/conttree.hxx 
b/sw/source/uibase/inc/conttree.hxx
index 1e6bacbcd4db..b4f352bb6950 100644
--- a/sw/source/uibase/inc/conttree.hxx
+++ b/sw/source/uibase/inc/conttree.hxx
@@ -136,8 +136,9 @@ class SwContentTree final : public SfxListener
 std::unique_ptr m_xOverlayCompareEntry;
 std::unique_ptr m_xOverlayObject;
 
-void OverlayObject(std::vector&& aRanges);
+void OverlayObject(std::vector&& aRanges = {});
 
+void BringEntryToAttention(const weld::TreeIter& rEntry);
 void BringFramesToAttention(const std::vector& 
rFrameFormats);
 void BringBookmarksToAttention(const std::vector& rNames);
 void BringURLFieldsToAttention(const SwGetINetAttrs& rINetAttrsArr);
@@ -202,7 +203,7 @@ class SwContentTree final : public SfxListener
 DECL_LINK(QueryTooltipHdl, const weld::TreeIter&, OUString);
 DECL_LINK(DragBeginHdl, bool&, bool);
 DECL_LINK(TimerUpdate, Timer *, void);
-DECL_LINK(m_aOverlayObjectDelayTimerHdl, Timer *, void);
+DECL_LINK(OverlayObjectDelayTimerHdl, Timer *, void);
 DECL_LINK(MouseMoveHdl, const MouseEvent&, bool);
 
 public:
diff --git a/sw/source/uibase/utlui/content.cxx 
b/sw/source/uibase/utlui/content.cxx
index 7b71b5acb08d..d76b1103991e 100644
--- a/sw/source/uibase/utlui/content.cxx
+++ b/sw/source/uibase/utlui/content.cxx
@@ -1092,7 +1092,6 @@ 
SwContentTree::SwContentTree(std::unique_ptr xTreeView, SwNaviga
 , m_bIsLastReadOnly(false)
 , m_bIsOutlineMoveable(true)
 , m_bViewHasChanged(false)
-, m_xOverlayCompareEntry(m_xTreeView->make_iterator())
 {
 m_xTreeView->set_size_request(m_xTreeView->get_approximate_digit_width() * 
30,
   m_xTreeView->get_text_height() * 14);
@@ -1133,7 +1132,7 @@ 
SwContentTree::SwContentTree(std::unique_ptr xTreeView, SwNaviga
 
 m_aUpdTimer.SetInvokeHandler(LINK(this, SwContentTree, TimerUpdate));
 m_aUpdTimer.SetTimeout(1000);
-m_aOverlayObjectDelayTimer.SetInvokeHandler(LINK(this, SwContentTree, 
m_aOverlayObjectDelayTimerHdl));
+m_aOverlayObjectDelayTimer.SetInvokeHandler(LINK(this, SwContentTree, 
OverlayObjectDelayTimerHdl));
 m_aOverlayObjectDelayTimer.SetTimeout(500);
 }
 
@@ -1153,8 +1152,21 @@ IMPL_LINK(SwContentTree, MouseMoveHdl, const 
MouseEvent&, rMEvt, bool)
 {
 if (m_eState == State::HIDDEN)
 return false;
-if (rMEvt.IsLeaveWindow())
+if (std::unique_ptr xEntry(m_xTreeView->make_iterator());
+m_xTreeView->get_dest_row_at_pos(rMEvt.GetPosPixel(), 
xEntry.get(), false, false) &&
+!rMEvt.IsLeaveWindow())
+{
+if (!m_xOverlayCompareEntry)
+
m_xOverlayCompareEntry.reset(m_xTreeView->make_iterator().release());
+else if (m_xTreeView->iter_compare(*xEntry, *m_xOverlayCompareEntry) 
== 0)
+return false; // The entry under the mouse has not changed.
+m_xTreeView->copy_iterator(*xEntry, *m_xOverlayCompareEntry);
+BringEntryToAttention(*xEntry);
+}
+else
 {
+if (m_xOverlayCompareEntry)
+m_xOverlayCompareEntry.reset();
 m_aOverlayObjectDelayTimer.Stop();
 if (m_xOverlayObject && m_xOverlayObject->getOverlayManager())
 {
@@ -1162,296 +1174,6 @@ IMPL_LINK(SwContentTree, MouseMoveHdl, const 
MouseEvent&, rMEvt, bool)
 m_xOverlayObject.reset();
 }
 }
-else if (std::unique_ptr 
xEntry(m_xTreeView->make_iterator());
-m_xTreeView->get_dest_row_at_pos(rMEvt.GetPosPixel(), 
xEntry.get(), false, false))
-{
-// Remove the overlay object if the pointer is over a different entry 
than the last time
-// it was here. Guard against doing the iter_compare when entering the 
window to work
-// around a bug that 

[Libreoffice-bugs] [Bug 134114] FILEOPEN DOCX: Option "Allow overlap" is wrongly not set when opening docx document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=134114

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=98
   ||823

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 98823] FILEOPEN: 3-pages .docx with table shown incorrect, hangs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98823

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||4114

--- Comment #12 from Gabor Kelemen (allotropia)  ---
One issue I see is that the images have the Allow overlap setting turned off in
Word, but turned on in Writer. This is bug 134114.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: vcl/inc vcl/win

[Caolán McNamara (via logerrit)]

 vcl/inc/win/salframe.h|1 +
 vcl/inc/win/salinst.h |1 -
 vcl/win/gdi/salnativewidgets-luna.cxx |4 
 3 files changed, 5 insertions(+), 1 deletion(-)

New commits:
commit 8ab24f26626a65e1ce9e1ff8c4eb75a20e4b7629
Author: Caolán McNamara 
AuthorDate: Thu Jan 12 16:36:56 2023 +
Commit: Caolán McNamara 
CommitDate: Thu Jan 12 20:06:19 2023 +

tdf#152994 only query dark mode in Windows >= 10.0.18362

Change-Id: I8d8bd368d9d1ee38dac96dd369484ec74ce4835a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145414
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/vcl/inc/win/salframe.h b/vcl/inc/win/salframe.h
index bbf3506a723f..dedac6906467 100644
--- a/vcl/inc/win/salframe.h
+++ b/vcl/inc/win/salframe.h
@@ -148,6 +148,7 @@ public:
 void ImplSalGetWorkArea( HWND hWnd, RECT *pRect, const RECT *pParentRect );
 
 bool UseDarkMode();
+bool OSSupportsDarkMode();
 
 // get foreign key names
 namespace vcl_sal {
diff --git a/vcl/inc/win/salinst.h b/vcl/inc/win/salinst.h
index 35f2365fb166..7af6e007b562 100644
--- a/vcl/inc/win/salinst.h
+++ b/vcl/inc/win/salinst.h
@@ -85,7 +85,6 @@ public:
 SalFrame* ImplSalCreateFrame( WinSalInstance* pInst, HWND hWndParent, 
SalFrameStyleFlags nSalFrameStyle );
 SalObject* ImplSalCreateObject( WinSalInstance* pInst, WinSalFrame* pParent );
 HWND ImplSalReCreateHWND( HWND hWndParent, HWND oldhWnd, bool bAsChild );
-bool OSSupportsDarkMode();
 
 #endif // INCLUDED_VCL_INC_WIN_SALINST_H
 
diff --git a/vcl/win/gdi/salnativewidgets-luna.cxx 
b/vcl/win/gdi/salnativewidgets-luna.cxx
index e3811020a42e..b2c71bf51b78 100644
--- a/vcl/win/gdi/salnativewidgets-luna.cxx
+++ b/vcl/win/gdi/salnativewidgets-luna.cxx
@@ -398,6 +398,10 @@ static bool implDrawNativeMenuMark(HDC hDC, HTHEME hTheme, 
RECT rc, ControlPart
 
 bool UseDarkMode()
 {
+static bool bOSSupportsDarkMode = OSSupportsDarkMode();
+if (!bOSSupportsDarkMode)
+false;
+
 HINSTANCE hUxthemeLib = LoadLibraryExW(L"uxtheme.dll", nullptr, 
LOAD_LIBRARY_SEARCH_SYSTEM32);
 if (!hUxthemeLib)
 return false;

[Libreoffice-bugs] [Bug 152994] Daily Screenshot Build failure

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=152994

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.6.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: 2 commits - extensions/source

[Caolán McNamara (via logerrit)]

 extensions/source/scanner/sanedlg.cxx |   68 --
 1 file changed, 40 insertions(+), 28 deletions(-)

New commits:
commit 019c49ec96afc3ea0c50e99881f5a6324b4ec732
Author: Caolán McNamara 
AuthorDate: Thu Jan 12 11:35:54 2023 +
Commit: Caolán McNamara 
CommitDate: Thu Jan 12 20:05:09 2023 +

draw selection bounds without using RasterOp::Invert

Change-Id: I65fa68bbd8ff40c0e324851376dd8a8a1614ac99
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145396
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/extensions/source/scanner/sanedlg.cxx 
b/extensions/source/scanner/sanedlg.cxx
index 0d27a802cef0..35f2b37d63c7 100644
--- a/extensions/source/scanner/sanedlg.cxx
+++ b/extensions/source/scanner/sanedlg.cxx
@@ -24,6 +24,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -43,28 +44,52 @@
 
 namespace {
 
-void DrawRectangles(vcl::RenderContext& rRenderContext, Point const & rUL, 
Point const & rBR)
+void DrawRect(vcl::RenderContext& rRenderContext, const tools::Rectangle& 
rRect)
 {
-int nMiddleX, nMiddleY;
-Point aBL, aUR;
+tools::Rectangle aRect(rRect);
+rRenderContext.SetFillColor(COL_BLACK);
+rRenderContext.SetLineColor();
+rRenderContext.DrawRect(aRect);
+aRect.Move(1, 1);
+aRect.AdjustRight(-2);
+aRect.AdjustBottom(-2);
+rRenderContext.SetFillColor();
+rRenderContext.SetLineColor(COL_WHITE);
+rRenderContext.DrawRect(aRect);
+}
 
-aUR = Point(rBR.X(), rUL.Y());
-aBL = Point(rUL.X(), rBR.Y());
-nMiddleX = (rBR.X() - rUL.X()) / 2 + rUL.X();
-nMiddleY = (rBR.Y() - rUL.Y()) / 2 + rUL.Y();
+void DrawRectangles(vcl::RenderContext& rRenderContext, Point const & rUL, 
Point const & rBR)
+{
+Point aUR(rBR.X(), rUL.Y());
+Point aBL(rUL.X(), rBR.Y());
+int nMiddleX = (rBR.X() - rUL.X()) / 2 + rUL.X();
+int nMiddleY = (rBR.Y() - rUL.Y()) / 2 + rUL.Y();
 
+rRenderContext.SetLineColor(COL_WHITE);
 rRenderContext.DrawLine(rUL, aBL);
 rRenderContext.DrawLine(aBL, rBR);
 rRenderContext.DrawLine(rBR, aUR);
 rRenderContext.DrawLine(aUR, rUL);
-rRenderContext.DrawRect(tools::Rectangle(rUL, 
Size(RECT_SIZE_PIX,RECT_SIZE_PIX)));
-rRenderContext.DrawRect(tools::Rectangle(aBL, Size(RECT_SIZE_PIX, 
-RECT_SIZE_PIX)));
-rRenderContext.DrawRect(tools::Rectangle(rBR, Size(-RECT_SIZE_PIX, 
-RECT_SIZE_PIX)));
-rRenderContext.DrawRect(tools::Rectangle(aUR, Size(-RECT_SIZE_PIX, 
RECT_SIZE_PIX )));
-rRenderContext.DrawRect(tools::Rectangle(Point(nMiddleX - RECT_SIZE_PIX / 
2, rUL.Y()), Size(RECT_SIZE_PIX, RECT_SIZE_PIX)));
-rRenderContext.DrawRect(tools::Rectangle(Point(nMiddleX - RECT_SIZE_PIX / 
2, rBR.Y()), Size(RECT_SIZE_PIX, -RECT_SIZE_PIX)));
-rRenderContext.DrawRect(tools::Rectangle(Point(rUL.X(), nMiddleY - 
RECT_SIZE_PIX / 2), Size(RECT_SIZE_PIX, RECT_SIZE_PIX)));
-rRenderContext.DrawRect(tools::Rectangle(Point(rBR.X(), nMiddleY - 
RECT_SIZE_PIX / 2), Size(-RECT_SIZE_PIX, RECT_SIZE_PIX)));
+
+rRenderContext.SetLineColor(COL_BLACK);
+LineInfo aInfo(LineStyle::Dash, 1);
+aInfo.SetDistance(8);
+aInfo.SetDotLen(4);
+aInfo.SetDotCount(1);
+rRenderContext.DrawLine(rUL, aBL, aInfo);
+rRenderContext.DrawLine(aBL, rBR, aInfo);
+rRenderContext.DrawLine(rBR, aUR, aInfo);
+rRenderContext.DrawLine(aUR, rUL, aInfo);
+
+Size aSize(RECT_SIZE_PIX, RECT_SIZE_PIX);
+DrawRect(rRenderContext, tools::Rectangle(rUL, aSize));
+DrawRect(rRenderContext, tools::Rectangle(Point(aBL.X(), aBL.Y() - 
RECT_SIZE_PIX), aSize));
+DrawRect(rRenderContext, tools::Rectangle(Point(rBR.X() - RECT_SIZE_PIX, 
rBR.Y() - RECT_SIZE_PIX), aSize));
+DrawRect(rRenderContext, tools::Rectangle(Point(aUR.X() - RECT_SIZE_PIX, 
aUR.Y()), aSize));
+DrawRect(rRenderContext, tools::Rectangle(Point(nMiddleX - RECT_SIZE_PIX / 
2, rUL.Y()), aSize));
+DrawRect(rRenderContext, tools::Rectangle(Point(nMiddleX - RECT_SIZE_PIX / 
2, rBR.Y() - RECT_SIZE_PIX), aSize));
+DrawRect(rRenderContext, tools::Rectangle(Point(rUL.X(), nMiddleY - 
RECT_SIZE_PIX / 2), aSize));
+DrawRect(rRenderContext, tools::Rectangle(Point(rBR.X() - RECT_SIZE_PIX, 
nMiddleY - RECT_SIZE_PIX / 2), aSize));
 }
 
 }
@@ -1181,13 +1206,10 @@ void ScanPreview::DrawDrag(vcl::RenderContext& 
rRenderContext)
 if (!mbDragEnable)
 return;
 
-RasterOp eROP = rRenderContext.GetRasterOp();
-rRenderContext.SetRasterOp(RasterOp::Invert);
 rRenderContext.SetMapMode(MapMode(MapUnit::MapPixel));
 
 DrawRectangles(rRenderContext, maTopLeft, maBottomRight);
 
-rRenderContext.SetRasterOp(eROP);
 rRenderContext.SetMapMode(MapMode(MapUnit::MapAppFont));
 }
 
commit af27dabe81945b02cd31bb6d6f9d84f732c0
Author: Caolán McNamara 
AuthorDate: Thu Jan 12 09:38:05 2023 +
Commit: Caolán McNamara 
CommitDate: Thu Jan 12 20:05:00 2023 +

mbDragDrawn is always false when 

[Libreoffice-commits] core.git: lotuswordpro/source

[Caolán McNamara (via logerrit)]

 lotuswordpro/source/filter/lwpbackgroundstuff.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 13cd316bc733fbe37db105dc705b9d172aec8809
Author: Caolán McNamara 
AuthorDate: Thu Jan 12 14:50:41 2023 +
Commit: Caolán McNamara 
CommitDate: Thu Jan 12 20:03:30 2023 +

ofz#55034 Stack-buffer-overflow in vcl::bitmap::CreateFromData

since:

commit 21734247d58a6e915b058d8fa55ece949d049613
Date:   Tue Jan 10 12:56:58 2023 +0200

drop internal support for 1-bit images

the input data is still 1 bit here, even if the output will be 8 bit

Change-Id: Ib7eb301b2e62ebc61ee61ebb99e6de92c1f4931b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145410
Reviewed-by: Noel Grandin 
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 

diff --git a/lotuswordpro/source/filter/lwpbackgroundstuff.cxx 
b/lotuswordpro/source/filter/lwpbackgroundstuff.cxx
index 2c2fcf109504..dc3f9194e094 100644
--- a/lotuswordpro/source/filter/lwpbackgroundstuff.cxx
+++ b/lotuswordpro/source/filter/lwpbackgroundstuff.cxx
@@ -114,7 +114,7 @@ std::unique_ptr 
LwpBackgroundStuff::GetFillPattern()
 GetPattern(m_nID, aPttnArray);
 
 // create bitmap object from the pattern array
-BitmapEx aBmp = vcl::bitmap::CreateFromData(aPttnArray, 8, 8, 1, 
/*nBitsPerPixel*/ 8);
+BitmapEx aBmp = vcl::bitmap::CreateFromData(aPttnArray, 8, 8, 1, 
/*nBitsPerPixel*/ 1);
 
 // create XOBitmap object from bitmap object
 XOBitmap aXOBitmap(aBmp);

[Libreoffice-bugs] [Bug 103459] [META] Sidebar UI and UX bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103459
Bug 103459 depends on bug 152921, which changed state.

Bug 152921 Summary: Sidebar deck is shown as "selected active" when closing 
with grey cross
https://bugs.documentfoundation.org/show_bug.cgi?id=152921

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sfx2/source

[Jim Raykowski (via logerrit)]

 sfx2/source/sidebar/SidebarController.cxx |   13 ++---
 1 file changed, 2 insertions(+), 11 deletions(-)

New commits:
commit dc3deffb15f6c924375b38f606eb640fe065089f
Author: Jim Raykowski 
AuthorDate: Mon Jan 9 22:16:33 2023 -0900
Commit: Jim Raykowski 
CommitDate: Thu Jan 12 20:02:05 2023 +

tdf#152921 Fix sidebar tabbar tab highlighting

Makes the highlight state of the tabbar tab behave as expected when
the sidebar is in the collapsed or expanded state. When collapsed, the
tabbar should never have a highlighted tab. When expanded, the tab in
the tabbar corrosponding to the open deck should be highlighted.

Change-Id: I0e6c54aff95b1f1e417f147070742e900fd51513
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145251
Tested-by: Jenkins
Reviewed-by: Jim Raykowski 

diff --git a/sfx2/source/sidebar/SidebarController.cxx 
b/sfx2/source/sidebar/SidebarController.cxx
index a35bb1f7488c..3546297df79c 100644
--- a/sfx2/source/sidebar/SidebarController.cxx
+++ b/sfx2/source/sidebar/SidebarController.cxx
@@ -476,6 +476,7 @@ void SidebarController::NotifyResize()
 mpCurrentDeck->setPosSizePixel(nDeckX, 0, nWidth - 
nTabBarDefaultWidth, nHeight);
 mpCurrentDeck->Show();
 mpCurrentDeck->RequestLayout();
+mpTabBar->HighlightDeck(mpCurrentDeck->GetId());
 }
 else
 mpCurrentDeck->Hide();
@@ -599,10 +600,6 @@ void SidebarController::UpdateConfigurations()
 return;
 }
 
-// Tell the tab bar to highlight the button associated
-// with the deck.
-mpTabBar->HighlightDeck(sNewDeckId);
-
 std::shared_ptr xDescriptor = 
mpResourceManager->GetDeckDescriptor(sNewDeckId);
 
 if (xDescriptor)
@@ -830,8 +827,6 @@ void SidebarController::SwitchToDeck (
 msCurrentDeckId = rDeckDescriptor.msId;
 }
 
-mpTabBar->HighlightDeck(msCurrentDeckId);
-
 // Determine the panels to display in the deck.
 ResourceManager::PanelContextDescriptorContainer aPanelContextDescriptors;
 
@@ -1255,8 +1250,7 @@ void SidebarController::RequestCloseDeck()
 mbIsDeckRequestedOpen = false;
 UpdateDeckOpenState();
 
-if (!mpCurrentDeck)
-mpTabBar->RemoveDeckHighlight();
+mpTabBar->RemoveDeckHighlight();
 }
 
 void SidebarController::RequestOpenDeck()
@@ -1376,9 +1370,6 @@ void SidebarController::UpdateDeckOpenState()
 mpParentWindow->SetStyle(mpParentWindow->GetStyle() & ~WB_SIZEABLE);
 }
 
-mbIsDeckOpen = *mbIsDeckRequestedOpen;
-if (*mbIsDeckOpen && mpCurrentDeck)
-mpCurrentDeck->Show();
 NotifyResize();
 }
 

[Libreoffice-commits] core.git: vcl/qa

[Stephan Bergmann (via logerrit)]

 vcl/qa/cppunit/text.cxx |   13 ++---
 1 file changed, 10 insertions(+), 3 deletions(-)

New commits:
commit 933519505aee0e91ca99af0ed860e4a0f148f922
Author: Stephan Bergmann 
AuthorDate: Thu Jan 12 16:42:39 2023 +0100
Commit: Stephan Bergmann 
CommitDate: Thu Jan 12 19:08:03 2023 +

Fix VclTextTest with colorized antialiasing

The Flathub build for


"Merge pull request #206 from flathub/lo-7.4.4" on 2023-01-12 at
 consistently 
failed for
both aarch64 and x86_64 builds with

> text.cxx:260:Assertion
> Test name: VclTextTest::testSimpleText
> double equality assertion failed
> - Expected: 28
> - Actual  : -1
> - Delta   : 2

during CppunitTest_vcl_text.  The reason (as seen with a temporary build 
setting
mbExportBitmap = true and looking at the resulting
workdir/CppunitTest/vcl_text.test.core/simple-text-36-50pct.png) is that the
stem of the "L" doesn't contain any COL_BLACK pixels, so
getCharacterLeftSideHeight returns early with -1.  The stem is drawn as 
three
vertical lines of pixels, a yellow (RGB 255/195/111), a black-ish (RGB 
23/0/0),
and a blue (RGB 31/155/199) one.  In comparison, when running the same test 
on
Fedora 37, the three vertical lines use gray-scale instead of colors,
RGB 195/195/195, then true black (RGB 0/0/0), and RGB 115/115/115.

An earlier test build of
 "Update to
LibreOffice 7.4.4" for the same libreoffice-7.4.4.2 tag on 2023-01-02 at
 succeeded, so I 
assume
that it must be some change in the meantime to the underlying
org.fedoraproject.sdk//22.08 that started to cause colorized antialiasing 
here.

Change-Id: I7059268eabcfe8e501d0be4f38746707def7bb35
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145411
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/vcl/qa/cppunit/text.cxx b/vcl/qa/cppunit/text.cxx
index 69365f98a00e..833022ee2204 100644
--- a/vcl/qa/cppunit/text.cxx
+++ b/vcl/qa/cppunit/text.cxx
@@ -99,6 +99,13 @@ public:
 CPPUNIT_TEST_SUITE_END();
 };
 
+// Avoid issues when colorized antialiasing generates slightly tinted rather 
than truly black
+// pixels:
+static bool isBlack(Color col)
+{
+return col.GetRed() < 25 && col.GetGreen() < 25 && col.GetBlue() < 25;
+}
+
 // Return pixel width of the base of the given character located above
 // the starting position.
 // In other words, go up in y direction until a black pixel is found,
@@ -109,7 +116,7 @@ static tools::Long getCharacterBaseWidth(VirtualDevice* 
device, const Point& sta
 Bitmap bitmap = device->GetBitmap(Point(), device->GetOutputSizePixel());
 Bitmap::ScopedReadAccess access(bitmap);
 tools::Long y = start.Y();
-while (y >= 0 && access->GetColor(y, start.X()) != COL_BLACK)
+while (y >= 0 && !isBlack(access->GetColor(y, start.X(
 --y;
 if (y < 0)
 return -1;
@@ -128,7 +135,7 @@ static tools::Long getCharacterTopWidth(VirtualDevice* 
device, const Point& star
 Bitmap bitmap = device->GetBitmap(Point(), device->GetOutputSizePixel());
 Bitmap::ScopedReadAccess access(bitmap);
 tools::Long y = start.Y();
-while (y < bitmap.GetSizePixel().Height() && access->GetColor(y, 
start.X()) != COL_BLACK)
+while (y < bitmap.GetSizePixel().Height() && !isBlack(access->GetColor(y, 
start.X(
 ++y;
 if (y >= bitmap.GetSizePixel().Height())
 return -1;
@@ -149,7 +156,7 @@ static tools::Long 
getCharacterLeftSideHeight(VirtualDevice* device, const Point
 Bitmap bitmap = device->GetBitmap(Point(), device->GetOutputSizePixel());
 Bitmap::ScopedReadAccess access(bitmap);
 tools::Long x = start.X();
-while (x < bitmap.GetSizePixel().Width() && access->GetColor(start.Y(), x) 
!= COL_BLACK)
+while (x < bitmap.GetSizePixel().Width() && 
!isBlack(access->GetColor(start.Y(), x)))
 ++x;
 if (x >= bitmap.GetSizePixel().Width())
 return -1;

[Libreoffice-bugs] [Bug 152968] Conditional Format defined for columns with number >1024 blocks functionality under "old" versions.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=152968

--- Comment #5 from Wolfgang Jäger  ---
Yes. The afflicted versions killing the complete oversize CF settings will die
out one day. But the problem occurred at least since V 3.6.5. Many users may
still stick to versions in the range of 3.6 through 7.3 and will then not be
able to use (e.g.) one of my listing-paper-templates created with 7.4 or
higher. 

Compatibility of 7.4 files with later versions isn't afflicted anyway. 
The question is if a "dirty" workaround the way I described should be
accepted/implemented. A clean solution will not be found.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 130937] Mouse-hold preview differs from result when changing a connector via dragging

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=130937

--- Comment #5 from giger.jonat...@gmail.com ---
Bug 148425 is the equivalent bug to this issue in Libreoffice Impress.

Bibisected to the same commit in Libreoffice Draw as well as in Impress.

https://git.libreoffice.org/core/+/1ebb77fd17b417d92ab48fcef56a0230c5750de2

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148425] Connectors not being previewed correctly when adjusting their position

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148425

--- Comment #4 from giger.jonat...@gmail.com ---
Bibisected with linux-64-5.10 to
https://git.libreoffice.org/core/+/1ebb77fd17b417d92ab48fcef56a0230c5750de2

> 8213642104b4d1a40e2f43098116b13e5f256738 is the first bad commit
> commit 8213642104b4d1a40e2f43098116b13e5f256738
> Author: Jenkins Build User 
> Date:   Mon Sep 17 09:35:35 2018 +0200
> 
> source sha:1ebb77fd17b417d92ab48fcef56a0230c5750de2
> 
> source sha:1ebb77fd17b417d92ab48fcef56a0230c5750de2
>

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149044] autonumbering and the action which caused it are combined into a single undo step

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149044

lvm  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #10 from lvm  ---
(In reply to Heiko Tietze from comment #9)
> (In reply to lvm from comment #8)
> > When a keystroke modifies the document and triggers autoformatting...
> 
> That's not true, you enter a paragraph break and the new paragraph is layout
> as defined in the style. => NAB

Ok, when enter is pressed two things happen:
1. paragraph is split into two
2. style of both is modified to include a list

Undo should undo step 2, then step 1, not both together in a single step. If
you are implying that under the hood it actually happens the other way around:
style changed first, then paragraph is split, that's too bad - underlying
technical design is not a consideration in UX. From user's POV enter is pressed
to split a paragraph and then list style is applied, and that's how it should
be undone.

Also this bug was already confirmed (comment 1) so it is NEW, not UNCONFIRMED.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 141535] VIEWING: base crashes when viewing a form

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141535

--- Comment #4 from user...@mailbox.org ---
no sorry, still have the problem, sorry for confusing you.
Debian has an outdated version of libreoffice, so it is.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/qa sw/source

[Miklos Vajna (via logerrit)]

 sw/qa/filter/html/html.cxx |   36 ++-
 sw/source/filter/html/htmltabw.cxx |   49 +++--
 2 files changed, 77 insertions(+), 8 deletions(-)

New commits:
commit a2fb3a135425bbc14375e1edfcc1e09a41d760f9
Author: Miklos Vajna 
AuthorDate: Thu Jan 12 13:57:16 2023 +0100
Commit: Miklos Vajna 
CommitDate: Thu Jan 12 18:32:21 2023 +

sw HTML export: fix invalid HTML when all cells of a row have the same 
rowspan

The bugdoc has a table with 2 columns and 2 rows, but both the A1 and
the A2 cell has rowspan=2, so there are only covered cells in the second
row. It seems there is no valid HTML markup to express this Writer doc
model.

What HTML seems to suggest instead is to simply decrease the amount of
rowspan attribute values and then the empty  elements can be simply
skipped.

This fixes the

Row 2 of a row group established by a tbody element has no cells 
beginning on it.

from the w3c HTML validator.

Note that you can't create such problematic tables on the UI: the UI
will delete the row only containing covered cells for you when the last
cell gets merged. Such documents can be created by importers, though.

Change-Id: Ice4fa3636e8b780d374f3d319b198da9f5e0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145402
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins

diff --git a/sw/qa/filter/html/html.cxx b/sw/qa/filter/html/html.cxx
index 4ec815da0c56..537b437c4bdb 100644
--- a/sw/qa/filter/html/html.cxx
+++ b/sw/qa/filter/html/html.cxx
@@ -8,6 +8,7 @@
  */
 
 #include 
+#include 
 
 #include 
 
@@ -30,7 +31,7 @@ namespace
  * Keep using the various sw_import/export suites for multiple filter 
calls inside a single
  * test.
  */
-class Test : public SwModelTestBase
+class Test : public SwModelTestBase, public HtmlTestTools
 {
 public:
 Test()
@@ -162,6 +163,39 @@ CPPUNIT_TEST_FIXTURE(Test, testTableCellFloatValueType)
 assertXPathNoAttribute(pXmlDoc, "//reqif-xhtml:td", "sdval");
 assertXPathNoAttribute(pXmlDoc, "//reqif-xhtml:td", "sdnum");
 }
+
+CPPUNIT_TEST_FIXTURE(Test, testTableRowSpanInAllCells)
+{
+// Given a document with a 2x2 table, A1:A2 and B1:B2 is merged:
+createSwDoc();
+SwDoc* pDoc = getSwDoc();
+SwWrtShell* pWrtShell = pDoc->GetDocShell()->GetWrtShell();
+SwInsertTableOptions aTableOptions(SwInsertTableFlags::DefaultBorder, 0);
+pWrtShell->InsertTable(aTableOptions, /*nRows=*/2, /*nCols=*/2);
+pWrtShell->MoveTable(GotoPrevTable, fnTableStart);
+SwTableNode* pTableNode = 
pWrtShell->GetCursor()->GetPointNode().FindTableNode();
+SwTable& rTable = pTableNode->GetTable();
+auto pBox = const_cast(rTable.GetTableBox("A1"));
+pBox->setRowSpan(2);
+pBox = const_cast(rTable.GetTableBox("B1"));
+pBox->setRowSpan(2);
+pBox = const_cast(rTable.GetTableBox("A2"));
+pBox->setRowSpan(-1);
+pBox = const_cast(rTable.GetTableBox("B2"));
+pBox->setRowSpan(-1);
+
+// When exporting to HTML:
+save("HTML (StarWriter)");
+
+// Then make sure that the output is simplified to valid HTML, by omitting 
the rowspan attribute
+// & the empty  element:
+htmlDocUniquePtr pHtmlDoc = parseHtml(maTempFile);
+// Without the accompanying fix in place, this test would have failed with:
+// - XPath '//tr[1]/td[1]' unexpected 'rowspan' attribute
+// i.e. a combination of rowspan + empty  was emitted.
+assertXPathNoAttribute(pHtmlDoc, "//tr[1]/td[1]", "rowspan");
+assertXPath(pHtmlDoc, "//tr", 1);
+}
 }
 
 CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/sw/source/filter/html/htmltabw.cxx 
b/sw/source/filter/html/htmltabw.cxx
index 43e9ebf97328..ddb8c8eb5f10 100644
--- a/sw/source/filter/html/htmltabw.cxx
+++ b/sw/source/filter/html/htmltabw.cxx
@@ -63,12 +63,20 @@ class SwHTMLWrtTable : public SwWriteTable
 static void Pixelize( sal_uInt16& rValue );
 void PixelizeBorders();
 
+/// Writes a single table cell.
+///
+/// bCellRowSpan decides if the cell's row span should be written or not.
 void OutTableCell( SwHTMLWriter& rWrt, const SwWriteTableCell *pCell,
-   bool bOutVAlign ) const;
+   bool bOutVAlign,
+   bool bCellRowSpan ) const;
 
+/// Writes a single table row.
+///
+/// rSkipRows decides if the next N rows should be skipped or written.
 void OutTableCells( SwHTMLWriter& rWrt,
 const SwWriteTableCells& rCells,
-const SvxBrushItem *pBrushItem ) const;
+const SvxBrushItem *pBrushItem,
+sal_uInt16& rSkipRows ) const;
 
 virtual bool ShouldExpandSub( const SwTableBox *pBox,
 bool bExpandedBefore, sal_uInt16 nDepth ) const 
override;
@@ -254,7 +262,8 @@ bool SwHTMLWrtTable::ShouldExpandSub( const SwTableBox 

[Libreoffice-bugs] [Bug 152968] Conditional Format defined for columns with number >1024 blocks functionality under "old" versions.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=152968

--- Comment #4 from Wolfgang Jäger  ---
Created attachment 184623
  --> https://bugs.documentfoundation.org/attachment.cgi?id=184623=edit
Demonstrate the suggested workaround

Because I have talked about a possible workaround, I would also like to explain
how it is conceived and demonstrate that it would be applicable.

1. The workaround would require to include an additional step into the process
of storing a spredsheet document: Filter all the defined CF for their ranges,
and split every CF as well including cells with .Coulumn<1024 as some with
.Column>=1024 in two, one restricted to the old limit of 1024 columns, the
other restricted to the rest.
2. When loading such a file older versions currently destroying the complete
"supersize" CF could then accept the first part and ignore the second one. 
3. Versions >= 7.4.0 can even re-merge the pairs of ranges created the
described way.

Of course, I didn't create a private version of LibO for the demo, but did the
split "manually". The trick worked with V 7.3.6.

See new attachment
Open it first with 7.4 or higher. Then try 7.3.6 or the like.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149190] calc text spell check red line on word does not always present add to dictionary

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149190

--- Comment #6 from David Pickett  ---
Sure, if nothing jumps out on code review, we can wait for a better report. 
After all this time, I cannot recall which xls triggered this observation.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 141535] VIEWING: base crashes when viewing a form

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141535

user...@mailbox.org changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #3 from user...@mailbox.org ---
Hi all thanks for your help.
After a while it seems the bug is no more existent.
I use Libreoffice 7.0.4.2 in Debian bullseye and no crashes :-).
Maybe it was a bug in gtk

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: external/redland

[Tor Lillqvist (via logerrit)]

 external/redland/UnpackedTarball_raptor.mk|1 +
 external/redland/raptor/raptor-emscripten.patch.1 |   12 
 2 files changed, 13 insertions(+)

New commits:
commit 044cf67f1362088723908747d576aff81cdf4e61
Author: Tor Lillqvist 
AuthorDate: Thu Jan 12 16:01:00 2023 +0200
Commit: Tor Lillqvist 
CommitDate: Thu Jan 12 17:45:21 2023 +

Adapt to newer Emscripten SDK

The check for platform in raptor's sort_r.h no longer worked with
Emscripten 3.1.30. Looking for __EMSCRIPTEN__ explicitly helps.

Change-Id: Ieccf723d809b4e90d44a8a510f71e12bd1d2e529
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145408
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist 

diff --git a/external/redland/UnpackedTarball_raptor.mk 
b/external/redland/UnpackedTarball_raptor.mk
index 619116c3380c..f829f6fb736b 100644
--- a/external/redland/UnpackedTarball_raptor.mk
+++ b/external/redland/UnpackedTarball_raptor.mk
@@ -22,6 +22,7 @@ $(eval $(call gb_UnpackedTarball_set_patchlevel,raptor,0))
 $(eval $(call gb_UnpackedTarball_add_patches,raptor,\
external/redland/raptor/raptor-freebsd.patch.1 \
external/redland/raptor/raptor-msvc.patch.1 \
+   external/redland/raptor/raptor-emscripten.patch.1 \
$(if $(filter-out 
WNT,$(OS)),external/redland/raptor/raptor-bundled-soname.patch.1) \
$(if $(filter 
ANDROID,$(OS)),external/redland/raptor/raptor-android.patch.1) \
external/redland/raptor/ubsan.patch \
diff --git a/external/redland/raptor/raptor-emscripten.patch.1 
b/external/redland/raptor/raptor-emscripten.patch.1
new file mode 100644
index ..e3c53b35b7b0
--- /dev/null
+++ b/external/redland/raptor/raptor-emscripten.patch.1
@@ -0,0 +1,12 @@
+-*- Mode: Diff -*-
+--- raptor/src/sort_r.h
 raptor/src/sort_r.h
+@@ -27,7 +27,7 @@
+  defined AMIGA)
+ #  define _SORT_R_BSD
+ #elif (defined _GNU_SOURCE || defined __gnu_hurd__ || defined __GNU__ || \
+-   defined __linux__ || defined __MINGW32__ || defined __GLIBC__)
++   defined __linux__ || defined __MINGW32__ || defined __GLIBC__ || 
defined __EMSCRIPTEN__)
+ #  define _SORT_R_LINUX
+ #elif (defined _WIN32 || defined _WIN64 || defined __WINDOWS__)
+ #  define _SORT_R_WINDOWS

[Libreoffice-commits] core.git: configure.ac

[Tor Lillqvist (via logerrit)]

 configure.ac |   12 
 1 file changed, 8 insertions(+), 4 deletions(-)

New commits:
commit 57eae105cdd6faeb7640f06cf4706fde9bf73fbf
Author: Tor Lillqvist 
AuthorDate: Thu Jan 12 15:45:11 2023 +0200
Commit: Tor Lillqvist 
CommitDate: Thu Jan 12 17:45:03 2023 +

Adapt to newer Emscripten SDK

The __EMSCRIPTEN_major__, minor, and tiny macros are no longer
predefined but only defined in . So grep that
instead of running emcc -dM -E.

Change-Id: I2383a906f9c746784449cd4606f653ab722b54de
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145407
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist 

diff --git a/configure.ac b/configure.ac
index 01219ec033be..93a1c89e3569 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1410,10 +1410,14 @@ 
EMSCRIPTEN_MIN_VERSION="${EMSCRIPTEN_MIN_MAJOR}.${EMSCRIPTEN_MIN_MINOR}.${EMSCRI
 
 if test "$_os" = "Emscripten"; then
 AC_MSG_CHECKING([if Emscripten is at least $EMSCRIPTEN_MIN_VERSION])
-EMSCRIPTEN_DEFINES=$(echo | emcc -dM -E - | $GREP __EMSCRIPTEN_)
-EMSCRIPTEN_MAJOR=$(echo "$EMSCRIPTEN_DEFINES" | $SED -ne 
's/.*__EMSCRIPTEN_major__ //p')
-EMSCRIPTEN_MINOR=$(echo "$EMSCRIPTEN_DEFINES" | $SED -ne 
's/.*__EMSCRIPTEN_minor__ //p')
-EMSCRIPTEN_TINY=$(echo "$EMSCRIPTEN_DEFINES" | $SED -ne 
's/.*__EMSCRIPTEN_tiny__ //p')
+AS_IF([test -z "$EMSDK"],
+  [AC_MSG_ERROR([No \$EMSDK environment variable.])])
+
EMSCRIPTEN_VERSION_H=$EMSDK/upstream/emscripten/cache/sysroot/include/emscripten/version.h
+AS_IF([test ! -f "$EMSCRIPTEN_VERSION_H"],
+  [AC_MSG_ERROR([Could not find the  in the 
Emscripten SDK.])])
+EMSCRIPTEN_MAJOR=$($GREP __EMSCRIPTEN_major__ "$EMSCRIPTEN_VERSION_H" | 
$SED -ne 's/.*__EMSCRIPTEN_major__ //p')
+EMSCRIPTEN_MINOR=$($GREP __EMSCRIPTEN_minor__ "$EMSCRIPTEN_VERSION_H" | 
$SED -ne 's/.*__EMSCRIPTEN_minor__ //p')
+EMSCRIPTEN_TINY=$($GREP __EMSCRIPTEN_tiny__ "$EMSCRIPTEN_VERSION_H" | $SED 
-ne 's/.*__EMSCRIPTEN_tiny__ //p')
 
EMSCRIPTEN_VERSION="${EMSCRIPTEN_MAJOR}.${EMSCRIPTEN_MINOR}.${EMSCRIPTEN_TINY}"
 
 check_semantic_version_three_prefixed EMSCRIPTEN MIN

[Libreoffice-bugs] [Bug 149212] Impress: Powerpoint OLE animations don't work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149212

--- Comment #6 from Daniel Collins  ---
Agreed, confirmed this works for me now with the 7.4.4.2 download. Major fix
for me, thanks to whoever made that happen.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152968] Conditional Format defined for columns with number >1024 blocks functionality under "old" versions.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=152968

Mike Kaganski  changed:

   What|Removed |Added

 CC||er...@redhat.com

--- Comment #3 from Mike Kaganski  ---
I suppose that this should be mostly WONTFIX, because, while I agree that we
need descent backward compatibility, it is also normal that any new feature
that was absent in previous versions should be ignored in those versions. This
happens how, the feature being the large range in the conditional format.

There could be a corner case (shown in the attachment 184564), where the range
spans the whole width. Then we can simply store the range as



instead of



which would work for all versions since 5.0.

The discussed corner case could be important enough to warrant the special
treatment, because this could generally be used for "decorating" the whole
area.

Incidentally, the problematic file works fine in AOO, and even in OOo 2.2.0. It
looks like we lack a fallback to the older (non-calcext) data when newer data
can't be used. Unfortunately, this can't be fixed in 7.3 and older; but maybe
it's worth fixing separately anyway.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 72038] LOCALHELP: Unclear Help Text of Options “Number recognition” and “Number format recognition”

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72038

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 72038] LOCALHELP: Unclear Help Text of Options “Number recognition” and “Number format recognition”

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72038

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Status|CLOSED  |RESOLVED

--- Comment #9 from Stéphane Guillou (stragu) 
 ---
Just setting to Resolved, then Verified as what Harald did was verifying the
bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: vcl/source

[Miklos Vajna (via logerrit)]

 vcl/source/bitmap/BitmapEx.cxx |   17 ++---
 1 file changed, 14 insertions(+), 3 deletions(-)

New commits:
commit b3a15589915e8b60eae5878e53f90d706c79c106
Author: Miklos Vajna 
AuthorDate: Thu Jan 12 13:33:20 2023 +0100
Commit: Miklos Vajna 
CommitDate: Thu Jan 12 17:27:08 2023 +

vcl: handle VCL_DUMP_BMP_PATH in BitmapEx::DumpAsPng()

As requested at

.

Change-Id: I8868969a2061f0447b101d978acc5027d1bdd545
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145400
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/vcl/source/bitmap/BitmapEx.cxx b/vcl/source/bitmap/BitmapEx.cxx
index cc3988abf333..f83f44d5007a 100644
--- a/vcl/source/bitmap/BitmapEx.cxx
+++ b/vcl/source/bitmap/BitmapEx.cxx
@@ -1486,9 +1486,20 @@ void  BitmapEx::GetColorModel(css::uno::Sequence< 
sal_Int32 >& rRGBPalette,
 
 void BitmapEx::DumpAsPng(const char* pFileName) const
 {
-SvFileStream aStream(pFileName ? OUString::fromUtf8(pFileName)
-   : OUString("file:///tmp/bitmap.png"),
- StreamMode::STD_READWRITE | StreamMode::TRUNC);
+OUString sPath;
+if (pFileName)
+{
+sPath = OUString::fromUtf8(pFileName);
+}
+else if (const char* pEnv = std::getenv("VCL_DUMP_BMP_PATH"))
+{
+sPath = OUString::fromUtf8(pEnv);
+}
+else
+{
+sPath = "file:///tmp/bitmap.png";
+}
+SvFileStream aStream(sPath, StreamMode::STD_READWRITE | StreamMode::TRUNC);
 assert(aStream.good());
 vcl::PngImageWriter aWriter(aStream);
 aWriter.write(*this);

[Libreoffice-bugs] [Bug 111942] [META] User locale bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=111942

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||72039


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=72039
[Bug 72039] TABLE: Differences between English and German Number Recognition
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 72039] TABLE: Differences between English and German Number Recognition

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72039

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Blocks||111942
   Hardware|Other   |All


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=111942
[Bug 111942] [META] User locale bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 72039] TABLE: Differences between English and German Number Recognition

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72039

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||stephane.guillou@libreoffic
   ||e.org

--- Comment #12 from Stéphane Guillou (stragu) 
 ---
Created attachment 184622
  --> https://bugs.documentfoundation.org/attachment.cgi?id=184622=edit
Test document updated with results of LO 7.4 on Ubuntu

Still the case, in 7.4.4.2 and beyond:

Version: 7.4.4.2 / LibreOffice Community
Build ID: 85569322deea74ec9134968a29af2df5663baa21
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 92deea6301a02f5530f17263f58402344f82013c
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Both versions with the same results: the inconsistency reported by Harald 6.1
is valid for the same cases, but the inconsistent numbers also entirely fail to
format as percentages in German on Linux (highlighted in yellow in attachment).
This failed percentage formatting was also present in version 6.1, so it looks
like a Linux issue that's been around for a while.

The updated attachment makes it a bit easier to test and to see previous
results.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 86206] Exporting to SVG breaks dashed lines

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=86206

--- Comment #25 from Roland Baudin  ---
Created attachment 184621
  --> https://bugs.documentfoundation.org/attachment.cgi?id=184621=edit
Test case test1.svg

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 86206] Exporting to SVG breaks dashed lines

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=86206

--- Comment #24 from Roland Baudin  ---
Created attachment 184620
  --> https://bugs.documentfoundation.org/attachment.cgi?id=184620=edit
Test case test1.odg

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 86206] Exporting to SVG breaks dashed lines

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=86206

--- Comment #23 from Roland Baudin  ---
Hi,

I see a different behaviour with the following use case:

1. Open Draw and create two dashed lines, one with 0" width (thin line) and the
other with 0.03" width (thick line)

2. Export to SVG

3. Open with Inkscape: the thin line is dashed (as expected) but the thick line
is solid (not expected)

I attach the files: test1.odg and test1.svg with this example.

LibreOffice version
---

Version: 7.4.3.2 / LibreOffice Community
Build ID: 40(Build:2)
CPU threads: 48; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: fr-CH (fr_FR.UTF-8); UI: fr-FR
Ubuntu package version: 1:7.4.3~rc2-0ubuntu0.22.04.1~lo1
Calc: threaded

Fresh LibreOffice profile

System
--

Ubuntu 22.04.1 64 bits

Fresh user profile

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152371] Hidden cells create a new empty page

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=152371

--- Comment #2 from Robert Ombuzal  ---
Created attachment 184619
  --> https://bugs.documentfoundation.org/attachment.cgi?id=184619=edit
Hidden a cell on Page TWO

Hidden a cell on Page TWO, Print Preview prints two pages.

-- 
You are receiving this mail because:
You are the assignee for the bug.