[Libreoffice-commits] core.git: 2 commits - include/svx svx/Library_svx.mk svx/source sw/inc sw/Library_sw.mk sw/source sw/uiconfig
include/svx/dialog/ThemeColorValueSet.hxx | 38 ++
svx/Library_svx.mk |1
svx/source/dialog/ThemeColorValueSet.cxx | 98 ++
sw/Library_sw.mk |1
sw/inc/swtypes.hxx |6
sw/source/core/inc/ThemeColorChanger.hxx | 33 ++
sw/source/core/inc/UndoAttribute.hxx |2
sw/source/core/model/ThemeColorChanger.cxx | 271 ++
sw/source/core/undo/unattr.cxx | 21 +
sw/source/uibase/sidebar/ThemePanel.cxx| 436 -
sw/source/uibase/sidebar/ThemePanel.hxx|7
sw/uiconfig/swriter/ui/sidebartheme.ui | 164 ++
12 files changed, 529 insertions(+), 549 deletions(-)
New commits:
commit 1af58b5acec4a2de095d86feef05ac4aed3edb8f
Author: Tomaž Vajngerl
AuthorDate: Fri Jan 6 17:28:49 2023 +0900
Commit: Tomaž Vajngerl
CommitDate: Sat Jan 14 07:52:46 2023 +
sw: add ThemeColorChanger that sweeps the model and changes colors
The ThemeColorChanger responisiblity is to recalculate and change
all the theme colors in the model. This includes styles and direct
formatting changes. It uses ModelTraverser for direct formatting
changes as it already implements traversing through nodes.
The ThemeColorChanger replaces the code to change the colors in
ThemePanel.
Also modify undo/redo for changing of attributes to not move
the cursor and selection when undoing and redoing (new flag
NO_CURSOR_CHANGE), as in this case it is very distrcting.
Change-Id: Ida1912bd0697307daad9244d474862830ab2686f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145263
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/sw/Library_sw.mk b/sw/Library_sw.mk
index 478136e50f54..fa2ca1663512 100644
--- a/sw/Library_sw.mk
+++ b/sw/Library_sw.mk
@@ -366,6 +366,7 @@ $(eval $(call gb_Library_add_exception_objects,sw,\
sw/source/core/layout/wsfrm \
sw/source/core/model/ModelTraverser \
sw/source/core/model/SearchResultLocator \
+sw/source/core/model/ThemeColorChanger \
sw/source/core/objectpositioning/anchoredobjectposition \
sw/source/core/objectpositioning/ascharanchoredobjectposition \
sw/source/core/objectpositioning/environmentofanchoredobject \
diff --git a/sw/inc/swtypes.hxx b/sw/inc/swtypes.hxx
index 96c0fb5008c3..b3cdfa531074 100644
--- a/sw/inc/swtypes.hxx
+++ b/sw/inc/swtypes.hxx
@@ -143,17 +143,19 @@ enum class SetAttrMode
NOHINTADJUST= 0x0008, // No merging of ranges.
NOFORMATATTR= 0x0010, // Do not change into format attribute.
APICALL = 0x0020, // Called from API (all UI related
-// functionality will
be disabled).
+ // functionality will be disabled).
/// Force hint expand (only matters for hints with CH_TXTATR).
FORCEHINTEXPAND = 0x0040,
/// The inserted item is a copy -- intended for use in ndtxt.cxx.
IS_COPY = 0x0080,
/// for Undo, translated to SwInsertFlags::NOHINTEXPAND
NOHINTEXPAND= 0x0100,
+/// don't change the cursor position
+NO_CURSOR_CHANGE = 0x0200
};
namespace o3tl
{
-template<> struct typed_flags : is_typed_flags {};
+template<> struct typed_flags : is_typed_flags {};
}
namespace sw {
diff --git a/sw/source/core/inc/ThemeColorChanger.hxx
b/sw/source/core/inc/ThemeColorChanger.hxx
new file mode 100644
index ..0698126da3e9
--- /dev/null
+++ b/sw/source/core/inc/ThemeColorChanger.hxx
@@ -0,0 +1,33 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ *
+ */
+#pragma once
+
+#include
+#include
+
+namespace sw
+{
+class ThemeColorChanger
+{
+private:
+SwDocShell* mpDocSh;
+
+public:
+ThemeColorChanger(SwDocShell* pDocSh)
+: mpDocSh(pDocSh)
+{
+}
+
+void apply(svx::ColorSet const& rColorSet);
+};
+
+} // end sw namespace
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/core/inc/UndoAttribute.hxx
b/sw/source/core/inc/UndoAttribute.hxx
index c3cf4925d95a..e3c40b7f0e87 100644
--- a/sw/source/core/inc/UndoAttribute.hxx
+++ b/sw/source/core/inc/UndoAttribute.hxx
@@ -45,7 +45,7 @@ class SwUndoAttr final : public SwUndo, private SwUndRng
OUString m_aChrFormatName;
void RemoveIdx( SwDoc& rDoc );
-
+void redoAttribute(SwPaM& rPam, sw::UndoRedoContext& rContext);
public:
SwUndoAttr( const SwPaM&, SfxItemSet, const SetAttrMode nFlags );
SwUndoAttr( const SwPaM&, const SfxPoolItem&, const SetAttrMode nFlags );
diff --git a/sw/source/core/model/ThemeColorChanger.cxx
[Libreoffice-bugs] [Bug 152736] Editing the resolution of jpg or png exports changes physical image size by default
https://bugs.documentfoundation.org/show_bug.cgi?id=152736 Robert Großkopf changed: What|Removed |Added OS|Windows (All) |All Whiteboard| QA:needsComment| Status|UNCONFIRMED |NEW Version|unspecified |7.2.0.4 release CC||rob...@familiegrosskopf.de Ever confirmed|0 |1 Keywords||regression --- Comment #1 from Robert Großkopf --- The dialog is irritating at this moment. If you set the resolution from 96 dpi up to 300 dpi it doesn't change the field for the dimension, but it creates an image, which will need the same memory as the image with 96 dpi. Click in the radio button for Modify dimensions: Width and height will be changed immediately. Now change the width to the width of the page and the needed memory grows by a factor of ten. The dialog with the radio buttons has been created for changing dpi without changing dimension, as it was before up to LO 7.1.*. New introduced radio buttons are a regression, because they show the old dimension and still will change the content to a new dimension. Tested with LO 7.4.4.2 on OpenSUSE 15.3 64bit rpm Linux. Also tested with older versions. New dialog appears first with LO 7.2. LO 7.1.5.2 won't show the radio buttons. Changing of dpi will directly show a changing of dimensions. So you see: Oh, I have to adjust dimensions. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: xmlsecurity/source
xmlsecurity/source/xmlsec/nss/securityenvironment_nssimpl.cxx | 11 +++--
xmlsecurity/source/xmlsec/nss/x509certificate_nssimpl.cxx | 12 --
xmlsecurity/source/xmlsec/nss/x509certificate_nssimpl.hxx |7 -
3 files changed, 4 insertions(+), 26 deletions(-)
New commits:
commit 08cae41f6f8cb8f9f592c0735d1285c0575d6e49
Author: Noel Grandin
AuthorDate: Fri Jan 13 08:30:28 2023 +0200
Commit: Noel Grandin
CommitDate: Sat Jan 14 07:29:12 2023 +
XUnoTunnel->dynamic_cast in X509Certificate_NssImpl
Change-Id: I027e8bcee4f9e2b7bafd2ddf9070b6a28bcded37
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145496
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/xmlsecurity/source/xmlsec/nss/securityenvironment_nssimpl.cxx
b/xmlsecurity/source/xmlsec/nss/securityenvironment_nssimpl.cxx
index d130c03723e9..2add74631001 100644
--- a/xmlsecurity/source/xmlsec/nss/securityenvironment_nssimpl.cxx
+++ b/xmlsecurity/source/xmlsec/nss/securityenvironment_nssimpl.cxx
@@ -361,8 +361,7 @@ Sequence< Reference < XCertificate > >
SecurityEnvironment_NssImpl::buildCertifi
// Remember the signing certificate.
m_xSigningCertificate = begin;
-Reference< XUnoTunnel > xCertTunnel( begin, UNO_QUERY_THROW ) ;
-const X509Certificate_NssImpl* xcert =
comphelper::getFromUnoTunnel(xCertTunnel);
+const X509Certificate_NssImpl* xcert =
dynamic_cast(begin.get());
if( xcert == nullptr ) {
throw RuntimeException() ;
}
@@ -495,11 +494,10 @@ verifyCertificate( const Reference< csss::XCertificate >&
aCert,
{
sal_Int32 validity = csss::CertificateValidity::INVALID;
const CERTCertificate* cert ;
-Reference< XUnoTunnel > xCertTunnel( aCert, UNO_QUERY_THROW ) ;
SAL_INFO("xmlsecurity.xmlsec", "Start verification of certificate: " <<
aCert->getSubjectName());
-const X509Certificate_NssImpl* xcert =
comphelper::getFromUnoTunnel(xCertTunnel);
+const X509Certificate_NssImpl* xcert =
dynamic_cast(aCert.get());
if( xcert == nullptr ) {
throw RuntimeException() ;
}
@@ -711,8 +709,7 @@ sal_Int32
SecurityEnvironment_NssImpl::getCertificateCharacters(
sal_Int32 characters ;
const CERTCertificate* cert ;
-Reference< XUnoTunnel > xCertTunnel( aCert, UNO_QUERY_THROW ) ;
-const X509Certificate_NssImpl* xcert =
comphelper::getFromUnoTunnel(xCertTunnel);
+const X509Certificate_NssImpl* xcert =
dynamic_cast(aCert.get());
if( xcert == nullptr ) {
throw RuntimeException() ;
}
@@ -814,7 +811,7 @@ xmlSecKeysMngrPtr
SecurityEnvironment_NssImpl::createKeysManager() {
// Adopt the private key of the signing certificate, if it has any.
if (auto pCertificate
-=
comphelper::getFromUnoTunnel(m_xSigningCertificate))
+=
dynamic_cast(m_xSigningCertificate.get()))
{
SECKEYPrivateKey* pPrivateKey =
SECKEY_CopyPrivateKey(pCertificate->getPrivateKey());
if (pPrivateKey)
diff --git a/xmlsecurity/source/xmlsec/nss/x509certificate_nssimpl.cxx
b/xmlsecurity/source/xmlsec/nss/x509certificate_nssimpl.cxx
index 79441da1edf5..4997a482728e 100644
--- a/xmlsecurity/source/xmlsec/nss/x509certificate_nssimpl.cxx
+++ b/xmlsecurity/source/xmlsec/nss/x509certificate_nssimpl.cxx
@@ -332,18 +332,6 @@ SECKEYPrivateKey* X509Certificate_NssImpl::getPrivateKey()
return nullptr;
}
-/* XUnoTunnel */
-sal_Int64 SAL_CALL X509Certificate_NssImpl::getSomething( const
css::uno::Sequence< sal_Int8 >& aIdentifier ) {
-return comphelper::getSomethingImpl(aIdentifier, this);
-}
-
-/* XUnoTunnel extension */
-
-const css::uno::Sequence< sal_Int8>& X509Certificate_NssImpl::getUnoTunnelId()
{
-static const comphelper::UnoIdInit theX509Certificate_NssImplUnoTunnelId;
-return theX509Certificate_NssImplUnoTunnelId.getSeq();
-}
-
static OUString getAlgorithmDescription(SECAlgorithmID const *aid)
{
SECOidTag tag;
diff --git a/xmlsecurity/source/xmlsec/nss/x509certificate_nssimpl.hxx
b/xmlsecurity/source/xmlsec/nss/x509certificate_nssimpl.hxx
index dbfb6c6b07ed..9ad50f12ba0f 100644
--- a/xmlsecurity/source/xmlsec/nss/x509certificate_nssimpl.hxx
+++ b/xmlsecurity/source/xmlsec/nss/x509certificate_nssimpl.hxx
@@ -22,7 +22,6 @@
#include
#include
#include
-#include
#include
#include
#include
@@ -33,7 +32,6 @@
class X509Certificate_NssImpl : public ::cppu::WeakImplHelper<
css::security::XCertificate ,
-css::lang::XUnoTunnel,
css::lang::XServiceInfo > , public xmlsecurity::Certificate
{
private:
@@ -76,17 +74,12 @@ class X509Certificate_NssImpl : public
::cppu::WeakImplHelper<
virtual sal_Int32 SAL_CALL getCertificateUsage( ) override ;
-//Methods from XUnoTunnel
-virtual sal_Int64 SAL_CALL getSomething( const css::uno::Sequence<
sal_Int8 >& aIdentifier ) override;
-
/// @see xmlsecurity::Certificate::getSHA256Thumbprint().
virtual
[Libreoffice-commits] core.git: include/xmloff sc/source starmath/inc starmath/source sw/source xmloff/source
include/xmloff/xmlexp.hxx |7 +--
sc/source/filter/xml/xmlexprt.cxx |7 ---
sc/source/filter/xml/xmlexprt.hxx |3 ---
sc/source/filter/xml/xmlwrap.cxx|2 +-
starmath/inc/mathml/export.hxx |4
starmath/inc/mathml/mathmlexport.hxx|4
starmath/source/mathml/export.cxx | 16 ++--
starmath/source/mathml/mathmlexport.cxx | 14 +-
sw/source/filter/xml/xmlexp.cxx | 12
sw/source/filter/xml/xmlexp.hxx |4
xmloff/source/core/xmlexp.cxx |3 ---
11 files changed, 5 insertions(+), 71 deletions(-)
New commits:
commit d66d1f6fd47b02076945c09c0d6f8f019d0501d5
Author: Noel Grandin
AuthorDate: Thu Jan 12 16:39:44 2023 +0200
Commit: Noel Grandin
CommitDate: Sat Jan 14 07:28:18 2023 +
XUnoTunnel->dynamic_cast in SvXMLExport
Change-Id: I68e4691ac0a58e2320b534d15934ff177feb124d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145493
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/include/xmloff/xmlexp.hxx b/include/xmloff/xmlexp.hxx
index 37a9096a0b32..818f524ad545 100644
--- a/include/xmloff/xmlexp.hxx
+++ b/include/xmloff/xmlexp.hxx
@@ -24,7 +24,6 @@
#include
#include
-#include
#include
#include
#include
@@ -113,8 +112,7 @@ class XMLOFF_DLLPUBLIC SvXMLExport : public
cppu::WeakImplHelper<
css::lang::XServiceInfo,
css::document::XExporter,
css::lang::XInitialization,
- css::container::XNamed,
- css::lang::XUnoTunnel>
+ css::container::XNamed>
{
std::unique_ptrmpImpl;// dummy
@@ -311,9 +309,6 @@ public:
virtual sal_Bool SAL_CALL supportsService( const OUString& ServiceName )
final override;
virtual css::uno::Sequence< OUString > SAL_CALL getSupportedServiceNames(
) final override;
-// XUnoTunnel
-UNO3_GETIMPLEMENTATION_DECL(SvXMLExport)
-
/** ensures that the given namespace is in scope at the next started
element.
diff --git a/sc/source/filter/xml/xmlexprt.cxx
b/sc/source/filter/xml/xmlexprt.cxx
index 051c0ac251b3..e164766fa677 100644
--- a/sc/source/filter/xml/xmlexprt.cxx
+++ b/sc/source/filter/xml/xmlexprt.cxx
@@ -5449,13 +5449,6 @@ void SAL_CALL ScXMLExport::initialize( const
css::uno::Sequence< css::uno::Any >
SvXMLExport::initialize(aArguments);
}
-// XUnoTunnel
-sal_Int64 SAL_CALL ScXMLExport::getSomething( const css::uno::Sequence<
sal_Int8 >& aIdentifier )
-{
-SolarMutexGuard aGuard;
-return SvXMLExport::getSomething(aIdentifier);
-}
-
void ScXMLExport::DisposingModel()
{
SvXMLExport::DisposingModel();
diff --git a/sc/source/filter/xml/xmlexprt.hxx
b/sc/source/filter/xml/xmlexprt.hxx
index 8ab8901d4671..a29ab0ea45d8 100644
--- a/sc/source/filter/xml/xmlexprt.hxx
+++ b/sc/source/filter/xml/xmlexprt.hxx
@@ -271,9 +271,6 @@ public:
// XInitialization
virtual void SAL_CALL initialize( const css::uno::Sequence< css::uno::Any
>& aArguments ) override;
-// XUnoTunnel
-virtual sal_Int64 SAL_CALL getSomething( const css::uno::Sequence<
sal_Int8 >& aIdentifier ) override;
-
virtual void DisposingModel() override;
};
diff --git a/sc/source/filter/xml/xmlwrap.cxx b/sc/source/filter/xml/xmlwrap.cxx
index 79cb3a9fc06a..1bcd82311d26 100644
--- a/sc/source/filter/xml/xmlwrap.cxx
+++ b/sc/source/filter/xml/xmlwrap.cxx
@@ -660,7 +660,7 @@ bool ScXMLImportWrapper::ExportToComponent(const
uno::Reference(comphelper::getFromUnoTunnel(xFilter));
+ScXMLExport* pExport =
static_cast(dynamic_cast(xFilter.get()));
pExport->SetSharedData(std::move(pSharedData));
// if there are sheets to copy, get the source stream
diff --git a/starmath/inc/mathml/export.hxx b/starmath/inc/mathml/export.hxx
index 12e541d31551..0ed354be4b67 100644
--- a/starmath/inc/mathml/export.hxx
+++ b/starmath/inc/mathml/export.hxx
@@ -204,10 +204,6 @@ private:
SmDocShell* getSmDocShell();
public:
-// XUnoTunnel
-sal_Int64 SAL_CALL getSomething(const css::uno::Sequence& rId)
override;
-static const css::uno::Sequence& getUnoTunnelId() noexcept;
-
/** Exports auto styles
* However math doesn't have any
*/
diff --git a/starmath/inc/mathml/mathmlexport.hxx
b/starmath/inc/mathml/mathmlexport.hxx
index 28e35a7c52a0..74a655174089 100644
--- a/starmath/inc/mathml/mathmlexport.hxx
+++ b/starmath/inc/mathml/mathmlexport.hxx
@@ -109,10 +109,6 @@ public:
SmXMLExport(const css::uno::Reference&
rContext,
OUString const& implementationName, SvXMLExportFlags
nExportFlags);
-// XUnoTunnel
-sal_Int64 SAL_CALL getSomething(const css::uno::Sequence& rId)
override;
-static const css::uno::Sequence& getUnoTunnelId() noexcept;
-
void ExportAutoStyles_() override {}
void ExportMasterStyles_() override {}
void ExportContent_()
[Libreoffice-commits] core.git: chart2/source
chart2/source/controller/accessibility/AccessibleChartView.cxx | 13
++
chart2/source/controller/inc/AccessibleChartView.hxx |3 +-
2 files changed, 10 insertions(+), 6 deletions(-)
New commits:
commit fd6df89dbc26cda08c54e76644b43219d8b75236
Author: Noel Grandin
AuthorDate: Fri Jan 13 18:59:38 2023 +0200
Commit: Noel Grandin
CommitDate: Sat Jan 14 07:28:02 2023 +
use more concrete types in chart
Change-Id: I23888f636e36f6163405603a542a2f2f12eefa1d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145488
Tested-by: Noel Grandin
Reviewed-by: Noel Grandin
diff --git a/chart2/source/controller/accessibility/AccessibleChartView.cxx
b/chart2/source/controller/accessibility/AccessibleChartView.cxx
index 2b96c684ff43..8e35e05706ac 100644
--- a/chart2/source/controller/accessibility/AccessibleChartView.cxx
+++ b/chart2/source/controller/accessibility/AccessibleChartView.cxx
@@ -25,6 +25,7 @@
#include
#include "AccessibleViewForwarder.hxx"
#include
+#include
#include
#include
@@ -172,14 +173,14 @@ void SAL_CALL AccessibleChartView::initialize( const
Sequence< Any >& rArguments
Reference< view::XSelectionSupplier > xSelectionSupplier;
rtl::Reference<::chart::ChartModel> xChartModel;
-Reference< uno::XInterface > xChartView;
+rtl::Reference<::chart::ChartView> xChartView;
Reference< XAccessible > xParent;
Reference< awt::XWindow > xWindow;
{
MutexGuard aGuard( m_aMutex);
xSelectionSupplier.set( m_xSelectionSupplier );
xChartModel = m_xChartModel;
-xChartView.set( m_xChartView );
+xChartView = m_xChartView;
xParent.set( m_xParent );
xWindow.set( m_xWindow );
}
@@ -209,8 +210,10 @@ void SAL_CALL AccessibleChartView::initialize( const
Sequence< Any >& rArguments
if( rArguments.getLength() > 2 )
{
-Reference< uno::XInterface > xNewChartView;
-rArguments[2] >>= xNewChartView;
+Reference< uno::XInterface > xTmp;
+rArguments[2] >>= xTmp;
+rtl::Reference<::chart::ChartView> xNewChartView =
dynamic_cast<::chart::ChartView*>(xTmp.get());
+assert(bool(xTmp)==bool(xNewChartView) && "we only support ChartView");
if( xNewChartView != xChartView )
{
xChartView = xNewChartView;
@@ -283,7 +286,7 @@ void SAL_CALL AccessibleChartView::initialize( const
Sequence< Any >& rArguments
MutexGuard aGuard( m_aMutex);
m_xSelectionSupplier = WeakReference< view::XSelectionSupplier
>(xSelectionSupplier);
m_xChartModel = xChartModel.get();
-m_xChartView = WeakReference< uno::XInterface >(xChartView);
+m_xChartView = xChartView.get();
m_xParent = WeakReference< XAccessible >(xParent);
m_xWindow = WeakReference< awt::XWindow >(xWindow);
}
diff --git a/chart2/source/controller/inc/AccessibleChartView.hxx
b/chart2/source/controller/inc/AccessibleChartView.hxx
index 3e1217d67233..c66578c0c09e 100644
--- a/chart2/source/controller/inc/AccessibleChartView.hxx
+++ b/chart2/source/controller/inc/AccessibleChartView.hxx
@@ -38,6 +38,7 @@ class IAccessibleViewForwarder;
namespace chart
{
+class ChartView;
namespace impl
{
@@ -103,7 +104,7 @@ private: // methods
private: // members
css::uno::WeakReference< css::view::XSelectionSupplier >
m_xSelectionSupplier;
unotools::WeakReference<::chart::ChartModel>
m_xChartModel;
-css::uno::WeakReference< css::uno::XInterface >
m_xChartView;
+unotools::WeakReference< ChartView >
m_xChartView;
css::uno::WeakReference< css::awt::XWindow >m_xWindow;
css::uno::WeakReference< css::accessibility::XAccessible > m_xParent;
[Libreoffice-commits] core.git: chart2/source
chart2/source/controller/dialogs/dlg_InsertErrorBars.cxx |5 +
chart2/source/controller/inc/ChartController.hxx |5 +
chart2/source/controller/inc/dlg_InsertErrorBars.hxx | 10 ++-
chart2/source/controller/main/ChartController.cxx| 24 +++-
chart2/source/controller/main/ChartController_Insert.cxx |1
chart2/source/controller/main/ChartController_Position.cxx |6 +-
chart2/source/controller/main/ChartController_Properties.cxx |3 -
chart2/source/controller/main/ChartController_TextEdit.cxx | 11 +--
chart2/source/controller/main/ChartController_Window.cxx | 32 +++
chart2/source/controller/uitest/uiobject.cxx |8 +-
10 files changed, 48 insertions(+), 57 deletions(-)
New commits:
commit b0e0a74d72af09c01e0c6e1324b42fcc2ef55451
Author: Noel Grandin
AuthorDate: Fri Jan 13 19:18:46 2023 +0200
Commit: Noel Grandin
CommitDate: Sat Jan 14 07:27:31 2023 +
use more concrete types in chart
Change-Id: I87a7aed6f0168e92f3de7e188a1858b93b44a9cd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145489
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/chart2/source/controller/dialogs/dlg_InsertErrorBars.cxx
b/chart2/source/controller/dialogs/dlg_InsertErrorBars.cxx
index 6d3aa87d20a0..7f00dcc976db 100644
--- a/chart2/source/controller/dialogs/dlg_InsertErrorBars.cxx
+++ b/chart2/source/controller/dialogs/dlg_InsertErrorBars.cxx
@@ -23,6 +23,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -68,12 +69,12 @@ void
InsertErrorBarsDialog::SetAxisMinorStepWidthForErrorBarDecimals( double fMi
double InsertErrorBarsDialog::getAxisMinorStepWidthForErrorBarDecimals(
const rtl::Reference<::chart::ChartModel>& xChartModel,
-const Reference< uno::XInterface >& xChartView,
+const rtl::Reference<::chart::ChartView>& xChartView,
std::u16string_view rSelectedObjectCID )
{
double fStepWidth = 0.001;
-ExplicitValueProvider* pExplicitValueProvider(
comphelper::getFromUnoTunnel(xChartView) );
+ExplicitValueProvider* pExplicitValueProvider( xChartView.get() );
if( pExplicitValueProvider )
{
rtl::Reference< Diagram > xDiagram( ChartModelHelper::findDiagram(
xChartModel ) );
diff --git a/chart2/source/controller/inc/ChartController.hxx
b/chart2/source/controller/inc/ChartController.hxx
index f948e3bc6303..63fb4d4fc302 100644
--- a/chart2/source/controller/inc/ChartController.hxx
+++ b/chart2/source/controller/inc/ChartController.hxx
@@ -83,6 +83,7 @@ namespace chart
{
class UndoGuard;
+class ChartView;
class ChartWindow;
class DrawModelWrapper;
class DrawViewWrapper;
@@ -341,7 +342,7 @@ public:
void NotifyUndoActionHdl( std::unique_ptr );
-css::uno::Reference const & getChartView() const;
+rtl::Reference<::chart::ChartView> const & getChartView() const { return
m_xChartView; }
rtl::Reference<::chart::ChartModel> getChartModel();
rtl::Reference<::chart::Diagram> getFirstDiagram();
@@ -395,7 +396,7 @@ private:
//view
css::uno::Reference m_xViewWindow;
-css::uno::Reference m_xChartView;
+rtl::Reference<::chart::ChartView> m_xChartView;
std::shared_ptr< DrawModelWrapper > m_pDrawModelWrapper;
std::unique_ptr m_pDrawViewWrapper;
diff --git a/chart2/source/controller/inc/dlg_InsertErrorBars.hxx
b/chart2/source/controller/inc/dlg_InsertErrorBars.hxx
index 59911c2f5ed2..4f8e8d094a34 100644
--- a/chart2/source/controller/inc/dlg_InsertErrorBars.hxx
+++ b/chart2/source/controller/inc/dlg_InsertErrorBars.hxx
@@ -31,6 +31,8 @@ class XModel;
namespace chart
{
+class ChartView;
+
class InsertErrorBarsDialog final : public weld::GenericDialogController
{
public:
@@ -40,10 +42,10 @@ public:
void SetAxisMinorStepWidthForErrorBarDecimals(double fMinorStepWidth);
-static double getAxisMinorStepWidthForErrorBarDecimals(
-const rtl::Reference<::chart::ChartModel>& xChartModel,
-const css::uno::Reference& xChartView,
-std::u16string_view rSelectedObjectCID);
+static double
+getAxisMinorStepWidthForErrorBarDecimals(const
rtl::Reference<::chart::ChartModel>& xChartModel,
+ const
rtl::Reference<::chart::ChartView>& xChartView,
+ std::u16string_view
rSelectedObjectCID);
void FillItemSet(SfxItemSet& rOutAttrs);
diff --git a/chart2/source/controller/main/ChartController.cxx
b/chart2/source/controller/main/ChartController.cxx
index 1a59bb161ec3..6007499248c1 100644
--- a/chart2/source/controller/main/ChartController.cxx
+++ b/chart2/source/controller/main/ChartController.cxx
@@ -22,6 +22,7 @@
#include
#include
+#include
#include
#include
#include
@@ -543,9 +544,8 @@ sal_Bool SAL_CALL ChartController::attachModel( const
uno::Reference< frame::XMo
//--handle relations to the old
[Libreoffice-commits] core.git: include/xmloff starmath/inc starmath/source sw/source xmloff/source
include/xmloff/xmlimp.hxx |6 --
starmath/inc/mathml/import.hxx |4
starmath/inc/mathml/mathmlimport.hxx|4
starmath/source/mathml/import.cxx | 16 ++--
starmath/source/mathml/mathmlimport.cxx | 14 +-
sw/source/filter/xml/xmlimp.cxx | 12
sw/source/filter/xml/xmlimp.hxx |4
xmloff/source/core/xmlimp.cxx | 15 ++-
8 files changed, 5 insertions(+), 70 deletions(-)
New commits:
commit e07d4c03ac08bc1139420210214e69115cf08586
Author: Noel Grandin
AuthorDate: Thu Jan 12 16:45:39 2023 +0200
Commit: Noel Grandin
CommitDate: Sat Jan 14 07:21:10 2023 +
XUnoTunnel->dynamic_cast in SvXMLImport
Change-Id: I070bc1a8136e5b492c0ea56774a274b9a3d2ec2d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145494
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/include/xmloff/xmlimp.hxx b/include/xmloff/xmlimp.hxx
index 26873175268d..3e1d8966b47b 100644
--- a/include/xmloff/xmlimp.hxx
+++ b/include/xmloff/xmlimp.hxx
@@ -31,7 +31,6 @@
#include
#include
#include
-#include
#include
#include
#include
@@ -182,7 +181,6 @@ class XMLOFF_DLLPUBLIC SAL_LOPLUGIN_ANNOTATE("crosscast")
SvXMLImport : public c
css::lang::XInitialization,
css::document::XImporter,
css::document::XFilter,
- css::lang::XUnoTunnel,
css::xml::sax::XFastParser>
{
friend class SvXMLImportContext;
@@ -354,10 +352,6 @@ public:
// XInitialization
virtual void SAL_CALL initialize( const css::uno::Sequence< css::uno::Any
>& aArguments ) override;
-// XUnoTunnel
-static const css::uno::Sequence& getUnoTunnelId() noexcept;
-virtual sal_Int64 SAL_CALL getSomething( const css::uno::Sequence<
sal_Int8 >& aIdentifier ) override;
-
// XServiceInfo
virtual OUString SAL_CALL getImplementationName( ) final override;
virtual sal_Bool SAL_CALL supportsService( const OUString& ServiceName )
final override;
diff --git a/starmath/inc/mathml/import.hxx b/starmath/inc/mathml/import.hxx
index 56f7fe68814b..312768e43f22 100644
--- a/starmath/inc/mathml/import.hxx
+++ b/starmath/inc/mathml/import.hxx
@@ -115,10 +115,6 @@ public:
virtual ~SmMLImport() noexcept override { cleanup(); };
public:
-// XUnoTunnel
-sal_Int64 SAL_CALL getSomething(const css::uno::Sequence& rId)
override;
-static const css::uno::Sequence& getUnoTunnelId() noexcept;
-
/** End the document
*/
void SAL_CALL endDocument() override;
diff --git a/starmath/inc/mathml/mathmlimport.hxx
b/starmath/inc/mathml/mathmlimport.hxx
index 03a78b92a76d..c18b587f20b5 100644
--- a/starmath/inc/mathml/mathmlimport.hxx
+++ b/starmath/inc/mathml/mathmlimport.hxx
@@ -84,10 +84,6 @@ public:
OUString const& implementationName, SvXMLImportFlags
nImportFlags);
virtual ~SmXMLImport() noexcept override;
-// XUnoTunnel
-sal_Int64 SAL_CALL getSomething(const css::uno::Sequence& rId)
override;
-static const css::uno::Sequence& getUnoTunnelId() noexcept;
-
void SAL_CALL endDocument() override;
SvXMLImportContext* CreateFastContext(
diff --git a/starmath/source/mathml/import.cxx
b/starmath/source/mathml/import.cxx
index 90469abaa0d1..62cd455ad069 100644
--- a/starmath/source/mathml/import.cxx
+++ b/starmath/source/mathml/import.cxx
@@ -429,7 +429,7 @@ ErrCode SmMLImportWrapper::ReadThroughComponentIS(
if (nSyntaxVersion == 5)
{
-SmXMLImport* pXMlImport =
comphelper::getFromUnoTunnel(xFilter);
+SmXMLImport* pXMlImport =
dynamic_cast(xFilter.get());
if (pXMlImport != nullptr && pXMlImport->GetSuccess())
return ERRCODE_NONE;
else
@@ -442,7 +442,7 @@ ErrCode SmMLImportWrapper::ReadThroughComponentIS(
}
}
-m_pMlImport = comphelper::getFromUnoTunnel(xFilter);
+m_pMlImport = dynamic_cast(xFilter.get());
if (m_pMlImport != nullptr && m_pMlImport->getSuccess())
return ERRCODE_NONE;
else
@@ -1203,18 +1203,6 @@ void SmMLImportContext::endFastElement(sal_Int32) {
inheritStyleEnd(); }
// SmMLImport
/*/
-const uno::Sequence& SmMLImport::getUnoTunnelId() noexcept
-{
-static const comphelper::UnoIdInit theSmMLImportUnoTunnelId;
-return theSmMLImportUnoTunnelId.getSeq();
-}
-
-sal_Int64 SAL_CALL SmMLImport::getSomething(const uno::Sequence& rId)
-{
-return comphelper::getSomethingImpl(rId, this,
-
comphelper::FallbackToGetSomethingOf{});
-}
-
SvXMLImportContext*
SmMLImport::CreateFastContext(sal_Int32 nElement,
const
uno::Reference& /*xAttrList*/)
diff --git a/starmath/source/mathml/mathmlimport.cxx
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - sw/qa sw/source writerfilter/source
sw/qa/extras/ooxmlexport/ooxmlexport18.cxx | 13 -
sw/source/filter/ww8/styles.cxx |1
sw/source/filter/ww8/wrtw8sty.cxx | 13 +
writerfilter/source/dmapper/StyleSheetTable.cxx | 232 +---
4 files changed, 142 insertions(+), 117 deletions(-)
New commits:
commit 00943494f782295b1d186045d7307f7924eb8c1d
Author: Mike Kaganski
AuthorDate: Wed Jan 11 17:02:04 2023 +0300
Commit: Mike Kaganski
CommitDate: Sat Jan 14 07:17:41 2023 +
tdf#152425 Synchronize import and export style names mapping
1. Make the mapping in StyleSheetTable::ConvertStyleName match the
opposite direction mapping happening in MSWordStyles::GetWWId and
ww::GetEnglishNameFromSti. Add missing styles, provide comments to
clarify the process and find respective pool format ids.
2. Instead of appending " (user)" to conflicting style names, which
is the method used by SwStyleNameMapper to disambiguate API names,
append " (WW)", which allows to avoid unwanted merging conflicting
styles.
Change-Id: I47b1c7f570da6e6e21155669fdd1b77de5cc17da
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145349
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145377
Tested-by: Jenkins CollaboraOffice
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport18.cxx
b/sw/qa/extras/ooxmlexport/ooxmlexport18.cxx
index 97d1d117e3ea..129e42325640 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport18.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport18.cxx
@@ -147,17 +147,12 @@ CPPUNIT_TEST_FIXTURE(Test, testTdf152425)
// Check that "List Number" and "List 5" styles don't get merged
const OUString Para3Style = getProperty(getParagraph(3),
"ParaStyleName");
-CPPUNIT_ASSERT_EQUAL(OUString("List Number"), Para3Style);
+CPPUNIT_ASSERT_EQUAL(OUString("Numbering 1"), Para3Style);
const OUString Para4Style = getProperty(getParagraph(4),
"ParaStyleName");
-// Eventually, we need to check this:
-// CPPUNIT_ASSERT_EQUAL(OUString("List 5"), Para4Style);
-// But for now, just make sure that the style names differ
-CPPUNIT_ASSERT(Para4Style != Para3Style);
+CPPUNIT_ASSERT_EQUAL(OUString("List 5 (WW)"), Para4Style);
+// Also check that "List 5" and "List Bullet 5" styles don't get merged
const OUString Para5Style = getProperty(getParagraph(5),
"ParaStyleName");
-// Eventually, we need to check this:
-// CPPUNIT_ASSERT_EQUAL(OUString("List Bullet 5"), Para5Style);
-// But for now, just make sure that the style names differ
-CPPUNIT_ASSERT(Para5Style != Para4Style);
+CPPUNIT_ASSERT_EQUAL(OUString("List 5"), Para5Style);
}
CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/sw/source/filter/ww8/styles.cxx b/sw/source/filter/ww8/styles.cxx
index c7a28e77e60b..33d0ad3dec5f 100644
--- a/sw/source/filter/ww8/styles.cxx
+++ b/sw/source/filter/ww8/styles.cxx
@@ -23,6 +23,7 @@
namespace
{
+// Keep in sync with StyleSheetTable::ConvertStyleName
const char **GetStiNames() noexcept
{
// Matches enum ww::sti in sw/source/filter/inc/wwstyles.hxx
diff --git a/sw/source/filter/ww8/wrtw8sty.cxx
b/sw/source/filter/ww8/wrtw8sty.cxx
index b76907229f0d..5fdc76c55aac 100644
--- a/sw/source/filter/ww8/wrtw8sty.cxx
+++ b/sw/source/filter/ww8/wrtw8sty.cxx
@@ -198,6 +198,7 @@ static sal_uInt16 BuildGetSlot(const SwFormat& rFormat)
}
+// Keep in sync with StyleSheetTable::ConvertStyleName
sal_uInt16 MSWordStyles::GetWWId( const SwFormat& rFormat )
{
sal_uInt16 nRet = ww::stiUser;// user style as default
@@ -317,6 +318,14 @@ void MSWordStyles::BuildStylesTable()
}
}
+// StyleSheetTable::ConvertStyleName appends the suffix do disambiguate
conflicting style names
+static OUString StripWWSuffix(const OUString& s)
+{
+OUString ret = s;
+ret.endsWith(" (WW)", );
+return ret;
+}
+
void MSWordStyles::BuildWwNames()
{
std::unordered_set aUsed;
@@ -361,9 +370,9 @@ void MSWordStyles::BuildWwNames()
if (!entry.ww_name.isEmpty())
continue;
if (entry.format)
-entry.ww_name = entry.format->GetName();
+entry.ww_name = StripWWSuffix(entry.format->GetName());
else if (entry.num_rule)
-entry.ww_name = entry.num_rule->GetName();
+entry.ww_name = StripWWSuffix(entry.num_rule->GetName());
else
continue;
makeUniqueName(entry.ww_name);
diff --git a/writerfilter/source/dmapper/StyleSheetTable.cxx
b/writerfilter/source/dmapper/StyleSheetTable.cxx
index 8b3bc02b44a6..d82bc3ed61fa 100644
--- a/writerfilter/source/dmapper/StyleSheetTable.cxx
+++ b/writerfilter/source/dmapper/StyleSheetTable.cxx
@@ -1418,129 +1418,141 @@ OUString StyleSheetTable::ConvertStyleName( const
OUString& rWWName, bool bExten
//search for the rWWName in the IdentifierD of the existing styles
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - 2 commits - sw/qa sw/source
sw/qa/extras/ooxmlexport/data/tdf152425.docx |binary
sw/qa/extras/ooxmlexport/ooxmlexport13.cxx |8 -
sw/qa/extras/ooxmlexport/ooxmlexport16.cxx |2
sw/qa/extras/ooxmlexport/ooxmlexport18.cxx | 19 ++
sw/source/filter/inc/wwstyles.hxx|1
sw/source/filter/ww8/docxattributeoutput.cxx | 16 +-
sw/source/filter/ww8/styles.cxx | 185 +--
sw/source/filter/ww8/wrtw8sty.cxx| 142 +++-
sw/source/filter/ww8/wrtww8.hxx | 10 +
9 files changed, 209 insertions(+), 174 deletions(-)
New commits:
commit 673f59684f8bd2aac29c703f07fdb91165a38775
Author: Mike Kaganski
AuthorDate: Sat Dec 10 08:58:10 2022 +0300
Commit: Mike Kaganski
CommitDate: Sat Jan 14 07:17:31 2023 +
tdf#152425 Make Word names unique, and use them for style ids generation
Before, a style id was generated from LibreOffice name, and then the
name was replaced with Word name. Given that Writer's List N maps to
Word's List Bullet N, and Word's List N doesn't map to anything in
Writer, this led to styles.xml having after roundtrip:
...
So the idea is to do the following steps:
1. Collect all the exported styles (unchanged);
2. Build unique Word names for collected styles (new):
a. Process all the styles that map to special Word styles first,
so that their Word names don't get changed when made unique;
b. Process the rest of the styles, making sure to append a sequential
number after the Writer name, if a clash happens.
3. Build Style Ids from the Word names (previously Writer name could be
used), also making sure they are unique.
Change-Id: I9f8f254aa6ae713671234f0109b94cc72a588150
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143905
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145376
Tested-by: Jenkins CollaboraOffice
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport13.cxx
b/sw/qa/extras/ooxmlexport/ooxmlexport13.cxx
index 671d9c9958db..cd194b5c68f1 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport13.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport13.cxx
@@ -1238,8 +1238,8 @@ CPPUNIT_TEST_FIXTURE(Test, testTdf123628)
xmlDocUniquePtr pXmlStyles = parseExport("word/styles.xml");
-assertXPath(pXmlDoc,
"/w:document/w:body/w:p[1]/w:hyperlink/w:r/w:rPr/w:rStyle", "val",
"InternetLink");
-assertXPath(pXmlStyles,
"/w:styles/w:style[@w:styleId='InternetLink']/w:name", "val", "Hyperlink");
+assertXPath(pXmlDoc,
"/w:document/w:body/w:p[1]/w:hyperlink/w:r/w:rPr/w:rStyle", "val", "Hyperlink");
+assertXPath(pXmlStyles,
"/w:styles/w:style[@w:styleId='Hyperlink']/w:name", "val", "Hyperlink");
}
DECLARE_OOXMLEXPORT_TEST(testTdf127741, "tdf127741.docx")
@@ -1265,7 +1265,7 @@ CPPUNIT_TEST_FIXTURE(Test, testTdf127925)
loadAndSave("tdf127925.odt");
CPPUNIT_ASSERT_EQUAL(1, getPages());
xmlDocUniquePtr pXmlStyles = parseExport("word/styles.xml");
-assertXPath(pXmlStyles,
"/w:styles/w:style[@w:styleId='VisitedInternetLink']/w:name", "val",
"FollowedHyperlink");
+assertXPath(pXmlStyles,
"/w:styles/w:style[@w:styleId='FollowedHyperlink']/w:name", "val",
"FollowedHyperlink");
}
CPPUNIT_TEST_FIXTURE(Test, testTdf127579)
@@ -1273,7 +1273,7 @@ CPPUNIT_TEST_FIXTURE(Test, testTdf127579)
loadAndSave("tdf127579.odt");
CPPUNIT_ASSERT_EQUAL(1, getPages());
xmlDocUniquePtr pXmlDoc = parseExport("word/document.xml");
-assertXPath(pXmlDoc,
"/w:document/w:body/w:p/w:hyperlink/w:r/w:rPr/w:rStyle", "val", "InternetLink");
+assertXPath(pXmlDoc,
"/w:document/w:body/w:p/w:hyperlink/w:r/w:rPr/w:rStyle", "val", "Hyperlink");
}
DECLARE_OOXMLEXPORT_TEST(testTdf128304, "tdf128304.odt")
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport16.cxx
b/sw/qa/extras/ooxmlexport/ooxmlexport16.cxx
index ae8b96c99f66..22c3b75c5e87 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport16.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport16.cxx
@@ -984,7 +984,7 @@ DECLARE_OOXMLEXPORT_TEST(testTdf143726, "Simple-TOC.odt")
CPPUNIT_ASSERT(pXmlStyles);
// Without the fix this was "TOA Heading" which belongs to the "Table of
Authorities" index in Word
// TOC's heading style should be exported as "TOC Heading" as that's the
default Word style name
-assertXPath(pXmlStyles,
"/w:styles/w:style[@w:styleId='ContentsHeading']/w:name", "val", "TOC Heading");
+assertXPath(pXmlStyles,
"/w:styles/w:style[@w:styleId='TOCHeading']/w:name", "val", "TOC Heading");
}
CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport18.cxx
b/sw/qa/extras/ooxmlexport/ooxmlexport18.cxx
index 37b1bad5d10e..97d1d117e3ea 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport18.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport18.cxx
@@ -153,6 +153,11 @@
[Libreoffice-bugs] [Bug 105681] 5.3.0.3 installer hangs when custom option to install to d: drive selected
https://bugs.documentfoundation.org/show_bug.cgi?id=105681 Stéphane Guillou (stragu) changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #12 from Stéphane Guillou (stragu) --- Jean-Baptiste's link to the French mailing list doesn't work anymore, here is a working one: https://www.mail-archive.com/users@fr.libreoffice.org/msg40909.html The issue was reported in 2018 for LO 5.4, Windows 10. The reporter says the installer tries to install to the C drive anyway. Paul replied via email and said he wasn't able to test because of different hardware. Duplicate bug 112895 could be a false-positive related to the unpacking of the installer on a nearly-full C drive. Tempted to close as "works for me" because no one has reproduced since 2018 and LO 5.4. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: comphelper/source
comphelper/source/misc/SelectionMultiplex.cxx |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
New commits:
commit e4e2c7a63217c797802045d326f732296e0af918
Author: Xisco Fauli
AuthorDate: Fri Jan 13 11:42:38 2023 +0100
Commit: Noel Grandin
CommitDate: Sat Jan 14 06:41:06 2023 +
comphelper: check for nullptr
See
https://crashreport.libreoffice.org/stats/signature/comphelper::OSelectionChangeMultiplexer::dispose()
Regression from 9931d6b1fb0406e16d56e186812884511738dcfa
"tdf#150575: REPORTBUILDER: Crash when closing report when used report
navigator"
Change-Id: I6e4ada368254879d983f80026e9b42ddb4186c51
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145461
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/comphelper/source/misc/SelectionMultiplex.cxx
b/comphelper/source/misc/SelectionMultiplex.cxx
index e4fb824a0ba3..438eaa80d718 100644
--- a/comphelper/source/misc/SelectionMultiplex.cxx
+++ b/comphelper/source/misc/SelectionMultiplex.cxx
@@ -100,7 +100,8 @@ void OSelectionChangeMultiplexer::dispose()
osl_atomic_increment(_refCount);
{
Reference< XSelectionChangeListener> xPreventDelete(this);
-m_xSet->removeSelectionChangeListener(xPreventDelete);
+if(m_xSet.is())
+m_xSet->removeSelectionChangeListener(xPreventDelete);
}
osl_atomic_decrement(_refCount);
}
[Libreoffice-commits] core.git: include/toolkit toolkit/source
include/toolkit/controls/unocontrolmodel.hxx | 10 ++
toolkit/source/controls/unocontrolmodel.cxx | 13 -
2 files changed, 2 insertions(+), 21 deletions(-)
New commits:
commit 678747f95083be6f3e4d184e6258e49086952f45
Author: Noel Grandin
AuthorDate: Thu Jan 12 15:59:22 2023 +0200
Commit: Noel Grandin
CommitDate: Sat Jan 14 06:36:58 2023 +
XUnoTunnel->dynamic_cast in UnoControlModel
Change-Id: I0d8a65aa16583fcb6c8201589b2d356da0be5cac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145482
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/include/toolkit/controls/unocontrolmodel.hxx
b/include/toolkit/controls/unocontrolmodel.hxx
index fb22dc3e4383..fb32aa5b0860 100644
--- a/include/toolkit/controls/unocontrolmodel.hxx
+++ b/include/toolkit/controls/unocontrolmodel.hxx
@@ -25,7 +25,6 @@
#include
#include
#include
-#include
#include
#include
@@ -33,7 +32,7 @@
#include
#include
-#include
+#include
#include
#include
@@ -47,12 +46,11 @@ typedef std::map
ImplPropertyTable;
-typedef ::cppu::WeakAggImplHelper7 < css::awt::XControlModel
+typedef ::cppu::WeakAggImplHelper6 < css::awt::XControlModel
, css::beans::XPropertyState
, css::io::XPersistObject
, css::lang::XComponent
, css::lang::XServiceInfo
-, css::lang::XUnoTunnel
, css::util::XCloneable
> UnoControlModel_Base;
@@ -130,10 +128,6 @@ public:
// css::uno::XAggregation
css::uno::Any SAL_CALL queryAggregation( const css::uno::Type & rType )
override;
-// css::lang::XUnoTunnel
-static const css::uno::Sequence< sal_Int8 >& getUnoTunnelId() noexcept;
-sal_Int64 SAL_CALL
getSomething( const css::uno::Sequence< sal_Int8 >& rIdentifier ) override;
-
// css::util::XCloneable
css::uno::Reference< css::util::XCloneable > SAL_CALL createClone()
override;
diff --git a/toolkit/source/controls/unocontrolmodel.cxx
b/toolkit/source/controls/unocontrolmodel.cxx
index 983ea89459ee..3147164332bd 100644
--- a/toolkit/source/controls/unocontrolmodel.cxx
+++ b/toolkit/source/controls/unocontrolmodel.cxx
@@ -420,19 +420,6 @@ css::uno::Any UnoControlModel::queryAggregation( const
css::uno::Type & rType )
return aRet;
}
-// css::lang::XUnoTunnel
-
-const css::uno::Sequence< sal_Int8 >& UnoControlModel::getUnoTunnelId()
noexcept
-{
-static const comphelper::UnoIdInit theUnoControlModelUnoTunnelId;
-return theUnoControlModelUnoTunnelId.getSeq();
-}
-
-sal_Int64 UnoControlModel::getSomething( const css::uno::Sequence< sal_Int8 >&
rIdentifier )
-{
-return comphelper::getSomethingImpl(rIdentifier, this);
-}
-
// XInterface
IMPLEMENT_FORWARD_REFCOUNT( UnoControlModel, UnoControlModel_Base )
[Libreoffice-commits] core.git: framework/source include/sfx2 include/svtools reportdesign/source sfx2/source svtools/source sw/source
framework/source/uielement/controlmenucontroller.cxx |1 framework/source/uielement/fontmenucontroller.cxx |1 framework/source/uielement/fontsizemenucontroller.cxx |1 framework/source/uielement/headermenucontroller.cxx|1 framework/source/uielement/langselectionmenucontroller.cxx |1 framework/source/uielement/macrosmenucontroller.cxx|1 framework/source/uielement/newmenucontroller.cxx |6 - framework/source/uielement/objectmenucontroller.cxx|1 framework/source/uielement/popuptoolbarcontroller.cxx | 15 - framework/source/uielement/recentfilesmenucontroller.cxx |1 framework/source/uielement/resourcemenucontroller.cxx | 11 +++-- framework/source/uielement/thesaurusmenucontroller.cxx |1 framework/source/uielement/toolbarmodemenucontroller.cxx |4 ++- framework/source/uielement/toolbarsmenucontroller.cxx |4 ++- include/sfx2/dispatch.hxx |4 ++- include/sfx2/viewsh.hxx|7 +++--- include/svtools/popupmenucontrollerbase.hxx|4 ++- reportdesign/source/ui/report/ReportSection.cxx|5 +--- sfx2/source/control/dispatch.cxx |8 ++ sfx2/source/notebookbar/NotebookbarTabControl.cxx |4 +-- sfx2/source/view/viewsh.cxx| 10 svtools/source/uno/popupmenucontrollerbase.cxx |4 ++- sw/source/uibase/docvw/edtwin.cxx |4 +-- sw/source/uibase/docvw/romenu.hxx |3 +- sw/source/uibase/inc/olmenu.hxx|3 +- sw/source/uibase/uiview/viewling.cxx |4 +-- 26 files changed, 58 insertions(+), 51 deletions(-) New commits: commit 793904ff3a7d8cceafab3d83a562261c4c17fd14 Author: Noel Grandin AuthorDate: Fri Jan 13 14:50:36 2023 +0200 Commit: Noel Grandin CommitDate: Sat Jan 14 06:36:24 2023 + use more VCLXPopupMenu instead of XPopupMenu which avoids a bunch of casting and makes the dependency explicit instead of implicit Change-Id: I754da72916fbbc51e7edc3c806155da34d347bd8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145472 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/framework/source/uielement/controlmenucontroller.cxx b/framework/source/uielement/controlmenucontroller.cxx index 2c31081bbe6b..dec13831646f 100644 --- a/framework/source/uielement/controlmenucontroller.cxx +++ b/framework/source/uielement/controlmenucontroller.cxx @@ -31,6 +31,7 @@ #include #include #include +#include #include #include diff --git a/framework/source/uielement/fontmenucontroller.cxx b/framework/source/uielement/fontmenucontroller.cxx index c0dd19e2e71a..e25b5b210b83 100644 --- a/framework/source/uielement/fontmenucontroller.cxx +++ b/framework/source/uielement/fontmenucontroller.cxx @@ -33,6 +33,7 @@ #include #include #include +#include // Defines diff --git a/framework/source/uielement/fontsizemenucontroller.cxx b/framework/source/uielement/fontsizemenucontroller.cxx index 4c5c686888a9..e050c1659eb6 100644 --- a/framework/source/uielement/fontsizemenucontroller.cxx +++ b/framework/source/uielement/fontsizemenucontroller.cxx @@ -34,6 +34,7 @@ #include #include #include +#include #include #include #include diff --git a/framework/source/uielement/headermenucontroller.cxx b/framework/source/uielement/headermenucontroller.cxx index cbcdc33bc5fa..842e74559fac 100644 --- a/framework/source/uielement/headermenucontroller.cxx +++ b/framework/source/uielement/headermenucontroller.cxx @@ -33,6 +33,7 @@ #include #include #include +#include // Defines diff --git a/framework/source/uielement/langselectionmenucontroller.cxx b/framework/source/uielement/langselectionmenucontroller.cxx index 94918c02179a..51994c1021a0 100644 --- a/framework/source/uielement/langselectionmenucontroller.cxx +++ b/framework/source/uielement/langselectionmenucontroller.cxx @@ -29,6 +29,7 @@ #include #include +#include #include #include diff --git a/framework/source/uielement/macrosmenucontroller.cxx b/framework/source/uielement/macrosmenucontroller.cxx index a0745b1e4f6f..b15b3191efe7 100644 --- a/framework/source/uielement/macrosmenucontroller.cxx +++ b/framework/source/uielement/macrosmenucontroller.cxx @@ -26,6 +26,7 @@ #include #include #include +#include #include using namespace com::sun::star::uno; diff --git a/framework/source/uielement/newmenucontroller.cxx b/framework/source/uielement/newmenucontroller.cxx index 14b59c263b85..c36818341ad0 100644 --- a/framework/source/uielement/newmenucontroller.cxx +++ b/framework/source/uielement/newmenucontroller.cxx @@ -395,15 +395,11 @@ void SAL_CALL NewMenuController::itemActivated( const
[Libreoffice-bugs] [Bug 153019] New: LibreOffice calc recovery does not recover hours of unsaved work
https://bugs.documentfoundation.org/show_bug.cgi?id=153019 Bug ID: 153019 Summary: LibreOffice calc recovery does not recover hours of unsaved work Product: LibreOffice Version: 7.4.3.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: documentationfoundat...@jen.fastmail.org Description: My desktop (Fedora 37) running LibreOffice 7.4.3.2 was asleep after I closed the lid. Upon opening the lid, the unlock screen was unresponsive to keyboard or mouse presses; attempting to switch to the console (F1) was also unsuccessful. I had to press and hold the power button to force the system to turn off. Upon reboot, I launched LibreOffice Calc and recovered the .xlsx file I had been editing. Unfortunately, there was very little if any recovery data, and I had lost hours of work. This is unexpected behavior; earlier versions of LibreOffice Calc (on Fedora 36) would recover most if not all of the cached changes. Steps to Reproduce: 1.Open an .xlsx file 2.Type in cells, create a sheet. 3.Wait 20 minutes. 4.Power off and reboot the system. 5.Launch LibreOffice Calc and recover the file. Actual Results: No (or very little) recovery occurs. Expected Results: Almost--if not all--recovery occurs. Reproducible: Always User Profile Reset: No Additional Info: [Information automatically included from LibreOffice] Locale: en-US Module: SpreadsheetDocument [Information guessed from browser] OS: Linux (All) OS is 64bit: yes Version: 7.4.3.2 Build ID: 40(Build:2) CPU threads: 16; OS: Linux 6.0; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 39936] UI: Right Click on Row/Column -> Insert Copied Cells... (paste + shift cells in one click)
https://bugs.documentfoundation.org/show_bug.cgi?id=39936 Greg changed: What|Removed |Added CC||greg...@hotmail.com --- Comment #65 from Greg --- I've wanted to see this feature added to Calc for years, and wondered why it's never been addressed. The "drag" method works, but is hard to use if scrolling is involved -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 72504] EDITING: Unable to edit .odb file with non-local URL
https://bugs.documentfoundation.org/show_bug.cgi?id=72504 --- Comment #40 from triumphg...@gmail.com --- Tested today as per request #39 from QA Administrators. Test done with: LibreOffice version 7.3.6.2. Environment: CPU threads: 16; OS: Linux 5.15 User Interface: UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Misc: Ubuntu package version: 1.7.3.6.2-0ubuntu0.22.04.2. Calc: threaded Problem still exists, as per error message box: "The connection to the data source "Database name" could not be established. SQL Status: HY000 The given URL contains no valid local file system path. Please check the location of your database file. ./connectivity/source/commontools/dbexception.cxx:413" -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 104271] New comment box should automatically re-position and re-size appropriately based on the shape of text pasted into it
https://bugs.documentfoundation.org/show_bug.cgi?id=104271 --- Comment #24 from giaverma --- Thank you for sharing this amazing and great site and knowledge with us. http://www.callgirlfriendrelationship.com/ http://www.callgirlfriendrelationship.com/night-partner-in-hyderabad-call-girls.html http://www.callgirlfriendrelationship.com/chennai-call-girl-number-whatsapp.html http://www.callgirlfriendrelationship.com/bangalore-call-girl-number.html http://www.callgirlfriendrelationship.com/sexy-bhabhi-whatsapp-number.html -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 104271] New comment box should automatically re-position and re-size appropriately based on the shape of text pasted into it
https://bugs.documentfoundation.org/show_bug.cgi?id=104271 --- Comment #23 from giaverma --- This is great post here. Gratitude for getting some margin to post such important data. Quality substance generally gets the guests coming. https://www.pinkjaipurescorts.com/ https://www.pinkjaipurescorts.com/russian-escorts-jaipur.html https://www.pinkjaipurescorts.com/independent-escorts-jaipur.html https://www.pinkjaipurescorts.com/hotel-escorts-jaipur.html https://www.pinkjaipurescorts.com/alwar-escorts.html https://www.pinkjaipurescorts.com/ajmer-escorts.html https://www.pinkjaipurescorts.com/jodhpur-escorts.html -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 104271] New comment box should automatically re-position and re-size appropriately based on the shape of text pasted into it
https://bugs.documentfoundation.org/show_bug.cgi?id=104271 --- Comment #22 from giaverma --- I have been looking at a couple of your accounts and I can state very great stuff. I will bookmark your blog. https://www.callgirlsservicejaipur.com/ https://www.dirtyescortsmodels.in/ https://www.callgiral.in/ https://www.agraescort.co.in/ https://www.babesofcochin.in/ -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: 3 commits - include/svx oox/source svx/source
include/svx/ColorSets.hxx | 15 --
oox/source/drawingml/clrscheme.cxx | 24 ++--
svx/source/styles/ColorSets.cxx| 214 +
3 files changed, 162 insertions(+), 91 deletions(-)
New commits:
commit 2ec4a66b6d049f5d11f4ceb993ed907c790ed592
Author: Tomaž Vajngerl
AuthorDate: Thu Jan 5 23:37:18 2023 +0900
Commit: Tomaž Vajngerl
CommitDate: Sat Jan 14 04:44:15 2023 +
svx: add UX defined theme color sets
Change-Id: I82cbe16fcfaa8367dacda7ff977e18b0ed39ec2f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145086
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/svx/source/styles/ColorSets.cxx b/svx/source/styles/ColorSets.cxx
index cf634b735c37..439c63d1ee35 100644
--- a/svx/source/styles/ColorSets.cxx
+++ b/svx/source/styles/ColorSets.cxx
@@ -171,7 +171,103 @@ ColorSets::~ColorSets()
void ColorSets::init()
{
-//{
+{
+ColorSet aColorSet("LibreOffice");
+aColorSet.add(model::ThemeColorType::Dark1, 0x00);
+aColorSet.add(model::ThemeColorType::Light1, 0xFF);
+aColorSet.add(model::ThemeColorType::Dark2, 0x00);
+aColorSet.add(model::ThemeColorType::Light2, 0xFF);
+aColorSet.add(model::ThemeColorType::Accent1, 0x18A303);
+aColorSet.add(model::ThemeColorType::Accent2, 0x0369A3);
+aColorSet.add(model::ThemeColorType::Accent3, 0xA33E03);
+aColorSet.add(model::ThemeColorType::Accent4, 0x8E03A3);
+aColorSet.add(model::ThemeColorType::Accent5, 0xC99C00);
+aColorSet.add(model::ThemeColorType::Accent6, 0xC9211E);
+aColorSet.add(model::ThemeColorType::Hyperlink, 0xEE);
+aColorSet.add(model::ThemeColorType::FollowedHyperlink, 0x551A8B);
+maColorSets.push_back(aColorSet);
+}
+{
+ColorSet aColorSet("Rainbow");
+aColorSet.add(model::ThemeColorType::Dark1, 0x00);
+aColorSet.add(model::ThemeColorType::Light1, 0xFF);
+aColorSet.add(model::ThemeColorType::Dark2, 0x1C1C1C);
+aColorSet.add(model::ThemeColorType::Light2, 0xDD);
+aColorSet.add(model::ThemeColorType::Accent1, 0xFF);
+aColorSet.add(model::ThemeColorType::Accent2, 0xFF8000);
+aColorSet.add(model::ThemeColorType::Accent3, 0x00);
+aColorSet.add(model::ThemeColorType::Accent4, 0x00A933);
+aColorSet.add(model::ThemeColorType::Accent5, 0x2A6099);
+aColorSet.add(model::ThemeColorType::Accent6, 0x800080);
+aColorSet.add(model::ThemeColorType::Hyperlink, 0xEE);
+aColorSet.add(model::ThemeColorType::FollowedHyperlink, 0x551A8B);
+maColorSets.push_back(aColorSet);
+}
+{
+ColorSet aColorSet("Beach");
+aColorSet.add(model::ThemeColorType::Dark1, 0x00);
+aColorSet.add(model::ThemeColorType::Light1, 0xFF);
+aColorSet.add(model::ThemeColorType::Dark2, 0xFFBF00);
+aColorSet.add(model::ThemeColorType::Light2, 0x33);
+aColorSet.add(model::ThemeColorType::Accent1, 0xFFF5CE);
+aColorSet.add(model::ThemeColorType::Accent2, 0xDEE6EF);
+aColorSet.add(model::ThemeColorType::Accent3, 0xE8F2A1);
+aColorSet.add(model::ThemeColorType::Accent4, 0xFFD7D7);
+aColorSet.add(model::ThemeColorType::Accent5, 0xDEE7E5);
+aColorSet.add(model::ThemeColorType::Accent6, 0xDDDBB6);
+aColorSet.add(model::ThemeColorType::Hyperlink, 0xEE);
+aColorSet.add(model::ThemeColorType::FollowedHyperlink, 0xEE77D7);
+maColorSets.push_back(aColorSet);
+}
+{
+ColorSet aColorSet("Sunset");
+aColorSet.add(model::ThemeColorType::Dark1, 0x00);
+aColorSet.add(model::ThemeColorType::Light1, 0xFF);
+aColorSet.add(model::ThemeColorType::Dark2, 0x492300);
+aColorSet.add(model::ThemeColorType::Light2, 0xF6F9D4);
+aColorSet.add(model::ThemeColorType::Accent1, 0x00);
+aColorSet.add(model::ThemeColorType::Accent2, 0xFFBF00);
+aColorSet.add(model::ThemeColorType::Accent3, 0xFF8000);
+aColorSet.add(model::ThemeColorType::Accent4, 0xFF4000);
+aColorSet.add(model::ThemeColorType::Accent5, 0xBF0041);
+aColorSet.add(model::ThemeColorType::Accent6, 0x800080);
+aColorSet.add(model::ThemeColorType::Hyperlink, 0xEE);
+aColorSet.add(model::ThemeColorType::FollowedHyperlink, 0x551A8B);
+maColorSets.push_back(aColorSet);
+}
+{
+ColorSet aColorSet("Ocean");
+aColorSet.add(model::ThemeColorType::Dark1, 0x00);
+aColorSet.add(model::ThemeColorType::Light1, 0xFF);
+aColorSet.add(model::ThemeColorType::Dark2, 0x2A6099);
+aColorSet.add(model::ThemeColorType::Light2, 0xCC);
+aColorSet.add(model::ThemeColorType::Accent1, 0x800080);
+aColorSet.add(model::ThemeColorType::Accent2, 0x55308D);
+
[Libreoffice-bugs] [Bug 120230] Palette of colors on tool bar 'Color Bar' cannot be set directly; palette chosen elsewhere is used only after restart
https://bugs.documentfoundation.org/show_bug.cgi?id=120230 --- Comment #8 from V Stuart Foote --- Issue remains, the Draw 'Color bar' does not refresh with palette selection, and no drop list widget with the color bar to directly change it. Version: 7.4.3.2 (x64) / LibreOffice Community Build ID: 1048a8393ae2eeec98dff31b5c133c5f1d08b890 CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153018] New: The entire document loses formatting done when I use the clone formatting tool
https://bugs.documentfoundation.org/show_bug.cgi?id=153018 Bug ID: 153018 Summary: The entire document loses formatting done when I use the clone formatting tool Product: LibreOffice Version: 7.4.3.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jacc90...@gmail.com Description: Working with numbered schemes in writer, when cloning formatting from one paragraph to another, all document formatting is lost (font, size, tables, etc.). The same thing happened when inserting rows or columns into a table. Steps to Reproduce: 1.I have an schemes list in a table. 2.When I insert a new row, all the table an its content lost them previous format (font, size, color background, etc.) 3.When I clone the format of the list happen the same issue Actual Results: All the table an its content lost them previous format (font, size, color background, etc.) Expected Results: The table should keep its previuos format Reproducible: Always User Profile Reset: No Additional Info: SO Ubuntu 20.04 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152920] LO Writer: User Input fields in header or footer not visible in freshly opened documents
https://bugs.documentfoundation.org/show_bug.cgi?id=152920 QA Administrators changed: What|Removed |Added Keywords||bibisectRequest -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152743] Table elements not accessible in field formulas and text field formulas not available in table cells
https://bugs.documentfoundation.org/show_bug.cgi?id=152743 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152730] Trying to open a file from StartCenter gets some warnings in console with debug LO
https://bugs.documentfoundation.org/show_bug.cgi?id=152730 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152739] Round ROUND_HALF_UP is OK in Python, but NO in Basic when call the same Python def.
https://bugs.documentfoundation.org/show_bug.cgi?id=152739 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152741] Single line plain text content control created with MS Word not recognized by Libre Office
https://bugs.documentfoundation.org/show_bug.cgi?id=152741 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152999] UI: Document background color in settings overrides cell background colors in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=152999 --- Comment #4 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152736] Editing the resolution of jpg or png exports changes physical image size by default
https://bugs.documentfoundation.org/show_bug.cgi?id=152736 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152742] Writer tells me I'm writing Afrikaans - but I never chose that
https://bugs.documentfoundation.org/show_bug.cgi?id=152742 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152742] Writer tells me I'm writing Afrikaans - but I never chose that
https://bugs.documentfoundation.org/show_bug.cgi?id=152742 --- Comment #9 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149419] Footnote numbers aren't reset between letters in mail merge
https://bugs.documentfoundation.org/show_bug.cgi?id=149419 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149419] Footnote numbers aren't reset between letters in mail merge
https://bugs.documentfoundation.org/show_bug.cgi?id=149419 --- Comment #3 from QA Administrators --- Dear c+lobug, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 90407] AutoFit option not exported in ppt
https://bugs.documentfoundation.org/show_bug.cgi?id=90407 --- Comment #22 from QA Administrators --- Dear Ljiljan, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 89089] Editing: no keyboard shortcut to simultaneously apply default Paragraph Style while removing any applied character styles
https://bugs.documentfoundation.org/show_bug.cgi?id=89089 --- Comment #13 from QA Administrators --- Dear Cor Nouws, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 86896] FRAMEWORK: Command line help not translated
https://bugs.documentfoundation.org/show_bug.cgi?id=86896 --- Comment #11 from QA Administrators --- Dear Olivier Hallot, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 72504] EDITING: Unable to edit .odb file with non-local URL
https://bugs.documentfoundation.org/show_bug.cgi?id=72504 --- Comment #39 from QA Administrators --- Dear TriumphGuru, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139213] Formatting depends on fonts used
https://bugs.documentfoundation.org/show_bug.cgi?id=139213 --- Comment #5 from QA Administrators --- Dear Prince Singh Tomar, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 122473] FILEOPEN XLSX, Pivot table’s labels lose their orientation in LO
https://bugs.documentfoundation.org/show_bug.cgi?id=122473 --- Comment #7 from QA Administrators --- Dear NISZ LibreOffice Team, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 122024] merged cells become unmerged when deleting first row or column
https://bugs.documentfoundation.org/show_bug.cgi?id=122024 --- Comment #9 from QA Administrators --- Dear raal, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 121751] Cursor overlaps comment when shown in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=121751 --- Comment #7 from QA Administrators --- Dear Dan Dascalescu, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 121741] Clicking in of text box with placeholder text generates an Undo step
https://bugs.documentfoundation.org/show_bug.cgi?id=121741 --- Comment #6 from QA Administrators --- Dear Aron Budea, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 121455] hang: Doesn't open embedded PDF file from .odt
https://bugs.documentfoundation.org/show_bug.cgi?id=121455 --- Comment #14 from QA Administrators --- Dear Maarten van Druten, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 112781] loadComponentFromUrl forces the window to full-screen
https://bugs.documentfoundation.org/show_bug.cgi?id=112781 --- Comment #8 from QA Administrators --- Dear Stéphane Aulery, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 120230] Palette of colors on tool bar 'Color Bar' cannot be set directly; palette chosen elsewhere is used only after restart
https://bugs.documentfoundation.org/show_bug.cgi?id=120230 --- Comment #7 from QA Administrators --- Dear Cor Nouws, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153000] FILEOPEN DOCX file types MSO_SPT=25 to 31 are wrongly rendered
https://bugs.documentfoundation.org/show_bug.cgi?id=153000 --- Comment #9 from Regina Henschel --- In this place is nothing more to do. The wrong size in docx and the wrong handle position in rtf have to be solved somewhere else. Unit test will come, but I first need to update and build my repository, which takes some time. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: include/editeng include/oox include/svx oox/inc oox/qa oox/source sd/source svx/source
include/editeng/unoprnms.hxx |1
include/oox/export/drawingml.hxx |2
include/svx/unoshprp.hxx |1
oox/inc/drawingml/lineproperties.hxx |3 -
oox/qa/unit/data/ThemeShapesReference.pptx |binary
oox/qa/unit/drawingml.cxx | 71 -
oox/source/drawingml/lineproperties.cxx| 34 -
oox/source/drawingml/shape.cxx |4 +
oox/source/export/drawingml.cxx| 64 +-
oox/source/token/properties.txt|1
sd/source/core/stlsheet.cxx| 10
svx/source/table/cell.cxx | 12
svx/source/unodraw/unoshape.cxx| 10
svx/source/xoutdev/xattr.cxx | 44 +++--
14 files changed, 192 insertions(+), 65 deletions(-)
New commits:
commit af8fdba1194e657237f9abc460381a1c4bc49982
Author: Tomaž Vajngerl
AuthorDate: Thu Jan 5 13:12:34 2023 +0900
Commit: Tomaž Vajngerl
CommitDate: Fri Jan 13 23:07:22 2023 +
support theme color for lines + oox support + tests
Extended XLineColor to handle model::ThemeColor which then maps
to the newly added LineColorThemeData property.
Extended oox import and export to map the scheme color elements
to and from ThemeColor. Added a new test to check the theme line
color in impress shapes.
Change-Id: I23ecc18c88b5b47608c9110f5681f189d02e2f36
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145071
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/include/editeng/unoprnms.hxx b/include/editeng/unoprnms.hxx
index 7f82cd0b1fea..300a0a2b7765 100644
--- a/include/editeng/unoprnms.hxx
+++ b/include/editeng/unoprnms.hxx
@@ -77,6 +77,7 @@ inline constexpr OUStringLiteral UNO_NAME_LINESTYLE =
u"LineStyle";
inline constexpr OUStringLiteral UNO_NAME_LINEDASH = u"LineDash";
inline constexpr OUStringLiteral UNO_NAME_LINEWIDTH = u"LineWidth";
inline constexpr OUStringLiteral UNO_NAME_LINECOLOR = u"LineColor";
+inline constexpr OUStringLiteral UNO_NAME_LINECOLOR_THEME_REFERENCE =
u"LineColorThemeReference";
inline constexpr OUStringLiteral UNO_NAME_LINEJOINT = u"LineJoint";
inline constexpr OUStringLiteral UNO_NAME_LINESTART = u"LineStart";
inline constexpr OUStringLiteral UNO_NAME_LINEEND = u"LineEnd";
diff --git a/include/oox/export/drawingml.hxx b/include/oox/export/drawingml.hxx
index eb0fea23b95c..c131632aea8d 100644
--- a/include/oox/export/drawingml.hxx
+++ b/include/oox/export/drawingml.hxx
@@ -235,7 +235,7 @@ public:
void WriteConnectorConnections( sal_Int32 nStartGlueId, sal_Int32
nEndGlueId, sal_Int32 nStartID, sal_Int32 nEndID );
bool WriteCharColor(const css::uno::Reference&
xPropertySet);
-bool WriteFillColor(const css::uno::Reference&
xPropertySet);
+bool WriteSchemeColor(OUString const& rPropertyName, const
css::uno::Reference& xPropertySet);
void WriteSolidFill( ::Color nColor, sal_Int32 nAlpha = MAX_PERCENT );
void WriteSolidFill( const OUString& sSchemeName, const
css::uno::Sequence< css::beans::PropertyValue >& aTransformations, sal_Int32
nAlpha = MAX_PERCENT );
diff --git a/include/svx/unoshprp.hxx b/include/svx/unoshprp.hxx
index 8af8142c1d43..70be33007013 100644
--- a/include/svx/unoshprp.hxx
+++ b/include/svx/unoshprp.hxx
@@ -236,6 +236,7 @@
#define LINE_PROPERTIES_DEFAULTS\
{ UNO_NAME_LINECAP, XATTR_LINECAP,
::cppu::UnoType::get(), 0, 0}, \
{ UNO_NAME_LINECOLOR, XATTR_LINECOLOR,
::cppu::UnoType::get() , 0, 0}, \
+{ UNO_NAME_LINECOLOR_THEME_REFERENCE, XATTR_LINECOLOR,
::cppu::UnoType::get() , 0,
MID_COLOR_THEME_REFERENCE}, \
{ UNO_NAME_LINEENDCENTER, XATTR_LINEENDCENTER,
cppu::UnoType::get() , 0, 0}, \
{ UNO_NAME_LINEENDWIDTH, XATTR_LINEENDWIDTH,
::cppu::UnoType::get() , 0, 0,
PropertyMoreFlags::METRIC_ITEM}, \
{ UNO_NAME_LINEJOINT, XATTR_LINEJOINT,
::cppu::UnoType::get(), 0, 0}, \
diff --git a/oox/inc/drawingml/lineproperties.hxx
b/oox/inc/drawingml/lineproperties.hxx
index f2d37a7f8a9f..52c27825bdaf 100644
--- a/oox/inc/drawingml/lineproperties.hxx
+++ b/oox/inc/drawingml/lineproperties.hxx
@@ -69,7 +69,8 @@ struct LineProperties
voidpushToPropMap(
ShapePropertyMap& rPropMap,
const GraphicHelper& rGraphicHelper,
-::Color nPhClr = API_RGB_TRANSPARENT ) const;
+::Color nPhClr = API_RGB_TRANSPARENT,
+sal_Int16 nPhClrTheme = -1) const;
/** Calculates the line style attribute from the internal state of the
object */
css::drawing::LineStyle getLineStyle() const;
diff --git a/oox/qa/unit/data/ThemeShapesReference.pptx
[Libreoffice-bugs] [Bug 152656] "Drawing Style" should be renamed "Drawing Object Style" or "Shape Style"
https://bugs.documentfoundation.org/show_bug.cgi?id=152656 Eyal Rozenberg changed: What|Removed |Added Summary|"Drawing Style" should be |"Drawing Style" should be |renamed "Drawing Object |renamed "Drawing Object |Style" |Style" or "Shape Style" --- Comment #6 from Eyal Rozenberg --- (In reply to Heiko Tietze from comment #5) > We discussed the topic in the design meeting. While Stuart agrees, Roman, > Cor and me would recommend to keep it short ... short where? In the sidebar tooltip? Because other than that, it's icons. Also, why is "Fill format mode" considered short enough, but "Drawing Object Style" isn't? > Precision is not always an improvement for usability. Perhaps, but truth, as opposed to untruth, is. A "Drawing style" is not a style of drawing. > Cor and me would recommend to keep it ... simple. "Drawing style" is short, but it would only be simple if it were true - which it isn't. This reminds me of the "heading"/"outline"/"chapter" numbering conundrum. It's very short and simple to talk about "chapter numbering"; but - it's not true. "Drawing object style" is simple, because the user knows about objects. They align objects. They insert objects. They have drawing object properties toolbar ... ... hmm. Now that I think about it, maybe I'm over fixated on "Drawing Objects". While this is still a pretty good choice of name, I was assuming we need to keep the word "drawing". Maybe, instead, we should call them "shape styles". The word "shapes" appears more often in the UI than "Drawing object": * Shape menu * Arrow shapes, star shapes etc menubutton * Navigator shows shapes so that's something to consider as well. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153000] FILEOPEN DOCX file types MSO_SPT=25 to 31 are wrongly rendered
https://bugs.documentfoundation.org/show_bug.cgi?id=153000 --- Comment #8 from Julien Nabet --- Is it ok now and I can cherry-pick this on 7.5 or is there still something to do here? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: dbaccess/source
dbaccess/source/ui/uno/copytablewizard.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit c9b0eacae71f111209cb77f14f2693d73e5e8d90 Author: Julien Nabet AuthorDate: Fri Jan 13 22:05:35 2023 +0100 Commit: Julien Nabet CommitDate: Fri Jan 13 22:32:26 2023 + Related tdf#153003: Copying a query and pasting as table in same DB impossible It might be a regression from ca82061c2cad00aeddb17b766063776fee0ee41a "make ValueTransfer easier to understand storing references to local variables makes it harder to figure out what the control flow is doing. " in peculiar: -sal_Int32 nDestColumn( 0 ); -sal_Int32 nSourceColumn( 1 ); -ValueTransfer aTransfer( nSourceColumn, nDestColumn, std::vector(aSourceColTypes), xRow, xStatementParams ); +sal_Int32 nSourceColumn( 0 ); +ValueTransfer aTransfer( aSourceColTypes, xRow, xStatementParams ); Change-Id: Iaa27c4f46fcc51ec12fff08f8e99f862c8b4ac2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145499 Tested-by: Jenkins Reviewed-by: Julien Nabet diff --git a/dbaccess/source/ui/uno/copytablewizard.cxx b/dbaccess/source/ui/uno/copytablewizard.cxx index fab5e3966cbd..c886995398a7 100644 --- a/dbaccess/source/ui/uno/copytablewizard.cxx +++ b/dbaccess/source/ui/uno/copytablewizard.cxx @@ -1141,7 +1141,7 @@ void CopyTableWizard::impl_copyRows_throw( const Reference< XResultSet >& _rxSou // notify listeners m_aCopyTableListeners.notifyEach( ::copyingRow, aCopyEvent ); -sal_Int32 nSourceColumn( 0 ); +sal_Int32 nSourceColumn( 1 ); ValueTransfer aTransfer( aSourceColTypes, xRow, xStatementParams ); for ( auto const& rColumnPos : aColumnPositions )
[Libreoffice-bugs] [Bug 153017] printer chaos
https://bugs.documentfoundation.org/show_bug.cgi?id=153017 --- Comment #1 from alignedtrain...@outlook.com --- problem also persists in safe mode -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153017] New: printer chaos
https://bugs.documentfoundation.org/show_bug.cgi?id=153017 Bug ID: 153017 Summary: printer chaos Product: LibreOffice Version: 7.4.4.2 release Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Printing and PDF export Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: alignedtrain...@outlook.com Description: I had the misfortune to have to change the page layout / printer settings on one document .. and now every single one inherits those settings .. total utter chaos and each document is ruined to the point I cant even get the old settings back. Steps to Reproduce: 1.open document 2.get annoyed 3. Actual Results: utter chaos .. Expected Results: individual printer settings for each document are retained .. as they used to be Reproducible: Always User Profile Reset: No Additional Info: [Information automatically included from LibreOffice] Locale: en-US Module: TextDocument [Information guessed from browser] OS: Linux (All) OS is 64bit: yes -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153008] FILEOPEN PPTX: images (clipped against a shape) appear horizontally compressed
https://bugs.documentfoundation.org/show_bug.cgi?id=153008 Aron Budea changed: What|Removed |Added Attachment #184636|application/vnd.ms-powerpoi |application/vnd.openxmlform mime type|nt |ats-officedocument.presenta ||tionml.presentation -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153008] FILEOPEN PPTX: images (clipped against a shape) appear horizontally compressed
https://bugs.documentfoundation.org/show_bug.cgi?id=153008 Aron Budea changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||0714 CC||aron.bu...@gmail.com Status|UNCONFIRMED |NEW Blocks||139902 Ever confirmed|0 |1 Version|7.1.6.2 release |7.1.3.2 release Keywords||bibisected, bisected --- Comment #2 from Aron Budea --- Confirmed using LO 7.6.0.0.alpha0+ (d993327eab0a2c9c8820c6528075b01de68b0ec6) / Ubuntu. The mentioned change comes from bug 140714 's fix, as found by reverse bibisecting it. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=139902 [Bug 139902] [META] PPTX Image issues -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139902] [META] PPTX Image issues
https://bugs.documentfoundation.org/show_bug.cgi?id=139902 Aron Budea changed: What|Removed |Added Depends on||153008 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=153008 [Bug 153008] FILEOPEN PPTX: images (clipped against a shape) appear horizontally compressed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 116280] [META] Regressions introduced by the image handling refactoring
https://bugs.documentfoundation.org/show_bug.cgi?id=116280 Aron Budea changed: What|Removed |Added Depends on||147704 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=147704 [Bug 147704] FILEOPEN PPTX: image appears vertically compressed (by a factor of two) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147704] FILEOPEN PPTX: image appears vertically compressed (by a factor of two)
https://bugs.documentfoundation.org/show_bug.cgi?id=147704 Aron Budea changed: What|Removed |Added Blocks||116280 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=116280 [Bug 116280] [META] Regressions introduced by the image handling refactoring -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153014] FILEOPEN PPTX: slide build-up with animations/effects very, very choppy
https://bugs.documentfoundation.org/show_bug.cgi?id=153014 m.a.riosv changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||miguelangelrv@libreoffice.o ||rg Ever confirmed|0 |1 --- Comment #1 from m.a.riosv --- Reproducible Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 12e8d57e791bb1befc0716d4d02af7d1d1ccb4ae CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL threaded Jumbo -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153016] Duplicated comment with action description in .doc file
https://bugs.documentfoundation.org/show_bug.cgi?id=153016 --- Comment #1 from Marcin Segit --- Created attachment 184654 --> https://bugs.documentfoundation.org/attachment.cgi?id=184654=edit Added/deleted comments -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153016] New: Duplicated comment with action description in .doc file
https://bugs.documentfoundation.org/show_bug.cgi?id=153016 Bug ID: 153016 Summary: Duplicated comment with action description in .doc file Product: LibreOffice Version: 7.4.4.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: s...@onet.pl Description: In a doc with track changes turned on after adding or deleting a comment and saving and closing the file upon reopening an additional comment appears stating "Comment added/deleted", thus doubling the number of comments in the text. Steps to Reproduce: 1. Create doc file with Writer. 2. Type some text. 3. Turn on track changes. 4. Make changes in the text. 5. Add a comment. 6. Save. 7. Quit. 8. Open the .doc file again. Actual Results: Additional comment appears. Expected Results: There is only one comment that was left by me. Reproducible: Always User Profile Reset: Yes Additional Info: Version: 7.4.4.2 (x64) / LibreOffice Community Build ID: 85569322deea74ec9134968a29af2df5663baa21 CPU threads: 16; OS: Windows 10.0 Build 19045; UI render: Skia/Vulkan; VCL: win Locale: pl-PL (pl_PL); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153003] Copying a query and pasting as table in same database impossible
https://bugs.documentfoundation.org/show_bug.cgi?id=153003 Julien Nabet changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |serval2...@yahoo.fr |desktop.org | --- Comment #4 from Julien Nabet --- (In reply to Julien Nabet from comment #3) > I've submitted this first patch: > https://gerrit.libreoffice.org/c/core/+/145499 > > but then I've got: > warn:dbaccess:165069:165069:dbaccess/source/ui/uno/copytablewizard.cxx:1421: > com.sun.star.sdbc.SQLException message: "This operation is not supported in > statement [ALTER TABLE "qry_Name1" ALTER "ID" RESTART WITH 3] at > /home/julien/lo/libreoffice/connectivity/source/drivers/jdbc/Object.cxx:172" > SQLState: S1000 ErrorCode: -73 > wrapped: void message: "at > /home/julien/lo/libreoffice/comphelper/source/misc/diagnose_ex.cxx:66" It seems due to the fact that "ID" field in "tbl_Name' is not an IDENTITY column. To change this, you must set "autoincrement" to "yes" and then it works. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153012] FILEOPEN PPTX: ring segment renders black (or transparent?) instead of grey
https://bugs.documentfoundation.org/show_bug.cgi?id=153012 m.a.riosv changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||miguelangelrv@libreoffice.o ||rg Ever confirmed|0 |1 --- Comment #2 from m.a.riosv --- Reproducible it's imported with black color instead grey. Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 12e8d57e791bb1befc0716d4d02af7d1d1ccb4ae CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL threaded Jumbo -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153003] Copying a query and pasting as table in same database impossible
https://bugs.documentfoundation.org/show_bug.cgi?id=153003 Julien Nabet changed: What|Removed |Added CC||noelgran...@gmail.com, ||serval2...@yahoo.fr --- Comment #3 from Julien Nabet --- I've submitted this first patch: https://gerrit.libreoffice.org/c/core/+/145499 but then I've got: warn:dbaccess:165069:165069:dbaccess/source/ui/uno/copytablewizard.cxx:1421: com.sun.star.sdbc.SQLException message: "This operation is not supported in statement [ALTER TABLE "qry_Name1" ALTER "ID" RESTART WITH 3] at /home/julien/lo/libreoffice/connectivity/source/drivers/jdbc/Object.cxx:172" SQLState: S1000 ErrorCode: -73 wrapped: void message: "at /home/julien/lo/libreoffice/comphelper/source/misc/diagnose_ex.cxx:66" -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153011] FILEOPEN PPTX: rectangular shapes are missing shadows
https://bugs.documentfoundation.org/show_bug.cgi?id=153011 m.a.riosv changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||miguelangelrv@libreoffice.o ||rg Ever confirmed|0 |1 --- Comment #2 from m.a.riosv --- Reproducible, seems for shapes it's imported, but not for graphics. Version: 7.4.4.2 (x64) / LibreOffice Community Build ID: 85569322deea74ec9134968a29af2df5663baa21 CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Vulkan; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 12e8d57e791bb1befc0716d4d02af7d1d1ccb4ae CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL threaded Jumbo -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 122945] VIEWING: Tab colors of protected worksheets not shown in Excel 2007 spreadsheet
https://bugs.documentfoundation.org/show_bug.cgi?id=122945 --- Comment #10 from Ben Elliston --- I vote for mimicking MS Excel behaviour. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153015] FILEOPEN PPTX: narrow slices of background appear between rectangles (in presentation mode only)
https://bugs.documentfoundation.org/show_bug.cgi?id=153015 --- Comment #1 from Gerald Pfeifer --- Created attachment 184653 --> https://bugs.documentfoundation.org/attachment.cgi?id=184653=edit Screenshot in presentation mode - respective areas marked (in green) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153015] New: FILEOPEN PPTX: narrow slices of background appear between rectangles (in presentation mode only)
https://bugs.documentfoundation.org/show_bug.cgi?id=153015 Bug ID: 153015 Summary: FILEOPEN PPTX: narrow slices of background appear between rectangles (in presentation mode only) Product: LibreOffice Version: 6.4 all versions Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ger...@pfeifer.com Created attachment 184652 --> https://bugs.documentfoundation.org/attachment.cgi?id=184652=edit Sample slide (PPTX) If we view the sample documentation in edit mode, the actual slide background is not visible. In presentation mode - in Impress, not so in PowerPoint, there are three places where it comes through. Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 5b3fd1af1247d4096451e5a768c3438fbccec2b2 CPU threads: 8; OS: Linux 6.0; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US (and back to 6.4 at least) Disclaimer: I am not arguing this is a well designed slide. It still renders differently in Impress than it does in PowerPoint. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153013] Rendering regression in Writer 7.5rc1: Text/font is rendered sometimes blury, sometimes sharp
https://bugs.documentfoundation.org/show_bug.cgi?id=153013 --- Comment #2 from Gerry --- Created attachment 184651 --> https://bugs.documentfoundation.org/attachment.cgi?id=184651=edit Second screenshot Please open the screenshot. Again, in this screenshot you see that the first three lines are rendered blury, but the last line is rendered correctly (= sharp). The interesting difference to the "First screenshot" is that the third line/paragraph changed its state from sharp to blury when I entered the fourth line/pargraph. If you don't see this immediately in the screenshot, please zoom the screenshot to e.g. 450% and compare the rendering. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152999] UI: Document background color in settings overrides cell background colors in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=152999 --- Comment #3 from Jens --- Created attachment 184650 --> https://bugs.documentfoundation.org/attachment.cgi?id=184650=edit Libreoffice Writer UI with text colors and "Libreoffice" theme Similarly in Libreoffice Writer. Currently it doesn't seem possible to have a dark mode Desktop theme but a white document background color AND have content backgrounds within the document. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153013] Rendering regression in Writer 7.5rc1: Text/font is rendered sometimes blury, sometimes sharp
https://bugs.documentfoundation.org/show_bug.cgi?id=153013 --- Comment #1 from Gerry --- Created attachment 184649 --> https://bugs.documentfoundation.org/attachment.cgi?id=184649=edit First screenshot Please open the screenshot. You see that the third line (paragraph) in the document is rendered sharp while the two first lines are rendered blury. If you don't see this immediately in the screenshot, please zoom the screenshot to e.g. 450% and compare the rendering. It looks to me that antialising works fine for all lines, but the display of the first two lines is just blury. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153014] New: FILEOPEN PPTX: slide build-up with animations/effects very, very choppy
https://bugs.documentfoundation.org/show_bug.cgi?id=153014 Bug ID: 153014 Summary: FILEOPEN PPTX: slide build-up with animations/effects very, very choppy Product: LibreOffice Version: 6.4 all versions Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ger...@pfeifer.com Created attachment 184648 --> https://bugs.documentfoundation.org/attachment.cgi?id=184648=edit Sample slide (PPTX) I got a presentation with the slide included here. In Office 365 (web version) the build is not perfectly smooth, but okayish. In Impress with a (three year old) quad core CPU and 16GB the build-up with animation/effects is very, very, very choppy. Essentially unbearable. Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 5b3fd1af1247d4096451e5a768c3438fbccec2b2 CPU threads: 8; OS: Linux 6.0; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153007] LibreOffice 7.4.3.2 very slow with VCL GTK3
https://bugs.documentfoundation.org/show_bug.cgi?id=153007 Julien Nabet changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 CC||serval2...@yahoo.fr --- Comment #1 from Julien Nabet --- Do you have any accessibility tool enabled? If yes, could you disable them just for the test? Indeed, contrary to gen rendering, gtk3 and kf5 use accessibility part. It could also be due to Skia or graphic driver, could you apply advice from the link https://wiki.documentfoundation.org/QA/FirstSteps#Graphics-related_issues_.28_Skia_.29 ? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153013] New: Rendering regression in Writer 7.5rc1: Text/font is rendered sometimes blury, sometimes sharp
https://bugs.documentfoundation.org/show_bug.cgi?id=153013 Bug ID: 153013 Summary: Rendering regression in Writer 7.5rc1: Text/font is rendered sometimes blury, sometimes sharp Product: LibreOffice Version: 7.5.0.1 rc Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: gerry.trep...@googlemail.com Description: I encounter a regression in the rendering of text/fonts in LibreOffice Writer 7.5rc1. I did not see the problem in any previous LibreOffice version such as 7.4.x, 7.3.x. The rendering of text is sometimes blury and sometimes sharp (see attached screenshots). It changes the state of text rendering from blury to sharp and the other way around. It is also possible, that some paragraphs are sharp while other are blury. I did not really figure out a pattern in that behaviour of LO Writer, but it seems to be to me that the last line is more likely sharp than the prevous ones. But sometimes, it is the other way around or everything is blury. Steps to Reproduce: 1. open empty LibreOffice writer text 2. start typing a couple of lines/paragraphs Actual Results: 3. LibreOffice will show all or some of the text blury or sharp Expected Results: Text/fonts should be rendered normally (sharp) Reproducible: Always User Profile Reset: No Additional Info: Version: 7.5.0.1 (X86_64) / LibreOffice Community Build ID: 77cd3d7ad4445740a0c6cf977992dafd8ebad8df CPU threads: 16; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: fr-FR (fr_FR.UTF-8); UI: fr-FR Calc: threaded System: Ubuntu 22.04 with vanilla Gnome Shell Lenovo ThinkPad T14s Gen 1 AMD® Ryzen 7 pro 4750u with radeon graphics × 16 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152999] UI: Document background color in settings overrides cell background colors in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=152999 --- Comment #2 from Jens --- Created attachment 184647 --> https://bugs.documentfoundation.org/attachment.cgi?id=184647=edit Libreoffice Calc UI with text colors and "Libreoffice" theme Hello, Thank you for helping! I am using this theme. However, all colors seem inverted. Also, cell background colors are not applied. I can set the "Document background color" to white manually but then also all background and fill colors *within the document* are also ignored. Note that this is also regardless of the icon theme (I chose one with good contrast). How can I fix this? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153007] LibreOffice 7.4.3.2 very slow with VCL GTK3
https://bugs.documentfoundation.org/show_bug.cgi?id=153007 Julien Nabet changed: What|Removed |Added Summary|LibreOffice 7.4.3.2 very|LibreOffice 7.4.3.2 very |slow with VLC GTK3 |slow with VCL GTK3 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: forms/source
forms/source/richtext/richtextcontrol.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 32911b8fe99f5205bda08a31b22bfbd991db20f7 Author: Andrea Gelmini AuthorDate: Fri Jan 13 19:12:00 2023 +0100 Commit: Julien Nabet CommitDate: Fri Jan 13 20:26:24 2023 + Fix typo Change-Id: I4d6b70095259b179f8ac3fc210899ffa84b87fa0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145492 Tested-by: Jenkins Reviewed-by: Julien Nabet diff --git a/forms/source/richtext/richtextcontrol.cxx b/forms/source/richtext/richtextcontrol.cxx index cb4bb3e5357c..b481b6bfc981 100644 --- a/forms/source/richtext/richtextcontrol.cxx +++ b/forms/source/richtext/richtextcontrol.cxx @@ -257,7 +257,7 @@ namespace frm // the EditEngine of the model RichTextEngine* pEngine = ORichTextModel::getEditEngine( _rxModel ); -OSL_ENSURE( pEngine, "ORichTextPeer::Create: could not obtaine the edit engine from the model!" ); +OSL_ENSURE( pEngine, "ORichTextPeer::Create: could not obtain the edit engine from the model!" ); if ( !pEngine ) return nullptr;
[Libreoffice-bugs] [Bug 153000] FILEOPEN DOCX file types MSO_SPT=25 to 31 are wrongly rendered
https://bugs.documentfoundation.org/show_bug.cgi?id=153000 Commit Notification changed: What|Removed |Added Whiteboard||target:7.6.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153000] FILEOPEN DOCX file types MSO_SPT=25 to 31 are wrongly rendered
https://bugs.documentfoundation.org/show_bug.cgi?id=153000 --- Comment #7 from Commit Notification --- Julien Nabet committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/11319f419988443af85cf3c60dbed12d67fc183f tdf#153000: file types MSO_SPT=25 to 31 are wrongly rendered It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: svx/source
svx/source/customshapes/EnhancedCustomShapeGeometry.cxx | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) New commits: commit 11319f419988443af85cf3c60dbed12d67fc183f Author: Julien Nabet AuthorDate: Fri Jan 13 19:08:47 2023 +0100 Commit: Julien Nabet CommitDate: Fri Jan 13 20:20:09 2023 + tdf#153000: file types MSO_SPT=25 to 31 are wrongly rendered Description and analysis with MS ref + code pointer + solution here: https://bugs.documentfoundation.org/show_bug.cgi?id=153000#c0 all this thanks to Regina. Change-Id: I63a66e075bc67e3c7d833756026933b3447d0cd8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145491 Tested-by: Jenkins Reviewed-by: Julien Nabet diff --git a/svx/source/customshapes/EnhancedCustomShapeGeometry.cxx b/svx/source/customshapes/EnhancedCustomShapeGeometry.cxx index 0f999ed42209..c2ae1c20f268 100644 --- a/svx/source/customshapes/EnhancedCustomShapeGeometry.cxx +++ b/svx/source/customshapes/EnhancedCustomShapeGeometry.cxx @@ -8506,19 +8506,14 @@ const mso_CustomShape* GetCustomShapeContent( MSO_SPT eSpType ) case mso_sptCurvedConnector5 : pCustomShape = break; // Don't know, simply mapping to TextSimple -case mso_sptTextOnRing : -case mso_sptTextOnCurve : -case mso_sptTextRing : -case mso_sptTextWave : -case mso_sptTextCurve : -case mso_sptTextHexagon : -case mso_sptTextOctagon : case mso_sptTextBox : pCustomShape = break; // FontWork case mso_sptTextSimple : case mso_sptTextPlainText : pCustomShape = break; +case mso_sptTextOctagon : case mso_sptTextStop : pCustomShape = break; +case mso_sptTextHexagon : case mso_sptTextTriangle : pCustomShape = break; case mso_sptTextTriangleInverted : pCustomShape = break; case mso_sptTextChevron : pCustomShape = break; @@ -8533,10 +8528,12 @@ const mso_CustomShape* GetCustomShapeContent( MSO_SPT eSpType ) case mso_sptTextSlantDown : pCustomShape = break; case mso_sptTextCascadeUp : pCustomShape = break; case mso_sptTextCascadeDown : pCustomShape = break; +case mso_sptTextOnRing : case mso_sptTextArchUpCurve : pCustomShape = break; case mso_sptTextArchDownCurve : pCustomShape = break; case mso_sptTextCircleCurve : pCustomShape = break; case mso_sptTextButtonCurve : pCustomShape = break; +case mso_sptTextRing : case mso_sptTextArchUpPour :pCustomShape = break; case mso_sptTextArchDownPour : pCustomShape = break; case mso_sptTextCirclePour :pCustomShape = break; @@ -8544,6 +8541,8 @@ const mso_CustomShape* GetCustomShapeContent( MSO_SPT eSpType ) case mso_sptTextCurveUp : pCustomShape = break; case mso_sptTextCurveDown : pCustomShape = break; case mso_sptTextCanUp : pCustomShape = break; +case mso_sptTextCurve : +case mso_sptTextOnCurve : case mso_sptTextCanDown : pCustomShape = break; case mso_sptTextInflate : pCustomShape = break; case mso_sptTextDeflate : pCustomShape = break; @@ -8553,6 +8552,7 @@ const mso_CustomShape* GetCustomShapeContent( MSO_SPT eSpType ) case mso_sptTextDeflateTop :pCustomShape = break; case mso_sptTextDeflateInflate :pCustomShape = break; case mso_sptTextDeflateInflateDeflate : pCustomShape = break; +case mso_sptTextWave : case mso_sptTextWave1 : pCustomShape = break; case mso_sptTextWave2 : pCustomShape = break; case mso_sptTextWave3 : pCustomShape = break;
[Libreoffice-bugs] [Bug 152994] Daily Screenshot Build failure
https://bugs.documentfoundation.org/show_bug.cgi?id=152994 Caolán McNamara changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED Assignee|libreoffice-b...@lists.free |caol...@redhat.com |desktop.org | --- Comment #6 from Caolán McNamara --- reported works, done in trunk, backport to 7-5 in gerrit -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153012] FILEOPEN PPTX: ring segment renders black (or transparent?) instead of grey
https://bugs.documentfoundation.org/show_bug.cgi?id=153012 --- Comment #1 from Gerald Pfeifer --- Created attachment 184646 --> https://bugs.documentfoundation.org/attachment.cgi?id=184646=edit Visual comparison Office 365 (left) vs LibreOffice (right) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153012] New: FILEOPEN PPTX: ring segment renders black (or transparent?) instead of grey
https://bugs.documentfoundation.org/show_bug.cgi?id=153012 Bug ID: 153012 Summary: FILEOPEN PPTX: ring segment renders black (or transparent?) instead of grey Product: LibreOffice Version: 6.4 all versions Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ger...@pfeifer.com Created attachment 184645 --> https://bugs.documentfoundation.org/attachment.cgi?id=184645=edit Sample slide (PPTX) Compare the sample slide in Impress vs PowerPoint and notice how a segment of the ring shown is black (or the background color) instead of grey. Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 5b3fd1af1247d4096451e5a768c3438fbccec2b2 CPU threads: 8; OS: Linux 6.0; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US and back to version 6.4. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - sw/qa sw/source
sw/qa/uibase/uno/uno.cxx | 34
sw/source/uibase/uno/loktxdoc.cxx | 62 --
2 files changed, 94 insertions(+), 2 deletions(-)
New commits:
commit 3c61a3642c8342568748bd9feaf58d8998ddb285
Author: Miklos Vajna
AuthorDate: Thu Jan 12 15:13:00 2023 +0100
Commit: Pranam Lashkari
CommitDate: Fri Jan 13 20:01:09 2023 +
sw lok: expose name of refmark under cursor
This is similar to commit 4bcb66ec7b417fbe113267f2615e78fe47eb55ca (sw
lok: expose name of bookmark under cursor, 2023-01-11), but that was for
the bookmark under the cursor and this is for refmarks.
(cherry picked from commit 81f690ec0cb2a6dc0d6ca0f6de3adcc07eb7bc12)
Change-Id: I0acf0181d0acfdc087e1ed737b3c18ab3736031a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145429
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Justin Luth
diff --git a/sw/qa/uibase/uno/uno.cxx b/sw/qa/uibase/uno/uno.cxx
index 595987eea423..ee6ce3f1ac70 100644
--- a/sw/qa/uibase/uno/uno.cxx
+++ b/sw/qa/uibase/uno/uno.cxx
@@ -368,6 +368,40 @@ CPPUNIT_TEST_FIXTURE(SwUibaseUnoTest, testGetBookmark)
CPPUNIT_ASSERT_EQUAL(std::string("ZOTERO_BREF_1"),
aBookmark.get("name"));
}
+CPPUNIT_TEST_FIXTURE(SwUibaseUnoTest, testGetField)
+{
+// Given a document with a refmark:
+SwDoc* pDoc = createSwDoc();
+uno::Sequence aArgs = {
+comphelper::makePropertyValue("TypeName",
uno::Any(OUString("SetRef"))),
+comphelper::makePropertyValue("Name",
+ uno::Any(OUString("ZOTERO_ITEM
CSL_CITATION {} refmark"))),
+comphelper::makePropertyValue("Content",
uno::Any(OUString("content"))),
+};
+dispatchCommand(mxComponent, ".uno:InsertField", aArgs);
+
+// When in the refmark with the cursor and getting the command value for
.uno:Field:
+SwWrtShell* pWrtShell = pDoc->GetDocShell()->GetWrtShell();
+pWrtShell->SttEndDoc(/*bStt=*/false);
+pWrtShell->Left(CRSR_SKIP_CHARS, /*bSelect=*/false, 1,
/*bBasicCall=*/false);
+tools::JsonWriter aJsonWriter;
+OString
aCommand(".uno:Field?typeName=SetRef=ZOTERO_ITEM%20CSL_CITATION");
+auto pXTextDocument = dynamic_cast(mxComponent.get());
+pXTextDocument->getCommandValues(aJsonWriter, aCommand);
+
+// Then make sure we find the inserted refmark:
+std::unique_ptr
pJSON(aJsonWriter.extractData());
+std::stringstream aStream(pJSON.get());
+boost::property_tree::ptree aTree;
+boost::property_tree::read_json(aStream, aTree);
+boost::property_tree::ptree aBookmark = aTree.get_child("setRef");
+// Without the accompanying fix in place, this test would have failed with:
+// - No such node (setRef)
+// i.e. the returned JSON was an empty object.
+CPPUNIT_ASSERT_EQUAL(std::string("ZOTERO_ITEM CSL_CITATION {} refmark"),
+ aBookmark.get("name"));
+}
+
CPPUNIT_PLUGIN_IMPLEMENT();
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/uibase/uno/loktxdoc.cxx
b/sw/source/uibase/uno/loktxdoc.cxx
index 101f0ff082c8..2780e39a1686 100644
--- a/sw/source/uibase/uno/loktxdoc.cxx
+++ b/sw/source/uibase/uno/loktxdoc.cxx
@@ -328,6 +328,58 @@ void GetFields(tools::JsonWriter& rJsonWriter, SwDocShell*
pDocShell,
}
}
+/// Implements getCommandValues(".uno:Field").
+///
+/// Parameters:
+///
+/// - typeName: field type condition to not return all fields
+/// - namePrefix: field name prefix to not return all fields
+void GetField(tools::JsonWriter& rJsonWriter, SwDocShell* pDocShell,
+ const std::map& rArguments)
+{
+OUString aTypeName;
+{
+auto it = rArguments.find("typeName");
+if (it != rArguments.end())
+{
+aTypeName = it->second;
+}
+}
+// See SwFieldTypeFromString().
+if (aTypeName != "SetRef")
+{
+return;
+}
+
+OUString aNamePrefix;
+{
+auto it = rArguments.find("namePrefix");
+if (it != rArguments.end())
+{
+aNamePrefix = it->second;
+}
+}
+
+SwWrtShell* pWrtShell = pDocShell->GetWrtShell();
+SwPosition& rCursor = *pWrtShell->GetCursor()->GetPoint();
+SwTextNode* pTextNode = rCursor.GetNode().GetTextNode();
+std::vector aAttrs
+= pTextNode->GetTextAttrsAt(rCursor.nContent.GetIndex(),
RES_TXTATR_REFMARK);
+tools::ScopedJsonWriterNode aRefmark = rJsonWriter.startNode("setRef");
+if (aAttrs.empty())
+{
+return;
+}
+
+const SwFormatRefMark& rRefmark = aAttrs[0]->GetRefMark();
+if (!rRefmark.GetRefName().startsWith(aNamePrefix))
+{
+return;
+}
+
+rJsonWriter.put("name", rRefmark.GetRefName());
+}
+
/// Implements getCommandValues(".uno:Sections").
///
/// Parameters:
@@ -363,8 +415,9 @@ void GetSections(tools::JsonWriter& rJsonWriter,
SwDocShell* pDocShell,
bool SwXTextDocument::supportsCommand(const
[Libreoffice-commits] core.git: drawinglayer/Library_drawinglayer.mk drawinglayer/source include/drawinglayer
drawinglayer/Library_drawinglayer.mk |1
drawinglayer/source/drawinglayeruno/xprimitive2drenderer.cxx | 10
drawinglayer/source/primitive2d/fillgraphicprimitive2d.cxx |3
drawinglayer/source/processor2d/SDPRProcessor2dTools.cxx | 277 +++
drawinglayer/source/processor2d/d2dpixelprocessor2d.cxx | 159 +-
include/drawinglayer/primitive2d/fillgraphicprimitive2d.hxx | 31 +
include/drawinglayer/processor2d/SDPRProcessor2dTools.hxx| 104
include/drawinglayer/processor2d/d2dpixelprocessor2d.hxx |3
8 files changed, 571 insertions(+), 17 deletions(-)
New commits:
commit 9455aae461685809191a3051cf86a208fa5946b4
Author: Armin Le Grand (Allotropia)
AuthorDate: Fri Jan 13 10:42:44 2023 +0100
Commit: Armin Le Grand
CommitDate: Fri Jan 13 20:00:19 2023 +
SDPR: Direct support for FillGraphicPrimitive2D
Added support to directly paint FillGraphicPrimitive2D, that
means object fill with multiple tiles/tiled fill. Note: This
may use not only bitmap data, but also metafile or svg.
The standard decompose creates one transformed bitmap/vector
data primitive per tile what is correct, but has some limits
(a) These may get many when tiles are small compared to
mask polyPolygon (performance/ressources)
(b) Correctness: when rendering in AA the common edges of
tiles will *not* sum up perfectly, but due to AA
multiplying when blending will leave ugly 'traces'
This direct rendering avoids both. It can use the D2D Brush
functionality to repeat. Additionally to the current
office it can also do that when content is rotated/sheared.
This may not be well known since for those fills the office
always keeps the fill unrotated (for historical reasons,
primitives can do that, but not vcl). To see it you may
convert a SdrObject to metafile and rotate that, so the
content gets rotated and shows that ugly gaps.
Also added a square-pixel step value for vector fills where
the default gets used starting from some size. The argument
is better quality for vector data fills while only a
limited number of tiles will be rendered.
Also added a buffered handling of the (old and ugly)
OffsetX/OffsetY to make that work, we will not get rid of
that soon.
Packed all of this into tooling (so started a tooling
collection for SDPRs target-system independent) to be able
to easily re-use all these preparations/tests in other
SDPR implementations in the future.
Change-Id: Iafacf4181e7c9e2d2b2e3b5cf1f7e4cdd0a43f0a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145466
Tested-by: Jenkins
Reviewed-by: Armin Le Grand
diff --git a/drawinglayer/Library_drawinglayer.mk
b/drawinglayer/Library_drawinglayer.mk
index 884c32b170a8..40abc8d0f0fa 100644
--- a/drawinglayer/Library_drawinglayer.mk
+++ b/drawinglayer/Library_drawinglayer.mk
@@ -66,6 +66,7 @@ endif
ifeq ($(OS),WNT)
$(eval $(call gb_Library_add_exception_objects,drawinglayer,\
drawinglayer/source/processor2d/d2dpixelprocessor2d \
+drawinglayer/source/processor2d/SDPRProcessor2dTools \
))
endif
diff --git a/drawinglayer/source/drawinglayeruno/xprimitive2drenderer.cxx
b/drawinglayer/source/drawinglayeruno/xprimitive2drenderer.cxx
index be58c77dd390..2eb1373df0ae 100644
--- a/drawinglayer/source/drawinglayeruno/xprimitive2drenderer.cxx
+++ b/drawinglayer/source/drawinglayeruno/xprimitive2drenderer.cxx
@@ -116,7 +116,15 @@ namespace drawinglayer::unorenderer
MaximumQuadraticPixels = 50;
}
-const auto aViewInformation2D =
geometry::createViewInformation2D(aViewInformationSequence);
+auto aViewInformation2D =
geometry::createViewInformation2D(aViewInformationSequence);
+
+if(aViewInformation2D.getViewport().isEmpty())
+{
+// we have a Viewport since we create a discrete pixel
device, use it
+// if none is given
+aViewInformation2D.setViewport(aRange);
+}
+
const sal_uInt32
nDiscreteWidth(basegfx::fround(o3tl::convert(fWidth, eRangeUnit,
o3tl::Length::in) * DPI_X));
const sal_uInt32
nDiscreteHeight(basegfx::fround(o3tl::convert(fHeight, eRangeUnit,
o3tl::Length::in) * DPI_Y));
diff --git a/drawinglayer/source/primitive2d/fillgraphicprimitive2d.cxx
b/drawinglayer/source/primitive2d/fillgraphicprimitive2d.cxx
index 383d199f52b0..8c50993e6033 100644
--- a/drawinglayer/source/primitive2d/fillgraphicprimitive2d.cxx
+++ b/drawinglayer/source/primitive2d/fillgraphicprimitive2d.cxx
@@ -95,7 +95,8 @@ namespace drawinglayer::primitive2d
basegfx::B2DHomMatrix aTransformation,
const attribute::FillGraphicAttribute& rFillGraphic)
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - desktop/source
desktop/source/lib/init.cxx | 127 +++-
1 file changed, 125 insertions(+), 2 deletions(-)
New commits:
commit bb0c63cc73998a0f67ae4c3e59acea3827a6e11c
Author: Henry Castro
AuthorDate: Wed Jan 11 16:14:57 2023 -0400
Commit: Andras Timar
CommitDate: Fri Jan 13 19:58:59 2023 +
lok: add function getDocLanguages
If the spell checker is disabled to use a remote
spelling feature, the getLanguages function is obsolete.
In order to not break stable functions, introduce the
getDocLanguages for the remote spelling feature.
Signed-off-by: Henry Castro
Change-Id: Ic210f31eddd3208b29d073ff35ba4fa2d98ea772
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145363
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Andras Timar
diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index 377667804e74..0567c12edca4 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -75,6 +75,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -100,6 +101,7 @@
#include
#include
+#include
#include
#include
#include
@@ -5379,6 +5381,119 @@ static void
doc_setGraphicSelection(LibreOfficeKitDocument* pThis, int nType, in
pDoc->setGraphicSelection(nType, nX, nY);
}
+static uno::Any getDocLanguages(LibreOfficeKitDocument* pThis)
+{
+SfxViewFrame* pViewFrame = SfxViewFrame::Current();
+if (!pViewFrame)
+return uno::makeAny(Sequence());
+
+SfxDispatcher* pDispatcher = pViewFrame->GetBindings().GetDispatcher();
+if (!pDispatcher)
+return uno::makeAny(Sequence());
+
+css::uno::Any aLangStatus;
+pDispatcher->QueryState(SID_LANGUAGE_STATUS, aLangStatus);
+
+Sequence aSeqLang;
+if (!(aLangStatus >>= aSeqLang))
+return uno::makeAny(Sequence());
+
+// (aSeqLang[0] == "Current Language", aSeqLang[1] == "Script Type",
+// aSeqLang[2] == "Keyboard Language", aSeqLang[3] == "Guess Text Lang")
+if (aSeqLang.getLength() != 4)
+return uno::makeAny(Sequence());
+
+LanguageType nLangType;
+std::set aLangItems;
+SvtScriptType eScriptType =
static_cast(aSeqLang[1].toInt32());
+
+if (!aSeqLang[0].isEmpty())
+{
+nLangType = SvtLanguageTable::GetLanguageType(aSeqLang[0]);
+if (nLangType != LANGUAGE_DONTKNOW)
+{
+aLangItems.insert(nLangType);
+}
+}
+
+const AllSettings& rAllSettings = Application::GetSettings();
+nLangType = rAllSettings.GetLanguageTag().getLanguageType();
+if (nLangType != LANGUAGE_DONTKNOW &&
+(eScriptType & SvtLanguageOptions::GetScriptTypeOfLanguage(nLangType)))
+{
+aLangItems.insert(nLangType);
+}
+
+nLangType = rAllSettings.GetUILanguageTag().getLanguageType();
+if (nLangType != LANGUAGE_DONTKNOW &&
+(eScriptType & SvtLanguageOptions::GetScriptTypeOfLanguage(nLangType)))
+{
+aLangItems.insert(nLangType);
+}
+
+if (!aSeqLang[2].isEmpty())
+{
+nLangType = SvtLanguageTable::GetLanguageType(aSeqLang[2]);
+if (nLangType != LANGUAGE_DONTKNOW &&
+(eScriptType &
SvtLanguageOptions::GetScriptTypeOfLanguage(nLangType)))
+{
+aLangItems.insert(nLangType);
+}
+}
+
+if (!aSeqLang[3].isEmpty())
+{
+Reference xLangGuesser;
+try
+{
+xLangGuesser = linguistic2::LanguageGuessing::create(xContext);
+}
+catch(...)
+{
+}
+
+if (xLangGuesser.is())
+{
+lang::Locale aLocale =
xLangGuesser->guessPrimaryLanguage(aSeqLang[3], 0,
+
aSeqLang[3].getLength());
+nLangType = LanguageTag(aLocale).makeFallback().getLanguageType();
+if (nLangType != LANGUAGE_DONTKNOW &&
+(eScriptType &
SvtLanguageOptions::GetScriptTypeOfLanguage(nLangType)))
+{
+aLangItems.insert(nLangType);
+}
+}
+}
+
+LibLODocument_Impl* pDocument = static_cast(pThis);
+Reference
xDocumentLanguages(pDocument->mxComponent, UNO_QUERY);
+if (xDocumentLanguages.is())
+{
+const Sequence
aLocales(xDocumentLanguages->getDocumentLanguages(
+
static_cast(eScriptType), 64));
+
+for (const lang::Locale& aLocale : aLocales)
+{
+nLangType = SvtLanguageTable::GetLanguageType(aLocale.Language);
+if (nLangType != LANGUAGE_DONTKNOW &&
+(eScriptType &
SvtLanguageOptions::GetScriptTypeOfLanguage(nLangType)))
+{
+aLangItems.insert(nLangType);
+}
+}
+}
+
+int nLocale = 0;
+Sequence aLocales(aLangItems.size());
+auto pLocales = aLocales.getArray();
+for (const LanguageType& itLang :
[Libreoffice-bugs] [Bug 152712] Support setting style attributes relative to parent style
https://bugs.documentfoundation.org/show_bug.cgi?id=152712 --- Comment #9 from Eyal Rozenberg --- (In reply to Heiko Tietze from comment #8) > Do you know the "Document Theme" (available in the sidebar if experimental > features is on)? Not what you are looking for but improvements there make > more sense. No, and - I didn't realize there was a toggle for experimental features. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 152712] Support setting style attributes relative to parent style
https://bugs.documentfoundation.org/show_bug.cgi?id=152712 --- Comment #9 from Eyal Rozenberg --- (In reply to Heiko Tietze from comment #8) > Do you know the "Document Theme" (available in the sidebar if experimental > features is on)? Not what you are looking for but improvements there make > more sense. No, and - I didn't realize there was a toggle for experimental features. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 131386] Hidden linebreaks are ignored on creating pdf from rtf document
https://bugs.documentfoundation.org/show_bug.cgi?id=131386 --- Comment #10 from Commit Notification --- Michael Stahl committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/a25eda715591cfa96136bcfd95360156516239d1 tdf#131386 writerfilter: RTF import paragraph mark formatting It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 131386] Hidden linebreaks are ignored on creating pdf from rtf document
https://bugs.documentfoundation.org/show_bug.cgi?id=131386 Commit Notification changed: What|Removed |Added Whiteboard||target:7.6.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/CppunitTest_sw_rtfimport.mk sw/qa writerfilter/source
sw/CppunitTest_sw_rtfimport.mk|1
sw/qa/extras/rtfimport/data/hidden-para-separator.rtf | 67 ++
sw/qa/extras/rtfimport/rtfimport.cxx | 37 +
writerfilter/source/rtftok/rtfdispatchsymbol.cxx |4 -
writerfilter/source/rtftok/rtfdocumentimpl.cxx| 17 +++-
writerfilter/source/rtftok/rtfdocumentimpl.hxx|3
6 files changed, 120 insertions(+), 9 deletions(-)
New commits:
commit a25eda715591cfa96136bcfd95360156516239d1
Author: Michael Stahl
AuthorDate: Fri Jan 13 17:49:58 2023 +0100
Commit: Michael Stahl
CommitDate: Fri Jan 13 19:31:53 2023 +
tdf#131386 writerfilter: RTF import paragraph mark formatting
One obstacle was remove in commit 02f53bd61222d7999b847a22fd24d65195f129e5
To fix it, when \par is handled, runProps() just has to be called
unconditionally.
Now one test fails with:
rtfexport5.cxx:438:Assertion
Test name: testTdf107413::Load_Verify_Reload_Verify
equality assertion failed
- Expected: 14578
- Actual : 14698
The spacing above the first paragraph in the table in the footer
is not imported - because this is recorded in a buffer, and when replaying,
getProperties() is called with Id 0, and not LN_Value_ST_StyleType_character
as when it's called immediately without buffering.
Change-Id: If86ed2fa88eb2ac0eafd7a8be411bbfa341619b7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145490
Tested-by: Jenkins
Reviewed-by: Michael Stahl
diff --git a/sw/CppunitTest_sw_rtfimport.mk b/sw/CppunitTest_sw_rtfimport.mk
index 650abb178408..e961c4c2304b 100644
--- a/sw/CppunitTest_sw_rtfimport.mk
+++ b/sw/CppunitTest_sw_rtfimport.mk
@@ -25,6 +25,7 @@ $(eval $(call gb_CppunitTest_use_libraries,sw_rtfimport, \
sfx \
subsequenttest \
i18nlangtag \
+ svl \
sw \
swqahelper \
test \
diff --git a/sw/qa/extras/rtfimport/data/hidden-para-separator.rtf
b/sw/qa/extras/rtfimport/data/hidden-para-separator.rtf
new file mode 100644
index ..b35bdcf710e3
--- /dev/null
+++ b/sw/qa/extras/rtfimport/data/hidden-para-separator.rtf
@@ -0,0 +1,67 @@
+{\rtf1\adeflang1025\ansi\ansicpg1252\uc1\adeff0\deff0\stshfdbch0\stshfloch31506\stshfhich31506\stshfbi31506\deflang1033\deflangfe1033\themelang1038\themelangfe0\themelangcs0{\fonttbl{\f0\fbidi
\froman\fcharset0\fprq2{\*\panose 02020603050405020304}Times New Roman{\*\falt
Times New Roman};}
+{\f1\fbidi \fswiss\fcharset0\fprq2{\*\panose
020b0604020202020204}Arial;}{\f34\fbidi \froman\fcharset1\fprq2{\*\panose
02040503050406030204}Cambria Math;}{\f60\fbidi
\fswiss\fcharset0\fprq2{\*\panose }Verdana;}
+{\flomajor\f31500\fbidi \froman\fcharset0\fprq2{\*\panose
02020603050405020304}Times New Roman{\*\falt Times New
Roman};}{\fdbmajor\f31501\fbidi \froman\fcharset0\fprq2{\*\panose
02020603050405020304}Times New Roman{\*\falt Times New Roman};}
+{\fhimajor\f31502\fbidi \fswiss\fcharset0\fprq2{\*\panose
020f0302020204030204}Calibri Light;}{\fbimajor\f31503\fbidi
\froman\fcharset0\fprq2{\*\panose 02020603050405020304}Times New Roman{\*\falt
Times New Roman};}
+{\flominor\f31504\fbidi \froman\fcharset0\fprq2{\*\panose
02020603050405020304}Times New Roman{\*\falt Times New
Roman};}{\fdbminor\f31505\fbidi \froman\fcharset0\fprq2{\*\panose
02020603050405020304}Times New Roman{\*\falt Times New Roman};}
+{\fhiminor\f31506\fbidi \fswiss\fcharset0\fprq2{\*\panose
020f0502020204030204}Calibri;}{\fbiminor\f31507\fbidi
\froman\fcharset0\fprq2{\*\panose 02020603050405020304}Times New Roman{\*\falt
Times New Roman};}
+{\f61\fbidi \froman\fcharset238\fprq2 Times New Roman CE{\*\falt Times New
Roman};}{\f62\fbidi \froman\fcharset204\fprq2 Times New Roman Cyr{\*\falt Times
New Roman};}{\f64\fbidi \froman\fcharset161\fprq2 Times New Roman Greek{\*\falt
Times New Roman};}
+{\f65\fbidi \froman\fcharset162\fprq2 Times New Roman Tur{\*\falt Times New
Roman};}{\f66\fbidi \froman\fcharset177\fprq2 Times New Roman (Hebrew){\*\falt
Times New Roman};}
+{\f67\fbidi \froman\fcharset178\fprq2 Times New Roman (Arabic){\*\falt Times
New Roman};}{\f68\fbidi \froman\fcharset186\fprq2 Times New Roman
Baltic{\*\falt Times New Roman};}
+{\f69\fbidi \froman\fcharset163\fprq2 Times New Roman (Vietnamese){\*\falt
Times New Roman};}{\f71\fbidi \fswiss\fcharset238\fprq2 Arial CE;}{\f72\fbidi
\fswiss\fcharset204\fprq2 Arial Cyr;}{\f74\fbidi \fswiss\fcharset161\fprq2
Arial Greek;}
+{\f75\fbidi \fswiss\fcharset162\fprq2 Arial Tur;}{\f76\fbidi
\fswiss\fcharset177\fprq2 Arial (Hebrew);}{\f77\fbidi \fswiss\fcharset178\fprq2
Arial (Arabic);}{\f78\fbidi \fswiss\fcharset186\fprq2 Arial Baltic;}
+{\f79\fbidi \fswiss\fcharset163\fprq2 Arial (Vietnamese);}{\f661\fbidi
\fswiss\fcharset238\fprq2 Verdana CE;}{\f662\fbidi \fswiss\fcharset204\fprq2
Verdana Cyr;}{\f664\fbidi \fswiss\fcharset161\fprq2 Verdana Greek;}
[Libreoffice-bugs] [Bug 153011] FILEOPEN PPTX: rectangular shapes are missing shadows
https://bugs.documentfoundation.org/show_bug.cgi?id=153011 --- Comment #1 from Gerald Pfeifer --- Created attachment 184644 --> https://bugs.documentfoundation.org/attachment.cgi?id=184644=edit Visual comparison: Powerpoint (left) vs Impress (right) Ignore the top left item - something apparently was lost on the way - and focus on the lower row. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153011] New: FILEOPEN PPTX: rectangular shapes are missing shadows
https://bugs.documentfoundation.org/show_bug.cgi?id=153011 Bug ID: 153011 Summary: FILEOPEN PPTX: rectangular shapes are missing shadows Product: LibreOffice Version: 7.1.6.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ger...@pfeifer.com Created attachment 184643 --> https://bugs.documentfoundation.org/attachment.cgi?id=184643=edit Sample slide (PPTX) On the sample slide, all but on of the rectangular shapes are not showing a shadow in Impress (that they are showing in PowerPoint). Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 5b3fd1af1247d4096451e5a768c3438fbccec2b2 CPU threads: 8; OS: Linux 6.0; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US back to at least Version: 7.1.8.0.0+ / LibreOffice Community Build ID: 4784990eda6098f0408276b4d424e81382a50460 CPU threads: 8; OS: Linux 6.0; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:libreoffice-7-1, Time: 2021-10-15_11:37:03 Interestingly the top left shape does show a shadow (and used to do in LibreOffice 7.0 already, also not correct there.) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152997] SVG: circle based upon combination of solid lines + dashes, only renders as solid line
https://bugs.documentfoundation.org/show_bug.cgi?id=152997 Telesto changed: What|Removed |Added Status|UNCONFIRMED |NEW Keywords||bibisectRequest, regression Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152999] UI: Document background color in settings overrides cell background colors in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=152999 Rafael Lima changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||rafael.palma.l...@gmail.com Ever confirmed|0 |1 --- Comment #1 from Rafael Lima --- When using a dark theme in KDE, if you want the document background to be white (with black text), you need to use the "LibreOffice" color scheme. To do that: 1) Go to Tools - Options - Application Colors 2) Under "Color scheme" choose "LibreOffice" 3) Make sure all colors are set to "Automatic" 4) Click OK This should fix the problem. Let me know if the problem persists. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - sc/source
sc/source/ui/view/gridwin4.cxx |9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
New commits:
commit dbb8d805dbea42fa5955c2f9b54a1d476592df7d
Author: Szymon Kłos
AuthorDate: Tue Jan 10 10:56:18 2023 +0100
Commit: Andras Timar
CommitDate: Fri Jan 13 18:52:24 2023 +
lok: adjust paint rect for in-place editing
This allows to send correct cursor position (at the very end
of the cell) when typing numbers in LOK mode.
This fixes regression from:
commit 9257486636dfe95b73e5690462ba6e8408a12166
lok: sc: render expanded EditEngine when editing in-place
Change-Id: I1f6c7ce3de7a2ba7ccbd4f9f9becd49e352cf05e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145260
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Andras Timar
diff --git a/sc/source/ui/view/gridwin4.cxx b/sc/source/ui/view/gridwin4.cxx
index 6fdd332092de..31022c43144d 100644
--- a/sc/source/ui/view/gridwin4.cxx
+++ b/sc/source/ui/view/gridwin4.cxx
@@ -1174,7 +1174,9 @@ void ScGridWindow::DrawContent(OutputDevice ,
const ScTableInfo& rTableI
// Get top-left offset because of margin and
indent.
lcl_GetEditAreaTLOffset(nOffsetX, nOffsetY,
ScAddress(nCol1, nRow1, nTab), mrViewData, rDoc);
aEditRect.AdjustLeft(nOffsetX + 1);
+aEditRect.AdjustRight(1);
aEditRect.AdjustTop(nOffsetY + 1);
+aEditRect.AdjustBottom(1);
// EditView has an 'output area' which is used to
clip the 'paint area' we provide below.
// So they need to be in the same
coordinates/units. This is tied to the mapmode of the gridwin
@@ -1306,13 +1308,6 @@ void ScGridWindow::DrawContent(OutputDevice ,
const ScTableInfo& rTableI
// paint the editeng text
if (bIsTiledRendering)
{
-tools::Rectangle aEditRect(aBackground);
-tools::Long nOffsetX = 0, nOffsetY = 0;
-// Get top-left offset because of margin and indent.
-lcl_GetEditAreaTLOffset(nOffsetX, nOffsetY, ScAddress(nCol1,
nRow1, mrViewData.GetTabNo()), mrViewData, rDoc);
-aEditRect.AdjustLeft(nOffsetX + 1);
-aEditRect.AdjustTop(nOffsetY + 1);
-
// EditView has an 'output area' which is used to clip the paint
area we provide below.
// So they need to be in the same coordinates/units. This is tied
to the mapmode of the gridwin
// attached to the EditView, so we have to change its mapmode too
(temporarily). We save the
[Libreoffice-commits] core.git: 2 commits - editeng/source include/xmloff reportdesign/source xmloff/source
editeng/source/items/xmlcnitm.cxx |4 ++--
include/xmloff/attrlist.hxx |7 +--
include/xmloff/unoatrcn.hxx |9 ++---
reportdesign/source/filter/xml/xmlExportDocumentHandler.cxx |6 +++---
xmloff/source/core/attrlist.cxx |9 ++---
xmloff/source/core/unoatrcn.cxx | 11 ---
6 files changed, 10 insertions(+), 36 deletions(-)
New commits:
commit f2918ed9add416e16396965a4b6c7a5e8865a07f
Author: Noel Grandin
AuthorDate: Thu Jan 12 16:33:01 2023 +0200
Commit: Noel Grandin
CommitDate: Fri Jan 13 18:32:34 2023 +
XUnoTunnel->dynamic_cast in SvUnoAttributeContainer
Change-Id: Ief76f12dd98e3455667b70d09605c82c0cedc4b9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145485
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/editeng/source/items/xmlcnitm.cxx
b/editeng/source/items/xmlcnitm.cxx
index 50733ade4dd4..7507ed2afdd0 100644
--- a/editeng/source/items/xmlcnitm.cxx
+++ b/editeng/source/items/xmlcnitm.cxx
@@ -76,8 +76,8 @@ bool SvXMLAttrContainerItem::QueryValue( css::uno::Any& rVal,
sal_uInt8 /*nMembe
bool SvXMLAttrContainerItem::PutValue( const css::uno::Any& rVal, sal_uInt8
/*nMemberId*/ )
{
-Reference xTunnel(rVal, UNO_QUERY);
-if (auto pContainer =
comphelper::getFromUnoTunnel(xTunnel))
+Reference xTunnel(rVal, UNO_QUERY);
+if (auto pContainer =
dynamic_cast(xTunnel.get()))
{
maContainerData = *pContainer->GetContainerImpl();
}
diff --git a/include/xmloff/unoatrcn.hxx b/include/xmloff/unoatrcn.hxx
index 8e5556bb18aa..b09a06250215 100644
--- a/include/xmloff/unoatrcn.hxx
+++ b/include/xmloff/unoatrcn.hxx
@@ -28,18 +28,16 @@
#include
#include
#include
-#include
#include
-#include
+#include
extern css::uno::Reference< css::uno::XInterface >
SvUnoAttributeContainer_CreateInstance();
class XMLOFF_DLLPUBLIC SvUnoAttributeContainer final :
-public ::cppu::WeakAggImplHelper3<
+public ::cppu::WeakAggImplHelper2<
css::lang::XServiceInfo,
-css::lang::XUnoTunnel,
css::container::XNameContainer >
{
private:
@@ -52,9 +50,6 @@ public:
SvUnoAttributeContainer( std::unique_ptr
pContainer = nullptr );
SvXMLAttrContainerData* GetContainerImpl() const { return
mpContainer.get(); }
-static const css::uno::Sequence< sal_Int8 > & getUnoTunnelId() noexcept;
-virtual sal_Int64 SAL_CALL getSomething( const css::uno::Sequence<
sal_Int8 >& aIdentifier ) override;
-
// css::container::XElementAccess
virtual css::uno::Type SAL_CALL getElementType() override;
virtual sal_Bool SAL_CALL hasElements() override;
diff --git a/xmloff/source/core/unoatrcn.cxx b/xmloff/source/core/unoatrcn.cxx
index 354cd47b49ce..676c1d75ac65 100644
--- a/xmloff/source/core/unoatrcn.cxx
+++ b/xmloff/source/core/unoatrcn.cxx
@@ -86,17 +86,6 @@ sal_uInt16
SvUnoAttributeContainer::getIndexByName(std::u16string_view aName ) c
return USHRT_MAX;
}
-const css::uno::Sequence< sal_Int8 > &
SvUnoAttributeContainer::getUnoTunnelId() noexcept
-{
-static const comphelper::UnoIdInit theSvUnoAttributeContainerUnoTunnelId;
-return theSvUnoAttributeContainerUnoTunnelId.getSeq();
-}
-
-sal_Int64 SAL_CALL SvUnoAttributeContainer::getSomething( const
css::uno::Sequence< sal_Int8 >& rId )
-{
-return comphelper::getSomethingImpl(rId, this);
-}
-
// container::XNameAccess
uno::Any SAL_CALL SvUnoAttributeContainer::getByName(const OUString& aName)
{
commit 9ca22b602154dfab8f45a98259e5365b0a5e7bc4
Author: Noel Grandin
AuthorDate: Thu Jan 12 16:30:20 2023 +0200
Commit: Noel Grandin
CommitDate: Fri Jan 13 18:32:21 2023 +
XUnoTunnel->dynamic_cast in SvXMLAttributeList
Change-Id: I68806bf4b59f76c49f733283d9db21c68342c071
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145484
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/include/xmloff/attrlist.hxx b/include/xmloff/attrlist.hxx
index 7f4fef2b9544..1261dd5c2ac9 100644
--- a/include/xmloff/attrlist.hxx
+++ b/include/xmloff/attrlist.hxx
@@ -24,7 +24,6 @@
#include
#include
#include
-#include
#include
#include
@@ -32,8 +31,7 @@
class XMLOFF_DLLPUBLIC SvXMLAttributeList final : public
::cppu::WeakImplHelper<
css::xml::sax::XAttributeList,
-css::util::XCloneable,
-css::lang::XUnoTunnel>
+css::util::XCloneable>
{
struct SvXMLTagAttribute_Impl
{
@@ -48,9 +46,6 @@ public:
css::xml::sax::XAttributeList> & rAttrList );
virtual ~SvXMLAttributeList() override;
-// XUnoTunnel
-UNO3_GETIMPLEMENTATION_DECL(SvXMLAttributeList)
-
// css::xml::sax::XAttributeList
virtual sal_Int16 SAL_CALL getLength() override;
virtual OUString SAL_CALL getNameByIndex(sal_Int16 i) override;
diff --git
[Libreoffice-bugs] [Bug 113610] FILEOPEN XLSX: modern "form control" checkboxes not loaded
https://bugs.documentfoundation.org/show_bug.cgi?id=113610 Justin L changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||7266 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 117266] FILESAVE: xlsm- spreedsheet looses macro-linked buttons (and links) after saving
https://bugs.documentfoundation.org/show_bug.cgi?id=117266 Justin L changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||3610 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: include/vcl sc/source sd/source starmath/source sw/source vcl/source
include/vcl/transfer.hxx | 10 +-
sc/source/ui/app/drwtrans.cxx| 14 +-
sc/source/ui/app/transobj.cxx| 14 +-
sc/source/ui/inc/drwtrans.hxx|3 ---
sc/source/ui/inc/transobj.hxx|2 --
sc/source/ui/view/viewfun3.cxx |6 ++
sd/source/ui/app/sdxfer.cxx |5 -
sd/source/ui/dlg/sdtreelb.cxx| 12
sd/source/ui/inc/sdtreelb.hxx|3 ---
sd/source/ui/inc/sdxfer.hxx |3 ---
starmath/source/view.cxx |2 +-
sw/source/uibase/dochdl/swdtflvr.cxx | 14 +-
sw/source/uibase/inc/swdtflvr.hxx|3 ---
sw/source/uibase/inc/uivwimp.hxx |3 ++-
sw/source/uibase/uiview/uivwimp.cxx |7 +++
vcl/source/treelist/transfer.cxx | 12
16 files changed, 12 insertions(+), 101 deletions(-)
New commits:
commit d60722e29a0dde6282915188e5ff7e24890a14d3
Author: Noel Grandin
AuthorDate: Thu Jan 12 16:25:40 2023 +0200
Commit: Noel Grandin
CommitDate: Fri Jan 13 18:13:51 2023 +
XUnoTunnel->dynamic_cast in TransferableHelper
which leads us to find that we can skip all the dynamic_cast'ing
altogether in SwView_Impl
Change-Id: I8914f78df6bfdd743df370c0017d5b8521863594
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145483
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/include/vcl/transfer.hxx b/include/vcl/transfer.hxx
index bd5999a82234..e460e9f9c155 100644
--- a/include/vcl/transfer.hxx
+++ b/include/vcl/transfer.hxx
@@ -29,7 +29,6 @@
#include
#include
#include
-#include
#include
#include
#include
@@ -130,8 +129,7 @@ struct ExecuteDropEvent
class VCL_DLLPUBLIC TransferableHelper : public cppu::WeakImplHelper<
css::datatransfer::XTransferable2,
css::datatransfer::clipboard::XClipboardOwner,
-
css::datatransfer::dnd::XDragSourceListener,
-
css::lang::XUnoTunnel >
+
css::datatransfer::dnd::XDragSourceListener>
{
private:
@@ -265,12 +263,6 @@ public:
voidStartDrag( vcl::Window* pWindow, sal_Int8
nDragSourceActions );
static void ClearPrimarySelection();
-
-static const css::uno::Sequence< sal_Int8 >& getUnoTunnelId();
-
-public:
-
-virtual sal_Int64 SAL_CALL getSomething( const css::uno::Sequence<
sal_Int8 >& rId ) override;
};
struct TransferableDataHelper_Impl;
diff --git a/sc/source/ui/app/drwtrans.cxx b/sc/source/ui/app/drwtrans.cxx
index ed83dc893ae5..2ec8c57354b6 100644
--- a/sc/source/ui/app/drwtrans.cxx
+++ b/sc/source/ui/app/drwtrans.cxx
@@ -231,7 +231,7 @@ ScDrawTransferObj::~ScDrawTransferObj()
ScDrawTransferObj* ScDrawTransferObj::GetOwnClipboard(const
uno::Reference& xTransferable)
{
-return comphelper::getFromUnoTunnel(xTransferable);
+return dynamic_cast(xTransferable.get());
}
static bool lcl_HasOnlyControls( SdrModel* pModel )
@@ -719,16 +719,4 @@ void ScDrawTransferObj::InitDocShell()
pDocSh->UpdateOle(aViewData, true);
}
-const css::uno::Sequence< sal_Int8 >& ScDrawTransferObj::getUnoTunnelId()
-{
-static const comphelper::UnoIdInit theScDrawTransferObjUnoTunnelId;
-return theScDrawTransferObjUnoTunnelId.getSeq();
-}
-
-sal_Int64 SAL_CALL ScDrawTransferObj::getSomething( const css::uno::Sequence<
sal_Int8 >& rId )
-{
-return comphelper::getSomethingImpl(
-rId, this,
comphelper::FallbackToGetSomethingOf{});
-}
-
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sc/source/ui/app/transobj.cxx b/sc/source/ui/app/transobj.cxx
index a81e4149956e..3bba033d28e7 100644
--- a/sc/source/ui/app/transobj.cxx
+++ b/sc/source/ui/app/transobj.cxx
@@ -198,7 +198,7 @@ ScTransferObj::~ScTransferObj()
ScTransferObj* ScTransferObj::GetOwnClipboard(const
uno::Reference& xTransferable)
{
-return comphelper::getFromUnoTunnel(xTransferable);
+return dynamic_cast(xTransferable.get());
}
void ScTransferObj::AddSupportedFormats()
@@ -903,16 +903,4 @@ void ScTransferObj::StripRefs( ScDocument& rDoc,
}
}
-const css::uno::Sequence< sal_Int8 >& ScTransferObj::getUnoTunnelId()
-{
-static const comphelper::UnoIdInit theScTransferUnoTunnelId;
-return theScTransferUnoTunnelId.getSeq();
-}
-
-sal_Int64 SAL_CALL ScTransferObj::getSomething( const css::uno::Sequence<
sal_Int8 >& rId )
-{
-return comphelper::getSomethingImpl(
-rId, this,
comphelper::FallbackToGetSomethingOf{});
-}
-
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sc/source/ui/inc/drwtrans.hxx b/sc/source/ui/inc/drwtrans.hxx
index 34e4af7063fc..49ec9e1e34d3 100644
--- a/sc/source/ui/inc/drwtrans.hxx
+++ b/sc/source/ui/inc/drwtrans.hxx
@@ -90,9 +90,6 @@ public:
[Libreoffice-bugs] [Bug 153000] FILEOPEN DOCX file types MSO_SPT=25 to 31 are wrongly rendered
https://bugs.documentfoundation.org/show_bug.cgi?id=153000 --- Comment #6 from Julien Nabet --- Ok then I've submitted the patch here: https://gerrit.libreoffice.org/c/core/+/145491 As I indicated in it, you're the one who did the work! :-) -- You are receiving this mail because: You are the assignee for the bug.
