[Libreoffice-commits] core.git: include/svx sc/source sd/source svx/qa svx/source sw/source
include/svx/svdmodel.hxx|4 +
sc/source/ui/docshell/docsh.cxx |2
sd/source/ui/docshell/docshel4.cxx |1
svx/qa/unit/data/tdf148000_EOLinCurvedText.pptx |binary
svx/qa/unit/data/tdf148000_EOLinCurvedText_Legacy.odp |binary
svx/qa/unit/data/tdf148000_EOLinCurvedText_New.odp |binary
svx/qa/unit/svdraw.cxx | 42 +++
svx/source/customshapes/EnhancedCustomShapeFontWork.cxx | 57
svx/source/svdraw/svdmodel.cxx | 42 +++
sw/source/uibase/app/docshini.cxx | 10 +-
10 files changed, 142 insertions(+), 16 deletions(-)
New commits:
commit f9d6dd788e82a1964dab9cc0d0436c8c54b775c0
Author: Attila Szűcs
AuthorDate: Fri Jan 13 04:49:33 2023 +0100
Commit: Miklos Vajna
CommitDate: Fri Jan 20 07:56:29 2023 +
tdf#148000 impress: Handle linebreaks on fontwork.
Split text lines in a paragraph, right before polygons are created
for rendering, so eol will brake line in fontwork just like eop.
Change-Id: Ie9e6764f9f91c2e19afd43dc9a212bd18c41c99d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145425
Tested-by: Jenkins
Reviewed-by: Miklos Vajna
diff --git a/include/svx/svdmodel.hxx b/include/svx/svdmodel.hxx
index 7c23b5a24712..b5d93fa53eb7 100644
--- a/include/svx/svdmodel.hxx
+++ b/include/svx/svdmodel.hxx
@@ -575,6 +575,10 @@ public:
void SetAnchoredTextOverflowLegacy(bool bEnabled);
bool IsAnchoredTextOverflowLegacy() const;
+// tdf#148000 compatibility flag
+void SetLegacySingleLineFontwork(bool bEnabled);
+bool IsLegacySingleLineFontwork() const;
+
void ReformatAllTextObjects();
std::unique_ptr createOutliner( OutlinerMode nOutlinerMode );
diff --git a/sc/source/ui/docshell/docsh.cxx b/sc/source/ui/docshell/docsh.cxx
index 071c2530f61b..1f58bf43f1b7 100644
--- a/sc/source/ui/docshell/docsh.cxx
+++ b/sc/source/ui/docshell/docsh.cxx
@@ -589,6 +589,8 @@ bool ScDocShell::Load( SfxMedium& rMedium )
{
if (m_pDocument->GetDrawLayer())
m_pDocument->GetDrawLayer()->SetAnchoredTextOverflowLegacy(true);
+if (m_pDocument->GetDrawLayer())
+m_pDocument->GetDrawLayer()->SetLegacySingleLineFontwork(true);
//for tdf#148000
}
GetUndoManager()->Clear();
diff --git a/sd/source/ui/docshell/docshel4.cxx
b/sd/source/ui/docshell/docshel4.cxx
index 99d6890fe1f0..4df8aee97a4a 100644
--- a/sd/source/ui/docshell/docshel4.cxx
+++ b/sd/source/ui/docshell/docshel4.cxx
@@ -269,6 +269,7 @@ bool DrawDocShell::Load( SfxMedium& rMedium )
if (IsOwnStorageFormat(rMedium))
{
mpDoc->SetAnchoredTextOverflowLegacy(true);
+mpDoc->SetLegacySingleLineFontwork(true); //for tdf#148000
}
bool bRet = false;
diff --git a/svx/qa/unit/data/tdf148000_EOLinCurvedText.pptx
b/svx/qa/unit/data/tdf148000_EOLinCurvedText.pptx
new file mode 100644
index ..137fc816697a
Binary files /dev/null and b/svx/qa/unit/data/tdf148000_EOLinCurvedText.pptx
differ
diff --git a/svx/qa/unit/data/tdf148000_EOLinCurvedText_Legacy.odp
b/svx/qa/unit/data/tdf148000_EOLinCurvedText_Legacy.odp
new file mode 100644
index ..13e7cc4e5c8a
Binary files /dev/null and
b/svx/qa/unit/data/tdf148000_EOLinCurvedText_Legacy.odp differ
diff --git a/svx/qa/unit/data/tdf148000_EOLinCurvedText_New.odp
b/svx/qa/unit/data/tdf148000_EOLinCurvedText_New.odp
new file mode 100644
index ..7ebdb9431b72
Binary files /dev/null and b/svx/qa/unit/data/tdf148000_EOLinCurvedText_New.odp
differ
diff --git a/svx/qa/unit/svdraw.cxx b/svx/qa/unit/svdraw.cxx
index c2a7f244b8ab..7bf1ceb9d4a1 100644
--- a/svx/qa/unit/svdraw.cxx
+++ b/svx/qa/unit/svdraw.cxx
@@ -382,6 +382,48 @@ CPPUNIT_TEST_FIXTURE(SvdrawTest, testFontWorks)
"32");
}
+CPPUNIT_TEST_FIXTURE(SvdrawTest, testTdf148000_EOLinCurvedText)
+{
+std::vector aFilenames
+= { u"tdf148000_EOLinCurvedText.pptx",
u"tdf148000_EOLinCurvedText_New.odp",
+u"tdf148000_EOLinCurvedText_Legacy.odp" };
+
+for (int i = 0; i < 3; i++)
+{
+loadFromURL(aFilenames[i]);
+
+SdrPage* pSdrPage = getFirstDrawPageWithAssert();
+
+xmlDocUniquePtr pXmlDoc =
lcl_dumpAndParseFirstObjectWithAssert(pSdrPage);
+
+OString aBasePath
+=
"/primitive2D/objectinfo[4]/unhandled/unhandled/polypolygoncolor/polypolygon/";
+
+// The text is: "O" + eop + "O" + eol + "O"
+// It should be displayed as 3 line of text. (1 "O" letter in every
line)
+sal_Int32 nY1 = getXPath(pXmlDoc, aBasePath + "polygon[1]/point[1]",
"y").toInt32();
+sal_Int32 nY2 = getXPath(pXmlDoc, aBasePath + "polygon[3]/point[1]",
"y").toInt32();
+sal_Int32 nY3 = getXPath(pXmlDoc, aBasePath + "polygon[5]/point[1]",
"y").toInt32();
+
+sal_Int32 nDiff21
[Libreoffice-commits] core.git: include/vcl sw/qa sw/source vcl/source
include/vcl/filter/PDFiumLibrary.hxx |1 +
sw/qa/core/text/text.cxx | 24
sw/source/core/text/itrform2.cxx | 22 ++
vcl/source/pdf/PDFiumLibrary.cxx | 31 +++
4 files changed, 66 insertions(+), 12 deletions(-)
New commits:
commit 14da39fcfffe8006a79971ac0b670e12d0d7a0ea
Author: Miklos Vajna
AuthorDate: Thu Jan 19 19:53:12 2023 +0100
Commit: Miklos Vajna
CommitDate: Fri Jan 20 07:50:29 2023 +
tdf#153047 sw: fix PDF export of content controls in placeholder mode
Importing an inline content control from DOCX used to be just plain text
in Writer, so the PDF export of that was also just plain text.
Now that content controls are actually supported, we used to not emit
them as plain text in the PDF export, since
82d90529dc2b3cb8359dec78852cbd910a66d275 (sw content controls, rich
text: add initial PDF export, 2022-09-12). Part of this was to write the
string value of the content control as the /V (value) key of the form,
when it's not in placeholder mode. This made sure that once the form is
filled in, no overlap between the plain text and the filled in text
happens.
Try to support both use-cases at the same time by also mapping the value
of the content control to /V, even if it's in placeholder mode. This
keeps avoiding the unwanted overlap, but this way the placeholder text
is no longer lost on PDF export.
An alternative would have been to map the placeholder text to
description when the alias/title is empty, but that would show up only
as a mouse tooltip, so won't change the behavior when the PDF is
printed.
Change-Id: I9408b5abe36af28cd00845a74a3dfff13973b83a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145828
Tested-by: Jenkins
Reviewed-by: Miklos Vajna
diff --git a/include/vcl/filter/PDFiumLibrary.hxx
b/include/vcl/filter/PDFiumLibrary.hxx
index 347b64619045..9c278d281a1c 100644
--- a/include/vcl/filter/PDFiumLibrary.hxx
+++ b/include/vcl/filter/PDFiumLibrary.hxx
@@ -110,6 +110,7 @@ public:
virtual OUString getFormAdditionalActionJavaScript(PDFiumDocument* pDoc,
PDFAnnotAActionType
eEvent)
= 0;
+virtual OUString getFormFieldValue(PDFiumDocument* pDoc) = 0;
};
class PDFiumTextPage;
diff --git a/sw/qa/core/text/text.cxx b/sw/qa/core/text/text.cxx
index db1895b795c0..9391630acd51 100644
--- a/sw/qa/core/text/text.cxx
+++ b/sw/qa/core/text/text.cxx
@@ -675,6 +675,30 @@ CPPUNIT_TEST_FIXTURE(SwCoreTextTest, testContentControlPDF)
pAnnotation->getFormFieldAlternateName(pPdfDocument.get()));
}
+CPPUNIT_TEST_FIXTURE(SwCoreTextTest, testContentControlPlaceholderPDF)
+{
+// Given a file with a content control, in placeholder mode:
+createSwDoc();
+SwDoc* pDoc = getSwDoc();
+SwWrtShell* pWrtShell = pDoc->GetDocShell()->GetWrtShell();
+pWrtShell->InsertContentControl(SwContentControlType::RICH_TEXT);
+
+// When exporting to PDF:
+save("writer_pdf_Export");
+
+// Then make sure that a fillable form widget is emitted with the expected
value:
+std::unique_ptr pPdfDocument = parsePDFExport();
+std::unique_ptr pPage = pPdfDocument->openPage(0);
+CPPUNIT_ASSERT_EQUAL(1, pPage->getAnnotationCount());
+std::unique_ptr pAnnotation =
pPage->getAnnotation(0);
+// Without the accompanying fix in place, this test would have failed with:
+// - Expected: Click here to enter text
+// - Actual :
+// i.e. the value of the content control was empty, the placeholder value
was lost.
+CPPUNIT_ASSERT_EQUAL(SwResId(STR_CONTENT_CONTROL_PLACEHOLDER),
+ pAnnotation->getFormFieldValue(pPdfDocument.get()));
+}
+
CPPUNIT_TEST_FIXTURE(SwCoreTextTest, testCheckboxContentControlPDF)
{
// Given a file with a checkbox content control:
diff --git a/sw/source/core/text/itrform2.cxx b/sw/source/core/text/itrform2.cxx
index 9f075014fd9a..91f73ed87825 100644
--- a/sw/source/core/text/itrform2.cxx
+++ b/sw/source/core/text/itrform2.cxx
@@ -1047,18 +1047,16 @@ bool SwContentControlPortion::DescribePDFControl(const
SwTextPaintInfo& rInf) co
pDescriptor->Description = pContentControl->GetAlias();
}
-if (!pContentControl->GetShowingPlaceHolder())
-{
-SwPosition aPoint(*pTextNode, nStart);
-SwPosition aMark(*pTextNode, nEnd);
-SwPaM aPam(aMark, aPoint);
-OUString aText = aPam.GetText();
-static sal_Unicode const aForbidden[] = {
-CH_TXTATR_BREAKWORD,
-0
-};
-pDescriptor->Text = comphelper::string::removeAny(aText, aForbidden);
-}
+// Map the text of the content control to the descriptor's text.
+SwPosition aPoint(*pTextNode, nStart);
+SwPosition aMark(*pTextNode, nEnd);
+SwPaM aPam(aMark,
[Libreoffice-bugs] [Bug 135272] Tight integration dialog accessibility, close on escape
https://bugs.documentfoundation.org/show_bug.cgi?id=135272 Heiko Tietze changed: What|Removed |Added Summary|Tight integration dialog|Tight integration dialog |accessibility |accessibility, close on ||escape -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152848] When using accents in a table (spanish), a cell break occurs.
https://bugs.documentfoundation.org/show_bug.cgi?id=152848 Dieter changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 CC||dgp-m...@gmx.de --- Comment #1 from Dieter --- Zchronos, thank you for reporting the bug. It seems you're using an old version of LibreOffice. Could you please try to reproduce it with the latest version of LibreOffice from https://www.libreoffice.org/download/libreoffice-fresh/ ? I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' if the bug is still present in the latest version. Change to RESOLVED WORKSFORME, if the problem went away. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152804] TABLES: Numbers in a cell equal to or greater than 10 are set to 0 upon saving and re-opening
https://bugs.documentfoundation.org/show_bug.cgi?id=152804 --- Comment #7 from Dieter --- (In reply to Mitch from comment #5) > This seems similar to > https://bugs.documentfoundation.org/show_bug.cgi?id=133611, except it > doesn't happen for all numbers. Bug 133611 is a duplicate of bug 131025, which is fixed since LO 7.3. but perhaps not tested with numbers > 10. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 82254] FILESAVE: UTF-8 BOM removed from CSV when saving file
https://bugs.documentfoundation.org/show_bug.cgi?id=82254 Andreas Heinisch changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |andreas.heini...@yahoo.de |desktop.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103100] [META] Writer table bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=103100 Dieter changed: What|Removed |Added Depends on||152804 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=152804 [Bug 152804] TABLES: Numbers in a cell equal to or greater than 10 are set to 0 upon saving and re-opening -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152804] TABLES: Numbers in a cell equal to or greater than 10 are set to 0 upon saving and re-opening
https://bugs.documentfoundation.org/show_bug.cgi?id=152804 Dieter changed: What|Removed |Added Ever confirmed|0 |1 See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||1025 Summary|Numbers in a cell equal to |TABLES: Numbers in a cell |or greater than 10 are set |equal to or greater than 10 |to 0 upon saving and|are set to 0 upon saving |re-opening |and re-opening Hardware|x86-64 (AMD64) |All Blocks||103100 Status|UNCONFIRMED |NEW OS|Linux (All) |All CC||dgp-m...@gmx.de Whiteboard| QA:needsComment| --- Comment #6 from Dieter --- I confirm it with Version: 7.5.0.1 (X86_64) / LibreOffice Community Build ID: 77cd3d7ad4445740a0c6cf977992dafd8ebad8df CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL threaded Steps: 1. Open attachment 184436 2. Save, close and reopen Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103100 [Bug 103100] [META] Writer table bugs -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - svx/source
svx/source/styles/ColorSets.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 126018f3dee60462207380eba017d0fac6d6b0f8
Author: Andrea Gelmini
AuthorDate: Sat Jan 14 18:49:26 2023 +0100
Commit: Tomaž Vajngerl
CommitDate: Fri Jan 20 07:16:26 2023 +
Typo in "code"
Not sure about this...
Change-Id: I8aebfdf48dc7dc2bdbce180fa2f1bd3305489a24
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145516
Tested-by: Jenkins
Reviewed-by: Julien Nabet
Reviewed-by: Tomaž Vajngerl
(cherry picked from commit 92e6cd75a3599d3d411d123bd1e691ec447fa563)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145856
Tested-by: Tomaž Vajngerl
diff --git a/svx/source/styles/ColorSets.cxx b/svx/source/styles/ColorSets.cxx
index 439c63d1ee35..66a5e3e91016 100644
--- a/svx/source/styles/ColorSets.cxx
+++ b/svx/source/styles/ColorSets.cxx
@@ -252,7 +252,7 @@ void ColorSets::init()
maColorSets.push_back(aColorSet);
}
{
-ColorSet aColorSet("Forrest");
+ColorSet aColorSet("Forest");
aColorSet.add(model::ThemeColorType::Dark1, 0x00);
aColorSet.add(model::ThemeColorType::Light1, 0xFF);
aColorSet.add(model::ThemeColorType::Dark2, 0x00);
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - include/sfx2 include/svx officecfg/registry svx/Library_svx.mk svx/sdi svx/source svx/uiconfig svx/UIConfig_svx.mk sw/sdi sw/source
include/sfx2/sfxsids.hrc |1
include/svx/dialog/ThemeDialog.hxx | 42 ++
include/svx/theme/IThemeColorChanger.hxx | 26 +
officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu |8
svx/Library_svx.mk |1
svx/UIConfig_svx.mk |1
svx/sdi/svx.sdi | 17 +
svx/source/dialog/ThemeDialog.cxx| 63
svx/uiconfig/ui/themedialog.ui | 145
++
sw/sdi/_basesh.sdi |7
sw/source/core/inc/ThemeColorChanger.hxx |7
sw/source/core/model/ThemeColorChanger.cxx |2
sw/source/uibase/shells/basesh.cxx | 26 +
sw/uiconfig/sglobal/menubar/menubar.xml |1
sw/uiconfig/swriter/menubar/menubar.xml |1
15 files changed, 346 insertions(+), 2 deletions(-)
New commits:
commit 1484112b94baef357c91e2e872825ef5f52b09f3
Author: Tomaž Vajngerl
AuthorDate: Tue Jan 10 20:21:31 2023 +0900
Commit: Tomaž Vajngerl
CommitDate: Fri Jan 20 07:16:06 2023 +
ThemeDialog added which allows to change the theme used by the doc.
ThemeDialog is a common dialog that can be used to select the
theme used by the document. Currently it only implements colors
but in the future also the fonts and formats (for shapes) will
be adde.
The IThemeColorChanger interface is used by the dialog to change
the actual color values inside the document. For the writer the
existing ThemeColorChanger is now implementing the interface.
The dialog is accessible in Writer at Format -> Theme... in the
main menu.
Change-Id: I23c7dc9668cdc5427f36d604a76c433d6dbef497
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145264
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
(cherry picked from commit d4e4a2b96a787b4f99d68d7a417c37c97b47c170)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145855
Tested-by: Tomaž Vajngerl
diff --git a/include/sfx2/sfxsids.hrc b/include/sfx2/sfxsids.hrc
index a0289c0881ab..d029b314d4d9 100644
--- a/include/sfx2/sfxsids.hrc
+++ b/include/sfx2/sfxsids.hrc
@@ -469,6 +469,7 @@ class SvxZoomItem;
#define SID_ACCESSIBILITY_CHECK (SID_SFX_START + 812)
#define SID_ASYNCHRON (SID_SFX_START + 813)
#define SID_ACCESSIBILITY_CHECK_ONLINE (SID_SFX_START + 814)
+#define SID_THEME_DIALOG(SID_SFX_START + 815)
// default-ids for configuration
#define SID_CONFIG (SID_SFX_START + 904)
diff --git a/include/svx/dialog/ThemeDialog.hxx
b/include/svx/dialog/ThemeDialog.hxx
new file mode 100644
index ..968c54af9e98
--- /dev/null
+++ b/include/svx/dialog/ThemeDialog.hxx
@@ -0,0 +1,42 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#pragma once
+
+#include
+#include
+#include
+#include
+#include
+#include
+
+namespace svx
+{
+class SVX_DLLPUBLIC ThemeDialog final : public weld::GenericDialogController
+{
+private:
+svx::Theme* mpTheme;
+svx::ColorSets maColorSets;
+std::shared_ptr mpChanger;
+
+std::unique_ptr mxValueSetThemeColors;
+std::unique_ptr mxValueSetThemeColorsWindow;
+
+public:
+ThemeDialog(weld::Window* pParent, svx::Theme* pTheme,
+std::shared_ptr const& pChanger);
+virtual ~ThemeDialog() override;
+
+DECL_LINK(DoubleClickValueSetHdl, ValueSet*, void);
+void DoubleClickHdl();
+};
+
+} // end svx namespace
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/include/svx/theme/IThemeColorChanger.hxx
b/include/svx/theme/IThemeColorChanger.hxx
new file mode 100644
index ..5f90f273ee37
--- /dev/null
+++ b/include/svx/theme/IThemeColorChanger.hxx
@@ -0,0 +1,26 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#pragma once
+
+#include
+#include
+
+namespace svx
+{
+class SVX_DLLPUBLIC IThemeColorChanger
+{
+public:
+virtual ~IThemeColorChanger() = default;
+virtual void
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - sw/inc sw/Library_sw.mk sw/source
sw/Library_sw.mk |1
sw/inc/swtypes.hxx |6
sw/source/core/inc/ThemeColorChanger.hxx | 33 +++
sw/source/core/inc/UndoAttribute.hxx |2
sw/source/core/model/ThemeColorChanger.cxx | 271 +
sw/source/core/undo/unattr.cxx | 21 +-
sw/source/uibase/sidebar/ThemePanel.cxx| 44
7 files changed, 331 insertions(+), 47 deletions(-)
New commits:
commit 7283ee786d3234241c595f26463520dfa0c326e9
Author: Tomaž Vajngerl
AuthorDate: Fri Jan 6 17:28:49 2023 +0900
Commit: Tomaž Vajngerl
CommitDate: Fri Jan 20 07:15:29 2023 +
sw: add ThemeColorChanger that sweeps the model and changes colors
The ThemeColorChanger responisiblity is to recalculate and change
all the theme colors in the model. This includes styles and direct
formatting changes. It uses ModelTraverser for direct formatting
changes as it already implements traversing through nodes.
The ThemeColorChanger replaces the code to change the colors in
ThemePanel.
Also modify undo/redo for changing of attributes to not move
the cursor and selection when undoing and redoing (new flag
NO_CURSOR_CHANGE), as in this case it is very distrcting.
Change-Id: Ida1912bd0697307daad9244d474862830ab2686f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145263
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
(cherry picked from commit 1af58b5acec4a2de095d86feef05ac4aed3edb8f)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145854
Tested-by: Tomaž Vajngerl
diff --git a/sw/Library_sw.mk b/sw/Library_sw.mk
index 478136e50f54..fa2ca1663512 100644
--- a/sw/Library_sw.mk
+++ b/sw/Library_sw.mk
@@ -366,6 +366,7 @@ $(eval $(call gb_Library_add_exception_objects,sw,\
sw/source/core/layout/wsfrm \
sw/source/core/model/ModelTraverser \
sw/source/core/model/SearchResultLocator \
+sw/source/core/model/ThemeColorChanger \
sw/source/core/objectpositioning/anchoredobjectposition \
sw/source/core/objectpositioning/ascharanchoredobjectposition \
sw/source/core/objectpositioning/environmentofanchoredobject \
diff --git a/sw/inc/swtypes.hxx b/sw/inc/swtypes.hxx
index 96c0fb5008c3..b3cdfa531074 100644
--- a/sw/inc/swtypes.hxx
+++ b/sw/inc/swtypes.hxx
@@ -143,17 +143,19 @@ enum class SetAttrMode
NOHINTADJUST= 0x0008, // No merging of ranges.
NOFORMATATTR= 0x0010, // Do not change into format attribute.
APICALL = 0x0020, // Called from API (all UI related
-// functionality will
be disabled).
+ // functionality will be disabled).
/// Force hint expand (only matters for hints with CH_TXTATR).
FORCEHINTEXPAND = 0x0040,
/// The inserted item is a copy -- intended for use in ndtxt.cxx.
IS_COPY = 0x0080,
/// for Undo, translated to SwInsertFlags::NOHINTEXPAND
NOHINTEXPAND= 0x0100,
+/// don't change the cursor position
+NO_CURSOR_CHANGE = 0x0200
};
namespace o3tl
{
-template<> struct typed_flags : is_typed_flags {};
+template<> struct typed_flags : is_typed_flags {};
}
namespace sw {
diff --git a/sw/source/core/inc/ThemeColorChanger.hxx
b/sw/source/core/inc/ThemeColorChanger.hxx
new file mode 100644
index ..0698126da3e9
--- /dev/null
+++ b/sw/source/core/inc/ThemeColorChanger.hxx
@@ -0,0 +1,33 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ *
+ */
+#pragma once
+
+#include
+#include
+
+namespace sw
+{
+class ThemeColorChanger
+{
+private:
+SwDocShell* mpDocSh;
+
+public:
+ThemeColorChanger(SwDocShell* pDocSh)
+: mpDocSh(pDocSh)
+{
+}
+
+void apply(svx::ColorSet const& rColorSet);
+};
+
+} // end sw namespace
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/core/inc/UndoAttribute.hxx
b/sw/source/core/inc/UndoAttribute.hxx
index c3cf4925d95a..e3c40b7f0e87 100644
--- a/sw/source/core/inc/UndoAttribute.hxx
+++ b/sw/source/core/inc/UndoAttribute.hxx
@@ -45,7 +45,7 @@ class SwUndoAttr final : public SwUndo, private SwUndRng
OUString m_aChrFormatName;
void RemoveIdx( SwDoc& rDoc );
-
+void redoAttribute(SwPaM& rPam, sw::UndoRedoContext& rContext);
public:
SwUndoAttr( const SwPaM&, SfxItemSet, const SetAttrMode nFlags );
SwUndoAttr( const SwPaM&, const SfxPoolItem&, const SetAttrMode nFlags );
diff --git a/sw/source/core/model/ThemeColorChanger.cxx
b/sw/source/core/model/ThemeColorChanger.cxx
new file mode 100644
index ..ff59c474748b
--- /dev/null
+++
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - 2 commits - include/svx svx/Library_svx.mk svx/source sw/source sw/uiconfig
include/svx/dialog/ThemeColorValueSet.hxx | 38 ++
svx/Library_svx.mk|1
svx/source/dialog/ThemeColorValueSet.cxx | 98 +++
svx/source/styles/ColorSets.cxx | 100 +++
sw/source/uibase/sidebar/ThemePanel.cxx | 412 +-
sw/source/uibase/sidebar/ThemePanel.hxx |7
sw/uiconfig/swriter/ui/sidebartheme.ui| 164 +++
7 files changed, 306 insertions(+), 514 deletions(-)
New commits:
commit 733a7bf52296e941cd77c9bf7a4ff64e69b57879
Author: Tomaž Vajngerl
AuthorDate: Thu Jan 5 23:58:50 2023 +0900
Commit: Tomaž Vajngerl
CommitDate: Fri Jan 20 07:14:58 2023 +
sw: rework ThemePanel, theme color ValueSet drawing as custom draw
Rework the ThemePanel to only work with theme colors, as fonts
are uing an old mock implemntation of themes. To do this properly
it is needed to remove the implementation for now.
The theme colors entries were rendered as a bitmap and then shown
in the ValueSet. This has the problem that it doesn't look sharp
on a HiDPI screen, so replace that with a ThemeColorValueSet, which
uses custom draw to render the theme color entries directly.
The ThemeColorValueSet was added to th svx component as it will be
used in other components as well.
Change-Id: I1a727ef4cf4be4e215db57ac33f571f43aaddc15
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145087
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
(cherry picked from commit 8bc22ed6899bcbafc3020f0af6c939019506a5fd)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145853
Tested-by: Tomaž Vajngerl
diff --git a/include/svx/dialog/ThemeColorValueSet.hxx
b/include/svx/dialog/ThemeColorValueSet.hxx
new file mode 100644
index ..4b70ed0f56db
--- /dev/null
+++ b/include/svx/dialog/ThemeColorValueSet.hxx
@@ -0,0 +1,38 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#pragma once
+
+#include
+#include
+#include
+#include
+
+namespace svx
+{
+class SVX_DLLPUBLIC ThemeColorValueSet final : public ValueSet
+{
+std::vector> maColorSets;
+
+public:
+ThemeColorValueSet()
+: ValueSet(nullptr)
+{
+}
+
+void SetDrawingArea(weld::DrawingArea* pDrawingArea) override;
+void UserDraw(const UserDrawEvent& rUserDrawEvent) override;
+void StyleUpdated() override;
+
+void insert(svx::ColorSet const& rColorSet);
+};
+
+} // end svx namespace
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/svx/Library_svx.mk b/svx/Library_svx.mk
index 29f8d16454c7..9021b46d7f1b 100644
--- a/svx/Library_svx.mk
+++ b/svx/Library_svx.mk
@@ -174,6 +174,7 @@ $(eval $(call gb_Library_add_exception_objects,svx,\
svx/source/dialog/svxruler \
svx/source/dialog/swframeexample \
svx/source/dialog/swframeposstrings \
+svx/source/dialog/ThemeColorValueSet \
svx/source/dialog/txencbox \
svx/source/dialog/txenctab \
svx/source/dialog/weldeditview \
diff --git a/svx/source/dialog/ThemeColorValueSet.cxx
b/svx/source/dialog/ThemeColorValueSet.cxx
new file mode 100644
index ..204a37ba72de
--- /dev/null
+++ b/svx/source/dialog/ThemeColorValueSet.cxx
@@ -0,0 +1,98 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include
+#include
+#include
+
+namespace svx
+{
+constexpr tools::Long BORDER = 3;
+constexpr tools::Long SIZE = 14;
+constexpr tools::Long LABEL_HEIGHT = 16;
+constexpr tools::Long LABEL_TEXT_HEIGHT = 14;
+constexpr tools::Long constElementNumber = 8;
+
+void ThemeColorValueSet::insert(svx::ColorSet const& rColorSet)
+{
+maColorSets.push_back(std::cref(rColorSet));
+InsertItem(maColorSets.size());
+}
+
+void ThemeColorValueSet::SetDrawingArea(weld::DrawingArea* pDrawingArea)
+{
+ValueSet::SetDrawingArea(pDrawingArea);
+SetStyle(WB_TABSTOP | WB_ITEMBORDER | WB_DOUBLEBORDER);
+Size aSize(BORDER * 7 + SIZE * 6 + BORDER * 2, BORDER * 3 + SIZE * 2 +
LABEL_HEIGHT);
+SetItemWidth(aSize.Width());
+SetItemHeight(aSize.Height());
+}
+
+void ThemeColorValueSet::UserDraw(const UserDrawEvent& rUserDrawEvent)
+{
+vcl::RenderContext* pDev = rUserDrawEvent.GetRenderContext();
+tools::Rectangle aRect = rUserDrawEvent.GetRect();
+const Point aPosition = aRect.GetPos();
+const sal_uInt16 nItemId = rUserDrawEvent.GetItemId();
+svx::ColorSet const&
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - 2 commits - include/svx oox/source svx/source
include/svx/ColorSets.hxx | 15 +---
oox/source/drawingml/clrscheme.cxx | 24 +++---
svx/source/styles/ColorSets.cxx| 138 -
3 files changed, 76 insertions(+), 101 deletions(-)
New commits:
commit ca8e0aadbdc519fe52bd6cba8ef8f8af88bd5ff6
Author: Tomaž Vajngerl
AuthorDate: Thu Jan 5 23:22:47 2023 +0900
Commit: Tomaž Vajngerl
CommitDate: Fri Jan 20 07:14:32 2023 +
svx: add resolveColor that resolves the color for input theme
resolveColor added to ColorSet resolves the color for the input
ThemeColor, which contains the index for the color in the ColorSet
and applies all the additional tranformations defined in the
ThemeColor.
Change-Id: I5c6d53d5e1d2c61bdb22b0e58c034ec91fbeb2d4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145085
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
(cherry picked from commit 4d17d06279d3bceee8d4b92f444b5e425412c576)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145851
Tested-by: Tomaž Vajngerl
diff --git a/include/svx/ColorSets.hxx b/include/svx/ColorSets.hxx
index d971cb1f5b77..115236da1979 100644
--- a/include/svx/ColorSets.hxx
+++ b/include/svx/ColorSets.hxx
@@ -17,7 +17,7 @@
#include
#include
#include
-#include
+#include
#include
typedef struct _xmlTextWriter* xmlTextWriterPtr;
@@ -42,15 +42,8 @@ public:
return maName;
}
-Color getColor(model::ThemeColorType nType) const
-{
-if (nType == model::ThemeColorType::Unknown)
-{
-SAL_WARN("svx", "ColorSet::getColor with ThemeColorType::Unknown");
-return COL_AUTO;
-}
-return maColors[size_t(nType)];
-}
+Color resolveColor(model::ThemeColor const& rThemeColor) const;
+Color getColor(model::ThemeColorType eType) const;
void dumpAsXml(xmlTextWriterPtr pWriter) const;
};
diff --git a/svx/source/styles/ColorSets.cxx b/svx/source/styles/ColorSets.cxx
index 0f24480c15e6..cf634b735c37 100644
--- a/svx/source/styles/ColorSets.cxx
+++ b/svx/source/styles/ColorSets.cxx
@@ -52,9 +52,7 @@ void UpdateTextPortionColorSet(const
uno::Reference& xPorti
if (aThemeColor.getType() == model::ThemeColorType::Unknown)
return;
-Color aColor = rColorSet.getColor(aThemeColor.getType());
-aColor = aThemeColor.applyTransformations(aColor);
-
+Color aColor = rColorSet.resolveColor(aThemeColor);
xPortion->setPropertyValue(UNO_NAME_EDIT_CHAR_COLOR,
uno::Any(static_cast(aColor)));
}
@@ -74,8 +72,7 @@ void UpdateFillColorSet(const
uno::Reference& xShape, const
if (aThemeColor.getType() == model::ThemeColorType::Unknown)
return;
-Color aColor = rColorSet.getColor(aThemeColor.getType());
-aColor = aThemeColor.applyTransformations(aColor);
+Color aColor = rColorSet.resolveColor(aThemeColor);
xShape->setPropertyValue(UNO_NAME_FILLCOLOR,
uno::Any(static_cast(aColor)));
}
@@ -125,6 +122,28 @@ void ColorSet::add(model::ThemeColorType eType, Color
aColorData)
maColors[sal_Int16(eType)] = aColorData;
}
+Color ColorSet::getColor(model::ThemeColorType eType) const
+{
+if (eType == model::ThemeColorType::Unknown)
+{
+SAL_WARN("svx", "ColorSet::getColor with ThemeColorType::Unknown");
+return COL_AUTO;
+}
+return maColors[size_t(eType)];
+}
+
+Color ColorSet::resolveColor(model::ThemeColor const& rThemeColor) const
+{
+auto eType = rThemeColor.getType();
+if (eType == model::ThemeColorType::Unknown)
+{
+SAL_WARN("svx", "ColorSet::resolveColor with ThemeColorType::Unknown");
+return COL_AUTO;
+}
+Color aColor = getColor(eType);
+return rThemeColor.applyTransformations(aColor);
+}
+
void ColorSet::dumpAsXml(xmlTextWriterPtr pWriter) const
{
(void)xmlTextWriterStartElement(pWriter, BAD_CAST("ColorSet"));
commit f3bf7ed7a0e788cf5559c65af7327864526cde73
Author: Tomaž Vajngerl
AuthorDate: Thu Jan 5 14:46:30 2023 +0900
Commit: Tomaž Vajngerl
CommitDate: Fri Jan 20 07:14:21 2023 +
svx: change ColorSet add method to use ThemeColorTyp enum
Change-Id: I2034a7e915d41c6b55c8344d44be4f6a60e8287e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145072
Tested-by: Tomaž Vajngerl
Reviewed-by: Tomaž Vajngerl
(cherry picked from commit 0b35b239c0ff1adad2c4544d8692b5b13a0d363b)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145850
diff --git a/include/svx/ColorSets.hxx b/include/svx/ColorSets.hxx
index ac420031527b..d971cb1f5b77 100644
--- a/include/svx/ColorSets.hxx
+++ b/include/svx/ColorSets.hxx
@@ -35,7 +35,7 @@ class SVXCORE_DLLPUBLIC ColorSet
public:
ColorSet(OUString const& rName);
-void add(sal_uInt32 nIndex, Color aColorData);
+void add(model::ThemeColorType Type, Color aColorData);
const OUString& getName() const
{
diff --git a/oox/source/drawingml/clrscheme.cxx
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - 2 commits - include/editeng include/oox include/svx oox/inc oox/qa oox/source sd/source svx/source
include/editeng/unoprnms.hxx |1
include/oox/export/drawingml.hxx |2
include/svx/unoshprp.hxx |1
oox/inc/drawingml/lineproperties.hxx |3
oox/qa/unit/data/ThemeShapesReference.pptx |binary
oox/qa/unit/drawingml.cxx | 92 +
oox/source/drawingml/fillproperties.cxx|2
oox/source/drawingml/lineproperties.cxx| 34 +-
oox/source/drawingml/shape.cxx |4 -
oox/source/export/drawingml.cxx| 64
oox/source/token/properties.txt|1
sd/source/core/stlsheet.cxx| 10 +++
svx/source/table/cell.cxx | 12 +++
svx/source/unodraw/unoshape.cxx| 10 +++
svx/source/xoutdev/xattr.cxx | 44 +++--
15 files changed, 205 insertions(+), 75 deletions(-)
New commits:
commit be7284695ac1a2a583f98479cd6864d7ef41c5e0
Author: Tomaž Vajngerl
AuthorDate: Thu Jan 5 13:12:34 2023 +0900
Commit: Tomaž Vajngerl
CommitDate: Fri Jan 20 07:14:09 2023 +
support theme color for lines + oox support + tests
Extended XLineColor to handle model::ThemeColor which then maps
to the newly added LineColorThemeData property.
Extended oox import and export to map the scheme color elements
to and from ThemeColor. Added a new test to check the theme line
color in impress shapes.
Change-Id: I23ecc18c88b5b47608c9110f5681f189d02e2f36
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145071
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
(cherry picked from commit af8fdba1194e657237f9abc460381a1c4bc49982)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145849
Tested-by: Tomaž Vajngerl
diff --git a/include/editeng/unoprnms.hxx b/include/editeng/unoprnms.hxx
index 7f82cd0b1fea..300a0a2b7765 100644
--- a/include/editeng/unoprnms.hxx
+++ b/include/editeng/unoprnms.hxx
@@ -77,6 +77,7 @@ inline constexpr OUStringLiteral UNO_NAME_LINESTYLE =
u"LineStyle";
inline constexpr OUStringLiteral UNO_NAME_LINEDASH = u"LineDash";
inline constexpr OUStringLiteral UNO_NAME_LINEWIDTH = u"LineWidth";
inline constexpr OUStringLiteral UNO_NAME_LINECOLOR = u"LineColor";
+inline constexpr OUStringLiteral UNO_NAME_LINECOLOR_THEME_REFERENCE =
u"LineColorThemeReference";
inline constexpr OUStringLiteral UNO_NAME_LINEJOINT = u"LineJoint";
inline constexpr OUStringLiteral UNO_NAME_LINESTART = u"LineStart";
inline constexpr OUStringLiteral UNO_NAME_LINEEND = u"LineEnd";
diff --git a/include/oox/export/drawingml.hxx b/include/oox/export/drawingml.hxx
index eb0fea23b95c..c131632aea8d 100644
--- a/include/oox/export/drawingml.hxx
+++ b/include/oox/export/drawingml.hxx
@@ -235,7 +235,7 @@ public:
void WriteConnectorConnections( sal_Int32 nStartGlueId, sal_Int32
nEndGlueId, sal_Int32 nStartID, sal_Int32 nEndID );
bool WriteCharColor(const css::uno::Reference&
xPropertySet);
-bool WriteFillColor(const css::uno::Reference&
xPropertySet);
+bool WriteSchemeColor(OUString const& rPropertyName, const
css::uno::Reference& xPropertySet);
void WriteSolidFill( ::Color nColor, sal_Int32 nAlpha = MAX_PERCENT );
void WriteSolidFill( const OUString& sSchemeName, const
css::uno::Sequence< css::beans::PropertyValue >& aTransformations, sal_Int32
nAlpha = MAX_PERCENT );
diff --git a/include/svx/unoshprp.hxx b/include/svx/unoshprp.hxx
index 8af8142c1d43..70be33007013 100644
--- a/include/svx/unoshprp.hxx
+++ b/include/svx/unoshprp.hxx
@@ -236,6 +236,7 @@
#define LINE_PROPERTIES_DEFAULTS\
{ UNO_NAME_LINECAP, XATTR_LINECAP,
::cppu::UnoType::get(), 0, 0}, \
{ UNO_NAME_LINECOLOR, XATTR_LINECOLOR,
::cppu::UnoType::get() , 0, 0}, \
+{ UNO_NAME_LINECOLOR_THEME_REFERENCE, XATTR_LINECOLOR,
::cppu::UnoType::get() , 0,
MID_COLOR_THEME_REFERENCE}, \
{ UNO_NAME_LINEENDCENTER, XATTR_LINEENDCENTER,
cppu::UnoType::get() , 0, 0}, \
{ UNO_NAME_LINEENDWIDTH, XATTR_LINEENDWIDTH,
::cppu::UnoType::get() , 0, 0,
PropertyMoreFlags::METRIC_ITEM}, \
{ UNO_NAME_LINEJOINT, XATTR_LINEJOINT,
::cppu::UnoType::get(), 0, 0}, \
diff --git a/oox/inc/drawingml/lineproperties.hxx
b/oox/inc/drawingml/lineproperties.hxx
index f2d37a7f8a9f..52c27825bdaf 100644
--- a/oox/inc/drawingml/lineproperties.hxx
+++ b/oox/inc/drawingml/lineproperties.hxx
@@ -69,7 +69,8 @@ struct LineProperties
voidpushToPropMap(
ShapePropertyMap& rPropMap,
const GraphicHelper& rGraphicHelper,
-::Color nPhClr = API_RGB_TRANSPARENT ) const;
+::Color nPhClr = API_RGB_TRANSPARENT,
+sal_Int16 nPhClrTheme = -1) const;
/** Calculates the line
[Libreoffice-bugs] [Bug 122048] SQL TRIGGER does not properly display SQLSTATE message text in a Base form
https://bugs.documentfoundation.org/show_bug.cgi?id=122048 --- Comment #12 from Robert Großkopf --- Buggy behavior still there in LO 7.4.4.2 on OpenSUSE 15.3 64bit rpm Linux. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - 2 commits - include/xmloff oox/qa schema/libreoffice writerfilter/source xmloff/CppunitTest_xmloff_draw.mk xmloff/CppunitTest_xmlof
dev/null|binary include/xmloff/txtprmap.hxx |2 include/xmloff/xmltoken.hxx |8 oox/qa/unit/data/ReferenceShapeFill.odp |binary oox/qa/unit/export.cxx | 21 schema/libreoffice/OpenDocument-v1.3+libreoffice-schema.rng | 88 ++- writerfilter/source/dmapper/TDefTableHandler.cxx|8 xmloff/CppunitTest_xmloff_draw.mk |1 xmloff/CppunitTest_xmloff_uxmloff.mk|1 xmloff/Library_xo.mk|3 xmloff/inc/XMLThemeColorContext.hxx | 33 + xmloff/inc/XMLThemeColorExport.hxx | 30 + xmloff/inc/XMLThemeColorHandler.hxx | 40 - xmloff/inc/xmlprop.hxx |8 xmloff/qa/unit/data/Reference-ThemeColors-TextAndFill.pptx |binary xmloff/qa/unit/data/ReferenceShapeFill.pptx |binary xmloff/qa/unit/draw.cxx | 268 +--- xmloff/source/core/xmltoken.cxx |8 xmloff/source/draw/XMLShapePropertySetContext.cxx |4 xmloff/source/draw/sdpropls.cxx |4 xmloff/source/style/PagePropertySetContext.cxx |4 xmloff/source/text/XMLTextPropertySetContext.cxx|6 xmloff/source/text/XMLTextShapeStyleContext.cxx |4 xmloff/source/text/XMLThemeColorContext.cxx | 116 + xmloff/source/text/XMLThemeColorExport.cxx | 85 +++ xmloff/source/text/txtexppr.cxx |7 xmloff/source/text/txtexppr.hxx |2 xmloff/source/text/txtprhdl.cxx | 18 xmloff/source/text/txtprmap.cxx |9 xmloff/source/token/tokens.txt |8 30 files changed, 607 insertions(+), 179 deletions(-) New commits: commit 1f5cfa7be7eb67c602d15f8ce610f61badf47b98 Author: Tomaž Vajngerl AuthorDate: Thu Jan 5 12:32:02 2023 +0900 Commit: Tomaž Vajngerl CommitDate: Fri Jan 20 07:13:47 2023 + ooxml: fix theme color type mapping: bg -> light, text -> dark Change-Id: I19ad3ef7c911943075d7ddc01626047cdf11d5db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145070 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl (cherry picked from commit 1a79594a27f41ad369e7c387c51e00afb1352872) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145847 Tested-by: Tomaž Vajngerl diff --git a/writerfilter/source/dmapper/TDefTableHandler.cxx b/writerfilter/source/dmapper/TDefTableHandler.cxx index 4d279ac4bc12..b8e0582de033 100644 --- a/writerfilter/source/dmapper/TDefTableHandler.cxx +++ b/writerfilter/source/dmapper/TDefTableHandler.cxx @@ -300,13 +300,13 @@ model::ThemeColorType TDefTableHandler::getThemeColorTypeIndex(sal_Int32 nType) case NS_ooxml::LN_Value_St_ThemeColor_none: return model::ThemeColorType::Unknown; case NS_ooxml::LN_Value_St_ThemeColor_background1: -return model::ThemeColorType::Dark1; -case NS_ooxml::LN_Value_St_ThemeColor_text1: return model::ThemeColorType::Light1; +case NS_ooxml::LN_Value_St_ThemeColor_text1: +return model::ThemeColorType::Dark1; case NS_ooxml::LN_Value_St_ThemeColor_background2: -return model::ThemeColorType::Dark2; -case NS_ooxml::LN_Value_St_ThemeColor_text2: return model::ThemeColorType::Light2; +case NS_ooxml::LN_Value_St_ThemeColor_text2: +return model::ThemeColorType::Dark2; default: break; } commit d58e3a0716a91e3d1360299a926c7060a47d0650 Author: Tomaž Vajngerl AuthorDate: Sat Dec 31 20:59:03 2022 +0900 Commit: Tomaž Vajngerl CommitDate: Fri Jan 20 07:13:37 2023 + xmloff: use XThemeColor in ODF, change the format for themes Change the xmloff filter to use XThemeColor and the associated proprties (CharColorThemeReference and FillColorThemeReference). Change the ODF format for referencing a theme color - make it an element instead a series of attributes on the *-properties style element. Change-Id: I0fa7d8ebffecc02897b7fe9824d6f1776ef36380 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144923 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl (cherry picked from commit 3eb53d327fb5d9689b799ff991a6c53c05eff496) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145846 Tested-by: Tomaž Vajngerl diff --git a/include/xmloff/txtprmap.hxx b/include/xmloff/txtprmap.hxx index 37c0d7a9f330..986bbd007d8a 100644 ---
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - 2 commits - bin/update_pch cui/inc cui/Library_cui.mk cui/source docmodel/inc docmodel/Library_docmodel.mk docmodel/Makefile docmod
Repository.mk |1 RepositoryModule_build.mk |1 RepositoryModule_host.mk |1 bin/update_pch| 31 ++-- cui/Library_cui.mk|1 cui/inc/pch/precompiled_cui.hxx | 14 +- cui/source/tabpages/chardlg.cxx | 12 + cui/source/tabpages/tpcolor.cxx | 10 - docmodel/Library_docmodel.mk | 39 + docmodel/Makefile |7 + docmodel/Module_docmodel.mk | 18 ++ docmodel/README.md|5 docmodel/inc/pch/precompiled_docmodel.cxx | 12 + docmodel/inc/pch/precompiled_docmodel.hxx | 34 + docmodel/source/uno/UnoThemeColor.cxx | 40 ++ editeng/CppunitTest_editeng_core.mk |1 editeng/Library_editeng.mk|1 editeng/inc/pch/precompiled_editeng.hxx |7 - editeng/source/items/textitem.cxx | 124 +++--- editeng/source/uno/unotext.cxx| 28 +++- forms/qa/unoapi/knownissues.xcl |2 include/docmodel/dllapi.h | 21 +++ include/docmodel/theme/ThemeColor.hxx | 146 ++ include/docmodel/theme/ThemeColorType.hxx | 42 ++ include/docmodel/uno/UnoThemeColor.hxx| 55 include/editeng/colritem.hxx | 54 include/editeng/memberids.h |1 include/editeng/unoprnms.hxx |3 include/editeng/unotext.hxx |1 include/svx/ColorSets.hxx | 35 + include/svx/unoshprp.hxx |1 include/svx/xcolit.hxx|9 - offapi/UnoApi_offapi.mk |1 offapi/com/sun/star/util/XThemeColor.idl | 26 +++ oox/CppunitTest_oox_drawingml.mk |1 oox/CppunitTest_oox_shape.mk |1 oox/CppunitTest_oox_tokenmap.mk |1 oox/Library_oox.mk|2 oox/inc/pch/precompiled_oox.hxx | 69 +++--- oox/qa/unit/drawingml.cxx | 71 ++ oox/qa/unit/shape.cxx | 12 + oox/source/drawingml/fillproperties.cxx | 21 ++- oox/source/drawingml/textcharacterproperties.cxx | 23 ++- oox/source/export/ThemeExport.cxx | 28 ++-- oox/source/export/drawingml.cxx | 99 +++--- oox/source/token/properties.txt |2 sd/CppunitTest_sd_uiimpress.mk|1 sd/CppunitTest_sd_uimpress.mk |1 sd/Library_sd.mk |1 sd/inc/pch/precompiled_sd.hxx | 68 +- sd/qa/unit/uiimpress.cxx | 61 - sd/source/core/stlsheet.cxx | 27 +++- sd/source/filter/eppt/pptx-epptooxml.cxx |2 sd/source/ui/func/fuconstr.cxx|4 sd/source/ui/view/drtxtob1.cxx| 29 ++-- sd/source/ui/view/drviews2.cxx|7 - solenv/gbuild/extensions/pre_MergedLibsList.mk|1 solenv/qa/python/gbuildtojson.py |2 svx/CppunitTest_svx_removewhichrange.mk |1 svx/CppunitTest_svx_styles.mk |1 svx/CppunitTest_svx_unit.mk |1 svx/Library_svxcore.mk|1 svx/inc/pch/precompiled_svx.hxx | 29 ++-- svx/qa/unit/styles.cxx| 43 +++--- svx/qa/unit/xoutdev.cxx | 47 +++ svx/source/styles/ColorSets.cxx | 68 -- svx/source/table/cell.cxx | 28 +++- svx/source/unodraw/unoprov.cxx|1 svx/source/unodraw/unoshap2.cxx |1 svx/source/unodraw/unoshape.cxx | 27 +++- svx/source/xoutdev/xattr.cxx | 62 +++-- sw/CppunitTest_sw_apitests.mk |1 sw/CppunitTest_sw_core_draw.mk|1 sw/CppunitTest_sw_core_theme.mk |1 sw/CppunitTest_sw_macros_test.mk |1 sw/CppunitTest_sw_ooxmlimport.mk |1 sw/CppunitTest_sw_ooxmlimport2.mk |1 sw/CppunitTest_sw_tiledrendering.mk |1 sw/CppunitTest_sw_uwriter.mk |1 sw/Library_sw.mk |1 sw/layoutwriter_setup.mk |
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - 2 commits - include/oox include/svx oox/Library_oox.mk oox/source svx/source sw/source
include/oox/export/ThemeExport.hxx | 38
include/svx/ColorSets.hxx |2
oox/Library_oox.mk |1
oox/source/export/ThemeExport.cxx | 263
svx/source/styles/ColorSets.cxx |5
sw/source/uibase/sidebar/ThemePanel.cxx | 15 +
6 files changed, 324 insertions(+)
New commits:
commit 299270cadfde2376494d939521c58b5b0797acd5
Author: Tomaž Vajngerl
AuthorDate: Mon Dec 12 22:26:41 2022 +0900
Commit: Tomaž Vajngerl
CommitDate: Fri Jan 20 07:13:02 2023 +
sw: add the ColorSet from SdrPage into ColorSets in ThemePanel
Change-Id: I7c4ef103b2be65a8adbad5d4f00304ee22be668f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143997
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
(cherry picked from commit 7c10e3b120ba75a2db75342fdc68040a179404b8)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145843
Tested-by: Tomaž Vajngerl
diff --git a/include/svx/ColorSets.hxx b/include/svx/ColorSets.hxx
index bbc3dda2cdee..c966f411efa6 100644
--- a/include/svx/ColorSets.hxx
+++ b/include/svx/ColorSets.hxx
@@ -93,6 +93,8 @@ public:
}
const ColorSet& getColorSet(std::u16string_view rName);
+
+void insert(ColorSet const& rColorSet);
};
struct SVXCORE_DLLPUBLIC ThemeSupplementalFont
diff --git a/svx/source/styles/ColorSets.cxx b/svx/source/styles/ColorSets.cxx
index bb8009fdc5be..5511253f3d03 100644
--- a/svx/source/styles/ColorSets.cxx
+++ b/svx/source/styles/ColorSets.cxx
@@ -238,6 +238,11 @@ const ColorSet& ColorSets::getColorSet(std::u16string_view
rName)
return maColorSets[0];
}
+void ColorSets::insert(ColorSet const& rColorSet)
+{
+maColorSets.push_back(rColorSet);
+}
+
Theme::Theme(OUString const& rName)
: maName(rName)
{
diff --git a/sw/source/uibase/sidebar/ThemePanel.cxx
b/sw/source/uibase/sidebar/ThemePanel.cxx
index 9be8649def38..97856cfedbac 100644
--- a/sw/source/uibase/sidebar/ThemePanel.cxx
+++ b/sw/source/uibase/sidebar/ThemePanel.cxx
@@ -30,6 +30,11 @@
#include
#include
#include
+#include
+#include
+#include
+#include
+
namespace
{
@@ -442,6 +447,16 @@ ThemePanel::ThemePanel(weld::Widget* pParent)
maColorSets.init();
+SwDocShell* pDocSh = static_cast(SfxObjectShell::Current());
+SwDoc* pDocument = pDocSh->GetDoc();
+if (pDocument)
+{
+SdrPage* pPage =
pDocument->getIDocumentDrawModelAccess().GetDrawModel()->GetPage(0);
+svx::Theme* pTheme = pPage->getSdrPageProperties().GetTheme();
+if (pTheme)
+maColorSets.insert(*pTheme->GetColorSet());
+}
+
const std::vector& aColorSets = maColorSets.getColorSets();
for (size_t i = 0; i < aColorSets.size(); ++i)
{
commit 09c73ae2bd9c533645c2c8412bf66be92ef6d743
Author: Tomaž Vajngerl
AuthorDate: Mon Dec 12 22:18:43 2022 +0900
Commit: Tomaž Vajngerl
CommitDate: Fri Jan 20 07:12:52 2023 +
oox: add ThemeExport that exports a svx::Theme into theme.xml file
Adds ThemeExport that takes a svx::Theme as input and exports that
into a theme.xml file in the OOXML document. Currently supports
exporting of color schemes and font schemes. Format schemes are
hard-coded for now. The ThemeExport isn't yet used in any actual
export functionality.
Change-Id: I5ca9c256da65be77e7192be7d66c73d26d78ebd8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143996
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
(cherry picked from commit 958d4667e361a1d8461889117ca830a5da85d0ee)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145842
Tested-by: Tomaž Vajngerl
diff --git a/include/oox/export/ThemeExport.hxx
b/include/oox/export/ThemeExport.hxx
new file mode 100644
index ..02f222cadafe
--- /dev/null
+++ b/include/oox/export/ThemeExport.hxx
@@ -0,0 +1,38 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#pragma once
+
+#include
+#include
+#include
+#include
+
+namespace oox
+{
+class OOX_DLLPUBLIC ThemeExport
+{
+private:
+oox::core::XmlFilterBase* mpFilterBase;
+
+public:
+ThemeExport(oox::core::XmlFilterBase* pFilterBase);
+
+void write(OUString const& rPath, svx::Theme const& rTheme);
+
+private:
+static bool writeColorSet(sax_fastparser::FSHelperPtr pFS, svx::Theme
const& rTheme);
+static bool writeFontScheme(sax_fastparser::FSHelperPtr pFS,
+svx::FontScheme const& rFontScheme);
+static bool writeFormatScheme(sax_fastparser::FSHelperPtr pFS);
+};
+
+} // end namespace oox
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - 2 commits - include/oox include/svx oox/inc oox/Library_oox.mk oox/source solenv/clang-format svx/CppunitTest_svx_unit.mk svx/qa sw
include/oox/drawingml/ThemeFilterBase.hxx | 58 +
include/oox/drawingml/theme.hxx| 12
include/oox/drawingml/themefragmenthandler.hxx |1
include/svx/ColorSets.hxx | 149 +++
oox/Library_oox.mk |1
oox/inc/drawingml/textfont.hxx |3
oox/source/drawingml/ThemeFilterBase.cxx | 50 +
oox/source/drawingml/textfont.cxx |9
oox/source/drawingml/theme.cxx | 69 +
oox/source/drawingml/themeelementscontext.cxx | 23
oox/source/drawingml/themefragmenthandler.cxx | 56 -
oox/source/shape/ShapeContextHandler.cxx |4
solenv/clang-format/excludelist|1
svx/CppunitTest_svx_unit.mk|1
svx/qa/unit/ThemeTest.cxx | 40
sw/qa/core/theme/ThemeTest.cxx | 46 +
writerfilter/Library_writerfilter.mk |3
writerfilter/inc/ooxml/OOXMLDocument.hxx |3
writerfilter/source/dmapper/DomainMapper.cxx | 27
writerfilter/source/dmapper/DomainMapper_Impl.cxx |8
writerfilter/source/dmapper/DomainMapper_Impl.hxx | 19
writerfilter/source/dmapper/ThemeHandler.cxx | 422 +
writerfilter/source/dmapper/ThemeHandler.hxx | 35
writerfilter/source/dmapper/ThemeTable.cxx | 563 -
writerfilter/source/dmapper/ThemeTable.hxx | 58 -
writerfilter/source/ooxml/OOXMLDocumentImpl.cxx| 14
writerfilter/source/ooxml/OOXMLDocumentImpl.hxx|9
writerfilter/source/ooxml/OOXMLFactory.hxx |2
writerfilter/source/ooxml/OOXMLFastContextHandlerTheme.cxx | 69 +
writerfilter/source/ooxml/OOXMLFastContextHandlerTheme.hxx | 46 +
writerfilter/source/ooxml/model.xml|2
31 files changed, 1116 insertions(+), 687 deletions(-)
New commits:
commit 330afe0206fb2b8e952d3a46ec809a866fc6fe82
Author: Tomaž Vajngerl
AuthorDate: Tue Dec 6 17:33:44 2022 +0900
Commit: Tomaž Vajngerl
CommitDate: Fri Jan 20 07:12:40 2023 +
sw: read theme from OOXML file and set it to the draw page
This change extends writerfilter to use oox::ThemeFragmentHandler
to read the theme properties, and sets that to the one and only
draw page of a Writer document.
This change also removes ThemeTable and replaces it with the
ThemeHandler, which takes theme font data from svx::Theme
instead.
In addition, a test has been writen, which loads a document with
a theme, and asserts the draw page has the theme and the theme
properties currently supported.
Change-Id: Iff0048cd21ea030ac55287707852acc463ec3cb0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143699
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
(cherry picked from commit 31213fc7cae358038aaec853584782c698f8)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145841
Tested-by: Tomaž Vajngerl
diff --git a/include/oox/drawingml/ThemeFilterBase.hxx
b/include/oox/drawingml/ThemeFilterBase.hxx
new file mode 100644
index ..7f311e206a90
--- /dev/null
+++ b/include/oox/drawingml/ThemeFilterBase.hxx
@@ -0,0 +1,58 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#pragma once
+
+#include
+#include
+#include
+#include
+#include
+
+namespace oox::drawingml
+{
+class OOX_DLLPUBLIC ThemeFilterBase final : public core::XmlFilterBase
+{
+public:
+typedef rtl::Reference Pointer_t;
+
+explicit ThemeFilterBase(css::uno::Reference
const& rxContext);
+
+virtual ~ThemeFilterBase() override;
+
+/** Has to be implemented by each filter, returns the current theme. */
+virtual const oox::drawingml::Theme* getCurrentTheme() const override;
+
+/** May be implemented by filters which handle Diagrams, default returns
empty ptr */
+virtual std::shared_ptr getCurrentThemePtr() const
override;
+
+void setCurrentTheme(const oox::drawingml::ThemePtr& pTheme);
+
+/** Has to be implemented by each filter to return the collection of VML
shapes. */
+virtual oox::vml::Drawing* getVmlDrawing() override;
+
+/** Has to be implemented by each filter to return TableStyles. */
+virtual oox::drawingml::table::TableStyleListPtr getTableStyles() override;
+
+virtual oox::drawingml::chart::ChartConverter*
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - 2 commits - include/oox include/svx oox/source svx/source
include/oox/drawingml/theme.hxx |8 ---
include/svx/ColorSets.hxx | 22 ++--
oox/source/drawingml/themeelementscontext.cxx | 17 +++
svx/source/styles/ColorSets.cxx | 28 ++
4 files changed, 44 insertions(+), 31 deletions(-)
New commits:
commit 77d1b32832cafab03eb858b3b37eeeaf61b51cc4
Author: Tomaž Vajngerl
AuthorDate: Mon Dec 12 21:48:17 2022 +0900
Commit: Tomaž Vajngerl
CommitDate: Fri Jan 20 07:12:16 2023 +
svx: use array for colors in ColorSet, add consts, rename vars
Use std::array for colors in ColorSet as there are always only 12
colors for a color scheme.
Add "const" to getters where appropriate.
Rename maColorSetName to maName in ColorSet - long variable name
is not needed.
Change-Id: Iacb976a22af2d2585d627b0ba65d98cbe1b825c8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143994
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
(cherry picked from commit 29c2bba1f3ef216d226c97197185066880fc1ab5)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145839
Tested-by: Tomaž Vajngerl
diff --git a/include/svx/ColorSets.hxx b/include/svx/ColorSets.hxx
index 692e683218e8..6b4504ebb877 100644
--- a/include/svx/ColorSets.hxx
+++ b/include/svx/ColorSets.hxx
@@ -11,6 +11,7 @@
#ifndef INCLUDED_SVX_COLORSETS_HXX
#define INCLUDED_SVX_COLORSETS_HXX
+#include
#include
#include
@@ -52,19 +53,17 @@ constexpr ThemeColorType convertToThemeColorType(sal_Int32
nIndex)
class SVXCORE_DLLPUBLIC ColorSet
{
-OUString maColorSetName;
-std::vector maColors;
+OUString maName;
+std::array maColors;
+
public:
-ColorSet(OUString aName);
+ColorSet(OUString const& rName);
-void add(sal_uInt32 nIndex, ::Color aColorData)
-{
-maColors[nIndex] = aColorData;
-}
+void add(sal_uInt32 nIndex, Color aColorData);
const OUString& getName() const
{
-return maColorSetName;
+return maName;
}
Color getColor(ThemeColorType nType) const
@@ -88,7 +87,7 @@ public:
return maColorSets;
}
-const ColorSet& getColorSet(sal_uInt32 nIndex)
+const ColorSet& getColorSet(sal_uInt32 nIndex) const
{
return maColorSets[nIndex];
}
@@ -99,14 +98,15 @@ public:
/// A named theme has a named color set.
class SVXCORE_DLLPUBLIC Theme
{
+private:
OUString maName;
std::unique_ptr mpColorSet;
public:
-Theme(OUString sName);
-~Theme();
+Theme(OUString const& rName);
void SetColorSet(std::unique_ptr pColorSet);
+const ColorSet* GetColorSet() const;
ColorSet* GetColorSet();
void SetName(const OUString& rName);
diff --git a/svx/source/styles/ColorSets.cxx b/svx/source/styles/ColorSets.cxx
index 6af2ee6313bc..bb8009fdc5be 100644
--- a/svx/source/styles/ColorSets.cxx
+++ b/svx/source/styles/ColorSets.cxx
@@ -93,7 +93,7 @@ void UpdateFillColorSet(const
uno::Reference& xShape, const
void UpdateSdrObject(svx::Theme* pTheme, SdrObject* pObject)
{
-svx::ColorSet* pColorSet = pTheme->GetColorSet();
+const svx::ColorSet* pColorSet = pTheme->GetColorSet();
if (!pColorSet)
{
return;
@@ -126,20 +126,21 @@ void UpdateSdrObject(svx::Theme* pTheme, SdrObject*
pObject)
namespace svx
{
-ColorSet::ColorSet(OUString aColorSetName)
-: maColorSetName(std::move(aColorSetName))
-, maColors(12)
+ColorSet::ColorSet(OUString const& rName)
+: maName(rName)
{}
-ColorSets::ColorSets()
-{}
+void ColorSet::add(sal_uInt32 nIndex, Color aColorData)
+{
+maColors[nIndex] = aColorData;
+}
void ColorSet::dumpAsXml(xmlTextWriterPtr pWriter) const
{
(void)xmlTextWriterStartElement(pWriter, BAD_CAST("ColorSet"));
(void)xmlTextWriterWriteFormatAttribute(pWriter, BAD_CAST("ptr"), "%p",
this);
-(void)xmlTextWriterWriteAttribute(pWriter, BAD_CAST("maColorSetName"),
-
BAD_CAST(maColorSetName.toUtf8().getStr()));
+(void)xmlTextWriterWriteAttribute(pWriter, BAD_CAST("maName"),
+ BAD_CAST(maName.toUtf8().getStr()));
for (const auto& rColor : maColors)
{
@@ -153,6 +154,9 @@ void ColorSet::dumpAsXml(xmlTextWriterPtr pWriter) const
(void)xmlTextWriterEndElement(pWriter);
}
+ColorSets::ColorSets()
+{}
+
ColorSets::~ColorSets()
{}
@@ -234,15 +238,15 @@ const ColorSet&
ColorSets::getColorSet(std::u16string_view rName)
return maColorSets[0];
}
-Theme::Theme(OUString aName)
-: maName(std::move(aName))
+Theme::Theme(OUString const& rName)
+: maName(rName)
{
}
-Theme::~Theme() {}
-
void Theme::SetColorSet(std::unique_ptr pColorSet) { mpColorSet =
std::move(pColorSet); }
+const ColorSet* Theme::GetColorSet() const { return mpColorSet.get(); }
+
ColorSet* Theme::GetColorSet() { return mpColorSet.get(); }
void Theme::SetName(const
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - include/oox include/svx oox/source
include/oox/drawingml/clrscheme.hxx |3 +++
include/svx/ColorSets.hxx |2 +-
oox/source/drawingml/clrscheme.cxx | 27 +++
oox/source/drawingml/theme.cxx | 30 --
4 files changed, 51 insertions(+), 11 deletions(-)
New commits:
commit fa044ee2d251a11e9dda56851d5a06f900db5be7
Author: Tomaž Vajngerl
AuthorDate: Mon Dec 12 21:13:07 2022 +0900
Commit: Tomaž Vajngerl
CommitDate: Fri Jan 20 07:11:50 2023 +
oox: set svx::Theme directly to a SdrPage when importing
Bypass the need to set the theme data (svx::Theme) throught UNO
as multiple nested properties. Much more properties will be added
to the svx::Theme and this will simplify handling a lot.
Change-Id: I0b54628ff22c7c823a999de257fd5bb45e736bdb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143992
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
(cherry picked from commit a6253e13e0f3f866ab47e4271db9a80d8cbce708)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145837
Tested-by: Tomaž Vajngerl
diff --git a/include/oox/drawingml/clrscheme.hxx
b/include/oox/drawingml/clrscheme.hxx
index a4f0b653441a..fd7662511a88 100644
--- a/include/oox/drawingml/clrscheme.hxx
+++ b/include/oox/drawingml/clrscheme.hxx
@@ -30,6 +30,7 @@
#include
#include
#include
+#include
namespace oox::drawingml {
@@ -94,6 +95,8 @@ public:
const OUString& GetName() const { return maName; }
void ToAny(css::uno::Any& rVal) const;
+void fill(svx::ColorSet& rColorSet) const;
+
};
}
diff --git a/include/svx/ColorSets.hxx b/include/svx/ColorSets.hxx
index 71f12c2dbe71..692e683218e8 100644
--- a/include/svx/ColorSets.hxx
+++ b/include/svx/ColorSets.hxx
@@ -50,7 +50,7 @@ constexpr ThemeColorType convertToThemeColorType(sal_Int32
nIndex)
return static_cast(nIndex);
}
-class ColorSet
+class SVXCORE_DLLPUBLIC ColorSet
{
OUString maColorSetName;
std::vector maColors;
diff --git a/oox/source/drawingml/clrscheme.cxx
b/oox/source/drawingml/clrscheme.cxx
index 19c0afd44900..225faf81eecf 100644
--- a/oox/source/drawingml/clrscheme.cxx
+++ b/oox/source/drawingml/clrscheme.cxx
@@ -120,6 +120,33 @@ void ClrScheme::ToAny(css::uno::Any& rVal) const
rVal <<= comphelper::containerToSequence(aRet);
}
+void ClrScheme::fill(svx::ColorSet& rColorSet) const
+{
+for (const auto& [nToken, rColor] : maClrScheme)
+{
+switch (nToken)
+{
+case XML_tx1:
+case XML_dk1: rColorSet.add(0, rColor); break;
+case XML_bg1:
+case XML_lt1: rColorSet.add(1, rColor); break;
+case XML_tx2:
+case XML_dk2: rColorSet.add(2, rColor); break;
+case XML_bg2:
+case XML_lt2: rColorSet.add(3, rColor); break;
+case XML_accent1: rColorSet.add(4, rColor); break;
+case XML_accent2: rColorSet.add(5, rColor); break;
+case XML_accent3: rColorSet.add(6, rColor); break;
+case XML_accent4: rColorSet.add(7, rColor); break;
+case XML_accent5: rColorSet.add(8, rColor); break;
+case XML_accent6: rColorSet.add(9, rColor); break;
+case XML_hlink: rColorSet.add(10, rColor); break;
+case XML_folHlink: rColorSet.add(11, rColor); break;
+default: break;
+}
+}
+}
+
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/oox/source/drawingml/theme.cxx b/oox/source/drawingml/theme.cxx
index f406f829ea91..885d87b1bb0f 100644
--- a/oox/source/drawingml/theme.cxx
+++ b/oox/source/drawingml/theme.cxx
@@ -24,6 +24,11 @@
#include
#include
#include
+#include
+#include
+#include
+#include
+#include
using namespace com::sun::star;
@@ -105,16 +110,21 @@ const TextFont* Theme::resolveFont( std::u16string_view
rName ) const
void Theme::addTheme(const css::uno::Reference&
xDrawPage) const
{
-beans::PropertyValue aColorScheme;
-aColorScheme.Name = "ColorScheme";
-maClrScheme.ToAny(aColorScheme.Value);
-beans::PropertyValues aValues = {
-comphelper::makePropertyValue("Name", maThemeName),
-comphelper::makePropertyValue("ColorSchemeName",
maClrScheme.GetName()),
-aColorScheme,
-};
-uno::Reference xPropertySet(xDrawPage,
uno::UNO_QUERY);
-xPropertySet->setPropertyValue("Theme", uno::Any(aValues));
+SAL_WARN_IF(!xDrawPage.is(), "oox", "DrawPage is not set");
+
+SdrPage* pPage = GetSdrPageFromXDrawPage(xDrawPage);
+
+SAL_WARN_IF(!pPage, "oox", "Can't get SdrPage from XDrawPage");
+
+if (!pPage)
+return;
+
+auto pTheme = std::make_unique(maThemeName);
+auto pColorSet = std::make_unique(maClrScheme.GetName());
+maClrScheme.fill(*pColorSet);
+pTheme->SetColorSet(std::move(pColorSet));
+
+pPage->getSdrPageProperties().SetTheme(std::move(pTheme));
}
} // namespace oox::drawingml
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - 2 commits - include/svx oox/inc oox/source sd/source svx/source sw/source
include/svx/ColorSets.hxx| 48 ++-
oox/inc/drawingml/textfont.hxx | 10 +++---
oox/source/drawingml/textfont.cxx| 20
sd/source/filter/eppt/pptx-epptooxml.cxx |3 +
sd/source/ui/func/fuconstr.cxx |2 -
svx/source/styles/ColorSets.cxx | 31 +---
sw/source/uibase/sidebar/ThemePanel.cxx |7 ++--
7 files changed, 69 insertions(+), 52 deletions(-)
New commits:
commit 0edc0b43105b7c326e9501e994a2f039d1915021
Author: Tomaž Vajngerl
AuthorDate: Mon Dec 12 20:59:59 2022 +0900
Commit: Tomaž Vajngerl
CommitDate: Fri Jan 20 07:11:39 2023 +
svx: rename mnPitch to mnPitchFamily, add resolvePitchFamily
Rename mnPitch to mnPitchFamily as it contains both. Extract the
code to resolve what is pitch and what is family into its own
(static) function.
Change-Id: I0c17351ea690a85decefb8d73dd07644ce5c78d5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143991
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
(cherry picked from commit 4ee7e71d850315f5ae4c3b763b0e80e8d83a6454)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145836
Tested-by: Tomaž Vajngerl
diff --git a/oox/inc/drawingml/textfont.hxx b/oox/inc/drawingml/textfont.hxx
index 6bdf13ab890a..231b18cffecb 100644
--- a/oox/inc/drawingml/textfont.hxx
+++ b/oox/inc/drawingml/textfont.hxx
@@ -51,6 +51,8 @@ public:
sal_Int16& rnFontFamily,
const ::oox::core::XmlFilterBase& rFilter ) const;
+static void resolvePitch(sal_Int32 nOoxPitch, sal_Int16& rnFontPitch,
sal_Int16& rnFontFamily);
+
private:
boolimplGetFontData(
OUString& rFontName,
@@ -58,10 +60,10 @@ private:
sal_Int16& rnFontFamily ) const;
private:
-OUString maTypeface;
-OUString maPanose;
-sal_Int32 mnPitch;
-sal_Int32 mnCharset;
+OUString maTypeface;
+OUString maPanose;
+sal_Int32 mnPitchFamily;
+sal_Int32 mnCharset;
};
diff --git a/oox/source/drawingml/textfont.cxx
b/oox/source/drawingml/textfont.cxx
index bcfe516893ee..e5899780ad2c 100644
--- a/oox/source/drawingml/textfont.cxx
+++ b/oox/source/drawingml/textfont.cxx
@@ -48,7 +48,7 @@ sal_Int16 lclGetFontFamily( sal_Int32 nOoxValue )
} // namespace
TextFont::TextFont() :
-mnPitch( 0 ),
+mnPitchFamily(0),
mnCharset( WINDOWS_CHARSET_ANSI )
{
}
@@ -56,16 +56,16 @@ TextFont::TextFont() :
void TextFont::setAttributes( const AttributeList& rAttribs )
{
maTypeface = rAttribs.getStringDefaulted( XML_typeface);
-maPanose = rAttribs.getStringDefaulted( XML_panose);
-mnPitch= rAttribs.getInteger( XML_pitchFamily, 0 );
-mnCharset = rAttribs.getInteger( XML_charset, WINDOWS_CHARSET_DEFAULT );
+maPanose = rAttribs.getStringDefaulted( XML_panose);
+mnPitchFamily = rAttribs.getInteger( XML_pitchFamily, 0 );
+mnCharset = rAttribs.getInteger( XML_charset, WINDOWS_CHARSET_DEFAULT );
}
void TextFont::setAttributes( const OUString& sFontName )
{
maTypeface = sFontName;
maPanose.clear();
-mnPitch = 0;
+mnPitchFamily = 0;
mnCharset = WINDOWS_CHARSET_DEFAULT;
}
@@ -86,11 +86,17 @@ bool TextFont::getFontData( OUString& rFontName, sal_Int16&
rnFontPitch, sal_Int
bool TextFont::implGetFontData( OUString& rFontName, sal_Int16& rnFontPitch,
sal_Int16& rnFontFamily ) const
{
rFontName = maTypeface;
-rnFontPitch = lclGetFontPitch( extractValue< sal_Int16 >( mnPitch, 0, 4 )
);
-rnFontFamily = lclGetFontFamily( extractValue< sal_Int16 >( mnPitch, 4, 4
) );
+resolvePitch(mnPitchFamily, rnFontPitch, rnFontFamily);
return !rFontName.isEmpty();
}
+void TextFont::resolvePitch(sal_Int32 nOoxPitchFamily, sal_Int16& rnFontPitch,
sal_Int16& rnFontFamily)
+{
+rnFontPitch = lclGetFontPitch(extractValue(nOoxPitchFamily, 0,
4));
+rnFontFamily = lclGetFontFamily(extractValue(nOoxPitchFamily,
4, 4));
+}
+
+
} // namespace oox::drawingml
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
commit 6ff08e13e6eed09a9b51413910947ac4d75bc620
Author: Tomaž Vajngerl
AuthorDate: Mon Dec 12 20:17:09 2022 +0900
Commit: Tomaž Vajngerl
CommitDate: Fri Jan 20 07:11:27 2023 +
svx: rename ThemeColorType enum values, use enum instead of index
Change-Id: I81c1553205365c4076562474078b3b0aa834b249
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143990
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
(cherry picked from commit 1386e26b2d7fc5173266ffbfb94bc82b1d3f7bb9)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145835
Tested-by: Tomaž Vajngerl
diff --git a/include/svx/ColorSets.hxx b/include/svx/ColorSets.hxx
index 91ac4e1651c7..71f12c2dbe71 100644
--- a/include/svx/ColorSets.hxx
+++ b/include/svx/ColorSets.hxx
@@
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - 2 commits - editeng/source include/editeng sw/CppunitTest_sw_core_theme.mk sw/Module_sw.mk sw/qa sw/source writerfilter/source xmlo
editeng/source/items/textitem.cxx | 25 +++
include/editeng/colritem.hxx | 26 ---
include/editeng/unoprnms.hxx |2
sw/CppunitTest_sw_core_theme.mk | 62 ++
sw/Module_sw.mk |1
sw/qa/core/theme/ThemeTest.cxx| 35 ++
sw/qa/core/theme/data/ThemeColorInHeading.docx|binary
sw/source/core/unocore/unomap.cxx |4 -
sw/source/core/unocore/unomap1.cxx|6 +
sw/source/core/unocore/unomapproperties.hxx |6 +
sw/source/uibase/sidebar/ThemePanel.cxx | 29 ++--
sw/source/uibase/sidebar/WriterInspectorTextPanel.cxx | 14 ++--
writerfilter/source/dmapper/DomainMapper.cxx | 16
writerfilter/source/dmapper/PropertyIds.cxx |2
writerfilter/source/dmapper/PropertyIds.hxx |2
writerfilter/source/dmapper/TDefTableHandler.cxx | 44
writerfilter/source/dmapper/TDefTableHandler.hxx |1
xmloff/inc/XMLThemeColorHandler.hxx | 49 ++
xmloff/inc/enummaps.hxx |2
xmloff/source/draw/sdpropls.cxx |3
xmloff/source/text/txtprhdl.cxx |6 +
21 files changed, 281 insertions(+), 54 deletions(-)
New commits:
commit f627192b6055479a2ac2fecd6a8349c0fdc131fc
Author: Tomaž Vajngerl
AuthorDate: Mon Dec 5 13:59:22 2022 +0900
Commit: Tomaž Vajngerl
CommitDate: Fri Jan 20 07:11:05 2023 +
editeng: move "tint or shade" variable into SvxThemeColor
Change-Id: Ia2094854a8275082cf7444307e17fe5449c43b3a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143698
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
(cherry picked from commit 6fb682487e355933d79a8ef74560ecf318b4f705)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145834
Tested-by: Tomaž Vajngerl
diff --git a/editeng/source/items/textitem.cxx
b/editeng/source/items/textitem.cxx
index 147fa301d548..30b780f1b855 100644
--- a/editeng/source/items/textitem.cxx
+++ b/editeng/source/items/textitem.cxx
@@ -1354,9 +1354,10 @@ bool SvxContourItem::GetPresentation
}
SvxThemeColor::SvxThemeColor()
-: maThemeIndex(-1),
-mnLumMod(1),
-mnLumOff(0)
+: maThemeIndex(-1)
+, mnLumMod(1)
+, mnLumOff(0)
+, mnTintOrShade(0)
{
}
@@ -1364,7 +1365,8 @@ bool SvxThemeColor::operator==(const SvxThemeColor&
rThemeColor) const
{
return maThemeIndex == rThemeColor.maThemeIndex &&
mnLumMod == rThemeColor.mnLumMod &&
-mnLumOff == rThemeColor.mnLumOff;
+mnLumOff == rThemeColor.mnLumOff &&
+mnTintOrShade == rThemeColor.mnTintOrShade;
}
void SvxThemeColor::dumpAsXml(xmlTextWriterPtr pWriter) const
@@ -1377,6 +1379,8 @@ void SvxThemeColor::dumpAsXml(xmlTextWriterPtr pWriter)
const
BAD_CAST(OString::number(mnLumMod).getStr()));
(void)xmlTextWriterWriteAttribute(pWriter, BAD_CAST("lum-off"),
BAD_CAST(OString::number(mnLumOff).getStr()));
+(void)xmlTextWriterWriteAttribute(pWriter, BAD_CAST("tint-or-shade"),
+
BAD_CAST(OString::number(mnTintOrShade).getStr()));
(void)xmlTextWriterEndElement(pWriter);
}
@@ -1384,15 +1388,13 @@ void SvxThemeColor::dumpAsXml(xmlTextWriterPtr pWriter)
const
// class SvxColorItem
SvxColorItem::SvxColorItem( const sal_uInt16 nId ) :
SfxPoolItem(nId),
-mColor( COL_BLACK ),
-maTintShade(0)
+mColor( COL_BLACK )
{
}
SvxColorItem::SvxColorItem( const Color& rCol, const sal_uInt16 nId ) :
SfxPoolItem( nId ),
-mColor( rCol ),
-maTintShade(0)
+mColor( rCol )
{
}
@@ -1406,8 +1408,7 @@ bool SvxColorItem::operator==( const SfxPoolItem& rAttr )
const
const SvxColorItem& rColorItem = static_cast(rAttr);
return mColor == rColorItem.mColor &&
- maThemeColor == rColorItem.maThemeColor &&
- maTintShade == rColorItem.maTintShade;
+ maThemeColor == rColorItem.maThemeColor;
}
bool SvxColorItem::QueryValue( uno::Any& rVal, sal_uInt8 nMemberId ) const
@@ -1433,7 +1434,7 @@ bool SvxColorItem::QueryValue( uno::Any& rVal, sal_uInt8
nMemberId ) const
}
case MID_COLOR_TINT_OR_SHADE:
{
-rVal <<= maTintShade;
+rVal <<= maThemeColor.GetTintOrShade();
break;
}
case MID_COLOR_LUM_MOD:
@@ -1489,7 +1490,7 @@ bool SvxColorItem::PutValue( const uno::Any& rVal,
sal_uInt8 nMemberId )
sal_Int16 nTintShade = -1;
if (!(rVal >>= nTintShade))
return false;
-maTintShade = nTintShade;
+
[Libreoffice-bugs] [Bug 96527] FILEOPEN PPTX gradient and animation effects are not smooth
https://bugs.documentfoundation.org/show_bug.cgi?id=96527 Ari Latvala changed: What|Removed |Added Summary|FILEOPEN PPTX gradient |FILEOPEN PPTX gradient and |animation effect not smooth |animation effects are not ||smooth -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 96527] FILEOPEN PPTX gradient animation effect not smooth
https://bugs.documentfoundation.org/show_bug.cgi?id=96527 Ari Latvala changed: What|Removed |Added Summary|FILEOPEN PPTX gradient |FILEOPEN PPTX gradient |effect not smooth |animation effect not smooth --- Comment #13 from Ari Latvala --- Tested with the latest LO version. On slideshow animation is still not smooth like on MSO. Version: 7.4.4.2 (x64) / LibreOffice Community Build ID: 85569322deea74ec9134968a29af2df5663baa21 CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: fi-FI (fi_FI); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 96527] FILEOPEN PPTX gradient effect not smooth
https://bugs.documentfoundation.org/show_bug.cgi?id=96527 Ari Latvala changed: What|Removed |Added Summary|FILEOPEN PPTX gradient not |FILEOPEN PPTX gradient |smooth |effect not smooth -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: officecfg/registry sd/source sd/util solenv/bin
officecfg/registry/data/org/openoffice/Office/Impress.xcu |7 -
officecfg/registry/schema/org/openoffice/Office/Impress.xcs |9 --
sd/source/ui/framework/factories/PresentationFactory.cxx| 43 --
sd/source/ui/framework/module/ModuleController.cxx | 47 +---
sd/source/ui/inc/framework/ModuleController.hxx | 18
sd/source/ui/inc/framework/PresentationFactory.hxx |9 ++
sd/util/sd.component|4 -
solenv/bin/native-code.py |1
8 files changed, 21 insertions(+), 117 deletions(-)
New commits:
commit 4c06cfcd13195e9e996bc09dbee2dcac1c5e8ed2
Author: Noel Grandin
AuthorDate: Thu Jan 19 12:36:54 2023 +0200
Commit: Noel Grandin
CommitDate: Fri Jan 20 06:26:48 2023 +
[API CHANGE] no need to load PresentationFactoryProvider via UNO and/or
config
there is no benefit to having this constructed in such a convoluted
manner
Change-Id: Ib02b4bfe689326784bd8233003d10960700811d8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145778
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/officecfg/registry/data/org/openoffice/Office/Impress.xcu
b/officecfg/registry/data/org/openoffice/Office/Impress.xcu
index 112a89e8521f..37ebdf4d005f 100644
--- a/officecfg/registry/data/org/openoffice/Office/Impress.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/Impress.xcu
@@ -181,13 +181,6 @@
-
-
-
-
com.sun.star.drawing.framework.PresentationFactoryProvider
-
-
-
diff --git a/officecfg/registry/schema/org/openoffice/Office/Impress.xcs
b/officecfg/registry/schema/org/openoffice/Office/Impress.xcs
index fefd4ba2f6bf..e650c48e9766 100644
--- a/officecfg/registry/schema/org/openoffice/Office/Impress.xcs
+++ b/officecfg/registry/schema/org/openoffice/Office/Impress.xcs
@@ -1319,15 +1319,6 @@
Multi Pane Framework Resource Factories
-
-
-
- Set of services that are instantiated every time the
- framework of a Draw or Impress document is initialized.
-
-Multi Pane Framework Startup Services
-
-
diff --git a/sd/source/ui/framework/factories/PresentationFactory.cxx
b/sd/source/ui/framework/factories/PresentationFactory.cxx
index 73c2d4bdb732..6603f5db5159 100644
--- a/sd/source/ui/framework/factories/PresentationFactory.cxx
+++ b/sd/source/ui/framework/factories/PresentationFactory.cxx
@@ -39,20 +39,6 @@ namespace sd::framework {
namespace {
-typedef comphelper::WeakComponentImplHelper
PresentationFactoryProviderInterfaceBase;
-
-class PresentationFactoryProvider
-: public PresentationFactoryProviderInterfaceBase
-{
-public:
-PresentationFactoryProvider ();
-
-// XInitialization
-
-virtual void SAL_CALL initialize(
-const css::uno::Sequence& aArguments) override;
-};
-
typedef comphelper::WeakComponentImplHelper
PresentationViewInterfaceBase;
/** The PresentationView is not an actual view, it is a marker whose
@@ -143,32 +129,19 @@ void PresentationFactory::ThrowIfDisposed() const
}
}
-namespace {
-
//= PresentationFactoryProvider ===
-PresentationFactoryProvider::PresentationFactoryProvider ()
-{
-}
-
-// XInitialization
-
-void SAL_CALL PresentationFactoryProvider::initialize(
-const Sequence& aArguments)
+PresentationFactoryProvider::PresentationFactoryProvider (const
Reference& rxController)
{
-if (!aArguments.hasElements())
-return;
-
try
{
// Get the XController from the first argument.
-Reference xController (aArguments[0],
UNO_QUERY_THROW);
-Reference xCM (xController, UNO_QUERY_THROW);
+Reference xCM (rxController, UNO_QUERY_THROW);
Reference xCC
(xCM->getConfigurationController());
if (xCC.is())
xCC->addResourceFactory(
gsPresentationViewURL,
-new PresentationFactory(xController));
+new PresentationFactory(rxController));
}
catch (RuntimeException&)
{
@@ -176,17 +149,7 @@ void SAL_CALL PresentationFactoryProvider::initialize(
}
}
-} // end of anonymous namespace.
-
} // end of namespace sd::framework
-extern "C" SAL_DLLPUBLIC_EXPORT css::uno::XInterface*
-com_sun_star_comp_Draw_framework_PresentationFactoryProvider_get_implementation(css::uno::XComponentContext*,
-
css::uno::Sequence const &)
-{
-return cppu::acquire(new sd::framework::PresentationFactoryProvider);
-}
-
-
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sd/source/ui/framework/module/ModuleController.cxx
b/sd/source/ui/framework/module/ModuleController.cxx
Re: Mold linker and clang 15: /usr/bin/ld: cannot find -lLLVM-14: No such file or directory
On 19.1.2023 16.24, Christian Lohmaier wrote: On Thu, Jan 19, 2023 at 3:15 PM Ilmari Lauhakangas wrote: After upgrading from llvm 14 to 15 today, I got this: [GEN] compilerplugins/clang/sharedvisitor/analyzer /usr/bin/ld: cannot find -lLLVM-14: No such file or directory FYI: compilerplugins stuff doesn't get wiped with regular make clean, use make compilerplugins-clean or make distclean Indeed, make distclean helped, thanks. Ilmari
[Libreoffice-bugs] [Bug 149776] Web view skips fragments of text between pages
https://bugs.documentfoundation.org/show_bug.cgi?id=149776 --- Comment #12 from krumple_sodium --- I have not manually added any bars in my files. I have thousands of ODT files and they have all been created by me as I create documents on various subjects and as I keep adding more text to the ODT files. Eventually, every document gets bars in random places. The documents only create text, with arial font, size 10 or 22 and in some cases, they contain images. Is there any plan to solve this bug? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148653] Linux + LibreOffice Writer + render problem in View -> Web : horizontal grey bars
https://bugs.documentfoundation.org/show_bug.cgi?id=148653 --- Comment #11 from krumple_sodium --- I have not manually added any bars in my files. I have thousands of ODT files and they have all been created by me as I create documents on various subjects and as I keep adding more text to the ODT files. Eventually, every document gets bars in random places. The documents only create text, with arial font, size 10 or 22 and in some cases, they contain images. Is there any plan to solve this bug? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152888] parts of symbol bar vanish while editing
https://bugs.documentfoundation.org/show_bug.cgi?id=152888 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152889] View->Show Whitespace is reset after File->Print
https://bugs.documentfoundation.org/show_bug.cgi?id=152889 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142123] Charts/Graph in Calc don't allow full Text Formating of Legends and Axes Titles.
https://bugs.documentfoundation.org/show_bug.cgi?id=142123 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152887] Online/automatic accessibility check needs new icons for the status bar
https://bugs.documentfoundation.org/show_bug.cgi?id=152887 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152885] FILEOPEN RTF Page break and section break result in extra paragraph
https://bugs.documentfoundation.org/show_bug.cgi?id=152885 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152868] In Calc, a cell with a function returns a string to the active cell, but the string can not yet be pushed into a Designated Cell by a standard function. [1] Status "NEW
https://bugs.documentfoundation.org/show_bug.cgi?id=152868 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152882] Draw freezes after copying object into clipboard
https://bugs.documentfoundation.org/show_bug.cgi?id=152882 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152789] Please create a way to automatically add a word to exclusion list
https://bugs.documentfoundation.org/show_bug.cgi?id=152789 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152789] Please create a way to automatically add a word to exclusion list
https://bugs.documentfoundation.org/show_bug.cgi?id=152789 --- Comment #4 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152738] LO75RC1: Automatic spell-check on macOS not underlining misspelled words
https://bugs.documentfoundation.org/show_bug.cgi?id=152738 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152738] LO75RC1: Automatic spell-check on macOS not underlining misspelled words
https://bugs.documentfoundation.org/show_bug.cgi?id=152738 --- Comment #6 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150110] error in "
https://bugs.documentfoundation.org/show_bug.cgi?id=150110 --- Comment #3 from QA Administrators --- Dear fabio, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 96527] FILEOPEN PPTX gradient not smooth
https://bugs.documentfoundation.org/show_bug.cgi?id=96527 --- Comment #12 from QA Administrators --- Dear Ari Latvala, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150092] Calc crashes saving XCell spreadsheet
https://bugs.documentfoundation.org/show_bug.cgi?id=150092 --- Comment #8 from QA Administrators --- Dear Owen Savill, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 96492] Broken accessibility tree when objects are accessed via flows-to/flows-from relation
https://bugs.documentfoundation.org/show_bug.cgi?id=96492 --- Comment #9 from QA Administrators --- Dear Joanmarie Diggs, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 96487] Expose tracked changes to ATs via accessible objects and attributes
https://bugs.documentfoundation.org/show_bug.cgi?id=96487 --- Comment #7 from QA Administrators --- Dear Joanmarie Diggs, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 96490] Accessible object:children-changed events not emitted when paragraphs are created, destroyed, or exposed
https://bugs.documentfoundation.org/show_bug.cgi?id=96490 --- Comment #9 from QA Administrators --- Dear Joanmarie Diggs, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 96363] "Edit Document" button (shown on read only documents) is not tab focusable
https://bugs.documentfoundation.org/show_bug.cgi?id=96363 --- Comment #7 from QA Administrators --- Dear chry...@web.de, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 93828] Incorrect and duplicate accessibility events when Writer paragraphs become selected
https://bugs.documentfoundation.org/show_bug.cgi?id=93828 --- Comment #7 from QA Administrators --- Dear Joanmarie Diggs, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 66813] Tools / SQL dialog is modal
https://bugs.documentfoundation.org/show_bug.cgi?id=66813 --- Comment #17 from QA Administrators --- Dear Lionel Elie Mamane, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 77679] [ACCESSIBILITY] Accessibility support for replaced objects is incomplete
https://bugs.documentfoundation.org/show_bug.cgi?id=77679 --- Comment #14 from QA Administrators --- Dear Joanmarie Diggs, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 35110] A list box in writer document doesn't expose correct role to AT-SPI.
https://bugs.documentfoundation.org/show_bug.cgi?id=35110 --- Comment #12 from QA Administrators --- Dear Dattatray Bhat, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139631] Cut is cutting outside the selected range
https://bugs.documentfoundation.org/show_bug.cgi?id=139631 --- Comment #7 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 138708] Unwanted scrolling when moving/positioning an image with arrow keys
https://bugs.documentfoundation.org/show_bug.cgi?id=138708 --- Comment #3 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 135272] Tight integration dialog accessibility
https://bugs.documentfoundation.org/show_bug.cgi?id=135272 --- Comment #2 from QA Administrators --- Dear Heiko Tietze, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 123260] FILEOPEN: PPTX imported gradient fill wrong due to different fill algorithm
https://bugs.documentfoundation.org/show_bug.cgi?id=123260 --- Comment #4 from QA Administrators --- Dear Tobias Burnus, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 122399] File Locking (on by default) Cannot Be Turned Off in LibreOffice Versions 5 & 6 for Mac by modifying soffice file
https://bugs.documentfoundation.org/show_bug.cgi?id=122399 --- Comment #10 from QA Administrators --- Dear glen, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 122210] When using the Orca screen reader on the Toolbars, everything is announced as a scroll pane; probably incorrect accessibility attributes being passed to the accessibili
https://bugs.documentfoundation.org/show_bug.cgi?id=122210 --- Comment #6 from QA Administrators --- Dear am_dxer, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 122048] SQL TRIGGER does not properly display SQLSTATE message text in a Base form
https://bugs.documentfoundation.org/show_bug.cgi?id=122048 --- Comment #11 from QA Administrators --- Dear Russell Salerno, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118828] FILEOPEN: RTF: Incorrect row's height in table if there's a shape inside
https://bugs.documentfoundation.org/show_bug.cgi?id=118828 --- Comment #4 from QA Administrators --- Dear Xisco Faulí, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 115955] When using tab to navigate the Sidebar, Cell Style is updated without confirmation to screen reader.
https://bugs.documentfoundation.org/show_bug.cgi?id=115955 --- Comment #7 from QA Administrators --- Dear am_dxer, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108471] In a Form Table Control the Default time is not working in Date/Time (time) fields.
https://bugs.documentfoundation.org/show_bug.cgi?id=108471 --- Comment #14 from QA Administrators --- Dear Howard Johnson, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 105651] Find dialog not functioning correctly for screen reader users.
https://bugs.documentfoundation.org/show_bug.cgi?id=105651 --- Comment #12 from QA Administrators --- Dear am_dxer, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 106718] In read-only text documents, when selection cursor enabled, only arrows keys allow to navigate through documents
https://bugs.documentfoundation.org/show_bug.cgi?id=106718 --- Comment #9 from QA Administrators --- Dear Alex ARNAUD, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 104351] Accessible text-attributes-changed signals should not be emitted when starting new paragraph
https://bugs.documentfoundation.org/show_bug.cgi?id=104351 --- Comment #2 from QA Administrators --- Dear Aron Budea, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 105492] Sidebar tab bar buttons exposed to screen readers as radio buttons
https://bugs.documentfoundation.org/show_bug.cgi?id=105492 --- Comment #8 from QA Administrators --- Dear Yousuf Philips (jay) (retired), To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 102164] No assistive technology indication when jumping from header/footer back to main document area
https://bugs.documentfoundation.org/show_bug.cgi?id=102164 --- Comment #5 from QA Administrators --- Dear am_dxer, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 102172] Line numbers added via line numbering dialog not exposed to assistive technology
https://bugs.documentfoundation.org/show_bug.cgi?id=102172 --- Comment #4 from QA Administrators --- Dear am_dxer, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 102158] Accessible status not updated correctly for Recent Files and Templates Buttons in Start dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=102158 --- Comment #8 from QA Administrators --- Dear am_dxer, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 102140] Sidebar content panel title's "more options" button not accessible with shift tab
https://bugs.documentfoundation.org/show_bug.cgi?id=102140 --- Comment #8 from QA Administrators --- Dear Yousuf Philips (jay) (retired), To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 102145] Textboxes content not read by screen reader
https://bugs.documentfoundation.org/show_bug.cgi?id=102145 --- Comment #10 from QA Administrators --- Dear Yousuf Philips (jay) (retired), To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 102033] Sidebar's settings control exposed without a label
https://bugs.documentfoundation.org/show_bug.cgi?id=102033 --- Comment #7 from QA Administrators --- Dear Yousuf Philips (jay) (retired), To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - vcl/unx
vcl/unx/gtk3/gtkinst.cxx | 38 +++---
1 file changed, 19 insertions(+), 19 deletions(-)
New commits:
commit e49307d408fc95c280da729c6fdfc95d774c8837
Author: Caolán McNamara
AuthorDate: Thu Jan 19 16:31:03 2023 +
Commit: Adolfo Jayme Barrientos
CommitDate: Fri Jan 20 03:21:16 2023 +
Resolves: tdf#153091 support text/plain without encoding from nedit
Change-Id: I56dfc6dfec21b8c57b6f402c53b0229a2a2e7778
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145798
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos
diff --git a/vcl/unx/gtk3/gtkinst.cxx b/vcl/unx/gtk3/gtkinst.cxx
index 9a5be553501f..a072db8c5cc8 100644
--- a/vcl/unx/gtk3/gtkinst.cxx
+++ b/vcl/unx/gtk3/gtkinst.cxx
@@ -825,16 +825,12 @@ public:
virtual css::uno::Any SAL_CALL getTransferData(const
css::datatransfer::DataFlavor& rFlavor) override
{
+css::uno::Any aRet;
+
css::datatransfer::DataFlavor aFlavor(rFlavor);
if (aFlavor.MimeType == "text/plain;charset=utf-16")
aFlavor.MimeType = "text/plain;charset=utf-8";
-auto it = m_aMimeTypeToGtkType.find(aFlavor.MimeType);
-if (it == m_aMimeTypeToGtkType.end())
-return css::uno::Any();
-
-css::uno::Any aRet;
-
GdkClipboard* clipboard = clipboard_get(m_eSelection);
#if !GTK_CHECK_VERSION(4, 0, 0)
@@ -846,21 +842,25 @@ public:
aRet <<= aStr.replaceAll("\r\n", "\n");
return aRet;
}
-else
+#endif
+
+auto it = m_aMimeTypeToGtkType.find(aFlavor.MimeType);
+if (it == m_aMimeTypeToGtkType.end())
+return css::uno::Any();
+
+#if !GTK_CHECK_VERSION(4, 0, 0)
+GtkSelectionData* data = gtk_clipboard_wait_for_contents(clipboard,
+ it->second);
+if (!data)
{
-GtkSelectionData* data = gtk_clipboard_wait_for_contents(clipboard,
-
it->second);
-if (!data)
-{
-return css::uno::Any();
-}
-gint length;
-const guchar *rawdata =
gtk_selection_data_get_data_with_length(data,
-
);
-Sequence aSeq(reinterpret_cast(rawdata), length);
-gtk_selection_data_free(data);
-aRet <<= aSeq;
+return css::uno::Any();
}
+gint length;
+const guchar *rawdata = gtk_selection_data_get_data_with_length(data,
+
);
+Sequence aSeq(reinterpret_cast(rawdata),
length);
+gtk_selection_data_free(data);
+aRet <<= aSeq;
#else
SalInstance* pInstance = GetSalInstance();
read_transfer_result aRes;
[Libreoffice-commits] core.git: writerfilter/source
writerfilter/source/dmapper/DomainMapper_Impl.cxx | 31 --
1 file changed, 17 insertions(+), 14 deletions(-)
New commits:
commit d2cd7097ab8d8fe1a69b9f6e4a11c978b667951a
Author: Justin Luth
AuthorDate: Thu Jan 19 12:04:32 2023 -0500
Commit: Justin Luth
CommitDate: Fri Jan 20 03:06:17 2023 +
NFC writerfilter: avoid unnecessary code processing
Early return on useless parameter,
and conditional processing on missing ID.
Change-Id: Iecf2d7522bd0c1e958f826214368966399be311c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145831
Tested-by: Jenkins
Reviewed-by: Justin Luth
diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
index 48dfc3434ed4..0b73640fd57f 100644
--- a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
+++ b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
@@ -253,27 +253,30 @@ static FieldContextPtr GetParentFieldContext(const
std::deque&
/// Decides if the pInner field inside pOuter is allowed in Writer core,
depending on their type.
static bool IsFieldNestingAllowed(const FieldContextPtr& pOuter, const
FieldContextPtr& pInner)
{
-std::optional oOuterFieldId = pOuter->GetFieldId();
-OUString aCommand = pOuter->GetCommand();
-
-// Ignore leading space before the field name, but don't accept IFF when
we check for IF.
-if (!aCommand.isEmpty() && aCommand[0] == ' ')
-{
-aCommand = aCommand.subView(1);
-}
-
-if (!oOuterFieldId && aCommand.startsWith("IF "))
+if (!pInner->GetFieldId())
{
-// This will be FIELD_IF once the command is closed.
-oOuterFieldId = FIELD_IF;
+return true;
}
+std::optional oOuterFieldId = pOuter->GetFieldId();
if (!oOuterFieldId)
{
-return true;
+OUString aCommand = pOuter->GetCommand();
+
+// Ignore leading space before the field name, but don't accept IFF
when we check for IF.
+if (!aCommand.isEmpty() && aCommand[0] == ' ')
+{
+aCommand = aCommand.subView(1);
+}
+
+if (aCommand.startsWith("IF "))
+{
+// This will be FIELD_IF once the command is closed.
+oOuterFieldId = FIELD_IF;
+}
}
-if (!pInner->GetFieldId())
+if (!oOuterFieldId)
{
return true;
}
[Libreoffice-bugs] [Bug 149073] Provide indication when an OLE object is linked (e.g., in Properties dialog and/or Navigator or with border decoration)
https://bugs.documentfoundation.org/show_bug.cgi?id=149073 --- Comment #3 from Commit Notification --- Jim Raykowski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/1c638b7ac46d8077994c8483e6becc4a33efd12b tdf#149073 SwNavigator: provide an indication for linked images It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149073] Provide indication when an OLE object is linked (e.g., in Properties dialog and/or Navigator or with border decoration)
https://bugs.documentfoundation.org/show_bug.cgi?id=149073 Commit Notification changed: What|Removed |Added Whiteboard||target:7.6.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/inc sw/source
sw/inc/bitmaps.hlst|1
sw/source/uibase/inc/conttree.hxx |2
sw/source/uibase/utlui/content.cxx | 81 -
3 files changed, 39 insertions(+), 45 deletions(-)
New commits:
commit 1c638b7ac46d8077994c8483e6becc4a33efd12b
Author: Jim Raykowski
AuthorDate: Sat Jan 14 22:45:18 2023 -0900
Commit: Jim Raykowski
CommitDate: Fri Jan 20 01:10:19 2023 +
tdf#149073 SwNavigator: provide an indication for linked images
Sets an image for image content entries that are of linked type
Function 'InsertContent' added to replace duplicated code that
inserts content.
Change-Id: I25dec3f5765fa3dffe505743cd9c5fe044349ab0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145530
Tested-by: Jenkins
Reviewed-by: Jim Raykowski
diff --git a/sw/inc/bitmaps.hlst b/sw/inc/bitmaps.hlst
index 647d2fb2f073..9606076d3032 100644
--- a/sw/inc/bitmaps.hlst
+++ b/sw/inc/bitmaps.hlst
@@ -81,6 +81,7 @@ inline constexpr OUStringLiteral RID_BMP_NAVI_OUTLINE =
u"sw/res/nc2.png";
inline constexpr OUStringLiteral RID_BMP_NAVI_TABLE = u"sw/res/nc20001.png";
inline constexpr OUStringLiteral RID_BMP_NAVI_FRAME = u"sw/res/nc20002.png";
inline constexpr OUStringLiteral RID_BMP_NAVI_GRAPHIC = u"sw/res/nc20003.png";
+inline constexpr OUStringLiteral RID_BMP_NAVI_GRAPHIC_LINK =
u"sw/res/nc20007.png";
inline constexpr OUStringLiteral RID_BMP_NAVI_OLE = u"sw/res/nc20004.png";
inline constexpr OUStringLiteral RID_BMP_NAVI_BOOKMARK = u"sw/res/nc20005.png";
inline constexpr OUStringLiteral RID_BMP_NAVI_REGION = u"sw/res/nc20006.png";
diff --git a/sw/source/uibase/inc/conttree.hxx
b/sw/source/uibase/inc/conttree.hxx
index b4f352bb6950..c924241d0153 100644
--- a/sw/source/uibase/inc/conttree.hxx
+++ b/sw/source/uibase/inc/conttree.hxx
@@ -155,6 +155,8 @@ class SwContentTree final : public SfxListener
*/
voidFindActiveTypeAndRemoveUserData();
+void InsertContent(const weld::TreeIter& rParent);
+
void insert(const weld::TreeIter* pParent, const OUString& rStr, const
OUString& rId,
bool bChildrenOnDemand, weld::TreeIter* pRet);
diff --git a/sw/source/uibase/utlui/content.cxx
b/sw/source/uibase/utlui/content.cxx
index d76b1103991e..1148689ce9d9 100644
--- a/sw/source/uibase/utlui/content.cxx
+++ b/sw/source/uibase/utlui/content.cxx
@@ -2063,6 +2063,34 @@ IMPL_LINK(SwContentTree, CommandHdl, const
CommandEvent&, rCEvt, bool)
return true;
}
+void SwContentTree::InsertContent(const weld::TreeIter& rParent)
+{
+
assert(dynamic_cast(weld::fromId(m_xTreeView->get_id(rParent;
+SwContentType* pCntType =
weld::fromId(m_xTreeView->get_id(rParent));
+bool bGraphic = pCntType->GetType() == ContentTypeId::GRAPHIC;
+bool bRegion = pCntType->GetType() == ContentTypeId::REGION;
+std::unique_ptr xChild = m_xTreeView->make_iterator();
+const size_t nCount = pCntType->GetMemberCount();
+for(size_t i = 0; i < nCount; ++i)
+{
+const SwContent* pCnt = pCntType->GetMember(i);
+if (pCnt)
+{
+OUString sEntry = pCnt->GetName();
+if (sEntry.isEmpty())
+sEntry = m_sSpace;
+OUString sId(weld::toId(pCnt));
+insert(, sEntry, sId, false, xChild.get());
+m_xTreeView->set_sensitive(*xChild, !pCnt->IsInvisible());
+if (bGraphic && !static_cast(pCnt)->GetLink().isEmpty())
+m_xTreeView->set_image(*xChild, RID_BMP_NAVI_GRAPHIC_LINK);
+else if (bRegion)
+m_xTreeView->set_extra_row_indent(*xChild,
+static_cast(pCnt)->GetRegionLevel());
+}
+}
+}
+
void SwContentTree::insert(const weld::TreeIter* pParent, const OUString&
rStr, const OUString& rId,
bool bChildrenOnDemand, weld::TreeIter* pRet)
{
@@ -2085,9 +2113,9 @@ void SwContentTree::remove(const weld::TreeIter& rIter)
// Content will be integrated into the Box only on demand.
bool SwContentTree::RequestingChildren(const weld::TreeIter& rParent)
{
-bool bChild = m_xTreeView->iter_has_child(rParent);
-if (bChild || !m_xTreeView->get_children_on_demand(rParent))
-return bChild;
+// Does the parent already have children or is it not a 'children on
demand' node?
+if (m_xTreeView->iter_has_child(rParent) ||
!m_xTreeView->get_children_on_demand(rParent))
+return false;
// Is this a content type?
if (lcl_IsContentType(rParent, *m_xTreeView))
@@ -2134,34 +2162,16 @@ bool SwContentTree::RequestingChildren(const
weld::TreeIter& rParent)
// add this node as a parent candidate for any following
nodes at a higher outline level
aParentCandidates.emplace_back(m_xTreeView->make_iterator(xChild.get()));
-
-bChild = true;
}
}
}
else
-
[Libreoffice-bugs] [Bug 146579] (Enhancement) Show the current View Layout option in the status bar, without relying on color.
https://bugs.documentfoundation.org/show_bug.cgi?id=146579 Jim Raykowski changed: What|Removed |Added CC||rayk...@gmail.com --- Comment #8 from Jim Raykowski --- This can be done programmatically without need to modify the existing images used to indicate active view mode (emptypage_a_10x14.png, twopages_a_10x24.png, and doublepage_a_10x22.png) Code pointers: Images for SwViewLayoutControl are drawn in: void SwViewLayoutControl::Paint sw/source/uibase/utlui/viewlayoutctrl.cxx A rectangle of chosen color can be drawn around the active image using OutputDevice::DrawRect. Optionally, OutputDevice::DrawBorder can be used but the line color can not be changed, it is set in the function as light grey and grey to, I suppose, provide a border effect. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 113200] [META] DOC (binary) field bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=113200 Bug 113200 depends on bug 141649, which changed state. Bug 141649 Summary: FILEOPEN: DOC: Incorrect conditional field https://bugs.documentfoundation.org/show_bug.cgi?id=141649 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/qa sw/source
sw/qa/extras/ooxmlexport/ooxmlfieldexport.cxx |4 +++-
sw/qa/extras/ww8export/data/tdf141649_conditionalText.doc |binary
sw/qa/extras/ww8export/ww8export4.cxx |9 +
sw/source/filter/ww8/ww8par5.cxx | 10 ++
4 files changed, 22 insertions(+), 1 deletion(-)
New commits:
commit 85ae3d1513d4be3eb102bf3065ddfba27cb1f1c3
Author: Justin Luth
AuthorDate: Wed Jan 18 14:32:21 2023 -0500
Commit: Justin Luth
CommitDate: Thu Jan 19 23:57:28 2023 +
tdf#141649 doc import: do not duplicate conditional text
This patch is a mixed blessing.
It will be a regression if an IF FIELD was bogus,
and the user only wanted to see the modified, unrefreshed text.
That is because in MS Word, most fields do not update automatically,
but require the user to press F9 to refresh the contents.
The contents are also editable, so the result might not match
either the true or false result-string.
However, in LO the IF FIELD is always refreshed, and thus will
never display any bogus hand-modifications.
The import of these IF fields started in DOC in LO 6.1,
but it was never correct and immediately duplicated content.
Additionally, DOC format didn't export at all, so anything
to do with IF FIELDS was lost - meaning that after a round-trip
the result was the same as what MS Word last saw with the field gone.
So in the eyes of the user, the fixing of import and export
might be causing a regression of changed text.
So be it.
I can only assume that in most cases the use of an IF FIELD
is intentional and that it would be desirsable to have it working.
Change-Id: If90f6f4cddcefebf379352aac6519595c1bf2b23
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145821
Tested-by: Jenkins
Reviewed-by: Justin Luth
diff --git a/sw/qa/extras/ooxmlexport/ooxmlfieldexport.cxx
b/sw/qa/extras/ooxmlexport/ooxmlfieldexport.cxx
index d20cf2338a07..11ddc54f1717 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlfieldexport.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlfieldexport.cxx
@@ -824,7 +824,9 @@ CPPUNIT_TEST_FIXTURE(Test, testConditionalText2)
// Load a document which has a conditional text field in it.
xmlDocUniquePtr pXmlDoc = parseExport("word/document.xml");
std::u16string_view aExpected(u" IF 1 = 1 \"test1\" \"test2\"");
-assertXPathContent(pXmlDoc, "/w:document/w:body/w:p/w:r[3]/w:instrText",
OUString(aExpected));
+assertXPathContent(pXmlDoc, "/w:document/w:body/w:p/w:r[2]/w:instrText",
OUString(aExpected));
+
+getParagraph(1, "test1");
}
DECLARE_OOXMLEXPORT_TEST(testTdf142464_ampm, "tdf142464_ampm.docx")
diff --git a/sw/qa/extras/ww8export/data/tdf141649_conditionalText.doc
b/sw/qa/extras/ww8export/data/tdf141649_conditionalText.doc
new file mode 100644
index ..9e4ec49e38a6
Binary files /dev/null and
b/sw/qa/extras/ww8export/data/tdf141649_conditionalText.doc differ
diff --git a/sw/qa/extras/ww8export/ww8export4.cxx
b/sw/qa/extras/ww8export/ww8export4.cxx
index 1910178d0ac8..6889b587ac6a 100644
--- a/sw/qa/extras/ww8export/ww8export4.cxx
+++ b/sw/qa/extras/ww8export/ww8export4.cxx
@@ -78,6 +78,15 @@ DECLARE_WW8EXPORT_TEST(testTdf151548_formFieldMacros,
"tdf151548_formFieldMacros
}
}
+DECLARE_WW8EXPORT_TEST(testTdf141649_conditionalText,
"tdf141649_conditionalText.doc")
+{
+// In MS Word, the IF field is editable and requires manual update, so the
most correct
+// result is "manual refresh with F9" inside a text field,
+// but for our purposes, a single instance of "trueResult" is appropriate.
+getParagraph(1, "trueResult");
+}
+
+
CPPUNIT_PLUGIN_IMPLEMENT();
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/filter/ww8/ww8par5.cxx b/sw/source/filter/ww8/ww8par5.cxx
index 35cb2b507369..ddaad0e3f741 100644
--- a/sw/source/filter/ww8/ww8par5.cxx
+++ b/sw/source/filter/ww8/ww8par5.cxx
@@ -1026,6 +1026,16 @@ tools::Long
SwWW8ImplReader::Read_Field(WW8PLCFManResult* pRes)
m_bEmbeddObj = true;
// Field not supported: store the field code for later use
m_aFieldStack.back().SetBookmarkCode( aStr );
+
+if (aF.nId == ww::eIF)
+{
+// In MS Word, the IF field is editable and requires a manual
refresh
+// so the last, saved result might not match either of the
true or false options.
+// But in LO the field is automatically updated and not
editable,
+// so the previous result is of no value to import since it
could never be seen.
+return aF.nLen;
+}
+
return aF.nLen - aF.nLRes - 1; // skipped too many, the resulted
field will be read like main text
}
}
[Libreoffice-bugs] [Bug 106858] Slide / Page background image size needs a "keep ratio" option like images do ( steps in comment 2 )
https://bugs.documentfoundation.org/show_bug.cgi?id=106858 Stéphane Guillou (stragu) changed: What|Removed |Added Summary|Slide background image size |Slide / Page background |needs a "keep proportions" |image size needs a "keep |option ( steps in comment 2 |ratio" option like images |) |do ( steps in comment 2 ) CC||stephane.guillou@libreoffic ||e.org -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 106858] Slide background image size needs a "keep proportions" option ( steps in comment 2 )
https://bugs.documentfoundation.org/show_bug.cgi?id=106858 Stéphane Guillou (stragu) changed: What|Removed |Added CC||jakob_krue...@gmx.net --- Comment #6 from Stéphane Guillou (stragu) --- *** Bug 138119 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 113224] [META] Image fill issues of the Area fill tab
https://bugs.documentfoundation.org/show_bug.cgi?id=113224 Bug 113224 depends on bug 138119, which changed state. Bug 138119 Summary: Add option for preserving aspect ratio of an Area Image fill https://bugs.documentfoundation.org/show_bug.cgi?id=138119 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 138119] Add option for preserving aspect ratio of an Area Image fill
https://bugs.documentfoundation.org/show_bug.cgi?id=138119 Stéphane Guillou (stragu) changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED CC||stephane.guillou@libreoffic ||e.org --- Comment #3 from Stéphane Guillou (stragu) --- *** This bug has been marked as a duplicate of bug 106858 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 130543] Impress doesn't show existing background image in Slide Setup nor in Sidebar (Comment 5)
https://bugs.documentfoundation.org/show_bug.cgi?id=130543 Stéphane Guillou (stragu) changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=10 ||0832 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 100832] Custom bitmap fill doesnt appear in Area dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=100832 Stéphane Guillou (stragu) changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||0543 --- Comment #10 from Stéphane Guillou (stragu) --- Same in: Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 579d144290c1617fdb38d09b30900a6bbe390b8d CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: fr-FR (en_AU.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 114609] pptx: textbox shape line around slightly visible if white on white background
https://bugs.documentfoundation.org/show_bug.cgi?id=114609 --- Comment #15 from nicholasj...@mailfence.com --- In Impress 7.4, on Linux, and with imported PowerPoint files, occasionally _graphics_ - perhaps only _rotated_ graphics? - show a white border on a _dark_ background. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 132049] DOCX: Bitmap area size modifications of a shape not saved
https://bugs.documentfoundation.org/show_bug.cgi?id=132049 Stéphane Guillou (stragu) changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||3105 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 113224] [META] Image fill issues of the Area fill tab
https://bugs.documentfoundation.org/show_bug.cgi?id=113224 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||153105 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=153105 [Bug 153105] After saving the background style, the custom size will change. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152960] Filesave: "Keep with next paragraph" not working on sections to follow
https://bugs.documentfoundation.org/show_bug.cgi?id=152960 --- Comment #5 from Stéphane Guillou (stragu) --- (In reply to Michael Stahl (allotropia) from comment #4) > doesn't look like a regression. > > i've tried to revert that commit - no difference. > > i've tried loading the attached bugdoc on builds from every bibisect repo > from 7.4 to 5.3 on Linux - not a single one respected the "keep-with-next". > > OOo 3.3 also displays it that way. > > => clearing regression keywords Michael, I agree that all versions will probably display the same, because the issue is a filesave issue and the example document was saved with a version that has the bug. To test, you will have to follow the steps in comment 2. Could you please have another look at the effect of reverting the commit, following the steps? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 116902] The aspect ratio isn't honored when using an external image area bitmap fill
https://bugs.documentfoundation.org/show_bug.cgi?id=116902 Stéphane Guillou (stragu) changed: What|Removed |Added CC||stephane.guillou@libreoffic ||e.org --- Comment #4 from Stéphane Guillou (stragu) --- It's as if the scale setting uses percentages of the width and height _of the page_ rather than of the original size of the picture, as documented[1]: "Scale: Mark to turn the height and width settings relative to original size." Default values are both 100%, so the image should have its original aspect ratio. [1]: https://help.libreoffice.org/7.6/en-US/text/shared/01/05210500.html Reproduced in: Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 579d144290c1617fdb38d09b30900a6bbe390b8d CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: fr-FR (en_AU.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/qa
sw/qa/uitest/writer_tests7/tdf135938.py | 25 +++--
1 file changed, 15 insertions(+), 10 deletions(-)
New commits:
commit a29ec09f7c2a01f131095fd9b2ecafa0812e8325
Author: Andreas Heinisch
AuthorDate: Thu Jan 19 15:57:27 2023 +0100
Commit: Andreas Heinisch
CommitDate: Thu Jan 19 22:57:59 2023 +
tdf#135938 - Search for "insert reference" tree entry
Instead of assuming that the "insert reference" entry is always the second
item of the menu tree, search for the correct child in the tree list. This
commit addresses the failing build from
https://gerrit.libreoffice.org/c/core/+/140985.
Change-Id: I6f0d7021ab6f632784cab85656823c69f90baf60
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145816
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch
diff --git a/sw/qa/uitest/writer_tests7/tdf135938.py
b/sw/qa/uitest/writer_tests7/tdf135938.py
index 013da93624da..00a72bec26ff 100755
--- a/sw/qa/uitest/writer_tests7/tdf135938.py
+++ b/sw/qa/uitest/writer_tests7/tdf135938.py
@@ -31,16 +31,21 @@ class tdf135938(UITestCase):
xName.executeAction("TYPE", mkPropertyValues({"TEXT": "DEF"}))
xInsert.executeAction("CLICK", tuple())
-# Select insert reference type
-xTreeEntry = xTreelistType.getChild('1')
-self.assertEqual(get_state_as_dict(xTreeEntry)["Text"],
"Insert Reference")
-xTreeEntry.executeAction("SELECT", tuple())
+# Search for insert reference type
+xFilter = None
+for childIx in range(len(xTreelistType.getChildren())):
+xTreeEntry = xTreelistType.getChild(childIx)
+if get_state_as_dict(xTreeEntry)["Text"] == "Insert
Reference":
+xTreeEntry.executeAction("SELECT", tuple())
+# Filter the cross references
+xFilter = xDialog.getChild("filter")
+xFilter.executeAction("TYPE",
mkPropertyValues({"TEXT": "A"}))
+# Without the fix in place, this test would have
failed with
+# AssertionError: 'ABC' != 'DEF', i.e., the text of
the name field did not change
+self.assertEqual(get_state_as_dict(xName)["Text"],
"ABC")
+break
-# Filter the cross references
-xFilter = xDialog.getChild("filter")
-xFilter.executeAction("TYPE", mkPropertyValues({"TEXT": "A"}))
-# Without the fix in place, this test would have failed with
-# AssertionError: 'ABC' != 'DEF', i.e., the text of the name
field did not change
-self.assertEqual(get_state_as_dict(xName)["Text"], "ABC")
+# Check if insert reference entry was found
+self.assertFalse(xFilter is None)
# vim: set shiftwidth=4 softtabstop=4 expandtab:
[Libreoffice-bugs] [Bug 94714] Bitmaps and patterns are applied at a larger size
https://bugs.documentfoundation.org/show_bug.cgi?id=94714 Stéphane Guillou (stragu) changed: What|Removed |Added CC||stephane.guillou@libreoffic ||e.org --- Comment #23 from Stéphane Guillou (stragu) --- Created attachment 184789 --> https://bugs.documentfoundation.org/attachment.cgi?id=184789=edit example ODT with 3 shapes filled with 3 tiled bitmaps Note that the preview does not change depending on the zoom level, so for a fair comparison, make sure the zoom level is at 100%. The attachment uses three example bitmaps that make it easy to compare preview and "reality". Reproduced in: Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 579d144290c1617fdb38d09b30900a6bbe390b8d CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: fr-FR (en_AU.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153115] Deleted tracked information re-inserted after undo of text to table
https://bugs.documentfoundation.org/show_bug.cgi?id=153115 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||3119 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153119] Crash on paste
https://bugs.documentfoundation.org/show_bug.cgi?id=153119 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||3115 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153119] Crash on paste
https://bugs.documentfoundation.org/show_bug.cgi?id=153119 Telesto changed: What|Removed |Added CC||serval2...@yahoo.fr Keywords||wantBacktrace -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153119] Crash on paste
https://bugs.documentfoundation.org/show_bug.cgi?id=153119 m.a.riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #2 from m.a.riosv --- Repro Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: fc441f3886330c4ae2abeb67c0758b935ba23f47 CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL threaded Jumbo -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 135832] UI: Configuring a bitmap to show on full page with custom position and size not easy to do/ user friendly
https://bugs.documentfoundation.org/show_bug.cgi?id=135832 Stéphane Guillou (stragu) changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 CC||stephane.guillou@libreoffic ||e.org --- Comment #5 from Stéphane Guillou (stragu) --- Telesto, isn't what you want to do simply about changing from "Custom position/size" to "Stretched"? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153119] Crash on paste
https://bugs.documentfoundation.org/show_bug.cgi?id=153119 --- Comment #1 from Telesto --- Created attachment 184788 --> https://bugs.documentfoundation.org/attachment.cgi?id=184788=edit Sample -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153119] New: Crash on paste
https://bugs.documentfoundation.org/show_bug.cgi?id=153119 Bug ID: 153119 Summary: Crash on paste Product: LibreOffice Version: 7.6.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: Crash on paste Steps to Reproduce: 1. Open the attached file (based attachment 178841 bug 147938 2. Select the table on the last page with "Crash" written in it 3. Select the table 4. Table -> Convert -> table to text -> OK (with default settings) 5. CTRL+Z 6. CTRL+C 7. CTRL+V Actual Results: Crash Expected Results: No crash Reproducible: Always User Profile Reset: No Additional Info: Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 37e3455a13ab5741104bf41d05a80e60a4612682 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
