[Libreoffice-bugs] [Bug 114039] [META] Field dialog bugs and enhancements

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=114039
Bug 114039 depends on bug 153089, which changed state.

Bug 153089 Summary: Allow separator (for Numbering by Chapter) to be greater 
than one character in the Edit Fields dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=153089

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |NOTABUG

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153089] Allow separator (for Numbering by Chapter) to be greater than one character in the Edit Fields dialog

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153089

Heiko Tietze  changed:

   What|Removed |Added

 Resolution|--- |NOTABUG
 Status|UNCONFIRMED |RESOLVED
 CC||stephane.guillou@libreoffic
   ||e.org,
   ||vmik...@collabora.com

--- Comment #7 from Heiko Tietze  ---
Using some other character than the fix list offered in MSO works and "1~a" is
shown if the document is loaded in MSO. But the separator is updated to "1-1"
with the next inserted caption / when fields are updated.

I spotted an issue when loading a DOCX: it shows the numbering as None, though
the field says "1.1", and I can create something like "1.1.1" (the first number
wont update). Different topic, maybe reported somewhere else.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 153089] Allow separator (for Numbering by Chapter) to be greater than one character in the Edit Fields dialog

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153089

Heiko Tietze  changed:

   What|Removed |Added

 Resolution|--- |NOTABUG
 Status|UNCONFIRMED |RESOLVED
 CC||stephane.guillou@libreoffic
   ||e.org,
   ||vmik...@collabora.com

--- Comment #7 from Heiko Tietze  ---
Using some other character than the fix list offered in MSO works and "1~a" is
shown if the document is loaded in MSO. But the separator is updated to "1-1"
with the next inserted caption / when fields are updated.

I spotted an issue when loading a DOCX: it shows the numbering as None, though
the field says "1.1", and I can create something like "1.1.1" (the first number
wont update). Different topic, maybe reported somewhere else.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-ux-advise] [Bug 153089] Allow separator (for Numbering by Chapter) to be greater than one character in the Edit Fields dialog

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153089

--- Comment #6 from Heiko Tietze  ---
Created attachment 184861
  --> https://bugs.documentfoundation.org/attachment.cgi?id=184861=edit
Numbering in MSO

MSO provides a list of fix separators, hyphen, full stop, color, em- and
en-dash. Resolving WF.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 153089] Allow separator (for Numbering by Chapter) to be greater than one character in the Edit Fields dialog

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153089

--- Comment #6 from Heiko Tietze  ---
Created attachment 184861
  --> https://bugs.documentfoundation.org/attachment.cgi?id=184861=edit
Numbering in MSO

MSO provides a list of fix separators, hyphen, full stop, color, em- and
en-dash. Resolving WF.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - sw/qa writerfilter/source

2023-01-23 Thread Justin Luth (via logerrit)
 sw/qa/extras/ooxmlexport/data/tdf125038_conditionalText3.docx |binary
 sw/qa/extras/ooxmlexport/ooxmlfieldexport.cxx |   10 +++
 writerfilter/source/dmapper/DomainMapper_Impl.cxx |   32 +-
 3 files changed, 28 insertions(+), 14 deletions(-)

New commits:
commit 002f0ea6e9fda83977876c5fbe01327e5c8690ca
Author: Justin Luth 
AuthorDate: Thu Jan 19 12:04:32 2023 -0500
Commit: Miklos Vajna 
CommitDate: Tue Jan 24 07:29:55 2023 +

related tdf#125038 FORMTEXT/REF:fix spurious text outside IF field

squashed commit, including d2cd7097ab8d8fe1a69b9f6e4a11c978b667951a
NFC writerfilter: avoid unnecessary code processing
which reformats this section of the code.

This builds on top of commit d09336fbdceaafd9320466b660a2b32a07dcc16a
(tdf#125038 DOCX import: fix lost MERGEFIELD result inside an IF field,
2019-10-31), and extends it for FORMTEXT and REF.

With this, all unexpected content is gone from the paragraph.

Actually this is all somewhat irrelevant since DOCX doesn't import
IF fields at all anyway - they are just left blank.
So AFAICS, we should ALWAYS return false at this point.

I also took the opportunity to be able to remove multiple
spaces from the front of the command.

Change-Id: Ib7e7971bce86bdda545166e398fbb620ca515b91
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145832
Tested-by: Jenkins
Reviewed-by: Justin Luth 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145956
Reviewed-by: Miklos Vajna 
Tested-by: Miklos Vajna 

diff --git a/sw/qa/extras/ooxmlexport/data/tdf125038_conditionalText3.docx 
b/sw/qa/extras/ooxmlexport/data/tdf125038_conditionalText3.docx
new file mode 100644
index ..ec5698eeae1c
Binary files /dev/null and 
b/sw/qa/extras/ooxmlexport/data/tdf125038_conditionalText3.docx differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlfieldexport.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlfieldexport.cxx
index 96ba5e5a83e1..2210231b661b 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlfieldexport.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlfieldexport.cxx
@@ -818,6 +818,16 @@ CPPUNIT_TEST_FIXTURE(Test, testConditionalText)
 assertXPathContent(pXmlDoc, "/w:document/w:body/w:p/w:r[2]/w:instrText", 
OUString(aExpected));
 }
 
+CPPUNIT_TEST_FIXTURE(Test, testConditionalText3)
+{
+loadAndReload("tdf125038_conditionalText3.docx");
+// It is unclear what the purpose of all the conditional IF statements is,
+// but the end result should not produce any output.
+// Previously, the fields were being displayed as text
+// instead of as building blocks for the IF field condition.
+CPPUNIT_ASSERT_EQUAL(sal_Int32(-1), 
getParagraph(1)->getString().indexOf('2'));
+}
+
 DECLARE_OOXMLEXPORT_TEST(testTdf142464_ampm, "tdf142464_ampm.docx")
 {
 css::uno::Reference xTextFieldsSupplier(
diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.cxx 
b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
index b3695ab68862..79de1985efea 100644
--- a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
+++ b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
@@ -253,27 +253,28 @@ static FieldContextPtr GetParentFieldContext(const 
std::deque&
 /// Decides if the pInner field inside pOuter is allowed in Writer core, 
depending on their type.
 static bool IsFieldNestingAllowed(const FieldContextPtr& pOuter, const 
FieldContextPtr& pInner)
 {
-std::optional oOuterFieldId = pOuter->GetFieldId();
-OUString aCommand = pOuter->GetCommand();
-
-// Ignore leading space before the field name, but don't accept IFF when 
we check for IF.
-if (!aCommand.isEmpty() && aCommand[0] == ' ')
-{
-aCommand = aCommand.subView(1);
-}
-
-if (!oOuterFieldId && aCommand.startsWith("IF "))
+if (!pInner->GetFieldId())
 {
-// This will be FIELD_IF once the command is closed.
-oOuterFieldId = FIELD_IF;
+return true;
 }
 
+std::optional oOuterFieldId = pOuter->GetFieldId();
 if (!oOuterFieldId)
 {
-return true;
+OUString aCommand = pOuter->GetCommand();
+
+// Ignore leading space before the field name, but don't accept IFF 
when we check for IF.
+while (aCommand.getLength() > 3 && aCommand[0] == ' ')
+aCommand = aCommand.subView(1);
+
+if (aCommand.startsWith("IF "))
+{
+// This will be FIELD_IF once the command is closed.
+oOuterFieldId = FIELD_IF;
+}
 }
 
-if (!pInner->GetFieldId())
+if (!oOuterFieldId)
 {
 return true;
 }
@@ -285,10 +286,13 @@ static bool IsFieldNestingAllowed(const FieldContextPtr& 
pOuter, const FieldCont
 switch (*pInner->GetFieldId())
 {
 case FIELD_DOCVARIABLE:
+case FIELD_FORMTEXT:
 case FIELD_FORMULA:
 case FIELD_IF:
 case 

[Libreoffice-bugs] [Bug 153146] Add "Chapter Numbering" Dropdown Language Labels

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153146

--- Comment #2 from Shantanu  ---
And the chapter numbering should also be available in words like: 

एक, दोन, तीन (marathi)

The source code for this is already built-in.

https://github.com/Numbertext/libnumbertext/blob/master/data/mr.sor

The numbering is visible once 'Complex text layout' option is enabled from
Tools - Options - Language Settings - Languages.  

Version: 7.4.3.2 (x64) / LibreOffice Community
Build ID: 1048a8393ae2eeec98dff31b5c133c5f1d08b890
CPU threads: 1; OS: Windows 10.0 Build 14393; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143000] [META] Tracked Changes of images

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143000
Bug 143000 depends on bug 150806, which changed state.

Bug 150806 Summary: FILESAVE: Image duplicates / aspect ratio changes after ODT 
save (track changes involved)
https://bugs.documentfoundation.org/show_bug.cgi?id=150806

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: xmloff/qa xmloff/source

2023-01-23 Thread Miklos Vajna (via logerrit)
 xmloff/qa/unit/data/scale-width-redline.fodt |  170 +++
 xmloff/qa/unit/text.cxx  |   21 +++
 xmloff/source/text/txtparae.cxx  |5 
 3 files changed, 196 insertions(+)

New commits:
commit 713493c107e6a210ef9b87d033efd0614271483a
Author: Miklos Vajna 
AuthorDate: Mon Jan 23 20:10:30 2023 +0100
Commit: Miklos Vajna 
CommitDate: Tue Jan 24 07:12:08 2023 +

tdf#150806 ODT export: fix fallback svg:width/height for zero layout size

The reported problem was that once tracked changes is enabled and an
image is deleted, its aspect ratio changes on save.

What happens here is that the image's frame is marked as a redline
deletion, so when the ODT export writes the file, it'll have a zero
size. But this zero size is nothing we should take into account on save,
XMLTextParagraphExport::addTextFrameAttributes() expected to always have
a valid layout size if the LayoutSize property is available.

Fix the problem by adding one more condition where we ignore the layout
size, which was already there since commit
80550ade305b9e68c6281a258d162bc2c413713a (tdf#150990 ODT export: fix
zero layout size of scale/scale images, 2022-09-20).

Note that this way the written side will be the original one, so only
the aspect ratio will be correct, but that was accepted as a compromise
earlier.

Change-Id: I108dc2428ce0cb07a044bfef216575fdba19267b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146043
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/xmloff/qa/unit/data/scale-width-redline.fodt 
b/xmloff/qa/unit/data/scale-width-redline.fodt
new file mode 100644
index ..6b98c6e27a34
--- /dev/null
+++ b/xmloff/qa/unit/data/scale-width-redline.fodt
@@ -0,0 +1,170 @@
+
+http://www.w3.org/TR/css3-text/; 
xmlns:grddl="http://www.w3.org/2003/g/data-view#; 
xmlns:xhtml="http://www.w3.org/1999/xhtml; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xmlns:xsd="http://www.w3.org/2001/XMLSchema; 
xmlns:xforms="http://www.w3.org/2002/xforms; 
xmlns:dom="http://www.w3.org/2001/xml-events; 
xmlns:script="urn:oasis:names:tc:opendocument:xmlns:script:1.0" 
xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0" 
xmlns:math="http://www.w3.org/1998/Math/MathML; 
xmlns:office="urn:oasis:names:tc:opendocument:xmlns:office:1.0" 
xmlns:ooo="http://openoffice.org/2004/office; 
xmlns:fo="urn:oasis:names:tc:opendocument:xmlns:xsl-fo-compatible:1.0" 
xmlns:config="urn:oasis:names:tc:opendocument:xmlns:config:1.0" 
xmlns:ooow="http://openoffice.org/2004/writer; 
xmlns:xlink="http://www.w3.org/1999/xlink; 
xmlns:drawooo="http://openoffice.org/2010/draw; 
xmlns:oooc="http://openoffice.org/2004/calc; 
xmlns:dc="http://purl.org/dc/elements/1.1/; xmlns:c
 alcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0" 
xmlns:style="urn:oasis:names:tc:opendocument:xmlns:style:1.0" 
xmlns:text="urn:oasis:names:tc:opendocument:xmlns:text:1.0" 
xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2" 
xmlns:tableooo="http://openoffice.org/2009/table; 
xmlns:draw="urn:oasis:names:tc:opendocument:xmlns:drawing:1.0" 
xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0" 
xmlns:rpt="http://openoffice.org/2005/report; 
xmlns:formx="urn:openoffice:names:experimental:ooxml-odf-interop:xmlns:form:1.0"
 xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0" 
xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0" 
xmlns:officeooo="http://openoffice.org/2009/office; 
xmlns:table="urn:oasis:names:tc:opendocument:xmlns:table:1.0" 
xmlns:field="urn:openoffice:names:experimental:ooo-ms-interop:xmlns:field:1.0" 
xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0" 
xmlns:meta="urn:oasis:names:tc:opendocument:xmlns:
 meta:1.0" 
xmlns:loext="urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.0"
 office:version="1.3" office:mimetype="application/vnd.oasis.opendocument.text">
+ LibreOfficeDev/7.6.0.0.alpha0$Linux_X86_64 
LibreOffice_project/2e076661cf81225e390a3f5c86171eebb74ebbedGetting
 Started with LibreOffice 
4.22010-01-04T08:31:18369P2DT11H48M52SJean
 Hollis 
Weber2023-01-23T16:28:26.015905461
+ 
+  
+  
+  
+  
+  
+  
+  
+ 
+  
+   
+   
+
+   
+   
+  
+  
+   
+   
+  
+  
+   
+  
+  
+   
+  
+  
+   
+   
+  
+  
+   
+  
+  
+   
+  
+  
+  
+  
+   
+  
+  
+   
+  
+  
+   
+
+   
+   
+
+   
+   
+
+   
+   
+
+   
+   
+
+   
+   
+
+   
+   
+
+   
+   
+
+   
+   
+
+   
+   
+
+   
+  
+  
+  
+  
+ 
+ 
+  
+   
+  
+  
+   
+  
+  
+   
+  
+  
+   
+  
+  
+   
+
+   
+   
+   
+  
+  
+   
+
+   
+   
+   
+
+   
+  
+  
+   
+
+   
+   
+   
+  
+  
+   
+
+   
+   
+   
+  
+  
+   
+
+   
+   
+   
+  
+  
+   
+  
+ 
+ 
+  
+  
+ 
+  
+   
+   
+
+
+
+
+
+
+   
+   
+
+   
+   before image
+   
+ 

[Libreoffice-bugs] [Bug 152638] Rotating an image and not able to position correctly

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152638

Buovjaga  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||ilmari.lauhakangas@libreoff
   ||ice.org
 Status|UNCONFIRMED |NEEDINFO

--- Comment #5 from Buovjaga  ---
Alan: Please copy and paste here the contents of your Help - About (LibreOffice
- About on macOS) by clicking the copy button. This allows us to know more
about your system.

If you are able to share a problematic image, it would be great.

Set to NEEDINFO.
Change back to UNCONFIRMED after you have provided the information.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Question re the uno-skeletonmaker'-t' CLI qualifier

2023-01-23 Thread Stephan Bergmann

On 24/01/2023 01:05, David wrote:
Hello Stephan, Yes, this is a Linux system and I'm invoking 
uno-skeletonmaker thus:


david@anon:~> "$OFFICE_HOME"/sdk/bin/uno-skeletonmaker calc-add-in 
--java5 -l "$OFFICE_PROGRAM_PATH"/types.rdb -n 
org.openoffice.adl.util.CalcDL1 -t CalcDL1

ERROR: Unknown entity 'CalcDL1'
david@anon:~>

I'd already found the '-l' trap for the unwary the hard way (and it also 
occurs in 'javamaker')!  My problem now is that a value for '-t' is 
apparently mandatory for the 'calc-add-in' command but I don't 
understand what to put there.


The uno-skeletonmaker source code, its help text, and every other 
reference have identical wording:  "-t  specifies a UNOIDL type 
name, e.g. com.sun.star.text.XText (can be used more than once)”.


Since '-l' already points to types.rdb you'd think '-t' wouldn't be 
needed. The phrasing "-t CalcDL1" was just a guess as I'd read some 
source code which seemed to imply a service-name was required.


I don't know much about skeletonmaker or Calc add-ins, but 
 
says "The functions that the add-in component exports to the spreadsheet 
application have to be defined in a new interface."  So I would assume 
that -t must specify that interface type.  And one or more -l will be 
needed to make available that interface type and all the other UNOIDL 
entities recursively referenced from it.  So if you have your own type 
com.example.XMyAddIn in your own local mytypes.rdb, you'd probably need 
something like



-t com.example.XMyAddIn -l "$OFFICE_HOME"/program/types.rdb -l 
"$OFFICE_HOME"/program/types/offapi.rdb -l mytypes.rdb




[Libreoffice-bugs] [Bug 153175] Spell Checker in Persian (Farsi) language

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153175

خالد حسني  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #4 from خالد حسني  ---


*** This bug has been marked as a duplicate of bug 151968 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151968] Squiggly lines cover misspelled Arabic words

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151968

خالد حسني  changed:

   What|Removed |Added

 CC||afs...@libreoffice.ir

--- Comment #3 from خالد حسني  ---
*** Bug 153175 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153166] Ods saved from xls has issue with images in cells

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153166

Robert Großkopf  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||rob...@familiegrosskopf.de
 Ever confirmed|0   |1

--- Comment #3 from Robert Großkopf  ---
Couldn't confirm the buggy behavior here. Could move the images wherever I
want.
Tested on OpenSUSE 15.3 64bit rpm Linux.
Version: 7.5.0.2 (X86_64) / LibreOffice Community
Build ID: c0dd1bc3f1a385d110b88e26ece634da94921f58
CPU threads: 6; OS: Linux 5.3; UI render: default; VCL: kf5 (cairo+xcb)
Locale: de-DE (de_DE.UTF-8); UI: de-DE
Calc: threaded

Might be a special problem of gtk3? 
Please describe the used version.
Try to start also with SAL_USE_VCLPLUGIN=gen

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - include/oox oox/qa oox/source

2023-01-23 Thread Regina Henschel (via logerrit)
 include/oox/export/drawingml.hxx|6 -
 oox/qa/unit/data/tdf148784_StretchCommandQ.odp  |binary
 oox/qa/unit/data/tdf148784_StretchCommandVW.odp |binary
 oox/qa/unit/data/tdf148784_StretchXY.odp|binary
 oox/qa/unit/export.cxx  |  113 
 oox/source/export/drawingml.cxx |  108 +++---
 6 files changed, 188 insertions(+), 39 deletions(-)

New commits:
commit 03625a00e7d147251d916a09f0bf9dbdf3a51913
Author: Regina Henschel 
AuthorDate: Tue Apr 26 23:48:21 2022 +0200
Commit: Andras Timar 
CommitDate: Tue Jan 24 06:39:17 2023 +

tdf#148784 consider StretchX in OOXML export

The export to custGeom uses currently a static version of the shape. Its
vertices are calculated with EnhancedCustomShape2d::GetParameter(). That
has parameters to determine whether ReplaceGeoWidth and ReplaceGeoHeight
has to be used. It needs to be used, in case the shape has property
StretchX or StretchY. That was missing. It is added now in cases where
GetParameter() returns a coordinate.

Not all cases are covered by unit tests. Further files for manual testing
are attached to the bug.

Change-Id: Idcdd081f855ed6c4e3a84dba08f8a2148ddfe54c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133463
Tested-by: Jenkins
Reviewed-by: Regina Henschel 
(cherry picked from commit 0818a3dcaf6d7962d043829d42a3bb9d998393d4)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145987
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Andras Timar 

diff --git a/include/oox/export/drawingml.hxx b/include/oox/export/drawingml.hxx
index 65c9112ab497..8e4fe156c0cd 100644
--- a/include/oox/export/drawingml.hxx
+++ b/include/oox/export/drawingml.hxx
@@ -200,12 +200,14 @@ protected:
 void WriteGlowEffect(const css::uno::Reference& 
rXPropSet);
 void WriteSoftEdgeEffect(const 
css::uno::Reference& rXPropSet);
 void WriteCustomGeometryPoint(const 
css::drawing::EnhancedCustomShapeParameterPair& rParamPair,
-  const EnhancedCustomShape2d& rCustomShape2d);
+  const EnhancedCustomShape2d& rCustomShape2d,
+  const bool bReplaceGeoWidth, const bool 
bReplaceGeoHeight);
 bool WriteCustomGeometrySegment(
 const sal_Int16 eCommand, const sal_Int32 nCount,
 const 
css::uno::Sequence& rPairs,
 sal_Int32& rnPairIndex, double& rfCurrentX, double& rfCurrentY, bool& 
rbCurrentValid,
-const EnhancedCustomShape2d& rCustomShape2d);
+const EnhancedCustomShape2d& rCustomShape2d,
+const bool bReplaceGeoWidth, const bool bReplaceGeoHeight);
 
 public:
 DrawingML( ::sax_fastparser::FSHelperPtr pFS, ::oox::core::XmlFilterBase* 
pFB, DocumentType eDocumentType = DOCUMENT_PPTX, DMLTextExport* pTextExport = 
nullptr )
diff --git a/oox/qa/unit/data/tdf148784_StretchCommandQ.odp 
b/oox/qa/unit/data/tdf148784_StretchCommandQ.odp
new file mode 100644
index ..3da092b2c598
Binary files /dev/null and b/oox/qa/unit/data/tdf148784_StretchCommandQ.odp 
differ
diff --git a/oox/qa/unit/data/tdf148784_StretchCommandVW.odp 
b/oox/qa/unit/data/tdf148784_StretchCommandVW.odp
new file mode 100644
index ..bf1054a20581
Binary files /dev/null and b/oox/qa/unit/data/tdf148784_StretchCommandVW.odp 
differ
diff --git a/oox/qa/unit/data/tdf148784_StretchXY.odp 
b/oox/qa/unit/data/tdf148784_StretchXY.odp
new file mode 100644
index ..f9df40570e89
Binary files /dev/null and b/oox/qa/unit/data/tdf148784_StretchXY.odp differ
diff --git a/oox/qa/unit/export.cxx b/oox/qa/unit/export.cxx
index a6cf4e7342eb..31f81936684e 100644
--- a/oox/qa/unit/export.cxx
+++ b/oox/qa/unit/export.cxx
@@ -592,6 +592,119 @@ CPPUNIT_TEST_FIXTURE(Test, testFaultyPathCommandsAWT)
 assertXPath(pXmlDoc, 
"//p:spTree/p:sp[4]/p:spPr/a:custGeom/a:pathLst/a:path/a:moveTo");
 }
 
+CPPUNIT_TEST_FIXTURE(Test, testTdf148784StretchXY)
+{
+// The document has a custom shapes of type "non-primitive" to trigger the 
custGeom export.
+// They use formulas with 'right' and 'bottom'.
+// When saving to PPTX the attributes stretchpoint-x and stretchpoint-y 
were not considered. The
+// line at right and bottom edge were positioned inside as if the shape 
had a square size.
+OUString aURL = m_directories.getURLFromSrc(DATA_DIRECTORY) + 
"tdf148784_StretchXY.odp";
+loadAndSave(aURL, "Impress Office Open XML");
+
+// Verify the markup.
+std::unique_ptr pStream = parseExportStream(getTempFile(), 
"ppt/slides/slide1.xml");
+xmlDocUniquePtr pXmlDoc = parseXmlStream(pStream.get());
+
+// x-position of last segment should be same as path width. It was 21600 
without fix.
+sal_Int32 nWidth
+= getXPathContent(pXmlDoc, 
"//p:spTree/p:sp[1]/p:spPr/a:custGeom/a:pathLst/a:path/@w")
+  .toInt32();
+sal_Int32 

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - oox/qa oox/source

2023-01-23 Thread Regina Henschel (via logerrit)
 oox/qa/unit/data/tdf100391_TextAreaRect.odp |binary
 oox/qa/unit/export.cxx  |   21 ++
 oox/source/export/drawingml.cxx |   98 +++-
 3 files changed, 116 insertions(+), 3 deletions(-)

New commits:
commit b88449732d1b97ad53c09425831d48362c3a9bf5
Author: Regina Henschel 
AuthorDate: Mon Apr 4 01:55:29 2022 +0200
Commit: Andras Timar 
CommitDate: Tue Jan 24 06:38:56 2023 +

tdf#100391 calculate true textarea rect for custGeom

Without the fix the attributes for  were set to 'l', 't', 'r'
and 'b'. That means that the textarea rectangle equals the shape
rectangle. That is the default and works for many shapes. But 'Puzzle'
has a smaller textarea rectangle, for example.

Because the values in draw:text-areas are relative to the internal
coordinate system given by draw:viewBox in ODF, but the values in
 are relative to the shape coordinate system in OOXML, we
cannot simple write the current absolute values but need to calculate
them depending on actual width and height. For that we need guides.

The patch introduces a guide list. Currently the list contains only the
guides for the textarea rectangle, but it can be extended when export
of handles will be implemented one day.

Change-Id: I1050627ef6459ab5f8fafa939d7905122870c903
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132489
Tested-by: Jenkins
Reviewed-by: Regina Henschel 
(cherry picked from commit 1ad58c77352e418124387b804b18da2aeea22c8b)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145986
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Andras Timar 

diff --git a/oox/qa/unit/data/tdf100391_TextAreaRect.odp 
b/oox/qa/unit/data/tdf100391_TextAreaRect.odp
new file mode 100755
index ..b9b9e5b39e4a
Binary files /dev/null and b/oox/qa/unit/data/tdf100391_TextAreaRect.odp differ
diff --git a/oox/qa/unit/export.cxx b/oox/qa/unit/export.cxx
index 69dc10860f4e..a6cf4e7342eb 100644
--- a/oox/qa/unit/export.cxx
+++ b/oox/qa/unit/export.cxx
@@ -530,6 +530,27 @@ CPPUNIT_TEST_FIXTURE(Test, testTdf147978_subpath)
 assertXPath(pXmlDoc, "//a:pathLst/a:path[4]", "h", "80");
 }
 
+CPPUNIT_TEST_FIXTURE(Test, testTdf100391TextAreaRect)
+{
+// The document has a custom shape of type "non-primitive" to trigger the 
custGeom export
+OUString aURL = m_directories.getURLFromSrc(DATA_DIRECTORY) + 
"tdf100391_TextAreaRect.odp";
+// When saving to PPTX the textarea rect was set to default instead of 
using the actual area
+loadAndSave(aURL, "Impress Office Open XML");
+
+// Verify the markup. Without fix the values were l="l", t="t", r="r", 
b="b"
+std::unique_ptr pStream = parseExportStream(getTempFile(), 
"ppt/slides/slide1.xml");
+xmlDocUniquePtr pXmlDoc = parseXmlStream(pStream.get());
+assertXPath(pXmlDoc, "//a:custGeom/a:rect", "l", "textAreaLeft");
+assertXPath(pXmlDoc, "//a:custGeom/a:rect", "t", "textAreaTop");
+assertXPath(pXmlDoc, "//a:custGeom/a:rect", "r", "textAreaRight");
+assertXPath(pXmlDoc, "//a:custGeom/a:rect", "b", "textAreaBottom");
+// The values are calculated in guides, for example
+assertXPath(pXmlDoc, "//a:custGeom/a:gdLst/a:gd[1]", "name", 
"textAreaLeft");
+assertXPath(pXmlDoc, "//a:custGeom/a:gdLst/a:gd[1]", "fmla", "*/ 144 w 
288");
+// The test reflects the state of Apr 2022. It needs to be adapted when 
export of handles and
+// guides is implemented.
+}
+
 CPPUNIT_TEST_FIXTURE(Test, testTdf109169_OctagonBevel)
 {
 // The odp file contains an "Octagon Bevel" shape. Such has shading not in 
commands H,I,J,K
diff --git a/oox/source/export/drawingml.cxx b/oox/source/export/drawingml.cxx
index da43043bd9c5..b8e265882a65 100644
--- a/oox/source/export/drawingml.cxx
+++ b/oox/source/export/drawingml.cxx
@@ -3865,6 +3865,83 @@ sal_Int32 GetCustomGeometryPointValue(const 
css::drawing::EnhancedCustomShapePar
 
 return nValue;
 }
+
+struct TextAreaRect
+{
+OString left;
+OString top;
+OString right;
+OString bottom;
+};
+
+struct Guide
+{
+OString sName;
+OString sFormula;
+};
+
+void prepareTextArea(const EnhancedCustomShape2d& rEnhancedCustomShape2d,
+std::vector& rGuideList, TextAreaRect& 
rTextAreaRect)
+{
+tools::Rectangle aTextAreaLO(rEnhancedCustomShape2d.GetTextRect());
+tools::Rectangle aLogicRectLO(rEnhancedCustomShape2d.GetLogicRect());
+if (aTextAreaLO == aLogicRectLO)
+{
+rTextAreaRect.left = "l";
+rTextAreaRect.top = "t";
+rTextAreaRect.right = "r";
+rTextAreaRect.bottom = "b";
+return;
+}
+// Flip aTextAreaLO if shape is flipped
+if (rEnhancedCustomShape2d.IsFlipHorz())
+aTextAreaLO.Move((aLogicRectLO.Center().X() - 
aTextAreaLO.Center().X()) * 2, 0);
+if (rEnhancedCustomShape2d.IsFlipVert())
+aTextAreaLO.Move(0, 

[Libreoffice-bugs] [Bug 153172] Options > Charts > Default Colors are no longer persistent

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153172

Heiko Tietze  changed:

   What|Removed |Added

 CC||heiko.tietze@documentfounda
   ||tion.org,
   ||vmik...@collabora.com

--- Comment #4 from Heiko Tietze  ---
Miklos, is this a fall-out from bug 151900?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153175] Spell Checker in Persian (Farsi) language

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153175

--- Comment #3 from افشین  ---
This bug does not exist in English, but it exists in Farsi.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153172] Options > Charts > Default Colors are no longer persistent

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153172

raal  changed:

   What|Removed |Added

 CC||r...@post.cz

--- Comment #3 from raal  ---
Can you share your test file?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 102187] [META] Options dialog bugs and enhancements

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=102187

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||153172


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=153172
[Bug 153172] Options > Charts > Default Colors are no longer persistent
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153172] Options > Charts > Default Colors are no longer persistent

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153172

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

Summary|Chart Colors are no longer  |Options > Charts > Default
   |persistent  |Colors are no longer
   ||persistent
   Keywords||regression
 Blocks||102187


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=102187
[Bug 102187] [META] Options dialog bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 106013] IMCOSH, IMCOT, IMCSC, IMCSCH, IMSEC, IMSECH, IMSINH and IMTAN compatibility

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=106013

--- Comment #10 from raal  ---
Still repro with Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: offapi/com offapi/UnoApi_offapi.mk sd/source sd/util solenv/bin

2023-01-23 Thread Noel Grandin (via logerrit)
 offapi/UnoApi_offapi.mk   |1 
 offapi/com/sun/star/drawing/framework/ConfigurationController.idl |   42 
--
 sd/source/ui/framework/configuration/ConfigurationController.cxx  |   32 
+--
 sd/source/ui/inc/DrawController.hxx   |6 -
 sd/source/ui/inc/framework/ConfigurationController.hxx|   11 --
 sd/source/ui/unoidl/DrawController.cxx|   10 --
 sd/util/sd.component  |4 
 solenv/bin/native-code.py |1 
 8 files changed, 16 insertions(+), 91 deletions(-)

New commits:
commit 31a5db6f28cd006adf5630b2c5d683accb9eeadb
Author: Noel Grandin 
AuthorDate: Mon Jan 23 12:14:25 2023 +0200
Commit: Noel Grandin 
CommitDate: Tue Jan 24 05:46:58 2023 +

[API CHANGE] remove service sd::framework::ConfigurationController

It makes no sense to be constructed externally.

Change-Id: I6fb8f58ff8594c58d190f78e6f26b2703046a95b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146001
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/offapi/UnoApi_offapi.mk b/offapi/UnoApi_offapi.mk
index 0041655dac91..0f3a4a371a73 100644
--- a/offapi/UnoApi_offapi.mk
+++ b/offapi/UnoApi_offapi.mk
@@ -148,7 +148,6 @@ $(eval $(call 
gb_UnoApi_add_idlfiles_nohdl,offapi,com/sun/star/drawing/framework
BasicPaneFactory \
BasicToolBarFactory \
BasicViewFactory \
-   ConfigurationController \
ModuleController \
ResourceId \
 ))
diff --git a/offapi/com/sun/star/drawing/framework/ConfigurationController.idl 
b/offapi/com/sun/star/drawing/framework/ConfigurationController.idl
deleted file mode 100644
index 46df3fa820f0..
--- a/offapi/com/sun/star/drawing/framework/ConfigurationController.idl
+++ /dev/null
@@ -1,42 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- *
- * This file incorporates work covered by the following license notice:
- *
- *   Licensed to the Apache Software Foundation (ASF) under one or more
- *   contributor license agreements. See the NOTICE file distributed
- *   with this work for additional information regarding copyright
- *   ownership. The ASF licenses this file to you under the Apache
- *   License, Version 2.0 (the "License"); you may not use this file
- *   except in compliance with the License. You may obtain a copy of
- *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
- */
-
-module com { module sun { module star { module drawing { module framework {
-
-/** See XConfigurationController for a description of the
-configuration controller.
-
-This service is used at the moment by the
-XControllerManager to create a configuration controller.
-This allows developers to replace the default implementation of the
-configuration controller with their own.  This may not be a useful
-feature.  Furthermore the sub controllers may need a tighter coupling
-than the interfaces allow.  These are reasons for removing this service
-in the future and let the controller manager create the sub controllers
-directly.
-*/
-service ConfigurationController
-: XConfigurationController
-{
-create ([in] ::com::sun::star::frame::XController xController);
-};
-
-}; }; }; }; }; // ::com::sun::star::drawing::framework
-
-/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sd/source/ui/framework/configuration/ConfigurationController.cxx 
b/sd/source/ui/framework/configuration/ConfigurationController.cxx
index 3fc95adb9b96..59fdf374a74f 100644
--- a/sd/source/ui/framework/configuration/ConfigurationController.cxx
+++ b/sd/source/ui/framework/configuration/ConfigurationController.cxx
@@ -101,10 +101,15 @@ ConfigurationController::Lock::~Lock()
 
 //= ConfigurationController ===
 
-ConfigurationController::ConfigurationController() noexcept
+ConfigurationController::ConfigurationController(const 
css::uno::Reference& rxController) noexcept
 : ConfigurationControllerInterfaceBase(m_aMutex)
 , mbIsDisposed(false)
 {
+const SolarMutexGuard aSolarGuard;
+
+mpImplementation.reset(new Implementation(
+*this,
+rxController));
 }
 
 ConfigurationController::~ConfigurationController() noexcept
@@ -475,22 +480,6 @@ Reference SAL_CALL 
ConfigurationController::getResourceFactory
 return 
mpImplementation->mpResourceFactoryContainer->GetFactory(sResourceURL);
 }
 
-//- XInitialization ---
-
-void SAL_CALL 

[Libreoffice-bugs] [Bug 153175] Spell Checker in Persian (Farsi) language

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153175

--- Comment #2 from افشین  ---
There is not this bug in English and there is in Persian (Farsi) words.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153175] Spell Checker in Persian (Farsi) language

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153175

--- Comment #1 from افشین  ---
Created attachment 184860
  --> https://bugs.documentfoundation.org/attachment.cgi?id=184860=edit
Persian Spelling Sample

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153175] New: Spell Checker in Persian (Farsi) language

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153175

Bug ID: 153175
   Summary: Spell Checker in Persian (Farsi) language
   Product: LibreOffice
   Version: 7.4.4.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: afs...@libreoffice.ir

Created attachment 184859
  --> https://bugs.documentfoundation.org/attachment.cgi?id=184859=edit
Persian Spelling Sample

Hello. 

When the spell checker is active, instead of drawing a diagonal red line under
the word, LibreOffice draws almost on the line, which makes the misspelled word
not read correctly!

Version: 7.4.4.2 / LibreOffice Community
Build ID: 40(Build:2)
CPU threads: 2; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: fa-IR (en_US.UTF-8); UI: en-US
Ubuntu package version: 1:7.4.4-0ubuntu0.22.04.1~lo1
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153174] New: Update Amiri font to final release 1.000

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153174

Bug ID: 153174
   Summary: Update Amiri font to final release 1.000
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: shanshandehongx...@outlook.com

Description:
Since the Amiri font is released 1.000, it's reasonable to adopt that.

Steps to Reproduce:
-

Actual Results:
-

Expected Results:
-


Reproducible: Always


User Profile Reset: No

Additional Info:
https://github.com/aliftype/amiri/releases/tag/1.000

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153172] Chart Colors are no longer persistent

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153172

Telesto  changed:

   What|Removed |Added

 CC||stephane.guillou@libreoffic
   ||e.org, tele...@surfxs.nl
   Keywords||bibisectRequest
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152877] Dates are getting formatted as dollar amounts and can't change

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152877

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152875] Diagram legend is changed when saving

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152875

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152590] UI WollMux sidebar dropdown menu appears detached

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152590

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152946] when sidebar is wider that some value, most of the final row of widgets is lost below the sidebar border, and is unreadable (but not necessarily unusable)

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152946

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152930] Jumpy text and off-by-one-pixel errors in Calc with 150% high-DPI scaling

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152930

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 153168] Please remove the "finished" dialog after restoring Documents

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153168

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 153149] LibreOffice Writer and Calc buttons group is mixed in taskbar of Debian 11.6 KDE

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153149

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 153168] Please remove the "finished" dialog after restoring Documents

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153168

--- Comment #3 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 153149] LibreOffice Writer and Calc buttons group is mixed in taskbar of Debian 11.6 KDE

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153149

--- Comment #3 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153121] Comment inside Slide

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153121

--- Comment #3 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153121] Comment inside Slide

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153121

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152844] Footnote separator alignment + Footnote paragraph direction flip in LO->MSO->LO round-trip

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152844

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152844] Footnote separator alignment + Footnote paragraph direction flip in LO->MSO->LO round-trip

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152844

--- Comment #3 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147171] EDITING: Page breaks revert to portrait although set to landscape

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147171

--- Comment #3 from QA Administrators  ---
Dear emery.peter,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150106] using link external data fails after upgrade to 7.3

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150106

--- Comment #4 from QA Administrators  ---
Dear rqu...@gmail.com,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149735] MP4 video does not play correctly when showing a presentation

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149735

--- Comment #4 from QA Administrators  ---
Dear Aleksandr,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149612] LibreOffice Writer stops working after 15-120 minutes

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149612

--- Comment #3 from QA Administrators  ---
Dear lanedvt,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 93732] Start Center window does not have a title

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=93732

--- Comment #11 from QA Administrators  ---
Dear Pieter van Oostrum,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 68088] incorrect AutoCorrect of quotation marks after a slash (e.g.: /" changes to /”)

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=68088

--- Comment #10 from QA Administrators  ---
Dear flamingdescent,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 63251] FORMATTING: Formatting an auto-field (e.g. date) not possible in Impress and Draw

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=63251

--- Comment #16 from QA Administrators  ---
Dear whoever,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 106013] IMCOSH, IMCOT, IMCSC, IMCSCH, IMSEC, IMSECH, IMSINH and IMTAN compatibility

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=106013

--- Comment #9 from QA Administrators  ---
Dear raal,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 121634] The numerically size (and position) of an shape changes after rotation

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121634

--- Comment #4 from QA Administrators  ---
Dear Telesto,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147608] Memory usage runs away when Skia is used

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147608

--- Comment #9 from V Stuart Foote  ---
Sorry those was attachment 181502 (with symbols) compared to attachment 178516
and  it is a dupe to me.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 129062] [META] Skia library bugs

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129062
Bug 129062 depends on bug 147608, which changed state.

Bug 147608 Summary: Memory usage runs away when Skia is used
https://bugs.documentfoundation.org/show_bug.cgi?id=147608

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 122652] [META] Memory problems in LibreOffice

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122652
Bug 122652 depends on bug 147608, which changed state.

Bug 147608 Summary: Memory usage runs away when Skia is used
https://bugs.documentfoundation.org/show_bug.cgi?id=147608

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149527] Calc crashes when scroll up and down quickly within a document, or hold Page Down (Skia/Vulkan)

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149527

V Stuart Foote  changed:

   What|Removed |Added

 CC||philipp-maximilian.bender@t
   ||-online.de

--- Comment #30 from V Stuart Foote  ---
*** Bug 147608 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147608] Memory usage runs away when Skia is used

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147608

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #8 from V Stuart Foote  ---
Yes, the stack trace of attachment 178516 in comment 6 is similar, if not
identical and just lacking symbols, with overflow error C409 as seen in
attachment 178516 on bug 149527 (or dupe bug 150190 ).

*** This bug has been marked as a duplicate of bug 149527 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 133999] [META] XLSX (OOXML) Form Controls related issues

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133999
Bug 133999 depends on bug 135987, which changed state.

Bug 135987 Summary: FILEOPEN XLSX: Check box loses "Linked Cell" property after 
round-trip (comment 6)
https://bugs.documentfoundation.org/show_bug.cgi?id=135987

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 108897] [META] XLSX (OOXML) bug tracker

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108897
Bug 108897 depends on bug 135987, which changed state.

Bug 135987 Summary: FILEOPEN XLSX: Check box loses "Linked Cell" property after 
round-trip (comment 6)
https://bugs.documentfoundation.org/show_bug.cgi?id=135987

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 135987] FILEOPEN XLSX: Check box loses "Linked Cell" property after round-trip (comment 6)

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135987

Justin L  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 135987] FILEOPEN XLSX: Check box loses "Linked Cell" property after round-trip (comment 6)

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135987

--- Comment #7 from Commit Notification 
 ---
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/7f23dae00fedc9d7119b44b6c44d9eca4f8c87b8

tdf#135987 xlsx vml export: retain checkbox link to cell

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 135987] FILEOPEN XLSX: Check box loses "Linked Cell" property after round-trip (comment 6)

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135987

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.6.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sc/qa sc/source

2023-01-23 Thread Justin Luth (via logerrit)
 sc/qa/unit/subsequent_export_test2.cxx |4 
 sc/source/filter/excel/xeescher.cxx|   17 +++--
 2 files changed, 19 insertions(+), 2 deletions(-)

New commits:
commit 7f23dae00fedc9d7119b44b6c44d9eca4f8c87b8
Author: Justin Luth 
AuthorDate: Sat Jan 21 21:40:25 2023 -0500
Commit: Justin Luth 
CommitDate: Tue Jan 24 02:14:12 2023 +

tdf#135987 xlsx vml export: retain checkbox link to cell

The checkbox can be linked to a cell, so that the cell's value
is toggled between true and false.
This was lost on a round-trip.

Change-Id: I4f2d44a594a92caedb29ded9b2c292006c803115
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145962
Tested-by: Justin Luth 
Reviewed-by: Justin Luth 

diff --git a/sc/qa/unit/subsequent_export_test2.cxx 
b/sc/qa/unit/subsequent_export_test2.cxx
index 3093e63500dd..81df3cb9452f 100644
--- a/sc/qa/unit/subsequent_export_test2.cxx
+++ b/sc/qa/unit/subsequent_export_test2.cxx
@@ -1075,6 +1075,10 @@ void ScExportTest2::testTdf106181()
 pDrawing,
 
"/xdr:wsDr/mc:AlternateContent/mc:Choice/xdr:twoCellAnchor/xdr:sp/xdr:nvSpPr/xdr:cNvPr",
 "hidden", "0");
+
+xmlDocUniquePtr pVmlDrawing = parseExport("xl/drawings/vmlDrawing1.vml");
+CPPUNIT_ASSERT(pVmlDrawing);
+assertXPathContent(pVmlDrawing, "//xx:ClientData/xx:FmlaLink", "$D$9");
 }
 
 void ScExportTest2::testTdf145057()
diff --git a/sc/source/filter/excel/xeescher.cxx 
b/sc/source/filter/excel/xeescher.cxx
index c0c15fda599a..4e9491cc94c3 100644
--- a/sc/source/filter/excel/xeescher.cxx
+++ b/sc/source/filter/excel/xeescher.cxx
@@ -1094,13 +1094,14 @@ class VmlFormControlExporter : public 
oox::vml::VMLExport
 tools::Rectangle m_aAreaFrom;
 tools::Rectangle m_aAreaTo;
 OUString m_sControlName;
+OUString m_sFmlaLink;
 OUString m_aLabel;
 OUString m_aMacroName;
 
 public:
 VmlFormControlExporter(const sax_fastparser::FSHelperPtr& p, sal_uInt16 
nObjType,
const tools::Rectangle& rAreaFrom, const 
tools::Rectangle& rAreaTo,
-   const OUString& sControlName,
+   const OUString& sControlName, const OUString& 
sFmlaLink,
OUString aLabel, OUString aMacroName);
 
 protected:
@@ -1115,12 +1116,14 @@ VmlFormControlExporter::VmlFormControlExporter(const 
sax_fastparser::FSHelperPtr
const tools::Rectangle& 
rAreaFrom,
const tools::Rectangle& rAreaTo,
const OUString& sControlName,
+   const OUString& sFmlaLink,
OUString aLabel, OUString 
aMacroName)
 : VMLExport(p)
 , m_nObjType(nObjType)
 , m_aAreaFrom(rAreaFrom)
 , m_aAreaTo(rAreaTo)
 , m_sControlName(sControlName)
+, m_sFmlaLink(sFmlaLink)
 , m_aLabel(std::move(aLabel))
 , m_aMacroName(std::move(aMacroName))
 {
@@ -1178,6 +1181,9 @@ void VmlFormControlExporter::EndShape(sal_Int32 
nShapeElement)
 }
 XclXmlUtils::WriteElement(pVmlDrawing, FSNS(XML_x, XML_TextVAlign), 
"Center");
 
+if (!m_sFmlaLink.isEmpty())
+XclXmlUtils::WriteElement(pVmlDrawing, FSNS(XML_x, XML_FmlaLink), 
m_sFmlaLink);
+
 pVmlDrawing->endElement(FSNS(XML_x, XML_ClientData));
 VMLExport::EndShape(nShapeElement);
 }
@@ -1192,8 +1198,15 @@ void XclExpTbxControlObj::SaveVml(XclExpXmlStream& rStrm)
 tools::Rectangle aAreaTo;
 // Unlike XclExpTbxControlObj::SaveXml(), this is not calculated in EMUs.
 lcl_GetFromTo(mrRoot, pObj->GetLogicRect(), GetTab(), aAreaFrom, aAreaTo);
+
+const OUString sCellLink
+= mxCellLinkAddress.IsValid()
+  ? mxCellLinkAddress.Format(ScRefFlags::ADDR_ABS, (),
+ 
ScAddress::Details(formula::FormulaGrammar::CONV_XL_A1))
+  : OUString();
+
 VmlFormControlExporter aFormControlExporter(rStrm.GetCurrentStream(), 
GetObjType(), aAreaFrom,
-aAreaTo, msCtrlName, msLabel, 
GetMacroName());
+aAreaTo, msCtrlName, 
sCellLink, msLabel, GetMacroName());
 aFormControlExporter.SetSkipwzName(true);  // use XML_id for legacyid, not 
XML_ID
 aFormControlExporter.OverrideShapeIDGen(true, "_x_s");
 aFormControlExporter.AddSdrObject(*pObj, /*bIsFollowingTextFlow=*/false, 
/*eHOri=*/-1,


[Libreoffice-bugs] [Bug 120374] FILESAVE XLSM: VBA button doesn't execute linked macro after round-trip

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120374

--- Comment #8 from Commit Notification 
 ---
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/245912dc42bfc13cbf0db3f04f2411f3dede9615

tdf#117266 tdf#120374 sc oox: export correct vml button name #2

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 120374] FILESAVE XLSM: VBA button doesn't execute linked macro after round-trip

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120374

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.6.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 117266] FILESAVE: xlsm- VBA broken by export - missing userforms (comment 18)

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=117266

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.6.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: oox/source sc/qa sc/source

2023-01-23 Thread Justin Luth (via logerrit)
 oox/source/export/vmlexport.cxx|   18 +++---
 sc/qa/unit/subsequent_export_test2.cxx |5 -
 sc/source/filter/excel/xeescher.cxx|9 -
 3 files changed, 23 insertions(+), 9 deletions(-)

New commits:
commit 245912dc42bfc13cbf0db3f04f2411f3dede9615
Author: Justin Luth 
AuthorDate: Sat Jan 21 17:00:26 2023 -0500
Commit: Justin Luth 
CommitDate: Tue Jan 24 02:09:55 2023 +

tdf#117266 tdf#120374 sc oox: export correct vml button name #2

So the actual name is more important than I knew.
For example, VBA maps click macros based on the button name.
So use the MS-provided name and use the SPID to connect to the shape id.

Of the existing unit tests that were affected by this:
-macro-button-form-control.xlsm: button now launches hello macro
-tdf117266_macroButton.xlsm - same file as ^^^
-button-form-control.xls nearly same file as ^^^
-tdf134769.xlsx - checkbox still exists on round-trip
-tdf106181.ods - checkbox still exists, but link to cell still lost.
-checkbox-form-control.xlsx - nearly same as ^^^

All looks good.

Change-Id: If83cf17d60b73c46d55a21b1a46ed320513044cb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145961
Tested-by: Jenkins
Reviewed-by: Justin Luth 

diff --git a/oox/source/export/vmlexport.cxx b/oox/source/export/vmlexport.cxx
index 339187fbe4d2..6da57bdd8be8 100644
--- a/oox/source/export/vmlexport.cxx
+++ b/oox/source/export/vmlexport.cxx
@@ -187,20 +187,24 @@ void VMLExport::AddShape( sal_uInt32 nShapeType, 
ShapeFlag nShapeFlags, sal_uInt
 m_nShapeFlags = nShapeFlags;
 
 m_sShapeId = ShapeIdString( nShapeId );
-// If shape is a watermark object - should keep the original shape's name
-// because Microsoft detects if it is a watermark by the actual name
-if (!IsWaterMarkShape(m_pSdrObject->GetName()))
+if (m_sShapeId.startsWith("_x_"))
 {
-// Not a watermark object
-m_pShapeAttrList->add( XML_id, m_sShapeId );
+// xml_id must be set elsewhere. The id is critical for matching VBA 
macros etc,
+// and the spid is critical to link to the shape number elsewhere.
+m_pShapeAttrList->addNS( XML_o, XML_spid, m_sShapeId );
 }
-else
+else if (IsWaterMarkShape(m_pSdrObject->GetName()))
 {
-// A watermark object - store the optional shape ID
+// Shape is a watermark object - keep the original shape's name
+// because Microsoft detects if it is a watermark by the actual name
 m_pShapeAttrList->add( XML_id, m_pSdrObject->GetName() );
 // also ('o:spid')
 m_pShapeAttrList->addNS( XML_o, XML_spid, m_sShapeId );
 }
+else
+{
+m_pShapeAttrList->add(XML_id, m_sShapeId);
+}
 }
 
 bool VMLExport::IsWaterMarkShape(std::u16string_view rStr)
diff --git a/sc/qa/unit/subsequent_export_test2.cxx 
b/sc/qa/unit/subsequent_export_test2.cxx
index 16188c90bbfa..3093e63500dd 100644
--- a/sc/qa/unit/subsequent_export_test2.cxx
+++ b/sc/qa/unit/subsequent_export_test2.cxx
@@ -542,7 +542,10 @@ void ScExportTest2::testTdf117266()
 xmlDocUniquePtr pVmlDrawing = parseExport("xl/drawings/vmlDrawing1.vml");
 
 OUString sName = getXPath(pVmlDrawing, "/xml/v:shape", "id");
-CPPUNIT_ASSERT(sName.startsWith("_x_s"));
+CPPUNIT_ASSERT_EQUAL(OUString("Button 1001"), sName);
+
+OUString sSpid = getXPath(pVmlDrawing, "/xml/v:shape", "spid");
+CPPUNIT_ASSERT(sSpid.startsWith("_x_s"));
 
 assertXPathContent(pVmlDrawing, "/xml/v:shape/v:textbox/div/font", "Button 
1 \"y\" z");
 // Why the xx:, I have no idea..., but it certainly doesn't work with just 
x:.
diff --git a/sc/source/filter/excel/xeescher.cxx 
b/sc/source/filter/excel/xeescher.cxx
index 00b1b53a76a1..c0c15fda599a 100644
--- a/sc/source/filter/excel/xeescher.cxx
+++ b/sc/source/filter/excel/xeescher.cxx
@@ -1093,12 +1093,14 @@ class VmlFormControlExporter : public 
oox::vml::VMLExport
 sal_uInt16 m_nObjType;
 tools::Rectangle m_aAreaFrom;
 tools::Rectangle m_aAreaTo;
+OUString m_sControlName;
 OUString m_aLabel;
 OUString m_aMacroName;
 
 public:
 VmlFormControlExporter(const sax_fastparser::FSHelperPtr& p, sal_uInt16 
nObjType,
const tools::Rectangle& rAreaFrom, const 
tools::Rectangle& rAreaTo,
+   const OUString& sControlName,
OUString aLabel, OUString aMacroName);
 
 protected:
@@ -1112,11 +1114,13 @@ VmlFormControlExporter::VmlFormControlExporter(const 
sax_fastparser::FSHelperPtr
sal_uInt16 nObjType,
const tools::Rectangle& 
rAreaFrom,
const tools::Rectangle& rAreaTo,
+   const OUString& sControlName,

Re: Chart Colours: Bug or expected behaviour

2023-01-23 Thread Toki

On 23/01/23 22:51, Stéphane Guillou wrote:
Can you please report the bug on Bugzilla? I couldn't find an existing 



bug 153172
https://bugs.documentfoundation.org/show_bug.cgi?id=153172

I hope I filled everything out correctly.

jonathon


[Libreoffice-bugs] [Bug 153172] Chart Colors are no longer persistent

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153172

--- Comment #2 from jonathon  ---
Created attachment 184858
  --> https://bugs.documentfoundation.org/attachment.cgi?id=184858=edit
Screenshot LibO 7.3.7.2

This is the same image as https://imgur.com/zUAyHiP.png

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153172] Chart Colors are no longer persistent

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153172

--- Comment #1 from jonathon  ---
Created attachment 184857
  --> https://bugs.documentfoundation.org/attachment.cgi?id=184857=edit
screenshot LibO.7.5. Data Colours

This is the same image as https://i.imgur.com/fJZuiF4.png

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153173] New: "Remove personal information on saving" [FILESAVE] (Prefs/LibreOffice/Security/Options [CONFIGURATION]) does not with MS .doc documents [FILESAVE]. Likewise for Fi

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153173

Bug ID: 153173
   Summary: "Remove personal information on saving" [FILESAVE]
(Prefs/LibreOffice/Security/Options [CONFIGURATION])
does not with MS .doc documents [FILESAVE].  Likewise
for File/Properties/General/Reset Properties.
   Product: LibreOffice
   Version: 7.4.4.2 release
  Hardware: x86 (IA32)
OS: macOS (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kevbu...@gmail.com

Description:
"Remove personal information on saving" (Prefs/LibreOffice/Security/Options)
works with MS .docx documents, but not .doc documents.  This
File/Properties/General/Reset Properties feature also has this problem.  In
some cases saving a .doc document to .docx and then back to .doc will set the
fake date and time (not yet fully characterized).

Steps to Reproduce:
1. Set Security option to "Remove personal information on saving".
2. Set "Track Changes" to "Record".
3. Make changes and/or add comments.
4. Save the file.
5. View dates and times of changes or comments.  

Actual Results:
The original dates and times are not replaced with 01/01/1970 00:00:00. 

Expected Results:
The original dates and times should be replaced with 01/01/1970 00:00:00. 


Reproducible: Always


User Profile Reset: No

Additional Info:
Remove personal information on saving

Select to always remove user data from file properties, comments and tracked
changes. The names of authors in comments and changes will be replaced by
generic values as "Author1", "Author2" and so forth. Time values will also be
reset to a single standard value. If this option is not selected, you can still
remove the personal information for the current document with the Reset
Properties button on File - Properties - General.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153171] suggestion: add option to add x number of rows/columns in the menu

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153171

m.a.riosv  changed:

   What|Removed |Added

   Severity|normal  |enhancement

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153166] Ods saved from xls has issue with images in cells

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153166

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #2 from m.a.riosv  ---
Works for me on Win10
Versión: 6.4.7.2 (x64)
Id. de compilación: 639b8ac485750d5696d7590a72ef1b496725cfb5
Subprocs. CPU: 4; SO: Windows 10.0 Build 19045; Repres. IU: GL; VCL: win; 
Configuración regional: es-ES (es_ES); Idioma de IU: es-ES Calc: CL
Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: fc441f3886330c4ae2abeb67c0758b935ba23f47
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: en-US Calc: CL threaded Jumbo

Please test with a clean profile, Menu/Help/Restart in Safe Mode

Or try updating your version, it is EOL.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153172] New: Chart Colors are no longer persistent

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153172

Bug ID: 153172
   Summary: Chart Colors are no longer persistent
   Product: LibreOffice
   Version: 7.3.0.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Chart
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: toki.kant...@gmail.com

Description:
CF https://i.imgur.com/fJZuiF4.png  For LibreOffice 7.5.0.2 screenshot
CF https://imgur.com/zUAyHiP.png for LibreOffice 7.3.7.2 screenshot

For the LibO 7.5.0.2 screenshot the bar chart is what I expected to see after
changing the default colours.
Chart Default Colours shows what LibO 7.5.0.2 claims I changed the colours to.

For the LibO 7.3.7.2 screenshot, the bar chart displays the default colours,
not the colours I selected.
Chart Default Colours shows the colour palette I selected the colours from.  
Deta Series 1 is the first colour on the palette
Data Series 44 is the last colour on the palette

Both 7.3.x and 7.5.x remove Data Series 13 and higher.


Steps to Reproduce:
1 Go to ">Tools >Options >Charts >Default Colors"
2. Select a colour palette
3.Click on "Data Series 1" then click on a colour in the palette
4. The colour you clicked on shows up in the "chart colors Data Series 1"
space.
5. Click on the "Apply " button
6: Watch the colour block in Data Series 1 change back to the original colour.

Actual Results:
Data Series Colors revert back to the default setup.
Data Series are reduced back to 12 colours.

Expected Results:
Data Series Colours should retain the colour I selected.
Data Series Colours should retain all of the Data Series Chart Numbers I added.


Reproducible: Always


User Profile Reset: Yes

Additional Info:
stephane.guillou says that it is a regression to LibreOffice 6.1

I'm using 
Version: 7.5.0.2 (X86_64) / LibreOffice Community
Build ID: c0dd1bc3f1a385d110b88e26ece634da94921f58
CPU threads: 4; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: en-ZA (en_NZ.UTF-8); UI: en-ZA
Calc: threaded

and also tested on
Version: 7.3.7.2 / LibreOffice Community
Build ID: e114eadc50a9ff8d8c8a0567d6da8f454beeb84f
CPU threads: 4; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: en-ZA (en_NZ.UTF-8); UI: en-ZA
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Question re the uno-skeletonmaker'-t' CLI qualifier

2023-01-23 Thread David
Hello Stephan, Yes, this is a Linux system and I'm invoking uno-skeletonmaker 
thus:

david@anon:~> "$OFFICE_HOME"/sdk/bin/uno-skeletonmaker calc-add-in --java5 -l 
"$OFFICE_PROGRAM_PATH"/types.rdb -n org.openoffice.adl.util.CalcDL1 -t CalcDL1
ERROR: Unknown entity 'CalcDL1'
david@anon:~>

I'd already found the '-l' trap for the unwary the hard way (and it also occurs 
in 'javamaker')!  My problem now is that a value for '-t' is apparently 
mandatory for the 'calc-add-in' command but I don't understand what to put 
there.

The uno-skeletonmaker source code, its help text, and every other reference 
have identical wording:  "-t  specifies a UNOIDL type name, e.g. 
com.sun.star.text.XText (can be used more than once)”.

Since '-l' already points to types.rdb you'd think '-t' wouldn't be needed.  
The phrasing "-t CalcDL1" was just a guess as I'd read some source code which 
seemed to imply a service-name was required.
_
__Regards, David_


On 24/1/23 01:15, Stephan Bergmann wrote:
> On 23/01/2023 03:45, David wrote:
>> According to 
>> https://api.libreoffice.org/docs/tools.html#uno-skeletonmaker the 
>> argument ‘-t’  “specifies a UNOIDL type name, e.g. 
>> com.sun.star.text.XText (can be used more than once)”.  This wording is 
>> the same as both the uno-skeletonmaker command-line ‘help’ and the 
>> introductory comments in the source code for 'skeletonmaker.cxx'.
>>
>> However I don't understand which entity the UNOIDL type name is intended 
>> to qualify.  For example, is it the type of the skeleton code to be 
>> generated (presumably not, since that’s defined by the ‘calc-add-in’ 
>> command), the type of each value returned by the Java methods 
>> implemented in this addIn, or something else? Anything I've tried 
>> results in an "unknown entity" diagnostic.
> uno-skeletonmaker apparently needs to be explicitly told where to find 
> any referenced UNOIDL entities, via the -l option.  So adding something like
>> -l "$OFFICE_HOME"/program/types.rdb -l 
>> "$OFFICE_HOME"/program/types/offapi.rdb
> should work (in an SDK shell, on Linux at least).
>

[Libreoffice-bugs] [Bug 131675] Memory usage goes through the roof saving document with 120k of comments

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=131675

Telesto  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||5619

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 125619] 'performance problem with plenty comments' still in 6.3 alpha1, *only after save of file/autosave*

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125619

Telesto  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||1675

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146014] [META] Poor Scrolling Performance

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=146014
Bug 146014 depends on bug 125641, which changed state.

Bug 125641 Summary: Slow scrolling responsiveness after saving a file with lots 
of comments
https://bugs.documentfoundation.org/show_bug.cgi?id=125641

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 108075] [META] Scrolling and Page up/down issues

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108075
Bug 108075 depends on bug 125641, which changed state.

Bug 125641 Summary: Slow scrolling responsiveness after saving a file with lots 
of comments
https://bugs.documentfoundation.org/show_bug.cgi?id=125641

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 125619] 'performance problem with plenty comments' still in 6.3 alpha1, *only after save of file/autosave*

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125619

--- Comment #27 from Telesto  ---
*** Bug 125641 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 125641] Slow scrolling responsiveness after saving a file with lots of comments

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125641

Telesto  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEEDINFO|RESOLVED
   Keywords|bibisectRequest, perf   |

--- Comment #7 from Telesto  ---
(In reply to Stéphane Guillou (stragu) from comment #6)
> I also get a huge slowdown and lag with the example file in OOo 3.3.
> Telesto, any reason why this shouldn't be a duplicate of bug 61558?

It's a duplicate of bug 125619. Is bug 125619 being a duplicate of bug 61558? I
don't really know. Based on my vague recollection, not testing

There is a difference between a calc document with lots of comments, but
hidden. And a document with lots of comments with those comments all visible
(expanded) 
Both slow but maybe a different cause.

There is difference between scrolling before and after save and a good state.
at bug 125619, but might be simply the old problem uncovered in different way?

Or the perf was omni-present in 3.3.0, problem got resolved for this case by
incident or on purpose, but got re-introduced for different reason?

The slowness of this bug and bug 125619 could also be explained by bug 131675
(still present?).. different perspective on the same problem or a third
separate issue exacerbating the problems

Sidenote
I tend to assume multiple bugs being chased with the end-user effect colliding
(slow scrolling), except proven otherwise. I personally dislike marking things
duplicates easily. It might hide that multiple issues exists. And a bug report
becoming a real mess, if multiple reports start te comment on their own bug
case, and the cause being different. And rechecking duplicates - if those being
true duplicates - after a fix isn't done on a regular bases either. Ideally
(often) you don't need to - it's a waste of time - duplicates being true
duplicate

*** This bug has been marked as a duplicate of bug 125619 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - 20 commits - configure.ac cui/source distro-configs/CPAndroidBranding.conf distro-configs/CPLinux.conf distro-configs/CPLinux-LOKit

2023-01-23 Thread Aron Budea (via logerrit)
 Makefile.fetch  |   15 
 Repository.mk   |   13 
 configure.ac|   32 
 cui/source/dialogs/about.cxx|2 
 distro-configs/CPAndroidBranding.conf   |3 
 distro-configs/CPLinux-LOKit.conf   |   10 
 distro-configs/CPLinux.conf |   47 
 distro-configs/CPOSX.conf   |   19 
 distro-configs/CPWin32-MPL.conf |   27 
 distro-configs/CPWin32.conf |   26 
 distro-configs/CPWin64.conf |   26 
 download.lst|   58 
 external/Module_external.mk |1 
 external/more_fonts/ExternalPackage_karla.mk|   19 
 external/more_fonts/ExternalPackage_opendyslexic.mk |   19 
 external/more_fonts/Module_more_fonts.mk|4 
 external/more_fonts/UnpackedTarball_karla.mk|   14 
 external/more_fonts/UnpackedTarball_opendyslexic.mk |   14 
 external/noto_font/ExternalPackage_noto.mk  |  134 
 external/noto_font/ExternalPackage_notosansjp.mk|   17 
 external/noto_font/ExternalPackage_notosanskr.mk|   17 
 external/noto_font/ExternalPackage_notosanssc.mk|   17 
 external/noto_font/ExternalPackage_notosanstc.mk|   17 
 external/noto_font/ExternalPackage_notoserifjp.mk   |   17 
 external/noto_font/ExternalPackage_notoserifkr.mk   |   17 
 external/noto_font/ExternalPackage_notoserifsc.mk   |   17 
 external/noto_font/ExternalPackage_notoseriftc.mk   |   17 
 external/noto_font/Makefile |7 
 external/noto_font/Module_noto_font.mk  |   33 
 external/noto_font/README   |1 
 external/noto_font/UnpackedTarball_noto.mk  |   46 
 external/noto_font/UnpackedTarball_notosansjp.mk|   14 
 external/noto_font/UnpackedTarball_notosanskr.mk|   14 
 external/noto_font/UnpackedTarball_notosanssc.mk|   14 
 external/noto_font/UnpackedTarball_notosanstc.mk|   14 
 external/noto_font/UnpackedTarball_notoserifjp.mk   |   14 
 external/noto_font/UnpackedTarball_notoserifkr.mk   |   14 
 external/noto_font/UnpackedTarball_notoserifsc.mk   |   14 
 external/noto_font/UnpackedTarball_notoseriftc.mk   |   14 
 framework/source/helper/titlebarupdate.cxx  |2 
 icon-themes/colibre/sfx2/res/logo.png   |binary
 icon-themes/galaxy/brand_cp/about.svg   | 1463 
+
 icon-themes/galaxy/brand_cp/about_inverted.svg  | 1452 
+
 icon-themes/galaxy/brand_cp/flat_logo.svg   |  717 
 icon-themes/galaxy/brand_cp/intro-highres.png   |binary
 icon-themes/galaxy/brand_cp/intro.png   |binary
 icon-themes/galaxy/brand_cp/logo-sc.svg |   98 
 icon-themes/galaxy/brand_cp/logo-sc_inverted.svg|   58 
 icon-themes/galaxy/brand_cp/logo.svg|   99 
 icon-themes/galaxy/brand_cp/logo_inverted.svg   |   58 
 icon-themes/galaxy/brand_cp_snapshot/about.svg  | 1511 
+
 icon-themes/galaxy/brand_cp_snapshot/about_inverted.svg | 1535 
++
 icon-themes/galaxy/brand_cp_snapshot/flat_logo.svg  |  738 
 icon-themes/galaxy/brand_cp_snapshot/intro-highres.png  |binary
 icon-themes/galaxy/brand_cp_snapshot/intro.png  |binary
 icon-themes/galaxy/brand_cp_snapshot/logo-sc.svg|   98 
 icon-themes/galaxy/brand_cp_snapshot/logo-sc_inverted.svg   |   58 
 icon-themes/galaxy/brand_cp_snapshot/logo.svg   |   98 
 icon-themes/galaxy/brand_cp_snapshot/logo_inverted.svg  |   58 
 icon-themes/karasa_jaga/sfx2/res/logo.png   |binary
 include/default.rc  |2 
 instsetoo_native/CustomTarget_setup.mk  |   18 
 instsetoo_native/inc_common/windows/msi_templates/Binary/Banner.bmp |binary
 instsetoo_native/inc_common/windows/msi_templates/Binary/Image.bmp  |binary
 

[Libreoffice-commits] core.git: external/cairo

2023-01-23 Thread Tor Lillqvist (via logerrit)
 external/cairo/ExternalProject_cairo.mk  |2 +-
 external/cairo/ExternalProject_pixman.mk |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 5cd3a8ec6d36a389eb0be4d59f4570e3bda92dc5
Author: Tor Lillqvist 
AuthorDate: Mon Jan 23 16:29:42 2023 +0200
Commit: Tor Lillqvist 
CommitDate: Mon Jan 23 22:58:54 2023 +

Enforce compiling cairo and pixman for WASM with -O3

Earlier, no -O flag at all got used in the cairo and pixman
builds. Which was sad, as these two libraries are performance-critical.

Yes, this change is quick-and-dirty. The proper way would be to modify
things in solenv/gbuild. But that is somewhat complicated.

In general it seems fairly hard to make sure the same compiler flags
get used for every external bundled library. Each external library is
a special snowflake, more or less, with a differently structured
ExternalProject makefile.

For instance for the libwpd library (just picked randomly as an
example), even -O2 gets used. (Which as such is OK.) This despite
solenv/gbuild/platform/EMSCRIPTEN_INTEL_GCC.mk apparently trying to
enforce use of -O1 for Emscripten.

This change has a visible impact on the performance of COWASM.

Change-Id: I99d74db2da733134fde16661881856f9a81100f9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146009
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist 

diff --git a/external/cairo/ExternalProject_cairo.mk 
b/external/cairo/ExternalProject_cairo.mk
index fd934906343b..b677098482ff 100644
--- a/external/cairo/ExternalProject_cairo.mk
+++ b/external/cairo/ExternalProject_cairo.mk
@@ -48,7 +48,7 @@ $(call gb_ExternalProject_get_state_target,cairo,build) :
$(gb_RUN_CONFIGURE) ./configure \
$(if $(debug),STRIP=" ") \
$(if $(filter ANDROID iOS,$(OS)),CFLAGS="$(if $(debug),-g) 
$(ZLIB_CFLAGS) $(gb_VISIBILITY_FLAGS)") \
-   $(if $(filter EMSCRIPTEN,$(OS)),CFLAGS=-DCAIRO_NO_MUTEX" 
$(ZLIB_CFLAGS) -Wno-enum-conversion $(gb_EMSCRIPTEN_CPPFLAGS)" ) \
+   $(if $(filter EMSCRIPTEN,$(OS)),CFLAGS="-O3 -DCAIRO_NO_MUTEX 
$(ZLIB_CFLAGS) -Wno-enum-conversion $(gb_EMSCRIPTEN_CPPFLAGS)" ) \
$(if $(filter-out EMSCRIPTEN ANDROID iOS,$(OS)), \
CFLAGS="$(CFLAGS) $(call 
gb_ExternalProject_get_build_flags,cairo) $(ZLIB_CFLAGS)" \
LDFLAGS="$(call 
gb_ExternalProject_get_link_flags,cairo)" \
diff --git a/external/cairo/ExternalProject_pixman.mk 
b/external/cairo/ExternalProject_pixman.mk
index 9293b9234013..ac78b23d5c9e 100644
--- a/external/cairo/ExternalProject_pixman.mk
+++ b/external/cairo/ExternalProject_pixman.mk
@@ -28,7 +28,7 @@ $(call gb_ExternalProject_get_state_target,pixman,build) :
$(if $(filter ANDROID,$(OS)),--disable-arm-simd 
--disable-arm-neon --disable-arm-a64-neon --disable-arm-iwmmxt) \
$(gb_CONFIGURE_PLATFORMS) \
$(if $(CROSS_COMPILING),$(if $(filter INTEL 
ARM,$(CPUNAME)),ac_cv_c_bigendian=no)) \
-   $(if $(filter EMSCRIPTEN,$(OS)),CFLAGS="-pthread") \
+   $(if $(filter EMSCRIPTEN,$(OS)),CFLAGS="-O3 -pthread") \
&& $(MAKE) \
)
$(call gb_Trace_EndRange,pixman,EXTERNAL)


[Libreoffice-bugs] [Bug 153149] LibreOffice Writer and Calc buttons group is mixed in taskbar of Debian 11.6 KDE

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153149

--- Comment #2 from dragospac...@gmail.com ---
You mean there won't be a fix released? I am not sure on the LO 7.4.4.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Chart Colours: Bug or expected behaviour

2023-01-23 Thread Stéphane Guillou

On 23/1/23 23:33, Toki wrote:

All:

Before I file a bug-report, I want to know if this is due to my having 
a strange setup, or is the expected behaviour, or is a bug other 
people experience.


Image is at https://i.imgur.com/fJZuiF4.png

Version: 7.5.0.2 (X86_64) / LibreOffice Community
Build ID: c0dd1bc3f1a385d110b88e26ece634da94921f58
CPU threads: 4; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: en-ZA (en_NZ.UTF-8); UI: en-ZA
Calc: threaded

Look at the default colours at >Tools >Options >Charts >Default Colors.

Look at the colours in the bar chart.
(The bar chart has the colours this specific chart requires.)

I tried umpteen times to change the default colours for charts to the 
colours I use --- the colours in the bar chart.


Is >Tools >Options >Charts >Default Colors no longer functional?

jonathon




Hi Toki

You are right, changing the default colours in the Options dialog is not 
persistent anymore. It's a regression as LO 6.1 saves them properly. (I 
tested on Ubuntu 20.04)


Can you please report the bug on Bugzilla? I couldn't find an existing 
report.


Thank you!

--
Stéphane Guillou
Quality Assurance Analyst | The Document Foundation

Email: stephane.guil...@libreoffice.org
Mobile (France): +33 7 79 67 18 72
Matrix: @stragu:matrix.org
Fediverse: @str...@mastodon.indie.host
Web: https://stragu.gitlab.io/



[Libreoffice-bugs] [Bug 152649] Crash with activated SKIA Option

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152649

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

Version|7.3.0.3 release |7.4.4.2 release

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149527] Calc crashes when scroll up and down quickly within a document, or hold Page Down (Skia/Vulkan)

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149527

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=15 |
   |2649|
 CC||so...@web.de

--- Comment #29 from Stéphane Guillou (stragu) 
 ---
*** Bug 152649 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152649] Crash with activated SKIA Option

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152649

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Resolution|WORKSFORME  |DUPLICATE
   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=14 |
   |9527|

--- Comment #14 from Stéphane Guillou (stragu) 
 ---
Thank you for reporting back, Viktor.

Crash happened with Skia/Vulkan while scrolling in Calc, and comment 13 shows
that it doesn't crash anymore with Skia/Raster, so I'm calling this a duplicate
of bug 149527.

Version 7.3.0.3 was never mentioned so setting back to the one we are sure of,
7.4.4.1

*** This bug has been marked as a duplicate of bug 149527 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

Chart Colours: Bug or expected behaviour

2023-01-23 Thread Toki

All:

Before I file a bug-report, I want to know if this is due to my having a 
strange setup, or is the expected behaviour, or is a bug other people 
experience.


Image is at https://i.imgur.com/fJZuiF4.png

Version: 7.5.0.2 (X86_64) / LibreOffice Community
Build ID: c0dd1bc3f1a385d110b88e26ece634da94921f58
CPU threads: 4; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: en-ZA (en_NZ.UTF-8); UI: en-ZA
Calc: threaded

Look at the default colours at >Tools >Options >Charts >Default Colors.

Look at the colours in the bar chart.
(The bar chart has the colours this specific chart requires.)

I tried umpteen times to change the default colours for charts to the 
colours I use --- the colours in the bar chart.


Is >Tools >Options >Charts >Default Colors no longer functional?

jonathon





[Libreoffice-bugs] [Bug 153170] LibreOffice 7.4 can not programmatically delete paragraph breaks created by ENTER key.

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153170

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||stephane.guillou@libreoffic
   ||e.org
 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |NOTABUG
   Keywords|difficultyInteresting   |

--- Comment #1 from Stéphane Guillou (stragu) 
 ---
A paragraph break can be matched with a the regular expression "$" (no quotes).
Go to the Find and Replace tool, tick "Regular expressions", search for "$" and
replace with e.g. " ". That should work.

Tested with

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: cd20a17ab703e97191b4e3421527267ef82a704f
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

as well as 

Version: 7.4.4.2 / LibreOffice Community
Build ID: 85569322deea74ec9134968a29af2df5663baa21
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: desktop/source

2023-01-23 Thread Henry Castro (via logerrit)
 desktop/source/lib/init.cxx |   14 ++
 1 file changed, 14 insertions(+)

New commits:
commit 7a6324ea0d81bbe2bba09f8a7f5230342a4f4e85
Author: Henry Castro 
AuthorDate: Fri Nov 4 14:00:26 2022 -0400
Commit: Andras Timar 
CommitDate: Mon Jan 23 21:47:29 2023 +

lok: ensure to initialize the security context

if the backend NSS is used, before load the document
ensure the NSS is initialized otherwise NSS next functions
calls will fail.

Signed-off-by: Henry Castro 
Change-Id: I7ac1d7681995e6c284e2dd4595a33d044af4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142213
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Aron Budea 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142289
Tested-by: Jenkins
Reviewed-by: Andras Timar 

diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index bdc4b1869ded..8e98e675bb79 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -3404,6 +3404,20 @@ static void doc_iniUnoCommands ()
 return;
 }
 
+uno::Reference xSEInitializer = 
xml::crypto::SEInitializer::create(xContext);
+if (!xSEInitializer.is())
+{
+SAL_WARN("lok", "iniUnoCommands: XSEInitializer is not available");
+return;
+}
+
+uno::Reference xSecurityContext =
+xSEInitializer->createSecurityContext(OUString());
+if (!xSecurityContext.is())
+{
+SAL_WARN("lok", "iniUnoCommands: failed to create security context");
+}
+
 SfxSlotPool& rSlotPool = SfxSlotPool::GetSlotPool(pViewFrame);
 uno::Reference 
xParser(util::URLTransformer::create(xContext));
 


[Libreoffice-bugs] [Bug 153171] suggestion: add option to add x number of rows/columns in the menu

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153171

maximus...@yahoo.com changed:

   What|Removed |Added

Summary|suggestion: add option to   |suggestion: add option to
   |add x number of lines below |add x number of
   |and above in the menu   |rows/columns in the menu

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153171] New: suggestion: add option to add x number of lines below and above in the menu

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153171

Bug ID: 153171
   Summary: suggestion: add option to add x number of lines below
and above in the menu
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: maximus...@yahoo.com

the option to add single lines is also available in the context menu on the row
label

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152054] SDK SimpleBootstrap_cpp.cxx stuck in cppu_threadpool::JobQueue::enter() with factory/swriter

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152054

Dieter  changed:

   What|Removed |Added

 Resolution|FIXED   |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144656] Load-Property AsTemplate='True' shows dialog if document is write protected

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=144656

Adolfo Jayme Barrientos  changed:

   What|Removed |Added

 Resolution|FIXED   |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 61558] High CPU load when scrolling a document with many comments

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=61558

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||5641

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 125641] Slow scrolling responsiveness after saving a file with lots of comments

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125641

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||stephane.guillou@libreoffic
   ||e.org
 Status|NEW |NEEDINFO
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=61
   ||558

--- Comment #6 from Stéphane Guillou (stragu) 
 ---
I also get a huge slowdown and lag with the example file in OOo 3.3.
Telesto, any reason why this shouldn't be a duplicate of bug 61558?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147608] Memory usage runs away when Skia is used

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147608

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||stephane.guillou@libreoffic
   ||e.org

--- Comment #7 from Stéphane Guillou (stragu) 
 ---
Stuart, would you say the part about scrolling in Calc is a duplicate of bug
149527?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 153168] Please remove the "finished" dialog after restoring Documents

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153168

--- Comment #2 from amanita+libreoff...@mailbox.org ---
Hi, yes I mean that button.

The reason sounds legit and I think the solution would fit perfectly.

But isnt there a different button shown anyway, if the restore failed?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-commits] core.git: svx/uiconfig

2023-01-23 Thread Adolfo Jayme Barrientos (via logerrit)
 svx/uiconfig/ui/imapdialog.ui |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 66291d467be4bf0e841814111d57d1af76117f8e
Author: Adolfo Jayme Barrientos 
AuthorDate: Mon Jan 23 12:15:50 2023 -0600
Commit: Adolfo Jayme Barrientos 
CommitDate: Mon Jan 23 20:46:20 2023 +

tdf#153167 ImageMap Editor dialog had no title

Change-Id: I90048520d250d086b7b0ef4af675c9e1bcff93f4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146039
Tested-by: Adolfo Jayme Barrientos 
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/svx/uiconfig/ui/imapdialog.ui b/svx/uiconfig/ui/imapdialog.ui
index faea4d096736..4ebb2c078e49 100644
--- a/svx/uiconfig/ui/imapdialog.ui
+++ b/svx/uiconfig/ui/imapdialog.ui
@@ -5,6 +5,7 @@
   
 False
 6
+ImageMap Editor
 0
 0
 dialog


[Libreoffice-ux-advise] [Bug 153168] Please remove the "finished" dialog after restoring Documents

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153168

Rafael Lima  changed:

   What|Removed |Added

   Keywords||needsUXEval
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 153168] Please remove the "finished" dialog after restoring Documents

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153168

Rafael Lima  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
   Assignee|libreoffice-b...@lists.free |rafael.palma.l...@gmail.com
   |desktop.org |
 CC||rafael.palma.l...@gmail.com
 Ever confirmed|0   |1

--- Comment #1 from Rafael Lima  ---
Created attachment 184856
  --> https://bugs.documentfoundation.org/attachment.cgi?id=184856=edit
Screenshot of the recovery dialog ("Finish" button)

Hi, thanks for reporting!

Do you mean the "Finish" button in this dialog?

Just to see if I understood correctly, after the user clicks "Recover Selected"
you'd like the next screen to simply be skipped, right?

I believe the reason this "Finish" button exists is to allow the user to see
the recovery status of all files. Maybe we could change the behavior a bit, so
that if all files were recovered successfully, then the "Finish" state is
skipped.

-- 
You are receiving this mail because:
You are the assignee for the bug.

  1   2   3   4   >