[Libreoffice-commits] core.git: sd/source
sd/source/ui/accessibility/AccessibleSlideSorterView.cxx | 21 +++
sd/source/ui/inc/AccessibleSlideSorterView.hxx | 10 ---
2 files changed, 17 insertions(+), 14 deletions(-)
New commits:
commit 4cd6cba3edcba6497220924acc6716ea6027e559
Author: Noel Grandin
AuthorDate: Fri Mar 3 08:45:45 2023 +0200
Commit: Noel Grandin
CommitDate: Fri Mar 3 07:58:05 2023 +
Revert "BaseMutex->std::mutex in AccessibleSlideSorterView"
This reverts commit 64c19da4c924c45df037c075ef88d1f01a5abbe9, which
is causing deadlock when loading
https://bugs.documentfoundation.org/attachment.cgi?id=180272
in gtk3
Change-Id: I346fa576cbbb7355e65483ff5aba1f67cf21469a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148156
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sd/source/ui/accessibility/AccessibleSlideSorterView.cxx
b/sd/source/ui/accessibility/AccessibleSlideSorterView.cxx
index ae9a45ea73f4..4c197a71279a 100644
--- a/sd/source/ui/accessibility/AccessibleSlideSorterView.cxx
+++ b/sd/source/ui/accessibility/AccessibleSlideSorterView.cxx
@@ -113,7 +113,8 @@ private:
AccessibleSlideSorterView::AccessibleSlideSorterView(
::sd::slidesorter::SlideSorter& rSlideSorter,
vcl::Window* pContentWindow)
-: mrSlideSorter(rSlideSorter),
+: AccessibleSlideSorterViewBase(m_aMutex),
+ mrSlideSorter(rSlideSorter),
mnClientId(0),
mpContentWindow(pContentWindow)
{
@@ -147,7 +148,7 @@ void AccessibleSlideSorterView::FireAccessibleEvent (
}
}
-void AccessibleSlideSorterView::disposing(std::unique_lock&
/*rGuard*/)
+void SAL_CALL AccessibleSlideSorterView::disposing()
{
if (mnClientId != 0)
{
@@ -161,7 +162,7 @@ AccessibleSlideSorterObject*
AccessibleSlideSorterView::GetAccessibleChildImplem
sal_Int32 nIndex)
{
AccessibleSlideSorterObject* pResult = nullptr;
-std::unique_lock aGuard (m_aMutex);
+::osl::MutexGuard aGuard (m_aMutex);
if (nIndex>=0 && nIndexGetVisibleChildCount())
pResult = mpImpl->GetVisibleChild(nIndex);
@@ -171,7 +172,7 @@ AccessibleSlideSorterObject*
AccessibleSlideSorterView::GetAccessibleChildImplem
void AccessibleSlideSorterView::Destroyed()
{
-std::unique_lock aGuard (m_aMutex);
+::osl::MutexGuard aGuard (m_aMutex);
// Send a disposing to all listeners.
if (mnClientId != 0)
@@ -195,7 +196,7 @@ Reference SAL_CALL
sal_Int64 SAL_CALL AccessibleSlideSorterView::getAccessibleChildCount()
{
ThrowIfDisposed();
-std::unique_lock aGuard (m_aMutex);
+::osl::MutexGuard aGuard (m_aMutex);
return mpImpl->GetVisibleChildCount();
}
@@ -203,7 +204,7 @@ Reference SAL_CALL
AccessibleSlideSorterView::getAccessibleChild (sal_Int64 nIndex)
{
ThrowIfDisposed();
-std::unique_lock aGuard (m_aMutex);
+::osl::MutexGuard aGuard (m_aMutex);
if (nIndex<0 || nIndex>=mpImpl->GetVisibleChildCount())
throw lang::IndexOutOfBoundsException();
@@ -322,9 +323,9 @@ void SAL_CALL
AccessibleSlideSorterView::addAccessibleEventListener(
if (!rxListener.is())
return;
-std::unique_lock aGuard(m_aMutex);
+const osl::MutexGuard aGuard(m_aMutex);
-if (m_bDisposed)
+if (rBHelper.bDisposed || rBHelper.bInDispose)
{
uno::Reference x (static_cast(this), uno::UNO_QUERY);
rxListener->disposing (lang::EventObject (x));
@@ -344,7 +345,7 @@ void SAL_CALL
AccessibleSlideSorterView::removeAccessibleEventListener(
if (!rxListener.is())
return;
-std::unique_lock aGuard(m_aMutex);
+const osl::MutexGuard aGuard(m_aMutex);
if (mnClientId == 0)
return;
@@ -622,7 +623,7 @@ uno::Sequence< OUString> SAL_CALL
void AccessibleSlideSorterView::ThrowIfDisposed()
{
-if (m_bDisposed)
+if (rBHelper.bDisposed || rBHelper.bInDispose)
{
SAL_WARN("sd", "Calling disposed object. Throwing exception:");
throw lang::DisposedException ("object has been already disposed",
diff --git a/sd/source/ui/inc/AccessibleSlideSorterView.hxx
b/sd/source/ui/inc/AccessibleSlideSorterView.hxx
index 66bcc8b5ced0..0cbaf62ed586 100644
--- a/sd/source/ui/inc/AccessibleSlideSorterView.hxx
+++ b/sd/source/ui/inc/AccessibleSlideSorterView.hxx
@@ -19,7 +19,8 @@
#pragma once
-#include
+#include
+#include
#include
#include
#include
@@ -37,7 +38,7 @@ namespace accessibility {
class AccessibleSlideSorterObject;
-typedef ::comphelper::WeakComponentImplHelper<
+typedef ::cppu::WeakComponentImplHelper<
css::accessibility::XAccessible,
css::accessibility::XAccessibleEventBroadcaster,
css::accessibility::XAccessibleContext,
@@ -51,7 +52,8 @@ typedef ::comphelper::WeakComponentImplHelper<
accessible.
*/
class AccessibleSlideSorterView
-: public AccessibleSlideSorterViewBase
+: public cppu::BaseMutex,
+ public AccessibleSlideSorterViewBase
{
public:
[Libreoffice-commits] core.git: sw/source
sw/source/filter/html/css1atr.cxx| 628 +++---
sw/source/filter/html/htmlatr.cxx| 742 +++
sw/source/filter/html/htmldrawwriter.cxx | 14
sw/source/filter/html/htmlfldw.cxx | 47 -
sw/source/filter/html/htmlflywriter.cxx | 374 +++
sw/source/filter/html/htmlforw.cxx | 47 -
sw/source/filter/html/htmlftn.cxx| 41 -
sw/source/filter/html/htmlnumwriter.cxx |4
sw/source/filter/html/htmlplug.cxx | 92 +--
sw/source/filter/html/htmltabw.cxx | 109 ++--
sw/source/filter/html/wrthtml.cxx| 32 -
sw/source/filter/html/wrthtml.hxx| 46 -
sw/source/filter/inc/wrt_fn.hxx |7
sw/source/filter/writer/wrt_fn.cxx |4
14 files changed, 1028 insertions(+), 1159 deletions(-)
New commits:
commit 60d9e89f5a18b437016cead0c5fb688d202bc90e
Author: Noel Grandin
AuthorDate: Fri Mar 3 08:36:05 2023 +0200
Commit: Noel Grandin
CommitDate: Fri Mar 3 07:57:48 2023 +
reduce casting in writer html export filter
Change-Id: I8e690eea423a60a5009376a222d18ac214c77bc1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148154
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sw/source/filter/html/css1atr.cxx
b/sw/source/filter/html/css1atr.cxx
index fe922c884ce5..99fffb76d6b3 100644
--- a/sw/source/filter/html/css1atr.cxx
+++ b/sw/source/filter/html/css1atr.cxx
@@ -119,44 +119,44 @@ namespace o3tl {
#define DOT_LEADERS_MAX_WIDTH 18
-static Writer& OutCSS1_SwFormat( Writer& rWrt, const SwFormat& rFormat,
+static SwHTMLWriter& OutCSS1_SwFormat( SwHTMLWriter& rWrt, const SwFormat&
rFormat,
IDocumentStylePoolAccess /*SwDoc*/ *pDoc, SwDoc
*pTemplate );
-static Writer& OutCSS1_SwPageDesc( Writer& rWrt, const SwPageDesc& rFormat,
+static SwHTMLWriter& OutCSS1_SwPageDesc( SwHTMLWriter& rWrt, const SwPageDesc&
rFormat,
IDocumentStylePoolAccess /*SwDoc*/ *pDoc,
SwDoc *pTemplate,
sal_uInt16 nRefPoolId, bool bExtRef,
bool bPseudo=true );
-static Writer& OutCSS1_SwFootnoteInfo( Writer& rWrt, const SwEndNoteInfo&
rInfo,
+static SwHTMLWriter& OutCSS1_SwFootnoteInfo( SwHTMLWriter& rWrt, const
SwEndNoteInfo& rInfo,
SwDoc *pDoc, bool bHasNotes, bool bEndNote );
static void OutCSS1_SwFormatDropAttrs( SwHTMLWriter& rHWrt,
const SwFormatDrop& rDrop,
const SfxItemSet
*pCharFormatItemSet=nullptr );
-static Writer& OutCSS1_SvxTextLn_SvxCrOut_SvxBlink( Writer& rWrt,
+static SwHTMLWriter& OutCSS1_SvxTextLn_SvxCrOut_SvxBlink( SwHTMLWriter& rWrt,
const SvxUnderlineItem *pUItem,
const SvxOverlineItem *pOItem,
const SvxCrossedOutItem *pCOItem,
const SvxBlinkItem *pBItem );
-static Writer& OutCSS1_SvxFontWeight( Writer& rWrt, const SfxPoolItem& rHt );
-static Writer& OutCSS1_SvxPosture( Writer& rWrt, const SfxPoolItem& rHt );
-static Writer& OutCSS1_SvxULSpace( Writer& rWrt, const SfxPoolItem& rHt );
-static Writer& OutCSS1_SvxFirstLineIndent(Writer& rWrt, const SfxPoolItem&
rHt);
-static Writer& OutCSS1_SvxTextLeftMargin(Writer& rWrt, const SfxPoolItem& rHt);
-static Writer& OutCSS1_SvxRightMargin(Writer& rWrt, const SfxPoolItem& rHt);
-static Writer& OutCSS1_SvxLRSpace( Writer& rWrt, const SfxPoolItem& rHt );
-static Writer& OutCSS1_SvxULSpace_SvxLRSpace( Writer& rWrt,
+static SwHTMLWriter& OutCSS1_SvxFontWeight( SwHTMLWriter& rWrt, const
SfxPoolItem& rHt );
+static SwHTMLWriter& OutCSS1_SvxPosture( SwHTMLWriter& rWrt, const
SfxPoolItem& rHt );
+static SwHTMLWriter& OutCSS1_SvxULSpace( SwHTMLWriter& rWrt, const
SfxPoolItem& rHt );
+static SwHTMLWriter& OutCSS1_SvxFirstLineIndent(SwHTMLWriter& rWrt, const
SfxPoolItem& rHt);
+static SwHTMLWriter& OutCSS1_SvxTextLeftMargin(SwHTMLWriter& rWrt, const
SfxPoolItem& rHt);
+static SwHTMLWriter& OutCSS1_SvxRightMargin(SwHTMLWriter& rWrt, const
SfxPoolItem& rHt);
+static SwHTMLWriter& OutCSS1_SvxLRSpace( SwHTMLWriter& rWrt, const
SfxPoolItem& rHt );
+static SwHTMLWriter& OutCSS1_SvxULSpace_SvxLRSpace( SwHTMLWriter& rWrt,
const SvxULSpaceItem *pULSpace,
const SvxLRSpaceItem *pLRSpace );
-static Writer& OutCSS1_SvxULSpace_SvxLRSpace( Writer& rWrt,
+static SwHTMLWriter& OutCSS1_SvxULSpace_SvxLRSpace( SwHTMLWriter& rWrt,
const SfxItemSet& rItemSet );
-static Writer& OutCSS1_SvxBrush( Writer& rWrt, const SfxPoolItem& rHt,
+static SwHTMLWriter& OutCSS1_SvxBrush( SwHTMLWriter& rWrt, const SfxPoolItem&
rHt,
sw::Css1Background nMode,
const OUString *pGraphicName );
-static
Re: sc: test failure depending on order of execution
Hi Xisco, On Thu, Mar 02, 2023 at 09:31:24AM +0100, Xisco Fauli wrote: > Yes, you were right. There is a static counter that increments the chart > export file names so it failed to find 'xl/charts/chart1.xml' because it was > exported as 'xl/charts/chart2.xml' > > Markus already added a mechanism to workaround this to the tests in chart2/ > in 5f7861e6ce212f47420533aed302fa4b5510557d "fix chart export tests > correctly". > > https://gerrit.libreoffice.org/c/core/+/148065 should fix it in the general > case. Hmm, it feels like this is an improvement, but the root cause is why we have a static counter for charts in the first place. Do you know where is that counter? At least resetting that counter similar to how it's done in oox/ DrawingML::ResetMlCounters() would be good, and then you don't need tricks on the testing side. Regards, Miklos
[Libreoffice-commits] core.git: sw/inc sw/source
sw/inc/swtable.hxx |7
sw/source/core/doc/DocumentFieldsManager.cxx | 12 +-
sw/source/core/doc/docsort.cxx |5 --
sw/source/core/doc/tblcpy.cxx| 17 +
sw/source/core/doc/tblrwcl.cxx | 14 +---
sw/source/core/docnode/ndtbl.cxx |4 --
sw/source/core/edit/edtab.cxx|5 --
sw/source/core/table/swtable.cxx | 47 +++
sw/source/core/undo/rolbck.cxx | 21 ++--
sw/source/core/undo/untbl.cxx| 11 +++---
10 files changed, 82 insertions(+), 61 deletions(-)
New commits:
commit b9716112219469fa4e0af33a6edb7eec0ff33026
Author: Bjoern Michaelsen
AuthorDate: Wed Mar 1 23:15:47 2023 +0100
Commit: Bjoern Michaelsen
CommitDate: Fri Mar 3 07:55:45 2023 +
Refactor TBL_{REL,}BOXNAME to SwTable
- because those only modify the fields of that one table
- also add lots of const_cast unfortunately, but not because it makes
things worse:
* this was modifying the table before (thus non-const)
* at least now this is a bit more explicit
Change-Id: I0174daecabcc6de9b7c9867b24c94659c0dbcafe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148080
Tested-by: Jenkins
Reviewed-by: Noel Grandin
Reviewed-by: Bjoern Michaelsen
diff --git a/sw/inc/swtable.hxx b/sw/inc/swtable.hxx
index 3858c55217be..ee63cf1972e0 100644
--- a/sw/inc/swtable.hxx
+++ b/sw/inc/swtable.hxx
@@ -174,6 +174,8 @@ private:
void NewSetTabCols( Parm , const SwTabCols , const SwTabCols ,
const SwTableBox *pStart, bool bCurRowOnly );
void ConvertSubtableBox(sal_uInt16 const nRow, sal_uInt16 const nBox);
+// Only used for TBL_BOXNAME and TBL_RELBOXNAME for now
+void UpdateFields(TableFormulaUpdateFlags eFlags);
public:
@@ -357,6 +359,11 @@ public:
// it doesn't contain box content (except single empty nested tables of
the boxes
// which could remain after deletion of text content of the selected table)
bool IsEmpty() const;
+void SwitchFormulasToExternalRepresentation()
+{ UpdateFields(TBL_BOXNAME); };
+void SwitchFormulasToRelativeRepresentation()
+{ UpdateFields(TBL_RELBOXNAME); };
+
void dumpAsXml(xmlTextWriterPtr pWriter) const;
};
diff --git a/sw/source/core/doc/DocumentFieldsManager.cxx
b/sw/source/core/doc/DocumentFieldsManager.cxx
index 62ed40812160..3ccbbfe00ca4 100644
--- a/sw/source/core/doc/DocumentFieldsManager.cxx
+++ b/sw/source/core/doc/DocumentFieldsManager.cxx
@@ -632,23 +632,15 @@ void DocumentFieldsManager::UpdateTableFields(
SfxPoolItem* pHt )
else
pField->ChgValid( false );
break;
-case TBL_BOXNAME:
-// is this the wanted table?
-if( >GetTable() == pUpdateField->m_pTable )
-// to the external representation
-pField->PtrToBoxNm( pUpdateField->m_pTable );
-break;
case TBL_BOXPTR:
// to the internal representation
// JP 17.06.96: internal representation on all formulas
// (reference to other table!!!)
pField->BoxNmToPtr( >GetTable() );
break;
+case TBL_BOXNAME:
case TBL_RELBOXNAME:
-// is this the wanted table?
-if( >GetTable() == pUpdateField->m_pTable )
-// to the relative representation
-pField->ToRelBoxNm( pUpdateField->m_pTable );
+assert(false); // use SwTable::SwitchTo...
break;
default:
break;
diff --git a/sw/source/core/doc/docsort.cxx b/sw/source/core/doc/docsort.cxx
index f4693871c3e3..3601c119bbb3 100644
--- a/sw/source/core/doc/docsort.cxx
+++ b/sw/source/core/doc/docsort.cxx
@@ -506,10 +506,7 @@ bool SwDoc::SortTable(const SwSelBoxes& rBoxes, const
SwSortOptions& rOpt)
nStart = 0;
}
-// Switch to relative Formulas
-SwTableFormulaUpdate aMsgHint( >GetTable() );
-aMsgHint.m_eFlags = TBL_RELBOXNAME;
-getIDocumentFieldsAccess().UpdateTableFields( );
+pTableNd->GetTable().SwitchFormulasToRelativeRepresentation();
// Table as a flat array structure
FlatFndBox aFlatBox(this, aFndBox);
diff --git a/sw/source/core/doc/tblcpy.cxx b/sw/source/core/doc/tblcpy.cxx
index 0343c9c35b27..c39d9c387a3c 100644
--- a/sw/source/core/doc/tblcpy.cxx
+++ b/sw/source/core/doc/tblcpy.cxx
@@ -673,10 +673,7 @@ bool SwTable::InsNewTable( const SwTable& rCpyTable, const
SwSelBoxes& rSelBoxes
aTarget.assignBoxes( aCopyStruct );
{
-// Change table formulas into relative representation
-
[Libreoffice-bugs] [Bug 153534] Most bundled page styles are nonsensical and/or redundant
https://bugs.documentfoundation.org/show_bug.cgi?id=153534 --- Comment #29 from Klim --- (In reply to David from comment #28) > I think what you're looking for would be done by setting the page layout in > the Default Page Style or another style to be mirrored. > I'm not sure what's meant by "specify the order of the next style." > Specifying a new page style is best done through the use of a heading. > This would be done by using a heading on the following page to insert a page > break before the heading. > This would be done by setting the title paragraph to automatically insert a > page break. The next page style to be used can also be specified. Yes you are right. I made a bad advise. however, I consider the 'next style' field to be a dirty hack. it does a side effect and looks like a code smell. in such a case, I don't think we should display the next style in the styles list, but we could put an appropriate icon in front of the style name in list to indicate that the next style field has changed. maybe. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 100155] [META] Improve object selection and alignment
https://bugs.documentfoundation.org/show_bug.cgi?id=100155 Heiko Tietze changed: What|Removed |Added Depends on||145112 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=145112 [Bug 145112] Add option to distribute relative to the slide/page -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 145112] Add option to distribute relative to the slide/page
https://bugs.documentfoundation.org/show_bug.cgi?id=145112 Heiko Tietze changed: What|Removed |Added Ever confirmed|0 |1 Blocks||100155 Status|UNCONFIRMED |NEW CC|libreoffice-ux-advise@lists |andreas.heini...@yahoo.de, |.freedesktop.org|heiko.tietze@documentfounda ||tion.org Summary|Formatting distribution |Add option to distribute |relative to page|relative to the slide/page Keywords|needsUXEval | --- Comment #7 from Heiko Tietze --- The feature is a toggle of (o) Align Selected Objects vs. ( ) Align to Slide. With the second option, the slide edges are taken into account and align to bottom, for example, moves the objects to the slide bottom instead of the lowest object. The distribution options are enabled even with a single object and the slide edges are added to the calculation. For example, a single object will be "distributed" to the slide center. The feature somewhat clashes with the snap lines from bug 125107. I could imagine a third radio button option. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=100155 [Bug 100155] [META] Improve object selection and alignment -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 145112] Add option to distribute relative to the slide/page
https://bugs.documentfoundation.org/show_bug.cgi?id=145112 Heiko Tietze changed: What|Removed |Added Ever confirmed|0 |1 Blocks||100155 Status|UNCONFIRMED |NEW CC|libreoffice-ux-advise@lists |andreas.heini...@yahoo.de, |.freedesktop.org|heiko.tietze@documentfounda ||tion.org Summary|Formatting distribution |Add option to distribute |relative to page|relative to the slide/page Keywords|needsUXEval | --- Comment #7 from Heiko Tietze --- The feature is a toggle of (o) Align Selected Objects vs. ( ) Align to Slide. With the second option, the slide edges are taken into account and align to bottom, for example, moves the objects to the slide bottom instead of the lowest object. The distribution options are enabled even with a single object and the slide edges are added to the calculation. For example, a single object will be "distributed" to the slide center. The feature somewhat clashes with the snap lines from bug 125107. I could imagine a third radio button option. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=100155 [Bug 100155] [META] Improve object selection and alignment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - 4 commits - sw/qa sw/source writerfilter/source
sw/qa/core/layout/data/floattable-3pages.docx |binary
sw/qa/core/layout/flycnt.cxx | 67 +++
sw/qa/filter/ww8/ww8.cxx | 39 ++
sw/source/core/layout/anchoredobject.cxx | 20 -
sw/source/core/layout/flycnt.cxx | 17
sw/source/core/layout/tabfrm.cxx |8
sw/source/core/objectpositioning/tocntntanchoredobjectposition.cxx | 23 -
sw/source/core/text/frmform.cxx|8
sw/source/core/text/itratr.cxx | 15
sw/source/core/text/txtfrm.cxx |7
sw/source/filter/ww8/docxattributeoutput.cxx | 171
+-
writerfilter/source/dmapper/DomainMapperTableHandler.cxx | 28 +
12 files changed, 305 insertions(+), 98 deletions(-)
New commits:
commit 58e70891131a99d4eb38b362bb2d4246c7a67cb6
Author: Miklos Vajna
AuthorDate: Wed Feb 22 08:11:00 2023 +0100
Commit: Miklos Vajna
CommitDate: Fri Mar 3 08:45:03 2023 +0100
sw floatable: teach the DOCX filter about SwFormatFlySplit
- stop creating a grab-bag for floating tables in the DOCX import if
split flys are allowed, which gives the exporter an opportunity to
actually read the doc model
- extract that code that writes a from a ww8::Frame to a new
CollectFloatingTableAttributes()
- in case a fly frame has a table and the fly has SwFormatFlySplit=true,
then call CollectFloatingTableAttributes() even without grab-bags
- in the unlikely case that we would have both a split fly and a
grab-bag, ignore the grab-bag
With this, we get a working DOCX export for multi-page floating tables.
The import is still disabled by default.
(cherry picked from commit e7be3b821cd42fdc9d8e51772b8202030d76497e)
Change-Id: I601833c49f49f94e1ff3cdc994e3027ee0542b94
diff --git a/sw/qa/filter/ww8/ww8.cxx b/sw/qa/filter/ww8/ww8.cxx
index 611d63259ae8..8eac94ae36d0 100644
--- a/sw/qa/filter/ww8/ww8.cxx
+++ b/sw/qa/filter/ww8/ww8.cxx
@@ -15,6 +15,10 @@
#include
#include
#include
+#include
+#include
+#include
+#include
namespace
{
@@ -189,6 +193,41 @@ CPPUNIT_TEST_FIXTURE(Test, testDocxSymbolFontExport)
assertXPath(pXmlDoc, "//w:p/w:r/w:sym[1]", "font", "Wingdings");
assertXPath(pXmlDoc, "//w:p/w:r/w:sym[1]", "char", "f0e0");
}
+
+CPPUNIT_TEST_FIXTURE(Test, testDocxFloatingTableExport)
+{
+// Given a document with a floating table:
+createSwDoc();
+SwDoc* pDoc = getSwDoc();
+SwWrtShell* pWrtShell = pDoc->GetDocShell()->GetWrtShell();
+// Insert a table:
+SwInsertTableOptions aTableOptions(SwInsertTableFlags::DefaultBorder, 0);
+pWrtShell->InsertTable(aTableOptions, 1, 1);
+pWrtShell->MoveTable(GotoPrevTable, fnTableStart);
+// Select it:
+pWrtShell->SelAll();
+// Wrap in a fly:
+SwFlyFrameAttrMgr aMgr(true, pWrtShell, Frmmgr_Type::TEXT, nullptr);
+pWrtShell->StartAllAction();
+aMgr.InsertFlyFrame(RndStdIds::FLY_AT_PARA, aMgr.GetPos(), aMgr.GetSize());
+// Mark it as a floating table:
+SwFrameFormats& rFlys = *pDoc->GetSpzFrameFormats();
+SwFrameFormat* pFly = rFlys[0];
+SwAttrSet aSet(pFly->GetAttrSet());
+aSet.Put(SwFormatFlySplit(true));
+pDoc->SetAttr(aSet, *pFly);
+pWrtShell->EndAllAction();
+
+// When saving to docx:
+save("Office Open XML Text");
+
+// Then make sure we write a floating table, not a textframe containing a
table:
+xmlDocUniquePtr pXmlDoc = parseExport("word/document.xml");
+// Without the accompanying fix in place, this test would have failed with:
+// - XPath '//w:tbl/w:tblPr/w:tblpPr' number of nodes is incorrect
+// i.e. no floating table was exported.
+assertXPath(pXmlDoc, "//w:tbl/w:tblPr/w:tblpPr", 1);
+}
}
CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/sw/source/filter/ww8/docxattributeoutput.cxx
b/sw/source/filter/ww8/docxattributeoutput.cxx
index 11a35b8bd55e..f1485b5814f4 100644
--- a/sw/source/filter/ww8/docxattributeoutput.cxx
+++ b/sw/source/filter/ww8/docxattributeoutput.cxx
@@ -137,6 +137,7 @@
#include
#include
#include
+#include
#include
#include
@@ -409,7 +410,14 @@ static void
checkAndWriteFloatingTables(DocxAttributeOutput& rDocxAttributeOutpu
std::map aTableGrabBag =
pTableGrabBag->GetGrabBag();
// no grabbag?
if (aTableGrabBag.find("TablePosition") == aTableGrabBag.end())
+{
+if (pFrameFormat->GetFlySplit().GetValue())
+{
+ww8::Frame aFrame(*pFrameFormat, *rAnchor.GetContentAnchor());
+rDocxAttributeOutput.WriteFloatingTable();
+}
continue;
+}
// write table to docx
ww8::Frame aFrame(*pFrameFormat,
[Libreoffice-bugs] [Bug 137883] Confusing terminology for DOCX save (Transitional versus Word 2007-365)
https://bugs.documentfoundation.org/show_bug.cgi?id=137883
--- Comment #16 from Tex2002ans ---
Michael + Olivier, just a small typo in the latest patches.
Accidentally used a HYPHEN instead of an EN DASH:
- Word 2010-365 Document
- Word 2010–365 Document
1st one is current.
2nd one is correct + will match the other Word filetypes in the dropdown ("Word
97–2003").
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 153334] Support/default to a non-white page background in Dark Mode
https://bugs.documentfoundation.org/show_bug.cgi?id=153334 Heiko Tietze changed: What|Removed |Added CC|libreoffice-ux-advise@lists | |.freedesktop.org| -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-ux-advise] [Bug 153933] bg color for area fill of cell and dialog fields for negative find results against calc cells -- #ff6d6d is a bit harsh
https://bugs.documentfoundation.org/show_bug.cgi?id=153933 Heiko Tietze changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC|heiko.tietze@documentfounda | |tion.org| Ever confirmed|0 |1 --- Comment #2 from Heiko Tietze --- Please share a screenshot, Jim. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 153933] bg color for area fill of cell and dialog fields for negative find results against calc cells -- #ff6d6d is a bit harsh
https://bugs.documentfoundation.org/show_bug.cgi?id=153933 Heiko Tietze changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC|heiko.tietze@documentfounda | |tion.org| Ever confirmed|0 |1 --- Comment #2 from Heiko Tietze --- Please share a screenshot, Jim. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153567] Default Envelope template size "A10" formatting prints & displays addresses incorrectly in Writer. Possible other size envelopes could be effected.
https://bugs.documentfoundation.org/show_bug.cgi?id=153567 --- Comment #5 from Ritchie --- Created attachment 185716 --> https://bugs.documentfoundation.org/attachment.cgi?id=185716=edit Correct Formatting for "A10" Envelope This is how the Default "A10" envelope should like. So it will print correctly. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 84973] "Date (fix)" fields must not update on copy
https://bugs.documentfoundation.org/show_bug.cgi?id=84973 --- Comment #22 from Heiko Tietze --- (In reply to Rainer Bielefeld Retired from comment #21) > This probably is "Bug 152871 - Editing Date/Time fields... My first patch failed and resulted in this bug asking to be reverted. However, with a little help the default of Date var/fix was inverted finally for bug 139141. This ticket is about copying the fix date variable. Comment 10: "When you open as copy, the original document with fixed fields is used as a *template* for the new copy; and it's normal and expected that *for templates*, the fixed fields are updated (that is one of the reasons to use the fixed fields instead of inserting plain text)." -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153567] Default Envelope template size "A10" formatting prints & displays addresses incorrectly in Writer. Possible other size envelopes could be effected.
https://bugs.documentfoundation.org/show_bug.cgi?id=153567 --- Comment #4 from Ritchie --- Created attachment 185715 --> https://bugs.documentfoundation.org/attachment.cgi?id=185715=edit 2nd Screenshot This second screenshot showing when I press [INSERT] button to insert the "A10" envelope into the document, the formatting of the envelope inserted "on the canvas" document windows is wrong/off/incorrect for the "A10" envelope. If I printed the envelope it would not print correctly on the actual envelope -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153567] Default Envelope template size "A10" formatting prints & displays addresses incorrectly in Writer. Possible other size envelopes could be effected.
https://bugs.documentfoundation.org/show_bug.cgi?id=153567 --- Comment #3 from Ritchie --- Created attachment 185714 --> https://bugs.documentfoundation.org/attachment.cgi?id=185714=edit 2 Screenshots as requested 1 screenshot showing that Writer's Default Formatting for the "A10" size in the [envelope dialog window] is correct (WIDTH 9.5" X HEIGHT 4.13) But when inserted into a writer document, the formatting is wrong on canvas therefore printing on the envelope incorrectly. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153803] Dropdown borders are not consistent in dark mode (kf5-only)
https://bugs.documentfoundation.org/show_bug.cgi?id=153803 Michael Weghorn changed: What|Removed |Added CC||m.wegh...@posteo.de Status|UNCONFIRMED |ASSIGNED Ever confirmed|0 |1 Assignee|libreoffice-b...@lists.free |m.wegh...@posteo.de |desktop.org | --- Comment #2 from Michael Weghorn --- Confirmed. Suggested Gerrit change: https://gerrit.libreoffice.org/c/core/+/148160 -- You are receiving this mail because: You are the assignee for the bug.
Gokulakrishnan Shankar: licence statement
Greetings! I hereby declare my license statement: "All of my past and future contributions to LibreOffice may be licensed under the MPLv2/LGPLv3+ dual license." (Ref: https://gerrit.libreoffice.org/c/core/+/147145/comments/42de2915_f9202748)
[Libreoffice-commits] core.git: Branch 'distro/vector/vector-7.0' - sw/qa
sw/qa/extras/htmlexport/htmlexport.cxx | 16
1 file changed, 8 insertions(+), 8 deletions(-)
New commits:
commit aa634cb115ec4efb61017aae6699744666a7c31f
Author: Mike Kaganski
AuthorDate: Fri Mar 3 09:45:16 2023 +0300
Commit: Mike Kaganski
CommitDate: Fri Mar 3 06:46:41 2023 +
tdf#153923: modify the unit test for the 7.0 branch
Test the ReqIF here.
Change-Id: Ief6703546398aa63812512f85a3185e5aceb405e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148155
Tested-by: Mike Kaganski
Reviewed-by: Mike Kaganski
diff --git a/sw/qa/extras/htmlexport/htmlexport.cxx
b/sw/qa/extras/htmlexport/htmlexport.cxx
index 1326fbb48dc5..b6cc08282287 100644
--- a/sw/qa/extras/htmlexport/htmlexport.cxx
+++ b/sw/qa/extras/htmlexport/htmlexport.cxx
@@ -2328,22 +2328,22 @@ CPPUNIT_TEST_FIXTURE(SwHtmlDomExportTest,
testSectionDir)
assertXPath(pXmlDoc, "//reqif-xhtml:div[@id='mysect']", "style", "dir:
ltr");
}
-CPPUNIT_TEST_FIXTURE(HtmlExportTest, testTdf153923)
+CPPUNIT_TEST_FIXTURE(SwHtmlDomExportTest, testTdf153923)
{
OUString aURL = m_directories.getURLFromSrc(DATA_DIRECTORY) +
"TableWithIndent.fodt";
mxComponent = loadFromDesktop(aURL, "com.sun.star.text.TextDocument", {});
-uno::Reference xStorable(mxComponent,
uno::UNO_QUERY_THROW);
-uno::Sequence aStoreProperties = {
-comphelper::makePropertyValue("FilterName", OUString("HTML
(StarWriter)"))
-};
-xStorable->storeToURL(maTempFile.GetURL(), aStoreProperties);
-htmlDocUniquePtr pDoc = parseHtml(maTempFile);
+// When exporting to (reqif-)xhtml:
+ExportToReqif();
+
+SvMemoryStream aStream;
+WrapReqifFromTempFile(aStream);
+xmlDocUniquePtr pDoc = parseXmlStream();
// Without the fix in place, this would fail
CPPUNIT_ASSERT(pDoc);
// The 'dd' tag was not closed
-assertXPath(pDoc, "/html/body//dd");
+assertXPath(pDoc, "//reqif-xhtml:dd");
}
CPPUNIT_PLUGIN_IMPLEMENT();
[Libreoffice-bugs] [Bug 153567] Default Envelope template size "A10" formatting prints & displays addresses incorrectly in Writer. Possible other size envelopes could be effected.
https://bugs.documentfoundation.org/show_bug.cgi?id=153567 Ritchie changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED --- Comment #2 from Ritchie --- OS Name Microsoft Windows 10 Pro Version 10.0.19044 Build 19044 LibreOffice Version 7.4.5.1 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153588] Writer and Calc 7.5.0.3 are very slow on INTEL (MacOS 11.7.3)
https://bugs.documentfoundation.org/show_bug.cgi?id=153588 Sciuriware changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153588] Writer and Calc 7.5.0.3 are very slow on INTEL (MacOS 11.7.3)
https://bugs.documentfoundation.org/show_bug.cgi?id=153588 --- Comment #1 from Sciuriware --- Release 7.5.1.2 (just installed) seems NOT to have this problem. The start-up and print delays are acceptable now. ;JOOP! -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/vector/vector-7.0' - sw/qa sw/source
sw/qa/extras/htmlexport/data/TableWithIndent.fodt | 22 ++
sw/qa/extras/htmlexport/htmlexport.cxx| 18 ++
sw/source/filter/html/htmltabw.cxx| 10 ++
3 files changed, 50 insertions(+)
New commits:
commit 2561cb3f97f9c58051a609873de6af175e529b42
Author: Mike Kaganski
AuthorDate: Thu Mar 2 16:15:16 2023 +0300
Commit: Mike Kaganski
CommitDate: Fri Mar 3 06:17:17 2023 +
tdf#153923: close 'dd' tag properly
Change-Id: I4ae3b23c616fc2ea40a5fdf8640bf5db0bb371ae
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148122
Tested-by: Jenkins
Reviewed-by: Noel Grandin
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148153
Tested-by: Mike Kaganski
Reviewed-by: Mike Kaganski
diff --git a/sw/qa/extras/htmlexport/data/TableWithIndent.fodt
b/sw/qa/extras/htmlexport/data/TableWithIndent.fodt
new file mode 100644
index ..5daaa75e8e24
--- /dev/null
+++ b/sw/qa/extras/htmlexport/data/TableWithIndent.fodt
@@ -0,0 +1,22 @@
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
\ No newline at end of file
diff --git a/sw/qa/extras/htmlexport/htmlexport.cxx
b/sw/qa/extras/htmlexport/htmlexport.cxx
index 19e40fb1c256..1326fbb48dc5 100644
--- a/sw/qa/extras/htmlexport/htmlexport.cxx
+++ b/sw/qa/extras/htmlexport/htmlexport.cxx
@@ -2328,6 +2328,24 @@ CPPUNIT_TEST_FIXTURE(SwHtmlDomExportTest, testSectionDir)
assertXPath(pXmlDoc, "//reqif-xhtml:div[@id='mysect']", "style", "dir:
ltr");
}
+CPPUNIT_TEST_FIXTURE(HtmlExportTest, testTdf153923)
+{
+OUString aURL = m_directories.getURLFromSrc(DATA_DIRECTORY) +
"TableWithIndent.fodt";
+mxComponent = loadFromDesktop(aURL, "com.sun.star.text.TextDocument", {});
+uno::Reference xStorable(mxComponent,
uno::UNO_QUERY_THROW);
+uno::Sequence aStoreProperties = {
+comphelper::makePropertyValue("FilterName", OUString("HTML
(StarWriter)"))
+};
+xStorable->storeToURL(maTempFile.GetURL(), aStoreProperties);
+
+htmlDocUniquePtr pDoc = parseHtml(maTempFile);
+// Without the fix in place, this would fail
+CPPUNIT_ASSERT(pDoc);
+
+// The 'dd' tag was not closed
+assertXPath(pDoc, "/html/body//dd");
+}
+
CPPUNIT_PLUGIN_IMPLEMENT();
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/filter/html/htmltabw.cxx
b/sw/source/filter/html/htmltabw.cxx
index 1150b72d5320..debf5d3d0e3a 100644
--- a/sw/source/filter/html/htmltabw.cxx
+++ b/sw/source/filter/html/htmltabw.cxx
@@ -1059,6 +1059,7 @@ Writer& OutHTML_SwTableNode( Writer& rWrt, SwTableNode &
rNode,
if( rHTMLWrt.m_bLFPossible )
rHTMLWrt.OutNewLine();
HTMLOutFuncs::Out_AsciiTag( rWrt.Strm(), rHTMLWrt.GetNamespace() +
OOO_STRING_SVTOOLS_HTML_dd );
+rHTMLWrt.IncIndentLevel();
}
// eFlyHoriOri and eTabHoriOri now only contain the values of
@@ -1185,6 +1186,15 @@ Writer& OutHTML_SwTableNode( Writer& rWrt, SwTableNode &
rNode,
// move Pam behind the table
rHTMLWrt.m_pCurrentPam->GetPoint()->nNode = *rNode.EndOfSectionNode();
+if (nNewDefListLvl)
+{
+rHTMLWrt.DecIndentLevel();
+if (rHTMLWrt.m_bLFPossible)
+rHTMLWrt.OutNewLine();
+// close the dd element
+HTMLOutFuncs::Out_AsciiTag(rWrt.Strm(), rHTMLWrt.GetNamespace() +
OOO_STRING_SVTOOLS_HTML_dd, false);
+}
+
if( bPreserveForm )
{
rHTMLWrt.m_bPreserveForm = false;
[Libreoffice-bugs] [Bug 135546] Pictures lost if cut and pasted (into Writer) from MacOS Notes
https://bugs.documentfoundation.org/show_bug.cgi?id=135546 PD Andrew changed: What|Removed |Added CC||pdandre...@gmail.com --- Comment #3 from PD Andrew --- Same thing happens with LibreOffice Writer document, copying and pasting into an email. None of the pictures are included. -- You are receiving this mail because: You are the assignee for the bug.
Arvind K license statement
All of my past and future contributions to LibreOffice may be licensed under the MPLv2/LGPLv3+ dual license.
Arvind K license statement
All of my past and future contributions to LibreOffice may be licensed under the MPLv2/LGLPLv3+ dual license.
[Libreoffice-commits] core.git: sw/source
sw/source/filter/ww8/wrtww8.hxx |1 - 1 file changed, 1 deletion(-) New commits: commit 5d7687c62a7f8d60267ce45ad27befc7d6567c24 Author: Andrea Gelmini AuthorDate: Thu Mar 2 20:26:59 2023 +0100 Commit: Julien Nabet CommitDate: Fri Mar 3 06:00:02 2023 + Remove duplicated include Change-Id: I89652d205efa508f2f9ccd2c449d4c54fa8b325a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148140 Reviewed-by: Julien Nabet Tested-by: Jenkins diff --git a/sw/source/filter/ww8/wrtww8.hxx b/sw/source/filter/ww8/wrtww8.hxx index cc1438e9d056..671dc7455b64 100644 --- a/sw/source/filter/ww8/wrtww8.hxx +++ b/sw/source/filter/ww8/wrtww8.hxx @@ -49,7 +49,6 @@ #include #include #include -#include #include #include
[Libreoffice-bugs] [Bug 153654] Problem with template shortcut
https://bugs.documentfoundation.org/show_bug.cgi?id=153654 Dieter changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 CC||dgp-m...@gmx.de --- Comment #1 from Dieter --- Edward, thank you for reporting the bug. Could you please the steps as follows: 1. Create a new template 2 3 => NEEDINFO -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - sc/source
sc/source/core/inc/interpre.hxx | 12 +
sc/source/core/tool/interpr1.cxx | 237 ---
2 files changed, 137 insertions(+), 112 deletions(-)
New commits:
commit 92b9499876dc42cae127df1a90881bfe25eed4e6
Author: Eike Rathke
AuthorDate: Fri Feb 17 12:03:54 2023 +0100
Commit: Andras Timar
CommitDate: Fri Mar 3 05:54:36 2023 +
Stack check safety belt before fishing in muddy waters
Have it hit hard in debug builds.
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147205
Reviewed-by: Eike Rathke
Tested-by: Jenkins
(cherry picked from commit 9d91fbba6f374fa1c10b38eae003da89bd4e6d4b)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147245
Reviewed-by: Caolán McNamara
(cherry picked from commit 166a07062dd4ffedca6106f439a6fcddaeee5eb5)
Change-Id: I9ea54844a0661fd7a75616a2876983a74b2d5bad
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147929
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Andras Timar
diff --git a/sc/source/core/inc/interpre.hxx b/sc/source/core/inc/interpre.hxx
index 3b902524d901..c7d4527dbf57 100644
--- a/sc/source/core/inc/interpre.hxx
+++ b/sc/source/core/inc/interpre.hxx
@@ -235,6 +235,7 @@ private:
inline bool MustHaveParamCount( short nAct, short nMust );
inline bool MustHaveParamCount( short nAct, short nMust, short nMax );
inline bool MustHaveParamCountMin( short nAct, short nMin );
+inline bool MustHaveParamCountMinWithStackCheck( short nAct, short nMin );
void PushParameterExpected();
void PushIllegalParameter();
void PushIllegalArgument();
@@ -1086,6 +1087,17 @@ inline bool ScInterpreter::MustHaveParamCountMin( short
nAct, short nMin )
return false;
}
+inline bool ScInterpreter::MustHaveParamCountMinWithStackCheck( short nAct,
short nMin )
+{
+assert(sp >= nAct);
+if (sp < nAct)
+{
+PushParameterExpected();
+return false;
+}
+return MustHaveParamCountMin( nAct, nMin);
+}
+
inline bool ScInterpreter::CheckStringPositionArgument( double & fVal )
{
if (!rtl::math::isFinite( fVal))
diff --git a/sc/source/core/tool/interpr1.cxx b/sc/source/core/tool/interpr1.cxx
index 0f37b4f9f35e..9e5754878848 100644
--- a/sc/source/core/tool/interpr1.cxx
+++ b/sc/source/core/tool/interpr1.cxx
@@ -7524,131 +7524,144 @@ void ScInterpreter::ScVLookup()
void ScInterpreter::ScSubTotal()
{
sal_uInt8 nParamCount = GetByte();
-if ( MustHaveParamCountMin( nParamCount, 2 ) )
+if ( !MustHaveParamCountMinWithStackCheck( nParamCount, 2 ) )
+return;
+
+// We must fish the 1st parameter deep from the stack! And push it on top.
+const FormulaToken* p = pStack[ sp - nParamCount ];
+PushWithoutError( *p );
+sal_Int32 nFunc = GetInt32();
+mnSubTotalFlags |= SubtotalFlags::IgnoreNestedStAg |
SubtotalFlags::IgnoreFiltered;
+if (nFunc > 100)
{
-// We must fish the 1st parameter deep from the stack! And push it on
top.
-const FormulaToken* p = pStack[ sp - nParamCount ];
-PushWithoutError( *p );
-sal_Int32 nFunc = GetInt32();
-mnSubTotalFlags |= SubtotalFlags::IgnoreNestedStAg |
SubtotalFlags::IgnoreFiltered;
-if (nFunc > 100)
-{
-// For opcodes 101 through 111, we need to skip hidden cells.
-// Other than that these opcodes are identical to 1 through 11.
-mnSubTotalFlags |= SubtotalFlags::IgnoreHidden;
-nFunc -= 100;
-}
+// For opcodes 101 through 111, we need to skip hidden cells.
+// Other than that these opcodes are identical to 1 through 11.
+mnSubTotalFlags |= SubtotalFlags::IgnoreHidden;
+nFunc -= 100;
+}
-if ( nGlobalError != FormulaError::NONE || nFunc < 1 || nFunc > 11 )
-PushIllegalArgument(); // simulate return on stack, not
SetError(...)
-else
+if ( nGlobalError != FormulaError::NONE || nFunc < 1 || nFunc > 11 )
+PushIllegalArgument(); // simulate return on stack, not SetError(...)
+else
+{
+cPar = nParamCount - 1;
+switch( nFunc )
{
-cPar = nParamCount - 1;
-switch( nFunc )
-{
-case SUBTOTAL_FUNC_AVE : ScAverage(); break;
-case SUBTOTAL_FUNC_CNT : ScCount(); break;
-case SUBTOTAL_FUNC_CNT2 : ScCount2(); break;
-case SUBTOTAL_FUNC_MAX : ScMax(); break;
-case SUBTOTAL_FUNC_MIN : ScMin(); break;
-case SUBTOTAL_FUNC_PROD : ScProduct(); break;
-case SUBTOTAL_FUNC_STD : ScStDev(); break;
-case SUBTOTAL_FUNC_STDP : ScStDevP(); break;
-case SUBTOTAL_FUNC_SUM : ScSum(); break;
-case SUBTOTAL_FUNC_VAR : ScVar(); break;
-case SUBTOTAL_FUNC_VARP : ScVarP();break;
-default :
[Libreoffice-bugs] [Bug 84973] "Date (fix)" fields must not update on copy
https://bugs.documentfoundation.org/show_bug.cgi?id=84973 --- Comment #21 from Rainer Bielefeld Retired --- (In reply to Rainer Bielefeld Retired from comment #20) But Version: 7.5.0.0.alpha0+ ... This probably is "Bug 152871 - Editing Date/Time fields have an inverted fixed/variable order", has nothing to do with Bug 84973 So I thin we can close this one. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148143] CRASH: after pasting twice the whole sheet
https://bugs.documentfoundation.org/show_bug.cgi?id=148143 Kohei Yoshida changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |ko...@libreoffice.org |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148143] CRASH: after pasting twice the whole sheet
https://bugs.documentfoundation.org/show_bug.cgi?id=148143 --- Comment #15 from Kohei Yoshida --- It's probably caused by this: https://cgit.freedesktop.org/libreoffice/core/commit/?id=99cd1d8834bb708afc81c825ff2b7992b7acb37d Prior to that commit, ColumnSpanSet::ColumnType was stored wrapped inside std::unique_ptr as a dynamically allocated memory, so when the std::vector reallocated its internal buffer and copied the stored values it would just copy the pointer values, and the ColumnType objects were still valid. But since that commit, ColumnType is now stored wrapped inside std::optional which stores the object as part of the std::optional's memory footprint, not as a dynamically allocated memory. So, when the std::vector store reallocates its buffer it now invokes ColumnType's copy constructor which copies both maSpans and miPos. miPos is used as a position hint into flat_segment_tree (maSpans) which stores a pointer to a node. And after the copy construction, that pointer may point to a node object that may have been deleted, which would certainly cause an invalid memory access and the crash would follow... I have my local fix, and now I cannot reproduce the crash after repeating the paste 10+ times. No idea why your bisecting ended up pointing to my commit, but that one is unrelated as far as I can tell. It may have just made the underlying issue easier to surface. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153934] MILEX COMPLETE AUTO CARE
https://bugs.documentfoundation.org/show_bug.cgi?id=153934 MILEX COMPLETE AUTO CARE changed: What|Removed |Added URL||https://margatemrtmilex.com ||/diagnostic-services -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153934] New: MILEX COMPLETE AUTO CARE
https://bugs.documentfoundation.org/show_bug.cgi?id=153934 Bug ID: 153934 Summary: MILEX COMPLETE AUTO CARE Product: cppunit Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: General Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: margatemrtmi...@gmail.com CC: markus.mohrh...@googlemail.com Margatemrtmilex is an expert automobile maintenance company. Our goal is to offer expert mechanic services that are covered by a national warranty. Since each of our service centres is individually owned and run, you will receive the personalised attention from local service centres and guidance from a nationally recognized company. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153675] size of the reference citation, e.g. "full" size as text "hello [23]".
https://bugs.documentfoundation.org/show_bug.cgi?id=153675 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153666] master document navigator context menu / insert: section option is "missing"
https://bugs.documentfoundation.org/show_bug.cgi?id=153666 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153657] NVDA dose not read Fontwork style title
https://bugs.documentfoundation.org/show_bug.cgi?id=153657 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153663] Selecting Text Box Multi-line formatting in forms does not allow formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=153663 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153665] After Windows 11 sleeping Calc crashes, recover feature does not work
https://bugs.documentfoundation.org/show_bug.cgi?id=153665 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153662] sections in navigator context menu: "open linked document" (enhancement)
https://bugs.documentfoundation.org/show_bug.cgi?id=153662 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153654] Problem with template shortcut
https://bugs.documentfoundation.org/show_bug.cgi?id=153654 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153660] Single Undo should remove all diagonal borders created with Toolbar>Borders
https://bugs.documentfoundation.org/show_bug.cgi?id=153660 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153905] PDF files created with LibO print incorrectly to some printers
https://bugs.documentfoundation.org/show_bug.cgi?id=153905 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153905] PDF files created with LibO print incorrectly to some printers
https://bugs.documentfoundation.org/show_bug.cgi?id=153905 --- Comment #8 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153582] a5 printing is broken
https://bugs.documentfoundation.org/show_bug.cgi?id=153582 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153582] a5 printing is broken
https://bugs.documentfoundation.org/show_bug.cgi?id=153582 --- Comment #7 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147813] hiding text
https://bugs.documentfoundation.org/show_bug.cgi?id=147813 --- Comment #7 from QA Administrators --- Dear Kaitlyn, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152657] Slower graphical performance and laggy behavior on data entry with large window (GTK)
https://bugs.documentfoundation.org/show_bug.cgi?id=152657 --- Comment #19 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 77786] EDITING: When doing Find and Replace with formatting attributes, the Replace button changes the next item, not currently found item
https://bugs.documentfoundation.org/show_bug.cgi?id=77786 --- Comment #7 from QA Administrators --- Dear D. Browne, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 56612] EDITING - Base problem with boolean field that defaults to unintended value
https://bugs.documentfoundation.org/show_bug.cgi?id=56612 --- Comment #12 from QA Administrators --- Dear Emanuele Gissi, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 117818] CHAPTER NUMBERING DIALOG: Preview doesn't work as expected for Position (steps in comment 1)
https://bugs.documentfoundation.org/show_bug.cgi?id=117818 --- Comment #15 from QA Administrators --- Dear Nithin, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 116106] FORMATTING: LO Calc Date as Number lost in saving
https://bugs.documentfoundation.org/show_bug.cgi?id=116106 --- Comment #5 from QA Administrators --- Dear lambda.halbe, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 111742] Slide background: Pattern with custom color lost during ODP roundtrip
https://bugs.documentfoundation.org/show_bug.cgi?id=111742 --- Comment #9 from QA Administrators --- Dear Tamás Zolnai, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153922] memory leak in dedicated memory of graphics card (e.g. geforce gt1030)
https://bugs.documentfoundation.org/show_bug.cgi?id=153922 m.a.riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO --- Comment #2 from m.a.riosv --- Please attach a sample file with which to reproduce the problem. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153741] calc 7.4.5 EDITING keeps protected a sheet created by excel with password
https://bugs.documentfoundation.org/show_bug.cgi?id=153741 --- Comment #5 from m.a.riosv --- I can't reproduce with the attached file, with Version: 7.5.1.2 (X86_64) / LibreOffice Community Build ID: fcbaee479e84c6cd81291587d2ee68cba099e129 CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL threaded The sheet it's not protected, the same than Excel. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153561] Rename "Chapter -> Heading" and "E# -> H#" in Entries tab of Insert Table of Contents, Index, Bibliography dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=153561 --- Comment #21 from sdc.bla...@youmail.dk --- https://gerrit.libreoffice.org/c/core/+/148104 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 153933] bg color for area fill of cell and dialog fields for negative find results against calc cells -- #ff6d6d is a bit harsh
https://bugs.documentfoundation.org/show_bug.cgi?id=153933 V Stuart Foote changed: What|Removed |Added Summary|v7.5.3 bg color for area|bg color for area fill of |fill of cell and dialog |cell and dialog fields for |fields for negative find|negative find results |results against calc cells |against calc cells -- |-- #ff6d6d is a bit harsh |#ff6d6d is a bit harsh -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 153933] bg color for area fill of cell and dialog fields for negative find results against calc cells -- #ff6d6d is a bit harsh
https://bugs.documentfoundation.org/show_bug.cgi?id=153933 V Stuart Foote changed: What|Removed |Added Summary|v7.5.3 bg color for area|bg color for area fill of |fill of cell and dialog |cell and dialog fields for |fields for negative find|negative find results |results against calc cells |against calc cells -- |-- #ff6d6d is a bit harsh |#ff6d6d is a bit harsh -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 153933] v7.5.3 bg color for area fill of cell and dialog fields for negative find results against calc cells -- #ff6d6d is a bit harsh
https://bugs.documentfoundation.org/show_bug.cgi?id=153933 V Stuart Foote changed: What|Removed |Added Summary|v7.5.3 bg color for area|v7.5.3 bg color for area |fill of cell and dialog |fill of cell and dialog |fields for negative results |fields for negative find |against calc cells -- |results against calc cells |#ff6d6d is a bit harsh |-- #ff6d6d is a bit harsh -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 153933] v7.5.3 bg color for area fill of cell and dialog fields for negative find results against calc cells -- #ff6d6d is a bit harsh
https://bugs.documentfoundation.org/show_bug.cgi?id=153933 V Stuart Foote changed: What|Removed |Added Summary|v7.5.3 bg color for area|v7.5.3 bg color for area |fill of cell and dialog |fill of cell and dialog |fields for negative results |fields for negative find |against calc cells -- |results against calc cells |#ff6d6d is a bit harsh |-- #ff6d6d is a bit harsh -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153933] v7.5.3 bg color for area fill of cell and dialog fields for negative results against calc cells -- #ff6d6d is a bit harsh
https://bugs.documentfoundation.org/show_bug.cgi?id=153933 V Stuart Foote changed: What|Removed |Added Summary|v7.5.3 bg color for area|v7.5.3 bg color for area |fill of cell and dialog |fill of cell and dialog |fields for negative results |fields for negative results |against calc cells -- |against calc cells -- |#ff6b6b is a bit harsh |#ff6d6d is a bit harsh -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 153933] v7.5.3 bg color for area fill of cell and dialog fields for negative results against calc cells -- #ff6d6d is a bit harsh
https://bugs.documentfoundation.org/show_bug.cgi?id=153933 V Stuart Foote changed: What|Removed |Added Summary|v7.5.3 bg color for area|v7.5.3 bg color for area |fill of cell and dialog |fill of cell and dialog |fields for negative results |fields for negative results |against calc cells -- |against calc cells -- |#ff6b6b is a bit harsh |#ff6d6d is a bit harsh -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-ux-advise] [Bug 153933] v7.5.3 bg color for area fill of cell and dialog fields for negative results against calc cells -- #ff6b6b is a bit harsh
https://bugs.documentfoundation.org/show_bug.cgi?id=153933 V Stuart Foote changed: What|Removed |Added CC||heiko.tietze@documentfounda ||tion.org, ||libreoffice-ux-advise@lists ||.freedesktop.org, ||vsfo...@libreoffice.org Summary|v7.5.3 Search Key |v7.5.3 bg color for area |Text-Fieldhas horrid pink |fill of cell and dialog |background |fields for negative results ||against calc cells -- ||#ff6b6b is a bit harsh Version|7.3.0.3 release |7.5.0.3 release Keywords||needsUXEval --- Comment #1 from V Stuart Foote --- Hmm that is kind of a harsh, used for for bg for the search field when no results are found. But field also receives white fg text on the red. The color looks to be the "Light Red 2" or #ff6d6d found on standard.soc palette, I think. But I couldn't find it assigned via variable string. Affects both the Quickfind or the Find & Replace dialog not sure where it is assigned. System | Light | Dark has not effect and can't locate as an established Application Colors AC. @Heiko, can you find the assigned fg/bg colors for the Find bar and Find & Replace dialog handling used for Calc cells? Might need to take the bg a lighter red and the fg to a blue or a green for contrast both Light and Dark color themes. =-testing-= Version: 7.5.1.2 (X86_64) / LibreOffice Community Build ID: fcbaee479e84c6cd81291587d2ee68cba099e129 CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 102593] [META] Paste bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102593 Bug 102593 depends on bug 153669, which changed state. Bug 153669 Summary: Formula stops working after copy and paste onto a different cell https://bugs.documentfoundation.org/show_bug.cgi?id=153669 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153933] v7.5.3 bg color for area fill of cell and dialog fields for negative results against calc cells -- #ff6b6b is a bit harsh
https://bugs.documentfoundation.org/show_bug.cgi?id=153933 V Stuart Foote changed: What|Removed |Added CC||heiko.tietze@documentfounda ||tion.org, ||libreoffice-ux-advise@lists ||.freedesktop.org, ||vsfo...@libreoffice.org Summary|v7.5.3 Search Key |v7.5.3 bg color for area |Text-Fieldhas horrid pink |fill of cell and dialog |background |fields for negative results ||against calc cells -- ||#ff6b6b is a bit harsh Version|7.3.0.3 release |7.5.0.3 release Keywords||needsUXEval --- Comment #1 from V Stuart Foote --- Hmm that is kind of a harsh, used for for bg for the search field when no results are found. But field also receives white fg text on the red. The color looks to be the "Light Red 2" or #ff6d6d found on standard.soc palette, I think. But I couldn't find it assigned via variable string. Affects both the Quickfind or the Find & Replace dialog not sure where it is assigned. System | Light | Dark has not effect and can't locate as an established Application Colors AC. @Heiko, can you find the assigned fg/bg colors for the Find bar and Find & Replace dialog handling used for Calc cells? Might need to take the bg a lighter red and the fg to a blue or a green for contrast both Light and Dark color themes. =-testing-= Version: 7.5.1.2 (X86_64) / LibreOffice Community Build ID: fcbaee479e84c6cd81291587d2ee68cba099e129 CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153931] Spell check stops working in Writer & Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=153931 Stéphane Guillou (stragu) changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||stephane.guillou@libreoffic ||e.org Ever confirmed|0 |1 --- Comment #2 from Stéphane Guillou (stragu) --- Thank you for the report. Can you please install version 7.5.1 and see if it is fixed? Sounds like the already-fixed bug 152738. https://www.libreoffice.org/download/download-libreoffice/ -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153857] Writer hangs or crashes when right-clicking on form field
https://bugs.documentfoundation.org/show_bug.cgi?id=153857 Stéphane Guillou (stragu) changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||3926 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153926] FORMATTING: CRASH when trying to change language for selection
https://bugs.documentfoundation.org/show_bug.cgi?id=153926 Stéphane Guillou (stragu) changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||3857 Regression By||Noel Grandin Priority|medium |high Severity|normal |critical -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sc/inc sc/Library_sc.mk sc/qa sc/source
sc/Library_sc.mk |1
sc/inc/broadcast.hxx | 86 +++
sc/inc/calcmacros.hxx |4
sc/inc/column.hxx |3
sc/inc/document.hxx|7 -
sc/inc/grouparealistener.hxx |3
sc/inc/table.hxx |3
sc/qa/unit/ucalc_formula.cxx | 85 +--
sc/source/core/data/bcaslot.cxx| 59 -
sc/source/core/data/broadcast.cxx | 164 +
sc/source/core/data/column4.cxx| 31 ++
sc/source/core/data/document.cxx |8 -
sc/source/core/data/document10.cxx | 15 +++
sc/source/core/data/table7.cxx |6 +
sc/source/core/inc/bcaslot.hxx | 15 +--
15 files changed, 400 insertions(+), 90 deletions(-)
New commits:
commit 687b950702c49c90cff9a43655ea97a0343799a0
Author: Kohei Yoshida
AuthorDate: Tue Feb 21 22:16:30 2023 -0500
Commit: Kohei Yoshida
CommitDate: Thu Mar 2 23:35:56 2023 +
Add a means to query the internal broadcaster state ...
... and use it in one unit test case. Also, remove the code inside
DEBUG_AREA_BROADCASTER macro since it no longer builds & has been
superceded by this new state query method.
Change-Id: I38691a76df5c63034ff488522936dd566bf8b4e3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148079
Tested-by: Kohei Yoshida
Reviewed-by: Kohei Yoshida
diff --git a/sc/Library_sc.mk b/sc/Library_sc.mk
index 4d3c7398b43d..49c36cf27d3c 100644
--- a/sc/Library_sc.mk
+++ b/sc/Library_sc.mk
@@ -104,6 +104,7 @@ $(eval $(call gb_Library_add_exception_objects,sc,\
sc/source/core/data/attrib \
sc/source/core/data/autonamecache \
sc/source/core/data/bcaslot \
+sc/source/core/data/broadcast \
sc/source/core/data/bigrange \
sc/source/core/data/celltextattr \
sc/source/core/data/cellvalue \
diff --git a/sc/inc/broadcast.hxx b/sc/inc/broadcast.hxx
new file mode 100644
index ..b095f819acb7
--- /dev/null
+++ b/sc/inc/broadcast.hxx
@@ -0,0 +1,86 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#pragma once
+
+#include "address.hxx"
+
+#include
+#include
+#include
+
+class ScFormulaCell;
+class SvtListener;
+
+namespace sc
+{
+class FormulaGroupAreaListener;
+
+struct BroadcasterState
+{
+enum class CellListenerType
+{
+FormulaCell,
+Generic,
+};
+
+enum class AreaListenerType
+{
+FormulaCell,
+FormulaGroup,
+Generic,
+};
+
+struct CellListener
+{
+using DataType = std::variant;
+
+CellListenerType eType;
+DataType pData;
+
+CellListener(const ScFormulaCell* p);
+CellListener(const SvtListener* p);
+};
+
+struct AreaListener
+{
+using DataType = std::variant;
+
+AreaListenerType eType;
+DataType pData;
+
+AreaListener(const ScFormulaCell* p);
+AreaListener(const sc::FormulaGroupAreaListener* p);
+AreaListener(const SvtListener* p);
+};
+
+std::map> aCellListenerStore;
+std::map> aAreaListenerStore;
+
+/**
+ * Check if a formula cell listens on a single cell.
+ */
+bool hasFormulaCellListener(const ScAddress& rBroadcasterPos,
+const ScAddress& rFormulaPos) const;
+
+/**
+ * Check if a formula cell listens on a single range.
+ */
+bool hasFormulaCellListener(const ScRange& rBroadcasterRange,
+const ScAddress& rFormulaPos) const;
+
+/**
+ * Dump all broadcaster state in YAML format.
+ */
+void dump(std::ostream& rStrm, const ScDocument* pDoc = nullptr) const;
+};
+}
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sc/inc/calcmacros.hxx b/sc/inc/calcmacros.hxx
index c0c68d4487cf..ebe96654804a 100644
--- a/sc/inc/calcmacros.hxx
+++ b/sc/inc/calcmacros.hxx
@@ -12,7 +12,6 @@
#define DEBUG_COLUMN_STORAGE 0
#define DEBUG_PIVOT_TABLE 0
#define DEBUG_FORMULA_COMPILER 0
-#define DEBUG_AREA_BROADCASTER 0
#define DUMP_COLUMN_STORAGE 0
#define DUMP_PIVOT_TABLE 0
@@ -26,8 +25,7 @@
#if DUMP_PIVOT_TABLE || DEBUG_PIVOT_TABLE || \
DUMP_COLUMN_STORAGE || DEBUG_COLUMN_STORAGE || \
-DEBUG_FORMULA_COMPILER || \
-DEBUG_AREA_BROADCASTER
+DEBUG_FORMULA_COMPILER
#include
using std::cout;
using std::cerr;
diff --git a/sc/inc/column.hxx b/sc/inc/column.hxx
index 949ca30dd137..5c42f02794ab 100644
--- a/sc/inc/column.hxx
+++ b/sc/inc/column.hxx
@@ -42,6 +42,7 @@ namespace formula { struct VectorRefArray; }
namespace sc {
+struct BroadcasterState;
struct FormulaGroupEntry;
[Libreoffice-bugs] [Bug 153769] error playing animations and transitions in libreoffice impress
https://bugs.documentfoundation.org/show_bug.cgi?id=153769 Michael FA changed: What|Removed |Added Version|7.5.0.3 release |7.5.1.2 rc Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153769] error playing animations and transitions in libreoffice impress
https://bugs.documentfoundation.org/show_bug.cgi?id=153769 --- Comment #2 from Michael FA --- Created attachment 185712 --> https://bugs.documentfoundation.org/attachment.cgi?id=185712=edit test video, animations not playing well there are animations and transitions that do not play correctly in full screen and window mode, there are flickers, they take time, etc. You have to take these errors into account since animations and transitions are very important in impress -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153325] LO 7.5 Draw adjusting connector lines (middle line handles)
https://bugs.documentfoundation.org/show_bug.cgi?id=153325 Aron Budea changed: What|Removed |Added Version|7.5.0.3 release |6.2.0.3 release -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 116979] [META] Regression introduced by Aw080
https://bugs.documentfoundation.org/show_bug.cgi?id=116979 Aron Budea changed: What|Removed |Added Depends on||153325 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=153325 [Bug 153325] LO 7.5 Draw adjusting connector lines (middle line handles) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153325] LO 7.5 Draw adjusting connector lines (middle line handles)
https://bugs.documentfoundation.org/show_bug.cgi?id=153325 Aron Budea changed: What|Removed |Added CC||aron.bu...@gmail.com Blocks||116979 --- Comment #10 from Aron Budea --- (In reply to raal from comment #8) > source 726d7e7b8b50dca9914329dbfd9491f7c8961f68 > source a28a839b9f9eeec1544c5ceeeabe7b1083ce1655 > source 4b4942224b550235da228655677b5c068a053254 This is a regression from the oldest commit in the list, as it's been backported to 6.1, and bibisecting there uniquely identifies the backport: https://cgit.freedesktop.org/libreoffice/core/commit/?id=4b4942224b550235da228655677b5c068a053254 author Armin Le Grand 2018-04-16 22:34:50 +0200 committer Armin Le Grand 2018-05-25 12:31:32 +0200 SOSAW080: Derive SdrObjGroup from SdrObjList Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=116979 [Bug 116979] [META] Regression introduced by Aw080 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148747] Bad use of the date in formulas
https://bugs.documentfoundation.org/show_bug.cgi?id=148747
--- Comment #35 from JPT ---
(In reply to ady from comment #34)
> (In reply to JPT from comment #33)
> > In version 7.4.5.1 (probably from version 7.2.6 and above), ".M." works
> > on that same statement.
>
> But that is not the current content of "Calculation.D1:O1" (after pasting
> the needed values from the other worksheet), is it?
No. I have to change the original "MM." to ".M." to make it work like
in 7.1.8.1
>
> When I review "Calculation.ods" and review the cell format (ctrl+1):
>
> Calculation.D1: General
> Calculation.E1: 0
> Calculation.F1: #,##0.00;[RED]-#,##0.00
I didn't even know that was the case. I didn't care what the format was when
everything worked the way I wanted it to.
>
> and the content of these cells start with an apostrophe (').
I don't have the apostrophe there either in version 7.1.8.1 or 7.4.5.1. But to
tell the truth, sometimes it happens to me that I have apostrophes in foreign
documents, I think most often in the dates. I already have a macro saved for
deleting the apostrophe.
>
> Under those conditions, and with the values of Statements.xls copied to the
> Statement worksheet in Calculation.ods, then the results in the Calculation
> worksheet are all zeroes for me (LO 7.4.5).
>
> Now, if I go to D1 and I type in "01.2022" (without quotation marks) over
> the previous "'01.2022" (which includes an apostrophe), then I do get
> non-zero values in the same column.
I have zeros there (in versions higher than 7.1.8.1) but I have nothing to
delete (apostrophe). Neither overwriting nor deleting and rewriting works.
Still zeros.
> but perhaps there is some locale factor too(?).
I'll add that at first I thought I had set something in the settings and it
changed from a certain version after reinstalling, but I installed a fresh
installation of version 7.4.5.1 in a virtual PC, so it probably won't be that.
It will probably be a locale setting. I can try to install English in
LibreOffice and see what it does there.
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152262] Template Name Has Dark Text on Dark
https://bugs.documentfoundation.org/show_bug.cgi?id=152262 --- Comment #5 from Sierk Bornemann --- Created attachment 185711 --> https://bugs.documentfoundation.org/attachment.cgi?id=185711=edit LibreOffice 7.5.1.2 PreferencePane menu tree LibreOffice 7.5.1.2 PreferencePane menu tree (white/light menu tree in dark mode on dark background) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152262] Template Name Has Dark Text on Dark
https://bugs.documentfoundation.org/show_bug.cgi?id=152262 --- Comment #4 from Sierk Bornemann --- Created attachment 185710 --> https://bugs.documentfoundation.org/attachment.cgi?id=185710=edit LibreOffice 7.6.0.0.alpha0+ PreferencePane menu tree Is this a regression (menu tree black rather than white in dark mode)? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153933] New: v7.5.3 Search Key Text-Fieldhas horrid pink background
https://bugs.documentfoundation.org/show_bug.cgi?id=153933 Bug ID: 153933 Summary: v7.5.3 Search Key Text-Fieldhas horrid pink background Product: LibreOffice Version: 7.3.0.3 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jim_a...@hotmail.com Description: In 7.5.x version the background of the textField is populated with a VERY annoying "pink" background that canNOT be dimmed nor can it be eliminated/changed. The prior versions highlighted the words "Search key not found" red to notify that the key did not match. That was adequate. The alteration of this notification is way overboard and EXTREMELY distracting! Please make it go away! OR; allow me to choose a nonDISTRACTING color; or allow me to dim the "pink" since I am not sight impaired! I can click the red-circle-white-X to make the pink go away; however, I feel that I should not have to take this seemingly unnecessary action each and every unFound key! Give me an option to: 1) (preferred) change it back to the red words "Search key not found"; 2) pick a nonDistracting color; 3) allow the background to be dimmed! 2) & 3) if implemented should be a, "one, the other, or both choice! Steps to Reproduce: 1.pick something that is a Search Key that cannot be found 2.Press enter 3.the "PINK" background appears some times after a "flash" a pink-draw across the textField; sometimes an annoying blinky-draw of pink ... . This is reproducible on six (6) other win10 platforms accessible by me with this LibreOffice update version! Actual Results: The background goes pink and stays that way until a search key is entered that is found or one takes the time to click the red-circle with the white-X Expected Results: the undesirable PINK in the background of the search texField Reproducible: Always User Profile Reset: Yes Additional Info: [Information automatically included from LibreOffice] Locale: en-US Module: SpreadsheetDocument [Information guessed from browser] OS: Windows (All) OS is 64bit: no leave the search textField background default and change ONLY the search key in the textField so it is noticeable but NOT distracting. Allow me to select the color of the lettering, optionally the background if changed, and the brightness. No place to enter the Help-About LibreOffice so I shall insert it here: Version: 7.5.0.3 (X86_64) / LibreOffice Community Build ID: c21113d003cd3efa8c53188764377a8272d9d6de CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153582] a5 printing is broken
https://bugs.documentfoundation.org/show_bug.cgi?id=153582 --- Comment #6 from mattreecebent...@gmail.com --- The client's printer was a Epson ET-2850. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118000] [META] Remote desktop related bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=118000 Bug 118000 depends on bug 40559, which changed state. Bug 40559 Summary: Ugly dithered symbol background in rdp/ica sessions https://bugs.documentfoundation.org/show_bug.cgi?id=40559 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 40559] Ugly dithered symbol background in rdp/ica sessions
https://bugs.documentfoundation.org/show_bug.cgi?id=40559 Heiko changed: What|Removed |Added Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #18 from Heiko --- Not sure since which Version, but the problem does not exist any more. Currently running LibreOffice 7.4.5 on Windows Server 2019/Citrix. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153334] Support/default to a non-white page background in Dark Mode
https://bugs.documentfoundation.org/show_bug.cgi?id=153334 --- Comment #19 from Sierk Bornemann --- *moved from bug#152184 comment 15* FYI, just for info, maybe it might help to orientate and maybe follow the same way, because it's not bad and has proved its worth: Microsoft Support document: Dark Mode in Word – Word for Microsoft 365, Word for Microsoft 365 for Mac, Word 2021 https://support.microsoft.com/en-us/office/dark-mode-in-word-e17b79a3-762f-4280-a81c-a15a859a693a#ID0EDD=MacOS Incl. what and how to change the settings to change/adjust the defaults. Sidenote (see screenshots and text in the document): for example, among other things: the default page background in dark mode is: a _dark_ page background, not a white one per default. Dark Mode in Word offers a dark color scheme for both the menu controls and the document background. Dark Mode can help to reduce eye strain and also provides a more modern feel to Word. The dark page background does not convey how your document will print, or the default view your collaborators will see when they open it. … Turn on Dark Mode To turn on Dark Mode in the Word, you need to enable Dark Mode for Mac OS. 1. Go to Settings > General 2. In the Appearance options, select Dark [Screenshot] Alternatively, you can select Auto, which will switch between Light and Dark modes based on your specified Night Shift schedule in MacOS. [Screenshot] 3. To turn off Dark Mode, go to Word > Preferences > General > Personalize and select Turn off Dark Mode [Screenshot] inclusive this section: Personalize ● Turn off Dark Mode ○ Dark mode has a dark page color ○ Dark mode has a white page color … Set the page background color Once Dark Mode has been turned on, you can toggle between the dark and light page background colors. 1. In the ribbon, go to the View tab. 2. Select Switch Modes to change the page background color. Word will remember the state of this toggle for future Dark Mode sessions. [Screenshot] Disable the dark page background You can disable the dark page background in Dark Mode and keep the page light. Go to Word > Preferences > General > Personalize. Select Dark Mode has a white page color. [Screenshot] Check the appearance Regardless of your Dark Mode settings, your document will print with the light mode page color. Also, your Dark Mode settings do not impact your collaborators, and Word will respect individual view preferences. To preview your document for printing and sharing, use the Switch Modes button to change the page background to light. … -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 153334] Support/default to a non-white page background in Dark Mode
https://bugs.documentfoundation.org/show_bug.cgi?id=153334 --- Comment #19 from Sierk Bornemann --- *moved from bug#152184 comment 15* FYI, just for info, maybe it might help to orientate and maybe follow the same way, because it's not bad and has proved its worth: Microsoft Support document: Dark Mode in Word – Word for Microsoft 365, Word for Microsoft 365 for Mac, Word 2021 https://support.microsoft.com/en-us/office/dark-mode-in-word-e17b79a3-762f-4280-a81c-a15a859a693a#ID0EDD=MacOS Incl. what and how to change the settings to change/adjust the defaults. Sidenote (see screenshots and text in the document): for example, among other things: the default page background in dark mode is: a _dark_ page background, not a white one per default. Dark Mode in Word offers a dark color scheme for both the menu controls and the document background. Dark Mode can help to reduce eye strain and also provides a more modern feel to Word. The dark page background does not convey how your document will print, or the default view your collaborators will see when they open it. … Turn on Dark Mode To turn on Dark Mode in the Word, you need to enable Dark Mode for Mac OS. 1. Go to Settings > General 2. In the Appearance options, select Dark [Screenshot] Alternatively, you can select Auto, which will switch between Light and Dark modes based on your specified Night Shift schedule in MacOS. [Screenshot] 3. To turn off Dark Mode, go to Word > Preferences > General > Personalize and select Turn off Dark Mode [Screenshot] inclusive this section: Personalize ● Turn off Dark Mode ○ Dark mode has a dark page color ○ Dark mode has a white page color … Set the page background color Once Dark Mode has been turned on, you can toggle between the dark and light page background colors. 1. In the ribbon, go to the View tab. 2. Select Switch Modes to change the page background color. Word will remember the state of this toggle for future Dark Mode sessions. [Screenshot] Disable the dark page background You can disable the dark page background in Dark Mode and keep the page light. Go to Word > Preferences > General > Personalize. Select Dark Mode has a white page color. [Screenshot] Check the appearance Regardless of your Dark Mode settings, your document will print with the light mode page color. Also, your Dark Mode settings do not impact your collaborators, and Word will respect individual view preferences. To preview your document for printing and sharing, use the Switch Modes button to change the page background to light. … -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 153554] Crash when closing LibreOffice opened via SDK
https://bugs.documentfoundation.org/show_bug.cgi?id=153554 --- Comment #9 from Hossein --- Tested with another Windows 10 instance, and the same problem was there. Here is the console output: $ instdir/program/python HelloTextTableShape.py warn:io.connector:5396:9860:io/source/connector/connector.cxx:93: Connector : couldn't connect to pipe "uno2882509348717913": 1 warn:io.connector:5396:9860:io/source/connector/connector.cxx:93: Connector : couldn't connect to pipe "uno2882509348717913": 1 warn:io.connector:5396:9860:io/source/connector/connector.cxx:93: Connector : couldn't connect to pipe "uno2882509348717913": 1 warn:io.connector:5396:9860:io/source/connector/connector.cxx:93: Connector : couldn't connect to pipe "uno2882509348717913": 1 warn:io.connector:5396:9860:io/source/connector/connector.cxx:93: Connector : couldn't connect to pipe "uno2882509348717913": 1 warn:io.connector:5396:9860:io/source/connector/connector.cxx:93: Connector : couldn't connect to pipe "uno2882509348717913": 1 Connected to a running office ... 153 warn:io.connector:5396:9860:io/source/connector/connector.cxx:93: Connector : couldn't connect to pipe "uno5734024485250353": 1 warn:io.connector:5396:9860:io/source/connector/connector.cxx:93: Connector : couldn't connect to pipe "uno5734024485250353": 1 warn:binaryurp:5396:9860:binaryurp/source/bridge.cxx:845: undisposed bridge "" in state 2, potential deadlock ahead Connected to a running office ... 153 warn:io.connector:5396:9860:io/source/connector/connector.cxx:93: Connector : couldn't connect to pipe "uno06361373529997805": 1 warn:io.connector:5396:9860:io/source/connector/connector.cxx:93: Connector : couldn't connect to pipe "uno06361373529997805": 1 warn:binaryurp:5396:9860:binaryurp/source/bridge.cxx:845: undisposed bridge "" in state 2, potential deadlock ahead Connected to a running office ... Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: e34074feeb1b918ab9f26a18c5fdb0b1f2e35f94 CPU threads: 32; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: en-US (en_DE); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153741] calc 7.4.5 EDITING keeps protected a sheet created by excel with password
https://bugs.documentfoundation.org/show_bug.cgi?id=153741 --- Comment #4 from chris64 --- Created attachment 185709 --> https://bugs.documentfoundation.org/attachment.cgi?id=185709=edit calc sheet protected by the password pw -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153891] Crash in: writerfilter::dmapper::DomainMapperTableHandler::endTable(unsigned int, bool)
https://bugs.documentfoundation.org/show_bug.cgi?id=153891 --- Comment #5 from László Németh --- Commit description: tdf#153891 DOCX import: crash fix at missing cell properties Regression from commit 81ce88aa80f8e7cde4fdc5b211e9500a3599643c "tdf#132514 DOCX import: fix lost table style with footer". Note: no crash without this fix by removing styles.xml from the test document. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153891] Crash in: writerfilter::dmapper::DomainMapperTableHandler::endTable(unsigned int, bool)
https://bugs.documentfoundation.org/show_bug.cgi?id=153891 --- Comment #4 from Commit Notification --- László Németh committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/e34074feeb1b918ab9f26a18c5fdb0b1f2e35f94 tdf#153891 DOCX import: crash fix at missing cell properties It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153891] Crash in: writerfilter::dmapper::DomainMapperTableHandler::endTable(unsigned int, bool)
https://bugs.documentfoundation.org/show_bug.cgi?id=153891 Commit Notification changed: What|Removed |Added Whiteboard||target:7.6.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 104444] [META] DOCX (OOXML) table-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=10 Bug 10 depends on bug 153891, which changed state. Bug 153891 Summary: Crash in: writerfilter::dmapper::DomainMapperTableHandler::endTable(unsigned int, bool) https://bugs.documentfoundation.org/show_bug.cgi?id=153891 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153891] Crash in: writerfilter::dmapper::DomainMapperTableHandler::endTable(unsigned int, bool)
https://bugs.documentfoundation.org/show_bug.cgi?id=153891 László Németh changed: What|Removed |Added Assignee|nem...@numbertext.org |libreoffice-b...@lists.free ||desktop.org Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/qa writerfilter/source
sw/qa/extras/ooxmlexport/data/tdf153891.docx |binary
sw/qa/extras/ooxmlexport/ooxmlexport6.cxx|5 +
writerfilter/source/dmapper/DomainMapperTableHandler.cxx |4 +++-
3 files changed, 8 insertions(+), 1 deletion(-)
New commits:
commit e34074feeb1b918ab9f26a18c5fdb0b1f2e35f94
Author: László Németh
AuthorDate: Wed Mar 1 14:11:30 2023 +0100
Commit: László Németh
CommitDate: Thu Mar 2 21:51:39 2023 +
tdf#153891 DOCX import: crash fix at missing cell properties
Regression from commit 81ce88aa80f8e7cde4fdc5b211e9500a3599643c
"tdf#132514 DOCX import: fix lost table style with footer".
Note: no crash without this fix by removing styles.xml from
the test document.
Change-Id: I7fd7edfc8f62e6b17c0c8f7a3bdec7d986ba57eb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148053
Tested-by: Jenkins
Reviewed-by: László Németh
diff --git a/sw/qa/extras/ooxmlexport/data/tdf153891.docx
b/sw/qa/extras/ooxmlexport/data/tdf153891.docx
new file mode 100644
index ..6fe8092982b6
Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/tdf153891.docx differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport6.cxx
b/sw/qa/extras/ooxmlexport/ooxmlexport6.cxx
index f80526a74e9b..213b8842f866 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport6.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport6.cxx
@@ -518,6 +518,11 @@ CPPUNIT_TEST_FIXTURE(Test, testTdf132514)
assertXPath(pXmlDoc,
"/w:document/w:body/w:tbl/w:tr[1]/w:tc[2]/w:p[2]/w:pPr/w:spacing", "after",
"0");
}
+DECLARE_OOXMLEXPORT_TEST(testTdf153891, "tdf153891.docx")
+{
+// This document simply crashed the importer.
+}
+
CPPUNIT_TEST_FIXTURE(Test, testFdo69636)
{
loadAndSave("fdo69636.docx");
diff --git a/writerfilter/source/dmapper/DomainMapperTableHandler.cxx
b/writerfilter/source/dmapper/DomainMapperTableHandler.cxx
index fc19793991f8..c879091f01ca 100644
--- a/writerfilter/source/dmapper/DomainMapperTableHandler.cxx
+++ b/writerfilter/source/dmapper/DomainMapperTableHandler.cxx
@@ -1445,7 +1445,9 @@ void DomainMapperTableHandler::endTable(unsigned int
nestedTableLevel, bool bTab
if (bApply)
{
bool bEndOfApply =
(xTextRangeCompare->compareRegionEnds(rEndPara, aIt->m_rEndParagraph) == 0);
-ApplyParagraphPropertiesFromTableStyle(*aIt,
aAllTableParaProperties, aCellProperties[nRow][nCell]);
+// tdf#153891 handle missing cell properties
(exception in style handling?)
+if ( nCell <
sal::static_int_cast(aCellProperties[nRow].getLength()) )
+
ApplyParagraphPropertiesFromTableStyle(*aIt, aAllTableParaProperties,
aCellProperties[nRow][nCell]);
// erase processed paragraph from list of
pending paragraphs
aIt = pTableParagraphs->erase(aIt);
if (bEndOfApply)
[Libreoffice-bugs] [Bug 153928] LibreOffice Writer High memory usage (memory leak?) caused computer to hang
https://bugs.documentfoundation.org/show_bug.cgi?id=153928 --- Comment #1 from Wolf Icefang --- Are you able to share the file that caused this memory leak, or did it include private info? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153794] Crash on file open because theme without name was written to file
https://bugs.documentfoundation.org/show_bug.cgi?id=153794 --- Comment #3 from Regina Henschel --- I can no longer create such document with Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 1309e6332d7ff2bd1f9b6bf87385b8b570e59158 CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded The theme color set is not written, if not available for that document. But if the attribute loext:name is missing, LO still crashes. So this crash needs to be fixed or the "name" attributes need to be mandatory in the schema. Currently they are 'optional'. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153920] Windows not opening in default / primary monitor
https://bugs.documentfoundation.org/show_bug.cgi?id=153920 V Stuart Foote changed: What|Removed |Added CC||glo...@fbihome.de, ||qui...@gmail.com, ||vsfo...@libreoffice.org --- Comment #1 from V Stuart Foote --- Since LibreOffice vcl composes to a virtual display with left most 0,0 on the left display it is not surprising that launching on non-primary monitor happens. You can look at the user profile for the ooSetupFactoryWindowAttributes for each module and follow along for changes for LO launch with different display configurations and module use. Losing content off display probably shouldn't happen. But seems an issue for the backend vcl to get the LO Start Center and modules to adjust onto the correct "default" display when secondary monitor is not available. Either translate, or fall back to single display defaults. @Jan-Marek would multi-head display testing be something more needed with the vcl::WindowPosSize work? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145112] Formatting distribution relative to page
https://bugs.documentfoundation.org/show_bug.cgi?id=145112 Regina Henschel changed: What|Removed |Added CC||rb.hensc...@t-online.de --- Comment #6 from Regina Henschel --- Created attachment 185708 --> https://bugs.documentfoundation.org/attachment.cgi?id=185708=edit The option in question in PowerPoint The attachment shows the location of the setting "Align to Slide" in the UI in PowerPoint. (In reply to Heiko Tietze from comment #2) > We have align and distribute. In order to make > equidistant you could create dummy > objects with the same size of the images and use the existing functions. Not "with the same size of the images", but you draw a vertical line on the left edge and a vertical line on the right edge. Then mark them together with the images and use the distribution "Horizontal Spacing". As last step remove the dummy lines. > I see no other functions in MS Impress (=> NEEDINFO). It is the option "Align to Slide", which provides the requested feature. LibreOffice uses only "Align Selected Objects". See screenshot. > What Impress has is what has been requested in bug 100141 - Add alignment > and spacing guides. That is not related to the requested feature here. I think it is a valid request. It would supersede the above noted workaround. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 145112] Formatting distribution relative to page
https://bugs.documentfoundation.org/show_bug.cgi?id=145112 Regina Henschel changed: What|Removed |Added CC||rb.hensc...@t-online.de --- Comment #6 from Regina Henschel --- Created attachment 185708 --> https://bugs.documentfoundation.org/attachment.cgi?id=185708=edit The option in question in PowerPoint The attachment shows the location of the setting "Align to Slide" in the UI in PowerPoint. (In reply to Heiko Tietze from comment #2) > We have align and distribute. In order to make > equidistant you could create dummy > objects with the same size of the images and use the existing functions. Not "with the same size of the images", but you draw a vertical line on the left edge and a vertical line on the right edge. Then mark them together with the images and use the distribution "Horizontal Spacing". As last step remove the dummy lines. > I see no other functions in MS Impress (=> NEEDINFO). It is the option "Align to Slide", which provides the requested feature. LibreOffice uses only "Align Selected Objects". See screenshot. > What Impress has is what has been requested in bug 100141 - Add alignment > and spacing guides. That is not related to the requested feature here. I think it is a valid request. It would supersede the above noted workaround. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 153921] Insertion video mp4 doesn't work in LO Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=153921 Julien Nabet changed: What|Removed |Added Ever confirmed|0 |1 CC||serval2...@yahoo.fr Status|UNCONFIRMED |NEEDINFO --- Comment #1 from Julien Nabet --- On pc Debian x86-64 with master sources updated today, no problem to include the file from https://file-examples.com/storage/feadec8f346400f84963e24/2017/04/file_example_MP4_480_1_5MG.mp4 Now I suppose it depends on the codecs used in the mp4 file. Would it be possible you attach the file or provide an url to download it? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153921] Insertion video mp4 doesn't work in LO Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=153921 Julien Nabet changed: What|Removed |Added Hardware|All |x86-64 (AMD64) Version|unspecified |7.5.0.3 release -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - bin/create-dmg-from-merged-app-bundle bin/merge-app-bundles
bin/create-dmg-from-merged-app-bundle | 81 ++ bin/merge-app-bundles |2 2 files changed, 83 insertions(+) New commits: commit 385bec920e2ad63dc06d77c695f8ab0639382cec Author: Patrick Luby AuthorDate: Wed Mar 1 09:23:12 2023 -0500 Commit: Andras Timar CommitDate: Thu Mar 2 20:20:50 2023 + Enable building non-Mac App Store Universal .dmg from merged and signed .app Add a new bin/create-dmg-from-merged-app-bundle script which is used to package a merged and signed .app folder (created with the bin/merge-app-bundles and manually signed) into a distributable .dmg. Also, add .jnilib files to the lipo list in bin/merge-app-bundles since these are really .dylib files for Java. Change-Id: I1da4105b0820251580401f975f499b8d59a20499 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148101 Tested-by: Jenkins Reviewed-by: Patrick Luby (cherry picked from commit 4637080c28ac082ca44ee37e05e1b0c0a6183ba6) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148103 Tested-by: Andras Timar Reviewed-by: Andras Timar diff --git a/bin/create-dmg-from-merged-app-bundle b/bin/create-dmg-from-merged-app-bundle new file mode 100755 index ..8f32e4d24b3e --- /dev/null +++ b/bin/create-dmg-from-merged-app-bundle @@ -0,0 +1,81 @@ +#!/usr/bin/env bash + +# This file is part of the LibreOffice project. +# +# This Source Code Form is subject to the terms of the Mozilla Public +# License, v. 2.0. If a copy of the MPL was not distributed with this +# file, You can obtain one at http://mozilla.org/MPL/2.0/. + +# Exit on errors +set -e + +# Use of unset variable is an error +set -u + +# If any part of a pipeline of commands fails, the whole pipeline fails +set -o pipefail + +if [ `uname` != Darwin ]; then +echo This is for macOS only >&2 +exit 1 +fi + +if [ $# != 1 ]; then +echo Usage: $0 signed-app-bundle +exit 1 +fi + +if [ ! -d "$1" ]; then +echo No such directory: $1 >&2 +exit 1 +fi + +if [[ "$1" != *.app ]]; then +echo "signed-app-bundle argument $1 does not end with .app" >&2 +exit 1 +fi + +IN=$(cd "$1" && /bin/pwd) +INAPP=$(basename "$IN") +INDIR=$(dirname "$IN") +OUTVOLUME=$(basename "$IN" .app) +OUTTMPDIR=$(dirname "$IN")/"$OUTVOLUME" +OUTFILE="$OUTTMPDIR".dmg +SRCDIR=$(cd `dirname "$0"`/.. && /bin/pwd) + +# Create $OUTTMPDIR directory in the same directory as the output .dmg and +# assemble assets + +if [ -f "$OUTFILE" ]; then +echo The file $OUTFILE exists already >&2 +exit 1 +fi + +if [ -d "$OUTFILE" ]; then +echo $OUTFILE exists and is a directory >&2 +exit 1 +fi + +if [ -d "$OUTTMPDIR" ]; then +echo The directory $OUTTMPDIR exists already >&2 +exit 1 +fi + +if [ -f "$OUTTMPDIR" ]; then +echo $OUTTMPDIR exists and is a file >&2 +exit 1 +fi + +mkdir "$OUTTMPDIR" +mkdir "$OUTTMPDIR"/.background +tar cf - "$INAPP" -C "$INDIR" | tar xvpf - -C "$OUTTMPDIR" +ln -s /Applications "$OUTTMPDIR"/Applications +cp "$SRCDIR"/setup_native/source/packinfo/DS_Store "$OUTTMPDIR"/.DS_Store +cp "$SRCDIR"/setup_native/source/packinfo/VolumeIcon.icns "$OUTTMPDIR"/.VolumeIcon.icns +cp "$SRCDIR"/setup_native/source/packinfo/osxdndinstall.png "$OUTTMPDIR"/.background/background.png + +# Create and mount empty .dmg + +# Copied and adapted to bash from solenv/bin/modules/installer/simplepackage.pm +# tdf#151341 Use lzfse compression instead of bzip2 +hdiutil create -srcfolder "$OUTTMPDIR" "$OUTFILE" -ov -fs HFS+ -volname "$OUTVOLUME" -format ULFO diff --git a/bin/merge-app-bundles b/bin/merge-app-bundles index 2a2200f1c44d..b92c90b5a0c9 100755 --- a/bin/merge-app-bundles +++ b/bin/merge-app-bundles @@ -76,6 +76,8 @@ OUT=$(cd "$3" && /bin/pwd) elif test -f "$fname"; then case "$fname" in *.so | \ +*.jnilib | \ +*.jnilib.* | \ *.dylib | \ *.dylib.* | \ */Frameworks/LibreOfficePython.framework/Versions/*/LibreOfficePython | \
