[Libreoffice-bugs] [Bug 154071] Request: Rename "Square" gradient to "Rectangle" gradient in the UI
https://bugs.documentfoundation.org/show_bug.cgi?id=154071 Heiko Tietze changed: What|Removed |Added OS|Windows (All) |All CC|heiko.tietze@documentfounda |sdc.bla...@youmail.dk |tion.org| Hardware|x86-64 (AMD64) |All --- Comment #1 from Heiko Tietze --- I don't like the over-specification of a fairly fuzzy term. Most users (including me) don't understand the difference between Square and Quadratic (and the documentation keeps silent over the types) and rather play with the result than trying to understand the effect from the name. Switching from "Square" to "Rectangular" sounds good to me but I'd keep "Quadratic". Ultimately I don't see need to align the UI labels with internal variable names. So probably also NAB. Looking for gradient naming did not return bug insights: CSS: linear, radial, and conic [1] Adobe: Linear, Radial, Conic, Diamond, Reflected Photoshop: Linear, Radial, Angle, Reflected and Diamond MSO: DiagonalDown, DiagonalUp, FromCenter, FromCorner, FromTitle, Horizontal, Mixed, Vertical MSO: Linear, Radial, Rectangular, Path [1] https://css-tricks.com/a-complete-guide-to-css-gradients/ [2] https://xd.adobe.com/ideas/principles/web-design/gradient-color-definition/ [3] https://www.creativebloq.com/computer-arts/how-master-gradients-photoshop-51411514 [4] https://learn.microsoft.com/en-us/office/vba/api/office.msogradientstyle [5] https://www.officetooltips.com/office_365/tips/fill_and_outline_options_in_microsoft.html -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 154071] Request: Rename "Square" gradient to "Rectangle" gradient in the UI
https://bugs.documentfoundation.org/show_bug.cgi?id=154071 Heiko Tietze changed: What|Removed |Added OS|Windows (All) |All CC|heiko.tietze@documentfounda |sdc.bla...@youmail.dk |tion.org| Hardware|x86-64 (AMD64) |All --- Comment #1 from Heiko Tietze --- I don't like the over-specification of a fairly fuzzy term. Most users (including me) don't understand the difference between Square and Quadratic (and the documentation keeps silent over the types) and rather play with the result than trying to understand the effect from the name. Switching from "Square" to "Rectangular" sounds good to me but I'd keep "Quadratic". Ultimately I don't see need to align the UI labels with internal variable names. So probably also NAB. Looking for gradient naming did not return bug insights: CSS: linear, radial, and conic [1] Adobe: Linear, Radial, Conic, Diamond, Reflected Photoshop: Linear, Radial, Angle, Reflected and Diamond MSO: DiagonalDown, DiagonalUp, FromCenter, FromCorner, FromTitle, Horizontal, Mixed, Vertical MSO: Linear, Radial, Rectangular, Path [1] https://css-tricks.com/a-complete-guide-to-css-gradients/ [2] https://xd.adobe.com/ideas/principles/web-design/gradient-color-definition/ [3] https://www.creativebloq.com/computer-arts/how-master-gradients-photoshop-51411514 [4] https://learn.microsoft.com/en-us/office/vba/api/office.msogradientstyle [5] https://www.officetooltips.com/office_365/tips/fill_and_outline_options_in_microsoft.html -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 153839] Exporting to xhtml results in most of the tags and content in one single line
https://bugs.documentfoundation.org/show_bug.cgi?id=153839 --- Comment #5 from Commit Notification --- Franklin Weng committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/d2e8705c9cc503afdaed366b1f71ed012b0c568f tdf#153839: add newline after certain tags It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153839] Exporting to xhtml results in most of the tags and content in one single line
https://bugs.documentfoundation.org/show_bug.cgi?id=153839 Commit Notification changed: What|Removed |Added Whiteboard||target:7.6.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: filter/source
filter/source/xslt/odf2xhtml/export/xhtml/body.xsl | 11 filter/source/xslt/odf2xhtml/export/xhtml/header.xsl| 31 filter/source/xslt/odf2xhtml/export/xhtml/opendoc2xhtml.xsl |6 ++ 3 files changed, 48 insertions(+) New commits: commit d2e8705c9cc503afdaed366b1f71ed012b0c568f Author: Franklin Weng AuthorDate: Wed Mar 1 00:04:11 2023 +0800 Commit: Miklos Vajna CommitDate: Thu Mar 9 07:43:14 2023 + tdf#153839: add newline after certain tags Add newline after certain tags in head section and paragraphs, to make generated xhtml easier to read. Change-Id: I9562ef48d9dd1283110be4a45527616dce186681 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148026 Tested-by: Jenkins Reviewed-by: Miklos Vajna diff --git a/filter/source/xslt/odf2xhtml/export/xhtml/body.xsl b/filter/source/xslt/odf2xhtml/export/xhtml/body.xsl index 430b834b3cca..ca7a6906b82c 100644 --- a/filter/source/xslt/odf2xhtml/export/xhtml/body.xsl +++ b/filter/source/xslt/odf2xhtml/export/xhtml/body.xsl @@ -50,9 +50,11 @@ + + @@ -178,6 +180,7 @@ + @@ -233,6 +236,7 @@ + @@ -472,10 +476,12 @@ + + @@ -547,6 +553,7 @@ + @@ -558,6 +565,7 @@ + @@ -565,6 +573,7 @@ + @@ -580,6 +589,7 @@ + @@ -1193,6 +1203,7 @@ + diff --git a/filter/source/xslt/odf2xhtml/export/xhtml/header.xsl b/filter/source/xslt/odf2xhtml/export/xhtml/header.xsl index 2bd07d8d29e4..581b8b8d3421 100644 --- a/filter/source/xslt/odf2xhtml/export/xhtml/header.xsl +++ b/filter/source/xslt/odf2xhtml/export/xhtml/header.xsl @@ -55,12 +55,14 @@ + http://dublincore.org/documents/dcmi-terms/ CSS helper variable will be created... + CSS variable ready, header will be created... @@ -68,6 +70,7 @@ CSS header creation finished! + @@ -246,11 +249,13 @@ + + @@ -262,6 +267,7 @@ en-US + @@ -271,6 +277,7 @@ + @@ -280,13 +287,16 @@ , + + Content-Type application/xhtml+xml; charset=utf-8 + @@ -304,6 +314,7 @@ + @@ -315,6 +326,7 @@ + @@ -322,6 +334,7 @@ + @@ -329,18 +342,21 @@ + DCTERMS.source http://xml.openoffice.org/odf2xhtml + + @@ -348,12 +364,14 @@ + + @@ -361,6 +379,7 @@ + @@ -369,6 +388,7 @@ + @@ -380,6 +400,7 @@ + @@ -387,6 +408,7 @@ + @@ -394,6 +416,7 @@
[Libreoffice-commits] help.git: source/text
source/text/shared/01/extensionupdate.xhp | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) New commits: commit d399273cdb7cfb2b90260d40e49e81ac75398718 Author: Adolfo Jayme Barrientos AuthorDate: Thu Mar 9 01:36:14 2023 -0600 Commit: Adolfo Jayme Barrientos CommitDate: Thu Mar 9 01:36:24 2023 -0600 Update more references to the Extensions dialog Change-Id: I478df514a784bac03c4acdca935df184accd6b6b diff --git a/source/text/shared/01/extensionupdate.xhp b/source/text/shared/01/extensionupdate.xhp index 8efcf5afc4..4484083536 100644 --- a/source/text/shared/01/extensionupdate.xhp +++ b/source/text/shared/01/extensionupdate.xhp @@ -28,7 +28,7 @@ Extension Update -Click the Check for Updates button in the Extension Manager to check for online updates for all installed extensions. To check for online updates for only the selected extension, right-click to open the context menu, then choose Update. +Click the Check for Updates button in the Extensions dialog to check for online updates for all installed extensions. To check for online updates for only the selected extension, right-click to open the context menu, then choose Update. insert hidden text for Exclude from this update/from all updates/include again, see i115834 - not needed because no Help ID assigned When you click the Check for Updates button or choose the Update command, the Extension Update dialog is displayed and the check for availability of updates starts immediately. @@ -42,7 +42,7 @@ Dependencies are not fulfilled (the update needs some more or newer files to be installed). -Insufficient user rights (the Extension Manager was started from the menu, but shared extensions can only be modified when %PRODUCTNAME does not run, and only by a user with appropriate rights). See Extension Manager for details. +Insufficient user rights (the Extensions dialog was started from the menu, but shared extensions can only be modified when %PRODUCTNAME does not run, and only by a user with appropriate rights). See Extensions dialog for details. A manual update is necessary. @@ -50,15 +50,15 @@ When you click the Install button the Download and Installation dialog is displayed. All extensions which can be directly downloaded are downloaded now. The progress is shown in the Download and Installation dialog. If an extension cannot be downloaded, a message is displayed. The operation continues for the remaining extensions. -Some extensions may be marked with the phrase "browser based update". These extensions cannot be downloaded by the Extension Manager. A web browser must be opened to download the extension update from a particular web site. That site may require several more user interaction to download the extension. After downloading you must install the extension manually, for example by double-clicking the extension's icon in a file browser. -For extensions marked as "browser based update", the Extension Manager will open your web browser on the respective web site. This happens when you close the dialog, after downloading any other extension updates. If there are no extensions which can be directly downloaded then the web browser is started immediately. +Some extensions may be marked with the phrase “browser-based update”. These extensions cannot be downloaded by the Extensions dialog. A web browser must be opened to download the extension update from a particular web site. That site may require several more user interaction to download the extension. After downloading you must install the extension manually, for example by double-clicking the extension's icon in a file browser. +For extensions marked as “browser-based update”, the Extensions dialog will open your web browser on the respective web site. This happens when you close the dialog, after downloading any other extension updates. If there are no extensions which can be directly downloaded then the web browser is started immediately. After the last extension has been downloaded, the installation begins. First all installed extensions for which an update could be downloaded successfully, are removed. Then the updated extensions are installed. If an error occurs, a message that the installation failed is displayed, but the operation proceeds. If all updates have been processed the Download and Installation dialog shows that it has finished. You can abort the download and installation process by clicking the Abort Update button. Show all Updates By default, only the downloadable extensions are shown in the dialog. Mark Show all Updates to see also other extensions and error messages. -Extension Manager +Extensions dialog
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit bc8b153da74b0961cc3c48691d41b4e16c6d4f5b Author: Adolfo Jayme Barrientos AuthorDate: Thu Mar 9 01:36:35 2023 -0600 Commit: Gerrit Code Review CommitDate: Thu Mar 9 07:36:35 2023 + Update git submodules * Update helpcontent2 from branch 'master' to d399273cdb7cfb2b90260d40e49e81ac75398718 - Update more references to the Extensions dialog Change-Id: I478df514a784bac03c4acdca935df184accd6b6b diff --git a/helpcontent2 b/helpcontent2 index 717e288c98b1..d399273cdb7c 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 717e288c98b181fe9a49e86f7fa6d4f594df4ab5 +Subproject commit d399273cdb7cfb2b90260d40e49e81ac75398718
[Libreoffice-bugs] [Bug 154050] Crashes when inserting or changing a note in Calc With Standard Toolbar (Single Mode) enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=154050 Commit Notification changed: What|Removed |Added Whiteboard||target:7.6.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sc/source
sc/source/ui/drawfunc/futext3.cxx |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) New commits: commit 37b2bb1f6c18b915286264682bf0b3c25f0d552a Author: Maxim Monastirsky AuthorDate: Thu Mar 9 02:37:19 2023 +0200 Commit: Maxim Monastirsky CommitDate: Thu Mar 9 07:23:25 2023 + tdf#154050 Unset external pointer before destroying Regression of 48ca2336251d62ac2e90300cd9945fb84b1cddd8 ("tdf#125040 Avoid flickering on context change"). Before that commit the state of toolbar commands was updating async, which is how it managed to not crash. Change-Id: I07e2ce25faf848c7db33dd029b54a98bafcf8fa9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148518 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky diff --git a/sc/source/ui/drawfunc/futext3.cxx b/sc/source/ui/drawfunc/futext3.cxx index 1c13beea9388..a0db57860945 100644 --- a/sc/source/ui/drawfunc/futext3.cxx +++ b/sc/source/ui/drawfunc/futext3.cxx @@ -92,6 +92,11 @@ void FuText::StopEditMode() if( pNote ) rDoc.LockStreamValid(true); // only the affected sheet is invalidated below +/* Unset the outliner undo manager before the call to SdrEndTextEdit. +SdrObjEditView::SdrEndTextEdit destroys it, but then ScDrawView::SdrEndTextEdit +initiates some UI update which might try to access the now invalid pointer. */ +rViewShell.SetDrawTextUndo( nullptr ); + /* SdrObjEditView::SdrEndTextEdit() may try to delete the entire drawing object, if it does not contain text and has invisible border and fill. This must not happen for note caption objects. They will be removed @@ -102,9 +107,6 @@ void FuText::StopEditMode() case. */ /*SdrEndTextEditKind eResult =*/ pView->SdrEndTextEdit( pNote != nullptr ); -// or ScEndTextEdit (with drawview.hxx) -rViewShell.SetDrawTextUndo( nullptr ); - vcl::Cursor* pCur = pWindow->GetCursor(); if( pCur && pCur->IsVisible() ) pCur->Hide();
[Libreoffice-bugs] [Bug 96190] Date in Form shows different values in Datefield and Formatted Field, if based on an integer Column
https://bugs.documentfoundation.org/show_bug.cgi?id=96190 --- Comment #12 from Robert Großkopf --- Bug is still the same in LO 7.5.1.2 on OpenSUSE 15.3 64bit rpm Linux. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153977] Bad quality of opened PDFs in Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=153977 Kurosh Tavassoli changed: What|Removed |Added Resolution|--- |INVALID Status|UNCONFIRMED |RESOLVED --- Comment #4 from Kurosh Tavassoli --- I'm so sorry, I can't reproduce the bug myself as well. I'll try to reproduce the bug and report it if I could. Thanks. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: emfio/qa
emfio/qa/cppunit/wmf/wmfimporttest.cxx | 113 + 1 file changed, 73 insertions(+), 40 deletions(-) New commits: commit a5c83673ba987bd6ed1a36fe5b8c4b1f600f9626 Author: Stephan Bergmann AuthorDate: Wed Mar 8 23:03:08 2023 +0100 Commit: Stephan Bergmann CommitDate: Thu Mar 9 07:06:05 2023 + Demultiplex test code It is so much easier to work with if a test failure's line number unambiguously points at the code's sole execution. (That is, test code is necessarily non- DRY.) Change-Id: I75919c55671348f6190e9e108e72e24ec18ce986 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148514 Tested-by: Jenkins Reviewed-by: Stephan Bergmann diff --git a/emfio/qa/cppunit/wmf/wmfimporttest.cxx b/emfio/qa/cppunit/wmf/wmfimporttest.cxx index c5b2ddbc3205..48e47fb0fd36 100644 --- a/emfio/qa/cppunit/wmf/wmfimporttest.cxx +++ b/emfio/qa/cppunit/wmf/wmfimporttest.cxx @@ -55,8 +55,10 @@ public: void testBigPPI(); void testTdf93750(); void testTdf99402(); -void testTdf39894(); -void testETO_PDY(); +void testTdf39894Wmf(); +void testTdf39894Emf(); +void testETO_PDYWmf(); +void testETO_PDYEmf(); void testStockObject(); CPPUNIT_TEST_SUITE(WmfTest); @@ -70,8 +72,10 @@ public: CPPUNIT_TEST(testBigPPI); CPPUNIT_TEST(testTdf93750); CPPUNIT_TEST(testTdf99402); -CPPUNIT_TEST(testTdf39894); -CPPUNIT_TEST(testETO_PDY); +CPPUNIT_TEST(testTdf39894Wmf); +CPPUNIT_TEST(testTdf39894Emf); +CPPUNIT_TEST(testETO_PDYWmf); +CPPUNIT_TEST(testETO_PDYEmf); CPPUNIT_TEST(testStockObject); CPPUNIT_TEST_SUITE_END(); }; @@ -369,49 +373,78 @@ void WmfTest::testTdf99402() CPPUNIT_ASSERT_EQUAL(RTL_TEXTENCODING_SYMBOL, fontStyle.aFont.GetCharSet()); } -void WmfTest::testTdf39894() +void WmfTest::testTdf39894Wmf() { -OUString files[] = { "tdf39894.wmf", "tdf39894.emf" }; -for (const auto& file : files) -{ -SvFileStream aFileStream(getFullUrl(file), StreamMode::READ); -GDIMetaFile aGDIMetaFile; -ReadWindowMetafile(aFileStream, aGDIMetaFile); +SvFileStream aFileStream(getFullUrl(u"tdf39894.wmf"), StreamMode::READ); +GDIMetaFile aGDIMetaFile; +ReadWindowMetafile(aFileStream, aGDIMetaFile); -MetafileXmlDump dumper; -xmlDocUniquePtr pDoc = dumpAndParse(dumper, aGDIMetaFile); +MetafileXmlDump dumper; +xmlDocUniquePtr pDoc = dumpAndParse(dumper, aGDIMetaFile); -CPPUNIT_ASSERT(pDoc); +CPPUNIT_ASSERT(pDoc); -// The x position of the second text must take into account -// the previous text's last Dx (previously was ~300) -auto x = getXPath(pDoc, "/metafile/push[2]/textarray[2]", "x"); -CPPUNIT_ASSERT_GREATER(sal_Int32(2700), x.toInt32()); -} +// The x position of the second text must take into account +// the previous text's last Dx (previously was ~300) +auto x = getXPath(pDoc, "/metafile/push[2]/textarray[2]", "x"); +CPPUNIT_ASSERT_GREATER(sal_Int32(2700), x.toInt32()); } -void WmfTest::testETO_PDY() +void WmfTest::testTdf39894Emf() { -OUString files[] = { "ETO_PDY.wmf", "ETO_PDY.emf" }; -for (const auto& file : files) -{ -SvFileStream aFileStream(getFullUrl(file), StreamMode::READ); -GDIMetaFile aGDIMetaFile; -ReadWindowMetafile(aFileStream, aGDIMetaFile); - -MetafileXmlDump dumper; -xmlDocUniquePtr pDoc = dumpAndParse(dumper, aGDIMetaFile); - -CPPUNIT_ASSERT(pDoc); - -// The y position of following text -// must be smaller than that of previous -auto y1 = getXPath(pDoc, "/metafile/push[2]/textarray[1]", "y"); -auto y2 = getXPath(pDoc, "/metafile/push[2]/textarray[2]", "y"); -auto y3 = getXPath(pDoc, "/metafile/push[2]/textarray[3]", "y"); -CPPUNIT_ASSERT_MESSAGE(file.toUtf8().getStr(), y2.toInt32() < y1.toInt32()); -CPPUNIT_ASSERT_MESSAGE(file.toUtf8().getStr(), y3.toInt32() < y2.toInt32()); -} +SvFileStream aFileStream(getFullUrl(u"tdf39894.emf"), StreamMode::READ); +GDIMetaFile aGDIMetaFile; +ReadWindowMetafile(aFileStream, aGDIMetaFile); + +MetafileXmlDump dumper; +xmlDocUniquePtr pDoc = dumpAndParse(dumper, aGDIMetaFile); + +CPPUNIT_ASSERT(pDoc); + +// The x position of the second text must take into account +// the previous text's last Dx (previously was ~300) +auto x = getXPath(pDoc, "/metafile/push[2]/textarray[2]", "x"); +CPPUNIT_ASSERT_GREATER(sal_Int32(2700), x.toInt32()); +} + +void WmfTest::testETO_PDYWmf() +{ +SvFileStream aFileStream(getFullUrl(u"ETO_PDY.wmf"), StreamMode::READ); +GDIMetaFile aGDIMetaFile; +ReadWindowMetafile(aFileStream, aGDIMetaFile); + +MetafileXmlDump dumper; +xmlDocUniquePtr pDoc = dumpAndParse(dumper, aGDIMetaFile); + +CPPUNIT_ASSERT(pDoc); + +// The y position of following text +// must be
[Libreoffice-commits] core.git: emfio/inc emfio/Module_emfio.mk
emfio/Module_emfio.mk |2 +- emfio/inc/mtftools.hxx |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) New commits: commit f194f9dba0aee30de9d5701f2ff0ce60c785131d Author: Stephan Bergmann AuthorDate: Wed Mar 8 22:56:51 2023 +0100 Commit: Stephan Bergmann CommitDate: Thu Mar 9 07:05:04 2023 + Re-enable CppunitTest_emfio_wmf for --enable-mergelibs It had originally been disabled by a037f6338c19e16bcbc0674214666a786872c59d "Disable CppunitTest_vcl_wmf_test under --enable-merglibs for now" because "the problems caused by that test having the vcl objects linked into both the test's library and the mergedlib (which the test's library links against) are just not manageable", which is no longer an issue at least since 29cdfa3fc337381e2529eaac2a551137ee8a1aaa "no need to statically link against the emfio library in the tests". But the test code apparently uses WinMtfFontStyle, which can thus no longer be hidden under --enable-mergelibs. Change-Id: Ie807b19f0cb44408c69d03faca01fabe88239ca0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148493 Tested-by: Jenkins Reviewed-by: Stephan Bergmann diff --git a/emfio/Module_emfio.mk b/emfio/Module_emfio.mk index 96b69d1cbe86..1ea9db2bb15a 100644 --- a/emfio/Module_emfio.mk +++ b/emfio/Module_emfio.mk @@ -24,7 +24,7 @@ $(eval $(call gb_Module_add_targets,emfio,\ $(eval $(call gb_Module_add_check_targets,emfio,\ CppunitTest_emfio_emf \ - $(if $(MERGELIBS),,CppunitTest_emfio_wmf) \ + CppunitTest_emfio_wmf \ )) # vim: set noet ts=4 sw=4: diff --git a/emfio/inc/mtftools.hxx b/emfio/inc/mtftools.hxx index f7a318f39d55..26e2d8cca088 100644 --- a/emfio/inc/mtftools.hxx +++ b/emfio/inc/mtftools.hxx @@ -387,7 +387,7 @@ namespace emfio GDIObj & operator =(GDIObj const &) = default; }; -struct UNLESS_MERGELIBS(EMFIO_DLLPUBLIC) WinMtfFontStyle final : GDIObj +struct EMFIO_DLLPUBLIC WinMtfFontStyle final : GDIObj { vcl::FontaFont;
[Libreoffice-commits] core.git: sw/inc sw/source
sw/inc/strings.hrc |1 + sw/inc/swundo.hxx |1 + sw/source/core/undo/undobj.cxx |3 +++ sw/source/uibase/shells/textsh1.cxx |4 ++-- 4 files changed, 7 insertions(+), 2 deletions(-) New commits: commit db73d73c4031c20cede546e00b2fc34d673f3069 Author: Miklos Vajna AuthorDate: Wed Mar 8 20:13:41 2023 +0100 Commit: Miklos Vajna CommitDate: Thu Mar 9 07:00:12 2023 + sw: fix undo comment of FN_UPDATE_BOOKMARKS It's updates, not insert. One has to dispatch .uno:UpdateBookmarks to see this in action, which does something if the document already contains at least one bookmark. Change-Id: I32d259b0b5c18cbbec2969cd189ca7ba4dd0dde4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148487 Tested-by: Jenkins Reviewed-by: Miklos Vajna diff --git a/sw/inc/strings.hrc b/sw/inc/strings.hrc index 033a1a225a92..2965e6b884b2 100644 --- a/sw/inc/strings.hrc +++ b/sw/inc/strings.hrc @@ -439,6 +439,7 @@ #define STR_DELBOOKMARK NC_("STR_DELBOOKMARK", "Delete bookmark: $1") #define STR_INSBOOKMARK NC_("STR_INSBOOKMARK", "Insert bookmark: $1") #define STR_UPDATE_BOOKMARK NC_("STR_UPDATE_BOOKMARK", "Update bookmark: $1") +#define STR_UPDATE_BOOKMARKSNC_("STR_UPDATE_BOOKMARKS", "Update bookmarks") #define STR_SORT_TBLNC_("STR_SORT_TBL", "Sort table") #define STR_SORT_TXTNC_("STR_SORT_TXT", "Sort text") #define STR_INSTABLE_UNDO NC_("STR_INSTABLE_UNDO", "Insert table: $1$2$3") diff --git a/sw/inc/swundo.hxx b/sw/inc/swundo.hxx index d4da619560cc..efca97bc1b23 100644 --- a/sw/inc/swundo.hxx +++ b/sw/inc/swundo.hxx @@ -171,6 +171,7 @@ enum class SwUndoId UPDATE_FORM_FIELDS,// 139 DELETE_FORM_FIELDS,// 140 UPDATE_BOOKMARK, // 141 +UPDATE_BOOKMARKS, // 142 }; OUString GetUndoComment(SwUndoId eId); diff --git a/sw/source/core/undo/undobj.cxx b/sw/source/core/undo/undobj.cxx index d872bc812166..8e5638205c61 100644 --- a/sw/source/core/undo/undobj.cxx +++ b/sw/source/core/undo/undobj.cxx @@ -658,6 +658,9 @@ OUString GetUndoComment(SwUndoId eId) case SwUndoId::UPDATE_BOOKMARK: pId = STR_UPDATE_BOOKMARK; break; +case SwUndoId::UPDATE_BOOKMARKS: +pId = STR_UPDATE_BOOKMARKS; +break; } assert(pId); diff --git a/sw/source/uibase/shells/textsh1.cxx b/sw/source/uibase/shells/textsh1.cxx index f1d9522a89f7..b52e26778388 100644 --- a/sw/source/uibase/shells/textsh1.cxx +++ b/sw/source/uibase/shells/textsh1.cxx @@ -515,7 +515,7 @@ void UpdateBookmarks(SfxRequest& rReq, SwWrtShell& rWrtSh) pBookmarks->GetValue() >>= aBookmarks; } -rWrtSh.GetDoc()->GetIDocumentUndoRedo().StartUndo(SwUndoId::INSBOOKMARK, nullptr); + rWrtSh.GetDoc()->GetIDocumentUndoRedo().StartUndo(SwUndoId::UPDATE_BOOKMARKS, nullptr); rWrtSh.StartAction(); IDocumentMarkAccess& rIDMA = *rWrtSh.GetDoc()->getIDocumentMarkAccess(); @@ -578,7 +578,7 @@ void UpdateBookmarks(SfxRequest& rReq, SwWrtShell& rWrtSh) } rWrtSh.EndAction(); -rWrtSh.GetDoc()->GetIDocumentUndoRedo().EndUndo(SwUndoId::INSBOOKMARK, nullptr); + rWrtSh.GetDoc()->GetIDocumentUndoRedo().EndUndo(SwUndoId::UPDATE_BOOKMARKS, nullptr); } void UpdateBookmark(SfxRequest& rReq, SwWrtShell& rWrtSh)
[Libreoffice-bugs] [Bug 153609] Elementary's Book Preview icon not distinct enough to Two Pages Preview
https://bugs.documentfoundation.org/show_bug.cgi?id=153609 Rizal Muttaqin changed: What|Removed |Added CC||riz...@libreoffice.org --- Comment #2 from Rizal Muttaqin --- (In reply to Stéphane Guillou (stragu) from comment #1) > Created attachment 185363 [details] > Highlighted icons in LO 7.6, Elementary icons, GNOME dark mode Oh yes I kind of agree since elementary use non-folded paper as the representation. Do you think the icons should have folded part? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154084] CALC Rogue URL addresses
https://bugs.documentfoundation.org/show_bug.cgi?id=154084 --- Comment #1 from Colin --- Created attachment 185854 --> https://bugs.documentfoundation.org/attachment.cgi?id=185854=edit Calc Demonstrating the issue -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154084] New: CALC Rogue URL addresses
https://bugs.documentfoundation.org/show_bug.cgi?id=154084 Bug ID: 154084 Summary: CALC Rogue URL addresses Product: LibreOffice Version: 7.4.5.1 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: trivial Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: that.man.co...@gmail.com Description: Where a column of anchored and resized URL "Buttons" has been created, double-clicking any "empty" cell will produce a URL address hint at locations in the "URL Column" when the mouse is moved to hover in that column. The hint is dynamic and will change as the cursor is scrolled over a lower or higher cell. It is not necessary to click to focus the new cell, just hovering will produce the effect. If hovering over the first vacant cell below the column of buttons, the rogue hint is for the URL in row 11. Scrolling up "on top of" the existing buttons it will only cycle the rogue hint as far back as the genuine first link address. I have no idea why the first "uncluttered" cell produces the link address for row 11. Steps to Reproduce: Utilising the attached CALC, double-click F424 Observe that a rogue URL Hint will appear at that location Move your mouse cursor to any location in the column and observe how the hint is dynamic, reflecting the anticipated incremental address. It is not necessary to click or focus in any way - a simple mouse hover will elicit the rogue response. There is a nominal pause when the mouse moves over the page layout marquee. Actual Results: Rogue hint produced Expected Results: nothing Reproducible: Always User Profile Reset: No Additional Info: Version: 7.4.5.1 (x64) / LibreOffice Community Build ID: 9c0871452b3918c1019dde9bfac75448afc4b57f CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: sv-SE (en_GB); UI: en-GB Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: compilerplugins/clang
compilerplugins/clang/store/unique2optional.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit a7952b339e73d203ba7d2b4f701d3279bb581d16 Author: Andrea Gelmini AuthorDate: Wed Mar 8 13:14:56 2023 +0100 Commit: Julien Nabet CommitDate: Thu Mar 9 06:21:24 2023 + Fix typo Change-Id: Ie69dd2bacbd1f1680d82ad113b707cca24950d2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148471 Tested-by: Jenkins Reviewed-by: Julien Nabet diff --git a/compilerplugins/clang/store/unique2optional.cxx b/compilerplugins/clang/store/unique2optional.cxx index cc1dc66f193c..e4b8efa1e110 100644 --- a/compilerplugins/clang/store/unique2optional.cxx +++ b/compilerplugins/clang/store/unique2optional.cxx @@ -205,7 +205,7 @@ bool Unique2Optional::doDecl(const DeclaratorDecl* fieldDecl) auto paramRecordDecl = firstTemplateParamType->getAsCXXRecordDecl(); if (paramRecordDecl) { -// if the pointed-to type has a virtual destructor, then we dont know for sure +// if the pointed-to type has a virtual destructor, then we don't know for sure // what size type will be stored there if (!paramRecordDecl->isEffectivelyFinal()) if (CXXDestructorDecl* dd = paramRecordDecl->getDestructor())
[Libreoffice-commits] core.git: package/source
package/source/zipapi/Deflater.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 5eae429d026b3f502e40265376772e2188239fb5 Author: Andrea Gelmini AuthorDate: Wed Mar 8 20:49:06 2023 +0100 Commit: Julien Nabet CommitDate: Thu Mar 9 06:20:54 2023 + Fix typo Change-Id: I4c48c988667ffd9221a0e226ab9c35e1e857e9d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148489 Tested-by: Jenkins Reviewed-by: Julien Nabet diff --git a/package/source/zipapi/Deflater.cxx b/package/source/zipapi/Deflater.cxx index 2c66253fd0ed..9439e3f56bcb 100644 --- a/package/source/zipapi/Deflater.cxx +++ b/package/source/zipapi/Deflater.cxx @@ -83,7 +83,7 @@ sal_Int32 Deflater::doDeflateBytes (uno::Sequence < sal_Int8 > , sal_Int #else nResult = z_deflate(pStream.get(), bFinish ? Z_FINISH : Z_NO_FLUSH); #endif -// total_in / total_out may stored only in 32bit, and can owerflow during deflate +// total_in / total_out may stored only in 32bit, and can overflow during deflate // 1 deflate call, uncompress only a few data, so only 1 overflow can happen at once. if (pStream->total_in < nLastTotalIn) {
[Libreoffice-bugs] [Bug 154077] Drop Common/InternalMSExport/UseOldExport config key completely
https://bugs.documentfoundation.org/show_bug.cgi?id=154077 Buovjaga changed: What|Removed |Added Keywords||topicCleanup Ever confirmed|0 |1 CC|ilmari.lauhakangas@libreoff | |ice.org | Status|UNCONFIRMED |NEW -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154068] LO_Style_design
https://bugs.documentfoundation.org/show_bug.cgi?id=154068 --- Comment #5 from Roman --- (In reply to V Stuart Foote from comment #4) > link in comment 3 provides method to set > > Tools -> Options -> View "Appearance" change from System to Light|Dark as > you prefer. That's it, he does not react as he was black, and he remained so Вот именно не реагирует он как был чёрным, так и остался им -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153780] Draw has problems with displaying cropped images and SVGs
https://bugs.documentfoundation.org/show_bug.cgi?id=153780 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150858] Italian corrector "perchè', ciò'"
https://bugs.documentfoundation.org/show_bug.cgi?id=150858 --- Comment #8 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154019] UI string "Scale" is misleading
https://bugs.documentfoundation.org/show_bug.cgi?id=154019 --- Comment #3 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154016] Libreoffice Math Crash when scrolling through "element categories"
https://bugs.documentfoundation.org/show_bug.cgi?id=154016 --- Comment #3 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150266] Program does not continue where it left off.
https://bugs.documentfoundation.org/show_bug.cgi?id=150266 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150858] Italian corrector "perchè', ciò'"
https://bugs.documentfoundation.org/show_bug.cgi?id=150858 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148800] Print size decreases when highlighting or replacing a word.
https://bugs.documentfoundation.org/show_bug.cgi?id=148800 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150266] Program does not continue where it left off.
https://bugs.documentfoundation.org/show_bug.cgi?id=150266 --- Comment #6 from QA Administrators --- Dear holtecaydi, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149721] LO doesn't jump to last edited page
https://bugs.documentfoundation.org/show_bug.cgi?id=149721 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149721] LO doesn't jump to last edited page
https://bugs.documentfoundation.org/show_bug.cgi?id=149721 --- Comment #4 from QA Administrators --- Dear Stu Corpe, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150887] LibreOffice only works in safe mode
https://bugs.documentfoundation.org/show_bug.cgi?id=150887 --- Comment #3 from QA Administrators --- Dear FLAVIO, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147147] Display of UI is very large on Mac
https://bugs.documentfoundation.org/show_bug.cgi?id=147147 --- Comment #4 from QA Administrators --- Dear Tony, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148800] Print size decreases when highlighting or replacing a word.
https://bugs.documentfoundation.org/show_bug.cgi?id=148800 --- Comment #5 from QA Administrators --- Dear howaz, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144388] Libreoffice 7.2 upgrade after install the office suite won't launch
https://bugs.documentfoundation.org/show_bug.cgi?id=144388 --- Comment #4 from QA Administrators --- Dear Robin, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 96615] Repainting issues when the focus is in the footer
https://bugs.documentfoundation.org/show_bug.cgi?id=96615 --- Comment #9 from QA Administrators --- Dear szotsaki, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 96620] Chart is lost as soon as custom formatting is involved
https://bugs.documentfoundation.org/show_bug.cgi?id=96620 --- Comment #7 from QA Administrators --- Dear szotsaki, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140325] Frame content not properly rendered after certain steps
https://bugs.documentfoundation.org/show_bug.cgi?id=140325 --- Comment #7 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 42040] Scrolling with Mouse Wheel sticks in Form Fields and Comment Boxes
https://bugs.documentfoundation.org/show_bug.cgi?id=42040 --- Comment #12 from QA Administrators --- Dear Harald Koester, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 96190] Date in Form shows different values in Datefield and Formatted Field, if based on an integer Column
https://bugs.documentfoundation.org/show_bug.cgi?id=96190 --- Comment #11 from QA Administrators --- Dear Robert Großkopf, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 138841] Windows installer display tiny icon under high resolution
https://bugs.documentfoundation.org/show_bug.cgi?id=138841 --- Comment #15 from QA Administrators --- Dear Chaoting Liu, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 115038] Umlaute (mutation) will be shown wrong in some objects when you type them first
https://bugs.documentfoundation.org/show_bug.cgi?id=115038 --- Comment #15 from QA Administrators --- Dear Karsten, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 100951] [EDITING] Font colour picker doesn't show current colour
https://bugs.documentfoundation.org/show_bug.cgi?id=100951 --- Comment #7 from QA Administrators --- Dear szotsaki, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 100958] [EDITING] Cannot demote list item
https://bugs.documentfoundation.org/show_bug.cgi?id=100958 --- Comment #6 from QA Administrators --- Dear szotsaki, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 100565] Graphic redraw problems with multiple windows
https://bugs.documentfoundation.org/show_bug.cgi?id=100565 --- Comment #14 from QA Administrators --- Dear welliben, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154083] New: LibreOffice & Calc 7.4.5 don't start
https://bugs.documentfoundation.org/show_bug.cgi?id=154083 Bug ID: 154083 Summary: LibreOffice & Calc 7.4.5 don't start Product: LibreOffice Version: 7.4.5.1 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rpl01...@gmail.com Description: just downloaded it and did system Restart. Now clicking on any LibreOffice or Calc document or starting Office from Windows Start has no effect. No error message, no dialog box. Restarted again, same result. Windows Start in Safe Mode same result. The command line command libreoffice --safe-mode gives a dialog box "Windows cannot find LibreOffice". 64-bit Windows 10 on a Lenovo X1 carbon. Have been using LibreOffice all the time for over a year now. Issued a bug report involving what seems to be a mutex mess-up in Calc earlier today before downloading 7.4.5, if that as any connection. Actual Results: see Description. Expected Results: see Description Reproducible: Always User Profile Reset: Yes Additional Info: re user profile: using soffice.com -env:UserInstallation=file:///c:/my-test-profile results in ...>soffice.com -env:UserInstallation=file:///c:/my 'soffice.com' is not recognized as an internal or external command, operable program or batch file. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: icon-themes/sukapura icon-themes/sukapura_dark icon-themes/sukapura_dark_svg icon-themes/sukapura_svg
icon-themes/sukapura/svx/res/a11y_check_issues_found.png |binary icon-themes/sukapura/svx/res/a11y_check_issues_not_found.png |binary icon-themes/sukapura_dark/svx/res/a11y_check_issues_found.png |binary icon-themes/sukapura_dark/svx/res/a11y_check_issues_not_found.png |binary icon-themes/sukapura_dark_svg/svx/res/a11y_check_issues_found.svg | 3135 ++ icon-themes/sukapura_dark_svg/svx/res/a11y_check_issues_not_found.svg |1 icon-themes/sukapura_svg/svx/res/a11y_check_issues_found.svg | 3135 ++ icon-themes/sukapura_svg/svx/res/a11y_check_issues_not_found.svg |1 8 files changed, 6272 insertions(+) New commits: commit 082d009b6a156faa74c9966b0dffc5fa6ce22287 Author: Rizal Muttaqin AuthorDate: Thu Mar 9 07:39:26 2023 +0700 Commit: Rizal Muttaqin CommitDate: Thu Mar 9 02:02:42 2023 + Sukapura: tdf#152887 Add status bar icons for Accessibility Check Change-Id: If5b556fe8263740f26b80961add87398e8b3eefe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148517 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin diff --git a/icon-themes/sukapura/svx/res/a11y_check_issues_found.png b/icon-themes/sukapura/svx/res/a11y_check_issues_found.png new file mode 100644 index ..b2840d0e2f19 Binary files /dev/null and b/icon-themes/sukapura/svx/res/a11y_check_issues_found.png differ diff --git a/icon-themes/sukapura/svx/res/a11y_check_issues_not_found.png b/icon-themes/sukapura/svx/res/a11y_check_issues_not_found.png new file mode 100644 index ..30d963e4d18b Binary files /dev/null and b/icon-themes/sukapura/svx/res/a11y_check_issues_not_found.png differ diff --git a/icon-themes/sukapura_dark/svx/res/a11y_check_issues_found.png b/icon-themes/sukapura_dark/svx/res/a11y_check_issues_found.png new file mode 100644 index ..1a5c3a7c200d Binary files /dev/null and b/icon-themes/sukapura_dark/svx/res/a11y_check_issues_found.png differ diff --git a/icon-themes/sukapura_dark/svx/res/a11y_check_issues_not_found.png b/icon-themes/sukapura_dark/svx/res/a11y_check_issues_not_found.png new file mode 100644 index ..f0bba9d40b96 Binary files /dev/null and b/icon-themes/sukapura_dark/svx/res/a11y_check_issues_not_found.png differ diff --git a/icon-themes/sukapura_dark_svg/svx/res/a11y_check_issues_found.svg b/icon-themes/sukapura_dark_svg/svx/res/a11y_check_issues_found.svg new file mode 100644 index ..4c43e62849d7 --- /dev/null +++ b/icon-themes/sukapura_dark_svg/svx/res/a11y_check_issues_found.svg @@ -0,0 +1,3135 @@ +http://www.w3.org/2000/svg; xmlns:xlink="http://www.w3.org/1999/xlink;>
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - sw/qa sw/source sw/uiconfig
sw/qa/uitest/ui/misc/misc.py| 12 +++ sw/source/ui/misc/contentcontroldlg.cxx | 36 +++ sw/source/uibase/inc/contentcontroldlg.hxx |2 sw/uiconfig/swriter/ui/contentcontroldlg.ui | 85 +--- 4 files changed, 128 insertions(+), 7 deletions(-) New commits: commit 234f7317e91b07f1bef1baa52c654fde038e6a4b Author: Justin Luth AuthorDate: Thu Feb 23 15:40:02 2023 -0500 Commit: Justin Luth CommitDate: Thu Mar 9 01:38:50 2023 + tdf#151548 sw content controls: add UI for Id and TabIndex This is my first go at adding anything to the UI. (I've done some fixing of other people's design, but never created anything new myself.) I took all my inspiration from Miklos' add110bad816fadeb96e7af0d4689389c04c263e. In the first iteration I did a fancy "same as id" scenario. But ID-as-unsigned, securing unique IDs, and English-only number recognition sadly made me decide to drop the fancy features. Now, both are simple, stand-alone spinbuttons that depend on tooltips to guide user input, not fancy comboboxes. It is important for the ID to display as unsigned, since that is how it is used as a "name" in VBA. It should be copy-pasteable for use in VBA programming. It is useful for the TABINDEX to display as signed, since it allows entering a -1 to disable tab navigation to the control. make UITest_sw_ui_misc Change-Id: Ia7c99888e60c33ac39616b24c7c1715604c3ec69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147591 Tested-by: Jenkins Reviewed-by: Justin Luth Reviewed-by: Miklos Vajna (cherry picked from commit 0d2a962c363632a890a994e7e143099c53ac4283) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147908 Tested-by: Justin Luth diff --git a/sw/qa/uitest/ui/misc/misc.py b/sw/qa/uitest/ui/misc/misc.py index 2b6307cefb61..8af00054a5e6 100644 --- a/sw/qa/uitest/ui/misc/misc.py +++ b/sw/qa/uitest/ui/misc/misc.py @@ -26,6 +26,7 @@ class TestTmpdlg(UITestCase): contentControl = portion.ContentControl contentControl.Alias = "my alias" contentControl.Tag = "my tag" +contentControl.TabIndex = "1" listItems = contentControl.ListItems self.assertEqual(len(listItems), 1) self.assertEqual(listItems[0][0].Name, "DisplayText") @@ -42,6 +43,15 @@ class TestTmpdlg(UITestCase): self.assertEqual(get_state_as_dict(xTag)['Text'], "my tag") type_text(xTag, "new tag ") xAdd = xDialog.getChild("add") + +xId = xDialog.getChild("idspinbutton") +self.assertEqual(get_state_as_dict(xId)['Text'], "0") +type_text(xId, "429496729") # added in front, making it 4294967290 + +xTabIndex = xDialog.getChild("tabindexspinbutton") +self.assertEqual(get_state_as_dict(xTabIndex)['Text'], "1") +type_text(xTabIndex, "-") # add a minus in front, making it -1 + with self.ui_test.execute_blocking_action(xAdd.executeAction, args=('CLICK', ())) as xSubDialog: xDisplayName = xSubDialog.getChild("displayname") type_text(xDisplayName, "Foo Bar") @@ -57,6 +67,8 @@ class TestTmpdlg(UITestCase): self.assertEqual(listItems[1][1].Value, "foo-bar") self.assertEqual(contentControl.Alias, "new alias my alias") self.assertEqual(contentControl.Tag, "new tag my tag") +self.assertEqual(contentControl.Id, -6) # stored as signed, displays as unsigned +self.assertEqual(contentControl.TabIndex, 4294967295) # stored as unsigned, displays as signed # vim: set shiftwidth=4 softtabstop=4 expandtab: diff --git a/sw/source/ui/misc/contentcontroldlg.cxx b/sw/source/ui/misc/contentcontroldlg.cxx index 3aeeab3c6306..f318fa6a699e 100644 --- a/sw/source/ui/misc/contentcontroldlg.cxx +++ b/sw/source/ui/misc/contentcontroldlg.cxx @@ -40,6 +40,8 @@ SwContentControlDlg::SwContentControlDlg(weld::Window* pParent, SwWrtShell& rWrt , m_xShowingPlaceHolderCB(m_xBuilder->weld_check_button("showing_place_holder")) , m_xAlias(m_xBuilder->weld_entry("aliasentry")) , m_xTag(m_xBuilder->weld_entry("tagentry")) +, m_xId(m_xBuilder->weld_spin_button("idspinbutton")) +, m_xTabIndex(m_xBuilder->weld_spin_button("tabindexspinbutton")) , m_xCheckboxFrame(m_xBuilder->weld_frame("checkboxframe")) , m_xCheckedState(m_xBuilder->weld_entry("checkboxcheckedentry")) , m_xCheckedStateBtn(m_xBuilder->weld_button("btncheckboxchecked")) @@ -108,6 +110,28 @@ SwContentControlDlg::SwContentControlDlg(weld::Window* pParent, SwWrtShell& rWrt m_xTag->save_value(); } +// The ID is supposed to be a unique ID, but it isn't really used for much +// and in MS Word it (supposedly) is
[Libreoffice-bugs] [Bug 154082] FILEOPEN DOCX: section starts after the top margin of the first paragraph in the section
https://bugs.documentfoundation.org/show_bug.cgi?id=154082 --- Comment #1 from Justin L --- It is probably worth nothing that the PDF is not actually a perfect representation of how it appears in MS Word 2019 - apparently what you see is not what you export to pdf. (Mainly the background colouring is off. The focus in any case is the position of the text relative to the top of the column, which is accurately shown in the PDF.) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154082] FILEOPEN DOCX: section starts after the top margin of the first paragraph in the section
https://bugs.documentfoundation.org/show_bug.cgi?id=154082 Justin L changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||3964 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 131304] [META] MS Word compatibilityMode = 15
https://bugs.documentfoundation.org/show_bug.cgi?id=131304 Bug 131304 depends on bug 153964, which changed state. Bug 153964 Summary: FILEOPEN DOCX COMPAT15: paragraph top margin should only apply once - affecting page/col breaks https://bugs.documentfoundation.org/show_bug.cgi?id=153964 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153964] FILEOPEN DOCX COMPAT15: paragraph top margin should only apply once - affecting page/col breaks
https://bugs.documentfoundation.org/show_bug.cgi?id=153964 Justin L changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |jl...@mail.com |desktop.org | See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||4082 Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #8 from Justin L --- Actually, let me close it since the description is all over the place. I'll open a new ticket to deal specifically with the section difference. bug 154082 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 107738] [META] Section bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107738 Justin L changed: What|Removed |Added Depends on||154082 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=154082 [Bug 154082] FILEOPEN DOCX: section starts after the top margin of the first paragraph in the section -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 104520] [META] DOCX (OOXML) bug tracker
https://bugs.documentfoundation.org/show_bug.cgi?id=104520 Justin L changed: What|Removed |Added Depends on||154082 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=154082 [Bug 154082] FILEOPEN DOCX: section starts after the top margin of the first paragraph in the section -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154082] New: FILEOPEN DOCX: section starts after the top margin of the first paragraph in the section
https://bugs.documentfoundation.org/show_bug.cgi?id=154082 Bug ID: 154082 Summary: FILEOPEN DOCX: section starts after the top margin of the first paragraph in the section Product: LibreOffice Version: Inherited From OOo Hardware: All OS: All Status: UNCONFIRMED Keywords: filter:docx, notBibisectable Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jl...@mail.com CC: jl...@mail.com Blocks: 104520, 107738 If a section starts with a back-ground coloured paragraph and a top margin of 100pts, you would expect to see a large coloured block above the text. And normally you do, except at the start of a section - where the block is just "empty". This is especially noticeable when the section has columns. The other columns don't start "at the top of the page", but "after the 100pt top margin". In other words, they are automatically aligned with the first paragraph's text. This is a fundamental difference between LO and MS Word. See bug 153964 where this was initially discussed, and is demonstrated by attachment 185823: sectionStart.odt. To reproduce: -open attachment 185749: columnMargin15.docx It should look like the compat15 version in attachment 185748. This is not bibisectable. I don't care if earlier versions imported the DOCX as page-columns instead of section-columns. The point of the bug report is about sections, so use sectionStart.odt if you want to do any bibisecting. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=104520 [Bug 104520] [META] DOCX (OOXML) bug tracker https://bugs.documentfoundation.org/show_bug.cgi?id=107738 [Bug 107738] [META] Section bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153964] FILEOPEN DOCX COMPAT15: paragraph top margin should only apply once - affecting page/col breaks
https://bugs.documentfoundation.org/show_bug.cgi?id=153964 Justin L changed: What|Removed |Added Whiteboard|target:7.6.0| Assignee|jl...@mail.com |libreoffice-b...@lists.free ||desktop.org -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154081] Unnumbered headings influence the numbering of numbered headings
https://bugs.documentfoundation.org/show_bug.cgi?id=154081 sdc.bla...@youmail.dk changed: What|Removed |Added Keywords||possibleRegression Blocks||103370 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103370 [Bug 103370] [META] Heading Numbering bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103370] [META] Heading Numbering bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103370 sdc.bla...@youmail.dk changed: What|Removed |Added Depends on||154081 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=154081 [Bug 154081] Unnumbered headings influence the numbering of numbered headings -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154081] New: Unnumbered headings influence the numbering of numbered headings
https://bugs.documentfoundation.org/show_bug.cgi?id=154081 Bug ID: 154081 Summary: Unnumbered headings influence the numbering of numbered headings Product: LibreOffice Version: 7.6.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: sdc.bla...@youmail.dk Created attachment 185853 --> https://bugs.documentfoundation.org/attachment.cgi?id=185853=edit demonstration of problem Attachment demonstrates the problem. 1. Tools - Chapter (Heading) Numbering, assign: Level Numbering 1 1,2,3 2 A,B,C show 2 sublevels 3 none show 3 sublevels (i.e., first two outline levels get numbering, third does not) Test document w/ three paragraphs with following PS 1 Heading 1 Heading 3 1.A heading 2 Critical "test": What numbering shown for outline level 2 (i.e., third paragraph)? RESULTS: Actual and expected (in 7.2.7.2): 1.A heading 2 Actual in 7.6.0.0.alpha0+: 1.B heading 2 Expected: 1.A heading 2 Additional test: Change unnumbered level 3 paragraph to "Text Body", then numbering on level 2 paragraph is as expected. => presence of unnumbered outline level 3 paragraph appears to increase the numbering for the outline level 2 paragraph. => seems like possible regression, because works as expected in 7.2.7.2 Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: a179f6c91692076e7e17babf4890638caa398384 CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: da-DK (da_DK); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 133764] [META] Very large spreadsheets problem
https://bugs.documentfoundation.org/show_bug.cgi?id=133764 Bug 133764 depends on bug 148143, which changed state. Bug 148143 Summary: CRASH: after pasting twice the whole sheet https://bugs.documentfoundation.org/show_bug.cgi?id=148143 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/qa writerfilter/source
sw/qa/extras/ooxmlexport/data/tdf153964_firstIndentAfterBreak14.docx |binary sw/qa/extras/ooxmlexport/data/tdf153964_numberingAfterBreak14.docx |binary sw/qa/extras/ooxmlexport/ooxmlexport18.cxx | 42 +- writerfilter/source/dmapper/DomainMapper.cxx |3 writerfilter/source/dmapper/DomainMapper_Impl.cxx| 15 +++ 5 files changed, 56 insertions(+), 4 deletions(-) New commits: commit 80e8763036f36afd482a06fbf0f3ffe1ebbe2b46 Author: Justin Luth AuthorDate: Tue Mar 7 20:26:22 2023 -0500 Commit: Justin Luth CommitDate: Thu Mar 9 00:33:26 2023 + tdf#153964 writerfilter: column break split should inherit most properties When a column break or page break split occurs, the split off paragraph should keep (most of) the properties of the original paragraph. This already happened for page breaks. Exceptions are first line indents, and numbering if there was a run to apply them to already. This commit: -tells lcl_startParagraph when column breaks are m_bIsParaSplit, resulting in the paragraph properties being copied over -clears the para properties that shouldn't apply twice. [Top Margin was more complicated and handled separately.] make CppunitTest_sw_ooxmlexport18 \ CPPUNIT_TEST_NAME=testTdf153964_firstIndentAfterBreak14 make CppunitTest_sw_ooxmlexport18 \ CPPUNIT_TEST_NAME=testTdf153964_numberingAfterBreak14 Change-Id: I5ecd25da831894536044c6dbffbb0a262f8b6828 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148452 Tested-by: Jenkins Reviewed-by: Justin Luth diff --git a/sw/qa/extras/ooxmlexport/data/tdf153964_firstIndentAfterBreak14.docx b/sw/qa/extras/ooxmlexport/data/tdf153964_firstIndentAfterBreak14.docx new file mode 100644 index ..696c4b4278c9 Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/tdf153964_firstIndentAfterBreak14.docx differ diff --git a/sw/qa/extras/ooxmlexport/data/tdf153964_numberingAfterBreak14.docx b/sw/qa/extras/ooxmlexport/data/tdf153964_numberingAfterBreak14.docx new file mode 100644 index ..a94a3c9736d7 Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/tdf153964_numberingAfterBreak14.docx differ diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport18.cxx b/sw/qa/extras/ooxmlexport/ooxmlexport18.cxx index 1e87210d90f8..770ea9a89dec 100644 --- a/sw/qa/extras/ooxmlexport/ooxmlexport18.cxx +++ b/sw/qa/extras/ooxmlexport/ooxmlexport18.cxx @@ -216,7 +216,7 @@ DECLARE_OOXMLEXPORT_TEST(testTdf153964_topMarginAfterBreak14, "tdf153964_topMarg // The top margin was applied to paragraph 3, so it shouldn't apply here xPara.set(getParagraph(4, u"column break1"), uno::UNO_QUERY); CPPUNIT_ASSERT_EQUAL(sal_Int32(0), getProperty(xPara, "ParaTopMargin")); -//CPPUNIT_ASSERT_EQUAL(Color(0xfbe4d5), getProperty(xPara, "ParaBackColor")); +CPPUNIT_ASSERT_EQUAL(Color(0xfbe4d5), getProperty(xPara, "ParaBackColor")); xPara.set(getParagraph(5, u"60 pt followed by page break"), uno::UNO_QUERY); CPPUNIT_ASSERT_EQUAL(sal_Int32(2117), getProperty(xPara, "ParaTopMargin")); @@ -240,7 +240,7 @@ DECLARE_OOXMLEXPORT_TEST(testTdf153964_topMarginAfterBreak14, "tdf153964_topMarg // The top margin was not applied before the column break, so with compat14 it should apply here xPara.set(getParagraph(10, u""), uno::UNO_QUERY); // after column break CPPUNIT_ASSERT_EQUAL(sal_Int32(2117), getProperty(xPara, "ParaTopMargin")); -//CPPUNIT_ASSERT_EQUAL(Color(0xfff2cc), getProperty(xPara, "ParaBackColor")); +CPPUNIT_ASSERT_EQUAL(Color(0xfff2cc), getProperty(xPara, "ParaBackColor")); // In an odd twist, the w:br was actually at the end of the previous w:p, so in that case // we ignore the top margin definition this time. @@ -262,7 +262,7 @@ DECLARE_OOXMLEXPORT_TEST(testTdf153964_topMarginAfterBreak15, "tdf153964_topMarg // The top margin was applied to paragraph 3, so it shouldn't apply here xPara.set(getParagraph(4, u"column break1"), uno::UNO_QUERY); CPPUNIT_ASSERT_EQUAL(sal_Int32(0), getProperty(xPara, "ParaTopMargin")); -//CPPUNIT_ASSERT_EQUAL(Color(0xfbe4d5), getProperty(xPara, "ParaBackColor")); +CPPUNIT_ASSERT_EQUAL(Color(0xfbe4d5), getProperty(xPara, "ParaBackColor")); xPara.set(getParagraph(5, u"60 pt followed by page break"), uno::UNO_QUERY); CPPUNIT_ASSERT_EQUAL(sal_Int32(2117), getProperty(xPara, "ParaTopMargin")); @@ -285,13 +285,47 @@ DECLARE_OOXMLEXPORT_TEST(testTdf153964_topMarginAfterBreak15, "tdf153964_topMarg // The top margin was not applied to paragraph 9, and with compat15 it shouldn't apply here. xPara.set(getParagraph(10, u""), uno::UNO_QUERY); // after column break CPPUNIT_ASSERT_EQUAL(sal_Int32(0), getProperty(xPara, "ParaTopMargin")); -//CPPUNIT_ASSERT_EQUAL(Color(0xfff2cc), getProperty(xPara,
[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - icon-themes/breeze icon-themes/breeze_dark icon-themes/breeze_dark_svg icon-themes/breeze_svg icon-themes/colibre icon-themes/colibre_dark ic
icon-themes/breeze/svx/res/a11y_check_issues_found.png |binary icon-themes/breeze/svx/res/a11y_check_issues_not_found.png |binary icon-themes/breeze_dark/svx/res/a11y_check_issues_found.png |binary icon-themes/breeze_dark/svx/res/a11y_check_issues_not_found.png |binary icon-themes/breeze_dark_svg/svx/res/a11y_check_issues_found.svg |1 + icon-themes/breeze_dark_svg/svx/res/a11y_check_issues_not_found.svg |1 + icon-themes/breeze_svg/svx/res/a11y_check_issues_found.svg |1 + icon-themes/breeze_svg/svx/res/a11y_check_issues_not_found.svg |1 + icon-themes/colibre/svx/res/a11y_check_issues_found.png |binary icon-themes/colibre/svx/res/a11y_check_issues_not_found.png |binary icon-themes/colibre_dark/svx/res/a11y_check_issues_found.png |binary icon-themes/colibre_dark/svx/res/a11y_check_issues_not_found.png |binary icon-themes/colibre_dark_svg/svx/res/a11y_check_issues_found.svg |1 + icon-themes/colibre_dark_svg/svx/res/a11y_check_issues_not_found.svg |2 ++ icon-themes/colibre_svg/svx/res/a11y_check_issues_found.svg |2 +- icon-themes/colibre_svg/svx/res/a11y_check_issues_not_found.svg |3 ++- icon-themes/karasa_jaga/svx/res/a11y_check_issues_found.png |binary icon-themes/karasa_jaga/svx/res/a11y_check_issues_not_found.png |binary icon-themes/karasa_jaga_svg/svx/res/a11y_check_issues_found.svg |1 + icon-themes/karasa_jaga_svg/svx/res/a11y_check_issues_not_found.svg |1 + icon-themes/sifr/svx/res/a11y_check_issues_found.png |binary icon-themes/sifr/svx/res/a11y_check_issues_not_found.png |binary icon-themes/sifr_dark/svx/res/a11y_check_issues_found.png|binary icon-themes/sifr_dark/svx/res/a11y_check_issues_not_found.png|binary icon-themes/sifr_dark_svg/svx/res/a11y_check_issues_found.svg|3 +++ icon-themes/sifr_dark_svg/svx/res/a11y_check_issues_not_found.svg|3 +++ icon-themes/sifr_svg/svx/res/a11y_check_issues_found.svg |3 +++ icon-themes/sifr_svg/svx/res/a11y_check_issues_not_found.svg |3 +++ 28 files changed, 24 insertions(+), 2 deletions(-) New commits: commit 72f44054e158545dd8642bb2d99ae87a116bea18 Author: Rizal Muttaqin AuthorDate: Wed Mar 8 15:40:42 2023 +0700 Commit: Rizal Muttaqin CommitDate: Thu Mar 9 00:33:36 2023 + tdf#152887 Add status bar icons for Accessibility Check Change-Id: Ied2b876938824c3504231988943851bd97265e44 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148466 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin (cherry picked from commit 6002b5ff598ed63ad8de259b04fc7a17789a1751) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148499 diff --git a/icon-themes/breeze/svx/res/a11y_check_issues_found.png b/icon-themes/breeze/svx/res/a11y_check_issues_found.png new file mode 100644 index ..446f5ba89528 Binary files /dev/null and b/icon-themes/breeze/svx/res/a11y_check_issues_found.png differ diff --git a/icon-themes/breeze/svx/res/a11y_check_issues_not_found.png b/icon-themes/breeze/svx/res/a11y_check_issues_not_found.png new file mode 100644 index ..ae6eefc74209 Binary files /dev/null and b/icon-themes/breeze/svx/res/a11y_check_issues_not_found.png differ diff --git a/icon-themes/breeze_dark/svx/res/a11y_check_issues_found.png b/icon-themes/breeze_dark/svx/res/a11y_check_issues_found.png new file mode 100644 index ..590ad2b3ecfb Binary files /dev/null and b/icon-themes/breeze_dark/svx/res/a11y_check_issues_found.png differ diff --git a/icon-themes/breeze_dark/svx/res/a11y_check_issues_not_found.png b/icon-themes/breeze_dark/svx/res/a11y_check_issues_not_found.png new file mode 100644 index ..e1f712de72b8 Binary files /dev/null and b/icon-themes/breeze_dark/svx/res/a11y_check_issues_not_found.png differ diff --git a/icon-themes/breeze_dark_svg/svx/res/a11y_check_issues_found.svg b/icon-themes/breeze_dark_svg/svx/res/a11y_check_issues_found.svg new file mode 100644 index ..a305bd9fbd73 --- /dev/null +++ b/icon-themes/breeze_dark_svg/svx/res/a11y_check_issues_found.svg @@ -0,0 +1 @@ +http://www.w3.org/2000/svg;> \ No newline at end of file diff --git a/icon-themes/breeze_dark_svg/svx/res/a11y_check_issues_not_found.svg b/icon-themes/breeze_dark_svg/svx/res/a11y_check_issues_not_found.svg new file mode 100644 index ..4862322da1ad --- /dev/null +++ b/icon-themes/breeze_dark_svg/svx/res/a11y_check_issues_not_found.svg @@ -0,0 +1 @@ +http://www.w3.org/2000/svg;> \ No newline at end of file diff --git a/icon-themes/breeze_svg/svx/res/a11y_check_issues_found.svg b/icon-themes/breeze_svg/svx/res/a11y_check_issues_found.svg new file mode 100644 index ..48ae1f4cf812 --- /dev/null +++ b/icon-themes/breeze_svg/svx/res/a11y_check_issues_found.svg @@ -0,0 +1 @@
Re: Re: OpenLDAP (with OpenSSL) build fails on Jenkins.
Hi, Yes, libssl-dev(libssl and libcrypto) installed on Ubuntu. Regards taichi --- sys.ad...@robotum.ai wrote: > Hey, > > did you have on this instance the both Develop - Library installed? > * libssl-dev > * libcrypt-ssl > > It seems, that it cańt find the Libraries > > Best regards > > > Z. Matthias > > > > > > > > >On Mittwoch, März 08, 2023 at 3:32 PM, taichi <20001...@ymail.ne.jp> wrote: > Hi. > I have built the OpenLDAP version used for LibreOfffice to 2.6.4 and changed > the TLS Library specified with --with-tls from NSS to OpenSSL. > The build was successful on my build environment (Ubuntu), but fails to build > on Jenkins. > (In Ubuntu)> SSL_export_keying_material_early in -lssl... yes > (In Jenkins)> SSL_export_keying_material_early in -lssl... no> configure: > error: Could not locate TLS/SSL package > Why does this error occur? > https://gerrit.libreoffice.org/c/core/+/143646 > (build environment)OS: Ubuntu 22.10compiler: gcc-12.2.0 > (options of > autogen.sh)CC=/usr/bin/gccCXX=/usr/bin/g++--enable-kf5--disable-dependency-tracking--with-jdk-home=/usr/lib/jvm/java-11-openjdk-amd64/--enable-odk--enable-mergelibs--disable-dconf--enable-python=internal > Regards,taichi >
[Libreoffice-bugs] [Bug 154069] no link to relevant help page for "Create new user-defined index"
https://bugs.documentfoundation.org/show_bug.cgi?id=154069 Olivier Hallot changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - sw/qa writerfilter/source
sw/qa/extras/ooxmlexport/data/tdf153964_topMarginAfterBreak14.docx |binary sw/qa/extras/ooxmlexport/data/tdf153964_topMarginAfterBreak15.docx |binary sw/qa/extras/ooxmlexport/ooxmlexport18.cxx | 101 +- writerfilter/source/dmapper/DomainMapper.cxx | 62 ++ 4 files changed, 156 insertions(+), 7 deletions(-) New commits: commit e099d21f540a0018687064953832163815549b2e Author: Justin Luth AuthorDate: Tue Mar 7 07:43:14 2023 -0500 Commit: Justin Luth CommitDate: Wed Mar 8 23:34:15 2023 + tdf#153964 writerfilter compat15: top margin after break split The problem was that the top margin was being applied to the new paragraph after the split. This is absolutely attrocious in MS Word before 2013. If I am going to be in error, I want to error on the side of being compliant with compat15, since all other versions of MS Word are now unsupported. I think I have the logic of it mostly figured out. In compat15, the top margin never applies after the break. In compat14, if the paragraph properties are not applied to a run before the break, then they can be applied after the break. make CppunitTest_sw_ooxmlexport18 \ CPPUNIT_TEST_NAME=testTdf153964_topMarginAfterBreak14 make CppunitTest_sw_ooxmlexport18 \ CPPUNIT_TEST_NAME=testTdf153964_topMarginAfterBreak15 Change-Id: I8816b391e898cfea58c2e0dbf01c881f87bbc4c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148451 Tested-by: Justin Luth Reviewed-by: Justin Luth Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148476 diff --git a/sw/qa/extras/ooxmlexport/data/tdf153964_topMarginAfterBreak14.docx b/sw/qa/extras/ooxmlexport/data/tdf153964_topMarginAfterBreak14.docx new file mode 100644 index ..6c57bcfdc8ef Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/tdf153964_topMarginAfterBreak14.docx differ diff --git a/sw/qa/extras/ooxmlexport/data/tdf153964_topMarginAfterBreak15.docx b/sw/qa/extras/ooxmlexport/data/tdf153964_topMarginAfterBreak15.docx new file mode 100644 index ..e4d5c45ed034 Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/tdf153964_topMarginAfterBreak15.docx differ diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport18.cxx b/sw/qa/extras/ooxmlexport/ooxmlexport18.cxx index 02d229f08f11..fc3ca2f99bf8 100644 --- a/sw/qa/extras/ooxmlexport/ooxmlexport18.cxx +++ b/sw/qa/extras/ooxmlexport/ooxmlexport18.cxx @@ -87,12 +87,6 @@ DECLARE_OOXMLEXPORT_TEST(testTdf153526_commentInNumbering, "tdf153526_commentInN CPPUNIT_ASSERT_EQUAL(13, getParagraphs()); } -DECLARE_OOXMLEXPORT_TEST(testTdf153613_sdtAfterPgBreak, "tdf153613_sdtAfterPgBreak.docx") -{ -// the page break was missing. Before the fix this was 1 page -CPPUNIT_ASSERT_EQUAL(2, getPages()); -} - CPPUNIT_TEST_FIXTURE(Test, testTdf153592_columnBreaks) { loadAndSave("tdf153592_columnBreaks.docx"); @@ -159,6 +153,101 @@ DECLARE_OOXMLEXPORT_TEST(testTdf153613_textboxAfterPgBreak2, "tdf153613_textboxA assertXPathContent(pLayout, "//page[2]/body/txt", "There should be no prior carriage return."); } +DECLARE_OOXMLEXPORT_TEST(testTdf153613_sdtAfterPgBreak, "tdf153613_sdtAfterPgBreak.docx") +{ +CPPUNIT_ASSERT_EQUAL(2, getPages()); +} + +DECLARE_OOXMLEXPORT_TEST(testTdf153964_topMarginAfterBreak14, "tdf153964_topMarginAfterBreak14.docx") +{ +//The top margin should only apply once in a split paragraph. +//In this compat14 (Windows 2010) version, it applies after the break if no prior visible run. +uno::Reference xPara(getParagraph(2, "a w:br at the start of the document. Does it use 60 point top margin?"), uno::UNO_QUERY); +//CPPUNIT_ASSERT_EQUAL(sal_Int32(2117), getProperty(xPara, "ParaTopMargin")); + +xPara.set(getParagraph(3, u"60 pt spacing before"), uno::UNO_QUERY); +CPPUNIT_ASSERT_EQUAL(sal_Int32(2117), getProperty(xPara, "ParaTopMargin")); +CPPUNIT_ASSERT_EQUAL(Color(0xfbe4d5), getProperty(xPara, "ParaBackColor")); + +// The top margin was applied to paragraph 3, so it shouldn't apply here +xPara.set(getParagraph(4, u"column break1"), uno::UNO_QUERY); +CPPUNIT_ASSERT_EQUAL(sal_Int32(0), getProperty(xPara, "ParaTopMargin")); +//CPPUNIT_ASSERT_EQUAL(Color(0xfbe4d5), getProperty(xPara, "ParaBackColor")); + +xPara.set(getParagraph(5, u"60 pt followed by page break"), uno::UNO_QUERY); +CPPUNIT_ASSERT_EQUAL(sal_Int32(2117), getProperty(xPara, "ParaTopMargin")); +CPPUNIT_ASSERT_EQUAL(Color(0xdeeaf6), getProperty(xPara, "ParaBackColor")); + +// The top margin was applied to paragraph 5, so it shouldn't apply here +xPara.set(getParagraph(6, u"page break1"), uno::UNO_QUERY); +CPPUNIT_ASSERT_EQUAL(sal_Int32(0), getProperty(xPara, "ParaTopMargin")); +CPPUNIT_ASSERT_EQUAL(Color(0xdeeaf6), getProperty(xPara, "ParaBackColor")); + +// The top margin was not
[Libreoffice-bugs] [Bug 154080] Comment indicator is too small, non-circumspect, easy to miss
https://bugs.documentfoundation.org/show_bug.cgi?id=154080 Eyal Rozenberg changed: What|Removed |Added Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152887] Online/automatic accessibility check needs new icons for the status bar
https://bugs.documentfoundation.org/show_bug.cgi?id=152887 Rizal Muttaqin changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |riz...@libreoffice.org |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: icon-themes/breeze icon-themes/breeze_dark icon-themes/breeze_dark_svg icon-themes/breeze_svg icon-themes/colibre icon-themes/colibre_dark icon-themes/colibre_dark_svg
icon-themes/breeze/svx/res/a11y_check_issues_found.png |binary icon-themes/breeze/svx/res/a11y_check_issues_not_found.png |binary icon-themes/breeze_dark/svx/res/a11y_check_issues_found.png |binary icon-themes/breeze_dark/svx/res/a11y_check_issues_not_found.png |binary icon-themes/breeze_dark_svg/svx/res/a11y_check_issues_found.svg |1 + icon-themes/breeze_dark_svg/svx/res/a11y_check_issues_not_found.svg |1 + icon-themes/breeze_svg/svx/res/a11y_check_issues_found.svg |1 + icon-themes/breeze_svg/svx/res/a11y_check_issues_not_found.svg |1 + icon-themes/colibre/svx/res/a11y_check_issues_found.png |binary icon-themes/colibre/svx/res/a11y_check_issues_not_found.png |binary icon-themes/colibre_dark/svx/res/a11y_check_issues_found.png |binary icon-themes/colibre_dark/svx/res/a11y_check_issues_not_found.png |binary icon-themes/colibre_dark_svg/svx/res/a11y_check_issues_found.svg |1 + icon-themes/colibre_dark_svg/svx/res/a11y_check_issues_not_found.svg |2 ++ icon-themes/colibre_svg/svx/res/a11y_check_issues_found.svg |2 +- icon-themes/colibre_svg/svx/res/a11y_check_issues_not_found.svg |3 ++- icon-themes/karasa_jaga/svx/res/a11y_check_issues_found.png |binary icon-themes/karasa_jaga/svx/res/a11y_check_issues_not_found.png |binary icon-themes/karasa_jaga_svg/svx/res/a11y_check_issues_found.svg |1 + icon-themes/karasa_jaga_svg/svx/res/a11y_check_issues_not_found.svg |1 + icon-themes/sifr/svx/res/a11y_check_issues_found.png |binary icon-themes/sifr/svx/res/a11y_check_issues_not_found.png |binary icon-themes/sifr_dark/svx/res/a11y_check_issues_found.png|binary icon-themes/sifr_dark/svx/res/a11y_check_issues_not_found.png|binary icon-themes/sifr_dark_svg/svx/res/a11y_check_issues_found.svg|3 +++ icon-themes/sifr_dark_svg/svx/res/a11y_check_issues_not_found.svg|3 +++ icon-themes/sifr_svg/svx/res/a11y_check_issues_found.svg |3 +++ icon-themes/sifr_svg/svx/res/a11y_check_issues_not_found.svg |3 +++ 28 files changed, 24 insertions(+), 2 deletions(-) New commits: commit 6002b5ff598ed63ad8de259b04fc7a17789a1751 Author: Rizal Muttaqin AuthorDate: Wed Mar 8 15:40:42 2023 +0700 Commit: Rizal Muttaqin CommitDate: Wed Mar 8 23:27:00 2023 + tdf#152887 Add status bar icons for Accessibility Check Change-Id: Ied2b876938824c3504231988943851bd97265e44 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148466 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin diff --git a/icon-themes/breeze/svx/res/a11y_check_issues_found.png b/icon-themes/breeze/svx/res/a11y_check_issues_found.png new file mode 100644 index ..446f5ba89528 Binary files /dev/null and b/icon-themes/breeze/svx/res/a11y_check_issues_found.png differ diff --git a/icon-themes/breeze/svx/res/a11y_check_issues_not_found.png b/icon-themes/breeze/svx/res/a11y_check_issues_not_found.png new file mode 100644 index ..ae6eefc74209 Binary files /dev/null and b/icon-themes/breeze/svx/res/a11y_check_issues_not_found.png differ diff --git a/icon-themes/breeze_dark/svx/res/a11y_check_issues_found.png b/icon-themes/breeze_dark/svx/res/a11y_check_issues_found.png new file mode 100644 index ..590ad2b3ecfb Binary files /dev/null and b/icon-themes/breeze_dark/svx/res/a11y_check_issues_found.png differ diff --git a/icon-themes/breeze_dark/svx/res/a11y_check_issues_not_found.png b/icon-themes/breeze_dark/svx/res/a11y_check_issues_not_found.png new file mode 100644 index ..e1f712de72b8 Binary files /dev/null and b/icon-themes/breeze_dark/svx/res/a11y_check_issues_not_found.png differ diff --git a/icon-themes/breeze_dark_svg/svx/res/a11y_check_issues_found.svg b/icon-themes/breeze_dark_svg/svx/res/a11y_check_issues_found.svg new file mode 100644 index ..a305bd9fbd73 --- /dev/null +++ b/icon-themes/breeze_dark_svg/svx/res/a11y_check_issues_found.svg @@ -0,0 +1 @@ +http://www.w3.org/2000/svg;> \ No newline at end of file diff --git a/icon-themes/breeze_dark_svg/svx/res/a11y_check_issues_not_found.svg b/icon-themes/breeze_dark_svg/svx/res/a11y_check_issues_not_found.svg new file mode 100644 index ..4862322da1ad --- /dev/null +++ b/icon-themes/breeze_dark_svg/svx/res/a11y_check_issues_not_found.svg @@ -0,0 +1 @@ +http://www.w3.org/2000/svg;> \ No newline at end of file diff --git a/icon-themes/breeze_svg/svx/res/a11y_check_issues_found.svg b/icon-themes/breeze_svg/svx/res/a11y_check_issues_found.svg new file mode 100644 index ..48ae1f4cf812 --- /dev/null +++ b/icon-themes/breeze_svg/svx/res/a11y_check_issues_found.svg @@ -0,0 +1 @@ +http://www.w3.org/2000/svg;> \ No newline at end of file diff --git a/icon-themes/breeze_svg/svx/res/a11y_check_issues_not_found.svg
[Libreoffice-bugs] [Bug 152887] Online/automatic accessibility check needs new icons for the status bar
https://bugs.documentfoundation.org/show_bug.cgi?id=152887 Commit Notification changed: What|Removed |Added Whiteboard|| target:7.6.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154066] Unable to undo attributes part of cell's area
https://bugs.documentfoundation.org/show_bug.cgi?id=154066 m.a.riosv changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED CC||miguelangelrv@libreoffice.o ||rg --- Comment #3 from m.a.riosv --- *** This bug has been marked as a duplicate of bug 154044 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154044] Undoing the first applied cell formatting only works for column A
https://bugs.documentfoundation.org/show_bug.cgi?id=154044 m.a.riosv changed: What|Removed |Added CC||nfsmob...@mail.ru --- Comment #2 from m.a.riosv --- *** Bug 154066 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154080] Comment indicator is too small, non-circumspect, easy to miss
https://bugs.documentfoundation.org/show_bug.cgi?id=154080 m.a.riosv changed: What|Removed |Added Severity|normal |enhancement -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151273] With qt5 and qfont, characters overlap in autofit text box, unreadable
https://bugs.documentfoundation.org/show_bug.cgi?id=151273 --- Comment #19 from Eyal Rozenberg --- (In reply to Michael Weghorn from comment #18) > (In reply to Eyal Rozenberg from comment #15) > What we can still consider is switching the default from 2) to 1), i.e. > people that only set SAL_USE_VCLPLUGIN=qt5 get the more mature Cairo > rendering by default. And then introduce some new environment variable > (maybe sth like SAL_VCL_QT5_USE_QFONT_RENDERING) to explicitly switch to the > experimental QFont rendering. I'm very much in favor of that: The default should be the more robustly-implemented alternative. Unless there's some strong argument to the contrary I'm not aware of? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - sw/qa writerfilter/source
sw/qa/extras/ooxmlexport/data/tdf153613_inlineAfterPgBreak2.docx |binary sw/qa/extras/ooxmlexport/ooxmlexport18.cxx | 12 sw/qa/extras/rtfexport/data/tdf153613_inlineAfterPgBreak2.rtf| 265 ++ sw/qa/extras/rtfexport/rtfexport5.cxx| 12 writerfilter/source/dmapper/DomainMapper.cxx | 16 5 files changed, 302 insertions(+), 3 deletions(-) New commits: commit 19c189557d4c2cd3bd1eaff95f8c853dc4a4346c Author: Justin Luth AuthorDate: Thu Feb 16 09:16:39 2023 -0500 Commit: Justin Luth CommitDate: Wed Mar 8 22:42:49 2023 + tdf#153613 writerfilter: split para for inline too if not FirstRun If we have some stuff in a character run (i.e some text usually) and then a page break and then an inline image, then the inline image should start a new paragraph and move to the following page. Only anchored images don't necessarily move to the next page. make CppunitTest_sw_ooxmlexport18 CPPUNIT_TEST_NAME=testTdf153613_inlineAfterPgBreak2 make CppunitTest_sw_rtfexport5 CPPUNIT_TEST_NAME=testTdf153613_inlineAfterPgBreak2 Change-Id: I756f756d836b29eedc776a35b7667ba33e6cdebd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147170 Tested-by: Jenkins Reviewed-by: Justin Luth Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147180 Tested-by: Justin Luth diff --git a/sw/qa/extras/ooxmlexport/data/tdf153613_inlineAfterPgBreak2.docx b/sw/qa/extras/ooxmlexport/data/tdf153613_inlineAfterPgBreak2.docx new file mode 100644 index ..c8fe50ea3fa2 Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/tdf153613_inlineAfterPgBreak2.docx differ diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport18.cxx b/sw/qa/extras/ooxmlexport/ooxmlexport18.cxx index 3b26dded9fbc..02d229f08f11 100644 --- a/sw/qa/extras/ooxmlexport/ooxmlexport18.cxx +++ b/sw/qa/extras/ooxmlexport/ooxmlexport18.cxx @@ -130,6 +130,18 @@ DECLARE_OOXMLEXPORT_TEST(testTdf153613_inlineAfterPgBreak, "tdf153613_inlineAfte assertXPath(pLayout, "//page[2]//anchored", 1); } +DECLARE_OOXMLEXPORT_TEST(testTdf153613_inlineAfterPgBreak2, "tdf153613_inlineAfterPgBreak2.docx") +{ +// An inline AS character image moves to the following page when after the page break. +// The difference from the previous test is that it is not the first character run +CPPUNIT_ASSERT_EQUAL(2, getPages()); +CPPUNIT_ASSERT_EQUAL(4, getParagraphs()); + +const auto& pLayout = parseLayoutDump(); +CPPUNIT_ASSERT_EQUAL(OUString("x"), getXPathContent(pLayout, "//page[1]/body/txt[2]")); +assertXPath(pLayout, "//page[2]//anchored", 1); +} + DECLARE_OOXMLEXPORT_TEST(testTdf153613_textboxAfterPgBreak, "tdf153613_textboxAfterPgBreak.docx") { CPPUNIT_ASSERT_EQUAL(3, getParagraphs()); diff --git a/sw/qa/extras/rtfexport/data/tdf153613_inlineAfterPgBreak2.rtf b/sw/qa/extras/rtfexport/data/tdf153613_inlineAfterPgBreak2.rtf new file mode 100644 index ..43e43377f86b --- /dev/null +++ b/sw/qa/extras/rtfexport/data/tdf153613_inlineAfterPgBreak2.rtf @@ -0,0 +1,265 @@ +{\rtf1\adeflang1025\ansi\ansicpg1252\uc1\adeff31507\deff0\stshfdbch31506\stshfloch31506\stshfhich31506\stshfbi31507\deflang2057\deflangfe2057\themelang1038\themelangfe0\themelangcs1025{\fonttbl{\f1\fbidi \fswiss\fcharset0\fprq2{\*\panose 020b0604020202020204}Arial;}{\f34\fbidi \froman\fcharset0\fprq2{\*\panose 02040503050406030204}Cambria Math;} +{\f37\fbidi \fswiss\fcharset0\fprq2{\*\panose 020f0502020204030204}Calibri;}{\f38\fbidi \fswiss\fcharset0\fprq2{\*\panose 020b0604030504040204}Tahoma;}{\flomajor\f31500\fbidi \froman\fcharset0\fprq2{\*\panose 02020603050405020304}Times New Roman;} +{\fdbmajor\f31501\fbidi \froman\fcharset0\fprq2{\*\panose 02020603050405020304}Times New Roman;}{\fhimajor\f31502\fbidi \fswiss\fcharset0\fprq2{\*\panose 020f0302020204030204}Calibri Light{\*\falt Calibri};} +{\fbimajor\f31503\fbidi \froman\fcharset0\fprq2{\*\panose 02020603050405020304}Times New Roman;}{\flominor\f31504\fbidi \froman\fcharset0\fprq2{\*\panose 02020603050405020304}Times New Roman;} +{\fdbminor\f31505\fbidi \froman\fcharset0\fprq2{\*\panose 02020603050405020304}Times New Roman;}{\fhiminor\f31506\fbidi \fswiss\fcharset0\fprq2{\*\panose 020f0502020204030204}Calibri;} +{\fbiminor\f31507\fbidi \fswiss\fcharset0\fprq2{\*\panose 020b0604020202020204}Arial;}{\f240\fbidi \fswiss\fcharset238\fprq2 Arial CE;}{\f241\fbidi \fswiss\fcharset204\fprq2 Arial Cyr;}{\f243\fbidi \fswiss\fcharset161\fprq2 Arial Greek;} +{\f244\fbidi \fswiss\fcharset162\fprq2 Arial Tur;}{\f245\fbidi \fswiss\fcharset177\fprq2 Arial (Hebrew);}{\f246\fbidi \fswiss\fcharset178\fprq2 Arial (Arabic);}{\f247\fbidi \fswiss\fcharset186\fprq2 Arial Baltic;} +{\f248\fbidi \fswiss\fcharset163\fprq2 Arial (Vietnamese);}{\f570\fbidi \froman\fcharset238\fprq2 Cambria Math CE;}{\f571\fbidi \froman\fcharset204\fprq2 Cambria Math
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - sw/qa writerfilter/source
sw/qa/extras/ooxmlexport/data/tdf153613_textboxAfterPgBreak.docx |binary sw/qa/extras/ooxmlexport/data/tdf153613_textboxAfterPgBreak2.docx |binary sw/qa/extras/ooxmlexport/ooxmlexport18.cxx| 17 ++ sw/qa/extras/rtfexport/data/n818997B.rtf | 77 ++ sw/qa/extras/rtfexport/rtfexport5.cxx |6 writerfilter/source/dmapper/DomainMapper.cxx | 16 +- 6 files changed, 108 insertions(+), 8 deletions(-) New commits: commit 943a6a3b627d88a88bc2441d060c35987e3fc7c2 Author: Justin Luth AuthorDate: Wed Feb 15 13:54:31 2023 -0500 Commit: Justin Luth CommitDate: Wed Mar 8 22:39:16 2023 + tdf#153613 writerfilter: don't always split para for shape w/ pagebreak The problem was that an extra paragraph was added, and the shape was anchored to the wrong page. There are lots of places that handle deferred breaks, and they typically do this only for FirstParagraph or non-first character properties run. This is needed here too. make CppunitTest_sw_ooxmlexport18 CPPUNIT_TEST_NAME=testTdf153613_textboxAfterPgBreak make CppunitTest_sw_ooxmlexport18 CPPUNIT_TEST_NAME=testTdf153613_textboxAfterPgBreak2 Of course, RTF is goofy, so handle that as an exception to just leave it alone as it has been. To solve it properly is likely very tricky - as are all things RTF, because we can't trust IsFirstRun in general and especially not for RTF. make CppunitTest_sw_rtfexport5 CPPUNIT_TEST_NAME=testN818997B Change-Id: Iad06f3ea9684a2860ae6ba724887bdf0b5850f94 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147169 Tested-by: Jenkins Reviewed-by: Justin Luth Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147179 Tested-by: Justin Luth diff --git a/sw/qa/extras/ooxmlexport/data/tdf153613_textboxAfterPgBreak.docx b/sw/qa/extras/ooxmlexport/data/tdf153613_textboxAfterPgBreak.docx new file mode 100644 index ..4ad4dfba8110 Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/tdf153613_textboxAfterPgBreak.docx differ diff --git a/sw/qa/extras/ooxmlexport/data/tdf153613_textboxAfterPgBreak2.docx b/sw/qa/extras/ooxmlexport/data/tdf153613_textboxAfterPgBreak2.docx new file mode 100644 index ..26006abd2fe3 Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/tdf153613_textboxAfterPgBreak2.docx differ diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport18.cxx b/sw/qa/extras/ooxmlexport/ooxmlexport18.cxx index f6d1d48094f0..3b26dded9fbc 100644 --- a/sw/qa/extras/ooxmlexport/ooxmlexport18.cxx +++ b/sw/qa/extras/ooxmlexport/ooxmlexport18.cxx @@ -130,6 +130,23 @@ DECLARE_OOXMLEXPORT_TEST(testTdf153613_inlineAfterPgBreak, "tdf153613_inlineAfte assertXPath(pLayout, "//page[2]//anchored", 1); } +DECLARE_OOXMLEXPORT_TEST(testTdf153613_textboxAfterPgBreak, "tdf153613_textboxAfterPgBreak.docx") +{ +CPPUNIT_ASSERT_EQUAL(3, getParagraphs()); + +const auto& pLayout = parseLayoutDump(); +assertXPathContent(pLayout, "//page[2]/body/txt", "There should be no prior carriage return."); +} + +DECLARE_OOXMLEXPORT_TEST(testTdf153613_textboxAfterPgBreak2, "tdf153613_textboxAfterPgBreak2.docx") +{ +// same as previous example, except that it is the first paragraph in the section. +CPPUNIT_ASSERT_EQUAL(2, getParagraphs()); + +const auto& pLayout = parseLayoutDump(); +assertXPathContent(pLayout, "//page[2]/body/txt", "There should be no prior carriage return."); +} + CPPUNIT_TEST_FIXTURE(Test, testTdf149551_mongolianVert) { // Given a docx document with a shape with vert="mongolianVert". diff --git a/sw/qa/extras/rtfexport/data/n818997B.rtf b/sw/qa/extras/rtfexport/data/n818997B.rtf new file mode 100644 index ..94c0324f42e8 --- /dev/null +++ b/sw/qa/extras/rtfexport/data/n818997B.rtf @@ -0,0 +1,77 @@ +{\rtf +{\par\par\shp +{\*\shpinst\shpleft2310\shpright6060\shptop8685\shpbottom8985\shpbxpage +\shpbypage\shpwr3\shpz2 +{\sp +{\sn shapeType} +{\sv 202} +} +{\sp +{\sn dxTextLeft} +{\sv +0} +} +{\sp +{\sn dxTextRight} +{\sv 0} +} +{\sp +{\sn dyTextTop} +{\sv 0} +} +{\sp +{\sn +dyTextBottom} +{\sv 0} +} +{\sp +{\sn fLine} +{\sv 0} +} +{\shptxt\plain\pard\f29\fs24 +On first page.\par} +{\sp +{\sn fFilled} +{\sv 0} +} +} +} +\page +{\shp +{\*\shpinst\shpleft4800\shpright8025\shptop780\shpbottom1080\shpbxpage +\shpbypage\shpwr3\shpz2 +{\sp +{\sn shapeType} +{\sv 202} +} +{\sp +{\sn dxTextLeft} +{\sv +0} +} +{\sp +{\sn dxTextRight} +{\sv 0} +} +{\sp +{\sn dyTextTop} +{\sv 0} +} +{\sp +{\sn +dyTextBottom} +{\sv 0} +} +{\sp +{\sn fLine} +{\sv 0} +} +{\shptxt\plain\pard\f29\fs24\b +On second page.\par} +{\sp +{\sn fFilled} +{\sv 0} +} +} +} +} diff --git a/sw/qa/extras/rtfexport/rtfexport5.cxx b/sw/qa/extras/rtfexport/rtfexport5.cxx index 751269daac03..8d122ec97b63 100644 --- a/sw/qa/extras/rtfexport/rtfexport5.cxx +++
[Libreoffice-bugs] [Bug 154075] Calc's F4 absolute cycle is sub-optimal when starting from a sheet-only absolute reference
https://bugs.documentfoundation.org/show_bug.cgi?id=154075 --- Comment #6 from Justin L --- (In reply to ady from comment #3) > I cannot reproduce your sequence. Sorry - I mis-read. I thought you said there was an existing case where your SUGGESTION was followed. Although I have no intention of proposing that this be accepted, I have coded up your suggested sequence. https://gerrit.libreoffice.org/c/core/+/148516 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153410] Style list changes scroll bar position to 'active' style after deleting a style
https://bugs.documentfoundation.org/show_bug.cgi?id=153410 --- Comment #6 from Eyal Rozenberg --- (In reply to Heiko Tietze from comment #5) > The Stylist is a single-selection tree where one node is always selected. It doesn't have to have one node always selected. It could be a single-selection tree in which _at most_ one node is selected. Also, that's only one of two options for resolving this bug. > After deleting the selected node the currently active style becomes > selected. And by default the tree scrolls to this position to give proper > feedback. How is that feedback in any way proper? Typically, the focused element's style has not even changed, and the selected item before the deletion was not the active one. So how is such feedback in any way related to what the user has just done? No, this is _improper_ feedback. Wrong feedback. A bug. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153792] Chart with drawing object going beyond the chart results in distorted, scaled down chart elements
https://bugs.documentfoundation.org/show_bug.cgi?id=153792 --- Comment #6 from wpeat...@gmail.com --- In my version of LibO (7.2.7.2) and OS (Windoze), I always get funny behavior when I have a drawn line in a chart and then copy and paste said chart. It doesn't matter if the line is inside or outside the chart axes. It can be a regular line or a freeform line. So to respond to stragu and vsfoote, the only way I know to create a line that extends outside the chart area is to copy and paste the chart and it will happen automatically. If you look at the attached file, the original chart is on the first sheet ("data and chart"). The pasted charts are on the second sheet ("chart copies"). Other drawing objects are well behaved. Boxes, text boxes. Even callouts (which have lines) will copy and paste fine. Polygons are wonky. You can't draw them inside of a chart. But if you paste one inside of a chart, it will not behave well when the whole chart is copied and pasted. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 137931] Show the UI selection dialog on first start-up
https://bugs.documentfoundation.org/show_bug.cgi?id=137931 --- Comment #14 from Eyal Rozenberg --- About a light/dark choice on that dialog: Do you guys also want that choice to be available via View | User Interface on the menus , or do you want a different, special dialog for the first startup? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154080] Comment indicator is too small, non-circumspect, easy to miss
https://bugs.documentfoundation.org/show_bug.cgi?id=154080 Eyal Rozenberg changed: What|Removed |Added Summary|Comment indicator is too|Comment indicator is too |non-circumspect, easy to|small, non-circumspect, |miss|easy to miss --- Comment #5 from Eyal Rozenberg --- I'll clarify the ask here: It's not about the size per se, but the visibility. If the indicator is visible enough, I don't mind that it's small. Enlargment is just one possible way of increasing its visibility. I'll also repeat a comment I made on bug 153106: The patch for 91415 improved the situation by switching to a triangle for, which I find more visible (but it also introduced scaling at different zoom levels, which may be problematic.) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154080] Comment indicator is too non-circumspect, easy to miss
https://bugs.documentfoundation.org/show_bug.cgi?id=154080 Eyal Rozenberg changed: What|Removed |Added Summary|Comment indicator is too|Comment indicator is too |small, non-circumspect, |non-circumspect, easy to |easy to miss|miss -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 56677] Comment indicator too small
https://bugs.documentfoundation.org/show_bug.cgi?id=56677 --- Comment #7 from Eyal Rozenberg --- To followers of the old bug: I claim that this has _not_ been fixed, at least not in the release version. You may also want to look at what's happened on bug 91415, which has bearing on this. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147760] DOCX export: Writer adds timestamps to the anonymized tracked changes
https://bugs.documentfoundation.org/show_bug.cgi?id=147760 László Németh changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||6904 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 136904] Crash swlo!SwRedlineData::operator!=+0x177 (steps in comment 7)
https://bugs.documentfoundation.org/show_bug.cgi?id=136904 László Németh changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||7760 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 136904] Crash swlo!SwRedlineData::operator!=+0x177 (steps in comment 7)
https://bugs.documentfoundation.org/show_bug.cgi?id=136904 László Németh changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||1176 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 133092] [META] Crash bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=133092 Bug 133092 depends on bug 136904, which changed state. Bug 136904 Summary: Crash swlo!SwRedlineData::operator!=+0x177 (steps in comment 7) https://bugs.documentfoundation.org/show_bug.cgi?id=136904 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 83946] [META] Tracking changes issues
https://bugs.documentfoundation.org/show_bug.cgi?id=83946 Bug 83946 depends on bug 136904, which changed state. Bug 136904 Summary: Crash swlo!SwRedlineData::operator!=+0x177 (steps in comment 7) https://bugs.documentfoundation.org/show_bug.cgi?id=136904 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 136904] Crash swlo!SwRedlineData::operator!=+0x177 (steps in comment 7)
https://bugs.documentfoundation.org/show_bug.cgi?id=136904 László Németh changed: What|Removed |Added Assignee|nem...@numbertext.org |libreoffice-b...@lists.free ||desktop.org Resolution|--- |FIXED Status|ASSIGNED|RESOLVED --- Comment #19 from László Németh --- @Telesto: very nice catch! Thanks! @Xisco, Buovjaga, Hossein: Thanks for bibisecting and feedback! Commit description: tdf#136904 tdf#116084 tdf#121176 sw: fix Undo & anonymized w:del in w:ins Undo/Redo crash resulted by the workaround for anonymized w:del in w:ins. Anonymized (no time stamp) redlines are loaded with Epoch time (1970-01-01) since commit 2c51746997478ad5d0e7cc64aa6489769c473d43 "tdf#146171 DOCX: fix loss of change tracking, if no date", so it's possible to fix the original DOCX import problem using this value: don't combine anonymized deletion inside/over anonymized insertion, and remove all the workaround, keeping only their adjusted unit tests, and add new tests for the export fixed finally, which keeps anonymized w:del in anonymized w:ins. Revert commit 2de1fd7d8b8bd42c66190140cc4506df0c3367f1 "tdf#125187 DOCX track changes: fix w:del within w:ins", commit df4f405a153603551f67e289bbaccf9ac39b923c "tdf#121176 DOCX track changes: same size w:del in w:ins" and commit 7a810d6a9fb79a24d00e5dbd8e1223e6f8b09677 "tdf#116084 DOCX track changes: fix w:del within w:ins". Regression from commit 2de1fd7d8b8bd42c66190140cc4506df0c3367f1 "tdf#125187 DOCX track changes: fix w:del within w:ins". See also commit 64dcedcf7c073d1819794d68a33651b14877e1b5 "tdf#147760 tdf#142902 DOCX export: anonymize date and moveFromRangeStart". -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - sw/qa
sw/qa/extras/rtfexport/data/tdf153613_anchoredAfterPgBreak.rtf | 268 +++ sw/qa/extras/rtfexport/data/tdf153613_anchoredAfterPgBreak2.rtf | 269 +++ sw/qa/extras/rtfexport/data/tdf153613_anchoredAfterPgBreak4.rtf | 268 +++ sw/qa/extras/rtfexport/data/tdf153613_anchoredAfterPgBreak5.rtf | 365 ++ sw/qa/extras/rtfexport/data/tdf153613_inlineAfterPgBreak.rtf| 265 +++ sw/qa/extras/rtfexport/rtfexport5.cxx | 52 + 6 files changed, 1487 insertions(+) New commits: commit 8dff0eea623a17c0f6377a4927068b7793b34d1a Author: Justin Luth AuthorDate: Thu Feb 16 10:08:50 2023 -0500 Commit: Justin Luth CommitDate: Wed Mar 8 21:41:10 2023 + tdf#153613 writerfilter: RTF pre-emptive tests Anchored tests 1 and 5 were fixed by the previous commit. make CppunitTest_sw_rtfexport5 \ CPPUNIT_TEST_NAME=testTdf153613_anchoredAfterPgBreak make CppunitTest_sw_rtfexport5 \ CPPUNIT_TEST_NAME=testTdf153613_anchoredAfterPgBreak2 make CppunitTest_sw_rtfexport5 \ CPPUNIT_TEST_NAME=testTdf153613_anchoredAfterPgBreak4 make CppunitTest_sw_rtfexport5 \ CPPUNIT_TEST_NAME=testTdf153613_anchoredAfterPgBreak5 make CppunitTest_sw_rtfexport5 \ CPPUNIT_TEST_NAME=testTdf153613_inlineAfterPgBreak Change-Id: I5e92330ed95c5c6409d2e4743ccdb7a0a331b4f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147167 Tested-by: Jenkins Reviewed-by: Justin Luth Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147178 Tested-by: Justin Luth diff --git a/sw/qa/extras/rtfexport/data/tdf153613_anchoredAfterPgBreak.rtf b/sw/qa/extras/rtfexport/data/tdf153613_anchoredAfterPgBreak.rtf new file mode 100644 index ..f1b1556f37e9 --- /dev/null +++ b/sw/qa/extras/rtfexport/data/tdf153613_anchoredAfterPgBreak.rtf @@ -0,0 +1,268 @@ +{\rtf1\adeflang1025\ansi\ansicpg1252\uc1\adeff31507\deff0\stshfdbch31506\stshfloch31506\stshfhich31506\stshfbi31507\deflang2057\deflangfe2057\themelang1038\themelangfe0\themelangcs1025{\fonttbl{\f1\fbidi \fswiss\fcharset0\fprq2{\*\panose 020b0604020202020204}Arial;}{\f34\fbidi \froman\fcharset0\fprq2{\*\panose 02040503050406030204}Cambria Math;} +{\f37\fbidi \fswiss\fcharset0\fprq2{\*\panose 020f0502020204030204}Calibri;}{\f38\fbidi \fswiss\fcharset0\fprq2{\*\panose 020b0604030504040204}Tahoma;}{\flomajor\f31500\fbidi \froman\fcharset0\fprq2{\*\panose 02020603050405020304}Times New Roman;} +{\fdbmajor\f31501\fbidi \froman\fcharset0\fprq2{\*\panose 02020603050405020304}Times New Roman;}{\fhimajor\f31502\fbidi \fswiss\fcharset0\fprq2{\*\panose 020f0302020204030204}Calibri Light{\*\falt Calibri};} +{\fbimajor\f31503\fbidi \froman\fcharset0\fprq2{\*\panose 02020603050405020304}Times New Roman;}{\flominor\f31504\fbidi \froman\fcharset0\fprq2{\*\panose 02020603050405020304}Times New Roman;} +{\fdbminor\f31505\fbidi \froman\fcharset0\fprq2{\*\panose 02020603050405020304}Times New Roman;}{\fhiminor\f31506\fbidi \fswiss\fcharset0\fprq2{\*\panose 020f0502020204030204}Calibri;} +{\fbiminor\f31507\fbidi \fswiss\fcharset0\fprq2{\*\panose 020b0604020202020204}Arial;}{\f240\fbidi \fswiss\fcharset238\fprq2 Arial CE;}{\f241\fbidi \fswiss\fcharset204\fprq2 Arial Cyr;}{\f243\fbidi \fswiss\fcharset161\fprq2 Arial Greek;} +{\f244\fbidi \fswiss\fcharset162\fprq2 Arial Tur;}{\f245\fbidi \fswiss\fcharset177\fprq2 Arial (Hebrew);}{\f246\fbidi \fswiss\fcharset178\fprq2 Arial (Arabic);}{\f247\fbidi \fswiss\fcharset186\fprq2 Arial Baltic;} +{\f248\fbidi \fswiss\fcharset163\fprq2 Arial (Vietnamese);}{\f570\fbidi \froman\fcharset238\fprq2 Cambria Math CE;}{\f571\fbidi \froman\fcharset204\fprq2 Cambria Math Cyr;}{\f573\fbidi \froman\fcharset161\fprq2 Cambria Math Greek;} +{\f574\fbidi \froman\fcharset162\fprq2 Cambria Math Tur;}{\f577\fbidi \froman\fcharset186\fprq2 Cambria Math Baltic;}{\f578\fbidi \froman\fcharset163\fprq2 Cambria Math (Vietnamese);}{\f600\fbidi \fswiss\fcharset238\fprq2 Calibri CE;} +{\f601\fbidi \fswiss\fcharset204\fprq2 Calibri Cyr;}{\f603\fbidi \fswiss\fcharset161\fprq2 Calibri Greek;}{\f604\fbidi \fswiss\fcharset162\fprq2 Calibri Tur;}{\f607\fbidi \fswiss\fcharset186\fprq2 Calibri Baltic;} +{\f608\fbidi \fswiss\fcharset163\fprq2 Calibri (Vietnamese);}{\f610\fbidi \fswiss\fcharset238\fprq2 Tahoma CE;}{\f611\fbidi \fswiss\fcharset204\fprq2 Tahoma Cyr;}{\f613\fbidi \fswiss\fcharset161\fprq2 Tahoma Greek;} +{\f614\fbidi \fswiss\fcharset162\fprq2 Tahoma Tur;}{\f615\fbidi \fswiss\fcharset177\fprq2 Tahoma (Hebrew);}{\f616\fbidi \fswiss\fcharset178\fprq2 Tahoma (Arabic);}{\f617\fbidi \fswiss\fcharset186\fprq2 Tahoma Baltic;} +{\f618\fbidi \fswiss\fcharset163\fprq2 Tahoma (Vietnamese);}{\f619\fbidi \fswiss\fcharset222\fprq2 Tahoma (Thai);}{\flomajor\f31508\fbidi \froman\fcharset238\fprq2 Times New Roman CE;}{\flomajor\f31509\fbidi \froman\fcharset204\fprq2 Times New Roman Cyr;} +{\flomajor\f31511\fbidi
[Libreoffice-bugs] [Bug 153106] Revert commit of Bug 91415 - Scale Calc's comment indicator with zoom level (please, do not)
https://bugs.documentfoundation.org/show_bug.cgi?id=153106 --- Comment #22 from Eyal Rozenberg --- (In reply to ady from comment #21) > > I disagree with that. On the contrary, I see it as a problem if the comment > > indicator does not draw your attention. > > Yes, if that were to be a problem. It has definitely been a problem: bug 56677. But the "fix" was insufficient in my opinion. Things have certainly not gotten to the level of visibility of MS Excel, and in absolute terms - it's really not good enough. > There is no report claiming that the comment indicator cannot be seen. There is now: Bug 154080. > The user should be able to see it, but it > should not be "the main thing"; that would be distracting. It _needs_ to distract - while not interfering with the visibility of the actual cell contents. > (In reply to Eyal Rozenberg from comment #20) > > There are (at least) two usability considerations/problems regarding comment > > indications: > > > > 1. On one hand, it's a problem when comment indicators hide content. > > 2. On the other hand, it's a problem if comment indicators are not > > clearly-visible, as I might inadvertently miss them > > > > Bug 91415 was opened regarding the first usability problem, not the second > > one. Also, bug 91415 did not ask for any changes at high zoom levels - it > > regarded the situation without playing with the zoom level. > > That sounds as if the request explicitly said "I cannot use the zoom feature > to solve this" A bug was reported in the behavior without the user applying zoom. Whatever changes in the behavior when zooming in or out cannot resolve the bug. > The reason users do not mention zoom in bug 91415 is > because they are simply not aware that the zoom feature resolves the problem. No, that's not the reason, and no, it doesn't resolve the problem. ... which is also why the patch should not have included scaling at different zoom levels - because zoom is irrelevant to the bug. > There is no physical way to > _simultaneously_ see more details and to see "the big picture" in the same > UI. That's the reason to use zoom. Of course there is. More than one way even. The use of the triangle shape rather than the dot/small square is one such way. One can think of others. > I could take almost any cell, with a clear visible text and indicator, scale > the zoom factor to, say, 20%, and show how it is an inconvenience. It doesn't matter what happens at zoom 20% nor at zoom 500%. Both cell contents, and comment indicators, must be clearly visible at zoom 100%. (or rather - it does matter, but not in the context of bug 91415.) Anyway, I don't understand why you're arguing with one of the people who agrees with you. In fact, you're undermining your own request for back-out by claiming that what happens at different zoom levels has bearing on 91415. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 153106] Revert commit of Bug 91415 - Scale Calc's comment indicator with zoom level (please, do not)
https://bugs.documentfoundation.org/show_bug.cgi?id=153106 --- Comment #22 from Eyal Rozenberg --- (In reply to ady from comment #21) > > I disagree with that. On the contrary, I see it as a problem if the comment > > indicator does not draw your attention. > > Yes, if that were to be a problem. It has definitely been a problem: bug 56677. But the "fix" was insufficient in my opinion. Things have certainly not gotten to the level of visibility of MS Excel, and in absolute terms - it's really not good enough. > There is no report claiming that the comment indicator cannot be seen. There is now: Bug 154080. > The user should be able to see it, but it > should not be "the main thing"; that would be distracting. It _needs_ to distract - while not interfering with the visibility of the actual cell contents. > (In reply to Eyal Rozenberg from comment #20) > > There are (at least) two usability considerations/problems regarding comment > > indications: > > > > 1. On one hand, it's a problem when comment indicators hide content. > > 2. On the other hand, it's a problem if comment indicators are not > > clearly-visible, as I might inadvertently miss them > > > > Bug 91415 was opened regarding the first usability problem, not the second > > one. Also, bug 91415 did not ask for any changes at high zoom levels - it > > regarded the situation without playing with the zoom level. > > That sounds as if the request explicitly said "I cannot use the zoom feature > to solve this" A bug was reported in the behavior without the user applying zoom. Whatever changes in the behavior when zooming in or out cannot resolve the bug. > The reason users do not mention zoom in bug 91415 is > because they are simply not aware that the zoom feature resolves the problem. No, that's not the reason, and no, it doesn't resolve the problem. ... which is also why the patch should not have included scaling at different zoom levels - because zoom is irrelevant to the bug. > There is no physical way to > _simultaneously_ see more details and to see "the big picture" in the same > UI. That's the reason to use zoom. Of course there is. More than one way even. The use of the triangle shape rather than the dot/small square is one such way. One can think of others. > I could take almost any cell, with a clear visible text and indicator, scale > the zoom factor to, say, 20%, and show how it is an inconvenience. It doesn't matter what happens at zoom 20% nor at zoom 500%. Both cell contents, and comment indicators, must be clearly visible at zoom 100%. (or rather - it does matter, but not in the context of bug 91415.) Anyway, I don't understand why you're arguing with one of the people who agrees with you. In fact, you're undermining your own request for back-out by claiming that what happens at different zoom levels has bearing on 91415. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 154061] CRASH: undoing column insert
https://bugs.documentfoundation.org/show_bug.cgi?id=154061 --- Comment #2 from Paris Oplopoios --- I added a patch that seems to fix this issue https://gerrit.libreoffice.org/c/core/+/148492 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154080] Comment indicator is too small, non-circumspect, easy to miss
https://bugs.documentfoundation.org/show_bug.cgi?id=154080 --- Comment #4 from Eyal Rozenberg --- Created attachment 185852 --> https://bugs.documentfoundation.org/attachment.cgi?id=185852=edit Screenshot of calc window with attachment 185851 Note how the triangles for text exceeding cell boundaries are also a bit similar to comment indicators, helping camouflage it even further. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154080] Comment indicator is too small, non-circumspect, easy to miss
https://bugs.documentfoundation.org/show_bug.cgi?id=154080 Eyal Rozenberg changed: What|Removed |Added Attachment #185850|0 |1 is obsolete|| --- Comment #3 from Eyal Rozenberg --- Created attachment 185851 --> https://bugs.documentfoundation.org/attachment.cgi?id=185851=edit Calc sheet with comments and surrounding text -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154080] Comment indicator is too small, non-circumspect, easy to miss
https://bugs.documentfoundation.org/show_bug.cgi?id=154080 --- Comment #2 from Eyal Rozenberg --- Created attachment 185850 --> https://bugs.documentfoundation.org/attachment.cgi?id=185850=edit Calc sheet with comments -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154080] Comment indicator is too small, non-circumspect, easy to miss
https://bugs.documentfoundation.org/show_bug.cgi?id=154080 Eyal Rozenberg changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=56 ||677 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 56677] Comment indicator too small
https://bugs.documentfoundation.org/show_bug.cgi?id=56677 Eyal Rozenberg changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||4080 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153106] Revert commit of Bug 91415 - Scale Calc's comment indicator with zoom level (please, do not)
https://bugs.documentfoundation.org/show_bug.cgi?id=153106 Eyal Rozenberg changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||4080 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 153106] Revert commit of Bug 91415 - Scale Calc's comment indicator with zoom level (please, do not)
https://bugs.documentfoundation.org/show_bug.cgi?id=153106 Eyal Rozenberg changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||4080 -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 154080] Comment indicator is too small, non-circumspect, easy to miss
https://bugs.documentfoundation.org/show_bug.cgi?id=154080 Eyal Rozenberg changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||3106 -- You are receiving this mail because: You are the assignee for the bug.