[Libreoffice-bugs] [Bug 154040] Not possible to insert interactive frame
https://bugs.documentfoundation.org/show_bug.cgi?id=154040 --- Comment #10 from Tomaz Vajngerl --- Yes, I can reproduce. Must be something dumb we do at inserting with the SdrObject, which is not valid anymore. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - icon-themes/elementary icon-themes/elementary_svg
icon-themes/elementary/cmd/32/showbookview.png |binary icon-themes/elementary/cmd/lc_showbookview.png |binary icon-themes/elementary/cmd/sc_showbookview.png |binary icon-themes/elementary_svg/cmd/32/showbookview.svg |2 +- icon-themes/elementary_svg/cmd/lc_showbookview.svg |2 +- icon-themes/elementary_svg/cmd/sc_showbookview.svg |2 +- 6 files changed, 3 insertions(+), 3 deletions(-) New commits: commit ab4d92ae4bf78d0af68d8e1dbf7b035c2b90eb73 Author: Rizal Muttaqin AuthorDate: Mon Mar 13 11:59:21 2023 +0700 Commit: Rizal Muttaqin CommitDate: Thu Mar 16 03:42:34 2023 + elementary: tdf#153609 Update Book Preview in Page Preview Change-Id: Idc5710c576b6edcea21cfad715507df1e38267c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148761 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin diff --git a/icon-themes/elementary/cmd/32/showbookview.png b/icon-themes/elementary/cmd/32/showbookview.png index f3170bcd4c9c..bb64b1470b7a 100644 Binary files a/icon-themes/elementary/cmd/32/showbookview.png and b/icon-themes/elementary/cmd/32/showbookview.png differ diff --git a/icon-themes/elementary/cmd/lc_showbookview.png b/icon-themes/elementary/cmd/lc_showbookview.png index aad4079901de..796b5ca20d50 100644 Binary files a/icon-themes/elementary/cmd/lc_showbookview.png and b/icon-themes/elementary/cmd/lc_showbookview.png differ diff --git a/icon-themes/elementary/cmd/sc_showbookview.png b/icon-themes/elementary/cmd/sc_showbookview.png index 9957351d4bc4..c58a9c258667 100644 Binary files a/icon-themes/elementary/cmd/sc_showbookview.png and b/icon-themes/elementary/cmd/sc_showbookview.png differ diff --git a/icon-themes/elementary_svg/cmd/32/showbookview.svg b/icon-themes/elementary_svg/cmd/32/showbookview.svg index e402f2c5119c..41e8889356e3 100644 --- a/icon-themes/elementary_svg/cmd/32/showbookview.svg +++ b/icon-themes/elementary_svg/cmd/32/showbookview.svg @@ -1 +1 @@ -http://www.w3.org/2000/svg; xmlns:xlink="http://www.w3.org/1999/xlink;> \ No newline at end of file +http://www.w3.org/2000/svg; xmlns:xlink="http://www.w3.org/1999/xlink;> \ No newline at end of file diff --git a/icon-themes/elementary_svg/cmd/lc_showbookview.svg b/icon-themes/elementary_svg/cmd/lc_showbookview.svg index 257ee4a47ddf..b80056d62384 100644 --- a/icon-themes/elementary_svg/cmd/lc_showbookview.svg +++ b/icon-themes/elementary_svg/cmd/lc_showbookview.svg @@ -1 +1 @@ -http://www.w3.org/2000/svg; xmlns:xlink="http://www.w3.org/1999/xlink;> \ No newline at end of file +http://www.w3.org/2000/svg; xmlns:xlink="http://www.w3.org/1999/xlink;> \ No newline at end of file diff --git a/icon-themes/elementary_svg/cmd/sc_showbookview.svg b/icon-themes/elementary_svg/cmd/sc_showbookview.svg index f2cecd6d1ad7..6e0ac00dcdfc 100644 --- a/icon-themes/elementary_svg/cmd/sc_showbookview.svg +++ b/icon-themes/elementary_svg/cmd/sc_showbookview.svg @@ -1 +1 @@ -http://www.w3.org/2000/svg; xmlns:xlink="http://www.w3.org/1999/xlink;> \ No newline at end of file +http://www.w3.org/2000/svg; xmlns:xlink="http://www.w3.org/1999/xlink;> \ No newline at end of file
[Libreoffice-bugs] [Bug 154154] LO can't install an extension for all users under macOS
https://bugs.documentfoundation.org/show_bug.cgi?id=154154 QA Administrators changed: What|Removed |Added Keywords||notBibisectable -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151074] LibreOffice from macOS appstore - can not create connection to mysql database via database creation wizard
https://bugs.documentfoundation.org/show_bug.cgi?id=151074 QA Administrators changed: What|Removed |Added Keywords||notBibisectable -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153911] Warning when opening files with other files already open
https://bugs.documentfoundation.org/show_bug.cgi?id=153911 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152250] Copying conditional formatting creates unmodifiable styles (save/load fixes it)
https://bugs.documentfoundation.org/show_bug.cgi?id=152250 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146764] LibreOffice Vanilla, TDF LibreOffice from macOS AppStore - form wizard fails to launch with embedded Firebird DB
https://bugs.documentfoundation.org/show_bug.cgi?id=146764 QA Administrators changed: What|Removed |Added Keywords||notBibisectable -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153910] textbox in Writer does not resolve style:writing-mode="page" to the writing mode of the page
https://bugs.documentfoundation.org/show_bug.cgi?id=153910 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152250] Copying conditional formatting creates unmodifiable styles (save/load fixes it)
https://bugs.documentfoundation.org/show_bug.cgi?id=152250 --- Comment #4 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 96651] Background Image Can be Arranged Forward
https://bugs.documentfoundation.org/show_bug.cgi?id=96651 --- Comment #9 from QA Administrators --- Dear Harald Koester, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 55355] Writer PRINTING, PDF, FILEOPEN DOCX: Embedded image imported from docx file print at wrong size
https://bugs.documentfoundation.org/show_bug.cgi?id=55355 --- Comment #13 from QA Administrators --- Dear Ian Miller, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 137510] Mail merge printer or single: fields remains without value at second header style
https://bugs.documentfoundation.org/show_bug.cgi?id=137510 --- Comment #11 from QA Administrators --- Dear pabordel, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140698] calc paste not working between sheets with Klipper history size set to 1 (steps in comment 12)
https://bugs.documentfoundation.org/show_bug.cgi?id=140698 --- Comment #13 from QA Administrators --- Dear Pascal, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 136230] SPECIAL CHARACTER DIALOG: Results of search field are not displayed after font changing
https://bugs.documentfoundation.org/show_bug.cgi?id=136230 --- Comment #5 from QA Administrators --- Dear shariqkeen, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 123527] Insert / special Character not correctly rebuilding font chart to match selected font and search string
https://bugs.documentfoundation.org/show_bug.cgi?id=123527 --- Comment #4 from QA Administrators --- Dear Luuk, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 116372] VIEWING: Page jumps relative to ruler when switching to another window of the same document
https://bugs.documentfoundation.org/show_bug.cgi?id=116372 --- Comment #12 from QA Administrators --- Dear Harald Koester, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 111850] UI breaks after scrolling somewhere while playing video
https://bugs.documentfoundation.org/show_bug.cgi?id=111850 --- Comment #8 from QA Administrators --- Dear Yan Pas, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154210] F1 (Help) for Navigator context menu for Headings not linked to relevant help pages
https://bugs.documentfoundation.org/show_bug.cgi?id=154210 Olivier Hallot changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/cib/libreoffice-6-4' - sfx2/source
sfx2/source/doc/iframe.cxx|4 sfx2/source/inc/eventsupplier.hxx |1 - 2 files changed, 4 insertions(+), 1 deletion(-) New commits: commit 6ce7620a163e9f03c3b4f43162a84e0347ae5b10 Author: Samuel Mehrbrodt AuthorDate: Mon Feb 27 15:27:24 2023 +0100 Commit: Thorsten Behrens CommitDate: Thu Mar 16 01:52:20 2023 + Check iframe target for allowed document URLs Change-Id: I00e4192becbc160282a43ab89dcd269f3d1012d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147919 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt (cherry picked from commit 288c0920a8475f9f2c537212e04aa7649192ad8c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148230 Tested-by: Thorsten Behrens Reviewed-by: Thorsten Behrens diff --git a/sfx2/source/doc/iframe.cxx b/sfx2/source/doc/iframe.cxx index aea851894286..c8c0c76357e7 100644 --- a/sfx2/source/doc/iframe.cxx +++ b/sfx2/source/doc/iframe.cxx @@ -46,6 +46,7 @@ #include #include #include +#include using namespace ::com::sun::star; @@ -174,6 +175,9 @@ sal_Bool SAL_CALL IFrameObject::load( return false; } +if (!SfxEvents_Impl::isScriptURLAllowed(aTargetURL.Complete)) +return false; + DBG_ASSERT( !mxFrame.is(), "Frame already existing!" ); VclPtr pParent = VCLUnoHelper::GetWindow( xFrame->getContainerWindow() ); VclPtr pWin = VclPtr::Create( pParent, maFrmDescr.IsFrameBorderOn() ); diff --git a/sfx2/source/inc/eventsupplier.hxx b/sfx2/source/inc/eventsupplier.hxx index 4624ed8b4907..d24345dba1c5 100644 --- a/sfx2/source/inc/eventsupplier.hxx +++ b/sfx2/source/inc/eventsupplier.hxx @@ -87,7 +87,6 @@ public: SfxObjectShell* i_document ); static void Execute( css::uno::Any const & aEventData, const css::document::DocumentEvent& aTrigger, SfxObjectShell* pDoc ); -private: /// Check if script URL whitelist exists, and if so, if current script url is part of it static bool isScriptURLAllowed(const OUString& aScriptURL); };
[Libreoffice-commits] core.git: Branch 'distro/cib/libreoffice-6-4' - sc/inc sc/qa sc/source
sc/inc/document.hxx |1
sc/inc/table.hxx |1
sc/qa/unit/data/ods/tdf154005.ods |binary
sc/qa/unit/scshapetest.cxx| 47 ++
sc/source/core/data/document.cxx |8 ++
sc/source/core/data/drwlayer.cxx | 16 +++-
sc/source/core/data/table5.cxx| 22 +
7 files changed, 93 insertions(+), 2 deletions(-)
New commits:
commit 1d9c9ebd552b9394a025fbb9e692451ba9d3460c
Author: Balazs Varga
AuthorDate: Sun Mar 12 17:49:53 2023 +0100
Commit: Thorsten Behrens
CommitDate: Thu Mar 16 01:51:29 2023 +
tdf#154005 sc ods fileopen: fix dropdown form control size
Dropdown form control size was increased by the size of hidden
rows or columns.
Regression from commit: 1f0b3c7a40edfa81bbc7a58d123a6a2dfd83e4ca
(Improve 'resize with cell' handling)
Change-Id: Ic903a488cab22286f95cfdf4ee559013fd7bfa02
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148738
Tested-by: Thorsten Behrens
Reviewed-by: Thorsten Behrens
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148874
diff --git a/sc/inc/document.hxx b/sc/inc/document.hxx
index 4cc98b01096e..03a4345ead15 100644
--- a/sc/inc/document.hxx
+++ b/sc/inc/document.hxx
@@ -1919,6 +1919,7 @@ public:
SC_DLLPUBLIC SCROW FirstVisibleRow(SCROW nStartRow, SCROW
nEndRow, SCTAB nTab) const;
SC_DLLPUBLIC SCROW LastVisibleRow(SCROW nStartRow, SCROW nEndRow,
SCTAB nTab) const;
SCROW CountVisibleRows(SCROW nStartRow, SCROW
nEndRow, SCTAB nTab) const;
+SCCOL CountVisibleCols(SCROW nStartCol, SCROW
nEndCol, SCTAB nTab) const;
boolRowFiltered(SCROW nRow, SCTAB nTab, SCROW*
pFirstRow = nullptr, SCROW* pLastRow = nullptr) const;
boolHasFilteredRows(SCROW nStartRow, SCROW
nEndRow, SCTAB nTab) const;
diff --git a/sc/inc/table.hxx b/sc/inc/table.hxx
index e1e21588278d..cc90bd31b980 100644
--- a/sc/inc/table.hxx
+++ b/sc/inc/table.hxx
@@ -905,6 +905,7 @@ public:
SCROW FirstVisibleRow(SCROW nStartRow, SCROW nEndRow) const;
SCROW LastVisibleRow(SCROW nStartRow, SCROW nEndRow) const;
SCROW CountVisibleRows(SCROW nStartRow, SCROW nEndRow) const;
+SCCOL CountVisibleCols(SCCOL nStartCol, SCCOL nEndCol) const;
sal_uInt32 GetTotalRowHeight(SCROW nStartRow, SCROW nEndRow, bool
bHiddenAsZero = true) const;
SCCOLROWLastHiddenColRow(SCCOLROW nPos, bool bCol) const;
diff --git a/sc/qa/unit/data/ods/tdf154005.ods
b/sc/qa/unit/data/ods/tdf154005.ods
new file mode 100644
index ..1b52a4dba556
Binary files /dev/null and b/sc/qa/unit/data/ods/tdf154005.ods differ
diff --git a/sc/qa/unit/scshapetest.cxx b/sc/qa/unit/scshapetest.cxx
index 7f2d762bc34d..55a2b0a8537c 100644
--- a/sc/qa/unit/scshapetest.cxx
+++ b/sc/qa/unit/scshapetest.cxx
@@ -12,6 +12,7 @@
#include
#include
#include
+#include
#include
#include
@@ -33,10 +34,12 @@ public:
void testFitToCellSize();
void testCustomShapeCellAnchoredRotatedShape();
+void testFormSizeWithHiddenCol();
CPPUNIT_TEST_SUITE(ScShapeTest);
CPPUNIT_TEST(testFitToCellSize);
CPPUNIT_TEST(testCustomShapeCellAnchoredRotatedShape);
+CPPUNIT_TEST(testFormSizeWithHiddenCol);
CPPUNIT_TEST_SUITE_END();
private:
@@ -171,6 +174,50 @@ void ScShapeTest::testCustomShapeCellAnchoredRotatedShape()
pDocSh->DoClose();
}
+void ScShapeTest::testFormSizeWithHiddenCol()
+{
+// The document contains a form (Listbox) shape anchored "To Cell (resize
with cell)" with starts in cell B5 and
+// ends in cell D5. The error was the form shape was resized if there was
hidden col/row.
+OUString aFileURL;
+createFileURL("tdf154005.ods", aFileURL);
+uno::Reference xComponent =
loadFromDesktop(aFileURL);
+CPPUNIT_ASSERT(xComponent.is());
+
+// Get the document model
+SfxObjectShell* pFoundShell =
SfxObjectShell::GetShellFromComponent(xComponent);
+CPPUNIT_ASSERT_MESSAGE("Failed to access document shell", pFoundShell);
+
+ScDocShell* pDocSh = dynamic_cast(pFoundShell);
+CPPUNIT_ASSERT(pDocSh);
+
+// Get the shape
+ScDocument& rDoc = pDocSh->GetDocument();
+ScDrawLayer* pDrawLayer = rDoc.GetDrawLayer();
+CPPUNIT_ASSERT(pDrawLayer);
+
+const SdrPage* pPage = pDrawLayer->GetPage(0);
+CPPUNIT_ASSERT(pPage);
+
+SdrUnoObj* pObj = dynamic_cast(pPage->GetObj(0));
+CPPUNIT_ASSERT(pObj);
+
+// Check Position and Size
+rDoc.SetDrawPageSize(0); // trigger recalcpos
+tools::Rectangle aRect(2432, 3981, 4932, 4631); // expected snap rect from
values in file
+const tools::Rectangle& rShapeRect(pObj->GetSnapRect());
+const OUString sPosSizeErrors(lcl_compareRectWithTolerance(aRect,
rShapeRect, 1));
+CPPUNIT_ASSERT_EQUAL(OUString(), sPosSizeErrors);
+
+//
[Libreoffice-bugs] [Bug 154221] New: Insert image URL
https://bugs.documentfoundation.org/show_bug.cgi?id=154221 Bug ID: 154221 Summary: Insert image URL Product: LibreOffice Version: 7.5.1.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: sme...@gmu.edu Provide a means to insert an image URL into a document and to use that URL rather than the actual image when exporting as HTML. Ideally this should include generating the URL from the browse (file selection) dialog. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154220] New: Case conversion
https://bugs.documentfoundation.org/show_bug.cgi?id=154220 Bug ID: 154220 Summary: Case conversion Product: LibreOffice Version: 7.5.1.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: sme...@gmu.edu Provide keyboard and menu tool for case conversions: lower case, sentence case, title case, toggle case, upper case. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154219] New: Set format of image caption
https://bugs.documentfoundation.org/show_bug.cgi?id=154219 Bug ID: 154219 Summary: Set format of image caption Product: LibreOffice Version: 7.5.1.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: sme...@gmu.edu Provide keyboard and menu tool to set the format of image captions to include centering and hyperlink. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 127146] Footnotes "Before/After" text disappears while saving as DOC/X
https://bugs.documentfoundation.org/show_bug.cgi?id=127146 --- Comment #9 from Sulphur --- There isn't any workaround until this is fixed, is there? Maybe some way to add a space automatically to the beginning of the footnote text, as opposed to appending a non-clickable character to the footnote numeral? (That doesn't help with needing to add characters before the footnote numeral, of course.) Just tired of manually going to each footnote and hitting space when I need to send someone a decently-formatted docx. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154215] The WeekNum worksheet function is very slow
https://bugs.documentfoundation.org/show_bug.cgi?id=154215 --- Comment #2 from NOYB --- I realize VBA is a compatibility layer and do expect a performance hit. But a 1000 x performance hit? Seriously? Actually it even more the 1000 x because the system used for the Excel benchmark is 10 years old and much slower machine. 1.8GHz compared to 2.4GHz. The performance difference is probably near 2000 x. That doesn't seem reasonable even for compatibility. Even though it technically functions. With the much of a performance hit, it's essentially not compatible. Pretty sure there is plenty of room for improvement. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154215] The WeekNum worksheet function is very slow
https://bugs.documentfoundation.org/show_bug.cgi?id=154215 --- Comment #1 from Eike Rathke --- VBASupport is a compatibility layer, so don't expect speed. Any invocation of WorksheetFunction.something() requires overhead that can't be neglected. You'd probably save some time using the com.sun.star.sheet.FunctionAccess service directly from BASIC. See https://api.libreoffice.org/docs/idl/ref/servicecom_1_1sun_1_1star_1_1sheet_1_1FunctionAccess.html -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153908] Dragging scrollbars with mouse in relationships window causes content panel moves in oposite direction than expected
https://bugs.documentfoundation.org/show_bug.cgi?id=153908 Stéphane Guillou (stragu) changed: What|Removed |Added Regression By||Caolán McNamara Keywords|bibisectRequest |bibisected, bisected CC||caol...@redhat.com --- Comment #5 from Stéphane Guillou (stragu) --- bibisected with linux-64-7.5 repo to first bad commit 842a5e704af521cb282236a0fbd49a46e5fe615b which points to core commit: commit 59a2650101a0ce711151bfd39af1bbb69f71f318 author Caolán McNamara Fri Aug 05 15:51:46 2022 +0100 committer Caolán McNamara Sat Aug 06 13:07:49 2022 +0200 tdf#117388 use native scrollbar under gtk in database scrolled window Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137879 Caolán, can you please have a look? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152250] Copying conditional formatting creates unmodifiable styles (save/load fixes it)
https://bugs.documentfoundation.org/show_bug.cgi?id=152250 --- Comment #3 from Peter Gervai --- Same happens in safe mode. Version: 7.4.5.1 / LibreOffice Community Build ID: 40(Build:1) CPU threads: 8; OS: Linux 6.1; UI render: default; VCL: gtk3 Locale: hu-HU (hu_HU.UTF8); UI: en-US Debian package version: 4:7.4.5-2 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152250] Copying conditional formatting creates unmodifiable styles (save/load fixes it)
https://bugs.documentfoundation.org/show_bug.cgi?id=152250 --- Comment #2 from Peter Gervai --- Reproduced in 7.4.5.1 as well. More detailed steps: 1. create a new sheet document 2. create new style "test1", set font color to octarine or whatever 3. create a column from 1..10 numbers 4. select column 5. Fromat >> Conditional >> Condition 6. Set "Cell Value // is less than // 5", Apply style "test1". Half of the cell colors shall change. 7. select cells with values; edit >> copy 8. create a new sheet document (where "test1" does not exist) 9. create a few numbers, select them 10. Edit >> Paste special >> Paste special >> Formats Only (button) This will color some cells and ALSO creates "test1" style. 11. open styles sidebar (F11), right click on "test1" 12. Modify is grayed out. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153908] Dragging scrollbars with mouse in relationships window causes content panel moves in oposite direction than expected
https://bugs.documentfoundation.org/show_bug.cgi?id=153908 Stéphane Guillou (stragu) changed: What|Removed |Added Blocks||105957, 108044 CC||stephane.guillou@libreoffic ||e.org OS|Windows (All) |All Status|UNCONFIRMED |NEW Keywords||bibisectRequest, regression Ever confirmed|0 |1 --- Comment #4 from Stéphane Guillou (stragu) --- Reproduced in: Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 44837a12d12be3e525fa48b37c3dd2553cc97d94 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded Confirmed that it's a regression, not reproduced in 7.4.6.2 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=105957 [Bug 105957] [META] Scrollbar-related bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=108044 [Bug 108044] [META] Base UX bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108044] [META] Base UX bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108044 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||153908 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=153908 [Bug 153908] Dragging scrollbars with mouse in relationships window causes content panel moves in oposite direction than expected -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 105957] [META] Scrollbar-related bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=105957 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||153908 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=153908 [Bug 153908] Dragging scrollbars with mouse in relationships window causes content panel moves in oposite direction than expected -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151472] FORMATTING: Style change breaks direct formatting (bold, italic, underline)
https://bugs.documentfoundation.org/show_bug.cgi?id=151472 Peter Gervai changed: What|Removed |Added Resolution|--- |WORKSFORME Status|NEEDINFO|RESOLVED --- Comment #3 from Peter Gervai --- It is _not_ broken in 7.4.5.1. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 104468] [META] DOCX (OOXML) image-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=104468 Bug 104468 depends on bug 147318, which changed state. Bug 147318 Summary: FILEOPEN DOCX: Image position off https://bugs.documentfoundation.org/show_bug.cgi?id=147318 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 96579] [WRITER] Figure caption badly converted in Word format because image anchoring and wrapping is changed to as-character/DML
https://bugs.documentfoundation.org/show_bug.cgi?id=96579 --- Comment #19 from Justin L --- *** Bug 147318 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147318] FILEOPEN DOCX: Image position off
https://bugs.documentfoundation.org/show_bug.cgi?id=147318 Justin L changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #4 from Justin L --- *** This bug has been marked as a duplicate of bug 96579 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154218] New: variable and user field input field mishandles datetime when a locale is active
https://bugs.documentfoundation.org/show_bug.cgi?id=154218 Bug ID: 154218 Summary: variable and user field input field mishandles datetime when a locale is active Product: LibreOffice Version: 7.4.5.1 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: g...@grin.hu When using a full datetime format for a variable (fields>>variables>>user field or set variable) like "1999-01-01 11:22:33" it seems the dialog mishandles the decimal point. I had my test set to Hungarian, which uses comma (,) as a decimal separator, so the input field for "1999-01-01 12:00" generated a string like "43210,12345" which resulted "1899-12-31 12:00" since the dialog seem to expect english decimal point, as "43210.12345". Replacing the decimal manually fixed the datetime. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103378] [META] PDF export bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103378 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||154193 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=154193 [Bug 154193] Inserted SVG is distorted after exporting to PDF -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154193] Inserted SVG is distorted after exporting to PDF
https://bugs.documentfoundation.org/show_bug.cgi?id=154193 Stéphane Guillou (stragu) changed: What|Removed |Added CC||stephane.guillou@libreoffic ||e.org Version|7.5.0.3 release |5.4.0.3 release Ever confirmed|0 |1 Component|Writer |Printing and PDF export Status|UNCONFIRMED |NEW Blocks||103378 --- Comment #1 from Stéphane Guillou (stragu) --- Reproduced with: Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 44837a12d12be3e525fa48b37c3dd2553cc97d94 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded Artifacts were even worse back in 5.4.0.3 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103378 [Bug 103378] [META] PDF export bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154217] New: Fields variables (user field and variable) cannot format value for update as date (or similar)
https://bugs.documentfoundation.org/show_bug.cgi?id=154217 Bug ID: 154217 Summary: Fields variables (user field and variable) cannot format value for update as date (or similar) Product: LibreOffice Version: 7.4.5.1 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: g...@grin.hu Fields >> Variables >> User Field, Set variable, Show Variable, and editing a field or a variable by double click cannot handle formatting other than text or numerical, causing a very confusing experience, especially for dates and datetime. Reproduction: 1. create a new variable with "Set variable", and set format to a date format like "1999-01-01", and enter a date value, say, 2023-03-15. 2. Insert the variable, and close the dialog. 3. Double-click on the field: you will get value "42000" I see that it's "number of dates since 1899-12-30", but that probably won't help much in everyday use. It seems user fields and variables remember their formatting, but the input field ignores that when displaying. It is still possible to correctly update the field with "2022-11-22", but it's not possible to view the actual value. (As a sidenote: the manual about variables and user fields is pretty terse. It even neglects to tell the difference between variables and user fields. I see now but... possibly I shall create some diff there.) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 120163] Image partially hidden by white rectangle in header ( created with OnlyOffice)
https://bugs.documentfoundation.org/show_bug.cgi?id=120163 --- Comment #19 from Justin L --- "Compte Rendu" in the header requests a white background for the whole paragraph. Ceo-vision image requests to be in the background - behind the text. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140961] LO Writer: Frames are converted into text box when saving in .docx
https://bugs.documentfoundation.org/show_bug.cgi?id=140961 --- Comment #14 from Justin L --- I think this should be closed as INVALID. We have to do all kinds of emulation when saving from ODT to DOCX. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153758] LibreOffice Online Build is failing
https://bugs.documentfoundation.org/show_bug.cgi?id=153758 Stéphane Guillou (stragu) changed: What|Removed |Added CC||stephane.guillou@libreoffic ||e.org --- Comment #1 from Stéphane Guillou (stragu) --- Thank you for the report. Unfortunately, LibreOffice Online is currently frozen, so it is unlikely a fix will be available in the short term. I recommend looking into https://collaboraonline.github.io/ instead, which is built on top of LibreOffice. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154216] New: Scroll region window object; capture tools inhibited
https://bugs.documentfoundation.org/show_bug.cgi?id=154216 Bug ID: 154216 Summary: Scroll region window object; capture tools inhibited Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: junkyardma...@frontier.com Description: Scroll region is not a separate window object so cannot use scroll capture feature of tools such as Hypersnap. Please make the rows/columns scroll region a separate window object that can be utilized by the scroll capture feature of tools such as Hypersnap. Capture - Entire page with Scrolling; Ctrl + Shift + S Steps to Reproduce: 1. Create speaesheet with more rows than fit on screen. 2. Use a tool such as Hypersnap to do a scroll capture. 3. Actual Results: Capture entire visible window rather than the scrollable region. Expected Results: Scroll to capture the entire scrollable region. Even the portion that is off screen. Reproducible: Always User Profile Reset: No Additional Info: Perhaps other capture tools used with non windows OS are also inhibited. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 113776] Hierarchical numerbing of objects (e.g. tables, figures) is not saved properly to DOC or DOCX format
https://bugs.documentfoundation.org/show_bug.cgi?id=113776 --- Comment #13 from Gabor Kelemen (allotropia) --- (In reply to space from comment #12) > Hi guy, > I used the latest released version of LO v7.5.1, this issue can be still > reproduced for .doc and .docx. so how is the progress and what is the plan ? > > Thanks > BR Hi If this bug is important for you (or any organization you work for/with) to be fixed, please consider getting professional help from certified developers: https://www.documentfoundation.org/certified-developers/ -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149570] Can't undo removing columns / rows until leaving the table or adding to history stack (steps in comment 4)
https://bugs.documentfoundation.org/show_bug.cgi?id=149570 Stéphane Guillou (stragu) changed: What|Removed |Added Version|7.4.0.0 alpha1+ |7.3.0.0.alpha1+ Regression By||Tomaž Vajngerl --- Comment #7 from Stéphane Guillou (stragu) --- Thanks, Caolán. I should have clarified the steps I used for my bisect: 1. Open Impress or Draw 2. Insert table 3. Add row: undo is possible 4. Remove row: undo is greyed out Before commit ae0e7e3918284c31a91acca0f733919926ae3a62, it was possible to undo the row removal without extra steps. But now I can see how your change in focus simply made a pre-existing issue pop-up when following my steps. Before that commit, one needs to then click inside the table as a step 5 to see that the undo was already unavailable. Quikee, any thoughts? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 107830] [META] DOCX (OOXML) paragraph-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=107830 Gabor Kelemen (allotropia) changed: What|Removed |Added Depends on|124059 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=124059 [Bug 124059] FILEOPEN DOCX: Position of text changes when exporting to DOCX and reopen in LO -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 120466] [META] DOCX (OOXML) anchor and text wrapping bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=120466 Gabor Kelemen (allotropia) changed: What|Removed |Added Depends on||124059 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=124059 [Bug 124059] FILEOPEN DOCX: Position of text changes when exporting to DOCX and reopen in LO -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 124059] FILEOPEN DOCX: Position of text changes when exporting to DOCX and reopen in LO
https://bugs.documentfoundation.org/show_bug.cgi?id=124059 Gabor Kelemen (allotropia) changed: What|Removed |Added Blocks|107830 |120466 CC||kelem...@ubuntu.com Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107830 [Bug 107830] [META] DOCX (OOXML) paragraph-related issues https://bugs.documentfoundation.org/show_bug.cgi?id=120466 [Bug 120466] [META] DOCX (OOXML) anchor and text wrapping bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 115625] FILEOPEN DOCX: Table placed on wrong position because of Frame Wrap
https://bugs.documentfoundation.org/show_bug.cgi?id=115625 --- Comment #9 from Justin L --- This kind of bug report is duplicated several times. Apparently LO doesn't really consider a table something that needs to be affected by wrapping. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 31914] FILEOPEN: incorrectly formatting 2007 DOCX; missing first page text shape content with Content Controls
https://bugs.documentfoundation.org/show_bug.cgi?id=31914 --- Comment #23 from Justin L --- Yeah - we can't put content controls into an editeng textbox. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154215] New: The WeekNum worksheet function is very slow
https://bugs.documentfoundation.org/show_bug.cgi?id=154215
Bug ID: 154215
Summary: The WeekNum worksheet function is very slow
Product: LibreOffice
Version: unspecified
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: medium
Component: BASIC
Assignee: libreoffice-bugs@lists.freedesktop.org
Reporter: junkyardma...@frontier.com
Description:
More than 1000x > than Excel
Steps to Reproduce:
1. Run the code in the other information section.
2.
3.
Actual Results:
12 seconds for 10K WeekNum() calls (> 1ms per)
More than 1000x > than Excel
Expected Results:
Reasonably close to Excel performance (< 10x)
0.101 seconds for 10K WeekNum() calls
Reproducible: Always
User Profile Reset: No
Additional Info:
Option VBASupport 1
Sub WeekNum_Function_Performance()
Dim T1 As Single
Dim T2 As Single
With WorksheetFunction
T1 = Timer()
For i = 1 To 1
WkNum = .WeekNum("03/14/2023", 1)
Next i
T2 = Timer()
End With
MsgBox ("Iterations: " & i & ", Time: " & T2 - T1)
End Sub
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-commits] core.git: svx/uiconfig
svx/uiconfig/ui/imapdialog.ui |1 + 1 file changed, 1 insertion(+) New commits: commit 1aeacf54bf6c961d89678e961c747ff76d867c5f Author: Michael Weghorn AuthorDate: Wed Mar 15 11:09:42 2023 +0100 Commit: Adolfo Jayme Barrientos CommitDate: Wed Mar 15 20:54:12 2023 + tdf#153167 Re-add ImageMap Editor dialog title again Essentially reapply commit 66291d467be4bf0e841814111d57d1af76117f8e Date: Mon Jan 23 12:15:50 2023 -0600 tdf#153167 ImageMap Editor dialog had no title after it has been reverted in commit a90ef17809071b808a8c703e7e47e045ddabcd4a Date: Tue Jan 24 08:36:48 2023 + Revert "tdf#153167 ImageMap Editor dialog had no title" This reverts commit 66291d467be4bf0e841814111d57d1af76117f8e. Reason for revert: didn't wait for jenkins and broke the build translatable strings need context attribute. , but this time add the required context attribute as well, as it used to be before commit 8a35ae3e6c5c45aa1426cfd81472b309d02a1b48 Date: Thu May 16 15:17:38 2019 +0100 weld SvxIMapDlg Co-authored-by: Adolfo Jayme Barrientos Change-Id: Id777e457fe144b0f0746cfc19e7e13e6db7a89a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148914 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos diff --git a/svx/uiconfig/ui/imapdialog.ui b/svx/uiconfig/ui/imapdialog.ui index faea4d096736..9365875f47dc 100644 --- a/svx/uiconfig/ui/imapdialog.ui +++ b/svx/uiconfig/ui/imapdialog.ui @@ -5,6 +5,7 @@ False 6 +ImageMap Editor 0 0 dialog
[Libreoffice-bugs] [Bug 152943] GetErrCode() doesn't work as expected on RISC-V due to floating-point NaN payload not being propagated
https://bugs.documentfoundation.org/show_bug.cgi?id=152943 --- Comment #5 from Eike Rathke --- From https://groups.google.com/a/groups.riscv.org/g/isa-dev/c/g79dHlV4B_k/m/dtlPNaq8AwAJ "Implementors are free to provide a NaN payload propagation scheme as a nonstandard extension enabled by a nonstandard operating mode." I deduce that there may be RISC-V systems that support propagating NaN payloads. So with bad luck a build, even if it did make check on such system, would not run properly on systems that do not support the extension. We might have to have a runtime check in Calc as well and bail out if NaN payloads are not supported. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 95228] FILEOPEN DOCX Textboxes overlap
https://bugs.documentfoundation.org/show_bug.cgi?id=95228 Justin L changed: What|Removed |Added Priority|medium |lowest Hardware|x86-64 (AMD64) |All OS|Windows (All) |All --- Comment #8 from Justin L --- Yeah, like comment 5 says, there is more than just textboxes here. It totally depends on a page-wide transparent image to contour-wrap paragraphs to the next page. The design of this document is atrocious. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 135706] Text behind image frame after saving DOCX (as character frame)
https://bugs.documentfoundation.org/show_bug.cgi?id=135706 Telesto changed: What|Removed |Added Keywords|bibisectRequest | -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154197] Pivot Table with column named "Data" does not show in Data Fields pane -EDITING
https://bugs.documentfoundation.org/show_bug.cgi?id=154197 --- Comment #2 from Alistair Saywell --- Original spreadsheet from Meta.xml was created in LibreOffice/7.0.4.2$Linux_ARM_EABI LibreOffice_project I modified it in 7.3.7.2 just to add image so neither is earlier version. It was created in German language version so the word displayed in Data fields was "Daten" not "Date". Apparently, it still displays "Daten" in German version, de.DE. Maybe better to have an error dialogue on creation of pivot table based on a range with a heading using reserved words so the issue could be corrected before the pivot table is created. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139666] Text hidden behind red arrow after DOCX export (but visible in ODT) (wrap issue)
https://bugs.documentfoundation.org/show_bug.cgi?id=139666 Telesto changed: What|Removed |Added Keywords|bibisectRequest, regression | -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152943] GetErrCode() doesn't work as expected on RISC-V due to floating-point NaN payload not being propagated
https://bugs.documentfoundation.org/show_bug.cgi?id=152943 Eike Rathke changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 Version|7.6.0.0 alpha0+ Master |Inherited From OOo OS|Linux (All) |All -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 114426] [META] Caption bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=114426 sdc.bla...@youmail.dk changed: What|Removed |Added Depends on||154214 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=154214 [Bug 154214] redesign proposal for Caption Options dialog -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154214] redesign proposal for Caption Options dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=154214 sdc.bla...@youmail.dk changed: What|Removed |Added Blocks||114426 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=114426 [Bug 114426] [META] Caption bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154214] New: redesign proposal for Caption Options dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=154214 Bug ID: 154214 Summary: redesign proposal for Caption Options dialog Product: LibreOffice Version: 7.6.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: sdc.bla...@youmail.dk Created attachment 185992 --> https://bugs.documentfoundation.org/attachment.cgi?id=185992=edit glade preview of proposed redesign Attached is Glade preview screenshot for proposed redesign of Caption Options dialog. Main features: 1. groups options under meaningful section titles 2. organizes sections starting with the one that affects greater number of users, and then downward. 3. better labelling (i.e., more accurate presentation of the function of each option) Comparison with current dialog 1. (has poor section titles) 2. (no apparent logic to section ordering) 3. (labels are wrong, hard to understand in Category and Frame Format section) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 104449] [META] DOCX (OOXML) textbox-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=104449 Bug 104449 depends on bug 135706, which changed state. Bug 135706 Summary: Text behind image frame after saving DOCX (as character frame) https://bugs.documentfoundation.org/show_bug.cgi?id=135706 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 104450] [META] DOCX (OOXML) file opening issues
https://bugs.documentfoundation.org/show_bug.cgi?id=104450 Bug 104450 depends on bug 135706, which changed state. Bug 135706 Summary: Text behind image frame after saving DOCX (as character frame) https://bugs.documentfoundation.org/show_bug.cgi?id=135706 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 135706] Text behind image frame after saving DOCX (as character frame)
https://bugs.documentfoundation.org/show_bug.cgi?id=135706 Justin L changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #8 from Justin L --- *** This bug has been marked as a duplicate of bug 96579 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 96579] [WRITER] Figure caption badly converted in Word format because image anchoring and wrapping is changed to as-character/DML
https://bugs.documentfoundation.org/show_bug.cgi?id=96579 --- Comment #18 from Justin L --- *** Bug 135706 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142855] Heading below image after DOCX export (anchored vertical-bottom-of-paragraph)
https://bugs.documentfoundation.org/show_bug.cgi?id=142855 Justin L changed: What|Removed |Added Summary|Heading below image after |Heading below image after |DOCX export |DOCX export (anchored ||vertical-bottom-of-paragrap ||h) --- Comment #7 from Justin L --- Lots of emulation happening here, since an ODT frame changes to a DOCX drawing something. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154205] Crash on reload of file (segfault in libswlo.so)
https://bugs.documentfoundation.org/show_bug.cgi?id=154205 --- Comment #2 from Caolán McNamara --- https://gerrit.libreoffice.org/c/core/+/148939 and https://gerrit.libreoffice.org/c/core/+/148940 might help -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: connectivity/source vcl/source
connectivity/source/manager/mdrivermanager.cxx |7 ++
vcl/source/window/layout.cxx | 28 +
2 files changed, 35 insertions(+)
New commits:
commit 5377a98c2cb78b0768d469ff379f9add9aaa7b68
Author: Stephan Bergmann
AuthorDate: Tue Mar 14 22:33:32 2023 +0100
Commit: Stephan Bergmann
CommitDate: Wed Mar 15 19:57:23 2023 +
Silence some false -Werror=dangling-reference
...seen at least with gcc-c++-13.0.1-0.7.fc38.x86_64,
> connectivity/source/manager/mdrivermanager.cxx: In lambda function:
> connectivity/source/manager/mdrivermanager.cxx:621:41: error: possibly
dangling reference to a temporary [-Werror=dangling-reference]
> 621 | const DriverAccess& ensuredAccess =
EnsureDriver(m_xContext)(driverAccess);
> | ^
> connectivity/source/manager/mdrivermanager.cxx:621:81: note: the
temporary was destroyed at the end of the full expression
‘drivermanager::{anonymous}::EnsureDriver(this->drivermanager::OSDBCDriverManager::m_xContext).drivermanager::{anonymous}::EnsureDriver::operator()((*
& driverAccess))’
> 621 | const DriverAccess& ensuredAccess =
EnsureDriver(m_xContext)(driverAccess);
> |
^~
and
> vcl/source/window/layout.cxx: In function ‘array_type assembleGrid(const
VclGrid&)’:
> vcl/source/window/layout.cxx:952:30: error: possibly dangling reference
to a temporary [-Werror=dangling-reference]
> 952 | const GridEntry = A[x][y];
> | ^~
> vcl/source/window/layout.cxx:952:45: note: the temporary was destroyed at
the end of the full expression ‘boost::multi_array_ref::operator[](index) [with T = {anonymous}::GridEntry; long unsigned int
NumDims = 2; reference =
boost::detail::multi_array::sub_array<{anonymous}::GridEntry, 1>; index = long
int](((boost::multi_array_ref<{anonymous}::GridEntry,
2>::index)x)).boost::detail::multi_array::sub_array<{anonymous}::GridEntry,
1>::operator[](((boost::detail::multi_array::sub_array<{anonymous}::GridEntry,
1>::index)y))’
> 952 | const GridEntry = A[x][y];
> | ^
> vcl/source/window/layout.cxx: In function ‘void calcMaxs(const
array_type&, std::__debug::vector&,
std::__debug::vector&)’:
> vcl/source/window/layout.cxx:1075:30: error: possibly dangling reference
to a temporary [-Werror=dangling-reference]
> 1075 | const GridEntry = A[x][y];
> | ^~
> vcl/source/window/layout.cxx:1075:45: note: the temporary was destroyed
at the end of the full expression ‘boost::multi_array_ref::operator[](index) const [with T = {anonymous}::GridEntry; long
unsigned int NumDims = 2; const_reference =
boost::detail::multi_array::const_sub_array<{anonymous}::GridEntry, 1, const
{anonymous}::GridEntry*>; index = long
int](((boost::multi_array_ref<{anonymous}::GridEntry,
2>::index)x)).boost::detail::multi_array::const_sub_array<{anonymous}::GridEntry,
1, const
{anonymous}::GridEntry*>::operator[](((boost::detail::multi_array::const_sub_array<{anonymous}::GridEntry,
1, const {anonymous}::GridEntry*>::index)y))’
> 1075 | const GridEntry = A[x][y];
> | ^
> vcl/source/window/layout.cxx:1106:30: error: possibly dangling reference
to a temporary [-Werror=dangling-reference]
> 1106 | const GridEntry = A[x][y];
> | ^~
> vcl/source/window/layout.cxx:1106:45: note: the temporary was destroyed
at the end of the full expression ‘boost::multi_array_ref::operator[](index) const [with T = {anonymous}::GridEntry; long
unsigned int NumDims = 2; const_reference =
boost::detail::multi_array::const_sub_array<{anonymous}::GridEntry, 1, const
{anonymous}::GridEntry*>; index = long
int](((boost::multi_array_ref<{anonymous}::GridEntry,
2>::index)x)).boost::detail::multi_array::const_sub_array<{anonymous}::GridEntry,
1, const
{anonymous}::GridEntry*>::operator[](((boost::detail::multi_array::const_sub_array<{anonymous}::GridEntry,
1, const {anonymous}::GridEntry*>::index)y))’
> 1106 | const GridEntry = A[x][y];
> | ^
Change-Id: I498bb468ade52f83117c8cf57f8d64697978d9ff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148921
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/connectivity/source/manager/mdrivermanager.cxx
b/connectivity/source/manager/mdrivermanager.cxx
index dbc35c2c4072..c4b884cc973b 100644
--- a/connectivity/source/manager/mdrivermanager.cxx
+++
[Libreoffice-bugs] [Bug 152943] GetErrCode() doesn't work as expected on RISC-V due to floating-point NaN payload not being propagated
https://bugs.documentfoundation.org/show_bug.cgi?id=152943 --- Comment #4 from Commit Notification --- Eike Rathke committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/2fd915b7d2d2a9e25600a07587ab01d23bffbc58 Related: tdf#152943 Test that a quiet NaN payload is propagated It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152943] GetErrCode() doesn't work as expected on RISC-V due to floating-point NaN payload not being propagated
https://bugs.documentfoundation.org/show_bug.cgi?id=152943 Commit Notification changed: What|Removed |Added Whiteboard||target:7.6.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sal/qa
sal/qa/rtl/math/test-rtl-math.cxx | 24
1 file changed, 24 insertions(+)
New commits:
commit 2fd915b7d2d2a9e25600a07587ab01d23bffbc58
Author: Eike Rathke
AuthorDate: Wed Mar 15 17:37:14 2023 +0100
Commit: Eike Rathke
CommitDate: Wed Mar 15 19:55:32 2023 +
Related: tdf#152943 Test that a quiet NaN payload is propagated
Change-Id: Ib98b507db9305ed20e3000f7f457a135a3bb3836
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148936
Reviewed-by: Eike Rathke
Tested-by: Jenkins
diff --git a/sal/qa/rtl/math/test-rtl-math.cxx
b/sal/qa/rtl/math/test-rtl-math.cxx
index f0288fd50e0e..57ac2a2616f0 100644
--- a/sal/qa/rtl/math/test-rtl-math.cxx
+++ b/sal/qa/rtl/math/test-rtl-math.cxx
@@ -642,6 +642,29 @@ public:
CPPUNIT_ASSERT(std::isnan(res));
}
+void test_payloadNaN() {
+// Test that a quiet NaN payload is propagated and behaves as we
+// expect. Ideally that could be done with a constexpr in
+// sal/rtl/math.cxx to fail already during compile time instead of make
+// check, but..
+// See
+//
https://grouper.ieee.org/groups/msc/ANSI_IEEE-Std-754-2019/background/nan-propagation.pdf
+double fVal1 = std::numeric_limits::quiet_NaN();
+reinterpret_cast()->nan_parts.fraction_lo =
0xbeef;
+const double fVal2 = 0 + fVal1;
+CPPUNIT_ASSERT(std::isnan(fVal2));
+CPPUNIT_ASSERT_EQUAL_MESSAGE("Your platform does not support
propagation of NaN payloads.",
+static_cast(0xbeef),
+static_cast(reinterpret_cast()->nan_parts.fraction_lo));
+reinterpret_cast()->nan_parts.fraction_lo =
0xdead;
+const double fVal3 = fVal1 + fVal2;
+// Result is one of the payloaded NaNs but the standard does not
+// specify which.
+CPPUNIT_ASSERT_MESSAGE("Your platform does not support propagation of
two combined NaN payloads.",
+0xbeef == reinterpret_cast()->nan_parts.fraction_lo ||
+0xdead == reinterpret_cast()->nan_parts.fraction_lo);
+}
+
CPPUNIT_TEST_SUITE(Test);
CPPUNIT_TEST(test_stringToDouble_good);
CPPUNIT_TEST(test_stringToDouble_bad);
@@ -656,6 +679,7 @@ public:
CPPUNIT_TEST(test_acosh);
CPPUNIT_TEST(test_asinh);
CPPUNIT_TEST(test_atanh);
+CPPUNIT_TEST(test_payloadNaN);
CPPUNIT_TEST_SUITE_END();
};
[Libreoffice-bugs] [Bug 118017] [META] macOS Dark Mode bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=118017 Bug 118017 depends on bug 154169, which changed state. Bug 154169 Summary: macOS Dark mode: black tree menu lines on dark background in LO preferences https://bugs.documentfoundation.org/show_bug.cgi?id=154169 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/qa
sw/qa/extras/uiwriter/data/tdf64242_optimizeTable.odt |binary 1 file changed New commits: commit ebaccbd0acc41bfb6c1a1321656679b18026d983 Author: Caolán McNamara AuthorDate: Wed Mar 15 12:39:43 2023 + Commit: Caolán McNamara CommitDate: Wed Mar 15 19:50:07 2023 + avoid font replacement in test Change-Id: Id3ec97f0859cf7c702ad0a501c2431af1df997d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148923 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/sw/qa/extras/uiwriter/data/tdf64242_optimizeTable.odt b/sw/qa/extras/uiwriter/data/tdf64242_optimizeTable.odt index 83d9be2cdf16..9aac8d2fd022 100644 Binary files a/sw/qa/extras/uiwriter/data/tdf64242_optimizeTable.odt and b/sw/qa/extras/uiwriter/data/tdf64242_optimizeTable.odt differ
[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - vcl/source
vcl/source/treelist/svimpbox.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit 0573c5d067d866fc00178942d1db397da499670b Author: Caolán McNamara AuthorDate: Sun Mar 12 21:19:15 2023 + Commit: Caolán McNamara CommitDate: Wed Mar 15 19:49:39 2023 + tdf#132847 emit NotifyScrolled on use of end/home to scroll to end/start Change-Id: I8d4366b6ad667f28ff35f18fef13f2e0f3e9b194 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148757 Reviewed-by: Michael Stahl Tested-by: Jenkins diff --git a/vcl/source/treelist/svimpbox.cxx b/vcl/source/treelist/svimpbox.cxx index beb5435920ec..32f3d234166f 100644 --- a/vcl/source/treelist/svimpbox.cxx +++ b/vcl/source/treelist/svimpbox.cxx @@ -946,6 +946,7 @@ void SvImpLBox::MakeVisible( SvTreeListEntry* pEntry, bool bMoveToTop ) FillView(); m_aVerSBar->SetThumbPos( static_cast(m_pView->GetVisiblePos( m_pStartEntry )) ); ShowCursor( true ); +m_pView->NotifyScrolled(); m_pView->Invalidate(); }
[Libreoffice-commits] core.git: vcl/source
vcl/source/treelist/svimpbox.cxx |8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) New commits: commit edf9d231dd5dc197aeb627bb0712dbc0db37f42e Author: Caolán McNamara AuthorDate: Tue Mar 14 11:18:36 2023 + Commit: Caolán McNamara CommitDate: Wed Mar 15 19:49:50 2023 + Resolves: tdf#154169 tree lines not visible in macOS dark mode or kf5, a collision in expectations between commit db6fbb0317fcb0a7babca9f71adbbb7c126b9e4e Date: Tue Feb 14 08:56:13 2023 + base section Titles are invisible in dark mode and commit 5f9cd841a22fa7eb6f29ca8b9a35a8b016fb3d56 Date: Thu Oct 13 22:03:27 2022 +0200 tdf#144587 Fix lines in treelists using dark mode As reported by the user, the lines in a treelist are dark over a dark background. This patch fixes that. where db6fbb0317fcb0a7babca9f71adbbb7c126b9e4e basically undid the work of 5f9cd841a22fa7eb6f29ca8b9a35a8b016fb3d56 making the tree lines indistinct again when making the base heading distinct I think "LightColor" and "ShadowColor" etc should be thought of from the perspective of the expectations of the original "Light Mode" and "LightColor" is basically close to the window/canvas background and "ShadowColor" basically close to the the text foreground color, so "LightColor" is something close to Black in "Dark Mode" and not typically suitable for drawing on the default background, while "ShadowColor" is something close to White in "Dark Mode" and suitable for use on the default background. also drop restoring the line color with rRenderContext.SetLineColor(aOldLineColor); because the Push(...LINECOLOR), Pop() does that automatically Change-Id: Ic08a8563f41f892c75a08195c04cd9b9c2abf4da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148848 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/vcl/source/treelist/svimpbox.cxx b/vcl/source/treelist/svimpbox.cxx index 32f3d234166f..c61fec0f001a 100644 --- a/vcl/source/treelist/svimpbox.cxx +++ b/vcl/source/treelist/svimpbox.cxx @@ -1023,12 +1023,7 @@ void SvImpLBox::DrawNet(vcl::RenderContext& rRenderContext) const StyleSettings& rStyleSettings = rRenderContext.GetSettings().GetStyleSettings(); // Set color to draw the vertical and horizontal lines -Color aOldLineColor = rRenderContext.GetLineColor(); -Color aBackgroundColor = rRenderContext.GetBackground().GetColor(); -if (aBackgroundColor.IsDark()) -rRenderContext.SetLineColor(rStyleSettings.GetLightColor()); -else -rRenderContext.SetLineColor(rStyleSettings.GetShadowColor()); +rRenderContext.SetLineColor(rStyleSettings.GetShadowColor()); Point aPos1, aPos2; sal_uInt16 nDistance; @@ -1069,7 +1064,6 @@ void SvImpLBox::DrawNet(vcl::RenderContext& rRenderContext) pEntry = m_pView->NextVisible(pEntry); } -rRenderContext.SetLineColor(aOldLineColor); rRenderContext.Pop(); }
[Libreoffice-qa] Minutes from the UX/design meeting 2023-Mar-15
Present: Cor, Heiko Comments: Dieter, Stephane, Jim, Eyal, Regina, Caolan, Andrea Tickets/Topics * Keyboard short cut to traverse over open modules + https://bugs.documentfoundation.org/show_bug.cgi?id=147219 + could be a UNO command to access uno:WindowList or some Alt+W+ mnemonic (Heiko) + isn't it a question of the OS, eg. alt+^ switches between windows of the active application in Gnome (Cor) => function welcome, comment on ticket * MASTER DOCUMENT: In navigator 'Insert -> File' should be 'Insert -> Text File' to be more precise + https://bugs.documentfoundation.org/show_bug.cgi?id=153666 + agree with renaming (Dieter) + Insert from the popup menu is the same as Insert > Text from File... and unifying the labels makes sense (Heiko) + "Insert > Insert from File" replaces the current text while Insert > File adds the document into a new section (Cor) + rename to "Text Document" to make it clear what type of document can be loaded (Heiko) + could be misunderstood as ASCII text or RTF files (Cor) => resolve WF/NAB also to keep the help * In Writer, there should be 3 types of hyperlinks + https://bugs.documentfoundation.org/show_bug.cgi?id=153740 + somewhat over-engineering (Dieter) + if, it should be done for all types (Stephane) + easy-hackable (Jim) + some options like a) different underlining, b) split the hyperlink section in the navigator, c) add icons (Heiko) + a) not so good, b) could have merits, c) clutters (Eyal) + hovering over the entry shows the type (Cor) => use case needed to make coding necessary * Request: Rename "Square" gradient to "Rectangle" gradient in the UI + https://bugs.documentfoundation.org/show_bug.cgi?id=154071 + a) "Square" -> "Rectangle", b) "Quadratic" -> "Quadratic (square)" + +1 for a) -0.5 for b) with the explanation in brackets (Heiko) + needed for transition (Regina) + agree with both (Eyal) + we need to make sure that renaming wont affect legacy documents (Cor) + "Rectangular" and as a compromise "Square (Quadratic)" using the old name in brackets (Heiko) => do it * Impress: Improve search for animations + https://bugs.documentfoundation.org/show_bug.cgi?id=149015 + easy-hackable (Caolan) + consistency is prime (Eyal, Heiko) => do it * Bring back the transparency option + https://bugs.documentfoundation.org/show_bug.cgi?id=154140 + moving this option into expert settings make sense (Heiko) + it's also about accessibility (Andreas) + option is not specific to Calc; was probably added to deal with performance issues with transparency back in the year dot (Cor) + if it is a FAQ we should consider to bring it back (Cor) => will ask for more info (Cor) OpenPGP_signature Description: OpenPGP digital signature
Minutes from the UX/design meeting 2023-Mar-15
Present: Cor, Heiko Comments: Dieter, Stephane, Jim, Eyal, Regina, Caolan, Andrea Tickets/Topics * Keyboard short cut to traverse over open modules + https://bugs.documentfoundation.org/show_bug.cgi?id=147219 + could be a UNO command to access uno:WindowList or some Alt+W+ mnemonic (Heiko) + isn't it a question of the OS, eg. alt+^ switches between windows of the active application in Gnome (Cor) => function welcome, comment on ticket * MASTER DOCUMENT: In navigator 'Insert -> File' should be 'Insert -> Text File' to be more precise + https://bugs.documentfoundation.org/show_bug.cgi?id=153666 + agree with renaming (Dieter) + Insert from the popup menu is the same as Insert > Text from File... and unifying the labels makes sense (Heiko) + "Insert > Insert from File" replaces the current text while Insert > File adds the document into a new section (Cor) + rename to "Text Document" to make it clear what type of document can be loaded (Heiko) + could be misunderstood as ASCII text or RTF files (Cor) => resolve WF/NAB also to keep the help * In Writer, there should be 3 types of hyperlinks + https://bugs.documentfoundation.org/show_bug.cgi?id=153740 + somewhat over-engineering (Dieter) + if, it should be done for all types (Stephane) + easy-hackable (Jim) + some options like a) different underlining, b) split the hyperlink section in the navigator, c) add icons (Heiko) + a) not so good, b) could have merits, c) clutters (Eyal) + hovering over the entry shows the type (Cor) => use case needed to make coding necessary * Request: Rename "Square" gradient to "Rectangle" gradient in the UI + https://bugs.documentfoundation.org/show_bug.cgi?id=154071 + a) "Square" -> "Rectangle", b) "Quadratic" -> "Quadratic (square)" + +1 for a) -0.5 for b) with the explanation in brackets (Heiko) + needed for transition (Regina) + agree with both (Eyal) + we need to make sure that renaming wont affect legacy documents (Cor) + "Rectangular" and as a compromise "Square (Quadratic)" using the old name in brackets (Heiko) => do it * Impress: Improve search for animations + https://bugs.documentfoundation.org/show_bug.cgi?id=149015 + easy-hackable (Caolan) + consistency is prime (Eyal, Heiko) => do it * Bring back the transparency option + https://bugs.documentfoundation.org/show_bug.cgi?id=154140 + moving this option into expert settings make sense (Heiko) + it's also about accessibility (Andreas) + option is not specific to Calc; was probably added to deal with performance issues with transparency back in the year dot (Cor) + if it is a FAQ we should consider to bring it back (Cor) => will ask for more info (Cor) OpenPGP_signature Description: OpenPGP digital signature
[Libreoffice-bugs] [Bug 104461] [META] DOCX (OOXML) frame-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=104461 Bug 104461 depends on bug 143292, which changed state. Bug 143292 Summary: Misaligned caption name in caption frame after DOCX/DOC export https://bugs.documentfoundation.org/show_bug.cgi?id=143292 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 96579] [WRITER] Figure caption badly converted in Word format because image anchoring and wrapping is changed to as-character/DML
https://bugs.documentfoundation.org/show_bug.cgi?id=96579 --- Comment #17 from Justin L --- *** Bug 143292 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143292] Misaligned caption name in caption frame after DOCX/DOC export
https://bugs.documentfoundation.org/show_bug.cgi?id=143292 Justin L changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #7 from Justin L --- *** This bug has been marked as a duplicate of bug 96579 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/qa
sw/qa/extras/tiledrendering/tiledrendering.cxx | 131 ++---
sw/qa/extras/uiwriter/uiwriter4.cxx|6 -
sw/qa/extras/uiwriter/uiwriter6.cxx| 10 -
sw/qa/extras/uiwriter/uiwriter7.cxx| 17 ---
sw/qa/extras/uiwriter/uiwriter8.cxx| 13 --
sw/qa/inc/swmodeltestbase.hxx |2
sw/qa/unit/swmodeltestbase.cxx | 12 ++
7 files changed, 52 insertions(+), 139 deletions(-)
New commits:
commit 797938b7bb897617a078fc7e57de27759a00ed07
Author: Xisco Fauli
AuthorDate: Wed Mar 15 14:38:46 2023 +0100
Commit: Xisco Fauli
CommitDate: Wed Mar 15 19:44:03 2023 +
SwModelTestBase: factor out common code
Change-Id: Iab415dadd3bc465d31bf14cbe2f384b9588466a1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148929
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
diff --git a/sw/qa/extras/tiledrendering/tiledrendering.cxx
b/sw/qa/extras/tiledrendering/tiledrendering.cxx
index 31eb9b267fba..fd5c469c4f3b 100644
--- a/sw/qa/extras/tiledrendering/tiledrendering.cxx
+++ b/sw/qa/extras/tiledrendering/tiledrendering.cxx
@@ -322,9 +322,7 @@ CPPUNIT_TEST_FIXTURE(SwTiledRenderingTest, testPostKeyEvent)
// Did we manage to go after the first character?
CPPUNIT_ASSERT_EQUAL(static_cast(1),
pShellCursor->GetPoint()->GetContentIndex());
-pXTextDocument->postKeyEvent(LOK_KEYEVENT_KEYINPUT, 'x', 0);
-pXTextDocument->postKeyEvent(LOK_KEYEVENT_KEYUP, 'x', 0);
-Scheduler::ProcessEventsToIdle();
+emulateTyping(*pXTextDocument, u"x");
// Did we manage to insert the character after the first one?
CPPUNIT_ASSERT_EQUAL(OUString("Axaa bbb."),
pShellCursor->GetPoint()->GetNode().GetTextNode()->GetText());
}
@@ -1028,9 +1026,7 @@ CPPUNIT_TEST_FIXTURE(SwTiledRenderingTest,
testShapeViewCursors)
SdrObject* pObject = pPage->GetObj(0);
SdrView* pView = pWrtShell2->GetDrawView();
pWrtShell2->GetView().BeginTextEdit(pObject, pView->GetSdrPageView(),
pWrtShell2->GetWin());
-pXTextDocument->postKeyEvent(LOK_KEYEVENT_KEYINPUT, 'x', 0);
-pXTextDocument->postKeyEvent(LOK_KEYEVENT_KEYUP, 'x', 0);
-Scheduler::ProcessEventsToIdle();
+emulateTyping(*pXTextDocument, u"x");
// Press a key in the second view, while the first one observes this.
aView1.m_bViewCursorInvalidated = false;
aView2.m_bOwnCursorInvalidated = false;
@@ -1039,9 +1035,7 @@ CPPUNIT_TEST_FIXTURE(SwTiledRenderingTest,
testShapeViewCursors)
const tools::Rectangle aLastOwnCursor2 = aView2.m_aOwnCursor;
const tools::Rectangle aLastViewCursor2 = aView2.m_aViewCursor;
-pXTextDocument->postKeyEvent(LOK_KEYEVENT_KEYINPUT, 'y', 0);
-pXTextDocument->postKeyEvent(LOK_KEYEVENT_KEYUP, 'y', 0);
-Scheduler::ProcessEventsToIdle();
+emulateTyping(*pXTextDocument, u"y");
// Make sure that aView1 gets a view-only cursor notification, while
// aView2 gets a real cursor notification.
CPPUNIT_ASSERT_EQUAL(aView1.m_aOwnCursor, aLastOwnCursor1);
@@ -1146,15 +1140,11 @@ CPPUNIT_TEST_FIXTURE(SwTiledRenderingTest,
testTextEditViewInvalidations)
SdrObject* pObject = pPage->GetObj(0);
SdrView* pView = pWrtShell->GetDrawView();
pWrtShell->GetView().BeginTextEdit(pObject, pView->GetSdrPageView(),
pWrtShell->GetWin());
-pXTextDocument->postKeyEvent(LOK_KEYEVENT_KEYINPUT, 'x', 0);
-pXTextDocument->postKeyEvent(LOK_KEYEVENT_KEYUP, 'x', 0);
-Scheduler::ProcessEventsToIdle();
+emulateTyping(*pXTextDocument, u"x");
// Assert that both views are invalidated when pressing a key while in
text edit.
aView1.m_bTilesInvalidated = false;
-pXTextDocument->postKeyEvent(LOK_KEYEVENT_KEYINPUT, 'y', 0);
-pXTextDocument->postKeyEvent(LOK_KEYEVENT_KEYUP, 'y', 0);
-Scheduler::ProcessEventsToIdle();
+emulateTyping(*pXTextDocument, u"y");
CPPUNIT_ASSERT(aView1.m_bTilesInvalidated);
@@ -1175,9 +1165,7 @@ CPPUNIT_TEST_FIXTURE(SwTiledRenderingTest,
testUndoInvalidations)
// Insert a character the end of the document.
SwWrtShell* pWrtShell = pXTextDocument->GetDocShell()->GetWrtShell();
pWrtShell->EndOfSection();
-pXTextDocument->postKeyEvent(LOK_KEYEVENT_KEYINPUT, 'c', 0);
-pXTextDocument->postKeyEvent(LOK_KEYEVENT_KEYUP, 'c', 0);
-Scheduler::ProcessEventsToIdle();
+emulateTyping(*pXTextDocument, u"c");
// ProcessEventsToIdle resets the view; set it again
SfxLokHelper::setView(nView1);
SwShellCursor* pShellCursor = pWrtShell->getShellCursor(false);
@@ -1206,9 +1194,7 @@ CPPUNIT_TEST_FIXTURE(SwTiledRenderingTest,
testUndoLimiting)
// Insert a character the end of the document in the second view.
SwWrtShell* pWrtShell2 = pXTextDocument->GetDocShell()->GetWrtShell();
pWrtShell2->EndOfSection();
-pXTextDocument->postKeyEvent(LOK_KEYEVENT_KEYINPUT, 'c', 0);
-pXTextDocument->postKeyEvent(LOK_KEYEVENT_KEYUP, 'c', 0);
-
[Libreoffice-bugs] [Bug 154140] Bring back the transparency option
https://bugs.documentfoundation.org/show_bug.cgi?id=154140 Cor Nouws changed: What|Removed |Added CC||c...@nouenoff.nl --- Comment #8 from Cor Nouws --- (In reply to Andreas Säger from comment #0) > Transparency option is now hidden in the "expert options". > > My most popular answer on ask.libreoffice.org is this: > https://ask.libreoffice.org/t/asked-before-calc-ver-7-3-1-3-highlighted-cell- > color/75738/4 Hi Andreas, It is happening so frequent and so complicated, that you think it is really worth bringing that option back from hidden to somewhere in the UI? thnx - Cor -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 154140] Bring back the transparency option
https://bugs.documentfoundation.org/show_bug.cgi?id=154140 Cor Nouws changed: What|Removed |Added CC||c...@nouenoff.nl --- Comment #8 from Cor Nouws --- (In reply to Andreas Säger from comment #0) > Transparency option is now hidden in the "expert options". > > My most popular answer on ask.libreoffice.org is this: > https://ask.libreoffice.org/t/asked-before-calc-ver-7-3-1-3-highlighted-cell- > color/75738/4 Hi Andreas, It is happening so frequent and so complicated, that you think it is really worth bringing that option back from hidden to somewhere in the UI? thnx - Cor -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 105035] FILEOPEN DOCX: Two frames, anchored to the same paragraph, imported as a single frame (comment 7)
https://bugs.documentfoundation.org/show_bug.cgi?id=105035 Justin L changed: What|Removed |Added CC||jl...@mail.com --- Comment #11 from Justin L --- The two frames are different because style Cm has a
[Libreoffice-bugs] [Bug 104461] [META] DOCX (OOXML) frame-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=104461 Bug 104461 depends on bug 127622, which changed state. Bug 127622 Summary: A text frame is imported from a specific DOCX as several separate frames which overlap https://bugs.documentfoundation.org/show_bug.cgi?id=127622 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 105035] FILEOPEN DOCX: Two frames, anchored to the same paragraph, imported as a single frame (comment 7)
https://bugs.documentfoundation.org/show_bug.cgi?id=105035 Justin L changed: What|Removed |Added CC||mikekagan...@hotmail.com --- Comment #10 from Justin L --- *** Bug 127622 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 127622] A text frame is imported from a specific DOCX as several separate frames which overlap
https://bugs.documentfoundation.org/show_bug.cgi?id=127622 Justin L changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #7 from Justin L --- *** This bug has been marked as a duplicate of bug 105035 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - svtools/source
svtools/source/misc/acceleratorexecute.cxx |2 ++
1 file changed, 2 insertions(+)
New commits:
commit 6720a608a7cc8fb11ae1f0c0bc9210bbf80134f4
Author: Patrick Luby
AuthorDate: Wed Feb 22 16:22:00 2023 -0500
Commit: Aron Budea
CommitDate: Wed Mar 15 19:38:40 2023 +
Fix build error when compiling on iOS or macOS with Xcode 14.2
Commit 67fcd647341118747a4e7cd404d907d29613778c was missing a return value
Signed-off-by: Patrick Luby
Change-Id: I1e6a0bf2ec65d3bb03eced6518611a7567a34a6b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147492
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Patrick Luby
(cherry picked from commit 99e6cbab7bb5954f0ee5792d07e1ba543260f434)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148870
Tested-by: Aron Budea
Reviewed-by: Aron Budea
diff --git a/svtools/source/misc/acceleratorexecute.cxx
b/svtools/source/misc/acceleratorexecute.cxx
index 099616fe07e2..ebe93bf7daa4 100644
--- a/svtools/source/misc/acceleratorexecute.cxx
+++ b/svtools/source/misc/acceleratorexecute.cxx
@@ -421,6 +421,8 @@ css::uno::Reference
AcceleratorExecute::lok_
}
catch(const css::container::NoSuchElementException&)
{}
+
+return css::uno::Reference();
}
void
AcceleratorExecute::lok_setModuleConfig(css::uno::Reference
acceleratorConfig)
[Libreoffice-bugs] [Bug 127622] A text frame is imported from a specific DOCX as several separate frames which overlap
https://bugs.documentfoundation.org/show_bug.cgi?id=127622 Justin L changed: What|Removed |Added CC||jl...@mail.com --- Comment #6 from Justin L --- (In reply to NISZ LibreOffice Team from comment #3) > The text in the frame has several paragraphs and they have different > paragraph styles set. This seems to be the basis of breaking up the frame Yes, the documentation says that only "exactly identically defined framePr's are grouped together. So if there are any differences in x, y, etc, then they are separate frames. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 104461] [META] DOCX (OOXML) frame-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=104461 Bug 104461 depends on bug 149370, which changed state. Bug 149370 Summary: FILEOPEN DOCX Content imported without the frame https://bugs.documentfoundation.org/show_bug.cgi?id=149370 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 137788] FILEOPEN DOCX: Table in frame positioned wrongly
https://bugs.documentfoundation.org/show_bug.cgi?id=137788 --- Comment #13 from Justin L --- *** Bug 149370 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149370] FILEOPEN DOCX Content imported without the frame
https://bugs.documentfoundation.org/show_bug.cgi?id=149370 Justin L changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #4 from Justin L --- *** This bug has been marked as a duplicate of bug 137788 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 137788] FILEOPEN DOCX: Table in frame positioned wrongly
https://bugs.documentfoundation.org/show_bug.cgi?id=137788 --- Comment #12 from Justin L --- frame created by have the same across a regular paragraph and a blockTable (a table not inside ). Good luck. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154213] LibeOffice icons on the GNOME desktop are too big
https://bugs.documentfoundation.org/show_bug.cgi?id=154213 --- Comment #2 from Verhoeckx --- Created attachment 185991 --> https://bugs.documentfoundation.org/attachment.cgi?id=185991=edit GNOME icon template -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154213] LibeOffice icons on the GNOME desktop are too big
https://bugs.documentfoundation.org/show_bug.cgi?id=154213 --- Comment #1 from Verhoeckx --- Created attachment 185990 --> https://bugs.documentfoundation.org/attachment.cgi?id=185990=edit LibreOffice icon compared to a normal desktop icon This image was created by Tobias Bernard. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154213] New: LibeOffice icons on the GNOME desktop are too big
https://bugs.documentfoundation.org/show_bug.cgi?id=154213 Bug ID: 154213 Summary: LibeOffice icons on the GNOME desktop are too big Product: LibreOffice Version: 7.5.0.3 release Hardware: x86-64 (AMD64) OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: j.verhoe...@protonmail.com Description: Hello LibreOffice developers, The GNOME desktop has developed a standard how big the icons on their platform should be: https://developer.gnome.org/hig/guidelines/app-icons.html?highlight=icons#size-shape https://gitlab.gnome.org/Teams/Design/HIG-app-icons/blob/master/template.svg According to this standard the icons should adhere to the size of the base shape and shouldn't take the full height and width of the canvas. The problem with the icons of LibreOffice is that they take the full height of the canvas and don't follow the size of the base shape. The result is that the icons look too big on the GNOME desktop (in the Activities Overview and in the Dash). The solution is quiet simple: shrink the icons until they adhere to the base shape. This will improve the look and feel (the aesthetics) of the icons on the GNOME desktop a lot. --- I was made aware of this issue by a comment of Tobias Bernard (one of the main UX designers of the GNOME desktop) on Mastodon. You can find his comment here: https://mastodon.social/@tbernard/109982952297798479 --- LibreOffice 7.5 GNOME 43 Steps to Reproduce: 1. Install LibreOffice on the GNOME desktop 2. Look at the icons ;-) Actual Results: The icons are too big compared to all the other icons on the GNOME desktop. Expected Results: The icons should have the same size as all the other icons on the GNOME desktop. Reproducible: Always User Profile Reset: No Additional Info: A new set if icons especially for the GNOME desktop should be created in which the icons adhere to the base shape of the icon canvas. I'm not sure if the same problem also happens on the KDE desktop (or any other desktop) so this should be checked. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - include/vcl vcl/jsdialog vcl/source
include/vcl/jsdialog/executor.hxx |5 +
include/vcl/toolkit/menubtn.hxx |2 ++
include/vcl/weld.hxx |2 ++
vcl/jsdialog/executor.cxx |6 ++
vcl/source/control/menubtn.cxx| 17 +
5 files changed, 32 insertions(+)
New commits:
commit 9724250c50d8f890339aa44a1ae43ea81dfabb23
Author: Szymon Kłos
AuthorDate: Wed Mar 15 18:46:17 2023 +0100
Commit: Szymon Kłos
CommitDate: Wed Mar 15 19:21:31 2023 +
jsdialog: dump menu for menubutton
Change-Id: I449ae3f8cf294e2ab81a5b47862278e325f2cb1b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148937
Tested-by: Szymon Kłos
Reviewed-by: Szymon Kłos
diff --git a/include/vcl/jsdialog/executor.hxx
b/include/vcl/jsdialog/executor.hxx
index 0c47066da9fa..40214fb465af 100644
--- a/include/vcl/jsdialog/executor.hxx
+++ b/include/vcl/jsdialog/executor.hxx
@@ -66,6 +66,11 @@ public:
rDrawingArea.dblclick(rPos);
}
+static void trigger_selected(weld::MenuButton& rButton, const OString&
rIdent)
+{
+rButton.signal_selected(rIdent);
+}
+
static void trigger_value_changed(weld::SpinButton& rSpinButton)
{
rSpinButton.signal_value_changed();
diff --git a/include/vcl/toolkit/menubtn.hxx b/include/vcl/toolkit/menubtn.hxx
index ca77a48c9fec..7bb43cadb864 100644
--- a/include/vcl/toolkit/menubtn.hxx
+++ b/include/vcl/toolkit/menubtn.hxx
@@ -92,6 +92,8 @@ public:
virtual FactoryFunction GetUITestFactory() const override;
void SetCurItemId();
+
+virtual void DumpAsPropertyTree(tools::JsonWriter& rJsonWriter) override;
};
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/include/vcl/weld.hxx b/include/vcl/weld.hxx
index a1966434355a..1a1e5ab4a223 100644
--- a/include/vcl/weld.hxx
+++ b/include/vcl/weld.hxx
@@ -1576,6 +1576,8 @@ struct VCL_DLLPUBLIC TriStateEnabled
class VCL_DLLPUBLIC MenuButton : virtual public ToggleButton
{
+friend class ::LOKTrigger;
+
Link m_aSelectHdl;
protected:
diff --git a/vcl/jsdialog/executor.cxx b/vcl/jsdialog/executor.cxx
index 33e5884c74d2..997d0a515cc8 100644
--- a/vcl/jsdialog/executor.cxx
+++ b/vcl/jsdialog/executor.cxx
@@ -166,6 +166,12 @@ bool ExecuteAction(const std::string& nWindowId, const
OString& rWidget, StringM
return true;
}
+else if (sAction == "select")
+{
+LOKTrigger::trigger_selected(
+*pButton, OUStringToOString(rData["data"],
RTL_TEXTENCODING_ASCII_US));
+return true;
+}
}
}
else if (sControlType == "checkbox")
diff --git a/vcl/source/control/menubtn.cxx b/vcl/source/control/menubtn.cxx
index cd9b2095985e..64aec098db0f 100644
--- a/vcl/source/control/menubtn.cxx
+++ b/vcl/source/control/menubtn.cxx
@@ -265,6 +265,23 @@ void MenuButton::SetCurItemId(){
msCurItemIdent = mpMenu->GetCurItemIdent();
}
+void MenuButton::DumpAsPropertyTree(tools::JsonWriter& rJsonWriter)
+{
+PushButton::DumpAsPropertyTree(rJsonWriter);
+
+if (mpMenu)
+{
+auto aMenuNode = rJsonWriter.startArray("menu");
+for (int i = 0; i < mpMenu->GetItemCount(); i++)
+{
+auto aEntryNode = rJsonWriter.startStruct();
+auto sId = mpMenu->GetItemId(i);
+rJsonWriter.put("id", mpMenu->GetItemIdent(sId));
+rJsonWriter.put("text", mpMenu->GetItemText(sId));
+}
+}
+}
+
//class MenuToggleButton
MenuToggleButton::MenuToggleButton( vcl::Window* pParent, WinBits nWinBits )
[Libreoffice-bugs] [Bug 153666] MASTER DOCUMENT: In navigator 'Insert -> File' should be 'Insert -> Text File' to be more precise
https://bugs.documentfoundation.org/show_bug.cgi?id=153666 Cor Nouws changed: What|Removed |Added Version|7.5.0.3 release |Inherited From OOo -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 153666] MASTER DOCUMENT: In navigator 'Insert -> File' should be 'Insert -> Text File' to be more precise
https://bugs.documentfoundation.org/show_bug.cgi?id=153666 Cor Nouws changed: What|Removed |Added Version|7.5.0.3 release |Inherited From OOo -- You are receiving this mail because: You are on the CC list for the bug.
