[Libreoffice-commits] core.git: include/com sw/qa writerfilter/source

2023-03-22 Thread Mike Kaganski (via logerrit)
 include/com/sun/star/uno/Any.h|4 
 include/com/sun/star/uno/Any.hxx  |8 
 sw/qa/extras/ooxmlimport/data/tdf154319-ToC_with_s_and_d.docx |binary
 sw/qa/extras/ooxmlimport/ooxmlimport2.cxx |   50 +++
 writerfilter/source/dmapper/DomainMapper_Impl.cxx |  150 ++
 5 files changed, 162 insertions(+), 50 deletions(-)

New commits:
commit 76777c82fa4bb5080c135e2241c3f7122dcbb298
Author: Mike Kaganski 
AuthorDate: Tue Mar 21 21:35:58 2023 +0300
Commit: Mike Kaganski 
CommitDate: Thu Mar 23 04:39:28 2023 +

tdf#154319: fix TOC field codes parsing

Change-Id: I734697f52df14ca5b316481df8a58fef72ab9571
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149254
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/include/com/sun/star/uno/Any.h b/include/com/sun/star/uno/Any.h
index f232ccd90fe9..b453f5fa5b0c 100644
--- a/include/com/sun/star/uno/Any.h
+++ b/include/com/sun/star/uno/Any.h
@@ -451,6 +451,10 @@ template<>
 inline bool SAL_CALL operator >>= ( const Any & rAny, ::rtl::OUString & value 
);
 template<>
 inline bool SAL_CALL operator == ( const Any & rAny, const ::rtl::OUString & 
value );
+#if defined LIBO_INTERNAL_ONLY
+template
+inline bool SAL_CALL operator == (const Any& rAny, const 
rtl::OUStringLiteral& value);
+#endif
 // type
 template<>
 inline bool SAL_CALL operator >>= ( const Any & rAny, Type & value );
diff --git a/include/com/sun/star/uno/Any.hxx b/include/com/sun/star/uno/Any.hxx
index d73b2a586d61..6267d41e733c 100644
--- a/include/com/sun/star/uno/Any.hxx
+++ b/include/com/sun/star/uno/Any.hxx
@@ -600,6 +600,14 @@ inline bool SAL_CALL operator == ( const Any & rAny, const 
::rtl::OUString & val
 return (typelib_TypeClass_STRING == rAny.pType->eTypeClass &&
 value == * static_cast< const ::rtl::OUString * >( rAny.pData ) );
 }
+
+#if defined LIBO_INTERNAL_ONLY
+template
+inline bool SAL_CALL operator == (const Any& rAny, const 
rtl::OUStringLiteral& value)
+{
+return operator ==(rAny, rtl::OUString(value));
+}
+#endif
 // type
 
 template<>
diff --git a/sw/qa/extras/ooxmlimport/data/tdf154319-ToC_with_s_and_d.docx 
b/sw/qa/extras/ooxmlimport/data/tdf154319-ToC_with_s_and_d.docx
new file mode 100644
index ..dc5a67824c9d
Binary files /dev/null and 
b/sw/qa/extras/ooxmlimport/data/tdf154319-ToC_with_s_and_d.docx differ
diff --git a/sw/qa/extras/ooxmlimport/ooxmlimport2.cxx 
b/sw/qa/extras/ooxmlimport/ooxmlimport2.cxx
index 09de11d4c0bb..e556d3e08625 100644
--- a/sw/qa/extras/ooxmlimport/ooxmlimport2.cxx
+++ b/sw/qa/extras/ooxmlimport/ooxmlimport2.cxx
@@ -1037,6 +1037,56 @@ CPPUNIT_TEST_FIXTURE(Test, testTdf153791)
 CPPUNIT_ASSERT_EQUAL(COL_AUTO, getProperty(xRun, "CharColor"));
 }
 
+CPPUNIT_TEST_FIXTURE(Test, testTdf154319)
+{
+createSwDoc("tdf154319-ToC_with_s_and_d.docx");
+
+css::uno::Reference 
xSupplier(mxComponent,
+   
css::uno::UNO_QUERY_THROW);
+auto xIndexes = xSupplier->getDocumentIndexes();
+css::uno::Reference 
xTOCIndex(xIndexes->getByIndex(0),
+
css::uno::UNO_QUERY_THROW);
+css::uno::Reference xLevelFormats;
+CPPUNIT_ASSERT(xTOCIndex->getPropertyValue("LevelFormat") >>= 
xLevelFormats);
+CPPUNIT_ASSERT_EQUAL(sal_Int32(11), xLevelFormats->getCount());
+
+const auto checkPropVal = [](const auto& expected, const 
css::beans::PropertyValues& entry,
+ const OUString& name) {
+auto it
+= std::find_if(entry.begin(), entry.end(),
+   [](const css::beans::PropertyValue& p) { 
return p.Name == name; });
+OString msg = "Property: " + name.toUtf8();
+CPPUNIT_ASSERT_MESSAGE(msg.getStr(), it != entry.end());
+CPPUNIT_ASSERT_EQUAL_MESSAGE(msg.getStr(), css::uno::Any(expected), 
it->Value);
+};
+
+//start with level 1, 0 is the header level
+for (sal_Int32 nLevel = 1; nLevel < xLevelFormats->getCount(); ++nLevel)
+{
+css::uno::Sequence aLevel;
+xLevelFormats->getByIndex(nLevel) >>= aLevel;
+
+CPPUNIT_ASSERT_EQUAL(sal_Int32(8), aLevel.getLength());
+
+checkPropVal(OUString("TokenHyperlinkStart"), aLevel[0], "TokenType");
+
+checkPropVal(OUString("TokenEntryNumber"), aLevel[1], "TokenType");
+
+checkPropVal(OUString("TokenEntryText"), aLevel[2], "TokenType");
+
+checkPropVal(OUString("TokenTabStop"), aLevel[3], "TokenType");
+
+checkPropVal(OUString("TokenChapterInfo"), aLevel[4], "TokenType");
+
+checkPropVal(OUString("TokenText"), aLevel[5], "TokenType");
+checkPropVal(OUString("\""), aLevel[5], "Text");
+
+checkPropVal(OUString("TokenPageNumber"), aLevel[6], "TokenType");
+
+checkPropVal(OUString("TokenHyperlinkEnd"), aLevel[7], "TokenType");
+ 

[Libreoffice-bugs] [Bug 154078] [EDITING][FILESAVE]:Finish Signing option in info-bar not functioning

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154078

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153988] Autocorrect dialog should offer starting-ending quote pairs more conveniently

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153988

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 153988] Autocorrect dialog should offer starting-ending quote pairs more conveniently

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153988

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 154057] Cell focus when creating a URL link button may be inconsistent

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154057

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154062] First document to open takes very long to load. Second will load quickly. (Windows)

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154062

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150556] Libreoffice 7.3.5.2 x64 can't open or save ODS files

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150556

--- Comment #3 from QA Administrators  ---
Dear jeremy,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 153988] Autocorrect dialog should offer starting-ending quote pairs more conveniently

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153988

QA Administrators  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-ux-advise] [Bug 153988] Autocorrect dialog should offer starting-ending quote pairs more conveniently

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153988

--- Comment #3 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 153988] Autocorrect dialog should offer starting-ending quote pairs more conveniently

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153988

--- Comment #3 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153988] Autocorrect dialog should offer starting-ending quote pairs more conveniently

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153988

QA Administrators  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150556] Libreoffice 7.3.5.2 x64 can't open or save ODS files

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150556

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150322] EDITING: An ordered list will reset the footnote sequence

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150322

--- Comment #3 from QA Administrators  ---
Dear K K,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150322] EDITING: An ordered list will reset the footnote sequence

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150322

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143847] Setting a DOCX to multi-page view; affecting other DOCX documents on file open

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143847

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143847] Setting a DOCX to multi-page view; affecting other DOCX documents on file open

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143847

--- Comment #17 from QA Administrators  ---
Dear Telesto,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143458] large tables can't be resized easily

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143458

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 143458] large tables can't be resized easily

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143458

--- Comment #13 from QA Administrators  ---
Dear ffs,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-ux-advise] [Bug 143458] large tables can't be resized easily

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143458

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 95307] Comments shown in wrong position when hovering over comment indicators

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=95307

--- Comment #7 from QA Administrators  ---
Dear helplibreoffice,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143458] large tables can't be resized easily

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143458

--- Comment #13 from QA Administrators  ---
Dear ffs,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 94113] Accessible focus event missing when caret moves to start of paragraph spanning two pages (see comment 11)

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=94113

--- Comment #12 from QA Administrators  ---
Dear Joanmarie Diggs,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 44763] Cell styles with localized names, in Pivot Table, replaced with en-US named styles, if pivot changed in en-US UI

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=44763

--- Comment #29 from QA Administrators  ---
Dear famo,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 79920] Fileopen DOCX: Diagram shapes not displayed correctly

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=79920

--- Comment #20 from QA Administrators  ---
Dear Richard,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 141136] Tabbed toolbar mode keeps switching you away from the current tab to the "Home" tab each time you enter (focus) or leave a comment

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141136

--- Comment #6 from QA Administrators  ---
Dear Jean-François Fortin Tam,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 141124] Part of TOC Index goes to next page after index update (until some type in it)

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141124

--- Comment #17 from QA Administrators  ---
Dear Georgy Litvinov,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 124104] LibreOffice Base: Text cut off in GUI elements with font scaling enabling or when font size increased above 12 point

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124104

--- Comment #5 from QA Administrators  ---
Dear Allan Macdonald,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 123864] No feedback for screen reader when radio button for underline attribute changes

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123864

--- Comment #16 from QA Administrators  ---
Dear Jean-Philippe MENGUAL,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 123498] Contextual menu from sidebar is not accessible with keyboard

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123498

--- Comment #3 from QA Administrators  ---
Dear Arnaud Versini,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154330] PDF password protect from copying does not protect from copying

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154330

--- Comment #3 from pingo  ---
Can see that LO-generated password-protected pdfs may perform differently in
different viewers. That certainly sounds complicated. Don't see how this is
duplicates tdf#49697 though.

Checked:
Copy-protected in Acrobat, Foxit
Not protected in Firefox, Sumatra, Avast Secure Browser, Edge, 

Interestingly, the file is not protected in LO. I get a box requiring a
password for a temp file, but just hitting Enter opens the pdf, which is then
not copy-protected.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154330] PDF password protect from copying does not protect from copying

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154330

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #2 from m.a.riosv  ---
Seems a complicated case.
Edge respect it.
Chrome for copy, but let's use it for search.
Firefox lets copy.
Acrobat reader respect the restrictions.

I'm not sure if it is a LO issue.

Looks like a duplicate of tdf#49697

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: include/docmodel include/oox oox/inc oox/source

2023-03-22 Thread Tomaž Vajngerl (via logerrit)
 include/docmodel/theme/FormatScheme.hxx  |   46 +++
 include/oox/drawingml/drawingmltypes.hxx |4 +
 oox/inc/drawingml/misccontexts.hxx   |8 +-
 oox/source/drawingml/drawingmltypes.cxx  |8 ++
 oox/source/drawingml/misccontexts.cxx|   93 ---
 5 files changed, 135 insertions(+), 24 deletions(-)

New commits:
commit 0d18262789fbe95eafe32bd775a9827ed99685ef
Author: Tomaž Vajngerl 
AuthorDate: Fri Feb 24 00:48:55 2023 +0900
Commit: Tomaž Vajngerl 
CommitDate: Thu Mar 23 02:28:08 2023 +

oox: import gradient fill to model::FormatScheme

Change-Id: I90bc7cf4239f08efbc7239928c34ccdbec20cb2c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147575
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl 

diff --git a/include/docmodel/theme/FormatScheme.hxx 
b/include/docmodel/theme/FormatScheme.hxx
index a256532791d9..39fa5d36ae0b 100644
--- a/include/docmodel/theme/FormatScheme.hxx
+++ b/include/docmodel/theme/FormatScheme.hxx
@@ -159,6 +159,52 @@ public:
 }
 };
 
+class DOCMODEL_DLLPUBLIC GradientStop
+{
+public:
+double mfPosition = 0.0; // 0.0 - 1.0
+ColorDefinition maColor;
+};
+
+enum class GradientType
+{
+Undefined,
+Linear,
+Circle,
+Rectangle,
+Shape,
+};
+
+struct DOCMODEL_DLLPUBLIC LinearGradientProperties
+{
+sal_Int32 mnAngle = 0;
+bool mbScaled = false;
+};
+
+struct DOCMODEL_DLLPUBLIC RelativeRectangle
+{
+sal_Int32 mnLeft = 0;
+sal_Int32 mnTop = 0;
+sal_Int32 mnRight = 0;
+sal_Int32 mnBottom = 0;
+};
+
+class DOCMODEL_DLLPUBLIC GradientFill : public Fill
+{
+public:
+bool mbRotateWithShape = false;
+GradientType meGradientType = GradientType::Undefined;
+std::vector maGradientStops;
+LinearGradientProperties maLinearGradient;
+RelativeRectangle maFillToRectangle;
+RelativeRectangle maTileRectangle;
+
+GradientFill()
+: Fill(FillType::Gradient)
+{
+}
+};
+
 // Format Scheme
 
 class DOCMODEL_DLLPUBLIC FillStyle
diff --git a/include/oox/drawingml/drawingmltypes.hxx 
b/include/oox/drawingml/drawingmltypes.hxx
index 5fe86d56439e..8dd5dee727d4 100644
--- a/include/oox/drawingml/drawingmltypes.hxx
+++ b/include/oox/drawingml/drawingmltypes.hxx
@@ -31,6 +31,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -100,6 +101,9 @@ css::awt::Size GetSize2D( const css::uno::Reference< 
css::xml::sax::XFastAttribu
 /** converts the attributes from a CT_RelativeRect to an IntegerRectangle2D */
 css::geometry::IntegerRectangle2D GetRelativeRect( const css::uno::Reference< 
css::xml::sax::XFastAttributeList >& xAttributes );
 
+void fillRelativeRectangle(model::RelativeRectangle& rRelativeRectangle,
+   const 
css::uno::Reference& xAttributes);
+
 /** converts EMUs into 1/100th mmm */
 sal_Int32 GetCoordinate( sal_Int32 nValue );
 
diff --git a/oox/inc/drawingml/misccontexts.hxx 
b/oox/inc/drawingml/misccontexts.hxx
index e2e255d10b64..6bbaa74efcf2 100644
--- a/oox/inc/drawingml/misccontexts.hxx
+++ b/oox/inc/drawingml/misccontexts.hxx
@@ -42,10 +42,9 @@ public:
 class GradientFillContext final : public ::oox::core::ContextHandler2
 {
 public:
-explicitGradientFillContext(
-::oox::core::ContextHandler2Helper const & rParent,
-const ::oox::AttributeList& rAttribs,
-GradientFillProperties& rGradientProps );
+explicit GradientFillContext(::oox::core::ContextHandler2Helper const & 
rParent,
+const ::oox::AttributeList& rAttribs, GradientFillProperties& 
rGradientProps,
+model::GradientFill* pGradientFill);
 
 virtual ::oox::core::ContextHandlerRef
 onCreateContext(
@@ -53,6 +52,7 @@ public:
 const ::oox::AttributeList& rAttribs ) override;
 
 private:
+model::GradientFill* mpGradientFill;
 GradientFillProperties& mrGradientProps;
 };
 
diff --git a/oox/source/drawingml/drawingmltypes.cxx 
b/oox/source/drawingml/drawingmltypes.cxx
index fc2f28d902b7..d0bf1bf2c892 100644
--- a/oox/source/drawingml/drawingmltypes.cxx
+++ b/oox/source/drawingml/drawingmltypes.cxx
@@ -400,6 +400,14 @@ IntegerRectangle2D GetRelativeRect( const Reference< 
XFastAttributeList >& xAttr
 return r;
 }
 
+void fillRelativeRectangle(model::RelativeRectangle& rRelativeRectangle, const 
Reference& xAttribs)
+{
+rRelativeRectangle.mnLeft = 
GetST_Percentage(xAttribs->getOptionalValue(XML_l));
+rRelativeRectangle.mnTop = 
GetST_Percentage(xAttribs->getOptionalValue(XML_t));
+rRelativeRectangle.mnRight = 
GetST_Percentage(xAttribs->getOptionalValue(XML_r));
+rRelativeRectangle.mnBottom = 
GetST_Percentage(xAttribs->getOptionalValue(XML_b));
+}
+
 /** converts the attributes from a CT_Size2D into an awt Size with 1/100thmm */
 awt::Size GetSize2D( const Reference< XFastAttributeList >& xAttribs )
 {
diff --git 

[Libreoffice-bugs] [Bug 154328] The hyperlink disappears after Libre office is closed

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154328

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #2 from m.a.riosv  ---
No issue for me, with native file format and xlsx:
Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: b5c3a7502f7ff6ccf0f829c1f3a2ba50b8584c41
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: en-US Calc: CL threaded Jumbo

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154327] Wrong HEIGHT formatting when Inserting ROW

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154327

m.a.riosv  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 CC||miguelangelrv@libreoffice.o
   ||rg
 Status|UNCONFIRMED |RESOLVED

--- Comment #2 from m.a.riosv  ---


*** This bug has been marked as a duplicate of bug 108016 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 108016] Calc: Insert Row Above should use format of selected row instead of previous row

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108016

m.a.riosv  changed:

   What|Removed |Added

 CC||jkl...@dokom.net

--- Comment #6 from m.a.riosv  ---
*** Bug 154327 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 120949] [META] Elementary icons

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120949
Bug 120949 depends on bug 154318, which changed state.

Bug 154318 Summary: Wrong Conditional Formatting 5 Quarters Icon Sets Are Wrong 
in elementary (SVG) Theme
https://bugs.documentfoundation.org/show_bug.cgi?id=154318

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - icon-themes/elementary icon-themes/elementary_svg

2023-03-22 Thread Rizal Muttaqin (via logerrit)
 icon-themes/elementary/sc/res/icon-set-pies-empty.png  |binary
 icon-themes/elementary/sc/res/icon-set-pies-half.png   |binary
 icon-themes/elementary/sc/res/icon-set-pies-one-quarter.png|binary
 icon-themes/elementary/sc/res/icon-set-pies-three-quarters.png |binary
 icon-themes/elementary_svg/sc/res/icon-set-pies-empty.svg  |2 +-
 icon-themes/elementary_svg/sc/res/icon-set-pies-half.svg   |2 +-
 icon-themes/elementary_svg/sc/res/icon-set-pies-one-quarter.svg|2 +-
 icon-themes/elementary_svg/sc/res/icon-set-pies-three-quarters.svg |2 +-
 8 files changed, 4 insertions(+), 4 deletions(-)

New commits:
commit d6f6edc565093954acbbdd05b4df8054ec4c97bc
Author: Rizal Muttaqin 
AuthorDate: Wed Mar 22 11:23:25 2023 +0700
Commit: Rizal Muttaqin 
CommitDate: Thu Mar 23 02:10:01 2023 +

tdf#154318 elementary: Fix 5 Quarters Conditional Formatting Icon Sets

Change-Id: I60d57891d460f795efd7e0151dc434f427251fee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149288
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin 
(cherry picked from commit d79350a7653a96126dca901d2054574c23bb390e)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149301

diff --git a/icon-themes/elementary/sc/res/icon-set-pies-empty.png 
b/icon-themes/elementary/sc/res/icon-set-pies-empty.png
index d33b51d76635..85165b5bc22a 100644
Binary files a/icon-themes/elementary/sc/res/icon-set-pies-empty.png and 
b/icon-themes/elementary/sc/res/icon-set-pies-empty.png differ
diff --git a/icon-themes/elementary/sc/res/icon-set-pies-half.png 
b/icon-themes/elementary/sc/res/icon-set-pies-half.png
index 17d611797797..5714177be5ba 100644
Binary files a/icon-themes/elementary/sc/res/icon-set-pies-half.png and 
b/icon-themes/elementary/sc/res/icon-set-pies-half.png differ
diff --git a/icon-themes/elementary/sc/res/icon-set-pies-one-quarter.png 
b/icon-themes/elementary/sc/res/icon-set-pies-one-quarter.png
index 46a73dfc348f..ae911becfc9c 100644
Binary files a/icon-themes/elementary/sc/res/icon-set-pies-one-quarter.png and 
b/icon-themes/elementary/sc/res/icon-set-pies-one-quarter.png differ
diff --git a/icon-themes/elementary/sc/res/icon-set-pies-three-quarters.png 
b/icon-themes/elementary/sc/res/icon-set-pies-three-quarters.png
index 37dcc031bbbc..e5c32d1e6c3e 100644
Binary files a/icon-themes/elementary/sc/res/icon-set-pies-three-quarters.png 
and b/icon-themes/elementary/sc/res/icon-set-pies-three-quarters.png differ
diff --git a/icon-themes/elementary_svg/sc/res/icon-set-pies-empty.svg 
b/icon-themes/elementary_svg/sc/res/icon-set-pies-empty.svg
index 90477a457462..acb85a17a7f2 100644
--- a/icon-themes/elementary_svg/sc/res/icon-set-pies-empty.svg
+++ b/icon-themes/elementary_svg/sc/res/icon-set-pies-empty.svg
@@ -1 +1 @@
-http://www.w3.org/2000/svg; 
xmlns:xlink="http://www.w3.org/1999/xlink;>
\ No newline at end of file
+http://www.w3.org/2000/svg; 
xmlns:xlink="http://www.w3.org/1999/xlink;>
\ No newline at end of file
diff --git a/icon-themes/elementary_svg/sc/res/icon-set-pies-half.svg 
b/icon-themes/elementary_svg/sc/res/icon-set-pies-half.svg
index 89454b4196a8..fb11fbaa16ce 100644
--- a/icon-themes/elementary_svg/sc/res/icon-set-pies-half.svg
+++ b/icon-themes/elementary_svg/sc/res/icon-set-pies-half.svg
@@ -1 +1 @@
-http://www.w3.org/2000/svg; 
xmlns:xlink="http://www.w3.org/1999/xlink;>
\ No newline at end of file
+http://www.w3.org/2000/svg; 
xmlns:xlink="http://www.w3.org/1999/xlink;>
\ No newline at end of file
diff --git a/icon-themes/elementary_svg/sc/res/icon-set-pies-one-quarter.svg 
b/icon-themes/elementary_svg/sc/res/icon-set-pies-one-quarter.svg
index cbeec87b6ed1..100ec6f3a316 100644
--- a/icon-themes/elementary_svg/sc/res/icon-set-pies-one-quarter.svg
+++ b/icon-themes/elementary_svg/sc/res/icon-set-pies-one-quarter.svg
@@ -1 +1 @@
-http://www.w3.org/2000/svg; 
xmlns:xlink="http://www.w3.org/1999/xlink;>
\ No newline at end of file
+http://www.w3.org/2000/svg; 
xmlns:xlink="http://www.w3.org/1999/xlink;>
\ No newline at end of file
diff --git a/icon-themes/elementary_svg/sc/res/icon-set-pies-three-quarters.svg 
b/icon-themes/elementary_svg/sc/res/icon-set-pies-three-quarters.svg
index 2f3edb9f501e..be3b5448379b 100644
--- a/icon-themes/elementary_svg/sc/res/icon-set-pies-three-quarters.svg
+++ b/icon-themes/elementary_svg/sc/res/icon-set-pies-three-quarters.svg
@@ -1 +1 @@
-http://www.w3.org/2000/svg; 
xmlns:xlink="http://www.w3.org/1999/xlink;>
\ No newline at end of file
+http://www.w3.org/2000/svg; 
xmlns:xlink="http://www.w3.org/1999/xlink;>
\ No newline at end of file


[Libreoffice-bugs] [Bug 154282] editeng/source/items/frmitems.cxx:772: virtual bool SvxTextLeftMarginItem::QueryValue(uno::Any &, sal_uInt8) const: Assertion `false' failed.

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154282

--- Comment #2 from Rafael Lima  ---
Apparently this is related to .uno:LeftParaMargin command, that only exists in
the Tabbed Compact and Tabbed user interfaces.

This is actually a control defined in:
/core/include/svx/ParaSpacingControl.hxx
/core/svx/source/sidebar/paragraph/ParaSpacingControl.cxx

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147892] Corrupt DOCX document after saving (track changes involved)

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147892

--- Comment #20 from Aron Budea  ---
László, could the fix be backported to 7.4 as well?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154070] SAXException after editing, saving and reopening a DOCX with tracked changes

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154070

Aron Budea  changed:

   What|Removed |Added

 CC||aron.bu...@gmail.com

--- Comment #5 from Aron Budea  ---
This seems similar to bug 147892, which is expected to be fixed in 7.5.2,
Stéphane, have you been able to reproduce in a recent build from trunk?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154282] editeng/source/items/frmitems.cxx:772: virtual bool SvxTextLeftMarginItem::QueryValue(uno::Any &, sal_uInt8) const: Assertion `false' failed.

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154282

Rafael Lima  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
 CC||rafael.palma.l...@gmail.com

--- Comment #1 from Rafael Lima  ---
I can confirm this bug. Simply switching to Tabbed Compact crashes LO.

After that, LO Writer won't even start. To get it back working, I need to reset
the user profile.

Other apps will open fine.

System info

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: e845332e73f454cd863e0324241aa7f7d52c5164
CPU threads: 16; OS: Linux 5.19; UI render: default; VCL: kf5 (cairo+xcb)
Locale: pt-BR (pt_BR.UTF-8); UI: en-US
Calc: CL threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 58079] FILEOPEN: Table shrinked in Word 2003 XML document

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=58079

Regina Henschel  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||4177

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 76134] FORMATTING: Column widths are not interpreted properly from Microsoft Word 2003 XML format

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=76134

Regina Henschel  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||4177

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 113869] [META] MS Office XML formats (pre-OOXML) bugs and enhancements

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113869

Regina Henschel  changed:

   What|Removed |Added

 Depends on||154177


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=154177
[Bug 154177] libreoffice cannot parse word documents generated by FreeMarker
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 133089] macOS: Some character can't be rendered in the Styles: List Styles; bullet x, >, tickbox replaced with "square"

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133089

bunkem  changed:

   What|Removed |Added

Version|7.0.0.0.alpha1+ |6.3.0.4 release

--- Comment #6 from bunkem  ---
The bullet previews in the Styles List Style is missing in the
mac64-6.4.bundle.
Missing in version:
Version: 6.3.0.0.alpha1+
Build ID: c98b1f1cd43b3e109bcaf6324ef2d1f449b34099

to version:
Version: 6.4.0.0.beta1+
Build ID: d54bae3471e9b9529f1ac03c811c3370d9f5ed89

So updated the version earliest affected to 6.3.0.4 release.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 133089] macOS: Some character can't be rendered in the Styles: List Styles; bullet x, >, tickbox replaced with "square"

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133089

bunkem  changed:

   What|Removed |Added

Summary|macOS: Some character can't |macOS: Some character can't
   |be rendered; square |be rendered in the Styles:
   ||List Styles; bullet x, >,
   ||tickbox replaced with
   ||"square"

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152237] impress crashes on duplicate slide action

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152237

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   Keywords||haveBacktrace

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153033] Writer crashes after configuring LanguageTool in Writing Aids

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153033

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #5 from Stéphane Guillou (stragu) 
 ---
I could not reproduce on Linux:

Version: 7.4.6.2 / LibreOffice Community
Build ID: 5b1f5509c2decdade7fda905e3e1429a67acd63d
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Can you please update to 7.4.6 and let us know if you can still reproduce the
crash?

Thank you!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 122066] Drag-and-drop multiple file links

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122066

--- Comment #8 from wpeat...@gmail.com ---
Verified bug still present in LibO 7.2.7.2

In Writer, dragging multiple files with Ctl+Shift+Drag will be linked as
expected.

In Calc, Draw, Impress, dragging multiple files with Ctl+Shift+Drag will only
link one of the dragged files, the rest are embedded in the document.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152237] impress crashes on duplicate slide action

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152237

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||stephane.guillou@libreoffic
   ||e.org
 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #5 from Stéphane Guillou (stragu) 
 ---
I could not reproduce on Linux either:

Version: 7.4.6.2 / LibreOffice Community
Build ID: 5b1f5509c2decdade7fda905e3e1429a67acd63d
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

almos, can you please update to 7.4.6 and let us know if you can still
reproduce the crash?

Thank you!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152173] [MacOS 13] Tooltips bring out-of-focus LO windows to second-to-last position

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152173

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||rghilto...@gmail.com

--- Comment #24 from Stéphane Guillou (stragu) 
 ---
*** Bug 153776 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153776] Moving mouse slowly over 2 or more open workbooks, the one behind becomes inactive and comes forward.

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153776

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE
 Whiteboard| QA:needsComment|

--- Comment #1 from Stéphane Guillou (stragu) 
 ---
Thank you for the report, Richard. This is already tracked in bug 152173.

*** This bug has been marked as a duplicate of bug 152173 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153834] Ajout d'une fonction récepteur "=" dans un dessin "Carré" ou "Rectangle" ou "Zone de texte" dans LibreOffice Calc

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153834

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||stephane.guillou@libreoffic
   ||e.org
 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |INVALID
 Whiteboard| QA:needsComment|

--- Comment #1 from Stéphane Guillou (stragu) 
 ---
Bonjour Palongo

Merci de rouvrir un ticket en anglais, puisque la langue par défaut est ici
l'anglais :
https://wiki.documentfoundation.org/QA/Bugzilla/Policies_and_Procedures#Policies

Vous pouvez utiliser une traduction automatique si c'est un problème, ou
demander de l'aide à la communauté francophone :
https://ask.libreoffice.org/c/french/

Merci !

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154070] SAXException after editing, saving and reopening a DOCX with tracked changes

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154070

--- Comment #4 from Stéphane Guillou (stragu) 
 ---
Created attachment 186146
  --> https://bugs.documentfoundation.org/attachment.cgi?id=186146=edit
test DOCX after editing, displaying the error

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154070] SAXException after editing, saving and reopening a DOCX with tracked changes

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154070

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

Summary|Writer_Record_track_changed |SAXException after editing,
   ||saving and reopening a DOCX
   ||with tracked changes
 Blocks||115709
 Status|UNCONFIRMED |NEW
 CC||stephane.guillou@libreoffic
   ||e.org
 Ever confirmed|0   |1

--- Comment #3 from Stéphane Guillou (stragu) 
 ---
I also get the error message after making a few changes, saving and reopening
the file.

The message reads:

SAXException: [word/document.xml line 2]: Opening and ending tag mismatch: rPr
line 2 and ins at
/home/buildslave/source/libo-core/sax/source/fastparser/-fastparser.cxx615
Proceeding with import may cause data loss or corruption, and application may
become unstable or crash.

Tested with:

Version: 7.4.6.2 / LibreOffice Community
Build ID: 5b1f5509c2decdade7fda905e3e1429a67acd63d
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Version: 7.5.1.2 (X86_64) / LibreOffice Community
Build ID: fcbaee479e84c6cd81291587d2ee68cba099e129
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=115709
[Bug 115709] [META] DOCX (OOXML) Tracking changes-related issues
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 115709] [META] DOCX (OOXML) Tracking changes-related issues

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=115709

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||154070


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=154070
[Bug 154070] SAXException after editing, saving and reopening a DOCX with
tracked changes
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154058] błąd #ARG przy wywołaniu funkcji

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154058

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||stephane.guillou@libreoffic
   ||e.org
 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |INVALID

--- Comment #1 from Stéphane Guillou (stragu) 
 ---
Sorry Jaroslaw, could you please report again in English (even an automatic
translation), as this is the language we try to stick to here. Please see
https://wiki.documentfoundation.org/QA/Bugzilla/Policies_and_Procedures#Policies

If you need help with it, the Polish-language mailing lists can put you in
contact with someone:
https://wiki.documentfoundation.org/Language/LocalMailingLists#Polish

Thank you!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 112581] [META] Linked (non-embedded) external files bugs and enhancements

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=112581

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||140829


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=140829
[Bug 140829] Breaking links does not reliably work.
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 140829] Breaking links does not reliably work.

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=140829

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 OS|Windows (All)   |All
 Blocks||112581
 CC||stephane.guillou@libreoffic
   ||e.org


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=112581
[Bug 112581] [META] Linked (non-embedded) external files bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154335] Deprecate layer_new.xhp in favour of insert_layer.xhp

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154335

Olivier Hallot  changed:

   What|Removed |Added

 Blocks||80430
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=80430
[Bug 80430] [META] Documentation gap for new features
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 80430] [META] Documentation gap for new features

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=80430

Olivier Hallot  changed:

   What|Removed |Added

 Depends on||154335


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=154335
[Bug 154335] Deprecate layer_new.xhp in favour of insert_layer.xhp
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154064] Break Links doesn't

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154064

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|UNCONFIRMED |RESOLVED

--- Comment #1 from Stéphane Guillou (stragu) 
 ---
Thank you DM. I believe this is the same issue as described in bug 140829.

*** This bug has been marked as a duplicate of bug 140829 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 140829] Breaking links does not reliably work.

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=140829

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||miscellaneous@paintdrawer.c
   ||o.uk

--- Comment #12 from Stéphane Guillou (stragu) 
 ---
*** Bug 154064 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

Jani Saranpää license statement

2023-03-22 Thread Jani Saranpää
Hi,

All of my past & future contributions to LibreOffice may be licensed under
the MPLv2/LGPLv3+ dual license.

Br,
Jani Saranpää


Bringing theme colors to ODF

2023-03-22 Thread Regina Henschel

Hi Tomaž, hi all,

I have started with creating a proposal to extend ODF with theme colors. 
The first draft is attached.


Tomaž, could you please look whether it fits to what you have intended.

Kind regards,
Regina


ODF proposal theme color v1.odt
Description: application/vnd.oasis.opendocument.text


[Libreoffice-bugs] [Bug 154322] XML Form Document: Choosing Instance after first clicking on Bindings leads to Crash of LO

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154322

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   Keywords||haveBacktrace

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154322] XML Form Document: Choosing Instance after first clicking on Bindings leads to Crash of LO

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154322

--- Comment #4 from Stéphane Guillou (stragu) 
 ---
Created attachment 186145
  --> https://bugs.documentfoundation.org/attachment.cgi?id=186145=edit
gdb backtrace with LO 7.6

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: cppuhelper/source

2023-03-22 Thread Stephan Bergmann (via logerrit)
 cppuhelper/source/paths.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 27f9a9cfa76fa584477e89f13b33720b5edbd570
Author: Stephan Bergmann 
AuthorDate: Wed Mar 22 21:43:09 2023 +0100
Commit: Stephan Bergmann 
CommitDate: Wed Mar 22 21:51:01 2023 +

OUString::match -> OUString::startsWith

(which reads better in combination with the following
OUString::endsWithIgnoreAsciiCase)

Change-Id: Ia80e3d205e5e3b48f9df43757fb267258ba3f8ea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149353
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/cppuhelper/source/paths.cxx b/cppuhelper/source/paths.cxx
index dd8fe56df2bf..28a1d34658b3 100644
--- a/cppuhelper/source/paths.cxx
+++ b/cppuhelper/source/paths.cxx
@@ -101,7 +101,7 @@ bool cppu::nextDirectoryItem(osl::Directory & directory, 
OUString * url) {
 if (stat.getFileType() != osl::FileStatus::Directory) { //TODO: 
symlinks
 // Ignore backup and spurious junk files:
 OUString name(stat.getFileName());
-if (name.match(".") || !name.endsWithIgnoreAsciiCase(u".rdb")) {
+if (name.startsWith(".") || 
!name.endsWithIgnoreAsciiCase(u".rdb")) {
 SAL_WARN("cppuhelper", "ignoring <" << stat.getFileURL() << 
">");
 } else {
 *url = stat.getFileURL();


[Libreoffice-bugs] [Bug 65138] [META] Sidebar feature related issues

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=65138

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on|154322  |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=154322
[Bug 154322] XML Form Document: Choosing Instance after first clicking on
Bindings leads to Crash of LO
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 107742] [META] Form control bugs and enhancements

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107742

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||154322


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=154322
[Bug 154322] XML Form Document: Choosing Instance after first clicking on
Bindings leads to Crash of LO
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154322] XML Form Document: Choosing Instance after first clicking on Bindings leads to Crash of LO

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154322

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bibisected, bisected
 CC||caol...@redhat.com
  Regression By||Caolán McNamara
 Blocks|65138   |107742
Version|7.1.0.3 release |7.1.0.0.alpha1+

--- Comment #3 from Stéphane Guillou (stragu) 
 ---
Bibisected with linux-64-7.1 repo to first bad commit
8061e52b512c0e8f6ae6302b0ec39fc3386bd4a2 which points to core commit:

commit  3c5e074a8fe5e0a18d326d37bc54a5ec0f077e4e
author  Caolán McNamara Fri Jun 19 12:37:05 2020 +0100
committer   Caolán McNamara Tue Jun 23 10:21:08
2020 +0200
weld DataNavigator
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96750

Caolán, can you please have a look?


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=65138
[Bug 65138] [META] Sidebar feature related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=107742
[Bug 107742] [META] Form control bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153860] FILEOPEN DOCX: Frame moves to the left (instead of spilling off the end of the page)

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153860

--- Comment #4 from Vince  ---
Confirmed adjusting the width to fit within the page allows it to show
correctly.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 135769] Accessibility Unnamed Button (for screenreaders)in hyphenation

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135769

Michael Weghorn  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |m.wegh...@posteo.de
   |desktop.org |

--- Comment #7 from Michael Weghorn  ---
Created attachment 186144
  --> https://bugs.documentfoundation.org/attachment.cgi?id=186144=edit
Sample doc used

(In reply to Heiko Tietze from comment #6)
> Help says: 
> "Left / Right Arrow
> Set the position of the hyphen. This option is only available if more than
> one hyphenation suggestion is displayed."
> 
> We could use this Left/Right for both the accessibility names and tooltips,
> which are missing too.

Thanks. https://gerrit.libreoffice.org/c/core/+/149355 implements setting
"Left" and "Right" for a11y name and tooltip.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 135769] Accessibility Unnamed Button (for screenreaders)in hyphenation

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135769

Michael Weghorn  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |m.wegh...@posteo.de
   |desktop.org |

--- Comment #7 from Michael Weghorn  ---
Created attachment 186144
  --> https://bugs.documentfoundation.org/attachment.cgi?id=186144=edit
Sample doc used

(In reply to Heiko Tietze from comment #6)
> Help says: 
> "Left / Right Arrow
> Set the position of the hyphen. This option is only available if more than
> one hyphenation suggestion is displayed."
> 
> We could use this Left/Right for both the accessibility names and tooltips,
> which are missing too.

Thanks. https://gerrit.libreoffice.org/c/core/+/149355 implements setting
"Left" and "Right" for a11y name and tooltip.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 153380] Pasting attribute table copied from QGIS makes LibreOffice freeze because of large values in WKT column

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153380

--- Comment #17 from m.a.riosv  ---
With attached file, no slowness for me, only a few seconds (about 5-6), and
shows the message about cell lengths:

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: b5c3a7502f7ff6ccf0f829c1f3a2ba50b8584c41
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: en-US Calc: CL threaded Jumbo
Version: 7.5.2.1 (X86_64) / LibreOffice Community
Build ID: e8bf3b441b8370f8440b0339fd9490765a8d57ca
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: en-US Calc: CL threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154335] New: Deprecate layer_new.xhp in favour of insert_layer.xhp

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154335

Bug ID: 154335
   Summary: Deprecate layer_new.xhp in favour of insert_layer.xhp
   Product: LibreOffice
   Version: 6.1 all versions
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Documentation
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: stephane.guil...@libreoffice.org
CC: olivier.hal...@libreoffice.org

In the Help pages, we have:
- layer_new.xhp:
https://help.libreoffice.org/latest/en-US/text/sdraw/guide/layer_new.html
- insert_layer.xhp:
https://help.libreoffice.org/latest/en-US/text/sdraw/01/insert_layer.html

insert_layer is more detailed than layer_new, covers the same topic, and is the
page that is linked from the Modify Layer dialog in LO.

layer_new should be removed, and all references to it replaced by insert_layer:
https://opengrok.libreoffice.org/search?project=help=layer_new===1=full=full

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154021] Customize dialog is too big to display on 1280x800 laptop screen GNOME (gtk3)

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154021

vi...@vincentbentley.co.uk changed:

   What|Removed |Added

 Resolution|--- |NOTOURBUG
 Status|NEW |RESOLVED

--- Comment #15 from vi...@vincentbentley.co.uk ---
Using the gnome-tweaks tool to drop the font sizes from 11pt to 10pt is
sufficient to reveal the buttons in the Customize dialog.

I guess this is more of a problem with the default Ubuntu configuration.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 154021] Customize dialog is too big to display on 1280x800 laptop screen GNOME (gtk3)

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154021

vi...@vincentbentley.co.uk changed:

   What|Removed |Added

 Resolution|--- |NOTOURBUG
 Status|NEW |RESOLVED

--- Comment #15 from vi...@vincentbentley.co.uk ---
Using the gnome-tweaks tool to drop the font sizes from 11pt to 10pt is
sufficient to reveal the buttons in the Customize dialog.

I guess this is more of a problem with the default Ubuntu configuration.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-5-2' - avmedia/source

2023-03-22 Thread Michael Stahl (via logerrit)
 avmedia/source/gstreamer/gstplayer.cxx |   13 ++---
 1 file changed, 6 insertions(+), 7 deletions(-)

New commits:
commit f3bee7eff23f01942ceb723b6ebc8eddc6fa0cf4
Author: Michael Stahl 
AuthorDate: Tue Mar 21 19:10:14 2023 +0100
Commit: Thorsten Behrens 
CommitDate: Wed Mar 22 20:44:32 2023 +

Revert "avmedia : use std::mutex instead of osl::Mutex"

This reverts commit 477fa6c3cb92f578032dee60482718efdb8f44f2.

MissingPluginInstaller requires a recursive lock:

Thread 2 (Thread 0x7f8e73d69700 (LWP 29931)):
0  __lll_lock_wait () at /lib64/libpthread.so.0
...
5  std::unique_lock::lock() (this=0x7f8e73d65a88) at 
/opt/rh/devtoolset-7/root/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/bits/std_mutex.h:267
6  std::unique_lock::unique_lock(std::mutex&) 
(this=0x7f8e73d65a88, __m=...) at 
/opt/rh/devtoolset-7/root/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/bits/std_mutex.h:197
7  avmedia::gstreamer::(anonymous 
namespace)::MissingPluginInstaller::detach(avmedia::gstreamer::Player const*) 
(this=0x7f8e644c6be0 ::get()::instance>, source=0x75d2fa0) at 
avmedia/source/gstreamer/gstplayer.cxx:187
8  avmedia::gstreamer::Player::disposing() (this=0x75d2fa0) at 
avmedia/source/gstreamer/gstplayer.cxx:334
9  cppu::WeakComponentImplHelperBase::dispose() (this=0x75d2fa0) at 
cppuhelper/source/implbase.cxx:104
10 cppu::PartialWeakComponentImplHelper::dispose() (this=0x75d2fa0) at 
include/cppuhelper/compbase.hxx:90
11 cppu::WeakComponentImplHelperBase::release() (this=0x75d2fa0) at 
cppuhelper/source/implbase.cxx:79
13 rtl::Reference::~Reference() 
(this=0x7f8e7c028f20) at include/rtl/ref.hxx:129
...
21 std::__debug::set, 
std::less >, 
std::allocator > >::clear() 
(this=0x7f8e644c6cd8 ::get()::instance+248>) at 
/opt/rh/devtoolset-7/root/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/debug/set.h:426
22 avmedia::gstreamer::(anonymous 
namespace)::MissingPluginInstaller::report(rtl::Reference
 const&, _GstMessage*) (this=0x7f8e644c6be0 
::get()::instance>, source=..., 
message=0x7cdb400) at avmedia/source/gstreamer/gstplayer.cxx:156
23 avmedia::gstreamer::Player::processSyncMessage(_GstMessage*) 
(this=0x75abfe0, message=0x7cdb400) at 
avmedia/source/gstreamer/gstplayer.cxx:536
24 avmedia::gstreamer::pipeline_bus_sync_handler(_GstBus*, _GstMessage*, 
void*) (message=0x7cdb400, data=0x75abfe0) at 
avmedia/source/gstreamer/gstplayer.cxx:382
25 gst_bus_post () at /lib64/libgstreamer-1.0.so.0

Change-Id: Ia8e7fef4d4cee2dde7189702af6dddf883b6cceb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149233
Tested-by: Jenkins
Reviewed-by: Michael Stahl 
(cherry picked from commit 621143588b3cb438baf27fb6893ab02e7b06f9dd)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149300
Reviewed-by: Xisco Fauli 
Reviewed-by: Caolán McNamara 
Tested-by: Thorsten Behrens 
Reviewed-by: Thorsten Behrens 

diff --git a/avmedia/source/gstreamer/gstplayer.cxx 
b/avmedia/source/gstreamer/gstplayer.cxx
index 7d7602b5b3eb..b841c576be17 100644
--- a/avmedia/source/gstreamer/gstplayer.cxx
+++ b/avmedia/source/gstreamer/gstplayer.cxx
@@ -25,7 +25,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
@@ -99,7 +98,7 @@ private:
 
 DECL_STATIC_LINK(MissingPluginInstaller, launchUi, void*, void);
 
-std::mutex mutex_;
+osl::Mutex mutex_;
 std::set reported_;
 std::map>> queued_;
 rtl::Reference currentThread_;
@@ -111,7 +110,7 @@ private:
 
 
 MissingPluginInstaller::~MissingPluginInstaller() {
-std::unique_lock g(mutex_);
+osl::MutexGuard g(mutex_);
 SAL_WARN_IF(currentThread_.is(), "avmedia.gstreamer", "unjoined thread");
 inCleanUp_ = true;
 }
@@ -139,7 +138,7 @@ void MissingPluginInstaller::report(
 rtl::Reference join;
 rtl::Reference launch;
 {
-std::unique_lock g(mutex_);
+osl::MutexGuard g(mutex_);
 if (reported_.find(detStr) != reported_.end()) {
 return;
 }
@@ -184,7 +183,7 @@ void eraseSource(std::set> & set, 
Player const * source)
 void MissingPluginInstaller::detach(Player const * source) {
 rtl::Reference join;
 {
-std::unique_lock g(mutex_);
+osl::MutexGuard g(mutex_);
 if (inCleanUp_) {
 // Guard against ~MissingPluginInstaller with erroneously un-joined
 // currentThread_ (thus non-empty currentSources_) calling
@@ -256,7 +255,7 @@ void MissingPluginInstallerThread::execute() {
 for (;;) {
 std::vector details;
 {
-std::unique_lock g(inst.mutex_);
+osl::MutexGuard g(inst.mutex_);
 assert(!inst.currentDetails_.empty());
 details.swap(inst.currentDetails_);
 }
@@ -269,7 +268,7 @@ void MissingPluginInstallerThread::execute() {
 args.push_back(nullptr);
 

[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - avmedia/source

2023-03-22 Thread Michael Stahl (via logerrit)
 avmedia/source/gstreamer/gstplayer.cxx |   13 ++---
 1 file changed, 6 insertions(+), 7 deletions(-)

New commits:
commit 76aaa231c44922f6aa4d4a0546e350259a98ef08
Author: Michael Stahl 
AuthorDate: Tue Mar 21 19:10:14 2023 +0100
Commit: Thorsten Behrens 
CommitDate: Wed Mar 22 20:43:45 2023 +

Revert "avmedia : use std::mutex instead of osl::Mutex"

This reverts commit 477fa6c3cb92f578032dee60482718efdb8f44f2.

MissingPluginInstaller requires a recursive lock:

Thread 2 (Thread 0x7f8e73d69700 (LWP 29931)):
0  __lll_lock_wait () at /lib64/libpthread.so.0
...
5  std::unique_lock::lock() (this=0x7f8e73d65a88) at 
/opt/rh/devtoolset-7/root/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/bits/std_mutex.h:267
6  std::unique_lock::unique_lock(std::mutex&) 
(this=0x7f8e73d65a88, __m=...) at 
/opt/rh/devtoolset-7/root/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/bits/std_mutex.h:197
7  avmedia::gstreamer::(anonymous 
namespace)::MissingPluginInstaller::detach(avmedia::gstreamer::Player const*) 
(this=0x7f8e644c6be0 ::get()::instance>, source=0x75d2fa0) at 
avmedia/source/gstreamer/gstplayer.cxx:187
8  avmedia::gstreamer::Player::disposing() (this=0x75d2fa0) at 
avmedia/source/gstreamer/gstplayer.cxx:334
9  cppu::WeakComponentImplHelperBase::dispose() (this=0x75d2fa0) at 
cppuhelper/source/implbase.cxx:104
10 cppu::PartialWeakComponentImplHelper::dispose() (this=0x75d2fa0) at 
include/cppuhelper/compbase.hxx:90
11 cppu::WeakComponentImplHelperBase::release() (this=0x75d2fa0) at 
cppuhelper/source/implbase.cxx:79
13 rtl::Reference::~Reference() 
(this=0x7f8e7c028f20) at include/rtl/ref.hxx:129
...
21 std::__debug::set, 
std::less >, 
std::allocator > >::clear() 
(this=0x7f8e644c6cd8 ::get()::instance+248>) at 
/opt/rh/devtoolset-7/root/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/debug/set.h:426
22 avmedia::gstreamer::(anonymous 
namespace)::MissingPluginInstaller::report(rtl::Reference
 const&, _GstMessage*) (this=0x7f8e644c6be0 
::get()::instance>, source=..., 
message=0x7cdb400) at avmedia/source/gstreamer/gstplayer.cxx:156
23 avmedia::gstreamer::Player::processSyncMessage(_GstMessage*) 
(this=0x75abfe0, message=0x7cdb400) at 
avmedia/source/gstreamer/gstplayer.cxx:536
24 avmedia::gstreamer::pipeline_bus_sync_handler(_GstBus*, _GstMessage*, 
void*) (message=0x7cdb400, data=0x75abfe0) at 
avmedia/source/gstreamer/gstplayer.cxx:382
25 gst_bus_post () at /lib64/libgstreamer-1.0.so.0

Change-Id: Ia8e7fef4d4cee2dde7189702af6dddf883b6cceb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149233
Tested-by: Jenkins
Reviewed-by: Michael Stahl 
(cherry picked from commit 621143588b3cb438baf27fb6893ab02e7b06f9dd)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149297
Reviewed-by: Thorsten Behrens 

diff --git a/avmedia/source/gstreamer/gstplayer.cxx 
b/avmedia/source/gstreamer/gstplayer.cxx
index 7d7602b5b3eb..b841c576be17 100644
--- a/avmedia/source/gstreamer/gstplayer.cxx
+++ b/avmedia/source/gstreamer/gstplayer.cxx
@@ -25,7 +25,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
@@ -99,7 +98,7 @@ private:
 
 DECL_STATIC_LINK(MissingPluginInstaller, launchUi, void*, void);
 
-std::mutex mutex_;
+osl::Mutex mutex_;
 std::set reported_;
 std::map>> queued_;
 rtl::Reference currentThread_;
@@ -111,7 +110,7 @@ private:
 
 
 MissingPluginInstaller::~MissingPluginInstaller() {
-std::unique_lock g(mutex_);
+osl::MutexGuard g(mutex_);
 SAL_WARN_IF(currentThread_.is(), "avmedia.gstreamer", "unjoined thread");
 inCleanUp_ = true;
 }
@@ -139,7 +138,7 @@ void MissingPluginInstaller::report(
 rtl::Reference join;
 rtl::Reference launch;
 {
-std::unique_lock g(mutex_);
+osl::MutexGuard g(mutex_);
 if (reported_.find(detStr) != reported_.end()) {
 return;
 }
@@ -184,7 +183,7 @@ void eraseSource(std::set> & set, 
Player const * source)
 void MissingPluginInstaller::detach(Player const * source) {
 rtl::Reference join;
 {
-std::unique_lock g(mutex_);
+osl::MutexGuard g(mutex_);
 if (inCleanUp_) {
 // Guard against ~MissingPluginInstaller with erroneously un-joined
 // currentThread_ (thus non-empty currentSources_) calling
@@ -256,7 +255,7 @@ void MissingPluginInstallerThread::execute() {
 for (;;) {
 std::vector details;
 {
-std::unique_lock g(inst.mutex_);
+osl::MutexGuard g(inst.mutex_);
 assert(!inst.currentDetails_.empty());
 details.swap(inst.currentDetails_);
 }
@@ -269,7 +268,7 @@ void MissingPluginInstallerThread::execute() {
 args.push_back(nullptr);
 gst_install_plugins_sync(args.data(), nullptr);
 {
-std::unique_lock g(inst.mutex_);
+

Re: 7.5.1.2 crashes

2023-03-22 Thread Caolán McNamara
On Tue, 2023-03-21 at 13:18 +0100, Xisco Fauli wrote:
> Hello,
> 
> Attached you can find the list of LibreOffice 7.5.1.2 crashes
> reported 
> to https://crashreport.libreoffice.org/stats/version/7.5.1.2

#1 is a opengl slide transition. "DuplicatePage, DuplicatePage, Paste,
Paste" suggests copying and pasting a slide with a slide transition in
it, though in the past I feel I saw similar with opengl slide
transitions marked as requiring a lower version of opengl then they
actually did require.



[Libreoffice-bugs] [Bug 153988] Autocorrect dialog should offer starting-ending quote pairs more conveniently

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153988

--- Comment #2 from Eyal Rozenberg  ---
(In reply to Heiko Tietze from comment #1)
> The default for German is double quotes being converted to „Lorem ipsum“. I
> don't have to do anything, the autocorrection works perfectly. Please
> elaborate with an example.

I meant, when you want to use something _other_ than the default. This bug is
about the UX for doing that.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 153988] Autocorrect dialog should offer starting-ending quote pairs more conveniently

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153988

--- Comment #2 from Eyal Rozenberg  ---
(In reply to Heiko Tietze from comment #1)
> The default for German is double quotes being converted to „Lorem ipsum“. I
> don't have to do anything, the autocorrection works perfectly. Please
> elaborate with an example.

I meant, when you want to use something _other_ than the default. This bug is
about the UX for doing that.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-commits] core.git: Branch 'feature/cib_contract891c' - external/libgpg-error

2023-03-22 Thread Michael Stahl (via logerrit)
 external/libgpg-error/ExternalPackage_libgpg-error.mk|   10 ++
 external/libgpg-error/UnpackedTarball_libgpg-error.mk|1 
 external/libgpg-error/libgpgerror-bundled-soname.patch.1 |   22 +++
 3 files changed, 32 insertions(+), 1 deletion(-)

New commits:
commit 7155fba93bbf4304d4920787d43227455e7801f8
Author: Michael Stahl 
AuthorDate: Mon Jan 28 14:31:12 2019 +0100
Commit: Gabor Kelemen 
CommitDate: Wed Mar 22 17:00:47 2023 +0100

libgpg-error: use custom soname and symbol version

The hope is that this should allow both system's libgpg-error.so.0 and
LO's bundled libgpg-error-lo.so.0 to be loaded by soffice.bin without
unintended hilarity.

Change-Id: I94498097a847b9756de86051798cb4ce022f6c83
Reviewed-on: https://gerrit.libreoffice.org/67012
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens 

diff --git a/external/libgpg-error/ExternalPackage_libgpg-error.mk 
b/external/libgpg-error/ExternalPackage_libgpg-error.mk
index ba6e8c67f754..3afd218eef9e 100644
--- a/external/libgpg-error/ExternalPackage_libgpg-error.mk
+++ b/external/libgpg-error/ExternalPackage_libgpg-error.mk
@@ -13,7 +13,15 @@ $(eval $(call 
gb_ExternalPackage_use_external_project,libgpg-error,libgpg-error)
 
 ifneq ($(DISABLE_DYNLOADING),TRUE)
 
-$(eval $(call 
gb_ExternalPackage_add_file,libgpg-error,$(LIBO_LIB_FOLDER)/libgpg-error.so.0,src/.libs/libgpg-error.so.0.21.0))
+ifeq ($(OS),LINUX)
+
+$(eval $(call 
gb_ExternalPackage_add_file,libgpg-error,$(LIBO_LIB_FOLDER)/libgpg-error-lo.so.0,src/.libs/libgpg-error-lo.so.0.22.0))
+
+else ifeq ($(OS),MACOSX)
+
+$(eval $(call 
gb_ExternalPackage_add_file,libgpg-error,$(LIBO_LIB_FOLDER)/libgpg-error.0.dylib,src/.libs/libgpg-error.0.dylib))
+
+endif
 
 endif # $(DISABLE_DYNLOADING)
 
diff --git a/external/libgpg-error/UnpackedTarball_libgpg-error.mk 
b/external/libgpg-error/UnpackedTarball_libgpg-error.mk
index 8343ad63bb6d..9594e9c635ef 100644
--- a/external/libgpg-error/UnpackedTarball_libgpg-error.mk
+++ b/external/libgpg-error/UnpackedTarball_libgpg-error.mk
@@ -17,6 +17,7 @@ $(eval $(call gb_UnpackedTarball_add_patches,libgpg-error, \
 external/libgpg-error/fix-autoconf-macros.patch \
 external/libgpg-error/disable-rpath-option.patch \
external/libgpg-error/libgpg-error_gawk5.patch \
+   $(if $(filter 
LINUX,$(OS)),external/libgpg-error/libgpgerror-bundled-soname.patch.1) \
 ))
 
 # vim: set noet sw=4 ts=4:
diff --git a/external/libgpg-error/libgpgerror-bundled-soname.patch.1 
b/external/libgpg-error/libgpgerror-bundled-soname.patch.1
new file mode 100644
index ..4f927def368a
--- /dev/null
+++ b/external/libgpg-error/libgpgerror-bundled-soname.patch.1
@@ -0,0 +1,22 @@
+--- libgpg-error/src/Makefile.in.orig  2019-01-28 14:11:10.518425440 +0100
 libgpg-error/src/Makefile.in   2019-01-28 14:11:16.901414229 +0100
+@@ -540,7 +540,7 @@
+ @HAVE_LD_VERSION_SCRIPT_TRUE@libgpg_error_vers_opt = 
-Wl,--version-script=$(srcdir)/gpg-error.vers
+ libgpg_error_la_LDFLAGS = \
+   $(no_undefined) $(export_symbols) $(libgpg_error_vers_opt) \
+-  $(extra_ltoptions) -version-info \
++  $(extra_ltoptions) -release lo -version-info \
+   @LIBGPG_ERROR_LT_CURRENT@:@LIBGPG_ERROR_LT_REVISION@:@LIBGPG_ERROR_LT_AGE@
+ 
+ libgpg_error_la_SOURCES = gettext.h $(arch_sources) \
+--- libgpg-error/src/gpg-error.vers.orig   2019-01-28 14:08:11.413740011 
+0100
 libgpg-error/src/gpg-error.vers2019-01-28 14:08:34.172700037 +0100
+@@ -20,7 +20,7 @@
+ #   visibility.h and gpg-error.def.in as well.
+ 
+ 
+-GPG_ERROR_1.0 {
++GPG_ERROR_LIBREOFFICE {
+   global:
+ gpg_strerror;
+ gpg_strerror_r;


[Libreoffice-bugs] [Bug 61768] macOS does not recognise LO dialog windows for standalone screenshots

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=61768

--- Comment #16 from João Gomes  ---
I have to add that besides this issue with screenshots, and with screenshots
looking corrupted if you move the modal window away from the main document
window, there's the added undesirable effect of not being able to functionally
move a modal window to a secondary display when using Mission Control and
separate spaces for each screen.

When in that configuration, moving any modal window to a display other than the
one containing the parent, document window results in the modal window becoming
invisible/inaccessible. By activating regular or App Exposé you can indeed see
the window exists, but the only way to leave this modal state and fix the issue
is by pressing the Escape or Enter key to close the window (and opening it
again if needed).

This situation is inevitable, as macOS obscures any parts of a window that lie
outside of its parent display/space and how LibreOffice is effectively treating
the parent window/modal window combo as a single window/Z-axis layer, and also
has the added detrimental effect, besides being bad UX, in potentially
resulting in lost input data (if the user presses Escape) or inputting
undesirable data (if the user blindly presses Enter without being able to
select tabs to check their inputs before committing to potential changes).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152173] [MacOS 13] Tooltips bring out-of-focus LO windows to second-to-last position

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152173

--- Comment #23 from João Gomes  ---
(In reply to João Gomes from comment #22)
> (In reply to eisa01 from comment #21)
> > (In reply to João Gomes from comment #20)
> > > (I am obviously filing all these as separate bug reports, worry not).
> > 
> > Already exist as bug 31915 bug 61768 and bug 130678
> 
> Oh, okay, thank you for pointing it out.
> 
> I'll be sure to check them out and see if there's anything of value I can
> add.

Indeed there is.

Neither those first two bug reports (or maybe the second one, I don't think I
fully understand the scope of the first one), nor the subsequent comments
address the ensuing issue with external displays.

That alone doesn't warrant an entry of its own, as the underlying behaviour
that causes it is the same, but is indeed yet another “buggy” and “undesirable”
expression/effect thereof.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152173] [MacOS 13] Tooltips bring out-of-focus LO windows to second-to-last position

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152173

--- Comment #22 from João Gomes  ---
(In reply to eisa01 from comment #21)
> (In reply to João Gomes from comment #20)
> > (I am obviously filing all these as separate bug reports, worry not).
> 
> Already exist as bug 31915 bug 61768 and bug 130678

Oh, okay, thank you for pointing it out.

I'll be sure to check them out and see if there's anything of value I can add.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152173] [MacOS 13] Tooltips bring out-of-focus LO windows to second-to-last position

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152173

--- Comment #21 from eisa01  ---
(In reply to João Gomes from comment #20)
> (I am obviously filing all these as separate bug reports, worry not).

Already exist as bug 31915 bug 61768 and bug 130678

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153664] FILESAVE DOCX Table of Figures entry saved with incorrect paragraph style

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153664

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.6.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153659] FILEOPEN DOCX Table of Figures entry has incorrect paragraph style

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153659

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.6.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: 2 commits - sw/qa sw/source writerfilter/source

2023-03-22 Thread Gabor Kelemen (via logerrit)
 sw/qa/extras/odfexport/odfexport2.cxx  |3 +++
 sw/qa/extras/ooxmlexport/data/Table-of-Figures.odt |binary
 sw/qa/extras/ooxmlexport/ooxmlexport18.cxx |   13 +
 sw/source/filter/ww8/wrtw8sty.cxx  |2 +-
 writerfilter/source/dmapper/StyleSheetTable.cxx|3 ++-
 5 files changed, 19 insertions(+), 2 deletions(-)

New commits:
commit 667f5f87dee072f6737ee6b6491ed53b7cf154a7
Author: Gabor Kelemen 
AuthorDate: Tue Mar 21 20:12:13 2023 +0100
Commit: Gabor Kelemen 
CommitDate: Wed Mar 22 20:05:09 2023 +

tdf#153664 Export correct Table of Figures paragraph style

Change-Id: I892a0185a94aadd902e55ee9b719f855edbdfc89
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149258
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen 

diff --git a/sw/qa/extras/ooxmlexport/data/Table-of-Figures.odt 
b/sw/qa/extras/ooxmlexport/data/Table-of-Figures.odt
new file mode 100644
index ..cd1502cf866f
Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/Table-of-Figures.odt 
differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport18.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport18.cxx
index b19c196016b2..20db0327ccef 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport18.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport18.cxx
@@ -632,6 +632,19 @@ CPPUNIT_TEST_FIXTURE(Test, testTdf148026)
 assertXPath(pXmlDoc, "//w:hyperlink", "tgtFrame", "_self");
 }
 
+CPPUNIT_TEST_FIXTURE(Test, testTdf153664)
+{
+loadAndReload("Table-of-Figures.odt");
+CPPUNIT_ASSERT_EQUAL(1, getPages());
+xmlDocUniquePtr pXmlStyles = parseExport("word/styles.xml");
+CPPUNIT_ASSERT(pXmlStyles);
+// Without the fix this was styleId='FigureIndex1' and name was "Figure 
Index 1"
+// This led to syle settings being reset when ToF was updated in Word
+// TOF's paragraph style should be exported as "Table of Figures" as 
that's the default Word style name
+assertXPath(pXmlStyles, "/w:styles/w:style[12]", "styleId", 
"TableofFigures");
+assertXPath(pXmlStyles, 
"/w:styles/w:style[@w:styleId='TableofFigures']/w:name", "val", "Table of 
Figures");
+}
+
 CPPUNIT_PLUGIN_IMPLEMENT();
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/filter/ww8/wrtw8sty.cxx 
b/sw/source/filter/ww8/wrtw8sty.cxx
index 1d556fc312b8..8e0bcdde91a1 100644
--- a/sw/source/filter/ww8/wrtw8sty.cxx
+++ b/sw/source/filter/ww8/wrtw8sty.cxx
@@ -268,7 +268,7 @@ sal_uInt16 MSWordStyles::GetWWId( const SwFormat& rFormat )
 case RES_POOLCOLL_FOOTER:   nRet = ww::stiFooter;
break;
 case RES_POOLCOLL_TOX_IDXH: nRet = ww::stiIndexHeading;  
break;
 case RES_POOLCOLL_LABEL:nRet = ww::stiCaption;   
break;
-case RES_POOLCOLL_LABEL_DRAWING:nRet = ww::stiToCaption; 
break;
+case RES_POOLCOLL_TOX_ILLUS1:   nRet = ww::stiToCaption; 
break;
 case RES_POOLCOLL_ENVELOPE_ADDRESS: nRet = ww::stiEnvAddr;   
break;
 case RES_POOLCOLL_SEND_ADDRESS: nRet = ww::stiEnvRet;
break;
 case RES_POOLCHR_FOOTNOTE_ANCHOR:   nRet = ww::stiFootnoteRef;   
break;
commit 9b89ce887836742bb84bf57afa3b536b6c3bb1c1
Author: Gabor Kelemen 
AuthorDate: Tue Mar 21 09:21:18 2023 +0100
Commit: Gabor Kelemen 
CommitDate: Wed Mar 22 20:04:57 2023 +

tdf#153659 Import Table of Figures paragraph style correctly

Change-Id: I5a995349c168bfbb5c8933dafa72e06eddb74ac6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149257
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen 

diff --git a/sw/qa/extras/odfexport/odfexport2.cxx 
b/sw/qa/extras/odfexport/odfexport2.cxx
index e4da067f5396..269525a8756b 100644
--- a/sw/qa/extras/odfexport/odfexport2.cxx
+++ b/sw/qa/extras/odfexport/odfexport2.cxx
@@ -606,6 +606,9 @@ DECLARE_ODFEXPORT_TEST(testTdf153090, 
"Custom-Style-TOC.docx")
 uno::Reference 
xIndexes(xIndexSupplier->getDocumentIndexes());
 uno::Reference xTOC(xIndexes->getByIndex(0), 
uno::UNO_QUERY);
 CPPUNIT_ASSERT_EQUAL(OUString("_CustomImageCaption"), 
getProperty(xTOC, "CreateFromParagraphStyle"));
+// tdf#153659 this was imported as "table of figures" instead of "Figure 
Index 1"
+// thus custom settings were not retained after ToF update
+CPPUNIT_ASSERT_EQUAL(OUString("Figure Index 1"), 
getProperty(getParagraph(1), "ParaStyleName"));
 
 xTOC->update();
 OUString const tocContent(xTOC->getAnchor()->getString());
diff --git a/writerfilter/source/dmapper/StyleSheetTable.cxx 
b/writerfilter/source/dmapper/StyleSheetTable.cxx
index 1e10d4966dbf..a78ac4fda2db 100644
--- a/writerfilter/source/dmapper/StyleSheetTable.cxx
+++ b/writerfilter/source/dmapper/StyleSheetTable.cxx
@@ -1594,7 +1594,8 @@ OUString StyleSheetTable::ConvertStyleName( const 
OUString& rWWName, bool bExten
 { "footer", "Footer" }, // RES_POOLCOLL_FOOTER
 { "Index Heading", 

[Libreoffice-commits] core.git: chart2/inc chart2/source

2023-03-22 Thread Noel Grandin (via logerrit)
 chart2/inc/ChartModel.hxx  
|7 +
 chart2/source/controller/chartapiwrapper/TitleWrapper.cxx  
|6 -
 
chart2/source/controller/chartapiwrapper/WrappedAxisAndGridExistenceProperties.cxx
 |2 
 chart2/source/controller/dialogs/ObjectNameProvider.cxx
|6 -
 chart2/source/controller/dialogs/TitleDialogData.cxx   
|4 
 chart2/source/controller/itemsetwrapper/MultipleChartConverters.cxx
|4 
 chart2/source/controller/main/ChartController_Insert.cxx   
|2 
 chart2/source/controller/main/ChartController_Properties.cxx   
|2 
 chart2/source/controller/main/ChartController_TextEdit.cxx 
|4 
 chart2/source/controller/main/ChartController_Tools.cxx
|4 
 chart2/source/controller/main/ChartController_Window.cxx   
|2 
 chart2/source/controller/sidebar/ChartElementsPanel.cxx
|5 -
 chart2/source/inc/Axis.hxx 
|6 +
 chart2/source/inc/ObjectIdentifier.hxx 
|3 
 chart2/source/inc/Title.hxx
|5 -
 chart2/source/inc/TitleHelper.hxx  
|   17 +--
 chart2/source/model/main/Axis.cxx  
|   19 +++-
 chart2/source/model/main/ChartModel.cxx
|   21 +++-
 chart2/source/tools/ObjectIdentifier.cxx   
|   39 +---
 chart2/source/tools/TitleHelper.cxx
|   46 +-
 chart2/source/view/main/ChartView.cxx  
|5 -
 chart2/source/view/main/ExplicitValueProvider.cxx  
|8 -
 chart2/source/view/main/VTitle.cxx 
|   14 +++
 chart2/source/view/main/VTitle.hxx 
|3 
 24 files changed, 150 insertions(+), 84 deletions(-)

New commits:
commit 6f59baf135f42f9c281148184b1b1f16e3902442
Author: Noel Grandin 
AuthorDate: Wed Mar 22 12:22:09 2023 +0200
Commit: Noel Grandin 
CommitDate: Wed Mar 22 19:58:38 2023 +

use more concrete type in chart2

Change-Id: If67a4f0fe75554e14c3030c68374607b76d5b840
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149336
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/chart2/inc/ChartModel.hxx b/chart2/inc/ChartModel.hxx
index 8c876d8b95e6..c8b34562e0b4 100644
--- a/chart2/inc/ChartModel.hxx
+++ b/chart2/inc/ChartModel.hxx
@@ -76,6 +76,7 @@ class ChartTypeTemplate;
 class InternalDataProvider;
 class NameContainer;
 class PageBackground;
+class Title;
 
 namespace impl
 {
@@ -167,8 +168,7 @@ private:
 // Diagram Access
 rtl::Reference< ::chart::Diagram > m_xDiagram;
 
-css::uno::Reference< css::chart2::XTitle >
-  m_xTitle;
+rtl::Reference< ::chart::Title > m_xTitle;
 
 rtl::Reference< ::chart::PageBackground > m_xPageBackground;
 
@@ -475,6 +475,9 @@ public:
 
 const rtl::Reference< ::chart::ChartTypeManager > & getTypeManager() const 
{ return m_xChartTypeManager; }
 
+rtl::Reference< ::chart::Title > getTitleObject2() const;
+void setTitleObject( const rtl::Reference< ::chart::Title >& Title );
+
 private:
 void dumpAsXml(xmlTextWriterPtr pWriter) const;
 
diff --git a/chart2/source/controller/chartapiwrapper/TitleWrapper.cxx 
b/chart2/source/controller/chartapiwrapper/TitleWrapper.cxx
index 3a59015d9e67..594209d4fbf3 100644
--- a/chart2/source/controller/chartapiwrapper/TitleWrapper.cxx
+++ b/chart2/source/controller/chartapiwrapper/TitleWrapper.cxx
@@ -75,12 +75,12 @@ WrappedTitleStringProperty::WrappedTitleStringProperty( 
const Reference< uno::XC
 
 void WrappedTitleStringProperty::setPropertyValue( const Any& rOuterValue, 
const Reference< beans::XPropertySet >& xInnerPropertySet ) const
 {
-Reference< chart2::XTitle > xTitle(xInnerPropertySet,uno::UNO_QUERY);
-if(xTitle.is())
+Title* pTitle = dynamic_cast(xInnerPropertySet.get());
+if(pTitle)
 {
 OUString aString;
 rOuterValue >>= aString;
-TitleHelper::setCompleteString( aString, xTitle, m_xContext );
+TitleHelper::setCompleteString( aString, pTitle, m_xContext );
 }
 }
 Any WrappedTitleStringProperty::getPropertyValue( const Reference< 
beans::XPropertySet >& xInnerPropertySet ) const
diff --git 
a/chart2/source/controller/chartapiwrapper/WrappedAxisAndGridExistenceProperties.cxx
 
b/chart2/source/controller/chartapiwrapper/WrappedAxisAndGridExistenceProperties.cxx
index 

[Libreoffice-commits] core.git: 2 commits - chart2/source

2023-03-22 Thread Noel Grandin (via logerrit)
 chart2/source/controller/dialogs/DataBrowserModel.cxx |6 +---
 chart2/source/controller/dialogs/DataBrowserModel.hxx |2 -
 chart2/source/controller/main/ObjectHierarchy.cxx |9 +++
 chart2/source/controller/sidebar/ChartSeriesPanel.cxx |2 -
 chart2/source/inc/StatisticsHelper.hxx|   12 +
 chart2/source/tools/StatisticsHelper.cxx  |   23 --
 6 files changed, 27 insertions(+), 27 deletions(-)

New commits:
commit f6da444a9e2b239d8905d6cdb845c7be8d8ce66f
Author: Noel Grandin 
AuthorDate: Wed Mar 22 11:04:36 2023 +0200
Commit: Noel Grandin 
CommitDate: Wed Mar 22 19:58:26 2023 +

use more concrete type in chart2

Change-Id: I33deb726da5a59093b1104696da7c80ce830b7e0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149335
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/chart2/source/controller/dialogs/DataBrowserModel.cxx 
b/chart2/source/controller/dialogs/DataBrowserModel.cxx
index f406935b1f21..ffddcacf5d8f 100644
--- a/chart2/source/controller/dialogs/DataBrowserModel.cxx
+++ b/chart2/source/controller/dialogs/DataBrowserModel.cxx
@@ -888,7 +888,7 @@ void DataBrowserModel::updateFromModel()
 }
 
 void DataBrowserModel::addErrorBarRanges(
-const Reference< chart2::XDataSeries > & xDataSeries,
+const rtl::Reference< DataSeries > & xDataSeries,
 sal_Int32 nNumberFormatKey,
 sal_Int32 & rInOutSequenceIndex,
 sal_Int32 & rInOutHeaderEnd, bool bYError )
@@ -918,9 +918,7 @@ void DataBrowserModel::addErrorBarRanges(
 
 for (uno::Reference const & 
rDataSequence : aSequences)
 {
-rtl::Reference pDataSeries = 
dynamic_cast(xDataSeries.get());
-assert(pDataSeries || !xDataSeries);
-m_aColumns.emplace_back(pDataSeries, 
lcl_getUIRoleName(rDataSequence),
+m_aColumns.emplace_back(xDataSeries, 
lcl_getUIRoleName(rDataSequence),
  rDataSequence, NUMBER, 
nNumberFormatKey);
 ++rInOutSequenceIndex;
 ++rInOutHeaderEnd;
diff --git a/chart2/source/controller/dialogs/DataBrowserModel.hxx 
b/chart2/source/controller/dialogs/DataBrowserModel.hxx
index 7195363ff148..e3254851d002 100644
--- a/chart2/source/controller/dialogs/DataBrowserModel.hxx
+++ b/chart2/source/controller/dialogs/DataBrowserModel.hxx
@@ -146,7 +146,7 @@ private:
 void removeComplexCategoryLevel( sal_Int32 nAtColumnIndex );
 
 void addErrorBarRanges(
-const css::uno::Reference & xDataSeries,
+const rtl::Reference<::chart::DataSeries > & xDataSeries,
 sal_Int32 nNumberFormatKey,
 sal_Int32 & rInOutSequenceIndex,
 sal_Int32 & rInOutHeaderEnd, bool bYError );
diff --git a/chart2/source/inc/StatisticsHelper.hxx 
b/chart2/source/inc/StatisticsHelper.hxx
index d4a05daafd80..e7008020022c 100644
--- a/chart2/source/inc/StatisticsHelper.hxx
+++ b/chart2/source/inc/StatisticsHelper.hxx
@@ -20,6 +20,7 @@
 
 #include 
 #include 
+#include 
 #include "charttoolsdllapi.hxx"
 
 namespace com::sun::star::beans { class XPropertySet; }
@@ -30,6 +31,7 @@ namespace com::sun::star::chart2::data { class XDataSource; }
 namespace com::sun::star::chart2::data { class XLabeledDataSequence; }
 namespace com::sun::star::uno { template  class Sequence; }
 namespace chart { class LabeledDataSequence; }
+namespace chart { class DataSeries; }
 
 namespace chart::StatisticsHelper
 {
@@ -74,25 +76,25 @@ namespace chart::StatisticsHelper
 /// @return the newly created or existing error bar object
 OOO_DLLPUBLIC_CHARTTOOLS css::uno::Reference< css::beans::XPropertySet >
 addErrorBars(
-const css::uno::Reference< css::chart2::XDataSeries > & 
xDataSeries,
+const rtl::Reference< ::chart::DataSeries > & xDataSeries,
 sal_Int32 nStyle,
 bool bYError = true );
 
 OOO_DLLPUBLIC_CHARTTOOLS css::uno::Reference< css::beans::XPropertySet >
 getErrorBars(
-const css::uno::Reference< css::chart2::XDataSeries > & 
xDataSeries,
+const rtl::Reference< ::chart::DataSeries > & xDataSeries,
 bool bYError = true );
 
 OOO_DLLPUBLIC_CHARTTOOLS bool hasErrorBars(
-const css::uno::Reference< css::chart2::XDataSeries > & xDataSeries,
+const rtl::Reference< ::chart::DataSeries > & xDataSeries,
 bool bYError = true );
 
 OOO_DLLPUBLIC_CHARTTOOLS void removeErrorBars(
-const css::uno::Reference< css::chart2::XDataSeries > & xDataSeries,
+const rtl::Reference< ::chart::DataSeries > & xDataSeries,
 bool bYError = true );
 
 OOO_DLLPUBLIC_CHARTTOOLS bool usesErrorBarRanges(
-const css::uno::Reference< css::chart2::XDataSeries > & xDataSeries,
+const rtl::Reference< ::chart::DataSeries > & xDataSeries,
 bool bYError = true );
 
 } //  namespace chart
diff --git a/chart2/source/tools/StatisticsHelper.cxx 

[Libreoffice-commits] core.git: 2 commits - chart2/source

2023-03-22 Thread Noel Grandin (via logerrit)
 chart2/source/inc/FormattedStringHelper.hxx  |7 +--
 chart2/source/inc/RegressionCurveCalculator.hxx  |   44 +++
 chart2/source/inc/RegressionCurveHelper.hxx  |3 +
 chart2/source/tools/FormattedStringHelper.cxx|6 +--
 chart2/source/tools/RegressionCurveHelper.cxx|4 +-
 chart2/source/tools/RegressionCurveModel.cxx |1 
 chart2/source/view/charttypes/VSeriesPlotter.cxx |6 +--
 chart2/source/view/inc/LegendEntryProvider.hxx   |2 -
 chart2/source/view/main/VDataSeries.cxx  |5 +-
 chart2/source/view/main/VLegend.cxx  |   21 --
 10 files changed, 48 insertions(+), 51 deletions(-)

New commits:
commit c00cd73f15606d4e0fc942ddbb1ab734b83fc8c7
Author: Noel Grandin 
AuthorDate: Wed Mar 22 10:38:50 2023 +0200
Commit: Noel Grandin 
CommitDate: Wed Mar 22 19:58:09 2023 +

use more concrete type in chart2

Change-Id: I92e0cb707b0fdd8e82ba350919294584904f2c68
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149333
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/chart2/source/inc/RegressionCurveCalculator.hxx 
b/chart2/source/inc/RegressionCurveCalculator.hxx
index 6cf1f2914d5b..ebb3ad40f616 100644
--- a/chart2/source/inc/RegressionCurveCalculator.hxx
+++ b/chart2/source/inc/RegressionCurveCalculator.hxx
@@ -42,28 +42,6 @@ public:
 static bool isLogarithmicScaling(
 const css::uno::Reference< css::chart2::XScaling >& xScaling );
 
-protected:
-virtual OUString ImplGetRepresentation(
-const css::uno::Reference< css::util::XNumberFormatter >& 
xNumFormatter,
-sal_Int32 nNumberFormatKey, sal_Int32* pFormulaLength = nullptr ) 
const = 0;
-
-static OUString getFormattedString(
-const css::uno::Reference< css::util::XNumberFormatter >& 
xNumFormatter,
-sal_Int32 nNumberFormatKey,
-double fNumber,
-const sal_Int32* pStringLength );
-
-static void addStringToEquation( OUStringBuffer& aStrEquation, sal_Int32& 
nLineLength, OUStringBuffer const & aAddString, const sal_Int32* pMaxLength );
-
-double m_fCorrelationCoefficient;
-
-sal_Int32 mDegree;
-bool  mForceIntercept;
-doublemInterceptValue;
-sal_Int32 mPeriod;
-OUString mXName, mYName;
-sal_Int32 mnMovingType;
-
 //  XRegressionCurveCalculator 
 virtual void SAL_CALL setRegressionProperties(
 sal_Int32 aDegree,
@@ -96,6 +74,28 @@ protected:
 
 virtual void SAL_CALL setXYNames(
 const OUString& aXName, const OUString& aYName ) override;
+
+protected:
+virtual OUString ImplGetRepresentation(
+const css::uno::Reference< css::util::XNumberFormatter >& 
xNumFormatter,
+sal_Int32 nNumberFormatKey, sal_Int32* pFormulaLength = nullptr ) 
const = 0;
+
+static OUString getFormattedString(
+const css::uno::Reference< css::util::XNumberFormatter >& 
xNumFormatter,
+sal_Int32 nNumberFormatKey,
+double fNumber,
+const sal_Int32* pStringLength );
+
+static void addStringToEquation( OUStringBuffer& aStrEquation, sal_Int32& 
nLineLength, OUStringBuffer const & aAddString, const sal_Int32* pMaxLength );
+
+double m_fCorrelationCoefficient;
+
+sal_Int32 mDegree;
+bool  mForceIntercept;
+doublemInterceptValue;
+sal_Int32 mPeriod;
+OUString mXName, mYName;
+sal_Int32 mnMovingType;
 };
 
 } //  namespace chart
diff --git a/chart2/source/inc/RegressionCurveHelper.hxx 
b/chart2/source/inc/RegressionCurveHelper.hxx
index d8e35a25f089..9f1b935c0d01 100644
--- a/chart2/source/inc/RegressionCurveHelper.hxx
+++ b/chart2/source/inc/RegressionCurveHelper.hxx
@@ -35,6 +35,7 @@ namespace com::sun::star::frame { class XModel; }
 namespace chart { class ChartModel; }
 namespace chart { class DataSeries; }
 namespace chart { class RegressionCurveModel; }
+namespace chart { class RegressionCurveCalculator; }
 
 namespace chart::RegressionCurveHelper
 {
@@ -140,7 +141,7 @@ namespace chart::RegressionCurveHelper
 css::uno::Reference const & 
xRegressionCurve );
 
 /// returns a calculator object for regression curves (used by the view)
-OOO_DLLPUBLIC_CHARTTOOLS 
css::uno::Reference
+OOO_DLLPUBLIC_CHARTTOOLS rtl::Reference<::chart::RegressionCurveCalculator>
 createRegressionCurveCalculatorByServiceName( std::u16string_view 
aServiceName );
 
 /** recalculates the regression parameters according to the data given in
diff --git a/chart2/source/tools/RegressionCurveHelper.cxx 
b/chart2/source/tools/RegressionCurveHelper.cxx
index 50da3958d959..0bed3ca19e16 100644
--- a/chart2/source/tools/RegressionCurveHelper.cxx
+++ b/chart2/source/tools/RegressionCurveHelper.cxx
@@ -135,10 +135,10 @@ rtl::Reference< RegressionCurveModel > 
RegressionCurveHelper::createRegressionCu
 return xResult;
 }
 
-Reference< XRegressionCurveCalculator > 
RegressionCurveHelper::createRegressionCurveCalculatorByServiceName(

[Libreoffice-bugs] [Bug 153293] [META] Dark Mode bugs and enhancements

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153293
Bug 153293 depends on bug 153808, which changed state.

Bug 153808 Summary: Preview in the Bullets and Numbering is not painting 
bullets/numbers in dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=153808

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 125902] [META] Impress Bullets New Dialog

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125902
Bug 125902 depends on bug 153808, which changed state.

Bug 153808 Summary: Preview in the Bullets and Numbering is not painting 
bullets/numbers in dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=153808

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: cui/source

2023-03-22 Thread Rafael Lima (via logerrit)
 cui/source/tabpages/numpages.cxx |   43 ++-
 1 file changed, 25 insertions(+), 18 deletions(-)

New commits:
commit 3a4b32c9e1dfc56d9b00e3720834d21c9095f629
Author: Rafael Lima 
AuthorDate: Fri Feb 24 15:23:48 2023 -0300
Commit: Rafael Lima 
CommitDate: Wed Mar 22 19:52:24 2023 +

tdf#153808 Fix numbering preview in dark mode

This patch fixes the color used for numbers and bullets in the preview
of the Bullets and Numbering dialog in Impress. Currently the
implementation causes the bullets and numbers to be rendered in white
over a white background when using dark mode.

The fix uses DOCCOLOR and FONTCOLOR to create the preview, instead of
FieldColor and FieldTextColor.

Change-Id: Icf41c5be59c67a2d68e3c520744276492e9baa59
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147664
Tested-by: Jenkins
Reviewed-by: Heiko Tietze 

diff --git a/cui/source/tabpages/numpages.cxx b/cui/source/tabpages/numpages.cxx
index 0ced9e4536dd..19a2b37ed82d 100644
--- a/cui/source/tabpages/numpages.cxx
+++ b/cui/source/tabpages/numpages.cxx
@@ -43,6 +43,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -2161,10 +2162,10 @@ static tools::Long lcl_DrawBullet(VirtualDevice* pVDev,
 aFont.SetFontSize(aTmpSize);
 aFont.SetTransparent(true);
 Color aBulletColor = rFmt.GetBulletColor();
-if(aBulletColor == COL_AUTO)
-aBulletColor = pVDev->GetFillColor().IsDark() ? COL_WHITE : COL_BLACK;
-else if(aBulletColor == pVDev->GetFillColor())
-aBulletColor.Invert();
+if (aBulletColor == COL_AUTO)
+aBulletColor = pVDev->GetBackgroundColor().IsDark() ? COL_WHITE : 
COL_BLACK;
+else if (pVDev->GetBackgroundColor().IsDark() == aBulletColor.IsDark())
+aBulletColor = pVDev->GetBackgroundColor().IsDark() ? COL_WHITE : 
COL_BLACK;
 aFont.SetColor(aBulletColor);
 pVDev->SetFont( aFont );
 sal_UCS4 cChar = rFmt.GetBulletChar();
@@ -2190,9 +2191,9 @@ void SvxNumberingPreview::Paint(vcl::RenderContext& 
rRenderContext, const ::tool
 {
 Size aSize(rRenderContext.PixelToLogic(GetOutputSizePixel()));
 
-const StyleSettings& rStyleSettings = 
rRenderContext.GetSettings().GetStyleSettings();
-const Color aBackColor = rStyleSettings.GetFieldColor();
-const Color aTextColor = rStyleSettings.GetFieldTextColor();
+// Use default document and font colors to create preview
+const Color aBackColor = 
svtools::ColorConfig().GetColorValue(svtools::DOCCOLOR).nColor;
+const Color aTextColor = 
svtools::ColorConfig().GetColorValue(svtools::FONTCOLOR).nColor;
 
 ScopedVclPtrInstance pVDev(rRenderContext);
 pVDev->EnableRTL(rRenderContext.IsRTLEnabled());
@@ -2204,6 +2205,8 @@ void SvxNumberingPreview::Paint(vcl::RenderContext& 
rRenderContext, const ::tool
 aLineColor.Invert();
 pVDev->SetLineColor(aLineColor);
 pVDev->SetFillColor(aBackColor);
+pVDev->SetBackground(Wallpaper(aBackColor));
+pVDev->DrawWallpaper(pVDev->GetOutputRectPixel(), pVDev->GetBackground());
 
 if (pActNum)
 {
@@ -2231,6 +2234,9 @@ void SvxNumberingPreview::Paint(vcl::RenderContext& 
rRenderContext, const ::tool
 
 if (bPosition)
 {
+// When bPosition == true, draw the preview used in the Writer's 
"Position" tab
+// This is not used in Impress/Draw
+
 tools::Long nLineHeight = nFontHeight * 8 / 7;
 sal_uInt8 nStart = 0;
 while (!(nActLevel & (1GetBackgroundColor().IsDark() == 
aTmpBulletColor.IsDark())
+aTmpBulletColor = pVDev->GetBackgroundColor().IsDark() 
? COL_WHITE : COL_BLACK;
 aColorFont.SetColor(aTmpBulletColor);
 pVDev->SetFont(aColorFont);
 pVDev->DrawText(Point(nNumberXPos, nYStart), aText);
@@ -2361,14 +2367,15 @@ void SvxNumberingPreview::Paint(vcl::RenderContext& 
rRenderContext, const ::tool
 }
 else
 {
+// When bPosition == false, draw the preview used in Writer's 
"Customize" tab
+// and in Impress' "Bullets and Numbering" dialog
+
 //#i5153# painting gray or black rectangles as 'normal' numbering 
text
 tools::Long nWidth = pVDev->GetTextWidth("Preview");
 tools::Long nTextHeight = pVDev->GetTextHeight();
 tools::Long nRectHeight = nTextHeight * 2 / 3;
 tools::Long nTopOffset = nTextHeight - nRectHeight;
-Color aBlackColor(COL_BLACK);
-if (aBlackColor == aBackColor)
-aBlackColor.Invert();
+Color aSelRectColor = pVDev->GetBackgroundColor().IsDark() ? 
COL_WHITE : COL_BLACK;
 
 for (sal_uInt16 nLevel = 0; nLevel < pActNum->GetLevelCount(); 
++nLevel, nYStart = nYStart + nYStep)

[Libreoffice-bugs] [Bug 154334] hang when doing email mail merge

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154334

John F. Ervin  changed:

   What|Removed |Added

 CC||jfer...@gmail.com

--- Comment #1 from John F. Ervin  ---
Created attachment 186143
  --> https://bugs.documentfoundation.org/attachment.cgi?id=186143=edit
screen shot of failing email merge.

I am aware that this is actually and long term and persistently reported bug,
but it would have been very convenient to send these emails using LibreOffice. 
I'll have to figure out how to do it in gmail now.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154334] New: hang when doing email mail merge

2023-03-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154334

Bug ID: 154334
   Summary: hang when doing email mail merge
   Product: LibreOffice
   Version: 7.4.6.2 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: jfer...@gmail.com

Description:
I have a Template, I have a spreadsheet (ods) when I fire off the email merge
and tell it to do from 2 to 9, (because I've heard it decrements the first
number, so 1 goes to 0), it says it's creating 2 to 8 and then sits there til
it times out.  I tried 7.4.6.2 and I tried the most recent 6.4 and it hung for
both.  The spreadsheet has 9 lines of information for 9 people.

Steps to Reproduce:
1.Bring up the template in writer
2.Point it to the correct spreadsheet database
3.click on send email messages
4.follow process and it should hang.  I can help be sending the actual
template, the database spreadsheet is sort of proprietary but I can send a fake
version.

Actual Results:
Mail Merge Hangs after it says it created the emails (before it sends them)

Expected Results:
9 people should have emails sent to them.


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 7.4.6.2 / LibreOffice Community
Build ID: 5b1f5509c2decdade7fda905e3e1429a67acd63d
CPU threads: 8; OS: Linux 6.2; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-7-5+backports' - 3 commits - android/source

2023-03-22 Thread Michael Weghorn (via logerrit)
 android/source/build.gradle   |9 
+
 android/source/src/java/org/libreoffice/LibreOfficeMainActivity.java  |2 +-
 android/source/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java |6 
++
 3 files changed, 12 insertions(+), 5 deletions(-)

New commits:
commit 4ae165696f00d08715cf4797a746a025a2e24a71
Author: Michael Weghorn 
AuthorDate: Wed Jan 18 12:10:43 2023 +0100
Commit: Michael Weghorn 
CommitDate: Wed Mar 22 20:00:12 2023 +0100

android: Only offer creating docs when editing enabled

Hide the UI to create new documents unless the
experimental editing mode is enabled. There is
little use in creating new empty documents when there
is no way to edit them...

Change-Id: I2f8c86f5db96a5135ff8a66a7a7078b664d05a5e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145735
Tested-by: Jenkins
Reviewed-by: Michael Weghorn 
(cherry picked from commit 5e4bcb501f2cefaa495e59de7decbdf5a1f69d51)

diff --git 
a/android/source/src/java/org/libreoffice/LibreOfficeMainActivity.java 
b/android/source/src/java/org/libreoffice/LibreOfficeMainActivity.java
index a44ec56e2457..54418f5cbc8f 100644
--- a/android/source/src/java/org/libreoffice/LibreOfficeMainActivity.java
+++ b/android/source/src/java/org/libreoffice/LibreOfficeMainActivity.java
@@ -60,7 +60,7 @@ import java.util.UUID;
 public class LibreOfficeMainActivity extends AppCompatActivity implements 
SettingsListenerModel.OnSettingsPreferenceChangedListener {
 
 private static final String LOGTAG = "LibreOfficeMainActivity";
-private static final String ENABLE_EXPERIMENTAL_PREFS_KEY = 
"ENABLE_EXPERIMENTAL";
+public static final String ENABLE_EXPERIMENTAL_PREFS_KEY = 
"ENABLE_EXPERIMENTAL";
 private static final String ASSETS_EXTRACTED_PREFS_KEY = 
"ASSETS_EXTRACTED";
 private static final String ENABLE_DEVELOPER_PREFS_KEY = 
"ENABLE_DEVELOPER";
 private static final int REQUEST_CODE_SAVEAS = 12345;
diff --git 
a/android/source/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java 
b/android/source/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java
index a5fa78f22404..05a0c2f8ef21 100644
--- a/android/source/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java
+++ b/android/source/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java
@@ -46,6 +46,7 @@ import android.widget.TextView;
 import android.widget.Toast;
 
 import org.libreoffice.AboutDialogFragment;
+import org.libreoffice.BuildConfig;
 import org.libreoffice.LibreOfficeMainActivity;
 import org.libreoffice.LocaleHelper;
 import org.libreoffice.R;
@@ -179,6 +180,11 @@ public class LibreOfficeUIActivity extends 
AppCompatActivity implements Settings
 
 editFAB = findViewById(R.id.editFAB);
 editFAB.setOnClickListener(this);
+// allow creating new docs only when experimental editing is enabled
+SharedPreferences preferences = 
PreferenceManager.getDefaultSharedPreferences(getApplicationContext());
+boolean bAllowCreatingDocs = BuildConfig.ALLOW_EDITING && 
preferences.getBoolean(LibreOfficeMainActivity.ENABLE_EXPERIMENTAL_PREFS_KEY, 
false);
+editFAB.setVisibility(bAllowCreatingDocs ? View.VISIBLE : 
View.INVISIBLE);
+
 impressFAB = findViewById(R.id.newImpressFAB);
 impressFAB.setOnClickListener(this);
 writerFAB = findViewById(R.id.newWriterFAB);
commit 264ad1f991b24e681ed84b857f21b8320681ca42
Author: Michael Weghorn 
AuthorDate: Tue Dec 27 12:46:28 2022 +0100
Commit: Michael Weghorn 
CommitDate: Wed Mar 22 19:58:32 2023 +0100

android: Update compileSdkVersion/targetSdkVersion to 33

API version 33 refers to Android 13.

I didn't notice anything requiring changes
when quickly going over the release notes for all apps running on
Android 13 [1] and apps targeting Android 13 [2].

[1] https://developer.android.com/about/versions/13/behavior-changes-all
[2] https://developer.android.com/about/versions/13/behavior-changes-13

Change-Id: I8b68f3bf0afc4c00ecd3412a8fdf0581f2d6bbc0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144837
Tested-by: Jenkins
Reviewed-by: Michael Weghorn 
(cherry picked from commit e690752d5643ffaf4da8778768e5e080476b2427)

diff --git a/android/source/build.gradle b/android/source/build.gradle
index 48fe1627af27..4e2f31b84252 100644
--- a/android/source/build.gradle
+++ b/android/source/build.gradle
@@ -31,7 +31,7 @@ dependencies {
 }
 
 android {
-compileSdkVersion 32
+compileSdkVersion 33
 // uses non-conventional source layout, so need to reconfigure accordingly
 // ToDo move to conventional layout, so stuff can be stripped down.
 sourceSets {
@@ -47,7 +47,7 @@ android {
 }
 defaultConfig {
 minSdkVersion 16
-targetSdkVersion 32
+targetSdkVersion 33
 vectorDrawables.useSupportLibrary = true
 }
 buildTypes {
commit 

  1   2   3   4   >