[Libreoffice-bugs] [Bug 154852] CELL() function does not update after worksheet rename

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154852

kenjfzh...@163.com changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154852] CELL() function does not update after worksheet rename

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154852

--- Comment #9 from kenjfzh...@163.com ---
(In reply to Eike Rathke from comment #6)
> (In reply to Eike Rathke from comment #3)
> > For this to work, the formula cell containing CELL() would have to listen at
> > a sheet rename event. Which currently isn't broadcasted as a data change at
> > all, and also shouldn't in general except for CELL() and probably 
> > INDIRECT().
> > 
> > The reference appears updated because it refers only to the sheet number and
> > when being viewed that is resolved to the current name.
> 
> Hi, Eike, the cell() function is what I needed.
> I use 'CELL("address",S1!$B$2)' in MS office, and it works fine, but it not
> work right in libreoffice.

Hi, Eike, thanks for your info, and it works.
I just understood your message after the workaround explanation from ady.
Thank you so much.
Have a nice day!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143200] Crash: Assertion failing when pasting a cell to a large-height range

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143200

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.6.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: xmloff/source

2023-04-17 Thread Noel Grandin (via logerrit)
 xmloff/source/draw/shapeexport.cxx |6 ++
 1 file changed, 2 insertions(+), 4 deletions(-)

New commits:
commit 94e505b9ffbeb1695393d5dea0da84a0bf887fba
Author: Noel Grandin 
AuthorDate: Mon Apr 17 19:25:26 2023 +0200
Commit: Noel Grandin 
CommitDate: Tue Apr 18 07:51:55 2023 +0200

no need to perform lookup twice in XMLShapeExport::seekShapes

Change-Id: I833da530fdc43233e14482a17a60beadb6ef6043
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150530
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/xmloff/source/draw/shapeexport.cxx 
b/xmloff/source/draw/shapeexport.cxx
index 056c3ce98267..94b7ad8e78a0 100644
--- a/xmloff/source/draw/shapeexport.cxx
+++ b/xmloff/source/draw/shapeexport.cxx
@@ -1092,11 +1092,9 @@ void XMLShapeExport::seekShapes( const uno::Reference< 
drawing::XShapes >& xShap
 maCurrentShapesIter = maShapesInfos.find( xShapes );
 if( maCurrentShapesIter == maShapesInfos.end() )
 {
-ImplXMLShapeExportInfoVector aNewInfoVector;
-aNewInfoVector.resize( 
static_cast(xShapes->getCount()) );
-maShapesInfos[ xShapes ] = aNewInfoVector;
+auto itPair = maShapesInfos.emplace( xShapes, 
ImplXMLShapeExportInfoVector( 
static_cast(xShapes->getCount()) ) );
 
-maCurrentShapesIter = maShapesInfos.find( xShapes );
+maCurrentShapesIter = itPair.first;
 
 SAL_WARN_IF( maCurrentShapesIter == maShapesInfos.end(), "xmloff", 
"XMLShapeExport::seekShapes(): insert into stl::map failed" );
 }


[Libreoffice-commits] core.git: tools/source

2023-04-17 Thread Noel Grandin (via logerrit)
 tools/source/generic/fract.cxx |   44 -
 1 file changed, 22 insertions(+), 22 deletions(-)

New commits:
commit b1684730ccbbca83df4dcb07d4759eebebbc4d66
Author: Noel Grandin 
AuthorDate: Mon Apr 17 13:24:25 2023 +0200
Commit: Noel Grandin 
CommitDate: Tue Apr 18 07:51:38 2023 +0200

tdf#143200 assert when pasting a cell to a large-height range

The values are unfortunately genuinely outside the range that our
Fraction class can work with.
So do the least-bad thing for now, and reduce the magnitude of the
values until they fit.

Change-Id: Iedc34e9767b3d4a502f5d84efcdebc96c6514cac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150493
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/tools/source/generic/fract.cxx b/tools/source/generic/fract.cxx
index 4acd46cec404..a583e75a7cac 100644
--- a/tools/source/generic/fract.cxx
+++ b/tools/source/generic/fract.cxx
@@ -49,24 +49,36 @@ static boost::rational toRational(sal_Int32 n, 
sal_Int32 d)
 return boost::rational(n, d);
 }
 
+static constexpr bool isOutOfRange(sal_Int64 nNum)
+{
+return nNum < std::numeric_limits::min()
+|| nNum > std::numeric_limits::max();
+}
+
 // Initialized by setting nNum as nominator and nDen as denominator
 // Negative values in the denominator are invalid and cause the
 // inversion of both nominator and denominator signs
 // in order to return the correct value.
 Fraction::Fraction( sal_Int64 nNum, sal_Int64 nDen ) : mnNumerator(nNum), 
mnDenominator(nDen)
 {
-assert( nNum >= std::numeric_limits::min() );
-assert( nNum <= std::numeric_limits::max( ));
-assert( nDen >= std::numeric_limits::min() );
-assert( nDen <= std::numeric_limits::max( ));
-if ( nDen == 0 )
+if ( isOutOfRange(nNum) || isOutOfRange(nDen) )
+{
+// tdf#143200
+SAL_WARN("tools.fraction", "values outside of range we can represent, 
doing reduction, which will reduce precision");
+do
+{
+mnNumerator /= 2;
+mnDenominator /= 2;
+} while (isOutOfRange(mnNumerator) || isOutOfRange(mnDenominator));
+}
+if ( mnDenominator == 0 )
 {
 mbValid = false;
 SAL_WARN( "tools.fraction", "'Fraction(" << nNum << ",0)' invalid 
fraction created" );
 return;
 }
-if ((nDen == -1 && nNum == std::numeric_limits::min()) ||
-(nNum == -1 && nDen == std::numeric_limits::min()))
+else if ((nDen == -1 && nNum == std::numeric_limits::min()) ||
+(nNum == -1 && nDen == std::numeric_limits::min()))
 {
 mbValid = false;
 SAL_WARN("tools.fraction", "'Fraction(" << nNum << "," << nDen << ")' 
invalid fraction created");
@@ -77,21 +89,9 @@ Fraction::Fraction( sal_Int64 nNum, sal_Int64 nDen ) : 
mnNumerator(nNum), mnDeno
 /**
  * only here to prevent passing of NaN
  */
-Fraction::Fraction( double nNum, double nDen ) : mnNumerator(sal_Int64(nNum)), 
mnDenominator(sal_Int64(nDen))
-{
-assert( !std::isnan(nNum) );
-assert( !std::isnan(nDen) );
-assert( nNum >= std::numeric_limits::min() );
-assert( nNum <= std::numeric_limits::max( ));
-assert( nDen >= std::numeric_limits::min() );
-assert( nDen <= std::numeric_limits::max( ));
-if ( nDen == 0 )
-{
-mbValid = false;
-SAL_WARN( "tools.fraction", "'Fraction(" << nNum << ",0)' invalid 
fraction created" );
-return;
-}
-}
+Fraction::Fraction( double nNum, double nDen )
+: Fraction(sal_Int64(nNum), sal_Int64(nDen))
+{}
 
 Fraction::Fraction( double dVal )
 {


[Libreoffice-bugs] [Bug 154876] FORMCONTROLS: Radio button reference value (on) not passed exported to PDF

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154876

--- Comment #1 from Steve  ---
This is on Win10 21H2.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154876] New: FORMCONTROLS: Radio button reference value (on) not passed exported to PDF

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154876

Bug ID: 154876
   Summary: FORMCONTROLS: Radio button reference value (on) not
passed exported to PDF
   Product: LibreOffice
   Version: 7.5.2.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: st...@nyhof.id.au

This problem is new since LibreOffice 7.1.8.1, where things worked just fine.

To reproduce:

1. Create a radio button group in a Writer document.
2. Set a button's 'Data' tab 'Reference value (on)' to '5'.
3. Export As PDF (with 'Create PDF Form' ticked).
4. Open the resulting PDF in Acrobat.
5. Right-click the radio button, select 'Properties'.
6. Click the 'Options' tab.
7. Note that the 'Radio Button Choice' field is set to '0'. It should be '5'.

If the identical steps are taken in Writer 7.1.8.1, the value is exported
properly.

I also tested 7.4.6 and it exhibited the problem too.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154852] CELL() function does not update after worksheet rename

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154852

--- Comment #8 from kenjfzh...@163.com ---
(In reply to ady from comment #7)
> (In reply to Eike Rathke from comment #3)
> > For this to work, the formula cell containing CELL() would have to listen at
> > a sheet rename event. Which currently isn't broadcasted as a data change at
> > all, and also shouldn't in general except for CELL() and probably 
> > INDIRECT().
> 
> 
> * FWIW (OT), INFO() doesn't even react to recalculation (e.g. INFO("recalc")
> when going from Automatic to Manual is not updated by recalc hard).
> 
> * FWIW, Google Sheets works in the same way as LO (i.e. CELL() doesn't
> listen at sheet rename event).
> 
> 
> 
> (In reply to kenjfzhong from comment #5)
> > formula :=  =CELL("address",S3.$B$2)
> > result := "$S2.$B$2"
> 
> 
> Simple workaround:
> 1. In $Sheet2.$A$1, use the (volatile) function =NOW()
> 2. Wherever you want, use =CELL("address",$Sheet2.$A$1)
> 3. Rename the worksheet Sheet2 to whatever else you want.
> 
> Result: since you have autocalculate ON, when you rename the worksheet the
> volatile function NOW() gets updated, and so the dependent CELL() function
> will get updated too.

Ah! thanks for your workaround, it works!
Thank you so much!
Have a good day!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: canvas/source configmgr/source forms/source sd/source sw/source vcl/source

2023-04-17 Thread Stephan Bergmann (via logerrit)
 canvas/source/vcl/canvas.cxx |   13 +
 canvas/source/vcl/canvas.hxx |8 +++-
 configmgr/source/update.cxx  |   16 +++-
 forms/source/component/imgprod.cxx   |   14 ++
 forms/source/component/imgprod.hxx   |6 ++
 sd/source/ui/presenter/PresenterHelper.cxx   |   13 +
 sd/source/ui/presenter/PresenterHelper.hxx   |6 ++
 sd/source/ui/presenter/PresenterPreviewCache.cxx |   13 +
 sd/source/ui/presenter/PresenterPreviewCache.hxx |6 ++
 sw/source/filter/ww8/rtfexportfilter.cxx |   13 +
 sw/source/filter/ww8/rtfexportfilter.hxx |8 +++-
 vcl/source/app/session.cxx   |   18 --
 12 files changed, 129 insertions(+), 5 deletions(-)

New commits:
commit 7c36c5fdfdfeab9d15ea733fe2a831cd4ff25d27
Author: Stephan Bergmann 
AuthorDate: Mon Apr 17 21:33:37 2023 +0200
Commit: Stephan Bergmann 
CommitDate: Tue Apr 18 07:38:29 2023 +0200

Some missing XServiceInfo implementations

Change-Id: I1cf871b40f9f4020147dac0456ebeed3de0438e6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150533
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/canvas/source/vcl/canvas.cxx b/canvas/source/vcl/canvas.cxx
index 7e38276e06d3..ac73acd96a8f 100644
--- a/canvas/source/vcl/canvas.cxx
+++ b/canvas/source/vcl/canvas.cxx
@@ -24,6 +24,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 
 #include "outdevholder.hxx"
@@ -96,6 +97,18 @@ namespace vclcanvas
 return "com.sun.star.rendering.Canvas.VCL";
 }
 
+OUString Canvas::getImplementationName() {
+return "com.sun.star.comp.rendering.Canvas.VCL";
+}
+
+sal_Bool Canvas::supportsService(OUString const & ServiceName) {
+return cppu::supportsService(this, ServiceName);
+}
+
+css::uno::Sequence Canvas::getSupportedServiceNames() {
+return {getServiceName()};
+}
+
 bool Canvas::repaint( const GraphicObjectSharedPtr& rGrf,
   const rendering::ViewState&   viewState,
   const rendering::RenderState& renderState,
diff --git a/canvas/source/vcl/canvas.hxx b/canvas/source/vcl/canvas.hxx
index be7d7858e3ad..8bcbc1f49894 100644
--- a/canvas/source/vcl/canvas.hxx
+++ b/canvas/source/vcl/canvas.hxx
@@ -21,6 +21,7 @@
 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -48,7 +49,8 @@ namespace vclcanvas
  css::lang::XMultiServiceFactory,
  css::util::XUpdatable,
  css::beans::XPropertySet,
- css::lang::XServiceName >
GraphicDeviceBase_Base;
+ css::lang::XServiceName,
+ css::lang::XServiceInfo >
GraphicDeviceBase_Base;
 typedef ::canvas::GraphicDeviceBase< ::canvas::BaseMutexHelper< 
GraphicDeviceBase_Base >,
DeviceHelper,
tools::LocalGuard,
@@ -96,6 +98,10 @@ namespace vclcanvas
 // XServiceName
 virtual OUString SAL_CALL getServiceName(  ) override;
 
+OUString SAL_CALL getImplementationName() override;
+sal_Bool SAL_CALL supportsService(OUString const & ServiceName) 
override;
+css::uno::Sequence SAL_CALL getSupportedServiceNames() 
override;
+
 // RepaintTarget
 virtual bool repaint( const GraphicObjectSharedPtr& 
rGrf,
   const css::rendering::ViewState&  
viewState,
diff --git a/configmgr/source/update.cxx b/configmgr/source/update.cxx
index 1cc2a06fe2a2..5851a6af05a3 100644
--- a/configmgr/source/update.cxx
+++ b/configmgr/source/update.cxx
@@ -23,10 +23,12 @@
 #include 
 
 #include 
+#include 
 #include 
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -50,7 +52,7 @@ std::set< OUString > seqToSet(
 }
 
 class Service:
-public cppu::WeakImplHelper< css::configuration::XUpdate >
+public cppu::WeakImplHelper< css::configuration::XUpdate, 
css::lang::XServiceInfo >
 {
 public:
 explicit Service(const css::uno::Reference< css::uno::XComponentContext >& 
context):
@@ -79,6 +81,18 @@ private:
 css::uno::Sequence< OUString > const & includedPaths,
 css::uno::Sequence< OUString > const & excludedPaths) override;
 
+OUString SAL_CALL getImplementationName() override {
+return "com.sun.star.comp.configuration.Update";
+}
+
+sal_Bool SAL_CALL supportsService(OUString const & ServiceName) override {
+return cppu::supportsService(this, ServiceName);
+}
+
+css::uno::Sequence SAL_CALL getSupportedServiceNames() override {
+

[Libreoffice-bugs] [Bug 38194] Style indicator in document margin

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=38194

--- Comment #53 from Jim Raykowski  ---
(In reply to Eyal Rozenberg from comment #51)
> Nice work!
Thanks! 

> * The diagonal stripes pattern is too "bold" IMHO. I'd consider decreasing
> its strength, e.g. by a transparency like effect, i.e. stripe color = eps *
> original color + (1 - eps) * black.
I agree. Is what is shown in the second demo better for you?

> * Repeating my question about controlling the color palette  
> * Will it be possible to highlight only _some_ of the styles?
Noted for future enhancements.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 38194] Style indicator in document margin

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=38194

--- Comment #52 from Jim Raykowski  ---
Created attachment 186749
  --> https://bugs.documentfoundation.org/attachment.cgi?id=186749=edit
Demo of border, hatch pattern, and feature name changes

Attached is a demo of changes made to the patch to:

- show no border around DF and CS
- make the hatch line color less dark
- increase the hatch line spacing
- use 'Spotlight' in place of 'Highlight'

Also shown is placement of the UNO control used to show character directed
formatting. The patch does not include an icon for the UNO or add it to any
toolbar or menu. Design team assistance please.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154875] "Use slide background" area fill keeps coming back in sidebar, transparency slider gone

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154875

Aron Budea  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
 CC||aron.bu...@gmail.com

--- Comment #1 from Aron Budea  ---
Confirmed using LO 7.6.0.0.alpha0+ (60bce1af8aab2115d603781193bb659b35d1aedb) /
Ubuntu.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: helpcontent2

2023-04-17 Thread Adolfo Jayme Barrientos (via logerrit)
 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 3c4f53bc19ab90a98edb75a2dc554c917e36ab11
Author: Adolfo Jayme Barrientos 
AuthorDate: Mon Apr 17 23:00:17 2023 -0600
Commit: Gerrit Code Review 
CommitDate: Tue Apr 18 07:00:17 2023 +0200

Update git submodules

* Update helpcontent2 from branch 'master'
  to d7088d24df28bba2fdbab7d77a2e7151e3b4f0dd
  - These descriptions shouldn’t be imperatives with contractions

Change-Id: I030e188834356511a64a243d5b38d413fd21667c
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/150534
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/helpcontent2 b/helpcontent2
index 2c7b120a5613..d7088d24df28 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 2c7b120a56135515df2a3f2a0ea74c2a5166de5b
+Subproject commit d7088d24df28bba2fdbab7d77a2e7151e3b4f0dd


[Libreoffice-commits] help.git: source/text

2023-04-17 Thread Adolfo Jayme Barrientos (via logerrit)
 source/text/swriter/01/05030200.xhp |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit d7088d24df28bba2fdbab7d77a2e7151e3b4f0dd
Author: Adolfo Jayme Barrientos 
AuthorDate: Mon Apr 17 22:59:12 2023 -0600
Commit: Adolfo Jayme Barrientos 
CommitDate: Tue Apr 18 07:00:17 2023 +0200

These descriptions shouldn’t be imperatives with contractions

Change-Id: I030e188834356511a64a243d5b38d413fd21667c
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/150534
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/source/text/swriter/01/05030200.xhp 
b/source/text/swriter/01/05030200.xhp
index f30faf26fd..8b7e3e0527 100644
--- a/source/text/swriter/01/05030200.xhp
+++ b/source/text/swriter/01/05030200.xhp
@@ -50,10 +50,10 @@
 Automatically inserts hyphens where they 
are needed in a paragraph.
 
 Don't hyphenate words in CAPS
-Don't insert hyphens in words written 
entirely in capital letters.
+Avoids hyphenating words written entirely 
in capital letters, such as initialisms.
 
 Don't hyphenate the last word
-Don't insert hyphens in the last word 
of paragraphs.
+Avoids hyphenating the last word of 
paragraphs. This feature can help prevent these words from being split up 
across pages, affecting readability.
 
 Characters at line end
 Enter the minimum number of characters to 
leave at the end of the line before a hyphen is inserted.


[Libreoffice-bugs] [Bug 154861] scalc crash on long scrolling (PageDown) ; Skia/Vulkan / Extremely high RAM consumption

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154861

a_san...@mail.ru changed:

   What|Removed |Added

Summary|scalc crash on long |scalc crash on long
   |scrolling (PageDown) ;  |scrolling (PageDown) ;
   |Skia/Vulkan |Skia/Vulkan / Extremely
   ||high RAM consumption

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154861] scalc crash on long scrolling (PageDown) ; Skia/Vulkan

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154861

--- Comment #6 from a_san...@mail.ru ---
When scrolling, memory consumption increases greatly. It can be seen in the
task manager.

After a while, free memory runs out and scalc closes or hangs.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154852] CELL() function does not update after worksheet rename

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154852

ady  changed:

   What|Removed |Added

Version|7.5.1.2 release |Inherited From OOo

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154852] CELL() function does not update after worksheet rename

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154852

ady  changed:

   What|Removed |Added

Summary|The cell formula does not   |CELL() function does not
   |reflect the updated result  |update after worksheet
   ||rename

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154861] scalc crash on long scrolling (PageDown) ; Skia/Vulkan

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154861

--- Comment #5 from a_san...@mail.ru ---
It reproduce on 7.5.3.1 / 7.5.2.2 / 7.4.6.2 / 7.3.7.2 / 7.3.5.2 / 7.3.1.3 /
7.3.0.3 / 7.3.0.1 / 7.3.0.0 a1 x64
The profile is always new.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154852] The cell formula does not reflect the updated result

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154852

--- Comment #7 from ady  ---
(In reply to Eike Rathke from comment #3)
> For this to work, the formula cell containing CELL() would have to listen at
> a sheet rename event. Which currently isn't broadcasted as a data change at
> all, and also shouldn't in general except for CELL() and probably INDIRECT().


* FWIW (OT), INFO() doesn't even react to recalculation (e.g. INFO("recalc")
when going from Automatic to Manual is not updated by recalc hard).

* FWIW, Google Sheets works in the same way as LO (i.e. CELL() doesn't listen
at sheet rename event).



(In reply to kenjfzhong from comment #5)
> formula :=  =CELL("address",S3.$B$2)
> result := "$S2.$B$2"


Simple workaround:
1. In $Sheet2.$A$1, use the (volatile) function =NOW()
2. Wherever you want, use =CELL("address",$Sheet2.$A$1)
3. Rename the worksheet Sheet2 to whatever else you want.

Result: since you have autocalculate ON, when you rename the worksheet the
volatile function NOW() gets updated, and so the dependent CELL() function will
get updated too.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154865] Enhancement: Eliminate duplicate Page settings in Properties deck of Sidebar

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154865

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154550] add icon for Edit Index Entry

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154550

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154822] "Repeat header" table's option causes in incorrect "Select table" selection

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154822

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154865] Enhancement: Eliminate duplicate Page settings in Properties deck of Sidebar

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154865

--- Comment #4 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154822] "Repeat header" table's option causes in incorrect "Select table" selection

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154822

--- Comment #6 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154714] Auto capital should not be applicable to a single letter inside quotations

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154714

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 154714] Auto capital should not be applicable to a single letter inside quotations

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154714

--- Comment #7 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-ux-advise] [Bug 154714] Auto capital should not be applicable to a single letter inside quotations

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154714

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-ux-advise] [Bug 147326] UI: "augmented reality" hovering mode (immediate display of underlying formulas etc.)

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147326

QA Administrators  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 154714] Auto capital should not be applicable to a single letter inside quotations

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154714

--- Comment #7 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147326] UI: "augmented reality" hovering mode (immediate display of underlying formulas etc.)

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147326

QA Administrators  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 147326] UI: "augmented reality" hovering mode (immediate display of underlying formulas etc.)

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147326

--- Comment #4 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 147326] UI: "augmented reality" hovering mode (immediate display of underlying formulas etc.)

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147326

--- Comment #4 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147333] Sheet Styles in Calc (Page style)

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147333

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147333] Sheet Styles in Calc (Page style)

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147333

--- Comment #3 from QA Administrators  ---
Dear ppae,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146389] charts in xlsx lost data opening in Libreoffice

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=146389

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146389] charts in xlsx lost data opening in Libreoffice

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=146389

--- Comment #8 from QA Administrators  ---
Dear Vikas,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145149] Unable to open spreadsheet

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145149

--- Comment #5 from QA Administrators  ---
Dear Richard BARRAS,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 137272] Superscripted font is cut off and line spacing increased when smaller block quoted text has footnote or endnote in it, due to use of one font size for all footnotes in

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137272

--- Comment #13 from QA Administrators  ---
Dear TH,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 98451] SVG: Transform scale works wrong on stroke, if Skia is enabled

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=98451

--- Comment #14 from QA Administrators  ---
Dear Regina Henschel,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 90139] EDITING: Cursor can disappear when cancelling Insert Shapes or Text Box when cursor in comment

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=90139

--- Comment #11 from QA Administrators  ---
Dear Gordo,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 141014] RTL footnotes that are added to ms-word files appear mirrorred in ms-word

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141014

--- Comment #13 from QA Administrators  ---
Dear Yotam Benshalom,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 140685] Changes in gutter position are not applied immediately but need reload

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=140685

--- Comment #3 from QA Administrators  ---
Dear Regina Henschel,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 141143] Extra paragraph is inserted after dragging an image

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141143

--- Comment #8 from QA Administrators  ---
Dear GAIDO Gilles,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 139637] Certain animations not functioning in Impress; previews end abruptly.

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=139637

--- Comment #4 from QA Administrators  ---
Dear Vijayendra Acharya,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 126970] calc: calculation: cancellation and operand ordering effects in calc | was: Function "SUM()" work doesn't correct if final result is zerro.

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126970

--- Comment #8 from QA Administrators  ---
Dear Oleksandr,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 118167] FILESAVE XLSX VBA-Project and Microsoft Excel Objects look different after export

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=118167

--- Comment #13 from QA Administrators  ---
Dear Gabor Kelemen,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - starmath/source

2023-04-17 Thread Mike Kaganski (via logerrit)
 starmath/source/ElementsDockingWindow.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 73e4009dc2a645b1bf9f06ce34711e135c147082
Author: Mike Kaganski 
AuthorDate: Mon Apr 17 18:26:56 2023 +0300
Commit: Adolfo Jayme Barrientos 
CommitDate: Tue Apr 18 05:17:49 2023 +0200

tdf#154016: use ScopedVclPtr

A regression crash from commit d79c527c2a599c7821d27cf03b95cb79e2abe685
(Use IconView in SmElementsControl, 2022-06-01). Without disposeAndClear,
the VirtualDevices leak; and on Windows this quickly leads to GDI handle
10 000 limit killing the process (which is good, helping to track this
kind of issues).

Change-Id: I28e1ffbeb425fae3fdbd76b7873fef5c929b8e11
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150523
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 
(cherry picked from commit c11463cdc5415707d05ab6da08736ff7212db4a0)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150511
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/starmath/source/ElementsDockingWindow.cxx 
b/starmath/source/ElementsDockingWindow.cxx
index a52b5f85ec0f..a3a4085a7ea1 100644
--- a/starmath/source/ElementsDockingWindow.cxx
+++ b/starmath/source/ElementsDockingWindow.cxx
@@ -508,7 +508,7 @@ struct ElementData
 void SmElementsControl::addElement(const OUString& aElementVisual, const 
OUString& aElementSource, const OUString& aHelpText)
 {
 std::unique_ptr pNode = maParser->ParseExpression(aElementVisual);
-VclPtr pDevice(mpIconView->create_virtual_device());
+ScopedVclPtr pDevice(mpIconView->create_virtual_device());
 pDevice->SetTextRenderModeForResolutionIndependentLayout(true);
 pDevice->SetMapMode(MapMode(MapUnit::Map100thMM));
 pDevice->SetDrawMode(DrawModeFlags::Default);


[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - starmath/source

2023-04-17 Thread Mike Kaganski (via logerrit)
 starmath/source/ElementsDockingWindow.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 069fcbe6531ad7e22c368c1a3994528ea30c8195
Author: Mike Kaganski 
AuthorDate: Mon Apr 17 18:26:56 2023 +0300
Commit: Adolfo Jayme Barrientos 
CommitDate: Tue Apr 18 05:17:31 2023 +0200

tdf#154016: use ScopedVclPtr

A regression crash from commit d79c527c2a599c7821d27cf03b95cb79e2abe685
(Use IconView in SmElementsControl, 2022-06-01). Without disposeAndClear,
the VirtualDevices leak; and on Windows this quickly leads to GDI handle
10 000 limit killing the process (which is good, helping to track this
kind of issues).

Change-Id: I28e1ffbeb425fae3fdbd76b7873fef5c929b8e11
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150523
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 
(cherry picked from commit c11463cdc5415707d05ab6da08736ff7212db4a0)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150510
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/starmath/source/ElementsDockingWindow.cxx 
b/starmath/source/ElementsDockingWindow.cxx
index 1ea324dc7fe7..59a02422c34c 100644
--- a/starmath/source/ElementsDockingWindow.cxx
+++ b/starmath/source/ElementsDockingWindow.cxx
@@ -527,7 +527,7 @@ namespace
 void SmElementsControl::addElement(const OUString& aElementVisual, const 
OUString& aElementSource, const OUString& aHelpText)
 {
 std::unique_ptr pNode = maParser->ParseExpression(aElementVisual);
-VclPtr pDevice(mpIconView->create_virtual_device());
+ScopedVclPtr pDevice(mpIconView->create_virtual_device());
 pDevice->SetMapMode(MapMode(SmMapUnit()));
 pDevice->SetDrawMode(DrawModeFlags::Default);
 pDevice->SetLayoutMode(vcl::text::ComplexTextLayoutFlags::Default);


[Libreoffice-bugs] [Bug 94660] ORDERING with Unicode order is not respected (sort dialogue and autofilter)

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=94660

Robert Lacroix  changed:

   What|Removed |Added

   Severity|minor   |normal

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 94660] ORDERING with Unicode order is not respected (sort dialogue and autofilter)

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=94660

--- Comment #5 from Robert Lacroix  ---
There is a bug here, but it's not what the OP thinks it is.
The bug is: autofilter overwrites the sort range's descriptor.

The OP wants the natural sort order, but that's not available through
autofilter. So we sort the range with options and then add Autofilter. The
problem is that Autofilter, when actually applied, overwrites the sort order
option set in the sort range's descriptor.

1) Open a new Calc document and enter the OP's data into a column of cells
along with a heading row of "data", but we scramble the data a bit to confirm
that the sort is happening.
Our cell contents are:
data
aaa2004
aaa_2006
aaa_2005

2) Select the range including the heading and sort it with options:
2a) Select the range including the title
2b) Choose Data menu > Sort...
2c) Choose Sort dialog Options tab
2d) Check "Range includes column labels"
2e) Check "Enable natural sort"
2f) Click OK

The data is now sorted as the OP wants. Our cell contents are:
data
aaa2004
aaa_2005
aaa_2006

3) With the range still selected, choose Data menu > Autofilter
Autofilter sees that the range has a column heading set by the sort range's
descriptor and does not ask whether to use the first row as a heading. This is
good. The range's heading cell now acquires the Autofilter dropdown menu
button, but nothing will happen to the data until the Autofilter option is
exercised, which we will do in step 5.

4) With the range still selected, confirm that sort options are still set.
2a) Choose Data menu > Sort...
2b) Choose Sort dialog Options tab
2c) See that the column labels and natural sort options are still checked
2d) Click Cancel

5) Sort the range using the Autofilter's dropdown menu button in the heading.
5a) Click the downward pointing triangle in the heading cell
5b) Click Sort Ascending

Notice that the data is now sorted as the OP's complains, not the natural
order.

6) With the heading row still selected, verify sort options once again.
6a) Choose Data menu > Sort...
6b) Choose Sort dialog Options tab
6c) See that the column label is still checked but the natural sort is now
unchecked.
2d) Click Cancel

Step 6 shows that the Autofilter sorting action overwrites the sort descriptor.
The Sort Ascending and Sort Descending UI buttons and corresponding menu
options are even more egregious, wiping out the entire sort descriptor
including the column heading. Is this by design? I think not.

As far as the default sort order, I find no fault in LO Calc's choice.

Unicode Technical Standard #10 UNICODE COLLATION ALGORITHM
https://www.unicode.org/reports/tr10/

declares as the basic principle:

"The position of characters in the Unicode code charts does not specify their
sort order."

The meaning of "Unicode order" is thus utterly ambiguous because code points
collate in different orders for different languages. However, taking the cue of
"unix ls" as the OP's desired sort order, the "Enable natural sort" option
should be selected by the OP. The default sort order used by LO is in fact the
start of the Unicode code set, where the first 127 characters copies the 7-bit
ASCII code: punctuation precedes digits which precedes alphabetic characters.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 141623] Qt5 refresh problem when starting LO start center and cairo (text) rendering ennabled

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141623

--- Comment #11 from samuelweaver  ---
It has been pushed to "libreoffice-7-1":

https://git.libreoffice.org/core/commit/3f204ca2fed7614e1e12180af5ce5bfd88249eb7/https://drift-hunters.io

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154591] I edit excel files and then save as 97-2003 Format and later when I open it backup it is completely empty. Frustrating to say the least

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154591

John  changed:

   What|Removed |Added

Summary|crashes |I edit excel files and then
   ||save as 97-2003 Format and
   ||later when I open it backup
   ||it is completely empty.
   ||Frustrating to say the
   ||least
 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

--- Comment #2 from John  ---
I ran in safe mode for awhile and it still happens.  Completely deleted
LibrOffice from PC and re-loaded 7.4.6.2   It still happens.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154852] The cell formula does not reflect the updated result

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154852

kenjfzh...@163.com changed:

   What|Removed |Added

Version|Inherited From OOo  |7.5.1.2 release

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154852] The cell formula does not reflect the updated result

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154852

--- Comment #6 from kenjfzh...@163.com ---
(In reply to Eike Rathke from comment #3)
> For this to work, the formula cell containing CELL() would have to listen at
> a sheet rename event. Which currently isn't broadcasted as a data change at
> all, and also shouldn't in general except for CELL() and probably INDIRECT().
> 
> The reference appears updated because it refers only to the sheet number and
> when being viewed that is resolved to the current name.

Hi, Eike, the cell() function is what I needed.
I use 'CELL("address",S1!$B$2)' in MS office, and it works fine, but it not
work right in libreoffice.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154852] The cell formula does not reflect the updated result

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154852

--- Comment #5 from kenjfzh...@163.com ---
(In reply to ady from comment #2)
> There is one detail that should be noted: The formula in the formula bar
> gets updated instantly without the need to force recalculate, so there is no
> problem there.
> 
> The CELL() function is considered volatile, depending on its arguments.

I tried to reset below formula again
,and I also checked the Data> Calculate> AutoCalculate is on
,and I confirmed that formula result is not be recalculated again.

formula :=  =CELL("address",S3.$B$2)
result := "$S2.$B$2"

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154852] The cell formula does not reflect the updated result

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154852

--- Comment #4 from kenjfzh...@163.com ---
(In reply to ady from comment #1)
> Just use the keyboard, either [F9] on the specific cell, or
> [CTRL]+[SHIFT]+[F9].
> 
> These are in menu Data > Calculate.
> 
> Unless someone could demonstrate that this was not happening with the CELL()
> function before (I have not checked), then this would probably end up being
> NAB.

Hi, ady,
Thanks for your tips.

What the cell formula does in my case, is to check the sheet name
automatically, this is a trick I've used in MS office for a long time, and I
would be very grateful for this approach in libreoffice.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154865] Enhancement: Eliminate duplicate Page settings in Properties deck of Sidebar

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154865

--- Comment #3 from Don Matschull  ---
(In reply to Stéphane Guillou (stragu) from comment #1)
> I could see that but the issue disappeared after I reset my user profile.
> You can do that by using Help > Restart in Safe Mode and using both options
> in "Reset to factory settings". (But keep in mind that you will lose any
> user customisation.)
> 
> However, it would be interesting to find steps that would make the issue
> reappear.
> Do you know how it started?
> Please also paste here the information copied from Help > About LibreOffice.

I restarted in Safe Mode which eliminated the duplicate page settings. I don't
know when or what happen to cause the duplicate.

I've attached an image of my About LibreOffice screen.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154865] Enhancement: Eliminate duplicate Page settings in Properties deck of Sidebar

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154865

--- Comment #2 from Don Matschull  ---
Created attachment 186748
  --> https://bugs.documentfoundation.org/attachment.cgi?id=186748=edit
About LibreOffice screen

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154874] Crash in LibreOffice Writer when typing real fast

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154874

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1
 CC||stephane.guillou@libreoffic
   ||e.org

--- Comment #1 from Stéphane Guillou (stragu) 
 ---
Please share your version information copied from Help > About LibreOffice.
Thank you!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154861] scalc crash on long scrolling (PageDown) ; Skia/Vulkan

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154861

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO
 CC||stephane.guillou@libreoffic
   ||e.org

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154865] Enhancement: Eliminate duplicate Page settings in Properties deck of Sidebar

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154865

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 OS|Windows (All)   |All
 CC||stephane.guillou@libreoffic
   ||e.org
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO

--- Comment #1 from Stéphane Guillou (stragu) 
 ---
I could see that but the issue disappeared after I reset my user profile.
You can do that by using Help > Restart in Safe Mode and using both options in
"Reset to factory settings". (But keep in mind that you will lose any user
customisation.)

However, it would be interesting to find steps that would make the issue
reappear.
Do you know how it started?
Please also paste here the information copied from Help > About LibreOffice.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154865] Enhancement: Eliminate duplicate Page settings in Properties deck of Sidebar

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154865

m.a.riosv  changed:

   What|Removed |Added

   Severity|normal  |enhancement

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sc/inc sc/qa sc/source

2023-04-17 Thread Maxim Monastirsky (via logerrit)
 sc/inc/postit.hxx   |4 +++-
 sc/qa/unit/subsequent_filters_test4.cxx |8 +++-
 sc/source/core/data/postit.cxx  |   14 ++
 sc/source/filter/xml/xmlcelli.cxx   |2 +-
 4 files changed, 21 insertions(+), 7 deletions(-)

New commits:
commit 0ee9501c0b7dc1a291715fff9c1934b1c08cb654
Author: Maxim Monastirsky 
AuthorDate: Thu Apr 13 18:57:26 2023 +0300
Commit: Maxim Monastirsky 
CommitDate: Tue Apr 18 01:57:24 2023 +0200

sc drawstyles: Assign the Note style to imported comments

... that don't have a style assignment. Typically in ods files
created by older versions or by 3rd party.

- For hidden comments this should make no difference, as we used
to apply the default comment formatting as DF underneath their
defined DF, just now we do that as a style assignment instead.

- Same for comments from xlsx and xls files.

- For visible comments from ods files created by OOo/LO, there
should be no difference either, as such files typically include
the shape formatting in them.

- For visible comments from ods files created by Excel, there
will be a difference, as Excel used to not include the full shape
formatting (known to be the case with Excel 2007 and 2016; can't
test any other version). This resulted with a weird look, e.g.
a line instead of an arrow, a default blue fill color and too
distant shadow, which clearly not how comments supposed to look.
Moreover, the comment will turn to transparent after hiding or
copying the cell, and will revert to the default look anyway
with resaving. Given that we were already enforcing the default
formatting for hidden comments and for foreign formats, I think
it's reasonable to do that for visible comments too (and in
general it's unclear to me why the ODF import treats visible
comments differently than hidden ones).

The main motivation of this change is to aid solving the shadow
issue - see the next commits.

Regarding the comment height change in the testCommentSize test:
This does *not* mean there is a change in that comment's import.
What this test does is to replace the existing comment with
a new comment, and that use the default formatting instead of
inheriting the formatting of the old one. But while the current
default formatting is whatever defined in the Note style, the old
default formatting was actually the draw pool defaults. This is
because we used to apply the comment formatting as DF, and the
relevant svx code (in SdrTextObj::NbcSetText) wasn't aware of the
fact that part of the DF was considered as default in this case.
Which means that this test was actually asserting a buggy behavior.

Change-Id: I37723cce3c719ecaa9c57bef25bcb168e353c55c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150489
Tested-by: Jenkins
Reviewed-by: Maxim Monastirsky 

diff --git a/sc/inc/postit.hxx b/sc/inc/postit.hxx
index 7da83a9ebea0..6b458ad41763 100644
--- a/sc/inc/postit.hxx
+++ b/sc/inc/postit.hxx
@@ -193,6 +193,8 @@ public:
 The underlying ScPostIt::ScNoteData::ScCaptionPtr takes managing
 ownership of the pointer.
 
+@param bHasStyle  Is there a drawing style set for the note.
+
 @return  Pointer to the new cell note object if insertion was
 successful (i.e. the passed cell position was valid), null
 otherwise. The Calc document is the owner of the note object. The
@@ -201,7 +203,7 @@ public:
  */
 static ScPostIt*CreateNoteFromCaption(
 ScDocument& rDoc, const ScAddress& rPos,
-SdrCaptionObj* pCaption );
+SdrCaptionObj* pCaption, bool bHasStyle );
 
 /** Creates a cell note based on the passed caption object data.
 
diff --git a/sc/qa/unit/subsequent_filters_test4.cxx 
b/sc/qa/unit/subsequent_filters_test4.cxx
index 06af93de19d9..c439a02c6582 100644
--- a/sc/qa/unit/subsequent_filters_test4.cxx
+++ b/sc/qa/unit/subsequent_filters_test4.cxx
@@ -45,6 +45,8 @@
 #include 
 #include 
 #include 
+#include 
+#include 
 
 #include 
 #include 
@@ -1580,6 +1582,10 @@ CPPUNIT_TEST_FIXTURE(ScFiltersTest4, testCommentSize)
 SdrCaptionObj* pCaption = pNote->GetCaption();
 CPPUNIT_ASSERT(pCaption);
 
+// The values below depend on particular font and char size.
+// At least assert that the corresponding style was set:
+CPPUNIT_ASSERT_EQUAL(ScResId(STR_STYLENAME_NOTE), 
pCaption->GetStyleSheet()->GetName());
+
 const tools::Rectangle& rOldRect = pCaption->GetLogicRect();
 CPPUNIT_ASSERT_EQUAL(tools::Long(2899), rOldRect.getOpenWidth());
 CPPUNIT_ASSERT_EQUAL(tools::Long(939), rOldRect.getOpenHeight());
@@ -1588,7 +1594,7 @@ CPPUNIT_TEST_FIXTURE(ScFiltersTest4, testCommentSize)
 
 const tools::Rectangle& rNewRect = 

[Libreoffice-commits] core.git: sc/qa sc/source

2023-04-17 Thread Maxim Monastirsky (via logerrit)
 sc/qa/unit/subsequent_export_test4.cxx |   16 +++-
 sc/source/filter/excel/xlroot.cxx  |1 +
 2 files changed, 16 insertions(+), 1 deletion(-)

New commits:
commit 86cbbbccba19ba0433693e3e5c59c67e9dc6a003
Author: Maxim Monastirsky 
AuthorDate: Fri Apr 14 02:19:44 2023 +0300
Commit: Maxim Monastirsky 
CommitDate: Tue Apr 18 01:56:31 2023 +0200

sc drawstyles: Fix xlsx export for text attributes in comments

Change-Id: Ic5b6099460bd5e978c04aff3233537059ce711b9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150379
Tested-by: Jenkins
Reviewed-by: Maxim Monastirsky 

diff --git a/sc/qa/unit/subsequent_export_test4.cxx 
b/sc/qa/unit/subsequent_export_test4.cxx
index 5d629e83eb4a..663767c7374f 100644
--- a/sc/qa/unit/subsequent_export_test4.cxx
+++ b/sc/qa/unit/subsequent_export_test4.cxx
@@ -1583,7 +1583,21 @@ CPPUNIT_TEST_FIXTURE(ScExportTest4, testCommentStyles)
 
 // Check that the style was imported, and survived copying
 CPPUNIT_ASSERT_EQUAL(OUString("MyStyle1"), 
pCaption->GetStyleSheet()->GetName());
-// Check that the style formatting is in effect
+}
+
+saveAndReload("Calc Office Open XML");
+
+{
+ScDocument* pDoc = getScDoc();
+
+ScAddress aPos(0, 0, 0);
+ScPostIt* pNote = pDoc->GetNote(aPos);
+CPPUNIT_ASSERT(pNote);
+
+auto pCaption = pNote->GetOrCreateCaption(aPos);
+CPPUNIT_ASSERT(pCaption);
+
+// Check that the style formatting is preserved
 CPPUNIT_ASSERT_EQUAL(sal_uInt32(1129),
  
pCaption->GetMergedItemSet().Get(EE_CHAR_FONTHEIGHT).GetHeight());
 }
diff --git a/sc/source/filter/excel/xlroot.cxx 
b/sc/source/filter/excel/xlroot.cxx
index 47f5ff7806c1..71d308d2f29c 100644
--- a/sc/source/filter/excel/xlroot.cxx
+++ b/sc/source/filter/excel/xlroot.cxx
@@ -408,6 +408,7 @@ EditEngine& XclRoot::GetDrawEditEngine() const
 {
 mrData.mxDrawEditEng = std::make_shared( 
().GetDrawLayer()->GetItemPool() );
 EditEngine& rEE = *mrData.mxDrawEditEng;
+
rEE.SetStyleSheetPool(static_cast(GetDoc().GetDrawLayer()->GetStyleSheetPool()));
 rEE.SetRefMapMode(MapMode(MapUnit::Map100thMM));
 rEE.SetUpdateLayout( false );
 rEE.EnableUndo( false );


[Libreoffice-bugs] [Bug 154830] Fileopen takes too long to open an existing small file.

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154830

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #7 from m.a.riosv  ---
No delay
Version: 7.5.3.1 (X86_64) / LibreOffice Community
Build ID: d29ee673721b12c92b3de9b9663473211414f0db
CPU threads: 16; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: en-US Calc: CL threaded

Maybe some network printer installed, not available.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154867] Enhancement Eliminate unnecessary Object settings in Properties deck of Sidebar

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154867

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Resolution|--- |NOTABUG
 Status|UNCONFIRMED |RESOLVED
 CC||stephane.guillou@libreoffic
   ||e.org

--- Comment #3 from Stéphane Guillou (stragu) 
 ---
On top of what Regina pointed out, the sections related to text are relevant to
text written in the shape (as explained in bug 154866), so they should stay
visible if the user wants to change settings before writing text.

However, while testing, I noticed other issues and reported bug 154870 and bug
154875.

Closing this one as "not a bug".

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 107580] [META] Area content panel of the Properties deck/tab of the sidebar

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107580

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||154875


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=154875
[Bug 154875] "Use slide background" area fill keeps coming back in sidebar,
transparency slider gone
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151188] Area-Fill color in Sidebar is not selected on click on the 1st element

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151188

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||4875

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154875] New: "Use slide background" area fill keeps coming back in sidebar, transparency slider gone

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154875

Bug ID: 154875
   Summary: "Use slide background" area fill keeps coming back in
sidebar, transparency slider gone
   Product: LibreOffice
   Version: 7.4.4.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Keywords: bibisected, bisected, regression
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: stephane.guil...@libreoffice.org
CC: samuel.mehrbr...@allotropia.de
Blocks: 107580

Steps to reproduce:
1. Open Draw or Writer
2. Insert a shape
3. Set area fill to "Use Slide Background" in sidebar
4. Set it back to "Color"

Result: sidebar's transparency slider is gone. Clicking out of the shape and
selecting it again makes the setting go back to "Use Slide Background", even
though Color is still active on canvas.

In:

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 1b06f35de68a555b85bceb5fc29d1a5f426f4bb7
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: fr-FR (fr_FR.UTF-8); UI: en-US
Calc: threaded

Bibisected with linux-64-7.4 repo to first bad commit
478fd06265ded7669db2ff092db37513de528270 which points to core commit
8f0d52d122024d1ed0bd5f59d36e3ade5b7b5629 which is a cherrypick of:

commit  490c2fc6080aa652b9b31385517aaf536f5bbd57
author  Samuel MehrbrodtThu Nov 03
10:56:47 2022 +0100
committer   Samuel MehrbrodtThu Nov
03 14:22:42 2022 +0100
tdf#151174 Hide transparency widgets when not needed
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142221

Samuel, can you please have a look?


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107580
[Bug 107580] [META] Area content panel of the Properties deck/tab of the
sidebar
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154820] Pasting a cell from Excel changes the default cell style

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154820

m.a.riosv  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||miguelangelrv@libreoffice.o
   ||rg
 Status|UNCONFIRMED |NEW

--- Comment #1 from m.a.riosv  ---
Reproducible
Version: 7.5.3.1 (X86_64) / LibreOffice Community
Build ID: d29ee673721b12c92b3de9b9663473211414f0db
CPU threads: 16; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: en-US Calc: CL threaded
Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 96c4c0fcffc4f0a1f5a49be576646d15d613228e
CPU threads: 16; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: en-US Calc: CL threaded Jumbo

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154717] Drop one note and revise the other in the "Refer using" section of Cross-references

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154717

sdc.bla...@youmail.dk changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |sdc.bla...@youmail.dk
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154874] New: Crash in LibreOffice Writer when typing real fast

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154874

Bug ID: 154874
   Summary: Crash in LibreOffice Writer when typing real fast
   Product: LibreOffice
   Version: unspecified
  Hardware: IA64 (Itanium)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: gdehuff...@gmail.com

Description:
1) I am not using the HTML editor.
2) I had annoying crashes with a 600+Kb LibreOffice Writer document but, it
wasn't too frequent so I lived with it for years.
3) Then it became very annoying so I split the document into two ~ 300Kb
documents to see if that would eliminate the problem - it didn't help and, if
anything, it happened sometimes only a few minutes apart and at least once a
day which was a lot worse than before the split.
4) After several totally unacceptably frequent occurrences where recovery
didn't pick up what had been typed in a very short interval, it finally dawned
on me that the crashes were happening when I typed very fast on a word or a
short sequence of words whose letters were configured on the keyboard in such a
way that I could type them much faster than most words.
5) in the two days since I've slowed my typing down, I haven't had a single
crash.  that is a big improvement.

In case it helps, I am running Windows 10 Pro (64 bit)'s latest update on a
very fast 8 core Intel i7-10875H processor in a Dell XPS 1700, laptop with a
9700Bios that stays upgraded when Dell releases a new update, 16MB Cache, 32GB
(2x16G) DDR4-293MHZ Ram with NVIDIA graphics (GeForce RTX 2060 6GB GDDr6 with
Max Q)

Gil DeHuff

Steps to Reproduce:
1.the crashes were happening when I typed very fast on a word or a short
sequence of words whose letters were configured on the keyboard in such a way
that I could type them much faster than most words.
2.
3.

Actual Results:
crash

Expected Results:
no crash


Reproducible: Always


User Profile Reset: No

Additional Info:
not sure about Itanium64 hardware or version # but it is the latest update.  It
is automatically updated by Microsoft early in their release schedule.

This is what I do know for certain about my system:
In case it helps, I am running Windows 10 Pro (64 bit)'s latest update on a
very fast 8 core Intel i7-10875H processor in a Dell XPS 1700, laptop with a
9700Bios that stays upgraded when Dell releases a new update, 16MB Cache, 32GB
(2x16G) DDR4-293MHZ Ram with NVIDIA graphics (GeForce RTX 2060 6GB GDDr6 with
Max Q)

Don't see any need to reset my user profile since it doesn't happen unless I
type too fast for the I/O channels

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sd/source

2023-04-17 Thread Bayram Çiçek (via logerrit)
 sd/source/ui/func/futext.cxx |  104 +--
 sd/source/ui/inc/futext.hxx  |1 
 2 files changed, 22 insertions(+), 83 deletions(-)

New commits:
commit 059f1e8f291404addeba9341d2c4989976af
Author: Bayram Çiçek 
AuthorDate: Fri Apr 14 00:34:52 2023 +0300
Commit: Maxim Monastirsky 
CommitDate: Tue Apr 18 01:18:57 2023 +0200

tdf#90253: Impress: make TextBox retain its height

- [Impress] drawing a new Text Box and Vertical Text
minimize itself to the height of one line.

- This behavior has changed and inserting a
new TextBox/VerticalText does not shrink itself to
height of one line.

- Unified some common Draw and Impress codes

- removed unnecessary ImpSetAttributesFitCommon(pText)
function, as ImpSetAttributesForNewTextObject(pText)
takes care of the Text Box creations.

- SID_ATTR_CHAR (.uno:Text)
- SID_ATTR_CHAR_VERTICAL (.uno:VerticalText)

Change-Id: Ia944c2b64d5b1fa6970f6afabf41d36bf1643efa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150377
Tested-by: Jenkins
Reviewed-by: Maxim Monastirsky 

diff --git a/sd/source/ui/func/futext.cxx b/sd/source/ui/func/futext.cxx
index 60e36e2674b3..f01851668f76 100644
--- a/sd/source/ui/func/futext.cxx
+++ b/sd/source/ui/func/futext.cxx
@@ -509,59 +509,34 @@ bool FuText::MouseMove(const MouseEvent& rMEvt)
 
 void FuText::ImpSetAttributesForNewTextObject(SdrTextObj* pTxtObj)
 {
-if(mpDoc->GetDocumentType() == DocumentType::Impress)
+if( nSlotId == SID_ATTR_CHAR )
 {
-if( nSlotId == SID_ATTR_CHAR )
-{
-/* Create Impress text object (rescales to line height)
-   We get the correct height during the subsequent creation of the
-   object, otherwise we draw too much */
-SfxItemSet aSet(mpViewShell->GetPool());
-aSet.Put(makeSdrTextMinFrameHeightItem(0));
-aSet.Put(makeSdrTextAutoGrowWidthItem(false));
-aSet.Put(makeSdrTextAutoGrowHeightItem(true));
-pTxtObj->SetMergedItemSet(aSet);
-pTxtObj->AdjustTextFrameWidthAndHeight();
-
aSet.Put(makeSdrTextMaxFrameHeightItem(pTxtObj->GetLogicRect().GetSize().Height()));
-pTxtObj->SetMergedItemSet(aSet);
-const SfxViewShell* pCurrentViewShell = SfxViewShell::Current();
-if (pCurrentViewShell && (pCurrentViewShell->isLOKMobilePhone() || 
pCurrentViewShell->isLOKTablet()))
-pTxtObj->SetText(SdResId(STR_PRESOBJ_TEXT_EDIT_MOBILE));
-}
-else if( nSlotId == SID_ATTR_CHAR_VERTICAL )
-{
-SfxItemSet aSet(mpViewShell->GetPool());
-aSet.Put(makeSdrTextMinFrameWidthItem(0));
-aSet.Put(makeSdrTextAutoGrowWidthItem(true));
-aSet.Put(makeSdrTextAutoGrowHeightItem(false));
-
-// Needs to be set since default is SDRTEXTHORZADJUST_BLOCK
-aSet.Put(SdrTextHorzAdjustItem(SDRTEXTHORZADJUST_RIGHT));
-pTxtObj->SetMergedItemSet(aSet);
-pTxtObj->AdjustTextFrameWidthAndHeight();
-
aSet.Put(makeSdrTextMaxFrameWidthItem(pTxtObj->GetLogicRect().GetSize().Width()));
-pTxtObj->SetMergedItemSet(aSet);
-}
+SfxItemSet aSet(mpViewShell->GetPool());
+aSet.Put(makeSdrTextAutoGrowWidthItem(false));
+aSet.Put(makeSdrTextAutoGrowHeightItem(true));
+pTxtObj->SetMergedItemSet(aSet);
+pTxtObj->AdjustTextFrameWidthAndHeight();
+const SfxViewShell* pCurrentViewShell = SfxViewShell::Current();
+if (pCurrentViewShell && (pCurrentViewShell->isLOKMobilePhone() || 
pCurrentViewShell->isLOKTablet()))
+pTxtObj->SetText(SdResId(STR_PRESOBJ_TEXT_EDIT_MOBILE));
 }
-else
+else if( nSlotId == SID_ATTR_CHAR_VERTICAL )
 {
-if( nSlotId == SID_ATTR_CHAR_VERTICAL )
-{
-// draw text object, needs to be initialized when vertical text is 
used
-SfxItemSet aSet(mpViewShell->GetPool());
+// draw text object, needs to be initialized when vertical text is used
+SfxItemSet aSet(mpViewShell->GetPool());
 
-aSet.Put(makeSdrTextAutoGrowWidthItem(true));
-aSet.Put(makeSdrTextAutoGrowHeightItem(false));
+aSet.Put(makeSdrTextAutoGrowWidthItem(true));
+aSet.Put(makeSdrTextAutoGrowHeightItem(false));
 
-// Set defaults for vertical click-n'drag text object, pool 
defaults are:
-// SdrTextVertAdjustItem: SDRTEXTVERTADJUST_TOP
-// SdrTextHorzAdjustItem: SDRTEXTHORZADJUST_BLOCK
-// Analog to that:
-aSet.Put(SdrTextVertAdjustItem(SDRTEXTVERTADJUST_BLOCK));
-aSet.Put(SdrTextHorzAdjustItem(SDRTEXTHORZADJUST_RIGHT));
+// Set defaults for vertical click-n'drag text object, pool defaults 
are:
+// SdrTextVertAdjustItem: SDRTEXTVERTADJUST_TOP
+// 

[Libreoffice-bugs] [Bug 143571] leftover coloured selection rectangle remains after particular undo/redo sequence related to table insertion

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143571

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=12 |
   |0678|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 117780] Blue textbox background when pasting sheets from clipboard using templates

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=117780

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||0678

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154852] The cell formula does not reflect the updated result

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154852

Eike Rathke  changed:

   What|Removed |Added

 CC||er...@redhat.com
   Hardware|x86-64 (AMD64)  |All
Version|7.5.1.2 release |Inherited From OOo
 Ever confirmed|0   |1
 OS|Windows (All)   |All
 Status|UNCONFIRMED |NEW

--- Comment #3 from Eike Rathke  ---
For this to work, the formula cell containing CELL() would have to listen at a
sheet rename event. Which currently isn't broadcasted as a data change at all,
and also shouldn't in general except for CELL() and probably INDIRECT().

The reference appears updated because it refers only to the sheet number and
when being viewed that is resolved to the current name.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 141817] Blue square after undo table in Impress

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141817

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=12 |
   |0678|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 120678] Blue image background after undo/redo of a slide paste

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120678

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |https://bugs.documentfounda
   |tion.org/show_bug.cgi?id=14 |tion.org/show_bug.cgi?id=11
   |1817,   |7780
   |https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=14 |
   |3571|

--- Comment #6 from Stéphane Guillou (stragu) 
 ---
Still repro in:

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 1b06f35de68a555b85bceb5fc29d1a5f426f4bb7
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: fr-FR (fr_FR.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 140522] Using Keypad Entry Fills Many Pages With The Selected Number

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=140522

--- Comment #7 from miguel  ---
What fixed the error for me was installing a new version of KeyScrambler
protection software.  I found on the KeyScrambler forums that the repeating
numbers issue was due to a bug in the KeyScrambler software.  QFX pointed me to
an updated version; I installed; and the bug went away.  Thankfully.

I too had to use OpenOffice.  Most of the time I use OpenOffice, due to other
issues with LibreOffice.  I use Libreoffice occasionally, if I have some issue
with a Microsoft document (latest MS versions).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103394] Can't undo impress background change from sidebar

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103394

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||stephane.guillou@libreoffic
   ||e.org
 Blocks||112602
Summary|Can't undo impress  |Can't undo impress
   |background color change |background change from
   ||sidebar

--- Comment #7 from Stéphane Guillou (stragu) 
 ---
Still repro in:

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 1b06f35de68a555b85bceb5fc29d1a5f426f4bb7
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: fr-FR (fr_FR.UTF-8); UI: en-US
Calc: threaded


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=112602
[Bug 112602] [META] Slide Layouts content panel of the Properties deck/tab of
the sidebar
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 112602] [META] Slide Layouts content panel of the Properties deck/tab of the sidebar

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=112602

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||103394


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103394
[Bug 103394] Can't undo impress background change from sidebar
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sc/qa sc/source

2023-04-17 Thread Maxim Monastirsky (via logerrit)
 sc/qa/unit/subsequent_export_test4.cxx |   13 ++
 sc/qa/unit/ucalc.cxx   |   18 
 sc/source/core/data/document.cxx   |7 -
 sc/source/core/data/drwlayer.cxx   |   59 +
 sc/source/core/data/postit.cxx |   63 --
 sc/source/core/tool/detfunc.cxx|  147 -
 sc/source/core/tool/stylehelper.cxx|1 
 7 files changed, 130 insertions(+), 178 deletions(-)

New commits:
commit 3e4b8463f288d87f91cd5bc864d30ae02d4f5579
Author: Maxim Monastirsky 
AuthorDate: Mon Apr 10 00:38:33 2023 +0300
Commit: Maxim Monastirsky 
CommitDate: Tue Apr 18 01:09:21 2023 +0200

sc drawstyles: Maintain comment formatting with styles

Up to now the look of comments was maintained with the comment
shape's DF, with the default formatting being reapplied on
import (for hidden comments), on changing Tools > Options... >
LibreOffice > AC > Notes background, and on changing the
default cell style, while keeping the user-applied DF to some
extent. However, as we attempt to support drawing styles, this
approach is no longer viable, as applying DF on top of styles
at random times makes styles useless in the context of
comments.

(One might argue, that the look of comments should ideally be
treated as an app view setting, and not as a formatting of an
individual shape. This definitely makes sense, but has compat.
implications, as both LO and Excel allow formatting individual
comments (e.g. show a comment, right click > Area...). However
we will probably do it anyway if we ever implement threaded
comments like in recent Excel [1], as the callout shape based
approach seems to not scale to it.)

One way around it could be to explicitly disable any style
interaction with comments. But this will be unfortunate, as
styles have a clear advantage of being able to consistently
maintain the same formatting for several elements, much more
that the fragile approach of mixing the default formatting and
user-applied formatting in the same formatting layer. Not to
mention the possibility to define several custom styles. In
addition there is a request in tdf#55682 to disconnect the
formatting of comments from the default cell style, having a
dedicated style instead, which I find reasonable.

So this commit introduces a comment style, and uses it for new
comments instead of DF, making it easy to format all comments at
once. And a style based formatting is never overriden with DF,
unless explicitly set by the user. Changing Tools > Options... >
LibreOffice > AC > Notes background still has an effect in two
ways: (1) Sets the default background of the comment style for new
documents, and (2) if changed while a document is open, changes
also the comment style of the current document. An undo action
is also added, in case changing the current document wasn't
deliberate. Changing the default cell style no longer has any
effect on comment formatting.

One unfortunate side effect of this change, is that newly
created and permanently visible comments will lose their
default look when opened in an older version. But there is not
much I can do here, as older versions don't support styles, and
I believe the advantage of using styles outweigh this concern.
Hidden comments are not affected by this.

[1] see 
https://support.microsoft.com/en-us/office/the-difference-between-threaded-comments-and-notes-75a51eec-4092-42ab-abf8-7669077b7be3

Change-Id: I84215791b9e6ce393c6d979aa2b19ef70c76dff9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150352
Tested-by: Jenkins
Reviewed-by: Maxim Monastirsky 

diff --git a/sc/qa/unit/subsequent_export_test4.cxx 
b/sc/qa/unit/subsequent_export_test4.cxx
index 9d6e38ef8a09..5d629e83eb4a 100644
--- a/sc/qa/unit/subsequent_export_test4.cxx
+++ b/sc/qa/unit/subsequent_export_test4.cxx
@@ -26,6 +26,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -1553,12 +1554,14 @@ CPPUNIT_TEST_FIXTURE(ScExportTest4, testCommentStyles)
 ScPostIt* pNote = pDoc->GetNote(aPos);
 CPPUNIT_ASSERT(pNote);
 
-pNote->ShowCaption(aPos, true);
 auto pCaption = pNote->GetCaption();
 CPPUNIT_ASSERT(pCaption);
 
 auto pStyleSheet = >GetStyleSheetPool()->Make("MyStyle1", 
SfxStyleFamily::Frame);
-pCaption->SetStyleSheet(static_cast(pStyleSheet), 
true);
+auto& rSet = pStyleSheet->GetItemSet();
+rSet.Put(SvxFontHeightItem(1129, 100, EE_CHAR_FONTHEIGHT));
+
+pCaption->SetStyleSheet(static_cast(pStyleSheet), 
false);
 
 // Hidden comments use different code path on import
 pNote->ShowCaption(aPos, false);
@@ -1575,12 +1578,14 @@ CPPUNIT_TEST_FIXTURE(ScExportTest4, testCommentStyles)
 ScPostIt* pNote = 

[Libreoffice-bugs] [Bug 154867] Enhancement Eliminate unnecessary Object settings in Properties deck of Sidebar

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154867

--- Comment #2 from Don Matschull  ---
(In reply to Regina Henschel from comment #1)
> The "Cap style" is not only used for the ends of a line but for dashes and
> dots as well. So even closed shapes need it for the case their outline is
> dashed.

Thank you. I had not seen that information anywhere before. I now see where
this can be useful and should be available.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 141817] Blue square after undo table in Impress

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141817

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Resolution|WORKSFORME  |DUPLICATE

--- Comment #6 from Stéphane Guillou (stragu) 
 ---
Rectangle colour is the selection colour of the desktop environment.

(In reply to Telesto from comment #5)
> No repro (and no active memory if the STR is lacking something) 
> Version: 7.2.0.0.alpha1+ (x64) / LibreOffice Community
> Build ID: 05366b8e6683363688de8708a3d88cf144c7a2bf
> CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
> Locale: nl-NL (nl_NL); UI: nl-NL
> Calc: CL

Build includes the commit that fixed bug 112067.

*** This bug has been marked as a duplicate of bug 112067 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 112067] EDITING: A residual colored rectangle appears on all slides after a specific undo/redo table operation

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=112067

--- Comment #8 from Stéphane Guillou (stragu) 
 ---
*** Bug 141817 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 120678] Blue image background after undo/redo of a slide paste

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120678

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||9799

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 117780] Blue textbox background when pasting sheets from clipboard using templates

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=117780

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||9799

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 119799] Table becomes blue if it's pasted 2 times in a row

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=119799

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Blocks||102593
 CC||stephane.guillou@libreoffic
   ||e.org
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||7780,
   ||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||0678
Version|4.1 all versions|Inherited From OOo

--- Comment #4 from Stéphane Guillou (stragu) 
 ---
Still repro in:

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 1b06f35de68a555b85bceb5fc29d1a5f426f4bb7
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: fr-FR (fr_FR.UTF-8); UI: en-US
Calc: threaded

Already in OOo 3.3, so inherited.

Very similar to bug 117780.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=102593
[Bug 102593] [META] Paste bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 102593] [META] Paste bugs and enhancements

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=102593

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||119799


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=119799
[Bug 119799] Table becomes blue if it's pasted 2 times in a row
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 112067] EDITING: A residual colored rectangle appears on all slides after a specific undo/redo table operation

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=112067

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||3571

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 105948] [META] Undo/Redo bugs and enhancements

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105948

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||143571


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=143571
[Bug 143571] leftover coloured selection rectangle remains after particular
undo/redo sequence related to table insertion
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143571] leftover coloured selection rectangle remains after particular undo/redo sequence related to table insertion

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143571

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||mark...@gmail.com,
   ||stephane.guillou@libreoffic
   ||e.org
   Priority|medium  |low
 Blocks||100366, 105948
Version|7.3.0.0 alpha0+ |7.0.6.2 release
   Severity|normal  |minor
Summary|Blue square after   |leftover coloured selection
   |particular undo/redo|rectangle remains after
   |sequence related to table   |particular undo/redo
   |insertion   |sequence related to table
   ||insertion
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||2067

--- Comment #6 from Stéphane Guillou (stragu) 
 ---
This is very similar to the resolved bug 112067.

The colour of the rectangle depends on the selection colour of your desktop
environment, it's orange for me on Ubuntu 20.04 with GNOME 3.36.8.
It is persistent when switching slides. A file reload makes it disappear.

Still reproducible in:

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 1b06f35de68a555b85bceb5fc29d1a5f426f4bb7
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: fr-FR (fr_FR.UTF-8); UI: en-US
Calc: threaded

Also in 7.0.

Started with core commit f3f7cc53efda828af8897fa45fa2a8f18cf3b48b which was a
fix for crash bug 136956. Not marking as regression as it was crashing on first
Ctrl + Z previously, but copying Mark in just in case he has ideas.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=100366
[Bug 100366] [META] Impress/Draw table bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=105948
[Bug 105948] [META] Undo/Redo bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 100366] [META] Impress/Draw table bugs and enhancements

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=100366

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||143571


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=143571
[Bug 143571] leftover coloured selection rectangle remains after particular
undo/redo sequence related to table insertion
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 48534] EDITING: No footnotes possible in frames including figure captions

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=48534

--- Comment #18 from john.m.ast...@verizon.net ---
This bug is still present in as of 2023!
Version: 7.5.1.2 (X86_64) / LibreOffice Community
Build ID: fcbaee479e84c6cd81291587d2ee68cba099e129
CPU threads: 20; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded

The structure of my document requires me to use captions for photographs, but I
also need to footnote the sources of the photographs. I've done hours of work
until I encountered this problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154873] The Random Number Generator dialog should allow the user to inform the number of rows and columns to be generated

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154873

Eike Rathke  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #1 from Eike Rathke  ---
Shift+Ctrl+T A1:AX1 Enter
50x1 range gets selected ;-)

But yeah..

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154745] Basic Dialogues: Runtime Appearance differs from Editor (spin buttons, dropdown list) on Linux

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154745

--- Comment #5 from Kai Struck  ---
Thanks for testing.
It worked ok with LO 4.4.7.2 on Lubuntu. 
This is when I created these extensions:
https://extensions.libreoffice.org/en/extensions/show/change-multiple-images-in-writer-pictool
https://extensions.libreoffice.org/en/extensions/show/chorddiagrams
https://extensions.libreoffice.org/en/extensions/show/chordtransposer

and a lot more of dialogues for this project:
http://struckkai.blogspot.de/2015/04/libreofficesongbookarchitect.html

All these are nowadays only usable on Windows and broken on Linux (although
they look ok in the Editor on the Linux Versions!!!)

So I'm asking for a solution to make the dialogues appear the same as they are
constucted in the Editor.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 117780] Blue textbox background when pasting sheets from clipboard using templates

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=117780

--- Comment #5 from Stéphane Guillou (stragu) 
 ---
Created attachment 186747
  --> https://bugs.documentfoundation.org/attachment.cgi?id=186747=edit
test file using Classy Red template

Still reproducible in:

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 1b06f35de68a555b85bceb5fc29d1a5f426f4bb7
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: fr-FR (fr_FR.UTF-8); UI: en-US
Calc: threaded

As the "Classy Red" template is not available anymore, here's a blank
presentation that uses it, to test.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154871] ROUNDDOWN returns invalid results when working with larger numbers

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154871

Eike Rathke  changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 125577] EDITING: Impress: Background image turns to solid blue when editing Master Slide

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125577

--- Comment #9 from Stéphane Guillou (stragu) 
 ---
Reproduced with recent master build:

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 1b06f35de68a555b85bceb5fc29d1a5f426f4bb7
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: fr-FR (fr_FR.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

  1   2   3   4   5   6   >