[Libreoffice-bugs] [Bug 154958] Why does Format | Paragraph | Proportional default to 6% ?
https://bugs.documentfoundation.org/show_bug.cgi?id=154958 Robert Großkopf changed: What|Removed |Added CC||rob...@familiegrosskopf.de --- Comment #1 from Robert Großkopf --- Have tested this: Opened a new Writer document. Go to paragraph. Set Line Spacing → Proportional. '100%' will appear here. So I couldn't see 6% as reported. Tested with Version: 7.5.2.2 (X86_64) / LibreOffice Community Build ID: 53bb9681a964705cf672590721dbc85eb4d0c3a2 CPU threads: 6; OS: Linux 5.14; UI render: default; VCL: kf5 (cairo+xcb) Locale: de-DE (de_DE.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142124] In FORMATTING (Styles) there is NO VERTICAL ALIGNMENT option for table rows
https://bugs.documentfoundation.org/show_bug.cgi?id=142124 Robert Großkopf changed: What|Removed |Added CC||rob...@familiegrosskopf.de --- Comment #3 from Robert Großkopf --- Vertical alignment is only available for cells in tables. So it is hard coded and not available as a template for a paragraph. How should vertical alignment work in a normal paragraph? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 50626] EDITING: Query on Mac OS X Addressbook doesn't display data for fields other than CHAR datatype
https://bugs.documentfoundation.org/show_bug.cgi?id=50626 --- Comment #26 from Robert Großkopf --- Couldn't say anything about this bug. Have only written the bug description for another person. No Mac available here… -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154962] work session files, opening and re-opening working sessions with all documents
https://bugs.documentfoundation.org/show_bug.cgi?id=154962 --- Comment #2 from peter josvai --- +1 to "Windows" menu: perhaps, for a beginning, a "send file list to clipboard" could be introduced... and we could save the list in a document as a session organizer document ... and in that list, file-links would be present -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154962] work session files, opening and re-opening working sessions with all documents
https://bugs.documentfoundation.org/show_bug.cgi?id=154962 --- Comment #1 from peter josvai --- the approach could start with the "windows" menu... where we see all the open documents there could be perhaps a "create session" menu item... and the session could be set as "autosave" or "persistent" (just making up words :)) - - documents being linked in session files / session documents / session navigators would have their session(s) listed in properties window... one main session and many possible others - - Navigator could be the place where sessions could be handled, edited.. BUT recently used windows in the "starting menu" too offer this possibility perhaps... and session files / session documents / session organizers could be made of normal documents... but could later on saved as session organizers perhaps with their own extension +1, one other possible starting point could be, where this concept already exists is the "restore documents" window and "system" just sketchy ideas... we'll see if others join in :) for a beginning I'd be happy if I could easily copy a document's hard link (local relative/absolute link in the file system)... into a collector document... as clickable links... -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154962] work session files, opening and re-opening working sessions with all documents
https://bugs.documentfoundation.org/show_bug.cgi?id=154962 peter josvai changed: What|Removed |Added Summary|project files, opening |work session files, opening |projects with all the files |and re-opening working ||sessions with all documents -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142124] In FORMATTING (Styles) there is NO VERTICAL ALIGNMENT option for table rows
https://bugs.documentfoundation.org/show_bug.cgi?id=142124 BogdanB changed: What|Removed |Added CC||buzea.bog...@libreoffice.or ||g Ever confirmed|1 |0 Status|NEW |UNCONFIRMED --- Comment #2 from BogdanB --- You can not confirm your own bug. Please wait others to confirm it. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 115930] [META] Adding and deleting cells / rows / columns
https://bugs.documentfoundation.org/show_bug.cgi?id=115930 BogdanB changed: What|Removed |Added Depends on||139365 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=139365 [Bug 139365] Table>insert Rows should move the cursor to the new row -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139365] Table>insert Rows should move the cursor to the new row
https://bugs.documentfoundation.org/show_bug.cgi?id=139365 BogdanB changed: What|Removed |Added Summary|Table>insert Rows should|Table>insert Rows should |move the cursor to the new |move the cursor to the new |row.|row Blocks||115930 CC||buzea.bog...@libreoffice.or ||g Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=115930 [Bug 115930] [META] Adding and deleting cells / rows / columns -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 102847] [META] Quick Find, Search and Replace
https://bugs.documentfoundation.org/show_bug.cgi?id=102847 BogdanB changed: What|Removed |Added Depends on||138781 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=138781 [Bug 138781] FIND & REPLACE DIALOG: Write cannot find empty paragraphs in a table (== empty cells). -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 138781] FIND & REPLACE DIALOG: Write cannot find empty paragraphs in a table (== empty cells).
https://bugs.documentfoundation.org/show_bug.cgi?id=138781 BogdanB changed: What|Removed |Added CC||buzea.bog...@libreoffice.or ||g Blocks||102847 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=102847 [Bug 102847] [META] Quick Find, Search and Replace -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143002] [META] Tracked Changes of tables
https://bugs.documentfoundation.org/show_bug.cgi?id=143002 BogdanB changed: What|Removed |Added Depends on||150673 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=150673 [Bug 150673] Track changes doesn't record deletion of a table column (only rows) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150673] Track changes doesn't record deletion of a table column (only rows)
https://bugs.documentfoundation.org/show_bug.cgi?id=150673 BogdanB changed: What|Removed |Added Blocks||143002 CC||buzea.bog...@libreoffice.or ||g Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=143002 [Bug 143002] [META] Tracked Changes of tables -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 107200] [META] Writer table and cell selection issues
https://bugs.documentfoundation.org/show_bug.cgi?id=107200 BogdanB changed: What|Removed |Added Depends on||151840 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=151840 [Bug 151840] API: Text Table Cursor has no notion of row and columns, and no sane way to loop through the selection -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151840] API: Text Table Cursor has no notion of row and columns, and no sane way to loop through the selection
https://bugs.documentfoundation.org/show_bug.cgi?id=151840 BogdanB changed: What|Removed |Added CC||buzea.bog...@libreoffice.or ||g Blocks||107200 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107200 [Bug 107200] [META] Writer table and cell selection issues -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108357] [META] Writer frame/image/OLE style bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108357 BogdanB changed: What|Removed |Added Depends on||149734 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=149734 [Bug 149734] Identical frames with identical style definitions; one is rotatable & other is not; Only difference is /where/ the style is defined -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149734] Identical frames with identical style definitions; one is rotatable & other is not; Only difference is /where/ the style is defined
https://bugs.documentfoundation.org/show_bug.cgi?id=149734 BogdanB changed: What|Removed |Added CC||buzea.bog...@libreoffice.or ||g Blocks||108357 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108357 [Bug 108357] [META] Writer frame/image/OLE style bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108430] [META] Mouse cursor bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108430 BogdanB changed: What|Removed |Added Depends on||139029 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=139029 [Bug 139029] The drag and drop position indicator and the actual 'drop' mismatched in table (arrow position defines the dropzone) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139029] The drag and drop position indicator and the actual 'drop' mismatched in table (arrow position defines the dropzone)
https://bugs.documentfoundation.org/show_bug.cgi?id=139029 BogdanB changed: What|Removed |Added Blocks||108430 CC||buzea.bog...@libreoffice.or ||g Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108430 [Bug 108430] [META] Mouse cursor bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 106045] [META] Vertical and rotated text direction issues
https://bugs.documentfoundation.org/show_bug.cgi?id=106045 BogdanB changed: What|Removed |Added Depends on||152843 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=152843 [Bug 152843] Incorrect line breaks in LibreOffice Writer tables, when text is rotated to 90deg or 270deg positions -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152843] Incorrect line breaks in LibreOffice Writer tables, when text is rotated to 90deg or 270deg positions
https://bugs.documentfoundation.org/show_bug.cgi?id=152843 BogdanB changed: What|Removed |Added Blocks||106045 CC||buzea.bog...@libreoffice.or ||g Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=106045 [Bug 106045] [META] Vertical and rotated text direction issues -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 48741] [META] Writer's page header and footer issues
https://bugs.documentfoundation.org/show_bug.cgi?id=48741 BogdanB changed: What|Removed |Added Depends on||90092 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=90092 [Bug 90092] FORMATTING & VIEWING: Text and line overlap in paragraph with bottom border after a table in footer -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 90092] FORMATTING & VIEWING: Text and line overlap in paragraph with bottom border after a table in footer
https://bugs.documentfoundation.org/show_bug.cgi?id=90092 BogdanB changed: What|Removed |Added Blocks||48741 CC||buzea.bog...@libreoffice.or ||g Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=48741 [Bug 48741] [META] Writer's page header and footer issues -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 105948] [META] Undo/Redo bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=105948 BogdanB changed: What|Removed |Added Depends on||153692 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=153692 [Bug 153692] Table layout split differently after undoing delete row -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153692] Table layout split differently after undoing delete row
https://bugs.documentfoundation.org/show_bug.cgi?id=153692 BogdanB changed: What|Removed |Added Blocks||105948 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=105948 [Bug 105948] [META] Undo/Redo bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103100] [META] Writer table bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=103100 BogdanB changed: What|Removed |Added Depends on||153692 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=153692 [Bug 153692] Table layout split differently after undoing delete row -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153692] Table layout split differently after undoing delete row
https://bugs.documentfoundation.org/show_bug.cgi?id=153692 BogdanB changed: What|Removed |Added Blocks||103100 CC||buzea.bog...@libreoffice.or ||g Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103100 [Bug 103100] [META] Writer table bugs -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 135382] Document scrolls to top after undo of pasting a frame
https://bugs.documentfoundation.org/show_bug.cgi?id=135382 BogdanB changed: What|Removed |Added Blocks||105948 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=105948 [Bug 105948] [META] Undo/Redo bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 105948] [META] Undo/Redo bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=105948 BogdanB changed: What|Removed |Added Depends on||135382 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=135382 [Bug 135382] Document scrolls to top after undo of pasting a frame -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 105948] [META] Undo/Redo bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=105948 BogdanB changed: What|Removed |Added Depends on||135240 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=135240 [Bug 135240] Undo restores hidden track changes information -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 135240] Undo restores hidden track changes information
https://bugs.documentfoundation.org/show_bug.cgi?id=135240 BogdanB changed: What|Removed |Added Blocks||105948, 83946 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=83946 [Bug 83946] [META] Tracking changes issues https://bugs.documentfoundation.org/show_bug.cgi?id=105948 [Bug 105948] [META] Undo/Redo bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 83946] [META] Tracking changes issues
https://bugs.documentfoundation.org/show_bug.cgi?id=83946 BogdanB changed: What|Removed |Added Depends on||135240 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=135240 [Bug 135240] Undo restores hidden track changes information -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 83946] [META] Tracking changes issues
https://bugs.documentfoundation.org/show_bug.cgi?id=83946 BogdanB changed: What|Removed |Added Depends on||135376 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=135376 [Bug 135376] Formatting messed up after undo (track & changes involved) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 105948] [META] Undo/Redo bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=105948 BogdanB changed: What|Removed |Added Depends on||135376 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=135376 [Bug 135376] Formatting messed up after undo (track & changes involved) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 135376] Formatting messed up after undo (track & changes involved)
https://bugs.documentfoundation.org/show_bug.cgi?id=135376 BogdanB changed: What|Removed |Added Blocks||105948, 83946 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=83946 [Bug 83946] [META] Tracking changes issues https://bugs.documentfoundation.org/show_bug.cgi?id=105948 [Bug 105948] [META] Undo/Redo bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108576] [META] Writer page style bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108576 BogdanB changed: What|Removed |Added Depends on||150994 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=150994 [Bug 150994] Rename the "Quotations" paragraph style -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150994] Rename the "Quotations" paragraph style
https://bugs.documentfoundation.org/show_bug.cgi?id=150994 BogdanB changed: What|Removed |Added Blocks||108576 CC||buzea.bog...@libreoffice.or ||g Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108576 [Bug 108576] [META] Writer page style bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154705] Enhancement: Add Snap to Intersection
https://bugs.documentfoundation.org/show_bug.cgi?id=154705 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148677] Add Avery 5160 to Label Format choices
https://bugs.documentfoundation.org/show_bug.cgi?id=148677 --- Comment #4 from QA Administrators --- Dear MikeH, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144610] Font drop down does not function correctly throughout the suite
https://bugs.documentfoundation.org/show_bug.cgi?id=144610 --- Comment #4 from QA Administrators --- Dear Brianna Michaela, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 90580] Cannot delete "VBA context"
https://bugs.documentfoundation.org/show_bug.cgi?id=90580 --- Comment #18 from QA Administrators --- Dear Andreas Säger, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151714] Calc fails to load XLS file
https://bugs.documentfoundation.org/show_bug.cgi?id=151714 --- Comment #2 from QA Administrators --- Dear allan.apayne, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 50626] EDITING: Query on Mac OS X Addressbook doesn't display data for fields other than CHAR datatype
https://bugs.documentfoundation.org/show_bug.cgi?id=50626 --- Comment #25 from QA Administrators --- Dear Robert Großkopf, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 132348] Draw: Multiple selected pages should be written in Print-Range-Pages, as in Impress (per comment 3)
https://bugs.documentfoundation.org/show_bug.cgi?id=132348 --- Comment #5 from QA Administrators --- Dear birnb...@posteo.de, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 124866] Doesn't work hyperlink inside text box in page headers (see Comment 10)
https://bugs.documentfoundation.org/show_bug.cgi?id=124866 --- Comment #15 from QA Administrators --- Dear Claudi, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 105465] Make the "Automatic" color a real checkbox
https://bugs.documentfoundation.org/show_bug.cgi?id=105465 --- Comment #5 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 124294] FORMATTING Strikethrough not cleared, when formatting cycle starts from partial application (edit mode works)
https://bugs.documentfoundation.org/show_bug.cgi?id=124294 --- Comment #4 from QA Administrators --- Dear Doug Arndt, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 101677] Make text flow in tables from top to bottom first and left to right secondary
https://bugs.documentfoundation.org/show_bug.cgi?id=101677 --- Comment #6 from QA Administrators --- Dear sergio.callegari, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: instsetoo_native/CustomTarget_install.mk instsetoo_native/inc_common msicreator/create_installer.py msicreator/createmsi.py
instsetoo_native/CustomTarget_install.mk |3 instsetoo_native/inc_common/windows/msi_templates/Binary/Image_2.bmp |binary msicreator/create_installer.py | 84 + msicreator/createmsi.py | 605 ++ 4 files changed, 692 insertions(+) New commits: commit 9aee0383c3ebc3f267c99e19764728ba09c12d3a Author: Rakielle AuthorDate: Sun Feb 12 21:42:00 2023 +0100 Commit: Thorsten Behrens CommitDate: Sat Apr 22 04:52:55 2023 +0200 Integrate msicreator into LO and generate installer Co-authored-by: Ximena Alcaman Change-Id: Iea2ea3b4bddc975a032592403727a4ff00db4a5d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146843 Tested-by: Jenkins Reviewed-by: Thorsten Behrens diff --git a/instsetoo_native/CustomTarget_install.mk b/instsetoo_native/CustomTarget_install.mk index 29dcb4b0b1cd..e4c0f7fcb9e7 100644 --- a/instsetoo_native/CustomTarget_install.mk +++ b/instsetoo_native/CustomTarget_install.mk @@ -74,6 +74,8 @@ instsetoo_installer_targets := $(foreach pkgformat,$(PKGFORMAT),\ $(foreach lang,$(filter-out en-US,$(gb_WITH_LANG)),ooolangpack‧$(lang)‧‧-languagepack‧$(pkgformat)‧nostrip))) endif +LIBO_VERSION = $(LIBO_VERSION_MAJOR).$(LIBO_VERSION_MINOR).$(LIBO_VERSION_MICRO).$(LIBO_VERSION_PATCH) + instsetoo_wipe: $(call gb_Output_announce,wiping installation output dir,$(true),WPE,6) rm -rf $(instsetoo_OUT) @@ -113,6 +115,7 @@ $(instsetoo_installer_targets): $(SRCDIR)/solenv/bin/make_installer.pl \ $(call gb_CustomTarget_get_workdir,instsetoo_native/install)/install.phony: $(instsetoo_installer_targets) $(call gb_Output_announce,$(subst $(WORKDIR)/,,$@),$(true),PRL,2) $(call gb_Trace_StartRange,$(subst $(WORKDIR)/,,$@),PRL) + $(if $(LODE_HOME),$(call gb_ExternalExecutable_get_command,python) $(SRCDIR)/msicreator/create_installer.py $(BUILDDIR) $(SRCDIR) $(LIBO_VERSION) $(PRODUCTNAME_WITHOUT_SPACES)) ifeq (TRUE,$(LIBO_TEST_INSTALL)) unzip -q -d $(TESTINSTALLDIR) $(instsetoo_OUT)/$(PRODUCTNAME_WITHOUT_SPACES)/archive/install/en-US/LibreOffice*_archive.zip mv $(TESTINSTALLDIR)/LibreOffice*_archive/LibreOffice*/* $(TESTINSTALLDIR)/ diff --git a/instsetoo_native/inc_common/windows/msi_templates/Binary/Image_2.bmp b/instsetoo_native/inc_common/windows/msi_templates/Binary/Image_2.bmp new file mode 100644 index ..b3795cadea7d Binary files /dev/null and b/instsetoo_native/inc_common/windows/msi_templates/Binary/Image_2.bmp differ diff --git a/msicreator/create_installer.py b/msicreator/create_installer.py new file mode 100644 index ..01394a48c4a3 --- /dev/null +++ b/msicreator/create_installer.py @@ -0,0 +1,84 @@ +import os, sys +from shutil import copytree, copy2, move, rmtree +import json +import createmsi + +build_dir = sys.argv[1] +src_dir = sys.argv[2] +creator_dir = os.path.join(build_dir, 'workdir/installation/MSICreatorLO') + +def prepare_project_dir(): +instdir = os.path.join(build_dir, 'instdir') +fonts_dir = os.path.join(instdir, 'share/fonts') +new_fonts_dir = os.path.join(creator_dir, 'libo-fonts/share/fonts') +main_dir = os.path.join(creator_dir, 'main') +src_uninstaller_icon = os.path.join(src_dir, 'icon-themes/colibre/res/mainapp_48_8.png') +src_ui_banner = os.path.join(src_dir, 'instsetoo_native/inc_common/windows/msi_templates/Binary/Banner.bmp') +src_ui_background = os.path.join(src_dir, 'instsetoo_native/inc_common/windows/msi_templates/Binary/Image_2.bmp') +graphics_dir = os.path.join(creator_dir, 'graphics') +sdk_dir = os.path.join(creator_dir, 'main/sdk') +try: +move(fonts_dir, new_fonts_dir) +copytree(instdir, main_dir, dirs_exist_ok=True) +copy2(src_uninstaller_icon, creator_dir) +os.mkdir(graphics_dir) +copy2(src_ui_banner, graphics_dir) +copy2(src_ui_background, graphics_dir) +rmtree(sdk_dir) +except FileExistsError as err: +print(err) + +def create_creator_json(): +lo_version = sys.argv[3] +lo_name = sys.argv[4] +uninstaller_icon = 'mainapp_48_8.png' +lo_dictionary = { +"upgrade_guid": "6f05ed48-a735-4155-ab60-e4cc98455262", +"version": lo_version, +"product_name": lo_name, +"manufacturer": "The Document Foundation", +"name": lo_name, +"name_base": lo_name, +"comments": "Testing a libo installer", +"installdir": "LibreOffice Test", +"startmenu_shortcut": "program/soffice.exe", +"desktop_shortcut": "program/soffice.exe", +"addremove_icon": uninstaller_icon, +"major_upgrade": { +"AllowDowngrades": "yes", +"IgnoreRemoveFailure": "yes" +}, +"graphics": { +"banner": "graphics/Banner.bmp", +"background": "graphics/Image_2.bmp" +}, +
[Libreoffice-commits] core.git: .github/workflows
.github/workflows/lockdown.yml |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 35787e07b7e83f7dcaa0c67830fcb4eded49c71f Author: Sarthak Roy AuthorDate: Thu Feb 23 01:41:12 2023 + Commit: Thorsten Behrens CommitDate: Sat Apr 22 03:27:06 2023 +0200 workflows: Update dessant/repo-lockdown to v3 * Changelog: https://github.com/dessant/repo-lockdown/blob/master/CHANGELOG.md#300-2022-12-04 Change-Id: I7c4f7dc8f97dc59b3d689cf82e23365740c8fd6c Signed-off-by: Sarthak Roy Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147495 Tested-by: Thorsten Behrens Reviewed-by: Thorsten Behrens diff --git a/.github/workflows/lockdown.yml b/.github/workflows/lockdown.yml index faf56b45525c..df2701495fda 100644 --- a/.github/workflows/lockdown.yml +++ b/.github/workflows/lockdown.yml @@ -12,7 +12,7 @@ jobs: point-to-upstream: runs-on: ubuntu-latest steps: - - uses: dessant/repo-lockdown@v2.2.0 + - uses: dessant/repo-lockdown@v3 with: issue-comment: > Thank you for your report. We use GitHub as a read-only mirror, so please submit your report into our own bug tracker: https://wiki.documentfoundation.org/QA/BugReport
[Libreoffice-commits] core.git: Branch 'distro/cib/libreoffice-6-4' - translations
translations |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 13b096b5289f4cb670212106996bfc967453e8cd Author: Gabor Kelemen AuthorDate: Sat Apr 22 03:12:55 2023 +0200 Commit: Gerrit Code Review CommitDate: Sat Apr 22 03:12:55 2023 +0200 Update git submodules * Update translations from branch 'distro/cib/libreoffice-6-4' to e7a8e73e4f04e918ceb2dd7e4d1cab078f0262eb - Add German translations for tdf#130199 Change-Id: I90d89c447a060c2d8948c007e1ed6237322fd696 Reviewed-on: https://gerrit.libreoffice.org/c/translations/+/150638 Reviewed-by: Thorsten Behrens Tested-by: Thorsten Behrens diff --git a/translations b/translations index 632f1d188810..e7a8e73e4f04 16 --- a/translations +++ b/translations @@ -1 +1 @@ -Subproject commit 632f1d188810f654edeb07ff11b0d859cf605d52 +Subproject commit e7a8e73e4f04e918ceb2dd7e4d1cab078f0262eb
[Libreoffice-commits] translations.git: Branch 'distro/cib/libreoffice-6-4' - source/de
source/de/sw/messages.po | 15 +++ 1 file changed, 15 insertions(+) New commits: commit e7a8e73e4f04e918ceb2dd7e4d1cab078f0262eb Author: Gabor Kelemen AuthorDate: Wed Apr 19 14:10:32 2023 +0200 Commit: Thorsten Behrens CommitDate: Sat Apr 22 03:12:55 2023 +0200 Add German translations for tdf#130199 Change-Id: I90d89c447a060c2d8948c007e1ed6237322fd696 Reviewed-on: https://gerrit.libreoffice.org/c/translations/+/150638 Reviewed-by: Thorsten Behrens Tested-by: Thorsten Behrens diff --git a/source/de/sw/messages.po b/source/de/sw/messages.po index 92427b510ac..09f2e588aba 100644 --- a/source/de/sw/messages.po +++ b/source/de/sw/messages.po @@ -21052,6 +21052,21 @@ msgctxt "warnemaildialog|WarnEmailDialog" msgid "The following error occurred:" msgstr "Folgender Fehler ist aufgetreten:" +#: sw/uiconfig/swriter/ui/warnhiddensectiondialog.ui:7 +msgctxt "warnhiddensectiondialog|WarnHiddenSectionDialog" +msgid "Delete hidden section(s)?" +msgstr "Ausgeblendete(n) Bereich(e) löschen?" + +#: sw/uiconfig/swriter/ui/warnhiddensectiondialog.ui:14 +msgctxt "warnhiddensectiondialog|WarnHiddenSectionDialog" +msgid "Would you like to delete the hidden section(s)?" +msgstr "Möchten Sie den/die versteckten Abschnitt(e) löschen?" + +#: sw/uiconfig/swriter/ui/warnhiddensectiondialog.ui:15 +msgctxt "warnhiddensectiondialog|WarnHiddenSectionDialog" +msgid "There are hidden sections in the deleted area." +msgstr "Es gibt versteckte Abschnitte im gelöschten Bereich." + #. fkAeJ #: sw/uiconfig/swriter/ui/watermarkdialog.ui:18 msgctxt "watermarkdialog|WatermarkDialog"
[Libreoffice-bugs] [Bug 154703] META Export DOCX flies with framePr instead of DrawingDML
https://bugs.documentfoundation.org/show_bug.cgi?id=154703 --- Comment #19 from Commit Notification --- Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/d3a121cecfa8fb3c6f81b05822ba3309d77ab85d tdf#154703 sw framePr: export knowing import wrap spacing limitations It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/qa sw/source
sw/qa/extras/ooxmlexport/data/tdf154703_framePrWrapSpacing.docx |binary sw/qa/extras/ooxmlexport/ooxmlexport18.cxx | 11 + sw/source/filter/ww8/docxattributeoutput.cxx| 21 ++ 3 files changed, 25 insertions(+), 7 deletions(-) New commits: commit d3a121cecfa8fb3c6f81b05822ba3309d77ab85d Author: Justin Luth AuthorDate: Fri Apr 21 19:42:55 2023 -0400 Commit: Justin Luth CommitDate: Sat Apr 22 02:56:45 2023 +0200 tdf#154703 sw framePr: export knowing import wrap spacing limitations I noticed that the wrap margin spacing was being cut in half each round-trip. That is because MS Word ignores the spacing on LEFT or RIGHT alignment, while LO doesn't. Rather than monkey with layout, import just ignored the spacing. Sounds like a good idea - but needed to do the same on export. make CppunitTest_sw_ooxmlexport18 \ CPPUNIT_TEST_NAME=testTdf154703_framePrWrapSpacing Change-Id: I3878d1bdb98cf027fe95137939caf6901c7188a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150796 Tested-by: Jenkins Reviewed-by: Justin Luth diff --git a/sw/qa/extras/ooxmlexport/data/tdf154703_framePrWrapSpacing.docx b/sw/qa/extras/ooxmlexport/data/tdf154703_framePrWrapSpacing.docx new file mode 100644 index ..57a9bea5a174 Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/tdf154703_framePrWrapSpacing.docx differ diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport18.cxx b/sw/qa/extras/ooxmlexport/ooxmlexport18.cxx index 171826175e0b..72cfe1723870 100644 --- a/sw/qa/extras/ooxmlexport/ooxmlexport18.cxx +++ b/sw/qa/extras/ooxmlexport/ooxmlexport18.cxx @@ -233,6 +233,17 @@ DECLARE_OOXMLEXPORT_TEST(testTdf154703_framePr2, "tdf154703_framePr2.rtf") assertXPath(pXmlDoc, "//w:body/w:p[3]/w:pPr/w:shd", "fill", "80"); } +DECLARE_OOXMLEXPORT_TEST(testTdf154703_framePrWrapSpacing, "tdf154703_framePrWrapSpacing.docx") +{ +CPPUNIT_ASSERT_EQUAL(2, getPages()); +if (!isExported()) +return; + +xmlDocUniquePtr pXmlDoc = parseExport("word/document.xml"); +// before the fix, this was half of the correct value. +assertXPath(pXmlDoc, "//w:body/w:p/w:pPr/w:framePr", "hSpace", "2552"); +} + DECLARE_OOXMLEXPORT_TEST(testTdf153613_anchoredAfterPgBreak, "tdf153613_anchoredAfterPgBreak.docx") { const auto& pLayout = parseLayoutDump(); diff --git a/sw/source/filter/ww8/docxattributeoutput.cxx b/sw/source/filter/ww8/docxattributeoutput.cxx index 43cfa953a041..94ed8bac2ba9 100644 --- a/sw/source/filter/ww8/docxattributeoutput.cxx +++ b/sw/source/filter/ww8/docxattributeoutput.cxx @@ -933,24 +933,31 @@ void DocxAttributeOutput::PopulateFrameProperties(const SwFrameFormat* pFrameFor attrList->add( FSNS( XML_w, XML_x), OString::number(aPos.X)); attrList->add( FSNS( XML_w, XML_y), OString::number(aPos.Y)); +OString aXAlign = convertToOOXMLHoriOrient(rHoriOrient.GetHoriOrient(), /*bIsPosToggle=*/false); +OString aYAlign = convertToOOXMLVertOrient(rVertOrient.GetVertOrient()); +if (!aXAlign.isEmpty()) +attrList->add(FSNS(XML_w, XML_xAlign), aXAlign); +if (!aYAlign.isEmpty()) +attrList->add(FSNS(XML_w, XML_yAlign), aYAlign); + sal_Int16 nLeft = pFrameFormat->GetLRSpace().GetLeft(); sal_Int16 nRight = pFrameFormat->GetLRSpace().GetRight(); sal_Int16 nUpper = pFrameFormat->GetULSpace().GetUpper(); sal_Int16 nLower = pFrameFormat->GetULSpace().GetLower(); +// To emulate, on import left was ignored (set to zero) if aligned to left, +// so just double up the right spacing in order to prevent cutting in half each round-trip. +if (rHoriOrient.GetHoriOrient() == text::HoriOrientation::LEFT) +nLeft = nRight; +else if (rHoriOrient.GetHoriOrient() == text::HoriOrientation::RIGHT) +nRight = nLeft; + attrList->add(FSNS(XML_w, XML_hSpace), OString::number((nLeft + nRight) / 2)); attrList->add(FSNS(XML_w, XML_vSpace), OString::number((nUpper + nLower) / 2)); OString relativeFromH = convertToOOXMLHoriOrientRel(rHoriOrient.GetRelationOrient()); OString relativeFromV = convertToOOXMLVertOrientRel(rVertOrient.GetRelationOrient()); -OString aXAlign = convertToOOXMLHoriOrient(rHoriOrient.GetHoriOrient(), /*bIsPosToggle=*/false); -OString aYAlign = convertToOOXMLVertOrient(rVertOrient.GetVertOrient()); -if (!aXAlign.isEmpty()) -attrList->add(FSNS(XML_w, XML_xAlign), aXAlign); -if (!aYAlign.isEmpty()) -attrList->add(FSNS(XML_w, XML_yAlign), aYAlign); - switch (pFrameFormat->GetSurround().GetValue()) { case css::text::WrapTextMode_NONE:
Re: ESC tendering policy changes ...
* Michael Meeks (michael.me...@collabora.com) wrote: > Hi there, > > > * ESC tender project proposal process (Thorsten) > > + proposal would be: (Thorsten) > > + share the draft in public: see > > https://nextcloud.documentfoundation.org/s/YprpsFP45z7a7p3 > . > + the unnecessary lengths we go to exclude people: the three > years is egregiously punitive - particularly in light of > the forward looking Declaration of Potential Conflict; lets > remove it. The future matters, for future tendering, not > the past. As someone who has very recently left a large relevant company, the other problem is that in a large company there are people who are on entirely different projects with no overlap with TDF stuff. Excluding ~300k people seems a little exessive when a few 10s of them may be relevant. Dave > + the effort we go to to exclude people - when the output of > this is just good advice for the board to act on is staggering. > > + the balance seems very substantially wrong in terms > of preserving our statutory meritocracy & efficiency > > + it is not worth sacrificing these to this extent to > try to solve every possible concern someone could > raise: there is already significant ongoing risk of people > using such spurious concerns to unbalance our governance. > > + Effort Estimate & exclusion is silly: > > + excluding the few non-conflicted experts in the > space - who are vital to review the code is totally > counter-productive. > > + if someone is not going to tender, and is not > affiliated - just assessing the estimate > should not exclude them from further process - > such as eg. seeing if it was delivered properly. > > + it is very unclear what rational can be used to > add a whole extra layer of CoI here. > > + the pool of skilled people here in any specific > area is small. > > + There are also many deeply wrong ideas embedded in > this idea of an accurate effort estimate. > > wrong premise 1. that effort is easy to estimate - for >extreme accuracy it takes a significant %age > of the time to do the job. > > + such estimates are best done by 2x > skilled people, with a range of > best/likely/worst triple-point > estimates, breaking down the problem > etc. > > + even so - fixed-priced projects bankrupt > skilled consultancies in all industries, > even non-innovative traditional ones eg. > building projects. > > wrong premise 2. that all engineers have the same >skill/experience level - there is no >"person day" - this varies 10x depending >on the person even among experienced engineers > cf. Fred Brooks, passim ad nauseum > > wrong premise 3. that person days can be meaningfully linked >to cost for a fixed-price project. > > + pricing include risk of overruns > > + pricing includes load factors & other > concurrent bids, capacity, probability of > other bids closing etc. this is a commercial > nightmare; think Ryan-Air, over-selling the > plane by a factor of two. > > + payment risk as well as reputational risks of > contracting for TDF are -very- substantial. > >the only sensible determination of price is >by seeing the result of a public, contested > tendering. To pretend otherwise is silly. > > 4. many tendered fixed-price tasks cost the people > executing on them rather more than they are bid > for - not even the companies with the experts > can get this perfectly right. > > + worse - this quest for an accurate estimate seems to > serve no very useful purpose. It is fine to have a > hyper-accurate number, but if no-one will deliver it in > that time - you wasted your time. > > + I would suggest that we instead have a process that > ranks tasks, tenders them by priority top-down and then > decides on reasonableness based on a number of ball-park > estimates. > > + the wisdom of crowds can give us several rough > ball-parks reasonably easily. > > + and otherwise to completely ignore this step, or > at least explain what extra purpose it tries to solve > > + Obvious hostages to fortune: > > "Only non-Conflicted Members can vote in the ESC." > > + this needs to be profoundly (and redundantly) > specialized - in the
[Libreoffice-bugs] [Bug 154874] Crash in LibreOffice Writer when typing real fast
https://bugs.documentfoundation.org/show_bug.cgi?id=154874 --- Comment #3 from gdehuff...@gmail.com --- note I tried to reply to your request by email but it came back as: " Address not found Your message wasn't delivered to bugzilla-dae...@bugs.documentfoundation.org because the address couldn't be found, or is unable to receive mail. " So I have changed the version info above to "7.5.1.2" and the Status to "UNCONFIRMED" per the instructions. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154874] Crash in LibreOffice Writer when typing real fast
https://bugs.documentfoundation.org/show_bug.cgi?id=154874 gdehuff...@gmail.com changed: What|Removed |Added Version|unspecified |7.5.1.2 release Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 --- Comment #2 from gdehuff...@gmail.com --- bug 154874 Version info: Libre Office: 7.5.1.2 (X86_64) / LibreOffice Community Thank you, Gil DeHuff -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154811] No smooth scrolling of a particular spreadsheet, only sluggish (without Skia)
https://bugs.documentfoundation.org/show_bug.cgi?id=154811 --- Comment #9 from b...@jth.net --- Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 61b41646c5a93ca24f2c9f143cdb0da2c9258989 CPU threads: 12; OS: Windows 10.0 Build 22624; UI render: default; VCL: win Locale: da-DK (da_DK); UI: en-US Calc: CL threaded Even with only 50 lines in the sheet, there are noticable delays This below in a VMware virtual machine using Linux Mint 21.1. It does not display any sluggishness Version: 7.5.2.2 (X86_64) / LibreOffice Community Build ID: 53bb9681a964705cf672590721dbc85eb4d0c3a2 CPU threads: 4; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded Thus the problem is most likely a Windows 11 version problem. (Libreoffice is reporting the OS as Windows 10) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154853] FILESAVE PPTX Order of radial gradients steps is reversed
https://bugs.documentfoundation.org/show_bug.cgi?id=154853 Gabor Kelemen (allotropia) changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #4 from Gabor Kelemen (allotropia) --- This was fixed by (expanding the gerrit linked above): https://cgit.freedesktop.org/libreoffice/core/commit/?id=dbbe5d0cd721 author Armin Le Grand (allotropia) 2023-04-14 16:29:18 +0200 committer Armin Le Grand 2023-04-17 16:10:48 +0200 commit dbbe5d0cd721a815df5e4cbf3215f291a423f2b1 (patch) MCGR: 1st corrections to gradient export, transparency Changed Alpha export from using Red component of used BColor too use luminance, that will be more safe if we evtl use same gradients for this in the future. Added evtl. needed inversion for gradient exports, also emulation of our 'axial' type. thx Armin :) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 114005] [META] Gradient fill bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=114005 Bug 114005 depends on bug 154853, which changed state. Bug 154853 Summary: FILESAVE PPTX Order of radial gradients steps is reversed https://bugs.documentfoundation.org/show_bug.cgi?id=154853 What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154962] New: project files, opening projects with all the files
https://bugs.documentfoundation.org/show_bug.cgi?id=154962 Bug ID: 154962 Summary: project files, opening projects with all the files Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: j...@cspv.hu it would be great to be able to open "projects", which would mean that a couple of files (documents) would open... or we could add documents to a list which would open together call them "document lists".. "document groups" but in NAVIGATOR we could handle it all.. like a playlist just an idea... -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154703] META Export DOCX flies with framePr instead of DrawingDML
https://bugs.documentfoundation.org/show_bug.cgi?id=154703 --- Comment #18 from Commit Notification --- Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/006b35d50024b1932d84380b5d2fec1f7066bccd tdf#154703 NFC sw framePr: flatten TextBoxIsFramePr and fix typo It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/source
sw/source/core/text/frmform.cxx |2 - sw/source/filter/ww8/docxattributeoutput.cxx | 42 +-- 2 files changed, 22 insertions(+), 22 deletions(-) New commits: commit 006b35d50024b1932d84380b5d2fec1f7066bccd Author: Justin Luth AuthorDate: Wed Apr 5 20:32:07 2023 -0400 Commit: Justin Luth CommitDate: Fri Apr 21 22:35:59 2023 +0200 tdf#154703 NFC sw framePr: flatten TextBoxIsFramePr and fix typo Change-Id: I0fd30cb62c3676a1c7088636798bd4e6d3a18c50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150071 Tested-by: Jenkins Reviewed-by: Justin Luth diff --git a/sw/source/core/text/frmform.cxx b/sw/source/core/text/frmform.cxx index 41b18363aed2..2f3024f1bb0a 100644 --- a/sw/source/core/text/frmform.cxx +++ b/sw/source/core/text/frmform.cxx @@ -1227,7 +1227,7 @@ void SwTextFrame::FormatAdjust( SwTextFormatter , } // bPrev is set whether Reformat.Start() was called because of Prev(). -// Else, wo don't know whether we can limit the repaint or not. +// Else, we don't know whether we can limit the repaint or not. bool SwTextFrame::FormatLine( SwTextFormatter , const bool bPrev ) { OSL_ENSURE( ! IsVertical() || IsSwapped(), diff --git a/sw/source/filter/ww8/docxattributeoutput.cxx b/sw/source/filter/ww8/docxattributeoutput.cxx index 2e456a8018fb..43cfa953a041 100644 --- a/sw/source/filter/ww8/docxattributeoutput.cxx +++ b/sw/source/filter/ww8/docxattributeoutput.cxx @@ -973,27 +973,27 @@ void DocxAttributeOutput::PopulateFrameProperties(const SwFrameFormat* pFrameFor bool DocxAttributeOutput::TextBoxIsFramePr(const SwFrameFormat& rFrameFormat) { -uno::Reference< drawing::XShape > xShape; -const SdrObject* pSdrObj = rFrameFormat.FindRealSdrObject(); -if (pSdrObj) -xShape.set(const_cast(pSdrObj)->getUnoShape(), uno::UNO_QUERY); -uno::Reference< beans::XPropertySet > xPropertySet(xShape, uno::UNO_QUERY); -uno::Reference< beans::XPropertySetInfo > xPropSetInfo; -if (xPropertySet.is()) -xPropSetInfo = xPropertySet->getPropertySetInfo(); -uno::Any aFrameProperties ; -if (xPropSetInfo.is() && xPropSetInfo->hasPropertyByName("FrameInteropGrabBag")) -{ -uno::Sequence< beans::PropertyValue > propList; -xPropertySet->getPropertyValue("FrameInteropGrabBag") >>= propList; -auto pProp = std::find_if(std::cbegin(propList), std::cend(propList), -[](const beans::PropertyValue& rProp) { return rProp.Name == "ParaFrameProperties"; }); -if (pProp != std::cend(propList)) -aFrameProperties = pProp->Value; -} -bool bFrameProperties = false; -aFrameProperties >>= bFrameProperties; -return bFrameProperties; +SdrObject* pSdrObj = const_cast(rFrameFormat.FindRealSdrObject()); +if (!pSdrObj) +return false; + +uno::Reference xPropertySet(pSdrObj->getUnoShape(), uno::UNO_QUERY); +if (!xPropertySet.is()) +return false; + +uno::Reference xPropSetInfo(xPropertySet->getPropertySetInfo()); +if (!xPropSetInfo.is() || !xPropSetInfo->hasPropertyByName("FrameInteropGrabBag")) +return false; + +bool bRet = false; +uno::Sequence propList; +xPropertySet->getPropertyValue("FrameInteropGrabBag") >>= propList; +auto pProp = std::find_if(std::cbegin(propList), std::cend(propList), +[](const beans::PropertyValue& rProp) { return rProp.Name == "ParaFrameProperties"; }); +if (pProp != std::cend(propList)) +pProp->Value >>= bRet; + +return bRet; } void DocxAttributeOutput::EndParagraph( ww8::WW8TableNodeInfoInner::Pointer_t pTextNodeInfoInner )
[Libreoffice-bugs] [Bug 153993] FORMATTING: ODF do not preserve embedded text and lowercase in scientific format
https://bugs.documentfoundation.org/show_bug.cgi?id=153993 --- Comment #7 from Matt Keveney --- > But this actual request may be achieved with a new attributes to the format, > containing a text replacement of scientific notation. I'm not following you. Is this "text replacement" an _existing_ feature? ..or an alternate feature proposal? If the former, please point me to the documentation. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/source
sw/source/filter/ww8/docxattributeoutput.cxx | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) New commits: commit 66465fe341a25652cf0eb06b8e4e24e18ea8ed3c Author: Justin Luth AuthorDate: Mon Apr 10 11:22:41 2023 -0400 Commit: Justin Luth CommitDate: Fri Apr 21 22:34:26 2023 +0200 NFC rename: const table::BorderLine2* rStyleProps (is not a reference) Added with commit ae61569eea0719a882010cfbb260a1a0d690d974 Author: Jacobo Aragunde Pérez on Thu Apr 3 16:27:37 2014 +0200 oox: Do not overwrite table style properties Change-Id: I8140e3a084f3f1e2d304a4ffc62897afa6427c4a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150771 Tested-by: Jenkins Reviewed-by: Justin Luth diff --git a/sw/source/filter/ww8/docxattributeoutput.cxx b/sw/source/filter/ww8/docxattributeoutput.cxx index 3b84ee2610d3..2e456a8018fb 100644 --- a/sw/source/filter/ww8/docxattributeoutput.cxx +++ b/sw/source/filter/ww8/docxattributeoutput.cxx @@ -4082,7 +4082,7 @@ void DocxAttributeOutput::ParagraphStyle( sal_uInt16 nStyle ) } static void impl_borderLine( FSHelperPtr const & pSerializer, sal_Int32 elementToken, const SvxBorderLine* pBorderLine, sal_uInt16 nDist, - bool bWriteShadow, const table::BorderLine2* rStyleProps = nullptr ) + bool bWriteShadow, const table::BorderLine2* pStyleProps = nullptr) { // Compute val attribute value // Can be one of: @@ -4153,7 +4153,7 @@ static void impl_borderLine( FSHelperPtr const & pSerializer, sal_Int32 elementT break; } } -else if ( !rStyleProps || !rStyleProps->LineWidth ) +else if (!pStyleProps || !pStyleProps->LineWidth) // no line, and no line set by the style either: // there is no need to write the property return; @@ -4161,11 +4161,14 @@ static void impl_borderLine( FSHelperPtr const & pSerializer, sal_Int32 elementT // compare the properties with the theme properties before writing them: // if they are equal, it means that they were style-defined and there is // no need to write them. -if( rStyleProps != nullptr && pBorderLine && !pBorderLine->isEmpty() && -pBorderLine->GetBorderLineStyle() == static_cast(rStyleProps->LineStyle) && -pBorderLine->GetColor() == Color(ColorTransparency, rStyleProps->Color) && -pBorderLine->GetWidth() == o3tl::toTwips(rStyleProps->LineWidth, o3tl::Length::mm100) ) +if (pStyleProps && pBorderLine && !pBorderLine->isEmpty() +&& pBorderLine->GetBorderLineStyle() + == static_cast(pStyleProps->LineStyle) +&& pBorderLine->GetColor() == Color(ColorTransparency, pStyleProps->Color) +&& pBorderLine->GetWidth() == o3tl::toTwips(pStyleProps->LineWidth, o3tl::Length::mm100)) +{ return; +} rtl::Reference pAttr = FastSerializerHelper::createAttrList(); pAttr->add( FSNS( XML_w, XML_val ), pVal );
[Libreoffice-bugs] [Bug 90708] Support display of SI units (like Gnumeric)
https://bugs.documentfoundation.org/show_bug.cgi?id=90708 --- Comment #9 from Matt Keveney --- (In reply to Laurent Balland from comment #7) ..subject originally raised in Bug 153993; moving discussion here. > > In the meantime, I had a look at what Gnumeric proposed and, mentioned in > comment 2, the main limitation is that only simple base units are available. > Something like area cannot be used. Moreover 1000 m² is NOT 1 km² ;-) > I agree that considering _units_ opens a huge can of worms. Aside from the example you mention, one might expect that 10V / 1kΩ would produce a result in Amps: 12mA. Such intelligence about units would be _far_ more complex than a simple display format. And I think it's unnecessary to go that far. I think prefix support alone, without considering units would be very useful and much simpler to implement. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142515] Optimal width/height of merged cells
https://bugs.documentfoundation.org/show_bug.cgi?id=142515 --- Comment #11 from Eike Rathke --- I don't see a straight forward solution for this. As the content of the merged cell has 6 lines, the only good solution would be to merge it over 6 rows instead of 5, i.e. B2:B7. Not doing so and not manually adjusting height calls for trouble. Any other would have to ask the user what they want, as Heiko lined out in comment 9. And then imagine multiple merged cells with different content height merged over different rows.. Mentioning the dirty word, what does Excel do for this? (In reply to Heiko Tietze from comment #10) > Potential duplicate: > * bug 57150: Calc FORMATTING: "Optimal column width" works incorrectly when > column includes a merged cell Not a duplicate, because that optimal column width behaviour is a result of a combination of merged cell with wrap-text cells interspersed with a not-wrapped cell, see https://bugs.documentfoundation.org/show_bug.cgi?id=57150#c6 about A20. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 142515] Optimal width/height of merged cells
https://bugs.documentfoundation.org/show_bug.cgi?id=142515 --- Comment #11 from Eike Rathke --- I don't see a straight forward solution for this. As the content of the merged cell has 6 lines, the only good solution would be to merge it over 6 rows instead of 5, i.e. B2:B7. Not doing so and not manually adjusting height calls for trouble. Any other would have to ask the user what they want, as Heiko lined out in comment 9. And then imagine multiple merged cells with different content height merged over different rows.. Mentioning the dirty word, what does Excel do for this? (In reply to Heiko Tietze from comment #10) > Potential duplicate: > * bug 57150: Calc FORMATTING: "Optimal column width" works incorrectly when > column includes a merged cell Not a duplicate, because that optimal column width behaviour is a result of a combination of merged cell with wrap-text cells interspersed with a not-wrapped cell, see https://bugs.documentfoundation.org/show_bug.cgi?id=57150#c6 about A20. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 154961] New: Enhancement needed: option to preserve recent Find targets at FileSave dialog box to be available at next session reopening same document in Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=154961 Bug ID: 154961 Summary: Enhancement needed: option to preserve recent Find targets at FileSave dialog box to be available at next session reopening same document in Writer Product: LibreOffice Version: 3.3.0 release Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: car...@gmail.com Description: Working on a large text document in Writer, I can search for (say) “Bug report” and edit the section. Then I can search for (say) “Linux commands”, read some text, then use Search again to return to “Bug report” easily. All my recent search texts are available in the Find window by scrolling using the arrow keys. When I save the document and close Writer, how can I get Writer to save those search texts with the document? When I re-open the same document tomorrow to continue editing, they have all vanished - but I will often need to re-visit the same locations in the document where I edited yesterday. If this is currently impossible, could it be added as an option in the FileSave dialog box? carrt7 Steps to Reproduce: 1. open a document, use Find to navigate to several locations 2. save document and exit LO. 3. reload LO and reopen same document Actual Results: Try Find: no items are retained from previous session. Expected Results: Find box should retain last location searched for in previous session, and allow scrolling up through other locations used in that session. Reproducible: Always User Profile Reset: No Additional Info: I realize that the Navigator can be used to reach frequently-used locations in a document. It is true that these could be bookmarked, for use in subsequent sessions. In actual editing of long documents this would be tedious. I will often complete edits to one portion of a document (and will not need to revisit it in the near future). But I will frequently have to end a session while still working on the LAST section. On resuming, I will need to revisit nearly all the sections which refer to the section I'm editing. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154703] META Export DOCX flies with framePr instead of DrawingDML
https://bugs.documentfoundation.org/show_bug.cgi?id=154703 --- Comment #17 from Commit Notification --- Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/981c5b5421b5fc728e2b8140d7d52d8c8eb465e7 NFC tdf#154703 docx export: optimize/reorder "if TextBoxIsFramePr" It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/source
sw/source/filter/ww8/docxattributeoutput.cxx | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) New commits: commit 981c5b5421b5fc728e2b8140d7d52d8c8eb465e7 Author: Justin Luth AuthorDate: Mon Apr 10 10:30:58 2023 -0400 Commit: Justin Luth CommitDate: Fri Apr 21 22:26:56 2023 +0200 NFC tdf#154703 docx export: optimize/reorder "if TextBoxIsFramePr" -there is no need to run the long TextBoxIsFramePr function first, so start by evaluating the simple boolean case to avoid unnecessary processing. -reorder if/else to logically start with the small section. By doing so, it highlights that really we are doing something special when TextBoxIsFramePr and the else is the normal for anything else. Change-Id: Ic06826c2b6dcd5d89a6873784eb58b2d7bedaba4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150770 Tested-by: Jenkins Reviewed-by: Justin Luth diff --git a/sw/source/filter/ww8/docxattributeoutput.cxx b/sw/source/filter/ww8/docxattributeoutput.cxx index 5590857f1c74..3b84ee2610d3 100644 --- a/sw/source/filter/ww8/docxattributeoutput.cxx +++ b/sw/source/filter/ww8/docxattributeoutput.cxx @@ -1019,7 +1019,12 @@ void DocxAttributeOutput::EndParagraph( ww8::WW8TableNodeInfoInner::Pointer_t pT ww8::Frame aFrame = m_aFramesOfParagraph.top()[nIndex]; const SwFrameFormat& rFrameFormat = aFrame.GetFrameFormat(); -if (!TextBoxIsFramePr(rFrameFormat) || m_bWritingHeaderFooter) +if (!m_bWritingHeaderFooter && TextBoxIsFramePr(rFrameFormat)) +{ +std::shared_ptr pFramePr = std::make_shared(aFrame); +aFramePrTextbox.push_back(pFramePr); +} +else { if (m_aRunSdt.m_bStartedSdt) { @@ -1074,11 +1079,6 @@ void DocxAttributeOutput::EndParagraph( ww8::WW8TableNodeInfoInner::Pointer_t pT m_pSerializer->endElementNS( XML_w, XML_r ); m_bParagraphFrameOpen = false; } -else -{ -std::shared_ptr pFramePr = std::make_shared(aFrame); -aFramePrTextbox.push_back(pFramePr); -} nFrames = m_aFramesOfParagraph.size() ? m_aFramesOfParagraph.top().size() : 0; }
[Libreoffice-commits] core.git: xmloff/source
xmloff/source/chart/XMLChartStyleContext.cxx|1 - xmloff/source/core/DomBuilderContext.cxx|1 - xmloff/source/draw/XMLGraphicsDefaultStyle.cxx |1 - xmloff/source/draw/XMLImageMapContext.cxx |1 - xmloff/source/draw/layerimp.cxx |1 - xmloff/source/draw/xexptran.cxx |2 -- xmloff/source/forms/elementimport.cxx |1 - xmloff/source/forms/officeforms.cxx |1 - xmloff/source/forms/propertyimport.cxx |1 - xmloff/source/script/XMLEventImportHelper.cxx |2 -- xmloff/source/script/XMLEventsImportContext.cxx |1 - xmloff/source/style/PageHeaderFooterContext.cxx |1 - xmloff/source/style/XMLFootnoteSeparatorImport.cxx |1 - xmloff/source/text/XMLAutoMarkFileContext.cxx |2 -- xmloff/source/text/XMLAutoTextContainerEventImport.cxx |2 -- xmloff/source/text/XMLAutoTextEventExport.cxx |1 - xmloff/source/text/XMLAutoTextEventImport.cxx |1 - xmloff/source/text/XMLChangeElementImportContext.cxx|2 -- xmloff/source/text/XMLChangeImportContext.cxx |2 -- xmloff/source/text/XMLChangeInfoContext.cxx |1 - xmloff/source/text/XMLChangedRegionImportContext.cxx|1 - xmloff/source/text/XMLFootnoteBodyImportContext.cxx |1 - xmloff/source/text/XMLIndexAlphabeticalSourceContext.cxx|2 -- xmloff/source/text/XMLIndexBibliographyConfigurationContext.cxx |1 - xmloff/source/text/XMLIndexBibliographyEntryContext.cxx |1 - xmloff/source/text/XMLIndexBibliographySourceContext.cxx|1 - xmloff/source/text/XMLIndexBodyContext.cxx |1 - xmloff/source/text/XMLIndexChapterInfoEntryContext.cxx |1 - xmloff/source/text/XMLIndexIllustrationSourceContext.cxx|2 -- xmloff/source/text/XMLIndexObjectSourceContext.cxx |2 -- xmloff/source/text/XMLIndexSimpleEntryContext.cxx |2 -- xmloff/source/text/XMLIndexSourceBaseContext.cxx|1 - xmloff/source/text/XMLIndexTOCContext.cxx |1 - xmloff/source/text/XMLIndexTOCSourceContext.cxx |1 - xmloff/source/text/XMLIndexTOCStylesContext.cxx |1 - xmloff/source/text/XMLIndexTabStopEntryContext.cxx |1 - xmloff/source/text/XMLIndexTableSourceContext.cxx |1 - xmloff/source/text/XMLIndexTemplateContext.cxx |1 - xmloff/source/text/XMLIndexTitleTemplateContext.cxx |2 -- xmloff/source/text/XMLIndexUserSourceContext.cxx|2 -- xmloff/source/text/XMLLineNumberingImportContext.cxx|1 - xmloff/source/text/XMLLineNumberingSeparatorImportContext.cxx |2 -- xmloff/source/text/XMLSectionFootnoteConfigImport.cxx |1 - xmloff/source/text/XMLSectionImportContext.cxx |1 - xmloff/source/text/XMLSectionSourceImportContext.cxx|1 - xmloff/source/text/XMLStringBufferImportContext.cxx |2 -- xmloff/source/text/XMLTextMasterStylesContext.cxx |1 - xmloff/source/text/XMLTrackedChangesImportContext.cxx |1 - xmloff/source/xforms/XFormsInstanceContext.cxx |1 - xmloff/source/xforms/XFormsSubmissionContext.cxx|1 - 50 files changed, 64 deletions(-) New commits: commit 36db242816099bdc3ed2573df1230313056c552c Author: Gabor Kelemen AuthorDate: Wed Apr 12 00:28:17 2023 +0200 Commit: Gabor Kelemen CommitDate: Fri Apr 21 22:22:33 2023 +0200 Run clang-tidy with misc-unused-using-decls on module xmloff To remove unneeded using declarations. Via the simple script: for i in $(find $dirname -name "*cxx" -o -name "*hxx" ); do clang-tidy-12 --checks="-*,misc-unused-using-decls" "$i"; done Change-Id: Iccae38de41c809b39345ec6b31c9f6346e620f53 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150611 Tested-by: Jenkins Reviewed-by: Gabor Kelemen diff --git a/xmloff/source/chart/XMLChartStyleContext.cxx b/xmloff/source/chart/XMLChartStyleContext.cxx index db30d22c96b3..fd8ff45d162e 100644 --- a/xmloff/source/chart/XMLChartStyleContext.cxx +++ b/xmloff/source/chart/XMLChartStyleContext.cxx @@ -32,7 +32,6 @@ #include "XMLChartPropertyContext.hxx" using namespace com::sun::star; -using ::xmloff::token::IsXMLToken; using ::xmloff::token::XML_DATA_STYLE_NAME; using ::xmloff::token::XML_PERCENTAGE_DATA_STYLE_NAME; using ::xmloff::token::XML_TEXT_PROPERTIES; diff --git
[Libreoffice-bugs] [Bug 57150] Calc FORMATTING: "Optimal column width" works incorrectly when column includes a merged cell and wrap-text cells and non-wrap cells (see comment 6 about A20)
https://bugs.documentfoundation.org/show_bug.cgi?id=57150 Eike Rathke changed: What|Removed |Added Summary|Calc FORMATTING: "Optimal |Calc FORMATTING: "Optimal |column width" works |column width" works |incorrectly when column |incorrectly when column |includes a merged cell |includes a merged cell and ||wrap-text cells and ||non-wrap cells (see comment ||6 about A20) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 120466] [META] DOCX (OOXML) anchor and text wrapping bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=120466 Bug 120466 depends on bug 116854, which changed state. Bug 116854 Summary: FILEOPEN DOCX: Floating table with 75,4% width in MSO opens 100% width in LO https://bugs.documentfoundation.org/show_bug.cgi?id=116854 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139532] [META] DOCX Floating table related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=139532 Bug 139532 depends on bug 116854, which changed state. Bug 116854 Summary: FILEOPEN DOCX: Floating table with 75,4% width in MSO opens 100% width in LO https://bugs.documentfoundation.org/show_bug.cgi?id=116854 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 116854] FILEOPEN DOCX: Floating table with 75, 4% width in MSO opens 100% width in LO
https://bugs.documentfoundation.org/show_bug.cgi?id=116854 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME CC||79045_79...@mail.ru --- Comment #10 from Roman Kuznetsov <79045_79...@mail.ru> --- The document looks the same as in attached PDF in Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 5cd9de202765e243e41416802f3e4486b8a96f16 CPU threads: 16; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: ru-RU (ru_RU); UI: ru-RU Calc: CL threaded closed as WFM -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 116292] FILEOPEN DOCX: floating table near bottom of page doesn't split across pages
https://bugs.documentfoundation.org/show_bug.cgi?id=116292 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||79045_79...@mail.ru --- Comment #11 from Roman Kuznetsov <79045_79...@mail.ru> --- Still repro in Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 5cd9de202765e243e41416802f3e4486b8a96f16 CPU threads: 16; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: ru-RU (ru_RU); UI: ru-RU Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139532] [META] DOCX Floating table related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=139532 Bug 139532 depends on bug 113672, which changed state. Bug 113672 Summary: Unnecessarily floated table HORIZONTAL position not correct for DOCX when converted to inline table (comment 5) https://bugs.documentfoundation.org/show_bug.cgi?id=113672 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 113672] Unnecessarily floated table HORIZONTAL position not correct for DOCX when converted to inline table (comment 5)
https://bugs.documentfoundation.org/show_bug.cgi?id=113672 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Status|NEW |RESOLVED CC||79045_79...@mail.ru Resolution|--- |WORKSFORME --- Comment #7 from Roman Kuznetsov <79045_79...@mail.ru> --- The table in the attached document looks the same as in MS Word in Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 5cd9de202765e243e41416802f3e4486b8a96f16 CPU threads: 16; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: ru-RU (ru_RU); UI: ru-RU Calc: CL threaded closed as WFM (thanks Miklos) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143806] Writer opens DOCX with slightly higher text spacing
https://bugs.documentfoundation.org/show_bug.cgi?id=143806 Bug 143806 depends on bug 105876, which changed state. Bug 105876 Summary: FILEOPEN: DOCX with long floating table is not split over multiple pages (imported in a frame) https://bugs.documentfoundation.org/show_bug.cgi?id=105876 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139532] [META] DOCX Floating table related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=139532 Bug 139532 depends on bug 105876, which changed state. Bug 105876 Summary: FILEOPEN: DOCX with long floating table is not split over multiple pages (imported in a frame) https://bugs.documentfoundation.org/show_bug.cgi?id=105876 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 105876] FILEOPEN: DOCX with long floating table is not split over multiple pages (imported in a frame)
https://bugs.documentfoundation.org/show_bug.cgi?id=105876 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME CC||79045_79...@mail.ru --- Comment #6 from Roman Kuznetsov <79045_79...@mail.ru> --- The document opened in Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 5cd9de202765e243e41416802f3e4486b8a96f16 CPU threads: 16; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: ru-RU (ru_RU); UI: ru-RU Calc: CL threaded looks good, the table is on two pages as should be closed as WFM (thanks Miklos I think) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 105373] FILEOPEN: In 2007 docx image misplaced with floating table (MSO saved DOCX opens as in LO)
https://bugs.documentfoundation.org/show_bug.cgi?id=105373 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||79045_79...@mail.ru --- Comment #12 from Roman Kuznetsov <79045_79...@mail.ru> --- Still repro in Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 5cd9de202765e243e41416802f3e4486b8a96f16 CPU threads: 16; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: ru-RU (ru_RU); UI: ru-RU Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 102012] FILEOPEN DOCX Frame with table inside it positioned wrong
https://bugs.documentfoundation.org/show_bug.cgi?id=102012 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||79045_79...@mail.ru --- Comment #22 from Roman Kuznetsov <79045_79...@mail.ru> --- The document looks much better in Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 5cd9de202765e243e41416802f3e4486b8a96f16 CPU threads: 16; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: ru-RU (ru_RU); UI: ru-RU Calc: CL threaded but Writer still shows the second empty page. I don't know should we close this one and file a new bug report. Buovjaga, what do you think? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 131323] Libreoffice pdf conversion fails in FIPS mode
https://bugs.documentfoundation.org/show_bug.cgi?id=131323 --- Comment #20 from James Blaszkiewicz --- With some further testing I was able to narrow the range down to: doesn't work for 7.3.3.2, does work for 7.3.4.1. So some change in 7.3.4.1 fixed this issue. I'll check out bibisecting to nail down the actual code changes. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: comphelper/source compilerplugins/clang lingucomponent/source sc/source sfx2/source svl/source svx/source vcl/jsdialog vcl/unx
comphelper/source/misc/lok.cxx |2 - comphelper/source/misc/sequenceashashmap.cxx |8 ++--- compilerplugins/clang/test/unnecessarygetstr.cxx | 25 + compilerplugins/clang/unnecessarygetstr.cxx | 32 ++- lingucomponent/source/numbertext/numbertext.cxx |2 - sc/source/filter/orcus/xmlcontext.cxx|2 - sfx2/source/doc/autoredactdialog.cxx | 10 +++ sfx2/source/doc/sfxbasemodel.cxx |2 - svl/source/undo/undo.cxx |4 +- svx/source/xoutdev/xattr.cxx |2 - vcl/jsdialog/executor.cxx|4 +- vcl/unx/generic/printer/cpdmgr.cxx |6 ++-- 12 files changed, 66 insertions(+), 33 deletions(-) New commits: commit f712c531336b2c44636a35ad682913550640e0d3 Author: Noel Grandin AuthorDate: Fri Apr 21 10:12:53 2023 +0200 Commit: Noel Grandin CommitDate: Fri Apr 21 21:46:09 2023 +0200 loplugin:unnecessarygetstr extend to checking std::string::c_str Change-Id: I17398e2a6a31a2c98ba8e54b5c8045f22aee8759 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150749 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/comphelper/source/misc/lok.cxx b/comphelper/source/misc/lok.cxx index 405411db7ba8..b5cbcc74cb54 100644 --- a/comphelper/source/misc/lok.cxx +++ b/comphelper/source/misc/lok.cxx @@ -232,7 +232,7 @@ bool isAllowlistedLanguage(const OUString& lang) continue; std::cerr << s << " "; -aList.emplace_back(OStringToOUString(s.c_str(), RTL_TEXTENCODING_UTF8)); +aList.emplace_back(OStringToOUString(s, RTL_TEXTENCODING_UTF8)); } std::cerr << std::endl; } diff --git a/comphelper/source/misc/sequenceashashmap.cxx b/comphelper/source/misc/sequenceashashmap.cxx index 3bbce289ffe0..50a4e0216cd0 100644 --- a/comphelper/source/misc/sequenceashashmap.cxx +++ b/comphelper/source/misc/sequenceashashmap.cxx @@ -49,7 +49,7 @@ uno::Any jsonToUnoAny(const boost::property_tree::ptree& aTree) uno::Sequence> aFields; uno::Reference xIdlClass = css::reflection::theCoreReflection::get(comphelper::getProcessComponentContext()) - ->forName(OUString::fromUtf8(rType.c_str())); + ->forName(OUString::fromUtf8(rType)); if (xIdlClass.is()) { uno::TypeClass aTypeClass = xIdlClass->getTypeClass(); @@ -91,7 +91,7 @@ uno::Any jsonToUnoAny(const boost::property_tree::ptree& aTree) else if (aTypeClass == uno::TypeClass_DOUBLE) aAny <<= o3tl::toDouble(rValue); else if (aTypeClass == uno::TypeClass_STRING) -aAny <<= OUString::fromUtf8(rValue.c_str()); +aAny <<= OUString::fromUtf8(rValue); } } return aAny; @@ -321,9 +321,9 @@ std::vector JsonToPropertyValues(const OString& rJson const std::string& rValue = rPair.second.get("value", ""); beans::PropertyValue aValue; -aValue.Name = OUString::fromUtf8(rPair.first.c_str()); +aValue.Name = OUString::fromUtf8(rPair.first); if (rType == "string") -aValue.Value <<= OUString::fromUtf8(rValue.c_str()); +aValue.Value <<= OUString::fromUtf8(rValue); else if (rType == "boolean") aValue.Value <<= OString(rValue.c_str()).toBoolean(); else if (rType == "float") diff --git a/compilerplugins/clang/test/unnecessarygetstr.cxx b/compilerplugins/clang/test/unnecessarygetstr.cxx index d04d2ca28402..12905ec5d233 100644 --- a/compilerplugins/clang/test/unnecessarygetstr.cxx +++ b/compilerplugins/clang/test/unnecessarygetstr.cxx @@ -18,6 +18,8 @@ #include #include +namespace test1 +{ void f1(bool, const OString& s); struct Foo { @@ -41,7 +43,10 @@ void test1(Foo& foo) = "xx" + OUString(aVal.getStr(), aVal.getLength(), RTL_TEXTENCODING_ASCII_US); (void)aCompText; } +} +namespace test2 +{ // call to param that takes string_view void f2(bool, std::string_view); struct Foo2 @@ -60,4 +65,24 @@ void test2(Foo2& foo) // expected-error@+1 {{unnecessary call to 'getStr' when passing to string_view arg [loplugin:unnecessarygetstr]}} foo.f2(true, OString::number(12).getStr()); } +} + +namespace test3 +{ +// call to param that takes string_view +void f2(bool, std::string_view); +struct Foo2 +{ +void f2(bool, std::string_view); +}; +void test3(Foo2& foo) +{ +std::string s; +// expected-error@+1 {{unnecessary call to 'c_str' when passing to string_view arg [loplugin:unnecessarygetstr]}} +f2(true, s.c_str()); +// expected-error@+1 {{unnecessary call to 'c_str' when passing to string_view arg [loplugin:unnecessarygetstr]}} +foo.f2(true, s.c_str()); +} +} + /* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */ diff --git
[Libreoffice-bugs] [Bug 139532] [META] DOCX Floating table related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=139532 Bug 139532 depends on bug 80869, which changed state. Bug 80869 Summary: FILEOPEN: illegal DOC DOCX with floating table and negative position to margin opens with wrong left margin as 0 https://bugs.documentfoundation.org/show_bug.cgi?id=80869 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 112700] [META] DOC (binary) table-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=112700 Bug 112700 depends on bug 80869, which changed state. Bug 80869 Summary: FILEOPEN: illegal DOC DOCX with floating table and negative position to margin opens with wrong left margin as 0 https://bugs.documentfoundation.org/show_bug.cgi?id=80869 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 80869] FILEOPEN: illegal DOC DOCX with floating table and negative position to margin opens with wrong left margin as 0
https://bugs.documentfoundation.org/show_bug.cgi?id=80869 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Resolution|--- |WORKSFORME Status|NEW |RESOLVED CC||79045_79...@mail.ru --- Comment #20 from Roman Kuznetsov <79045_79...@mail.ru> --- the bug document looks the same as in MS Word in Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 5cd9de202765e243e41416802f3e4486b8a96f16 CPU threads: 16; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: ru-RU (ru_RU); UI: ru-RU Calc: CL threaded Closed as WFM (I think we should say "thanks" to Miklos) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: scaddins/source
scaddins/source/analysis/analysis.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 90cbe03a0bd65151c197d3d4aeaf48a696f13fad Author: Eike Rathke AuthorDate: Fri Apr 21 15:42:01 2023 +0200 Commit: Eike Rathke CommitDate: Fri Apr 21 21:37:15 2023 +0200 Resolves: tdf#154941 MROUND() use approxValue of division to round Change-Id: I75394b1bdffbdadf051157e84afa06f30126fe23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150764 Reviewed-by: Eike Rathke Tested-by: Jenkins diff --git a/scaddins/source/analysis/analysis.cxx b/scaddins/source/analysis/analysis.cxx index 9c9fc9718c59..a168ff7c6f59 100644 --- a/scaddins/source/analysis/analysis.cxx +++ b/scaddins/source/analysis/analysis.cxx @@ -555,7 +555,7 @@ double SAL_CALL AnalysisAddIn::getMround( double fNum, double fMult ) if( fMult == 0.0 ) return fMult; -double fRet = fMult * ::rtl::math::round( fNum / fMult ); +double fRet = fMult * ::rtl::math::round( ::rtl::math::approxValue( fNum / fMult)); RETURN_FINITE( fRet ); }
[Libreoffice-bugs] [Bug 154957] Cropped area transparency lost on right of image
https://bugs.documentfoundation.org/show_bug.cgi?id=154957 Caolán McNamara changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |caol...@redhat.com |desktop.org | Status|NEW |ASSIGNED --- Comment #2 from Caolán McNamara --- Seeing as it was an optimization attempt I'll just revert it, but the same happens if I turn off tools, options, view, use anti-aliasing (and close and reopen the doc) and that precedes my effort. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: include/svx svx/source sw/source
include/svx/xmlexchg.hxx |7 +++--- svx/source/fmcomp/xmlexchg.cxx | 10 - svx/source/form/datanavi.cxx | 36 ++- sw/source/uibase/dochdl/swdtflvr.cxx |4 +-- 4 files changed, 34 insertions(+), 23 deletions(-) New commits: commit 1d0fadfd218b872ee5d4b07b88320c8f37667218 Author: Caolán McNamara AuthorDate: Fri Apr 21 16:16:02 2023 +0100 Commit: Caolán McNamara CommitDate: Fri Apr 21 21:18:00 2023 +0200 Resolves: tdf#154535 create the OXFormsDescriptor on-demand so we don't cause an unwanted Binding to be created unless we are forced to. Change-Id: Id78cbbb72ebd4e78b82a1ba614bbcb6488d04ce4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150769 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/include/svx/xmlexchg.hxx b/include/svx/xmlexchg.hxx index e03bdb4cfe31..73137c97c52b 100644 --- a/include/svx/xmlexchg.hxx +++ b/include/svx/xmlexchg.hxx @@ -23,6 +23,7 @@ #include #include #include +#include namespace com::sun::star::beans { class SAL_NO_VTABLE XPropertySet; @@ -61,17 +62,17 @@ namespace svx virtual voidAddSupportedFormats() override; virtual bool GetData( const css::datatransfer::DataFlavor& rFlavor, const OUString& rDestDoc ) override; -OXFormsDescriptor m_aDescriptor; +std::function m_getDescriptorFunc; public: /** construct the transferable */ -OXFormsTransferable( const OXFormsDescriptor ); +OXFormsTransferable(const std::function& getDescriptorFunc); /** extracts an xform descriptor from the transferable given */ -static const OXFormsDescriptor ( const TransferableDataHelper& _rData ); +static OXFormsDescriptor extractDescriptor( const TransferableDataHelper& _rData ); }; diff --git a/svx/source/fmcomp/xmlexchg.cxx b/svx/source/fmcomp/xmlexchg.cxx index 1f8d44ee7d3a..86bc1bbf46b9 100644 --- a/svx/source/fmcomp/xmlexchg.cxx +++ b/svx/source/fmcomp/xmlexchg.cxx @@ -27,8 +27,8 @@ namespace svx using namespace ::com::sun::star::datatransfer; -OXFormsTransferable::OXFormsTransferable( const OXFormsDescriptor ) : -m_aDescriptor(rhs) +OXFormsTransferable::OXFormsTransferable(const std::function& getDescriptorFunc) : +m_getDescriptorFunc(getDescriptorFunc) { } @@ -47,13 +47,13 @@ namespace svx return false; } -const OXFormsDescriptor ::extractDescriptor( const TransferableDataHelper &_rData ) { - +OXFormsDescriptor OXFormsTransferable::extractDescriptor( const TransferableDataHelper &_rData ) +{ using namespace ::com::sun::star::uno; Reference = const_cast &>(_rData.GetTransferable()); XTransferable *pInterface = transfer.get(); OXFormsTransferable& rThis = dynamic_cast(*pInterface); -return rThis.m_aDescriptor; +return rThis.m_getDescriptorFunc(); } } diff --git a/svx/source/form/datanavi.cxx b/svx/source/form/datanavi.cxx index cfacfa948fbe..a00747cd2633 100644 --- a/svx/source/form/datanavi.cxx +++ b/svx/source/form/datanavi.cxx @@ -300,19 +300,29 @@ namespace svxform return; } -OXFormsDescriptor desc; -desc.szName = m_xItemList->get_text(*m_xScratchIter); -if(pItemNode->m_xNode.is()) { -// a valid node interface tells us that we need to create a control from a binding -desc.szServiceName = GetServiceNameForNode(pItemNode->m_xNode); -desc.xPropSet = GetBindingForNode(pItemNode->m_xNode); -DBG_ASSERT( desc.xPropSet.is(), "DataTreeListBox::StartDrag(): invalid node binding" ); -} -else { -desc.szServiceName = FM_COMPONENT_COMMANDBUTTON; -desc.xPropSet = pItemNode->m_xPropSet; -} -xTransferable = rtl::Reference(new OXFormsTransferable(desc)); +OUString szName = m_xItemList->get_text(*m_xScratchIter); +Reference xNode(pItemNode->m_xNode); +Reference xPropSet(pItemNode->m_xPropSet); + +// tdf#154535 create the OXFormsDescriptor on-demand so we don't cause an unwanted +// Binding to be created unless we are forced to. +auto fnCreateFormsDescriptor = [this, szName, xNode, xPropSet](){ +OXFormsDescriptor desc; +desc.szName = szName; +if (xNode) { +// a valid node interface tells us that we need to create a control from a binding +desc.szServiceName = GetServiceNameForNode(xNode); +desc.xPropSet = GetBindingForNode(xNode); +DBG_ASSERT( desc.xPropSet.is(), "DataTreeListBox::StartDrag(): invalid node binding" ); +} +else { +desc.szServiceName = FM_COMPONENT_COMMANDBUTTON; +
[Libreoffice-bugs] [Bug 154960] New: the position of the text of the text-box isn't right on *.xhtml export
https://bugs.documentfoundation.org/show_bug.cgi?id=154960 Bug ID: 154960 Summary: the position of the text of the text-box isn't right on *.xhtml export Product: LibreOffice Version: 7.0.4.2 release Hardware: x86 (IA32) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Draw Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: solar...@mail.ru Created attachment 186846 --> https://bugs.documentfoundation.org/attachment.cgi?id=186846=edit a *.svg export of test.odg results fine but a *.xhtml export of test.odg results wrong! Simple explanation: == 1. Open Libreoffice-Draw 2. Insert an *.png image 3. Insert a text-box and write the following text inside: https://en.wikipedia.org/wiki/Memory_card 4. Drag the text-box inside/over the inserted image 5. Export to *.xhtml Conclusion: Bug: In the *.xhtml export the text of the text-box appears below the image. But if you make a *.png export or a *.svg export of the same, the text of the text-box appears where it should be (note: in these exports there are no bugs). Detailed explanation: 1. Go to site: https://en.wikipedia.org/wiki/Memory_card 2. Go to section of that site named: "Overview-of-all-memory-card-types" -> "Comparison" 3. With Firefox Web-browser do: right-mouse-click -> Take-Screenshot and screenshot that section of the site which is the same image that was inserted in "test.odg" provided in attachment. 4. Open Libreoffice-Draw 5. Insert the *.png image resulted from screenshot. 6. Insert a text-box and write the following text inside: https://en.wikipedia.org/wiki/Memory_card 7. Drag the text-box inside/over the inserted image 8. Export to *.xhtml Conclusion: Bug: In the *.xhtml export the text of the text-box appears below the image. But if you make a *.png export or a *.svg export of the same, the text of the text-box appears where it should be (note: in these exports there are no bugs). -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154789] EMF+ graphic causes hang / catastrophic memory leak
https://bugs.documentfoundation.org/show_bug.cgi?id=154789 Bartosz changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |gan...@poczta.onet.pl |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154957] Cropped area transparency lost on right of image
https://bugs.documentfoundation.org/show_bug.cgi?id=154957 Stéphane Guillou (stragu) changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154789] EMF+ graphic causes hang / catastrophic memory leak
https://bugs.documentfoundation.org/show_bug.cgi?id=154789 --- Comment #8 from Bartosz --- Created attachment 186845 --> https://bugs.documentfoundation.org/attachment.cgi?id=186845=edit Extracted EMF+ image which is causing performance issues -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108440] [META] Database form bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108440 Bug 108440 depends on bug 152614, which changed state. Bug 152614 Summary: Database Form Creation Wizard incorrectly distributes form controls in document. https://bugs.documentfoundation.org/show_bug.cgi?id=152614 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 113375] [META] Database wizard bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=113375 Bug 113375 depends on bug 152614, which changed state. Bug 152614 Summary: Database Form Creation Wizard incorrectly distributes form controls in document. https://bugs.documentfoundation.org/show_bug.cgi?id=152614 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152614] Database Form Creation Wizard incorrectly distributes form controls in document.
https://bugs.documentfoundation.org/show_bug.cgi?id=152614 Stéphane Guillou (stragu) changed: What|Removed |Added Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #9 from Stéphane Guillou (stragu) --- (In reply to Noel Grandin from comment #8) > On current master, I can't reproduce this? You're right, I can't see it in today's master build. Something in this ranged must have fixed it: https://git.libreoffice.org/core/+log/61b41646c5a93ca24f2c9f143cdb0da2c9258989..f6dbfbd2bfbd8a245bf42164bcb125528432cc38 Probably your 40babcfa637957bf7b59caa3cd12a630189e3e63 fix for bug 154827 and bug 154827, given that all 3 are regressions from the same commit. Could you please confirm and mark as fixed by you if that's the case? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154959] New: Brother QL700 label printer no longer rotates to landscape
https://bugs.documentfoundation.org/show_bug.cgi?id=154959 Bug ID: 154959 Summary: Brother QL700 label printer no longer rotates to landscape Product: LibreOffice Version: 7.5.2.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Printing and PDF export Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ba...@fastbk.com I have been printing labels to my Brother QL700 via LibreOffice for some time. It no longer will "rotate" to landscape and therefore I cannot print labels. This seems to have started with version 7.5.2.1. I am updated to 7.5.2.2, the latest available from OpenSuse Tumbleweed. I have verified the problem is not in the ppd file, as I can print labels to the printer via a Gnome program called "glabel". For some time, my LibreOffice label files have "saved" the necessary parameters and simply typing a new label has worked fine. Now, the same files will not print correctly, the label displays in "portrait" no matter what settings I change. I have tried "use only paper settings from printer preferences", "Printer language type > Postscript (Level from Driver)" and changing to "landscape" under both printer properties and the general print dialog tab. The correct label size displays in the print dialog, but it is in portrait instead of landscape, while the text is correctly in landscape (but only partially on the label). I have tried additional paper sizes, but the only paper dimensions are given for a portrait label and not a landscape one. The labels continue to display correctly in the wordprocessing/editing function, the errors are all in the print dialog. I tried printing in the hope that only the preview is wrong, but I cannot print a valid label. -- You are receiving this mail because: You are the assignee for the bug.