[Libreoffice-bugs] [Bug 63130] FILESAVE Working with a large Visio 2003 Drawing is slow
https://bugs.documentfoundation.org/show_bug.cgi?id=63130 Commit Notification changed: What|Removed |Added Whiteboard||target:7.6.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: basegfx/source include/basegfx solenv/clang-format
basegfx/source/matrix/b2dhommatrix.cxx | 92 +--
basegfx/source/matrix/b3dhommatrix.cxx |2
include/basegfx/matrix/b2dhommatrix.hxx | 27 ---
include/basegfx/matrix/hommatrixtemplate.hxx |3
solenv/clang-format/excludelist |2
5 files changed, 51 insertions(+), 75 deletions(-)
New commits:
commit 83650c82b56f496cd165981aa34edef9d5547697
Author: Noel Grandin
AuthorDate: Mon May 15 15:28:34 2023 +0200
Commit: Noel Grandin
CommitDate: Tue May 16 07:57:51 2023 +0200
tdf#63130 make B2DHomMatrix a flat object
instead of using COW for its data.
This takes the load time from 1m29 to 1m12
Also fix a bug in
ImplHomMatrixTemplate::operator=
which never triggered before because the usage
of o3tl::cow_wrapper means it very seldom gets used.
Change-Id: Ib0a7bdddf6c014f583e06d15e8dce5025e67e4a1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151793
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/basegfx/source/matrix/b2dhommatrix.cxx
b/basegfx/source/matrix/b2dhommatrix.cxx
index 9811304d..565be5c68b1c 100644
--- a/basegfx/source/matrix/b2dhommatrix.cxx
+++ b/basegfx/source/matrix/b2dhommatrix.cxx
@@ -18,7 +18,7 @@
*/
#include
-#include
+#include
#include
#include
#include
@@ -26,73 +26,50 @@
namespace basegfx
{
-typedef ::basegfx::internal::ImplHomMatrixTemplate< 3 >
Impl2DHomMatrix_Base;
-class Impl2DHomMatrix : public Impl2DHomMatrix_Base
-{
-};
-
-static o3tl::cow_wrapper DEFAULT;
-
-B2DHomMatrix::B2DHomMatrix() : mpImpl(DEFAULT) {}
-
-B2DHomMatrix::B2DHomMatrix(const B2DHomMatrix&) = default;
-
-B2DHomMatrix::B2DHomMatrix(B2DHomMatrix&&) = default;
-
-B2DHomMatrix::~B2DHomMatrix() = default;
B2DHomMatrix::B2DHomMatrix(double f_0x0, double f_0x1, double f_0x2,
double f_1x0, double f_1x1, double f_1x2)
{
-mpImpl->set(0, 0, f_0x0);
-mpImpl->set(0, 1, f_0x1);
-mpImpl->set(0, 2, f_0x2);
-mpImpl->set(1, 0, f_1x0);
-mpImpl->set(1, 1, f_1x1);
-mpImpl->set(1, 2, f_1x2);
-}
-
-B2DHomMatrix& B2DHomMatrix::operator=(const B2DHomMatrix&) = default;
-
-B2DHomMatrix& B2DHomMatrix::operator=(B2DHomMatrix&&) = default;
-
-double B2DHomMatrix::get(sal_uInt16 nRow, sal_uInt16 nColumn) const
-{
-return mpImpl->get(nRow, nColumn);
+maImpl.set(0, 0, f_0x0);
+maImpl.set(0, 1, f_0x1);
+maImpl.set(0, 2, f_0x2);
+maImpl.set(1, 0, f_1x0);
+maImpl.set(1, 1, f_1x1);
+maImpl.set(1, 2, f_1x2);
}
void B2DHomMatrix::set(sal_uInt16 nRow, sal_uInt16 nColumn, double fValue)
{
-mpImpl->set(nRow, nColumn, fValue);
+maImpl.set(nRow, nColumn, fValue);
}
void B2DHomMatrix::set3x2(double f_0x0, double f_0x1, double f_0x2, double
f_1x0, double f_1x1, double f_1x2)
{
-mpImpl->set(0, 0, f_0x0);
-mpImpl->set(0, 1, f_0x1);
-mpImpl->set(0, 2, f_0x2);
-mpImpl->set(1, 0, f_1x0);
-mpImpl->set(1, 1, f_1x1);
-mpImpl->set(1, 2, f_1x2);
+maImpl.set(0, 0, f_0x0);
+maImpl.set(0, 1, f_0x1);
+maImpl.set(0, 2, f_0x2);
+maImpl.set(1, 0, f_1x0);
+maImpl.set(1, 1, f_1x1);
+maImpl.set(1, 2, f_1x2);
}
bool B2DHomMatrix::isLastLineDefault() const
{
-return mpImpl->isLastLineDefault();
+return maImpl.isLastLineDefault();
}
bool B2DHomMatrix::isIdentity() const
{
-return mpImpl.same_object(DEFAULT) || mpImpl->isIdentity();
+return maImpl.isIdentity();
}
void B2DHomMatrix::identity()
{
-*mpImpl = Impl2DHomMatrix();
+maImpl = Impl2DHomMatrix();
}
bool B2DHomMatrix::isInvertible() const
{
-return mpImpl->isInvertible();
+return maImpl.isInvertible();
}
bool B2DHomMatrix::invert()
@@ -102,13 +79,13 @@ namespace basegfx
return true;
}
-Impl2DHomMatrix aWork(*mpImpl);
-sal_uInt16* pIndex = static_cast(alloca(
sizeof(sal_uInt16) * Impl2DHomMatrix_Base::getEdgeLength() ));
+Impl2DHomMatrix aWork(maImpl);
+sal_uInt16* pIndex = static_cast(alloca(
sizeof(sal_uInt16) * Impl2DHomMatrix::getEdgeLength() ));
sal_Int16 nParity;
if(aWork.ludcmp(pIndex, nParity))
{
-mpImpl->doInvert(aWork, pIndex);
+maImpl.doInvert(aWork, pIndex);
return true;
}
@@ -117,13 +94,13 @@ namespace basegfx
B2DHomMatrix& B2DHomMatrix::operator+=(const B2DHomMatrix& rMat)
{
-mpImpl->doAddMatrix(*rMat.mpImpl);
+maImpl.doAddMatrix(rMat.maImpl);
return *this;
}
B2DHomMatrix& B2DHomMatrix::operator-=(const B2DHomMatrix& rMat)
{
-mpImpl->doSubMatrix(*rMat.mpImpl);
+
[Libreoffice-bugs] [Bug 122247] [META] Icon requests
https://bugs.documentfoundation.org/show_bug.cgi?id=122247 Bug 122247 depends on bug 153789, which changed state. Bug 153789 Summary: Icons needed for new Uno commands WatchWindow and StackWindow in the Basic IDE https://bugs.documentfoundation.org/show_bug.cgi?id=153789 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155340] New: setting tabs in rule does not work
https://bugs.documentfoundation.org/show_bug.cgi?id=155340 Bug ID: 155340 Summary: setting tabs in rule does not work Product: LibreOffice Version: 7.6.0.0 alpha1+ Master Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rob...@iafrica.com Description: I cannot change the type of tab, nor can I set the tab by clicking in the ruler Steps to Reproduce: 1.open document 2.try to add or change a type of tab 3.click on symbol, click in ruler Actual Results: nothing happens Expected Results: should set tabs where indicated Reproducible: Always User Profile Reset: No Additional Info: [Information automatically included from LibreOffice] Locale: en-US Module: TextDocument [Information guessed from browser] OS: Linux (All) OS is 64bit: yes Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 002ae41bb6088002ba3ed0188ac822fb823a23f9 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-ZA (en_ZA.UTF-8); UI: en-US Calc: threaded works in v7.3 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155310] hyphenation line break function needs to be deprecated
https://bugs.documentfoundation.org/show_bug.cgi?id=155310 --- Comment #7 from Mike Kaganski --- (In reply to Ron from comment #6) > When you turn off auto hyphenation, it still auto-hyphenates dictionary > words containing hyphens. No. Auto-hyphenation is a process of *inserting* hyphens where they weren't normally shown, and *then* using this as a break opportunity. Pre-existing hyphens are not *inserted* so no, these words are *not* "auto-hyphenated"; and these existing hyphens in compounds are treated as normal breaking opportunities (just like spaces, which are also sometimes part of "dictionary words"). This is called orthography. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - include/vcl vcl/source vcl/unx
include/vcl/formatter.hxx |3 ++-
vcl/source/control/fmtfield.cxx |7 ++-
vcl/unx/gtk3/gtkinst.cxx| 13 -
3 files changed, 20 insertions(+), 3 deletions(-)
New commits:
commit cd2b0e5b6bdff92d08f94882cf44bde2a4114e9f
Author: Caolán McNamara
AuthorDate: Thu May 11 16:03:57 2023 +0100
Commit: Mike Kaganski
CommitDate: Tue May 16 06:36:12 2023 +0200
tdf#155241 keep current MetricSpinButton value if unparseable junk input
Change-Id: I0f13c9ae25c1788924fd81ed77307e96400f6220
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151734
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Mike Kaganski
diff --git a/include/vcl/formatter.hxx b/include/vcl/formatter.hxx
index 2049d1e12a6f..4aa81ea1be30 100644
--- a/include/vcl/formatter.hxx
+++ b/include/vcl/formatter.hxx
@@ -117,6 +117,7 @@ protected:
boolm_bAutoColor : 1;
boolm_bEnableNaN : 1;
boolm_bDisableRemainderFactor : 1;
+boolm_bDefaultValueSet : 1;
enum valueState { valueDirty, valueString, valueDouble };
valueState m_ValueState;
double m_dCurrentValue;
@@ -181,7 +182,7 @@ public:
voidEnableEmptyField(bool bEnable);
// If disabled, the value will be reset to the last valid value on leave
-voidSetDefaultValue(double dDefault){ m_dDefaultValue = dDefault;
m_ValueState = valueDirty; }
+voidSetDefaultValue(double dDefault){ m_dDefaultValue = dDefault;
m_ValueState = valueDirty; m_bDefaultValueSet = true; }
// If the current String is invalid, GetValue() returns this value
double GetDefaultValue() const { return m_dDefaultValue; }
diff --git a/vcl/source/control/fmtfield.cxx b/vcl/source/control/fmtfield.cxx
index d3f7d88985f2..33613c1395a3 100644
--- a/vcl/source/control/fmtfield.cxx
+++ b/vcl/source/control/fmtfield.cxx
@@ -266,6 +266,7 @@ Formatter::Formatter()
,m_bAutoColor(false)
,m_bEnableNaN(false)
,m_bDisableRemainderFactor(false)
+,m_bDefaultValueSet(false)
,m_ValueState(valueDirty)
,m_dCurrentValue(0)
,m_dDefaultValue(0)
@@ -791,7 +792,11 @@ bool Formatter::ImplGetValue(double& dNewVal)
if (m_ValueState == valueDouble)
return true;
-dNewVal = m_dDefaultValue;
+// tdf#155241 default to m_dDefaultValue only if explicitly set
+// otherwise default to m_dCurrentValue
+if (m_bDefaultValueSet)
+dNewVal = m_dDefaultValue;
+
OUString sText(GetEntryText());
if (sText.isEmpty())
return true;
diff --git a/vcl/unx/gtk3/gtkinst.cxx b/vcl/unx/gtk3/gtkinst.cxx
index 668ca5d1f156..d454fe8626f7 100644
--- a/vcl/unx/gtk3/gtkinst.cxx
+++ b/vcl/unx/gtk3/gtkinst.cxx
@@ -16570,6 +16570,11 @@ public:
m_aCustomFont.use_custom_font(, u"spinbutton");
}
+void set_update_policy_if_valid()
+{
+gtk_spin_button_set_update_policy(m_pButton, GTK_UPDATE_IF_VALID);
+}
+
virtual void disable_notify_events() override
{
g_signal_handler_block(m_pButton, m_nValueChangedSignalId);
@@ -23305,7 +23310,13 @@ public:
virtual std::unique_ptr
weld_metric_spin_button(const OString& id, FieldUnit eUnit) override
{
-return std::make_unique(weld_spin_button(id),
eUnit);
+std::unique_ptr xButton(weld_spin_button(id));
+if (xButton)
+{
+GtkInstanceSpinButton& rButton =
dynamic_cast(*xButton);
+rButton.set_update_policy_if_valid();
+}
+return std::make_unique(std::move(xButton),
eUnit);
}
virtual std::unique_ptr
weld_formatted_spin_button(const OString ) override
[Libreoffice-bugs] [Bug 31480] Find/replace non-printing characters easily
https://bugs.documentfoundation.org/show_bug.cgi?id=31480 --- Comment #88 from Thelaptopsguide --- https://legendaparafotosozinha.com/ https://xn--80aeecaeabbidqg7auldfcngzlt57a.com/ https://frasesmotivacionais.xyz/ https://поздравлениесднемрождения.com/ -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155310] hyphenation line break function needs to be deprecated
https://bugs.documentfoundation.org/show_bug.cgi?id=155310 --- Comment #6 from Ron --- When you turn off auto hyphenation, it still auto-hyphenates dictionary words containing hyphens. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155326] Calc with gtk3 VCL is unusable with large spreadsheets: huge lag, high CPU usage, etc.
https://bugs.documentfoundation.org/show_bug.cgi?id=155326 --- Comment #7 from q_user --- I've tested it - no change. (UI render = default in help->about, with or without SAL_SKIA=raster) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154628] XML Form Document: Sending data with GET fires very often
https://bugs.documentfoundation.org/show_bug.cgi?id=154628 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155320] After using the arrow keys to move the cursor, a "shadow" of the cursor will stay in place
https://bugs.documentfoundation.org/show_bug.cgi?id=155320 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155320] After using the arrow keys to move the cursor, a "shadow" of the cursor will stay in place
https://bugs.documentfoundation.org/show_bug.cgi?id=155320 --- Comment #4 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152062] Noto Serif Ahom font does not implement correctly in Libre Office
https://bugs.documentfoundation.org/show_bug.cgi?id=152062 --- Comment #6 from QA Administrators --- Dear Stephen Morey, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151555] Save As PDF fails
https://bugs.documentfoundation.org/show_bug.cgi?id=151555 --- Comment #5 from QA Administrators --- Dear nik, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151231] Change tracking formatting can't be modified
https://bugs.documentfoundation.org/show_bug.cgi?id=151231 --- Comment #4 from QA Administrators --- Dear Mike, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151824] Mysterious font colours in track changes
https://bugs.documentfoundation.org/show_bug.cgi?id=151824 --- Comment #3 from QA Administrators --- Dear philevedoug, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 117402] Invalid HTML for nested lists with Impress Preview in Web Browser
https://bugs.documentfoundation.org/show_bug.cgi?id=117402 --- Comment #7 from QA Administrators --- Dear lechten, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155339] XAccessibleStateSet Raise error on import in LO 7.5
https://bugs.documentfoundation.org/show_bug.cgi?id=155339 --- Comment #1 from vibrationofl...@pm.me --- I test on APT install and Snap install of LO 7.5, both fail the same. from com.sun.star.accessibility import XAccessibleStateSet Traceback (most recent call last): File "/usr/lib/python3.10/code.py", line 90, in runcode exec(code, self.locals) File "", line 1, in File "/usr/lib/python3/dist-packages/uno.py", line 428, in _uno_import raise uno_import_exc File "/usr/lib/python3/dist-packages/uno.py", line 349, in _uno_import return _builtin_import(name, *optargs, **kwargs) ImportError: No module named 'com' (or 'com.sun.star.accessibility.XAccessibleStateSet' is unknown) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155339] New: XAccessibleStateSet Raise error on import in LO 7.5
https://bugs.documentfoundation.org/show_bug.cgi?id=155339 Bug ID: 155339 Summary: XAccessibleStateSet Raise error on import in LO 7.5 Product: LibreOffice Version: 7.5.2.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: vibrationofl...@pm.me XAccessibleStateSet Raise error on import in LO 7.5 Works fine on 7.3 and 7.4 On 7.5 import fails from com.sun.star.accessibility import XAccessibleStateSet Traceback (most recent call last): File "", line 1, in File "/snap/libreoffice/275/lib/libreoffice/program/uno.py", line 425, in _uno_import raise uno_import_exc File "/snap/libreoffice/275/lib/libreoffice/program/uno.py", line 346, in _uno_import return _builtin_import(name, *optargs, **kwargs) ImportError: No module named 'com' (or 'com.sun.star.accessibility.XAccessibleStateSet' is unknown) I have only been able to test this on Linux (Ubuntu 22.04) so far. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: icon-themes/sifr icon-themes/sifr_dark icon-themes/sifr_dark_svg icon-themes/sifr_svg
icon-themes/sifr/cmd/32/stackwindow.png |binary icon-themes/sifr/cmd/32/watchwindow.png |binary icon-themes/sifr/cmd/lc_stackwindow.png |binary icon-themes/sifr/cmd/lc_watchwindow.png |binary icon-themes/sifr/cmd/sc_stackwindow.png |binary icon-themes/sifr/cmd/sc_watchwindow.png |binary icon-themes/sifr_dark/cmd/32/stackwindow.png |binary icon-themes/sifr_dark/cmd/32/watchwindow.png |binary icon-themes/sifr_dark/cmd/lc_stackwindow.png |binary icon-themes/sifr_dark/cmd/lc_watchwindow.png |binary icon-themes/sifr_dark/cmd/sc_stackwindow.png |binary icon-themes/sifr_dark/cmd/sc_watchwindow.png |binary icon-themes/sifr_dark_svg/cmd/32/stackwindow.svg |1 + icon-themes/sifr_dark_svg/cmd/32/watchwindow.svg |1 + icon-themes/sifr_dark_svg/cmd/lc_stackwindow.svg |1 + icon-themes/sifr_dark_svg/cmd/lc_watchwindow.svg |1 + icon-themes/sifr_dark_svg/cmd/sc_stackwindow.svg |1 + icon-themes/sifr_dark_svg/cmd/sc_watchwindow.svg |1 + icon-themes/sifr_svg/cmd/32/stackwindow.svg |1 + icon-themes/sifr_svg/cmd/32/watchwindow.svg |1 + icon-themes/sifr_svg/cmd/lc_stackwindow.svg |1 + icon-themes/sifr_svg/cmd/lc_watchwindow.svg |1 + icon-themes/sifr_svg/cmd/sc_stackwindow.svg |1 + icon-themes/sifr_svg/cmd/sc_watchwindow.svg |1 + 24 files changed, 12 insertions(+) New commits: commit 1303d88047e21fd40c0d1cf056727efc7d690d9c Author: Rizal Muttaqin AuthorDate: Mon May 15 21:56:37 2023 +0700 Commit: Rizal Muttaqin CommitDate: Tue May 16 04:57:13 2023 +0200 tdf#153789 sifr icons for Watched Expressions and Call Stack Change-Id: I9bd81878f931f78ed0b7d73a03cbc89d3d8347c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151797 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin diff --git a/icon-themes/sifr/cmd/32/stackwindow.png b/icon-themes/sifr/cmd/32/stackwindow.png new file mode 100644 index ..185254069e50 Binary files /dev/null and b/icon-themes/sifr/cmd/32/stackwindow.png differ diff --git a/icon-themes/sifr/cmd/32/watchwindow.png b/icon-themes/sifr/cmd/32/watchwindow.png new file mode 100644 index ..e8702835b0d4 Binary files /dev/null and b/icon-themes/sifr/cmd/32/watchwindow.png differ diff --git a/icon-themes/sifr/cmd/lc_stackwindow.png b/icon-themes/sifr/cmd/lc_stackwindow.png new file mode 100644 index ..cac5e991da13 Binary files /dev/null and b/icon-themes/sifr/cmd/lc_stackwindow.png differ diff --git a/icon-themes/sifr/cmd/lc_watchwindow.png b/icon-themes/sifr/cmd/lc_watchwindow.png new file mode 100644 index ..907c052a435f Binary files /dev/null and b/icon-themes/sifr/cmd/lc_watchwindow.png differ diff --git a/icon-themes/sifr/cmd/sc_stackwindow.png b/icon-themes/sifr/cmd/sc_stackwindow.png new file mode 100644 index ..eca254368c68 Binary files /dev/null and b/icon-themes/sifr/cmd/sc_stackwindow.png differ diff --git a/icon-themes/sifr/cmd/sc_watchwindow.png b/icon-themes/sifr/cmd/sc_watchwindow.png new file mode 100644 index ..a4e02f89ef3d Binary files /dev/null and b/icon-themes/sifr/cmd/sc_watchwindow.png differ diff --git a/icon-themes/sifr_dark/cmd/32/stackwindow.png b/icon-themes/sifr_dark/cmd/32/stackwindow.png new file mode 100644 index ..7c4367a06ce5 Binary files /dev/null and b/icon-themes/sifr_dark/cmd/32/stackwindow.png differ diff --git a/icon-themes/sifr_dark/cmd/32/watchwindow.png b/icon-themes/sifr_dark/cmd/32/watchwindow.png new file mode 100644 index ..09cdb4e108db Binary files /dev/null and b/icon-themes/sifr_dark/cmd/32/watchwindow.png differ diff --git a/icon-themes/sifr_dark/cmd/lc_stackwindow.png b/icon-themes/sifr_dark/cmd/lc_stackwindow.png new file mode 100644 index ..f29f31d70872 Binary files /dev/null and b/icon-themes/sifr_dark/cmd/lc_stackwindow.png differ diff --git a/icon-themes/sifr_dark/cmd/lc_watchwindow.png b/icon-themes/sifr_dark/cmd/lc_watchwindow.png new file mode 100644 index ..4183cad29dc3 Binary files /dev/null and b/icon-themes/sifr_dark/cmd/lc_watchwindow.png differ diff --git a/icon-themes/sifr_dark/cmd/sc_stackwindow.png b/icon-themes/sifr_dark/cmd/sc_stackwindow.png new file mode 100644 index ..eebc43e0dc77 Binary files /dev/null and b/icon-themes/sifr_dark/cmd/sc_stackwindow.png differ diff --git a/icon-themes/sifr_dark/cmd/sc_watchwindow.png b/icon-themes/sifr_dark/cmd/sc_watchwindow.png new file mode 100644 index ..837803bce55b Binary files /dev/null and b/icon-themes/sifr_dark/cmd/sc_watchwindow.png differ diff --git a/icon-themes/sifr_dark_svg/cmd/32/stackwindow.svg b/icon-themes/sifr_dark_svg/cmd/32/stackwindow.svg new file mode 100644 index ..b4364383864d --- /dev/null +++ b/icon-themes/sifr_dark_svg/cmd/32/stackwindow.svg @@ -0,0 +1 @@ +http://www.w3.org/2000/svg;> \ No newline at end of
[Libreoffice-bugs] [Bug 155320] After using the arrow keys to move the cursor, a "shadow" of the cursor will stay in place
https://bugs.documentfoundation.org/show_bug.cgi?id=155320 --- Comment #3 from tumbleweed1...@outlook.com --- Created attachment 187316 --> https://bugs.documentfoundation.org/attachment.cgi?id=187316=edit 截图 Version: 7.5.3.2 (X86_64) / LibreOffice Community Build ID: 9f56dff12ba03b9acd7730a5a481eea045e468f3 CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Vulkan; VCL: win Locale: zh-CN (zh_CN); UI: zh-CN Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155338] Fill option in the sidebar inappropriately launches the Area dialog box upon attempting to a change a fill's color
https://bugs.documentfoundation.org/show_bug.cgi?id=155338 m.a.riosv changed: What|Removed |Added Status|NEEDINFO|NEW Keywords||bibisectRequest, regression --- Comment #7 from m.a.riosv --- Reproducible. Version: 7.6.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: 6f1534940ac12ff8e46f4782e18cfb6cf585da39 CPU threads: 16; OS: Windows 10.0 Build 22621; UI render: default; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL threaded regression from Version: 7.5.3.2 (X86_64) / LibreOffice Community Build ID: 9f56dff12ba03b9acd7730a5a481eea045e468f3 CPU threads: 16; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155338] Fill option in the sidebar inappropriately launches the Area dialog box upon attempting to a change a fill's color
https://bugs.documentfoundation.org/show_bug.cgi?id=155338 --- Comment #6 from xordevore...@gmail.com --- Attachment isn't corrupt or zero length. Here it is on imgur. https://i.imgur.com/H3W8GhF.mp4 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155338] Fill option in the sidebar inappropriately launches the Area dialog box upon attempting to a change a fill's color
https://bugs.documentfoundation.org/show_bug.cgi?id=155338 --- Comment #5 from xordevore...@gmail.com --- Created attachment 187315 --> https://bugs.documentfoundation.org/attachment.cgi?id=187315=edit short video showing what happens during fill color selection Vidcap showing issue. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155338] Fill option in the sidebar inappropriately launches the Area dialog box upon attempting to a change a fill's color
https://bugs.documentfoundation.org/show_bug.cgi?id=155338 --- Comment #4 from m.a.riosv --- Can you take a screenshot? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155338] Fill option in the sidebar inappropriately launches the Area dialog box upon attempting to a change a fill's color
https://bugs.documentfoundation.org/show_bug.cgi?id=155338 xordevore...@gmail.com changed: What|Removed |Added CC||xordevore...@gmail.com --- Comment #3 from xordevore...@gmail.com --- Completely deleted the profile under \AppData\Roaming\LibreOfficeDev and then relaunched. Same result. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149292] FILEOPEN DOCX First page style not applied to table-in-table
https://bugs.documentfoundation.org/show_bug.cgi?id=149292 --- Comment #8 from Justin L --- repro 7.6+ -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155338] Fill option in the sidebar inappropriately launches the Area dialog box upon attempting to a change a fill's color
https://bugs.documentfoundation.org/show_bug.cgi?id=155338 m.a.riosv changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO --- Comment #2 from m.a.riosv --- Please test with a clean profile, Menu/Help/Restart in Safe Mode -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155338] Fill option in the sidebar inappropriately launches the Area dialog box upon attempting to a change a fill's color
https://bugs.documentfoundation.org/show_bug.cgi?id=155338 m.a.riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg --- Comment #1 from m.a.riosv --- Works for me. Version: 7.6.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: 99a88c9e55872214ce01d89447d18708e47e956b CPU threads: 16; OS: Windows 10.0 Build 22621; UI render: default; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150582] Words with smart quotes/apostrophes get added to custom dictionaries via Writer but not Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=150582 --- Comment #2 from xordevore...@gmail.com --- Still a problem in Version: 7.6.0.0.alpha1 (X86_64) / LibreOffice Community Build ID: 9366f83c88fc93d40ea0c0035508f24ad5dcb144 CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145716] Saving document as Word (docx) does not preserve paragraph space above/below correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=145716 Justin L changed: What|Removed |Added Severity|normal |minor Priority|medium |low --- Comment #6 from Justin L --- repro 7.6+ Also repro that when saving to .doc format, the gap is 2cm. repro that MS Word 2010 looks identical for both doc and docx. While I can sympathize with the desire that ODT should massage the data to export pixel perfect into DOCX format, the reality will be very different in cases where there are compatibility flags, especially when DOC is different. The solution is easy - fix the layout once after switching formats and move on. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145130] Changing an LO Draw's background gradient color resets its gradient type, angle, and other properties
https://bugs.documentfoundation.org/show_bug.cgi?id=145130 --- Comment #6 from xordevore...@gmail.com --- Still a problem in: Version: 7.6.0.0.alpha1 (X86_64) / LibreOffice Community Build ID: 9366f83c88fc93d40ea0c0035508f24ad5dcb144 CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149872] Sidebar properties switch from what we're manipulating to the page's properties after merging two shapes
https://bugs.documentfoundation.org/show_bug.cgi?id=149872 --- Comment #4 from xordevore...@gmail.com --- Still a problem in: Version: 7.6.0.0.alpha1 (X86_64) / LibreOffice Community Build ID: 9366f83c88fc93d40ea0c0035508f24ad5dcb144 CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 136844] Undo / Control-Z does not undo slide background choice in Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=136844 --- Comment #15 from xordevore...@gmail.com --- Still a problem in: Version: 7.6.0.0.alpha1 (X86_64) / LibreOffice Community Build ID: 9366f83c88fc93d40ea0c0035508f24ad5dcb144 CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139106] Only first slide's background is updated in Windows 10 LO Draw when all slides are selected
https://bugs.documentfoundation.org/show_bug.cgi?id=139106 --- Comment #12 from xordevore...@gmail.com --- Still a problem in: Version: 7.6.0.0.alpha1 (X86_64) / LibreOffice Community Build ID: 9366f83c88fc93d40ea0c0035508f24ad5dcb144 CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 123973] Master objects in a LO Draw document export with TIFF but not PNG or GIF when exported with transparency
https://bugs.documentfoundation.org/show_bug.cgi?id=123973 --- Comment #41 from xordevore...@gmail.com --- Still a problem in: Version: 7.6.0.0.alpha1 (X86_64) / LibreOffice Community Build ID: 9366f83c88fc93d40ea0c0035508f24ad5dcb144 CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 119079] FILEOPEN DOC: character properties affecting CR, but shouldn't
https://bugs.documentfoundation.org/show_bug.cgi?id=119079 --- Comment #8 from Justin L --- repro 7.6+ -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155338] New: Fill option in the sidebar inappropriately launches the Area dialog box upon attempting to a change a fill's color
https://bugs.documentfoundation.org/show_bug.cgi?id=155338 Bug ID: 155338 Summary: Fill option in the sidebar inappropriately launches the Area dialog box upon attempting to a change a fill's color Product: LibreOffice Version: 7.6.0.0 alpha1+ Master Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Draw Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: xordevore...@gmail.com Description: Previously, when changing a drawing element's color, all I did was select the element (such as a square), select the color under the property tab under the Fill: Color drop-down, done. Now it launches the Area dialog box, which presents way more than what I'm trying to do when simply wanting to change something's color. Steps to Reproduce: 1. Launch LO Draw in Microsoft Windows 2. Draw a simple shape (circle, square, whatever) 3. Expose the property sidebar if not already showing 4. Under the Fill: Option (which should be shown defaulting to "color") attempt to change the shape's color using the supplied drop-down. Actual Results: Area dialog box appears rather than changing the shape's color Expected Results: Just change the shape's color Reproducible: Always User Profile Reset: No Additional Info: Version: 7.6.0.0.alpha1 (X86_64) / LibreOffice Community Build ID: 9366f83c88fc93d40ea0c0035508f24ad5dcb144 CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141135] GTK3 version: in tabbed, tabbed compact, and groupedbar compact toolbar modes, the menu entries to switch between Normal and Web view modes are checkboxes instead of ra
https://bugs.documentfoundation.org/show_bug.cgi?id=141135 Justin L changed: What|Removed |Added Version|7.0.4.2 release |unspecified -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140529] Enhancement: Glow Effect needs to work on more than base shapes
https://bugs.documentfoundation.org/show_bug.cgi?id=140529 --- Comment #3 from xordevore...@gmail.com --- Still not available in Version: 7.6.0.0.alpha1 (X86_64) / LibreOffice Community Build ID: 9366f83c88fc93d40ea0c0035508f24ad5dcb144 CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded attempting to assign a glow effect to text that's been converted to a curve. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155330] FILEOPEN: PPT: Incorrect font size
https://bugs.documentfoundation.org/show_bug.cgi?id=155330 --- Comment #2 from Tomaz Vajngerl --- The issue with this one is not that the auto-fitting is misbehaving and the text size is wrong. The issue is that none of the text boxes in the document should be set to "autofit text" = true at all. All of them in MSO have auto-fitting disabled. You can see this issue clearly on page 5 where MSO and LO differ even with the older auto-fitting algorithm, but if you turn of "autofit text" the rendering MSO and LO match. So the issue is an old one, but the issue manifested only now when auto-fitting has changed. Converting in MSO to pptx and opening in LO renders correctly, which makes me happy. I'll look if this can be solved quickly. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144654] Switching LO draw from any visible page margin to None and undoing the change does not restore the side margins
https://bugs.documentfoundation.org/show_bug.cgi?id=144654 --- Comment #9 from xordevore...@gmail.com --- Still a problem in Version: 7.6.0.0.alpha1 (X86_64) / LibreOffice Community Build ID: 9366f83c88fc93d40ea0c0035508f24ad5dcb144 CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 134375] Position and size property box in LO should show 0.00 when abutting a document's edge not be blank
https://bugs.documentfoundation.org/show_bug.cgi?id=134375 --- Comment #18 from xordevore...@gmail.com --- Created attachment 187314 --> https://bugs.documentfoundation.org/attachment.cgi?id=187314=edit screencap showing missing properties in sidebar Weirdness continues. Created a new Draw document in Version: 7.6.0.0.alpha1 (X86_64) / LibreOffice Community Build ID: 9366f83c88fc93d40ea0c0035508f24ad5dcb144 CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded ...and now the x/y position shows up but not the width and height (see attachment). Only after clicking, clicking off, adding new shapes, flipping between pages, more clicking, etc., did all four show up --and-- it didn't matter where on the page the drawing elements were. I then created a new shape, and its x/y/w/h properties were completely blank until more fiddling around. All four properties should appear in real time in the side bar after each move/edit of a drawing element. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143761] Access to image colorization commands from sidebar deck
https://bugs.documentfoundation.org/show_bug.cgi?id=143761 --- Comment #12 from xordevore...@gmail.com --- While still not available in the sidebar in Version: 7.6.0.0.alpha1 (X86_64) / LibreOffice Community Build ID: 9366f83c88fc93d40ea0c0035508f24ad5dcb144 CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded the color control is accessible easily enough when in using the "tabbed" UI variant under "Select Your Preferred User Interface." People not using the tabbed UI variant still have to hunt down the % color options by finding the color control. Having switched to tabbed views, my problem is solved, but the issue remains regarding the sidebar, so... not sure what to say about the state of the bug. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145081] Line spacing style type "Fixed" is exposed on the property side bar but not on the style sheet dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=145081 --- Comment #4 from xordevore...@gmail.com --- Still a problem in Version: 7.6.0.0.alpha1 (X86_64) / LibreOffice Community Build ID: 9366f83c88fc93d40ea0c0035508f24ad5dcb144 CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155096] FORMCONTROLS: Combo box exports fonts inconsistently to other form controls
https://bugs.documentfoundation.org/show_bug.cgi?id=155096 --- Comment #12 from Steve --- Created attachment 187313 --> https://bugs.documentfoundation.org/attachment.cgi?id=187313=edit Textbox + combobox PDF font properties -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155096] FORMCONTROLS: Combo box exports fonts inconsistently to other form controls
https://bugs.documentfoundation.org/show_bug.cgi?id=155096 --- Comment #11 from Steve --- Created attachment 187312 --> https://bugs.documentfoundation.org/attachment.cgi?id=187312=edit Combobox-only PDF font properties -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155096] FORMCONTROLS: Combo box exports fonts inconsistently to other form controls
https://bugs.documentfoundation.org/show_bug.cgi?id=155096 --- Comment #10 from Steve --- Created attachment 187311 --> https://bugs.documentfoundation.org/attachment.cgi?id=187311=edit Combobox-only exported PDF -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155096] FORMCONTROLS: Combo box exports fonts inconsistently to other form controls
https://bugs.documentfoundation.org/show_bug.cgi?id=155096 --- Comment #9 from Steve --- Created attachment 187310 --> https://bugs.documentfoundation.org/attachment.cgi?id=187310=edit Combobox-only source file -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155096] FORMCONTROLS: Combo box exports fonts inconsistently to other form controls
https://bugs.documentfoundation.org/show_bug.cgi?id=155096 --- Comment #8 from Steve --- Created attachment 187309 --> https://bugs.documentfoundation.org/attachment.cgi?id=187309=edit Textbox-only PDF font properties -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155096] FORMCONTROLS: Combo box exports fonts inconsistently to other form controls
https://bugs.documentfoundation.org/show_bug.cgi?id=155096 --- Comment #7 from Steve --- Created attachment 187308 --> https://bugs.documentfoundation.org/attachment.cgi?id=187308=edit Textbox-only exported PDF -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155096] FORMCONTROLS: Combo box exports fonts inconsistently to other form controls
https://bugs.documentfoundation.org/show_bug.cgi?id=155096 --- Comment #6 from Steve --- Created attachment 187307 --> https://bugs.documentfoundation.org/attachment.cgi?id=187307=edit Textbox only source file -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155096] FORMCONTROLS: Combo box exports fonts inconsistently to other form controls
https://bugs.documentfoundation.org/show_bug.cgi?id=155096 --- Comment #5 from Steve --- (In reply to Buovjaga from comment #4) > (In reply to Steve from comment #0) > > I can't test this as I don't have Acrobat, but Type 1 fonts are not > supported in LibreOffice (and most software these days). My point is that Combo boxes should export the font in the same manner as text boxes, date fields, numeric fields, etc. In the current stable build they do not and it does cause problems and in my opinion should be made consistent. I will attach another two source files, one with only textbox and the other with only combobox. I have also attached screenshots from Acrobat File -> Properties -> Font tab to show the differences between the 3 cases (textbox only, combobox only, textbox and combobox). You will see that textbox-only contains Times Roman, combobox contains TimesNewRomanPSMT, and the textbox+combobox contains both. Please let me know if there is anything else I can do to assist your understanding of this issue. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/source
sw/source/core/doc/docbm.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 22950a9b008e1bb22fa9e54b5d45715e25fee764
Author: Justin Luth
AuthorDate: Wed May 10 10:49:56 2023 -0400
Commit: Justin Luth
CommitDate: Tue May 16 01:36:10 2023 +0200
tdf#154956 sw: delete bookmarks at end: fix crashtesting
This fixes LO 7.6 commit 21b1dd42e9a817ae9b68e9e13ea57ce2491940c6
wget https://bugs.documentfoundation.org/attachment.cgi?id=124859 \
-O ~/tdf99692-1.odt
./instdir/program/soffice --headless --convert-to odt ~/tdf99692-1.odt
sw/source/core/crsr/pam.cxx:268: void SwPosition::SetContent(sal_Int32):
Assertion `nNode.GetNode().GetContentNode()
&& "only valid to call this if we point to an SwContentNode"' failed.
Change-Id: Ic8280bf56f1e7f339fdff3e9591470bc74aa0d5b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151639
Tested-by: Jenkins
Reviewed-by: Justin Luth
diff --git a/sw/source/core/doc/docbm.cxx b/sw/source/core/doc/docbm.cxx
index ab5e544c2358..2d8a411a9c5d 100644
--- a/sw/source/core/doc/docbm.cxx
+++ b/sw/source/core/doc/docbm.cxx
@@ -2063,7 +2063,7 @@ void DelBookmarks(
if( lcl_Greater( *pREnd, rStt, oStartContentIdx ) && lcl_Lower(
*pREnd, rEnd, oEndContentIdx ))
{
pREnd->Assign( rStt );
-if( oStartContentIdx )
+if (oStartContentIdx && rStt.IsContentNode())
pREnd->SetContent( *oStartContentIdx );
else
{
[Libreoffice-bugs] [Bug 154876] FORMCONTROLS: Radio button reference value (on) not passed exported to PDF
https://bugs.documentfoundation.org/show_bug.cgi?id=154876 --- Comment #10 from Steve --- Hi Xisco Yes it is reproducible with latest stable build. That's how I discovered it. I knew earlier versions had worked so I went back and checked. The issue seems to be with the export rather than the source file. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 109072] [META] XLS (binary) format bug tracker
https://bugs.documentfoundation.org/show_bug.cgi?id=109072 Bug 109072 depends on bug 79542, which changed state. Bug 79542 Summary: FORMCONTROLS: .xls - Option buttons contained in group boxes are not grouped. https://bugs.documentfoundation.org/show_bug.cgi?id=79542 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 107742] [META] Form control bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107742 Bug 107742 depends on bug 79542, which changed state. Bug 79542 Summary: FORMCONTROLS: .xls - Option buttons contained in group boxes are not grouped. https://bugs.documentfoundation.org/show_bug.cgi?id=79542 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 79542] FORMCONTROLS: .xls - Option buttons contained in group boxes are not grouped.
https://bugs.documentfoundation.org/show_bug.cgi?id=79542 Justin L changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED Assignee|libreoffice-b...@lists.free |jl...@mail.com |desktop.org | --- Comment #18 from Justin L --- This could be backported to 7.5 - the bug it depends on was fixed there. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 120177] FILEOPEN XLS: Radio button Form controls no longer grouped
https://bugs.documentfoundation.org/show_bug.cgi?id=120177 Justin L changed: What|Removed |Added Whiteboard|target:7.6.0|target:7.5.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 112762] [META] DOC (binary) page-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=112762 Bug 112762 depends on bug 144362, which changed state. Bug 144362 Summary: FILESAVE DOC: 2 columns section merge with next section https://bugs.documentfoundation.org/show_bug.cgi?id=144362 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sc/qa sc/source
sc/qa/unit/data/xls/tdf79542_radioGroupBox.xls |binary
sc/qa/unit/subsequent_filters_test4.cxx| 20
sc/source/filter/excel/xiescher.cxx| 60 +
sc/source/filter/inc/xiescher.hxx |6 ++
4 files changed, 86 insertions(+)
New commits:
commit 25fed4ae027b9680597ea498c25acc3f854db4bf
Author: Justin Luth
AuthorDate: Thu Aug 4 19:52:23 2022 -0400
Commit: Justin Luth
CommitDate: Tue May 16 01:01:27 2023 +0200
tdf#79542 xls: applyGroupBox to radiobutton groups
A group box control links radiobuttons together,
and so does a sheet.
No matching unit tests were found.
make CppunitTest_sc_subsequent_filters_test4 \
CPPUNIT_TEST_NAME=testLegacyOptionButtonGroupBox
Change-Id: Ib5b03c68b5218649268f283d11981cc03fe4850a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137838
Tested-by: Jenkins
Reviewed-by: Justin Luth
diff --git a/sc/qa/unit/data/xls/tdf79542_radioGroupBox.xls
b/sc/qa/unit/data/xls/tdf79542_radioGroupBox.xls
new file mode 100644
index ..1861913020d3
Binary files /dev/null and b/sc/qa/unit/data/xls/tdf79542_radioGroupBox.xls
differ
diff --git a/sc/qa/unit/subsequent_filters_test4.cxx
b/sc/qa/unit/subsequent_filters_test4.cxx
index fcbc02ebe0a3..d6b853607e51 100644
--- a/sc/qa/unit/subsequent_filters_test4.cxx
+++ b/sc/qa/unit/subsequent_filters_test4.cxx
@@ -116,6 +116,26 @@ CPPUNIT_TEST_FIXTURE(ScFiltersTest4, testControlImport)
UNO_QUERY_THROW);
}
+CPPUNIT_TEST_FIXTURE(ScFiltersTest4, testLegacyOptionButtonGroupBox)
+{
+createScDoc("xls/tdf79542_radioGroupBox.xls");
+uno::Reference xDoc(mxComponent,
UNO_QUERY_THROW);
+uno::Reference xIA(xDoc->getSheets(),
UNO_QUERY_THROW);
+uno::Reference
xDrawPageSupplier(xIA->getByIndex(0),
+
UNO_QUERY_THROW);
+uno::Reference
xIA_DrawPage(xDrawPageSupplier->getDrawPage(),
+ UNO_QUERY_THROW);
+
+OUString sGroupName;
+uno::Reference
xControlShape(xIA_DrawPage->getByIndex(1),
+ UNO_QUERY_THROW);
+uno::Reference
xPropertySet(xControlShape->getControl(),
+ uno::UNO_QUERY_THROW);
+// The radio buttons are grouped by GroupBoxes - so the name comes from
the group shape name
+xPropertySet->getPropertyValue("GroupName") >>= sGroupName;
+CPPUNIT_ASSERT_EQUAL(OUString("Casella di gruppo 1"), sGroupName);
+}
+
CPPUNIT_TEST_FIXTURE(ScFiltersTest4, testActiveXOptionButtonGroup)
{
createScDoc("xlsx/tdf111980_radioButtons.xlsx");
diff --git a/sc/source/filter/excel/xiescher.cxx
b/sc/source/filter/excel/xiescher.cxx
index e9a47fada31c..1805b7a26312 100644
--- a/sc/source/filter/excel/xiescher.cxx
+++ b/sc/source/filter/excel/xiescher.cxx
@@ -378,6 +378,11 @@ void XclImpDrawObjBase::SetAnchor( const XclObjAnchor&
rAnchor )
mbHasAnchor = true;
}
+const tools::Rectangle& XclImpDrawObjBase::GetDffRect() const
+{
+return maDffRect;
+}
+
void XclImpDrawObjBase::SetDffData(
const DffObjData& rDffObjData, const OUString& rObjName, const OUString&
rHyperlink,
bool bVisible, bool bAutoMargin )
@@ -388,6 +393,7 @@ void XclImpDrawObjBase::SetDffData(
maHyperlink = rHyperlink;
mbVisible = bVisible;
mbAutoMargin = bAutoMargin;
+maDffRect = rDffObjData.aChildAnchor;
}
OUString XclImpDrawObjBase::GetObjName() const
@@ -2086,6 +2092,16 @@ void XclImpTbxObjBase::SetDffProperties( const
DffPropSet& rDffPropSet )
::set_flag( maLineData.mnAuto, EXC_OBJ_FILL_AUTO, false );
}
+void XclImpControlHelper::SetStringProperty(const OUString& sName, const
OUString& sVal)
+{
+Reference xCtrlModel =
XclControlHelper::GetControlModel(mxShape);
+if (!xCtrlModel.is())
+return;
+
+ScfPropertySet aProps(xCtrlModel);
+aProps.SetStringProperty(sName, sVal);
+}
+
bool XclImpTbxObjBase::FillMacroDescriptor( ScriptEventDescriptor& rDescriptor
) const
{
return XclControlHelper::FillMacroDescriptor( rDescriptor,
DoGetEventType(), GetMacroName(), GetDocShell() );
@@ -2393,6 +2409,11 @@ XclTbxEventType XclImpOptionButtonObj::DoGetEventType()
const
return EXC_TBX_EVENT_ACTION;
}
+bool XclImpOptionButtonObj::IsInGroup() const
+{
+return mnNextInGroup;
+}
+
XclImpLabelObj::XclImpLabelObj( const XclImpRoot& rRoot ) :
XclImpTbxObjBase( rRoot )
{
@@ -4070,6 +4091,43 @@ const XclImpObjTextData* XclImpDrawing::FindTextData(
const DffRecordHeader& rHe
return nullptr;
}
+void XclImpDrawing::ApplyGroupBoxes()
+{
+// sorted: smallest to largest - looking for smallest contained-in GroupBox
+// multimap: allows duplicate key values - may have identical areas.
+std::multimap aGroupBoxAreaMap;
+for (auto&
[Libreoffice-bugs] [Bug 79542] FORMCONTROLS: .xls - Option buttons contained in group boxes are not grouped.
https://bugs.documentfoundation.org/show_bug.cgi?id=79542 Commit Notification changed: What|Removed |Added Whiteboard|BSA |BSA target:7.6.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/qa sw/source
sw/qa/extras/ooxmlexport/data/tdf144362.odt |binary
sw/qa/extras/ooxmlexport/ooxmlexport9.cxx | 26 ++
sw/source/filter/ww8/wrtw8sty.cxx |8 +++-
sw/source/filter/ww8/wrtww8.hxx |2 +-
sw/source/filter/ww8/ww8atr.cxx | 25 +
5 files changed, 55 insertions(+), 6 deletions(-)
New commits:
commit 67d4fe32713070be5688eef2da9377a91e2f6b81
Author: Justin Luth
AuthorDate: Sat May 13 22:17:07 2023 -0400
Commit: Justin Luth
CommitDate: Tue May 16 00:59:52 2023 +0200
tdf#144362 doc/x export: different columns mean new section
The situation causing this may have become more likely in 7.4.0.
I think that tdf#149313 might have caused a regression in the
unit test that I found that exhibited the problem,
so I am adding another one.
make CppunitTest_sw_ooxmlexport9
CPPUNIT_TEST_NAME=testTdf97648_relativeWidth
make CppunitTest_sw_ooxmlexport9 CPPUNIT_TEST_NAME=testTdf144362
Change-Id: I8e668ac7bfb01a8704634a3e16243be7298bd1ee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151731
Tested-by: Jenkins
Reviewed-by: Justin Luth
diff --git a/sw/qa/extras/ooxmlexport/data/tdf144362.odt
b/sw/qa/extras/ooxmlexport/data/tdf144362.odt
new file mode 100644
index ..9c161dbdeb7f
Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/tdf144362.odt differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport9.cxx
b/sw/qa/extras/ooxmlexport/ooxmlexport9.cxx
index fc4a1c9f1445..0dbad12503bf 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport9.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport9.cxx
@@ -529,6 +529,32 @@ DECLARE_OOXMLEXPORT_TEST(testTdf97648_relativeWidth,
"tdf97648_relativeWidth.doc
CPPUNIT_ASSERT_EQUAL(text::HoriOrientation::RIGHT,
getProperty(getShape(3), "HoriOrient"));
CPPUNIT_ASSERT_EQUAL(text::HoriOrientation::LEFT,
getProperty(getShape(4), "HoriOrient"));
}
+
+uno::Reference
xTextSectionsSupplier(mxComponent, uno::UNO_QUERY);
+uno::Reference
xSections(xTextSectionsSupplier->getTextSections(),
+ uno::UNO_QUERY);
+
+CPPUNIT_ASSERT_EQUAL(sal_Int32(3), xSections->getCount());
+
+uno::Reference xTextSection(xSections->getByIndex(2),
uno::UNO_QUERY);
+uno::Reference xTextColumns
+= getProperty>(xTextSection,
"TextColumns");
+CPPUNIT_ASSERT_EQUAL(sal_Int16(2), xTextColumns->getColumnCount());
+}
+
+DECLARE_OOXMLEXPORT_TEST(testTdf144362, "tdf144362.odt")
+{
+uno::Reference
xTextSectionsSupplier(mxComponent, uno::UNO_QUERY);
+uno::Reference
xSections(xTextSectionsSupplier->getTextSections(),
+ uno::UNO_QUERY);
+
+// This is difference OK: tdf#107837 extra section added on export to
preserve balanced columns.
+CPPUNIT_ASSERT_GREATEREQUAL(sal_Int32(2), xSections->getCount());
+
+uno::Reference xTextSection(xSections->getByIndex(1),
uno::UNO_QUERY);
+uno::Reference xTextColumns
+= getProperty>(xTextSection,
"TextColumns");
+CPPUNIT_ASSERT_EQUAL(sal_Int16(2), xTextColumns->getColumnCount());
}
DECLARE_OOXMLEXPORT_TEST(testTdf104061_tableSectionColumns,"tdf104061_tableSectionColumns.docx")
diff --git a/sw/source/filter/ww8/wrtw8sty.cxx
b/sw/source/filter/ww8/wrtw8sty.cxx
index 8e0bcdde91a1..cf62d9ded167 100644
--- a/sw/source/filter/ww8/wrtw8sty.cxx
+++ b/sw/source/filter/ww8/wrtw8sty.cxx
@@ -1114,10 +1114,10 @@ sal_uInt16 MSWordSections::CurrentNumberOfColumns(
const SwDoc ) const
if ( m_aSects.empty() )
return 1;
-return NumberOfColumns( rDoc, m_aSects.back() );
+return GetFormatCol(rDoc, m_aSects.back()).GetNumCols();
}
-sal_uInt16 MSWordSections::NumberOfColumns( const SwDoc , const
WW8_SepInfo& rInfo )
+const SwFormatCol& MSWordSections::GetFormatCol(const SwDoc , const
WW8_SepInfo& rInfo)
{
const SwPageDesc* pPd = rInfo.pPageDesc;
if ( !pPd )
@@ -1131,9 +1131,7 @@ sal_uInt16 MSWordSections::NumberOfColumns( const SwDoc
, const WW8_SepInfo
if ( rInfo.pSectionFormat &&
reinterpret_cast(sal_IntPtr(-1)) != rInfo.pSectionFormat )
aSet.Put( rInfo.pSectionFormat->GetFormatAttr( RES_COL ) );
-const SwFormatCol& rCol = aSet.Get( RES_COL );
-const SwColumns& rColumns = rCol.GetColumns();
-return rColumns.size();
+return aSet.Get(RES_COL);
}
const WW8_SepInfo* MSWordSections::CurrentSectionInfo()
diff --git a/sw/source/filter/ww8/wrtww8.hxx b/sw/source/filter/ww8/wrtww8.hxx
index 87aa2298f0a8..7266bb8e91d4 100644
--- a/sw/source/filter/ww8/wrtww8.hxx
+++ b/sw/source/filter/ww8/wrtww8.hxx
@@ -223,7 +223,7 @@ public:
sal_uInt16 CurrentNumberOfColumns( const SwDoc ) const;
/// Number of columns of the provided WW8_SepInfo.
-static sal_uInt16 NumberOfColumns( const SwDoc , const WW8_SepInfo&
rInfo );
+static const SwFormatCol&
[Libreoffice-bugs] [Bug 155337] Writer Has Repeatable Crash
https://bugs.documentfoundation.org/show_bug.cgi?id=155337 m.a.riosv changed: What|Removed |Added Ever confirmed|0 |1 CC||miguelangelrv@libreoffice.o ||rg Status|UNCONFIRMED |NEEDINFO --- Comment #1 from m.a.riosv --- Please test with a clean profile, Menu/Help/Restart in Safe Mode -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155336] EDITING: freeze and crash after editing header
https://bugs.documentfoundation.org/show_bug.cgi?id=155336 m.a.riosv changed: What|Removed |Added Ever confirmed|0 |1 CC||miguelangelrv@libreoffice.o ||rg Status|UNCONFIRMED |NEEDINFO --- Comment #2 from m.a.riosv --- Please test with a clean profile, Menu/Help/Restart in Safe Mode -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155331] RTF sections (/sect control word) are not on new pages, which is the default
https://bugs.documentfoundation.org/show_bug.cgi?id=155331 m.a.riosv changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 CC||miguelangelrv@libreoffice.o ||rg --- Comment #1 from m.a.riosv --- Please attach a mbasic sample file. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155337] Writer Has Repeatable Crash
https://bugs.documentfoundation.org/show_bug.cgi?id=155337 BrendaEM changed: What|Removed |Added Version|3.3.3 release |3.3.2 release -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155337] New: Writer Has Repeatable Crash
https://bugs.documentfoundation.org/show_bug.cgi?id=155337 Bug ID: 155337 Summary: Writer Has Repeatable Crash Product: LibreOffice Version: 3.3.3 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: brendieel...@brenda-make.com Description: Writer crashes often. I thought that either pasting or scrolling has something to do with it--but they might be red-herrings. Steps to Reproduce: I am unsure what is causing the crash. Actual Results: LibreOffice crashes Expected Results: It would keep going. Reproducible: Always User Profile Reset: No Additional Info: Version: 7.5.3.2 (X86_64) / LibreOffice Community Build ID: 9f56dff12ba03b9acd7730a5a481eea045e468f3 CPU threads: 16; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded Faulting application name: soffice.bin, version: 7.5.3.2, time stamp: 0x644b30c9 Faulting module name: ucrtbase.dll, version: 10.0.22621.608, time stamp: 0xf5fc15a3 Exception code: 0xc409 Fault offset: 0x0007f61e Faulting process id: 0x0x11D8 Faulting application start time: 0x0x1D98773016C2006 Faulting application path: C:\Program Files\LibreOffice\program\soffice.bin Faulting module path: C:\WINDOWS\System32\ucrtbase.dll Report Id: 80bc426c-7174-4c01-ba74-f00a2d1effca Faulting package full name: Faulting package-relative application ID: Faulting application name: soffice.bin, version: 7.5.3.2, time stamp: 0x644b30c9 Faulting module name: ucrtbase.dll, version: 10.0.22621.608, time stamp: 0xf5fc15a3 Exception code: 0xc409 Fault offset: 0x0007f61e Faulting process id: 0x0x2580 Faulting application start time: 0x0x1D9876C89908551 Faulting application path: C:\Program Files\LibreOffice\program\soffice.bin Faulting module path: C:\WINDOWS\System32\ucrtbase.dll Report Id: 5bcc60c1-5930-4ed2-93d3-dd848adf11ad Faulting package full name: Faulting application name: soffice.bin, version: 7.5.3.2, time stamp: 0x644b30c9 Faulting module name: ucrtbase.dll, version: 10.0.22621.608, time stamp: 0xf5fc15a3 Exception code: 0xc409 Fault offset: 0x0007f61e Faulting process id: 0x0x238C Faulting application start time: 0x0x1D9876678C0BE72 Faulting application path: C:\Program Files\LibreOffice\program\soffice.bin Faulting module path: C:\WINDOWS\System32\ucrtbase.dll Report Id: c6a14383-15af-4919-8002-731037539360 Faulting package full name: Faulting package-relative application ID: Faulting application name: soffice.bin, version: 7.5.3.2, time stamp: 0x644b30c9 Faulting module name: ucrtbase.dll, version: 10.0.22621.608, time stamp: 0xf5fc15a3 Exception code: 0xc409 Fault offset: 0x0007f61e Faulting process id: 0x0x468 Faulting application start time: 0x0x1D98762F5EA78A5 Faulting application path: C:\Program Files\LibreOffice\program\soffice.bin Faulting module path: C:\WINDOWS\System32\ucrtbase.dll Report Id: c97db6b7-ed95-4827-8184-1539884d5dd7 Faulting package full name: Faulting package-relative application ID: -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141135] GTK3 version: in tabbed, tabbed compact, and groupedbar compact toolbar modes, the menu entries to switch between Normal and Web view modes are checkboxes instead of ra
https://bugs.documentfoundation.org/show_bug.cgi?id=141135 --- Comment #5 from Justin L --- in LO 5.1, the menu switched from icons to radio buttons. I looked in the patch range indicated by bibisect, but didn't find any clue. git log -p \ 47cddc662efc470505f0b76427fa3092bae5550a..e2e058d450c1d2fdc6230933ec66c037971b9aea -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142979] UI Hyperlinks to cells of other sheets are not clickable if they are generated and there are many of them
https://bugs.documentfoundation.org/show_bug.cgi?id=142979 ady changed: What|Removed |Added Keywords||needsUXEval --- Comment #6 from ady --- There is no need to use 200 rows. I can repro with 10 rows too. As long as the list of numbers exists, no problem. After dragging the hyperlink function up to the first row that results in #N/A (meaning that there was no number in column A), then all "links" are broken in the sense that you cannot ctrl+click them as hyperlinks anymore. There is no "tooltip" at that point in time either (but there was before). All links, in all cells, are now "broken". Even deleting the #N/A cell(s), the linking feature no longer works, nowhere. There is no change in the formula; just the "linking" feature does not exist anymore. Still repro in: Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: daf30c29be67b8b8fa361b0efd1a6cdbe087b6f8 CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: en-US (es_AR); UI: en-US Calc: CL threaded Built: 2023-05-10 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140226] Make use of SfxPoolItems more typesafe by using StaticWhichCast
https://bugs.documentfoundation.org/show_bug.cgi?id=140226 --- Comment #8 from Commit Notification --- MoazAlaa committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/a9d60aba81305bf86024df707eb694d1cabc9a1d tdf#140226: use StaticWhichCast It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: cui/source include/svx
cui/source/tabpages/connect.cxx | 20 ++--
include/svx/sxelditm.hxx|2 +-
2 files changed, 11 insertions(+), 11 deletions(-)
New commits:
commit a9d60aba81305bf86024df707eb694d1cabc9a1d
Author: MoazAlaa
AuthorDate: Fri Apr 21 22:03:52 2023 +0200
Commit: Hossein
CommitDate: Mon May 15 23:35:28 2023 +0200
tdf#140226: use StaticWhichCast
Change-Id: If5eab003a732264522ff1b1fe55a6a2c876c22db
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150794
Tested-by: Jenkins
Reviewed-by: Hossein
diff --git a/cui/source/tabpages/connect.cxx b/cui/source/tabpages/connect.cxx
index d668a2a6b8b7..f26cb485c897 100644
--- a/cui/source/tabpages/connect.cxx
+++ b/cui/source/tabpages/connect.cxx
@@ -132,7 +132,7 @@ void SvxConnectionPage::Reset( const SfxItemSet* rAttrs )
// SdrEdgeNode1HorzDistItem
if( !pItem )
pItem = >GetDefaultItem( SDRATTR_EDGENODE1HORZDIST );
-SetMetricValue(*m_xMtrFldHorz1, static_cast(pItem)->GetValue(),
+SetMetricValue(*m_xMtrFldHorz1,
pItem->StaticWhichCast(SDRATTR_EDGENODE1HORZDIST).GetValue(),
eUnit);
m_xMtrFldHorz1->save_value();
@@ -140,7 +140,7 @@ void SvxConnectionPage::Reset( const SfxItemSet* rAttrs )
pItem = GetItem( *rAttrs, SDRATTR_EDGENODE2HORZDIST );
if( !pItem )
pItem = >GetDefaultItem( SDRATTR_EDGENODE2HORZDIST );
-SetMetricValue(*m_xMtrFldHorz2, static_cast(pItem)->GetValue(),
+SetMetricValue(*m_xMtrFldHorz2,
pItem->StaticWhichCast(SDRATTR_EDGENODE2HORZDIST).GetValue(),
eUnit);
m_xMtrFldHorz2->save_value();
@@ -148,7 +148,7 @@ void SvxConnectionPage::Reset( const SfxItemSet* rAttrs )
pItem = GetItem( *rAttrs, SDRATTR_EDGENODE1VERTDIST );
if( !pItem )
pItem = >GetDefaultItem( SDRATTR_EDGENODE1VERTDIST );
-SetMetricValue(*m_xMtrFldVert1, static_cast(pItem)->GetValue(),
+SetMetricValue(*m_xMtrFldVert1,
pItem->StaticWhichCast(SDRATTR_EDGENODE1VERTDIST).GetValue(),
eUnit);
m_xMtrFldVert1->save_value();
@@ -156,7 +156,7 @@ void SvxConnectionPage::Reset( const SfxItemSet* rAttrs )
pItem = GetItem( *rAttrs, SDRATTR_EDGENODE2VERTDIST );
if( !pItem )
pItem = >GetDefaultItem( SDRATTR_EDGENODE2VERTDIST );
-SetMetricValue(*m_xMtrFldVert2, static_cast(pItem)->GetValue(),
+SetMetricValue(*m_xMtrFldVert2,
pItem->StaticWhichCast(SDRATTR_EDGENODE2VERTDIST).GetValue(),
eUnit);
m_xMtrFldVert2->save_value();
@@ -164,28 +164,28 @@ void SvxConnectionPage::Reset( const SfxItemSet* rAttrs )
pItem = GetItem( *rAttrs, SDRATTR_EDGELINE1DELTA );
if( !pItem )
pItem = >GetDefaultItem( SDRATTR_EDGELINE1DELTA );
-SetMetricValue(*m_xMtrFldLine1, static_cast(pItem)->GetValue(), eUnit);
+SetMetricValue(*m_xMtrFldLine1,
pItem->StaticWhichCast(SDRATTR_EDGELINE1DELTA).GetValue(), eUnit);
m_xMtrFldLine1->save_value();
// SdrEdgeLine2DeltaItem
pItem = GetItem( *rAttrs, SDRATTR_EDGELINE2DELTA );
if( !pItem )
pItem = >GetDefaultItem( SDRATTR_EDGELINE2DELTA );
-SetMetricValue(*m_xMtrFldLine2, static_cast(pItem)->GetValue(), eUnit);
+SetMetricValue(*m_xMtrFldLine2,
pItem->StaticWhichCast(SDRATTR_EDGELINE2DELTA).GetValue(), eUnit);
m_xMtrFldLine2->save_value();
// SdrEdgeLine3DeltaItem
pItem = GetItem( *rAttrs, SDRATTR_EDGELINE3DELTA );
if( !pItem )
pItem = >GetDefaultItem( SDRATTR_EDGELINE3DELTA );
-SetMetricValue(*m_xMtrFldLine3, static_cast(pItem)->GetValue(), eUnit);
+SetMetricValue(*m_xMtrFldLine3,
pItem->StaticWhichCast(SDRATTR_EDGELINE3DELTA).GetValue(), eUnit);
m_xMtrFldLine3->save_value();
// SdrEdgeLineDeltaAnzItem
pItem = GetItem( *rAttrs, SDRATTR_EDGELINEDELTACOUNT );
if( !pItem )
pItem = >GetDefaultItem( SDRATTR_EDGELINEDELTACOUNT );
-switch (static_cast(pItem)->GetValue())
+switch (pItem->StaticWhichCast(SDRATTR_EDGELINEDELTACOUNT).GetValue())
{
case 0:
m_xFtLine1->set_sensitive(false);
@@ -209,7 +209,7 @@ void SvxConnectionPage::Reset( const SfxItemSet* rAttrs )
if( !pItem )
pItem = >GetDefaultItem( SDRATTR_EDGEKIND );
m_xLbType->set_active(
-sal::static_int_cast(static_cast(pItem)->GetValue()));
+
sal::static_int_cast(pItem->StaticWhichCast(SDRATTR_EDGEKIND).GetValue()));
m_xLbType->save_value();
}
@@ -395,7 +395,7 @@ void SvxConnectionPage::FillTypeLB()
if( !pItem )
pItem = >GetDefaultItem( SDRATTR_EDGEKIND );
-const SdrEdgeKindItem* pEdgeKindItem = static_cast(pItem);
+const SdrEdgeKindItem* pEdgeKindItem =
>StaticWhichCast(SDRATTR_EDGEKIND);
const sal_uInt16 nCount = pEdgeKindItem->GetValueCount();
for (sal_uInt16 i = 0; i < nCount; i++)
{
diff --git a/include/svx/sxelditm.hxx b/include/svx/sxelditm.hxx
index c957070ce271..7d2bc11dc102 100644
--- a/include/svx/sxelditm.hxx
[Libreoffice-bugs] [Bug 155200] As of version LO 7.4.x.x large branding icon in the thumbnails of the last used documents.
https://bugs.documentfoundation.org/show_bug.cgi?id=155200 m.a.riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg --- Comment #8 from m.a.riosv --- Created attachment 187306 --> https://bugs.documentfoundation.org/attachment.cgi?id=187306=edit Screenshot wit 7.0.0.a1 Version: 7.6.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: 6f1534940ac12ff8e46f4782e18cfb6cf585da39 CPU threads: 16; OS: Windows 10.0 Build 22621; UI render: default; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL threaded Screen 2240x1400 scale 175% -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155290] Mouse-over labels are in reverse order with a chart with dates on the x-axis, when dates are listed from new to old in the source data
https://bugs.documentfoundation.org/show_bug.cgi?id=155290 --- Comment #3 from m.a.riosv --- Thank @Stéphane for locating it. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 85539] SUMPRODUCT not summing multiple sheets
https://bugs.documentfoundation.org/show_bug.cgi?id=85539 --- Comment #8 from m.a.riosv --- Could you attach a sample file that works in excel? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143340] Undo/redo for checking/unchecking KeepRatio in Image Properties Dialog not properly handled
https://bugs.documentfoundation.org/show_bug.cgi?id=143340 --- Comment #4 from stefan_lange...@t-online.de --- I have bibisected to find the change from "old" behavior as described in the bug description to the "new" behavior as described in Comment 3: e18b47dbd75cec720d7f486a44b8a235625a5856 is the first bad commit commit e18b47dbd75cec720d7f486a44b8a235625a5856 Author: Norbert Thiebaud Date: Thu Mar 17 11:22:13 2022 -0700 source sha:9e8712ed6f9fb5dbd971e352a5709bd45fadc74f source sha:9e8712ed6f9fb5dbd971e352a5709bd45fadc74f instdir/program/cuilo.dll | Bin 4620800 -> 4621312 bytes instdir/program/setup.ini | 2 +- instdir/program/swlo.dll| Bin 17019392 -> 17019904 bytes instdir/program/version.ini | 2 +- 4 files changed, 2 insertions(+), 2 deletions(-) The "old" behavior was in the bisect tests exactly as described in the bug description except the detail "Height value is set to Width value (10,00 cm) - problem as described in Bug 143321". This effect propably didn't occur because Bug 143633 was already fixed in LO 7.2.1 on 2021-08-25 15:10:09 UTC. IMHO it makes no sense to bibisect for the start of the "old" behavior because it is obsolete. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155336] EDITING: freeze and crash after editing header
https://bugs.documentfoundation.org/show_bug.cgi?id=155336 sunnypon...@gmail.com changed: What|Removed |Added CC||sunnypon...@gmail.com --- Comment #1 from sunnypon...@gmail.com --- Created attachment 187305 --> https://bugs.documentfoundation.org/attachment.cgi?id=187305=edit document I was editing during both crashes -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155272] FILEOPEN DOCX: invalid document: fldchar begin without fldchar end - lots of text is lost.
https://bugs.documentfoundation.org/show_bug.cgi?id=155272 Justin L changed: What|Removed |Added Priority|medium |low Summary|Writer: Very bad|FILEOPEN DOCX: invalid |import/display of .docx |document: fldchar begin |Microsoft Word file |without fldchar end - lots ||of text is lost. Severity|normal |minor CC||aron.bu...@gmail.com --- Comment #9 from Justin L --- The first thing we do in DomainMapper_Impl::finishParagraph is to just do an early return if the field command is not finished. We can't just assume that the end of the paragraph can just close any started field commands because of embedded fields, paragraphs in field shapes/tables etc. This probably needs to be chalked up to corrupt documents, and likely WONTFIX. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155336] New: EDITING: freeze and crash after editing header
https://bugs.documentfoundation.org/show_bug.cgi?id=155336 Bug ID: 155336 Summary: EDITING: freeze and crash after editing header Product: LibreOffice Version: 7.5.2.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: sunnypon...@gmail.com Description: Document has an existing header and bulleted content arranged in 2 columns. Sometimes after editing the header and deselecting the area and beginning to edit bullet points, Writer will freeze and crash a minute or so later. This happened twice within 20 minutes but I was unable to reproduce the bug intentionally. Actual Results: Freezes while typing, crashes about 1 minute later. Expected Results: Writer should stay open and continue to allow text editing. Reproducible: Sometimes User Profile Reset: No Additional Info: Version: 7.5.2.2 (X86_64) / LibreOffice Community Build ID: 53bb9681a964705cf672590721dbc85eb4d0c3a2 CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154929] [META] Accessibility Check sidebar deck, Automatic Accessibility Checking
https://bugs.documentfoundation.org/show_bug.cgi?id=154929 Bug 154929 depends on bug 154784, which changed state. Bug 154784 Summary: A11Y sidebar: default width too narrow (non-GTK) https://bugs.documentfoundation.org/show_bug.cgi?id=154784 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103440] [META] Sidebar accessibility bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103440 Bug 103440 depends on bug 154782, which changed state. Bug 154782 Summary: A11Y sidebar: scrolling no longer works with mouse wheel https://bugs.documentfoundation.org/show_bug.cgi?id=154782 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154929] [META] Accessibility Check sidebar deck, Automatic Accessibility Checking
https://bugs.documentfoundation.org/show_bug.cgi?id=154929 Bug 154929 depends on bug 154782, which changed state. Bug 154782 Summary: A11Y sidebar: scrolling no longer works with mouse wheel https://bugs.documentfoundation.org/show_bug.cgi?id=154782 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/source sw/uiconfig
sw/source/uibase/sidebar/A11yCheckIssuesPanel.cxx |9 -
sw/source/uibase/sidebar/A11yCheckIssuesPanel.hxx |1
sw/uiconfig/swriter/ui/a11ycheckissuespanel.ui| 35 +-
3 files changed, 9 insertions(+), 36 deletions(-)
New commits:
commit 26df8770efecb6f98f05ceffa5c81905582d1d3b
Author: Samuel Mehrbrodt
AuthorDate: Mon May 15 15:40:02 2023 +0200
Commit: Samuel Mehrbrodt
CommitDate: Mon May 15 22:51:03 2023 +0200
tdf#154782 Fix scrolling in a11y sidebar
Doesn't need its own scroll handler anymore,
Sidebar has a generic scroll handler.
Change-Id: Ic56d1cfd7cde8ed81bf36f3302a128aa03ff6f27
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151769
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt
diff --git a/sw/source/uibase/sidebar/A11yCheckIssuesPanel.cxx
b/sw/source/uibase/sidebar/A11yCheckIssuesPanel.cxx
index cd5d76e23cb0..854f7f151230 100644
--- a/sw/source/uibase/sidebar/A11yCheckIssuesPanel.cxx
+++ b/sw/source/uibase/sidebar/A11yCheckIssuesPanel.cxx
@@ -70,7 +70,6 @@ std::unique_ptr
A11yCheckIssuesPanel::Create(weld::Widget* pParent,
A11yCheckIssuesPanel::A11yCheckIssuesPanel(weld::Widget* pParent, SfxBindings*
pBindings)
: PanelLayout(pParent, "A11yCheckIssuesPanel",
"modules/swriter/ui/a11ycheckissuespanel.ui")
, m_xAccessibilityCheckBox(m_xBuilder->weld_box("accessibilityCheckBox"))
-, m_xScrolledWindow(m_xBuilder->weld_scrolled_window("scrolledwindow"))
, mpBindings(pBindings)
, mpDoc(nullptr)
, maA11yCheckController(FN_STAT_ACCESSIBILITY_CHECK, *pBindings, *this)
@@ -131,14 +130,6 @@ void A11yCheckIssuesPanel::populateIssues()
m_xAccessibilityCheckBox->reorder_child(xEntry->get_widget(), i++);
m_aAccessibilityCheckEntries.push_back(std::move(xEntry));
}
-
-if (!m_aAccessibilityCheckEntries.empty())
-{
-auto nRowHeight
-=
m_aAccessibilityCheckEntries.back()->get_widget()->get_preferred_size().Height();
-// 6 is the spacing set in the .ui
-m_xScrolledWindow->vadjustment_set_step_increment(nRowHeight + 6);
-}
}
void A11yCheckIssuesPanel::NotifyItemUpdate(const sal_uInt16 nSid, const
SfxItemState /* eState */,
diff --git a/sw/source/uibase/sidebar/A11yCheckIssuesPanel.hxx
b/sw/source/uibase/sidebar/A11yCheckIssuesPanel.hxx
index 46d74c97f5a1..b3e33c049528 100644
--- a/sw/source/uibase/sidebar/A11yCheckIssuesPanel.hxx
+++ b/sw/source/uibase/sidebar/A11yCheckIssuesPanel.hxx
@@ -61,7 +61,6 @@ public:
private:
std::vector>
m_aAccessibilityCheckEntries;
std::unique_ptr m_xAccessibilityCheckBox;
-std::unique_ptr m_xScrolledWindow;
sfx::AccessibilityIssueCollection m_aIssueCollection;
std::function m_getIssueCollection;
void populateIssues();
diff --git a/sw/uiconfig/swriter/ui/a11ycheckissuespanel.ui
b/sw/uiconfig/swriter/ui/a11ycheckissuespanel.ui
index b8581dd350b4..5a55d382a3cd 100644
--- a/sw/uiconfig/swriter/ui/a11ycheckissuespanel.ui
+++ b/sw/uiconfig/swriter/ui/a11ycheckissuespanel.ui
@@ -10,40 +10,23 @@
True
vertical
-
+
True
-True
+False
+start
True
True
-in
+vertical
+6
+True
-
-True
-False
-True
-True
-
-
-True
-False
-start
-True
-True
-vertical
-6
-True
-
-
-
-
-
-
+
-True
+False
True
-1
+0
[Libreoffice-bugs] [Bug 148234] symbol bar in Calc while editing
https://bugs.documentfoundation.org/show_bug.cgi?id=148234 --- Comment #18 from ady --- (In reply to Buovjaga from comment #16) > *** Bug 152888 has been marked as a duplicate of this bug. *** If bug 152888 is a duplicate, then it should rather be invalid, considering that it is the same reporter as this bug 148234. It is either invalid, or it is not really a duplicate. (In reply to BogdanB from comment #17) > Can you attach a screenshot of the bug? In order to see if others can > confirm it. I could be wrong but maybe this is just another duplicate of bug 140557. Using the (currently named) "Tabbed" or "Tabbed Compact", indeed part of the icons of the toolbar are hidden by default (unintentionally), and one of the methods to make them show up again is to change the size of the window. Using the chevron also achieves the same effect. The amount of icons that are initially hidden vary, depending on several factors, including UI Language. If the reporter can confirm that this is the same toolbar he is talking about in this report, then that would mean that this bug 148234 would be yet another duplicate of bug 140557. If it is not the same toolbar, we indeed need a screenshot to be attached to this bug report. In either case, we need some reply from the reporter. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155089] No way to create pivot table compact layout from scratch
https://bugs.documentfoundation.org/show_bug.cgi?id=155089 Stéphane Guillou (stragu) changed: What|Removed |Added Ever confirmed|0 |1 Whiteboard| QA:needsComment| Status|UNCONFIRMED |NEW --- Comment #1 from Stéphane Guillou (stragu) --- Repro with: Version: 7.6.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: 73b35219cc9ed42072506ed18a5767f072e1da02 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155272] Writer: Very bad import/display of .docx Microsoft Word file
https://bugs.documentfoundation.org/show_bug.cgi?id=155272 --- Comment #8 from Justin L --- The reason the fldChar is invalid is because it is missing an end. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 136536] Bullets become red (font color) after save & reload (ODT)
https://bugs.documentfoundation.org/show_bug.cgi?id=136536 Rajasekaran Karunanithi changed: What|Removed |Added CC||rajasekara...@gmail.com --- Comment #8 from Rajasekaran Karunanithi --- Still exists in LO 7.6 dev under Windows 10(x64). Version: 7.6.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: 975590e69edfa351ef20a0973a5005ca49d08edc CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: en-IN (en_IN); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 136536] Bullets become red (font color) after save & reload (ODT)
https://bugs.documentfoundation.org/show_bug.cgi?id=136536 Justin L changed: What|Removed |Added Whiteboard|target:7.6.0| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155334] Credit card donation requires email address
https://bugs.documentfoundation.org/show_bug.cgi?id=155334 Stéphane Guillou (stragu) changed: What|Removed |Added CC||floeff@documentfoundation.o ||rg --- Comment #1 from Stéphane Guillou (stragu) --- Florian, is that a legal requirement for sending a donation receipt? Asking before moving the ticket to Redmine in case it's an obvious "won't fix". -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - sw/inc sw/qa sw/source
sw/inc/crsrsh.hxx| 14 -
sw/qa/extras/odfimport/odfimport.cxx |4
sw/qa/extras/uiwriter/uiwriter3.cxx |8
sw/source/core/crsr/crsrsh.cxx | 281 ---
sw/source/core/edit/eddel.cxx| 20 --
sw/source/core/edit/edglss.cxx | 20 --
sw/source/uibase/wrtsh/move.cxx | 46 +
sw/source/uibase/wrtsh/select.cxx| 36 ++--
8 files changed, 348 insertions(+), 81 deletions(-)
New commits:
commit ad03ed5106499f74b38da28489a9352ce3f01d1a
Author: Michael Stahl
AuthorDate: Mon May 8 16:38:03 2023 +0200
Commit: Thorsten Behrens
CommitDate: Mon May 15 22:15:08 2023 +0200
tdf#154877 sw: generalise ExtendedSelectAll()
This used to work only in the body text; make it work in any text, so
also text frame, header/footer, footnote, table cell.
(fixes regression from commit 0590cd2857f68f48b8847071a9c1a7dbef135721)
This is made much more difficult by table cells, which may contain
nested tables; there is already some code to switch between text
selection (via m_pCurrentCursor) and table cell selection (via
m_pTableCursor).
There were also a few things that looked kinda wrong, but i forgot
where.
One tricky case that can't be handled well is if there are multiple
tables in a text but no paragraph (this is impossible in the body but
possible in other texts by removing the paragraph via Ctrl+Shift+Delete)
... here the most we get is one table fully selected, because the
SwTableCursor can't select cells from multiple tables.
Change-Id: I0964baacecb8f10636792a27efa9ea6b18da4709
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151544
Tested-by: Jenkins
Reviewed-by: Michael Stahl
(cherry picked from commit d81379db730a163c5ff75d4f3a3cddbd7b5eddda)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151766
Reviewed-by: Thorsten Behrens
diff --git a/sw/inc/crsrsh.hxx b/sw/inc/crsrsh.hxx
index c7148020bc2b..c3d3dc85959f 100644
--- a/sw/inc/crsrsh.hxx
+++ b/sw/inc/crsrsh.hxx
@@ -331,7 +331,7 @@ public:
// only for usage in special cases allowed!
void ExtendedSelectAll(bool bFootnotes = true);
/// If ExtendedSelectAll() was called and selection didn't change since
then.
-bool ExtendedSelectedAll();
+SwNode const* ExtendedSelectedAll() const;
enum class StartsWith { None, Table, HiddenPara };
/// If document body starts with a table or starts/ends with hidden
paragraph.
StartsWith StartsWith_();
@@ -592,8 +592,11 @@ public:
// fields etc.
OUString GetSelText() const;
-// Check of SPoint or Mark of current cursor are placed within a table.
-inline const SwTableNode* IsCursorInTable() const;
+/// Check if Point of current cursor is placed within a table.
+const SwTableNode* IsCursorInTable() const;
+bool MoveOutOfTable();
+bool TrySelectOuterTable();
+bool MoveStartText();
bool IsCursorInFootnote() const;
@@ -907,11 +910,6 @@ inline bool SwCursorShell::IsMultiSelection() const
return m_pCurrentCursor->GetNext() != m_pCurrentCursor;
}
-inline const SwTableNode* SwCursorShell::IsCursorInTable() const
-{
-return m_pCurrentCursor->GetPointNode().FindTableNode();
-}
-
inline bool SwCursorShell::IsCursorPtAtEnd() const
{
return m_pCurrentCursor->End() == m_pCurrentCursor->GetPoint();
diff --git a/sw/qa/extras/odfimport/odfimport.cxx
b/sw/qa/extras/odfimport/odfimport.cxx
index e38f1629bf23..6370d8dc4e8c 100644
--- a/sw/qa/extras/odfimport/odfimport.cxx
+++ b/sw/qa/extras/odfimport/odfimport.cxx
@@ -723,6 +723,8 @@ CPPUNIT_TEST_FIXTURE(Test, testFdo37606)
pWrtShell->SelAll(); // Selects the whole table.
pWrtShell->SelAll(); // Selects the whole document.
+pShellCursor = pWrtShell->getShellCursor(false);
+
SwTextNode& rStart =
dynamic_cast(pShellCursor->Start()->GetNode());
CPPUNIT_ASSERT_EQUAL(OUString("A1"), rStart.GetText());
@@ -789,11 +791,11 @@ CPPUNIT_TEST_FIXTURE(Test, testFdo69862)
SwXTextDocument* pTextDoc = dynamic_cast(mxComponent.get());
CPPUNIT_ASSERT(pTextDoc);
SwWrtShell* pWrtShell = pTextDoc->GetDocShell()->GetWrtShell();
-SwShellCursor* pShellCursor = pWrtShell->getShellCursor(false);
pWrtShell->SelAll(); // Selects A1.
pWrtShell->SelAll(); // Selects the whole table.
pWrtShell->SelAll(); // Selects the whole document.
+SwShellCursor* pShellCursor = pWrtShell->getShellCursor(false);
SwTextNode& rStart =
dynamic_cast(pShellCursor->Start()->GetNode());
// This was "Footnote.", as Ctrl-A also selected footnotes, but it should
not.
CPPUNIT_ASSERT_EQUAL(OUString("A1"), rStart.GetText());
diff --git a/sw/qa/extras/uiwriter/uiwriter3.cxx
b/sw/qa/extras/uiwriter/uiwriter3.cxx
index f0cbf7339937..b739bd0306f6 100644
--- a/sw/qa/extras/uiwriter/uiwriter3.cxx
+++
[Libreoffice-bugs] [Bug 155272] Writer: Very bad import/display of .docx Microsoft Word file
https://bugs.documentfoundation.org/show_bug.cgi?id=155272 Justin L changed: What|Removed |Added Version|4.0.0.3 release |Inherited From OOo --- Comment #7 from Justin L --- tested with bibisect-releases and see it is inherited from OOo. The problem is related to bookmarks in the original document that are removed when MS Word round-trips the file. 29.09.2022 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: 2 commits - officecfg/registry
officecfg/registry/schema/org/openoffice/Office/Common.xcs | 31 - 1 file changed, 31 deletions(-) New commits: commit 01f9e76ed9c90244e161a7bfc30d702a5567f018 Author: Gabor Kelemen AuthorDate: Thu May 4 22:35:55 2023 +0200 Commit: Thorsten Behrens CommitDate: Mon May 15 22:13:17 2023 +0200 [API CHANGE] Drop unused ToolboxStyle config key Unused since 2020 commit a0eab90bd1f7fc31978da3f7be0ec86781baf8bc Change-Id: Id03396022d7481ce85356207d468f5b1201df44c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151407 Tested-by: Jenkins Reviewed-by: Thorsten Behrens diff --git a/officecfg/registry/schema/org/openoffice/Office/Common.xcs b/officecfg/registry/schema/org/openoffice/Office/Common.xcs index 3aa092ae586e..2b6aabf31c3e 100644 --- a/officecfg/registry/schema/org/openoffice/Office/Common.xcs +++ b/officecfg/registry/schema/org/openoffice/Office/Common.xcs @@ -5430,25 +5430,6 @@ - - - - Specifies which button style the toolbars should use. - - - - - 3D style - - - - - Flat style - - - -1 - Enables/Disables the usage of AutoPilots for form commit 1ec0a53d6e07f24b3f186b5dc152b66a66af2ff1 Author: Gabor Kelemen AuthorDate: Wed Apr 26 13:26:54 2023 +0200 Commit: Thorsten Behrens CommitDate: Mon May 15 22:13:02 2023 +0200 [API CHANGE] Drop unused Dictionaries config group Its use was removed in 2020 by commit acb1c390539730957fb509f18f469fc7f6133082 Change-Id: I48a10ab13de9fcdb1b1c5721a9be648250166f52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151058 Tested-by: Jenkins Reviewed-by: Thorsten Behrens diff --git a/officecfg/registry/schema/org/openoffice/Office/Common.xcs b/officecfg/registry/schema/org/openoffice/Office/Common.xcs index 8f9115d3bac3..3aa092ae586e 100644 --- a/officecfg/registry/schema/org/openoffice/Office/Common.xcs +++ b/officecfg/registry/schema/org/openoffice/Office/Common.xcs @@ -775,18 +775,6 @@ false - - -Contains settings related to dictionaries. - - - - Specifies a repository URL where users can download additional - dictionaries. - - - - Specifies settings for the Drawinglayer.
[Libreoffice-bugs] [Bug 155327] FILEOPEN: PPTX: Wordart not displayed
https://bugs.documentfoundation.org/show_bug.cgi?id=155327 --- Comment #4 from Regina Henschel --- The problem with these examples is, that the character properties in the file do not define a fill property. PowerPoint uses the "tx1" from the theme in such case. But on import the "moFillType" member of the FillProperties is not set and the "maFillColor" member has "meMode = COlOR_UNUSED". The effect of not set moFillType is, that in the call of rCharProps.maFillProperties.pushToPropMap in [1] it returns immediately without doing anything [2]. But even if it would be set to XML_solidFill for example, it would still not work, because "if( maFillColor.isUsed() )" in line #423 would fail. [1] https://opengrok.libreoffice.org/xref/core/oox/source/drawingml/shape.cxx?r=60bce1af#732 [2] https://opengrok.libreoffice.org/xref/core/oox/source/drawingml/fillproperties.cxx?r=1df0565f#408 Perhaps it is needed to copy the rCharProps.maFillProperties and tweak them. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: officecfg/registry
officecfg/registry/schema/org/openoffice/Office/Common.xcs |7 --- 1 file changed, 7 deletions(-) New commits: commit d948d183930ef9c5d062717c4d7f95f9453c50f6 Author: Gabor Kelemen AuthorDate: Wed Apr 26 14:26:10 2023 +0200 Commit: Thorsten Behrens CommitDate: Mon May 15 22:12:41 2023 +0200 [API CHANGE] Drop unused config key EmojiFont Its use was removed in 2022 by commit 5f1eb2a12b6e6ee646b5e9536822531ad0bd3259 Change-Id: Ifc7e3f645422a478571aaa9dcbcd9ebe9a811b23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151061 Tested-by: Jenkins Reviewed-by: Thorsten Behrens diff --git a/officecfg/registry/schema/org/openoffice/Office/Common.xcs b/officecfg/registry/schema/org/openoffice/Office/Common.xcs index 1958e6a2e687..8f9115d3bac3 100644 --- a/officecfg/registry/schema/org/openoffice/Office/Common.xcs +++ b/officecfg/registry/schema/org/openoffice/Office/Common.xcs @@ -5129,13 +5129,6 @@ be open at the same time. NIL will be interpreted as infinite! - - - - Special font for rendering of emojis - -Segoe UI Emoji,Apple Color Emoji,Noto Color Emoji -
[Libreoffice-commits] core.git: officecfg/registry
officecfg/registry/schema/org/openoffice/Office/Common.xcs | 43 - 1 file changed, 43 deletions(-) New commits: commit d5c033e4393395e8c7ef18115f00bdd835ba0bfb Author: Gabor Kelemen AuthorDate: Tue Apr 25 13:55:29 2023 +0200 Commit: Thorsten Behrens CommitDate: Mon May 15 22:12:19 2023 +0200 [API CHANGE] Drop obsolete group PersonasEntry and set PersonasList Its use was removed in 2020 by commit e1e9e2aa16f08a8fd9e38db706d63e8eceeda8d1 Change-Id: I1271c3a1d0dc9c1b294f9d93753196609a85a245 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150988 Tested-by: Jenkins Reviewed-by: Thorsten Behrens diff --git a/officecfg/registry/schema/org/openoffice/Office/Common.xcs b/officecfg/registry/schema/org/openoffice/Office/Common.xcs index d6a005ec977c..1958e6a2e687 100644 --- a/officecfg/registry/schema/org/openoffice/Office/Common.xcs +++ b/officecfg/registry/schema/org/openoffice/Office/Common.xcs @@ -632,44 +632,6 @@ true - - -Stores the details of the installed personas. - - - - Unique pretty id of the persona, also part of its url - - - - - The Persona's name - - - - - Name of the preview file for the Persona to show in the UI - - - - - Name of the header file for the Persona - - - - - - Name of the footer file for the Persona - - - - - - Value of the text color for the Persona - - - - Stores the last selected directory for the filepicker for different contexts. @@ -5557,11 +5519,6 @@ List of names of the CMIS servers in the place edition dialog. - - - Contains the Personas installed through extensions - - Number of saved searches in the Find and Replace dialog.
[Libreoffice-bugs] [Bug 128224] Uninstall local help
https://bugs.documentfoundation.org/show_bug.cgi?id=128224 --- Comment #9 from Andreas Radke --- The Arch Linux main libreoffice package provides en-US langpack + help files. All -i18n packages contain the specific language files + help files. Arch doesn't split out help packages any further. But that's a downstream distribution decision. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: 2 commits - icon-themes/colibre icon-themes/colibre_dark icon-themes/colibre_dark_svg icon-themes/colibre_svg icon-themes/sukapura icon-themes/sukapura_dark icon-themes
icon-themes/colibre/cmd/32/addwatch.png |binary icon-themes/colibre/cmd/32/stackwindow.png |binary icon-themes/colibre/cmd/32/watchwindow.png |binary icon-themes/colibre/cmd/lc_addwatch.png |binary icon-themes/colibre/cmd/lc_stackwindow.png |binary icon-themes/colibre/cmd/lc_watchwindow.png |binary icon-themes/colibre/cmd/sc_stackwindow.png |binary icon-themes/colibre/cmd/sc_watchwindow.png |binary icon-themes/colibre_dark/cmd/32/addwatch.png |binary icon-themes/colibre_dark/cmd/32/stackwindow.png |binary icon-themes/colibre_dark/cmd/32/watchwindow.png |binary icon-themes/colibre_dark/cmd/lc_addwatch.png |binary icon-themes/colibre_dark/cmd/lc_stackwindow.png |binary icon-themes/colibre_dark/cmd/lc_watchwindow.png |binary icon-themes/colibre_dark/cmd/sc_stackwindow.png |binary icon-themes/colibre_dark/cmd/sc_watchwindow.png |binary icon-themes/colibre_dark_svg/cmd/32/addwatch.svg |2 +- icon-themes/colibre_dark_svg/cmd/32/stackwindow.svg |1 + icon-themes/colibre_dark_svg/cmd/32/watchwindow.svg |1 + icon-themes/colibre_dark_svg/cmd/lc_addwatch.svg |2 +- icon-themes/colibre_dark_svg/cmd/lc_stackwindow.svg |1 + icon-themes/colibre_dark_svg/cmd/lc_watchwindow.svg |1 + icon-themes/colibre_dark_svg/cmd/sc_stackwindow.svg |3 +++ icon-themes/colibre_dark_svg/cmd/sc_watchwindow.svg |4 icon-themes/colibre_svg/cmd/32/addwatch.svg |2 +- icon-themes/colibre_svg/cmd/32/stackwindow.svg |1 + icon-themes/colibre_svg/cmd/32/watchwindow.svg |1 + icon-themes/colibre_svg/cmd/lc_addwatch.svg |2 +- icon-themes/colibre_svg/cmd/lc_stackwindow.svg |1 + icon-themes/colibre_svg/cmd/lc_watchwindow.svg |1 + icon-themes/colibre_svg/cmd/sc_stackwindow.svg |1 + icon-themes/colibre_svg/cmd/sc_watchwindow.svg |1 + icon-themes/sukapura/cmd/32/stackwindow.png |binary icon-themes/sukapura/cmd/32/watchwindow.png |binary icon-themes/sukapura/cmd/lc_stackwindow.png |binary icon-themes/sukapura/cmd/lc_watchwindow.png |binary icon-themes/sukapura/cmd/sc_stackwindow.png |binary icon-themes/sukapura/cmd/sc_watchwindow.png |binary icon-themes/sukapura_dark/cmd/32/stackwindow.png |binary icon-themes/sukapura_dark/cmd/32/watchwindow.png |binary icon-themes/sukapura_dark/cmd/lc_stackwindow.png |binary icon-themes/sukapura_dark/cmd/lc_watchwindow.png |binary icon-themes/sukapura_dark/cmd/sc_stackwindow.png |binary icon-themes/sukapura_dark/cmd/sc_watchwindow.png |binary icon-themes/sukapura_dark_svg/cmd/32/stackwindow.svg |1 + icon-themes/sukapura_dark_svg/cmd/32/watchwindow.svg |1 + icon-themes/sukapura_dark_svg/cmd/lc_stackwindow.svg |1 + icon-themes/sukapura_dark_svg/cmd/lc_watchwindow.svg |1 + icon-themes/sukapura_dark_svg/cmd/sc_stackwindow.svg | 10 ++ icon-themes/sukapura_dark_svg/cmd/sc_watchwindow.svg |1 + icon-themes/sukapura_svg/cmd/32/stackwindow.svg |1 + icon-themes/sukapura_svg/cmd/32/watchwindow.svg |1 + icon-themes/sukapura_svg/cmd/lc_stackwindow.svg |1 + icon-themes/sukapura_svg/cmd/lc_watchwindow.svg |1 + icon-themes/sukapura_svg/cmd/sc_stackwindow.svg | 10 ++ icon-themes/sukapura_svg/cmd/sc_watchwindow.svg |1 + 56 files changed, 51 insertions(+), 4 deletions(-) New commits: commit 172aa5d1ed851366f78375c297a5d458416f7d03 Author: Rizal Muttaqin AuthorDate: Mon May 15 23:52:07 2023 +0700 Commit: Adolfo Jayme Barrientos CommitDate: Mon May 15 22:10:14 2023 +0200 tdf#153789 Colibre icons for Watched Expressions and Call Stack Change-Id: I0cbe5df13e49a6bdbdcf7aa93472c24e331b5576 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151804 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos diff --git a/icon-themes/colibre/cmd/32/addwatch.png b/icon-themes/colibre/cmd/32/addwatch.png index a4f28256fc37..ed372fbcd4be 100644 Binary files a/icon-themes/colibre/cmd/32/addwatch.png and b/icon-themes/colibre/cmd/32/addwatch.png differ diff --git a/icon-themes/colibre/cmd/32/stackwindow.png b/icon-themes/colibre/cmd/32/stackwindow.png new file mode 100644 index ..c6fbb7a1b850 Binary files /dev/null and b/icon-themes/colibre/cmd/32/stackwindow.png differ diff --git a/icon-themes/colibre/cmd/32/watchwindow.png b/icon-themes/colibre/cmd/32/watchwindow.png new file mode 100644 index ..f3e62b798398 Binary files /dev/null and b/icon-themes/colibre/cmd/32/watchwindow.png differ diff --git a/icon-themes/colibre/cmd/lc_addwatch.png b/icon-themes/colibre/cmd/lc_addwatch.png index 59b2c31dd9a3..e8e408e68cce 100644 Binary files a/icon-themes/colibre/cmd/lc_addwatch.png and
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - sfx2/source
sfx2/source/view/viewsh.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 7b0259573fb3c16e43fb47cf5f2548c81f162383
Author: Andras Timar
AuthorDate: Mon May 15 22:06:10 2023 +0200
Commit: Andras Timar
CommitDate: Mon May 15 22:06:10 2023 +0200
fix unused exception parameter 'e'
Change-Id: Ibfee099e4e9b724648d7500b9ebb4e8ab84989b8
diff --git a/sfx2/source/view/viewsh.cxx b/sfx2/source/view/viewsh.cxx
index 132497876eb7..b19da3d1ee23 100644
--- a/sfx2/source/view/viewsh.cxx
+++ b/sfx2/source/view/viewsh.cxx
@@ -723,7 +723,7 @@ void LOKDocumentFocusListener::notifyEvent( const
accessibility::AccessibleEvent
break;
}
}
-catch( const lang::IndexOutOfBoundsException& e )
+catch( const lang::IndexOutOfBoundsException& )
{
SAL_WARN("lok.a11y", "Focused object has invalid index in parent");
}
[Libreoffice-bugs] [Bug 155329] Track changes in "hidden fields" breaks documents
https://bugs.documentfoundation.org/show_bug.cgi?id=155329 dav...@gmx.ch changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |WORKSFORME --- Comment #3 from dav...@gmx.ch --- Ok, I agree. Tried again with 7.5.3 and it works. Thanks! -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] help.git: source/text
source/text/shared/02/12100200.xhp | 213 +++-- 1 file changed, 111 insertions(+), 102 deletions(-) New commits: commit 08e07a280483ca2db507cc9d06848d53f64f7d12 Author: Olivier Hallot AuthorDate: Mon May 15 11:06:07 2023 -0300 Commit: Olivier Hallot CommitDate: Mon May 15 21:59:16 2023 +0200 tdf#155309 - Base Form link to right Help page + Add bookmark to right Help page + refactor + pretty-fy table. Change-Id: I7832bb3732bb96232f8bd644311c1336e2e491bd Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151791 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/source/text/shared/02/12100200.xhp b/source/text/shared/02/12100200.xhp index c1921daac0..b91f61c78f 100644 --- a/source/text/shared/02/12100200.xhp +++ b/source/text/shared/02/12100200.xhp @@ -20,259 +20,268 @@ -Find Record +Find Record /text/shared/02/12100200.xhp - + tables in databases; searching forms; browsing records; searching in databases searching; databases databases; searching records mw changed" database tables;" to "tables in databases;" - - + + + Find Record -Searches database tables and forms. In forms or database tables, you can search through data fields, list boxes, and check boxes for specific values. +Searches database tables and forms. In forms or database tables, you can search through data fields, list boxes, and check boxes for specific values. -When searching a table, the data fields of the current table are searched. When searching in a form, the data fields of the table linked with the form are searched. +When searching a table, the data fields of the current table are searched. When searching in a form, the data fields of the table linked with the form are searched. The search described here is carried out by %PRODUCTNAME. If you want to use the SQL server to search in a database, then you should use the Form-based Filters icon on the Form bar. -The search function is also available for table controls. When calling the search function from a table control, you can search each column of the table control corresponding to the database columns of the linked database table. +The search function is also available for table controls. When calling the search function from a table control, you can search each column of the table control corresponding to the database columns of the linked database table. Search for -Specifies the type of search. - - +Specifies the type of search. + + Text: -Enter the search term in the box or select it from the list. The text under the cursor is already copied into the Text combo box. Note that while running a search in a form, tabs and line breaks cannot be processed. -Your search terms will be saved as long as the table or the form document is open. If you are running more than one search and you would like to repeat the search term, you can select a previously used search term from the combo box. - +Enter the search term in the box or select it from the list. The text under the cursor is already copied into the Text combo box. Note that while running a search in a form, tabs and line breaks cannot be processed. +Your search terms will be saved as long as the table or the form document is open. If you are running more than one search and you would like to repeat the search term, you can select a previously used search term from the combo box. + Field content is NULL -Specifies that fields will be found that contain no data. - +Specifies that fields will be found that contain no data. + Field content is not NULL -Specifies that fields will be found that contain data. +Specifies that fields will be found that contain data. Where to search -Specifies the fields for the search. - +Specifies the fields for the search. + Form -Specifies the logical form in which you want the search to take place. +Specifies the logical form in which you want the search to take place. The Form combo box is only visible if the current document is a form document with more than one logical form. It does not appear during a search in tables or queries. -Form documents may contain multiple logical forms. These are individual form components, which are each linked to a table. -The Form combo box contains the names of all logical forms for which controls exist. - +Form documents may contain multiple logical forms. These are individual form components, which are each linked to a table. +The Form combo box contains the names of all logical forms for which controls exist. + All Fields -Searches through all fields. If you are running a search in a table, all fields in the table will be searched. If you are running a search in a form, all fields of the logical form (entered under Form) will be searched. If you are running a search in a table control field, all columns that are linked to a valid database table field
