[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - external/libxslt
external/libxslt/ExternalPackage_libxslt.mk |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 2808d5a6874d5956d99e02feb0fbf55a7343d63c Author: Stephan Bergmann AuthorDate: Tue Jul 4 08:31:28 2023 +0200 Commit: Taichi Haradaguchi <20001...@ymail.ne.jp> CommitDate: Wed Jul 5 07:40:06 2023 +0200 Fix Linux --without-system-libxml build ...after 362dfc50a28a918ec73609a00d2851eb3058375d "libxslt: upgrade to release 1.1.38" Change-Id: Id0ebf5676f79c43bb4fab3a33a2a19e303881aef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153942 Tested-by: Jenkins Reviewed-by: Stephan Bergmann (cherry picked from commit d1fc1c326470461def5ab092a311afee31950880) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154000 Reviewed-by: Taichi Haradaguchi <20001...@ymail.ne.jp> diff --git a/external/libxslt/ExternalPackage_libxslt.mk b/external/libxslt/ExternalPackage_libxslt.mk index c22a2e1b5dad..c1a8ee1217f1 100644 --- a/external/libxslt/ExternalPackage_libxslt.mk +++ b/external/libxslt/ExternalPackage_libxslt.mk @@ -25,7 +25,7 @@ $(eval $(call gb_ExternalPackage_add_file,libxslt,$(LIBO_LIB_FOLDER)/libexslt.dl endif else # OS!=WNT $(eval $(call gb_ExternalPackage_add_file,libxslt,$(LIBO_LIB_FOLDER)/libxslt.so.1,libxslt/.libs/libxslt.so.1.1.$(LIBXSLT_VERSION_MICRO))) -$(eval $(call gb_ExternalPackage_add_file,libxslt,$(LIBO_LIB_FOLDER)/libexslt.so.0,libexslt/.libs/libexslt.so.0.8.20)) +$(eval $(call gb_ExternalPackage_add_file,libxslt,$(LIBO_LIB_FOLDER)/libexslt.so.0,libexslt/.libs/libexslt.so.0.8.21)) endif endif # DISABLE_DYNLOADING
[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - sw/inc sw/qa sw/source writerfilter/source
sw/inc/autostyle_helper.hxx | 31 +++ sw/qa/extras/ooxmlimport/data/tdf141969-font_in_table_with_style.docx |binary sw/qa/extras/ooxmlimport/ooxmlimport2.cxx | 17 + sw/source/core/unocore/unoobj.cxx | 52 + sw/source/core/unocore/unostyle.cxx | 67 -- writerfilter/source/dmapper/DomainMapperTableHandler.cxx | 99 ++ 6 files changed, 213 insertions(+), 53 deletions(-) New commits: commit cece082f1b94e448ea807d22a1d177c33635406c Author: Mike Kaganski AuthorDate: Tue Jul 4 08:14:02 2023 +0300 Commit: Mike Kaganski CommitDate: Wed Jul 5 07:17:56 2023 +0200 tdf#141969: use paragraph autostyle to mimic Word's table style Word's table styles may define paragraph and character properties. They are handled in DomainMapperTableHandler::ApplyParagraphPropertiesFromTableStyle. When setting such a character property using setPropertyValue, it may apply to the text runs inside the paragraph, overriding values from character style and direct formatting, which must be kept. To fix that, this change creates a *paragraph* autostyle first, containing the properties; and then applies only this autostyle to the paragraph; the autostyle can't apply to runs, so the properties apply at paragraph level. Sadly, it is impossible to create a useful autostyle in writerfilter using UNO, because of the same problem that caused tdf#155945. UNO properties may define only parts of complex SfxPoolItem; setting them without having already applied values of such SfxPoolItem's would create wrong values for properties that weren't set by the UNO properties, but happen to share the same SfxPoolItem. To workaround that in writerfilter, a map of UNO names to sets of UNO names defining the complex property would be required, and then maintained. Instead, introduce a hidded 'ParaAutoStyleDef' property of SwXTextCursor, taking the same PropertyValue sequence as in XAutoStyleFamily::insertStyle. Implement it similarly to SwUnoCursorHelper::SetPropertyValues: first, build a WhichRangesContainer for specific WIDs needed for the properties; then obtain the actual values for these WIDs from the paragraph; and then set properties from the PropertyValue sequence. To create the autostyle properly, the code from SwXAutoStyleFamily::insertStyle is reused. There are more "proper" ways to fix this in part or as a whole, e.g.: * Split all complex SfxPoolItem's to simple ones, as done for one of them in commit db115bec9254417ef7a3faf687478fe5424ab378 (tdf#78510 sw,cui: split SvxLRSpaceItem for SwTextNode, SwTextFormatColl, 2023-02-24); * Rewrite writerfilter in sw; * Implement the missing proper table styles with paragraph and character properties, having the same precedence. But I don't feel crazy enough for any of these :D Change-Id: I07142cb23e8ec51f0e8ac8609f367ba247d94438 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153947 Tested-by: Jenkins Reviewed-by: Mike Kaganski (cherry picked from commit b036e563e699595fa7625888f11ab0c76f1abd66) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153989 diff --git a/sw/inc/autostyle_helper.hxx b/sw/inc/autostyle_helper.hxx new file mode 100644 index ..9336085db02e --- /dev/null +++ b/sw/inc/autostyle_helper.hxx @@ -0,0 +1,31 @@ +/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */ +/* + * This file is part of the LibreOffice project. + * + * This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. + */ + +#pragma once + +#include + +#include + +#include +#include + +#include + +#include "istyleaccess.hxx" +#include "swatrset.hxx" + +class SwDoc; + +std::shared_ptr +PropValuesToAutoStyleItemSet(SwDoc& rDoc, IStyleAccess::SwAutoStyleFamily eFamily, + const css::uno::Sequence& Values, + SfxItemSet& rSet); + +/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */ diff --git a/sw/qa/extras/ooxmlimport/data/tdf141969-font_in_table_with_style.docx b/sw/qa/extras/ooxmlimport/data/tdf141969-font_in_table_with_style.docx new file mode 100644 index ..6cbb8fb72e9d Binary files /dev/null and b/sw/qa/extras/ooxmlimport/data/tdf141969-font_in_table_with_style.docx differ diff --git a/sw/qa/extras/ooxmlimport/ooxmlimport2.cxx b/sw/qa/extras/ooxmlimport/ooxmlimport2.cxx index 20b190d59af6..a0a4d8051686 100644 --- a/sw/qa/extras/ooxmlimport/ooxmlimport2.cxx +++
[Libreoffice-bugs] [Bug 155624] A11y crash on cppunittester exit
https://bugs.documentfoundation.org/show_bug.cgi?id=155624 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155949] EDITING: Extending selection to next word includes after-word space
https://bugs.documentfoundation.org/show_bug.cgi?id=155949 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155952] WRITER: Absatzkontrolle in Tabellen wirkt nicht
https://bugs.documentfoundation.org/show_bug.cgi?id=155952 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156130] The tabs is automatically added to the preference after saving a docx file
https://bugs.documentfoundation.org/show_bug.cgi?id=156130 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155944] Irrelevant page positioning when maximizing a tiled window
https://bugs.documentfoundation.org/show_bug.cgi?id=155944 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156130] The tabs is automatically added to the preference after saving a docx file
https://bugs.documentfoundation.org/show_bug.cgi?id=156130 --- Comment #4 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156085] LibreOffice hangs at start, frequent crashes
https://bugs.documentfoundation.org/show_bug.cgi?id=156085 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156085] LibreOffice hangs at start, frequent crashes
https://bugs.documentfoundation.org/show_bug.cgi?id=156085 --- Comment #11 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152374] LibreOffice Draw crashes as soon as I begin to create a drawing
https://bugs.documentfoundation.org/show_bug.cgi?id=152374 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146661] Linked images anchored as characters are missing
https://bugs.documentfoundation.org/show_bug.cgi?id=146661 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152374] LibreOffice Draw crashes as soon as I begin to create a drawing
https://bugs.documentfoundation.org/show_bug.cgi?id=152374 --- Comment #6 from QA Administrators --- Dear toddfirk...@hotmail.com, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146661] Linked images anchored as characters are missing
https://bugs.documentfoundation.org/show_bug.cgi?id=146661 --- Comment #9 from QA Administrators --- Dear John, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142316] Shift+Space does not select the row
https://bugs.documentfoundation.org/show_bug.cgi?id=142316 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142316] Shift+Space does not select the row
https://bugs.documentfoundation.org/show_bug.cgi?id=142316 --- Comment #8 from QA Administrators --- Dear M Rumi, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152869] LibreOffice Writer crashes, when typing the document (macOS)
https://bugs.documentfoundation.org/show_bug.cgi?id=152869 --- Comment #3 from QA Administrators --- Dear Gen Lovyet Agustsson, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148604] LibreOffice and files wont launch
https://bugs.documentfoundation.org/show_bug.cgi?id=148604 --- Comment #3 from QA Administrators --- Dear kline0885, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148575] Crash when I tried to change the contents in a formula field of a write table
https://bugs.documentfoundation.org/show_bug.cgi?id=148575 --- Comment #8 from QA Administrators --- Dear special, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145957] Writer swap the view for my font "Liberation Sans" to "Liberation Serif" if the shapes is define to Bold or Italic
https://bugs.documentfoundation.org/show_bug.cgi?id=145957 --- Comment #7 from QA Administrators --- Dear estienne.bloch, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148493] replacement does not work well
https://bugs.documentfoundation.org/show_bug.cgi?id=148493 --- Comment #8 from QA Administrators --- Dear masao-okn, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148262] Fixed width text import not working
https://bugs.documentfoundation.org/show_bug.cgi?id=148262 --- Comment #2 from QA Administrators --- Dear aqui21584, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 136807] RTF Paste doesn't include image caption frame
https://bugs.documentfoundation.org/show_bug.cgi?id=136807 --- Comment #4 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 123338] FILEOPEN XLSX Comment arrangement is changing to default
https://bugs.documentfoundation.org/show_bug.cgi?id=123338 --- Comment #4 from QA Administrators --- Dear NISZ LibreOffice Team, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108342] BASE, Editing: list field in table grid shows status row changed on opening form when it's first column
https://bugs.documentfoundation.org/show_bug.cgi?id=108342 --- Comment #14 from QA Administrators --- Dear Gerhard Weydt, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118434] Comments not pasted when closing LibO between sessions (or between different versions of LibO)
https://bugs.documentfoundation.org/show_bug.cgi?id=118434 --- Comment #6 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 114760] Word Count problem with symbols in Chinese mixed with English text
https://bugs.documentfoundation.org/show_bug.cgi?id=114760 --- Comment #8 from QA Administrators --- Dear Cheng-Chia Tseng, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156113] Calc, Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=156113 Angie changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |FIXED --- Comment #4 from Angie --- Hi, version 7.5 is working well, menus stay readable and handles dark mode fine. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153446] Tabbed UI - Hidden button don't work when displayed then used
https://bugs.documentfoundation.org/show_bug.cgi?id=153446 --- Comment #4 from Justin L --- More specifically, rMEvt.IsLeft(), but !mpView->IsCreateObj(). The problem can be avoided by not calling mpViewShell->GetViewFrame()->GetDispatcher()->Execute(SID_OBJECT_SELECT, SfxCallMode::ASYNCHRON) It switches to select mode for FuConstruct::MouseButtonUp and FuConstructCustomShape::MouseButtonUp. However, I'm not seeing any way that seems legitimate to skip FuConstruct. MouseButtonDown is lost early, in winproc.cxx ImplHandleMouseEvent if ( !pChild && !bMouseLeave ) return false; -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - sc/qa
sc/qa/unit/ThemeImportExportTest.cxx | 61 +--
1 file changed, 38 insertions(+), 23 deletions(-)
New commits:
commit cf2356bf647bd3edf63cb98dc56d627916597a03
Author: Tomaž Vajngerl
AuthorDate: Fri Jun 30 15:46:22 2023 +0900
Commit: Tomaž Vajngerl
CommitDate: Wed Jul 5 03:20:58 2023 +0200
sc: test export of model::Theme into theme1.xml with xpath
Change-Id: I9b2b61a5ae93a0738fb90aa20b20f9a9ecc7272b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153786
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
(cherry picked from commit 8164915520b27b655372e7521b2a58978516f88d)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153920
diff --git a/sc/qa/unit/ThemeImportExportTest.cxx
b/sc/qa/unit/ThemeImportExportTest.cxx
index 0cf03ea6c010..c04a90dc6f54 100644
--- a/sc/qa/unit/ThemeImportExportTest.cxx
+++ b/sc/qa/unit/ThemeImportExportTest.cxx
@@ -34,30 +34,45 @@ CPPUNIT_TEST_FIXTURE(ThemeImportExportTest, testThemeExport)
save("Calc Office Open XML");
-xmlDocUniquePtr pXmlDoc = parseExport("xl/styles.xml");
-
-assertXPath(pXmlDoc, "/x:styleSheet", 1);
-
-// Fonts
-assertXPath(pXmlDoc, "/x:styleSheet/x:fonts/x:font", 6);
-
-assertXPath(pXmlDoc, "/x:styleSheet/x:fonts/x:font[5]/x:color", "theme",
"7");
-
-assertXPath(pXmlDoc, "/x:styleSheet/x:fonts/x:font[6]/x:color", "rgb",
"FF9C5700");
-
-// Fills
-assertXPath(pXmlDoc, "/x:styleSheet/x:fills/x:fill", 4);
-
-assertXPath(pXmlDoc, "/x:styleSheet/x:fills/x:fill[1]/x:patternFill",
"patternType", "none");
-
-assertXPath(pXmlDoc, "/x:styleSheet/x:fills/x:fill[2]/x:patternFill",
"patternType", "gray125");
-
-assertXPath(pXmlDoc, "/x:styleSheet/x:fills/x:fill[3]/x:patternFill",
"patternType", "solid");
-assertXPath(pXmlDoc,
"/x:styleSheet/x:fills/x:fill[3]/x:patternFill/x:fgColor", "rgb",
-"EB9C");
+{
+xmlDocUniquePtr pXmlDoc = parseExport("xl/theme/theme1.xml");
+OString aClrScheme = "/a:theme/a:themeElements/a:clrScheme";
+assertXPath(pXmlDoc, aClrScheme, "name", "Office");
+assertXPath(pXmlDoc, aClrScheme + "/a:dk1/a:srgbClr", "val", "00");
+assertXPath(pXmlDoc, aClrScheme + "/a:lt1/a:srgbClr", "val", "ff");
+assertXPath(pXmlDoc, aClrScheme + "/a:dk2/a:srgbClr", "val", "44546a");
+assertXPath(pXmlDoc, aClrScheme + "/a:lt2/a:srgbClr", "val", "e7e6e6");
+assertXPath(pXmlDoc, aClrScheme + "/a:accent1/a:srgbClr", "val",
"4472c4");
+assertXPath(pXmlDoc, aClrScheme + "/a:accent2/a:srgbClr", "val",
"ed7d31");
+assertXPath(pXmlDoc, aClrScheme + "/a:accent3/a:srgbClr", "val",
"a5a5a5");
+assertXPath(pXmlDoc, aClrScheme + "/a:accent4/a:srgbClr", "val",
"ffc000");
+assertXPath(pXmlDoc, aClrScheme + "/a:accent5/a:srgbClr", "val",
"5b9bd5");
+assertXPath(pXmlDoc, aClrScheme + "/a:accent6/a:srgbClr", "val",
"70ad47");
+assertXPath(pXmlDoc, aClrScheme + "/a:hlink/a:srgbClr", "val",
"0563c1");
+assertXPath(pXmlDoc, aClrScheme + "/a:folHlink/a:srgbClr", "val",
"954f72");
+}
-assertXPath(pXmlDoc, "/x:styleSheet/x:fills/x:fill[4]/x:patternFill",
"patternType", "solid");
-assertXPath(pXmlDoc,
"/x:styleSheet/x:fills/x:fill[4]/x:patternFill/x:fgColor", "theme", "4");
+{
+xmlDocUniquePtr pXmlDoc = parseExport("xl/styles.xml");
+
+assertXPath(pXmlDoc, "/x:styleSheet", 1);
+
+// Fonts
+OString aFont = "/x:styleSheet/x:fonts/x:font";
+assertXPath(pXmlDoc, aFont, 6);
+assertXPath(pXmlDoc, aFont + "[5]/x:color", "theme", "7");
+assertXPath(pXmlDoc, aFont + "[6]/x:color", "rgb", "FF9C5700");
+
+// Fills
+OString aFill = "/x:styleSheet/x:fills/x:fill";
+assertXPath(pXmlDoc, aFill, 4);
+assertXPath(pXmlDoc, aFill + "[1]/x:patternFill", "patternType",
"none");
+assertXPath(pXmlDoc, aFill + "[2]/x:patternFill", "patternType",
"gray125");
+assertXPath(pXmlDoc, aFill + "[3]/x:patternFill", "patternType",
"solid");
+assertXPath(pXmlDoc, aFill + "[3]/x:patternFill/x:fgColor", "rgb",
"EB9C");
+assertXPath(pXmlDoc, aFill + "[4]/x:patternFill", "patternType",
"solid");
+assertXPath(pXmlDoc, aFill + "[4]/x:patternFill/x:fgColor", "theme",
"4");
+}
}
// Round 100th percent to percent value - so that small differences don't fail
the test
[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - chart2/source
chart2/source/controller/main/ControllerCommandDispatch.cxx | 13 ---
chart2/source/inc/RegressionCurveHelper.hxx |1
chart2/source/tools/RegressionCurveHelper.cxx | 14
chart2/source/tools/RegressionCurveModel.cxx|1
chart2/source/tools/RegressionEquation.cxx |8 ++
5 files changed, 34 insertions(+), 3 deletions(-)
New commits:
commit 47d3f102add9a46216e9082efdff362eb8555ad3
Author: Laurent Balland
AuthorDate: Sun Jun 18 19:25:39 2023 +0200
Commit: Tomaž Vajngerl
CommitDate: Wed Jul 5 03:19:43 2023 +0200
tdf#155526 Moving average: remove Insert R2
Moving average trend line does not R² value.
This change remove "Insert R²" from context menu when the trend is of
type "Moving average"
Change-Id: I729a6421df34859e7176c798a2b68a6f13cfb544
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153294
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
(cherry picked from commit aa86e7e8c22527eb5da0b8a05dbd4bd749f7a2b8)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153838
diff --git a/chart2/source/controller/main/ControllerCommandDispatch.cxx
b/chart2/source/controller/main/ControllerCommandDispatch.cxx
index 620082bd99d8..ba659fd00449 100644
--- a/chart2/source/controller/main/ControllerCommandDispatch.cxx
+++ b/chart2/source/controller/main/ControllerCommandDispatch.cxx
@@ -285,23 +285,28 @@ void ControllerState::update(
// Trendline Equation
bMayFormatTrendlineEquation = bMayDeleteTrendlineEquation =
RegressionCurveHelper::hasEquation( xRegCurve );
bMayAddTrendlineEquation = !bMayDeleteTrendlineEquation;
+bMayAddR2Value = RegressionCurveHelper::MayHaveCorrelationCoefficient(
xRegCurve ) && bMayAddTrendlineEquation;
}
else if( aObjectType == OBJECTTYPE_DATA_CURVE_EQUATION )
{
bMayFormatTrendlineEquation = true;
bool bHasR2Value = false;
+bool bMayHaveR2 = true;
try
{
uno::Reference< beans::XPropertySet > xEquationProperties =
ObjectIdentifier::getObjectPropertySet( aSelObjCID, xModel );
if( xEquationProperties.is() )
+{
xEquationProperties->getPropertyValue(
"ShowCorrelationCoefficient" ) >>= bHasR2Value;
+xEquationProperties->getPropertyValue(
"MayHaveCorrelationCoefficient" ) >>= bMayHaveR2;
+}
}
catch(const uno::RuntimeException&)
{
TOOLS_WARN_EXCEPTION("chart2", "" );
}
-bMayAddR2Value = !bHasR2Value;
+bMayAddR2Value = !bHasR2Value && bMayHaveR2;
bMayDeleteR2Value = bHasR2Value;
}
}
@@ -672,8 +677,10 @@ void ControllerCommandDispatch::updateCommandAvailability()
m_aCommandAvailability[ ".uno:InsertMeanValue" ] = bIsWritable &&
bControllerStateIsValid && m_apControllerState->bMayAddMeanValue;
m_aCommandAvailability[ ".uno:InsertTrendline" ] = bIsWritable &&
bControllerStateIsValid && m_apControllerState->bMayAddTrendline;
m_aCommandAvailability[ ".uno:InsertTrendlineEquation" ] = bIsWritable &&
bControllerStateIsValid && m_apControllerState->bMayAddTrendlineEquation;
-m_aCommandAvailability[ ".uno:InsertTrendlineEquationAndR2" ] =
m_aCommandAvailability[ ".uno:InsertTrendlineEquation" ];
-m_aCommandAvailability[ ".uno:InsertR2Value" ] = bIsWritable &&
bControllerStateIsValid && m_apControllerState->bMayAddR2Value;
+m_aCommandAvailability[ ".uno:InsertTrendlineEquationAndR2" ] =
+m_aCommandAvailability[ ".uno:InsertTrendlineEquation" ] &&
m_apControllerState->bMayAddR2Value;
+m_aCommandAvailability[ ".uno:InsertR2Value" ] = bIsWritable &&
bControllerStateIsValid && m_apControllerState->bMayAddR2Value
+&& !m_apControllerState->bMayAddTrendlineEquation;
m_aCommandAvailability[ ".uno:DeleteR2Value" ] = bIsWritable &&
bControllerStateIsValid && m_apControllerState->bMayDeleteR2Value;
m_aCommandAvailability[ ".uno:InsertXErrorBars" ] = bIsWritable &&
bControllerStateIsValid && m_apControllerState->bMayAddXErrorBars;
diff --git a/chart2/source/inc/RegressionCurveHelper.hxx
b/chart2/source/inc/RegressionCurveHelper.hxx
index 2666b41d9bb9..e2df1bb4cd4d 100644
--- a/chart2/source/inc/RegressionCurveHelper.hxx
+++ b/chart2/source/inc/RegressionCurveHelper.hxx
@@ -199,6 +199,7 @@ namespace chart::RegressionCurveHelper
const rtl::Reference<::chart::RegressionCurveModel>& xCurve );
OOO_DLLPUBLIC_CHARTTOOLS bool hasEquation(const
css::uno::Reference& xCurve );
+OOO_DLLPUBLIC_CHARTTOOLS bool MayHaveCorrelationCoefficient(const
css::uno::Reference& xCurve );
} // namespace chart
diff --git a/chart2/source/tools/RegressionCurveHelper.cxx
b/chart2/source/tools/RegressionCurveHelper.cxx
index 2ff161bf0cf7..9626b07c1fbd 100644
--- a/chart2/source/tools/RegressionCurveHelper.cxx
+++
[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit a5475addd81434478d7f91cbff098f64d72e877a Author: Olivier Hallot AuthorDate: Tue Jul 4 21:48:16 2023 -0300 Commit: Gerrit Code Review CommitDate: Wed Jul 5 02:48:16 2023 +0200 Update git submodules * Update helpcontent2 from branch 'libreoffice-7-6' to 29efaac233accae71a698ad64231f47d0dfc5f62 - Add bookmarks to PostgreSQL help page Change-Id: I8e3e52446b9b58e34faf479829ce72cfc4680f8b Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154013 Tested-by: Jenkins Reviewed-by: Olivier Hallot (cherry picked from commit ccaa099da1def9e89347af3f1759f48f9fa538ba) Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154004 diff --git a/helpcontent2 b/helpcontent2 index ee8c6dd6dbbf..29efaac233ac 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit ee8c6dd6dbbf5bba930a9264d9e1929be21dacbb +Subproject commit 29efaac233accae71a698ad64231f47d0dfc5f62
[Libreoffice-commits] help.git: Branch 'libreoffice-7-6' - source/text
source/text/sdatabase/dabawiz02pgsql.xhp |9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) New commits: commit 29efaac233accae71a698ad64231f47d0dfc5f62 Author: Olivier Hallot AuthorDate: Tue Jul 4 21:45:35 2023 -0300 Commit: Olivier Hallot CommitDate: Wed Jul 5 02:48:16 2023 +0200 Add bookmarks to PostgreSQL help page Change-Id: I8e3e52446b9b58e34faf479829ce72cfc4680f8b Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154013 Tested-by: Jenkins Reviewed-by: Olivier Hallot (cherry picked from commit ccaa099da1def9e89347af3f1759f48f9fa538ba) Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154004 diff --git a/source/text/sdatabase/dabawiz02pgsql.xhp b/source/text/sdatabase/dabawiz02pgsql.xhp index 92990dacbf..abbdfca5dc 100644 --- a/source/text/sdatabase/dabawiz02pgsql.xhp +++ b/source/text/sdatabase/dabawiz02pgsql.xhp @@ -19,15 +19,17 @@ PostgreSQL settings (Base) - PostgreSQL Connection Specifies the options for connecting to PostgreSQL databases. - + Direct connection to PostgreSQL databases The data for the direct connection to a PostgreSQL database can be provided in two different ways: Fill in the data Connection data can be provided by filling in the top three text boxes. Ask the database administrator for the correct data. + + + Database name: type the name of the specific database. @@ -38,7 +40,8 @@ Port number: enter the port number of the DBMS server. - + + DBMS/driver-specific connection string Instead of entering the data in the text boxes as explained above, or if you need to specify more parameter for the connection, you can enter the driver specific connection string. The connection string is a sequence of keyword/value pairs separated by spaces. For example dbname=MyDatabase host=myHost port=5432
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit d74344f6cae0cf1c12f08249c8f49be1374fb98f Author: Olivier Hallot AuthorDate: Tue Jul 4 21:47:16 2023 -0300 Commit: Gerrit Code Review CommitDate: Wed Jul 5 02:47:16 2023 +0200 Update git submodules * Update helpcontent2 from branch 'master' to ccaa099da1def9e89347af3f1759f48f9fa538ba - Add bookmarks to PostgreSQL help page Change-Id: I8e3e52446b9b58e34faf479829ce72cfc4680f8b Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154013 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index 2fd43ac04f55..ccaa099da1de 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 2fd43ac04f55c78c7e323dc28509889d027f7a42 +Subproject commit ccaa099da1def9e89347af3f1759f48f9fa538ba
[Libreoffice-commits] help.git: source/text
source/text/sdatabase/dabawiz02pgsql.xhp |9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) New commits: commit ccaa099da1def9e89347af3f1759f48f9fa538ba Author: Olivier Hallot AuthorDate: Tue Jul 4 21:45:35 2023 -0300 Commit: Olivier Hallot CommitDate: Wed Jul 5 02:47:16 2023 +0200 Add bookmarks to PostgreSQL help page Change-Id: I8e3e52446b9b58e34faf479829ce72cfc4680f8b Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154013 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/source/text/sdatabase/dabawiz02pgsql.xhp b/source/text/sdatabase/dabawiz02pgsql.xhp index 92990dacbf..abbdfca5dc 100644 --- a/source/text/sdatabase/dabawiz02pgsql.xhp +++ b/source/text/sdatabase/dabawiz02pgsql.xhp @@ -19,15 +19,17 @@ PostgreSQL settings (Base) - PostgreSQL Connection Specifies the options for connecting to PostgreSQL databases. - + Direct connection to PostgreSQL databases The data for the direct connection to a PostgreSQL database can be provided in two different ways: Fill in the data Connection data can be provided by filling in the top three text boxes. Ask the database administrator for the correct data. + + + Database name: type the name of the specific database. @@ -38,7 +40,8 @@ Port number: enter the port number of the DBMS server. - + + DBMS/driver-specific connection string Instead of entering the data in the text boxes as explained above, or if you need to specify more parameter for the connection, you can enter the driver specific connection string. The connection string is a sequence of keyword/value pairs separated by spaces. For example dbname=MyDatabase host=myHost port=5432
[Libreoffice-bugs] [Bug 80430] [META] Documentation gap for new features
https://bugs.documentfoundation.org/show_bug.cgi?id=80430 Bug 80430 depends on bug 155031, which changed state. Bug 155031 Summary: [LOCALHELP] Document style indicator in Help https://bugs.documentfoundation.org/show_bug.cgi?id=155031 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155031] [LOCALHELP] Document style indicator in Help
https://bugs.documentfoundation.org/show_bug.cgi?id=155031 Olivier Hallot changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/mimo/mimo-7-4' - 2 commits - sc/qa sc/source
sc/qa/unit/helper/qahelper.cxx | 38 ++
sc/source/core/data/dpoutput.cxx |6 +-
sc/source/ui/view/viewfun3.cxx |2 ++
3 files changed, 45 insertions(+), 1 deletion(-)
New commits:
commit 3a51b402f243eb32b544c16813f682617d88c0b9
Author: luigiiucci
AuthorDate: Wed May 17 11:02:37 2023 +0200
Commit: Aron Budea
CommitDate: Wed Jul 5 01:23:40 2023 +0200
Header columns can disappear with filtered data in pivot tables
When we set on a pivot table a filter that filters all the rows,
the pivot table showed only the first header columns and computed
column, but all the columns headers should still be shown so we can
adjust the filter for the column. This fixes this issue.
Also add more debug output and prevent a crash when running pivot
table tests.
Change-Id: I30b4ee72cf8436c4522ab4ba0781462b214816dd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151871
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
(cherry picked from commit 3551d18404cb19cdaa8edb170a549f5c5405d0cb)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153686
Tested-by: Jenkins CollaboraOffice
diff --git a/sc/qa/unit/helper/qahelper.cxx b/sc/qa/unit/helper/qahelper.cxx
index 9a5c5124cb08..99a8492ce87d 100644
--- a/sc/qa/unit/helper/qahelper.cxx
+++ b/sc/qa/unit/helper/qahelper.cxx
@@ -43,6 +43,7 @@
#include
#include
#include
+#include
#include
@@ -527,6 +528,43 @@ bool checkOutput(
svl::GridPrinter printer(e.Row() - s.Row() + 1, e.Col() - s.Col() + 1,
CALC_DEBUG_OUTPUT != 0);
SCROW nOutRowSize = e.Row() - s.Row() + 1;
SCCOL nOutColSize = e.Col() - s.Col() + 1;
+
+// Check if expected size iz smaller than actual size (and prevent a crash)
+if (aCheck.size() < o3tl::make_unsigned(nOutRowSize) || aCheck[0].size() <
o3tl::make_unsigned(nOutColSize))
+{
+// Dump the arrays to console, so we can compare
+std::cout << "Expected data:" << std::endl;
+for (size_t nRow = 0; nRow < aCheck.size(); ++nRow)
+{
+for (size_t nCol = 0; nCol < aCheck[nRow].size(); ++nCol)
+{
+const char* p = aCheck[nRow][nCol];
+if (p)
+{
+OUString aCheckVal = OUString::createFromAscii(p);
+std::cout << "'" << aCheckVal << "', ";
+}
+else
+std::cout << "null, ";
+}
+std::cout << std::endl;
+}
+
+std::cout << "Actual data:" << std::endl;
+for (SCROW nRow = 0; nRow < nOutRowSize; ++nRow)
+{
+for (SCCOL nCol = 0; nCol < nOutColSize; ++nCol)
+{
+OUString aVal = pDoc->GetString(nCol + s.Col(), nRow +
s.Row(), s.Tab());
+std::cout << "'" << aVal << "', ";
+}
+std::cout << std::endl;
+}
+std::cout << std::endl;
+
+return false;
+}
+
for (SCROW nRow = 0; nRow < nOutRowSize; ++nRow)
{
for (SCCOL nCol = 0; nCol < nOutColSize; ++nCol)
diff --git a/sc/source/core/data/dpoutput.cxx b/sc/source/core/data/dpoutput.cxx
index bf2109b300a3..b8565852d511 100644
--- a/sc/source/core/data/dpoutput.cxx
+++ b/sc/source/core/data/dpoutput.cxx
@@ -600,7 +600,11 @@ ScDPOutput::ScDPOutput( ScDocument* pD, const
uno::Reference
aResult = xLevRes->getResults();
-if (!lcl_MemberEmpty(aResult))
+// We want only to remove the DATA
column if it is empty
+// and not any other empty columns (to
still show the
+// header columns)
+bool bSkip = lcl_MemberEmpty(aResult)
&& bIsDataLayout;
+if (!bSkip)
{
ScDPOutLevelData tmp(nDim,
nHierarchy, nLev, nDimPos, nNumFmt, aResult, aName,
aCaption,
bHasHiddenMember, bIsDataLayout, false);
commit 0d38ec8443312398f81aa1eac57e97211018022d
Author: Luigi Iucci
AuthorDate: Wed Jun 21 10:16:16 2023 +0200
Commit: Aron Budea
CommitDate: Tue Jul 4 12:52:47 2023 +0200
problem pasting to calc an image copied from firefox (windows)
Calc tries to paste the image as html.
In case both HTML_SIMPLE and BITMAP flavors are present in
the clipboard, we paste as BITMAP
Change-Id: I2527bedf11eb6986b58329acaf360a397af03101
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153614
Tested-by: Jenkins
Reviewed-by: Henry Castro
(cherry picked from commit 46fa17b70db0d543518dde52908f46c85838ac12)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153668
Reviewed-by: Xisco Fauli
[Libreoffice-bugs] [Bug 156164] New: MCGR 3D Cube renders border with wrong color
https://bugs.documentfoundation.org/show_bug.cgi?id=156164 Bug ID: 156164 Summary: MCGR 3D Cube renders border with wrong color Product: LibreOffice Version: 24.2.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rb.hensc...@t-online.de Created attachment 188213 --> https://bugs.documentfoundation.org/attachment.cgi?id=188213=edit Compare 3D-cube with 2D-square Open attached document. It has a 3D-cube and 2D-square which use the same graphic style. The style uses a gradient with 60% border (UI "Transition start"). It has three gradient stops: offset 0 color #0033ff offset 0 color #00 offset 1 color #00 The 2D-square renders it correctly, but the 3D-cube has a wrong color in the area of the border. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - vcl/source
vcl/source/gdi/pdfwriter_impl.cxx | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
New commits:
commit fe2c0663436879b2d562f0c921da3f844017d85a
Author: Khaled Hosny
AuthorDate: Tue Jul 4 15:49:35 2023 +
Commit: Adolfo Jayme Barrientos
CommitDate: Wed Jul 5 01:20:43 2023 +0200
tdf#156151: Take PDF DPI into account when outputting Type 3 glyphs
We were always assuming the default 720 DPI, but this is not always true
when printing to file as the DPI would depend on printer settings in
this case.
Change-Id: I747f8e24f0942ecb94eb8acfc1dd9972d83ba0e3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153978
Tested-by: Jenkins
Reviewed-by: خالد حسني
(cherry picked from commit 4b05805df02eadd920e808c8f82dbfd1038b4be8)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153996
Reviewed-by: Adolfo Jayme Barrientos
diff --git a/vcl/source/gdi/pdfwriter_impl.cxx
b/vcl/source/gdi/pdfwriter_impl.cxx
index 432f25b04ba1..b5653748ac8e 100644
--- a/vcl/source/gdi/pdfwriter_impl.cxx
+++ b/vcl/source/gdi/pdfwriter_impl.cxx
@@ -2649,6 +2649,10 @@ bool PDFWriterImpl::emitType3Font(const
vcl::font::PhysicalFontFace* pFace,
ResourceDict aResourceDict;
std::list aOutputStreams;
+// Scale for glyph outlines.
+double fScaleX = GetDPIX() / 72.;
+double fScaleY = GetDPIY() / 72.;
+
for (auto i = 1u; i < nGlyphs; i++)
{
auto nStream = pGlyphStreams[i];
@@ -2731,9 +2735,12 @@ bool PDFWriterImpl::emitType3Font(const
vcl::font::PhysicalFontFace* pFace,
const auto& rOutline = rGlyph.getOutline();
if (rOutline.count())
{
-// XXX I have no idea why this transformation matrix is needed.
-aContents.append("q 10 0 0 10 0 ");
-appendDouble(m_aPages.back().getHeight() * -10, aContents, 3);
+aContents.append("q ");
+appendDouble(fScaleX, aContents);
+aContents.append(" 0 0 ");
+appendDouble(fScaleY, aContents);
+aContents.append(" 0 ");
+appendDouble(m_aPages.back().getHeight() * -fScaleY,
aContents, 3);
aContents.append(" cm\n");
m_aPages.back().appendPolyPolygon(rOutline, aContents);
aContents.append("f\n"
[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - vcl/source
vcl/source/gdi/pdfwriter_impl.cxx | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
New commits:
commit ef155fcf7bb78a2788f66cad3d6008b9203f5a32
Author: Khaled Hosny
AuthorDate: Tue Jul 4 15:49:35 2023 +
Commit: Adolfo Jayme Barrientos
CommitDate: Wed Jul 5 01:20:58 2023 +0200
tdf#156151: Take PDF DPI into account when outputting Type 3 glyphs
We were always assuming the default 720 DPI, but this is not always true
when printing to file as the DPI would depend on printer settings in
this case.
Change-Id: I747f8e24f0942ecb94eb8acfc1dd9972d83ba0e3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153978
Tested-by: Jenkins
Reviewed-by: خالد حسني
(cherry picked from commit c1dcffceb14cd35c7168ba2108b2f2e9aa875b56)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153997
Reviewed-by: Adolfo Jayme Barrientos
diff --git a/vcl/source/gdi/pdfwriter_impl.cxx
b/vcl/source/gdi/pdfwriter_impl.cxx
index 56d3db20716c..b6901420bddf 100644
--- a/vcl/source/gdi/pdfwriter_impl.cxx
+++ b/vcl/source/gdi/pdfwriter_impl.cxx
@@ -2673,6 +2673,10 @@ bool PDFWriterImpl::emitType3Font(const
vcl::font::PhysicalFontFace* pFace,
ResourceDict aResourceDict;
std::list aOutputStreams;
+// Scale for glyph outlines.
+double fScaleX = GetDPIX() / 72.;
+double fScaleY = GetDPIY() / 72.;
+
for (auto i = 1u; i < nGlyphs; i++)
{
auto nStream = pGlyphStreams[i];
@@ -2753,9 +2757,12 @@ bool PDFWriterImpl::emitType3Font(const
vcl::font::PhysicalFontFace* pFace,
const auto& rOutline = rGlyph.getOutline();
if (rOutline.count())
{
-// XXX I have no idea why this transformation matrix is needed.
-aContents.append("q 10 0 0 10 0 ");
-appendDouble(m_aPages.back().getHeight() * -10, aContents, 3);
+aContents.append("q ");
+appendDouble(fScaleX, aContents);
+aContents.append(" 0 0 ");
+appendDouble(fScaleY, aContents);
+aContents.append(" 0 ");
+appendDouble(m_aPages.back().getHeight() * -fScaleY,
aContents, 3);
aContents.append(" cm\n");
m_aPages.back().appendPolyPolygon(rOutline, aContents);
aContents.append("f\n");
[Libreoffice-bugs] [Bug 154072] crash / no effect when clicking some dropdown buttons when toolbar overflows
https://bugs.documentfoundation.org/show_bug.cgi?id=154072 Stéphane Guillou (stragu) changed: What|Removed |Added Regression By||Caolán McNamara -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154072] crash / no effect when clicking some dropdown buttons when toolbar overflows
https://bugs.documentfoundation.org/show_bug.cgi?id=154072 Stéphane Guillou (stragu) changed: What|Removed |Added CC||cont...@philippemosca.fr --- Comment #9 from Stéphane Guillou (stragu) --- *** Bug 156158 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156158] Menu can't be opened in reduced window
https://bugs.documentfoundation.org/show_bug.cgi?id=156158 Stéphane Guillou (stragu) changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE CC||stephane.guillou@libreoffic ||e.org --- Comment #4 from Stéphane Guillou (stragu) --- Sounds like the same regression as bug 154072. *** This bug has been marked as a duplicate of bug 154072 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 111450] [META] SVG fileSave filter (Draw/Impress)
https://bugs.documentfoundation.org/show_bug.cgi?id=111450 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||120941 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=120941 [Bug 120941] Impress: export to SVG results in unnecessarily large file (because of included script) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108226] [META] PPTX (OOXML) bug tracker
https://bugs.documentfoundation.org/show_bug.cgi?id=108226 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on|120941 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=120941 [Bug 120941] Impress: export to SVG results in unnecessarily large file (because of included script) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103378] [META] PDF export bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103378 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on|120941 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=120941 [Bug 120941] Impress: export to SVG results in unnecessarily large file (because of included script) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 120941] Impress: export to SVG results in unnecessarily large file (because of included script)
https://bugs.documentfoundation.org/show_bug.cgi?id=120941 Stéphane Guillou (stragu) changed: What|Removed |Added CC||stephane.guillou@libreoffic ||e.org Version|6.0.0.0.alpha0+ |5.2.0.4 release Component|Printing and PDF export |filters and storage Summary|PPTX with dashed line |Impress: export to SVG |exported to a large size|results in unnecessarily |SVG |large file (because of ||included script) Blocks|103378, 108226 |111450 --- Comment #14 from Stéphane Guillou (stragu) --- I suppose a solution to avoid multiple paths could be to support stroke-dasharray on SVG export: https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/stroke-dasharray But in this case, the exported SVG is mainly made up of an ECMAScript from line 161 to line 16704. This is not specific to PPTX. One can export an ODP file to SVG, the same script will be included. Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: ec60d354359067f8c5c686ef2239ee705916de43 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103378 [Bug 103378] [META] PDF export bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=108226 [Bug 108226] [META] PPTX (OOXML) bug tracker https://bugs.documentfoundation.org/show_bug.cgi?id=111450 [Bug 111450] [META] SVG fileSave filter (Draw/Impress) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153711] FILESAVE DOCX. Character theme color is not exported as theme color
https://bugs.documentfoundation.org/show_bug.cgi?id=153711 Aron Budea changed: What|Removed |Added Whiteboard| QA:needsComment| Hardware|x86-64 (AMD64) |All CC||aron.bu...@gmail.com OS|Windows (All) |All -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 64459] SVG: dashed line shown too fat/big
https://bugs.documentfoundation.org/show_bug.cgi?id=64459 Stéphane Guillou (stragu) changed: What|Removed |Added Component|LibreOffice |filters and storage Summary|SVG: dashed line shown to |SVG: dashed line shown too |fat/big |fat/big CC||stephane.guillou@libreoffic ||e.org Hardware|Other |All Status|RESOLVED|VERIFIED --- Comment #13 from Stéphane Guillou (stragu) --- (tested before seeing Xisco's recent comments, but sharing anyway) I could reproduce: - thick dashes on insert in Writer 6.0.0.3 - missing and misplaced text on import in Draw 6.0.0.3 - missing arrow line on insert in Writer 6.4.7.2 But now it looks true to original on both import and insert in: Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: ec60d354359067f8c5c686ef2239ee705916de43 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded Thick dash issue remains on break after import in Draw, but this should be tracked in a separate report if not already covered elsewhere. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152997] SVG: circle based upon combination of solid lines + dashes, only renders as solid line
https://bugs.documentfoundation.org/show_bug.cgi?id=152997 Stéphane Guillou (stragu) changed: What|Removed |Added Keywords||filter:svg Blocks||88278 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=88278 [Bug 88278] [META] SVG import image filter (all modules) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 88278] [META] SVG import image filter (all modules)
https://bugs.documentfoundation.org/show_bug.cgi?id=88278 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||152997 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=152997 [Bug 152997] SVG: circle based upon combination of solid lines + dashes, only renders as solid line -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156160] Long dash not properly rendered in presentation mode with GDI rendering
https://bugs.documentfoundation.org/show_bug.cgi?id=156160 Stéphane Guillou (stragu) changed: What|Removed |Added CC||stephane.guillou@libreoffic ||e.org --- Comment #3 from Stéphane Guillou (stragu) --- Could you check if it started in 7.0, like for bug 152997? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108230] [META] OOXML document theme issues
https://bugs.documentfoundation.org/show_bug.cgi?id=108230 Gabor Kelemen (allotropia) changed: What|Removed |Added Depends on||153711 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=153711 [Bug 153711] FILESAVE DOCX. Character theme color is not exported as theme color -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153711] FILESAVE DOCX. Character theme color is not exported as theme color
https://bugs.documentfoundation.org/show_bug.cgi?id=153711 Gabor Kelemen (allotropia) changed: What|Removed |Added Ever confirmed|0 |1 Blocks||108230 Status|UNCONFIRMED |NEW CC||kelem...@ubuntu.com --- Comment #1 from Gabor Kelemen (allotropia) --- Confirming in Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: e4e5fb4b2935e395c7e4b3a794d544a6f44709ce CPU threads: 15; OS: Windows 10.0 Build 19045; UI render: default; VCL: win Locale: de-DE (hu_HU); UI: en-US Calc: threaded Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108230 [Bug 108230] [META] OOXML document theme issues -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155211] Regression: dashed lines become solid when breaking imported SVG / exporting to SVG
https://bugs.documentfoundation.org/show_bug.cgi?id=155211 Stéphane Guillou (stragu) changed: What|Removed |Added CC||andygp...@gmail.com --- Comment #11 from Stéphane Guillou (stragu) --- *** Bug 148179 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148179] Dashed boxes, lines and polygons appear solid in exported SVG
https://bugs.documentfoundation.org/show_bug.cgi?id=148179 Stéphane Guillou (stragu) changed: What|Removed |Added Keywords|filter:svg | CC||stephane.guillou@libreoffic ||e.org --- Comment #2 from Stéphane Guillou (stragu) --- Changing to duplicate of 155211, which is a 7.1/7.2 regression rather than the inherited issue described in bug 86206. Thanks Andy! *** This bug has been marked as a duplicate of bug 155211 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 88918] Edit→Hyperlink… is greyed out when an object with a hyperlink is selected in Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=88918 Stéphane Guillou (stragu) changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||6159 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 107733] [META] Hyperlink bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107733 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||156159 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=156159 [Bug 156159] Shape hyperlinks don't act like other hyperlinks in Draw when they are first hyperlinked (OK after reload) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156159] Shape hyperlinks don't act like other hyperlinks in Draw when they are first hyperlinked (OK after reload)
https://bugs.documentfoundation.org/show_bug.cgi?id=156159 Stéphane Guillou (stragu) changed: What|Removed |Added Version|7.4.7.2 release |7.3.0.0 alpha0+ Blocks||107733 See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=88 ||918, ||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||3626 Summary|Shape hyperlinks don't act |Shape hyperlinks don't act |link other hyperlinks in|like other hyperlinks in |Draw|Draw when they are first ||hyperlinked (OK after ||reload) Status|UNCONFIRMED |NEW Ever confirmed|0 |1 CC||samuel.mehrbrodt@allotropia ||.de, ||stephane.guillou@libreoffic ||e.org Keywords||implementationError OS|Windows (All) |All --- Comment #2 from Stéphane Guillou (stragu) --- Testing in: Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: e4e5fb4b2935e395c7e4b3a794d544a6f44709ce CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded I can confirm: - The shape can't be Ctrl + clicked when adding the hyperlinked. One needs to save and reload the file to be able to use the hyperlink. - The "Edit hyperlink" is missing in the context menu. However, I think this could be tracked in the related issue with Edit > Hyperlink being greyed: bug 88918. One odd thing is that, if I am editing the text box below the shape in your attachment, a single click on the shape (without Ctrl) is sufficient to open the link in browser. Ability to interact with the shape as any other link was implemented by Samuel in 7.3 with 9a04703b22f9ffb11256d715f65e79a6a2417e18. Samuel, can you please have a look? Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107733 [Bug 107733] [META] Hyperlink bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/source
sw/source/core/unocore/unoobj2.cxx | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
New commits:
commit 16a94d2b25198442af1257574bf88007c8b352f3
Author: Xisco Fauli
AuthorDate: Tue Jul 4 15:53:39 2023 +0200
Commit: Xisco Fauli
CommitDate: Tue Jul 4 23:05:45 2023 +0200
sw: fix crash in CreateParentXText
See
https://crashreport.libreoffice.org/stats/signature/SfxObjectShell::GetBaseModel()
Change-Id: Idcfc8219b5765bca9c45819bde5f276ce68c45de
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153971
Reviewed-by: Caolán McNamara
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
diff --git a/sw/source/core/unocore/unoobj2.cxx
b/sw/source/core/unocore/unoobj2.cxx
index 210e62655a15..1b02cb5a0b27 100644
--- a/sw/source/core/unocore/unoobj2.cxx
+++ b/sw/source/core/unocore/unoobj2.cxx
@@ -1307,12 +1307,14 @@ CreateParentXText(SwDoc & rDoc, const SwPosition& rPos)
break;
default:
{
-// then it is the body text
-const uno::Reference xModel =
-rDoc.GetDocShell()->GetBaseModel();
-const uno::Reference< text::XTextDocument > xDoc(
-xModel, uno::UNO_QUERY);
-xParentText = xDoc->getText();
+if (SwDocShell *const pDocSh = rDoc.GetDocShell())
+{
+// then it is the body text
+const uno::Reference xModel =
pDocSh->GetBaseModel();
+const uno::Reference< text::XTextDocument > xDoc(
+xModel, uno::UNO_QUERY);
+xParentText = xDoc->getText();
+}
}
}
OSL_ENSURE(xParentText.is(), "no parent text?");
[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - 2 commits - sw/qa sw/source
sw/qa/extras/ooxmlimport/data/tdf156078_rightTabOutsideParaRightIndent.docx
|binary
sw/qa/extras/ooxmlimport/ooxmlimport2.cxx |
34 ++
sw/source/core/text/itrpaint.cxx|
7 +-
3 files changed, 39 insertions(+), 2 deletions(-)
New commits:
commit 3e04f54f7efdc0f7373c248b9ba02e6fd5a43da2
Author: Mike Kaganski
AuthorDate: Wed Jun 28 18:54:43 2023 +0300
Commit: Xisco Fauli
CommitDate: Tue Jul 4 22:59:59 2023 +0200
tdf#156078: Use TabOverSpacing compat option instead of TabOverflow
As Justin Luth noted, "TabOverflow is basically always true", and
using it basically equal to making the test always true. On the
other hand, TabOverSpacing is accurate for the task.
Change-Id: I608b200dac0169cbafc935a03452aac9ba0527a6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153722
Tested-by: Jenkins
Reviewed-by: Justin Luth
Signed-off-by: Xisco Fauli
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153876
diff --git a/sw/source/core/text/itrpaint.cxx b/sw/source/core/text/itrpaint.cxx
index 9c6dc347a47c..a189e5abf25b 100644
--- a/sw/source/core/text/itrpaint.cxx
+++ b/sw/source/core/text/itrpaint.cxx
@@ -167,8 +167,8 @@ void SwTextPainter::DrawTextLine( const SwRect ,
SwSaveClip ,
//compatibility settings: allow tabstop text to exceed right margin
const auto& iDSA =
GetInfo().GetTextFrame()->GetDoc().getIDocumentSettingAccess();
const bool bTabOverMargin = iDSA.get(DocumentSettingId::TAB_OVER_MARGIN);
-const bool bTabOverflow = iDSA.get(DocumentSettingId::TAB_OVERFLOW);
-if (bTabOverMargin || bTabOverflow)
+const bool bTabOverSpacing = iDSA.get(DocumentSettingId::TAB_OVER_SPACING);
+if (bTabOverMargin || bTabOverSpacing)
{
SwLinePortion* pPorIter = pPor;
while( pPorIter )
commit 237a550af3b4ec1223decf451fb41dc74c229080
Author: Mike Kaganski
AuthorDate: Tue Jun 27 17:42:49 2023 +0300
Commit: Xisco Fauli
CommitDate: Tue Jul 4 22:59:54 2023 +0200
tdf#156078: also consider TabOverflow for tabs outside of line bounds
Before commit 29bd00f7628e7a54e69cabcc7e2a1792c24aa55c, TabOverMargin
compat option was set for DOCX with any compat mode. After that commit,
the unset option disallowed output of content after a tab stop outside
of the paragraph indents, even within page margins.
SwTabPortion::PreFormat consults TabOverflow when checking if position
is outside the frame; so let's consult it also when painting.
Change-Id: I05ada0da6cd765c70b7bad1287ccc8c11d9b60ba
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153672
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
Signed-off-by: Xisco Fauli
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153875
diff --git
a/sw/qa/extras/ooxmlimport/data/tdf156078_rightTabOutsideParaRightIndent.docx
b/sw/qa/extras/ooxmlimport/data/tdf156078_rightTabOutsideParaRightIndent.docx
new file mode 100644
index ..cc2715cf6acd
Binary files /dev/null and
b/sw/qa/extras/ooxmlimport/data/tdf156078_rightTabOutsideParaRightIndent.docx
differ
diff --git a/sw/qa/extras/ooxmlimport/ooxmlimport2.cxx
b/sw/qa/extras/ooxmlimport/ooxmlimport2.cxx
index c3e834823c02..20b190d59af6 100644
--- a/sw/qa/extras/ooxmlimport/ooxmlimport2.cxx
+++ b/sw/qa/extras/ooxmlimport/ooxmlimport2.cxx
@@ -23,6 +23,9 @@
#include
#include
+#include
+#include
+#include
#include
#include
@@ -1143,6 +1146,37 @@ CPPUNIT_TEST_FIXTURE(Test, testTdf154695)
}
}
+CPPUNIT_TEST_FIXTURE(Test, testTdf156078)
+{
+// Given a DOCX with compat level 15, and a tab stop outside of paragraph
right indent
+createSwDoc("tdf156078_rightTabOutsideParaRightIndent.docx");
+
+// Export it to a PNG (96 ppi)
+uno::Sequence aFilterData(
+comphelper::InitPropertySequence({ { "PixelWidth",
uno::Any(sal_Int32(816)) },
+ { "PixelHeight",
uno::Any(sal_Int32(1056)) } }));
+uno::Sequence
aDescriptor(comphelper::InitPropertySequence(
+{ { "FilterName", uno::Any(OUString("writer_png_Export")) },
+ { "FilterData", uno::Any(aFilterData) } }));
+uno::Reference xStorable(mxComponent, uno::UNO_QUERY);
+xStorable->storeToURL(maTempFile.GetURL(), aDescriptor);
+CPPUNIT_ASSERT(maTempFile.IsValid());
+
+Graphic exported;
+GraphicFilter::LoadGraphic(maTempFile.GetURL(), {}, exported);
+Bitmap bmp = exported.GetBitmapEx().GetBitmap();
+Bitmap::ScopedReadAccess pAccess(bmp);
+
+// "1" must export to the top right corner; check its pixels
+bool numberPixelsFound = false;
+for (tools::Long y = 90; y < 130; ++y)
+for (tools::Long x = 680; x < 720; ++x)
+if (Color(pAccess->GetPixel(y, x)).IsDark())
+numberPixelsFound = true;
+
+CPPUNIT_ASSERT(numberPixelsFound);
+}
+
// tests should
[Libreoffice-bugs] [Bug 103378] [META] PDF export bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103378 Gabor Kelemen (allotropia) changed: What|Removed |Added Depends on||155228 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=155228 [Bug 155228] Syntax error in PDF for Tab key of page object -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 113122] [META] PDF bugs and enhancement
https://bugs.documentfoundation.org/show_bug.cgi?id=113122 Gabor Kelemen (allotropia) changed: What|Removed |Added Depends on|155228 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=155228 [Bug 155228] Syntax error in PDF for Tab key of page object -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 88918] Edit→Hyperlink… is greyed out when an object with a hyperlink is selected in Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=88918 Stéphane Guillou (stragu) changed: What|Removed |Added Keywords||needsDevEval Hardware|Other |All CC||hoss...@libreoffice.org, ||stephane.guillou@libreoffic ||e.org Version|4.3.5.2 release |Inherited From OOo --- Comment #12 from Stéphane Guillou (stragu) --- Same in OOo 3.3, so inherited. Still present in a recent 24.2 master build. Hossein, maybe an easyHack ? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 85184] [META] Color picker toolbar, dialog and sidebar drop-down widget bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=85184 Bug 85184 depends on bug 142962, which changed state. Bug 142962 Summary: The text color button resets to it's default color when entering and exiting textboxes https://bugs.documentfoundation.org/show_bug.cgi?id=142962 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142962] The text color button resets to it's default color when entering and exiting textboxes
https://bugs.documentfoundation.org/show_bug.cgi?id=142962 Maxim Monastirsky changed: What|Removed |Added Status|NEW |RESOLVED CC||momonas...@gmail.com Resolution|--- |DUPLICATE --- Comment #3 from Maxim Monastirsky --- *** This bug has been marked as a duplicate of bug 154270 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 113122] [META] PDF bugs and enhancement
https://bugs.documentfoundation.org/show_bug.cgi?id=113122 Gabor Kelemen (allotropia) changed: What|Removed |Added Depends on||155228 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=155228 [Bug 155228] Syntax error in PDF for Tab key of page object -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 113395] [META] Color split and group buttons in toolbar and sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=113395 Bug 113395 depends on bug 90852, which changed state. Bug 90852 Summary: TOOLBAR: 'Area Style / Filing' drop down control doesnt update 'Fill Color' drop down https://bugs.documentfoundation.org/show_bug.cgi?id=90852 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 90852] TOOLBAR: 'Area Style / Filing' drop down control doesnt update 'Fill Color' drop down
https://bugs.documentfoundation.org/show_bug.cgi?id=90852 Maxim Monastirsky changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #8 from Maxim Monastirsky --- *** This bug has been marked as a duplicate of bug 154270 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - sw/qa
sw/qa/uitest/writer_tests5/DateFormFieldPropertiesDialog.py |6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
New commits:
commit a3f74ebbb9082c6d8e15a10ea51e19f47de84510
Author: Mike Kaganski
AuthorDate: Tue Jul 4 06:20:36 2023 +0300
Commit: Xisco Fauli
CommitDate: Tue Jul 4 22:47:39 2023 +0200
Fix a UITest on Windows
Change-Id: I9645cea2394f945355f86b3f6013d1d0f5117c76
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153940
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
(cherry picked from commit 80569dc996a9a814ad7c2e729f30443debdbc6fe)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153923
Reviewed-by: Xisco Fauli
diff --git a/sw/qa/uitest/writer_tests5/DateFormFieldPropertiesDialog.py
b/sw/qa/uitest/writer_tests5/DateFormFieldPropertiesDialog.py
index eb43912782bc..0c556b6c2b65 100644
--- a/sw/qa/uitest/writer_tests5/DateFormFieldPropertiesDialog.py
+++ b/sw/qa/uitest/writer_tests5/DateFormFieldPropertiesDialog.py
@@ -9,6 +9,7 @@
from uitest.framework import UITestCase
from uitest.uihelper.common import get_state_as_dict, get_url_for_data_file
from libreoffice.uno.propertyvalue import mkPropertyValues
+import platform
class dateFormFieldDialog(UITestCase):
@@ -138,6 +139,9 @@ class dateFormFieldDialog(UITestCase):
xWriterEdit.executeAction("TYPE", mkPropertyValues({"KEYCODE":
"ALT+DOWN"}))
xWriterEdit.executeAction("TYPE", mkPropertyValues({"KEYCODE":
"ESC"}))
xWriterEdit.executeAction("TYPE", mkPropertyValues({"KEYCODE":
"UP"}))
-self.assertEqual(writer_doc.getText().getString(), "\nClick to
choose a date")
+if platform.system() == "Windows":
+self.assertEqual(writer_doc.getText().getString(), "\r\nClick
to choose a date")
+else:
+self.assertEqual(writer_doc.getText().getString(), "\nClick to
choose a date")
# vim: set shiftwidth=4 softtabstop=4 expandtab:
[Libreoffice-bugs] [Bug 139007] [META] PDF accessibility
https://bugs.documentfoundation.org/show_bug.cgi?id=139007 Bug 139007 depends on bug 151826, which changed state. Bug 151826 Summary: PAC Checker fails with PDF containing TOC https://bugs.documentfoundation.org/show_bug.cgi?id=151826 What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 84909] [META] Enhancing Impress/Draw toolbars and context menu
https://bugs.documentfoundation.org/show_bug.cgi?id=84909 Bug 84909 depends on bug 139209, which changed state. Bug 139209 Summary: DRAW: UI for line color in toolbars not consistent with (underlying) selected color https://bugs.documentfoundation.org/show_bug.cgi?id=139209 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139209] DRAW: UI for line color in toolbars not consistent with (underlying) selected color
https://bugs.documentfoundation.org/show_bug.cgi?id=139209 Maxim Monastirsky changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED CC||momonas...@gmail.com --- Comment #4 from Maxim Monastirsky --- *** This bug has been marked as a duplicate of bug 154270 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154102] Not all line color settings updating after changing colors in one
https://bugs.documentfoundation.org/show_bug.cgi?id=154102 Maxim Monastirsky changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEEDINFO|RESOLVED CC||momonas...@gmail.com --- Comment #2 from Maxim Monastirsky --- *** This bug has been marked as a duplicate of bug 154270 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156163] New: Thick Lines Not Printing as Thick
https://bugs.documentfoundation.org/show_bug.cgi?id=156163 Bug ID: 156163 Summary: Thick Lines Not Printing as Thick Product: LibreOffice Version: unspecified Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: catheri...@vivaldi.net Description: 1. insert 2 lines 2. make one line 0.07 thick, don't change other line 3. hit print to PDF or export as PDF EXPECTED: 2 different lines, one thick one thin ACTUAL BUG RESULT: 2 SAME LINES, ALL THIN Steps to Reproduce: 1. insert 2 lines 2. make one line 0.07 thick, don't change other line 3. hit print to PDF or export as PDF EXPECTED: 2 different lines, one thick one thin ACTUAL BUG RESULT: 2 SAME LINES, ALL THIN Actual Results: EXPECTED: 2 different lines, one thick one thin ACTUAL BUG RESULT: 2 SAME LINES, ALL THIN Expected Results: EXPECTED: 2 different lines, one thick one thin ACTUAL BUG RESULT: 2 SAME LINES, ALL THIN Reproducible: Always User Profile Reset: No Additional Info: Version: 7.5.4.2 (X86_64) / LibreOffice Community Build ID: 36ccfdc35048b057fd9854c757a8b67ec53977b6 CPU threads: 16; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win Locale: en-CA (en_CA); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 106179] [META] Writer comment bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=106179 Bug 106179 depends on bug 153429, which changed state. Bug 153429 Summary: Formatting of comments not applied to newly inserted https://bugs.documentfoundation.org/show_bug.cgi?id=153429 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 107833] [META] Writer paragraph style bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107833 Bug 107833 depends on bug 153429, which changed state. Bug 153429 Summary: Formatting of comments not applied to newly inserted https://bugs.documentfoundation.org/show_bug.cgi?id=153429 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 102950] Format All Comments is not persistent for new comments
https://bugs.documentfoundation.org/show_bug.cgi?id=102950 Maxim Monastirsky changed: What|Removed |Added CC||tim.chambers1...@gmail.com --- Comment #14 from Maxim Monastirsky --- *** Bug 153429 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153429] Formatting of comments not applied to newly inserted
https://bugs.documentfoundation.org/show_bug.cgi?id=153429 Maxim Monastirsky changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Maxim Monastirsky --- *** This bug has been marked as a duplicate of bug 102950 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - include/sfx2 sc/source sd/source sfx2/source sw/inc sw/source
include/sfx2/viewsh.hxx |2 ++
sc/source/ui/inc/tabvwsh.hxx|2 ++
sc/source/ui/view/tabvwshc.cxx |5 +
sd/source/ui/inc/ViewShellBase.hxx |2 ++
sd/source/ui/view/ViewShellBase.cxx | 12
sfx2/source/appl/appserv.cxx| 20 ++--
sfx2/source/view/viewsh.cxx |6 ++
sw/inc/view.hxx |2 ++
sw/inc/viewopt.hxx |2 +-
sw/source/core/view/vnew.cxx| 17 -
sw/source/uibase/uiview/viewprt.cxx | 14 ++
11 files changed, 80 insertions(+), 4 deletions(-)
New commits:
commit 884fd220d0025a92510d3ff4710c8c517c8f271e
Author: Paris Oplopoios
AuthorDate: Mon Jul 3 19:00:59 2023 +0300
Commit: Paris Oplopoios
CommitDate: Tue Jul 4 22:12:16 2023 +0200
Make sure views get new themes on .uno:ChangeTheme
It would be that sometimes .uno:ChangeTheme would not load the new
scheme because it was using EditableConfig::GetCurrentSchemeName which
uses a static name - normally great except for when you need different
views to have different color schemes in tiled rendering
Change-Id: I5b149bd1a4776337f76753c6de98d5386a899d34
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153939
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Paris Oplopoios
diff --git a/include/sfx2/viewsh.hxx b/include/sfx2/viewsh.hxx
index 2435caa52a47..78f75b7067dd 100644
--- a/include/sfx2/viewsh.hxx
+++ b/include/sfx2/viewsh.hxx
@@ -409,6 +409,8 @@ public:
virtual vcl::Window* GetEditWindowForActiveOLEObj() const override;
/// Get a color config color from this view
virtual ::Color GetColorConfigColor(svtools::ColorConfigEntry nColorType)
const;
+/// Get the color scheme name of this view
+virtual OUString GetColorConfigName() const;
/// Set the LibreOfficeKit language of this view.
void SetLOKLanguageTag(const OUString& rBcp47LanguageTag);
diff --git a/sc/source/ui/inc/tabvwsh.hxx b/sc/source/ui/inc/tabvwsh.hxx
index ee3edd020def..d32f664b5536 100644
--- a/sc/source/ui/inc/tabvwsh.hxx
+++ b/sc/source/ui/inc/tabvwsh.hxx
@@ -395,6 +395,8 @@ public:
void NotifyCursor(SfxViewShell* pViewShell) const override;
/// See SfxViewShell::GetColorConfigColor().
::Color GetColorConfigColor(svtools::ColorConfigEntry nColorType) const
override;
+/// See SfxViewShell::GetColorConfigName().
+OUString GetColorConfigName() const override;
/// Emits a LOK_CALLBACK_INVALIDATE_HEADER for all views whose current tab
is equal to nCurrentTabIndex
static void notifyAllViewsHeaderInvalidation(const SfxViewShell*
pForViewShell, HeaderType eHeaderType, SCTAB nCurrentTabIndex);
static bool isAnyEditViewInRange(const SfxViewShell* pForViewShell, bool
bColumns, SCCOLROW nStart, SCCOLROW nEnd);
diff --git a/sc/source/ui/view/tabvwshc.cxx b/sc/source/ui/view/tabvwshc.cxx
index 3b50da7114cb..517a00c8f2e1 100644
--- a/sc/source/ui/view/tabvwshc.cxx
+++ b/sc/source/ui/view/tabvwshc.cxx
@@ -516,6 +516,11 @@ void ScTabViewShell::NotifyCursor(SfxViewShell*
pOtherShell) const
return {};
}
+OUString ScTabViewShell::GetColorConfigName() const
+{
+return GetViewData().GetOptions().GetColorSchemeName();
+}
+
css::uno::Reference
ScTabViewShell::GetClipData(vcl::Window* pWin)
{
SfxViewFrame* pViewFrame = nullptr;
diff --git a/sd/source/ui/inc/ViewShellBase.hxx
b/sd/source/ui/inc/ViewShellBase.hxx
index aa0346ea5b2f..71522c7892d4 100644
--- a/sd/source/ui/inc/ViewShellBase.hxx
+++ b/sd/source/ui/inc/ViewShellBase.hxx
@@ -223,6 +223,8 @@ public:
void NotifyCursor(SfxViewShell* pViewShell) const override;
/// See SfxViewShell::GetColorConfigColor().
::Color GetColorConfigColor(svtools::ColorConfigEntry nColorType) const
override;
+/// See SfxViewShell::GetColorConfigName().
+OUString GetColorConfigName() const override;
void setLOKVisibleArea(const ::tools::Rectangle& rArea) { maLOKVisibleArea
= rArea; }
virtual ::tools::Rectangle getLOKVisibleArea() const override { return
maLOKVisibleArea; }
diff --git a/sd/source/ui/view/ViewShellBase.cxx
b/sd/source/ui/view/ViewShellBase.cxx
index 834e1d6cc3e2..19be45aaca12 100644
--- a/sd/source/ui/view/ViewShellBase.cxx
+++ b/sd/source/ui/view/ViewShellBase.cxx
@@ -1091,6 +1091,18 @@ void ViewShellBase::NotifyCursor(SfxViewShell*
pOtherShell) const
return {};
}
+OUString ViewShellBase::GetColorConfigName() const
+{
+if (DrawViewShell* pCurrentDrawShell =
dynamic_cast(GetMainViewShell().get()))
+{
+const SdViewOptions& rViewOptions =
pCurrentDrawShell->GetViewOptions();
+return rViewOptions.msColorSchemeName;
+}
+
+SAL_WARN("sd", "dynamic_cast to DrawViewShell failed");
+return {};
+}
+
//= ViewShellBase::Implementation =
ViewShellBase::Implementation::Implementation (ViewShellBase& rBase)
diff
[Libreoffice-bugs] [Bug 72991] Font, highlight and background color in toolbar buttons is not remembered for next session
https://bugs.documentfoundation.org/show_bug.cgi?id=72991 Maxim Monastirsky changed: What|Removed |Added Blocks|34804 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=34804 [Bug 34804] EDITING: Keyboard shortcut for Format-Highlighting does not work -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 34804] EDITING: Keyboard shortcut for Format-Highlighting does not work
https://bugs.documentfoundation.org/show_bug.cgi?id=34804 Maxim Monastirsky changed: What|Removed |Added Depends on|72991 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=72991 [Bug 72991] Font, highlight and background color in toolbar buttons is not remembered for next session -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 113395] [META] Color split and group buttons in toolbar and sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=113395 Bug 113395 depends on bug 82438, which changed state. Bug 82438 Summary: No synchronization between color attributes in the toolbar and sidebar https://bugs.documentfoundation.org/show_bug.cgi?id=82438 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 34804] EDITING: Keyboard shortcut for Format-Highlighting does not work
https://bugs.documentfoundation.org/show_bug.cgi?id=34804 Bug 34804 depends on bug 82438, which changed state. Bug 82438 Summary: No synchronization between color attributes in the toolbar and sidebar https://bugs.documentfoundation.org/show_bug.cgi?id=82438 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 82438] No synchronization between color attributes in the toolbar and sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=82438 Maxim Monastirsky changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #12 from Maxim Monastirsky --- *** This bug has been marked as a duplicate of bug 154270 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 113395] [META] Color split and group buttons in toolbar and sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=113395 Bug 113395 depends on bug 113433, which changed state. Bug 113433 Summary: Color split buttons should display the recently used color https://bugs.documentfoundation.org/show_bug.cgi?id=113433 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 82438] No synchronization between color attributes in the toolbar and sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=82438 Bug 82438 depends on bug 113433, which changed state. Bug 113433 Summary: Color split buttons should display the recently used color https://bugs.documentfoundation.org/show_bug.cgi?id=113433 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 72991] Font, highlight and background color in toolbar buttons is not remembered for next session
https://bugs.documentfoundation.org/show_bug.cgi?id=72991 Bug 72991 depends on bug 113433, which changed state. Bug 113433 Summary: Color split buttons should display the recently used color https://bugs.documentfoundation.org/show_bug.cgi?id=113433 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 113433] Color split buttons should display the recently used color
https://bugs.documentfoundation.org/show_bug.cgi?id=113433 Maxim Monastirsky changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #14 from Maxim Monastirsky --- *** This bug has been marked as a duplicate of bug 154270 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 113731] [META] Highlight bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=113731 Bug 113731 depends on bug 139803, which changed state. Bug 139803 Summary: highlight and font colours are always reset to defaults (after print preview) without asking! https://bugs.documentfoundation.org/show_bug.cgi?id=139803 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 113395] [META] Color split and group buttons in toolbar and sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=113395 Bug 113395 depends on bug 139803, which changed state. Bug 139803 Summary: highlight and font colours are always reset to defaults (after print preview) without asking! https://bugs.documentfoundation.org/show_bug.cgi?id=139803 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139803] highlight and font colours are always reset to defaults (after print preview) without asking!
https://bugs.documentfoundation.org/show_bug.cgi?id=139803 Maxim Monastirsky changed: What|Removed |Added Resolution|--- |DUPLICATE CC||momonas...@gmail.com Status|NEW |RESOLVED --- Comment #7 from Maxim Monastirsky --- *** This bug has been marked as a duplicate of bug 154270 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 113395] [META] Color split and group buttons in toolbar and sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=113395 Bug 113395 depends on bug 122003, which changed state. Bug 122003 Summary: Color split and group buttons in toolbar loose their settings when window is smaller than toolbar https://bugs.documentfoundation.org/show_bug.cgi?id=122003 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 112974] [META] Toolbar overflow/wrap/chevron button bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=112974 Bug 112974 depends on bug 122003, which changed state. Bug 122003 Summary: Color split and group buttons in toolbar loose their settings when window is smaller than toolbar https://bugs.documentfoundation.org/show_bug.cgi?id=122003 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 122003] Color split and group buttons in toolbar loose their settings when window is smaller than toolbar
https://bugs.documentfoundation.org/show_bug.cgi?id=122003 Maxim Monastirsky changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #6 from Maxim Monastirsky --- *** This bug has been marked as a duplicate of bug 154270 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 102062] [META] Notebookbar: bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102062 Bug 102062 depends on bug 150785, which changed state. Bug 150785 Summary: Color pickers reset to defaults on User Interface change https://bugs.documentfoundation.org/show_bug.cgi?id=150785 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150785] Color pickers reset to defaults on User Interface change
https://bugs.documentfoundation.org/show_bug.cgi?id=150785 Maxim Monastirsky changed: What|Removed |Added CC||momonas...@gmail.com Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #6 from Maxim Monastirsky --- *** This bug has been marked as a duplicate of bug 154270 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156162] New: Unhelpful error message when trying to install an extension over an existing macro library
https://bugs.documentfoundation.org/show_bug.cgi?id=156162 Bug ID: 156162 Summary: Unhelpful error message when trying to install an extension over an existing macro library Product: LibreOffice Version: 7.4.7.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: minor Priority: medium Component: Extensions Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: abree...@iquantumdg.com Description: When trying to install an extension, the error message "!link" appears if the extension contains a macro library of the same name as one that already exists. Steps to Reproduce: 1. Create a BASIC macro library 2. Export that library as an extension 3. Install that extension Actual Results: An error message box appears that just says "!link", and the extension is installed, but disabled Expected Results: Either it allows the extension to be enabled (perhaps checking if the existing macro library is identical to the extension's library, and allowing it if so), or it provides a human-understandable error message (such as "Extensions cannot be installed over an existing macro library"). Reproducible: Always User Profile Reset: Yes Additional Info: I got this error message when trying to follow this tutorial on the Libre Office wiki: https://wiki.documentfoundation.org/Development/Create_a_Hello_World_LibreOffice_extension That tutorial's GitHub repo has several issues flagged up recently about the same problem (so presumably this error didn't appear when the tutorial was created in 2019): https://github.com/luane-aquino/helloworld-libreoffice-extension/issues Help > About LibreOffice: Version: 7.5.4.2 (X86_64) / LibreOffice Community Build ID: 36ccfdc35048b057fd9854c757a8b67ec53977b6 CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Vulkan; VCL: win Locale: en-GB (en_GB); UI: en-GB Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 113359] [META] Calc toolbar bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=113359 Bug 113359 depends on bug 154270, which changed state. Bug 154270 Summary: Colours reset to defaults with Single Toolbar UI https://bugs.documentfoundation.org/show_bug.cgi?id=154270 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
