[Libreoffice-bugs] [Bug 156832] Symbol names in Math examples are not localized
https://bugs.documentfoundation.org/show_bug.cgi?id=156832 --- Comment #1 from Theppitak Karoonboonyanan --- FYI, I have untranslated all symbol names for Thai in master. It's also more appropriate for Thai users to use original English names in codes, as there are several localized versions in use in text books, although there is a standardization effort by the Royal Academy. With the untranslated names, the problem is gone. But the inconsistency of symbol names in examples is still a valid bug. They should still be localized anyway. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: configure.ac
configure.ac | 24 +--- 1 file changed, 17 insertions(+), 7 deletions(-) New commits: commit 1530584a7214ca92b457b24ebf5f0e444d805dca Author: Mike Kaganski AuthorDate: Wed Aug 23 00:24:47 2023 +0300 Commit: Mike Kaganski CommitDate: Wed Aug 23 06:43:02 2023 +0200 MPL subset: don't stop on first error - collect it all Otherwise, I have to disable items one by one, only to get to the next error. Change-Id: I21b915ccc2ebca32d185c8b68697fcb2991e005c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155959 Tested-by: Jenkins Reviewed-by: Mike Kaganski diff --git a/configure.ac b/configure.ac index 77d916ac8b5a..9249c73ef1d2 100644 --- a/configure.ac +++ b/configure.ac @@ -14668,6 +14668,8 @@ AC_MSG_CHECKING([MPL subset]) MPL_SUBSET= if test "$enable_mpl_subset" = "yes"; then +mpl_error_string= +newline=$'\n*' warn_report=false if test "$enable_report_builder" != "no" -a "$with_java" != "no"; then warn_report=true @@ -14675,35 +14677,43 @@ if test "$enable_mpl_subset" = "yes"; then warn_report=true fi if test "$warn_report" = "true"; then -AC_MSG_ERROR([need to --disable-report-builder - extended database report builder.]) +mpl_error_string="$mpl_error_string$newline Need to --disable-report-builder - extended database report builder." fi if test "x$enable_postgresql_sdbc" != "xno"; then -AC_MSG_ERROR([need to --disable-postgresql-sdbc - the PostgreSQL database backend.]) +mpl_error_string="$mpl_error_string$newline Need to --disable-postgresql-sdbc - the PostgreSQL database backend." fi if test "$enable_lotuswordpro" = "yes"; then -AC_MSG_ERROR([need to --disable-lotuswordpro - a Lotus Word Pro file format import filter.]) +mpl_error_string="$mpl_error_string$newline Need to --disable-lotuswordpro - a Lotus Word Pro file format import filter." fi if test -n "$ENABLE_POPPLER"; then if test "x$SYSTEM_POPPLER" = "x"; then -AC_MSG_ERROR([need to disable PDF import via poppler or use system library]) +mpl_error_string="$mpl_error_string$newline Need to disable PDF import via poppler or use system library." fi fi # cf. m4/libo_check_extension.m4 if test "x$WITH_EXTRA_EXTENSIONS" != "x"; then -AC_MSG_ERROR([need to disable extra extensions '$WITH_EXTRA_EXTENSIONS']) +mpl_error_string="$mpl_error_string$newline Need to disable extra extensions '$WITH_EXTRA_EXTENSIONS'." fi +denied_themes= for theme in $WITH_THEMES; do case $theme in breeze|breeze_dark|breeze_dark_svg|breeze_svg|elementary|elementary_svg|karasa_jaga|karasa_jaga_svg) #denylist of icon themes under GPL or LGPL -AC_MSG_ERROR([need to disable icon themes from '$WITH_THEMES': $theme present, use --with-theme=colibre]) ;; +denied_themes="$denied_themes $theme" ;; *) : ;; esac done +if test "x$denied_themes" != "x"; then +mpl_error_string="$mpl_error_string$newline Need to disable icon themes from '$WITH_THEMES': $denied_themes present, use --with-theme=colibre." +fi ENABLE_OPENGL_TRANSITIONS= if test "$enable_lpsolve" != "no" -o "x$ENABLE_LPSOLVE" = "xTRUE"; then -AC_MSG_ERROR([need to --disable-lpsolve - calc linear programming solver.]) +mpl_error_string="$mpl_error_string$newline Need to --disable-lpsolve - calc linear programming solver." +fi + +if test "x$mpl_error_string" != "x"; then +AC_MSG_ERROR([$mpl_error_string]) fi MPL_SUBSET="TRUE"
Re: Machine learning is used in gerrit build
Hi Thorsten,
I've modified the condition logic a little bit. Originally, gerrit_master
will run if SUCCESS or "jenkins:all" is set, but gerrit_master_seq will run
if not SUCCESS, so it may run again when "jenkins:all" is set.
Now, I've added another condition ("jenkins:all" is not set) for
gerrit_master_seq, such that only one of them will run. Hope it makes sense.
Best,
Baole Fang
On Tue, Aug 22, 2023 at 8:25 AM Thorsten Behrens
wrote:
> Hi Baole,
>
> Baole Fang wrote:
> > Hi Thorsten,
> >
> > After quickly checking the gerrit_master_ml and gerrit_master_seq
> > configuration, I didn't notice the change. Can you indicate the change
> for
> > me?
> >
> Sure - look into
> https://ci.libreoffice.org/view/Gerrit/job/gerrit_master_ml/configure
> , and search for GERRIT_TOPIC. There's a short-circuit check to divert
> into "normal" multijob, if that matches jenkins:all.
>
> Cheers,
>
> -- Thorsten
[Libreoffice-bugs] [Bug 156640] REPORTBUILDER: Blank Window after change of Data Field Type
https://bugs.documentfoundation.org/show_bug.cgi?id=156640 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156598] Custom list numbering from DOCX import is not available in UI
https://bugs.documentfoundation.org/show_bug.cgi?id=156598 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156662] Always using direct connection to api.languagetool.org
https://bugs.documentfoundation.org/show_bug.cgi?id=156662 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156826] Impossible de pré-formater des cellules
https://bugs.documentfoundation.org/show_bug.cgi?id=156826 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156674] UI: formula help still displayed when editing cell formatted as text
https://bugs.documentfoundation.org/show_bug.cgi?id=156674 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156676] Spreadsheet: converting formulas formatted as text to show formula result
https://bugs.documentfoundation.org/show_bug.cgi?id=156676 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 156598] Custom list numbering from DOCX import is not available in UI
https://bugs.documentfoundation.org/show_bug.cgi?id=156598 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 156826] Impossible de pré-formater des cellules
https://bugs.documentfoundation.org/show_bug.cgi?id=156826 --- Comment #7 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156606] Fileopen DOTX: poorly converted in writer
https://bugs.documentfoundation.org/show_bug.cgi?id=156606 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156606] Fileopen DOTX: poorly converted in writer
https://bugs.documentfoundation.org/show_bug.cgi?id=156606 --- Comment #9 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152925] LibreOffice: no visibility of menu when I open "Formatvorlagen verwalten"
https://bugs.documentfoundation.org/show_bug.cgi?id=152925 --- Comment #3 from QA Administrators --- Dear steam2, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 156455] Allow toggling repeating-header property of a row in row context menu
https://bugs.documentfoundation.org/show_bug.cgi?id=156455 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-ux-advise] [Bug 156455] Allow toggling repeating-header property of a row in row context menu
https://bugs.documentfoundation.org/show_bug.cgi?id=156455 --- Comment #7 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 156455] Allow toggling repeating-header property of a row in row context menu
https://bugs.documentfoundation.org/show_bug.cgi?id=156455 --- Comment #7 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152925] LibreOffice: no visibility of menu when I open "Formatvorlagen verwalten"
https://bugs.documentfoundation.org/show_bug.cgi?id=152925 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156455] Allow toggling repeating-header property of a row in row context menu
https://bugs.documentfoundation.org/show_bug.cgi?id=156455 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151838] EDITING: Find hard carriage return does not work.
https://bugs.documentfoundation.org/show_bug.cgi?id=151838 --- Comment #4 from QA Administrators --- Dear f.pignal, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151838] EDITING: Find hard carriage return does not work.
https://bugs.documentfoundation.org/show_bug.cgi?id=151838 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142347] add ability to change the background and font colours of the new tabbed/ribbon view (LibreOffice writer)
https://bugs.documentfoundation.org/show_bug.cgi?id=142347 --- Comment #7 from QA Administrators --- Dear joe-pringle, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142347] add ability to change the background and font colours of the new tabbed/ribbon view (LibreOffice writer)
https://bugs.documentfoundation.org/show_bug.cgi?id=142347 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151644] Full system stop for a minute and then libre office exel crash with the need to recover files as they become corrupt
https://bugs.documentfoundation.org/show_bug.cgi?id=151644 --- Comment #8 from QA Administrators --- Dear igor2001wilczynski, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151399] LibreOffice 7.3.6.2 Impress freezes when saving on Ubuntu 22.04
https://bugs.documentfoundation.org/show_bug.cgi?id=151399 --- Comment #3 from QA Administrators --- Dear Henry, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143899] FILEOPEN DOCX Shapes overlap margin in CompatibilityMode15
https://bugs.documentfoundation.org/show_bug.cgi?id=143899 --- Comment #5 from QA Administrators --- Dear NISZ LibreOffice Team, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 83762] FORMATTING: Cursor can be Positioned beyond Paper Margins by Using Negative Indentation Values
https://bugs.documentfoundation.org/show_bug.cgi?id=83762 --- Comment #12 from QA Administrators --- Dear Harald Koester, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 115292] FILEOPEN open PDF - picture shifted
https://bugs.documentfoundation.org/show_bug.cgi?id=115292 --- Comment #8 from QA Administrators --- Dear solar020, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140450] PDF export 1.6: The document does not conform to the requested standard.
https://bugs.documentfoundation.org/show_bug.cgi?id=140450 --- Comment #2 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 104185] Better Autoinput for functions (or different default than ENTER)
https://bugs.documentfoundation.org/show_bug.cgi?id=104185 --- Comment #10 from QA Administrators --- Dear Mieszko, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156787] docx format not entirely correct
https://bugs.documentfoundation.org/show_bug.cgi?id=156787 --- Comment #4 from hoang.hano...@gmail.com --- Hi Vladimir, I have tested both Microsoft Office docx file and Libre Office docx file uploaded to the website with your provided account. I have not seen any issue with uploading the Libre Office version as I expected. Your issue could probably comes from the inner content of the file. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156791] LibreOffice 7.5.5 has memory leak
https://bugs.documentfoundation.org/show_bug.cgi?id=156791 --- Comment #7 from vxs2...@yahoo.com --- I do have the latest drivers. After disabling Vulkan the memory leak appears to be fixed. So I guess that means either your use of the Vulkan API is bugged or AMD's drivers are buggy which wouldn't be surprising considering I recently filed a different bug report (https://bugs.chromium.org/p/chromium/issues/detail?id=1463267) caused by AMD's drivers -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156869] New: Document isn't saved when opening a .docx file by dragging it from an encrypted .zip file to LibreOffice main screen
https://bugs.documentfoundation.org/show_bug.cgi?id=156869 Bug ID: 156869 Summary: Document isn't saved when opening a .docx file by dragging it from an encrypted .zip file to LibreOffice main screen Product: LibreOffice Version: 7.5.4.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: lotanb...@gmail.com Description: After consulting with the AskLibre forum, I reached this site. I've tried numerous archiving software, I'm usually using the portable version, but tried it both on the installed one and the portable (7.5.4 and 7.4.7). When saving it shows the saving dialogue (2007 docx or odt format), I click one of them (doesn't matter, same result), and exit the file. Usually, when I use word office to edit the document, I get a pop up from the archiving software saying "update modified files?". but when opening it with LibreOffice - nothing. Perhaps it would be of any help if I tell you the zip is encrypted AND the file is encrypted, but I'll be honest I haven't tried to examine this particular point properly, and do not know if it's linked Steps to Reproduce: 1.open an archived file in archiving software 2.open LibreOffice main screen 3.drag the file from the archiving software to the main screen 4.make some changes and save 5. open it again and check if the file is saved Actual Results: the file isn't saved Expected Results: the file should be saved Reproducible: Always User Profile Reset: Yes Additional Info: Well, I like your software very much, it seems like you did a great job and created a great alternative for the pricey ms office. I'm using your software' portable version daily now, the only downside, is that I can't edit documents from my encrypted zip... Please help! -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156776] Base Save As New Table Name not refreshed if schema could be chosen
https://bugs.documentfoundation.org/show_bug.cgi?id=156776 --- Comment #30 from prrv...@gmail.com --- The integration in Base is finished. There remains, despite everything, the management of the combobox. I'm stuck for adding XConnection2 interface in the file: connectivity/source/drivers/jdbc/JConnection.cxx -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156868] Find function should highligh all instances of found keyword
https://bugs.documentfoundation.org/show_bug.cgi?id=156868 --- Comment #1 from Juergen --- Created attachment 189103 --> https://bugs.documentfoundation.org/attachment.cgi?id=189103=edit Multiple instance search display in Firefox -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156868] New: Find function should highligh all instances of found keyword
https://bugs.documentfoundation.org/show_bug.cgi?id=156868 Bug ID: 156868 Summary: Find function should highligh all instances of found keyword Product: LibreOffice Version: 7.3.7.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: all.onl...@posteo.eu Description: When using the Find function the searched phrase is only highlighted one by one. In other softwares all instances are highlighted at once. This is very helpful to detect repetitions when writing a book for example. Steps to Reproduce: 1. load any text 2. enter search word in Find function 3. Actual Results: Only one instance at a time is shown Expected Results: All instances should be shown. Example Firefox search function, see screen shot Reproducible: Always User Profile Reset: No Additional Info: All instances should be shown. Example Firefox search function, see screen shot -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156858] LibreCalc wrong subtraction of numbers 0, 0000000000001
https://bugs.documentfoundation.org/show_bug.cgi?id=156858 --- Comment #3 from ady --- (In reply to m.a.riosv from comment #2) > It works fine with > Version: 7.5.7.0.0+ (X86_64) / LibreOffice Community Are you sure? Have you tried expanding the width of the column? My guess is that this behavior is related to floating-point math capabilities, but I'll leave it to others with relevant knowledge of the matter to answer (with a proper reply, rather than a guess). Whether this particular subtraction is supposed to be exact, or with some inaccuracy because of floating-point math, IDK. https://wiki.documentfoundation.org/Faq/Calc/Accuracy -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156842] Export to PDF that includes PDF images are incorrect in size (macOS)
https://bugs.documentfoundation.org/show_bug.cgi?id=156842 Telesto changed: What|Removed |Added Summary|Export to PDF that includes |Export to PDF that includes |PDF images are incorrect in |PDF images are incorrect in |size|size (macOS) --- Comment #6 from Telesto --- Confirm with macOS Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: e60ef8651cfb30335471d1622e58c13eebc7d58b CPU threads: 8; OS: Mac OS X 13.4.1; UI render: Skia/Metal; VCL: osx Locale: nl-NL (nl_NL.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156854] Menu icons are broken on macOS with Skia
https://bugs.documentfoundation.org/show_bug.cgi?id=156854 --- Comment #4 from Patrick Luby --- (In reply to خالد حسني from comment #0) > When Skia is enable, menu icons on macOS are rendered as hallowed > rectangles. This might be related to bug 156853, but it happens only when > Skia is used (while bug 156853 happens all the time). I think you are right: it sure looks like it is another case of an alpha mask that needs to be inverted. This bug does not occur in LibreOffice 7.6.0.3 so it is likely due to the recent transparency->alpha patch. I can take a look at it tomorrow. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156854] Menu icons are broken on macOS with Skia
https://bugs.documentfoundation.org/show_bug.cgi?id=156854 Telesto changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #3 from Telesto --- Confirm Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: e60ef8651cfb30335471d1622e58c13eebc7d58b CPU threads: 8; OS: Mac OS X 13.4.1; UI render: Skia/Metal; VCL: osx Locale: nl-NL (nl_NL.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156867] LibreOffice logo in start center not properly rendered (macOS)
https://bugs.documentfoundation.org/show_bug.cgi?id=156867 --- Comment #1 from Telesto --- Created attachment 189102 --> https://bugs.documentfoundation.org/attachment.cgi?id=189102=edit Screenshot -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156867] New: LibreOffice logo in start center not properly rendered (macOS)
https://bugs.documentfoundation.org/show_bug.cgi?id=156867 Bug ID: 156867 Summary: LibreOffice logo in start center not properly rendered (macOS) Product: LibreOffice Version: 24.2.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: LibreOffice logo in start center not properly rendered (macOS) Steps to Reproduce: 1. Launch LibreOffice.app 2. Look at the logo in the left bottom corner 3. Launch Writer from Start Center 4. Close Writer -> OK Note I have LibreOffice light mode activated in LibreOffice -> preferences -> view . macOS system setting is set to dark-mode Actual Results: See screenshot Expected Results: readable logo Reproducible: Always User Profile Reset: No Additional Info: Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: e60ef8651cfb30335471d1622e58c13eebc7d58b CPU threads: 8; OS: Mac OS X 13.4.1; UI render: Skia/Metal; VCL: osx Locale: nl-NL (nl_NL.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156701] JRE errors messages still appearing for Macros
https://bugs.documentfoundation.org/show_bug.cgi?id=156701 --- Comment #3 from LucasLibre --- > So you should give that feedback as comment in bug 156161, if the problem > isn't fixed. I wasn't sure about any of this, so checked with Mike, who seemed to be the only one working on these issues; he suggested starting a new bug (i.e. this one) and copying him in, which I've done. Will revive the old bug request now. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156866] Logo in help about not properly rendered with Skia Raster/Metal (macOS)
https://bugs.documentfoundation.org/show_bug.cgi?id=156866 --- Comment #1 from Telesto --- Created attachment 189101 --> https://bugs.documentfoundation.org/attachment.cgi?id=189101=edit Screenshot -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156866] New: Logo in help about not properly rendered with Skia Raster/Metal (macOS)
https://bugs.documentfoundation.org/show_bug.cgi?id=156866 Bug ID: 156866 Summary: Logo in help about not properly rendered with Skia Raster/Metal (macOS) Product: LibreOffice Version: 24.2.0.0 alpha0+ Master Hardware: All OS: macOS (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: Logo in help about not properly rendered with Skia Raster/Metal Steps to Reproduce: 1. LibreOffice -> about in menubar Actual Results: See screenshot Expected Results: Logo Reproducible: Always User Profile Reset: No Additional Info: Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: e60ef8651cfb30335471d1622e58c13eebc7d58b CPU threads: 8; OS: Mac OS X 13.4.1; UI render: Skia/Metal; VCL: osx Locale: nl-NL (nl_NL.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156714] .uno:IndexMarktoIndex does not work (and is functionally unclear)
https://bugs.documentfoundation.org/show_bug.cgi?id=156714 sdc.bla...@youmail.dk changed: What|Removed |Added Summary|.uno:IndexMarktoIndex |.uno:IndexMarktoIndex does |crashes the application |not work (and is |(and is functionally|functionally unclear) |unclear)| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit c9916d9be9c060d43fc063b76d70629162650fea Author: Seth Chaiklin AuthorDate: Wed Aug 23 00:41:43 2023 +0200 Commit: Gerrit Code Review CommitDate: Wed Aug 23 00:41:43 2023 +0200 Update git submodules * Update helpcontent2 from branch 'master' to 2aa198ab57081bed9c012ea49c25fcd9d05dbfcb - (related) #tdf144512 change in AutoRecovery behavior * unify diverse references to "AutoRecovery" * update xml to current practice Change-Id: I2b4192582be9b813b683b379a9e2fda5bf6dfdfd Reviewed-on: https://gerrit.libreoffice.org/c/help/+/155595 Tested-by: Jenkins Reviewed-by: Seth Chaiklin diff --git a/helpcontent2 b/helpcontent2 index ba66530a081c..2aa198ab5708 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit ba66530a081cf3aadd706939fc7c580934af09dd +Subproject commit 2aa198ab57081bed9c012ea49c25fcd9d05dbfcb
[Libreoffice-commits] help.git: source/text
source/text/shared/optionen/01010200.xhp |9 + 1 file changed, 5 insertions(+), 4 deletions(-) New commits: commit 2aa198ab57081bed9c012ea49c25fcd9d05dbfcb Author: Seth Chaiklin AuthorDate: Sun Aug 13 01:44:05 2023 +0200 Commit: Seth Chaiklin CommitDate: Wed Aug 23 00:41:42 2023 +0200 (related) #tdf144512 change in AutoRecovery behavior * unify diverse references to "AutoRecovery" * update xml to current practice Change-Id: I2b4192582be9b813b683b379a9e2fda5bf6dfdfd Reviewed-on: https://gerrit.libreoffice.org/c/help/+/155595 Tested-by: Jenkins Reviewed-by: Seth Chaiklin diff --git a/source/text/shared/optionen/01010200.xhp b/source/text/shared/optionen/01010200.xhp index c157812ef6..2365f66577 100644 --- a/source/text/shared/optionen/01010200.xhp +++ b/source/text/shared/optionen/01010200.xhp @@ -83,13 +83,14 @@ Save AutoRecovery information every - Specifies that %PRODUCTNAME saves the information needed to restore all open documents in case of a crash. You can specify the saving time interval. - + Specifies that %PRODUCTNAME saves the information needed to restore all modified documents in case of a crash. + Minutes - Specifies the time interval in minutes for the automatic recovery option. + Specifies the time interval in minutes before AutoRecovery information is saved for a document. +A timer starts for a document when it is first modified. AutoRecovery information is saved after the specified time (while %PRODUCTNAME is idle). The timer then restarts with the next modification in the document. Automatically save the document too - Specifies that %PRODUCTNAME saves all open documents when saving auto recovery information. Uses the same time interval as AutoRecovery does. + Specifies that %PRODUCTNAME saves all modified documents when saving AutoRecovery information. Uses the time interval specified in Minutes. Edit document properties before saving Specifies that the Properties dialog will appear every time you select the Save As command.
[Libreoffice-bugs] [Bug 77963] FILEOPEN: WPS DOC - Text has wrong font and image not aligned correctly (fixed by round-tripping with Word)
https://bugs.documentfoundation.org/show_bug.cgi?id=77963 Justin L changed: What|Removed |Added Status|NEW |NEEDINFO -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156865] New: copying multiple HTML files with tables to Writer causes Writer to go berserk
https://bugs.documentfoundation.org/show_bug.cgi?id=156865 Bug ID: 156865 Summary: copying multiple HTML files with tables to Writer causes Writer to go berserk Product: LibreOffice Version: 7.5.5.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: r...@unidot.com Description: Several times I have copied a number of HTML files to Writer and had it go into an unrecoverable state but not a crash. When this occurs the last item inserted seems to be repeated numerous times and Writer does not seem to be able to recover. The last page has in the lower right corner a red triangle and appears to have a hairline beneath the triangle. This only seems to occur when multiple tables are copied, and has never occurred when simple text is copied. Steps to Reproduce: 1. open a new Writer document 2. Open an HTML document with several tables 3. Copy (ctl-C) the HTML document 4. Paste (ctl-V) the HTML document into the Writer document 5. Repeat step 5 a number of times until the page count is around 25 6. Suddenly the document gets pasted a number of times and stops when the red triangle is at the bottom of the page. Nothing appears to work after that. Actual Results: Suddenly the document gets pasted a number of times and stops when the red triangle is at the bottom of the page. Nothing appears to work after that. Expected Results: Only one copy of the HTML document should be pasted with each ctl-V Reproducible: Always User Profile Reset: No Additional Info: VersionL 7.6.0.3 (X86-64) / LibreOffice Community Build: 69edd8b8ebc41d00b4de3915d Environment: CPU threads: 16: OS: Windows 10.0 Build 19045 User Interfact: UL render: default; VCL: win Locale: en-US(en-US): UL en-US Misc: Calc: CL threaded the same problem occurs on my previous version of LibreOffice; 7.5 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156864] New: Active tab/button is unreadable on Mac with Increase Contrast enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=156864 Bug ID: 156864 Summary: Active tab/button is unreadable on Mac with Increase Contrast enabled Product: LibreOffice Version: 7.6.0.3 release Hardware: All OS: macOS (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: pfat...@uchicago.edu Description: MacOS Monterey 12.6.7 [M1], MacOS Ventura 13.3.1 [Intel]. LibreOffice 7.6. In System Preferences, Accessibility, Display, Increase Contrast is turned on (checked). With this system setting, the active tab in LibreOffice setting windows is unreadable. Similarly, buttons in some windows are also unreadable. Steps to Reproduce: 1. Enable Increase Contrast in System Preferences/Settings. 2. Open a dialog window in LibreOffice which has tabs, such as File-->Export As-->Export as PDF or Format-->Paragraph [Writer] or Data-->Sort [Calc]. The text label of the selected tab is unreadable. 3. Go to Help-->Restart in Safe Mode. The leftmost button in that dialog is unreadable, the rightmost button "Restart" is readable as expected. 4. When you have restarted in safe mode, the Safe Mode dialog button second from the left also exhibits the same problem. Actual Results: The text label of the active tab or a button is unreadable. Expected Results: It should be possible to read the text label of the active tab and all buttons. Likely the text color and/or the background color needs to be changed. Reproducible: Always User Profile Reset: Yes Additional Info: [Information automatically included from LibreOffice] Locale: en-US Module: TextDocument [Information guessed from browser] OS: Mac OS X (All) [Tested on Monterey and Ventura, Intel and M1 architectures] OS is 64bit: no -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156853] Exporting bitmap color fonts to PDF is broken
https://bugs.documentfoundation.org/show_bug.cgi?id=156853 Patrick Luby changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |plub...@neooffice.org |desktop.org | Status|NEW |ASSIGNED --- Comment #6 from Patrick Luby --- I can reproduce this as well. Unfortunately, the initial fix caused the same bug to now occur with all transparent images and shapes. So I will see if I can find what is unique about emoji bitmaps. -- You are receiving this mail because: You are the assignee for the bug.
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
2 new defect(s) introduced to LibreOffice found with Coverity Scan.
4 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)
** CID 1541186: Integer handling issues (CONSTANT_EXPRESSION_RESULT)
/writerperfect/source/common/WPXSvInputStream.cxx: 456 in
writerperfect::WPXSvInputStream::seek(long)()
*** CID 1541186: Integer handling issues (CONSTANT_EXPRESSION_RESULT)
/writerperfect/source/common/WPXSvInputStream.cxx: 456 in
writerperfect::WPXSvInputStream::seek(long)()
450 int WPXSvInputStream::seek(tools::Long offset)
451 {
452 if ((mnLength == 0) || !mxStream.is() || !mxSeekable.is())
453 return -1;
454
455 const sal_Int64 tmpPosition = mxSeekable->getPosition();
>>> CID 1541186: Integer handling issues (CONSTANT_EXPRESSION_RESULT)
>>> "tmpPosition > 9223372036854775807L" is always false regardless of the
>>> values of its operands. This occurs as the logical second operand of "||".
456 if ((tmpPosition < 0) || (tmpPosition > LONG_MAX))
457 return -1;
458
459 try
460 {
461 mxSeekable->seek(offset);
** CID 1541185: Integer handling issues (CONSTANT_EXPRESSION_RESULT)
/writerperfect/source/common/WPXSvInputStream.cxx: 444 in
writerperfect::WPXSvInputStream::tellImpl()()
*** CID 1541185: Integer handling issues (CONSTANT_EXPRESSION_RESULT)
/writerperfect/source/common/WPXSvInputStream.cxx: 444 in
writerperfect::WPXSvInputStream::tellImpl()()
438 {
439 if ((mnLength == 0) || !mxStream.is() || !mxSeekable.is())
440 return -1;
441 else
442 {
443 const sal_Int64 tmpPosition = mxSeekable->getPosition();
>>> CID 1541185: Integer handling issues (CONSTANT_EXPRESSION_RESULT)
>>> "tmpPosition > 9223372036854775807L" is always false regardless of the
>>> values of its operands. This occurs as the logical second operand of "||".
444 if ((tmpPosition < 0) || (tmpPosition > LONG_MAX))
445 return -1;
446 return static_cast(tmpPosition);
447 }
448 }
449
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3D1gxC_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiXV5MJlq0SQHeh3zIHStjN-2BM9Vbq8-2BCQyJ5qJeZmkQEdJ-2Fd2zGqzmFnHDxcKeLI7gZzhLCheJe6UfAzovCx-2BlO7zf4lGZmZ49MIjLZXoEbg3PoDbLKORPqe3kDofnlraSqqd3IKby1EbJzpwAr3qX0RcBSW20CtadQzHn0Oiv6EY-3D
[Libreoffice-bugs] [Bug 156861] FILEOPEN XLS, Function with logic answer gives back 1 or 0 in LO
https://bugs.documentfoundation.org/show_bug.cgi?id=156861 --- Comment #3 from ady --- (In reply to ady from comment #2) > might be needed to force the convertion. s/convertion/conversion -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156861] FILEOPEN XLS, Function with logic answer gives back 1 or 0 in LO
https://bugs.documentfoundation.org/show_bug.cgi?id=156861 --- Comment #2 from ady --- FWIW... LO does not really have a boolean or logical category of values; they are numbers really. * Zero = FALSE; all other numbers equal TRUE. * TRUE = 1 and FALSE = 0. https://help.libreoffice.org/latest/en-US/text/scalc/01/04060105.html MS Excel uses the TRUE() and FALSE() functions for compatibility with other tools. Excel does indeed have a boolean or logical category of values; they are not really numbers. Numbers are _usually_ "automatically" interpreted as needed, and logical/boolean values are _usually_ "automatically" interpreted as numbers when needed. Multiplying by 1 usually forces the logical value into a number (0 or 1, respectively). In some rare cases, the N() function might be needed to force the convertion. https://support.microsoft.com/en-gb/office/true-function-7652c6e3-8987-48d0-97cd-ef223246b3fb -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: 2 commits - toolkit/source winaccessibility/source
toolkit/source/controls/table/tablecontrol_impl.cxx |9 ++---
toolkit/source/controls/table/tablecontrol_impl.hxx |3 +++
winaccessibility/source/UAccCOM/AccActionBase.cxx |8
winaccessibility/source/UAccCOM/AccActionBase.h |3 ---
4 files changed, 13 insertions(+), 10 deletions(-)
New commits:
commit 18d45783a6c9f0d13fa0fae7b623be0805d8d825
Author: Michael Weghorn
AuthorDate: Tue Aug 22 16:01:49 2023 +0100
Commit: Michael Weghorn
CommitDate: Tue Aug 22 22:27:22 2023 +0200
wina11y: Drop CAccActionBase::GetXInterface
Just use the `pRXAct` member directly.
In particular the fact that all of the `CAccActionBase`
methods mixed both ways of accessing the member (first checking
`pRXAct` directly, but then retrieving it via
`CAccActionBase::GetXInterface` to call a method
on it) didn't really increase readability of the code.
Change-Id: Ic6f5ce9a9b229b949ac656668e3bbf01cb65af2e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155956
Tested-by: Jenkins
Reviewed-by: Michael Weghorn
diff --git a/winaccessibility/source/UAccCOM/AccActionBase.cxx
b/winaccessibility/source/UAccCOM/AccActionBase.cxx
index 70940aa31b1e..0fb2d7bbcee6 100644
--- a/winaccessibility/source/UAccCOM/AccActionBase.cxx
+++ b/winaccessibility/source/UAccCOM/AccActionBase.cxx
@@ -62,7 +62,7 @@ COM_DECLSPEC_NOTHROW STDMETHODIMP
CAccActionBase::nActions(/*[out,retval]*/long*
if( pRXAct.is() && nActions != nullptr )
{
-*nActions = GetXInterface()->getAccessibleActionCount();
+*nActions = pRXAct->getAccessibleActionCount();
return S_OK;
}
*nActions = 0;
@@ -85,7 +85,7 @@ COM_DECLSPEC_NOTHROW STDMETHODIMP CAccActionBase::doAction(/*
[in] */ long actio
if( pRXAct.is() )
{
-return GetXInterface()->doAccessibleAction( actionIndex )?S_OK:E_FAIL;
+return pRXAct->doAccessibleAction(actionIndex) ? S_OK : E_FAIL;
}
return E_FAIL;
@@ -110,7 +110,7 @@ COM_DECLSPEC_NOTHROW STDMETHODIMP
CAccActionBase::get_description(long actionInd
if(!pRXAct.is())
return E_FAIL;
-OUString ouStr =
GetXInterface()->getAccessibleActionDescription(actionIndex);
+OUString ouStr = pRXAct->getAccessibleActionDescription(actionIndex);
SysFreeString(*description);
*description = SysAllocString(o3tl::toW(ouStr.getStr()));
@@ -156,7 +156,7 @@ COM_DECLSPEC_NOTHROW STDMETHODIMP
CAccActionBase::get_keyBinding(
if( !pRXAct.is() )
return E_FAIL;
-Reference< XAccessibleKeyBinding > binding =
GetXInterface()->getAccessibleActionKeyBinding(actionIndex);
+Reference< XAccessibleKeyBinding > binding =
pRXAct->getAccessibleActionKeyBinding(actionIndex);
if( !binding.is() )
return E_FAIL;
diff --git a/winaccessibility/source/UAccCOM/AccActionBase.h
b/winaccessibility/source/UAccCOM/AccActionBase.h
index 26d3e7d054aa..9bf2c70b4bb2 100644
--- a/winaccessibility/source/UAccCOM/AccActionBase.h
+++ b/winaccessibility/source/UAccCOM/AccActionBase.h
@@ -66,9 +66,6 @@ public:
protected:
css::uno::Reference pRXAct;
-
-private:
-css::accessibility::XAccessibleAction* GetXInterface() { return
pRXAct.get(); }
};
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
commit cd00bc50a7425e2f58d54de80b714cb6b0362dce
Author: Michael Weghorn
AuthorDate: Tue Aug 22 14:57:04 2023 +0200
Commit: Michael Weghorn
CommitDate: Tue Aug 22 22:27:11 2023 +0200
tdf#156473 a11y: Keep a reference to table's a11y object
Keep a Reference to the a11y object in `TableControl_Impl`,
to prevent the object from getting deleted while it's still
needed.
Fixes a crash with this backtrace on Windows when closing
the macro dialog from tdf#156473 with the NVDA screen reader
active:
1 cppu::WeakComponentImplHelperBase::release implbase.cxx 70
0x7ff97c1f0f72
2
cppu::PartialWeakComponentImplHelper::release
compbase.hxx 86 0x7ff9200cc5a4
3 rtl::Reference::clear ref.hxx
198 0x7ff9200cc25b
4 accessibility::AccessibleGridControlAccess::DisposeAccessImpl
AccessibleGridControl.cxx 335 0x7ff9200cc17a
5 svt::table::TableControl_Impl::disposeAccessible
tablecontrol_impl.cxx 2397 0x7ff955829173
6 svt::table::TableControl::dispose tablecontrol.cxx 74 0x7ff9558190e4
7 VclReferenceBase::disposeOnce vclreferencebase.cxx 39 0x7ff9494f4fda
8 VclPtr::disposeAndClear vclptr.hxx 207 0x7ff9556b0fbe
9 VCLXWindow::dispose vclxwindow.cxx 927 0x7ff9556b0c9c
10 SVTXGridControl::dispose svtxgridcontrol.cxx 766 0x7ff9557e2577
11 UnoControl::dispose unocontrol.cxx 362 0x7ff95585bc3c
12 toolkit::UnoGridControl::dispose gridcontrol.cxx 292 0x7ff9557c9667
13 UnoControlContainer::dispose unocontrolcontainer.cxx 413
0x7ff955874606
14 ControlContainerBase::dispose controlmodelcontainerbase.cxx 1387
0x7ff95573f480
[Libreoffice-bugs] [Bug 154929] [META] Accessibility Check sidebar deck, Automatic Accessibility Checking
https://bugs.documentfoundation.org/show_bug.cgi?id=154929 Bug 154929 depends on bug 156654, which changed state. Bug 156654 Summary: A11Y sidebar: not fixable warning about "Document default language is not set." https://bugs.documentfoundation.org/show_bug.cgi?id=156654 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156835] FILEOPEN XLSX Password protected file with SHA-384 encryption does not open
https://bugs.documentfoundation.org/show_bug.cgi?id=156835 Balázs Varga (allotropia) changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |balazs.varga...@gmail.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142074] [META] Application Colours settings bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=142074 BogdanB changed: What|Removed |Added Depends on||156846 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=156846 [Bug 156846] Automatic Font color for DataTable is white instead black -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156846] Automatic Font color for DataTable is white instead black
https://bugs.documentfoundation.org/show_bug.cgi?id=156846 BogdanB changed: What|Removed |Added Blocks||142074 CC||buzea.bog...@libreoffice.or ||g Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=142074 [Bug 142074] [META] Application Colours settings bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 117082] Add the option to remove cropped areas to the "Compress Image" dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=117082 Justin L changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=83 ||734 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 83734] EDITING: Cropped image gets distorted when Compress Graphic is used
https://bugs.documentfoundation.org/show_bug.cgi?id=83734 Justin L changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||7082 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153425] Calc shows different representations (TRUE/FALSE/1/0) of boolean data types stored in .xlsx starting near row 50
https://bugs.documentfoundation.org/show_bug.cgi?id=153425 --- Comment #16 from ady --- (In reply to ady from comment #15) > 3. Save the file as ODS, close and reopen it. > > Result, as described in comment 13: > * shows all TRUE/FALSE values as TRUE and FALSE respectively, > * cell content is (values) TRUE and FALSE respectively, > * with cell format as Boolean. To be clear, since LO considers those strings as meaning the same as the respective functions (while working in English), this is probably OK for ODS. Importing/exporting from other tools in ODS might have different results, but I have not tested such scenario. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153425] Calc shows different representations (TRUE/FALSE/1/0) of boolean data types stored in .xlsx starting near row 50
https://bugs.documentfoundation.org/show_bug.cgi?id=153425 --- Comment #15 from ady --- (In reply to Justin L from comment #14) > > On the same LO Dev version, saving/exporting as ODS and reopening: > > * cell content is (values) TRUE and FALSE respectively, > That seems unlikely, and I can't reproduce. I still see formula =True(). I shall clarify my steps then: 1. New Calc worksheet (do not start from a previously-saved file). 2. Introduce the following string values, not as functions, not as numbers, and with the default standard cell format: A1: TRUE A2: FALSE 3. Save the file as ODS, close and reopen it. Result, as described in comment 13: * shows all TRUE/FALSE values as TRUE and FALSE respectively, * cell content is (values) TRUE and FALSE respectively, * with cell format as Boolean. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156847] Transparency in drop-down lists Line and Width on Sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=156847 Rafael Lima changed: What|Removed |Added Status|ASSIGNED|NEW Assignee|rafael.palma.l...@gmail.com |libreoffice-b...@lists.free ||desktop.org --- Comment #3 from Rafael Lima --- I had accidentally assigned it to myself. Changing it to NEW. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - sw/qa sw/source
sw/qa/extras/layout/data/tdf137523-1-min.fodt | 319 ++ sw/qa/extras/layout/layout3.cxx | 12 sw/source/core/layout/layact.cxx |6 3 files changed, 336 insertions(+), 1 deletion(-) New commits: commit b453cd8dad4580e0c2f7be358b3173ad7837fea3 Author: Michael Stahl AuthorDate: Mon Aug 21 19:21:34 2023 +0200 Commit: Xisco Fauli CommitDate: Tue Aug 22 21:00:28 2023 +0200 tdf#137523 sw: layout: fix text below tables in footer In the footer, the text frames below a table have a very small height and are effectively invisible. This is because the JoinLock in SwLayAction::FormatLayoutTab() causes SwTabFrame::MakeAll() to return early, which is called for every cell frame in the table, and which would move the table up the page in MakePos(), by calling SwHeadFootFrame::Format(). (regression from commit cc5916cd314a27b0cc99560ab887480026630a95) Change-Id: I4add9fdd73ad3756000969af20ebf758025a0ada Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155902 Tested-by: Jenkins Reviewed-by: Michael Stahl (cherry picked from commit 027f8328eef1e149b6c99b478ed5df870291dc2d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155915 Reviewed-by: Xisco Fauli diff --git a/sw/qa/extras/layout/data/tdf137523-1-min.fodt b/sw/qa/extras/layout/data/tdf137523-1-min.fodt new file mode 100644 index ..cbe85c9fbb82 --- /dev/null +++ b/sw/qa/extras/layout/data/tdf137523-1-min.fodt @@ -0,0 +1,319 @@ + +http://www.w3.org/TR/css3-text/; xmlns:grddl="http://www.w3.org/2003/g/data-view#; xmlns:xhtml="http://www.w3.org/1999/xhtml; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xmlns:xsd="http://www.w3.org/2001/XMLSchema; xmlns:xforms="http://www.w3.org/2002/xforms; xmlns:dom="http://www.w3.org/2001/xml-events; xmlns:script="urn:oasis:names:tc:opendocument:xmlns:script:1.0" xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0" xmlns:math="http://www.w3.org/1998/Math/MathML; xmlns:office="urn:oasis:names:tc:opendocument:xmlns:office:1.0" xmlns:ooo="http://openoffice.org/2004/office; xmlns:fo="urn:oasis:names:tc:opendocument:xmlns:xsl-fo-compatible:1.0" xmlns:config="urn:oasis:names:tc:opendocument:xmlns:config:1.0" xmlns:ooow="http://openoffice.org/2004/writer; xmlns:xlink="http://www.w3.org/1999/xlink; xmlns:drawooo="http://openoffice.org/2010/draw; xmlns:oooc="http://openoffice.org/2004/calc; xmlns:dc="http://purl.org/dc/elements/1.1/; xmlns:c alcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0" xmlns:style="urn:oasis:names:tc:opendocument:xmlns:style:1.0" xmlns:text="urn:oasis:names:tc:opendocument:xmlns:text:1.0" xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2" xmlns:tableooo="http://openoffice.org/2009/table; xmlns:draw="urn:oasis:names:tc:opendocument:xmlns:drawing:1.0" xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0" xmlns:rpt="http://openoffice.org/2005/report; xmlns:formx="urn:openoffice:names:experimental:ooxml-odf-interop:xmlns:form:1.0" xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0" xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0" xmlns:officeooo="http://openoffice.org/2009/office; xmlns:table="urn:oasis:names:tc:opendocument:xmlns:table:1.0" xmlns:field="urn:openoffice:names:experimental:ooo-ms-interop:xmlns:field:1.0" xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0" xmlns:meta="urn:oasis:names:tc:opendocument:xmlns: meta:1.0" xmlns:loext="urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.0" office:version="1.3" office:mimetype="application/vnd.oasis.opendocument.text"> + 2020-10-16T11:14:14.930082474LibreOfficeDev/24.2.0.0.alpha0$Linux_X86_64 LibreOffice_project/53ef297ff9342db2a32da0dd0e8e2f858a3624eeuser_manualP0D1Release 3.0.32020-10-181Train Backbone NodeT est Report + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + / + + / + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - 3 commits - svgio/inc svgio/qa svgio/source sw/qa sw/source
svgio/inc/svgnode.hxx |2
svgio/inc/svgstyleattributes.hxx | 13
svgio/inc/svgtoken.hxx|3
svgio/qa/cppunit/SvgImportTest.cxx| 47 +++
svgio/qa/cppunit/data/tdf129356.svg | 34 +++
svgio/qa/cppunit/data/tdf156834.svg |7 ++
svgio/source/svgreader/svgcharacternode.cxx | 24 +++
svgio/source/svgreader/svgnode.cxx| 68 +++---
svgio/source/svgreader/svgstyleattributes.cxx | 43 +
svgio/source/svgreader/svgtoken.cxx |6 +
sw/qa/core/layout/paintfrm.cxx| 10 +--
sw/source/core/layout/paintfrm.cxx| 80 +-
12 files changed, 281 insertions(+), 56 deletions(-)
New commits:
commit e7c02ea29d92bed2d713b9a3180bfb1674add908
Author: Miklos Vajna
AuthorDate: Mon Aug 21 08:33:14 2023 +0200
Commit: Xisco Fauli
CommitDate: Tue Aug 22 21:00:20 2023 +0200
tdf#156351 sw floattable: fix missing bottom border in master table
The problem was that the bugdoc has a split floating table, and the
bottom of the table on the first page was missing its border. The
borders on the second page were correct.
This happens because the cell itself has no bottom border and the layout
did not extra effort to mirror the top table margin at the buttom, like
Word does.
Fix the problem similar to commit
53798fef2cc0b5b0b9706081a4af5ceca964a41b (Related: tdf#156351 sw
floattable: fix missing top border in follow table, 2023-08-18), so we
add a bottom border for master tables at a layout level, similar how a
top border was already added for follow tables.
Given that this kind of worked already in the past (just top borders,
just the 1 row case), do this unconditionally; but if needed this could
be limited to the "Word table cell" case.
Change-Id: Iafdcd90226fdc425be597d36ad97fb69dca5a89a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155884
Reviewed-by: Miklos Vajna
Tested-by: Jenkins
(cherry picked from commit 08aea5526c75ff4c5385e960bd940f10ffa19cd5)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155914
Reviewed-by: Xisco Fauli
diff --git a/sw/qa/core/layout/paintfrm.cxx b/sw/qa/core/layout/paintfrm.cxx
index 15b9df6a4fb4..2416c6b95f8c 100644
--- a/sw/qa/core/layout/paintfrm.cxx
+++ b/sw/qa/core/layout/paintfrm.cxx
@@ -36,7 +36,8 @@ CPPUNIT_TEST_FIXTURE(Test, testSplitTableBorder)
// When rendering that document:
std::shared_ptr xMetaFile = pShell->GetPreviewMetaFile();
-// Then make sure that the follow table has a top border:
+// Then make sure that the master table has a bottom border and the follow
table has a top
+// border:
MetafileXmlDump aDumper;
xmlDocUniquePtr pXmlDoc = dumpAndParse(aDumper, *xMetaFile);
xmlXPathObjectPtr pXmlObj = getXPathNode(pXmlDoc,
"//polyline[@style='solid']/point");
@@ -61,10 +62,11 @@ CPPUNIT_TEST_FIXTURE(Test, testSplitTableBorder)
}
xmlXPathFreeObject(pXmlObj);
// Without the accompanying fix in place, this test would have failed with:
-// - Expected: 3
+// - Expected: 4
// - Actual : 2
-// i.e. the top border in the follow table was missing.
-CPPUNIT_ASSERT_EQUAL(3, nHorizontalBorders);
+// i.e. the bottom border in the master table and the top border in the
follow table were
+// missing.
+CPPUNIT_ASSERT_EQUAL(4, nHorizontalBorders);
}
}
diff --git a/sw/source/core/layout/paintfrm.cxx
b/sw/source/core/layout/paintfrm.cxx
index fdc6c6140a57..361e750570e9 100644
--- a/sw/source/core/layout/paintfrm.cxx
+++ b/sw/source/core/layout/paintfrm.cxx
@@ -2399,6 +2399,9 @@ class SwTabFramePainter
void InsertFollowTopBorder(const SwFrame& rFrame, const SvxBoxItem&
rBoxItem,
bool bWordTableCell, SwTwips nTop, SwTwips
nLeft, SwTwips nRight,
bool bTopIsOuter);
+void InsertMasterBottomBorder(const SwFrame& rFrame, const SvxBoxItem&
rBoxItem,
+ bool bWordTableCell, SwTwips nBottom,
SwTwips nLeft, SwTwips nRight,
+ bool bBottomIsOuter);
void HandleFrame(const SwLayoutFrame& rFrame, const SwRect& rPaintArea);
void FindStylesForLine( Point&,
@@ -2893,7 +2896,7 @@ void SwTabFramePainter::InsertFollowTopBorder(const
SwFrame& rFrame, const SvxBo
// This is then a first row in a follow table, without repeated headlines.
auto pLastRow = dynamic_cast(mrTabFrame.GetLastLower());
-if (!pLastRow && pLastRow == pThisRow)
+if (!pLastRow || pLastRow == pThisRow)
{
return;
}
@@ -2929,6 +2932,79 @@ void SwTabFramePainter::InsertFollowTopBorder(const
SwFrame& rFrame, const SvxBo
Insert(aFollowTop, true);
}
+void
[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - sw/CppunitTest_sw_core_text.mk sw/qa sw/source
sw/CppunitTest_sw_core_text.mk |1
sw/qa/core/text/data/floattable-leftover-para-portion.docx |binary
sw/qa/core/text/porrst.cxx | 57 +
sw/source/core/text/porrst.cxx |2
4 files changed, 59 insertions(+), 1 deletion(-)
New commits:
commit 2dc53489d6c36a5a04c154d78a9e8ea928407328
Author: Miklos Vajna
AuthorDate: Wed Aug 16 09:34:49 2023 +0200
Commit: Xisco Fauli
CommitDate: Tue Aug 22 20:59:36 2023 +0200
tdf#156682 sw floattable: fix missing del of master anchor para por on split
Pressing "enter" at the end of B1 in the bugdoc resulted in a split
floating table, which had the anchor text duplicated (both on page 1 and
page2).
What happened is that the master anchor frame didn't have its paragraph
portion cleared, the follow anchor frame had a correct frame offset (of
0).
Fix the problem in SwTextFrame::FormatEmpty(), similar to what commit
00b9b4791079c2dc26b1ed4c123450cabf7d (sw: call FormatEmpty() in
SwTextFrame::Format() for split fly masters, 2023-02-09), did; here what
we want to avoid is setting some properties on the paragraph preventing
the deletion of non-last anchor paragraph portions.
As a side effect, this also fixes the hang from the bugreport, after
pressing "enter" 5 times at the end of B1.
Change-Id: I16e6d786f02ad503a0fdff465ecf7716c1c5f8b7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155732
Reviewed-by: Miklos Vajna
Tested-by: Jenkins
(cherry picked from commit 1cf29168840f84c2e946e2678b99988e83503c96)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155787
Reviewed-by: Xisco Fauli
diff --git a/sw/CppunitTest_sw_core_text.mk b/sw/CppunitTest_sw_core_text.mk
index 477e25b91612..37b2fa566094 100644
--- a/sw/CppunitTest_sw_core_text.mk
+++ b/sw/CppunitTest_sw_core_text.mk
@@ -17,6 +17,7 @@ $(eval $(call
gb_CppunitTest_add_exception_objects,sw_core_text, \
sw/qa/core/text/frmform \
sw/qa/core/text/itratr \
sw/qa/core/text/itrform2 \
+sw/qa/core/text/porrst \
sw/qa/core/text/text \
))
diff --git a/sw/qa/core/text/data/floattable-leftover-para-portion.docx
b/sw/qa/core/text/data/floattable-leftover-para-portion.docx
new file mode 100644
index ..51eee56cf003
Binary files /dev/null and
b/sw/qa/core/text/data/floattable-leftover-para-portion.docx differ
diff --git a/sw/qa/core/text/porrst.cxx b/sw/qa/core/text/porrst.cxx
new file mode 100644
index ..1c343dc0d9f2
--- /dev/null
+++ b/sw/qa/core/text/porrst.cxx
@@ -0,0 +1,57 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include
+
+#include
+
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+
+namespace
+{
+/// Covers sw/source/core/text/porrst.cxx fixes.
+class Test : public SwModelTestBase
+{
+public:
+Test()
+: SwModelTestBase("/sw/qa/core/text/data/")
+{
+}
+};
+
+CPPUNIT_TEST_FIXTURE(Test, testFloattableLeftoverParaPortion)
+{
+// Given a document with a multi-page floating table, the anchor of the
table has some text:
+createSwDoc("floattable-leftover-para-portion.docx");
+
+// When laying out that document:
+calcLayout();
+
+// Then make sure all anchor text goes to the second page:
+SwDoc* pDoc = getSwDoc();
+SwRootFrame* pLayout = pDoc->getIDocumentLayoutAccess().GetCurrentLayout();
+auto pPage = dynamic_cast(pLayout->Lower());
+CPPUNIT_ASSERT(pPage);
+SwFrame* pBody = pPage->FindBodyCont();
+SwFrame* pPara1 = pBody->GetLower();
+auto pPara2 = pPara1->GetNext()->DynCastTextFrame();
+CPPUNIT_ASSERT(pPara2);
+// Without the accompanying fix in place, this test would have failed, the
first page's anchor
+// also had some (duplicated) anchor text.
+CPPUNIT_ASSERT(!pPara2->GetPara());
+}
+}
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/core/text/porrst.cxx b/sw/source/core/text/porrst.cxx
index 255318119f87..5c6ea428c1db 100644
--- a/sw/source/core/text/porrst.cxx
+++ b/sw/source/core/text/porrst.cxx
@@ -413,7 +413,7 @@ bool SwTextFrame::FormatEmpty()
// Split fly frames: non-last parts of the anchor want this optimization
to clear the old
// content.
bool bHasNonLastSplitFlyDrawObj = HasNonLastSplitFlyDrawObj();
-if ((HasFollow() && !bHasNonLastSplitFlyDrawObj) || GetMergedPara() ||
GetTextNodeFirst()->GetpSwpHints() ||
+if ((HasFollow() && !bHasNonLastSplitFlyDrawObj) || GetMergedPara() ||
(GetTextNodeFirst()->GetpSwpHints() && !bHasNonLastSplitFlyDrawObj) ||
[Libreoffice-bugs] [Bug 113545] [META] Paragraph spacing above and below and related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=113545 Bug 113545 depends on bug 101895, which changed state. Bug 101895 Summary: Paragraph dialog units shown as "ch" and "lines" when "Enable char unit" is enabled by default https://bugs.documentfoundation.org/show_bug.cgi?id=101895 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 113546] [META] Paragraph indent bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=113546 Bug 113546 depends on bug 101895, which changed state. Bug 101895 Summary: Paragraph dialog units shown as "ch" and "lines" when "Enable char unit" is enabled by default https://bugs.documentfoundation.org/show_bug.cgi?id=101895 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 83066] [META] CJK (Chinese, Japanese, Korean, and Vietnamese) language issues
https://bugs.documentfoundation.org/show_bug.cgi?id=83066 Bug 83066 depends on bug 101895, which changed state. Bug 101895 Summary: Paragraph dialog units shown as "ch" and "lines" when "Enable char unit" is enabled by default https://bugs.documentfoundation.org/show_bug.cgi?id=101895 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - 2 commits - sw/source
sw/source/core/layout/calcmove.cxx |9 -
sw/source/core/layout/fly.cxx | 13 +
2 files changed, 21 insertions(+), 1 deletion(-)
New commits:
commit 4a8041bc4ddadd91aec6038a380ab4ce2279d27a
Author: Michael Stahl
AuthorDate: Thu Aug 17 13:30:38 2023 +0200
Commit: Xisco Fauli
CommitDate: Tue Aug 22 20:59:24 2023 +0200
tdf#156728 sw: layout: invalidate fly on header/footer size
On page 30 there are at-page anchored shapes Shape22, Shape23 and
Shape25.
Shape22 and Shape23 are positioned relative to the bottom of the page
text area, and that is working; Shape25 is positioned with an offset to
the top of the page text area, and that doesn't work.
The problem is that the shapes are positioned when the header on the
page hasn't been formatted yet, and once the header is formatted, the
position of the Shape25 is not invalidated, so it's a header-height too
far up.
(regression from commit 425a252c3cc5e5a79a533965026dd4af6b8df739)
Change-Id: Ic907d98b1bcd4bb544fd1af9bf93ebc7b75bf362
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155762
Tested-by: Jenkins
Reviewed-by: Michael Stahl
(cherry picked from commit ee82accbd0d67eaf0f5a164a82b86abd00c3b0c9)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155774
Reviewed-by: Xisco Fauli
diff --git a/sw/source/core/layout/fly.cxx b/sw/source/core/layout/fly.cxx
index c2d27eaf2f0e..a06c2a9e7f70 100644
--- a/sw/source/core/layout/fly.cxx
+++ b/sw/source/core/layout/fly.cxx
@@ -2718,10 +2718,23 @@ void SwLayoutFrame::NotifyLowerObjs( const bool
_bUnlockPosOfObjs )
{
assert( dynamic_cast( pObj) &&
"GetFrameFormat().GetVertOrient().GetRelationOrient());
+if (nO == text::RelOrientation::PAGE_PRINT_AREA
+|| nO == text::RelOrientation::PAGE_PRINT_AREA_BOTTOM
+|| nO == text::RelOrientation::PAGE_PRINT_AREA_TOP)
+{
+isPositionedByHF = true;
+}
+}
// #i26945# - use to check, if
// fly frame is lower of layout frame resp. if fly frame is
// at a different page registered as its anchor frame is on.
if ( IsAnLower( pAnchorFrame ) ||
+ isPositionedByHF ||
pAnchorFrame->FindPageFrame() != pPageFrame )
{
// #i44016#
commit 9b6a4fcc010bdb740a5b3581a47327f45ee05718
Author: Michael Stahl
AuthorDate: Wed Aug 16 16:09:12 2023 +0200
Commit: Xisco Fauli
CommitDate: Tue Aug 22 20:59:13 2023 +0200
tdf#156727 sw: layout: allow MoveBwd if previous has keep-with-next
In the pathological fdo56431-6.odt there are 16 pages of 1-line
paragraphs that all have keep-with-next set, and only the first of them
has a page break before.
The layout temporarily uses 5 pages for the table of content at the
start but then everything fits on 4 pages, so page 5 is empty.
Now the first text frame on page 6 moves backward despite its
keep-with-next, because it hits SwFlowFrame::SetMoveBwdJump(true) in
SwFrame::GetPrevLeaf().
The next one however nopes out in SwContentFrame::WouldFit_().
This is because it continues along the sequence of keep-with-next frames
until it runs out of space in the new upper; this happens with a frame
that's actually on page 7.
Ignore keep-with-next in case the previous frame in the new upper also
has it set, because it really doesn't mean anything then.
(somehow regression from commit 25a252c3cc5e5a79a533965026dd4af6b8df739)
Change-Id: I0cfbc8b67bd0b95dfe08054660a2935de923a661
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155741
Tested-by: Jenkins
Reviewed-by: Michael Stahl
(cherry picked from commit 169b4d72b28b05e1a14d9b00571f7488200e39c2)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155709
Reviewed-by: Xisco Fauli
diff --git a/sw/source/core/layout/calcmove.cxx
b/sw/source/core/layout/calcmove.cxx
index 820d7834027b..5fb30d5c7afa 100644
--- a/sw/source/core/layout/calcmove.cxx
+++ b/sw/source/core/layout/calcmove.cxx
@@ -2004,6 +2004,12 @@ bool SwContentFrame::WouldFit_( SwTwips nSpace,
pTmpPrev = static_cast(pTmpPrev)->Lower();
while ( pTmpPrev && pTmpPrev->GetNext() )
pTmpPrev = pTmpPrev->GetNext();
+
+// tdf#156727 if the previous one has keep-with-next, ignore it on this
one!
+bool const isIgnoreKeep(pTmpPrev && pTmpPrev->IsFlowFrame()
+&& SwFlowFrame::CastFlowFrame(pTmpPrev)->IsKeep(
+pTmpPrev->GetAttrSet()->GetKeep(), pTmpPrev->GetBreakItem()));
+
do
{
// #i46181#
@@ -2153,7 +2159,8 @@ bool SwContentFrame::WouldFit_( SwTwips nSpace,
}
}
-if (bRet && !bSplit &&
[Libreoffice-bugs] [Bug 107642] [META] Paragraph dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107642 Bug 107642 depends on bug 101895, which changed state. Bug 101895 Summary: Paragraph dialog units shown as "ch" and "lines" when "Enable char unit" is enabled by default https://bugs.documentfoundation.org/show_bug.cgi?id=101895 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - 3 commits - sc/qa sw/qa sw/source
sc/qa/unit/ucalc_condformat.cxx | 12 +---
sw/qa/extras/layout/data/tdf142694-1.odt|binary
sw/qa/extras/layout/layout.cxx | 24
sw/source/core/layout/findfrm.cxx | 16 +---
sw/source/core/text/EnhancedPDFExportHelper.cxx |4
5 files changed, 46 insertions(+), 10 deletions(-)
New commits:
commit dd53384cfea6ad6e7995679976bd507b567afe2f
Author: Michael Stahl
AuthorDate: Tue Aug 15 16:29:31 2023 +0200
Commit: Xisco Fauli
CommitDate: Tue Aug 22 20:59:03 2023 +0200
sw: PDF/UA export: add /Placement/Block to Note
PDF 1.7 defines Note as an ILSE (inline), but that is rather odd and
definitely not how footnotes work in Writer.
PAC 3 complains about "Possibly inappropriate use of a "Note" structure
element" and "Possibly inappropriate use of a "P" structure element"
which is rather opaque but experimenting shows the warnings disappear
when the Note has a /Placement/Block attribute.
PDF 2.0 (ISO-32000-2:2020 Annex M) even removes the Note ILSE and
introduces FENote as a BLSE to replace it.
Change-Id: I46ee32c88d4be495bf79549280e2fa68d7da091c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155722
Tested-by: Jenkins
Reviewed-by: Michael Stahl
(cherry picked from commit 7712221f5340b8eb875d391967b2726e93285ab4)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155701
Reviewed-by: Xisco Fauli
diff --git a/sw/source/core/text/EnhancedPDFExportHelper.cxx
b/sw/source/core/text/EnhancedPDFExportHelper.cxx
index 9124522379c8..4473b89d25b4 100644
--- a/sw/source/core/text/EnhancedPDFExportHelper.cxx
+++ b/sw/source/core/text/EnhancedPDFExportHelper.cxx
@@ -585,6 +585,10 @@ void SwTaggedPDFHelper::SetAttributes(
vcl::PDFWriter::StructElement eType )
bWritingMode = true;
break;
+case vcl::PDFWriter::Note:
+bPlacement = true;
+break;
+
case vcl::PDFWriter::Table :
bPlacement =
bWritingMode =
commit 346cedd597bee1058bb8ebd0681faad9d8c2b203
Author: Michael Stahl
AuthorDate: Thu Aug 10 19:04:08 2023 +0200
Commit: Xisco Fauli
CommitDate: Tue Aug 22 20:58:56 2023 +0200
tdf#142694 sw: layout: fix infinite loop in SwFrame::PrepareMake()
The problem is that SwFrame::FindNext_() returns itself, because it's a
table frame 401 and its last cell is empty.
There was a nested table in the cell, but during an attempt to split the
outer table 401, the inner table moved backwards.
This is due to code that was added in commit
c9c956f2716c58e2573a9ac07073f712d736ed02, which only checks that the
height of the table frame is 0, but in this case the inner table does
contain a text frame which has never been formatted yet, but still the
table frame's size and print area was set to valid.
Unfortunately adding an obvious !ContainsContent() check to the
condition breaks uiwriter4 testTdf114306_2, the last table is not on
page 4 but on page 5, for no good reason.
So just fix SwFrame::FindNext_(), it should never return "this" anyway.
(somehow regression from commit 53a0a86df6eb5fc64a85ecd03f2e354fd4d8e213)
Change-Id: If043a53c32f175fc560d422c4a4e16d8e8c6ef49
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155563
Tested-by: Jenkins
Reviewed-by: Michael Stahl
(cherry picked from commit fcf6f5550cc7949e94dc74cbcd10a700a225e574)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155608
Reviewed-by: Xisco Fauli
diff --git a/sw/qa/extras/layout/data/tdf142694-1.odt
b/sw/qa/extras/layout/data/tdf142694-1.odt
new file mode 100644
index ..9e9245998735
Binary files /dev/null and b/sw/qa/extras/layout/data/tdf142694-1.odt differ
diff --git a/sw/qa/extras/layout/layout.cxx b/sw/qa/extras/layout/layout.cxx
index 53b3c2932c3a..ebb63e07eef9 100644
--- a/sw/qa/extras/layout/layout.cxx
+++ b/sw/qa/extras/layout/layout.cxx
@@ -3531,6 +3531,30 @@ CPPUNIT_TEST_FIXTURE(SwLayoutWriter, testTdf128611)
assertXPathContent(pXmlDoc, "//tab/row/cell[1]/txt", "Abcd efghijkl");
}
+CPPUNIT_TEST_FIXTURE(SwLayoutWriter, testTdf142694)
+{
+createSwDoc("tdf142694-1.odt");
+
+xmlDocUniquePtr pXmlDoc = parseLayoutDump();
+CPPUNIT_ASSERT(pXmlDoc);
+
+// the problem with this table is that the 3rd text frame (inside a nested
+// table) contains an as-char fly that doesn't fit on a page with the
+// repeated header row; currently it's split so that the 3rd text frame is
+// on a page of its own and extends outside the table.
+
+assertXPathNoAttribute(pXmlDoc, "/root/page[4]/body/tab[1]", "precede");
+CPPUNIT_ASSERT(!getXPath(pXmlDoc, "/root/page[4]/body/tab[1]",
"follow").isEmpty());
+assertXPath(pXmlDoc,
[Libreoffice-bugs] [Bug 156857] FILEOPEN PPTX: text boxes (with more text) expand vertically to fit text (when they don't in PowerPoint)
https://bugs.documentfoundation.org/show_bug.cgi?id=156857 Gabor Kelemen (allotropia) changed: What|Removed |Added CC||kelem...@ubuntu.com --- Comment #3 from Gabor Kelemen (allotropia) --- Repro in Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 4403b4e6bac19d89afded080d80de049aaa294ca CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3 Locale: hu-HU (hu_HU.UTF-8); UI: en-US Calc: threaded from bibisect-242 repo. But for me only the "Global Events" is two lines, the Web/Organic fits in one line (even back to bibisect-6.0). The font is also called "Poppins Light" which is something I don't have locally, but may be substituted differently under Linux/fontconfig and Windows. Also under Windows it is all one line. I'm not sure if this is a plain pptx import issue, I don't see anything weird with the textboxes settings. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 123417] File with lots of comments opens slower compared to LibO 4.4.7.2
https://bugs.documentfoundation.org/show_bug.cgi?id=123417 ady changed: What|Removed |Added Resolution|FIXED |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 88278] [META] SVG import image filter (all modules)
https://bugs.documentfoundation.org/show_bug.cgi?id=88278 Bug 88278 depends on bug 129356, which changed state. Bug 129356 Summary: VIEWING: SVG image are incorrectly rendered (CSS combinators) https://bugs.documentfoundation.org/show_bug.cgi?id=129356 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 124117] FILESAVE: Wrap Text is not saved to *.xls
https://bugs.documentfoundation.org/show_bug.cgi?id=124117 --- Comment #11 from ady --- (In reply to Oliver Brinzing from comment #6) > - open attached file > - select cell A39 > - press "Wrap Text" from Toolbar > -> layout changes > - save *.xls > - reload *.xls It still fails for these STR on the attached file from comment 2 – whether setting "wrap text" ON or OFF, the changed attribute is not saved to the file. The attribute (ON or OFF) is saved correctly in a new clean file (such as in attachment from comment 7). IDK what exactly triggers the problem. I wonder whether it can be reproduced with some other file, or in safe mode, or... -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: cui/source sw/qa
cui/source/tabpages/paragrph.cxx | 26 ++
sw/qa/uitest/writer_tests2/formatParagraph.py | 10 +-
sw/qa/uitest/writer_tests3/tdf79236.py| 20 ++--
3 files changed, 33 insertions(+), 23 deletions(-)
New commits:
commit a701a726dc3ccc174d1323a298c3550733773df9
Author: Caolán McNamara
AuthorDate: Tue Aug 22 13:14:38 2023 +0100
Commit: Caolán McNamara
CommitDate: Tue Aug 22 20:46:40 2023 +0200
tdf#101895 don't unconditionally default to ch[ar]/line
if CJK typography is available.
Given that we choose to show cm vs inch based on
SvtSysLocaleOptions::GetRealLanguageTag() also choose to use ch[ar] and
line based on that setting when bApplyCharUnit is enabled.
Change-Id: I812d05e0639f7e214d5c3d4dcca01b0709126fd9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155948
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/cui/source/tabpages/paragrph.cxx b/cui/source/tabpages/paragrph.cxx
index 957431e565a9..9f5e94833b3b 100644
--- a/cui/source/tabpages/paragrph.cxx
+++ b/cui/source/tabpages/paragrph.cxx
@@ -48,11 +48,14 @@
#include
#include
#include
+#include
+#include
#include
#include
#include
#include
#include
+#include
const WhichRangesContainer SvxStdParagraphTabPage::pStdRanges(
svl::Items<
@@ -527,6 +530,19 @@ bool SvxStdParagraphTabPage::FillItemSet( SfxItemSet*
rOutSet )
return bModified;
}
+static bool UseCharUnitInUI(const SfxItemSet& rSet)
+{
+const bool bApplyCharUnit = GetApplyCharUnit(rSet);
+if (!bApplyCharUnit)
+return false;
+if (!SvtCJKOptions::IsAsianTypographyEnabled())
+return false;
+// tdf#101895 Given that we choose to show cm vs inch based on this Locale
+// setting, also choose to use ch[ar] and line based on that locale when
+// bApplyCharUnit is enabled.
+return
MsLangId::isCJK(SvtSysLocaleOptions().GetRealLanguageTag().getLanguageType());
+}
+
void SvxStdParagraphTabPage::Reset( const SfxItemSet* rSet )
{
SfxItemPool* pPool = rSet->GetPool();
@@ -534,10 +550,7 @@ void SvxStdParagraphTabPage::Reset( const SfxItemSet* rSet
)
// adjust metric
FieldUnit eFUnit = GetModuleFieldUnit( *rSet );
-
-bool bApplyCharUnit = GetApplyCharUnit( *rSet );
-
-if(SvtCJKOptions::IsAsianTypographyEnabled() && bApplyCharUnit )
+if (UseCharUnitInUI(*rSet))
eFUnit = FieldUnit::CHAR;
m_aLeftIndent.SetFieldUnit(eFUnit);
@@ -1824,10 +1837,7 @@ void SvxExtParagraphTabPage::Reset( const SfxItemSet*
rSet )
// adjust metric
FieldUnit eFUnit = GetModuleFieldUnit( *rSet );
-
-bool bApplyCharUnit = GetApplyCharUnit( *rSet );
-
-if( SvtCJKOptions::IsAsianTypographyEnabled() && bApplyCharUnit )
+if (UseCharUnitInUI(*rSet))
eFUnit = FieldUnit::CHAR;
sal_uInt16 _nWhich = GetWhich( SID_ATTR_PARA_HYPHENZONE );
diff --git a/sw/qa/uitest/writer_tests2/formatParagraph.py
b/sw/qa/uitest/writer_tests2/formatParagraph.py
index cd72dbf7efe7..e90d0fd7f980 100644
--- a/sw/qa/uitest/writer_tests2/formatParagraph.py
+++ b/sw/qa/uitest/writer_tests2/formatParagraph.py
@@ -58,12 +58,12 @@ class formatParagraph(UITestCase):
xLineSpacing = xDialog.getChild("comboLB_LINEDIST")
xActivate = xDialog.getChild("checkCB_REGISTER")
-self.assertEqual(get_state_as_dict(xBeforeText)["Text"], "0.50
ch")
-self.assertEqual(get_state_as_dict(xAfterText)["Text"], "0.50
ch")
-self.assertEqual(get_state_as_dict(xFirstLine)["Text"], "0.50
ch")
+self.assertEqual(get_state_as_dict(xBeforeText)["Text"],
"0.02″")
+self.assertEqual(get_state_as_dict(xAfterText)["Text"],
"0.02″")
+self.assertEqual(get_state_as_dict(xFirstLine)["Text"],
"0.02″")
self.assertEqual(get_state_as_dict(xAutomaticChk)["Selected"],
"true")
-self.assertEqual(get_state_as_dict(xAbovePar)["Text"], "0.50
line")
-self.assertEqual(get_state_as_dict(xBelowPar)["Text"], "0.50
line")
+self.assertEqual(get_state_as_dict(xAbovePar)["Text"], "0.02″")
+self.assertEqual(get_state_as_dict(xBelowPar)["Text"], "0.02″")
self.assertEqual(get_state_as_dict(xChkspace)["Selected"],
"true")
self.assertEqual(get_state_as_dict(xLineSpacing)["SelectEntryText"], "Double")
self.assertEqual(get_state_as_dict(xActivate)["Selected"],
"true")
diff --git a/sw/qa/uitest/writer_tests3/tdf79236.py
b/sw/qa/uitest/writer_tests3/tdf79236.py
index c8e857188c9c..d7b59da19f63 100644
--- a/sw/qa/uitest/writer_tests3/tdf79236.py
+++ b/sw/qa/uitest/writer_tests3/tdf79236.py
@@ -59,11 +59,11 @@ class tdf79236(UITestCase):
xTopSpnBtn.executeAction("UP", tuple())
-
[Libreoffice-bugs] [Bug 156455] Allow toggling repeating-header property of a row in row context menu
https://bugs.documentfoundation.org/show_bug.cgi?id=156455 --- Comment #6 from Eyal Rozenberg --- (In reply to Heiko Tietze from comment #5) > Mind to elaborate? Let me clarify: I am _not_ asking for another place in which the existing "heading rows repeat" command can be used. What I'm asking for is the ability to add one row to the existing repeating heading rows; and to remove one row from that set of repeating heading rows. And - I'm asking that this be accessible as an item on the table row context menu. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 156455] Allow toggling repeating-header property of a row in row context menu
https://bugs.documentfoundation.org/show_bug.cgi?id=156455 --- Comment #6 from Eyal Rozenberg --- (In reply to Heiko Tietze from comment #5) > Mind to elaborate? Let me clarify: I am _not_ asking for another place in which the existing "heading rows repeat" command can be used. What I'm asking for is the ability to add one row to the existing repeating heading rows; and to remove one row from that set of repeating heading rows. And - I'm asking that this be accessible as an item on the table row context menu. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-commits] core.git: svgio/inc svgio/qa svgio/source
svgio/inc/svgnode.hxx |2 -
svgio/qa/cppunit/SvgImportTest.cxx | 23
svgio/qa/cppunit/data/tdf129356.svg | 34 ++
svgio/source/svgreader/svgnode.cxx | 68 +++-
4 files changed, 80 insertions(+), 47 deletions(-)
New commits:
commit b2247336409b7b3b0ae04356a167dcd204badb04
Author: Xisco Fauli
AuthorDate: Tue Aug 22 12:46:02 2023 +0200
Commit: Xisco Fauli
CommitDate: Tue Aug 22 20:06:24 2023 +0200
tdf#129356: handle css combinator when the element name is combined...
... with the ID or the class
While at it, simplify the code a bit
Change-Id: I9e36f334b884d31229568835a346d4427a47c760
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155945
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
diff --git a/svgio/inc/svgnode.hxx b/svgio/inc/svgnode.hxx
index 0d8008d41c90..96c6ade01efa 100644
--- a/svgio/inc/svgnode.hxx
+++ b/svgio/inc/svgnode.hxx
@@ -125,7 +125,7 @@ namespace svgio::svgreader
const OUString& aConcatenated);
void fillCssStyleVectorUsingHierarchyAndSelectors(
const SvgNode& rCurrent,
-const OUString& aConcatenated);
+std::u16string_view aConcatenated);
void fillCssStyleVectorUsingParent(
const SvgNode& rCurrent);
diff --git a/svgio/qa/cppunit/SvgImportTest.cxx
b/svgio/qa/cppunit/SvgImportTest.cxx
index 4d7cd9772d51..0450d3617e11 100644
--- a/svgio/qa/cppunit/SvgImportTest.cxx
+++ b/svgio/qa/cppunit/SvgImportTest.cxx
@@ -441,6 +441,29 @@ CPPUNIT_TEST_FIXTURE(Test, testTdf156168)
assertXPath(pDocument, "/primitive2D/transform/polypolygonstroke[4]/line",
"color", "#00ff00");
}
+CPPUNIT_TEST_FIXTURE(Test, testTdf129356)
+{
+Primitive2DSequence aSequence =
parseSvg(u"/svgio/qa/cppunit/data/tdf129356.svg");
+CPPUNIT_ASSERT_EQUAL(1, static_cast(aSequence.getLength()));
+
+drawinglayer::Primitive2dXmlDump dumper;
+xmlDocUniquePtr pDocument = dumper.dumpAndParse(aSequence);
+
+CPPUNIT_ASSERT (pDocument);
+
+// Without the fix in place, this test would have failed with
+// - Expected: #008000
+// - Actual : #ff
+assertXPath(pDocument, "/primitive2D/transform/polypolygoncolor[1]",
"color", "#008000");
+assertXPath(pDocument, "/primitive2D/transform/polypolygoncolor[2]",
"color", "#008000");
+assertXPath(pDocument, "/primitive2D/transform/polypolygoncolor[3]",
"color", "#008000");
+assertXPath(pDocument, "/primitive2D/transform/polypolygoncolor[4]",
"color", "#008000");
+assertXPath(pDocument, "/primitive2D/transform/polypolygoncolor[5]",
"color", "#008000");
+assertXPath(pDocument, "/primitive2D/transform/polypolygoncolor[6]",
"color", "#008000");
+assertXPath(pDocument, "/primitive2D/transform/polypolygoncolor[7]",
"color", "#008000");
+assertXPath(pDocument, "/primitive2D/transform/polypolygoncolor[8]",
"color", "#008000");
+}
+
CPPUNIT_TEST_FIXTURE(Test, testTdf156034)
{
Primitive2DSequence aSequence =
parseSvg(u"/svgio/qa/cppunit/data/tdf156034.svg");
diff --git a/svgio/qa/cppunit/data/tdf129356.svg
b/svgio/qa/cppunit/data/tdf129356.svg
new file mode 100644
index ..46bd6935daa4
--- /dev/null
+++ b/svgio/qa/cppunit/data/tdf129356.svg
@@ -0,0 +1,34 @@
+http://www.w3.org/2000/svg;
xmlns:xlink="http://www.w3.org/1999/xlink; viewBox="-0 0 800 800">
+
+
+g.g1 rect {fill:green;}
+g#g3 rect {fill:green;}
+g.g4 #r1 {fill:green;}
+g#g3 .r5 {fill:green;}
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
diff --git a/svgio/source/svgreader/svgnode.cxx
b/svgio/source/svgreader/svgnode.cxx
index 4f82a16ebf1e..fd80337eb5b6 100644
--- a/svgio/source/svgreader/svgnode.cxx
+++ b/svgio/source/svgreader/svgnode.cxx
@@ -94,7 +94,7 @@ namespace {
void SvgNode::fillCssStyleVectorUsingHierarchyAndSelectors(
const SvgNode& rCurrent,
-const OUString& aConcatenated)
+std::u16string_view aConcatenated)
{
const SvgDocument& rDocument = getDocument();
@@ -102,6 +102,7 @@ namespace {
return;
const SvgNode* pParent = rCurrent.getParent();
+OUString sCurrentType(SVGTokenToStr(rCurrent.getType()));
// check for ID (highest priority)
if(rCurrent.getId())
@@ -110,21 +111,17 @@ namespace {
if(rId.getLength())
{
-const OUString aNewConcatenated(
-"#" + rId + aConcatenated);
+const OUString aNewConcatenated("#" + rId + aConcatenated);
+addCssStyle(rDocument, aNewConcatenated);
+
+
[Libreoffice-bugs] [Bug 154227] Clone Formatting doesn't work on background color
https://bugs.documentfoundation.org/show_bug.cgi?id=154227 Andreas Mantke changed: What|Removed |Added CC||ma...@gmx.de Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #8 from Andreas Mantke --- I tested as in your video with background color of text. I started with yellow background and used the brush and could add with it the background color to another string (new paragraph). I tried this again with that line and could apply the background color with the brush to a third text line (also in a new paragraph). Then I changed the background color in the third line and used the brush in the reverse direction (from string 3 to 1) and it works also. Version: 7.5.5.2 (X86_64) / LibreOffice Community Build ID: ca8fe7424262805f223b9a2334bc7181abbcbf5e CPU threads: 8; OS: Linux 5.14; UI render: default; VCL: kf5 (cairo+xcb) Locale: de-DE (de_DE.UTF-8); UI: de-DE Calc: threaded Thus the issue is resolved at least in the current version 7.5.5. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156856] Assertion failed opening a specific PPTX
https://bugs.documentfoundation.org/show_bug.cgi?id=156856 Mike Kaganski changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |mikekagan...@hotmail.com |desktop.org | Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156856] Assertion failed opening a specific PPTX
https://bugs.documentfoundation.org/show_bug.cgi?id=156856 Commit Notification changed: What|Removed |Added Whiteboard||target:24.2.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156856] Assertion failed opening a specific PPTX
https://bugs.documentfoundation.org/show_bug.cgi?id=156856 --- Comment #1 from Commit Notification --- Mike Kaganski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/3cf3e0e21d2f7fa33abced5e2f7291de6e4441eb tdf#156856: close write access before using AlphaMask It will be available in 24.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sd/CppunitTest_sd_import_tests_skia.mk sd/Module_sd.mk sd/qa vcl/source
sd/CppunitTest_sd_import_tests_skia.mk | 13 +++
sd/Module_sd.mk|1
sd/qa/unit/data/pptx/tdf156856.pptx|binary
sd/qa/unit/import-tests_skia.cxx | 36 +
vcl/source/filter/graphicfilter.cxx|4 +--
5 files changed, 52 insertions(+), 2 deletions(-)
New commits:
commit 3cf3e0e21d2f7fa33abced5e2f7291de6e4441eb
Author: Mike Kaganski
AuthorDate: Tue Aug 22 17:45:03 2023 +0300
Commit: Mike Kaganski
CommitDate: Tue Aug 22 20:02:32 2023 +0200
tdf#156856: close write access before using AlphaMask
Change-Id: I432417f03d378f81c890ce6c313a2f140b564a60
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155955
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/sd/CppunitTest_sd_import_tests_skia.mk
b/sd/CppunitTest_sd_import_tests_skia.mk
new file mode 100644
index ..bb0d0ad2a3ba
--- /dev/null
+++ b/sd/CppunitTest_sd_import_tests_skia.mk
@@ -0,0 +1,13 @@
+# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t; fill-column:
100 -*-
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
+$(eval $(call sd_import_test,_skia))
+$(eval $(call gb_CppunitTest_use_vcl_non_headless,sd_import_tests_skia))
+
+# vim: set noet sw=4 ts=4:
diff --git a/sd/Module_sd.mk b/sd/Module_sd.mk
index 9b7736a41a5f..ff09ee8c5ba3 100644
--- a/sd/Module_sd.mk
+++ b/sd/Module_sd.mk
@@ -33,6 +33,7 @@ $(eval $(call gb_Module_add_slowcheck_targets,sd,\
CppunitTest_sd_uimpress) \
CppunitTest_sd_import_tests \
CppunitTest_sd_import_tests2 \
+CppunitTest_sd_import_tests_skia \
CppunitTest_sd_import_tests-smartart \
CppunitTest_sd_export_tests-ooxml1 \
CppunitTest_sd_export_tests-ooxml2 \
diff --git a/sd/qa/unit/data/pptx/tdf156856.pptx
b/sd/qa/unit/data/pptx/tdf156856.pptx
new file mode 100644
index ..a4624adbce91
Binary files /dev/null and b/sd/qa/unit/data/pptx/tdf156856.pptx differ
diff --git a/sd/qa/unit/import-tests_skia.cxx b/sd/qa/unit/import-tests_skia.cxx
new file mode 100644
index ..47f6406dde32
--- /dev/null
+++ b/sd/qa/unit/import-tests_skia.cxx
@@ -0,0 +1,36 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4;
fill-column: 100 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include
+
+#include "sdmodeltestbase.hxx"
+
+#include
+
+// Tests here are expected to run with Skia enabled, similar to
CppunitTest_vcl_skia.
+// At some point, this could be true for all tests?
+
+class SdImportTestSkia : public SdModelTestBase
+{
+public:
+SdImportTestSkia()
+: SdModelTestBase("/sd/qa/unit/data/")
+{
+}
+};
+
+CPPUNIT_TEST_FIXTURE(SdImportTestSkia, testTdf156856)
+{
+// Loading the document must not fail assertion
+createSdImpressDoc("pptx/tdf156856.pptx");
+}
+
+CPPUNIT_PLUGIN_IMPLEMENT();
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s
cinkeys+=0=break: */
diff --git a/vcl/source/filter/graphicfilter.cxx
b/vcl/source/filter/graphicfilter.cxx
index ffc3b7cb92de..83c091fa9ab3 100644
--- a/vcl/source/filter/graphicfilter.cxx
+++ b/vcl/source/filter/graphicfilter.cxx
@@ -635,10 +635,10 @@ void GraphicFilter::ImportGraphics(std::vector<
std::shared_ptr >& rGra
// Process data after import.
for (auto& rContext : aContexts)
{
-if(rContext.m_pAlphaAccess) // Need to move the AlphaMask back to the
BitmapEx.
-*rContext.m_pGraphic = BitmapEx(
rContext.m_pGraphic->GetBitmapExRef().GetBitmap(), rContext.mAlphaMask );
rContext.m_pAccess.reset();
rContext.m_pAlphaAccess.reset();
+if (!rContext.mAlphaMask.IsEmpty()) // Need to move the AlphaMask back
to the BitmapEx.
+*rContext.m_pGraphic = BitmapEx(
rContext.m_pGraphic->GetBitmapExRef().GetBitmap(), rContext.mAlphaMask );
if (rContext.m_nStatus == ERRCODE_NONE && (rContext.m_eLinkType !=
GfxLinkType::NONE) && !rContext.m_pGraphic->GetReaderContext())
{
[Libreoffice-commits] core.git: sd/source
sd/source/ui/dlg/sdtreelb.cxx |7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
New commits:
commit 6761b79e7b48a5885adecf445f0206f141888613
Author: Jim Raykowski
AuthorDate: Sat Aug 19 17:41:02 2023 -0800
Commit: Jim Raykowski
CommitDate: Tue Aug 22 19:46:29 2023 +0200
tdf#156610 tdf#139633 SdNavigator: Fix object not selected
for entry that context menu is shown for, GtkInstance only
Commit fdb504add8e21c137a37fde48fedb93638e8ee97 introduced a hack to
make inplace editing work for the SalInstance of the treeview that,
for Gtk3, breaks object selection before the entry popup menu is
displayed which causes the menu item Rename... not to always work as
expected. Sal doesn't notice this because the mouse pressed signal is
seen when there is a popup menu handler set. Gtk3 does not fire the
mouse pressed signal when a popup menu handler set. This patch makes
object selection always happen before the popup menu is shown.
Change-Id: I562ddf99bd15a48631170a7d70821021a4139295
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155867
Tested-by: Jenkins
Reviewed-by: Jim Raykowski
diff --git a/sd/source/ui/dlg/sdtreelb.cxx b/sd/source/ui/dlg/sdtreelb.cxx
index e6e72c8884e0..63c26bc5635c 100644
--- a/sd/source/ui/dlg/sdtreelb.cxx
+++ b/sd/source/ui/dlg/sdtreelb.cxx
@@ -301,6 +301,7 @@ IMPL_LINK(SdPageObjsTLV, CommandHdl, const CommandEvent&,
rCEvt, bool)
if (rCEvt.GetCommand() == CommandEventId::ContextMenu)
{
+m_bMouseReleased = false;
m_xTreeView->grab_focus();
// select clicked entry
@@ -314,7 +315,9 @@ IMPL_LINK(SdPageObjsTLV, CommandHdl, const CommandEvent&,
rCEvt, bool)
Select();
}
-return m_aPopupMenuHdl.Call(rCEvt);
+bool bRet = m_aPopupMenuHdl.Call(rCEvt);
+m_bMouseReleased = true;
+return bRet;
}
return false;
@@ -842,7 +845,7 @@ void SdPageObjsTLV::Select()
{
m_nSelectEventId = nullptr;
-// hack to make inplace editing work for x11
+// m_bMouseReleased is a hack to make inplace editing work for X11
if (m_bMouseReleased)
return;
[Libreoffice-bugs] [Bug 156842] Export to PDF that includes PDF images are incorrect in size
https://bugs.documentfoundation.org/show_bug.cgi?id=156842 --- Comment #5 from cytan...@yahoo.com --- I reproduced this bug on MacOS Ventura 13.5 MacOS Monterey 12.6.8 running LibreOffice 7.6.0.3 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156530] FIREBIRD: Copying a table from one database file to another gives wrong decimal numbers.
https://bugs.documentfoundation.org/show_bug.cgi?id=156530 --- Comment #9 from Alex Thurgood --- (In reply to Xisco Faulí from comment #8) > (In reply to Alex Thurgood from comment #6) > Hi Alex, > any chance you could revert it and test it ? or bisect it ? Unfortunately, I haven't been able to build environment for LO on Mac for several years now, or even a bibisect environment. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 138751] Not localized items in notebookbar customization
https://bugs.documentfoundation.org/show_bug.cgi?id=138751 --- Comment #10 from Stanislav Horacek --- I see it still not localized in: Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 47ca3f1f762352b488d58b3bf23d5776576f1cca CPU threads: 4; OS: Linux 6.2; UI render: default; VCL: gtk3 Locale: cs-CZ (cs_CZ.UTF-8); UI: cs-CZ Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156842] Export to PDF that includes PDF images are incorrect in size
https://bugs.documentfoundation.org/show_bug.cgi?id=156842 --- Comment #4 from Telesto --- No issue with Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 518fa99dd7693d64a53e404a065090aedc0002b1 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149736] EDITING: Delete key after pasting in a selected table cell does not delete the cell content
https://bugs.documentfoundation.org/show_bug.cgi?id=149736 LeroyG changed: What|Removed |Added Version|7.2.3.2 release |6.4.7.2 release --- Comment #6 from LeroyG --- Testing with: Version: 7.6.0.2 (x86) / LibreOffice Community Build ID: 41d6f628ba3f046f16b5fa9fa8db8d4c2ab3b582 CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: Skia/Raster; VCL: win Locale: es-MX (es_MX); UI: en-US Calc: threaded (In reply to LeroyG from comment #0) > Steps to Reproduce: > […] > Actual Results: > Cell selection is lost but cell content is not deleted. Still here. (In reply to Tudor Bocean from comment #3) > Version: 7.3.4.2 (x64) / LibreOffice Community 1. > - After pasting text from one cell to one or more other cells, putting the > Writer program in background, copying a word from a different place and > pasting it in Writer (cells are still selected) will result in the new text > being put AFTER the existing one and not replacing it as it would be > expected ===> Wrong behavior I can confirm here. Extrange. But this "feature" don't dislike me. Could it be a possibility? Must be documented. Ups! But it don't work if the new source text is from the same document. 2. > - After pasting text from one cell to one or more other cells, using the Cut > feature CTRL + X will result in no text deletion ===> Wrong behavior ===> > however, the cells Cut were correctly copied ===> Expected Ctrl + X works here. 3. > - After pasting text from one cell to one or more other cells, while cells > are still selecting, pasting again will result in the text being added a > second time ===> Probably a wrong behavior (?) I can confirm here. But won't work if the source text is the whole cell. Related to *1*. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156842] Export to PDF that includes PDF images are incorrect in size
https://bugs.documentfoundation.org/show_bug.cgi?id=156842 --- Comment #3 from cytan...@yahoo.com --- Bug reproduced in LibreOffice 7.6.0.3 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155353] unable to export as PDF in 7.5
https://bugs.documentfoundation.org/show_bug.cgi?id=155353 --- Comment #13 from N.P. --- > Is the working 7.4.7 also packaged by LibreItalia? We had a different third > party creating the appimages before. I guess it is some conflict in what the > appimage provides vs. what you have built for your user space. My apologies in not responding sooner. I have just tested this again on three AppImages packaged by LibreItalia: LibreOffice-7.4.7.2.standard.help-x86_64.AppImage LibreOffice-7.5.5.2.standard.help-x86_64.AppImage LibreOffice-7.6.0.3.standard.help-x86_64.AppImage Unfortunately, I now feel more confused than ever. LibreOffice-7.4.7.2: worked perfectly LibreOffice-7.5.5.2: worked perfectly LibreOffice-7.6.0.3: failed exactly as described above -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 149625] FORMATTING: Pasting a table cell, pastes the source cell in the upper/actual cell as an inner table cell
https://bugs.documentfoundation.org/show_bug.cgi?id=149625 --- Comment #21 from LeroyG --- (In reply to Mike Kaganski from comment #19) > I couldn't repro *that* piece using 7.6.0.3. Nor with version 7.6.0.2 (just tested). So, the bug to which the title refers (*3.a* in comment #0) was partially solved somewhere between versions 7.5.0.0.alpha0+ and 7.6.0.2. (In reply to Mike Kaganski from comment #17) > 3. Putting cursor into the first paragraph (no matter which position inside > that paragraph; selecting some characters starting from that paragraph works > the same) inside the target cell, and pasting, replaces the target cell with > the copied cell (no inner cell); The same in version 7.4.7.2. But this behavior has been evolving: i.e., in version 6.4.7.2 this results in an inner cell inserted at the text cursor position (in part like *4* in comment #17), except when the cursor is at the beginning of the cell. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 149625] FORMATTING: Pasting a table cell, pastes the source cell in the upper/actual cell as an inner table cell
https://bugs.documentfoundation.org/show_bug.cgi?id=149625 --- Comment #21 from LeroyG --- (In reply to Mike Kaganski from comment #19) > I couldn't repro *that* piece using 7.6.0.3. Nor with version 7.6.0.2 (just tested). So, the bug to which the title refers (*3.a* in comment #0) was partially solved somewhere between versions 7.5.0.0.alpha0+ and 7.6.0.2. (In reply to Mike Kaganski from comment #17) > 3. Putting cursor into the first paragraph (no matter which position inside > that paragraph; selecting some characters starting from that paragraph works > the same) inside the target cell, and pasting, replaces the target cell with > the copied cell (no inner cell); The same in version 7.4.7.2. But this behavior has been evolving: i.e., in version 6.4.7.2 this results in an inner cell inserted at the text cursor position (in part like *4* in comment #17), except when the cursor is at the beginning of the cell. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141579] Create Query in Design View Query Builder build SQL that aliases table name to itself causing some ODBC and JDBC database queries to fail
https://bugs.documentfoundation.org/show_bug.cgi?id=141579 --- Comment #2 from ianbstu...@gmail.com --- This bug still occurs at LibreOffice version 7.4.3.2 on OpenSuse leap 15.5 and Windows 10 To summarise: In LibreOffice Base when using Edit\Database\Advanced Settings there is an option to select/de-select "Append the table alias name on SELECT statements" as well the option "Use keyword AS before table alias names" Even when these options are "not" checked the resulting SQL query includes the aliasing of the table being selected with same name. EG: SELECT "AT_ID", "NAME1" FROM "CM" "CM" The only option related to using a table alias that is honoured is the "Use keyword AS before table alias names" When "Append the table alias name on SELECT statements" is "not" checked and and "Use keyword AS before table alias names" "is" checked: SELECT "AT_ID", "NAME1" FROM "CM" AS "CM" >From this one can deduce that the option "Append the table alias name on SELECT statements" is being ignored. The database using this JDBC driver requires that if a table is aliased it be to a unique name eg T1.CM - this is commonly done in many BI tools as well Because the options are not being honoured the query has to be manually edited to remove the alias. This can get complex when there many tables in the query. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156861] FILEOPEN XLS, Function with logic answer gives back 1 or 0 in LO
https://bugs.documentfoundation.org/show_bug.cgi?id=156861 Justin L changed: What|Removed |Added Version|4.1 all versions|4.2 all versions Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #1 from Justin L --- for export, sc/source/filter/excel/xetable.cxx says: /* Xcl doesn't know Boolean number formats, we write "TRUE";"FALSE" (language dependent). Don't do it for automatic formula formats, because Excel gets them right. */ -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - sw/qa sw/source
sw/qa/core/layout/paintfrm.cxx | 10 ++--
sw/source/core/layout/paintfrm.cxx | 80 -
2 files changed, 85 insertions(+), 5 deletions(-)
New commits:
commit 05ece1c965baff19a68e8be19711982256ab0d3d
Author: Miklos Vajna
AuthorDate: Mon Aug 21 08:33:14 2023 +0200
Commit: Caolán McNamara
CommitDate: Tue Aug 22 18:05:26 2023 +0200
tdf#156351 sw floattable: fix missing bottom border in master table
The problem was that the bugdoc has a split floating table, and the
bottom of the table on the first page was missing its border. The
borders on the second page were correct.
This happens because the cell itself has no bottom border and the layout
did not extra effort to mirror the top table margin at the buttom, like
Word does.
Fix the problem similar to commit
53798fef2cc0b5b0b9706081a4af5ceca964a41b (Related: tdf#156351 sw
floattable: fix missing top border in follow table, 2023-08-18), so we
add a bottom border for master tables at a layout level, similar how a
top border was already added for follow tables.
Given that this kind of worked already in the past (just top borders,
just the 1 row case), do this unconditionally; but if needed this could
be limited to the "Word table cell" case.
(cherry picked from commit 08aea5526c75ff4c5385e960bd940f10ffa19cd5)
Change-Id: Iafdcd90226fdc425be597d36ad97fb69dca5a89a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155934
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Caolán McNamara
diff --git a/sw/qa/core/layout/paintfrm.cxx b/sw/qa/core/layout/paintfrm.cxx
index 15b9df6a4fb4..2416c6b95f8c 100644
--- a/sw/qa/core/layout/paintfrm.cxx
+++ b/sw/qa/core/layout/paintfrm.cxx
@@ -36,7 +36,8 @@ CPPUNIT_TEST_FIXTURE(Test, testSplitTableBorder)
// When rendering that document:
std::shared_ptr xMetaFile = pShell->GetPreviewMetaFile();
-// Then make sure that the follow table has a top border:
+// Then make sure that the master table has a bottom border and the follow
table has a top
+// border:
MetafileXmlDump aDumper;
xmlDocUniquePtr pXmlDoc = dumpAndParse(aDumper, *xMetaFile);
xmlXPathObjectPtr pXmlObj = getXPathNode(pXmlDoc,
"//polyline[@style='solid']/point");
@@ -61,10 +62,11 @@ CPPUNIT_TEST_FIXTURE(Test, testSplitTableBorder)
}
xmlXPathFreeObject(pXmlObj);
// Without the accompanying fix in place, this test would have failed with:
-// - Expected: 3
+// - Expected: 4
// - Actual : 2
-// i.e. the top border in the follow table was missing.
-CPPUNIT_ASSERT_EQUAL(3, nHorizontalBorders);
+// i.e. the bottom border in the master table and the top border in the
follow table were
+// missing.
+CPPUNIT_ASSERT_EQUAL(4, nHorizontalBorders);
}
}
diff --git a/sw/source/core/layout/paintfrm.cxx
b/sw/source/core/layout/paintfrm.cxx
index 211a539b8c8f..ac9389e03277 100644
--- a/sw/source/core/layout/paintfrm.cxx
+++ b/sw/source/core/layout/paintfrm.cxx
@@ -2394,6 +2394,9 @@ class SwTabFramePainter
void InsertFollowTopBorder(const SwFrame& rFrame, const SvxBoxItem&
rBoxItem,
bool bWordTableCell, SwTwips nTop, SwTwips
nLeft, SwTwips nRight,
bool bTopIsOuter);
+void InsertMasterBottomBorder(const SwFrame& rFrame, const SvxBoxItem&
rBoxItem,
+ bool bWordTableCell, SwTwips nBottom,
SwTwips nLeft, SwTwips nRight,
+ bool bBottomIsOuter);
void HandleFrame(const SwLayoutFrame& rFrame, const SwRect& rPaintArea);
void FindStylesForLine( Point&,
@@ -2866,7 +2869,7 @@ void SwTabFramePainter::InsertFollowTopBorder(const
SwFrame& rFrame, const SvxBo
// This is then a first row in a follow table, without repeated headlines.
auto pLastRow = dynamic_cast(mrTabFrame.GetLastLower());
-if (!pLastRow && pLastRow == pThisRow)
+if (!pLastRow || pLastRow == pThisRow)
{
return;
}
@@ -2902,6 +2905,79 @@ void SwTabFramePainter::InsertFollowTopBorder(const
SwFrame& rFrame, const SvxBo
Insert(aFollowTop, true);
}
+void SwTabFramePainter::InsertMasterBottomBorder(const SwFrame& rFrame, const
SvxBoxItem& rBoxItem,
+ bool bWordTableCell, SwTwips
nBottom, SwTwips nLeft,
+ SwTwips nRight, bool
bBottomIsOuter)
+{
+// Figure out which cell to copy.
+int nCol = 0;
+const SwFrame* pCell =
+while (pCell)
+{
+if (!pCell->GetPrev())
+{
+break;
+}
+
+++nCol;
+pCell = pCell->GetPrev();
+}
+
+auto pThisRow = dynamic_cast(rFrame.GetUpper());
+if (!pThisRow || pThisRow->GetUpper() != )
+{
+return;
+}
+
+if (mrTabFrame.IsFollow() || !mrTabFrame.GetFollow())
+{
+
