[Libreoffice-bugs] [Bug 129062] [META] Skia library bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=129062 Buovjaga changed: What|Removed |Added Depends on||156216 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=156216 [Bug 156216] Writer crashes in ~1 million lines of text with line numbering enabled -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156216] Writer crashes in ~1 million lines of text with line numbering enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=156216 Buovjaga changed: What|Removed |Added Blocks||129062 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=129062 [Bug 129062] [META] Skia library bugs -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: offapi/type_reference
offapi/type_reference/offapi.idl | 34 --
1 file changed, 24 insertions(+), 10 deletions(-)
New commits:
commit d0166429887ab3cbe8c8369fd73668502d638a4a
Author: Stephan Bergmann
AuthorDate: Mon Sep 4 20:56:30 2023 +0200
Commit: Stephan Bergmann
CommitDate: Tue Sep 5 07:36:05 2023 +0200
Update the reference rdbs to libreoffice-7.6.0.3
.../master/instdir/sdk/bin/unoidl-read --published \
.../libreoffice-7.6.0.3/instdir/program/types.rdb \
>.../master/udkapi/type_reference/udkapi.idl
.../master/instdir/sdk/bin/unoidl-read --published \
.../libreoffice-7.6.0.3/instdir/program/types.rdb \
.../libreoffice-7.6.0.3/instdir/program/types/offapi.rdb \
>.../master/offapi/type_reference/offapi.idl
Change-Id: I3ed0f2fd05caaeb083ac8d5f3c40c30c389847b2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156529
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/offapi/type_reference/offapi.idl b/offapi/type_reference/offapi.idl
index 7c172af98344..fd13e3da3452 100644
--- a/offapi/type_reference/offapi.idl
+++ b/offapi/type_reference/offapi.idl
@@ -430,6 +430,7 @@ module com {
const short BRACKETRIGHT = 1316;
const short C = 514;
const short CAPSLOCK = 1312;
+ const short COLON = 1320;
const short COMMA = 1292;
const short CONTEXTMENU = 1305;
const short COPY = 1298;
@@ -2846,7 +2847,7 @@ module com {
};
published enum LineJoint {
NONE = 0,
- MIDDLE = 1,
+ /** @deprecated */ MIDDLE = 1,
BEVEL = 2,
MITER = 3,
ROUND = 4
@@ -3273,6 +3274,9 @@ module com {
[property, optional] short RelativeWidth;
[property, optional] short RelativeHeightRelation;
[property, optional] short RelativeWidthRelation;
+ [property, optional] string Title;
+ [property, optional] string Description;
+ [property, optional] boolean Decorative;
};
};
module chart {
@@ -3658,6 +3662,7 @@ module com {
[property, optional] boolean ParaHyphenationNoLastWord;
[property, optional] short ParaHyphenationMinWordLength;
[property, optional] long ParaHyphenationZone;
+ [property, optional, readonly] long SortedTextId;
};
};
module util {
@@ -4323,11 +4328,6 @@ module com {
interface ::com::sun::star::lang::XInitialization;
interface ::com::sun::star::lang::XComponent;
};
- published constants RenderingCapabilities {
- const byte Delayed = 1;
- /** @deprecated */ const byte Persistant = 2;
- const byte Persistent = 2;
- };
published interface XFlushableClipboard {
interface ::com::sun::star::uno::XInterface;
void flushClipboard();
@@ -4338,6 +4338,11 @@ module com {
interface ::com::sun::star::lang::XComponent;
[optional] interface
::com::sun::star::datatransfer::clipboard::XFlushableClipboard;
};
+ published constants RenderingCapabilities {
+ const byte Delayed = 1;
+ /** @deprecated */ const byte Persistant = 2;
+ const byte Persistent = 2;
+ };
published service SystemClipboard:
::com::sun::star::datatransfer::clipboard::XSystemClipboard;
published interface XClipboardFactory {
interface ::com::sun::star::uno::XInterface;
@@ -7888,7 +7893,7 @@ module com {
const short HYPHENATION = 2;
const short WORDBOUNDARY = 1;
};
-published constants CTLScriptType {
+/** @deprecated */ published constants CTLScriptType {
const short CTL_ARABIC = 2;
const short CTL_HEBREW = 1;
const short CTL_INDIC = 4;
@@ -8779,9 +8784,9 @@ module com {
long beginOfScriptDirection([in] string aText, [in] long nPos, [in] short
nScriptDirection);
long endOfScriptDirection([in] string aText, [in] long nPos, [in] short
nScriptDirection);
short getScriptDirection([in] string aText, [in] long nPos, [in] short
nDefaultScriptDirection);
- long beginOfCTLScriptType([in] string aText, [in] long nPos);
- long endOfCTLScriptType([in] string aText, [in] long nPos);
- short getCTLScriptType([in] string aText, [in] long nPos);
+ /** @deprecated */ long beginOfCTLScriptType([in] string aText, [in] long
nPos);
+ /** @deprecated */ long endOfCTLScriptType([in] string aText, [in] long
nPos);
+ /** @deprecated */ short getCTLScriptType([in] string aText, [in] long
nPos);
};
published constants reservedWords {
const short ABOVE_WORD = 6;
@@ -13376,14 +13381,18 @@ module com {
const short CHARS_CYRILLIC_LOWER_LETTER_N_BG = 41;
const short CHARS_CYRILLIC_LOWER_LETTER_N_RU = 45;
const short CHARS_CYRILLIC_LOWER_LETTER_N_SR = 51;
+ const short CHARS_CYRILLIC_LOWER_LETTER_N_UK = 75;
const short CHARS_CYRILLIC_LOWER_LETTER_RU = 43;
const short CHARS_CYRILLIC_LOWER_LETTER_SR = 49;
+ const short CHARS_CYRILLIC_LOWER_LETTER_UK = 73;
const short
[Libreoffice-bugs] [Bug 88108] Feature request - Option to lock formatting on cells and/or entire sheet, while allowing editing
https://bugs.documentfoundation.org/show_bug.cgi?id=88108 --- Comment #8 from BDF --- It would be very helpful if you could lock conditional formatting as well. My issue is the following: I work in a field where operation/mission information is stored in an table file (it's actually an Excel file, but 1) the same is true for LibreOffice; 2) we switched to LibreOffice in August so in the upcoming future this is where it's at). The (Excel) file has a good amount of conditional formatting to ensure people put in the correct values. Because the file is stored in a shared 'HLC Notes' room and because that system is buggy AF people save the file locally, enter the values there and then just copy the information to the shared file. And here starts the problem: People don't only copy the values, but also the conditional formatting which turns into several versions of the format with just different fields where they apply. (I know they *could* copy only the values, but the group includes people who don't know or just don't care) My suggestion and what would really help is if you could just lock conditional formatting while every cell can be manipulated freely. (Not sure if this is a good fit here or if it should go into their own report) -- You are receiving this mail because: You are the assignee for the bug.
What is the "dynamic" flag in errcode?
Hi, In the ErrCode definition (include/comphelper/errcode.hxx) error codes are defined as a 32-bit integer. There is a "Dynamic" area in bit 30-26. Also in ErrCode class it defines some methods like isDynamic(), StripDynamic(), ... etc. But we didn't find any comments or documents saying what this "Dynamic" flags means, and didn't find where this flag is set. We're looking at an issue about an ods file with empty meta.xml. The return errcode was SCWARN_IMPORT_FILE_ROWCOL but the Dynamic flag was set, but we couldn't find where and why it was set. Would anyone please tell me about this dynamic flag/area? Thanks, Dev
[Libreoffice-bugs] [Bug 156995] Selecting a group of many curves is extremely slow in Linux
https://bugs.documentfoundation.org/show_bug.cgi?id=156995 Peter Bleszynski changed: What|Removed |Added Summary|Selecting an embedded SVG |Selecting a group of many |is extremely slow in Linux |curves is extremely slow in ||Linux -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156852] Description field in Tools - Macros - Run Macro does not have borders
https://bugs.documentfoundation.org/show_bug.cgi?id=156852 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156849] Cell Style Not Overriding default
https://bugs.documentfoundation.org/show_bug.cgi?id=156849 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156839] Printing from macro creates empty page instead of the second sheet
https://bugs.documentfoundation.org/show_bug.cgi?id=156839 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156831] Writer - Navigator buttons open on second monitor.
https://bugs.documentfoundation.org/show_bug.cgi?id=156831 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146548] FORMATTING - Negative numbers not red
https://bugs.documentfoundation.org/show_bug.cgi?id=146548 --- Comment #13 from QA Administrators --- Dear Dinky, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156848] New version 7.6.0.3 does not replace version 7.5.5.2
https://bugs.documentfoundation.org/show_bug.cgi?id=156848 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157089] A question about lack of what seems to me a very essential feature for LibreOffice Calcs.
https://bugs.documentfoundation.org/show_bug.cgi?id=157089 --- Comment #3 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153394] enormous size of special characters in 'insert special characters' in Writer, LO 7.5.0.3
https://bugs.documentfoundation.org/show_bug.cgi?id=153394 --- Comment #4 from QA Administrators --- Dear befsztyk33, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156961] Crash in: libc.so.6
https://bugs.documentfoundation.org/show_bug.cgi?id=156961 --- Comment #5 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 135871] Highlighting no fill is not the same as no fill; there is still direct formatting present according to paragraph style
https://bugs.documentfoundation.org/show_bug.cgi?id=135871 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 112185] [META] Highlight text color button/widget bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=112185 Bug 112185 depends on bug 135871, which changed state. Bug 135871 Summary: Highlighting no fill is not the same as no fill; there is still direct formatting present according to paragraph style https://bugs.documentfoundation.org/show_bug.cgi?id=135871 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154030] Data Entered into Forms does not print
https://bugs.documentfoundation.org/show_bug.cgi?id=154030 --- Comment #4 from QA Administrators --- Dear Shawn Burton, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154022] Libre office Draw my paragraph alignment sometimes works
https://bugs.documentfoundation.org/show_bug.cgi?id=154022 --- Comment #2 from QA Administrators --- Dear jake_mason, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 135871] Highlighting no fill is not the same as no fill; there is still direct formatting present according to paragraph style
https://bugs.documentfoundation.org/show_bug.cgi?id=135871 --- Comment #65 from QA Administrators --- Dear Telesto, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154028] Difficult to change the language of everything in the document
https://bugs.documentfoundation.org/show_bug.cgi?id=154028 --- Comment #2 from QA Administrators --- Dear Eyal Rozenberg, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 99029] [FORMATTING] Broken table across page break in ODT saved sometime with MSO
https://bugs.documentfoundation.org/show_bug.cgi?id=99029 --- Comment #14 from QA Administrators --- Dear Nicolas Mailhot, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 68327] SVG: draw:glue-points cannot be defined outside svg:viewbox
https://bugs.documentfoundation.org/show_bug.cgi?id=68327 --- Comment #18 from QA Administrators --- Dear Laurent BP, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 65321] EDITING: Excess drawing area interferes with OLE importing of drawings into other docs
https://bugs.documentfoundation.org/show_bug.cgi?id=65321 --- Comment #16 from QA Administrators --- Dear Jim Avera, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143934] FILEOPEN DOCX Images in header/footer and document body can’t be positioned partly off page (compatibilityMode 15)
https://bugs.documentfoundation.org/show_bug.cgi?id=143934 --- Comment #7 from QA Administrators --- Dear NISZ LibreOffice Team, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144288] SUM(ABOVE) is turned into SUM()
https://bugs.documentfoundation.org/show_bug.cgi?id=144288 --- Comment #3 from QA Administrators --- Dear Dave McKellar, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 138085] Copy & paste & selecting with Ctrl pressed gives duplicated paste
https://bugs.documentfoundation.org/show_bug.cgi?id=138085 --- Comment #6 from QA Administrators --- Dear klausg, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 122674] EDITING: hovering over a Comment text, changes Cursor to handpoint, when a hyperlink is under the Comment popup
https://bugs.documentfoundation.org/show_bug.cgi?id=122674 --- Comment #3 from QA Administrators --- Dear Joe, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 120955] Incorrect Fall-Over Transition that have Implemented in PowerPoint 2019
https://bugs.documentfoundation.org/show_bug.cgi?id=120955 --- Comment #11 from QA Administrators --- Dear Daniel, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147483] Writer unable to read nested floating table/ group textbox in floating table.
https://bugs.documentfoundation.org/show_bug.cgi?id=147483 Gabor Kelemen (allotropia) changed: What|Removed |Added CC||kelem...@ubuntu.com --- Comment #4 from Gabor Kelemen (allotropia) --- Created attachment 189355 --> https://bugs.documentfoundation.org/attachment.cgi?id=189355=edit The example file in Word 2016 and Writer Now this looks kinda okay, except for the image inside of the group, which is completely lost. Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: cc7d6211bc01e5ec84dbad542605d2e93dea925c CPU threads: 15; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: en-US (hu_HU); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156588] Changing language crashes LO (Not Responding)
https://bugs.documentfoundation.org/show_bug.cgi?id=156588 Peter Wilkins changed: What|Removed |Added Status|RESOLVED|UNCONFIRMED Resolution|DUPLICATE |--- Ever confirmed|1 |0 --- Comment #4 from Peter Wilkins --- It only happens for some documents and I have never been able to identify what might trigger it. I am currently on v7.5.5.2 and - so far - I have not experienced this problem recently. I believe (but not totally sure) that I last experienced this problem after upgrading to v7.5.5.2. However, it does seem to be the same bug as described in bug 155939. I will check back if the problem resurfaces. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156995] Selecting an embedded SVG is extremely slow in Linux
https://bugs.documentfoundation.org/show_bug.cgi?id=156995 --- Comment #11 from Peter Bleszynski --- I'm curious why this bug is associated with OLE. A simple curve drawn in Impress or Draw, then duplicated ~1000 times and grouped causes extreme slowness in select, de-select, Navigator pane updates, file save, etc. The slowness seems to be many times worse in Linux than in Windows and MacOS. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157095] New: Content control opens "Review fields" dialog box instead of inline editing
https://bugs.documentfoundation.org/show_bug.cgi?id=157095 Bug ID: 157095 Summary: Content control opens "Review fields" dialog box instead of inline editing Product: LibreOffice Version: Inherited From OOo Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: hoss...@libreoffice.org Created attachment 189354 --> https://bugs.documentfoundation.org/attachment.cgi?id=189354=edit DOCX: document containing a content control Description: With the recent improvements on content controls, LibreOffice no longer opens dialog boxes for editing content controls. On the other hand, it seems that the old behavior is not completely removed for all the content control types. Steps to Reproduce: 1. Open the attachment 2. Double click on the text. Actual Results: The "Review Fields" dialog box comes up. Expected Results: The editing should happen inline, just like other content controls. This is also the behavior in MS Word. Reproducible: Always User Profile Reset: No Additional Info: Reproducible with the latest LO 24.2 dev master: Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 410632ac4b8a280e0993e665ffa9cfede8326b49 CPU threads: 20; OS: Windows 10.0 Build 22621; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_DE); UI: en-US Calc: CL threaded This is the relevant part from the OOXML (document.xml): This is inside a content control -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157089] A question about lack of what seems to me a very essential feature for LibreOffice Calcs.
https://bugs.documentfoundation.org/show_bug.cgi?id=157089 --- Comment #2 from ayd...@gmail.com --- "a3:a" - cells of column "A" beginning from row "3" and below. "a1:4" - all cells of rows from "1" to "4" -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157082] Calc Round Up is Rounding Down for some values.
https://bugs.documentfoundation.org/show_bug.cgi?id=157082 --- Comment #5 from NOYB --- Created attachment 189353 --> https://bugs.documentfoundation.org/attachment.cgi?id=189353=edit LibreOffice Calc Round Up Errors (positional) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157082] Calc Round Up is Rounding Down for some values.
https://bugs.documentfoundation.org/show_bug.cgi?id=157082 NOYB changed: What|Removed |Added Resolution|DUPLICATE |--- Ever confirmed|0 |1 Status|CLOSED |REOPENED --- Comment #4 from NOYB --- Don't believe this duplicate of the 154792 issue. This issue is seems to be with the digit position of the rounding. i.e. Everything beyond the specified digit+1 is ignored (treated as all zeros; truncated prior to rounding). Formula Actual Result Expected Result Difference '=ROUNDUP(0.27632700664,1) 0.300 0.300 '=ROUNDUP(0.27632700664,2) 0.280 0.280 '=ROUNDUP(0.27632700664,3) 0.277 0.277 '=ROUNDUP(0.27632700664,4) 0.2764000 0.2764000 '=ROUNDUP(0.27632700664,5) 0.2763300 0.2763300 '=ROUNDUP(0.27632700664,6) 0.2763270 0.2763280 -0.010 '=ROUNDUP(0.27632700664,7) 0.2763270 0.2763271 -0.001 '=ROUNDUP(0.27632700664,8) 0.2763270 0.27632701000 -0.0001000 '=ROUNDUP(0.27632700664,9) 0.2763270 0.27632700100 -0.100 '=ROUNDUP(0.27632700664,10) 0.2763270 0.27632700010 -0.010 '=ROUNDUP(0.27632700664,11) 0.2763270 0.2763271 -0.001 '=ROUNDUP(0.27632700664,12) 0.27632701000 0.27632701000 '=ROUNDUP(0.27632700664,13) 0.27632700700 0.27632700700 '=ROUNDUP(0.27632700664,14) 0.27632700670 0.27632700670 '=ROUNDUP(0.27632700664,15) 0.27632700664 0.27632700664 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 83946] [META] Tracking changes issues
https://bugs.documentfoundation.org/show_bug.cgi?id=83946 Bug 83946 depends on bug 157052, which changed state. Bug 157052 Summary: When showing a changes bar for style changes, list them in a popup when hovering over it https://bugs.documentfoundation.org/show_bug.cgi?id=157052 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157052] When showing a changes bar for style changes, list them in a popup when hovering over it
https://bugs.documentfoundation.org/show_bug.cgi?id=157052 Eyal Rozenberg changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 157052] When showing a changes bar for style changes, list them in a popup when hovering over it
https://bugs.documentfoundation.org/show_bug.cgi?id=157052 Eyal Rozenberg changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 157052] When showing a changes bar for style changes, list them in a popup when hovering over it
https://bugs.documentfoundation.org/show_bug.cgi?id=157052 --- Comment #2 from Eyal Rozenberg --- Created attachment 189352 --> https://bugs.documentfoundation.org/attachment.cgi?id=189352=edit screenshot of change bar Well, here it is, but - as I was making this screenshot, I realized that we don't actually get change bars unless at least some characters get visually marked as changes. So my suggestion is invalid. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 157052] When showing a changes bar for style changes, list them in a popup when hovering over it
https://bugs.documentfoundation.org/show_bug.cgi?id=157052 --- Comment #2 from Eyal Rozenberg --- Created attachment 189352 --> https://bugs.documentfoundation.org/attachment.cgi?id=189352=edit screenshot of change bar Well, here it is, but - as I was making this screenshot, I realized that we don't actually get change bars unless at least some characters get visually marked as changes. So my suggestion is invalid. -- You are receiving this mail because: You are on the CC list for the bug.
Re: Seeking help with Windows build using v7.6.1.1
Thank you for the input. I scraped my original tree and restarted from scratch under LODE's recommended '~/lode' path. Seeing same build issues. I have attempted to adjust my Norton 360 to exclude the LO build processing, but it may still be a factor. I am NOT willing to uninstall Norton on this machine, so I am aborting this Windows build effort. May try a Linux build to see if I have better luck... On Mon, Sep 4, 2023 at 4:03 PM Noel Grandin wrote: > > I am guessing either > > (a) anti-virus tool > > or > > (b) you are using a different git client and it has munged some line > endings > >
[Libreoffice-bugs] [Bug 157094] Calc miscalculating addition subtraction multiplication division in row
https://bugs.documentfoundation.org/show_bug.cgi?id=157094 m.a.riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg --- Comment #1 from m.a.riosv --- Created attachment 189351 --> https://bugs.documentfoundation.org/attachment.cgi?id=189351=edit Sample file In Calc the result is 50, your formula needs to be adapted. =7+7/7+7*7-7 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157093] Search function(ctrl + H) no finding the words with graphic accent in Portuguese Brazilian
https://bugs.documentfoundation.org/show_bug.cgi?id=157093 m.a.riosv changed: What|Removed |Added Status|NEW |NEEDINFO CC||miguelangelrv@libreoffice.o ||rg --- Comment #1 from m.a.riosv --- Works fine for me with: Version: 7.6.2.0.0+ (X86_64) / LibreOffice Community Build ID: e79bd728e66272d14881d40167dcf57ef48571eb CPU threads: 16; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL threaded Version: 7.5.7.0.0+ (X86_64) / LibreOffice Community Build ID: b00ebfb4f0803ef276f452e17d9e99f2229ef32f CPU threads: 16; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL threaded Please test in safe mode, Menu/Help/Restart in Safe Mode and paste here the information on Menu/Help/About LibreOffce (There is an icon to copy) And please don't put your own reports as NEW, someone else must do it, after reproduce the issue. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157091] Image inserted as character rotates wrong
https://bugs.documentfoundation.org/show_bug.cgi?id=157091 m.a.riosv changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||miguelangelrv@libreoffice.o ||rg Ever confirmed|0 |1 --- Comment #2 from m.a.riosv --- Reproducible, works fine with anchor To Character Version: 7.6.1.1 (X86_64) / LibreOffice Community Build ID: c7cda394c5de06de37d8109c310df89a4d4c3a98 CPU threads: 16; OS: Windows 10.0 Build 22621; UI render: default; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL threaded Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 3c7a35dd28fbc337a23473873b3dd47392b883ae CPU threads: 16; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL threaded Jumbo -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157089] A question about lack of what seems to me a very essential feature for LibreOffice Calcs.
https://bugs.documentfoundation.org/show_bug.cgi?id=157089 m.a.riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #1 from m.a.riosv --- And what that ranges it's expected should be? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156961] Crash in: libc.so.6
https://bugs.documentfoundation.org/show_bug.cgi?id=156961 --- Comment #4 from Emanuele Forner --- The sanitized document doesn't crash LO... Hmmm, I've removed a .jpg image, some numbers and fields. Maybe I'll give it another try... -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157094] New: Calc miscalculating addition subtraction multiplication division in row
https://bugs.documentfoundation.org/show_bug.cgi?id=157094 Bug ID: 157094 Summary: Calc miscalculating addition subtraction multiplication division in row Product: LibreOffice Version: 7.3.7.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: sziraki.ta...@gmail.com Description: Calc calculates this row of math operations incorrectly with or without brackets. 7+7:7+7×7-7= In the Calc the result is 49, but the correct result is 50. Actual Results: Just try it! Expected Results: The same as before. Reproducible: Always User Profile Reset: No Additional Info: [Information automatically included from LibreOffice] Locale: hu Module: SpreadsheetDocument [Information guessed from browser] OS: Linux (All) OS is 64bit: yes -- You are receiving this mail because: You are the assignee for the bug.
Re: Seeking help with Windows build using v7.6.1.1
I am guessing either (a) anti-virus tool or (b) you are using a different git client and it has munged some line endings
[Libreoffice-bugs] [Bug 122424] FILEOPEN RTF: In a specific document space character after table moves to the first cell of next row
https://bugs.documentfoundation.org/show_bug.cgi?id=122424 --- Comment #11 from Michaela --- Still repro with: Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: e46e663cc350d89e4997095466d675b875eb2e04 CPU threads: 12; OS: Windows 10.0 Build 22621; UI render: Skia/Vulkan; VCL: win -- You are receiving this mail because: You are the assignee for the bug.
Re: Adding an implemented UNO interface
On Mon, 4 Sept 2023 at 20:43, Lionel Élie Mamane wrote: > becomes an ambiguous base of class bar, as it is derived from twice > :-| > > How do we solve that? > > using using
[Libreoffice-bugs] [Bug 156216] Writer crashes in ~1 million lines of text with line numbering enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=156216 --- Comment #4 from Hossein --- Created attachment 189350 --> https://bugs.documentfoundation.org/attachment.cgi?id=189350=edit Loading 2 million lines in MS Word For a comparison, loading the above 2 million lines file lead to this error message in MS Word: "You have exceeded the maximum number of pages supported by Microsoft Word, or this document may be damaged. Microsoft Word will save the document, but to repair the document, use Open and Repair command (click Open, then click the arrow next to the Open button)." Then it goes into the "Draft" mode, and remains there, and not going back to "Print layout". Number of pages is visible when you decide to print, and it is bigger that 22000. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156216] Writer crashes in ~1 million lines of text with line numbering enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=156216 --- Comment #3 from Hossein --- (In reply to Telesto from comment #2) > Is this a Skia Vulkan only problem? It would seem so based on the backtrace It seems so. I've tested with 2 million lines and LibreOffice didn't crash: Version: 7.6.0.3 (X86_64) / LibreOffice Community Build ID: 69edd8b8ebc41d00b4de3915dc82f8f0fc3b6265 CPU threads: 20; OS: Windows 10.0 Build 22621; UI render: default; VCL: win Locale: en-US (en_DE); UI: en-GB Calc: CL threaded I used a file containing 1-2 million, One number in each line. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 101912] [META] Accessibility (a11y) bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=101912 Bug 101912 depends on bug 157088, which changed state. Bug 157088 Summary: qt6: Crash on exit after using font color toolbox item with Orca running https://bugs.documentfoundation.org/show_bug.cgi?id=157088 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: accessibility/inc accessibility/source
accessibility/inc/standard/vclxaccessiblelist.hxx|7 +-
accessibility/source/standard/vclxaccessiblelist.cxx | 53 +--
2 files changed, 30 insertions(+), 30 deletions(-)
New commits:
commit 410632ac4b8a280e0993e665ffa9cfede8326b49
Author: Michael Weghorn
AuthorDate: Mon Sep 4 19:09:18 2023 +0200
Commit: Michael Weghorn
CommitDate: Mon Sep 4 21:43:22 2023 +0200
a11y: Hold list items by rtl::Reference
Use a vector of `rtl::Reference`
for the children instead of a vector of
`css::uno::Reference`
and casting in various places.
Change-Id: I1d0e72a7c844a685d762069002d747cf5e7d02dc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156525
Tested-by: Jenkins
Reviewed-by: Michael Weghorn
diff --git a/accessibility/inc/standard/vclxaccessiblelist.hxx
b/accessibility/inc/standard/vclxaccessiblelist.hxx
index eb1cdc6f9d53..f668e75d7cda 100644
--- a/accessibility/inc/standard/vclxaccessiblelist.hxx
+++ b/accessibility/inc/standard/vclxaccessiblelist.hxx
@@ -25,6 +25,8 @@
#include
#include
+class VCLXAccessibleListItem;
+
namespace accessibility
{
class IComboListBoxHelper;
@@ -114,7 +116,7 @@ public:
private:
BoxType m_aBoxType;
std::unique_ptr<::accessibility::IComboListBoxHelper> m_pListBoxHelper;
-std::vector>
m_aAccessibleChildren;
+std::vector> m_aAccessibleChildren;
sal_Int32 m_nVisibleLineCount;
/// Index in parent. This is settable from the outside.
sal_Int32 m_nIndexInParent;
@@ -144,8 +146,7 @@ private:
/** Create the specified child and insert it into the list of children.
Sets the child's states.
*/
-css::uno::Reference< css::accessibility::XAccessible >
-CreateChild (sal_Int32 i);
+rtl::Reference CreateChild (sal_Int32 i);
/** Call this method when the item list has been changed, i.e. items
have been deleted or inserted.
diff --git a/accessibility/source/standard/vclxaccessiblelist.cxx
b/accessibility/source/standard/vclxaccessiblelist.cxx
index 14f6cddc504b..67061aac3ab0 100644
--- a/accessibility/source/standard/vclxaccessiblelist.cxx
+++ b/accessibility/source/standard/vclxaccessiblelist.cxx
@@ -108,8 +108,11 @@ void SAL_CALL VCLXAccessibleList::disposing()
VCLXAccessibleComponent::disposing();
// Dispose all items in the list.
-for (Reference& rxChild : m_aAccessibleChildren)
-comphelper::disposeComponent(rxChild);
+for (rtl::Reference& rxChild :
m_aAccessibleChildren)
+{
+if (rxChild.is())
+rxChild->dispose();
+}
m_aAccessibleChildren.clear();
@@ -159,18 +162,17 @@ void VCLXAccessibleList::notifyVisibleStates(bool
_bSetNew )
// adjust the index inside the VCLXAccessibleListItem
for ( ; aIter != m_aAccessibleChildren.end(); )
{
-Reference xChild = *aIter;
+rtl::Reference xChild = *aIter;
if (!xChild.is())
{
aIter = m_aAccessibleChildren.erase(aIter);
}
else
{
-VCLXAccessibleListItem* pItem =
static_cast(xChild.get());
const sal_Int32 nTopEntry = m_pListBoxHelper ?
m_pListBoxHelper->GetTopEntry() : 0;
const sal_Int32 nPos = static_cast(aIter -
m_aAccessibleChildren.begin());
bool bVisible = ( nPos>=nTopEntry && nPos<( nTopEntry +
m_nVisibleLineCount ) );
-pItem->SetVisible( m_bVisible && bVisible );
+xChild->SetVisible(m_bVisible && bVisible);
++aIter;
}
@@ -209,25 +211,24 @@ void VCLXAccessibleList::UpdateSelection_Impl_Acc(bool
bHasDropDownList)
{
sal_Int32 i=0;
m_nCurSelectedPos = LISTBOX_ENTRY_NOTFOUND;
-for (const Reference& rxChild : m_aAccessibleChildren)
+for (const rtl::Reference& rxChild :
m_aAccessibleChildren)
{
if (rxChild.is())
{
-VCLXAccessibleListItem* pItem = static_cast<
VCLXAccessibleListItem* >(rxChild.get() );
// Retrieve the item's index from the list entry.
bool bNowSelected = m_pListBoxHelper->IsEntryPosSelected
(i);
if (bNowSelected)
m_nCurSelectedPos = i;
-if ( bNowSelected && !pItem->IsSelected() )
+if (bNowSelected && !rxChild->IsSelected())
{
xNewAcc = rxChild;
aNewValue <<= xNewAcc;
}
-else if ( pItem->IsSelected() )
+else if (rxChild->IsSelected())
m_nLastSelectedPos = i;
-pItem->SetSelected( bNowSelected );
+rxChild->SetSelected(bNowSelected);
}
else
{ // it could happen that a child was not created before
@@ -332,7
[Libreoffice-bugs] [Bug 156593] FILEOPEN PPTX: image shown in full instead of cropped
https://bugs.documentfoundation.org/show_bug.cgi?id=156593 Gabor Kelemen (allotropia) changed: What|Removed |Added Attachment #189348|0 |1 is obsolete|| --- Comment #7 from Gabor Kelemen (allotropia) --- Created attachment 189349 --> https://bugs.documentfoundation.org/attachment.cgi?id=189349=edit The minimized example file in PP 2016 and Impress eh, correct file now :) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: accessibility/inc accessibility/source
accessibility/inc/standard/vclxaccessiblelist.hxx|5 +
accessibility/source/standard/vclxaccessiblelist.cxx |2 +-
2 files changed, 2 insertions(+), 5 deletions(-)
New commits:
commit 307b9af2420d649b2e50817e38f8cb63687abf8b
Author: Michael Weghorn
AuthorDate: Mon Sep 4 17:29:57 2023 +0200
Commit: Michael Weghorn
CommitDate: Mon Sep 4 21:41:40 2023 +0200
a11y: Drop ListItems typdef
Change-Id: Ie8d62b769c44ab74a21fadd9ab395fe0f908ee76
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156524
Tested-by: Jenkins
Reviewed-by: Michael Weghorn
diff --git a/accessibility/inc/standard/vclxaccessiblelist.hxx
b/accessibility/inc/standard/vclxaccessiblelist.hxx
index 57d43d2c11de..eb1cdc6f9d53 100644
--- a/accessibility/inc/standard/vclxaccessiblelist.hxx
+++ b/accessibility/inc/standard/vclxaccessiblelist.hxx
@@ -25,9 +25,6 @@
#include
#include
-typedef std::vector>
-ListItems;
-
namespace accessibility
{
class IComboListBoxHelper;
@@ -117,7 +114,7 @@ public:
private:
BoxType m_aBoxType;
std::unique_ptr<::accessibility::IComboListBoxHelper> m_pListBoxHelper;
-ListItems m_aAccessibleChildren;
+std::vector>
m_aAccessibleChildren;
sal_Int32 m_nVisibleLineCount;
/// Index in parent. This is settable from the outside.
sal_Int32 m_nIndexInParent;
diff --git a/accessibility/source/standard/vclxaccessiblelist.cxx
b/accessibility/source/standard/vclxaccessiblelist.cxx
index 101c5815c0ac..14f6cddc504b 100644
--- a/accessibility/source/standard/vclxaccessiblelist.cxx
+++ b/accessibility/source/standard/vclxaccessiblelist.cxx
@@ -154,7 +154,7 @@ void VCLXAccessibleList::notifyVisibleStates(bool _bSetNew )
(_bSetNew ? aNewValue : aOldValue ) <<= AccessibleStateType::SHOWING;
NotifyAccessibleEvent( AccessibleEventId::STATE_CHANGED, aOldValue,
aNewValue );
-ListItems::iterator aIter = m_aAccessibleChildren.begin();
+auto aIter = m_aAccessibleChildren.begin();
UpdateVisibleLineCount();
// adjust the index inside the VCLXAccessibleListItem
for ( ; aIter != m_aAccessibleChildren.end(); )
[Libreoffice-commits] core.git: accessibility/source
accessibility/source/standard/vclxaccessiblelist.cxx |3 +++ 1 file changed, 3 insertions(+) New commits: commit 51de048ae97cbd371457dbc07120e30db9ee4187 Author: Michael Weghorn AuthorDate: Mon Sep 4 17:19:03 2023 +0200 Commit: Michael Weghorn CommitDate: Mon Sep 4 21:41:21 2023 +0200 tdf#157088 a11y: Dispose list items with list Don't only clear, but also dispose the list items when the `VCLXAccessibleList` gets disposed. Interestingly, there was already a comment saying // Dispose all items in the list. , but that wasn't done so far... Fixes a crash on exit with the below backtrace after using the font color toolbox item with the qt6 VCL plugin and Orca running: 1 __pthread_kill_implementation pthread_kill.c 44 0x7fe2a2ea80fc 2 __pthread_kill_internalpthread_kill.c 78 0x7fe2a2ea815f 3 __GI_raise raise.c 26 0x7fe2a2e5a472 4 __GI_abort abort.c 79 0x7fe2a2e444b2 5 __assert_fail_base assert.c92 0x7fe2a2e443d5 6 __assert_fail assert.c101 0x7fe2a2e533a2 7 (anonymous namespace)::implLookupClient accessibleeventnotifier.cxx 140 0x7fe2a21138a4 8 comphelper::AccessibleEventNotifier::revokeClientNotifyDisposing accessibleeventnotifier.cxx 185 0x7fe2a2113bb8 9 VCLXAccessibleListItem::disposing vclxaccessiblelistitem.cxx 164 0x7fe26870cb58 10 cppu::WeakAggComponentImplHelperBase::dispose implbase.cxx230 0x7fe2a1c755e3 11 cppu::WeakAggComponentImplHelperBase::release implbase.cxx204 0x7fe2a1c75312 12 cppu::WeakAggComponentImplHelper6::release compbase6.hxx 142 0x7fe26870fc0c 13 com::sun::star::uno::Reference::~Reference Reference.hxx 114 0x7fe28f2428a7 14 QtAccessibleWidget::~QtAccessibleWidgetQtAccessibleWidget.hxx 39 0x7fe28f262cf9 15 QtAccessibleWidget::~QtAccessibleWidgetQtAccessibleWidget.hxx 39 0x7fe28f262dd0 16 QAccessibleCache::deleteInterface qaccessiblecache.cpp173 0x7fe28e0c8e4b 17 QAccessibleCache::~QAccessibleCacheqaccessiblecache.cpp31 0x7fe28e0c845c 18 QAccessibleCache::~QAccessibleCacheqaccessiblecache.cpp32 0x7fe28e0c84e2 19 cleanupAccessibleCache qaccessiblecache.cpp24 0x7fe28e0c83c8 20 qt_call_post_routines qcoreapplication.cpp327 0x7fe28e9a4593 21 QApplication::~QApplicationqapplication.cpp663 0x7fe28cf9dff6 22 QApplication::~QApplicationqapplication.cpp717 0x7fe28cf9e2f4 23 std::default_delete::operator() unique_ptr.h99 0x7fe28f2cf3ae 24 std::__uniq_ptr_impl>::reset unique_ptr.h211 0x7fe28f2cf7f6 25 std::unique_ptr>::resetunique_ptr.h509 0x7fe28f2cd72d 26 QtInstance::~QtInstanceQtInstance.cxx 273 0x7fe28f2c614f 27 QtInstance::~QtInstanceQtInstance.cxx 274 0x7fe28f2c6226 28 DestroySalInstance salplug.cxx 389 0x7fe299a62611 29 DeInitVCL svmain.cxx 600 0x7fe299b41226 30 ImplSVMain svmain.cxx 229 0x7fe299b3f9f7 31 SVMain svmain.cxx 236 0x7fe299b3fa53 32 soffice_main sofficemain.cxx 94 0x7fe2a30a1b5d 33 sal_main main.c 51 0x55c86565c9d4 34 main main.c 49 0x55c86565c9ba Change-Id: I42ddcf5501ddfb363aeae10a86f1c38251e6793b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156522 Tested-by: Jenkins Reviewed-by: Michael Weghorn diff --git a/accessibility/source/standard/vclxaccessiblelist.cxx b/accessibility/source/standard/vclxaccessiblelist.cxx index 57f9b1eabcb3..101c5815c0ac 100644 --- a/accessibility/source/standard/vclxaccessiblelist.cxx +++ b/accessibility/source/standard/vclxaccessiblelist.cxx @@ -27,6 +27,7 @@ #include #include #include +#include #include #include #include @@ -107,6 +108,8 @@ void SAL_CALL VCLXAccessibleList::disposing() VCLXAccessibleComponent::disposing(); // Dispose all items in the list. +for (Reference& rxChild : m_aAccessibleChildren) +comphelper::disposeComponent(rxChild); m_aAccessibleChildren.clear();
[Libreoffice-commits] core.git: accessibility/inc accessibility/source
accessibility/inc/standard/vclxaccessiblelist.hxx|2 -
accessibility/source/standard/vclxaccessiblelist.cxx | 25 +--
2 files changed, 13 insertions(+), 14 deletions(-)
New commits:
commit bfa9d01920e7e042a83627d7fa4e78c70bc7ece5
Author: Michael Weghorn
AuthorDate: Mon Sep 4 17:03:47 2023 +0200
Commit: Michael Weghorn
CommitDate: Mon Sep 4 21:41:00 2023 +0200
tdf#157088 a11y: No need to use WeakReference for list children
`VCLXAccessibleList` is the owner of the
`VCLXAccessibleListItem`s held in that vector,
so I see no reason to hold them by weak reference,
which according to the doc in
`udkapi/com/sun/star/uno/XWeak.idl` is to avoid
affecting the lifetime of the objects:
> The sense of weak references is to hold a reference to an object
> without affecting the lifetime of the object. That means that a weak
> reference may become invalid, at any time, if the referenced object dies.
>
Quite the contrary, it is actually responsible for the
lifecycle of the list item a11y objects and should dispose
them when itself gets disposed, which will be added
in a subsequent commit.
Change-Id: I57fe3367f1199cd0c24f006f6e25a1e9c930c154
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156521
Tested-by: Jenkins
Reviewed-by: Michael Weghorn
diff --git a/accessibility/inc/standard/vclxaccessiblelist.hxx
b/accessibility/inc/standard/vclxaccessiblelist.hxx
index bab8b649fa07..57d43d2c11de 100644
--- a/accessibility/inc/standard/vclxaccessiblelist.hxx
+++ b/accessibility/inc/standard/vclxaccessiblelist.hxx
@@ -25,7 +25,7 @@
#include
#include
-typedef std::vector< css::uno::WeakReference< css::accessibility::XAccessible
> >
+typedef std::vector>
ListItems;
namespace accessibility
diff --git a/accessibility/source/standard/vclxaccessiblelist.cxx
b/accessibility/source/standard/vclxaccessiblelist.cxx
index c38240e3b4e7..57f9b1eabcb3 100644
--- a/accessibility/source/standard/vclxaccessiblelist.cxx
+++ b/accessibility/source/standard/vclxaccessiblelist.cxx
@@ -107,6 +107,7 @@ void SAL_CALL VCLXAccessibleList::disposing()
VCLXAccessibleComponent::disposing();
// Dispose all items in the list.
+
m_aAccessibleChildren.clear();
m_pListBoxHelper.reset();
@@ -155,14 +156,14 @@ void VCLXAccessibleList::notifyVisibleStates(bool
_bSetNew )
// adjust the index inside the VCLXAccessibleListItem
for ( ; aIter != m_aAccessibleChildren.end(); )
{
-Reference< XAccessible > xHold = *aIter;
-if (!xHold.is())
+Reference xChild = *aIter;
+if (!xChild.is())
{
aIter = m_aAccessibleChildren.erase(aIter);
}
else
{
-VCLXAccessibleListItem* pItem =
static_cast(xHold.get());
+VCLXAccessibleListItem* pItem =
static_cast(xChild.get());
const sal_Int32 nTopEntry = m_pListBoxHelper ?
m_pListBoxHelper->GetTopEntry() : 0;
const sal_Int32 nPos = static_cast(aIter -
m_aAccessibleChildren.begin());
bool bVisible = ( nPos>=nTopEntry && nPos<( nTopEntry +
m_nVisibleLineCount ) );
@@ -205,12 +206,11 @@ void VCLXAccessibleList::UpdateSelection_Impl_Acc(bool
bHasDropDownList)
{
sal_Int32 i=0;
m_nCurSelectedPos = LISTBOX_ENTRY_NOTFOUND;
-for ( const auto& rChild : m_aAccessibleChildren )
+for (const Reference& rxChild : m_aAccessibleChildren)
{
-Reference< XAccessible > xHold = rChild;
-if ( xHold.is() )
+if (rxChild.is())
{
-VCLXAccessibleListItem* pItem = static_cast<
VCLXAccessibleListItem* >( xHold.get() );
+VCLXAccessibleListItem* pItem = static_cast<
VCLXAccessibleListItem* >(rxChild.get() );
// Retrieve the item's index from the list entry.
bool bNowSelected = m_pListBoxHelper->IsEntryPosSelected
(i);
if (bNowSelected)
@@ -218,7 +218,7 @@ void VCLXAccessibleList::UpdateSelection_Impl_Acc(bool
bHasDropDownList)
if ( bNowSelected && !pItem->IsSelected() )
{
-xNewAcc = rChild;
+xNewAcc = rxChild;
aNewValue <<= xNewAcc;
}
else if ( pItem->IsSelected() )
@@ -663,12 +663,11 @@ void VCLXAccessibleList::UpdateSelection_Impl(sal_Int32)
{
sal_Int32 i=0;
m_nCurSelectedPos = LISTBOX_ENTRY_NOTFOUND;
-for ( const auto& rChild : m_aAccessibleChildren )
+for (const Reference& rxChild : m_aAccessibleChildren
)
{
-Reference< XAccessible > xHold = rChild;
-if ( xHold.is() )
+if (rxChild.is())
{
-
[Libreoffice-bugs] [Bug 156593] FILEOPEN PPTX: image shown in full instead of cropped
https://bugs.documentfoundation.org/show_bug.cgi?id=156593 --- Comment #6 from Gabor Kelemen (allotropia) --- Created attachment 189348 --> https://bugs.documentfoundation.org/attachment.cgi?id=189348=edit The minimized example file in PP 2016 and Impress -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156593] FILEOPEN PPTX: image shown in full instead of cropped
https://bugs.documentfoundation.org/show_bug.cgi?id=156593 --- Comment #5 from Gabor Kelemen (allotropia) --- Created attachment 189347 --> https://bugs.documentfoundation.org/attachment.cgi?id=189347=edit Minimized example file, only with 2 cropped tiff images Interestingly this file minimized file produces the error, but changing the crop area somewhat (to be larger) makes the image partially visible, see the Picture 2. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151142] UI: Font Preview in the Styles sidebar is not working for Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=151142 --- Comment #4 from LeroyG --- Same with: Version: 7.6.0.2 (x86) / LibreOffice Community Build ID: 41d6f628ba3f046f16b5fa9fa8db8d4c2ab3b582 CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: Skia/Raster; VCL: win Locale: es-MX (es_MX); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: 2 commits - filter/source include/sfx2 include/svl include/vcl include/xmloff offapi/com offapi/UnoApi_offapi.mk sfx2/source sfx2/uiconfig vcl/inc vcl/source xmloff/sou
filter/source/pdf/pdfexport.cxx | 12
include/sfx2/dinfdlg.hxx | 32 ++
include/svl/memberid.h| 14
include/vcl/pdfwriter.hxx |8
include/xmloff/xmltoken.hxx |4
offapi/UnoApi_offapi.mk |1
offapi/com/sun/star/document/XDocumentProperties2.idl | 50 +++
sfx2/source/dialog/dinfdlg.cxx| 118 +++-
sfx2/source/doc/SfxDocumentMetaData.cxx | 135 +
sfx2/uiconfig/ui/descriptioninfopage.ui | 260 +-
vcl/inc/pdf/XmpMetadata.hxx |9
vcl/source/gdi/pdfwriter_impl.cxx | 28 +
vcl/source/pdf/XmpMetadata.cxx| 84 +
xmloff/source/core/xmltoken.cxx |4
xmloff/source/token/tokens.txt|4
15 files changed, 748 insertions(+), 15 deletions(-)
New commits:
commit b273a0c1527193e21fbd0ccbc23853205f90056b
Author: Sarper Akdemir
AuthorDate: Thu Aug 31 19:49:42 2023 +0300
Commit: Sarper Akdemir
CommitDate: Mon Sep 4 20:54:25 2023 +0200
tdf#138792: PDF export: export metadata dc:format
Export application/pdf MIMEType in dc:format
Change-Id: I7cb658c869898df3a9436937329b4082843338bc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156507
Tested-by: Jenkins
Reviewed-by: Sarper Akdemir
diff --git a/vcl/source/pdf/XmpMetadata.cxx b/vcl/source/pdf/XmpMetadata.cxx
index 7496ab26e3f5..cb88016365b3 100644
--- a/vcl/source/pdf/XmpMetadata.cxx
+++ b/vcl/source/pdf/XmpMetadata.cxx
@@ -73,6 +73,11 @@ void XmpMetadata::write()
aXmlWriter.startElement("rdf:Description");
aXmlWriter.attribute("rdf:about", OString(""));
aXmlWriter.attribute("xmlns:dc",
OString("http://purl.org/dc/elements/1.1/;));
+
+aXmlWriter.startElement("dc:format");
+aXmlWriter.content("application/pdf");
+aXmlWriter.endElement();
+
if (!msTitle.isEmpty())
{
// this is according to PDF/A-1, technical corrigendum 1
(2007-04-01)
commit 0deea02b1da1001fa497dc5afa5e43207af491d5
Author: Sarper Akdemir
AuthorDate: Sat Aug 19 17:18:50 2023 +0300
Commit: Sarper Akdemir
CommitDate: Mon Sep 4 20:54:19 2023 +0200
tdf#138792: PDF export: add batch of dublin core attributes
Adds support for exporting, editing in the UI and storage in
ODF for the dublin core attributes listed below.
Contributor (http://purl.org/dc/elements/1.1/contributor)
Coverage (http://purl.org/dc/elements/1.1/coverage)
Identifier (http://purl.org/dc/elements/1.1/identifier)
Publisher (http://purl.org/dc/elements/1.1/publisher)
Relation (http://purl.org/dc/elements/1.1/relation)
Rights (http://purl.org/dc/elements/1.1/rights)
Source (http://purl.org/dc/elements/1.1/source)
Type (http://purl.org/dc/elements/1.1/type)
Introduces XDocumentProperties2 to extend XDocumentProperties interface.
Change-Id: Ie2e0b1fbbbd00b66aef477ba1bf4e4f61c03a3b3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156330
Tested-by: Jenkins
Reviewed-by: Sarper Akdemir
diff --git a/filter/source/pdf/pdfexport.cxx b/filter/source/pdf/pdfexport.cxx
index 9b6523448dfb..a9a717a56cc5 100644
--- a/filter/source/pdf/pdfexport.cxx
+++ b/filter/source/pdf/pdfexport.cxx
@@ -49,7 +49,7 @@
#include
#include
#include
-#include
+#include
#include
#include
#include
@@ -470,7 +470,7 @@ bool PDFExport::Export( const OUString& rFile, const
Sequence< PropertyValue >&
Reference< document::XDocumentPropertiesSupplier >
xDocumentPropsSupplier( mxSrcDoc, UNO_QUERY );
if ( xDocumentPropsSupplier.is() )
{
-Reference< document::XDocumentProperties > xDocumentProps(
xDocumentPropsSupplier->getDocumentProperties() );
+Reference< document::XDocumentProperties2 > xDocumentProps(
xDocumentPropsSupplier->getDocumentProperties(), UNO_QUERY );
if ( xDocumentProps.is() )
{
aContext.DocumentInfo.Title = xDocumentProps->getTitle();
@@ -481,6 +481,14 @@ bool PDFExport::Export( const OUString& rFile, const
Sequence< PropertyValue >&
= xDocumentProps->getEditingCycles() < 1
? xDocumentProps->getCreationDate()
: xDocumentProps->getModificationDate();
+aContext.DocumentInfo.Contributor =
xDocumentProps->getContributor();
+aContext.DocumentInfo.Coverage =
xDocumentProps->getCoverage();
+aContext.DocumentInfo.Identifier =
xDocumentProps->getIdentifier();
+aContext.DocumentInfo.Publisher =
[Libreoffice-commits] core.git: vcl/inc vcl/source
vcl/inc/pdf/XmpMetadata.hxx |1 +
vcl/source/gdi/pdfwriter_impl.cxx | 32 +---
vcl/source/pdf/XmpMetadata.cxx|8 +++-
3 files changed, 29 insertions(+), 12 deletions(-)
New commits:
commit a45f72b8122d3bb4c0d5ac4252cf7e5a25d52291
Author: Sarper Akdemir
AuthorDate: Thu Aug 31 02:59:51 2023 +0300
Commit: Sarper Akdemir
CommitDate: Mon Sep 4 20:53:40 2023 +0200
tdf#138792: PDF export: export metadata pdf:PDFVersion
Adds export of pdf:PDFVersion metadata.
Change-Id: Ic4c3eec3672839d0d125b64dfca6149912cd2458
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156329
Tested-by: Jenkins
Reviewed-by: Sarper Akdemir
diff --git a/vcl/inc/pdf/XmpMetadata.hxx b/vcl/inc/pdf/XmpMetadata.hxx
index d94d6e690c3c..a144266497cf 100644
--- a/vcl/inc/pdf/XmpMetadata.hxx
+++ b/vcl/inc/pdf/XmpMetadata.hxx
@@ -27,6 +27,7 @@ public:
OString msAuthor;
OString msSubject;
OString msProducer;
+OString msPDFVersion;
OString msKeywords;
OString m_sCreatorTool;
OString m_sCreateDate;
diff --git a/vcl/source/gdi/pdfwriter_impl.cxx
b/vcl/source/gdi/pdfwriter_impl.cxx
index def3d4ee3ba5..00b59830f048 100644
--- a/vcl/source/gdi/pdfwriter_impl.cxx
+++ b/vcl/source/gdi/pdfwriter_impl.cxx
@@ -623,6 +623,25 @@ void appendPdfTimeDate(OStringBuffer & rBuffer,
}
}
+const char* getPDFVersionStr(PDFWriter::PDFVersion ePDFVersion)
+{
+switch (ePDFVersion)
+{
+case PDFWriter::PDFVersion::PDF_A_1:
+case PDFWriter::PDFVersion::PDF_1_4:
+return "1.4";
+case PDFWriter::PDFVersion::PDF_1_5:
+return "1.5";
+case PDFWriter::PDFVersion::PDF_1_6:
+return "1.6";
+default:
+case PDFWriter::PDFVersion::PDF_A_2:
+case PDFWriter::PDFVersion::PDF_A_3:
+case PDFWriter::PDFVersion::PDF_1_7:
+return "1.7";
+}
+}
+
} // end namespace
PDFPage::PDFPage( PDFWriterImpl* pWriter, double nPageWidth, double
nPageHeight, PDFWriter::Orientation eOrientation )
@@ -1295,17 +1314,7 @@ PDFWriterImpl::PDFWriterImpl( const
PDFWriter::PDFWriterContext& rContext,
// write header
OStringBuffer aBuffer( 20 );
aBuffer.append( "%PDF-" );
-switch( m_aContext.Version )
-{
-case PDFWriter::PDFVersion::PDF_A_1:
-case PDFWriter::PDFVersion::PDF_1_4: aBuffer.append( "1.4" );break;
-case PDFWriter::PDFVersion::PDF_1_5: aBuffer.append( "1.5" );break;
-case PDFWriter::PDFVersion::PDF_1_6: aBuffer.append( "1.6" );break;
-default:
-case PDFWriter::PDFVersion::PDF_A_2:
-case PDFWriter::PDFVersion::PDF_A_3:
-case PDFWriter::PDFVersion::PDF_1_7: aBuffer.append( "1.7" );break;
-}
+aBuffer.append(getPDFVersionStr(m_aContext.Version));
// append something binary as comment (suggested in PDF Reference)
aBuffer.append( "\n%\303\244\303\274\303\266\303\237\n" );
if( !writeBuffer( aBuffer ) )
@@ -5952,6 +5961,7 @@ sal_Int32 PDFWriterImpl::emitDocumentMetadata()
lcl_assignMeta(m_aContext.DocumentInfo.Author, aMetadata.msAuthor);
lcl_assignMeta(m_aContext.DocumentInfo.Subject, aMetadata.msSubject);
lcl_assignMeta(m_aContext.DocumentInfo.Producer, aMetadata.msProducer);
+aMetadata.msPDFVersion = getPDFVersionStr(m_aContext.Version);
lcl_assignMeta(m_aContext.DocumentInfo.Keywords, aMetadata.msKeywords);
lcl_assignMeta(m_aContext.DocumentInfo.Creator,
aMetadata.m_sCreatorTool);
aMetadata.m_sCreateDate = m_aCreationMetaDateString;
diff --git a/vcl/source/pdf/XmpMetadata.cxx b/vcl/source/pdf/XmpMetadata.cxx
index 7b0df42dbb92..6dae3b86ebc1 100644
--- a/vcl/source/pdf/XmpMetadata.cxx
+++ b/vcl/source/pdf/XmpMetadata.cxx
@@ -122,7 +122,7 @@ void XmpMetadata::write()
}
// PDF properties
-if (!msProducer.isEmpty() || !msKeywords.isEmpty())
+if (!msProducer.isEmpty() || !msKeywords.isEmpty() ||
!msPDFVersion.isEmpty())
{
aXmlWriter.startElement("rdf:Description");
aXmlWriter.attribute("rdf:about", OString(""));
@@ -139,6 +139,12 @@ void XmpMetadata::write()
aXmlWriter.content(msKeywords);
aXmlWriter.endElement();
}
+if (!msPDFVersion.isEmpty())
+{
+aXmlWriter.startElement("pdf:PDFVersion");
+aXmlWriter.content(msPDFVersion);
+aXmlWriter.endElement();
+}
aXmlWriter.endElement();
}
[Libreoffice-commits] core.git: 2 commits - filter/source include/vcl vcl/inc vcl/source
filter/source/pdf/pdfexport.cxx |4
include/vcl/pdfwriter.hxx |1 +
vcl/inc/pdf/pdfwriter_impl.hxx|1 +
vcl/source/gdi/pdfwriter_impl.cxx | 12 ++--
vcl/source/pdf/XmpMetadata.cxx|8
5 files changed, 24 insertions(+), 2 deletions(-)
New commits:
commit 7803c5749365c6dca6583708c14d6229c9659572
Author: Sarper Akdemir
AuthorDate: Thu Aug 10 08:49:24 2023 +0300
Commit: Sarper Akdemir
CommitDate: Mon Sep 4 20:53:27 2023 +0200
tdf#138792: PDF export: export metadata xmp:ModifyDate, xmp:MetadataDate
Export metadata xmp:ModifyDate & xmp:MetadataDate - populate
both with the same information as CreateDate.
Change-Id: I391a72cbe4e7d1ebba5c04c402a68534bbeb4743
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156328
Tested-by: Jenkins
Reviewed-by: Sarper Akdemir
diff --git a/vcl/source/pdf/XmpMetadata.cxx b/vcl/source/pdf/XmpMetadata.cxx
index d4c58c23348b..7b0df42dbb92 100644
--- a/vcl/source/pdf/XmpMetadata.cxx
+++ b/vcl/source/pdf/XmpMetadata.cxx
@@ -155,8 +155,16 @@ void XmpMetadata::write()
aXmlWriter.startElement("xmp:CreateDate");
aXmlWriter.content(m_sCreateDate);
aXmlWriter.endElement();
+
+aXmlWriter.startElement("xmp:ModifyDate");
+aXmlWriter.content(m_sCreateDate);
+aXmlWriter.endElement();
+
+aXmlWriter.startElement("xmp:MetadataDate");
+aXmlWriter.content(m_sCreateDate);
aXmlWriter.endElement();
+aXmlWriter.endElement();
aXmlWriter.endElement();
aXmlWriter.endElement();
aXmlWriter.endDocument();
commit 07ac61f2c67020ad2941462ea7081f06495bcb92
Author: Sarper Akdemir
AuthorDate: Mon Aug 28 11:16:34 2023 +0300
Commit: Sarper Akdemir
CommitDate: Mon Sep 4 20:53:17 2023 +0200
tdf#138792: PDF export: fix date of xmp:CreateDate
for pdf export xmp:CreateDate should be the modification
date instead of the creation date.
Change-Id: I2a86f30cb528cb2bd5e0f9e7c9a8a8b8d2993f50
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156327
Tested-by: Jenkins
Reviewed-by: Sarper Akdemir
diff --git a/filter/source/pdf/pdfexport.cxx b/filter/source/pdf/pdfexport.cxx
index 8199132b66b4..9b6523448dfb 100644
--- a/filter/source/pdf/pdfexport.cxx
+++ b/filter/source/pdf/pdfexport.cxx
@@ -477,6 +477,10 @@ bool PDFExport::Export( const OUString& rFile, const
Sequence< PropertyValue >&
aContext.DocumentInfo.Author = xDocumentProps->getAuthor();
aContext.DocumentInfo.Subject =
xDocumentProps->getSubject();
aContext.DocumentInfo.Keywords =
::comphelper::string::convertCommaSeparated(xDocumentProps->getKeywords());
+aContext.DocumentInfo.ModificationDate
+= xDocumentProps->getEditingCycles() < 1
+ ? xDocumentProps->getCreationDate()
+ : xDocumentProps->getModificationDate();
}
}
diff --git a/include/vcl/pdfwriter.hxx b/include/vcl/pdfwriter.hxx
index 796c1f03cd9b..2b62b26b6ef4 100644
--- a/include/vcl/pdfwriter.hxx
+++ b/include/vcl/pdfwriter.hxx
@@ -559,6 +559,7 @@ The following structure describes the permissions used in
PDF security
OUString Author; // document author
OUString Subject;// subject
OUString Keywords; // keywords
+css::util::DateTime ModificationDate;
OUString Creator;// application that created the
original document
OUString Producer; // OpenOffice
};
diff --git a/vcl/inc/pdf/pdfwriter_impl.hxx b/vcl/inc/pdf/pdfwriter_impl.hxx
index 75f613060c04..b9eaf4686b95 100644
--- a/vcl/inc/pdf/pdfwriter_impl.hxx
+++ b/vcl/inc/pdf/pdfwriter_impl.hxx
@@ -1115,6 +1115,7 @@ i12626
static void computeDocumentIdentifier( std::vector< sal_uInt8 >&
o_rIdentifier,
const vcl::PDFWriter::PDFDocInfo&
i_rDocInfo,
const OString& i_rCString1,
+ const css::util::DateTime&
rCreationMetaDate,
OString& o_rCString2
);
static sal_Int32 computeAccessPermissions( const
vcl::PDFWriter::PDFEncryptionProperties& i_rProperties,
diff --git a/vcl/source/gdi/pdfwriter_impl.cxx
b/vcl/source/gdi/pdfwriter_impl.cxx
index 55ed6d514b9d..def3d4ee3ba5 100644
--- a/vcl/source/gdi/pdfwriter_impl.cxx
+++ b/vcl/source/gdi/pdfwriter_impl.cxx
@@ -1375,7 +1375,7 @@ void PDFWriterImpl::setupDocInfo()
{
std::vector< sal_uInt8 > aId;
m_aCreationDateString = PDFWriter::GetDateTime();
-computeDocumentIdentifier( aId, m_aContext.DocumentInfo,
m_aCreationDateString, m_aCreationMetaDateString );
+computeDocumentIdentifier(
[Libreoffice-bugs] [Bug 157067] "Character styles" panel is not showing highlighting color style
https://bugs.documentfoundation.org/show_bug.cgi?id=157067 LeroyG changed: What|Removed |Added OS|Linux (All) |All --- Comment #3 from LeroyG --- Same behavior with: Version: 7.5.3.2 (x86) / LibreOffice Community Build ID: 9f56dff12ba03b9acd7730a5a481eea045e468f3 CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: Skia/Raster; VCL: win Locale: es-MX (es_MX); UI: fr-FR Calc: threaded Version: 7.6.0.2 (x86) / LibreOffice Community Build ID: 41d6f628ba3f046f16b5fa9fa8db8d4c2ab3b582 CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: Skia/Raster; VCL: win Locale: es-MX (es_MX); UI: en-US Calc: threaded Not reproducible with: Version: 7.4.7.2 (x86) / LibreOffice Community Build ID: 723314e595e8007d3cf785c16538505a1c878ca5 CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: Skia/Raster; VCL: win Locale: es-MX (es_MX); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157087] Unchecking "Save preview image with this document" does not work
https://bugs.documentfoundation.org/show_bug.cgi?id=157087 Gabor Kelemen (allotropia) changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||kelem...@ubuntu.com See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=87 ||995 Keywords||implementationError Ever confirmed|0 |1 --- Comment #1 from Gabor Kelemen (allotropia) --- Confirmed in current master Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: cc7d6211bc01e5ec84dbad542605d2e93dea925c CPU threads: 15; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: en-US (hu_HU); UI: en-US Calc: threaded Seems to have started with the implementation of the checkbox: https://cgit.freedesktop.org/libreoffice/core/commit/?id=d7ca71d4b1ac085c575fdc24f37940100ab38961 tdf#87995 - settings : missing a checkbox in order to avoid thumbnail saving -- You are receiving this mail because: You are the assignee for the bug.
Re: Adding an implemented UNO interface
On Mon, Sep 04, 2023 at 11:58:23AM +0200, Lionel Élie Mamane wrote:
> Reading up on ImplInheritanceHelper, I think you meant (or my question
> was unclear, but the answer to the question I had meant to ask is)
> typedef cppu::ImplInheritanceHelper bar_BASE;
> class bar: public bar_BASE
> {
>
> }
Now we hit the problem that css::corge is an extension of an interface
already implemented by grault (let's call it css::qux), so css:qux
becomes an ambiguous base of class bar, as it is derived from twice
:-|
How do we solve that?
So to recap (and rename corge to qux2 for better clarity) we have:
/* qux2.idl contains:
*
* interface qux2 : qux
* {
* ... stuff ...
* )
*/
#include
/* grault.hxx contains:
*
* typedef ::cppu::WeakComponentImplHelper2 <
*css::baz,
*css::qux > grault_BASE;
*
* class grault : public grault_BASE { ... }
*/
typedef grault bar_BASE;
class bar : public bar_BASE
{
...
}
and what we want to achieve is to implement interface css::qux2 in
class bar. Surely there must be a recipe for that.
(For Stephan: css::qux above is css::sdbc::XConnection in the patch,
and qux2 is the newly introduced css::sdbc::XConnection2)
[Libreoffice-bugs] [Bug 157093] Search function(ctrl + H) no finding the words with graphic accent in Portuguese Brazilian
https://bugs.documentfoundation.org/show_bug.cgi?id=157093 Jack changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157093] New: Search function(ctrl + H) no finding the words with graphic accent in Portuguese Brazilian
https://bugs.documentfoundation.org/show_bug.cgi?id=157093 Bug ID: 157093 Summary: Search function(ctrl + H) no finding the words with graphic accent in Portuguese Brazilian Product: LibreOffice Version: 7.5.5.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: e.je...@gmail.com In the Brazilian Portuguese language, in the Edit menu, Find and Replace option (Ctrl + H), the words with accents are not being found when I place the word without an accent. For example, words with accents á, à, if I put it without an accent, it doesn't find the word. Diacritic sensitive option is disabled. - In Portuguese Brazilian - No idioma Português do Brasil, Na opção Editar, Localizar e substituir(Ctrl + H), não está localizando as palavras com acentos quando coloco a palavra sem acento. Por exemplo, palavras com acentos á, à, se coloco sem acento não acha a palavra. A opção sensível à diacrítica está desativada. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157085] CRASH: fixing accessibility check of deleted image
https://bugs.documentfoundation.org/show_bug.cgi?id=157085 Samuel Mehrbrodt (allotropia) changed: What|Removed |Added Regression By||Samuel Mehrbrodt -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154929] [META] Accessibility Check sidebar deck, Automatic Accessibility Checking
https://bugs.documentfoundation.org/show_bug.cgi?id=154929 Samuel Mehrbrodt (allotropia) changed: What|Removed |Added Depends on||157085 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=157085 [Bug 157085] CRASH: fixing accessibility check of deleted image -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157085] CRASH: fixing accessibility check of deleted image
https://bugs.documentfoundation.org/show_bug.cgi?id=157085 Samuel Mehrbrodt (allotropia) changed: What|Removed |Added Blocks||154929 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=154929 [Bug 154929] [META] Accessibility Check sidebar deck, Automatic Accessibility Checking -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - cui/qa svx/source
cui/qa/uitest/dialogs/chardlg.py |4 ++--
cui/qa/uitest/tabpages/tpcolor.py |4 ++--
svx/source/tbxctrls/PaletteManager.cxx |6 +-
3 files changed, 9 insertions(+), 5 deletions(-)
New commits:
commit a70b613e6b5d95362f34f57df5cda22a74cb670e
Author: Julien Nabet
AuthorDate: Thu Aug 31 16:19:13 2023 +0200
Commit: Tomaž Vajngerl
CommitDate: Mon Sep 4 19:51:06 2023 +0200
tdf#157034: FILESAVE loext:theme-type is off by one
nItemId begins with 1 but list of themes begin with 0 so decrement nItemId
part of bt here:
https://bugs.documentfoundation.org/show_bug.cgi?id=157034#c1
+ adapt QA tests
Change-Id: I7913ea0f71abb9ff98039a9c45a49fdb8f709ae0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156350
Tested-by: Jenkins
Reviewed-by: Regina Henschel
(cherry picked from commit 85aa230aebfe383eecdb4fc6704d093db8a18402)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156389
Reviewed-by: Tomaž Vajngerl
diff --git a/cui/qa/uitest/dialogs/chardlg.py b/cui/qa/uitest/dialogs/chardlg.py
index 85e60f766238..d6ebffac3e1e 100644
--- a/cui/qa/uitest/dialogs/chardlg.py
+++ b/cui/qa/uitest/dialogs/chardlg.py
@@ -106,9 +106,9 @@ class Test(UITestCase):
portion = portions.nextElement()
# Without the accompanying fix in place, this test would have
failed with:
-# AssertionError: -1 != 4
+# AssertionError: -1 != 3
# i.e. no theme index was set, instead of accent1 (index into the
above color scheme).
-self.assertEqual(portion.CharColorTheme, 4)
+self.assertEqual(portion.CharColorTheme, 3)
# Then make sure that '80% lighter' is lum-mod=2000 and
lum-off=8000:
# Without the accompanying fix in place, this test would have
failed with:
diff --git a/cui/qa/uitest/tabpages/tpcolor.py
b/cui/qa/uitest/tabpages/tpcolor.py
index ad52711857e4..820ffa634eb1 100644
--- a/cui/qa/uitest/tabpages/tpcolor.py
+++ b/cui/qa/uitest/tabpages/tpcolor.py
@@ -61,9 +61,9 @@ class Test(UITestCase):
# Then make sure the doc model is updated accordingly:
shape = drawPage.getByIndex(0)
# Without the accompanying fix in place, this test would have
failed with:
-# AssertionError: -1 != 4
+# AssertionError: -1 != 3
# i.e. the theme metadata of the selected fill color was lost.
-self.assertEqual(shape.FillColorTheme, 4)
+self.assertEqual(shape.FillColorTheme, 3)
# vim: set shiftwidth=4 softtabstop=4 expandtab:
diff --git a/svx/source/tbxctrls/PaletteManager.cxx
b/svx/source/tbxctrls/PaletteManager.cxx
index 9fcefd34d1c8..343448c8e788 100644
--- a/svx/source/tbxctrls/PaletteManager.cxx
+++ b/svx/source/tbxctrls/PaletteManager.cxx
@@ -161,7 +161,11 @@ bool PaletteManager::IsThemePaletteSelected() const
bool PaletteManager::GetThemeAndEffectIndex(sal_uInt16 nItemId, sal_uInt16&
rThemeIndex, sal_uInt16& rEffectIndex)
{
- // Each column is the same color with different effects.
+// tdf#157034, nItemId begins with 1 but list of themes begin with 0
+// so decrement nItemId
+--nItemId;
+
+// Each column is the same color with different effects.
rThemeIndex = nItemId % 12;
rEffectIndex = nItemId / 12;
[Libreoffice-bugs] [Bug 113331] [META] PPT (binary) format bug tracker
https://bugs.documentfoundation.org/show_bug.cgi?id=113331 Bug 113331 depends on bug 48083, which changed state. Bug 48083 Summary: FILEOPEN PPT: Slide Background Fill is none instead of slide color (PPTX fixed in 5.2) https://bugs.documentfoundation.org/show_bug.cgi?id=48083 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: filter/source sd/qa
filter/source/msfilter/msdffimp.cxx | 13 -
filter/source/msfilter/svdfppt.cxx | 17 +++--
sd/qa/unit/data/ppt/tdf48083.ppt|binary
sd/qa/unit/import-tests2.cxx| 16 +++-
4 files changed, 34 insertions(+), 12 deletions(-)
New commits:
commit a43f1ac6c964181cbaa4c889409688197cbf7a2b
Author: Samuel Mehrbrodt
AuthorDate: Mon Sep 4 14:54:38 2023 +0200
Commit: Samuel Mehrbrodt
CommitDate: Mon Sep 4 19:44:29 2023 +0200
tdf#48083 Import mso_fillBackground from ppt
Change-Id: Ic60fbc5fcfd7b38e7dd594690e5cfe784061a3d9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156517
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt
diff --git a/filter/source/msfilter/msdffimp.cxx
b/filter/source/msfilter/msdffimp.cxx
index 8d6f9023ad16..bc28e62e2b16 100644
--- a/filter/source/msfilter/msdffimp.cxx
+++ b/filter/source/msfilter/msdffimp.cxx
@@ -74,6 +74,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -1338,6 +1339,7 @@ void DffPropertyReader::ApplyFillAttributes( SvStream&
rIn, SfxItemSet& rSet, co
if ( nFillFlags & 0x10 )
{
auto eMSO_FillType = GetPropertyValue(DFF_Prop_fillType,
mso_fillSolid);
+bool bUseSlideBackground = false;
drawing::FillStyle eXFill = drawing::FillStyle_NONE;
switch( eMSO_FillType )
{
@@ -1366,7 +1368,10 @@ void DffPropertyReader::ApplyFillAttributes( SvStream&
rIn, SfxItemSet& rSet, co
case mso_fillShadeTitle : // special type - shade to title
--- for PP
eXFill = drawing::FillStyle_GRADIENT;
break;
-// case mso_fillBackground : // Use the background fill
color/pattern
+case mso_fillBackground : // Use the background fill
color/pattern
+eXFill = drawing::FillStyle_NONE;
+bUseSlideBackground = true;
+break;
default: break;
}
rSet.Put( XFillStyleItem( eXFill ) );
@@ -1466,6 +1471,12 @@ void DffPropertyReader::ApplyFillAttributes( SvStream&
rIn, SfxItemSet& rSet, co
}
}
}
+else if (eXFill == drawing::FillStyle_BITMAP && bUseSlideBackground)
+{
+rSet.Put( XFillStyleItem( drawing::FillStyle_NONE ) );
+XFillUseSlideBackgroundItem aFillBgItem(true);
+rSet.Put(aFillBgItem);
+}
}
else
rSet.Put( XFillStyleItem( drawing::FillStyle_NONE ) );
diff --git a/filter/source/msfilter/svdfppt.cxx
b/filter/source/msfilter/svdfppt.cxx
index fa4c9c55d7dc..a4442cfb2393 100644
--- a/filter/source/msfilter/svdfppt.cxx
+++ b/filter/source/msfilter/svdfppt.cxx
@@ -53,6 +53,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -2930,17 +2931,13 @@ void SdrPowerPointImport::ImportPage( SdrPage* pRet,
const PptSlidePersistEntry*
{
if
(!aProcessData.aBackgroundColoredObjects.empty())
{
-if (!rSlidePersist.pBObj)
+for (auto const & pObject :
aProcessData.aBackgroundColoredObjects)
{
-for (auto const & pObject :
aProcessData.aBackgroundColoredObjects)
-{
-// The shape wants a background, but
the slide doesn't have
-// one: default to white.
-SfxItemSet
aNewSet(*pObject->GetMergedItemSet().GetPool());
-
aNewSet.Put(XFillStyleItem(css::drawing::FillStyle_SOLID));
-aNewSet.Put(XFillColorItem(OUString(),
COL_WHITE));
-pObject->SetMergedItemSet(aNewSet);
-}
+SfxItemSet
aNewSet(*pObject->GetMergedItemSet().GetPool());
+
aNewSet.Put(XFillStyleItem(css::drawing::FillStyle_NONE));
+XFillUseSlideBackgroundItem
aFillBgItem(true);
+aNewSet.Put(aFillBgItem);
+pObject->SetMergedItemSet(aNewSet);
}
}
}
diff --git a/sd/qa/unit/data/ppt/tdf48083.ppt b/sd/qa/unit/data/ppt/tdf48083.ppt
new file mode 100644
index ..97ca371d7a55
Binary files /dev/null and b/sd/qa/unit/data/ppt/tdf48083.ppt differ
diff --git a/sd/qa/unit/import-tests2.cxx b/sd/qa/unit/import-tests2.cxx
index 7702e27d715e..525177ba44da 100644
--- a/sd/qa/unit/import-tests2.cxx
+++ b/sd/qa/unit/import-tests2.cxx
@@ -581,7 +581,9 @@ CPPUNIT_TEST_FIXTURE(SdImportTest2, testTdf105150PPT)
// This
[Libreoffice-bugs] [Bug 157092] Using search feature in options dialog causes crash when NVDA is running
https://bugs.documentfoundation.org/show_bug.cgi?id=157092 Michael Weghorn changed: What|Removed |Added Keywords||accessibility CC||m.wegh...@posteo.de Blocks||101912 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=101912 [Bug 101912] [META] Accessibility (a11y) bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 101912] [META] Accessibility (a11y) bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=101912 Michael Weghorn changed: What|Removed |Added Depends on||157092 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=157092 [Bug 157092] Using search feature in options dialog causes crash when NVDA is running -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157092] New: Using search feature in options dialog causes crash when NVDA is running
https://bugs.documentfoundation.org/show_bug.cgi?id=157092 Bug ID: 157092 Summary: Using search feature in options dialog causes crash when NVDA is running Product: LibreOffice Version: 24.2.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: m.wegh...@posteo.de Steps to reproduce: 1) start the NVDA screen reader on Windows 2) start Writer 3) Tools -> Options 4) type "hello" in the newly addes search field 5) press Enter Result: LO crashes due to an exception being thrown: warn:svx:5688:9000:svtools/source/control/valueacc.cxx:953: Calling disposed object. Throwing exception: Behavior is the same with qt6 on Linux, but not with gen (which doesn't have an a11y implementation) or gtk3 (which likely uses native gtk widgets). Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 21af3e5b5df02747691f08c453407d0abfc91242 CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: en-US (en_DE); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157080] Assertion in Tools > Options > Font
https://bugs.documentfoundation.org/show_bug.cgi?id=157080 Michael Weghorn changed: What|Removed |Added Keywords||accessibility --- Comment #3 from Michael Weghorn --- Same on Windows when NVDA is running (but not without): > Assertion failed: GetChildCount() == 4 || pWindowImpl->mbInDispose, file > C:/tools/cygwin/home/user/development/git/libreoffice-WORKTREE/vcl/source/window/layout.cxx, > line 1928 > Assertion failed: GetChildCount() == 4 || pWindowImpl->mbInDispose, file > C:/tools/cygwin/home/user/development/git/libreoffice-WORKTREE/vcl/source/window/layout.cxx, > line 1928 > Assertion failed: GetChildCount() == 2 || pWindowImpl->mbInDispose, file > C:/tools/cygwin/home/user/development/git/libreoffice-WORKTREE/vcl/source/window/layout.cxx, > line 1558 Interestingly, it works fine when the "Tools" -> "Options" dialog already initially opens on the "Fonts" page (e.g. because that has been saved as the last open page when having it opened before without NVDA running). Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 21af3e5b5df02747691f08c453407d0abfc91242 CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: en-US (en_DE); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: starmath/inc starmath/source
starmath/inc/cursor.hxx|1
starmath/source/cursor.cxx |7
starmath/source/view.cxx | 64 -
3 files changed, 66 insertions(+), 6 deletions(-)
New commits:
commit 065609f86f730d4eedc6b7ae28382dc7daea11ac
Author: Khaled Hosny
AuthorDate: Mon Sep 4 13:22:04 2023 +0300
Commit: خالد حسني
CommitDate: Mon Sep 4 19:29:45 2023 +0200
starmath: Make cut/copy/paste buttons work with inline editing
Check for visual cursor selection when in inline editing mode, and update
edit
window when updating visual cursor.
Change-Id: Id1a259b67db47eea0b36b55d08ef5dc5f8aa8246
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156513
Tested-by: Jenkins
Reviewed-by: خالد حسني
diff --git a/starmath/inc/cursor.hxx b/starmath/inc/cursor.hxx
index 0a8a35071f10..7e1f8ec83c53 100644
--- a/starmath/inc/cursor.hxx
+++ b/starmath/inc/cursor.hxx
@@ -85,6 +85,7 @@ public:
/** True, if the cursor has a selection */
bool HasSelection() const { return mpAnchor != mpPosition; }
+const ESelection& GetSelection();
/** Move the position of this cursor */
void Move(OutputDevice* pDev, SmMovementDirection direction, bool
bMoveAnchor = true);
diff --git a/starmath/source/cursor.cxx b/starmath/source/cursor.cxx
index e8623517bcd7..41506dff3109 100644
--- a/starmath/source/cursor.cxx
+++ b/starmath/source/cursor.cxx
@@ -1141,6 +1141,13 @@ SmNode* SmCursor::FindSelectedNode(SmNode* pNode){
return nullptr;
}
+const ESelection& SmCursor::GetSelection() {
+const SmNode* pNode = FindSelectedNode(mpTree);
+if (!pNode)
+return mpTree->GetSelection();
+return pNode->GetSelection();
+}
+
void SmCursor::LineToList(SmStructureNode* pLine, SmNodeList& list){
for(auto pChild : *pLine)
{
diff --git a/starmath/source/view.cxx b/starmath/source/view.cxx
index 85dccb711ec6..22ca4e575d3b 100644
--- a/starmath/source/view.cxx
+++ b/starmath/source/view.cxx
@@ -368,8 +368,13 @@ bool SmGraphicWidget::MouseButtonDown(const MouseEvent&
rMEvt)
if (!pTree)
return true;
+SmEditWindow* pEdit = GetView().GetEditWindow();
+
if (SmViewShell::IsInlineEditEnabled()) {
-GetCursor().MoveTo(, aPos, !rMEvt.IsShift());
+SmCursor& rCursor = GetCursor();
+rCursor.MoveTo(, aPos, !rMEvt.IsShift());
+if (pEdit)
+pEdit->SetSelection(rCursor.GetSelection());
// 'on grab' window events are missing in lok, do it explicitly
if (comphelper::LibreOfficeKit::isActive())
SetIsCursorVisible(true);
@@ -383,7 +388,6 @@ bool SmGraphicWidget::MouseButtonDown(const MouseEvent&
rMEvt)
if (!pNode)
return true;
-SmEditWindow* pEdit = GetView().GetEditWindow();
if (!pEdit)
return true;
@@ -713,6 +717,7 @@ bool SmGraphicWidget::KeyInput(const KeyEvent& rKEvt)
return GetView().KeyInput(rKEvt);
bool bConsumed = true;
+bool bSetSelection = false;
SmCursor& rCursor = GetCursor();
switch (rKEvt.GetKeyCode().GetFunction())
@@ -737,24 +742,32 @@ bool SmGraphicWidget::KeyInput(const KeyEvent& rKEvt)
{
case KEY_LEFT:
rCursor.Move((), MoveLeft,
!rKEvt.GetKeyCode().IsShift());
+bSetSelection = true;
break;
case KEY_RIGHT:
rCursor.Move((), MoveRight,
!rKEvt.GetKeyCode().IsShift());
+bSetSelection = true;
break;
case KEY_UP:
rCursor.Move((), MoveUp,
!rKEvt.GetKeyCode().IsShift());
+bSetSelection = true;
break;
case KEY_DOWN:
rCursor.Move((), MoveDown,
!rKEvt.GetKeyCode().IsShift());
+bSetSelection = true;
break;
case KEY_RETURN:
if (!rKEvt.GetKeyCode().IsShift())
+{
rCursor.InsertRow();
+bSetSelection = true;
+}
break;
case KEY_DELETE:
if (!rCursor.HasSelection())
{
rCursor.Move((), MoveRight, false);
+bSetSelection = true;
if (rCursor.HasComplexSelection())
break;
}
@@ -762,12 +775,17 @@ bool SmGraphicWidget::KeyInput(const KeyEvent& rKEvt)
break;
case KEY_BACKSPACE:
rCursor.DeletePrev(());
+bSetSelection = true;
break;
default:
if (!CharInput(rKEvt.GetCharCode(), rCursor,
GetOutputDevice()))
bConsumed = GetView().KeyInput(rKEvt);
}
}
+
+SmEditWindow* pEdit = GetView().GetEditWindow();
+if (pEdit && bSetSelection)
+pEdit->SetSelection(rCursor.GetSelection());
CaretBlinkStop();
[Libreoffice-bugs] [Bug 156289] Unhelpful error when slash is given in filename
https://bugs.documentfoundation.org/show_bug.cgi?id=156289 Buovjaga changed: What|Removed |Added Resolution|--- |INVALID Status|UNCONFIRMED |RESOLVED CC||ilmari.lauhakangas@libreoff ||ice.org --- Comment #2 from Buovjaga --- (In reply to David Chen from comment #0) > Description: > I was mistakenly trying to save a file with a date formatted with a slash, > and was getting an unhelpful "Nonexistent object. Path to the file does not > exist." error. I had looked around for advice on this issue, only to find > other bugs, such as #90189 and forum posts regarding network file shares. > In the same vein as #95336, it would be a great improvement to user > experience if the warnings were more specific when there are invalid > character issues, instead of leaving them with a vague error that returns > unhelpful results when looking it up. Thank you. > > Steps to Reproduce: > 1. Open a LibreOffice document > 2. Try to save it as a new file > 3. Mistakenly enter an invalid file name character such as `/` > > Actual Results: > A somewhat unhelpful error, "Nonexistent object. Path to the file does not > exist.", which may lead one to overestimate their issue, is given. > > Expected Results: > The user should get an error warning them of their mistake, instead of being > directed towards unrelated issues. Forward slash is not an invalid character on Linux, but a directory delimiter: https://en.wikipedia.org/wiki/Path_(computing) The error message is as helpful as it can get. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157085] CRASH: fixing accessibility check of deleted image
https://bugs.documentfoundation.org/show_bug.cgi?id=157085 Julien Nabet changed: What|Removed |Added Keywords||haveBacktrace -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157085] CRASH: fixing accessibility check of deleted image
https://bugs.documentfoundation.org/show_bug.cgi?id=157085 Julien Nabet changed: What|Removed |Added CC||serval2...@yahoo.fr --- Comment #3 from Julien Nabet --- Created attachment 189346 --> https://bugs.documentfoundation.org/attachment.cgi?id=189346=edit bt with debug symbols On pc Debian x86-64 with master sources updated today, I got a crash at step 4. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144373] Writer not responsive for a while after opening 293 pages ODT with 3 big and terrible tables
https://bugs.documentfoundation.org/show_bug.cgi?id=144373 --- Comment #7 from Julien Nabet --- With master sources updated today or with LO Debian package 7.5.5 with gen rendering (to avoid accessibility part), it's still very slow for me when scrolling and still 100% CPU. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156961] Crash in: libc.so.6
https://bugs.documentfoundation.org/show_bug.cgi?id=156961 --- Comment #3 from Julien Nabet --- Created attachment 189345 --> https://bugs.documentfoundation.org/attachment.cgi?id=189345=edit Memoria exported in pdf On pc Debian x86-64 with master sources updated today or with LO Debian package 7.5.5.2, I don't reproduce this. BTW, do you still reproduce this with the sanitized document? Sometimes, the fact to sanitize may remove the pb, of course, it's not a solution! -- You are receiving this mail because: You are the assignee for the bug.
Adam Fallon (adam.eric.fal...@gmail.com) License Statement
Dear Sir, I am sending this statement as the parent of Adam Fallon as he is below 18. "All of my past & future contributions to LibreOffice may be licensed under the MPLv2/LGPLv3+ dual license.” Yours sincerely, Philip G Fallon (on behalf of Adam Fallon)
[Libreoffice-bugs] [Bug 146628] Outline-Folding Button Is Too Small [HiDPI]
https://bugs.documentfoundation.org/show_bug.cgi?id=146628 --- Comment #5 from Damian Hofmann --- Created attachment 189344 --> https://bugs.documentfoundation.org/attachment.cgi?id=189344=edit collapse button doesn't scale Reproduced with LO 7.5.x on Windows 10. Added new screenshot to illustrate the issue. On this HiDPI screen, I use a global scale factor of 200%. Yes, that makes stuff a little larger than "normal". But not by much. Setting the global scale to anything lower than 150%, everything on this system is too small to read. In the screenshot, note the size of the collapse button, in relation to normal 12pt text? Or also in relation to the toolbar buttons. I think the button should be about the same height (and width) of a normal text line. Or about half the height and width of the toolbar buttons you see on this screen. Or in other words, just apply the global scale factor. Right now, it seems, that the button is fixed pixels and doesn’t scale at all. This makes it unusable on HiDPI screens. --- Version: 7.5.3.2 (X86_64) / LibreOffice Community Build ID: 9f56dff12ba03b9acd7730a5a481eea045e468f3 CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: de-CH (de_CH); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155557] Wrong rendering of underline for justified mixed RTL/LTR script text
https://bugs.documentfoundation.org/show_bug.cgi?id=17 خالد حسني changed: What|Removed |Added Assignee|kha...@libreoffice.org |libreoffice-b...@lists.free ||desktop.org -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144134] Tabs in LibreOffice Tab layout do not scale properly with the size of the screen.
https://bugs.documentfoundation.org/show_bug.cgi?id=144134 --- Comment #10 from V Stuart Foote --- No, not resolved. With recent master against 24.2.0 no change in the binary collapse of "horizontal" padding for the MUFFIN 'Tabbed UI' Tabs/Buttons STR As in comment 1, and as visualized in attachment 174702 =-testing-= Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: d88779fc86385dde1215fd28b78a69eacc6b4f97 CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103302] [META] Writer's web layout/view bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103302 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||101788 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=101788 [Bug 101788] Split button for display modes -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 101788] Split button for display modes
https://bugs.documentfoundation.org/show_bug.cgi?id=101788 Stéphane Guillou (stragu) changed: What|Removed |Added Blocks||103302 Version|unspecified |Inherited From OOo Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103302 [Bug 103302] [META] Writer's web layout/view bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 43808] [META] Right-To-Left and Complex Text Layout language issues (RTL/CTL)
https://bugs.documentfoundation.org/show_bug.cgi?id=43808 Bug 43808 depends on bug 134193, which changed state. Bug 134193 Summary: Support right-to-left math layout in Formula Editor https://bugs.documentfoundation.org/show_bug.cgi?id=134193 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 39750] [META] General Math formula editor improvements
https://bugs.documentfoundation.org/show_bug.cgi?id=39750 Bug 39750 depends on bug 134193, which changed state. Bug 134193 Summary: Support right-to-left math layout in Formula Editor https://bugs.documentfoundation.org/show_bug.cgi?id=134193 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 84909] [META] Enhancing Impress/Draw toolbars and context menu
https://bugs.documentfoundation.org/show_bug.cgi?id=84909 Bug 84909 depends on bug 156097, which changed state. Bug 156097 Summary: Impress: Vertical Text missing as Insert menu item in Classic UI https://bugs.documentfoundation.org/show_bug.cgi?id=156097 What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |NOTABUG -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156097] Impress: Vertical Text missing as Insert menu item in Classic UI
https://bugs.documentfoundation.org/show_bug.cgi?id=156097 Buovjaga changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |NOTABUG CC||ilmari.lauhakangas@libreoff ||ice.org --- Comment #2 from Buovjaga --- Ok, let's close -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 90027] ENHANCEMENT: Draw: Measure shape area, length of paths... in the status bar and/or dedicated dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=90027 --- Comment #10 from Stéphane Guillou (stragu) --- (In reply to Heiko Tietze from comment #9) > Created attachment 189340 [details] > Statusbar > > Both shapes are 1x1cm - the statusbar shows the size of the selection. What > is missing? In this particular case, how I picture it would be having (as well as the _selection frame_ info we already have): - Shape area = 2 cm² - Total path length = 8 cm -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 122652] [META] Memory problems in LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=122652 Buovjaga changed: What|Removed |Added Depends on||156178 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=156178 [Bug 156178] Slides with videos leak memory (Linux-only) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156178] Slides with videos leak memory (Linux-only)
https://bugs.documentfoundation.org/show_bug.cgi?id=156178 Buovjaga changed: What|Removed |Added Blocks||122652 Status|UNCONFIRMED |NEW Ever confirmed|0 |1 Summary|LibreOffice Impress leaks |Slides with videos leak |memory |memory (Linux-only) CC||ilmari.lauhakangas@libreoff ||ice.org --- Comment #7 from Buovjaga --- The linked file is now gone. I tried with two small videos and changed back and forth quickly in a slideshow. It seems I was able to increase the memory use consistently. I could not reproduce this on Windows. Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: cc7d6211bc01e5ec84dbad542605d2e93dea925c CPU threads: 2; OS: Windows 10.0 Build 22621; UI render: default; VCL: win Locale: en-US (en_FI); UI: en-US Calc: threaded Arch Linux 64-bit, X11 Version: 7.6.0.3 (X86_64) / LibreOffice Community Build ID: 60(Build:3) CPU threads: 8; OS: Linux 6.4; UI render: default; VCL: kf5 (cairo+xcb) Locale: fi-FI (fi_FI.UTF-8); UI: en-US 7.6.0-2 Calc: threaded Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=122652 [Bug 122652] [META] Memory problems in LibreOffice -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: starmath/inc starmath/source
starmath/inc/visitors.hxx|2 +-
starmath/source/document.cxx | 24 ++--
starmath/source/visitors.cxx |8
3 files changed, 23 insertions(+), 11 deletions(-)
New commits:
commit f80c2c70756e3620daed6675c8546caca4153d4b
Author: Khaled Hosny
AuthorDate: Tue Aug 29 20:51:06 2023 +0300
Commit: خالد حسني
CommitDate: Mon Sep 4 18:18:37 2023 +0200
tdf#134193: Fix inline editing with RTL direction
Change-Id: I65d3ed0d7c56839ce3674318144269719b043ba5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156261
Tested-by: Jenkins
Reviewed-by: خالد حسني
diff --git a/starmath/inc/visitors.hxx b/starmath/inc/visitors.hxx
index c1a2a8983286..338e93432ba1 100644
--- a/starmath/inc/visitors.hxx
+++ b/starmath/inc/visitors.hxx
@@ -219,7 +219,7 @@ public:
, maPosition( position )
, mrFormat( rFormat )
{
-if (mrFormat.IsRightToLeft())
+if (mrFormat.IsRightToLeft() && mrDev.GetOutDevType() != OUTDEV_WINDOW)
mrDev.ReMirror(maPosition);
pTree->Accept( this );
}
diff --git a/starmath/source/document.cxx b/starmath/source/document.cxx
index 9bdaad7530e6..8f8e184470a0 100644
--- a/starmath/source/document.cxx
+++ b/starmath/source/document.cxx
@@ -332,8 +332,10 @@ void SmDocShell::DrawFormula(OutputDevice , Point
, bool bDrawSel
rPosition.AdjustY(maFormat.GetDistance( DIS_TOPSPACE ) );
Point aPosition(rPosition);
-if (bRTL)
-aPosition.AdjustX(GetSize().Width() -
maFormat.GetDistance(DIS_LEFTSPACE) - maFormat.GetDistance(DIS_RIGHTSPACE));
+if (bRTL && rDev.GetOutDevType() != OUTDEV_WINDOW)
+aPosition.AdjustX(GetSize().Width()
+ - maFormat.GetDistance(DIS_LEFTSPACE)
+ - maFormat.GetDistance(DIS_RIGHTSPACE));
//! in case of high contrast-mode (accessibility option!)
//! the draw mode needs to be set to default, because when embedding
@@ -353,11 +355,21 @@ void SmDocShell::DrawFormula(OutputDevice , Point
, bool bDrawSel
vcl::PushFlags::RTLENABLED);
// We want the device to always be LTR, we handle RTL formulas ourselves.
-rDev.EnableRTL(false);
+if (rDev.GetOutDevType() == OUTDEV_WINDOW)
+rDev.EnableRTL(bRTL);
+else
+rDev.EnableRTL(false);
-// For RTL formulas, we want the brackets to be mirrored.
-rDev.SetLayoutMode(bRTL ? vcl::text::ComplexTextLayoutFlags::BiDiRtl
-: vcl::text::ComplexTextLayoutFlags::Default);
+auto nLayoutFlags = vcl::text::ComplexTextLayoutFlags::Default;
+if (bRTL)
+{
+// For RTL formulas, we want the brackets to be mirrored.
+nLayoutFlags |= vcl::text::ComplexTextLayoutFlags::BiDiRtl;
+if (rDev.GetOutDevType() == OUTDEV_WINDOW)
+nLayoutFlags |= vcl::text::ComplexTextLayoutFlags::TextOriginLeft;
+}
+
+rDev.SetLayoutMode(nLayoutFlags);
// Numbers should not be converted, for now.
rDev.SetDigitLanguage( LANGUAGE_ENGLISH );
diff --git a/starmath/source/visitors.cxx b/starmath/source/visitors.cxx
index cece754de276..732c27f9840f 100644
--- a/starmath/source/visitors.cxx
+++ b/starmath/source/visitors.cxx
@@ -438,7 +438,7 @@ void SmDrawingVisitor::Visit( SmRootSymbolNode* pNode )
tools::Rectangle aBar( aBarPos, Size( nBarWidth, nBarHeight ) );
-if (mrFormat.IsRightToLeft())
+if (mrFormat.IsRightToLeft() && mrDev.GetOutDevType() != OUTDEV_WINDOW)
mrDev.ReMirror(aBar);
//! avoid GROWING AND SHRINKING of drawn rectangle when constantly
@@ -465,7 +465,7 @@ void SmDrawingVisitor::Visit( SmPolyLineNode* pNode )
+ Point( nBorderwidth, nBorderwidth ) ),
aPos ( maPosition + aOffset );
-if (mrFormat.IsRightToLeft())
+if (mrFormat.IsRightToLeft() && mrDev.GetOutDevType() != OUTDEV_WINDOW)
mrDev.ReMirror(aPos);
pNode->GetPolygon( ).Move( aPos.X( ), aPos.Y( ) );//Works because
Polygon wraps a pointer
@@ -497,7 +497,7 @@ void SmDrawingVisitor::Visit( SmRectangleNode* pNode )
SAL_WARN_IF( aTmp.IsEmpty(), "starmath", "Empty rectangle" );
-if (mrFormat.IsRightToLeft())
+if (mrFormat.IsRightToLeft() && mrDev.GetOutDevType() != OUTDEV_WINDOW)
mrDev.ReMirror(aTmp);
//! avoid GROWING AND SHRINKING of drawn rectangle when constantly
@@ -521,7 +521,7 @@ void SmDrawingVisitor::DrawTextNode( SmTextNode* pNode )
Point aPos ( maPosition );
aPos.AdjustY(pNode->GetBaselineOffset( ) );
-if (mrFormat.IsRightToLeft())
+if (mrFormat.IsRightToLeft() && mrDev.GetOutDevType() != OUTDEV_WINDOW)
mrDev.ReMirror(aPos);
// round to pixel coordinate
