[Libreoffice-commits] core.git: 2 commits - linguistic/source oox/qa oox/source

[Stephan Bergmann (via logerrit)]

 linguistic/source/convdicxml.cxx   |4 ++--
 linguistic/source/dicimp.cxx   |2 +-
 linguistic/source/hhconvdic.cxx|2 +-
 linguistic/source/lngsvcmgr.cxx|8 
 oox/qa/unit/export.cxx |2 +-
 oox/qa/unit/mcgr.cxx   |8 
 oox/source/core/filterbase.cxx |6 +++---
 oox/source/core/xmlfilterbase.cxx  |4 ++--
 oox/source/crypto/Standard2007Engine.cxx   |2 +-
 oox/source/drawingml/customshapeproperties.cxx |2 +-
 oox/source/drawingml/fontworkhelpers.cxx   |6 +++---
 oox/source/drawingml/hyperlinkcontext.cxx  |4 ++--
 oox/source/drawingml/shape.cxx |2 +-
 oox/source/export/vmlexport.cxx|2 +-
 oox/source/helper/modelobjecthelper.cxx|4 ++--
 oox/source/ole/oleobjecthelper.cxx |2 +-
 oox/source/ppt/pptshape.cxx|2 +-
 oox/source/ppt/presentationfragmenthandler.cxx |4 ++--
 oox/source/ppt/slidepersist.cxx|2 +-
 oox/source/vml/vmlinputstream.cxx  |2 +-
 oox/source/vml/vmlshape.cxx|2 +-
 oox/source/vml/vmlshapecontext.cxx |2 +-
 22 files changed, 37 insertions(+), 37 deletions(-)

New commits:
commit dd6f6147d431577ce7e1c5596481366a9faa7afb
Author: Stephan Bergmann 
AuthorDate: Thu Oct 19 10:30:20 2023 +0200
Commit: Stephan Bergmann 
CommitDate: Fri Oct 20 07:58:58 2023 +0200

Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: linguistic

Change-Id: I0866cdaffa7059c30a65373efcd37a91b1b6e63e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158205
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/linguistic/source/convdicxml.cxx b/linguistic/source/convdicxml.cxx
index c8a09997fd7e..370629925a45 100644
--- a/linguistic/source/convdicxml.cxx
+++ b/linguistic/source/convdicxml.cxx
@@ -43,8 +43,8 @@ using namespace linguistic;
 
 
 constexpr OUStringLiteral XML_NAMESPACE_TCD_STRING = 
u"http://openoffice.org/2003/text-conversion-dictionary;;
-constexpr OUStringLiteral CONV_TYPE_HANGUL_HANJA = u"Hangul / Hanja";
-constexpr OUStringLiteral CONV_TYPE_SCHINESE_TCHINESE = u"Chinese simplified / 
Chinese traditional";
+constexpr OUString CONV_TYPE_HANGUL_HANJA = u"Hangul / Hanja"_ustr;
+constexpr OUString CONV_TYPE_SCHINESE_TCHINESE = u"Chinese simplified / 
Chinese traditional"_ustr;
 
 
 static OUString ConversionTypeToText( sal_Int16 nConversionType )
diff --git a/linguistic/source/dicimp.cxx b/linguistic/source/dicimp.cxx
index ec49682b0cf9..b3099b3097e5 100644
--- a/linguistic/source/dicimp.cxx
+++ b/linguistic/source/dicimp.cxx
@@ -73,7 +73,7 @@ constexpr OUStringLiteral SPELLML_SUPPORT = u"";
 // The following fake file name extension will be
 // added to the text of the title: field for correct
 // text stripping and dictionary saving.
-constexpr OUStringLiteral EXTENSION_FOR_TITLE_TEXT = u".";
+constexpr OUString EXTENSION_FOR_TITLE_TEXT = u"."_ustr;
 
 const char* const pVerStr2= "WBSWG2";
 const char* const pVerStr5= "WBSWG5";
diff --git a/linguistic/source/hhconvdic.cxx b/linguistic/source/hhconvdic.cxx
index f2574d630e49..e7712ee66be4 100644
--- a/linguistic/source/hhconvdic.cxx
+++ b/linguistic/source/hhconvdic.cxx
@@ -39,7 +39,7 @@ using namespace linguistic;
 using namespace i18n;
 
 
-constexpr OUStringLiteral SN_HH_CONV_DICTIONARY = 
u"com.sun.star.linguistic2.HangulHanjaConversionDictionary";
+constexpr OUString SN_HH_CONV_DICTIONARY = 
u"com.sun.star.linguistic2.HangulHanjaConversionDictionary"_ustr;
 
 
 
diff --git a/linguistic/source/lngsvcmgr.cxx b/linguistic/source/lngsvcmgr.cxx
index 017d4b5e8c30..850d4d813bfd 100644
--- a/linguistic/source/lngsvcmgr.cxx
+++ b/linguistic/source/lngsvcmgr.cxx
@@ -710,10 +710,10 @@ void LngSvcMgr::UpdateAll()
 
 void LngSvcMgr::Notify( const uno::Sequence< OUString >  )
 {
-static constexpr OUStringLiteral aSpellCheckerList( 
u"ServiceManager/SpellCheckerList" );
-static constexpr OUStringLiteral aGrammarCheckerList( 
u"ServiceManager/GrammarCheckerList" );
-static constexpr OUStringLiteral aHyphenatorList( 
u"ServiceManager/HyphenatorList" );
-static constexpr OUStringLiteral aThesaurusList( 
u"ServiceManager/ThesaurusList" );
+static constexpr OUString aSpellCheckerList( 
u"ServiceManager/SpellCheckerList"_ustr );
+static constexpr OUString aGrammarCheckerList( 
u"ServiceManager/GrammarCheckerList"_ustr );
+static constexpr OUString aHyphenatorList( 
u"ServiceManager/HyphenatorList"_ustr );
+static constexpr OUString aThesaurusList( 
u"ServiceManager/ThesaurusList"_ustr );
 
 const uno::Sequence< OUString > aSpellCheckerListEntries( GetNodeNames( 
aSpellCheckerList ) );
 const uno::Sequence< OUString > aGrammarCheckerListEntries( GetNodeNames( 
aGrammarCheckerList ) );
commit 

[Libreoffice-commits] core.git: jvmfwk/source

[Stephan Bergmann (via logerrit)]

 jvmfwk/source/elements.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit cbe3899ed9b0fb226bf84c19e6f312e587ce2c03
Author: Stephan Bergmann 
AuthorDate: Thu Oct 19 10:30:19 2023 +0200
Commit: Stephan Bergmann 
CommitDate: Fri Oct 20 07:58:27 2023 +0200

Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: jvmfwk

Change-Id: I23ce970ad67047b0b22a9dda3dff047e5f59dff5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158203
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/jvmfwk/source/elements.cxx b/jvmfwk/source/elements.cxx
index ebbf8abf0fd2..57b500c56d56 100644
--- a/jvmfwk/source/elements.cxx
+++ b/jvmfwk/source/elements.cxx
@@ -177,8 +177,8 @@ NodeJava::NodeJava(Layer layer):
 
 void NodeJava::load()
 {
-static constexpr OStringLiteral sExcMsg("[Java framework] Error in 
function NodeJava::load"
- "(elements.cxx).");
+static constexpr OString sExcMsg("[Java framework] Error in function 
NodeJava::load"
+ "(elements.cxx)."_ostr);
 if (SHARED == m_layer)
 {
 //we do not support yet to write into the shared installation

[Libreoffice-bugs] [Bug 154864] Changing starting number of numbered list does nothing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=154864

Buovjaga  changed:

   What|Removed |Added

 CC||andorjk...@gmail.com

--- Comment #5 from Buovjaga  ---
*** Bug 157670 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157670] Writer list renumber

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157670

Buovjaga  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 CC||ilmari.lauhakangas@libreoff
   ||ice.org
 Status|UNCONFIRMED |RESOLVED

--- Comment #2 from Buovjaga  ---
No comment from reporter, so let's close as duplicate. Thanks, Kira!

*** This bug has been marked as a duplicate of bug 154864 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 113363] [META] DOCX (OOXML) content control-related issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113363
Bug 113363 depends on bug 157628, which changed state.

Bug 157628 Summary: No line breaks in the text in text frame
https://bugs.documentfoundation.org/show_bug.cgi?id=157628

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157628] No line breaks in the text in text frame

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157628

Buovjaga  changed:

   What|Removed |Added

 CC||ilmari.lauhakangas@libreoff
   ||ice.org
 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #4 from Buovjaga  ---
(In reply to Vasily Melenchuk (CIB) from comment #3)
> I did able to reproduce it with LibreOffice 7.5, but it is no longer
> reproducible with master.
> 
> Not sure 100%, but looks like this was fixed in:
> 
> commit 5082d50d24c3fec4487c724a15eb0d54a82ecd0d
> Author: Jaume Pujantell 
> Date:   Wed Sep 13 08:58:21 2023 +0200

Yes, I checked with linux-64-24.2 bibisect repo. Let's set to fixed as there is
no existing report associated with the fix.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: package/source

[Stephan Bergmann (via logerrit)]

 package/source/manifest/ManifestExport.cxx |8 
 package/source/manifest/ManifestImport.cxx |6 +++---
 package/source/xstor/owriteablestream.cxx  |8 
 package/source/zippackage/ZipPackage.cxx   |   16 
 package/source/zippackage/ZipPackageStream.cxx |   10 +-
 5 files changed, 24 insertions(+), 24 deletions(-)

New commits:
commit 6e4d3c3476fb60116fc7100a30a30ae15f60ce62
Author: Stephan Bergmann 
AuthorDate: Thu Oct 19 10:30:21 2023 +0200
Commit: Stephan Bergmann 
CommitDate: Fri Oct 20 07:06:58 2023 +0200

Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: package

Change-Id: I5d70d9291a64139bc2dc60c63173fef862a00f2c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158207
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/package/source/manifest/ManifestExport.cxx 
b/package/source/manifest/ManifestExport.cxx
index 79948c9ff068..feeb63353698 100644
--- a/package/source/manifest/ManifestExport.cxx
+++ b/package/source/manifest/ManifestExport.cxx
@@ -49,9 +49,9 @@ ManifestExport::ManifestExport( uno::Reference< 
xml::sax::XDocumentHandler > con
 static constexpr OUStringLiteral sPgpKeyIDProperty( u"KeyId" );
 static constexpr OUStringLiteral sPgpKeyPacketProperty( 
u"KeyPacket" );
 static constexpr OUStringLiteral sCipherValueProperty ( 
u"CipherValue" );
-static constexpr OUStringLiteral sFullPathProperty ( u"FullPath" );
-static constexpr OUStringLiteral sVersionProperty  ( u"Version" );
-static constexpr OUStringLiteral sMediaTypeProperty( u"MediaType" );
+static constexpr OUString sFullPathProperty ( u"FullPath"_ustr );
+static constexpr OUString sVersionProperty  ( u"Version"_ustr );
+static constexpr OUString sMediaTypeProperty( u"MediaType"_ustr );
 static constexpr OUStringLiteral sIterationCountProperty   ( 
u"IterationCount" );
 static constexpr OUStringLiteral sDerivedKeySizeProperty  ( 
u"DerivedKeySize" );
 static constexpr OUStringLiteral sSaltProperty ( u"Salt" );
@@ -62,7 +62,7 @@ ManifestExport::ManifestExport( uno::Reference< 
xml::sax::XDocumentHandler > con
 static constexpr OUStringLiteral sStartKeyAlgProperty  ( 
u"StartKeyAlgorithm" );
 static constexpr OUStringLiteral sDigestAlgProperty( 
u"DigestAlgorithm" );
 
-static constexpr OUStringLiteral sWhiteSpace   ( u" " );
+static constexpr OUString sWhiteSpace   ( u" "_ustr );
 
 const OUString sSHA256_URL_ODF12 ( SHA256_URL_ODF12 );
 const OUString  sSHA1_Name   ( SHA1_NAME );
diff --git a/package/source/manifest/ManifestImport.cxx 
b/package/source/manifest/ManifestImport.cxx
index d2b3177e34cf..2c55bcf87fe9 100644
--- a/package/source/manifest/ManifestImport.cxx
+++ b/package/source/manifest/ManifestImport.cxx
@@ -41,9 +41,9 @@ constexpr OUStringLiteral gsSaltProperty ( 
u"Salt" );
 constexpr OUStringLiteral gsInitialisationVectorProperty ( 
u"InitialisationVector" );
 constexpr OUStringLiteral gsSizeProperty ( u"Size" );
 constexpr OUStringLiteral gsDigestProperty   ( u"Digest" );
-constexpr OUStringLiteral gsEncryptionAlgProperty( 
u"EncryptionAlgorithm" );
-constexpr OUStringLiteral gsStartKeyAlgProperty  ( 
u"StartKeyAlgorithm" );
-constexpr OUStringLiteral gsDigestAlgProperty( u"DigestAlgorithm" 
);
+constexpr OUString gsEncryptionAlgProperty( 
u"EncryptionAlgorithm"_ustr );
+constexpr OUString gsStartKeyAlgProperty  ( u"StartKeyAlgorithm"_ustr 
);
+constexpr OUString gsDigestAlgProperty( u"DigestAlgorithm"_ustr );
 
 ManifestImport::ManifestImport( std::vector < Sequence < PropertyValue > > & 
rNewManVector )
 : bIgnoreEncryptData( false )
diff --git a/package/source/xstor/owriteablestream.cxx 
b/package/source/xstor/owriteablestream.cxx
index 1ed64c60e204..bd58f579a326 100644
--- a/package/source/xstor/owriteablestream.cxx
+++ b/package/source/xstor/owriteablestream.cxx
@@ -974,8 +974,8 @@ uno::Sequence< beans::PropertyValue > 
OWriteStream_Impl::ReadPackageStreamProper
 // The "Compressed" property must be set after "MediaType" property,
 // since the setting of the last one can change the value of the first one
 static constexpr OUStringLiteral sMediaType = u"MediaType";
-static constexpr OUStringLiteral sCompressed = u"Compressed";
-static constexpr OUStringLiteral sSize = u"Size";
+static constexpr OUString sCompressed = u"Compressed"_ustr;
+static constexpr OUString sSize = u"Size"_ustr;
 static constexpr OUStringLiteral sEncrypted = u"Encrypted";
 if ( m_nStorageType == embed::StorageFormats::OFOPXML || m_nStorageType == 
embed::StorageFormats::PACKAGE )
 {
@@ -2770,8 +2770,8 @@ void SAL_CALL OWriteStream::setPropertyValue( const 
OUString& aPropertyName, con
 }
 
 

[Libreoffice-commits] core.git: i18npool/qa i18npool/source

[Stephan Bergmann (via logerrit)]

 i18npool/qa/cppunit/test_breakiterator.cxx|   64 +-
 i18npool/qa/cppunit/test_characterclassification.cxx  |4 
 i18npool/source/breakiterator/breakiteratorImpl.cxx   |2 
 i18npool/source/collator/chaptercollator.cxx  |4 
 i18npool/source/collator/collator_unicode.cxx |4 
 i18npool/source/indexentry/indexentrysupplier.cxx |2 
 i18npool/source/indexentry/indexentrysupplier_ja_phonetic.cxx |4 
 i18npool/source/nativenumber/nativenumbersupplier.cxx |2 
 i18npool/source/ordinalsuffix/ordinalsuffix.cxx   |2 
 9 files changed, 44 insertions(+), 44 deletions(-)

New commits:
commit 3bbed358b617eb407184edac9a11aed62e36a2d7
Author: Stephan Bergmann 
AuthorDate: Thu Oct 19 10:30:18 2023 +0200
Commit: Stephan Bergmann 
CommitDate: Fri Oct 20 07:06:43 2023 +0200

Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: i18npool

Change-Id: If3eb4d8fb3068e26ce42c8cc751c2de38b5d04cb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158202
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/i18npool/qa/cppunit/test_breakiterator.cxx 
b/i18npool/qa/cppunit/test_breakiterator.cxx
index 9edadaaf4755..4463f46270e1 100644
--- a/i18npool/qa/cppunit/test_breakiterator.cxx
+++ b/i18npool/qa/cppunit/test_breakiterator.cxx
@@ -92,7 +92,7 @@ void TestBreakIterator::testLineBreaking()
 
 //See https://bugs.libreoffice.org/show_bug.cgi?id=49849
 {
-static constexpr OUStringLiteral aWord = 
u"\u05DE\u05D9\u05DC\u05D9\u05DD";
+static constexpr OUString aWord = 
u"\u05DE\u05D9\u05DC\u05D9\u05DD"_ustr;
 OUString aTest(aWord + " " + aWord);
 
 aLocale.Language = "he";
@@ -148,8 +148,8 @@ void TestBreakIterator::testLineBreaking()
 
 //See https://bugs.documentfoundation.org/show_bug.cgi?id=96197
 {
-static constexpr OUStringLiteral aTest = u"\uc560\uad6D\uac00\uc758 
\uac00"
-   "\uc0ac\ub294";
+static constexpr OUString aTest = u"\uc560\uad6D\uac00\uc758 \uac00"
+   "\uc0ac\ub294"_ustr;
 
 aLocale.Language = "ko";
 aLocale.Country = "KR";
@@ -226,7 +226,7 @@ void TestBreakIterator::testWordBoundaries()
 
 //See https://bz.apache.org/ooo/show_bug.cgi?id=14904
 {
-static constexpr OUStringLiteral aTest =
+static constexpr OUString aTest =
 u"Working \u201CWords"
 " starting wit"
 "h quotes\u201D Work"
@@ -234,7 +234,7 @@ void TestBreakIterator::testWordBoundaries()
 "?Spanish? doe"
 "sn\u2019t work. No"
 "t even \u00BFreal? "
-"Spanish";
+"Spanish"_ustr;
 
 aBounds = m_xBreak->getWordBoundary(aTest, 4, aLocale, 
i18n::WordType::DICTIONARY_WORD, false);
 CPPUNIT_ASSERT_EQUAL(sal_Int32(0), aBounds.startPos);
@@ -462,8 +462,8 @@ void TestBreakIterator::testWordBoundaries()
 break;
 }
 
-static constexpr OUStringLiteral aTest =
-u"I\u200Bwant\u200Bto\u200Bgo";
+static constexpr OUString aTest =
+u"I\u200Bwant\u200Bto\u200Bgo"_ustr;
 
 sal_Int32 nPos = 0;
 sal_Int32 aExpected[] = {1, 6, 9, 12};
@@ -498,11 +498,11 @@ void TestBreakIterator::testWordBoundaries()
 break;
 }
 
-static constexpr OUStringLiteral aTest =
+static constexpr OUString aTest =
 u"\u1F0C\u03BD\u03B4\u03C1\u03B1 \u1F00"
 "\u03C1\u03BD\u1F7B\u03BC\u03B5\u03BD\u03BF"
 "\u03C2 \u1F00\u03BB\u03BB \u1F24"
-"\u03C3\u03B8\u03B9\u03BF\u03BD";
+"\u03C3\u03B8\u03B9\u03BF\u03BD"_ustr;
 
 sal_Int32 nPos = 0;
 sal_Int32 aExpected[] = {5, 15, 19, 26};
@@ -569,8 +569,8 @@ void TestBreakIterator::testWordBoundaries()
 aLocale.Language = "en";
 aLocale.Country = "US";
 
-static constexpr OUStringLiteral aTest =
-u"ru\uFB00le \uFB01sh";
+static constexpr OUString aTest =
+u"ru\uFB00le \uFB01sh"_ustr;
 
 aBounds = m_xBreak->getWordBoundary(aTest, 1, aLocale, 
i18n::WordType::DICTIONARY_WORD, false);
 CPPUNIT_ASSERT_EQUAL(sal_Int32(0), aBounds.startPos);
@@ -586,8 +586,8 @@ void TestBreakIterator::testWordBoundaries()
 aLocale.Language = "en";
 aLocale.Country = "US";
 
-static constexpr OUStringLiteral aTest =
-u"a\u2013b\u2014c";
+static constexpr OUString aTest =
+u"a\u2013b\u2014c"_ustr;
 
 aBounds = m_xBreak->getWordBoundary(aTest, 0, aLocale, 
i18n::WordType::DICTIONARY_WORD, true);
 CPPUNIT_ASSERT_EQUAL(sal_Int32(0), aBounds.startPos);
@@ -614,7 +614,7 @@ void TestBreakIterator::testGraphemeIteration()
 aLocale.Country = "IN";
 
 {
-static constexpr OUStringLiteral 

[Libreoffice-commits] core.git: 2 commits - framework/source sal/osl sal/qa

[Stephan Bergmann (via logerrit)]

 framework/source/accelerators/acceleratorconfiguration.cxx  |8 -
 framework/source/accelerators/storageholder.cxx |2 
 framework/source/dispatch/closedispatcher.cxx   |4 
 framework/source/dispatch/servicehandler.cxx|2 
 framework/source/dispatch/systemexec.cxx|2 
 framework/source/fwe/classes/addonsoptions.cxx  |   10 +-
 framework/source/fwe/helper/propertysetcontainer.cxx|2 
 framework/source/fwe/xml/menudocumenthandler.cxx|   46 
+-
 framework/source/fwe/xml/statusbardocumenthandler.cxx   |   36 +++
 framework/source/fwe/xml/toolboxdocumenthandler.cxx |   10 +-
 framework/source/fwi/classes/protocolhandlercache.cxx   |2 
 framework/source/fwi/uielement/constitemcontainer.cxx   |2 
 framework/source/fwi/uielement/itemcontainer.cxx|4 
 framework/source/fwi/uielement/rootitemcontainer.cxx|6 -
 framework/source/helper/statusindicatorfactory.cxx  |2 
 framework/source/helper/uiconfigelementwrapperbase.cxx  |   16 +--
 framework/source/helper/uielementwrapperbase.cxx|6 -
 framework/source/jobs/jobexecutor.cxx   |4 
 framework/source/layoutmanager/layoutmanager.cxx|2 
 framework/source/loadenv/loadenv.cxx|4 
 framework/source/recording/dispatchrecorder.cxx |2 
 framework/source/services/autorecovery.cxx  |   24 ++---
 framework/source/services/pathsettings.cxx  |   10 +-
 framework/source/uiconfiguration/imagemanagerimpl.cxx   |4 
 framework/source/uielement/fontsizemenucontroller.cxx   |2 
 framework/source/uielement/langselectionstatusbarcontroller.cxx |2 
 framework/source/uielement/macrosmenucontroller.cxx |2 
 framework/source/uielement/menubarmanager.cxx   |2 
 framework/source/uielement/newmenucontroller.cxx|4 
 framework/source/uielement/recentfilesmenucontroller.cxx|8 -
 framework/source/uielement/toolbarsmenucontroller.cxx   |8 -
 framework/source/uielement/uicommanddescription.cxx |   16 +--
 framework/source/xml/imagesdocumenthandler.cxx  |   10 +-
 sal/osl/unx/pipe.cxx|4 
 sal/qa/osl/pipe/osl_Pipe.cxx|8 -
 sal/qa/rtl/digest/rtl_digest.cxx|2 
 sal/qa/rtl/oustringbuffer/test_oustringbuffer_utf32.cxx |   16 +--
 sal/qa/rtl/process/rtl_Process.cxx  |4 
 sal/qa/rtl/textenc/rtl_textcvt.cxx  |2 
 39 files changed, 150 insertions(+), 150 deletions(-)

New commits:
commit 35948cad8d41c0e70debb442b8f6182b28f0a65a
Author: Stephan Bergmann 
AuthorDate: Thu Oct 19 10:30:23 2023 +0200
Commit: Stephan Bergmann 
CommitDate: Fri Oct 20 07:06:31 2023 +0200

Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: sal

Change-Id: If4a7951fd3f9f7f2e081e6b8ba482566260c3235
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158209
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/sal/osl/unx/pipe.cxx b/sal/osl/unx/pipe.cxx
index 9aaa83bcb79e..43f577ba8f44 100644
--- a/sal/osl/unx/pipe.cxx
+++ b/sal/osl/unx/pipe.cxx
@@ -37,8 +37,8 @@
 #include 
 #include 
 
-constexpr OStringLiteral PIPEDEFAULTPATH = "/tmp";
-constexpr OStringLiteral PIPEALTERNATEPATH = "/var/tmp";
+constexpr OString PIPEDEFAULTPATH = "/tmp"_ostr;
+constexpr OString PIPEALTERNATEPATH = "/var/tmp"_ostr;
 
 static oslPipe osl_psz_createPipe(const char *pszPipeName, oslPipeOptions 
Options, oslSecurity Security);
 
diff --git a/sal/qa/osl/pipe/osl_Pipe.cxx b/sal/qa/osl/pipe/osl_Pipe.cxx
index 39c9e99864f6..62463f8868dc 100644
--- a/sal/qa/osl/pipe/osl_Pipe.cxx
+++ b/sal/qa/osl/pipe/osl_Pipe.cxx
@@ -82,11 +82,11 @@ static void printPipeError( ::osl::Pipe const & aPipe )
 
 // pipe name and transfer contents
 
-constexpr OUStringLiteral aTestPipeName(u"testpipe2");
-constexpr OUStringLiteral aTestPipe1(u"testpipe1");
+constexpr OUString aTestPipeName(u"testpipe2"_ustr);
+constexpr OUString aTestPipe1(u"testpipe1"_ustr);
 
-constexpr OStringLiteral m_pTestString1("Sun Microsystems");
-constexpr OStringLiteral m_pTestString2("test pipe PASS/OK");
+constexpr OString m_pTestString1("Sun Microsystems"_ostr);
+constexpr OString m_pTestString2("test pipe PASS/OK"_ostr);
 
 // test code start here
 
diff --git a/sal/qa/rtl/digest/rtl_digest.cxx b/sal/qa/rtl/digest/rtl_digest.cxx
index f62e951a7295..e259eead6a69 100644
--- a/sal/qa/rtl/digest/rtl_digest.cxx
+++ b/sal/qa/rtl/digest/rtl_digest.cxx
@@ -36,7 +36,7 @@ using namespace rtl;
 namespace
 {
 
-constexpr 

[Libreoffice-bugs] [Bug 142124] In FORMATTING (Styles) there is NO VERTICAL ALIGNMENT option for table rows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=142124

BogdanB  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 142124] In FORMATTING (Styles) there is NO VERTICAL ALIGNMENT option for table rows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=142124

--- Comment #6 from BogdanB  ---
Created attachment 190307
  --> https://bugs.documentfoundation.org/attachment.cgi?id=190307=edit
Demo document

In this document, I have a word "TEST" in a cell with a style "Footer left".
The vertical alignment can be changed from the table toolbar (to be vertical
centered), but not from "Footer left" style.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154052] Make "Level" spinbox into a dropdown menu in the Document tab of "Insert - Field"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=154052

Baole Fang  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |baole.f...@gmail.com
   |desktop.org |
 Status|NEW |ASSIGNED

--- Comment #6 from Baole Fang  ---
start working on this

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: winaccessibility/source

[Michael Weghorn (via logerrit)]

 winaccessibility/source/UAccCOM/MAccessible.cxx |  196 
 winaccessibility/source/UAccCOM/MAccessible.h   |5 
 2 files changed, 201 deletions(-)

New commits:
commit fc06de1b23df9c80445c99def36beab6efa755cb
Author: Michael Weghorn 
AuthorDate: Thu Oct 19 16:42:58 2023 +0100
Commit: Michael Weghorn 
CommitDate: Fri Oct 20 05:47:47 2023 +0200

wina11y: Drop now unused CMAccessible::get_String4Numbering etc.

`CMAccessible::get_String4Numbering` is unused since

commit 2bf88c172c9c9d159344b95fb96073f4891a6c30
Author: Michael Weghorn 
Date:   Wed Oct 18 13:44:42 2023 +0200

tdf#157696 wina11y: Switch from custom to IA2 text attributes

, so drop it.
This means that `CMAccessible::get_StringFromAny` is then
also unused, so drop it as well.

Change-Id: I35abc94b2fc2ecec1789918fbf4ed6707a96c974
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158195
Tested-by: Jenkins
Reviewed-by: Michael Weghorn 

diff --git a/winaccessibility/source/UAccCOM/MAccessible.cxx 
b/winaccessibility/source/UAccCOM/MAccessible.cxx
index eff02d6ade31..e8f29c8192d2 100644
--- a/winaccessibility/source/UAccCOM/MAccessible.cxx
+++ b/winaccessibility/source/UAccCOM/MAccessible.cxx
@@ -2439,202 +2439,6 @@ IAccessible* 
CMAccessible::get_IAccessibleFromXAccessible(XAccessible* pXAcc)
 return nullptr;
 }
 
-OUString CMAccessible::get_StringFromAny(Any const & pAny)
-{
-switch(pAny.getValueTypeClass())
-{
-case TypeClass_CHAR:
-{
-sal_Int8 val;
-pAny >>= val;
-return OUString::number(val);
-}
-case TypeClass_BOOLEAN:
-{
-bool val;
-pAny >>= val;
-return OUString::number(int(val));
-}
-case TypeClass_BYTE:
-{
-sal_Int8 val;
-pAny >>= val;
-return OUString::number(val);
-}
-case TypeClass_SHORT:
-{
-sal_Int16 val;
-pAny >>= val;
-return OUString::number(val);
-}
-case TypeClass_UNSIGNED_SHORT:
-{
-sal_uInt16 val;
-pAny >>= val;
-return OUString::number(val);
-}
-case TypeClass_LONG:
-{
-sal_Int32 val;
-pAny >>= val;
-return OUString::number(val);
-}
-case TypeClass_UNSIGNED_LONG:
-{
-sal_uInt32 val;
-pAny >>= val;
-return OUString::number(val);
-}
-case TypeClass_FLOAT:
-{
-float val;
-pAny >>= val;
-return OUString::number(val);
-}
-case TypeClass_DOUBLE:
-{
-double val;
-pAny >>= val;
-return OUString::number(val);
-}
-case TypeClass_STRING:
-{
-OUString val;
-pAny >>= val;
-return val;
-}
-case TypeClass_SEQUENCE:
-{
-if(pAny.getValueType() == cppu::UnoType>::get())
-{
-Sequence < OUString > val;
-pAny >>= val;
-
-OUStringBuffer pString;
-
-for (const OUString& rElem : val)
-pString.append(rElem);
-
-return pString.makeStringAndClear();
-}
-else if (pAny.getValueType() == cppu::UnoType>::get())
-{
-Sequence < css::style::TabStop > val;
-pAny >>= val;
-
-OUStringBuffer buf;
-for (const css::style::TabStop& rSingleVal : val)
-{
-buf.append(
-"Position=" + OUString::number(rSingleVal.Position) + 
",TabAlign="
-+ OUString::number(sal_Int32(rSingleVal.Alignment)) + 
",DecimalChar=");
-if (rSingleVal.DecimalChar==';' || rSingleVal.DecimalChar 
== ':' || rSingleVal.DecimalChar == ',' ||
-rSingleVal.DecimalChar == '=' || 
rSingleVal.DecimalChar == '\\')
-buf.append('\\');
-buf.append(OUStringChar(rSingleVal.DecimalChar) + 
",FillChar=");
-if (rSingleVal.FillChar==';' || rSingleVal.FillChar == ':' 
|| rSingleVal.FillChar == ',' ||
-rSingleVal.FillChar == '=' || rSingleVal.FillChar == 
'\\')
-buf.append('\\');
-buf.append(OUStringChar(rSingleVal.FillChar) + ",");
-}
-return buf.makeStringAndClear();
-}
-break;
-}
-case TypeClass_ENUM:
-{
-if (pAny.getValueType() == 
cppu::UnoType::get())
-{
-css::awt::FontSlant val;
-pAny >>= val;
-return OUString::number(sal_Int32(val));
-}
-break;
-}
-case 

[Libreoffice-bugs] [Bug 157833] Unable to resize columns and rows of a table inside of a frame using the cursor

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157833

--- Comment #2 from William Friedman  ---
Created attachment 190306
  --> https://bugs.documentfoundation.org/attachment.cgi?id=190306=edit
Gif video demonstrating the problem

Here's that same video in gif format in case anyone can't view the webm format.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157617] Inserting paragraph marks after a picture go unexpectedly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157617

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157331] in automatic filter, add the number of the first row where the value appears

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157331

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157821] Non-continous lines are not right rendered in SVG(Z) files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157821

--- Comment #3 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157614] Contextual menus span over 2 screens making them difficult to read

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157614

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157331] in automatic filter, add the number of the first row where the value appears

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157331

--- Comment #7 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157391] Access items in the Navigator window programatically

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157391

--- Comment #5 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157391] Access items in the Navigator window programatically

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157391

QA Administrators  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 157331] in automatic filter, add the number of the first row where the value appears

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157331

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-ux-advise] [Bug 157331] in automatic filter, add the number of the first row where the value appears

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157331

--- Comment #7 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 153779] FILESAVE Calc takes 4 minutes to save a file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=153779

--- Comment #8 from QA Administrators  ---
Dear christothemagnificent,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153939] seconds to delete 5 rows in LibreOffice 7.5 Calc, application hangs few seconds

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=153939

--- Comment #3 from QA Administrators  ---
Dear Kristof Bernaert,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 106876] [META] Find & Replace with styles

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106876
Bug 106876 depends on bug 152862, which changed state.

Bug 152862 Summary: LO Writer's Find/Replace Formats is broken when searching 
for color in styles
https://bugs.documentfoundation.org/show_bug.cgi?id=152862

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 97306] All LibreOffice apps blocked when a save dialog is opened (Gtk)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97306

--- Comment #9 from QA Administrators  ---
Dear rodhos92,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152862] LO Writer's Find/Replace Formats is broken when searching for color in styles

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=152862

--- Comment #6 from QA Administrators  ---
Dear Alexis,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 142124] In FORMATTING (Styles) there is NO VERTICAL ALIGNMENT option for table rows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=142124

--- Comment #5 from QA Administrators  ---
Dear antrrax,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 118241] FILEOPEN XLSX Basic code with CreateObject("Scripting.FileSystemObject") and “For Each ” loop does not work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=118241

--- Comment #10 from QA Administrators  ---
Dear Gabor Kelemen (allotropia),

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 83853] Other: Printing from File>Labels fails without error message

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=83853

--- Comment #18 from QA Administrators  ---
Dear Martin Thomas,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157833] Unable to resize columns and rows of a table inside of a frame using the cursor

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157833

--- Comment #1 from William Friedman  ---
Created attachment 190305
  --> https://bugs.documentfoundation.org/attachment.cgi?id=190305=edit
Video demonstrating the problem

Here's a video demonstrating the problem. The table outside the frame can be
resized by dragging; the table inside the frame cannot be.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157833] New: Unable to resize columns and rows of a table inside of a frame using the cursor

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157833

Bug ID: 157833
   Summary: Unable to resize columns and rows of a table inside of
a frame using the cursor
   Product: LibreOffice
   Version: 7.6.2.1 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: will.fried...@gmail.com

Description:
When a table is placed in a frame, there seems to be no way to drag the borders
of the columns and rows to resize them as you can with a normal table.

Steps to Reproduce:
1. Insert | Frame | Frame. Check relative to entire paragraph area. Width:
100%. Anchor: as character. (AFAICT none of these settings affect the bug.)
2. Click inside the frame. Table | Insert Table | 2 columns x 2 rows.
3. Try to hover the mouse over the line between the columns and the rows. It
never changes to the resize arrow and therefore one cannot resize the columns
or rows by dragging.

Actual Results:
Cursor never changes to the resize arrow.

Expected Results:
Cursor should change to the resize arrow.


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 7.6.2.1 (X86_64) / LibreOffice Community
Build ID: 56f7684011345957bbf33a7ee678afaf4d2ba333
CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render:
Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157831] Slow loading pages

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157831

m.a.riosv  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|UNCONFIRMED |RESOLVED
 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #1 from m.a.riosv  ---
Looks like a duplicate

*** This bug has been marked as a duplicate of bug 151763 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151763] Long pause of up to 1 min. while opening files in Windows 11 22H2

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=151763

m.a.riosv  changed:

   What|Removed |Added

 CC||steved...@yahoo.com

--- Comment #19 from m.a.riosv  ---
*** Bug 157831 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 114441] Convert use of sal_uLong to better integer types

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114441

--- Comment #71 from Commit Notification 
 ---
Adam Seskunas committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/1e6c1b672b1b93376f3c816e870d956b84e089e7

tdf#114441 Convert use of sal_uLong to better integer types

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: svtools/source

[Adam Seskunas (via logerrit)]

 svtools/source/control/ctrlbox.cxx  |4 ++--
 svtools/source/control/valueset.cxx |4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

New commits:
commit 1e6c1b672b1b93376f3c816e870d956b84e089e7
Author: Adam Seskunas 
AuthorDate: Wed Sep 20 13:54:44 2023 -0700
Commit: Hossein 
CommitDate: Fri Oct 20 03:37:45 2023 +0200

tdf#114441 Convert use of sal_uLong to better integer types

In ctrlbox.cxx, nCount and i were changed to sal_uInt32 because
aFontSizeNames.Count() returns sal_uInt32.

In valueset.cxx, nFirstItem and nLastItem are only used in a comparison
with a value of size_t. They were both changed to size_t because
nLastItem contains the product of tools::Long mnVisLines and
sal_uInt16 mnCols where tools::Long can be 64 bit in some cases.

Change-Id: Ib3f10cdf6ae81e96f28f13a0bb32699f26c8a0cb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157109
Tested-by: Jenkins
Reviewed-by: Hossein 

diff --git a/svtools/source/control/ctrlbox.cxx 
b/svtools/source/control/ctrlbox.cxx
index 22bfde7febe5..3d4ce47b0814 100644
--- a/svtools/source/control/ctrlbox.cxx
+++ b/svtools/source/control/ctrlbox.cxx
@@ -1186,8 +1186,8 @@ void FontSizeBox::Fill( const FontList* pList )
 if ( pAry == FontList::GetStdSizeAry() )
 {
 // for scalable fonts all font size names
-sal_uLong nCount = aFontSizeNames.Count();
-for( sal_uLong i = 0; i < nCount; i++ )
+sal_uInt32 nCount = aFontSizeNames.Count();
+for( sal_uInt32 i = 0; i < nCount; i++ )
 {
 OUString aSizeName = aFontSizeNames.GetIndexName( i );
 int nSize = aFontSizeNames.GetIndexSize( i );
diff --git a/svtools/source/control/valueset.cxx 
b/svtools/source/control/valueset.cxx
index 89ce7f8cdb23..87696d1a7886 100644
--- a/svtools/source/control/valueset.cxx
+++ b/svtools/source/control/valueset.cxx
@@ -1076,8 +1076,8 @@ void ValueSet::Format(vcl::RenderContext const & 
rRenderContext)
 }
 
 // draw items
-sal_uLong nFirstItem = static_cast(mnFirstLine) * mnCols;
-sal_uLong nLastItem = nFirstItem + (mnVisLines * mnCols);
+size_t nFirstItem = static_cast(mnFirstLine) * mnCols;
+size_t nLastItem = nFirstItem + (mnVisLines * mnCols);
 
 maItemListRect.SetLeft( x );
 maItemListRect.SetTop( y );

[Libreoffice-bugs] [Bug 151763] Long pause of up to 1 min. while opening files in Windows 11 22H2

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=151763

--- Comment #18 from m.a.riosv  ---
Verify you don't have a network driver defined and not connected.
Or a printer not connected with the option Menu/Tools/Options/Load -
General – Load printer settings with the document enabled.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157719] Copying styles via keyboard shortcut (like MSO)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157719

--- Comment #6 from m.a.riosv  ---
[Ctrl+Shift+V] works with Calc, not exist for Writer.

Help about clone format (Icon):
https://help.libreoffice.org/latest/en-US/text/shared/guide/paintbrush.html?DbPAR=SHARED#bm_id380260

It's possible to customize keys combinations.
Menu/Tools/Customize [Keyboard]
Search for 'Clone'
Select the combination.
Go to the source paragraph.
Use keyboard combination.
Click on destination paragraph.
Paragraph style is applied.

I don't know if it is enough.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157818] Background color not visible in sidebar-styles-preview

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157818

m.a.riosv  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #8 from m.a.riosv  ---
Sorry, not a duplicate.

Seems it works when the style is modified, but not with direct format.

Please, can you attach the sample file.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157832] New: Property and Method error when Macro Name same as Object

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157832

Bug ID: 157832
   Summary: Property and Method error when Macro Name same as
Object
   Product: LibreOffice
   Version: 7.6.2.1 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: martin.brie...@mbsoft.nu

When a Macro has the same name as an Object, an Error is issued that Property
or Method can not be found.

To re-create, save a Macro (File) with the name ComboBox and have a Macro with
the same Object name. The Debugger shows the right Properties, but the Macro
issues the Error that Property or Method can not be found. i.e.
ComboBox.SelectedText

Apparently there is no distinction between the Module Name and the Object Name
when a Macro is executed. It doesn't matter, if the Object is in a different
Macro (sub routine).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: helpcontent2

[Olivier Hallot (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 26a08eb18eb18963652b063ce8bfb3e36b7529f4
Author: Olivier Hallot 
AuthorDate: Thu Oct 19 21:33:07 2023 -0300
Commit: Gerrit Code Review 
CommitDate: Fri Oct 20 02:33:07 2023 +0200

Update git submodules

* Update helpcontent2 from branch 'master'
  to f7585dc09a544ff865dcf39f55cb81d77e9d73ba
  - tdf#155876 UI cmds Calc (05)

+ refactoring
+ Edit menu - Final

Change-Id: I4ff166ba0d6d4d009eb97a8cdb3c361abf776612
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/158213
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 7d08444f187d..f7585dc09a54 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 7d08444f187ddea8a983565fc2c7fb8b2a38176c
+Subproject commit f7585dc09a544ff865dcf39f55cb81d77e9d73ba

[Libreoffice-commits] help.git: source/text

[Olivier Hallot (via logerrit)]

 source/text/scalc/main0102.xhp |   15 +++
 source/text/shared/01/0218.xhp |6 +-
 source/text/shared/01/0220.xhp |1 +
 source/text/swriter/main0102.xhp   |   15 ++-
 4 files changed, 11 insertions(+), 26 deletions(-)

New commits:
commit f7585dc09a544ff865dcf39f55cb81d77e9d73ba
Author: Olivier Hallot 
AuthorDate: Thu Oct 19 19:37:11 2023 -0300
Commit: Olivier Hallot 
CommitDate: Fri Oct 20 02:33:07 2023 +0200

tdf#155876 UI cmds Calc (05)

+ refactoring
+ Edit menu - Final

Change-Id: I4ff166ba0d6d4d009eb97a8cdb3c361abf776612
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/158213
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/source/text/scalc/main0102.xhp b/source/text/scalc/main0102.xhp
index 74c251bae1..8cedebec4f 100644
--- a/source/text/scalc/main0102.xhp
+++ b/source/text/scalc/main0102.xhp
@@ -26,11 +26,9 @@
 
 
 
-
-
-
 
 
+
 Edit
 This menu contains commands for editing the contents of the current 
document.
 
@@ -47,15 +45,8 @@
 
 
 
-
-
-
-Links
-
-
-Object
-
+
+
 
 
-
 
diff --git a/source/text/shared/01/0218.xhp 
b/source/text/shared/01/0218.xhp
index ff4eb64cd0..244c236248 100644
--- a/source/text/shared/01/0218.xhp
+++ b/source/text/shared/01/0218.xhp
@@ -37,8 +37,12 @@
 
 
 
-Edit External Links
+
+  Links to External 
FilesExternal 
Links
+
   You can change or break each link to external 
files in the current document. You can also update the content of the current 
file to the most recently saved version of linked external file. This command 
does not apply to hyperlinks, and is not available if the current document does 
not contain links to other files.
+
+
 This command can be 
used with external file links to sections (place cursor outside of the section), master 
documents,sheets linked with 
Sheet - Insert Sheet from File or Sheet - 
External Links, Function WEBSERVICE, 
images and OLE objects (when inserted with a link to an external 
file).
 
 
diff --git a/source/text/shared/01/0220.xhp 
b/source/text/shared/01/0220.xhp
index 1a24952c6d..4dda4b7e31 100644
--- a/source/text/shared/01/0220.xhp
+++ b/source/text/shared/01/0220.xhp
@@ -34,6 +34,7 @@
   
 
 
+
 Save Copy as
 Opens the Save as dialog to save a copy of the 
object in a file. The file extension suggested depends on the type of the OLE 
object.
 
diff --git a/source/text/swriter/main0102.xhp b/source/text/swriter/main0102.xhp
index 0dbec975d6..379b9f24fa 100644
--- a/source/text/swriter/main0102.xhp
+++ b/source/text/swriter/main0102.xhp
@@ -26,9 +26,8 @@
 
 
 
-
 
-
+
 Edit
 This menu contains commands for editing the contents of the current 
document.
 
@@ -43,30 +42,20 @@
 
 
 
-
 
 
-
 
-
 
 
-
 
 
 
 Fields
 
-
-External Links
-
-
+
 
-
 
-
 
-
 
 
 

[Libreoffice-bugs] [Bug 155876] [LOCALHELP] - Calc - Help pages about dialogs should provide instructions for the Tabbed UI

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155876

--- Comment #8 from Commit Notification 
 ---
Olivier Hallot committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/f7585dc09a544ff865dcf39f55cb81d77e9d73ba

tdf#155876 UI cmds Calc (05)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: download.lst external/lxml

[Taichi Haradaguchi (via logerrit)]

 download.lst   
 |4 -
 
external/lxml/0001-Make-regexp-string-raw-to-correct-its-escape-sequenc.patch.1 
|   31 ++
 external/lxml/README   
 |6 -
 external/lxml/UnpackedTarball_lxml.mk  
 |5 -
 external/lxml/Wincompatible-function-pointer-types.patch   
 |   20 --
 external/lxml/replace-setuptools-with-distutils.patch.0
 |   11 +++
 6 files changed, 49 insertions(+), 28 deletions(-)

New commits:
commit a4b4a90557f9fc1839fc0eb297f4c6a4e94c761a
Author: Taichi Haradaguchi <20001...@ymail.ne.jp>
AuthorDate: Sun Jul 2 14:54:23 2023 +0900
Commit: Taichi Haradaguchi <20001...@ymail.ne.jp>
CommitDate: Fri Oct 20 02:23:12 2023 +0200

lxml: upgrade to release 4.9.2

* external/lxml/Wincompatible-function-pointer-types.patch: fixed upstream.
* backport 
external/lxml/0001-Make-regexp-string-raw-to-correct-its-escape-sequenc.patch.1
  from .

Changelog: https://lxml.de/4.9/changes-4.9.2.html

Change-Id: I8ea947b3b1fb30b9427d066bd41a5d4693ceedbf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153863
Tested-by: Jenkins
Reviewed-by: Taichi Haradaguchi <20001...@ymail.ne.jp>

diff --git a/download.lst b/download.lst
index 0a113753fbf9..ad03e50a6ad4 100644
--- a/download.lst
+++ b/download.lst
@@ -431,8 +431,8 @@ LPSOLVE_TARBALL := 
26b3e95ddf3d9c077c480ea45874b3b8-lp_solve_5.5.tar.gz
 # three static lines
 # so that git cherry-pick
 # will not run into conflicts
-LXML_SHA256SUM := 
940caef1ec7c78e0c34b0f6b94fe42d0f2022915ffc78643d28538a5cfd0f40e
-LXML_TARBALL := lxml-4.1.1.tgz
+LXML_SHA256SUM := 
2455cfaeb7ac70338b3257f41e21f0724f4b5b0c0e7702da67ee6c3640835b67
+LXML_TARBALL := lxml-4.9.2.tgz
 # three static lines
 # so that git cherry-pick
 # will not run into conflicts
diff --git 
a/external/lxml/0001-Make-regexp-string-raw-to-correct-its-escape-sequenc.patch.1
 
b/external/lxml/0001-Make-regexp-string-raw-to-correct-its-escape-sequenc.patch.1
new file mode 100644
index ..ce1ec383cc63
--- /dev/null
+++ 
b/external/lxml/0001-Make-regexp-string-raw-to-correct-its-escape-sequenc.patch.1
@@ -0,0 +1,31 @@
+From 9686dd9c7670d18acff6360c8444520273d5f1b2 Mon Sep 17 00:00:00 2001
+From: Jakub Wilk 
+Date: Fri, 16 Jun 2023 09:24:21 +0200
+Subject: [PATCH] Make regexp string raw to correct its escape sequence usage
+ (GH-371)
+
+Fixes:
+
+$ python3 -Wd setup.py
+setup.py:117: DeprecationWarning: invalid escape sequence \.
+...
+---
+ setup.py | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/setup.py b/setup.py
+index 709cbc68..7a3f46e5 100644
+--- a/setup.py
 b/setup.py
+@@ -114,7 +114,7 @@ extra_options['packages'] = [
+ 
+ def setup_extra_options():
+ is_interesting_package = re.compile('^(libxml|libxslt|libexslt)$').match
+-is_interesting_header = re.compile('^(zconf|zlib|.*charset)\.h$').match
++is_interesting_header = re.compile(r'^(zconf|zlib|.*charset)\.h$').match
+ 
+ def extract_files(directories, pattern='*'):
+ def get_files(root, dir_path, files):
+-- 
+2.39.2
+
diff --git a/external/lxml/README b/external/lxml/README
index ad9f0952c6b3..be90f0a862ce 100644
--- a/external/lxml/README
+++ b/external/lxml/README
@@ -1,7 +1,7 @@
-LXML XML processing python Library from [http://lxml.de/].
+LXML XML processing python Library from [https://lxml.de/].
 
 This library is used for the .ui accessibility checker bin/gla11y
 
 The archive was downloaded from:
-[http://lxml.de/files/lxml-4.1.1.tgz]
-on 2018-02-22.
+[https://lxml.de/files/lxml-4.9.2.tgz]
+on 2023-07-17.
diff --git a/external/lxml/UnpackedTarball_lxml.mk 
b/external/lxml/UnpackedTarball_lxml.mk
index 3f4180404870..8d032e70dd90 100644
--- a/external/lxml/UnpackedTarball_lxml.mk
+++ b/external/lxml/UnpackedTarball_lxml.mk
@@ -11,10 +11,9 @@ $(eval $(call gb_UnpackedTarball_UnpackedTarball,lxml))
 
 $(eval $(call gb_UnpackedTarball_set_tarball,lxml,$(LXML_TARBALL)))
 
-$(eval $(call gb_UnpackedTarball_set_patchlevel,lxml,0))
-
 $(eval $(call gb_UnpackedTarball_add_patches,lxml, \
-external/lxml/Wincompatible-function-pointer-types.patch \
+   
external/lxml/0001-Make-regexp-string-raw-to-correct-its-escape-sequenc.patch.1 
\
+   external/lxml/replace-setuptools-with-distutils.patch.0 \
 ))
 
 # vim: set noet sw=4 ts=4:
diff --git a/external/lxml/Wincompatible-function-pointer-types.patch 
b/external/lxml/Wincompatible-function-pointer-types.patch
deleted file mode 100644
index bb9c7a02918b..
--- a/external/lxml/Wincompatible-function-pointer-types.patch
+++ /dev/null
@@ -1,20 +0,0 @@
 src/lxml/etree.c
-+++ src/lxml/etree.c
-@@ -6810,7 +6810,7 @@
- static void __pyx_f_4lxml_5etree__xpath_function_call(xmlXPathParserContext 
*, int); /*proto*/
- 

[Libreoffice-commits] core.git: vcl/osx

[Patrick Luby (via logerrit)]

 vcl/osx/salframe.cxx |   25 +++--
 1 file changed, 23 insertions(+), 2 deletions(-)

New commits:
commit fb68f0761c3cfadf73f261d2d44de7b4e277e0af
Author: Patrick Luby 
AuthorDate: Thu Oct 19 16:32:33 2023 -0400
Commit: Patrick Luby 
CommitDate: Fri Oct 20 02:20:42 2023 +0200

tdf#157565 show tooltip if any parent window is the key window

Commit b69db38a38b09e158e8d46d8b717db85860ca874 caused tooltips
to fail to appear if their immediate parent window was not the
key window. So, look through the parent window's parent windows
and, if any of those windows are the kwy window, show the tooltip.

Change-Id: Icf1aed1144fdeac03b4b208de8ed8ee2db8ad4a0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158212
Tested-by: Jenkins
Reviewed-by: Patrick Luby 

diff --git a/vcl/osx/salframe.cxx b/vcl/osx/salframe.cxx
index 98c165d9659f..d20e6e3d8422 100644
--- a/vcl/osx/salframe.cxx
+++ b/vcl/osx/salframe.cxx
@@ -468,8 +468,29 @@ void AquaSalFrame::Show(bool bVisible, bool bNoActivate)
 // Also, don't display tooltips when mousing over non-key windows even if
 // the application is active as the tooltip window will pull the non-key
 // window in front of the key window.
-if (bVisible && (mnStyle & SalFrameStyleFlags::TOOLTIP) && (![NSApp 
isActive] || (mpParent && ![ mpParent->mpNSWindow isKeyWindow])))
-return;
+if (bVisible && (mnStyle & SalFrameStyleFlags::TOOLTIP))
+{
+if (![NSApp isActive])
+return;
+
+if (mpParent)
+{
+// tdf#157565 show tooltip if any parent window is the key window
+bool bKeyWindowFound = false;
+NSWindow *pParent = mpParent->mpNSWindow;
+while (pParent)
+{
+if ([pParent isKeyWindow])
+{
+bKeyWindowFound = true;
+break;
+}
+pParent = [pParent parentWindow];
+}
+if (!bKeyWindowFound)
+return;
+}
+}
 
 mbShown = bVisible;
 if(bVisible)

[Libreoffice-commits] core.git: sw/qa sw/source

[Mike Kaganski (via logerrit)]

 sw/qa/extras/tiledrendering/tiledrendering.cxx |   10 +-
 sw/source/core/doc/DocumentRedlineManager.cxx  |   23 +++
 2 files changed, 24 insertions(+), 9 deletions(-)

New commits:
commit 34ac12dca3f5af50fddfb7c77e2943897980b815
Author: Mike Kaganski 
AuthorDate: Thu Oct 19 20:32:56 2023 +0300
Commit: Mike Kaganski 
CommitDate: Fri Oct 20 00:55:03 2023 +0200

Do not forget to notify in cases when modified redline's start/end don't 
move

SwRangeRedline::SetStart/SetEnd call MaybeNotifyRedlineModification,
which means that e.g. continuing typing at the end of the current
redline would continue sending notifications. But as soon as cursor
is moved (e.g. using arrow left, inside the current redline), the
next modification is completely inside the current one, and would
be simply deleted. In this case (and other similar), notifications
weren't sent.

This change tries to make sure that every such case is handled. In
case of delete-inside-insert, when positions are equal, the current
redline is deleted; MaybeNotifyRedlineModification is not called,
to not crash. I don't know if this needs additional notification.

Change-Id: I2a97354623a5a784928ce4e1f2c93606954bd11c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158198
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/sw/qa/extras/tiledrendering/tiledrendering.cxx 
b/sw/qa/extras/tiledrendering/tiledrendering.cxx
index 13a882b7f82f..d66a2bc98c2d 100644
--- a/sw/qa/extras/tiledrendering/tiledrendering.cxx
+++ b/sw/qa/extras/tiledrendering/tiledrendering.cxx
@@ -1652,9 +1652,9 @@ CPPUNIT_TEST_FIXTURE(SwTiledRenderingTest, 
testRedlineUpdateCallback)
 m_nRedlineTableEntryModified = 0;
 pWrtShell->DelLeft();
 
-// Assert that we get exactly one notification about the redline update.
+// Assert that we get exactly two notification about the redline update.
 // This was 0, as LOK_CALLBACK_REDLINE_TABLE_ENTRY_MODIFIED wasn't sent.
-CPPUNIT_ASSERT_EQUAL(1, m_nRedlineTableEntryModified);
+CPPUNIT_ASSERT_EQUAL(2, m_nRedlineTableEntryModified);
 
 // Turn off the change tracking mode, make some modification to left of the
 // redline so that its position changes
@@ -1663,18 +1663,18 @@ CPPUNIT_TEST_FIXTURE(SwTiledRenderingTest, 
testRedlineUpdateCallback)
 pWrtShell->Insert("This text is left of the redline");
 
 // Position of the redline has changed => Modify callback
-CPPUNIT_ASSERT_EQUAL(2, m_nRedlineTableEntryModified);
+CPPUNIT_ASSERT_EQUAL(3, m_nRedlineTableEntryModified);
 
 pWrtShell->DelLeft();
 // Deletion also emits Modify callback
-CPPUNIT_ASSERT_EQUAL(3, m_nRedlineTableEntryModified);
+CPPUNIT_ASSERT_EQUAL(4, m_nRedlineTableEntryModified);
 
 // Make changes to the right of the redline => no position change in 
redline
 pWrtShell->Right(SwCursorSkipMode::Chars, /*bSelect=*/false, 100/*Go 
enough right */, /*bBasicCall=*/false);
 pWrtShell->Insert("This text is right of the redline");
 
 // No Modify callbacks
-CPPUNIT_ASSERT_EQUAL(3, m_nRedlineTableEntryModified);
+CPPUNIT_ASSERT_EQUAL(4, m_nRedlineTableEntryModified);
 }
 
 CPPUNIT_TEST_FIXTURE(SwTiledRenderingTest, testGetViewRenderState)
diff --git a/sw/source/core/doc/DocumentRedlineManager.cxx 
b/sw/source/core/doc/DocumentRedlineManager.cxx
index f5ab5a9fdba3..7a9af1ee8891 100644
--- a/sw/source/core/doc/DocumentRedlineManager.cxx
+++ b/sw/source/core/doc/DocumentRedlineManager.cxx
@@ -1427,6 +1427,7 @@ DocumentRedlineManager::AppendRedline(SwRangeRedline* 
pNewRedl, bool const bCall
 !pRedl->IsMoved() )
 {
 bool bDelete = false;
+bool bMaybeNotify = false;
 
 // Merge if applicable?
 if( (( SwComparePosition::Behind == eCmpPos &&
@@ -1477,22 +1478,22 @@ DocumentRedlineManager::AppendRedline(SwRangeRedline* 
pNewRedl, bool const bCall
 *pStt = *pREnd;
 if( ( *pStt == *pEnd ) &&
 ( pNewRedl->GetContentIdx() == nullptr ) )
-bDelete = true;
+bDelete = bMaybeNotify = true;
 }
 else if( SwComparePosition::OverlapBefore == eCmpPos )
 {
 *pEnd = *pRStt;
 if( ( *pStt == *pEnd ) &&
 ( pNewRedl->GetContentIdx() == nullptr ) )
-bDelete = true;
+bDelete = bMaybeNotify = true;
 }
 else if( SwComparePosition::Inside == eCmpPos )
 {
-bDelete = true;
+bDelete = bMaybeNotify = true;
 bMerged = true;
 }
  

[Libreoffice-bugs] [Bug 151318] Calc opening of the document very slow

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=151318

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||1763

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157831] Slow loading pages

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157831

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||1763

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151763] Long pause of up to 1 min. while opening files in Windows 11 22H2

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=151763

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||7831,
   ||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||1318
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO
 CC||stephane.guillou@libreoffic
   ||e.org

--- Comment #17 from Stéphane Guillou (stragu) 
 ---
Alex, do you still experience this with both Windows and LO up to date?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 108252] [META] Cell-related bugs and enhancements (including formatting)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108252

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||157618


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=157618
[Bug 157618] FILESAVE: Calc ignores directly formatted text color in .ods files
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157618] FILESAVE: Calc ignores directly formatted text color in .ods files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157618

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Blocks||108252
 Ever confirmed|0   |1
   Keywords||bibisectRequest,
   ||filter:ods, regression
 Status|UNCONFIRMED |NEW
 OS|macOS (All) |All
 CC||stephane.guillou@libreoffic
   ||e.org

--- Comment #7 from Stéphane Guillou (stragu) 
 ---
Thanks Patrick. Reproduced on Linux with:

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: b83f069101f1e6d8aaac09a805f02bbc4c619e7a
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108252
[Bug 108252] [META] Cell-related bugs and enhancements (including formatting)
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: l10ntools/source

[Stephan Bergmann (via logerrit)]

 l10ntools/source/merge.cxx|2 +-
 l10ntools/source/xmlparse.cxx |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit f6f00918854bae7f03e79192e5d79f78929cb418
Author: Stephan Bergmann 
AuthorDate: Thu Oct 19 10:30:19 2023 +0200
Commit: Stephan Bergmann 
CommitDate: Thu Oct 19 23:20:34 2023 +0200

Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: l10ntools

Change-Id: I4878e2209b8499e02b7a6c13867b1a3aa4dad7e7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158204
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/l10ntools/source/merge.cxx b/l10ntools/source/merge.cxx
index 8327442b0af2..2ad9d8261fb8 100644
--- a/l10ntools/source/merge.cxx
+++ b/l10ntools/source/merge.cxx
@@ -150,7 +150,7 @@ MergeDataFile::MergeDataFile(
 OString sLang;
 //Get language id from path
 {
-static constexpr OStringLiteral 
sTransSource("translations/source/");
+static constexpr OString sTransSource("translations/source/"_ostr);
 const sal_Int32 nStart =
 sPoFileName.indexOf(sTransSource)+sTransSource.getLength();
 const sal_Int32 nCount =
diff --git a/l10ntools/source/xmlparse.cxx b/l10ntools/source/xmlparse.cxx
index b3fa97ae00d0..51186ac5c623 100644
--- a/l10ntools/source/xmlparse.cxx
+++ b/l10ntools/source/xmlparse.cxx
@@ -36,7 +36,7 @@
 
 using namespace osl;
 
-constexpr OStringLiteral XML_LANG = "xml-lang";
+constexpr OString XML_LANG = "xml-lang"_ostr;
 
 
 

[Libreoffice-commits] core.git: hwpfilter/source

[Stephan Bergmann (via logerrit)]

 hwpfilter/source/hwpreader.cxx |8 
 1 file changed, 4 insertions(+), 4 deletions(-)

New commits:
commit f290768698b24e0d4e7cbf29d6255dc083f02001
Author: Stephan Bergmann 
AuthorDate: Thu Oct 19 10:30:17 2023 +0200
Commit: Stephan Bergmann 
CommitDate: Thu Oct 19 23:20:14 2023 +0200

Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: hwpfilter

Change-Id: I49a08f7102ad6669a5f307c412d07a8040249b12
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158201
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/hwpfilter/source/hwpreader.cxx b/hwpfilter/source/hwpreader.cxx
index 8ff1ba1d7541..450e582ca504 100644
--- a/hwpfilter/source/hwpreader.cxx
+++ b/hwpfilter/source/hwpreader.cxx
@@ -45,7 +45,7 @@
 #include 
 
 // xmloff/xmlkyd.hxx
-constexpr OUStringLiteral sXML_CDATA = u"CDATA";
+constexpr OUString sXML_CDATA = u"CDATA"_ustr;
 
 namespace
 {
@@ -53,7 +53,7 @@ double WTI(double x) { return x / 1800.; } // unit => inch
 double WTMM(double x) { return x / 1800. * 25.4; } // unit => mm
 int WTSM(double x) { return x / 1800. * 2540; } // unit ==> 1/100 mm
 
-constexpr OUStringLiteral sBeginOfDoc(u"[\uBB38\uC11C\uC758 \uCC98\uC74C]");
+constexpr OUString sBeginOfDoc(u"[\uBB38\uC11C\uC758 \uCC98\uC74C]"_ustr);
 // U+BB38 HANGUL SYLLABLE MUN, U+C11C HANGUL SYLLABLE SEO,
 // U+C758 HANGUL SYLLABLE YI, U+CC98 HANGUL SYLLABLE CEO,
 // U+C74C HANGUL SYLLABLE EUM: "Begin of Document"
@@ -4719,8 +4719,8 @@ namespace
 {
 
 constexpr OUStringLiteral IMPLEMENTATION_NAME = 
u"com.sun.comp.hwpimport.HwpImportFilter";
-constexpr OUStringLiteral SERVICE_NAME1 = 
u"com.sun.star.document.ImportFilter";
-constexpr OUStringLiteral SERVICE_NAME2 = 
u"com.sun.star.document.ExtendedTypeDetection";
+constexpr OUString SERVICE_NAME1 = u"com.sun.star.document.ImportFilter"_ustr;
+constexpr OUString SERVICE_NAME2 = 
u"com.sun.star.document.ExtendedTypeDetection"_ustr;
 
 class HwpImportFilter : public WeakImplHelper< XFilter, XImporter, 
XServiceInfo, XExtendedFilterDetection >
 {

[Libreoffice-bugs] [Bug 108546] Sections in Footnotes cannot be formatted into multiple columns

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108546

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||1474

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146348] FILEOPEN: DOCX: Incorrect footnote with columns

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146348

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||1474

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151474] Allow formatting footnotes in columns or separated by spaces

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=151474

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Blocks||103164
Version|unspecified |Inherited From OOo
 Status|UNCONFIRMED |NEW
 CC||stephane.guillou@libreoffic
   ||e.org
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||6348,
   ||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||8546
 Ever confirmed|0   |1
   Keywords||needsUXEval

--- Comment #10 from Stéphane Guillou (stragu) 
 ---
Adding some related reports in "see also".

Request makes sens to me too -> New.

Design/UX, opinion?


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103164
[Bug 103164] [META] Footnote and Endnote bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103164] [META] Footnote and Endnote bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103164

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||151474


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=151474
[Bug 151474] Allow formatting footnotes in columns or separated by spaces
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157831] New: Slow loading pages

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157831

Bug ID: 157831
   Summary: Slow loading pages
   Product: LibreOffice
   Version: 7.6.0.3 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: steved...@yahoo.com

Description:
Suddenly now some odt and ods files require approximately 50 seconds to open. 
Problem repeats with some files, but not others.  I'm using Windows 10 Home
version 22H2 and newly installed LibreOffice 7.6.2.1.  Same problem occurs with
LO 7.6.0.3.

Actual Results:
Merely click on the file to open.

Expected Results:
Wait approximately 50 seconds for file to open.  (Then save file as docx or
xlsx to prevent problem in the future.)


Reproducible: Sometimes


User Profile Reset: Yes

Additional Info:
File should have opened instantly as normal.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 114019] [META] Tooltip bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114019
Bug 114019 depends on bug 157565, which changed state.

Bug 157565 Summary: The Font Color chooser does not show color names any more 
since 7.6
https://bugs.documentfoundation.org/show_bug.cgi?id=157565

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 85184] [META] Color picker toolbar, dialog and sidebar drop-down widget bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=85184
Bug 85184 depends on bug 157565, which changed state.

Bug 157565 Summary: The Font Color chooser does not show color names any more 
since 7.6
https://bugs.documentfoundation.org/show_bug.cgi?id=157565

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103447] Cell containing hyperlink (URL or email), is not synchronized properly between cell and input line (mismatch in display, edit and selection)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103447

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||rootki...@yahoo.it

--- Comment #14 from Stéphane Guillou (stragu) 
 ---
*** Bug 145073 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145073] Editing an email address corrupts the cell data

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145073

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||stephane.guillou@libreoffic
   ||e.org

--- Comment #3 from Stéphane Guillou (stragu) 
 ---
Not a duplicate of bug 72266.
I reproduce as described the mismatch between the inputbar and the cell in 7.2:

Version: 7.2.0.4 / LibreOffice Community
Build ID: 9a9c6381e3f7a62afc1329bd359cc48accb6435b
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

As well as a recent trunk build:

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: b83f069101f1e6d8aaac09a805f02bbc4c619e7a
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Both with gtk3 and gen VCL plugins.

This is actually the same as bug 103447, marking as duplicate.

*** This bug has been marked as a duplicate of bug 103447 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150453] [EDITING] Select all in formula bar only selects partially for URLs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=150453

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

Version|4.1.0.4 release |3.5.0 release

--- Comment #12 from Stéphane Guillou (stragu) 
 ---
Repro in:

LibreOffice 3.5.0rc3 
Build ID: 7e68ba2-a744ebf-1f241b7-c506db1-7d53735

No repro in libreoffice-3.4.6rc2. Back then, clicking in formula bar would
always format its contents as a hyperlink, and Ctrl + A would work as expected.
Likely the same cause as bug 103447.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103447] Cell containing hyperlink (URL or email), is not synchronized properly between cell and input line (mismatch in display, edit and selection)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103447

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||0453

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 120543] [META] Bugs and enhancements around hyperlinks in Calc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=120543

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||150453


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=150453
[Bug 150453] [EDITING] Select all in formula bar only selects partially for
URLs
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150453] [EDITING] Select all in formula bar only selects partially for URLs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=150453

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||stephane.guillou@libreoffic
   ||e.org
 Blocks||120543
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||3447

--- Comment #11 from Stéphane Guillou (stragu) 
 ---
Difficulty in reproducing is likely because of the "cycling" in link formatting
in the formula bar, which is described in bug 103447.

When the formula bar formats the hyperlink in blue, Ctrl + A works.
When the formula bar formats the whole cell content as plain text, Ctrl + A
misbehaves work.

I'd say both issues would likely be fixed together.

Reproduced in:

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: b83f069101f1e6d8aaac09a805f02bbc4c619e7a
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=120543
[Bug 120543] [META] Bugs and enhancements around hyperlinks in Calc
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150414] Cell / font formatting lost when data linked from external data

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=150414

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   Keywords|bibisectRequest |needsUXEval
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org

--- Comment #11 from Stéphane Guillou (stragu) 
 ---
UX/Design team, please see potential improvement options suggested in comment
10.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 150414] Cell / font formatting lost when data linked from external data

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=150414

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   Keywords|bibisectRequest |needsUXEval
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org

--- Comment #11 from Stéphane Guillou (stragu) 
 ---
UX/Design team, please see potential improvement options suggested in comment
10.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 108660] [META] Formula bar (input line) bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108660

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on|146020  |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=146020
[Bug 146020] URL field in Formula Bar behaves erratically when entered first
time
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146020] URL field in Formula Bar behaves erratically when entered first time

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146020

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||stephane.guillou@libreoffic
   ||e.org
 Status|NEW |RESOLVED
   Keywords|bibisectRequest |bibisectNotNeeded
 Resolution|--- |DUPLICATE
 Blocks|108660  |

--- Comment #4 from Stéphane Guillou (stragu) 
 ---
Thanks for the description Mike, the issue appears less unpredictable now.
Marking as duplicate of earlier bug 103447.

*** This bug has been marked as a duplicate of bug 103447 ***


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108660
[Bug 108660] [META] Formula bar (input line) bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103447] Cell containing hyperlink (URL or email), is not synchronized properly between cell and input line (mismatch in display, edit and selection)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103447

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||mikekagan...@hotmail.com

--- Comment #13 from Stéphane Guillou (stragu) 
 ---
*** Bug 146020 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 108660] [META] Formula bar (input line) bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108660

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on|114022  |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=114022
[Bug 114022] Selection in Input Line, of cell containing also an email address
as link, is not synchronized properly in the cell
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146020] URL field in Formula Bar behaves erratically when entered first time

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146020

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=11 |
   |4022|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103447] Cell containing hyperlink (URL or email), is not synchronized properly between cell and input line (mismatch in display, edit and selection)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103447

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||c...@nouenoff.nl

--- Comment #12 from Stéphane Guillou (stragu) 
 ---
*** Bug 114022 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 114022] Selection in Input Line, of cell containing also an email address as link, is not synchronized properly in the cell

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114022

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=14 |
   |6020|
 Blocks|108660  |
 Resolution|WORKSFORME  |DUPLICATE

--- Comment #9 from Stéphane Guillou (stragu) 
 ---
(In reply to Andreas Heinisch from comment #8)
> No repro in:
> Version: 7.4.0.2 (x64) / LibreOffice Community
> Build ID: 1512ce97d7ed39dce3121f7e15651fd8895f950e
> CPU threads: 16; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL:
> win
> Locale: de-DE (de_DE); UI: de-DE
> Calc: CL

I still reproduce in a recent trunk build:

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: b83f069101f1e6d8aaac09a805f02bbc4c619e7a
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

I think Andreas seeing it as "works for me" has to do with the "cycling" nature
of the issue, described by Mike in duplicate bug 146020:

(Mike Kaganski from bug 146020 comment #0)
> Created attachment 176665 [details]
> Screen cast
> 
> When a Calc cell contains a URL field, entering the formula bar first time
> does not highlight the field, *and navigates the URL content as if it is
> normal text*. Clicking to the same cell to leave formula bar, then entering
> the formula bar again, (but *not* leaving this cell!) highlights the field,
> and starts to "jump" over the field, and usual. Leaving the cell, and
> entering it again, starts the sequence anew.

Marking as duplicate of earlier bug 103447.

*** This bug has been marked as a duplicate of bug 103447 ***


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108660
[Bug 108660] [META] Formula bar (input line) bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103447] Cell containing hyperlink (URL or email), is not synchronized properly between cell and input line (mismatch in display, edit and selection)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103447

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

Summary|Issues when working with|Cell containing hyperlink
   |URLs in Calc|(URL or email), is not
   ||synchronized properly
   ||between cell and input line
   ||(mismatch in display, edit
   ||and selection)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 95600] Modify a cell that contains URL in Calc; unable to modify hyperlink in formula bar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=95600

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||3447

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103447] Issues when working with URLs in Calc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103447

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

Version|5.1.3.2 release |3.5.0 release
 CC||stephane.guillou@libreoffic
   ||e.org
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=95
   ||600

--- Comment #11 from Stéphane Guillou (stragu) 
 ---
I still reproduce in a recent trunk build:

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: b83f069101f1e6d8aaac09a805f02bbc4c619e7a
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Has been observed in 3.5 as well, as shown in bug 114022.

See the description of the "cycling" nature of the issue, described by Mike in
duplicate bug 146020:

(Mike Kaganski from bug 146020 comment #0)
> Created attachment 176665 [details]
> Screen cast
> 
> When a Calc cell contains a URL field, entering the formula bar first time
> does not highlight the field, *and navigates the URL content as if it is
> normal text*. Clicking to the same cell to leave formula bar, then entering
> the formula bar again, (but *not* leaving this cell!) highlights the field,
> and starts to "jump" over the field, and usual. Leaving the cell, and
> entering it again, starts the sequence anew.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - vcl/source

[Patrick Luby (via logerrit)]

 vcl/source/gdi/impgraph.cxx   |   11 +++
 vcl/source/gdi/pdfwriter_impl.cxx |   18 ++
 2 files changed, 21 insertions(+), 8 deletions(-)

New commits:
commit 5ea44cd9fd467f1ed26f69e194d0a59d9e0e71c2
Author: Patrick Luby 
AuthorDate: Wed Oct 11 19:53:18 2023 -0400
Commit: Patrick Luby 
CommitDate: Thu Oct 19 21:44:14 2023 +0200

tdf#157680 scale down size and adjust size and scale factor for /BBox

The size of an embedded PDF files is multiplied by
PDF_INSERT_MAGIC_SCALE_FACTOR for platforms like macOS so undo that
by adjusting the size and scale factor.

For some unknown reason, when exporting the following PDF, the
estimated size of embedded PDF charts are 20x larger than expected.
This only occurs on macOS so possibly there is some special conversion
from MapUnit::MapPoint to MapUnit::MapTwip elsewhere in the code:

  https://bugs.documentfoundation.org/attachment.cgi?id=190109

Change-Id: Id0563466fea3d7a3a0419787ec9da45f0c1d2e0a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158155
Tested-by: Jenkins
Reviewed-by: Patrick Luby 

diff --git a/vcl/source/gdi/impgraph.cxx b/vcl/source/gdi/impgraph.cxx
index 35a2145aa8e4..c4a5a1ca11b5 100644
--- a/vcl/source/gdi/impgraph.cxx
+++ b/vcl/source/gdi/impgraph.cxx
@@ -788,6 +788,17 @@ Size ImpGraphic::getPrefSize() const
 // svg not yet buffered in maBitmapEx, return size 
derived from range
 const basegfx::B2DRange& rRange = 
maVectorGraphicData->getRange();
 
+#ifdef MACOSX
+// tdf#157680 scale down estimated size of embedded PDF
+// For some unknown reason, the embedded PDF sizes
+// are 20x larger than expected. This only occurs on
+// macOS so possibly there is some special conversion
+// from MapUnit::MapPoint to MapUnit::MapTwip elsewhere
+// in the code.
+if (maVectorGraphicData->getType() == 
VectorGraphicDataType::Pdf)
+   aSize = Size(basegfx::fround(rRange.getWidth() / 
20.0f), basegfx::fround(rRange.getHeight() / 20.0f));
+else
+#endif
 aSize = Size(basegfx::fround(rRange.getWidth()), 
basegfx::fround(rRange.getHeight()));
 }
 else
diff --git a/vcl/source/gdi/pdfwriter_impl.cxx 
b/vcl/source/gdi/pdfwriter_impl.cxx
index 8176f3f86378..15eeb5c4a619 100644
--- a/vcl/source/gdi/pdfwriter_impl.cxx
+++ b/vcl/source/gdi/pdfwriter_impl.cxx
@@ -71,6 +71,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -9058,6 +9059,7 @@ void PDFWriterImpl::writeReferenceXObject(const 
ReferenceXObjectEmit& rEmit)
 // vcl::ImportPDF() uses getDefaultPdfResolutionDpi to set the desired
 // rendering DPI so we have to take into account that here too.
 static const double fResolutionDPI = 
vcl::pdf::getDefaultPdfResolutionDpi();
+static const double fMagicScaleFactor = PDF_INSERT_MAGIC_SCALE_FACTOR;
 
 sal_Int32 nOldDPIX = GetDPIX();
 sal_Int32 nOldDPIY = GetDPIY();
@@ -9072,15 +9074,13 @@ void PDFWriterImpl::writeReferenceXObject(const 
ReferenceXObjectEmit& rEmit)
 sal_Int32 nWrappedFormObject = 0;
 if (!m_aContext.UseReferenceXObject)
 {
-#ifdef MACOSX
 // tdf#156842 increase scale for external PDF data
-// For some unknown reason, the scale is 8 times larger than for
-// non-external PDF XObjects.
+// Multiply PDF_INSERT_MAGIC_SCALE_FACTOR for platforms like macOS
+// that scale all images by this number.
 // This fix also allows the CppunitTest_vcl_pdfexport to run
 // successfully on macOS.
-fScaleX = 8.0 / aSize.Width();
-fScaleY = 8.0 / aSize.Height();
-#endif
+fScaleX = fMagicScaleFactor / aSize.Width();
+fScaleY = fMagicScaleFactor / aSize.Height();
 
 // Parse the PDF data, we need that to write the PDF dictionary of our
 // object.
@@ -9322,9 +9322,11 @@ void PDFWriterImpl::writeReferenceXObject(const 
ReferenceXObjectEmit& rEmit)
 appendDouble(fScaleY, aLine);
 aLine.append(" 0 0 ]");
 aLine.append(" /BBox [ 0 0 ");
-aLine.append(aSize.Width());
+// tdf#157680 reduce size by magic scale factor in /BBox
+aLine.append(aSize.Width() / fMagicScaleFactor);
 aLine.append(" ");
-aLine.append(aSize.Height());
+// tdf#157680 reduce size by magic scale factor in /BBox
+aLine.append(aSize.Height() / fMagicScaleFactor);
 aLine.append(" ]\n");
 
 if (m_aContext.UseReferenceXObject && rEmit.m_nEmbeddedObject > 0)

[Libreoffice-commits] core.git: test/source

[Stephan Bergmann (via logerrit)]

 test/source/sheet/xsheetoutline.cxx |8 
 1 file changed, 4 insertions(+), 4 deletions(-)

New commits:
commit c9a522a383bb5dea92f46b462302eb7ab521f34b
Author: Stephan Bergmann 
AuthorDate: Wed Oct 18 19:45:08 2023 +0200
Commit: Stephan Bergmann 
CommitDate: Thu Oct 19 21:19:33 2023 +0200

Presumed loplugin:cppunitassertequals

Change-Id: Ib8de8835d7ceb214bbf87d7cebfbb56723e8fb28
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158135
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/test/source/sheet/xsheetoutline.cxx 
b/test/source/sheet/xsheetoutline.cxx
index d60820021b29..e5b99c86a369 100644
--- a/test/source/sheet/xsheetoutline.cxx
+++ b/test/source/sheet/xsheetoutline.cxx
@@ -102,14 +102,14 @@ void XSheetOutline::testShowDetail()
 aSheetOutline->showDetail(aLevelRangeAddress);
 
 CPPUNIT_ASSERT_EQUAL_MESSAGE("Row level 2 still hidden",
-getVisibleAddress(aSheet, rowLevel2), OUString(rowLevel2));
+OUString(rowLevel2), getVisibleAddress(aSheet, rowLevel2));
 
 // Column Level 2
 aLevelRangeAddress = getAddressFromRangeString(aSheet, colLevel2);
 aSheetOutline->showDetail(aLevelRangeAddress);
 
 CPPUNIT_ASSERT_EQUAL_MESSAGE("Column level 2 still hidden",
-getVisibleAddress(aSheet, colLevel2), OUString(colLevel2));
+OUString(colLevel2), getVisibleAddress(aSheet, colLevel2));
 
 }
 
@@ -254,8 +254,8 @@ void XSheetOutline::testClearOutline()
 aLevelRangeAddress = getAddressFromRangeString(aSheet, rowLevel1);
 aSheetOutline->hideDetail(aLevelRangeAddress);
 
-CPPUNIT_ASSERT_EQUAL_MESSAGE("testClearOutline Columns are hidden after 
clear", getVisibleAddress(aSheet, colLevel1), OUString(colLevel1));
-CPPUNIT_ASSERT_EQUAL_MESSAGE("testClearOutline Rows are hidden after 
clear", getVisibleAddress(aSheet, rowLevel1), OUString(rowLevel1));
+CPPUNIT_ASSERT_EQUAL_MESSAGE("testClearOutline Columns are hidden after 
clear", OUString(colLevel1), getVisibleAddress(aSheet, colLevel1));
+CPPUNIT_ASSERT_EQUAL_MESSAGE("testClearOutline Rows are hidden after 
clear", OUString(rowLevel1), getVisibleAddress(aSheet, rowLevel1));
 
 }
 

[Libreoffice-commits] core.git: editeng/source

[Stephan Bergmann (via logerrit)]

 editeng/source/editeng/impedit3.cxx |2 +-
 editeng/source/items/numitem.cxx|4 ++--
 editeng/source/misc/svxacorr.cxx|   10 +-
 editeng/source/misc/unolingu.cxx|2 +-
 4 files changed, 9 insertions(+), 9 deletions(-)

New commits:
commit 30c4d857612ec3ba6c252d6da70b0195e0e1d902
Author: Stephan Bergmann 
AuthorDate: Thu Oct 19 10:30:12 2023 +0200
Commit: Stephan Bergmann 
CommitDate: Thu Oct 19 21:08:25 2023 +0200

Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: editeng

Change-Id: I9ea2bdf3b939f260184bf793e2b91cd37e9d80c1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158190
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/editeng/source/editeng/impedit3.cxx 
b/editeng/source/editeng/impedit3.cxx
index 7ed7423bbded..7402487120e1 100644
--- a/editeng/source/editeng/impedit3.cxx
+++ b/editeng/source/editeng/impedit3.cxx
@@ -88,7 +88,7 @@ using namespace ::com::sun::star::uno;
 using namespace ::com::sun::star::beans;
 using namespace ::com::sun::star::linguistic2;
 
-constexpr OUStringLiteral CH_HYPH = u"-";
+constexpr OUString CH_HYPH = u"-"_ustr;
 
 constexpr tools::Long WRONG_SHOW_MIN = 5;
 
diff --git a/editeng/source/items/numitem.cxx b/editeng/source/items/numitem.cxx
index 97f857547029..983eff2779e2 100644
--- a/editeng/source/items/numitem.cxx
+++ b/editeng/source/items/numitem.cxx
@@ -140,8 +140,8 @@ OUString SvxNumberType::GetNumStr( sal_Int32 nNo, const 
css::lang::Locale& rLoca
 else
 {
 SvxNumType nActType = !bIsLegal || 
isArabicNumberingType(nNumType) ? nNumType : SVX_NUM_ARABIC;
-static constexpr OUStringLiteral sNumberingType = 
u"NumberingType";
-static constexpr OUStringLiteral sValue = u"Value";
+static constexpr OUString sNumberingType = 
u"NumberingType"_ustr;
+static constexpr OUString sValue = u"Value"_ustr;
 Sequence< PropertyValue > aProperties
 {
 comphelper::makePropertyValue(sNumberingType, 
static_cast(nActType)),
diff --git a/editeng/source/misc/svxacorr.cxx b/editeng/source/misc/svxacorr.cxx
index 7959b9c2ba83..094ee2130f67 100644
--- a/editeng/source/misc/svxacorr.cxx
+++ b/editeng/source/misc/svxacorr.cxx
@@ -97,9 +97,9 @@ namespace o3tl {
 }
 const sal_Unicode cNonBreakingSpace = 0xA0; // UNICODE code for no break space
 
-constexpr OUStringLiteral pXMLImplWordStart_ExcptLstStr = 
u"WordExceptList.xml";
-constexpr OUStringLiteral pXMLImplCplStt_ExcptLstStr = 
u"SentenceExceptList.xml";
-constexpr OUStringLiteral pXMLImplAutocorr_ListStr = u"DocumentList.xml";
+constexpr OUString pXMLImplWordStart_ExcptLstStr = u"WordExceptList.xml"_ustr;
+constexpr OUString pXMLImplCplStt_ExcptLstStr = u"SentenceExceptList.xml"_ustr;
+constexpr OUString pXMLImplAutocorr_ListStr = u"DocumentList.xml"_ustr;
 
 // tdf#54409 check also typographical quotation marks in the case of skipped 
ASCII quotation marks
 // Curious, why these \u0083\u0084\u0089\u0091\u0092\u0093\u0094 are handled 
as "begin characters"?
@@ -304,8 +304,8 @@ ACFlags SvxAutoCorrect::GetDefaultFlags()
 
 constexpr sal_Unicode cEmDash = 0x2014;
 constexpr sal_Unicode cEnDash = 0x2013;
-constexpr OUStringLiteral sEmDash(u"\u2014");
-constexpr OUStringLiteral sEnDash(u"\u2013");
+constexpr OUString sEmDash(u"\u2014"_ustr);
+constexpr OUString sEnDash(u"\u2013"_ustr);
 constexpr sal_Unicode cApostrophe = 0x2019;
 constexpr sal_Unicode cLeftDoubleAngleQuote = 0xAB;
 constexpr sal_Unicode cRightDoubleAngleQuote = 0xBB;
diff --git a/editeng/source/misc/unolingu.cxx b/editeng/source/misc/unolingu.cxx
index b8b5676099f1..1e7b69a25f27 100644
--- a/editeng/source/misc/unolingu.cxx
+++ b/editeng/source/misc/unolingu.cxx
@@ -633,7 +633,7 @@ uno::Reference< XDictionary > LinguMgr::GetStandard()
 if (!xTmpDicList.is())
 return nullptr;
 
-static constexpr OUStringLiteral aDicName( u"standard.dic" );
+static constexpr OUString aDicName( u"standard.dic"_ustr );
 uno::Reference< XDictionary > xDic = xTmpDicList->getDictionaryByName( 
aDicName );
 if (!xDic.is())
 {

[Libreoffice-bugs] [Bug 144832] EDITING Add to list operation on an ordered/unordered list is not recorded as tracked change

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144832

--- Comment #5 from greg.diehl@gmail.com ---
Reproduced with the latest development build

Version: 24.2.0.0.alpha0+ (AARCH64) / LibreOffice Community
Build ID: b83f069101f1e6d8aaac09a805f02bbc4c619e7a
CPU threads: 10; OS: macOS 14.0; UI render: default; VCL: osx
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144831] EDITING Demote level on an ordered/unordered list is not recorded as tracked change

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144831

--- Comment #5 from greg.diehl@gmail.com ---
Reproduced with latest development build

Version: 24.2.0.0.alpha0+ (AARCH64) / LibreOffice Community
Build ID: b83f069101f1e6d8aaac09a805f02bbc4c619e7a
CPU threads: 10; OS: macOS 14.0; UI render: default; VCL: osx
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144830] EDITING No list operation on an ordered/unordered list is not recorded as tracked change

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144830

--- Comment #5 from greg.diehl@gmail.com ---
Reproduced with latest development build

Version: 24.2.0.0.alpha0+ (AARCH64) / LibreOffice Community
Build ID: b83f069101f1e6d8aaac09a805f02bbc4c619e7a
CPU threads: 10; OS: macOS 14.0; UI render: default; VCL: osx
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144829] EDITING Promote level on an ordered/unordered list is not recorded as tracked change

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144829

--- Comment #6 from greg.diehl@gmail.com ---
Reproduced with latest development build

Version: 24.2.0.0.alpha0+ (AARCH64) / LibreOffice Community
Build ID: b83f069101f1e6d8aaac09a805f02bbc4c619e7a
CPU threads: 10; OS: macOS 14.0; UI render: default; VCL: osx
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: filter/source

[Stephan Bergmann (via logerrit)]

 filter/source/msfilter/escherex.cxx  |6 -
 filter/source/msfilter/msdffimp.cxx  |   14 +--
 filter/source/msfilter/msocximex.cxx |2 
 filter/source/msfilter/msvbahelper.cxx   |4 -
 filter/source/pdf/pdfexport.cxx  |4 -
 filter/source/svg/svgexport.cxx  |   28 +++
 filter/source/svg/svgwriter.cxx  |   82 +++
 filter/source/textfilterdetect/filterdetect.cxx  |   16 ++--
 filter/source/xsltdialog/typedetectionexport.cxx |   28 +++
 filter/source/xsltdialog/xmlfilterjar.cxx|2 
 10 files changed, 93 insertions(+), 93 deletions(-)

New commits:
commit 24655ccaeb7d36cf024b31ad5925244ac7016351
Author: Stephan Bergmann 
AuthorDate: Thu Oct 19 10:30:14 2023 +0200
Commit: Stephan Bergmann 
CommitDate: Thu Oct 19 20:53:37 2023 +0200

Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: filter

Change-Id: I1dd21c1dc2a7aed54fa1c03036ad75d2e0eade87
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158193
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/filter/source/msfilter/escherex.cxx 
b/filter/source/msfilter/escherex.cxx
index 112d468e90db..caf07865941e 100644
--- a/filter/source/msfilter/escherex.cxx
+++ b/filter/source/msfilter/escherex.cxx
@@ -598,7 +598,7 @@ void EscherPropertyContainer::CreateFillProperties(
 uno::Any aAny;
 AddOpt( ESCHER_Prop_WrapText, ESCHER_WrapNone );
 AddOpt( ESCHER_Prop_AnchorText, ESCHER_AnchorMiddle );
-static constexpr OUStringLiteral aPropName( u"FillStyle" );
+static constexpr OUString aPropName( u"FillStyle"_ustr );
 
 if ( EscherPropertyValueHelper::GetPropertyValue(
 aAny, rXPropSet, aPropName ) )
@@ -2598,10 +2598,10 @@ void 
EscherPropertyContainer::CreateCustomShapeProperties( const MSO_SPT eShapeT
 
 static constexpr OUStringLiteral sViewBox( u"ViewBox"  );
 static constexpr OUStringLiteral sTextRotateAngle( u"TextRotateAngle"  
);
-static constexpr OUStringLiteral sExtrusion  ( u"Extrusion"  );
+static constexpr OUString sExtrusion  ( u"Extrusion"_ustr  );
 static constexpr OUStringLiteral sEquations  ( u"Equations"  );
 static constexpr OUStringLiteral sPath   ( u"Path"  );
-static constexpr OUStringLiteral sTextPath   ( u"TextPath"  );
+static constexpr OUString sTextPath   ( u"TextPath"_ustr  );
 static constexpr OUStringLiteral sHandles( u"Handles"  );
 static constexpr OUStringLiteral sAdjustmentValues   ( u"AdjustmentValues" 
 );
 
diff --git a/filter/source/msfilter/msdffimp.cxx 
b/filter/source/msfilter/msdffimp.cxx
index 058b61e1253d..6f2f29665ee0 100644
--- a/filter/source/msfilter/msdffimp.cxx
+++ b/filter/source/msfilter/msdffimp.cxx
@@ -171,7 +171,7 @@ using namespace container   ;
 
 // static counter for OLE-Objects
 static sal_uInt32 nMSOleObjCntr = 0;
-constexpr OUStringLiteral MSO_OLE_Obj = u"MSO_OLE_Obj";
+constexpr OUString MSO_OLE_Obj = u"MSO_OLE_Obj"_ustr;
 
 namespace {
 /* Office File Formats - 2.2.23  */
@@ -615,7 +615,7 @@ void SvxMSDffManager::SolveSolver( const 
SvxMSDffSolverContainer& rSolver )
 {
 const SfxPoolItem& aCustomShape =  
static_cast(pO)->GetMergedItem( 
SDRATTR_CUSTOMSHAPE_GEOMETRY );
 SdrCustomShapeGeometryItem aGeometryItem( 
static_cast(aCustomShape) );
-static constexpr OUStringLiteral sPath( 
u"Path" );
+static constexpr OUString sPath( u"Path"_ustr 
);
 sal_Int16 nGluePointType = 
EnhancedCustomShapeGluePointType::SEGMENTS;
 css::uno::Any* pAny = 
aGeometryItem.GetPropertyValueByName( sPath, "GluePointType" );
 if ( pAny )
@@ -737,7 +737,7 @@ void SvxMSDffManager::SolveSolver( const 
SvxMSDffSolverContainer& rSolver )
 sal_Int32 nX = 0, nY = 0;
 if ( ( rPara.First.Value >>= nX ) 
&& ( rPara.Second.Value >>= nY ) )
 {
-static constexpr 
OUStringLiteral sGluePoints( u"GluePoints" );
+static constexpr OUString 
sGluePoints( u"GluePoints"_ustr );
 css::uno::Sequence< 
css::drawing::EnhancedCustomShapeParameterPair > aGluePoints;
 pAny = 
aGeometryItem.GetPropertyValueByName( sPath, sGluePoints );
 if ( pAny )
@@ -2833,7 +2833,7 @@ void DffPropertyReader::CheckAndCorrectExcelTextRotation( 
SvStream& rIn, SfxItem
 
 const css::uno::Any* pAny;
 

[Libreoffice-bugs] [Bug 144828] EDITING Restart numbering on an ordered list is not recorded as tracked change

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144828

--- Comment #5 from greg.diehl@gmail.com ---
Reproduced with the latest development build

Version: 24.2.0.0.alpha0+ (AARCH64) / LibreOffice Community
Build ID: b83f069101f1e6d8aaac09a805f02bbc4c619e7a
CPU threads: 10; OS: macOS 14.0; UI render: default; VCL: osx
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144827] EDITING Creating an ordered/unordered list is not recorded as tracked change

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144827

--- Comment #5 from greg.diehl@gmail.com ---
Reproduced with the latest development build

Version: 24.2.0.0.alpha0+ (AARCH64) / LibreOffice Community
Build ID: b83f069101f1e6d8aaac09a805f02bbc4c619e7a
CPU threads: 10; OS: macOS 14.0; UI render: default; VCL: osx
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154602] Scrolling using keyboard very slow (GTK3) with 4K monitor

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=154602

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||7830

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157830] When scrolling a document at a resolution of 4k, CPU usage jumps to 50% or more and performance is laggy/choppy.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157830

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||4602
 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1
 CC||stephane.guillou@libreoffic
   ||e.org

--- Comment #1 from Stéphane Guillou (stragu) 
 ---
What is the first version you expérience the issue in?
Do you use Wayland?

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: LLVM exit code 139 building git master on Xubuntu 22.04

[David Gerard]

On Thu, 19 Oct 2023 at 07:26, Stephan Bergmann  wrote:
> On 10/18/23 23:08, David Gerard wrote:

> > I just tried again from a completely fresh git clone, and it's still
> > happening. Any ideas? Is there anything in the new C++20 conf that's
> > too new for llvm 14.0.0 Ubuntu version?

> Smells like a bug in that particular version of Clang.  I'd follow the
> printed instructions to report it, either directly upstream at LLVM or
> (presumably better) at Ubuntu first.


So rather than file a bug and wait, I first tried a newer version of
clang, and clang-15 worked. Hooray!

Here's what I did:

# Become root

sudo -s

# install clang-15

apt remove llvm-14 clang-14 libclang-cpp14 libclang1-14
apt autoremove
apt install clang-15 llvm-15 libclang-cpp15 libclang1-15

# put its binaries in the path - no, there doesn't seem to be a more elegant way

cd /usr/lib/llvm-15/bin
for f in *; do rm -f /usr/bin/$f; ln -s ../lib/llvm-15/bin/$f /usr/bin/$f; done

and then get out of root and ./autogen.sh


- d.

[Libreoffice-commits] core.git: embeddedobj/source

[Stephan Bergmann (via logerrit)]

 embeddedobj/source/commonembedding/persistence.cxx |   12 ++--
 embeddedobj/source/general/intercept.cxx   |   12 ++--
 embeddedobj/source/msole/ownview.cxx   |2 +-
 3 files changed, 13 insertions(+), 13 deletions(-)

New commits:
commit 93c0780392758f783592f030aa2d4e824d57bb2f
Author: Stephan Bergmann 
AuthorDate: Thu Oct 19 10:30:13 2023 +0200
Commit: Stephan Bergmann 
CommitDate: Thu Oct 19 20:32:23 2023 +0200

Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: embeddedobj

Change-Id: I2761e0a093aff75c5660b2b78012277c67eb8e17
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158191
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/embeddedobj/source/commonembedding/persistence.cxx 
b/embeddedobj/source/commonembedding/persistence.cxx
index 4bb8d19123a3..6859de216c24 100644
--- a/embeddedobj/source/commonembedding/persistence.cxx
+++ b/embeddedobj/source/commonembedding/persistence.cxx
@@ -178,7 +178,7 @@ static void TransferMediaType( const uno::Reference< 
embed::XStorage >& i_rSourc
 {
 const uno::Reference< beans::XPropertySet > xSourceProps( i_rSource, 
uno::UNO_QUERY_THROW );
 const uno::Reference< beans::XPropertySet > xTargetProps( i_rTarget, 
uno::UNO_QUERY_THROW );
-static constexpr OUStringLiteral sMediaTypePropName( u"MediaType" );
+static constexpr OUString sMediaTypePropName( u"MediaType"_ustr );
 xTargetProps->setPropertyValue( sMediaTypePropName, 
xSourceProps->getPropertyValue( sMediaTypePropName ) );
 }
 catch( const uno::Exception& )
@@ -784,11 +784,11 @@ void OCommonEmbeddedObject::StoreDocToStorage_Impl(
 if ( aFilterName.isEmpty() )
 throw io::IOException(); // TODO:
 
-static constexpr OUStringLiteral sFilterName = u"FilterName";
-static constexpr OUStringLiteral sHierarchicalDocumentName = 
u"HierarchicalDocumentName";
-static constexpr OUStringLiteral sDocumentBaseURL = u"DocumentBaseURL";
-static constexpr OUStringLiteral sSourceShellID = u"SourceShellID";
-static constexpr OUStringLiteral sDestinationShellID = 
u"DestinationShellID";
+static constexpr OUString sFilterName = u"FilterName"_ustr;
+static constexpr OUString sHierarchicalDocumentName = 
u"HierarchicalDocumentName"_ustr;
+static constexpr OUString sDocumentBaseURL = u"DocumentBaseURL"_ustr;
+static constexpr OUString sSourceShellID = u"SourceShellID"_ustr;
+static constexpr OUString sDestinationShellID = 
u"DestinationShellID"_ustr;
 uno::Sequence aArgs{
 comphelper::makePropertyValue(sFilterName, aFilterName),
 comphelper::makePropertyValue(sHierarchicalDocumentName, 
aHierarchName),
diff --git a/embeddedobj/source/general/intercept.cxx 
b/embeddedobj/source/general/intercept.cxx
index 58a7ed49bcc0..db16a59b9d68 100644
--- a/embeddedobj/source/general/intercept.cxx
+++ b/embeddedobj/source/general/intercept.cxx
@@ -26,12 +26,12 @@
 
 using namespace ::com::sun::star;
 
-constexpr OUStringLiteral IU0 = u".uno:Save";
-constexpr OUStringLiteral IU1 = u".uno:SaveAll";
-constexpr OUStringLiteral IU2 = u".uno:CloseDoc";
-constexpr OUStringLiteral IU3 = u".uno:CloseWin";
-constexpr OUStringLiteral IU4 = u".uno:CloseFrame";
-constexpr OUStringLiteral IU5 = u".uno:SaveAs";
+constexpr OUString IU0 = u".uno:Save"_ustr;
+constexpr OUString IU1 = u".uno:SaveAll"_ustr;
+constexpr OUString IU2 = u".uno:CloseDoc"_ustr;
+constexpr OUString IU3 = u".uno:CloseWin"_ustr;
+constexpr OUString IU4 = u".uno:CloseFrame"_ustr;
+constexpr OUString IU5 = u".uno:SaveAs"_ustr;
 const uno::Sequence< OUString > Interceptor::m_aInterceptedURL{ IU0, IU1, IU2, 
IU3, IU4, IU5 };
 
 class StatusChangeListenerContainer
diff --git a/embeddedobj/source/msole/ownview.cxx 
b/embeddedobj/source/msole/ownview.cxx
index e4684d6d29bf..5576f8633cce 100644
--- a/embeddedobj/source/msole/ownview.cxx
+++ b/embeddedobj/source/msole/ownview.cxx
@@ -401,7 +401,7 @@ void OwnView_Impl::CreateNative()
 aArgs, m_xContext ),
 uno::UNO_QUERY_THROW );
 
-static constexpr OUStringLiteral aSubStreamName(u"\1Ole10Native");
+static constexpr OUString aSubStreamName(u"\1Ole10Native"_ustr);
 uno::Reference< embed::XClassifiedObject > xStor( xNameAccess, 
uno::UNO_QUERY_THROW );
 uno::Sequence< sal_Int8 > aStorClassID = xStor->getClassID();
 

[Libreoffice-bugs] [Bug 144796] FILEOPEN DOCX Chart objects In Background property not read

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144796

--- Comment #4 from greg.diehl@gmail.com ---
Reproduced with the latest development build

Version: 24.2.0.0.alpha0+ (AARCH64) / LibreOffice Community
Build ID: b83f069101f1e6d8aaac09a805f02bbc4c619e7a
CPU threads: 10; OS: macOS 14.0; UI render: default; VCL: osx
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144799] FILEOPEN DOCX Text of textbox inside chart grows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144799

--- Comment #4 from greg.diehl@gmail.com ---
Bug is present in latest development build

Version: 24.2.0.0.alpha0+ (AARCH64) / LibreOffice Community
Build ID: b83f069101f1e6d8aaac09a805f02bbc4c619e7a
CPU threads: 10; OS: macOS 14.0; UI render: default; VCL: osx
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: forms/source

[Stephan Bergmann (via logerrit)]

 forms/source/component/Columns.cxx|4 ++--
 forms/source/component/DatabaseForm.cxx   |2 +-
 forms/source/component/FormattedField.cxx |4 ++--
 3 files changed, 5 insertions(+), 5 deletions(-)

New commits:
commit 6581f028f85d72f3b85c873eaecd77a37c98ac31
Author: Stephan Bergmann 
AuthorDate: Thu Oct 19 10:30:15 2023 +0200
Commit: Stephan Bergmann 
CommitDate: Thu Oct 19 20:21:47 2023 +0200

Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: forms

Change-Id: Ifab0f06a776a9c505508781018300c7ce5d46436
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158194
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/forms/source/component/Columns.cxx 
b/forms/source/component/Columns.cxx
index 4aab958f934e..56be293fc549 100644
--- a/forms/source/component/Columns.cxx
+++ b/forms/source/component/Columns.cxx
@@ -83,8 +83,8 @@ const css::uno::Sequence& getColumnTypes()
 
 sal_Int32 getColumnTypeByModelName(const OUString& aModelName)
 {
-static constexpr OUStringLiteral aModelPrefix 
(u"com.sun.star.form.component.");
-static constexpr OUStringLiteral aCompatibleModelPrefix 
(u"stardiv.one.form.component.");
+static constexpr OUString aModelPrefix 
(u"com.sun.star.form.component."_ustr);
+static constexpr OUString aCompatibleModelPrefix 
(u"stardiv.one.form.component."_ustr);
 
 sal_Int32 nTypeId = -1;
 if (aModelName == FRM_COMPONENT_EDIT)
diff --git a/forms/source/component/DatabaseForm.cxx 
b/forms/source/component/DatabaseForm.cxx
index fccd2367ea17..0d6aafaaa5cf 100644
--- a/forms/source/component/DatabaseForm.cxx
+++ b/forms/source/component/DatabaseForm.cxx
@@ -1953,7 +1953,7 @@ void ODatabaseForm::reset_impl(bool _bApproveByListeners)
 if ( xColProps.is() )
 xPSI = xColProps->getPropertySetInfo( );
 
-static constexpr OUStringLiteral PROPERTY_CONTROLDEFAULT = 
u"ControlDefault";
+static constexpr OUString PROPERTY_CONTROLDEFAULT = 
u"ControlDefault"_ustr;
 if ( xPSI.is() && xPSI->hasPropertyByName( 
PROPERTY_CONTROLDEFAULT ) )
 {
 Any aDefault = xColProps->getPropertyValue( 
PROPERTY_CONTROLDEFAULT );
diff --git a/forms/source/component/FormattedField.cxx 
b/forms/source/component/FormattedField.cxx
index dbabcaf9bcdd..119fcc35f6a1 100644
--- a/forms/source/component/FormattedField.cxx
+++ b/forms/source/component/FormattedField.cxx
@@ -656,7 +656,7 @@ void OFormattedModel::write(const 
Reference& _rxOutStream)
 Reference  xFormats = xSupplier->getNumberFormats();
 OUString sFormatDescription;
 LanguageTypeeFormatLanguage = LANGUAGE_DONTKNOW;
-static constexpr OUStringLiteral s_aLocaleProp = u"Locale";
+static constexpr OUString s_aLocaleProp = u"Locale"_ustr;
 Reference  xFormat = 
xFormats->getByKey(nKey);
 if (hasProperty(s_aLocaleProp, xFormat))
 {
@@ -667,7 +667,7 @@ void OFormattedModel::write(const 
Reference& _rxOutStream)
 eFormatLanguage = LanguageTag::convertToLanguageType( 
*pLocale, false);
 }
 }
-static constexpr OUStringLiteral s_aFormatStringProp = u"FormatString";
+static constexpr OUString s_aFormatStringProp = u"FormatString"_ustr;
 if (hasProperty(s_aFormatStringProp, xFormat))
 xFormat->getPropertyValue(s_aFormatStringProp) >>= 
sFormatDescription;
 _rxOutStream->writeUTF(sFormatDescription);

[Libreoffice-bugs] [Bug 144626] Borders of Writer tables are not correctly aligned

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144626

raal  changed:

   What|Removed |Added

  Regression By||Kohei Yoshida
   Keywords|bibisectRequest |bisected

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144626] Borders of Writer tables are not correctly aligned

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144626

raal  changed:

   What|Removed |Added

 CC||r...@post.cz

--- Comment #15 from raal  ---
Created attachment 190304
  --> https://bugs.documentfoundation.org/attachment.cgi?id=190304=edit
printscreen of bug in bibisect

Bibisected with repository/OS bibisect-43max/Linux.
After this commit thick line appears on the top:

a3ada5c2e0f610e97f9494118f3823de2abb6a31 is the first bad commit
commit a3ada5c2e0f610e97f9494118f3823de2abb6a31
Author: Matthew Francis 
Date:   Thu May 28 18:29:06 2015 +0800

source-hash-111fe03e36dd7e819e8fa9bdf38a16f5284b6063

Bibisect: This commit covers the following source commit(s) which failed to
build
f979a12741d0e5f47b26aa407593ab7c21979f6dKendy
6a3fb868b2b8af21f7b6140424b6f8377599a786Kohei
ec1a3157c1851dcb481f402ec25aa38fa9e7c51c
82599357ae6066b002ca2bd2b7060b26e51ba00f
b3b57c7a3a43a056217c72716d18bdeced029b66
ae22838d2ff4d388e97c30317a6a9f83e652a06a
30f97564f86ff2fff3e682a14191db0d841df0cf
41bee5b83102760a6da7eaca3b770e4c4e310d4d
01104522ef890bb535994311e627ba1bbfff023c
4b2b4133c2bd750a4b71230433dba0e41ced0abe

After this commit is line thinner
 8565c48d7e72be078a7344dafe680452a68cd82f is the first bad commit
commit 8565c48d7e72be078a7344dafe680452a68cd82f
Author: Matthew Francis 
Date:   Thu May 28 18:29:09 2015 +0800

source-hash-15974abe63f0d4fc88099634d5cd2ddb9760ec23

commit 15974abe63f0d4fc88099634d5cd2ddb9760ec23
Author: Kohei Yoshida 
AuthorDate: Mon Jan 20 18:37:08 2014 -0500
Commit: Kohei Yoshida 
CommitDate: Mon Jan 20 18:39:54 2014 -0500

fdo#73487: Center thick border lines around cell grid.

This reduces the amount of gap at line joins. Plus it generally looks
better
this way.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: drawinglayer/source

[Stephan Bergmann (via logerrit)]

 drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 26b63f4f2f71a48dc0a9be3356da88f8b5f143dc
Author: Stephan Bergmann 
AuthorDate: Thu Oct 19 10:30:11 2023 +0200
Commit: Stephan Bergmann 
CommitDate: Thu Oct 19 19:56:49 2023 +0200

Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: drawinglayer

Change-Id: I668041773862b380772d0425ac4eab1d37d310e3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158189
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx 
b/drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx
index 084cc0bef17e..193f5cdad31a 100644
--- a/drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx
+++ b/drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx
@@ -1083,7 +1083,7 @@ void VclMetafileProcessor2D::processControlPrimitive2D(
 uno::Reference xPropertyInfo(
 xModelProperties.is() ? xModelProperties->getPropertySetInfo()
   : 
uno::Reference());
-static constexpr OUStringLiteral 
sPrintablePropertyName(u"Printable");
+static constexpr OUString 
sPrintablePropertyName(u"Printable"_ustr);
 
 if (xPropertyInfo.is() && 
xPropertyInfo->hasPropertyByName(sPrintablePropertyName))
 {
@@ -1264,7 +1264,7 @@ void 
VclMetafileProcessor2D::processTextHierarchyFieldPrimitive2D(
 {
 // support for FIELD_SEQ_BEGIN, FIELD_SEQ_END and URL. It wraps text 
primitives (but is not limited to)
 // thus do the MetafileAction embedding stuff but just handle recursively.
-static constexpr OStringLiteral aCommentStringCommon("FIELD_SEQ_BEGIN");
+static constexpr OString aCommentStringCommon("FIELD_SEQ_BEGIN"_ostr);
 OUString aURL;
 
 switch (rFieldPrimitive.getType())
@@ -1358,7 +1358,7 @@ void 
VclMetafileProcessor2D::processTextHierarchyBulletPrimitive2D(
 void VclMetafileProcessor2D::processTextHierarchyParagraphPrimitive2D(
 const primitive2d::TextHierarchyParagraphPrimitive2D& rParagraphPrimitive)
 {
-static constexpr OStringLiteral aCommentString("XTEXT_EOP");
+static constexpr OString aCommentString("XTEXT_EOP"_ostr);
 static bool bSuppressPDFExtOutDevDataSupport(false); // 
loplugin:constvars:ignore
 
 if (nullptr == mpPDFExtOutDevData || bSuppressPDFExtOutDevDataSupport)

[Libreoffice-bugs] [Bug 157827] No plain text paste after copying an Impress/Draw table (missing text/plain target)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157827

jcs...@libreoffice.org changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #2 from jcs...@libreoffice.org ---
Confirmed with:

-
Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 7d08767b890e723cd502b1c61d250924f695eb98
CPU threads: 16; OS: Windows 10.0 Build 22621; UI render: Skia/Vulkan; VCL: win
Locale: es-ES (es_ES); UI: es-ES
Calc: CL threaded

-
Version: 7.6.2.1 (X86_64) / LibreOffice Community
Build ID: 56f7684011345957bbf33a7ee678afaf4d2ba333
CPU threads: 16; OS: Windows 10.0 Build 22621; UI render: Skia/Vulkan; VCL: win
Locale: es-ES (es_ES); UI: en-US
Calc: CL threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.