[Libreoffice-bugs] [Bug 154413] Problem with email adresses selection
https://bugs.documentfoundation.org/show_bug.cgi?id=154413 Stéphane Guillou (stragu) changed: What|Removed |Added CC||stephane.guillou@libreoffic ||e.org Status|NEEDINFO|RESOLVED Resolution|--- |DUPLICATE --- Comment #7 from Stéphane Guillou (stragu) --- *** This bug has been marked as a duplicate of bug 103447 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103447] Cell containing hyperlink (URL or email), is not synchronized properly between cell and input line (mismatch in display, edit and selection)
https://bugs.documentfoundation.org/show_bug.cgi?id=103447 Stéphane Guillou (stragu) changed: What|Removed |Added CC||nathan.rive...@outlook.fr --- Comment #15 from Stéphane Guillou (stragu) --- *** Bug 154413 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 46710] Can not select a hyperlinked text with the mouse
https://bugs.documentfoundation.org/show_bug.cgi?id=46710 --- Comment #7 from Stéphane Guillou (stragu) --- Using more accurate duplicate target. *** This bug has been marked as a duplicate of bug 116384 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156111] Drag and drop of a bookmark from the Navigator onto a text selection should use it as the hyperlink text
https://bugs.documentfoundation.org/show_bug.cgi?id=156111 Stéphane Guillou (stragu) changed: What|Removed |Added CC||dpquin...@zoho.com --- Comment #7 from Stéphane Guillou (stragu) --- *** Bug 140260 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140260] Enhancement: Make selected text a hyperlink to header using Navigator
https://bugs.documentfoundation.org/show_bug.cgi?id=140260 Stéphane Guillou (stragu) changed: What|Removed |Added CC||stephane.guillou@libreoffic ||e.org Resolution|INSUFFICIENTDATA|DUPLICATE --- Comment #4 from Stéphane Guillou (stragu) --- This was actually implemented for 24.2, so marking as duplicate. *** This bug has been marked as a duplicate of bug 156111 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157870] Office simply freezes and shuts down without warning
https://bugs.documentfoundation.org/show_bug.cgi?id=157870 Stéphane Guillou (stragu) changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO --- Comment #1 from Stéphane Guillou (stragu) --- Thanks for the report, Caroll. Please update to the latest release, as quite a few issues have been fixed since version 7.5.3.2: https://www.libreoffice.org/download/download-libreoffice/ If you still experience issues, please: - paste here your version information copied from Help > About LibreOffice - share a crash report link if you see the Crash Report dialog -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: fpicker/source
fpicker/source/office/iodlg.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit d5fa192f54eeb4294748d262034f64556fabd4fb Author: Stephan Bergmann AuthorDate: Thu Oct 19 10:30:16 2023 +0200 Commit: Stephan Bergmann CommitDate: Sat Oct 21 07:04:47 2023 +0200 Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: fpicker Change-Id: Id2e70665c78f5e5fd3dc7ab0f5889f83880804ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158299 Tested-by: Jenkins Reviewed-by: Stephan Bergmann diff --git a/fpicker/source/office/iodlg.cxx b/fpicker/source/office/iodlg.cxx index 00685bc25d7f..b3e279f6b471 100644 --- a/fpicker/source/office/iodlg.cxx +++ b/fpicker/source/office/iodlg.cxx @@ -236,7 +236,7 @@ namespace if ( xProviderProps.is() ) { Reference< XPropertySetInfo > xPropInfo = xProviderProps->getPropertySetInfo(); -static constexpr OUStringLiteral sHomeDirPropertyName( u"HomeDirectory" ); +static constexpr OUString sHomeDirPropertyName( u"HomeDirectory"_ustr ); if ( !xPropInfo.is() || xPropInfo->hasPropertyByName( sHomeDirPropertyName ) ) { OUString sHomeDirectory;
[Libreoffice-bugs] [Bug 106388] FILEOPEN: Flat MS Office Word 2003 XML file opens with wrong import filter
https://bugs.documentfoundation.org/show_bug.cgi?id=106388 --- Comment #10 from Buovjaga --- (In reply to Ken Parker from comment #9) > We at OpenText have a product, WebReports, with thousands of users producing > thousands of these documents per day. We would really appreciate anything > that could be done to move this issue up the priority list. https://www.libreoffice.org/get-help/professional-support/ -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157866] Toolbar dis/appearance must neither shift nor scale the slide display
https://bugs.documentfoundation.org/show_bug.cgi?id=157866 --- Comment #3 from V Stuart Foote --- (In reply to V Stuart Foote from comment #2) s/across the UI modes/across the LO modules/ -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 157866] Toolbar dis/appearance must neither shift nor scale the slide display
https://bugs.documentfoundation.org/show_bug.cgi?id=157866 --- Comment #3 from V Stuart Foote --- (In reply to V Stuart Foote from comment #2) s/across the UI modes/across the LO modules/ -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-ux-advise] [Bug 157866] Toolbar dis/appearance must neither shift nor scale the slide display
https://bugs.documentfoundation.org/show_bug.cgi?id=157866 --- Comment #2 from V Stuart Foote --- Aside from duplicate, you can avoid the jump by selectively unlocking and undocking the offending contextual toolbar(s). And also worth looking at using the Contextual Single UI MUFFIN user interface in conjunction with the undocked TBs. In turn being reworked for bug 125040 to make the Single Toolbar user interface context sensitive across the UI modes. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 157866] Toolbar dis/appearance must neither shift nor scale the slide display
https://bugs.documentfoundation.org/show_bug.cgi?id=157866 --- Comment #2 from V Stuart Foote --- Aside from duplicate, you can avoid the jump by selectively unlocking and undocking the offending contextual toolbar(s). And also worth looking at using the Contextual Single UI MUFFIN user interface in conjunction with the undocked TBs. In turn being reworked for bug 125040 to make the Single Toolbar user interface context sensitive across the UI modes. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103239] [META] Toolbars bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103239 Bug 103239 depends on bug 157866, which changed state. Bug 157866 Summary: Toolbar dis/appearance must neither shift nor scale the slide display https://bugs.documentfoundation.org/show_bug.cgi?id=157866 What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 124835] Contextual toolbars make UI jumping
https://bugs.documentfoundation.org/show_bug.cgi?id=124835 V Stuart Foote changed: What|Removed |Added CC||eyalr...@gmx.com --- Comment #32 from V Stuart Foote --- *** Bug 157866 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157866] Toolbar dis/appearance must neither shift nor scale the slide display
https://bugs.documentfoundation.org/show_bug.cgi?id=157866 V Stuart Foote changed: What|Removed |Added CC||vsfo...@libreoffice.org Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from V Stuart Foote --- *** This bug has been marked as a duplicate of bug 124835 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 157866] Toolbar dis/appearance must neither shift nor scale the slide display
https://bugs.documentfoundation.org/show_bug.cgi?id=157866 V Stuart Foote changed: What|Removed |Added CC||vsfo...@libreoffice.org Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from V Stuart Foote --- *** This bug has been marked as a duplicate of bug 124835 *** -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 157632] With multiple objects selected, can't set direction via sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=157632 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157852] Table Rows are not displayed
https://bugs.documentfoundation.org/show_bug.cgi?id=157852 QA Administrators changed: What|Removed |Added Keywords||bibisectRequest -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157621] dialog.dtd Is Outdated or Incomplete
https://bugs.documentfoundation.org/show_bug.cgi?id=157621 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157646] Scroll wheel on scrollbars is messed up in Customise dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=157646 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157648] FORMATTING: Setting language for Selection/Paragraph/All text can't be shortcut
https://bugs.documentfoundation.org/show_bug.cgi?id=157648 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157620] Wrong Links in XDL Exported Dialog File
https://bugs.documentfoundation.org/show_bug.cgi?id=157620 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154336] libvisio: Traditional Chinese characters in text box displayed unproperly
https://bugs.documentfoundation.org/show_bug.cgi?id=154336 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154336] libvisio: Traditional Chinese characters in text box displayed unproperly
https://bugs.documentfoundation.org/show_bug.cgi?id=154336 --- Comment #5 from QA Administrators --- Dear Hsiao, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154207] Application crash
https://bugs.documentfoundation.org/show_bug.cgi?id=154207 --- Comment #3 from QA Administrators --- Dear Eduardo, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154325] In Calc forgots the diferent fontsize of empty paragraphs inside the same cell.
https://bugs.documentfoundation.org/show_bug.cgi?id=154325 --- Comment #3 from QA Administrators --- Dear Luís Mendes, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153303] Window flickers (content shifts) on every key press when having opened multiple windows of a document
https://bugs.documentfoundation.org/show_bug.cgi?id=153303 --- Comment #5 from QA Administrators --- Dear Ulrich Windl, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153303] Window flickers (content shifts) on every key press when having opened multiple windows of a document
https://bugs.documentfoundation.org/show_bug.cgi?id=153303 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152946] when sidebar is wider that some value, most of the final row of widgets is lost below the sidebar border, and is unreadable (but not necessarily unusable)
https://bugs.documentfoundation.org/show_bug.cgi?id=152946 --- Comment #4 from QA Administrators --- Dear xaxazak, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152946] when sidebar is wider that some value, most of the final row of widgets is lost below the sidebar border, and is unreadable (but not necessarily unusable)
https://bugs.documentfoundation.org/show_bug.cgi?id=152946 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154949] Random and continuous crash. Crash reason: "Exception_access_violation_read"
https://bugs.documentfoundation.org/show_bug.cgi?id=154949 --- Comment #5 from QA Administrators --- Dear Alessandro, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151671] Calc: Freeze Rows and Columns is freez the first rows or columns only
https://bugs.documentfoundation.org/show_bug.cgi?id=151671 --- Comment #8 from QA Administrators --- Dear MARINA-SODA, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154482] [Clarification] - Delete Option not Present when Right Click on a Shape Element.
https://bugs.documentfoundation.org/show_bug.cgi?id=154482 --- Comment #7 from QA Administrators --- Dear M Ragul, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147718] LO(7.2) XML Form Document cannot unlock Read-only / Write-protected via any visible UI option
https://bugs.documentfoundation.org/show_bug.cgi?id=147718 --- Comment #26 from QA Administrators --- Dear Malome Khomo, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157870] New: Office simply freezes and shuts down without warning
https://bugs.documentfoundation.org/show_bug.cgi?id=157870 Bug ID: 157870 Summary: Office simply freezes and shuts down without warning Product: LibreOffice Version: 7.5.3.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: creim...@cox.net Description: NO warning. Office freezes and shuts down Steps to Reproduce: 1. Can't reproduce. It happens randomly and without warning Actual Results: recovered Expected Results: kept on working without shutting down Reproducible: Always User Profile Reset: No Additional Info: none -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: vcl/qa
vcl/qa/cppunit/pdfexport/data/tdf156685.docx |binary vcl/qa/cppunit/pdfexport/pdfexport.cxx | 36 +++ 2 files changed, 36 insertions(+) New commits: commit fc1ba4d17fd71656205697a6cf19432037e4a9d6 Author: Xisco Fauli AuthorDate: Fri Oct 20 16:03:56 2023 +0200 Commit: Xisco Fauli CommitDate: Sat Oct 21 01:04:12 2023 +0200 tdf#156182, tdf#156685: vcl_pdfexport: Add unittest Change-Id: I6756f1f19b9cc178191a47ea81857981f44aced0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158264 Tested-by: Jenkins Reviewed-by: Xisco Fauli diff --git a/vcl/qa/cppunit/pdfexport/data/tdf156685.docx b/vcl/qa/cppunit/pdfexport/data/tdf156685.docx new file mode 100644 index ..a3eddf84594b Binary files /dev/null and b/vcl/qa/cppunit/pdfexport/data/tdf156685.docx differ diff --git a/vcl/qa/cppunit/pdfexport/pdfexport.cxx b/vcl/qa/cppunit/pdfexport/pdfexport.cxx index 74283bdae3d3..c4158552677d 100644 --- a/vcl/qa/cppunit/pdfexport/pdfexport.cxx +++ b/vcl/qa/cppunit/pdfexport/pdfexport.cxx @@ -1357,6 +1357,42 @@ CPPUNIT_TEST_FIXTURE(PdfExportTest, testTdf145274) } } +CPPUNIT_TEST_FIXTURE(PdfExportTest, testTdf156685) +{ +// Import the bugdoc and export as PDF. +aMediaDescriptor["FilterName"] <<= OUString("writer_pdf_Export"); +saveAsPDF(u"tdf156685.docx"); + +// Parse the export result with pdfium. +std::unique_ptr pPdfDocument = parsePDFExport(); + +CPPUNIT_ASSERT_EQUAL(1, pPdfDocument->getPageCount()); + +auto pPage = pPdfDocument->openPage(0); +CPPUNIT_ASSERT(pPage); + +int nPageObjectCount = pPage->getObjectCount(); + +CPPUNIT_ASSERT_EQUAL(9, nPageObjectCount); + +auto pTextPage = pPage->getTextPage(); + +for (int i = 0; i < nPageObjectCount; ++i) +{ +std::unique_ptr pPageObject = pPage->getObject(i); +if (pPageObject->getType() != vcl::pdf::PDFPageObjectType::Text) +continue; + +CPPUNIT_ASSERT_EQUAL(11.0, pPageObject->getFontSize()); +CPPUNIT_ASSERT_EQUAL(vcl::pdf::PDFTextRenderMode::Fill, pPageObject->getTextRenderMode()); + +// Without the fix in place, this test would have failed with +// - Expected: rgba[00ff] +// - Actual : rgba[] +CPPUNIT_ASSERT_EQUAL(COL_BLACK, pPageObject->getFillColor()); +} +} + /// Test writing ToUnicode CMAP for doubly encoded glyphs. CPPUNIT_TEST_FIXTURE(PdfExportTest, testTdf66597_1) {
[Libreoffice-bugs] [Bug 106388] FILEOPEN: Flat MS Office Word 2003 XML file opens with wrong import filter
https://bugs.documentfoundation.org/show_bug.cgi?id=106388 --- Comment #9 from Ken Parker --- We at OpenText have a product, WebReports, with thousands of users producing thousands of these documents per day. We would really appreciate anything that could be done to move this issue up the priority list. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157852] Table Rows are not displayed
https://bugs.documentfoundation.org/show_bug.cgi?id=157852 raal changed: What|Removed |Added CC||kha...@libreoffice.org Version|7.5.3.2 release |4.2.0.4 release OS|Windows (All) |All --- Comment #3 from raal --- bisected with bibisect-41max [linux] to 25e5e68d27a53133d884691e880dbdc186610577 is the first bad commit commit 25e5e68d27a53133d884691e880dbdc186610577 Author: Matthew Francis Date: Fri Sep 18 11:10:18 2015 +0800 source-hash-f9560c8f9982eaef09b74baa479c187f049c4f9e commit f9560c8f9982eaef09b74baa479c187f049c4f9e Author: Khaled Hosny AuthorDate: Sat May 11 07:07:29 2013 +0200 Commit: Khaled Hosny CommitDate: Sat May 11 08:55:39 2013 +0200 Cleanup FreeType ascender/descender handling a bit Not sure if it's relevant. Before this commit is table on first page, after the commit the bug appears, but maybe only sizing of font was changed and there is not enough area to show rows? cc to Khaled. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103100] [META] Writer table bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=103100 raal changed: What|Removed |Added Depends on||157852 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=157852 [Bug 157852] Table Rows are not displayed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157852] Table Rows are not displayed
https://bugs.documentfoundation.org/show_bug.cgi?id=157852 raal changed: What|Removed |Added Ever confirmed|0 |1 Keywords||regression CC||r...@post.cz Status|UNCONFIRMED |NEW Blocks||103100 --- Comment #2 from raal --- Repro with Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 3649dc202bedf72e37c77993a1f7027bfdfc6d9e CPU threads: 4; OS: Linux 6.2; UI render: default; VCL: gtk3 Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US Calc: threaded When I unclick "Repeat heading" or click "Allow row to break accross pages and columns" in table properties, then all rows appears. In Version 4.1.0.0.alpha0+ (Build ID: efca6f15609322f62a35619619a6d5fe5c9bd5a) is table rendered on second page. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103100 [Bug 103100] [META] Writer table bugs -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 38194] Style indicator in document margin
https://bugs.documentfoundation.org/show_bug.cgi?id=38194 Gabriele Ponzo changed: What|Removed |Added CC||gpo...@gmail.com --- Comment #72 from Gabriele Ponzo --- I definitely LOVE this feature!!! Thank you so much Jim and compliments to have been able to achieve such a great result! A quick note: on master documents (ODM) the option to highlight the styles doesn't appear, but it's a minor issue. Should I open a bug for that? Anyway THANK YOU again and again! -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157857] Ctrl+W closes all open documents, not just the active window
https://bugs.documentfoundation.org/show_bug.cgi?id=157857 raal changed: What|Removed |Added CC||r...@post.cz --- Comment #2 from raal --- I can not confirm with Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 3649dc202bedf72e37c77993a1f7027bfdfc6d9e CPU threads: 4; OS: Linux 6.2; UI render: default; VCL: gtk3 Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: writerfilter/qa writerfilter/source
writerfilter/qa/cppunittests/dmapper/DomainMapper_Impl.cxx |2 - writerfilter/source/dmapper/DomainMapper_Impl.cxx | 10 writerfilter/source/dmapper/FormControlHelper.cxx |2 - writerfilter/source/dmapper/TextEffectsHandler.cxx |2 - writerfilter/source/ooxml/OOXMLDocumentImpl.cxx|6 ++-- writerfilter/source/ooxml/OOXMLStreamImpl.cxx | 16 ++--- 6 files changed, 19 insertions(+), 19 deletions(-) New commits: commit de087da9242a5d24fcc97b42e216e5375bca3f1b Author: Stephan Bergmann AuthorDate: Thu Oct 19 10:30:41 2023 +0200 Commit: Stephan Bergmann CommitDate: Sat Oct 21 00:00:47 2023 +0200 Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: writerfilter Change-Id: I6d566f7d7d2ef3d7d5efdd3cc94f129c6b4dbbb3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158292 Tested-by: Jenkins Reviewed-by: Stephan Bergmann diff --git a/writerfilter/qa/cppunittests/dmapper/DomainMapper_Impl.cxx b/writerfilter/qa/cppunittests/dmapper/DomainMapper_Impl.cxx index 97a19ef8da68..10311ef8176e 100644 --- a/writerfilter/qa/cppunittests/dmapper/DomainMapper_Impl.cxx +++ b/writerfilter/qa/cppunittests/dmapper/DomainMapper_Impl.cxx @@ -74,7 +74,7 @@ CPPUNIT_TEST_FIXTURE(Test, testNumberingRestartStyleParent) uno::UNO_QUERY); uno::Reference xParaEnum = xParaEnumAccess->createEnumeration(); uno::Reference xPara; -static constexpr OUStringLiteral aProp(u"ListLabelString"); +static constexpr OUString aProp(u"ListLabelString"_ustr); xPara.set(xParaEnum->nextElement(), uno::UNO_QUERY); CPPUNIT_ASSERT_EQUAL(OUString("A."), xPara->getPropertyValue(aProp).get()); xPara.set(xParaEnum->nextElement(), uno::UNO_QUERY); diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.cxx b/writerfilter/source/dmapper/DomainMapper_Impl.cxx index fd27e92510d5..24071c73d1ea 100644 --- a/writerfilter/source/dmapper/DomainMapper_Impl.cxx +++ b/writerfilter/source/dmapper/DomainMapper_Impl.cxx @@ -799,7 +799,7 @@ void DomainMapper_Impl::RemoveLastParagraph( ) return; uno::Reference xDocProps(GetTextDocument(), uno::UNO_QUERY_THROW); -static constexpr OUStringLiteral RecordChanges(u"RecordChanges"); +static constexpr OUString RecordChanges(u"RecordChanges"_ustr); comphelper::ScopeGuard redlineRestore( [xDocProps, aPreviousValue = xDocProps->getPropertyValue(RecordChanges)]() @@ -4713,7 +4713,7 @@ static sal_Int16 lcl_ParseNumberingType( std::u16string_view rCommand ) // The command looks like: " PAGE \* Arabic " // tdf#132185: but may as well be "PAGE \* Arabic" OUString sNumber; -constexpr OUStringLiteral rSeparator(u"\\* "); +constexpr OUString rSeparator(u"\\* "_ustr); if (size_t nStartIndex = rCommand.find(rSeparator); nStartIndex != std::u16string_view::npos) { sal_Int32 nStartIndex2 = nStartIndex + rSeparator.getLength(); @@ -6299,9 +6299,9 @@ static uno::Sequence< beans::PropertyValues > lcl_createTOXLevelHyperlinks( bool std::vector aNewLevel; aNewLevel.reserve(aLevel.getLength() + 5); // at most 5 added items -static constexpr OUStringLiteral tokType(u"TokenType"); -static constexpr OUStringLiteral tokHStart(u"TokenHyperlinkStart"); -static constexpr OUStringLiteral tokHEnd(u"TokenHyperlinkEnd"); +static constexpr OUString tokType(u"TokenType"_ustr); +static constexpr OUString tokHStart(u"TokenHyperlinkStart"_ustr); +static constexpr OUString tokHEnd(u"TokenHyperlinkEnd"_ustr); static constexpr OUStringLiteral tokPNum(u"TokenPageNumber"); static constexpr OUStringLiteral tokENum(u"TokenEntryNumber"); diff --git a/writerfilter/source/dmapper/FormControlHelper.cxx b/writerfilter/source/dmapper/FormControlHelper.cxx index 751b96db385b..40f5d703815e 100644 --- a/writerfilter/source/dmapper/FormControlHelper.cxx +++ b/writerfilter/source/dmapper/FormControlHelper.cxx @@ -92,7 +92,7 @@ uno::Reference const & FormControlHelper::FormControlHelper_Impl::g if (xFormsSupplier.is()) { uno::Reference xFormsNamedContainer(xFormsSupplier->getForms()); -static constexpr OUStringLiteral sDOCXForm = u"DOCX-Standard"; +static constexpr OUString sDOCXForm = u"DOCX-Standard"_ustr; OUString sFormName(sDOCXForm); sal_uInt16 nUnique = 0; diff --git a/writerfilter/source/dmapper/TextEffectsHandler.cxx b/writerfilter/source/dmapper/TextEffectsHandler.cxx index 2a3deb5d0e87..35d7efbbfee2 100644 --- a/writerfilter/source/dmapper/TextEffectsHandler.cxx +++ b/writerfilter/source/dmapper/TextEffectsHandler.cxx @@ -71,7 +71,7 @@ OUString lclGetNameForElementId(sal_uInt32 aId) return aIdMap[aId]; } -constexpr OUStringLiteral constAttributesSequenceName = u"attributes"; +constexpr OUString
[Libreoffice-bugs] [Bug 157851] FILEOPEN XLSX "Author" information about notes is not read
https://bugs.documentfoundation.org/show_bug.cgi?id=157851 raal changed: What|Removed |Added Ever confirmed|0 |1 CC||r...@post.cz Status|UNCONFIRMED |NEW --- Comment #2 from raal --- Confirm Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 3649dc202bedf72e37c77993a1f7027bfdfc6d9e CPU threads: 4; OS: Linux 6.2; UI render: default; VCL: gtk3 Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157818] Background color not visible in sidebar-styles-preview
https://bugs.documentfoundation.org/show_bug.cgi?id=157818 raal changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO CC||r...@post.cz --- Comment #11 from raal --- Cannot reproduce with Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 3649dc202bedf72e37c77993a1f7027bfdfc6d9e CPU threads: 4; OS: Linux 6.2; UI render: default; VCL: gtk3 Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US Calc: threaded Please attach sample file. Thank you. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157844] [META] Automatic color bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=157844 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||48707 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=48707 [Bug 48707] FILESAVE overline automatic color incorrect in pdf -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103378] [META] PDF export bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103378 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on|141134 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=141134 [Bug 141134] The overline automatic color is exported to PDF differently than in original document -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157844] [META] Automatic color bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=157844 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on|141134 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=141134 [Bug 141134] The overline automatic color is exported to PDF differently than in original document -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141134] The overline automatic color is exported to PDF differently than in original document
https://bugs.documentfoundation.org/show_bug.cgi?id=141134 Stéphane Guillou (stragu) changed: What|Removed |Added Blocks|103378, 157844 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103378 [Bug 103378] [META] PDF export bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=157844 [Bug 157844] [META] Automatic color bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sd/qa sd/source
sd/qa/unit/SVGExportTests.cxx|2 sd/qa/unit/export-tests-ooxml1.cxx | 16 +-- sd/qa/unit/export-tests-ooxml3.cxx | 14 +-- sd/qa/unit/misc-tests.cxx| 67 ++- sd/source/console/PresenterNotesView.cxx |4 sd/source/filter/grf/sdgrffilter.cxx |2 sd/source/filter/xml/sdtransform.cxx |4 sd/source/filter/xml/sdxmlwrp.cxx|2 sd/source/ui/animations/CustomAnimationDialog.cxx|2 sd/source/ui/animations/CustomAnimationList.cxx |4 sd/source/ui/animations/CustomAnimationPane.cxx |4 sd/source/ui/controller/slidelayoutcontroller.cxx|2 sd/source/ui/dlg/TemplateScanner.cxx |2 sd/source/ui/docshell/docshel3.cxx |8 - sd/source/ui/framework/factories/PresentationFactory.cxx |2 sd/source/ui/remotecontrol/ImagePreparer.cxx |4 sd/source/ui/slideshow/slideshowimpl.cxx |6 - sd/source/ui/tools/EventMultiplexer.cxx |4 sd/source/ui/unoidl/DrawController.cxx |2 sd/source/ui/unoidl/unomodel.cxx |4 sd/source/ui/unoidl/unoobj.cxx | 32 +++ sd/source/ui/unoidl/unopage.cxx |4 sd/source/ui/view/DocumentRenderer.cxx |2 sd/source/ui/view/drviewsf.cxx |8 - 24 files changed, 97 insertions(+), 104 deletions(-) New commits: commit c184f93863c27c5a59614ad0c47bea699abb1e7b Author: Stephan Bergmann AuthorDate: Thu Oct 19 10:32:21 2023 +0200 Commit: Stephan Bergmann CommitDate: Fri Oct 20 23:30:58 2023 +0200 Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: sd Change-Id: I4dc708ee57a7e305f4e377bde0e486299df56f0d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158297 Tested-by: Jenkins Reviewed-by: Stephan Bergmann diff --git a/sd/qa/unit/SVGExportTests.cxx b/sd/qa/unit/SVGExportTests.cxx index aae0d2e00a36..713cd3b5a4d6 100644 --- a/sd/qa/unit/SVGExportTests.cxx +++ b/sd/qa/unit/SVGExportTests.cxx @@ -263,7 +263,7 @@ public: void testSVGPlaceholderLocale() { -static constexpr OUStringLiteral aLangISO(u"it-IT"); +static constexpr OUString aLangISO(u"it-IT"_ustr); SvtSysLocaleOptions aSysLocaleOptions; aSysLocaleOptions.SetLocaleConfigString(aLangISO); aSysLocaleOptions.SetUILocaleConfigString(aLangISO); diff --git a/sd/qa/unit/export-tests-ooxml1.cxx b/sd/qa/unit/export-tests-ooxml1.cxx index 28cba427ce26..167f67f8674e 100644 --- a/sd/qa/unit/export-tests-ooxml1.cxx +++ b/sd/qa/unit/export-tests-ooxml1.cxx @@ -1409,8 +1409,7 @@ CPPUNIT_TEST_FIXTURE(SdOOXMLExportTest1, testTdf100348FontworkBitmapFill) // Make sure the fontwork shape has a blip bitmap fill and a colored outline. // Without the patch, fill and outline were black. xmlDocUniquePtr pXmlDoc = parseExport("ppt/slides/slide1.xml"); -static constexpr OStringLiteral sPathStart( -"//p:sld/p:cSld/p:spTree/p:sp/p:txBody/a:p/a:r/a:rPr"); +static constexpr OString sPathStart("//p:sld/p:cSld/p:spTree/p:sp/p:txBody/a:p/a:r/a:rPr"_ostr); assertXPath(pXmlDoc, sPathStart + "/a:blipFill/a:blip", 1); assertXPath(pXmlDoc, sPathStart + "/a:ln/a:solidFill/a:srgbClr", "val", "ffbf00"); } @@ -1423,8 +1422,7 @@ CPPUNIT_TEST_FIXTURE(SdOOXMLExportTest1, testTdf100348FontworkGradientGlow) // Make sure the fontwork shape has a gradient fill and a colored glow. // Without the patch, fill was black and no glow applied. xmlDocUniquePtr pXmlDoc = parseExport("ppt/slides/slide1.xml"); -static constexpr OStringLiteral sPathStart( -"//p:sld/p:cSld/p:spTree/p:sp/p:txBody/a:p/a:r/a:rPr"); +static constexpr OString sPathStart("//p:sld/p:cSld/p:spTree/p:sp/p:txBody/a:p/a:r/a:rPr"_ostr); assertXPath(pXmlDoc, sPathStart + "/a:gradFill/a:gsLst/a:gs[1]/a:srgbClr", "val", "8d281e"); assertXPath(pXmlDoc, sPathStart + "/a:effectLst/a:glow", "rad", "63360"); assertXPath(pXmlDoc, sPathStart + "/a:effectLst/a:glow/a:srgbClr", "val", "ff4500"); @@ -1447,7 +1445,7 @@ CPPUNIT_TEST_FIXTURE(SdOOXMLExportTest1, testTdf128345GradientLinear) // Make sure the shape has a lin fill. Without the patch, fill was solid red. xmlDocUniquePtr pXmlDoc = parseExport("ppt/slides/slide1.xml"); -static constexpr OStringLiteral sPathStart("//p:sld/p:cSld/p:spTree/p:sp/p:spPr/a:gradFill"); +static constexpr OString sPathStart("//p:sld/p:cSld/p:spTree/p:sp/p:spPr/a:gradFill"_ostr); assertXPath(pXmlDoc, sPathStart + "/a:lin", "ang", "360"); assertXPath(pXmlDoc, sPathStart + "/a:gsLst/a:gs", 2); assertXPath(pXmlDoc, sPathStart + "/a:gsLst/a:gs[1]",
[Libreoffice-commits] core.git: writerperfect/source
writerperfect/source/impress/KeynoteImportFilter.cxx |4 ++-- writerperfect/source/writer/EPUBPackage.cxx |2 +- 2 files changed, 3 insertions(+), 3 deletions(-) New commits: commit 9108c6e2755b8d6de3b20ad9a868dd393d5b80a8 Author: Stephan Bergmann AuthorDate: Thu Oct 19 10:30:41 2023 +0200 Commit: Stephan Bergmann CommitDate: Fri Oct 20 22:56:41 2023 +0200 Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: writerperfect Change-Id: Ibaf69c1d922be6fade028ce6602f215cd9cd35cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158293 Tested-by: Jenkins Reviewed-by: Stephan Bergmann diff --git a/writerperfect/source/impress/KeynoteImportFilter.cxx b/writerperfect/source/impress/KeynoteImportFilter.cxx index abf7d21e4055..c2fb11012391 100644 --- a/writerperfect/source/impress/KeynoteImportFilter.cxx +++ b/writerperfect/source/impress/KeynoteImportFilter.cxx @@ -215,8 +215,8 @@ KeynoteImportFilter::detect(css::uno::Sequence& Descr if (bUCBContentChanged) pDescriptor[nUCBContentLocation].Value <<= xContent; -static constexpr OUStringLiteral sTypeName(u"impress_AppleKeynote"); -pDescriptor[nTypeNameLocation].Value <<= OUString(sTypeName); +static constexpr OUString sTypeName(u"impress_AppleKeynote"_ustr); +pDescriptor[nTypeNameLocation].Value <<= sTypeName; return sTypeName; } diff --git a/writerperfect/source/writer/EPUBPackage.cxx b/writerperfect/source/writer/EPUBPackage.cxx index ba8bac1d91ce..6ad143aa5e49 100644 --- a/writerperfect/source/writer/EPUBPackage.cxx +++ b/writerperfect/source/writer/EPUBPackage.cxx @@ -43,7 +43,7 @@ EPUBPackage::EPUBPackage(uno::Reference xContext, mxOutputStream.set( mxStorage->openStreamElementByHierarchicalName("mimetype", embed::ElementModes::READWRITE), uno::UNO_QUERY); -static constexpr OStringLiteral aMimeType("application/epub+zip"); +static constexpr OString aMimeType("application/epub+zip"_ostr); uno::Sequence aData(reinterpret_cast(aMimeType.getStr()), aMimeType.getLength()); mxOutputStream->writeBytes(aData);
[Libreoffice-bugs] [Bug 157869] New: UI strings "columns number" and "columns spacing" are not proper English
https://bugs.documentfoundation.org/show_bug.cgi?id=157869 Bug ID: 157869 Summary: UI strings "columns number" and "columns spacing" are not proper English Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tuomas.hiet...@iki.fi Description: The UI strings "columns number" and "columns spacing" are not proper English and their meanings are a bit unclear. The meanings might be "Number of columns" for the first one and "Spacing of columns" / "Column spacing" for the second, but I haven't checked. Steps to Reproduce: 1. See https://translations.documentfoundation.org/translate/libo_ui-master/svxmessages/en/?checksum=92c916f1dcce67a6 and https://translations.documentfoundation.org/translate/libo_ui-master/svxmessages/en/?checksum=bb377b5ca1b7931c Actual Results: The strings are not proper English. Expected Results: The strings are proper English and factually correct. Reproducible: Always User Profile Reset: No Additional Info: n/a -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: vcl/jsdialog vcl/qa vcl/source vcl/unx
vcl/jsdialog/jsdialogbuilder.cxx |2 vcl/qa/cppunit/GraphicTest.cxx |4 vcl/qa/cppunit/PDFDocumentTest.cxx |2 vcl/qa/cppunit/TypeSerializerTest.cxx |2 vcl/qa/cppunit/mnemonic.cxx|4 vcl/source/control/wizardmachine.cxx |4 vcl/source/font/font.cxx |4 vcl/source/fontsubset/cff.cxx | 782 - vcl/source/gdi/formpdfexport.cxx | 40 - vcl/source/image/ImplImageTree.cxx |2 vcl/source/treelist/transfer.cxx | 22 vcl/unx/generic/dtrans/config.cxx |2 vcl/unx/generic/printer/ppdparser.cxx |2 vcl/unx/generic/printer/printerinfomanager.cxx |4 14 files changed, 438 insertions(+), 438 deletions(-) New commits: commit d49abee2132d6c572afa86898929fc2ad5b982b1 Author: Stephan Bergmann AuthorDate: Thu Oct 19 10:30:40 2023 +0200 Commit: Stephan Bergmann CommitDate: Fri Oct 20 22:48:21 2023 +0200 Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: vcl Change-Id: Iaeacacbbb0eec907d884219aa2bcfe7a86f00a2c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158291 Tested-by: Jenkins Reviewed-by: Stephan Bergmann diff --git a/vcl/jsdialog/jsdialogbuilder.cxx b/vcl/jsdialog/jsdialogbuilder.cxx index 91e09663bef1..47743ac5ffc7 100644 --- a/vcl/jsdialog/jsdialogbuilder.cxx +++ b/vcl/jsdialog/jsdialogbuilder.cxx @@ -1818,7 +1818,7 @@ JSMessageDialog::~JSMessageDialog() void JSMessageDialog::RememberMessageDialog() { -static constexpr OUStringLiteral sWidgetName = u"__DIALOG__"; +static constexpr OUString sWidgetName = u"__DIALOG__"_ustr; OUString sWindowId = OUString::number(m_xMessageDialog->GetLOKWindowId()); if (JSInstanceBuilder::FindWeldWidgetsMap(sWindowId, sWidgetName) != nullptr) return; diff --git a/vcl/qa/cppunit/GraphicTest.cxx b/vcl/qa/cppunit/GraphicTest.cxx index ef9678e42197..94cbd654b5ce 100644 --- a/vcl/qa/cppunit/GraphicTest.cxx +++ b/vcl/qa/cppunit/GraphicTest.cxx @@ -146,8 +146,8 @@ bool checkBitmap(Graphic& rGraphic) return bResult; } -constexpr OUStringLiteral DATA_DIRECTORY = u"/vcl/qa/cppunit/data/"; -constexpr OUStringLiteral PDFEXPORT_DATA_DIRECTORY = u"/vcl/qa/cppunit/pdfexport/data/"; +constexpr OUString DATA_DIRECTORY = u"/vcl/qa/cppunit/data/"_ustr; +constexpr OUString PDFEXPORT_DATA_DIRECTORY = u"/vcl/qa/cppunit/pdfexport/data/"_ustr; Graphic loadGraphic(std::u16string_view const& rFilename) { diff --git a/vcl/qa/cppunit/PDFDocumentTest.cxx b/vcl/qa/cppunit/PDFDocumentTest.cxx index 35af8e66cd58..88fcdc0a765b 100644 --- a/vcl/qa/cppunit/PDFDocumentTest.cxx +++ b/vcl/qa/cppunit/PDFDocumentTest.cxx @@ -22,7 +22,7 @@ public: PDFDocumentTest() = default; }; -constexpr OUStringLiteral DATA_DIRECTORY = u"/vcl/qa/cppunit/data/"; +constexpr OUString DATA_DIRECTORY = u"/vcl/qa/cppunit/data/"_ustr; CPPUNIT_TEST_FIXTURE(PDFDocumentTest, testParseBasicPDF) { diff --git a/vcl/qa/cppunit/TypeSerializerTest.cxx b/vcl/qa/cppunit/TypeSerializerTest.cxx index 2ffa3ec1257f..726843e19a03 100644 --- a/vcl/qa/cppunit/TypeSerializerTest.cxx +++ b/vcl/qa/cppunit/TypeSerializerTest.cxx @@ -34,7 +34,7 @@ namespace { -constexpr OUStringLiteral DATA_DIRECTORY = u"/vcl/qa/cppunit/data/"; +constexpr OUString DATA_DIRECTORY = u"/vcl/qa/cppunit/data/"_ustr; std::vector calculateHash(SvStream& rStream) { diff --git a/vcl/qa/cppunit/mnemonic.cxx b/vcl/qa/cppunit/mnemonic.cxx index 05ef7366cd21..9b6ce7d073ac 100644 --- a/vcl/qa/cppunit/mnemonic.cxx +++ b/vcl/qa/cppunit/mnemonic.cxx @@ -60,11 +60,11 @@ void VclMnemonicTest::testMnemonic() } { -static constexpr OUStringLiteral TEST = u"\u4E00"; +static constexpr OUString TEST = u"\u4E00"_ustr; OUString sResult = aGenerator.CreateMnemonic(TEST); CPPUNIT_ASSERT_EQUAL(OUString("(~C)"), sResult.copy(sResult.getLength() - 4)); sResult = MnemonicGenerator::EraseAllMnemonicChars(sResult); -CPPUNIT_ASSERT_EQUAL(OUString(TEST), sResult); +CPPUNIT_ASSERT_EQUAL(TEST, sResult); } } diff --git a/vcl/source/control/wizardmachine.cxx b/vcl/source/control/wizardmachine.cxx index f52069404564..38cc87793675 100644 --- a/vcl/source/control/wizardmachine.cxx +++ b/vcl/source/control/wizardmachine.cxx @@ -28,8 +28,8 @@ #include #include "wizimpldata.hxx" -constexpr OUStringLiteral HID_WIZARD_NEXT = u"SVT_HID_WIZARD_NEXT"; -constexpr OUStringLiteral HID_WIZARD_PREVIOUS = u"SVT_HID_WIZARD_PREVIOUS"; +constexpr OUString HID_WIZARD_NEXT = u"SVT_HID_WIZARD_NEXT"_ustr; +constexpr OUString HID_WIZARD_PREVIOUS = u"SVT_HID_WIZARD_PREVIOUS"_ustr; #define WIZARDDIALOG_BUTTON_OFFSET_Y6 #define WIZARDDIALOG_BUTTON_DLGOFFSET_X 6 diff --git a/vcl/source/font/font.cxx b/vcl/source/font/font.cxx index 7b48855f247a..6dfee423a998 100644 ---
[Libreoffice-commits] core.git: 2 commits - xmlscript/source xmlsecurity/qa xmlsecurity/source
xmlscript/source/xml_helper/xml_impctx.cxx |4 ++-- xmlscript/source/xmllib_imexp/xmllib_export.cxx |4 ++-- xmlsecurity/qa/unit/pdfsigning/pdfsigning.cxx|2 +- xmlsecurity/source/helper/xmlsignaturehelper.cxx |4 ++-- 4 files changed, 7 insertions(+), 7 deletions(-) New commits: commit 0c07a65377d3c2ba50128322fb036f990e17af82 Author: Stephan Bergmann AuthorDate: Thu Oct 19 10:30:43 2023 +0200 Commit: Stephan Bergmann CommitDate: Fri Oct 20 22:48:04 2023 +0200 Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: xmlsecurity Change-Id: I6cdabef12d60f9fa554b95c99e702e8c700329e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158296 Tested-by: Jenkins Reviewed-by: Stephan Bergmann diff --git a/xmlsecurity/qa/unit/pdfsigning/pdfsigning.cxx b/xmlsecurity/qa/unit/pdfsigning/pdfsigning.cxx index c4c5dcf077b3..0196a4707b92 100644 --- a/xmlsecurity/qa/unit/pdfsigning/pdfsigning.cxx +++ b/xmlsecurity/qa/unit/pdfsigning/pdfsigning.cxx @@ -42,7 +42,7 @@ using namespace com::sun::star; namespace { -constexpr OUStringLiteral DATA_DIRECTORY = u"/xmlsecurity/qa/unit/pdfsigning/data/"; +constexpr OUString DATA_DIRECTORY = u"/xmlsecurity/qa/unit/pdfsigning/data/"_ustr; } /// Testsuite for the PDF signing feature. diff --git a/xmlsecurity/source/helper/xmlsignaturehelper.cxx b/xmlsecurity/source/helper/xmlsignaturehelper.cxx index fe363858522d..b20113022cde 100644 --- a/xmlsecurity/source/helper/xmlsignaturehelper.cxx +++ b/xmlsecurity/source/helper/xmlsignaturehelper.cxx @@ -50,8 +50,8 @@ constexpr OUStringLiteral NS_DOCUMENTSIGNATURES = u"http://openoffice.org/2004/documentsignatures;; constexpr OUStringLiteral NS_DOCUMENTSIGNATURES_ODF_1_2 = u"urn:oasis:names:tc:opendocument:xmlns:digitalsignature:1.0"; -constexpr OUStringLiteral OOXML_SIGNATURE_ORIGIN = u"http://schemas.openxmlformats.org/package/2006/relationships/digital-signature/origin;; -constexpr OUStringLiteral OOXML_SIGNATURE_SIGNATURE = u"http://schemas.openxmlformats.org/package/2006/relationships/digital-signature/signature;; +constexpr OUString OOXML_SIGNATURE_ORIGIN = u"http://schemas.openxmlformats.org/package/2006/relationships/digital-signature/origin"_ustr; +constexpr OUString OOXML_SIGNATURE_SIGNATURE = u"http://schemas.openxmlformats.org/package/2006/relationships/digital-signature/signature"_ustr; using namespace ::com::sun::star; using namespace ::com::sun::star::graphic; commit d834361303bd3e2a2e1f42f89e1169544517d11d Author: Stephan Bergmann AuthorDate: Thu Oct 19 10:30:43 2023 +0200 Commit: Stephan Bergmann CommitDate: Fri Oct 20 22:47:50 2023 +0200 Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: xmlscript Change-Id: I8cde43bdc93b45376e9684f98f654d050864 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158295 Tested-by: Jenkins Reviewed-by: Stephan Bergmann diff --git a/xmlscript/source/xml_helper/xml_impctx.cxx b/xmlscript/source/xml_helper/xml_impctx.cxx index e38263243717..27a5e746a854 100644 --- a/xmlscript/source/xml_helper/xml_impctx.cxx +++ b/xmlscript/source/xml_helper/xml_impctx.cxx @@ -162,8 +162,8 @@ public: } -constexpr OUStringLiteral g_sXMLNS_PREFIX_UNKNOWN( u"<<< unknown prefix >>>" ); -constexpr OUStringLiteral g_sXMLNS( u"xmlns" ); +constexpr OUString g_sXMLNS_PREFIX_UNKNOWN( u"<<< unknown prefix >>>"_ustr ); +constexpr OUString g_sXMLNS( u"xmlns"_ustr ); DocumentHandlerImpl::DocumentHandlerImpl( diff --git a/xmlscript/source/xmllib_imexp/xmllib_export.cxx b/xmlscript/source/xmllib_imexp/xmllib_export.cxx index 00f8045a0b0c..6ab9b994c9c2 100644 --- a/xmlscript/source/xmllib_imexp/xmllib_export.cxx +++ b/xmlscript/source/xmllib_imexp/xmllib_export.cxx @@ -29,8 +29,8 @@ using namespace com::sun::star; namespace xmlscript { -constexpr OUStringLiteral aTrueStr = u"true"; -constexpr OUStringLiteral aFalseStr = u"false"; +constexpr OUString aTrueStr = u"true"_ustr; +constexpr OUString aFalseStr = u"false"_ustr; void exportLibraryContainer(
[Libreoffice-commits] core.git: xmloff/qa xmloff/source
xmloff/qa/unit/draw.cxx |4 xmloff/source/chart/ColorPropertySet.cxx|2 xmloff/source/chart/SchXMLExport.cxx|2 xmloff/source/chart/SchXMLSeries2Context.cxx|2 xmloff/source/chart/SchXMLTableContext.cxx |4 xmloff/source/chart/SchXMLTools.cxx |8 - xmloff/source/core/xmlexp.cxx | 44 +++--- xmloff/source/draw/XMLGraphicsDefaultStyle.cxx |2 xmloff/source/draw/XMLImageMapContext.cxx |2 xmloff/source/draw/XMLImageMapExport.cxx|2 xmloff/source/draw/animexp.cxx | 24 +-- xmloff/source/draw/sdxmlexp.cxx | 16 +- xmloff/source/draw/sdxmlimp.cxx |2 xmloff/source/draw/shapeexport.cxx | 26 +-- xmloff/source/draw/ximppage.cxx |8 - xmloff/source/draw/ximpshap.cxx | 12 - xmloff/source/forms/elementimport.cxx |2 xmloff/source/meta/xmlmetai.cxx |6 xmloff/source/meta/xmlversion.cxx |2 xmloff/source/script/XMLScriptContextFactory.cxx|8 - xmloff/source/script/XMLStarBasicContextFactory.cxx | 10 - xmloff/source/style/PageMasterImportContext.cxx |2 xmloff/source/style/XMLPageExport.cxx |6 xmloff/source/style/numehelp.cxx|8 - xmloff/source/style/prstylei.cxx|4 xmloff/source/style/styleexp.cxx| 10 - xmloff/source/style/xmlnume.cxx |6 xmloff/source/style/xmlnumi.cxx |6 xmloff/source/style/xmlstyle.cxx|4 xmloff/source/table/XMLTableExport.cxx |2 xmloff/source/text/XMLIndexBibliographyConfigurationContext.cxx |6 xmloff/source/text/XMLSectionExport.cxx |2 xmloff/source/text/XMLTextFrameContext.cxx | 12 - xmloff/source/text/XMLTextHeaderFooterContext.cxx |2 xmloff/source/text/XMLTextListAutoStylePool.cxx |2 xmloff/source/text/XMLTextListBlockContext.cxx |2 xmloff/source/text/XMLTextMarkImportContext.cxx |4 xmloff/source/text/XMLTextMasterPageContext.cxx |2 xmloff/source/text/XMLTextMasterPageExport.cxx |2 xmloff/source/text/XMLTextShapeStyleContext.cxx |2 xmloff/source/text/txtflde.cxx | 70 +- xmloff/source/text/txtfldi.cxx | 60 xmloff/source/text/txtimp.cxx | 44 +++--- xmloff/source/text/txtparae.cxx | 62 xmloff/source/text/txtstyli.cxx |8 - xmloff/source/text/txtvfldi.cxx | 20 +- xmloff/source/xforms/xformsexport.cxx |2 47 files changed, 269 insertions(+), 269 deletions(-) New commits: commit fe7f4eab95c0f8262c8e08ef6cfaf54b2cb24f18 Author: Stephan Bergmann AuthorDate: Thu Oct 19 10:30:42 2023 +0200 Commit: Stephan Bergmann CommitDate: Fri Oct 20 22:46:53 2023 +0200 Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: xmloff Change-Id: I2d58bbea770c4dd188cae13e11218a29f4cd5d05 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158294 Tested-by: Jenkins Reviewed-by: Stephan Bergmann diff --git a/xmloff/qa/unit/draw.cxx b/xmloff/qa/unit/draw.cxx index 225f77a09536..c3a556f54967 100644 --- a/xmloff/qa/unit/draw.cxx +++ b/xmloff/qa/unit/draw.cxx @@ -758,8 +758,8 @@ CPPUNIT_TEST_FIXTURE(XmloffDrawTest, testTdf156975_ThemeExport) // and check the markup. xmlDocUniquePtr pXmlDoc = parseExport("styles.xml"); -static constexpr OStringLiteral sThemePath -= "//office:master-styles/style:master-page/loext:theme"; +static constexpr OString sThemePath += "//office:master-styles/style:master-page/loext:theme"_ostr; assertXPath(pXmlDoc, sThemePath, 1); assertXPath(pXmlDoc, sThemePath + "[@loext:name='Custom']"); diff --git a/xmloff/source/chart/ColorPropertySet.cxx b/xmloff/source/chart/ColorPropertySet.cxx index 237888980d6a..b7a4b45dd893 100644 --- a/xmloff/source/chart/ColorPropertySet.cxx +++ b/xmloff/source/chart/ColorPropertySet.cxx @@ -44,7 +44,7 @@ protected: virtual sal_Bool SAL_CALL hasPropertyByName(
[Libreoffice-commits] core.git: vbahelper/source
vbahelper/source/msforms/vbamultipage.cxx|2 +- vbahelper/source/msforms/vbaprogressbar.cxx |2 +- vbahelper/source/vbahelper/vbaglobalbase.cxx |2 +- vbahelper/source/vbahelper/vbahelper.cxx | 16 4 files changed, 11 insertions(+), 11 deletions(-) New commits: commit 335e73a7f37f5efc08a6691d8e4b271c68e0a2ac Author: Stephan Bergmann AuthorDate: Thu Oct 19 10:30:39 2023 +0200 Commit: Stephan Bergmann CommitDate: Fri Oct 20 22:46:23 2023 +0200 Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: vbahelper Change-Id: Idb944974318a94763532639c9e74040adadf06f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158290 Tested-by: Jenkins Reviewed-by: Stephan Bergmann diff --git a/vbahelper/source/msforms/vbamultipage.cxx b/vbahelper/source/msforms/vbamultipage.cxx index 183a93b667d4..72f62b665248 100644 --- a/vbahelper/source/msforms/vbamultipage.cxx +++ b/vbahelper/source/msforms/vbamultipage.cxx @@ -25,7 +25,7 @@ using namespace com::sun::star; using namespace ooo::vba; -constexpr OUStringLiteral SVALUE( u"MultiPageValue" ); +constexpr OUString SVALUE( u"MultiPageValue"_ustr ); namespace { diff --git a/vbahelper/source/msforms/vbaprogressbar.cxx b/vbahelper/source/msforms/vbaprogressbar.cxx index f988112b5c52..2e6462e4d72b 100644 --- a/vbahelper/source/msforms/vbaprogressbar.cxx +++ b/vbahelper/source/msforms/vbaprogressbar.cxx @@ -22,7 +22,7 @@ using namespace com::sun::star; using namespace ooo::vba; // uno servicename com.sun.star.awt.UnoControlProgressBarMode -constexpr OUStringLiteral SVALUE( u"ProgressValue" ); +constexpr OUString SVALUE( u"ProgressValue"_ustr ); ScVbaProgressBar::ScVbaProgressBar( const uno::Reference< ov::XHelperInterface >& xParent, const uno::Reference< uno::XComponentContext >& xContext, const uno::Reference< uno::XInterface >& xControl, const uno::Reference< frame::XModel >& xModel, std::unique_ptr pGeomHelper ) : ProgressBarImpl_BASE( xParent, xContext, xControl, xModel, std::move(pGeomHelper) ) diff --git a/vbahelper/source/vbahelper/vbaglobalbase.cxx b/vbahelper/source/vbahelper/vbaglobalbase.cxx index 13273f246060..a8a0d6df3a8d 100644 --- a/vbahelper/source/vbahelper/vbaglobalbase.cxx +++ b/vbahelper/source/vbahelper/vbaglobalbase.cxx @@ -34,7 +34,7 @@ using namespace ooo::vba; // special key to return the Application const char sAppService[] = "ooo.vba.Application"; -constexpr OUStringLiteral gsApplication( u"Application" ); +constexpr OUString gsApplication( u"Application"_ustr ); VbaGlobalsBase::VbaGlobalsBase( const uno::Reference< ov::XHelperInterface >& xParent, diff --git a/vbahelper/source/vbahelper/vbahelper.cxx b/vbahelper/source/vbahelper/vbahelper.cxx index 20fa519dc0d6..0e0c7b9c8f28 100644 --- a/vbahelper/source/vbahelper/vbahelper.cxx +++ b/vbahelper/source/vbahelper/vbahelper.cxx @@ -854,14 +854,14 @@ double UserFormGeometryHelper::getOffsetY() const return mfOffsetY; } -constexpr OUStringLiteral saPosXName = u"PositionX"; -constexpr OUStringLiteral saPosYName = u"PositionY"; -constexpr OUStringLiteral saWidthName = u"Width"; -constexpr OUStringLiteral saHeightName = u"Height"; +constexpr OUString saPosXName = u"PositionX"_ustr; +constexpr OUString saPosYName = u"PositionY"_ustr; +constexpr OUString saWidthName = u"Width"_ustr; +constexpr OUString saHeightName = u"Height"_ustr; double UserFormGeometryHelper::implGetPos( bool bPosY ) const { -sal_Int32 nPosAppFont = mxModelProps->getPropertyValue( bPosY ? OUString(saPosYName) : OUString(saPosXName) ).get< sal_Int32 >(); +sal_Int32 nPosAppFont = mxModelProps->getPropertyValue( bPosY ? saPosYName : saPosXName ).get< sal_Int32 >(); // appfont to pixel awt::Point aPosPixel = mxUnitConv->convertPointToPixel( awt::Point( nPosAppFont, nPosAppFont ), util::MeasureUnit::APPFONT ); // pixel to VBA points @@ -876,12 +876,12 @@ void UserFormGeometryHelper::implSetPos( double fPos, bool bPosY ) awt::Point aPosPixel = mxUnitConv->convertPointToPixel( awt::Point( nPosPixel, nPosPixel ), util::MeasureUnit::POINT ); // pixel to appfont awt::Point aPosAppFont = mxUnitConv->convertPointToLogic( aPosPixel, util::MeasureUnit::APPFONT ); -mxModelProps->setPropertyValue( bPosY ? OUString(saPosYName) : OUString(saPosXName), uno::Any( bPosY ? aPosAppFont.Y : aPosAppFont.X ) ); +mxModelProps->setPropertyValue( bPosY ? saPosYName : saPosXName, uno::Any( bPosY ? aPosAppFont.Y : aPosAppFont.X ) ); } double UserFormGeometryHelper::implGetSize( bool bHeight, bool bOuter ) const { -sal_Int32 nSizeAppFont = mxModelProps->getPropertyValue( bHeight ? OUString(saHeightName) : OUString(saWidthName) ).get< sal_Int32 >(); +sal_Int32 nSizeAppFont = mxModelProps->getPropertyValue( bHeight ? saHeightName : saWidthName ).get< sal_Int32 >(); // appfont to pixel awt::Size aSizePixel = mxUnitConv->convertSizeToPixel( awt::Size( nSizeAppFont,
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - sw/qa sw/source
sw/qa/extras/tiledrendering/tiledrendering.cxx | 10 +- sw/source/core/doc/DocumentRedlineManager.cxx |4 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) New commits: commit 6f35a6f225cc9fb9bacd703417825fcfd439f709 Author: Mike Kaganski AuthorDate: Fri Oct 20 14:35:51 2023 +0300 Commit: Mike Kaganski CommitDate: Fri Oct 20 22:42:57 2023 +0200 Avoid double notifications for deletion case Follow-up to commit 34ac12dca3f5af50fddfb7c77e2943897980b815 When old redline is own Insert, and the new one is Delete, it means that it was already handled in DocumentRedlineManager::DeleteRedline. This also reverts the unit test change done in the mentioned commit. Change-Id: I77e59dceb1c880fc6ec10ad98867be3bf5282f70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158253 Tested-by: Jenkins Reviewed-by: Mike Kaganski (cherry picked from commit b24dbf7f58227e2c0d36f114edca11ef69011ee9) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158270 Tested-by: Jenkins CollaboraOffice diff --git a/sw/qa/extras/tiledrendering/tiledrendering.cxx b/sw/qa/extras/tiledrendering/tiledrendering.cxx index 4f70ac36a87f..91344a563505 100644 --- a/sw/qa/extras/tiledrendering/tiledrendering.cxx +++ b/sw/qa/extras/tiledrendering/tiledrendering.cxx @@ -1690,9 +1690,9 @@ CPPUNIT_TEST_FIXTURE(SwTiledRenderingTest, testRedlineUpdateCallback) m_nRedlineTableEntryModified = 0; pWrtShell->DelLeft(); -// Assert that we get exactly two notification about the redline update. +// Assert that we get exactly one notification about the redline update. // This was 0, as LOK_CALLBACK_REDLINE_TABLE_ENTRY_MODIFIED wasn't sent. -CPPUNIT_ASSERT_EQUAL(2, m_nRedlineTableEntryModified); +CPPUNIT_ASSERT_EQUAL(1, m_nRedlineTableEntryModified); // Turn off the change tracking mode, make some modification to left of the // redline so that its position changes @@ -1701,18 +1701,18 @@ CPPUNIT_TEST_FIXTURE(SwTiledRenderingTest, testRedlineUpdateCallback) pWrtShell->Insert("This text is left of the redline"); // Position of the redline has changed => Modify callback -CPPUNIT_ASSERT_EQUAL(3, m_nRedlineTableEntryModified); +CPPUNIT_ASSERT_EQUAL(2, m_nRedlineTableEntryModified); pWrtShell->DelLeft(); // Deletion also emits Modify callback -CPPUNIT_ASSERT_EQUAL(4, m_nRedlineTableEntryModified); +CPPUNIT_ASSERT_EQUAL(3, m_nRedlineTableEntryModified); // Make changes to the right of the redline => no position change in redline pWrtShell->Right(SwCursorSkipMode::Chars, /*bSelect=*/false, 100/*Go enough right */, /*bBasicCall=*/false); pWrtShell->Insert("This text is right of the redline"); // No Modify callbacks -CPPUNIT_ASSERT_EQUAL(4, m_nRedlineTableEntryModified); +CPPUNIT_ASSERT_EQUAL(3, m_nRedlineTableEntryModified); } CPPUNIT_TEST_FIXTURE(SwTiledRenderingTest, testGetViewRenderState) diff --git a/sw/source/core/doc/DocumentRedlineManager.cxx b/sw/source/core/doc/DocumentRedlineManager.cxx index f538e5d88a81..102e3ec1c780 100644 --- a/sw/source/core/doc/DocumentRedlineManager.cxx +++ b/sw/source/core/doc/DocumentRedlineManager.cxx @@ -1798,8 +1798,8 @@ DocumentRedlineManager::AppendRedline(SwRangeRedline* pNewRedl, bool const bCall delete pNewRedl; pNewRedl = nullptr; -if (!bDec) -MaybeNotifyRedlineModification(*pRedl, m_rDoc); +// No need to call MaybeNotifyRedlineModification, because a notification +// was already sent in DocumentRedlineManager::DeleteRedline break; case SwComparePosition::Outside:
[Libreoffice-bugs] [Bug 157868] New: "contributor accessible description" is not a proper extended tip
https://bugs.documentfoundation.org/show_bug.cgi?id=157868 Bug ID: 157868 Summary: "contributor accessible description" is not a proper extended tip Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: minor Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tuomas.hiet...@iki.fi Description: There's an extended tip in LO that reads "contributor accessible description". I assume this is a forgotten placeholder that should be replaced with a proper sentence. Steps to Reproduce: 1. See https://translations.documentfoundation.org/translate/libo_ui-master/sfx2messages/en/?checksum=a5e915a57b801969 Actual Results: The extended tip is not a proper sentence. Expected Results: The extended tip is a well-formed and descriptive sentence. Reproducible: Always User Profile Reset: No Additional Info: n/a -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145949] FILESAVE DOCX: Text outside Explosion shape on DOCX (fine with DOC)
https://bugs.documentfoundation.org/show_bug.cgi?id=145949 BogdanB changed: What|Removed |Added CC||buzea.bog...@libreoffice.or ||g Version|7.4.0.0 alpha0+ |7.3.0.0.alpha1+ -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157618] FILESAVE: Calc ignores directly formatted text color in .ods files
https://bugs.documentfoundation.org/show_bug.cgi?id=157618 BogdanB changed: What|Removed |Added Version|7.5.7.1 release |7.1.0.0.alpha0+ CC||buzea.bog...@libreoffice.or ||g --- Comment #8 from BogdanB --- The black color is lost also in Version: 7.1.0.0.alpha0+ Build ID: abcc4eb907661e07ad850ccce7eb06f129da4286 CPU threads: 16; OS: Linux 6.2; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US Calc: threaded I don't have older versions. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157867] New: Obsolete Windows 2000 reference in UI strings
https://bugs.documentfoundation.org/show_bug.cgi?id=157867 Bug ID: 157867 Summary: Obsolete Windows 2000 reference in UI strings Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: trivial Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tuomas.hiet...@iki.fi Description: One of the UI strings refers to Windows 2000, even though LO has not supported that version of Windows for a long time, if ever. Perhaps there's obsolete code, too? Steps to Reproduce: 1. See https://translations.documentfoundation.org/translate/libo_ui-master/instsetoo_nativeinc_openofficewindowsmsi_languages/en/?checksum=9dd4a773e372d060 Actual Results: Windows 2000 is mentioned in the UI string. Expected Results: Only strings relevant to versions of Windows currently supported by LO are included. Reproducible: Always User Profile Reset: No Additional Info: n/a -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150004] Validation dropdown stays visible when changing rows/columns
https://bugs.documentfoundation.org/show_bug.cgi?id=150004 BogdanB changed: What|Removed |Added Version|7.5.0.0 alpha0+ |7.3.4.2 release CC||buzea.bog...@libreoffice.or ||g -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151196] FORMATTING "MM/DD/YYYY HH:MM" won't wrap (wrapping uses pre-formatted data?)
https://bugs.documentfoundation.org/show_bug.cgi?id=151196 BogdanB changed: What|Removed |Added Version|7.5.0.0 alpha0+ |6.4 all versions -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151383] UI: slide sorting position icon black box, previously grayish
https://bugs.documentfoundation.org/show_bug.cgi?id=151383 BogdanB changed: What|Removed |Added Version|7.5.0.0 alpha0+ |7.1.0.3 release CC||buzea.bog...@libreoffice.or ||g -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: tools/source
tools/source/fsys/urlobj.cxx | 56 +-- 1 file changed, 28 insertions(+), 28 deletions(-) New commits: commit 5f69ffb27a09e094c5ba9da214c769b5ec2ce406 Author: Stephan Bergmann AuthorDate: Thu Oct 19 10:30:36 2023 +0200 Commit: Stephan Bergmann CommitDate: Fri Oct 20 21:51:02 2023 +0200 Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: tools Change-Id: I930c794c6f93531ef8d2b91c5e6ad62b486966dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158245 Tested-by: Jenkins Reviewed-by: Stephan Bergmann diff --git a/tools/source/fsys/urlobj.cxx b/tools/source/fsys/urlobj.cxx index 897d1c47ebd1..3c54eea3d664 100644 --- a/tools/source/fsys/urlobj.cxx +++ b/tools/source/fsys/urlobj.cxx @@ -318,34 +318,34 @@ struct INetURLObject::PrefixInfo inline INetURLObject::SchemeInfo const & INetURLObject::getSchemeInfo(INetProtocol eTheScheme) { -static constexpr OUStringLiteral EMPTY = u""; -static constexpr OUStringLiteral FTP = u"ftp"; -static constexpr OUStringLiteral HTTP = u"http"; -static constexpr OUStringLiteral FILE1 = u"file"; // because FILE is already defined -static constexpr OUStringLiteral MAILTO = u"mailto"; -static constexpr OUStringLiteral VND_WEBDAV = u"vnd.sun.star.webdav"; -static constexpr OUStringLiteral PRIVATE = u"private"; -static constexpr OUStringLiteral VND_HELP = u"vnd.sun.star.help"; -static constexpr OUStringLiteral HTTPS = u"https"; -static constexpr OUStringLiteral SLOT = u"slot"; -static constexpr OUStringLiteral MACRO = u"macro"; -static constexpr OUStringLiteral JAVASCRIPT = u"javascript"; -static constexpr OUStringLiteral DATA = u"data"; -static constexpr OUStringLiteral CID = u"cid"; -static constexpr OUStringLiteral VND_HIER = u"vnd.sun.star.hier"; -static constexpr OUStringLiteral UNO = u".uno"; -static constexpr OUStringLiteral COMPONENT = u".component"; -static constexpr OUStringLiteral VND_PKG = u"vnd.sun.star.pkg"; -static constexpr OUStringLiteral LDAP = u"ldap"; -static constexpr OUStringLiteral DB = u"db"; -static constexpr OUStringLiteral VND_CMD = u"vnd.sun.star.cmd"; -static constexpr OUStringLiteral TELNET = u"telnet"; -static constexpr OUStringLiteral VND_EXPAND = u"vnd.sun.star.expand"; -static constexpr OUStringLiteral VND_TDOC = u"vnd.sun.star.tdoc"; -static constexpr OUStringLiteral SMB = u"smb"; -static constexpr OUStringLiteral HID = u"hid"; -static constexpr OUStringLiteral SFTP = u"sftp"; -static constexpr OUStringLiteral VND_CMIS = u"vnd.libreoffice.cmis"; +static constexpr OUString EMPTY = u""_ustr; +static constexpr OUString FTP = u"ftp"_ustr; +static constexpr OUString HTTP = u"http"_ustr; +static constexpr OUString FILE1 = u"file"_ustr; // because FILE is already defined +static constexpr OUString MAILTO = u"mailto"_ustr; +static constexpr OUString VND_WEBDAV = u"vnd.sun.star.webdav"_ustr; +static constexpr OUString PRIVATE = u"private"_ustr; +static constexpr OUString VND_HELP = u"vnd.sun.star.help"_ustr; +static constexpr OUString HTTPS = u"https"_ustr; +static constexpr OUString SLOT = u"slot"_ustr; +static constexpr OUString MACRO = u"macro"_ustr; +static constexpr OUString JAVASCRIPT = u"javascript"_ustr; +static constexpr OUString DATA = u"data"_ustr; +static constexpr OUString CID = u"cid"_ustr; +static constexpr OUString VND_HIER = u"vnd.sun.star.hier"_ustr; +static constexpr OUString UNO = u".uno"_ustr; +static constexpr OUString COMPONENT = u".component"_ustr; +static constexpr OUString VND_PKG = u"vnd.sun.star.pkg"_ustr; +static constexpr OUString LDAP = u"ldap"_ustr; +static constexpr OUString DB = u"db"_ustr; +static constexpr OUString VND_CMD = u"vnd.sun.star.cmd"_ustr; +static constexpr OUString TELNET = u"telnet"_ustr; +static constexpr OUString VND_EXPAND = u"vnd.sun.star.expand"_ustr; +static constexpr OUString VND_TDOC = u"vnd.sun.star.tdoc"_ustr; +static constexpr OUString SMB = u"smb"_ustr; +static constexpr OUString HID = u"hid"_ustr; +static constexpr OUString SFTP = u"sftp"_ustr; +static constexpr OUString VND_CMIS = u"vnd.libreoffice.cmis"_ustr; static o3tl::enumarray constexpr map = { // [-loplugin:redundantfcast]:
[Libreoffice-bugs] [Bug 102847] [META] Quick Find, Search and Replace
https://bugs.documentfoundation.org/show_bug.cgi?id=102847 BogdanB changed: What|Removed |Added Depends on||151110 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=151110 [Bug 151110] Search box in bottom bar has silly animation effect -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151110] Search box in bottom bar has silly animation effect
https://bugs.documentfoundation.org/show_bug.cgi?id=151110 BogdanB changed: What|Removed |Added Blocks||102847 CC||buzea.bog...@libreoffice.or ||g Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=102847 [Bug 102847] [META] Quick Find, Search and Replace -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103341] [META] AutoCorrect and Word Completion bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103341 BogdanB changed: What|Removed |Added Depends on||157847 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=157847 [Bug 157847] Automatic correction activated, underlining disappears by increasing the font size -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150690] "Mac OS X Address Book" should be renamed
https://bugs.documentfoundation.org/show_bug.cgi?id=150690 --- Comment #5 from Tuomas Hietala --- This seems to have been fixed in master: https://translations.documentfoundation.org/translate/libo_ui-master/connectivityregistrymacaborgopenofficeofficedataaccess/en/?checksum=141ca7d62053cbc1 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - sw/qa sw/source
sw/qa/core/layout/data/floattable-nested-rowspan.docx |binary sw/qa/core/layout/tabfrm.cxx | 11 + sw/source/core/layout/tabfrm.cxx | 37 ++ 3 files changed, 48 insertions(+) New commits: commit 72f035790a28ad44ce1242f87eb71eb5241cbb17 Author: Miklos Vajna AuthorDate: Fri Oct 20 08:57:08 2023 +0200 Commit: Xisco Fauli CommitDate: Fri Oct 20 21:08:08 2023 +0200 tdf#157590 sw floattable: avoid hang in the nested + row span case Regression from commit 905962db870e9d1cf1dcf3bd1be44c347cddafe1 (sw floattable: handle AllowOverlap==false in the layout, 2023-08-10), the document load resulted in a hang due to a layout loop. What happens is that SwTabFrame::MakeAll() first does a Split(), but the problematic row has cells with rowspans, and once this is combined with multi-page nested floating tables, we move all the content to the next page (we only leave a stub table frame on the old page), so the next time SwTabFrame::MakeAll() is called, we do a Join(), and this leads to a loop. The traditional Writer way here would be to add a loop control, but we can do a little bit better: nobody really asked for row span handling with nested floating tables, so just don't split rows with row span in this case, move the entire row forward instead. This is enough to avoid the layout loop, and a next iteration can still use SwFlowFrame::MoveBwd() / SwFlowFrame::MoveFwd() to split the complex row. The bug is fairly hard to hit, any naive simplification to the original bugdoc leads to a working layout. Carefully keeping the size of the document, it's possible to at least simplify the content of the table cells (while keeping their size unchanged), so we avoid half of the tables and half of the shapes for a faster test case. Change-Id: Ib14154200c45ecb7f59e85f9f4f1fe0124c4256e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158228 Reviewed-by: Miklos Vajna Tested-by: Jenkins (cherry picked from commit 8e03dfd6a4bff4eabf779ace9b758b49cf80f8ba) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158165 Reviewed-by: Xisco Fauli diff --git a/sw/qa/core/layout/data/floattable-nested-rowspan.docx b/sw/qa/core/layout/data/floattable-nested-rowspan.docx new file mode 100644 index ..48cbdbfe59c3 Binary files /dev/null and b/sw/qa/core/layout/data/floattable-nested-rowspan.docx differ diff --git a/sw/qa/core/layout/tabfrm.cxx b/sw/qa/core/layout/tabfrm.cxx index a5e448081b0f..1659cf0df6fd 100644 --- a/sw/qa/core/layout/tabfrm.cxx +++ b/sw/qa/core/layout/tabfrm.cxx @@ -98,6 +98,17 @@ CPPUNIT_TEST_FIXTURE(Test, testSplitFlyInInlineTable) CPPUNIT_ASSERT(!pTab->GetFollow()); } } + +CPPUNIT_TEST_FIXTURE(Test, testSplitFlyNestedRowSpan) +{ +// Given a document with nested floating tables and a row with rowspan cells at page boundary: +// When loading that document: +// Without the accompanying fix in place, this test would have resulted in a layout loop. +createSwDoc("floattable-nested-rowspan.docx"); + +// Then make sure the resulting page count matches Word: +CPPUNIT_ASSERT_EQUAL(6, getPages()); +} } /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/sw/source/core/layout/tabfrm.cxx b/sw/source/core/layout/tabfrm.cxx index 51c29f899b77..079377aedb3c 100644 --- a/sw/source/core/layout/tabfrm.cxx +++ b/sw/source/core/layout/tabfrm.cxx @@ -2644,6 +2644,43 @@ void SwTabFrame::MakeAll(vcl::RenderContext* pRenderContext) // See if this is a split fly that can also grow. auto pUpperFly = static_cast(GetUpper()); bFlySplit = pUpperFly->IsFlySplitAllowed(); + +if (bFlySplit) +{ +// See if this is a nested split fly where the inner table also has +// rowspans. +SwTextFrame* pAnchorCharFrame = pUpperFly->FindAnchorCharFrame(); +if (pAnchorCharFrame && pAnchorCharFrame->IsInFly()) +{ +// Find the row we'll split. +SwTwips nRemaining += aRectFnSet.YDiff(nDeadLine, aRectFnSet.GetTop(getFrameArea())); +nRemaining -= aRectFnSet.GetTopMargin(*this); +const SwFrame* pRow = Lower(); +for (; pRow->GetNext(); pRow = pRow->GetNext()) +{ +if (nRemaining < aRectFnSet.GetHeight(pRow->getFrameArea())) +{ +break; +} + +nRemaining -= aRectFnSet.GetHeight(pRow->getFrameArea()); +
[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - sw/qa sw/source
sw/qa/core/txtnode/txtnode.cxx| 79 +++--- sw/source/core/txtnode/atrref.cxx | 20 ++--- 2 files changed, 55 insertions(+), 44 deletions(-) New commits: commit 01134e5742f362b0dced135fd49c2213001d15eb Author: Matti Tyrväinen AuthorDate: Mon Oct 16 09:23:15 2023 -0700 Commit: Xisco Fauli CommitDate: Fri Oct 20 21:07:52 2023 +0200 Revert change to Reference Mark behavior to avoid regression Hotfix for tdf#157287, unfixes tdf#81720. Setting the DontExpand flag would solve tdf#81720, but causes regression due to other code that depends on the old behavior. This patch restores the old behavior without reverting the UpdateFieldContent refactor included in 146941; testDontExpandRefmark is commented out for now. Change-Id: Ibaeacabec304473db63df9334e2fef46c6d9acc5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158059 Reviewed-by: Matti Tested-by: Jenkins Reviewed-by: Miklos Vajna (cherry picked from commit 58e5e3208a4257a8d9f2e28d8e2d304677aa6980) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158164 Reviewed-by: Xisco Fauli diff --git a/sw/qa/core/txtnode/txtnode.cxx b/sw/qa/core/txtnode/txtnode.cxx index 4a4bf9901a2f..757d6c830247 100644 --- a/sw/qa/core/txtnode/txtnode.cxx +++ b/sw/qa/core/txtnode/txtnode.cxx @@ -247,44 +247,47 @@ CPPUNIT_TEST_FIXTURE(SwCoreTxtnodeTest, testSplitNodeSuperscriptCopy) CPPUNIT_ASSERT(!aSet.HasItem(RES_CHRATR_ESCAPEMENT)); } -CPPUNIT_TEST_FIXTURE(SwCoreTxtnodeTest, testDontExpandRefmark) -{ -// Given a document with a refmark: -createSwDoc(); - -uno::Sequence aArgs = { -comphelper::makePropertyValue("TypeName", uno::Any(OUString("SetRef"))), -comphelper::makePropertyValue( -"Name", uno::Any(OUString("ZOTERO_ITEM CSL_CITATION {} RNDpyJknp173F"))), -comphelper::makePropertyValue("Content", uno::Any(OUString("foo"))), -}; -dispatchCommand(mxComponent, ".uno:InsertField", aArgs); - -SwDoc* pDoc = getSwDoc(); -SwWrtShell* pWrtShell = pDoc->GetDocShell()->GetWrtShell(); -SwPosition& rCursor = *pWrtShell->GetCursor()->GetPoint(); -SwTextNode* pTextNode = rCursor.GetNode().GetTextNode(); -std::vector aAttrs -= pTextNode->GetTextAttrsAt(rCursor.GetContentIndex(), RES_TXTATR_REFMARK); - -auto& rRefmark = const_cast(aAttrs[0]->GetRefMark()); -auto pTextRefMark = const_cast(rRefmark.GetTextRefMark()); - -// When typing after the refmark... -pWrtShell->SttEndDoc(/*bStt=*/true); -pWrtShell->Right(SwCursorSkipMode::Chars, /*bSelect=*/false, 3, /*bBasicCall=*/false); -pWrtShell->Insert(" bar"); - -// and skipping back to insert a comma after the refmark -pWrtShell->Left(SwCursorSkipMode::Chars, /*bSelect=*/false, 4, /*bBasicCall=*/false); -pWrtShell->Insert(","); - -// Without the accompanying fix in place, this test would have failed with: -// - Expected: 3 -// - Actual : 4 -// i.e. the reference mark expanded -CPPUNIT_ASSERT_EQUAL(3, static_cast(*pTextRefMark->End())); -} +/* FIXME: behavior change reverted due to regression; + * see sw/source/core/txtnode/atrref.cxx + *CPPUNIT_TEST_FIXTURE(SwCoreTxtnodeTest, testDontExpandRefmark) + *{ + *// Given a document with a refmark: + *createSwDoc(); + * + *uno::Sequence aArgs = { + *comphelper::makePropertyValue("TypeName", uno::Any(OUString("SetRef"))), + *comphelper::makePropertyValue( + *"Name", uno::Any(OUString("ZOTERO_ITEM CSL_CITATION {} RNDpyJknp173F"))), + *comphelper::makePropertyValue("Content", uno::Any(OUString("foo"))), + *}; + *dispatchCommand(mxComponent, ".uno:InsertField", aArgs); + * + *SwDoc* pDoc = getSwDoc(); + *SwWrtShell* pWrtShell = pDoc->GetDocShell()->GetWrtShell(); + *SwPosition& rCursor = *pWrtShell->GetCursor()->GetPoint(); + *SwTextNode* pTextNode = rCursor.GetNode().GetTextNode(); + *std::vector aAttrs + *= pTextNode->GetTextAttrsAt(rCursor.GetContentIndex(), RES_TXTATR_REFMARK); + * + *auto& rRefmark = const_cast(aAttrs[0]->GetRefMark()); + *auto pTextRefMark = const_cast(rRefmark.GetTextRefMark()); + * + *// When typing after the refmark... + *pWrtShell->SttEndDoc(true); + *pWrtShell->Right(SwCursorSkipMode::Chars, false, 3, false); + *pWrtShell->Insert(" bar"); + * + *// and skipping back to insert a comma after the refmark + *pWrtShell->Left(SwCursorSkipMode::Chars, false, 4, false); + *pWrtShell->Insert(","); + * + *// Without the accompanying fix in place, this test would have failed with: + *// - Expected: 3 + *// - Actual : 4 + *// i.e. the reference mark expanded + *CPPUNIT_ASSERT_EQUAL(3, static_cast(*pTextRefMark->End())); + *} + */ CPPUNIT_TEST_FIXTURE(SwCoreTxtnodeTest, testInsertDropDownContentControlTwice) { diff --git a/sw/source/core/txtnode/atrref.cxx
[Libreoffice-bugs] [Bug 156274] Table Properties | Table | "Text direction" is confusingly named
https://bugs.documentfoundation.org/show_bug.cgi?id=156274 Eyal Rozenberg changed: What|Removed |Added Keywords||needsDevEval --- Comment #6 from Eyal Rozenberg --- Wouldn't this by easy to hack? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103239] [META] Toolbars bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103239 Eyal Rozenberg changed: What|Removed |Added Depends on||157866 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=157866 [Bug 157866] Toolbar dis/appearance must neither shift nor scale the slide display -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157866] Toolbar dis/appearance must neither shift nor scale the slide display
https://bugs.documentfoundation.org/show_bug.cgi?id=157866 Eyal Rozenberg changed: What|Removed |Added Blocks||103239 Keywords||needsUXEval CC||libreoffice-ux-advise@lists ||.freedesktop.org Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103239 [Bug 103239] [META] Toolbars bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 157866] Toolbar dis/appearance must neither shift nor scale the slide display
https://bugs.documentfoundation.org/show_bug.cgi?id=157866 Eyal Rozenberg changed: What|Removed |Added Blocks||103239 Keywords||needsUXEval CC||libreoffice-ux-advise@lists ||.freedesktop.org Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103239 [Bug 103239] [META] Toolbars bugs and enhancements -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 157866] New: Toolbar dis/appearance must neither shift nor scale the slide display
https://bugs.documentfoundation.org/show_bug.cgi?id=157866 Bug ID: 157866 Summary: Toolbar dis/appearance must neither shift nor scale the slide display Product: LibreOffice Version: 3.3.0 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: eyalr...@gmx.com When we enter the scope of a table or a shape's textbox, there is usually a shift in the position of the slide, and slide elements, on the screen. This occurs due to the appearance or disappearance of toolbars, e.g. Table or Text Formatting. Regardless of whether the toolbars should or shouldn't appear - their appearance must _not_ move anything on the screen (and not rescale the slide). Instead, they may occlude the top or bottom part of what's currently visible - with no movement. The movement is jarring and confusing. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 107237] [META] Notebookbar Tabbed
https://bugs.documentfoundation.org/show_bug.cgi?id=107237 Bug 107237 depends on bug 157026, which changed state. Bug 157026 Summary: Align commands should appear in the Table tab of the Notebookbar when a table is selected https://bugs.documentfoundation.org/show_bug.cgi?id=157026 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 100155] [META] Improve object selection and alignment
https://bugs.documentfoundation.org/show_bug.cgi?id=100155 Bug 100155 depends on bug 157026, which changed state. Bug 157026 Summary: Align commands should appear in the Table tab of the Notebookbar when a table is selected https://bugs.documentfoundation.org/show_bug.cgi?id=157026 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157026] Align commands should appear in the Table tab of the Notebookbar when a table is selected
https://bugs.documentfoundation.org/show_bug.cgi?id=157026 Justin L changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED CC||jl...@mail.com Assignee|libreoffice-b...@lists.free |jl...@mail.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: officecfg/registry sd/uiconfig sd/UIConfig_sdraw.mk sd/UIConfig_simpress.mk
officecfg/registry/data/org/openoffice/Office/UI/Controller.xcu | 14 +++ sd/UIConfig_sdraw.mk|1 sd/UIConfig_simpress.mk |1 sd/uiconfig/sdraw/menubar/menubar.xml | 12 -- sd/uiconfig/sdraw/popupmenu/3dobject.xml| 12 -- sd/uiconfig/sdraw/popupmenu/3dscene.xml | 12 -- sd/uiconfig/sdraw/popupmenu/3dscene2.xml| 12 -- sd/uiconfig/sdraw/popupmenu/connector.xml | 12 -- sd/uiconfig/sdraw/popupmenu/curve.xml | 12 -- sd/uiconfig/sdraw/popupmenu/draw.xml| 12 -- sd/uiconfig/sdraw/popupmenu/form.xml| 12 -- sd/uiconfig/sdraw/popupmenu/graphic.xml | 12 -- sd/uiconfig/sdraw/popupmenu/group.xml | 12 -- sd/uiconfig/sdraw/popupmenu/line.xml| 12 -- sd/uiconfig/sdraw/popupmenu/measure.xml | 12 -- sd/uiconfig/sdraw/popupmenu/media.xml | 12 -- sd/uiconfig/sdraw/popupmenu/multiselect.xml | 12 -- sd/uiconfig/sdraw/popupmenu/objectalign.xml | 18 ++ sd/uiconfig/sdraw/popupmenu/oleobject.xml | 12 -- sd/uiconfig/sdraw/popupmenu/table.xml | 12 -- sd/uiconfig/sdraw/popupmenu/textbox.xml | 12 -- sd/uiconfig/sdraw/ui/notebookbar.ui |7 +++ sd/uiconfig/sdraw/ui/notebookbar_compact.ui |7 +++ sd/uiconfig/sdraw/ui/notebookbar_groupedbar_compact.ui | 13 +++ sd/uiconfig/simpress/menubar/menubar.xml| 12 -- sd/uiconfig/simpress/popupmenu/3dobject.xml | 12 -- sd/uiconfig/simpress/popupmenu/3dscene.xml | 12 -- sd/uiconfig/simpress/popupmenu/3dscene2.xml | 12 -- sd/uiconfig/simpress/popupmenu/connector.xml| 12 -- sd/uiconfig/simpress/popupmenu/curve.xml| 12 -- sd/uiconfig/simpress/popupmenu/draw.xml | 12 -- sd/uiconfig/simpress/popupmenu/form.xml | 12 -- sd/uiconfig/simpress/popupmenu/graphic.xml | 12 -- sd/uiconfig/simpress/popupmenu/group.xml| 12 -- sd/uiconfig/simpress/popupmenu/line.xml | 12 -- sd/uiconfig/simpress/popupmenu/measure.xml | 12 -- sd/uiconfig/simpress/popupmenu/media.xml| 12 -- sd/uiconfig/simpress/popupmenu/multiselect.xml | 12 -- sd/uiconfig/simpress/popupmenu/objectalign.xml | 18 ++ sd/uiconfig/simpress/popupmenu/oleobject.xml| 12 -- sd/uiconfig/simpress/popupmenu/table.xml| 12 -- sd/uiconfig/simpress/popupmenu/textbox.xml | 12 -- sd/uiconfig/simpress/ui/notebookbar.ui |7 +++ sd/uiconfig/simpress/ui/notebookbar_compact.ui |7 +++ sd/uiconfig/simpress/ui/notebookbar_groupedbar_compact.ui | 13 +++ sd/uiconfig/simpress/ui/notebookbar_groupedbar_full.ui | 13 +++ 46 files changed, 153 insertions(+), 374 deletions(-) New commits: commit 4e871d99ccace244de42c0d5c4bd11611af6ccb2 Author: Justin Luth AuthorDate: Tue Oct 17 08:18:17 2023 -0400 Commit: Justin Luth CommitDate: Fri Oct 20 20:25:58 2023 +0200 tdf#157026 sd notebookbar: add ObjectAlign to MenuTable as popupmenu The vast majority of this is just eliminating copy/paste, since I have now created a popupmenu.xml list for the popup menu. The "fix" is adding this to the Table menus. .uno:ObjectAlign is basically just a "label". Now it is a label for two different "views": * a toolbar widget dropdown * a menu subcategory Perhaps it is confusing to have one UNO entry serve these two similar purposes? I suppose someone might also complain that a simple isn't clear that this is a submenu. I considered making mine a new ObjectAlignMenu, but the annoyance of having to create a duplicate string translation in officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu made me just reuse the existing label. Change-Id: I17e037e0c9c5d1f57ac9f174a76cd041983bcea4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157894 Tested-by: Jenkins Reviewed-by: Justin Luth diff --git
[Libreoffice-bugs] [Bug 157026] Align commands should appear in the Table tab of the Notebookbar when a table is selected
https://bugs.documentfoundation.org/show_bug.cgi?id=157026 Commit Notification changed: What|Removed |Added Whiteboard||target:24.2.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157864] Introduce presentation and/or master color scheme support
https://bugs.documentfoundation.org/show_bug.cgi?id=157864 --- Comment #5 from Eyal Rozenberg --- (In reply to Mike Kaganski from comment #4) > For the results up to now: in a master build, see Format->Theme, which is > present in all modules, but in Impress, it's only active in Master views. So, it seems there's only been very preliminary work, since no theme corresponds to what we see on the Master slide, nor does selecting a theme affect the Master slide or the document. But - it's nice to know someone has been working on this. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 157864] Introduce presentation and/or master color scheme support
https://bugs.documentfoundation.org/show_bug.cgi?id=157864 --- Comment #5 from Eyal Rozenberg --- (In reply to Mike Kaganski from comment #4) > For the results up to now: in a master build, see Format->Theme, which is > present in all modules, but in Impress, it's only active in Master views. So, it seems there's only been very preliminary work, since no theme corresponds to what we see on the Master slide, nor does selecting a theme affect the Master slide or the document. But - it's nice to know someone has been working on this. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-commits] core.git: sd/qa
sd/qa/unit/data/pptx/smartart-autofit-sync.pptx |binary 1 file changed New commits: commit e64f3ab974e2f8c528fef8d75162b82ec0453293 Author: Miklos Vajna AuthorDate: Fri Oct 20 15:47:45 2023 +0200 Commit: Miklos Vajna CommitDate: Fri Oct 20 20:20:59 2023 +0200 CppunitTest_sd_import_tests-smartart: make testAutofitSync more robust - replace 'Calibri Light' with 'Noto Sans' (we bundle the later) - replace 'Calibri' with 'Arial' With this: diff --git a/sd/CppunitTest_sd_import_tests-smartart.mk b/sd/CppunitTest_sd_import_tests-smartart.mk index 9b7362b08152..72e0dead7731 100644 --- a/sd/CppunitTest_sd_import_tests-smartart.mk +++ b/sd/CppunitTest_sd_import_tests-smartart.mk @@ -11,4 +11,6 @@ $(eval $(call sd_import_test,-smartart)) +$(eval $(call gb_CppunitTest_set_non_application_font_use,sd_import_tests-smartart,abort)) + # vim: set noet sw=4 ts=4: doesn't abort anymore. In fact the second replacement is just for completeness, the first was enough alredy. Change-Id: I455b473233e351b7a2ee6a1b1b66049e63a8a6ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158263 Tested-by: Jenkins Reviewed-by: Miklos Vajna diff --git a/sd/qa/unit/data/pptx/smartart-autofit-sync.pptx b/sd/qa/unit/data/pptx/smartart-autofit-sync.pptx index 9a6ce0f494c5..e27dbbfd3de3 100644 Binary files a/sd/qa/unit/data/pptx/smartart-autofit-sync.pptx and b/sd/qa/unit/data/pptx/smartart-autofit-sync.pptx differ
[Libreoffice-bugs] [Bug 156274] Table Properties | Table | "Text direction" is confusingly named
https://bugs.documentfoundation.org/show_bug.cgi?id=156274 خالد حسني changed: What|Removed |Added CC||eyalr...@gmx.com --- Comment #5 from خالد حسني --- *** Bug 157819 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157819] Table direction labeled "text direction", even though it's not just that
https://bugs.documentfoundation.org/show_bug.cgi?id=157819 خالد حسني changed: What|Removed |Added Resolution|--- |DUPLICATE Status|UNCONFIRMED |RESOLVED --- Comment #1 from خالد حسني --- *** This bug has been marked as a duplicate of bug 156274 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157844] [META] Automatic color bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=157844 Bug 157844 depends on bug 141134, which changed state. Bug 141134 Summary: The overline automatic color is exported to PDF differently than in original document https://bugs.documentfoundation.org/show_bug.cgi?id=141134 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103378] [META] PDF export bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103378 Bug 103378 depends on bug 141134, which changed state. Bug 141134 Summary: The overline automatic color is exported to PDF differently than in original document https://bugs.documentfoundation.org/show_bug.cgi?id=141134 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141134] The overline automatic color is exported to PDF differently than in original document
https://bugs.documentfoundation.org/show_bug.cgi?id=141134 خالد حسني changed: What|Removed |Added CC||kha...@libreoffice.org Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #7 from خالد حسني --- *** This bug has been marked as a duplicate of bug 48707 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157864] Introduce presentation and/or master color scheme support
https://bugs.documentfoundation.org/show_bug.cgi?id=157864 --- Comment #4 from Mike Kaganski --- For the results up to now: in a master build, see Format->Theme, which is present in all modules, but in Impress, it's only active in Master views. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 157864] Introduce presentation and/or master color scheme support
https://bugs.documentfoundation.org/show_bug.cgi?id=157864 --- Comment #4 from Mike Kaganski --- For the results up to now: in a master build, see Format->Theme, which is present in all modules, but in Impress, it's only active in Master views. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 157864] Introduce presentation and/or master color scheme support
https://bugs.documentfoundation.org/show_bug.cgi?id=157864 --- Comment #3 from Mike Kaganski --- https://gerrit.libreoffice.org/q/owner:quikee%2540gmail.com+after:2021-01-01+branch:master+status:merged+theme -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 157864] Introduce presentation and/or master color scheme support
https://bugs.documentfoundation.org/show_bug.cgi?id=157864 --- Comment #3 from Mike Kaganski --- https://gerrit.libreoffice.org/q/owner:quikee%2540gmail.com+after:2021-01-01+branch:master+status:merged+theme -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-commits] core.git: toolkit/source
toolkit/source/controls/controlmodelcontainerbase.cxx |2 +- toolkit/source/controls/stdtabcontroller.cxx |2 +- toolkit/source/controls/tabpagemodel.cxx |2 +- 3 files changed, 3 insertions(+), 3 deletions(-) New commits: commit 711e01c7878ef0c319fd40c95484cb9be5105e00 Author: Stephan Bergmann AuthorDate: Thu Oct 19 10:30:35 2023 +0200 Commit: Stephan Bergmann CommitDate: Fri Oct 20 19:54:29 2023 +0200 Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: toolkit Change-Id: I67ba7b0f4d99f080b343a9b26a242cf4008b820c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158244 Tested-by: Jenkins Reviewed-by: Stephan Bergmann diff --git a/toolkit/source/controls/controlmodelcontainerbase.cxx b/toolkit/source/controls/controlmodelcontainerbase.cxx index c6292cd1e21b..8c9bba0890de 100644 --- a/toolkit/source/controls/controlmodelcontainerbase.cxx +++ b/toolkit/source/controls/controlmodelcontainerbase.cxx @@ -65,7 +65,7 @@ using namespace ::com::sun::star::beans; using namespace ::com::sun::star::util; using namespace toolkit; -constexpr OUStringLiteral PROPERTY_RESOURCERESOLVER = u"ResourceResolver"; +constexpr OUString PROPERTY_RESOURCERESOLVER = u"ResourceResolver"_ustr; namespace diff --git a/toolkit/source/controls/stdtabcontroller.cxx b/toolkit/source/controls/stdtabcontroller.cxx index 554fcfb3c76b..bac4aea58547 100644 --- a/toolkit/source/controls/stdtabcontroller.cxx +++ b/toolkit/source/controls/stdtabcontroller.cxx @@ -111,7 +111,7 @@ bool StdTabController::ImplCreateComponentSequence( if ( pTabs ) { // opt: Constant String for TabStop name -static constexpr OUStringLiteral aTabStopName = u"Tabstop"; +static constexpr OUString aTabStopName = u"Tabstop"_ustr; Reference< XPropertySet > xPSet( xCtrl->getModel(), UNO_QUERY ); Reference< XPropertySetInfo > xInfo = xPSet->getPropertySetInfo(); diff --git a/toolkit/source/controls/tabpagemodel.cxx b/toolkit/source/controls/tabpagemodel.cxx index 53a2c7335b27..7185f8241947 100644 --- a/toolkit/source/controls/tabpagemodel.cxx +++ b/toolkit/source/controls/tabpagemodel.cxx @@ -142,7 +142,7 @@ void SAL_CALL UnoControlTabPageModel::initialize (const Sequence& rArgument Reference xDialogProp(xDialogModel,UNO_QUERY); if ( xDialogProp.is() ) { -static constexpr OUStringLiteral s_sResourceResolver = u"ResourceResolver"; +static constexpr OUString s_sResourceResolver = u"ResourceResolver"_ustr; setPropertyValue(s_sResourceResolver,xDialogProp->getPropertyValue(s_sResourceResolver)); setPropertyValue(GetPropertyName(BASEPROPERTY_TITLE),xDialogProp->getPropertyValue(GetPropertyName(BASEPROPERTY_TITLE))); setPropertyValue(GetPropertyName(BASEPROPERTY_HELPTEXT),xDialogProp->getPropertyValue(GetPropertyName(BASEPROPERTY_HELPTEXT)));
[Libreoffice-bugs] [Bug 157865] Brochure function in Print to File do not respect formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=157865 --- Comment #3 from Romain --- Created attachment 190358 --> https://bugs.documentfoundation.org/attachment.cgi?id=190358=edit Draw SafeMode -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157865] Brochure function in Print to File do not respect formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=157865 --- Comment #2 from Romain --- Created attachment 190357 --> https://bugs.documentfoundation.org/attachment.cgi?id=190357=edit Draw -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157865] Brochure function in Print to File do not respect formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=157865 --- Comment #1 from Romain --- Created attachment 190356 --> https://bugs.documentfoundation.org/attachment.cgi?id=190356=edit Pandoc -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157865] New: Brochure function in Print to File do not respect formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=157865 Bug ID: 157865 Summary: Brochure function in Print to File do not respect formatting Product: LibreOffice Version: 7.3.7.2 release Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Draw Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: romain_underlin...@hotmail.com Description: After creating a markdown file and exporting to pdf with pandoc "pandoc -V geometry:"paperwidth=148mm, paperheight=210mm, top=10mm, right=20mm, bottom=15mm, left=20mm" -V fontsize=6pt Example.md -o Example_A5.pdf" I open the file with LibreOffice Draw and export it to pdf using the Brochure function. The top margin is respected but the lower margin is increased. Steps to Reproduce: 1. Markdown file 2. pandoc -V geometry:"paperwidth=148mm, paperheight=210mm, top=10mm, right=20mm 3. Open with Draw, File (A4, Short Edge), Print..., Print to file, Brochure Actual Results: Top margin of new pdf respected but bottom margin increased Expected Results: Same top and bottom margin Reproducible: Always User Profile Reset: Yes Additional Info: [Information automatically included from LibreOffice] Locale: en-US Module: DrawingDocument [Information guessed from browser] OS: Linux (All) OS is 64bit: yes Version: 7.3.7.2 / LibreOffice Community Build ID: 30(Build:2) CPU threads: 12; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Ubuntu package version: 1:7.3.7-0ubuntu0.22.04.3 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157818] Background color not visible in sidebar-styles-preview
https://bugs.documentfoundation.org/show_bug.cgi?id=157818 --- Comment #10 from fed...@gmail.com --- (ps: yesterday I uploaded some example screenshots) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157615] Marking parts of text with the mouse does not work any longer reliably
https://bugs.documentfoundation.org/show_bug.cgi?id=157615 Adalbert Hanßen changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |FIXED --- Comment #6 from Adalbert Hanßen --- Today I tried the issue again and it did not appear again (LO Version versions mentioned above). The Linux operating system has undergone the usual updates in the meantime. I also checked the issue with the Windows 10 operating system and the version mentioned above for that. Of course Windows 10 also undergoes regular updates. The bug did not show up again there either. I also tried it with the mouse connected to all available USB ports on the computer and on the docking station. I also checked it with the other mouse (same model as mentioned before). The issue did not show up again. I mark this issue therefore as RESOLVED. Is FIXED the right other attribute for this issue? If it shows up again (hopefully never!), I'll reopen it. -- You are receiving this mail because: You are the assignee for the bug.