[Libreoffice] Building on gentoo ...

[Anthony Youngman]

 Just tried to build libreoffice on gentoo. All the pre-requisites
should be there, given that I've done an emerge openoffice. But it
falls over ...

checking for Qt headers... no
configure: error: Qt headers not found.  Please specify the root of
your Qt installation by exporting QTDIR before running configure.
make: *** [stamp/build] Error 1

Not quite sure what to do about that ... especially as I'm just
following the instuctions on the wiki which don't even mention running
configure.

Oh - and the instructions also say --with-num-cpus=2. Except I've got
3, and gentoo instructions say you should normally use -j=cpus+1. So
should I really say cpus=4?

Cheers,
Wol
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] Rewrite as a static table of keywords and loop over these ke...

[Anthony Youngman]

Hi Lionel,

Thanks very much. Sorry for not doing it myself, my wife's been using
the computer too much :-) And I've been working this morning, I was
hoping to look at it this afternoon - Tor kindly told me how to squash
patches, but I hadn't had a chance to do it.

Hopefully all new work is going to be on a dev system that my wife won't
use :-)

Cheers,
Wol

On 29/04/13 09:22, Lionel Elie Mamane wrote:
 Hi Anthony,
 
 Thank you for submitting your change through gerrit. I've pushed it to
 master. On gerrit, Tor asked you to please combine all three changes
 into one; the main reason is that these changes are not meaningful
 changes by themselves, but the latter two are really fixes to the
 first one. It is thus cleaner to squash the changes into one.
 
 I did the squash of the three changes into one. Here's how to do it:
 
 1) I cherry-picked your changes (since you already have these changes
in your local tree, you wouldn't have needed to do that):
 
 user@host:~/src/libreoffice/workdirs/libreoffice-4.1$ git fetch 
 git://gerrit.libreoffice.org/core refs/changes/14/3614/1  git cherry-pick 
 FETCH_HEAD
 remote: Counting objects: 13, done.
 remote: Compressing objects: 100% (7/7), done.
 remote: Total 7 (delta 6), reused 1 (delta 0)
 Unpacking objects: 100% (7/7), done.
 From git://gerrit.libreoffice.org/core
  * branchrefs/changes/14/3614/1 - FETCH_HEAD
 [master 112e852] Rewrite as a static table of keywords and loop over these 
 keywords
  Author: Wol anth...@youngman.org.uk
  1 file changed, 25 insertions(+), 33 deletions(-)
 user@host:~/src/libreoffice/workdirs/libreoffice-4.1$ git fetch 
 git://gerrit.libreoffice.org/core refs/changes/15/3615/1  git cherry-pick 
 FETCH_HEAD
 remote: Counting objects: 20, done.
 remote: Compressing objects: 100% (12/12), done.
 remote: Total 14 (delta 12), reused 4 (delta 2)
 Unpacking objects: 100% (14/14), done.
 From git://gerrit.libreoffice.org/core
  * branchrefs/changes/15/3615/1 - FETCH_HEAD
 [master b997307] Rewrite as a static table of keywords and loop over them
  Author: Wol anth...@youngman.org.uk
  1 file changed, 3 insertions(+), 2 deletions(-)
 user@host:~/src/libreoffice/workdirs/libreoffice-4.1$ git fetch 
 git://gerrit.libreoffice.org/core refs/changes/16/3616/1  git cherry-pick 
 FETCH_HEAD
 remote: Counting objects: 27, done.
 remote: Compressing objects: 100% (8/8), done.
 remote: Total 21 (delta 17), reused 17 (delta 13)
 Unpacking objects: 100% (21/21), done.
 From git://gerrit.libreoffice.org/core
  * branchrefs/changes/16/3616/1 - FETCH_HEAD
 [master fa8cf51] Change j type to size_t
  Author: Wol anth...@youngman.org.uk
  1 file changed, 1 insertion(+), 3 deletions(-)
 
 
 2) Squash them into one:
 
 user@host:~/src/libreoffice/workdirs/libreoffice-4.1$ git rebase --interactive
 # I then get in my editor:
 #  pick 112e852 Rewrite as a static table of keywords and loop over these 
 keywords
 #  pick b997307 Rewrite as a static table of keywords and loop over them
 #  pick fa8cf51 Change j type to size_t
 # I change it to:
 #  pick 112e852 Rewrite as a static table of keywords and loop over these 
 keywords
 #  squash b997307 Rewrite as a static table of keywords and loop over them
 #  squash fa8cf51 Change j type to size_t
 # and then close my editor
 #  git proceeds and opens my editor again, with the concatenation of
 #  all three commit messages. I edit it to make one good commit
 #  message that covers everything and contains no temporary notes like
 #  does not compile yet:
 # I kept the Change-Id of the first change.
 # close my editor again
 # And I'm done!
 
 3) test
 
 4) push / submit to gerrit
 
 5) congratulate Wols for successful patch! ;-)
 
 Thanks for the patch!
 
 On Fri, Apr 26, 2013 at 08:20:49AM +, Anthony Youngman (via Code Review) 
 wrote:
 
 I have submitted a patch for review:
 
 https://gerrit.libreoffice.org/3614
 
 Rewrite as a static table of keywords and loop over these keywords
 
 It currently contains a compile error - the call the 
 matchIgnoreAsciiCaseAsciiL
 fails.
 
 On Fri, Apr 26, 2013 at 08:20:52AM +, Anthony Youngman (via Code Review) 
 wrote:
 
 I have submitted a patch for review:
 
 https://gerrit.libreoffice.org/3615
 
 Rewrite as a static table of keywords and loop over them
 On Fri, Apr 26, 2013 at 08:20:54AM +, Anthony Youngman (via Code Review) 
 wrote:
 
 I have submitted a patch for review:
 
 https://gerrit.libreoffice.org/3616
 
 Change j type to size_t
 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: I know I shouldn't but I'll do it anyway....

[Anthony Youngman]

On 15/02/2013 18:14, Noel Grandin wrote:
I have no idea why start screens always use so little of the available 
display.

Because an app pinching the entire damn screen isn't always welcome?!?!

I *hate* apps running full-screen - what's the joke? a gui is a means 
of happening several xterms visible at once ...


But seriously, the available display is NOT the entire screen. It 
should be whatever the user chooses to give you, and that's not always 
as much as you'd like. Yes I know most lusers seem to like full-screen 
apps. That's no reason to upset the power users by forcing them to work 
your way. That's why I hate Word ...


Cheers,
Wol
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Save as pdf - should we embed the document?

[Anthony Youngman]

I know developers love to add bells and whistles, and aiui when you 
"save as pdf" from LO it can now embed the original document in the pdf 
to make it easy to get the document back into editable form, but the 
attached email below makes me think "is this wise?".


As I've learnt from Groklaw, the amount of information leaked in 
documents because people did not know how to properly redact documents, 
makes me think that embedding an editable version in a pdf is not 
(certainly as a default) a wise thing to do.


I will add, I've never actually used the feature so I don't know what 
the defaults are, but if LO is like most other projects, it just hasn't 
crossed anybody's mind to think about it ... (having just looked at 
"export with pdf" I can't see any mention of including the document, so 
either LO doesn't which is fine, or it does and doesn't give the user 
the option, which imho is extremely dangerous ...)


Actually, I don't know how we'd do it, but this implies there could be a 
killer feature in here - a setting that warns about hidden data and 
possible security leaks. Probably not best enabled by default, but a nag 
feature that could be switched on to warn about hidden fields etc.


Cheers,
Wol

Date: Wed, 1 Jun 2016 12:09:59 +0100
From: "Patrick O'Beirne"
Subject: An expensive Pivot Table

Recently discussed on the Eusprig (European Spreadsheet Risk Interest Group)
mail list:

A hospital trust in Blackpool (pop. 145,000) in the UK was fined 185,000 GBP
for leaking sensitive information via an Excel Pivotable.

https://ico.org.uk/media/action-weve-taken/mpns/1624118/blackpool-nhs-trust-monetary-penalty-notice.pdf

It is a problem of the sorcerer's apprentice - knowing enough to be
dangerous.  To paraphrase Barry Boehm, "[EUC gives] many who have little
training or expertise in how to avoid or detect high-risk defects tremendous
power to create high-risk defects. "

The key point is "The Trust knew or ought to have envisaged those risks and
it did not take reasonable steps to prevent the contravention."  So: if they
OUGHT to have known, by what means were they expected to envisage those
risks? What guidance is available that describes that issue? Is it part of
any accredited training materials? The answer I think is here:

"It is worth noting that the Commissioner' s office issued two monetary
penalty notices on 30 July 2012 (Torbay NHS Trust) and 20 August 2013
(Islington Council) which raised awareness about the issue of data that
could be hidden in pivot tables. The Commissioner's office also
published a blog on 28 June 2013 entitled The Risk of Revealing Too Much.

https://iconewsblog.wordpress.com/2013/06/28/ico-blog-the-risk-of-revealing-too-much/
This shows the pivot table feature in question.
Just to explain, if the pivotcache is present then even if the original data
sheet is deleted, the data can be recreated by a simple double-click on a
pivotable cell.

They reference:
https://iconewsblog.wordpress.com/2015/11/13/the-dangers-of-hidden-data/
https://www.mysociety.org/2013/06/13/whatdotheyknow-team-urge-caution-when-using-excel-to-depersonalise-data/

Read the "Five Key Messages" at the end.

This is of course just one such example. The hidden rows in the Barclay's
bid for Lehman assets, or the summary chart in a paper on hospital
treatments which had the entire Excel spreadsheet embedded in it, are more.

Patrick O'Beirne, Systems Modelinghttp://www.sysmod.com
http://ie.linkedin.com/in/patrickobeirne


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Order of menu items

[Anthony Youngman]

On 03/07/16 19:12, Jan Rheinländer wrote:

Hi Oliver,

thanks that works!

Very interesting that LO on Windows can't sort labels if they start with
a digit...


Windows actually (by default) splits alphameric keys into a numeric 
part, and an alpha part. VERY confusing if you're not expecting it. My 
camera lets me define the second half of the folder the photos go in, so 
I thought "let's do 1_JAN, 2_FEB, ... A_OCT, ...".


So I ended up with names like 1059_SEP, 106A_OCT, etc. Guess what! 106 
sorts before 1059!


That's okay if you're expecting it, or everything starts with a letter, 
but I gather they made that change about XP time, and it still bites 
people who expect an alphameric key to sort alphabetically ...


Cheers,
Wol



Am 30.06.2016 um 20:44 schrieb Oliver Brinzing:

Hi Jan,


In Linux LO respects this order and arranges the menu items in order.
In Windows, it doesn't.

i use "m001", "m002", etc. to sort my menu entries.

Regards
Oliver





___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Temporary files written to predetermined location during build

[Anthony Youngman]

On 11/09/17 10:07, Rene Engelhard wrote:

that definitely looks like a bug, it should create that inside some
random subdirectory..



Yes, especially as/tmp/ is (also) a security-related bug
(possible symlink attack)..

See alsohttp://bugs.debian.org/875415  which I just received...


My experience of /tmp is that most things seem to create and write to 
/tmp/username or similar - it's odd to write straight into /tmp.


And that I guess is what's behind the original bug reported - the first 
user obviously created a directory with permissions set for him, then 
the second user came along, tried to use the same directory, and without 
write permission the second build fell over. (Obviously, whether that 
happens depends on how fast the reaper reaps the contents of /tmp.)


Cheers,
Wol
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Reveal code, old macros convert them to LO

[Anthony Youngman]

On 06/07/2019 22:31, Ralf Quint wrote:

On 7/6/2019 1:00 PM, Tor Lillqvist wrote:

You seem to hate a lot. Try to get over it.

+1



I'm a bit of a "grumpy old man", sorry ... :-)

Cheers,

Wol
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Rewrite as a static table of keywords and loop over these ke...

[Anthony Youngman (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3614

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/14/3614/1

Rewrite as a static table of keywords and loop over these keywords

This patch creates a static list of keywords which can easily be added
to.
It currently contains a compile error - the call the matchIgnoreAsciiCaseAsciiL
fails.
It also needs testing as I don't have PostgreSQL on this machine.

Change-Id: Ib581b3e834a57e0dfa9d139bcb4ae7a0a52a5472
---
M connectivity/source/drivers/postgresql/pq_connection.cxx
1 file changed, 25 insertions(+), 33 deletions(-)



diff --git a/connectivity/source/drivers/postgresql/pq_connection.cxx 
b/connectivity/source/drivers/postgresql/pq_connection.cxx
index 4bc15e4..b17ad9f 100644
--- a/connectivity/source/drivers/postgresql/pq_connection.cxx
+++ b/connectivity/source/drivers/postgresql/pq_connection.cxx
@@ -482,44 +482,31 @@
 // I.e. they are prefiltered to have only relevant ones?
 // Else, at least support all keywords from
 // http://www.postgresql.org/docs/9.0/interactive/libpq-connect.html
+
+static const char* keyword_list[] = {
+password,
+user,
+port,
+dbname,
+connect_timeout,
+options,
+requiressl
+};
+
 for( int i = 0; i  args.getLength() ; ++i )
 {
-bool append = true;
-// TODO: rewrite this as a static table of keywords, and a loop over 
these keywords.
-if( args[i].Name.matchIgnoreAsciiCaseAsciiL( 
RTL_CONSTASCII_STRINGPARAM( password ) ) )
+bool append = false;
+for( int j = 0; j  (int) ( sizeof( keyword_list ) / sizeof( char * 
)); j++)
 {
-keywords.push_back( password, SAL_NO_ACQUIRE );
-}
-else if( args[i].Name.matchIgnoreAsciiCaseAsciiL( 
RTL_CONSTASCII_STRINGPARAM( user ) ) )
-{
-keywords.push_back( user, SAL_NO_ACQUIRE );
-}
-else if( args[i].Name.matchIgnoreAsciiCaseAsciiL( 
RTL_CONSTASCII_STRINGPARAM( port ) ) )
-{
-keywords.push_back( port, SAL_NO_ACQUIRE );
-}
-else if( args[i].Name.matchIgnoreAsciiCaseAsciiL( 
RTL_CONSTASCII_STRINGPARAM( dbname ) ) )
-{
-keywords.push_back( dbname, SAL_NO_ACQUIRE );
-}
-else if( args[i].Name.matchIgnoreAsciiCaseAsciiL( 
RTL_CONSTASCII_STRINGPARAM( connect_timeout ) ) )
-{
-keywords.push_back( connect_timeout, SAL_NO_ACQUIRE );
-}
-else if( args[i].Name.matchIgnoreAsciiCaseAsciiL( 
RTL_CONSTASCII_STRINGPARAM( options ) ) )
-{
-keywords.push_back( options, SAL_NO_ACQUIRE );
-}
-else if( args[i].Name.matchIgnoreAsciiCaseAsciiL( 
RTL_CONSTASCII_STRINGPARAM( requiressl ) ) )
-{
-keywords.push_back( requiressl, SAL_NO_ACQUIRE );
-}
-else
-{
+if( args[i].Name.matchIgnoreAsciiCaseAsciiL( keyword_list[j] ))
+{
+keywords.push_back( keyword_list[j], SAL_NO_ACQUIRE );
+append = true;
+break;
+}
 append = false;
-// ignore for now
-OSL_TRACE(sdbc-postgresql: unknown argument '%s', 
OUStringToOString( args[i].Name, RTL_TEXTENCODING_UTF8 ).getStr() );
 }
+
 if( append )
 {
 OUString value;
@@ -527,6 +514,11 @@
 char *v = strdup(OUStringToOString(value, enc).getStr());
 values.push_back ( v );
 }
+else
+{
+// ignore for now
+OSL_TRACE(sdbc-postgresql: unknown argument '%s', 
OUStringToOString( args[i].Name, RTL_TEXTENCODING_UTF8 ).getStr() );
+}
 }
 }
 

-- 
To view, visit https://gerrit.libreoffice.org/3614
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib581b3e834a57e0dfa9d139bcb4ae7a0a52a5472
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Anthony Youngman anth...@youngman.org.uk

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Rewrite as a static table of keywords and loop over them

[Anthony Youngman (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3615

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/15/3615/1

Rewrite as a static table of keywords and loop over them

This patch implements a TODO so that new keywords can simply be added to
a static array rather than new else if blocks being added one per
keyword

Change-Id: I8aa4ff0f39166014c299783203eb646817b1399c
---
M connectivity/source/drivers/postgresql/pq_connection.cxx
1 file changed, 3 insertions(+), 2 deletions(-)



diff --git a/connectivity/source/drivers/postgresql/pq_connection.cxx 
b/connectivity/source/drivers/postgresql/pq_connection.cxx
index b17ad9f..f0d9e03 100644
--- a/connectivity/source/drivers/postgresql/pq_connection.cxx
+++ b/connectivity/source/drivers/postgresql/pq_connection.cxx
@@ -496,9 +496,10 @@
 for( int i = 0; i  args.getLength() ; ++i )
 {
 bool append = false;
-for( int j = 0; j  (int) ( sizeof( keyword_list ) / sizeof( char * 
)); j++)
+//for( int j = 0; j  (int) ( sizeof( keyword_list ) / sizeof( char * 
)); j++)
+for( int j = 0; j  (int) SAL_N_ELEMENTS( keyword_list ); j++)
 {
-if( args[i].Name.matchIgnoreAsciiCaseAsciiL( keyword_list[j] ))
+if( args[i].Name.equalsIgnoreAsciiCaseAscii( keyword_list[j] ))
 {
 keywords.push_back( keyword_list[j], SAL_NO_ACQUIRE );
 append = true;

-- 
To view, visit https://gerrit.libreoffice.org/3615
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8aa4ff0f39166014c299783203eb646817b1399c
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Anthony Youngman anth...@youngman.org.uk

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Change j type to size_t

[Anthony Youngman (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3616

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/16/3616/1

Change j type to size_t

Change-Id: If04e33228162baab392906903a574f1a6e7a6110
---
M connectivity/source/drivers/postgresql/pq_connection.cxx
1 file changed, 1 insertion(+), 3 deletions(-)



diff --git a/connectivity/source/drivers/postgresql/pq_connection.cxx 
b/connectivity/source/drivers/postgresql/pq_connection.cxx
index f0d9e03..4f830a1 100644
--- a/connectivity/source/drivers/postgresql/pq_connection.cxx
+++ b/connectivity/source/drivers/postgresql/pq_connection.cxx
@@ -496,8 +496,7 @@
 for( int i = 0; i  args.getLength() ; ++i )
 {
 bool append = false;
-//for( int j = 0; j  (int) ( sizeof( keyword_list ) / sizeof( char * 
)); j++)
-for( int j = 0; j  (int) SAL_N_ELEMENTS( keyword_list ); j++)
+for( size_t j = 0; j  SAL_N_ELEMENTS( keyword_list ); j++)
 {
 if( args[i].Name.equalsIgnoreAsciiCaseAscii( keyword_list[j] ))
 {
@@ -505,7 +504,6 @@
 append = true;
 break;
 }
-append = false;
 }
 
 if( append )

-- 
To view, visit https://gerrit.libreoffice.org/3616
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If04e33228162baab392906903a574f1a6e7a6110
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Anthony Youngman anth...@youngman.org.uk

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice