[PATCH] fdo#67093 Change traduction of Header in it to avoid conflic...

2013-07-25 Thread Arnaud Versini (via Code Review)
Hi, I would like you to review the following patch: https://gerrit.libreoffice.org/5092 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/translations refs/changes/92/5092/1 fdo#67093 Change traduction of Header in it to avoid conflict with Heading Change-Id:

[PATCH libreoffice-4-1] fdo#67093 Change traduction of Header in it to avoid conflic...

2013-07-25 Thread Arnaud Versini (via Code Review)
Hi, I would like you to review the following patch: https://gerrit.libreoffice.org/5093 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/translations refs/changes/93/5093/1 fdo#67093 Change traduction of Header in it to avoid conflict with Heading Change-Id:

[PATCH] Change traduction of Title in french to avoid conflict with ...

2013-07-20 Thread Arnaud Versini (via Code Review)
Hi, I would like you to review the following patch: https://gerrit.libreoffice.org/4994 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/translations refs/changes/94/4994/1 Change traduction of Title in french to avoid conflict with Heading Change-Id:

[PATCH libreoffice-4-1] Change traduction of Title in french to avoid conflict with ...

2013-07-20 Thread Arnaud Versini (via Code Review)
Hi, I would like you to review the following patch: https://gerrit.libreoffice.org/4995 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/translations refs/changes/95/4995/1 Change traduction of Title in french to avoid conflict with Heading Change-Id:

[PATCH libreoffice-4-1-0] Change traduction of Title in french to avoid conflict with ...

2013-07-20 Thread Arnaud Versini (via Code Review)
Hi, I would like you to review the following patch: https://gerrit.libreoffice.org/4996 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/translations refs/changes/96/4996/1 Change traduction of Title in french to avoid conflict with Heading Change-Id:

[PATCH] Multi threaded version of osl_getGlobalTime on Unix

2013-05-19 Thread Arnaud Versini (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3960 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/60/3960/1 Multi threaded version of osl_getGlobalTime on Unix Change-Id: Ibb9d23780600437f607d866ff3d396b96879245d --- M

[PATCH] Use clock_gettime when available on *nix

2013-05-19 Thread Arnaud Versini (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3964 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/64/3964/1 Use clock_gettime when available on *nix Change-Id: I65df2b119dbda274749ab2b4d0825fbdf44eb4e8 --- M

[ABANDONED] Use clock_gettime when available on *nix

2013-05-19 Thread Arnaud Versini (via Code Review)
Arnaud Versini has abandoned this change. Change subject: Use clock_gettime when available on *nix .. Patch Set 2: Abandoned -- To view, visit https://gerrit.libreoffice.org/3964 To unsubscribe, visit

[PATCH] Fix build on fedora and debian by checking _POSIX_C_SOURCE

2013-05-13 Thread Arnaud Versini (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3889 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/89/3889/1 Fix build on fedora and debian by checking _POSIX_C_SOURCE Change-Id: I12809d970d0a2a4ebb946675f904832ff37e029f

[ABANDONED] Fix build on linux by adding -lrt.

2013-05-13 Thread Arnaud Versini (via Code Review)
Arnaud Versini has abandoned this change. Change subject: Fix build on linux by adding -lrt. .. Patch Set 3: Abandoned Already changed in master by

[PATCH] Fixes fdo#64237 by modifying the underlyning string

2013-05-12 Thread Arnaud Versini (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3870 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/70/3870/1 Fixes fdo#64237 by modifying the underlyning string Change-Id: I7d387e40464b53a55524bf950b8d413cf8468376 --- M

[PATCH] Use clock_gettime instead of gettimeofday to have more preci...

2013-05-10 Thread Arnaud Versini (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3841 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/41/3841/1 Use clock_gettime instead of gettimeofday to have more precise time Change-Id:

[PATCH] SW : Fix crash by checking find result

2013-05-04 Thread Arnaud Versini (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3783 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/83/3783/1 SW : Fix crash by checking find result Change-Id: I6caf18b110dd0a40f09e185c00cb238261457db3 --- M

[PATCH] Keep OUString instance by using local variable to avoid cras...

2013-04-28 Thread Arnaud Versini (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3647 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/47/3647/1 Keep OUString instance by using local variable to avoid crash. Crash with GCC 4.8 without the modification.

[ABANDONED] Keep OUString instance by using local variable to avoid cras...

2013-04-28 Thread Arnaud Versini (via Code Review)
Arnaud Versini has abandoned this change. Change subject: Keep OUString instance by using local variable to avoid crash. .. Patch Set 1: Abandoned

[RESTORED] Keep OUString instance by using local variable to avoid cras...

2013-04-28 Thread Arnaud Versini (via Code Review)
Arnaud Versini has restored this change. Change subject: Keep OUString instance by using local variable to avoid crash. .. Patch Set 1: Restored Tomorary fix untail Miklos finish its patch. -- To view, visit

[PATCH] Introduce characters utilities in rtl/character.hxx

2013-04-07 Thread Arnaud Versini (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3224 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/24/3224/1 Introduce characters utilities in rtl/character.hxx Change-Id: I94d01cd4e766f92c70f941839a67101fa2c97654 --- M

[PATCH] Use local utility functions instead of SbxSimpleCharClass

2013-03-31 Thread Arnaud Versini (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3132 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/32/3132/1 Use local utility functions instead of SbxSimpleCharClass Change-Id: I7c4bc8cc44c0b4e78feb55dcd2c15b82c414e0ef

[PATCH] Fixes fdo#60701 by escaping uri-encode path correctly

2013-03-07 Thread Arnaud Versini (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2588 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/88/2588/1 Fixes fdo#60701 by escaping uri-encode path correctly Change-Id: If1242623f4954c0cb8c6c938608cd3185e652259 ---

[PATCH] sdremote : Remove pointer to deleted RemoteServer on error c...

2013-02-11 Thread Arnaud Versini (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2081 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/81/2081/1 sdremote : Remove pointer to deleted RemoteServer on error case Change-Id:

[PATCH] Remove specific socket code for Linux

2013-02-03 Thread Arnaud Versini (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1975 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/75/1975/1 Remove specific socket code for Linux Change-Id: I8b51f7027a6c55544ebbbcc9c76bea0913856cc6 --- M

[PATCH] Drag main window by using the menubar on Gtk

2013-02-03 Thread Arnaud Versini (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1976 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/76/1976/1 Drag main window by using the menubar on Gtk Change-Id: I04a5864120f44cf987312bb41b9cbb1f9c71b248 --- M

Change in core[master]: Removing useless SwTableBox_Impl from Writter

2013-01-28 Thread Arnaud Versini (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1885 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/85/1885/1 Removing useless SwTableBox_Impl from Writter Change-Id: I2cb471e9b0784673deb75beb7d403b136fbce500 --- M

Change in core[master]: Resolving crash in wizards fdo#59931 by NULL checking

2013-01-28 Thread Arnaud Versini (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1909 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/09/1909/1 Resolving crash in wizards fdo#59931 by NULL checking Change-Id: Iccc3f3b2913f21a3831ce55c706aa4dd1da53ad6 ---

[PATCH] Remove fprintf usage from vcl/builder

2013-01-22 Thread Arnaud Versini (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1813 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/13/1813/1 Remove fprintf usage from vcl/builder Change-Id: I185cedfaff30063fe0d0deb64eecff8796ac1ff9 --- M

[PATCH] Remove useless callback in unix socket implementation

2013-01-10 Thread Arnaud Versini (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1633 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/33/1633/1 Remove useless callback in unix socket implementation Change-Id: Ibe46e2f1628f4d2e4840429703e0d5a69059a188 ---

Use less RTTI in PDFParse by adding more virtual functions.

2013-01-10 Thread Arnaud Versini (via Code Review)
Arnaud Versini has abandoned this change. Change subject: Use less RTTI in PDFParse by adding more virtual functions. .. Patch Set 3: Abandoned -- To view, visit https://gerrit.libreoffice.org/1035 To unsubscribe, visit

Inlining acquire and release in osl/mutex.

2013-01-10 Thread Arnaud Versini (via Code Review)
Arnaud Versini has abandoned this change. Change subject: Inlining acquire and release in osl/mutex. .. Patch Set 2: Abandoned -- To view, visit https://gerrit.libreoffice.org/1276 To unsubscribe, visit

[PATCH] Revert part of 34e79c19babc0e6cc281025b40635b91dca444f3.

2012-12-17 Thread Arnaud Versini (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1389 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/89/1389/1 Revert part of 34e79c19babc0e6cc281025b40635b91dca444f3. undefined reference to `sal_detail_initialize'

[PATCH] Remove useless deprecated rtl/memory.h

2012-12-08 Thread Arnaud Versini (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1268 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/68/1268/1 Remove useless deprecated rtl/memory.h Change-Id: Iac156b004464018225bbfda24f0a234f9ebcb19f --- D

[PATCH] Remove useless getpid implementation on Linux.

2012-12-01 Thread Arnaud Versini (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1219 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/19/1219/1 Remove useless getpid implementation on Linux. The new minimal target have a proper getpid implementation.

[PATCH] Class MediaDescriptorHelper don't need virtual destructor.

2012-12-01 Thread Arnaud Versini (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1220 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/20/1220/1 Class MediaDescriptorHelper don't need virtual destructor. Change-Id: I6711ef712a8a04d6fc8991f7056d1440964832ef

Mark rtl_*memory as deprecated

2012-11-14 Thread Arnaud Versini (via Code Review)
Arnaud Versini has restored this change. Change subject: Mark rtl_*memory as deprecated .. Patch Set 1: Restored Restore for a 4.0 integration -- To view, visit https://gerrit.libreoffice.org/865 To unsubscribe, visit

[PATCH] Use memcmp instead of rtl_compareMemory in svtools

2012-11-11 Thread Arnaud Versini (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1034 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/34/1034/1 Use memcmp instead of rtl_compareMemory in svtools Change-Id: Id051a39774446595b5082316a470c23246de8124 --- M

[PATCH] Use less RTTI in PDFParse by adding more virtual functions.

2012-11-11 Thread Arnaud Versini (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1035 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/35/1035/1 Use less RTTI in PDFParse by adding more virtual functions. Change-Id:

[PATCH] Update dtrans commented code to use string.h function instea...

2012-11-10 Thread Arnaud Versini (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1025 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/25/1025/1 Update dtrans commented code to use string.h function instead of rtl/memory Change-Id:

[PATCH] Fix fdo#56603 by NULL pointer checking in SwDrawTextShell::E...

2012-11-04 Thread Arnaud Versini (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/984 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/84/984/1 Fix fdo#56603 by NULL pointer checking in SwDrawTextShell::Execute Change-Id:

[PATCH] Change in core[libreoffice-3-6]: Fix fdo#56603 by NULL pointer checking in SwDrawTextShell::E...

2012-11-04 Thread Arnaud Versini (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/985 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/85/985/1 Fix fdo#56603 by NULL pointer checking in SwDrawTextShell::Execute Change-Id:

Remove commented code from dtrans

2012-11-02 Thread Arnaud Versini (via Code Review)
Arnaud Versini has abandoned this change. Change subject: Remove commented code from dtrans .. Patch Set 2: Abandoned keep it in place for a future uncomment of this code. -- To view, visit https://gerrit.libreoffice.org/962

[PUSHED] Use memcpy instead of rtl_copyMemory in ucb

2012-11-02 Thread Arnaud Versini (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/961 Approvals: Arnaud Versini: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/961 To unsubscribe,

[PATCH] Better way to initialize SwNode

2012-11-01 Thread Arnaud Versini (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/960 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/60/960/1 Better way to initialize SwNode Change-Id: I6bc397d9ecd44975ebfa58014c6fe7cd470e4ada --- M

[PATCH] Remove commented code from dtrans

2012-11-01 Thread Arnaud Versini (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/962 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/62/962/1 Remove commented code from dtrans Change-Id: I1ef4abb5b561107df257279708f619a1715e72c2 --- M

[PATCH] Use memcpy instead of rtl_copyMemory in ucb

2012-11-01 Thread Arnaud Versini (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/961 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/61/961/1 Use memcpy instead of rtl_copyMemory in ucb Change-Id: I1bdb02c6d607a10fee03d3044bad20cb811e9939 --- M

Mark rtl_*memory as deprecated

2012-10-21 Thread Arnaud Versini (via Code Review)
Arnaud Versini has abandoned this change. Change subject: Mark rtl_*memory as deprecated .. Patch Set 1: Abandoned -- To view, visit https://gerrit.libreoffice.org/865 To unsubscribe, visit

[PATCH] More efficient way to initialize SwDoc

2012-10-21 Thread Arnaud Versini (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/894 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/94/894/1 More efficient way to initialize SwDoc Change-Id: Icde740ea12e8839b0a4c8e0317143dbe2157a964 --- M

[PATCH] Cleanup and simplification of process.cxx

2012-10-14 Thread Arnaud Versini (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/868 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/68/868/1 Cleanup and simplification of process.cxx Change-Id: I2bbc2763eca7c878ead2a325589d8c4bb9210bda --- M

[PATCH] Mark rtl_*memory as deprecated

2012-10-13 Thread Arnaud Versini (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/865 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/65/865/1 Mark rtl_*memory as deprecated Change-Id: I0e5e85d6b23961baa9ef3ed4247e39497bb063d7 --- M sal/inc/rtl/memory.h 1

[PATCH] Replace usage of rtl_*Memory with equivalent from string.h

2012-09-30 Thread Arnaud Versini (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/732 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/32/732/1 Replace usage of rtl_*Memory with equivalent from string.h Change-Id: I477532cd14cb362853b800746968469ec32cbed7

Replace usage of rtl_*Memory with equivalent from string.h

2012-09-30 Thread Arnaud Versini (via Code Review)
Arnaud Versini has abandoned this change. Change subject: Replace usage of rtl_*Memory with equivalent from string.h .. Patch Set 1: Abandoned -- To view, visit https://gerrit.libreoffice.org/732 To unsubscribe, visit

[PATCH] Remove unused member SwDoc::pMacroTable

2012-09-23 Thread Arnaud Versini (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/680 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/80/680/1 Remove unused member SwDoc::pMacroTable Change-Id: Ic09b960b675d674a16f7f252ed2a974c4e25505b --- M sw/inc/doc.hxx