[PATCH] fdo#67093 Change traduction of Header in it to avoid conflic...
Hi, I would like you to review the following patch: https://gerrit.libreoffice.org/5092 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/translations refs/changes/92/5092/1 fdo#67093 Change traduction of Header in it to avoid conflict with Heading Change-Id: Ib2c7d4c7df2f492a6a10081c9ed4e99ac9e61e73 --- M source/it/sw/source/ui/utlui.po 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/it/sw/source/ui/utlui.po b/source/it/sw/source/ui/utlui.po index 2553927..759ad55 100644 --- a/source/it/sw/source/ui/utlui.po +++ b/source/it/sw/source/ui/utlui.po @@ -126,7 +126,7 @@ STR_HEADER\n string.text msgid Header -msgstr Intestazione +msgstr Riga d'intestazione #: attrdesc.src msgctxt -- To view, visit https://gerrit.libreoffice.org/5092 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib2c7d4c7df2f492a6a10081c9ed4e99ac9e61e73 Gerrit-PatchSet: 1 Gerrit-Project: translations Gerrit-Branch: master Gerrit-Owner: Arnaud Versini arnaud.vers...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH libreoffice-4-1] fdo#67093 Change traduction of Header in it to avoid conflic...
Hi, I would like you to review the following patch: https://gerrit.libreoffice.org/5093 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/translations refs/changes/93/5093/1 fdo#67093 Change traduction of Header in it to avoid conflict with Heading Change-Id: Ib2c7d4c7df2f492a6a10081c9ed4e99ac9e61e73 --- M source/it/sw/source/ui/utlui.po 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/it/sw/source/ui/utlui.po b/source/it/sw/source/ui/utlui.po index d2c3a4c..822c92cc 100644 --- a/source/it/sw/source/ui/utlui.po +++ b/source/it/sw/source/ui/utlui.po @@ -126,7 +126,7 @@ STR_HEADER\n string.text msgid Header -msgstr Intestazione +msgstr Riga d'intestazione #: attrdesc.src msgctxt -- To view, visit https://gerrit.libreoffice.org/5093 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib2c7d4c7df2f492a6a10081c9ed4e99ac9e61e73 Gerrit-PatchSet: 1 Gerrit-Project: translations Gerrit-Branch: libreoffice-4-1 Gerrit-Owner: Arnaud Versini arnaud.vers...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Change traduction of Title in french to avoid conflict with ...
Hi, I would like you to review the following patch: https://gerrit.libreoffice.org/4994 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/translations refs/changes/94/4994/1 Change traduction of Title in french to avoid conflict with Heading Change-Id: Ia87132d3593097cc9d7b81a254c300de8b9fa3a5 --- M source/fr/sw/source/ui/utlui.po 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/fr/sw/source/ui/utlui.po b/source/fr/sw/source/ui/utlui.po index 07f591c..f697c52 100644 --- a/source/fr/sw/source/ui/utlui.po +++ b/source/fr/sw/source/ui/utlui.po @@ -3141,7 +3141,7 @@ STR_POOLCOLL_DOC_TITEL\n string.text msgid Title -msgstr Titre +msgstr Titre principal #: poolfmt.src msgctxt -- To view, visit https://gerrit.libreoffice.org/4994 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia87132d3593097cc9d7b81a254c300de8b9fa3a5 Gerrit-PatchSet: 1 Gerrit-Project: translations Gerrit-Branch: master Gerrit-Owner: Arnaud Versini arnaud.vers...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH libreoffice-4-1] Change traduction of Title in french to avoid conflict with ...
Hi, I would like you to review the following patch: https://gerrit.libreoffice.org/4995 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/translations refs/changes/95/4995/1 Change traduction of Title in french to avoid conflict with Heading Change-Id: Ia87132d3593097cc9d7b81a254c300de8b9fa3a5 --- M source/fr/sw/source/ui/utlui.po 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/fr/sw/source/ui/utlui.po b/source/fr/sw/source/ui/utlui.po index 07f591c..f697c52 100644 --- a/source/fr/sw/source/ui/utlui.po +++ b/source/fr/sw/source/ui/utlui.po @@ -3141,7 +3141,7 @@ STR_POOLCOLL_DOC_TITEL\n string.text msgid Title -msgstr Titre +msgstr Titre principal #: poolfmt.src msgctxt -- To view, visit https://gerrit.libreoffice.org/4995 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia87132d3593097cc9d7b81a254c300de8b9fa3a5 Gerrit-PatchSet: 1 Gerrit-Project: translations Gerrit-Branch: libreoffice-4-1 Gerrit-Owner: Arnaud Versini arnaud.vers...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH libreoffice-4-1-0] Change traduction of Title in french to avoid conflict with ...
Hi, I would like you to review the following patch: https://gerrit.libreoffice.org/4996 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/translations refs/changes/96/4996/1 Change traduction of Title in french to avoid conflict with Heading Change-Id: Ia87132d3593097cc9d7b81a254c300de8b9fa3a5 --- M source/fr/sw/source/ui/utlui.po 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/fr/sw/source/ui/utlui.po b/source/fr/sw/source/ui/utlui.po index 07f591c..f697c52 100644 --- a/source/fr/sw/source/ui/utlui.po +++ b/source/fr/sw/source/ui/utlui.po @@ -3141,7 +3141,7 @@ STR_POOLCOLL_DOC_TITEL\n string.text msgid Title -msgstr Titre +msgstr Titre principal #: poolfmt.src msgctxt -- To view, visit https://gerrit.libreoffice.org/4996 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia87132d3593097cc9d7b81a254c300de8b9fa3a5 Gerrit-PatchSet: 1 Gerrit-Project: translations Gerrit-Branch: libreoffice-4-1-0 Gerrit-Owner: Arnaud Versini arnaud.vers...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Multi threaded version of osl_getGlobalTime on Unix
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3960 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/60/3960/1 Multi threaded version of osl_getGlobalTime on Unix Change-Id: Ibb9d23780600437f607d866ff3d396b96879245d --- M sal/osl/unx/salinit.cxx M sal/osl/unx/time.c 2 files changed, 27 insertions(+), 8 deletions(-) diff --git a/sal/osl/unx/salinit.cxx b/sal/osl/unx/salinit.cxx index 327ca0e..b33e5f3 100644 --- a/sal/osl/unx/salinit.cxx +++ b/sal/osl/unx/salinit.cxx @@ -38,6 +38,8 @@ extern C { +void sal_initGlobalTimer(); + void sal_detail_initialize(int argc, char ** argv) { #if defined MACOSX // On Mac OS X, soffice can restart itself via exec (see restartOnMac in diff --git a/sal/osl/unx/time.c b/sal/osl/unx/time.c index c99036b..1516cd9 100644 --- a/sal/osl/unx/time.c +++ b/sal/osl/unx/time.c @@ -253,22 +253,37 @@ return sal_False; } +#if defined(LINUX) +void sal_initGlobalTimer() {} + +sal_uInt32 SAL_CALL osl_getGlobalTimer() +{ +struct timespec currentTime; +int res; + +res = clock_gettime(CLOCK_PROCESS_CPUTIME_ID , NULL); +if (res != 0) +{ + return 0; +} + +return currentTime.tv_sec + (currentTime.tv_nsec / 1000); +} + +#else static struct timeval startTime; -static sal_Bool bGlobalTimer = sal_False; + +void sal_initGlobalTimer() +{ +gettimeofday( startTime, NULL ); +} sal_uInt32 SAL_CALL osl_getGlobalTimer() { struct timeval currentTime; sal_uInt32 nSeconds; - - // FIXME: not thread safe !! - if ( bGlobalTimer == sal_False ) - { - gettimeofday( startTime, NULL ); - bGlobalTimer=sal_True; - } gettimeofday( currentTime, NULL ); @@ -277,4 +292,6 @@ return ( nSeconds * 1000 ) + (long) (( currentTime.tv_usec - startTime.tv_usec) / 1000 ); } +#endif + /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ -- To view, visit https://gerrit.libreoffice.org/3960 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibb9d23780600437f607d866ff3d396b96879245d Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Arnaud Versini arnaud.vers...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Use clock_gettime when available on *nix
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3964 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/64/3964/1 Use clock_gettime when available on *nix Change-Id: I65df2b119dbda274749ab2b4d0825fbdf44eb4e8 --- M sal/osl/unx/time.c 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/sal/osl/unx/time.c b/sal/osl/unx/time.c index 4294cd2..796e882 100644 --- a/sal/osl/unx/time.c +++ b/sal/osl/unx/time.c @@ -24,6 +24,7 @@ #include osl/time.h #include time.h #include assert.h +#include unistd /* FIXME: detection should be done in configure script */ #if defined(MACOSX) || defined(FREEBSD) || defined(NETBSD) || \ @@ -34,7 +35,11 @@ #define HAS_ALTZONE 1 #endif -#if defined(LINUX) +#if defined(_POSIX_TIMERS) (_POSIX_TIMERS 0) +#define USE_CLOCK_GETTIME 1 +#endif + +#if USE_CLOCK_GETTIME typedef struct timespec osl_time_t; #else typedef struct timeval osl_time_t; @@ -48,7 +53,7 @@ { int res; osl_time_t tp; -#if defined(LINUX) +#if defined(USE_CLOCK_GETTIME) res = clock_gettime(CLOCK_REALTIME, tp); #else res = gettimeofday(tp, NULL); @@ -60,7 +65,7 @@ } tv-Seconds = tp.tv_sec; -#if defined(LINUX) +#if defined(USE_CLOCK_GETTIME) tv-Nanosec = tp.tv_nsec; #else tv-Nanosec = tp.tv_usec * 1000; @@ -262,7 +267,7 @@ void sal_initGlobalTimer() { int res; - #if defined(LINUX) + #if defined(USE_CLOCK_GETTIME) res = clock_gettime(CLOCK_REALTIME, startTime); #else res = gettimeofday( startTime, NULL ); @@ -277,7 +282,7 @@ int res; sal_uInt32 nSeconds; - #if defined(LINUX) + #if defined(USE_CLOCK_GETTIME) res = clock_gettime(CLOCK_REALTIME, startTime); #else res = gettimeofday( startTime, NULL ); @@ -289,7 +294,7 @@ return 0; nSeconds = (sal_uInt32)( currentTime.tv_sec - startTime.tv_sec ); - #if defined(LINUX) + #if defined(USE_CLOCK_GETTIME) nSeconds = ( nSeconds * 1000 ) + (long) (( currentTime.tv_nsec - startTime.tv_nsec) / 100 ); #else nSeconds = ( nSeconds * 1000 ) + (long) (( currentTime.tv_usec - startTime.tv_usec) / 1000 ); -- To view, visit https://gerrit.libreoffice.org/3964 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I65df2b119dbda274749ab2b4d0825fbdf44eb4e8 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Arnaud Versini arnaud.vers...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[ABANDONED] Use clock_gettime when available on *nix
Arnaud Versini has abandoned this change. Change subject: Use clock_gettime when available on *nix .. Patch Set 2: Abandoned -- To view, visit https://gerrit.libreoffice.org/3964 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I65df2b119dbda274749ab2b4d0825fbdf44eb4e8 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Arnaud Versini arnaud.vers...@gmail.com Gerrit-Reviewer: Arnaud Versini arnaud.vers...@gmail.com Gerrit-Reviewer: Norbert Thiebaud nthieb...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Fix build on fedora and debian by checking _POSIX_C_SOURCE
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3889 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/89/3889/1 Fix build on fedora and debian by checking _POSIX_C_SOURCE Change-Id: I12809d970d0a2a4ebb946675f904832ff37e029f --- M sal/osl/unx/time.c 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/sal/osl/unx/time.c b/sal/osl/unx/time.c index c99036b..7a2d355 100644 --- a/sal/osl/unx/time.c +++ b/sal/osl/unx/time.c @@ -24,6 +24,8 @@ #include osl/time.h #include time.h +#include features.h + /* FIXME: detection should be done in configure script */ #if defined(MACOSX) || defined(FREEBSD) || defined(NETBSD) || \ defined(LINUX) || defined(OPENBSD) || defined(DRAGONFLY) @@ -33,6 +35,10 @@ #define HAS_ALTZONE 1 #endif +#if defined(LINUX) (_POSIX_C_SOURCE = 199309L) +#define USE_CLOCK_GETTIME +#endif + /*-- * osl_getSystemTime *-*/ @@ -40,7 +46,7 @@ sal_Bool SAL_CALL osl_getSystemTime(TimeValue* tv) { int res; -#if defined(LINUX) +#if defined(USE_CLOCK_GETTIME) struct timespec tp; res = clock_gettime(CLOCK_REALTIME, tp); @@ -56,7 +62,7 @@ } tv-Seconds = tp.tv_sec; -#if defined(LINUX) +#if defined(USE_CLOCK_GETTIME) tv-Nanosec = tp.tv_nsec; #else tv-Nanosec = tp.tv_usec * 1000; -- To view, visit https://gerrit.libreoffice.org/3889 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I12809d970d0a2a4ebb946675f904832ff37e029f Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Arnaud Versini arnaud.vers...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[ABANDONED] Fix build on linux by adding -lrt.
Arnaud Versini has abandoned this change. Change subject: Fix build on linux by adding -lrt. .. Patch Set 3: Abandoned Already changed in master by http://cgit.freedesktop.org/libreoffice/core/commit/?id=a85f5b1ee0ccf5e1999f5452ce162e251191dd98 -- To view, visit https://gerrit.libreoffice.org/3889 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I12809d970d0a2a4ebb946675f904832ff37e029f Gerrit-PatchSet: 3 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Arnaud Versini arnaud.vers...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Fixes fdo#64237 by modifying the underlyning string
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3870 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/70/3870/1 Fixes fdo#64237 by modifying the underlyning string Change-Id: I7d387e40464b53a55524bf950b8d413cf8468376 --- M sw/source/core/text/guess.cxx 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sw/source/core/text/guess.cxx b/sw/source/core/text/guess.cxx index 637372f..03628da 100644 --- a/sw/source/core/text/guess.cxx +++ b/sw/source/core/text/guess.cxx @@ -275,7 +275,7 @@ aDebugString = rInf.GetTxt(); #endif -OUString rOldTxt = rInf.GetTxt(); +OUString rOldTxt = const_castOUString (rInf.GetTxt()); rOldTxt = rOldTxt.replaceAt( rInf.GetIdx() - 1, 1, aTxt ); rInf.SetIdx( rInf.GetIdx() + nFieldDiff ); } @@ -487,9 +487,9 @@ I've got field trouble, part2! ); nCutPos = nCutPos - nFieldDiff; -XubString rOldTxt = (XubString)rInf.GetTxt(); -rOldTxt.Erase( nOldIdx - 1, nFieldDiff + 1 ); -rOldTxt.Insert( cFldChr, nOldIdx - 1 ); +OUString rOldTxt = const_castOUString (rInf.GetTxt()); +OUString aReplacement( cFldChr ); +rOldTxt = rOldTxt.replaceAt( nOldIdx - 1, nFieldDiff + 1, aReplacement); rInf.SetIdx( nOldIdx ); #if OSL_DEBUG_LEVEL 0 -- To view, visit https://gerrit.libreoffice.org/3870 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7d387e40464b53a55524bf950b8d413cf8468376 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Arnaud Versini arnaud.vers...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Use clock_gettime instead of gettimeofday to have more preci...
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3841 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/41/3841/1 Use clock_gettime instead of gettimeofday to have more precise time Change-Id: I8e568368e7626789dee21d4823dbedec6257a231 --- M sal/osl/unx/time.c 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/sal/osl/unx/time.c b/sal/osl/unx/time.c index e613248..e499d85 100644 --- a/sal/osl/unx/time.c +++ b/sal/osl/unx/time.c @@ -22,6 +22,7 @@ #include osl/diagnose.h #include osl/time.h +#include time.h /* FIXME: detection should be done in configure script */ #if defined(MACOSX) || defined(FREEBSD) || defined(NETBSD) || \ @@ -38,15 +39,20 @@ sal_Bool SAL_CALL osl_getSystemTime(TimeValue* tv) { -struct timeval tp; +struct timespec tp; +int res; -/* FIXME: use higher resolution */ -gettimeofday(tp, NULL); +res = clock_gettime(CLOCK_REALTIME, tp); + +if (res != 0) +{ +return sal_False; +} tv-Seconds = tp.tv_sec; -tv-Nanosec = tp.tv_usec * 1000; +tv-Nanosec = tp.tv_nsec; -return (sal_True); +return sal_True; } -- To view, visit https://gerrit.libreoffice.org/3841 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8e568368e7626789dee21d4823dbedec6257a231 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Arnaud Versini arnaud.vers...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] SW : Fix crash by checking find result
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3783 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/83/3783/1 SW : Fix crash by checking find result Change-Id: I6caf18b110dd0a40f09e185c00cb238261457db3 --- M sw/source/core/txtnode/ndtxt.cxx 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/sw/source/core/txtnode/ndtxt.cxx b/sw/source/core/txtnode/ndtxt.cxx index 437cf44..07f36ef 100644 --- a/sw/source/core/txtnode/ndtxt.cxx +++ b/sw/source/core/txtnode/ndtxt.cxx @@ -3211,7 +3211,10 @@ if (aHiddenMulti.IsSelected(nDummyCharPos)) continue; std::vectorblock::iterator aFind = std::find_if(aBlocks.begin(), aBlocks.end(), containsPos(nDummyCharPos)); -aFind-m_aAttrs.push_back(pAttr); +if (aFind != aBlocks.end()) +{ +aFind-m_aAttrs.push_back(pAttr); +} } } } -- To view, visit https://gerrit.libreoffice.org/3783 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6caf18b110dd0a40f09e185c00cb238261457db3 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Arnaud Versini arnaud.vers...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Keep OUString instance by using local variable to avoid cras...
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3647 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/47/3647/1 Keep OUString instance by using local variable to avoid crash. Crash with GCC 4.8 without the modification. Change-Id: Ieb2437f2ee6b02884aa10f2d03a4223306329cd8 --- M sw/source/core/text/itrcrsr.cxx 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sw/source/core/text/itrcrsr.cxx b/sw/source/core/text/itrcrsr.cxx index b68b5ce..d567e76 100644 --- a/sw/source/core/text/itrcrsr.cxx +++ b/sw/source/core/text/itrcrsr.cxx @@ -1593,7 +1593,8 @@ else nOldProp = 0; { -SwTxtSizeInfo aSizeInf( GetInfo(), rText, nCurrStart ); +OUString rTextStr = rText; +SwTxtSizeInfo aSizeInf( GetInfo(), rTextStr, nCurrStart ); ((SwTxtCursor*)this)-SeekAndChg( aSizeInf ); SwTxtSlot aDiffTxt( aSizeInf, ((SwTxtPortion*)pPor), false, false ); SwFontSave aSave( aSizeInf, pPor-IsDropPortion() ? -- To view, visit https://gerrit.libreoffice.org/3647 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ieb2437f2ee6b02884aa10f2d03a4223306329cd8 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Arnaud Versini arnaud.vers...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[ABANDONED] Keep OUString instance by using local variable to avoid cras...
Arnaud Versini has abandoned this change. Change subject: Keep OUString instance by using local variable to avoid crash. .. Patch Set 1: Abandoned http://cgit.freedesktop.org/~vmiklos/lo-core/commit/?id=bfb8d155269e915b150f2690323df5d572e69683 is better to solve this issue. -- To view, visit https://gerrit.libreoffice.org/3647 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ieb2437f2ee6b02884aa10f2d03a4223306329cd8 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Arnaud Versini arnaud.vers...@gmail.com Gerrit-Reviewer: Bosdonnat Cedric cedric.bosdon...@free.fr Gerrit-Reviewer: Norbert Thiebaud nthieb...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[RESTORED] Keep OUString instance by using local variable to avoid cras...
Arnaud Versini has restored this change. Change subject: Keep OUString instance by using local variable to avoid crash. .. Patch Set 1: Restored Tomorary fix untail Miklos finish its patch. -- To view, visit https://gerrit.libreoffice.org/3647 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: restore Gerrit-Change-Id: Ieb2437f2ee6b02884aa10f2d03a4223306329cd8 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Arnaud Versini arnaud.vers...@gmail.com Gerrit-Reviewer: Bosdonnat Cedric cedric.bosdon...@free.fr Gerrit-Reviewer: Norbert Thiebaud nthieb...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Introduce characters utilities in rtl/character.hxx
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3224 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/24/3224/1 Introduce characters utilities in rtl/character.hxx Change-Id: I94d01cd4e766f92c70f941839a67101fa2c97654 --- M basic/source/sbx/sbxexec.cxx M sal/ZipPackage_sal_odk_headers.mk A sal/inc/rtl/character.hxx M sal/rtl/math.cxx M sal/rtl/uri.cxx M stoc/source/uriproc/UriReferenceFactory.cxx M tools/inc/tools/inetmime.hxx M tools/source/fsys/urlobj.cxx 8 files changed, 212 insertions(+), 146 deletions(-) diff --git a/basic/source/sbx/sbxexec.cxx b/basic/source/sbx/sbxexec.cxx index 905b3a2..b6775ad 100644 --- a/basic/source/sbx/sbxexec.cxx +++ b/basic/source/sbx/sbxexec.cxx @@ -20,26 +20,7 @@ #include tools/errcode.hxx #include vcl/svapp.hxx #include basic/sbx.hxx - - - -static bool isAlpha( sal_Unicode c ) -{ -bool bRet = (c = 'a' c = 'z') || (c = 'A' c = 'Z'); -return bRet; -} - -static bool isDigit( sal_Unicode c ) -{ -bool bRet = (c = '0' c = '9'); -return bRet; -} - -static bool isAlphaNumeric( sal_Unicode c ) -{ -bool bRet = isDigit( c ) || isAlpha( c ); -return bRet; -} +#include rtl/character.hxx static SbxVariable* Element @@ -72,7 +53,7 @@ else { // A symbol had to begin with a alphabetic character or an underline -if( !isAlpha( *p ) *p != '_' ) +if( !rtl::isAsciiAlpha( *p ) *p != '_' ) { SbxBase::SetError( SbxERR_SYNTAX ); } @@ -80,7 +61,7 @@ { rSym = p; // The it can contain alphabetic characters, numbers or underlines -while( *p (isAlphaNumeric( *p ) || *p == '_') ) +while( *p (rtl::isAsciiAlphaNumeric( *p ) || *p == '_') ) { p++, nLen++; } @@ -103,7 +84,7 @@ SbxVariableRef refVar; const sal_Unicode* p = SkipWhitespace( *ppBuf ); -if( isAlpha( *p ) || *p == '_' || *p == '[' ) +if( rtl::isAsciiAlpha( *p ) || *p == '_' || *p == '[' ) { // Read in the element refVar = Element( pObj, pGbl, p, t ); @@ -139,8 +120,8 @@ { SbxVariableRef refVar( new SbxVariable ); const sal_Unicode* p = SkipWhitespace( *ppBuf ); -if( !bVar ( isDigit( *p ) - || ( *p == '.' isDigit( *( p+1 ) ) ) +if( !bVar ( rtl::isAsciiDigit( *p ) + || ( *p == '.' rtl::isAsciiDigit( *( p+1 ) ) ) || *p == '-' || *p == '' ) ) { diff --git a/sal/ZipPackage_sal_odk_headers.mk b/sal/ZipPackage_sal_odk_headers.mk index 458dbe5..696bc60 100644 --- a/sal/ZipPackage_sal_odk_headers.mk +++ b/sal/ZipPackage_sal_odk_headers.mk @@ -32,6 +32,7 @@ rtl/bootstrap.hxx \ rtl/byteseq.h \ rtl/byteseq.hxx \ + rtl/character.hxx \ rtl/cipher.h \ rtl/crc.h \ rtl/digest.h \ diff --git a/sal/inc/rtl/character.hxx b/sal/inc/rtl/character.hxx new file mode 100644 index 000..fa2a41f --- /dev/null +++ b/sal/inc/rtl/character.hxx @@ -0,0 +1,120 @@ +/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ +/* + * This file is part of the LibreOffice project. + * + * This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. + * + * This file incorporates work covered by the following license notice: + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed + * with this work for additional information regarding copyright + * ownership. The ASF licenses this file to you under the Apache + * License, Version 2.0 (the License); you may not use this file + * except in compliance with the License. You may obtain a copy of + * the License at http://www.apache.org/licenses/LICENSE-2.0 . + */ + +#pragma once + +namespace rtl +{ +/** Check for ASCII character. + +@param nUtf32 Some UCS-4 character. + +@return True if nChar is a ASCII character (0x00--0x7F). + */ +inline bool isAscii(sal_uInt32 nUtf32) +{ +return nUtf32 = 0x7F; +} + +/** Check for ASCII lower case character. + +@param nUtf32 Some UCS-4 character. + +@return True if nChar is a US-ASCII lower case alphabetic character +(ASCII 'a'--'z'). + */ +inline bool isAsciiLowerCase(sal_uInt32 nUtf32) +{ +return nUtf32 = 'a' nUtf32 = 'z'; +} + +/** Check for US-ASCII upper case character. + +@param nUtf32 Some UCS-4 character. + +@return True if nChar is a US-ASCII upper case alphabetic character +(US-ASCII 'A'--'Z'). + */ +inline bool isAsciiUpperCase(sal_uInt32 nUtf32) +{ +return nUtf32 = 'A' nUtf32 = 'Z'; +} + +/** Check for ASCII alphanumeric character. + +@param nUtf32 Some UCS-4 character. + +@return True if
[PATCH] Use local utility functions instead of SbxSimpleCharClass
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3132 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/32/3132/1 Use local utility functions instead of SbxSimpleCharClass Change-Id: I7c4bc8cc44c0b4e78feb55dcd2c15b82c414e0ef --- M basic/source/sbx/sbxexec.cxx 1 file changed, 26 insertions(+), 32 deletions(-) diff --git a/basic/source/sbx/sbxexec.cxx b/basic/source/sbx/sbxexec.cxx index 3eaaecf..905b3a2 100644 --- a/basic/source/sbx/sbxexec.cxx +++ b/basic/source/sbx/sbxexec.cxx @@ -22,32 +22,29 @@ #include basic/sbx.hxx -class SbxSimpleCharClass + +static bool isAlpha( sal_Unicode c ) { -public: -bool isAlpha( sal_Unicode c ) const -{ -bool bRet = (c = 'a' c = 'z') || (c = 'A' c = 'Z'); -return bRet; -} +bool bRet = (c = 'a' c = 'z') || (c = 'A' c = 'Z'); +return bRet; +} -bool isDigit( sal_Unicode c ) const -{ -bool bRet = (c = '0' c = '9'); -return bRet; -} +static bool isDigit( sal_Unicode c ) +{ +bool bRet = (c = '0' c = '9'); +return bRet; +} -bool isAlphaNumeric( sal_Unicode c ) const -{ -bool bRet = isDigit( c ) || isAlpha( c ); -return bRet; -} -}; +static bool isAlphaNumeric( sal_Unicode c ) +{ +bool bRet = isDigit( c ) || isAlpha( c ); +return bRet; +} static SbxVariable* Element ( SbxObject* pObj, SbxObject* pGbl, const sal_Unicode** ppBuf, - SbxClassType, const SbxSimpleCharClass rCharClass ); + SbxClassType ); static const sal_Unicode* SkipWhitespace( const sal_Unicode* p ) { @@ -59,7 +56,7 @@ // Scanning of a symbol. The symbol were inserted in rSym, the return value // is the new scan position. The symbol is at errors empty. -static const sal_Unicode* Symbol( const sal_Unicode* p, OUString rSym, const SbxSimpleCharClass rCharClass ) +static const sal_Unicode* Symbol( const sal_Unicode* p, OUString rSym ) { sal_uInt16 nLen = 0; // Did we have a nonstandard symbol? @@ -75,7 +72,7 @@ else { // A symbol had to begin with a alphabetic character or an underline -if( !rCharClass.isAlpha( *p ) *p != '_' ) +if( !isAlpha( *p ) *p != '_' ) { SbxBase::SetError( SbxERR_SYNTAX ); } @@ -83,7 +80,7 @@ { rSym = p; // The it can contain alphabetic characters, numbers or underlines -while( *p (rCharClass.isAlphaNumeric( *p ) || *p == '_') ) +while( *p (isAlphaNumeric( *p ) || *p == '_') ) { p++, nLen++; } @@ -103,14 +100,13 @@ static SbxVariable* QualifiedName ( SbxObject* pObj, SbxObject* pGbl, const sal_Unicode** ppBuf, SbxClassType t ) { -static SbxSimpleCharClass aCharClass; SbxVariableRef refVar; const sal_Unicode* p = SkipWhitespace( *ppBuf ); -if( aCharClass.isAlpha( *p ) || *p == '_' || *p == '[' ) +if( isAlpha( *p ) || *p == '_' || *p == '[' ) { // Read in the element -refVar = Element( pObj, pGbl, p, t, aCharClass ); +refVar = Element( pObj, pGbl, p, t ); while( refVar.Is() (*p == '.' || *p == '!') ) { // It follows still an objectelement. The current element @@ -124,7 +120,7 @@ break; p++; // And the next element please -refVar = Element( pObj, pGbl, p, t, aCharClass ); +refVar = Element( pObj, pGbl, p, t ); } } else @@ -141,12 +137,10 @@ static SbxVariable* Operand ( SbxObject* pObj, SbxObject* pGbl, const sal_Unicode** ppBuf, bool bVar ) { -static SbxSimpleCharClass aCharClass; - SbxVariableRef refVar( new SbxVariable ); const sal_Unicode* p = SkipWhitespace( *ppBuf ); -if( !bVar ( aCharClass.isDigit( *p ) - || ( *p == '.' aCharClass.isDigit( *( p+1 ) ) ) +if( !bVar ( isDigit( *p ) + || ( *p == '.' isDigit( *( p+1 ) ) ) || *p == '-' || *p == '' ) ) { @@ -306,10 +300,10 @@ static SbxVariable* Element ( SbxObject* pObj, SbxObject* pGbl, const sal_Unicode** ppBuf, - SbxClassType t, const SbxSimpleCharClass rCharClass ) + SbxClassType t ) { OUString aSym; -const sal_Unicode* p = Symbol( *ppBuf, aSym, rCharClass ); +const sal_Unicode* p = Symbol( *ppBuf, aSym ); SbxVariableRef refVar; if( !aSym.isEmpty() ) { -- To view, visit https://gerrit.libreoffice.org/3132 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7c4bc8cc44c0b4e78feb55dcd2c15b82c414e0ef Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Arnaud Versini arnaud.vers...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org
[PATCH] Fixes fdo#60701 by escaping uri-encode path correctly
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2588 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/88/2588/1 Fixes fdo#60701 by escaping uri-encode path correctly Change-Id: If1242623f4954c0cb8c6c938608cd3185e652259 --- M shell/source/unix/misc/senddoc.sh 1 file changed, 1 insertion(+), 0 deletions(-) diff --git a/shell/source/unix/misc/senddoc.sh b/shell/source/unix/misc/senddoc.sh index 0ff1594..a2c53fd 100644 --- a/shell/source/unix/misc/senddoc.sh +++ b/shell/source/unix/misc/senddoc.sh @@ -18,6 +18,7 @@ # URI_ENCODE=`dirname $0`/uri-encode +URI_ENCODE=$(printf %b $(URI_ENCODE)) FOPTS= sd_platform=`uname -s` -- To view, visit https://gerrit.libreoffice.org/2588 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If1242623f4954c0cb8c6c938608cd3185e652259 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Arnaud Versini arnaud.vers...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] sdremote : Remove pointer to deleted RemoteServer on error c...
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2081 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/81/2081/1 sdremote : Remove pointer to deleted RemoteServer on error case Change-Id: Id0fcbf46c907b94f1233acfbd84036b85ca388a3 --- M sd/source/ui/remotecontrol/Server.cxx 1 file changed, 4 insertions(+), 0 deletions(-) diff --git a/sd/source/ui/remotecontrol/Server.cxx b/sd/source/ui/remotecontrol/Server.cxx index 76b4dd7..a4dd53a 100644 --- a/sd/source/ui/remotecontrol/Server.cxx +++ b/sd/source/ui/remotecontrol/Server.cxx @@ -80,18 +80,21 @@ if (!xContext.is() || !officecfg::Office::Common::Misc::ExperimentalMode::get(xContext)) { SAL_INFO(sdremote, not in experimental mode, disabling TCP server); +spServer = NULL; return; } osl::SocketAddr aAddr( 0, PORT ); if ( !mSocket.bind( aAddr ) ) { SAL_WARN( sdremote, bind failed mSocket.getErrorAsString() ); +spServer = NULL; return; } if ( !mSocket.listen(3) ) { SAL_WARN( sdremote, listen failed mSocket.getErrorAsString() ); +spServer = NULL; return; } while ( true ) @@ -101,6 +104,7 @@ if ( mSocket.acceptConnection( aSocket ) == osl_Socket_Error ) { SAL_WARN( sdremote, accept failed mSocket.getErrorAsString() ); +spServer = NULL; return; // Closed, or other issue. } BufferedStreamSocket *pSocket = new BufferedStreamSocket( aSocket); -- To view, visit https://gerrit.libreoffice.org/2081 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id0fcbf46c907b94f1233acfbd84036b85ca388a3 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Arnaud Versini arnaud.vers...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Remove specific socket code for Linux
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1975 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/75/1975/1 Remove specific socket code for Linux Change-Id: I8b51f7027a6c55544ebbbcc9c76bea0913856cc6 --- M sal/osl/unx/pipe.c M sal/osl/unx/socket.c M sal/osl/unx/sockimpl.h 3 files changed, 0 insertions(+), 134 deletions(-) diff --git a/sal/osl/unx/pipe.c b/sal/osl/unx/pipe.c index f0720ec..a61a022 100644 --- a/sal/osl/unx/pipe.c +++ b/sal/osl/unx/pipe.c @@ -109,10 +109,6 @@ pPipeImpl = (oslPipe)calloc(1, sizeof(struct oslPipeImpl)); pPipeImpl-m_nRefCount =1; pPipeImpl-m_bClosed = sal_False; -#if defined(LINUX) -pPipeImpl-m_bIsInShutdown = sal_False; -pPipeImpl-m_bIsAccepting = sal_False; -#endif return pPipeImpl; } @@ -366,11 +362,6 @@ void SAL_CALL osl_closePipe( oslPipe pPipe ) { int nRet; -#if defined(LINUX) -size_t len; -struct sockaddr_un addr; -int fd; -#endif int ConnFD; if( ! pPipe ) @@ -384,34 +375,6 @@ } ConnFD = pPipe-m_Socket; - -/* - Thread does not return from accept on linux, so - connect to the accepting pipe - */ -#if defined(LINUX) -if ( pPipe-m_bIsAccepting ) -{ -pPipe-m_bIsInShutdown = sal_True; -pPipe-m_Socket = -1; -fd = socket(AF_UNIX, SOCK_STREAM, 0); -memset(addr, 0, sizeof(addr)); - -OSL_TRACE(osl_destroyPipe : Pipe Name '%s',pPipe-m_Name); - -addr.sun_family = AF_UNIX; -strncpy(addr.sun_path, pPipe-m_Name, sizeof(addr.sun_path) - 1); -len = sizeof(addr); - -nRet = connect( fd, (struct sockaddr *)addr, len); -if ( nRet 0 ) -{ -OSL_TRACE(connect in osl_destroyPipe failed with error: %s, strerror(errno)); -} -close(fd); -} -#endif /* LINUX */ - nRet = shutdown(ConnFD, 2); if ( nRet 0 ) @@ -451,15 +414,8 @@ OSL_ASSERT(strlen(pPipe-m_Name) 0); -#if defined(LINUX) -pPipe-m_bIsAccepting = sal_True; -#endif - s = accept(pPipe-m_Socket, NULL, NULL); -#if defined(LINUX) -pPipe-m_bIsAccepting = sal_False; -#endif if (s 0) { @@ -467,13 +423,6 @@ return NULL; } -#if defined(LINUX) -if ( pPipe-m_bIsInShutdown ) -{ -close(s); -return NULL; -} -#endif /* LINUX */ else { /* alloc memory */ diff --git a/sal/osl/unx/socket.c b/sal/osl/unx/socket.c index a9f3fc0..9e75710 100644 --- a/sal/osl/unx/socket.c +++ b/sal/osl/unx/socket.c @@ -471,10 +471,6 @@ pSocket-m_nLastError = 0; pSocket-m_nRefCount = 1; -#if defined(LINUX) -pSocket-m_bIsAccepting = sal_False; -#endif - #if OSL_DEBUG_LEVEL 1 g_nSocketImpl ++; #endif @@ -1478,13 +1474,6 @@ { if( pSocket 0 == osl_atomic_decrement( (pSocket-m_nRefCount) ) ) { -#if defined(LINUX) -if ( pSocket-m_bIsAccepting == sal_True ) -{ -OSL_FAIL(osl_destroySocket : attempt to destroy socket while accepting\n); -return; -} -#endif /* LINUX */ osl_closeSocket( pSocket ); __osl_destroySocketImpl( pSocket ); } @@ -1511,48 +1500,6 @@ return; pSocket-m_Socket = OSL_INVALID_SOCKET; - -#if defined(LINUX) -pSocket-m_bIsInShutdown = sal_True; - -if ( pSocket-m_bIsAccepting == sal_True ) -{ -int nConnFD; -union { -struct sockaddr aSockAddr; -struct sockaddr_in aSockAddrIn; -} s; -socklen_t nSockLen = sizeof(s.aSockAddr); - -nRet = getsockname(nFD, s.aSockAddr, nSockLen); -if ( nRet 0 ) -{ -OSL_TRACE(getsockname call failed with error: %s, strerror(errno)); -} - -if ( s.aSockAddr.sa_family == AF_INET ) -{ -if ( s.aSockAddrIn.sin_addr.s_addr == htonl(INADDR_ANY) ) -{ -s.aSockAddrIn.sin_addr.s_addr = htonl(INADDR_LOOPBACK); -} - -nConnFD = socket(AF_INET, SOCK_STREAM, 0); -if ( nConnFD 0 ) -{ -OSL_TRACE(socket call failed with error: %s, strerror(errno)); -} - -nRet = connect(nConnFD, s.aSockAddr, sizeof(s.aSockAddr)); -if ( nRet 0 ) -{ -OSL_TRACE(connect call failed with error: %s, strerror(errno)); -} -close(nConnFD); -} -pSocket-m_bIsAccepting = sal_False; -} -#endif /* LINUX */ nRet=close(nFD); if ( nRet != 0 ) @@ -1827,9 +1774,6 @@ } pSocket-m_nLastError=0; -#if defined(LINUX) -pSocket-m_bIsAccepting = sal_True; -#endif /* LINUX */ if( ppAddr *ppAddr ) { @@ -1850,24 +1794,10 @@ pSocket-m_nLastError=errno; OSL_TRACE(osl_acceptConnectionOnSocket : accept error '%s',strerror(errno)); -#if defined(LINUX) -pSocket-m_bIsAccepting = sal_False; -#endif /*
[PATCH] Drag main window by using the menubar on Gtk
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1976 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/76/1976/1 Drag main window by using the menubar on Gtk Change-Id: I04a5864120f44cf987312bb41b9cbb1f9c71b248 --- M vcl/headless/svpframe.cxx M vcl/inc/headless/svpframe.hxx M vcl/inc/salframe.hxx M vcl/inc/unx/gtk/gtkframe.hxx M vcl/inc/unx/salframe.h M vcl/inc/vcl/window.hxx M vcl/inc/win/salframe.h M vcl/source/window/menu.cxx M vcl/source/window/window.cxx M vcl/unx/generic/window/salframe.cxx M vcl/unx/gtk/window/gtkframe.cxx M vcl/unx/kde4/KDESalFrame.cxx M vcl/unx/kde4/KDESalFrame.hxx M vcl/win/source/window/salframe.cxx 14 files changed, 67 insertions(+), 3 deletions(-) diff --git a/vcl/headless/svpframe.cxx b/vcl/headless/svpframe.cxx index 0d4e466..c9dc95c 100644 --- a/vcl/headless/svpframe.cxx +++ b/vcl/headless/svpframe.cxx @@ -470,4 +470,8 @@ { } +void SvpSalFrame::StartDragFrame (long /*x*/, long /*y*/, sal_uInt16 /*button*/, sal_uLong /*nTime*/) +{ +} + /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/vcl/inc/headless/svpframe.hxx b/vcl/inc/headless/svpframe.hxx index c48d602..c96116c 100644 --- a/vcl/inc/headless/svpframe.hxx +++ b/vcl/inc/headless/svpframe.hxx @@ -127,7 +127,7 @@ bool IsVisible() { return m_bVisible; } static SvpSalFrame* GetFocusFrame() { return s_pFocusFrame; } - +void StartDragFrame (long x, long y, sal_uInt16 button, sal_uLong nTime) ; }; #endif // _SVP_SVPFRAME_HXX diff --git a/vcl/inc/salframe.hxx b/vcl/inc/salframe.hxx index 63096e0..fbbd9a2 100644 --- a/vcl/inc/salframe.hxx +++ b/vcl/inc/salframe.hxx @@ -22,6 +22,7 @@ #include tools/solar.h #include vcl/dllapi.h +#include vcl/event.hxx #ifdef __cplusplus @@ -248,6 +249,9 @@ // done setting up the clipregion virtual voidEndSetClipRegion() = 0; +// start dragging the frame on the desktop +virtual void StartDragFrame (long x, long y, sal_uInt16 button, sal_uLong nTime) = 0; + // Callbacks (indepent part in vcl/source/window/winproc.cxx) // for default message handling return 0 voidSetCallback( Window* pWindow, SALFRAMEPROC pProc ) diff --git a/vcl/inc/unx/gtk/gtkframe.hxx b/vcl/inc/unx/gtk/gtkframe.hxx index a33a558..8f454df 100644 --- a/vcl/inc/unx/gtk/gtkframe.hxx +++ b/vcl/inc/unx/gtk/gtkframe.hxx @@ -328,6 +328,7 @@ SalX11Screen getXScreenNumber() const { return m_nXScreen; } int GetDisplayScreen() const { return maGeometry.nDisplayScreenNumber; } void updateScreenNumber(); +void StartDragFrame (long x, long y, sal_uInt16 button, sal_uLong nTime); #if GTK_CHECK_VERSION(3,0,0) // only for gtk3 ... diff --git a/vcl/inc/unx/salframe.h b/vcl/inc/unx/salframe.h index c6a8cc3..541d75e 100644 --- a/vcl/inc/unx/salframe.h +++ b/vcl/inc/unx/salframe.h @@ -251,6 +251,8 @@ virtual voidSetScreenNumber( unsigned int ); virtual voidSetApplicationID( const rtl::OUString rWMClass ); +void StartDragFrame (long x, long y, sal_uInt16 button, sal_uLong nTime) ; + // shaped system windows // set clip region to none (- rectangular windows, normal state) virtual voidResetClipRegion(); @@ -265,6 +267,7 @@ /// @internal void setPendingSizeEvent(); + }; #ifdef _SV_SALDISP_HXX diff --git a/vcl/inc/vcl/window.hxx b/vcl/inc/vcl/window.hxx index ccd599a..811a8ee 100644 --- a/vcl/inc/vcl/window.hxx +++ b/vcl/inc/vcl/window.hxx @@ -980,6 +980,8 @@ voidStartAutoScroll( sal_uInt16 nFlags ); voidEndAutoScroll(); +voidStartDragWindow( const MouseEvent rMouseEvent ); + sal_BoolHandleScrollCommand( const CommandEvent rCmd, ScrollBar* pHScrl = NULL, ScrollBar* pVScrl = NULL ); diff --git a/vcl/inc/win/salframe.h b/vcl/inc/win/salframe.h index 54e10bd..d48563d 100644 --- a/vcl/inc/win/salframe.h +++ b/vcl/inc/win/salframe.h @@ -133,6 +133,7 @@ virtual voidBeginSetClipRegion( sal_uIntPtr nRects ); virtual voidUnionClipRegion( long nX, long nY, long nWidth, long nHeight ); virtual voidEndSetClipRegion(); +virtual void StartDragFrame (long x, long y, sal_uInt16 button, sal_uLong nTime) ; }; void ImplSalGetWorkArea( HWND hWnd, RECT *pRect, const RECT *pParentRect ); diff --git a/vcl/source/window/menu.cxx b/vcl/source/window/menu.cxx index a163041..1a4c45e 100644 --- a/vcl/source/window/menu.cxx +++ b/vcl/source/window/menu.cxx @@ -5395,11 +5395,15 @@ { ChangeHighlightItem( nEntry, sal_False ); } -else +else if (pActivePopup) { KillActivePopup(); ChangeHighlightItem( ITEMPOS_INVALID, sal_False ); } +
Change in core[master]: Removing useless SwTableBox_Impl from Writter
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1885 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/85/1885/1 Removing useless SwTableBox_Impl from Writter Change-Id: I2cb471e9b0784673deb75beb7d403b136fbce500 --- M sw/inc/swtable.hxx M sw/source/core/table/swtable.cxx 2 files changed, 31 insertions(+), 87 deletions(-) diff --git a/sw/inc/swtable.hxx b/sw/inc/swtable.hxx index 81f2696..1074aae 100644 --- a/sw/inc/swtable.hxx +++ b/sw/inc/swtable.hxx @@ -53,7 +53,6 @@ class SwUndoTblMerge; class SwUndo; class SwPaM; -class SwTableBox_Impl; class SwUndoTblCpyTbl; class SwBoxSelection; struct SwSaveRowSpan; @@ -391,7 +390,10 @@ SwTableLines aLines; const SwStartNode * pSttNd; SwTableLine *pUpper; -SwTableBox_Impl* pImpl; + +Color *pSaveUserColor, *pSaveNumFmtColor; +long nRowSpan; +bool bDummyFlag; // In case Format contains formulas/values already, // a new one must be created for the new box. @@ -400,7 +402,7 @@ public: TYPEINFO(); -SwTableBox() : pSttNd(0), pUpper(0), pImpl(0) {} +SwTableBox() : pSttNd(0), pUpper(0), pSaveUserColor(0), pSaveNumFmtColor(0), nRowSpan(1), bDummyFlag(false) {} SwTableBox( SwTableBoxFmt*, sal_uInt16 nLines, SwTableLine *pUp = 0 ); SwTableBox( SwTableBoxFmt*, const SwStartNode, SwTableLine *pUp = 0 ); @@ -457,15 +459,15 @@ DECL_FIXEDMEMPOOL_NEWDEL(SwTableBox) // Access on internal data - currently used for the NumFormatter. -inline const Color* GetSaveUserColor() const; -inline const Color* GetSaveNumFmtColor() const; +inline const Color* GetSaveUserColor() const { return pSaveUserColor; } +inline const Color* GetSaveNumFmtColor() const { return pSaveNumFmtColor; } inline void SetSaveUserColor(const Color* p ); inline void SetSaveNumFmtColor( const Color* p ); -long getRowSpan() const; -void setRowSpan( long nNewRowSpan ); -bool getDummyFlag() const; -void setDummyFlag( bool bDummy ); +long getRowSpan() const {return nRowSpan;} +void setRowSpan( long nNewRowSpan ) { nRowSpan = nNewRowSpan;} +bool getDummyFlag() const { return bDummyFlag;} +void setDummyFlag( bool bDummy ) { bDummyFlag = bDummy;} SwTableBox FindStartOfRowSpan( const SwTable, sal_uInt16 nMaxStep = USHRT_MAX ); const SwTableBox FindStartOfRowSpan( const SwTable rTable, diff --git a/sw/source/core/table/swtable.cxx b/sw/source/core/table/swtable.cxx index 466ed90..3b7d192 100644 --- a/sw/source/core/table/swtable.cxx +++ b/sw/source/core/table/swtable.cxx @@ -81,86 +81,18 @@ sal_Bool bChgAlign,sal_uLong nNdPos ); //-- -class SwTableBox_Impl -{ -Color *mpUserColor, *mpNumFmtColor; -long mnRowSpan; -bool mbDummyFlag; - -void SetNewCol( Color** ppCol, const Color* pNewCol ); -public: -SwTableBox_Impl() : mpUserColor(0), mpNumFmtColor(0), mnRowSpan(1), -mbDummyFlag( false ) {} -~SwTableBox_Impl() { delete mpUserColor; delete mpNumFmtColor; } - -const Color* GetSaveUserColor() const { return mpUserColor; } -const Color* GetSaveNumFmtColor() const { return mpNumFmtColor; } -void SetSaveUserColor(const Color* p ) { SetNewCol( mpUserColor, p ); } -void SetSaveNumFmtColor( const Color* p ) { SetNewCol( mpNumFmtColor, p ); } -long getRowSpan() const { return mnRowSpan; } -void setRowSpan( long nNewRowSpan ) { mnRowSpan = nNewRowSpan; } -bool getDummyFlag() const { return mbDummyFlag; } -void setDummyFlag( bool bDummy ) { mbDummyFlag = bDummy; } -}; +static void lcl_SetNewColor(Color** ppCol, const Color* pNewCol); // --- Inlines - -inline const Color* SwTableBox::GetSaveUserColor() const +inline void SwTableBox::SetSaveUserColor(const Color* pNewColor ) { -return pImpl ? pImpl-GetSaveUserColor() : 0; +lcl_SetNewColor(pSaveUserColor, pNewColor); } -inline const Color* SwTableBox::GetSaveNumFmtColor() const +inline void SwTableBox::SetSaveNumFmtColor( const Color* pNewColor ) { -return pImpl ? pImpl-GetSaveNumFmtColor() : 0; -} - -inline void SwTableBox::SetSaveUserColor(const Color* p ) -{ -if( pImpl ) -pImpl-SetSaveUserColor( p ); -else if( p ) -( pImpl = new SwTableBox_Impl ) -SetSaveUserColor( p ); -} - -inline void SwTableBox::SetSaveNumFmtColor( const Color* p ) -{ -if( pImpl ) -pImpl-SetSaveNumFmtColor( p ); -else if( p ) -( pImpl = new SwTableBox_Impl )-SetSaveNumFmtColor( p ); -} - -long SwTableBox::getRowSpan() const -{ -return pImpl ? pImpl-getRowSpan() : 1; -} - -void SwTableBox::setRowSpan( long nNewRowSpan ) -{ -if( !pImpl ) -{ -if( nNewRowSpan == 1 ) -return; -pImpl = new SwTableBox_Impl(); -} -pImpl-setRowSpan( nNewRowSpan ); -} - -bool SwTableBox::getDummyFlag() const -{ -return
Change in core[master]: Resolving crash in wizards fdo#59931 by NULL checking
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1909 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/09/1909/1 Resolving crash in wizards fdo#59931 by NULL checking Change-Id: Iccc3f3b2913f21a3831ce55c706aa4dd1da53ad6 --- M svtools/source/control/roadmap.cxx 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/svtools/source/control/roadmap.cxx b/svtools/source/control/roadmap.cxx index a0239cf..6a23688 100644 --- a/svtools/source/control/roadmap.cxx +++ b/svtools/source/control/roadmap.cxx @@ -700,7 +700,10 @@ SetFont( aFont ); RoadmapTypes::ItemId curItemID = GetCurrentRoadmapItemID(); RoadmapItem* pLabelItem = GetByID( curItemID ); - pLabelItem-ToggleBackgroundColor(rStyleSettings.GetHighlightColor()); +if (pLabelItem != NULL) +{ + pLabelItem-ToggleBackgroundColor(rStyleSettings.GetHighlightColor()); +} Invalidate(); } } -- To view, visit https://gerrit.libreoffice.org/1909 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iccc3f3b2913f21a3831ce55c706aa4dd1da53ad6 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Arnaud Versini arnaud.vers...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Remove fprintf usage from vcl/builder
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1813 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/13/1813/1 Remove fprintf usage from vcl/builder Change-Id: I185cedfaff30063fe0d0deb64eecff8796ac1ff9 --- M vcl/source/window/builder.cxx 1 file changed, 0 insertions(+), 2 deletions(-) diff --git a/vcl/source/window/builder.cxx b/vcl/source/window/builder.cxx index e564823..4596a2c 100644 --- a/vcl/source/window/builder.cxx +++ b/vcl/source/window/builder.cxx @@ -1636,8 +1636,6 @@ pWindow-set_property(rKey.copy(RTL_CONSTASCII_LENGTH(AtkObject::)), rValue); else SAL_WARN(vcl.layout, unhandled atk prop: rKey.getStr()); - -fprintf(stderr, setting atk props on %p\n, pWindow); } } -- To view, visit https://gerrit.libreoffice.org/1813 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I185cedfaff30063fe0d0deb64eecff8796ac1ff9 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Arnaud Versini arnaud.vers...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Remove useless callback in unix socket implementation
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1633 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/33/1633/1 Remove useless callback in unix socket implementation Change-Id: Ibe46e2f1628f4d2e4840429703e0d5a69059a188 --- M sal/osl/unx/socket.c M sal/osl/unx/sockimpl.h 2 files changed, 0 insertions(+), 16 deletions(-) diff --git a/sal/osl/unx/socket.c b/sal/osl/unx/socket.c index 1af9039..a9f3fc0 100644 --- a/sal/osl/unx/socket.c +++ b/sal/osl/unx/socket.c @@ -469,8 +469,6 @@ pSocket-m_Socket = Socket; pSocket-m_nLastError = 0; -pSocket-m_CloseCallback = 0; -pSocket-m_CallbackArg = 0; pSocket-m_nRefCount = 1; #if defined(LINUX) @@ -1466,10 +1464,6 @@ { pSocket-m_nLastError=errno; } - - -pSocket-m_CloseCallback= NULL; -pSocket-m_CallbackArg = NULL; } return pSocket; @@ -1559,12 +1553,6 @@ pSocket-m_bIsAccepting = sal_False; } #endif /* LINUX */ - -/* registrierten Callback ausfuehren */ -if (pSocket-m_CloseCallback != NULL) -{ -pSocket-m_CloseCallback(pSocket-m_CallbackArg); -} nRet=close(nFD); if ( nRet != 0 ) @@ -1905,8 +1893,6 @@ pConnectionSockImpl-m_Socket = Connection; pConnectionSockImpl-m_nLastError = 0; -pConnectionSockImpl-m_CloseCallback= NULL; -pConnectionSockImpl-m_CallbackArg = NULL; #if defined(LINUX) pConnectionSockImpl-m_bIsAccepting = sal_False; diff --git a/sal/osl/unx/sockimpl.h b/sal/osl/unx/sockimpl.h index d2c68b6..353d915 100644 --- a/sal/osl/unx/sockimpl.h +++ b/sal/osl/unx/sockimpl.h @@ -33,8 +33,6 @@ struct oslSocketImpl { int m_Socket; int m_nLastError; -oslCloseCallbackm_CloseCallback; -void* m_CallbackArg; oslInterlockedCount m_nRefCount; #if defined(LINUX) sal_Boolm_bIsAccepting; -- To view, visit https://gerrit.libreoffice.org/1633 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibe46e2f1628f4d2e4840429703e0d5a69059a188 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Arnaud Versini arnaud.vers...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Use less RTTI in PDFParse by adding more virtual functions.
Arnaud Versini has abandoned this change. Change subject: Use less RTTI in PDFParse by adding more virtual functions. .. Patch Set 3: Abandoned -- To view, visit https://gerrit.libreoffice.org/1035 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I0e394f5f28874e66c833adfe6440f138321d6455 Gerrit-PatchSet: 3 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Arnaud Versini arnaud.vers...@gmail.com Gerrit-Reviewer: Arnaud Versini arnaud.vers...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Inlining acquire and release in osl/mutex.
Arnaud Versini has abandoned this change. Change subject: Inlining acquire and release in osl/mutex. .. Patch Set 2: Abandoned -- To view, visit https://gerrit.libreoffice.org/1276 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I6bcbad2697a84449b7038aafdc9a988580104e68 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Arnaud Versini arnaud.vers...@gmail.com Gerrit-Reviewer: Arnaud Versini arnaud.vers...@gmail.com Gerrit-Reviewer: Caolán McNamara caol...@redhat.com Gerrit-Reviewer: Michael Stahl mst...@redhat.com Gerrit-Reviewer: Norbert Thiebaud nthieb...@gmail.com Gerrit-Reviewer: Stephan Bergmann sberg...@redhat.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Revert part of 34e79c19babc0e6cc281025b40635b91dca444f3.
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1389 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/89/1389/1 Revert part of 34e79c19babc0e6cc281025b40635b91dca444f3. undefined reference to `sal_detail_initialize' Change-Id: I92074e108dc405e1484503cb39c8c46b2cf50ce0 --- M sal/Library_sal.mk 1 file changed, 1 insertion(+), 5 deletions(-) -- To view, visit https://gerrit.libreoffice.org/1389 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I92074e108dc405e1484503cb39c8c46b2cf50ce0 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Arnaud Versini arnaud.vers...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Remove useless deprecated rtl/memory.h
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1268 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/68/1268/1 Remove useless deprecated rtl/memory.h Change-Id: Iac156b004464018225bbfda24f0a234f9ebcb19f --- D sal/inc/rtl/memory.h D sal/rtl/source/memory.cxx 2 files changed, 0 insertions(+), 108 deletions(-) -- To view, visit https://gerrit.libreoffice.org/1268 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iac156b004464018225bbfda24f0a234f9ebcb19f Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Arnaud Versini arnaud.vers...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Remove useless getpid implementation on Linux.
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1219 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/19/1219/1 Remove useless getpid implementation on Linux. The new minimal target have a proper getpid implementation. Change-Id: I1cf209d8b4cb651866287c3a682ebd0806ab35b9 --- M sal/osl/unx/system.c 1 file changed, 0 insertions(+), 34 deletions(-) -- To view, visit https://gerrit.libreoffice.org/1219 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1cf209d8b4cb651866287c3a682ebd0806ab35b9 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Arnaud Versini arnaud.vers...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Class MediaDescriptorHelper don't need virtual destructor.
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1220 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/20/1220/1 Class MediaDescriptorHelper don't need virtual destructor. Change-Id: I6711ef712a8a04d6fc8991f7056d1440964832ef --- M chart2/source/inc/MediaDescriptorHelper.hxx 1 file changed, 1 insertion(+), 1 deletion(-) -- To view, visit https://gerrit.libreoffice.org/1220 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6711ef712a8a04d6fc8991f7056d1440964832ef Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Arnaud Versini arnaud.vers...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Mark rtl_*memory as deprecated
Arnaud Versini has restored this change. Change subject: Mark rtl_*memory as deprecated .. Patch Set 1: Restored Restore for a 4.0 integration -- To view, visit https://gerrit.libreoffice.org/865 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: restore Gerrit-Change-Id: I0e5e85d6b23961baa9ef3ed4247e39497bb063d7 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Arnaud Versini arnaud.vers...@gmail.com Gerrit-Reviewer: Niko Rönkkö ron...@iki.fi Gerrit-Reviewer: Norbert Thiebaud nthieb...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Use memcmp instead of rtl_compareMemory in svtools
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1034 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/34/1034/1 Use memcmp instead of rtl_compareMemory in svtools Change-Id: Id051a39774446595b5082316a470c23246de8124 --- M svtools/source/graphic/graphic.cxx 1 file changed, 2 insertions(+), 1 deletion(-) -- To view, visit https://gerrit.libreoffice.org/1034 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id051a39774446595b5082316a470c23246de8124 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Arnaud Versini arnaud.vers...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Use less RTTI in PDFParse by adding more virtual functions.
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1035 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/35/1035/1 Use less RTTI in PDFParse by adding more virtual functions. Change-Id: I0e394f5f28874e66c833adfe6440f138321d6455 --- M sdext/source/pdfimport/inc/pdfparse.hxx M sdext/source/pdfimport/pdfparse/pdfentries.cxx M sdext/source/pdfimport/pdfparse/pdfparse.cxx 3 files changed, 76 insertions(+), 37 deletions(-) -- To view, visit https://gerrit.libreoffice.org/1035 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0e394f5f28874e66c833adfe6440f138321d6455 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Arnaud Versini arnaud.vers...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Update dtrans commented code to use string.h function instea...
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1025 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/25/1025/1 Update dtrans commented code to use string.h function instead of rtl/memory Change-Id: I244e436086746420cc66b0ed7d59bfcdc6606076 --- M dtrans/source/win32/dtobj/FmtFilter.cxx 1 file changed, 3 insertions(+), 3 deletions(-) -- To view, visit https://gerrit.libreoffice.org/1025 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I244e436086746420cc66b0ed7d59bfcdc6606076 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Arnaud Versini arnaud.vers...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Fix fdo#56603 by NULL pointer checking in SwDrawTextShell::E...
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/984 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/84/984/1 Fix fdo#56603 by NULL pointer checking in SwDrawTextShell::Execute Change-Id: I2dffbac1450682e4d116f10ca86a2837514f70a4 --- M sw/source/ui/shells/drwtxtex.cxx 1 file changed, 5 insertions(+), 2 deletions(-) -- To view, visit https://gerrit.libreoffice.org/984 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2dffbac1450682e4d116f10ca86a2837514f70a4 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Arnaud Versini arnaud.vers...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Change in core[libreoffice-3-6]: Fix fdo#56603 by NULL pointer checking in SwDrawTextShell::E...
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/985 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/85/985/1 Fix fdo#56603 by NULL pointer checking in SwDrawTextShell::Execute Change-Id: I98f246b2bafcf2669a8f6c3ec4c86ccee56519bf Reviewed-on: https://gerrit.libreoffice.org/984 Reviewed-by: Norbert Thiebaud nthieb...@gmail.com Tested-by: Norbert Thiebaud nthieb...@gmail.com --- M sw/source/ui/shells/drwtxtex.cxx 1 file changed, 5 insertions(+), 2 deletions(-) -- To view, visit https://gerrit.libreoffice.org/985 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I98f246b2bafcf2669a8f6c3ec4c86ccee56519bf Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: libreoffice-3-6 Gerrit-Owner: Arnaud Versini arnaud.vers...@gmail.com Gerrit-Reviewer: Norbert Thiebaud nthieb...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Remove commented code from dtrans
Arnaud Versini has abandoned this change. Change subject: Remove commented code from dtrans .. Patch Set 2: Abandoned keep it in place for a future uncomment of this code. -- To view, visit https://gerrit.libreoffice.org/962 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I1ef4abb5b561107df257279708f619a1715e72c2 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Arnaud Versini arnaud.vers...@gmail.com Gerrit-Reviewer: Norbert Thiebaud nthieb...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] Use memcpy instead of rtl_copyMemory in ucb
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/961 Approvals: Arnaud Versini: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/961 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1bdb02c6d607a10fee03d3044bad20cb811e9939 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Arnaud Versini arnaud.vers...@gmail.com Gerrit-Reviewer: Arnaud Versini arnaud.vers...@gmail.com Gerrit-Reviewer: Norbert Thiebaud nthieb...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Better way to initialize SwNode
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/960 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/60/960/1 Better way to initialize SwNode Change-Id: I6bc397d9ecd44975ebfa58014c6fe7cd470e4ada --- M sw/source/core/docnode/node.cxx 1 file changed, 23 insertions(+), 27 deletions(-) -- To view, visit https://gerrit.libreoffice.org/960 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6bc397d9ecd44975ebfa58014c6fe7cd470e4ada Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Arnaud Versini arnaud.vers...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Remove commented code from dtrans
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/962 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/62/962/1 Remove commented code from dtrans Change-Id: I1ef4abb5b561107df257279708f619a1715e72c2 --- M dtrans/source/win32/dtobj/FmtFilter.cxx 1 file changed, 0 insertions(+), 110 deletions(-) -- To view, visit https://gerrit.libreoffice.org/962 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1ef4abb5b561107df257279708f619a1715e72c2 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Arnaud Versini arnaud.vers...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Use memcpy instead of rtl_copyMemory in ucb
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/961 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/61/961/1 Use memcpy instead of rtl_copyMemory in ucb Change-Id: I1bdb02c6d607a10fee03d3044bad20cb811e9939 --- M ucb/source/ucp/webdav/SerfInputStream.cxx M ucb/source/ucp/webdav/SerfSession.cxx 2 files changed, 4 insertions(+), 4 deletions(-) -- To view, visit https://gerrit.libreoffice.org/961 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1bdb02c6d607a10fee03d3044bad20cb811e9939 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Arnaud Versini arnaud.vers...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Mark rtl_*memory as deprecated
Arnaud Versini has abandoned this change. Change subject: Mark rtl_*memory as deprecated .. Patch Set 1: Abandoned -- To view, visit https://gerrit.libreoffice.org/865 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I0e5e85d6b23961baa9ef3ed4247e39497bb063d7 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Arnaud Versini arnaud.vers...@gmail.com Gerrit-Reviewer: Norbert Thiebaud nthieb...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] More efficient way to initialize SwDoc
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/894 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/94/894/1 More efficient way to initialize SwDoc Change-Id: Icde740ea12e8839b0a4c8e0317143dbe2157a964 --- M sw/source/core/doc/docnew.cxx 1 file changed, 68 insertions(+), 66 deletions(-) -- To view, visit https://gerrit.libreoffice.org/894 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Icde740ea12e8839b0a4c8e0317143dbe2157a964 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Arnaud Versini arnaud.vers...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Cleanup and simplification of process.cxx
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/868 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/68/868/1 Cleanup and simplification of process.cxx Change-Id: I2bbc2763eca7c878ead2a325589d8c4bb9210bda --- M sal/osl/unx/process.cxx 1 file changed, 11 insertions(+), 82 deletions(-) -- To view, visit https://gerrit.libreoffice.org/868 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2bbc2763eca7c878ead2a325589d8c4bb9210bda Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Arnaud Versini arnaud.vers...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Mark rtl_*memory as deprecated
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/865 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/65/865/1 Mark rtl_*memory as deprecated Change-Id: I0e5e85d6b23961baa9ef3ed4247e39497bb063d7 --- M sal/inc/rtl/memory.h 1 file changed, 6 insertions(+), 0 deletions(-) -- To view, visit https://gerrit.libreoffice.org/865 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0e5e85d6b23961baa9ef3ed4247e39497bb063d7 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Arnaud Versini arnaud.vers...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Replace usage of rtl_*Memory with equivalent from string.h
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/732 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/32/732/1 Replace usage of rtl_*Memory with equivalent from string.h Change-Id: I477532cd14cb362853b800746968469ec32cbed7 --- M accessibility/source/standard/vclxaccessibletoolbox.cxx M animations/source/animcore/animcore.cxx M basctl/source/dlged/dlged.cxx M basebmp/source/bitmapdevice.cxx M basegfx/inc/basegfx/raster/bpixelraster.hxx M basegfx/inc/basegfx/raster/bzpixelraster.hxx M basic/source/basmgr/basmgr.cxx M basic/source/runtime/iosys.cxx M basic/source/uno/scriptcont.cxx M binaryurp/source/writer.cxx M bridges/source/jni_uno/nativethreadpool.cxx M canvas/source/directx/dx_9rm.cxx M canvas/source/directx/dx_surfacebitmap.cxx M canvas/source/null/null_canvasfont.cxx M chart2/source/controller/main/ChartRenderer.cxx M chart2/source/model/main/ChartModel.cxx M chart2/source/view/main/ChartView.cxx M codemaker/source/codemaker/global.cxx M cppu/source/typelib/static_types.cxx M cppu/source/uno/eq.hxx M dbaccess/source/core/api/RowSet.cxx M dbaccess/source/core/api/SingleSelectQueryComposer.cxx M dbaccess/source/core/api/TableDeco.cxx M dbaccess/source/core/api/querycomposer.cxx M dbaccess/source/core/api/querydescriptor.cxx M dbaccess/source/core/api/table.cxx M dbaccess/source/core/dataaccess/ContentHelper.cxx M dbaccess/source/core/dataaccess/databasecontext.cxx M dbaccess/source/ui/browser/sbagrid.cxx M dbaccess/source/ui/querydesign/JoinExchange.cxx M desktop/source/deployment/misc/dp_misc.cxx M desktop/source/deployment/registry/configuration/dp_configuration.cxx M desktop/source/pkgchk/unopkg/unopkg_cmdenv.cxx M dtrans/source/win32/dtobj/FmtFilter.cxx M dtrans/source/win32/misc/ImplHelper.cxx M dtrans/source/win32/workbench/test_wincb.cxx M editeng/source/uno/unofield.cxx M editeng/source/uno/unotext.cxx M extensions/source/ole/oleobjw.cxx M extensions/source/update/feed/updatefeed.cxx M extensions/workben/testpgp.cxx M forms/qa/integration/forms/CellBinding.java M forms/qa/integration/forms/DocumentType.java M forms/qa/integration/forms/DocumentViewHelper.java M forms/qa/integration/forms/FormControlTest.java M forms/qa/integration/forms/RadioButtons.java M forms/qa/org/openoffice/xforms/Instance.java M forms/source/component/Columns.cxx M forms/source/component/imgprod.cxx M forms/source/misc/InterfaceContainer.cxx M forms/source/misc/limitedformats.cxx M forms/source/richtext/parametrizedattributedispatcher.cxx M forms/source/richtext/richtextcontrol.cxx M forms/source/richtext/richtextimplcontrol.hxx M forms/source/richtext/richtextmodel.cxx M forms/source/solar/component/navbarcontrol.cxx M framework/source/fwi/uielement/constitemcontainer.cxx M framework/source/fwi/uielement/rootitemcontainer.cxx M jvmfwk/source/framework.cxx M lotuswordpro/source/filter/xfilter/xfbase64.cxx M lotuswordpro/source/filter/xfilter/xfcolor.cxx M lotuswordpro/source/filter/xfilter/xfdate.cxx M lotuswordpro/source/filter/xfilter/xflineheight.hxx M lotuswordpro/source/filter/xfilter/xfutil.hxx M package/source/zipapi/MemoryByteGrabber.hxx M rdbmaker/inc/codemaker/registry.hxx M rdbmaker/source/rdbmaker/typeblop.cxx M registry/source/regimpl.cxx M reportdesign/source/core/api/ReportDefinition.cxx M reportdesign/source/core/api/Section.cxx M rsc/source/tools/rsctools.cxx M sal/inc/rtl/ustring.hxx M sal/osl/w32/pipe.c M sal/osl/w32/profile.cxx M sal/rtl/source/byteseq.cxx M sal/rtl/source/cipher.cxx M sal/rtl/source/digest.cxx M sal/rtl/source/strbuf.cxx M sal/rtl/source/string.cxx M sal/rtl/source/ustrbuf.cxx M sal/rtl/source/ustring.cxx M sdext/source/pdfimport/filterdet.cxx M sdext/source/pdfimport/pdfparse/pdfentries.cxx M sdext/source/pdfimport/pdfparse/pdfparse.cxx M sfx2/source/control/thumbnailviewacc.cxx M sfx2/source/explorer/nochaos.cxx M starmath/source/mathmlexport.cxx M starmath/source/mathmlimport.cxx M starmath/source/unomodel.cxx M store/source/store.cxx M store/workben/t_base.cxx M store/workben/t_file.cxx M svtools/source/control/valueacc.cxx M svtools/source/filter/filter.cxx M svtools/source/graphic/graphic.cxx M svtools/source/misc/transfer.cxx M svx/source/accessibility/AccessibleShape.cxx M svx/source/dialog/dlgctrl.cxx M svx/source/fmcomp/fmgridif.cxx M svx/source/fmcomp/gridcell.cxx M svx/source/unodraw/unopage.cxx M svx/source/unodraw/unoshap2.cxx M svx/source/unodraw/unoshap3.cxx M svx/source/unodraw/unoshape.cxx M sw/source/core/undo/undraw.cxx M toolkit/inc/toolkit/helper/macros.hxx M toolkit/source/awt/vclxbitmap.cxx M toolkit/source/awt/vclxcontainer.cxx M toolkit/source/awt/vclxdevice.cxx M toolkit/source/awt/vclxfont.cxx M toolkit/source/awt/vclxgraphics.cxx M toolkit/source/awt/vclxmenu.cxx M toolkit/source/awt/vclxpointer.cxx M toolkit/source/awt/vclxprinter.cxx M toolkit/source/awt/vclxregion.cxx M toolkit/source/awt/vclxtoolkit.cxx M toolkit/source/awt/vclxwindow.cxx M
Replace usage of rtl_*Memory with equivalent from string.h
Arnaud Versini has abandoned this change. Change subject: Replace usage of rtl_*Memory with equivalent from string.h .. Patch Set 1: Abandoned -- To view, visit https://gerrit.libreoffice.org/732 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I477532cd14cb362853b800746968469ec32cbed7 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Arnaud Versini arnaud.vers...@gmail.com Gerrit-Reviewer: Arnaud Versini arnaud.vers...@gmail.com Gerrit-Reviewer: Norbert Thiebaud nthieb...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Remove unused member SwDoc::pMacroTable
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/680 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/80/680/1 Remove unused member SwDoc::pMacroTable Change-Id: Ic09b960b675d674a16f7f252ed2a974c4e25505b --- M sw/inc/doc.hxx M sw/source/core/doc/docnew.cxx 2 files changed, 0 insertions(+), 4 deletions(-) -- To view, visit https://gerrit.libreoffice.org/680 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic09b960b675d674a16f7f252ed2a974c4e25505b Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Arnaud Versini arnaud.vers...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice