[PATCH] cppcheck : redundantCondition. In this case, it seems to be ...

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/779 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/79/779/1 cppcheck : redundantCondition. In this case, it seems to be a typo. Changed the redundant check against fRate

[PATCH] cppcheck: unreadVariable.

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/781 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/81/781/1 cppcheck: unreadVariable. aLangMap is a std::map that is written but never used, so drop it. Change-Id:

[PATCH] cppcheck: Unused variable

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/782 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/82/782/1 cppcheck: Unused variable Defined the aDicLangInUse within the #ifdef block where it is used. Change-Id:

[PATCH] cppcheck: unreadVariable

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/832 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/32/832/1 cppcheck: unreadVariable Defined the aStr within the #ifdef block where it is used. Change-Id:

[PATCH] cppcheck: clarifyCalculation

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/833 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/33/833/1 cppcheck: clarifyCalculation Use () to clarify the order of the operator + minor formatting Change-Id:

[PATCH] Simplify and speed-up logic for copying data

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2523 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/23/2523/1 Simplify and speed-up logic for copying data Change-Id: I790ef30075d74c6bd7a049750dfb555d36d77542

[PATCH] cppCheck: Variable is reassigned a value before the old one ...

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2014 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/14/2014/1 cppCheck: Variable is reassigned a value before the old one has been used. Change-Id:

[PATCH] Remove useless function calls.

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2015 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/15/2015/1 Remove useless function calls. nPos has already been computed the 3 lines above. No need to recompute it.

[PATCH] cppCheck: Remove some 'redundantAssignment'

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/938 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/38/938/1 cppCheck: Remove some 'redundantAssignment' These iterators are already assigned with the same value a few lines

[PATCH] cppCheck: unusedStructMember

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/943 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/43/943/1 cppCheck: unusedStructMember Kill unused class member and struct definition in desktop/source/splash/splash.cxx

[PATCH] cppCheck: avoid obvious 'redundantAssignment'

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/944 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/44/944/1 cppCheck: avoid obvious 'redundantAssignment' Change-Id: Ib819c1664dc1643b0d8bf9f516fc0b328f201bff

[PATCH] cppCheck: Various clean-up

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/983 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/83/983/1 cppCheck: Various clean-up xfdrawstyle.cxx: correct a copy/paste typo in constructor number.cxx: remove an unused

[PATCH] cppCheck: Possible inefficient checking for emptiness

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/986 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/86/986/1 cppCheck: Possible inefficient checking for emptiness Change-Id: Ief04fa81abbba9e66353c57eb586f864c37deed0

[PATCH] cppCheck: Various clean-up

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/996 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/96/996/1 cppCheck: Various clean-up mailconfigpapge: shouldn't it be a logical AND instead of a bit-wise operation ?

[PATCH] cppCheck: Unused variable and Redundant assignment

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1005 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/05/1005/1 cppCheck: Unused variable and Redundant assignment Change-Id: I67084c1cb9dc23eb77787d2a6d57a5b70126873c

[PATCH] Cut and paste typo ?

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1009 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/09/1009/1 Cut and paste typo ? Corrected according to surrounding code. I don't know if or when this code is called.

[PATCH] cppCheck: redundant assignment and Possible null pointer der...

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1015 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/15/1015/1 cppCheck: redundant assignment and Possible null pointer dereference. Test against pOldFormat is useless

[PATCH] s/aIter++/++aIter/

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1016 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/16/1016/1 s/aIter++/++aIter/ Change-Id: Id80013cbab8f1633db59d2d4492c7363224871bd Signed-off-by: jailletc36

[PATCH] cppCheck: remove dead assignment

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1018 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/18/1018/1 cppCheck: remove dead assignment Change-Id: Iea8388c16de3399853dc384e7df6bfcc92170ea2 Signed-off-by: jailletc36

[PATCH] cppCheck: remove dead assignment + a little formatting

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1019 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/19/1019/1 cppCheck: remove dead assignment + a little formatting Change-Id: I78f7f7ae7373e00e0750abc4566c71a8b9c1640a

[PATCH] cppCheck: clarifyCondition

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1031 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/31/1031/1 cppCheck: clarifyCondition Remove some warnings about: Boolean result is used in bitwise operation

[PATCH] cppCheck: invalidPrintfArgType + minor formatting when appro...

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1032 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/32/1032/1 cppCheck: invalidPrintfArgType + minor formatting when appropriate Change-Id:

[PATCH] Turn some memmove into memcpy when it is safe to do so.

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1033 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/33/1033/1 Turn some memmove into memcpy when it is safe to do so. Most of the changes are related to newly allocated

cppCheck: invalidPrintfArgType + minor formatting when appro...

Christophe JAILLET has abandoned this change. Change subject: cppCheck: invalidPrintfArgType + minor formatting when appropriate .. Patch Set 1: Abandoned Will provide separate patches in the future. -- To view, visit

[PATCH] cppCheck: remove dead assignment and dead variables

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1153 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/53/1153/1 cppCheck: remove dead assignment and dead variables Change-Id: I3f0eae93be7f362ff70f8a544c46cd500d2ca50c

[PATCH] cppCheck: Possible NULL pointer dereference

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1154 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/54/1154/1 cppCheck: Possible NULL pointer dereference Change-Id: I1d740eea5c26e0515835c4dc6199a387b6fa8f6b Signed-off-by:

[PATCH] Remove useless comment.

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1169 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/69/1169/1 Remove useless comment. Change-Id: Ica37d08671700adea3b0d48c1d72b6d26f56dcfb Signed-off-by: jailletc36