Re: need help to fetch stable LibreOffice 5.0 code

2015-08-19 Thread Daniel
if it doesn't make sense. Best, Daniel signature.asc Description: Digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: make_shared underused

2015-10-26 Thread Daniel
constructor. Daniel signature.asc Description: Digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Compile to Assembly?

2015-11-15 Thread Daniel
out there. Cheers, Daniel signature.asc Description: Digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice-commits] core.git: editeng: Eliminate unecessary padding in classes

2015-11-04 Thread Daniel
the 3 bitfields to regular boolean members? I didn't like the bitfield, but there was one already there, and I didn't know if it was there for a reason. I appologize if I caused more problems than I fixed :-) Best, Daniel signature.asc Description: Digital signature

Re: [WIP] Remove boost dependency in sc/source/filter/excel/excimp8.cxx

2015-09-13 Thread Daniel
combining what you had and the above random points. Best, Daniel On Sun, Sep 13, 2015 at 10:06:05AM +0200, Albert Thuswaldner wrote: > Hi, > It would be great if I could get some advice on how to move forward on > removing more of the boost dependency. > > Originally I was working on th

Report from llvms static analysis tool

2015-10-04 Thread Daniel
allow". And don't judge me for how terrible and cheesy my github page is :-) #NotAWebDev #NoArtisticSkillz Best, Daniel signature.asc Description: Digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freed

Re: Report from llvms static analysis tool

2015-10-05 Thread Daniel
> the problem is, should a legacy assertion be converted to assert or to > SAL_WARN. that is easy to answer in some cases (like when a pointer is > asserted not to be null that is then unconditionally dereferenced), but > in general requires some thought about whether it is trying to detect an >

Re: Report from llvms static analysis tool

2015-10-05 Thread Daniel
/qa/extras/inc/swmodeltestbase.hxx:14:10: fatal error: 'com/sun/star/frame/Desktop.hpp' file not found #include ^ 1 error generated. Cheers, Daniel signature.asc Description: Digital signature ___ LibreOffice mailing list LibreOffi

Re: Report from llvms static analysis tool

2015-10-05 Thread Daniel
k? I also wouldn't mind adding this to the list of "long term fixes" I'm working on :-) Cheers, Daniel signature.asc Description: Digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.o

[Libreoffice-commits] core.git: cui/source cui/uiconfig

2017-09-25 Thread Daniel
: commit 4020945651b4f3c636980e2103db440b5c55459c Author: Daniel <danielfaleirosi...@gmail.com> Date: Sun Sep 24 17:55:19 2017 -0300 tdf#111739 fix Selecting a custom character as a bullet symbol insertion Change-Id: I638ef2467f27bd6214cde092be5a3055fd539ebc Reviewed-on:

[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - svx/source

2017-11-30 Thread Daniel
svx/source/table/tablecontroller.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit cf715c7c60bd37d69f6fd6cbcb55e320503d9e36 Author: Daniel <danielfaleirosi...@gmail.com> Date: Wed Nov 29 00:26:43 2017 -0200 tdf#111773 tdf#111780 Fix selection after

[Libreoffice-commits] core.git: svx/source

2017-11-30 Thread Daniel
svx/source/table/tablecontroller.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 9b5062a3eeed6b94a2020b97f6dab9316af5d357 Author: Daniel <danielfaleirosi...@gmail.com> Date: Wed Nov 29 00:26:43 2017 -0200 tdf#111773 tdf#111780 Fix selection after

[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - sc/source

2017-12-04 Thread Daniel
sc/source/core/data/table4.cxx | 67 - 1 file changed, 47 insertions(+), 20 deletions(-) New commits: commit 87efbdb1ae5a73d081667e10f1571f1e523c1b9c Author: Daniel <danielfaleirosi...@gmail.com> Date: Sat Nov 25 01:48:18 2017 -0200 tdf#

[Libreoffice-commits] core.git: sc/source

2017-12-03 Thread Daniel
sc/source/core/data/table4.cxx | 67 - 1 file changed, 47 insertions(+), 20 deletions(-) New commits: commit 76c1e7287e29a2a2739fce895fbded3c04764bca Author: Daniel <danielfaleirosi...@gmail.com> Date: Sat Nov 25 01:48:18 2017 -0200 tdf#

[Libreoffice-commits] core.git: sd/source

2018-05-06 Thread Daniel
sd/source/core/sdpage.cxx | 68 ++ 1 file changed, 51 insertions(+), 17 deletions(-) New commits: commit 6a8ae73b4c23ec80f97bcafd8b9a5e8f14b2abc7 Author: Daniel <danielfaleirosi...@gmail.com> Date: Sun Apr 29 14:51:08 2018 -0300 tdf#993

[Libreoffice-commits] core.git: sw/inc sw/source

2018-05-06 Thread Daniel
sw/inc/viewsh.hxx |5 +++-- sw/source/core/view/vprint.cxx| 13 +++-- sw/source/uibase/uno/unotxdoc.cxx |2 +- 3 files changed, 11 insertions(+), 9 deletions(-) New commits: commit 08441d466dd70c203a519a133aaf1a5997adbbd3 Author: Daniel <danielfaleir

[Libreoffice-commits] core.git: include/svx svx/source

2018-05-21 Thread Daniel
include/svx/sdr/table/tablecontroller.hxx |1 + svx/source/table/tablecontroller.cxx | 12 +++- 2 files changed, 12 insertions(+), 1 deletion(-) New commits: commit 7c5f1caa775e6a3d178c7dae7171d3fca2874635 Author: Daniel <danielfaleirosi...@gmail.com> Date: Thu May 17

[Libreoffice-commits] core.git: Branch 'feature/print_revamp' - vcl/inc vcl/source vcl/uiconfig

2018-06-14 Thread Daniel
vcl/inc/printdlg.hxx | 23 + vcl/source/window/printdlg.cxx | 616 - vcl/uiconfig/ui/printdialog.ui | 15 3 files changed, 641 insertions(+), 13 deletions(-) New commits: commit e0c9aaf19bed5a38ecb2748008d02b5c88a7ff26 Author: Daniel Date

[Libreoffice-commits] core.git: Branch 'feature/print_revamp' - vcl/inc vcl/source vcl/uiconfig

2018-06-07 Thread Daniel
commits: commit 1d5edc87667625d8b97c7cc9f59cbd2c8c96fe36 Author: Daniel Date: Sat Jun 2 19:40:52 2018 -0300 New Print Dialog Design Change-Id: Ib92a16ccfab70b84ffea07970a694800ecc16d07 Reviewed-on: https://gerrit.libreoffice.org/55237 Tested-by: Jenkins Reviewed

[Libreoffice-commits] core.git: Branch 'feature/print_revamp' - vcl/inc vcl/source vcl/uiconfig

2018-05-29 Thread Daniel
b9c297021d2b95b67fa2ab2842f0f4b344338129 Author: Daniel Date: Tue May 15 22:58:38 2018 -0300 tdf#67905 adds an option to disable print preview in print dialog Change-Id: Id6dd1724a1b8f61d94f0685f63d28b3cff19988f diff --git a/vcl/inc/printdlg.hxx b/vcl/inc/printdlg.hxx index b16d91cad1f6

[Libreoffice-commits] core.git: Branch 'feature/print_revamp' - basctl/inc basctl/source sc/inc sc/source sd/inc sd/source sw/inc sw/source vcl/uiconfig

2018-06-25 Thread Daniel
| 40 10 files changed, 103 insertions(+), 109 deletions(-) New commits: commit c75876410c6617f65c63b1d8d65ffb2cdf6fca51 Author: Daniel Date: Thu Jun 14 23:29:34 2018 -0300 Configures page range in print dialog Change-Id

[Libreoffice-commits] core.git: include/svx svx/source

2018-03-28 Thread Daniel
include/svx/tbcontrl.hxx |1 + svx/source/tbxctrls/tbcontrl.cxx |9 - 2 files changed, 9 insertions(+), 1 deletion(-) New commits: commit bdd7abf56676732f8ce4fd04bea5c72758f1ec3b Author: Daniel <danielfaleirosi...@gmail.com> Date: Sat Mar 24 00:13:26 2018 -0300

[Libreoffice] EasyHack: Improved bug filing form / flow

2011-02-17 Thread Daniel Neel
Improved bug filing form / flow *Background:* We have a lot of very poor quality bugs. Worse, our bug reporting interface is pretty terrible - ie. bugzilla. It would be wonderful to have a more easy-to-use, and attractive flow, that guided people to provide - all the information we need,

Re: [Libreoffice] EasyHack: Improved bug filing form / flow

2011-02-18 Thread Daniel Neel
On Fri, Feb 18, 2011 at 2:11 AM, Jonathan Aquilina eagles051...@gmail.com wrote: Daniel just a suggestion if its not already available in the current method. I am not sure if you have worked with launchpad the ubuntu bug tracker, but with it you have the ability to assign a bug to a team

Re: [Libreoffice] EasyHack: Improved bug filing form / flow

2011-02-18 Thread Daniel Neel
anyone have more suggestions by chance to improve this? I'm definitely interested :). Thanks, Daniel On Fri, Feb 18, 2011 at 7:58 PM, Daniel Neel dneel...@gmail.com wrote: On Fri, Feb 18, 2011 at 2:11 AM, Jonathan Aquilina eagles051...@gmail.com wrote: Daniel just a suggestion if its

Re: [Libreoffice] EasyHack: Improved bug filing form / flow

2011-02-24 Thread Daniel Neel
, an attachment of the file, and maybe a link to this mailing list conversation? I look forward to helping out LO in other ways soon. Thanks, Daniel On Mon, Feb 21, 2011 at 1:15 PM, Michael Meeks michael.me...@novell.comwrote: Hi Daniel, On Fri, 2011-02-18 at 22:32 -0500, Daniel Neel wrote

[Libreoffice-commits] .: Branch 'feature/gsoc-calc-perf2' - 2 commits - sc/qa sc/source

2012-07-19 Thread Daniel Bankston
: commit 7c7bbed45a883d10002879914e0fcbe84a0b1100 Author: Daniel Bankston daniel.e.banks...@gmail.com Date: Thu Jul 19 17:26:35 2012 -0500 Display blank cell instead of zero in matrix cells with blank text result Change-Id: Id9d17403717e42b91b1f45b0a081e2fb5a27c06e diff --git a/sc/source

[Libreoffice-commits] .: 2 commits - sc/qa sc/source

2012-07-19 Thread Daniel Bankston
: commit 61c39eae570d6d6040b65bfe93127b30e6080cc8 Author: Daniel Bankston daniel.e.banks...@gmail.com Date: Thu Jul 19 17:26:35 2012 -0500 Display blank cell instead of zero in matrix cells with blank text result Change-Id: Id9d17403717e42b91b1f45b0a081e2fb5a27c06e diff --git a/sc/source

[Libreoffice-commits] .: Branch 'feature/gsoc-calc-perf2' - mdds/0001-help-compiler-select-the-right-overload-of-vector-in.patch mdds/makefile.mk

2012-07-20 Thread Daniel Bankston
mdds/0001-help-compiler-select-the-right-overload-of-vector-in.patch | 52 ++ mdds/makefile.mk |5 2 files changed, 56 insertions(+), 1 deletion(-) New commits: commit ee1e3004506083a86b6bf9c3dabd21427cf8e935 Author: David

[Libreoffice-commits] .: Branch 'feature/gsoc-calc-perf2' - 4 commits - sc/source

2012-07-21 Thread Daniel Bankston
|3 +-- 5 files changed, 11 insertions(+), 23 deletions(-) New commits: commit 1283ad599c6ecb8dbfaefd1d74d948de9c2def96 Author: Daniel Bankston daniel.e.banks...@gmail.com Date: Sat Jul 21 03:03:42 2012 -0500 Use correct date/datetime format for formula cells and value cells

[Libreoffice-commits] .: 3 commits - sc/source

2012-07-21 Thread Daniel Bankston
(-) New commits: commit 5a14b6bb09bd054589deec1a58d96fe5fc562f0c Author: Daniel Bankston daniel.e.banks...@gmail.com Date: Sat Jul 21 03:03:42 2012 -0500 Use correct date/datetime format for formula cells and value cells. Change-Id: I37816eba909caa71aca95c5181daeea1751b6c5a diff --git

[Libreoffice-commits] .: Branch 'feature/gsoc-calc-perf2' - sc/inc sc/source

2012-07-28 Thread Daniel Bankston
/source/ui/docshell/docsh.cxx |2 +- 7 files changed, 20 insertions(+), 15 deletions(-) New commits: commit f4b6cc0d3d7bb762f3778c3230ec17c25a991f3e Author: Daniel Bankston daniel.e.banks...@gmail.com Date: Sat Jul 28 03:24:57 2012 -0500 Improve matrix import performance without breaking

Re: LibO master fails to build after pull

2012-07-28 Thread Daniel Bankston
=42c58d9ce4f33b047feb1e94e60f165360d96209 You may have pulled before David pushed it. If I remember correctly, after getting that commit, you'll need to make clean and make within sc. Then you can try top level make again. --Daniel Bankston http://cgit.freedesktop.org/libreoffice/core/commit/?id

RE: [Libreoffice-ux-advise] [PATCH] fix bug 51231, but...

2012-07-30 Thread Daniel Mania
in those features, but intelligent software is _always_ plain wrong, wrong and wrong and keep it simple is the best approach to usability. The user should not have to anticipate what the software might or might not do depending on different situations! Greetings, Daniel M

[Libreoffice-commits] .: Branch 'feature/gsoc-calc-perf2' - sc/source

2012-07-31 Thread Daniel Bankston
sc/source/filter/xml/xmlcelli.cxx | 47 -- sc/source/filter/xml/xmlcelli.hxx |2 + 2 files changed, 27 insertions(+), 22 deletions(-) New commits: commit 17e8bcbca919b3ca7cac2bf9c5bac4d4ef504232 Author: Daniel Bankston daniel.e.banks...@gmail.com Date

[Libreoffice-commits] .: Branch 'feature/gsoc-calc-perf2' - sc/source

2012-07-31 Thread Daniel Bankston
sc/source/filter/oox/workbookhelper.cxx |8 1 file changed, 8 insertions(+) New commits: commit 3c95101f43a8abb2a644fa2bdb3468cda5e459b0 Author: Daniel Bankston daniel.e.banks...@gmail.com Date: Tue Jul 31 06:43:06 2012 -0500 Prevent broadcasts to gain xlsx formula import

[Libreoffice-commits] .: sc/source

2012-07-31 Thread Daniel Bankston
sc/source/filter/xml/xmlcelli.cxx | 47 -- sc/source/filter/xml/xmlcelli.hxx |2 + 2 files changed, 27 insertions(+), 22 deletions(-) New commits: commit cc5b8609490637e3a19761a965af9fdd47310954 Author: Daniel Bankston daniel.e.banks...@gmail.com Date

[Libreoffice-commits] .: Branch 'feature/gsoc-calc-perf2' - 2 commits - sc/inc sc/source

2012-08-07 Thread Daniel Bankston
/source/filter/oox/workbookhelper.cxx | 20 +-- 6 files changed, 65 insertions(+), 18 deletions(-) New commits: commit 2892dab25d266ff81162ed91744b89f26299a004 Author: Daniel Bankston daniel.e.banks...@gmail.com Date: Tue Aug 7 04:21:54 2012 -0500 Convert xlsx unnamed database range

[PATCH] a few lines of German translation

2012-08-09 Thread Daniel Herde
Please review the translation of the german comments in some of the source files in dbaccess/source. More will follow. Thanks, Daniel. From 4b9ecc71b6d55cfae7c68ce56f8a7634197872b3 Mon Sep 17 00:00:00 2001 From: Daniel Herde dan...@dher.de Date: Thu, 9 Aug 2012 18:25:53 +0200 Subject: [PATCH

Re: [PATCH] a few lines of German translation

2012-08-09 Thread Daniel Herde
previous mail (0001-translated-the-german-comments-in-a-bunch-of-source-.patch) is licensed under LGPLv3+ and MPL. All my future contributions to libreoffice are submitted unter these licenses, unless stated otherwise. Best regards, Daniel. ___ LibreOffice

[PATCH] more german translations in dbaccess

2012-08-10 Thread Daniel Herde
Hi, here are some more translations of german comments. Have a nice friday evening, Daniel. 0001-additional-translations-of-german-comments-in-dbacce.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http

[Libreoffice-commits] .: Branch 'feature/gsoc-calc-perf' - sc/source

2012-05-24 Thread Daniel Bankston
sc/source/filter/xml/xmlcelli.cxx | 119 +- sc/source/filter/xml/xmlsubti.cxx |3 sc/source/filter/xml/xmlsubti.hxx |2 3 files changed, 56 insertions(+), 68 deletions(-) New commits: commit 1ddcc44190a690a3ac221a8c4b38d830046f03ef Author: Daniel

[Libreoffice-commits] .: Branch 'feature/gsoc-calc-perf' - sc/source

2012-05-25 Thread Daniel Bankston
Author: Daniel Bankston daniel.e.banks...@gmail.com Date: Fri May 25 02:36:28 2012 -0500 Convert ScMyTables matrix methods to use direct Sc calls Change-Id: I345d938b80e5c68f9db20cf032fed9966df44936 diff --git a/sc/source/filter/xml/xmlcelli.cxx b/sc/source/filter/xml/xmlcelli.cxx

[Libreoffice-commits] .: Branch 'feature/gsoc-calc-perf' - sc/source

2012-05-25 Thread Daniel Bankston
14be196c746fe307ddc7b4abbedf00df62c7dcac Author: Daniel Bankston daniel.e.banks...@gmail.com Date: Fri May 25 17:22:21 2012 -0500 Remove unnecessary code in ODS import for matrix and merge MyScTables matrix methods and ScXMLTableRowCellContext merge methods used getCellRangePosition() (that was adopted from

[Libreoffice-commits] .: Branch 'feature/gsoc-calc-perf' - sc/source

2012-05-25 Thread Daniel Bankston
sc/source/filter/xml/xmlsubti.cxx | 26 +++--- 1 file changed, 15 insertions(+), 11 deletions(-) New commits: commit 89a6f4d896a591273b555b72886d1e5ab1516eb9 Author: Daniel Bankston daniel.e.banks...@gmail.com Date: Fri May 25 21:07:41 2012 -0500 Remove ScDocFunc

[Libreoffice-commits] .: Branch 'feature/gsoc-calc-perf' - sc/source

2012-05-25 Thread Daniel Bankston
sc/source/filter/xml/xmlsubti.cxx |3 --- 1 file changed, 3 deletions(-) New commits: commit 0aa62e9e29e3db9f479c8662b5c606ed8386df11 Author: Daniel Bankston daniel.e.banks...@gmail.com Date: Fri May 25 21:39:24 2012 -0500 Remove header includes that are no longer used

[Libreoffice-commits] .: Branch 'feature/gsoc-calc-perf' - sc/source

2012-05-26 Thread Daniel Bankston
sc/source/filter/xml/xmlcelli.cxx | 71 -- sc/source/filter/xml/xmlcelli.hxx |1 2 files changed, 8 insertions(+), 64 deletions(-) New commits: commit c827d7b23bdccc1adfb8b44ec04ea2b6503d57f5 Author: Daniel Bankston daniel.e.banks...@gmail.com Date

ODS import with merged cells

2012-05-26 Thread Daniel Bankston
compile and pass sc unit tests. Also, when I manually run calc and open a spreadsheet with merged cells, I see that the file is imported correctly. Can you see anything that I might have missed or incorrectly removed? Thanks. Respectfully, Daniel Bankston

Re: ODS import with merged cells

2012-05-26 Thread Daniel Bankston
On 05/26/2012 10:58 AM, Michael Meeks wrote: On Sat, 2012-05-26 at 17:24 +0200, Markus Mohrhard wrote: That is not planned. Only during import all the code in ScDocFunc does not make much sense. We neither need to repaint areas nor do we need undo/redo code. Cool - yes, it's a nonsense

Re: ODS import with merged cells

2012-05-31 Thread Daniel Bankston
On 05/26/2012 10:22 AM, Markus Mohrhard wrote: Hey Daniel, 2012/5/26 Daniel Bankstondaniel.dev.libreoff...@gmail.com: Hi, Kohei and Markus, I pushed my changes to ScXMLTableRowCellContext::DoMerge() where I have removed the ScDocFunc layer and simplified the whole method in general. Great. I

Re: Disabling file opening and saving in print preview mode

2012-05-31 Thread Daniel Bankston
in print preview mode even less so. I personally can't ever remember having the desire to load or save a document while in print preview nor can I fathom a reason to do so. Respectfully, Daniel Bankston ___ LibreOffice mailing list LibreOffice

[Libreoffice-commits] .: Branch 'feature/gsoc-calc-perf' - 3 commits - sc/source

2012-06-01 Thread Daniel Bankston
deletions(-) New commits: commit 9e62caee992f9c352f1a8e7ea6772ae998fd309a Author: Daniel Bankston daniel.e.banks...@gmail.com Date: Fri Jun 1 00:52:51 2012 -0500 Convert GetRealCellPos and calls to use ScAddress Change-Id: Ic7a6ad82b5b4938ef67ddf8e62372635044cd5b2 diff --git a/sc

Continuing converting ScMyTables in feature/gsoc-calc-perf

2012-06-01 Thread Daniel Bankston
::SetTableStyle() at some point. Respectfully, Daniel Bankston ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Continuing converting ScMyTables in feature/gsoc-calc-perf

2012-06-01 Thread Daniel Bankston
On 06/01/2012 02:56 AM, Daniel Bankston wrote: I think before I can move forward, I need to know what to do about ScMyTables::IsMerged(), ScMyTables::DoMerge(), and ScMyTables::UnMerge(). ScMyTables references its own merge methods, but I'm not sure what would cause these methods

[Libreoffice-commits] .: Branch 'feature/gsoc-calc-perf' - sc/source

2012-06-04 Thread Daniel Bankston
sc/source/filter/xml/xmlsubti.cxx | 187 -- sc/source/filter/xml/xmlsubti.hxx |7 - 2 files changed, 2 insertions(+), 192 deletions(-) New commits: commit 5d757936fa06330f0abfd4a0c77521b7d4f5f7b4 Author: Daniel Bankston daniel.e.banks...@gmail.com Date

Re: Continuing converting ScMyTables in feature/gsoc-calc-perf

2012-06-04 Thread Daniel Bankston
/2012 02:56 AM, Daniel Bankston wrote: I think most of the other methods will follow fine from there except for GetCurrentXDrawPage() and GetCurrentXShapes() which are separate from the merge method concern. These methods get into things like xmloff's XMLShapeImportHelper. Do we want to go

[Libreoffice-commits] .: Branch 'feature/gsoc-calc-perf' - sc/source

2012-06-05 Thread Daniel Bankston
deletions(-) New commits: commit b91e54a89586717fef49531d9626fbd2c75cf24e Author: Daniel Bankston daniel.e.banks...@gmail.com Date: Tue Jun 5 02:17:07 2012 -0500 Replace CellAddress with ScAddress in ScXMLTableRowCellContext::EndElement() Replaced CellAddress with ScAddress in EndElement

[Libreoffice-commits] .: Branch 'feature/gsoc-calc-perf' - 5 commits - sc/qa sc/source

2012-06-06 Thread Daniel Bankston
|6 +--- sc/source/filter/xml/xmlrowi.cxx |4 +-- 6 files changed, 36 insertions(+), 24 deletions(-) New commits: commit 870bccb97838e175febf22b8103503097c59bf58 Author: Daniel Bankston daniel.e.banks...@gmail.com Date: Tue Jun 5 21:30:25 2012 -0500 Fix

Re: [PATCH] dead code: remove ScDocument::DeleteNumberFormat

2012-06-07 Thread Daniel Bankston
, Daniel Bankston ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] WaE in ScTabViewShell::UpdateNumberFormatter

2012-06-07 Thread Daniel Bankston
::UpdateNumberFormatter was forgotten. Respectfully, Daniel Bankston ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Changing Cell Validate Text

2012-06-07 Thread Daniel Bankston
linked the wrong bug report. Respectfully, Daniel Bankston ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Changing Cell Validate Text

2012-06-07 Thread Daniel Bankston
On 06/08/2012 12:24 AM, Joel Madero wrote: Thanks for pointing that out, correction: https://bugs.freedesktop.org/show_bug.cgi?id=43192 On Thu, Jun 7, 2012 at 10:20 PM, Daniel Bankston daniel.dev.libreoff...@gmail.com mailto:daniel.dev.libreoff...@gmail.com wrote: On 06/07/2012 10:58

Re: Changing Cell Validate Text

2012-06-07 Thread Daniel Bankston
Markus. Regardless, I defer to Markus's comments. Respectfully, Daniel Bankston ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] WaE in ScTabViewShell::UpdateNumberFormatter

2012-06-08 Thread Daniel Bankston
On 06/08/2012 01:14 AM, David Ostrovsky wrote: Hi Daniel, trying to send it to once time again. Regards David Looks good to me, but please let someone else concur (preferably one of the calc gurus). Respectfully, Daniel Bankston ___ LibreOffice

Re: [PATCH] WaE in ScTabViewShell::UpdateNumberFormatter

2012-06-08 Thread Daniel Bankston
. This is part of what open source is all about, right? We look out for each other. Didn't someone once say something along the lines, given enough eyeballs, all bugs are shallow? :-) Respectfully, Daniel Bankston ___ LibreOffice mailing list LibreOffice

[Libreoffice-commits] .: Branch 'feature/gsoc-calc-perf' - 5 commits - sc/qa sc/source

2012-06-09 Thread Daniel Bankston
++- sc/source/filter/xml/xmlcelli.hxx| 12 - 6 files changed, 311 insertions(+), 122 deletions(-) New commits: commit 8a7fce7e9f522c44d4207eef4becbd32a8148719 Author: Daniel Bankston daniel.e.banks...@gmail.com Date: Sat Jun 9 06:53:23 2012 -0500 Remove unused

[GSOC] Progress on ScXMLTableRowCellContext::EndElement() conversion

2012-06-09 Thread Daniel Bankston
, enjoy your vacation! Respectfully, Daniel Bankston ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Extend Database Range Unit test

2012-06-11 Thread Daniel Bankston
and end of school semester work. Ever since I remembered it, it's been bothering me, so I'd like to at least finish the database ranges at some point. (And whatever else you think should fall under this easyhack.) Very respectfully, Daniel Bankston From 51b83940b602f75800ed0e80216dd7a4d26cdcc7

Re: Source for 3.3

2012-06-12 Thread Daniel Bankston
this out: http://cgit.freedesktop.org/libreoffice/core/refs/tags. Respectfully, Daniel Bankston ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Recent commits on sc/source/ui/condformat/condformatdlg.cxx

2012-06-12 Thread Daniel Bankston
perhaps this was a work in progress for Markus? I just wanted to bring it to both of your attention to avoid unnecessary problems and confusion. Then again maybe you have already communicated about it? Respectfully, Daniel Bankston ___ LibreOffice

Re: OpenGrok Search Upon Link Click

2012-06-12 Thread Daniel Bankston
, for example sc, type in sc in the File Path search box in conjunction with the above. (core/sc more specifically, but just sc seems to work.) --Daniel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org

Re: Changing Cell Validate Text

2012-06-13 Thread Daniel Bankston
On 06/13/2012 03:07 PM, Joel Madero wrote: Hi Daniel, Just a quick email to see if you have finished up with the stuff needed so I can do the patch for this minor change that has been brought up as a bug. The files that will be changed are: validate.src validate.cxx validate.hrc Object name

follow up on handling text:p tag on ods import

2012-06-14 Thread Daniel Bankston
if I can convert the use of the XShape interface. Also there is the use of XAttributeList, but I think that is too deeply ingrained throughout all import. So what do you think is the highest priority right now? Respectfully, Daniel Bankston

Re: follow up on handling text:p tag on ods import

2012-06-14 Thread Daniel Bankston
On 06/14/2012 07:03 AM, Daniel Bankston wrote: So it seems either I should make the import conditionally use my OUString replacement for simple text and XTextCursor withXMLParaContext for complicated text, or I should abandon it all together for now. Do you think it would be worth

[Libreoffice-commits] .: Branch 'feature/gsoc-calc-perf' - sc/source

2012-06-15 Thread Daniel Bankston
sc/source/filter/xml/xmlcelli.cxx | 297 +- sc/source/filter/xml/xmlcelli.hxx |7 2 files changed, 141 insertions(+), 163 deletions(-) New commits: commit 3da9e8832632c4d7123e1e3f326eec2c1ab4f27b Author: Daniel Bankston daniel.e.banks...@gmail.com Date

[Libreoffice-commits] .: Branch 'feature/gsoc-calc-perf' - sc/source

2012-06-16 Thread Daniel Bankston
/filter/xml/xmltabi.hxx |4 - 6 files changed, 75 insertions(+), 141 deletions(-) New commits: commit 8d4d75c7d67832c65472d48637d1a200682c4d5f Author: Daniel Bankston daniel.e.banks...@gmail.com Date: Sat Jun 16 04:42:05 2012 -0500 Remove subtable import code since sc core doesn't support

Re: [PUSHED] fdo#43192: : confusing label for data validity criterion

2012-06-18 Thread Daniel Bankston
On 06/18/2012 10:12 AM, Joel Madero wrote: Thanks for the heads up. Marking bug as RESOLVED. Hopefully can get some higher priority things patched soon. Not going to lie, I was excited for my first patch, wife didn't understand ;) Joel Congrats :-)

[Libreoffice-commits] .: Branch 'feature/gsoc-calc-perf' - 2 commits - sc/source

2012-06-18 Thread Daniel Bankston
-- 5 files changed, 40 insertions(+), 297 deletions(-) New commits: commit 74dd823ebdc6910529f5b916780ace49121c04ea Author: Daniel Bankston daniel.e.banks...@gmail.com Date: Mon Jun 18 16:04:36 2012 -0500 Use better variable and method names for ScMyTables current cell position

[Libreoffice-commits] .: Branch 'feature/gsoc-calc-perf' - sc/source

2012-06-19 Thread Daniel Bankston
sc/source/filter/xml/xmlcelli.cxx | 23 --- 1 file changed, 8 insertions(+), 15 deletions(-) New commits: commit cb1b6e89995196e3dc61dc46d3207d410058638e Author: Daniel Bankston daniel.e.banks...@gmail.com Date: Tue Jun 19 16:42:54 2012 -0500 Clean up logic a bit

Re: Breakpoints

2012-06-20 Thread Daniel Bankston
, learning as I go. Joel Hi, Joel, From RMS himself: http://www.unknownroad.com/rtfm/gdbtut/gdbbreak.html Markus let me know about this handy cheat sheet: http://darkdust.net/files/GDB%20Cheat%20Sheet.pdf --Daniel Bankston ___ LibreOffice mailing

Re: Breakpoints

2012-06-20 Thread Daniel Bankston
On 06/20/2012 01:42 PM, Daniel Bankston wrote: On 06/20/2012 12:55 PM, Joel Madero wrote: I think this is a basic question but how do I go about putting on breakpoints and then how do I use the breakpoints to determine things like what variables are being called on? This stems from a previous

Re: Breakpoints

2012-06-20 Thread Daniel Bankston
On 06/20/2012 01:45 PM, Daniel Bankston wrote: Also take a lot at this about gdb and libo if you haven't already: https://wiki.documentfoundation.org/Development/How_to_debug Take a look. :-) ___ LibreOffice mailing list LibreOffice

Re: Breakpoints

2012-06-20 Thread Daniel Bankston
/install/program, where LIBOROOT is the root directory where ever you git cloned. Also make sure you are building with --enable-debug or at least with --enable-symbols. --Daniel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http

[Libreoffice-commits] .: Branch 'feature/gsoc-calc-perf2' - sc/qa

2012-06-21 Thread Daniel Bankston
sc/qa/unit/subsequent_filters-test.cxx | 87 + 1 file changed, 36 insertions(+), 51 deletions(-) New commits: commit a2a99a169f5395f41a9ee7f75dd4856ea42a5ee5 Author: Daniel Bankston daniel.e.banks...@gmail.com Date: Thu Jun 21 00:32:19 2012 -0500 Change

[GSOC] ODS Row height import

2012-06-23 Thread Daniel Bankston
, I can truly test the changes I made that use the imported row heights. After that, I can see about handling the cases where there is no row height to import. (In such a case, should we calculate the row height or use a default row height?) Respectfully, Daniel Bankston

[Libreoffice-commits] .: Branch 'feature/gsoc-calc-perf2' - 2 commits - sc/qa sc/source

2012-06-25 Thread Daniel Bankston
: commit a2abf16d605b9e4b4437124a08fc312e81ae33af Author: Daniel Bankston daniel.e.banks...@gmail.com Date: Mon Jun 25 01:21:26 2012 -0500 Stop calculating row heights and instead use imported row heights only Change-Id: I1a5e33c292fb915e61511efbdb9ce4a0cfd7265f diff --git a/sc/source

Re: [GSOC] ODS Row height import

2012-06-25 Thread Daniel Bankston
, Daniel Bankston ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

ScInterpreter::Interpret() backtraces during ODS import

2012-06-27 Thread Daniel Bankston
unnecessarily recalculating formula results even though we have imported formula results at our disposal? Respectfully, Daniel Bankston #0 ScInterpreter::Interpret (this=0x19aca60) at /home/dbank/code/git/libo/libo_gsoc-calc_perf2_cg/sc/source/core/tool/interpr4.cxx:3712 #1 0x7fffde699d0f

Re: ScInterpreter::Interpret() backtraces during ODS import

2012-06-29 Thread Daniel Bankston
On 06/29/2012 10:39 AM, Kohei Yoshida wrote: That said, doing what Eike suggests will be a good intermediate step even if we decide to prompt the user in the end. So does that mean this is my next task? :-) --Daniel ___ LibreOffice mailing list

Re: ScInterpreter::Interpret() backtraces during ODS import

2012-06-29 Thread Daniel Bankston
otherwise. --Daniel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: ScInterpreter::Interpret() backtraces during ODS import

2012-06-29 Thread Daniel Bankston
On 06/29/2012 11:20 AM, Daniel Bankston wrote: While there were no bugzilla bugs directly related to ODS import performance, Markus did find https://bugs.freedesktop.org/show_bug.cgi?id=47106 which is about performance while calc is already running, and may be closely related to our

[Libreoffice-commits] .: Branch 'feature/gsoc-calc-perf2' - 2 commits - sc/inc sc/qa sc/source

2012-07-03 Thread Daniel Bankston
/filter/xml/xmlimprt.cxx | 12 -- sc/source/ui/docshell/docsh.cxx|2 - 7 files changed, 54 insertions(+), 45 deletions(-) New commits: commit 7a0fba0b0225f59f8c38b245cb21b81750271e26 Author: Daniel Bankston daniel.e.banks...@gmail.com Date: Tue Jul 3 03:06:29 2012 -0500

[GSOC] Using cached formula results during ODS import

2012-07-03 Thread Daniel Bankston
document. Respectfully, Daniel Bankston ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [GSOC] Using cached formula results during ODS import

2012-07-03 Thread Daniel Bankston
On 07/03/2012 04:46 PM, Daniel Bankston wrote: If an ScFormulaCell is set to dirty, it will be re-Interpreted (recalculated). The goal is to avoid this during ODS import of a LibreOffice generated document and instead use cached formula results imported from the document itself to achieve

Re: [GSOC] Using cached formula results during ODS import

2012-07-04 Thread Daniel Bankston
prevent me from adding my own ScDocument libreoffice-generated-doc flag. What do you guys think? Respectfully, Daniel Bankston #0 ScFormulaCell::SetDirtyVar (this=0x8ee6db8) at /home/dbank/code/git/libo_gsoc-calc-perf2/sc/source/core/data/cell.cxx:1833 #1 0xada3b635 in ScFormulaCell

Fwd: Re: [GSOC] Using cached formula results during ODS import

2012-07-04 Thread Daniel Bankston
Sorry, I meant to also CC Kohei and mailing list. I having trouble trying to think of a way to prevent ScFormulaCells from being set dirty without my hackish ScDocument libreoffice-generated-doc flag. During the import of the functions.ods unit test file, ScFormulaCells are set dirty at

[Libreoffice-commits] .: Branch 'feature/gsoc-calc-perf2' - sc/inc sc/source

2012-07-05 Thread Daniel Bankston
/docshell/docsh.cxx | 14 +- 7 files changed, 18 insertions(+), 21 deletions(-) New commits: commit 93319669a0c7892af96221bc1e832ba01c5e2d54 Author: Daniel Bankston daniel.e.banks...@gmail.com Date: Thu Jul 5 18:15:45 2012 -0500 Use cached formula results instead

[Libreoffice-commits] .: Branch 'feature/gsoc-calc-perf2' - sc/source

2012-07-07 Thread Daniel Bankston
sc/source/filter/xml/xmlcelli.cxx | 12 ++-- sc/source/ui/docshell/docsh.cxx |5 - 2 files changed, 14 insertions(+), 3 deletions(-) New commits: commit 7dd4d50687d7c94673e6d9f62b54054b1b817027 Author: Daniel Bankston daniel.e.banks...@gmail.com Date: Sat Jul 7 07:15:21

[Libreoffice-commits] .: Branch 'feature/gsoc-calc-perf2' - sc/source

2012-07-08 Thread Daniel Bankston
insertions(+), 115 deletions(-) New commits: commit 9e639de0f9a7db8fb9cc48ca1e8036bb8f910811 Author: Daniel Bankston daniel.e.banks...@gmail.com Date: Sun Jul 8 11:26:52 2012 -0500 Use cached formula results for matrices Change-Id: Ia77a94184c3d598f16a2f51d996f4c7058d9e303 diff

[Libreoffice-commits] .: Branch 'feature/gsoc-calc-perf2' - 2 commits - sc/qa sc/source

2012-07-08 Thread Daniel Bankston
(-) New commits: commit 191c4bf8a6ee43bbac25f5a0f83181c74fac8390 Author: Daniel Bankston daniel.e.banks...@gmail.com Date: Sun Jul 8 12:57:36 2012 -0500 Fix problem with cached matrix formula results that contain errors Change-Id: I9277714780e00e311e6e81a9de6e4d39409d5c9b diff --git

  1   2   3   4   >