[Libreoffice] [PUSHED] Re: [PATCH] SvUShorts - std::vector

2011/10/20 Daniel Di Marco d.dima...@gmx.de: I replaced some more SvUShorts with std::vectors. http://cgit.freedesktop.org/libreoffice/core/commit/?id=593e4c36d2f199cc3b82be587bc7674c2f394d06 Pushed. Thank you! ;) ___ LibreOffice mailing list

[Libreoffice] Bug #i89051

Hi, I dug into http://openoffice.org/bugzilla/show_bug.cgi?id=89051 and I've stalled... --Some explanations.-- When inserting a point there is a call to SdrDragView::ImpBegInsObjPoint (svx/source/svdraw/svddrgv.cxx). Inside it: - we remember the number of new point in a polypolygon:

Re: [Libreoffice] [PUSHED] Re: Bug #i89051

Hi Kendy, 2011/11/2 Jan Holesovsky ke...@suse.cz: Very nice analysis!  According to what you described, the 1. (changing the order) sounds great to me, and works nicely too :-) - so I have pushed that, if you don't mind: Thank you for the approval, I was inclining to push that, too.

Re: [Libreoffice] translating german - english

2011/11/7 Michael Meeks michael.me...@suse.com: On Mon, 2011-11-07 at 11:57 +0100, Luc Castermans wrote: The last thing: I found patch making  instructions on the Libo site. If there are better ones, I like to receive them.        Just doing 'git diff /tmp/foo.diff' can be good You can

Re: [Libreoffice] [PUSHED] First Patch

Hi Emanuele, 2011/11/3 Emanuele Fia emanuele@gmail.com: git reset -hard HEAD~1 # warning this looses the head commit before running ./g pull -r to avoid conflicts (assuming you didn't do any more commits yet). This is for reset my local repo and restore the current version on git

[Libreoffice] [PATCH] Fix for fdo#42178

this. If someone will approve the patches, I will push them. Thanks, Ivan From bc7d667dccb8505516614daa5fb7da7996967617 Mon Sep 17 00:00:00 2001 From: Ivan Timofeev timofeev@gmail.com Date: Wed, 16 Nov 2011 15:47:51 +0400 Subject: [PATCH 1/2] fix fdo#42178: crash when printing from Page Preview

Re: [Libreoffice] [PATCH] Fix for fdo#42178

2011/11/16 Michael Stahl mst...@redhat.com: your workaround looks good (but please add an assertion for the case that we don't get any page number, i.e. OSL_ENSURE(pPreView,...)) Ok! isn't m_pPrintUIOptions supposed to be deleted when SwXTextDocument::render is called for the last page (and

Re: [Libreoffice] [PATCH] Fix for fdo#42178

2011/11/16 Michael Stahl mst...@redhat.com: please try it out: remove the 4 lines, then try print and cancel, then try print and close-the-document (to get a high page count just print 1000 copies), see that we survive that in Calc and Writer. Can not reproduce crash with removed lines. :-)

Re: [Libreoffice] [PUSHED, partial] Remove NULL checks from delete

I have played with manual solving of this problem today... :-) There are the more interesting examples: - else if(pUserMarker) + else { delete pUserMarker; pUserMarker = 0L; } and - if( GetPageNum() 0 pCntntAnchor ) + if( GetPageNum() 0 ) { delete pCntntAnchor; Actually,

Re: [Libreoffice] [PATCH] Fix for fdo#42178

16.11.2011 21:27, Ivan Timofeev пишет: Can not reproduce crash with removed lines. Oh, what a terrible formulation! I mean, Can not reproduce crash, even without the mentioned lines of code. So, should I commit this removal? Best Regards, Ivan

Re: [Libreoffice] [Patch] Unreachable code ?

Hi Muthu, 18.11.2011 15:38, Muthu Subramanian K пишет: That code is inside the constructor. and the constructor sets the variable pUndoSet to NULL right on the top. So, the if would always fail! Unless I am missing something. Looks too trivial to be true ;) I don't see any way to assign

Re: [Libreoffice] [PATCH] [PUSHED] Fix for fdo#42178

Pushed, many thanks for the review! ;) Cheers, Ivan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Bug with images in .doc with Writer

Hi Moray, 2011/11/24 moray33 mora...@hotmail.com: Hi. I found a bug in LibreOffice Writer. I don't know programming, so I post the problem here if someone can fix it. I would help me and I'm sure other people a lot. I told the problem here:

[Libreoffice] Possible little code simplification

Hi all, we have the field 'SwSortedObjs* pSortedObjs' in the class SwPageFrm. And we have the strange management of it: For example, sw/source/core/layout/flylay.cxx:734 if ( pSortedObjs ) { pSortedObjs-Remove( *pToRemove ); if ( !pSortedObjs-Count() ) {

Re: [Libreoffice] Possible little code simplification

Hello Michael, 2011/11/25 Michael Stahl mst...@redhat.com: On 24/11/11 19:07, Ivan Timofeev wrote: [...] What do you think about changing the code so that pSortedObjs will be alive every time? We will be able to return a reference to pSortedObjs in GetSortedObjs() instead of a pointer

Re: [Libreoffice] Possible little code simplification

2011/11/28 Michael Stahl mst...@redhat.com: On 25/11/11 19:05, Ivan Timofeev wrote: Well, another possible memory optimization is to merge SwSortedObjsImpl into SwSortedObjs. What is the reason to use the pImpl pattern here? usually pImpl is a good idea because it is the only way to get

[Libreoffice] [REVIEW 3-4] fdo#42147: fix crash

Hi there! Please review http://cgit.freedesktop.org/libreoffice/core/commit/?id=dc61ebdc93a777f4f41c1ae837bdb6098ecffcce and push to 3-4 if the commit is ok for you. It seems, due to wrong condition (using instead of ==) the code casted SwCntntNode to SwTxtNode, but the SwCntntNode is a base

Re: [Libreoffice] [REVIEW 3-4] fdo#42147: fix crash

08.12.2011 23:36, Ivan Timofeev пишет: Hi there! Please review http://cgit.freedesktop.org/libreoffice/core/commit/?id=dc61ebdc93a777f4f41c1ae837bdb6098ecffcce and push to 3-4 if the commit is ok for you. It seems, due to wrong condition (using instead of ==) the code casted SwCntntNode

Re: [Libreoffice] [REVIEWED] fdo#42147: fix crash

09.12.2011 15:26, Michael Meeks пишет: Hi Ivan, On Fri, 2011-12-09 at 09:44 +0400, Ivan Timofeev wrote: Oh no, wait, I was getting all mixed up :( This is not a fix for the mentioned bug, the proper fix was http://cgit.freedesktop.org/libreoffice/core/commit/?id

Re: [Libreoffice] [PATCH] Fix for fdo43460, Part II, getLength to isEmpty

Hi Olivier, 10.12.2011 04:29, Olivier Hallot пишет: Please find attached a partial fix for Easy Hack FDO43460, Part II Module basctl very nice, pushed now: http://cgit.freedesktop.org/libreoffice/core/commit/?id=1688a9d9235dd2ee4f3b9497308efd41f7a3fb6f Thanks! Ivan

Re: [Libreoffice] [PUSHED][PATCH] Fix for fdo43460, Part II, getLength to isEmpty

...and I forgot to change the subject :) Ivan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED][PATCH] Fix for fdo43460, Part III, getLength to isEmpty

10.12.2011 20:34, Olivier Hallot пишет: Please find attached a partial fix for Easy Hack FDO43460, Part III Module basic Pushed, thank you! :) May I suggest you to remove unnecessary parentheses in addition? i.e sal_Bool bOldPassword = ( !OldPassword.isEmpty() ); can be

Re: [Libreoffice] [PUSHED][PATCH 1/4] fdo38832 Replace ImplAccelTable with std::map

12.12.2011 20:05, Caolán McNamara пишет: On Sat, 2011-12-10 at 19:23 +0100, Marcel Metz wrote: Hello lo-devs, This patch series replaces some DECLARE_TABLE macros with the std::map equivalent. Looks good to me. Thanks for this, pushed now. Hmm... looking at this I think that - else if (

[Libreoffice] fixing fdo#41264: no check marks in Line Spacing and ALignment popup menu

Hi all, the bug: https://bugs.freedesktop.org/show_bug.cgi?id=41264 briefly: in the context menus (except the toolbar's ones) icons are not shown for radio menu items and for checked menu items. Rainer assigned it to me, so... :) looking at the drawing code (vcl/source/window/menu.cxx):

Re: [Libreoffice] [PUSHED][PATCH] Fix for fdo43460, Part IV, getLength to isEmpty

Hi Olivier, 10.12.2011 23:38, Olivier Hallot пишет: Please find attached a partial fix for Easy Hack FDO43460 Part IV Module basic (small cosmetic fix per demand of Ivan Timofeev) binaryurp bridges ah, I meant doing cosmetics only for future works... Sorry, sometimes I express my thoughts

Re: [Libreoffice] [PUSHED][PATCH] Fix for fdo43460, Part V, getLength to isEmpty

11.12.2011 04:08, Olivier Hallot пишет: Please find attached a partial fix for Easy Hack FDO43460 Part V Module chart2 pushed: http://cgit.freedesktop.org/libreoffice/core/commit/?id=0eac98aa742e8e76ebb1af91b32bd02e04b2e20a Thank you! Ivan ___

Re: [Libreoffice] [PUSHED][PATCH] Fix for fdo43460 Part VI getLength() to isEmpty()

13.12.2011 00:24, Olivier Hallot пишет: Please find attached a partial fix for Easy Hack FDO43460 Part VI Module codemaker http://cgit.freedesktop.org/libreoffice/core/commit/?id=fd866ac8f184c0910883963c9c12b45a239a9227 nice work! Regards, Ivan

Re: [Libreoffice] [PATCH] Fix for fdo43460 Part VII getLength() to isEmpty()

Hi Olivier, 13.12.2011 05:08, Olivier Hallot пишет: Please find attached a partial fix for Easy Hack FDO43460 Part VII Module comphelper Not sure whether this improves readability: +++ b/comphelper/source/misc/storagehelper.cxx @@ -522,7 +522,7 @@ sal_Bool OStorageHelper::PathHasSegment(

Re: [Libreoffice] [PUSHED][PATCH] Fix for fdo43460 Part VII getLength() to isEmpty()

forgot to change the subject again! ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] fixing fdo#41264: no check marks in Line Spacing and ALignment popup menu

14.12.2011 17:01, Michael Meeks пишет: On Wed, 2011-12-14 at 15:32 +0400, Ivan Timofeev wrote: If I understood you right, the MENU_FLAG_SHOWCHECKIMAGES flag was introduced to control whether a simple check mark [x] or an image should be painted with a checkable menu item; if it is so, it don't

Re: [Libreoffice] [PUSHED][PATCH] Fix for fdo43460 Part VIII getLength() to isEmpty()

Hi Olivier, 14.12.2011 17:39, Olivier Hallot пишет: Please find attached a partial fix for Easy Hack FDO43460 Part VIII Module configmgr http://cgit.freedesktop.org/libreoffice/core/commit/?id=4a0ab53cf44be11053a095470ad8cb426487dbc6 Thank you, Ivan

Re: [Libreoffice] [PUSHED][PATCH] Fix for fdo43460 Part IX getLength() to isEmpty()

15.12.2011 05:18, Olivier Hallot пишет: Please find attached a partial fix for Easy Hack FDO43460 Part IX Module connectivity (this one is quite big) it seems that you forgot to change the second condition: -if ( !pMasterFields-getLength() || !pDetailFields-getLength() ) +

Re: [Libreoffice] [PUSHED][PATCH] Fix for fdo43460 Part X getLength() to isEmpty()

15.12.2011 23:35, Olivier Hallot пишет: Please find attached a partial fix for Easy Hack FDO43460 Part X Module cppu cppuhelper cpputools great! http://cgit.freedesktop.org/libreoffice/core/commit/?id=1b99d8800e399f45404ab62827163a873d2a1aec Thanks, Ivan

Re: [Libreoffice] [PATCH] Fix for fdo43460 Part XI getLength() to isEmpty()

Hi Olivier, 16.12.2011 23:33, Olivier Hallot пишет: Please find attached a partial fix for Easy Hack FDO43460 Part XI Module cui sorry for the delay, (he-he, now I know how to resolve conflicts :) pushed:

Re: [Libreoffice] [PUSHED][PATCH] Fix for fdo43460 Part XI getLength() to isEmpty()

marking as pushed... ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED][PATCH] Fix for fdo43460 Part XIV getLength() to isEmpty()

Hi Gustavo, 23.12.2011 21:21, Gustavo Pacheco пишет: Hi! Partial fix for Easy Hack FDO43460 (part XIV) for review. Mentoring by Olivier Hallot (thanks for the tips Olivier!). Part XVI Modules drawinglayer, dtrans and editeng Looks nice for me, but -if

Re: [Libreoffice] [PUSHED][PATCH] Fix for fdo43460 Part XVII getLength() to isEmpty()

Hi Olivier, 24.12.2011 00:26, Olivier Hallot пишет: Please find attached a partial fix for Easy Hack FDO43460 Part XVII Module fileaccess and filter Pushed: http://cgit.freedesktop.org/libreoffice/core/commit/?id=e7bddf732798508e347221590110486e97bb45e6 Thanks a lot! Ivan

Re: [Libreoffice] [PUSHED][PATCH] Fix for fdo43460 Part XIX getLength() to isEmpty()

26.12.2011 01:35, Olivier Hallot пишет: Please find attached a partial fix for Easy Hack FDO43460 Part XIX Module formula and fpicker Pushed: http://cgit.freedesktop.org/libreoffice/core/commit/?id=3e4f51f112248b4e586f5bd86388099737ed17e9 Great work, thank you! Ivan

Re: [Libreoffice] minor problem with Insert - indexes and tables dialog

Hi Kaplan, 27.12.2011 03:04, Lior Kaplan пишет: The in Insert - Indexes and Tables dialog, the word Preview (bottom right corner in English interface) is trimmed. See screenshot (3.5.0 beta2). In RTL interface the same problem happens, and with a longer translation more of the text is trimmed.

Re: [Libreoffice] minor problem with Insert - indexes and tables dialog

Hi Jan, 27.12.2011 17:45, Jan Holesovsky пишет: The good news is that I fixed an unrelated text cut in my native language a visual annoyance there ;-) http://cgit.freedesktop.org/libreoffice/core/commit/?id=3a38a8514ab33f9d8b174000ca635db949c16940 Our *.src-based UI is a real disaster. This

Re: [Libreoffice] bug 36874 (label printing) further improvement?

someone who is willing to improve/change the UI Hello, Ivan Timofeev was very active eliminating problems and improving GUI. Ivan, what do you think? Are you interested? Interested, but extremely busy the whole January through... :-( I'm sorry. But an UI is an easy piece of programming

Re: [Libreoffice] [PUSHED][PATCH] Correct ARCCOSH's parameter description

Hi Korrawit, 31.12.2011 14:46, Korrawit Pruegsanusak пишет: I found this while translating. Could someone please review it? Looks great! Nice catch, thanks! :) Also, if this patch could be pushed in -3-5 branch as well? I've found the wiki page [1] says hard string freeze is next week. So,

Re: [Libreoffice] minor problems with format - page - organizer

06.01.2012 20:57, Lior Kaplan пишет: Anyone ? I'll try... :) On Mon, Jan 2, 2012 at 5:13 PM, Lior Kaplan kaplanl...@gmail.com wrote: Hi, 1. The format - page - organizer tab is missing a space between the page orientation and the page direction. You'll notice it as

Re: [Libreoffice] [PUSHED][PATCH] Remove superfluous _ZFORLIST_DECLARE_TABLE definition.

Hello Marcel, 07.01.2012 20:19, Marcel Metz пишет: this patch removes the superfluous _ZFORLIST_DECLARE_TABLE define that is explicit defined right in in front of the conditional code. Cool, you've killed this ancient and ugly definition. :) Thanks! Pushed:

Re: [Libreoffice] [REVIEW] Cherry-pick in 3.5 (3.4 ?) for fdo#44065

Hello Julien, 07.01.2012 20:57, julien2412 пишет: Would it be possible to cherry-pick the commit http://cgit.freedesktop.org/libreoffice/core/commit/?id=948f57e74dda7e64b7c72208eaec00eac1bb96ba in 3.5 branch ? It's a very quick and easy fix for fdo#44065. He-he, copy-paste negligence... :)

Re: [Libreoffice] [REVIEW] Re: minor problems with format - page - organizer

07.01.2012 22:37, Lior Kaplan пишет: This fix is also relevant a few lines bellow, adding a patch to include them both. Yep, feel free to push. It is anyway doubtful whether sticking two different-meaning strings together is good idea. Ivan ___

[Libreoffice] error in writerperfect?

Hi, glancing over the git-log I have noticed the following code writerperfect/source/filter/OdgGenerator.cxx:951 if (!propList[libwpg:mime-type] propList[libwpg:mime-type]-getStr().len() = 0) return; Is there should be || instead of ? Regards, Ivan

Re: [Libreoffice] [PATCH] Bug 33794 - The Open... button of the initial screen needs more room for localization fdo#33794

Hello, 13.01.2012 18:15, Tomcsik Bence Tibor пишет: Hi, Bug 33794 solved. IMHO it's better to pass some additional parameter to the layoutButton function ( e.g. int i_nExtraWidth = 0 ) and change: nTextWidth += maButtonImageSize.Width() + 8; // add some fuzz to be on the safe side

[Libreoffice] [REVIEW] fdo#43932: try to fix paper tray settings

Hi there, https://bugs.freedesktop.org/show_bug.cgi?id=43932 this patch partially reverts http://cgit.freedesktop.org/libreoffice/core/commit/?id=4cc5448ed82f13bb107695b65f39589df1e46cb9 because the following change made the option [ ] Use only paper tray from printer preferences useless: @@

Re: [Libreoffice] [REVIEW] fdo#43932: try to fix paper tray settings

forgot to attach the patch. From bae6b73a56cf4fcfffe21aa9f3f9ccce87e890cd Mon Sep 17 00:00:00 2001 From: Ivan Timofeev timofeev@gmail.com Date: Fri, 13 Jan 2012 21:50:55 +0400 Subject: [PATCH] fdo#43932: try to fix paper tray settings --- vcl/source/gdi/print3.cxx | 25

Re: [Libreoffice] [PATCH] Simple fix for fontconfig.cxx to review (from cppcheck report)

Hi Mat, 15.01.2012 03:29, Mat M пишет: Hello Le Sat, 14 Jan 2012 16:00:31 +0100, julien2412 serval2...@yahoo.fr a écrit: Hello, cppcheck reported this : core/vcl/generic/fontmanager/fontconfig.cxx 196 duplicateExpression style Same expression on both sides of '-' class SortFont : public

Re: [Libreoffice] [PUSHED][PATCH] Bug 33794 - The Open... button of the initial screen needs more room for localization fdo#33794

14.01.2012 03:30, Tomcsik Bence Tibor пишет: I send the new patch. Ok, pushed to the master branch and cherry-picked to libreoffice-3-5: http://cgit.freedesktop.org/libreoffice/core/commit/?id=1f628c7bf8361086be2044d0d6aa8bbf3f128162

[Libreoffice] [REVIEW 3-5, 3-4] fdo#43193: fix rotation of shapes in imported MS documents

Hello, I want to push the following commit to 3-5 and to 3-4: http://cgit.freedesktop.org/libreoffice/core/commit/?id=005d6524977bd51ce2f859b5ae5352a2fba68dd0 It fixes: https://bugs.freedesktop.org/show_bug.cgi?id=43193 partially reverting:

Re: [Libreoffice] [REVIEW 3-4] fdo#43193: fix rotation of shapes in imported MS documents

17.01.2012 16:49, Thorsten Behrens пишет: Seen pushed on -3-5 Great, thanks! -3-4 is still pending. Ivan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] minutes of ESC call ...

quality though :) - attaching it. So, I either have to reassign the bug to Thorsten or have to ask how to make the patch better. :) Thorsten, are you working on this already? Best Regards, Ivan From 186a015831027d5a8c77a0110b49b3e4614ac38d Mon Sep 17 00:00:00 2001 From: Ivan Timofeev timofeev

Re: [Libreoffice] [PUSHED][PATCH] proposed fix for fdo#44283

11.01.2012 22:15, Lionel Elie Mamane пишет: On Wed, Jan 11, 2012 at 04:22:59PM +, Caolán McNamara wrote: Looks good to me on the surface anyway. Go for it I say for master and 3.5. Lionel ? are we right here ? Yes, that patch is right. I committed (and pushed) a slightly extended version

Re: [Libreoffice] [REVIEW] fdo#44915 missing MSI localizations

Hi Andras, 20.01.2012 02:33, Andras Timar пишет: http://cgit.freedesktop.org/libreoffice/core/commit/?id=5d2f27834abd9ea13556387ffa7f773587edbebc #offtopic: My native windows build had failed on that call to msiinfo.exe, it would be nice to build with your patch again... Cheers, Ivan

[Libreoffice] [REVIEW 3-5] fdo#43705: fix incomplete updating of the page preview pane in Draw

Hi, https://bugs.freedesktop.org/show_bug.cgi?id=43705 (regression since 3.4) The fix for review: http://cgit.freedesktop.org/libreoffice/core/commit/?id=799f2de5d1085d845ec498af0a7932965c42ed68 Thanks, Ivan ___ LibreOffice mailing list

Re: [Libreoffice] [PUSHED] send-feedback patch

Hi Thorsten, 23.01.2012 15:40, Thorsten Behrens пишет: Sorry for the lag - patch is fine as-is I think, let's add the startcenter icon etc. as/when they arrive. Thanks for reviewing/pushing! I was afraid that the hard-coded url is not fine, because I saw another urls in

Re: [Libreoffice] [REVIEW] fdo#43932: try to fix paper tray settings

17.01.2012 16:05, Caolán McNamara пишет: On Fri, 2012-01-13 at 22:22 +0400, Ivan Timofeev wrote: Hi there, https://bugs.freedesktop.org/show_bug.cgi?id=43932 this patch partially reverts http://cgit.freedesktop.org/libreoffice/core/commit/?id=4cc5448ed82f13bb107695b65f39589df1e46cb9 because

[Libreoffice-commits] .: starmath/source

starmath/source/visitors.cxx |6 ++ 1 file changed, 6 insertions(+) New commits: commit cb4c69121a7ca4db4748a78a16d87aaadb3aa9fa Author: Ivan Timofeev timofeev@gmail.com Date: Sat Jul 21 12:37:19 2012 +0400 fdo#38887: SmNodeToTextVisitor: use braces for nested scripts

[Libreoffice-commits] .: starmath/source

starmath/source/commands.src |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit b0a727729d909fc26898dd0fd29a81834111a147 Author: Laurent Balland-Poirier laurent.balland-poir...@laposte.net Date: Tue Jul 24 00:00:02 2012 +0200 Correction of context menu entry for

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - starmath/source

for Math arccot function Change-Id: Ie44783111553d99bc70db81b7b0a31d3b72b254a (cherry picked from commit b0a727729d909fc26898dd0fd29a81834111a147) Signed-off-by: Ivan Timofeev timofeev@gmail.com diff --git a/starmath/source/commands.src b/starmath/source/commands.src index

[PUSHED] StarMath: fixing context menu entry for arccot function

Hi Laurent On 24.07.2012 02:19, jumbo444 wrote: There is a 'c' missing in the context menu for arccot function. Here's a small patch to fix it. Thanks, pushed to master and libreoffice-3-6. Regards, Ivan ___ LibreOffice mailing list

[Libreoffice-commits] .: basctl/source

basctl/source/basicide/baside2.cxx | 28 +--- basctl/source/basicide/baside2.hxx |2 ++ basctl/source/basicide/basides1.cxx | 23 --- basctl/source/basicide/basidesh.cxx |2 -- basctl/source/inc/basidesh.hxx |2 -- 5 files

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - basctl/source

: I96861bfcf7c0da6dd94c50acd673dedb14d15204 (cherry picked from commit c55a4639d27957ee96c59269d894d169fa2b7b34) Signed-off-by: Ivan Timofeev timofeev@gmail.com diff --git a/basctl/source/basicide/baside2.cxx b/basctl/source/basicide/baside2.cxx index a397e49..40fc635 100644 --- a/basctl/source/basicide/baside2.cxx

[PUSHED] fdo#52223: fix Object Catalog in Basic IDE when resizing

Hi, On 23.07.2012 20:55, János Uray wrote: This patch fixes this bug: https://bugs.freedesktop.org/show_bug.cgi?id=52223 Cool! Pushed to master and libreoffice-3-6. Thanks, Ivan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [PATCH] fdo#47164: Start Center: Recent Documents picker can not be reached right third of separate button area

Hi Joel, fdo: #47164: it should be fdo#47164, otherwise the commit would not be recognized as a bug-fix. Please enter the commit message for your changes. Lines starting ... How did you manage to get this lines in the commit message? :) Please remove those. -pDev-DrawRect(

[Libreoffice-commits] .: hwpfilter/source

hwpfilter/source/hwpreader.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 10f08195b8195640016a6eab42818c662f4541d2 Author: Ivan Timofeev timofeev@gmail.com Date: Tue Jul 24 21:17:58 2012 +0400 -Werror=format Change-Id

[Libreoffice-commits] .: 2 commits - vcl/source

vcl/source/control/button.cxx | 32 +++- 1 file changed, 23 insertions(+), 9 deletions(-) New commits: commit ce53472216cab75bfdf04799fb85f375f01af792 Author: Ivan Timofeev timofeev@gmail.com Date: Wed Jul 25 20:53:37 2012 +0400 changes to previous commit

[PUSHED] fdo#47164: Start Center: Recent Documents picker can not be reached right third of separate button area

Hi Joel, instead of commenting I have pushed it and made some changes in the subsequent commit (probably it is something buggy :). Hmm, I can't access cgit.freedesktop.org, luckily we have a mirror on gitorious. See:

[Libreoffice-commits] .: vcl/inc vcl/source

vcl/inc/vcl/button.hxx |5 ++-- vcl/source/control/button.cxx | 47 - vcl/source/control/menubtn.cxx |5 +--- 3 files changed, 24 insertions(+), 33 deletions(-) New commits: commit 452e452d3e9dcc259bc3e58ed6509284004f04fe Author: Ivan

Re: [PATCH] Native background for some more widgets

Hello Ruslan, On 12.07.2012 14:50, Ruslan Kabatsayev wrote: These patches make TabBar and ToolBox have correct native background (needed for bg gradients and other non-flat-colored backgrounds). this patch a bit breaks a toolbar look to me. (on Linux, the default Ubuntu's Ambiance theme,

Re: [PUSHED-3-6] [REVIEW-3-6-0] Revised Document as Email icon

On 26.07.2012 18:45, Eike Rathke wrote: Hi, On Thursday, 2012-07-26 15:51:26 +0200, Stefan Knorr wrote: some people (everyone who commented on that issue so far) found the new paper plane icon for Send Document as Email confusing. Thus, I've pushed a more conventional icon to master. Please

[Libreoffice-commits] .: 2 commits - rsc/inc rsc/source svtools/inc svtools/source vcl/inc vcl/source

|2 - vcl/source/window/brdwin.cxx | 59 ++--- 7 files changed, 31 insertions(+), 92 deletions(-) New commits: commit 09cc3a1b65dbf40717c4b41f24e86450f6fb4a99 Author: Ivan Timofeev timofeev@gmail.com Date: Thu Jul 26 20:20:38 2012 +0400 pTabBar

[Libreoffice-commits] .: padmin/source

padmin/source/rtsetup.src |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 73985cb4df6ecdeb2257758d115b7501031ee987 Author: Jean-Baptiste FAURE jbf.fa...@orange.fr Date: Fri Jul 27 21:35:02 2012 +0200 Add more room to a label in print dialog too short for FR

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - padmin/source

translation Change-Id: Ib54c7f58cf1d2e510b65038a6a0c21da2d6fd186 (cherry picked from commit 73985cb4df6ecdeb2257758d115b7501031ee987) Signed-off-by: Ivan Timofeev timofeev@gmail.com diff --git a/padmin/source/rtsetup.src b/padmin/source/rtsetup.src index 38f3bf2..d73b615

Re: [PUSHED] one line patch to make a label longer

Hi On 28.07.2012 00:06, Jean-Baptiste Faure wrote: Here is a small patch to make a label in the print dialog longer. It is necessary in order to have room enough for FR translation. pushed to master and 3-6. Thanks! Ivan ___ LibreOffice mailing

Re: [PATCH] gtk: listbox border was not rendered

Hi Ruslan, On 28.07.2012 15:08, Ruslan Kabatsayev wrote: This mostly looks good, but breaks a bit border for oxygen-gtk I have just installed it, yeah - it is broken... :( (which somehow has worked before the patch, unlike other themes). Strange. I'd suggest using getFrameWidth() to

[PATCH] fix bug 51231, but...

8aa577a7472c7e5b3da9f9c0f093c98f372e9440 Mon Sep 17 00:00:00 2001 From: Ivan Timofeev timofeev@gmail.com Date: Sun, 29 Jul 2012 14:47:35 +0400 Subject: [PATCH] fdo#51231: mouse position must be in logic slidesorter window coordinates Change-Id: I658bbd937c028ad2b4dc906d86d85e168320a8c0 --- sd/source/ui/slidesorter

Re: [PATCH] gtk: listbox border was not rendered

Hi Ruslan On 31.07.2012 17:56, Ruslan Kabatsayev wrote: After some checks I've come to the conclusion that your patch does it as it should, and the breakage should be fixed in oxygen-gtk. The only problem remains is when this fix should be done (i.e. there'll be some time until your patch gets

[Libreoffice-commits] .: 2 commits - svtools/source vcl/unx

svtools/source/contnr/svtreebx.cxx |2 - vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx | 40 --- 2 files changed, 12 insertions(+), 30 deletions(-) New commits: commit 6657052e463b4ff9c8a005faadcf2289d32343a3 Author: Ivan Timofeev timofeev@gmail.com Date

Re: [PUSHED] gtk: listbox border was not rendered

On 27.07.2012 21:39, Ivan Timofeev wrote: The problem is in gtk plugin which does some weird things when drawing a listbox (see the description in the patch). I have no idea why it does that, git blame shows that it is from the initial import. It would be great if someone review the patch, I am

Re: [PATCH] gtk: listbox border was not rendered

Hi Luke, On 01.08.2012 03:29, Luke Symes wrote: I was the one who made the original patch that set listboxes to integer heights of the list items, which was reverted for causing trouble. The reason I wanted to fully show all list items was not because partially shown list items looked bad. It

Re: double rendering of borders ...

Hi Michael, On 01.08.2012 13:24, Michael Meeks wrote: I was at GUADEC just now, and trying to get toolbar rendering sorted out for gtk3 - which turned out to be quite 'fun' ;-) it seems that the toolbar items we have have a WB_BORDER style set which appears to create a strange border

Re: double rendering of borders ...

On 01.08.2012 20:59, Michael Meeks wrote: On Wed, 2012-08-01 at 19:56 +0400, Ivan Timofeev wrote: I solved the problem by the following change in renderAreaToPix: cairo_data[x*4+0] * alpha That appears to me to break the compositing :-) it might happen to improve things for this case

[Libreoffice-commits] .: vcl/unx

vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) New commits: commit 92e00f2e536ce0458961d329a3c676acc86249e6 Author: Ivan Timofeev timofeev@gmail.com Date: Thu Aug 2 16:06:33 2012 +0400 cairo uses pre-multiplied alpha

Re: double rendering of borders ...

Hi Michael, On 02.08.2012 00:25, Michael Meeks wrote: On Wed, 2012-08-01 at 22:18 +0400, Ivan Timofeev wrote: We use CAIRO_FORMAT_ARGB32 and the cairo manual says[1]: Pre-multiplied alpha is used. (That is, 50% transparent red is 0x8080, not 0x80ff.) So you're right

Re: [Libreoffice-ux-advise] [PATCH] fix bug 51231, but...

Hi Astron, many thanks for the detailed reply. On 02.08.2012 03:34, Stefan Knorr wrote: Hi there, On 29 July 2012 13:20, Ivan Timofeev timofeev@gmail.com wrote: But (don't cast stones at me) could we revert this feature? No casting stones at you (I won't, at least). I agree with you

[Libreoffice-commits] .: 2 commits - sd/source vcl/unx

/gtk3salnativewidgets-gtk.cxx |4 + 5 files changed, 19 insertions(+), 55 deletions(-) New commits: commit e995824285cf6697a355d567abc8cd2df2b38b72 Author: Ivan Timofeev timofeev@gmail.com Date: Thu Aug 2 21:53:58 2012 +0400 fdo#51231 Revert Slidesorter: Show the buttons

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sd/source

, 15 insertions(+), 55 deletions(-) New commits: commit ee1ee06ec96c6db87203970bf05dd6cd7513f674 Author: Ivan Timofeev timofeev@gmail.com Date: Thu Aug 2 21:53:58 2012 +0400 fdo#51231 Revert Slidesorter: Show the buttons on the opposite side... This reverts commit

Re: [Libreoffice-ux-advise] [PUSHED] fix bug 51231, but...

at 18:15 +0400, Ivan Timofeev wrote: So can I use your sign-off for reverting http://cgit.freedesktop.org/libreoffice/core/commit/?id=4866b20ec6205b04cd21077fd00d68c4d4bb2c1b on the libreoffice-3-6 branch? Yes, if Astron says it should go, you have my sign-off too :-) Pushed, thanks!! Best

[Libreoffice-commits] .: sd/source

sd/source/ui/func/futext.cxx |2 ++ 1 file changed, 2 insertions(+) New commits: commit c6fdd2e4e5a54b388d25ca0fc97e1f325ae7a566 Author: Ivan Timofeev timofeev@gmail.com Date: Fri Aug 3 20:30:53 2012 +0400 fdo#36138: sd: fix undo in text objects Change-Id

[REVIEW 3-6 3-5] fdo#36138: sd: fix undo in text objects

Hi, I have fixed https://bugs.freedesktop.org/show_bug.cgi?id=36138 using my ultimate clumsy technique: try to change something somehow and see if that helps. http://cgit.freedesktop.org/libreoffice/core/commit/?id=c6fdd2e4e5a54b388d25ca0fc97e1f325ae7a566 That SidArray is passed to

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - xmloff/source

the invalidation up a bit. Change-Id: I244d1d5cfd40469ff6d2c081e057355460d34cf4 (cherry picked from commit 9e74e9f3c0931f34fb5421056851a06b83501ce9) Signed-off-by: Ivan Timofeev timofeev@gmail.com diff --git a/xmloff/source/style/PageMasterImportPropMapper.cxx b/xmloff

Re: [PUSHED 3-6][REVIEW][3-5-6] regression in fix for fdo#38056

On 04.08.2012 01:35, Michael Stahl wrote: this is a rather stupid regression in 3.5.6, introduced by the fix for fdo#38056 which can cause crashes because the invalidation is in the wrong place please push the fix to libreoffice-3-5-6 and libreoffice-3-6

[Libreoffice-commits] .: Branch 'libreoffice-3-5' - xmloff/source

the invalidation up a bit. Change-Id: I244d1d5cfd40469ff6d2c081e057355460d34cf4 (cherry picked from commit 9e74e9f3c0931f34fb5421056851a06b83501ce9) Signed-off-by: Ivan Timofeev timofeev@gmail.com diff --git a/xmloff/source/style/PageMasterImportPropMapper.cxx b/xmloff

Re: [PUSHED 3-6 3-5][REVIEW][3-5-6] regression in fix for fdo#38056

On 04.08.2012 10:36, Ivan Timofeev wrote: On 04.08.2012 01:35, Michael Stahl wrote: this is a rather stupid regression in 3.5.6, introduced by the fix for fdo#38056 which can cause crashes because the invalidation is in the wrong place please push the fix to libreoffice-3-5-6 and libreoffice

Re: [PUSHED] fdo#48549 System::Beep() removal

Adding [PUSHED] to the subject. http://cgit.freedesktop.org/libreoffice/core/commit/?id=85cb9084533605657aca0394afe4516058a8e4ef ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: 2 commits - sc/source

sc/source/ui/app/inputwin.cxx | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) New commits: commit 8e9f9afbe6eb9d676e678f208db48f30a6561af1 Author: Ivan Timofeev timofeev@gmail.com Date: Sat Aug 4 17:29:06 2012 +0400 calc input line: don't reset the scrollbar

  1   2   3   4   5   6   >