___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
This patch only fixes crash, changing of background still does not work. It
seems to be the small mistake in commit
1be43c60fb32783312c18e4f65d63f4d7a55ca70
From 08c3001bf59e671eae7cd3153d83d00d95f8c437 Mon Sep 17 00:00:00 2001
From: Ivan Timofeev
Date: Wed, 14 Sep 2011 21:49:17 +0400
Subject
Oops... Forgive me for my haste. Previous patch was incorrect. :( I have
created the new one.
From 094af00979359279641b8b58c1540c5df2f0f1b0 Mon Sep 17 00:00:00 2001
From: Ivan Timofeev
Date: Fri, 16 Sep 2011 17:48:47 +0400
Subject: [PATCH] fdo#38391: don't crash while dropping texture
--
This patch fixes crash when you input incorrect range of pages in "Print"
dialog, "General" tab, "Pages" textfield and layout is set to "Brochure".
http://nabble.documentfoundation.org/file/n3344034/Fix-for-fdo-35513.patch
Fix-for-fdo-35513.patch
--
View this message in context:
http://nabble.d
Michael Meeks wrote:
>
> Thanks ! I've just pushed it to master
>
That's great! :)
Michael Meeks wrote:
>
> can you confirm that this and all your future patches are licensed
> MPL/LGPLv3+ ? :-) [ and preferably
> add a link to that in the wiki here:
> http://wiki.documentfoundati
I confirm that all my patches to LibreOffice are licensed under
LGPL3+/GPL3+/MPL.
Ivan Timofeev.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
I'm glad to see my patches in master! :-) Thanks!
2011/9/20 Caolán McNamara :
> I don't *think* we need to move the code around, the check for empty is
> sufficient so I shrank it down to that bit.
Hmm, when in "brochure" layout, try to input incorrect range and you
will see "No pages" on the pri
> I think this lines should (?) be moved below the newly introduced check.
*This* lines:
rPagePairs.clear();
rValidPagesSet.clear();
rValidStartFrms.clear();
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mail
2011/9/20 Caolán McNamara :
> Hmm, if in normal mode I type in 3-4 I get that range previewed, change
> it to "foobar" and it stays previewing 3-4, which isn't great either
> really.
In normal layout in Writer and in any modes in other apps, i.e.
brochure layout in Writer is the only dissimilar pl
2011/9/21 Caolán McNamara :
> So I reckon we might be better off modifying
> StringRangeEnumerator::getRangesFromString to always clear its page
> vector argument, and then its probably worth being more forgiving and
> output what valid ranges in the text can be extracted before the
> invalid chars
2011/9/21 Caolán McNamara :
> Isn't it a good thing that the previous range isn't the one selected
> anymore when an invalid range has been entered ?
Maybe it is. But other apps have different behavior on processing invalid
range.
See results of my small test (in normal mode) for docs with 20 pa
2011/9/21 Caolán McNamara
> Did I just break this, or were they always so broken ?
No, I had tested on OOo 3.3 just now - same devilry.
> And do you want to fix it ? :-)
Yeah, I want. But since I'm newbie to source code, I'm working slowly.
However, if this is not time-critical, I will try.
___
Hello! I'm using gcc-4.5 and I've just got the following error while
compiling LibreOffice:
#pragma GCC diagnostic not allowed inside functions
The cause of error located in sal/inc/sal/types.h, line 469. It must
have "__GNUC_MINOR__ >= 6", I think.
You can make sure by comparing function "handle
second variant of the
condition.
From cea66ce0b9d68e7d67a051b1abbbd9a69842f34c Mon Sep 17 00:00:00 2001
From: Ivan Timofeev
Date: Fri, 23 Sep 2011 14:57:23 +0400
Subject: [PATCH] Fix for fdo#39898: don't crash on some invalid MathML
objects
---
starmath/source/mathmlimport.cxx | 94 +++-
Oh, I'm sorry... There is sawdust in my head...
Correction to previous message:
...in EndElement we can see:
if (pScriptNode->GetToken().aText.Len())
and in MiddleElement:
if (pScriptNode && ((pScriptNode->GetToken().eType != TIDENT) ||
(pScriptNode->GetToken().aText.Len(
In method EndElem
2011/9/23 Caolán McNamara :
> Looks sane to me. A good catch, pushed now.
He-he, I forgot to consider absolutely crazy cases - if
element is empty at all. Should this be fixed?
From b30f382e563675d2ffdf9a241b74c822720e6070 Mon Sep 17 00:00:00 2001
From: Ivan Timofeev
Date: Fri, 23 Sep 2011
This patches replace MultiSelection with StringRangeEnumerator in
Draw, because StringRangeEnumerator allows duplicated and reversed
ranges, i.e. "1,1,3-1". Second patch contains only cleaning changes.
From 85168ff499322b97256af3f0cb07c5bf7af3bca8 Mon Sep 17 00:00:00 2001
From: Ivan Timo
;+1".
From d4ed0f5f1cc5e34fdad1cfdc1a6f4e46e1e49ccc Mon Sep 17 00:00:00 2001
From: Ivan Timofeev
Date: Tue, 4 Oct 2011 17:16:34 +0400
Subject: [PATCH] fix doubling of one page when range is empty and incorrect
selection page
---
sd/source/ui/view/DocumentRenderer.cxx | 25 ++---
1 fi
oops, I've said "+ 1", but wrote "- 1" to patch. I'm sorry.
From 754322a700c43d84f3c17926dd5d993a08f46ee3 Mon Sep 17 00:00:00 2001
From: Ivan Timofeev
Date: Tue, 4 Oct 2011 17:16:34 +0400
Subject: [PATCH] fix doubling of one page when range is empty and incorrect
Hello, let me ask a few questions.
1. I've performed my first push today and received this message:
2011/10/6
> Your mail to 'Libreoffice-commits' with the subject
>
> .: tools/source
>
> Is being held until the list moderator can review it for approval.
>
> The reason it is being held:
>
>
Thanks a lot for all useful tips! :-)
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
2011/10/20 Daniel Di Marco :
> I replaced some more SvUShorts with std::vectors.
http://cgit.freedesktop.org/libreoffice/core/commit/?id=593e4c36d2f199cc3b82be587bc7674c2f394d06
Pushed. Thank you! ;)
___
LibreOffice mailing list
LibreOffice@lists.freedes
Hi,
I dug into http://openoffice.org/bugzilla/show_bug.cgi?id=89051 and
I've stalled...
--Some explanations.--
When inserting a point there is a call to
SdrDragView::ImpBegInsObjPoint (svx/source/svdraw/svddrgv.cxx).
Inside it:
- we remember the number of new point in a polypolygon:
mnInsPoin
Hi Kendy,
2011/11/2 Jan Holesovsky :
> Very nice analysis! According to what you described, the 1. (changing
> the order) sounds great to me, and works nicely too :-) - so I have
> pushed that, if you don't mind:
Thank you for the approval, I was inclining to push that, too.
Ivan
__
2011/11/7 Michael Meeks :
>
> On Mon, 2011-11-07 at 11:57 +0100, Luc Castermans wrote:
>> The last thing: I found "patch making" instructions on the Libo site.
>> If there are better ones, I like to receive them.
>
> Just doing 'git diff > /tmp/foo.diff' can be good
You can also use 'git d
Hi Emanuele,
2011/11/3 Emanuele Fia :
>>git reset -hard HEAD~1 # warning this looses the head commit
>>before running ./g pull -r to avoid conflicts (assuming you didn't do
>>any more commits yet).
>
> This is for reset my local repo and restore the current version on git
> repository ?
You need
The patch fixes this.
If someone will approve the patches, I will push them.
Thanks,
Ivan
From bc7d667dccb8505516614daa5fb7da7996967617 Mon Sep 17 00:00:00 2001
From: Ivan Timofeev
Date: Wed, 16 Nov 2011 15:47:51 +0400
Subject: [PATCH 1/2] fix fdo#42178: crash when printing from Page Previe
2011/11/16 Michael Stahl :
> your workaround looks good (but please add an assertion for the case
> that we don't get any page number, i.e. OSL_ENSURE(pPreView,...))
Ok!
> isn't m_pPrintUIOptions supposed to be deleted when
> SwXTextDocument::render is called for the last page (and there is
> spe
2011/11/16 Michael Stahl :
> please try it out: remove the 4 lines, then try print and cancel, then
> try print and close-the-document (to get a high page count just print
> 1000 copies), see that we survive that in Calc and Writer.
Can not reproduce crash with removed lines. :-) Have tried in Wri
I have played with manual solving of this problem today... :-) There are
the more interesting examples:
- else if(pUserMarker)
+ else
{
delete pUserMarker;
pUserMarker = 0L;
}
and
- if( GetPageNum() > 0 && pCntntAnchor )
+ if( GetPageNum() > 0 )
{
delete pCntntAnchor;
Actually, c
16.11.2011 21:27, Ivan Timofeev пишет:
Can not reproduce crash with removed lines.
Oh, what a terrible formulation! I mean, "Can not reproduce crash, even
without the mentioned lines of code."
So, should I commit this removal?
Best Regards,
Hi Muthu,
18.11.2011 15:38, Muthu Subramanian K пишет:
That code is inside the constructor.
and the constructor sets the variable pUndoSet to NULL right on the top.
So, the if would always fail! Unless I am missing something. Looks too
trivial to be true ;)
I don't see any way to assign non-NU
Pushed, many thanks for the review! ;)
Cheers,
Ivan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Hi Moray,
2011/11/24 moray33 :
> Hi. I found a bug in LibreOffice Writer. I don't know programming, so I post
> the problem here if someone can fix it. I would help me and I'm sure other
> people a lot.
>
> I told the problem here:
> http://nabble.documentfoundation.org/Images-get-smaller-and-defo
Hi all,
we have the field 'SwSortedObjs* pSortedObjs' in the class SwPageFrm.
And we have the strange management of it:
For example, sw/source/core/layout/flylay.cxx:734
if ( pSortedObjs )
{
pSortedObjs->Remove( *pToRemove );
if ( !pSortedObjs->Count() )
{ DELET
Hello Michael,
2011/11/25 Michael Stahl :
> On 24/11/11 19:07, Ivan Timofeev wrote:
>> [...]
>> What do you think about changing the code so that pSortedObjs will be
>> alive every time? We will be able to return a reference to pSortedObjs
>> in GetSortedObjs() instead
2011/11/28 Michael Stahl :
> On 25/11/11 19:05, Ivan Timofeev wrote:
>> Well, another possible memory optimization is to merge
>> SwSortedObjsImpl into SwSortedObjs. What is the reason to use the
>> "pImpl" pattern here?
>
> usually pImpl is a good idea bec
Hi there!
Please review
http://cgit.freedesktop.org/libreoffice/core/commit/?id=dc61ebdc93a777f4f41c1ae837bdb6098ecffcce
and push to 3-4 if the commit is ok for you.
It seems, due to wrong condition (using & instead of ==) the code casted
SwCntntNode to SwTxtNode, but the SwCntntNode is a base
08.12.2011 23:36, Ivan Timofeev пишет:
Hi there!
Please review
http://cgit.freedesktop.org/libreoffice/core/commit/?id=dc61ebdc93a777f4f41c1ae837bdb6098ecffcce
and push to 3-4 if the commit is ok for you.
It seems, due to wrong condition (using & instead of ==) the code casted
SwCntntNod
09.12.2011 15:26, Michael Meeks пишет:
Hi Ivan,
On Fri, 2011-12-09 at 09:44 +0400, Ivan Timofeev wrote:
Oh no, wait, I was getting all mixed up :(
This is not a fix for the mentioned bug, the proper fix was
http://cgit.freedesktop.org/libreoffice/core/commit/?id
Hi Olivier,
10.12.2011 04:29, Olivier Hallot пишет:
Please find attached a partial fix for Easy Hack FDO43460,
Part II
Module basctl
very nice, pushed now:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=1688a9d9235dd2ee4f3b9497308efd41f7a3fb6f
Thanks!
Ivan
__
...and I forgot to change the subject :)
Ivan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
10.12.2011 20:34, Olivier Hallot пишет:
Please find attached a partial fix for Easy Hack FDO43460,
Part III
Module basic
Pushed, thank you! :)
May I suggest you to remove unnecessary parentheses in addition? i.e
sal_Bool bOldPassword = ( !OldPassword.isEmpty() );
can be
sal
12.12.2011 20:05, Caolán McNamara пишет:
On Sat, 2011-12-10 at 19:23 +0100, Marcel Metz wrote:
Hello lo-devs,
This patch series replaces some DECLARE_TABLE macros with
the std::map equivalent.
Looks good to me. Thanks for this, pushed now.
Hmm... looking at this I think that
- else if ( !m
Hi all,
the bug: https://bugs.freedesktop.org/show_bug.cgi?id=41264
briefly: in the context menus (except the toolbar's ones) icons are not
shown for radio menu items and for checked menu items.
Rainer assigned it to me, so... :)
looking at the drawing code (vcl/source/window/menu.cxx):
Hi Olivier,
10.12.2011 23:38, Olivier Hallot пишет:
Please find attached a partial fix for Easy Hack FDO43460
Part IV
Module
basic (small cosmetic fix per demand of Ivan Timofeev)
binaryurp
bridges
ah, I meant doing cosmetics only for future works... Sorry, sometimes I
express my thoughts
11.12.2011 04:08, Olivier Hallot пишет:
Please find attached a partial fix for Easy Hack FDO43460
Part V
Module
chart2
pushed:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=0eac98aa742e8e76ebb1af91b32bd02e04b2e20a
Thank you!
Ivan
___
Li
13.12.2011 00:24, Olivier Hallot пишет:
Please find attached a partial fix for Easy Hack FDO43460
Part VI
Module
codemaker
http://cgit.freedesktop.org/libreoffice/core/commit/?id=fd866ac8f184c0910883963c9c12b45a239a9227
nice work!
Regards,
Ivan
___
Hi Olivier,
13.12.2011 05:08, Olivier Hallot пишет:
Please find attached a partial fix for Easy Hack FDO43460
Part VII
Module
comphelper
Not sure whether this improves readability:
+++ b/comphelper/source/misc/storagehelper.cxx
@@ -522,7 +522,7 @@ sal_Bool OStorageHelper::PathHasSegment( con
forgot to change the subject again!
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
14.12.2011 17:01, Michael Meeks пишет:
On Wed, 2011-12-14 at 15:32 +0400, Ivan Timofeev wrote:
If I understood you right, the MENU_FLAG_SHOWCHECKIMAGES flag was
introduced to control whether a simple check mark [x] or an image should
be painted with a checkable menu item; if it is so, it don&#
Hi Olivier,
14.12.2011 17:39, Olivier Hallot пишет:
Please find attached a partial fix for Easy Hack FDO43460
Part VIII
Module
configmgr
http://cgit.freedesktop.org/libreoffice/core/commit/?id=4a0ab53cf44be11053a095470ad8cb426487dbc6
Thank you,
Ivan
__
15.12.2011 05:18, Olivier Hallot пишет:
Please find attached a partial fix for Easy Hack FDO43460
Part IX
Module
connectivity
(this one is quite big)
it seems that you forgot to change the second condition:
-if ( !pMasterFields->getLength() ||
!pDetailFields->getLength() )
+
15.12.2011 23:35, Olivier Hallot пишет:
Please find attached a partial fix for Easy Hack FDO43460
Part X
Module
cppu
cppuhelper
cpputools
great!
http://cgit.freedesktop.org/libreoffice/core/commit/?id=1b99d8800e399f45404ab62827163a873d2a1aec
Thanks,
Ivan
__
101 - 200 of 514 matches
Mail list logo
