Re: [Libreoffice] [PATCH] Fix for fdo43460 Part XI getLength() to isEmpty()

Hi Olivier, 16.12.2011 23:33, Olivier Hallot пишет: Please find attached a partial fix for Easy Hack FDO43460 Part XI Module cui sorry for the delay, (he-he, now I know how to resolve conflicts :) pushed: http://cgit.freedesktop.org/libreoffice/core/commit/?id=1375183d465fb17db513dfe16ac522e4

Re: [Libreoffice] [PUSHED][PATCH] Fix for fdo43460 Part XI getLength() to isEmpty()

marking as pushed... ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] fixing fdo#41264: no check marks in Line Spacing and ALignment popup menu

Having fresh look into this problem, I think we should come to nothing more than: http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5&id=746cde4adb386e26ec3368198b4d893db16ee2cc I realize that it's a dirty hack and you can blame me for negligence here, but if we want to follo

Re: [Libreoffice] [PUSHED][PATCH] Fix for fdo43460 Part XIV getLength() to isEmpty()

Hi Gustavo, 23.12.2011 21:21, Gustavo Pacheco пишет: Hi! Partial fix for Easy Hack FDO43460 (part XIV) for review. Mentoring by Olivier Hallot (thanks for the tips Olivier!). Part XVI Modules drawinglayer, dtrans and editeng Looks nice for me, but -if (aLocale.Language.getLength

Re: [Libreoffice] [PUSHED][PATCH] Fix for fdo43460 Part XVII getLength() to isEmpty()

Hi Olivier, 24.12.2011 00:26, Olivier Hallot пишет: Please find attached a partial fix for Easy Hack FDO43460 Part XVII Module fileaccess and filter Pushed: http://cgit.freedesktop.org/libreoffice/core/commit/?id=e7bddf732798508e347221590110486e97bb45e6 Thanks a lot! Ivan __

Re: [Libreoffice] [PUSHED][PATCH] Fix for fdo43460 Part XIX getLength() to isEmpty()

26.12.2011 01:35, Olivier Hallot пишет: Please find attached a partial fix for Easy Hack FDO43460 Part XIX Module formula and fpicker Pushed: http://cgit.freedesktop.org/libreoffice/core/commit/?id=3e4f51f112248b4e586f5bd86388099737ed17e9 Great work, thank you! Ivan _

Re: [Libreoffice] minor problem with Insert -> indexes and tables dialog

Hi Kaplan, 27.12.2011 03:04, Lior Kaplan пишет: The in Insert -> Indexes and Tables dialog, the word "Preview" (bottom right corner in English interface) is trimmed. See screenshot (3.5.0 beta2). In RTL interface the same problem happens, and with a longer translation more of the text is trimmed

Re: [Libreoffice] minor problem with Insert -> indexes and tables dialog

Hi Jan, 27.12.2011 17:45, Jan Holesovsky пишет: The good news is that I fixed an unrelated text cut in my native language& a visual annoyance there ;-) http://cgit.freedesktop.org/libreoffice/core/commit/?id=3a38a8514ab33f9d8b174000ca635db949c16940 Our *.src-based UI is a real disaster. This

Re: [Libreoffice] bug 36874 (label printing) further improvement?

someone who is willing to improve/change the UI Hello, Ivan Timofeev was very active eliminating problems and improving GUI. Ivan, what do you think? Are you interested? Interested, but extremely busy the whole January through... :-( I'm sorry. But an UI is an easy piece of progra

Re: [Libreoffice] [PUSHED][PATCH] Correct ARCCOSH's parameter description

Hi Korrawit, 31.12.2011 14:46, Korrawit Pruegsanusak пишет: I found this while translating. Could someone please review it? Looks great! Nice catch, thanks! :) Also, if this patch could be pushed in -3-5 branch as well? I've found the wiki page [1] says hard string freeze is next week. So, i

Re: [Libreoffice] minor problems with format -> page -> organizer

06.01.2012 20:57, Lior Kaplan пишет: Anyone ? I'll try... :) On Mon, Jan 2, 2012 at 5:13 PM, Lior Kaplan wrote: Hi, 1. The format -> page -> organizer tab is missing a space between the page orientation and the page direction. You'll notice it as "PortraitLeft" instead of "

Re: [Libreoffice] [PUSHED][PATCH] Remove superfluous _ZFORLIST_DECLARE_TABLE definition.

Hello Marcel, 07.01.2012 20:19, Marcel Metz пишет: this patch removes the superfluous _ZFORLIST_DECLARE_TABLE define that is explicit defined right in in front of the conditional code. Cool, you've killed this ancient and ugly definition. :) Thanks! Pushed: http://cgit.freedesktop.org/libreoff

Re: [Libreoffice] [REVIEW] Cherry-pick in 3.5 (3.4 ?) for fdo#44065

Hello Julien, 07.01.2012 20:57, julien2412 пишет: Would it be possible to cherry-pick the commit http://cgit.freedesktop.org/libreoffice/core/commit/?id=948f57e74dda7e64b7c72208eaec00eac1bb96ba in 3.5 branch ? It's a very quick and easy fix for fdo#44065. He-he, copy-paste negligence... :) No

Re: [Libreoffice] [REVIEW] Re: minor problems with format -> page -> organizer

07.01.2012 22:37, Lior Kaplan пишет: This fix is also relevant a few lines bellow, adding a patch to include them both. Yep, feel free to push. It is anyway doubtful whether sticking two different-meaning strings together is good idea. Ivan ___ Lib

Re: [Libreoffice] [REVIEW] Cherry-pick in 3.5 (3.4 ?) for fdo#44065

Hi Korrawit, 08.01.2012 18:11, Korrawit Pruegsanusak пишет: On Sun, Jan 8, 2012 at 01:44, Ivan Timofeev wrote: And +1 for 3-4. Could you please push it? :-) Because the -3-4 branch requires only 1 reviewer after last beta. [1] [1] http://wiki.documentfoundation.org/Development/Branches

[Libreoffice] error in writerperfect?

Hi, glancing over the git-log I have noticed the following code writerperfect/source/filter/OdgGenerator.cxx:951 if (!propList["libwpg:mime-type"] && propList["libwpg:mime-type"]->getStr().len() <= 0) return; Is there should be || instead of && ? Regards, Ivan __

Re: [Libreoffice] [PATCH] Bug 33794 - The "Open..." button of the initial screen needs more room for localization fdo#33794

Hello, 13.01.2012 18:15, Tomcsik Bence Tibor пишет: Hi, Bug 33794 solved. IMHO it's better to pass some additional parameter to the layoutButton function ( e.g. int i_nExtraWidth = 0 ) and change: nTextWidth += maButtonImageSize.Width() + 8; // add some fuzz to be on the safe side t

[Libreoffice] [REVIEW] fdo#43932: try to fix paper tray settings

Hi there, https://bugs.freedesktop.org/show_bug.cgi?id=43932 this patch partially reverts http://cgit.freedesktop.org/libreoffice/core/commit/?id=4cc5448ed82f13bb107695b65f39589df1e46cb9 because the following change made the option "[ ] Use only paper tray from printer preferences" useless: @@

Re: [Libreoffice] [REVIEW] fdo#43932: try to fix paper tray settings

forgot to attach the patch. >From bae6b73a56cf4fcfffe21aa9f3f9ccce87e890cd Mon Sep 17 00:00:00 2001 From: Ivan Timofeev Date: Fri, 13 Jan 2012 21:50:55 +0400 Subject: [PATCH] fdo#43932: try to fix paper tray settings --- vcl/source/gdi/print3.cxx | 25 ++--- 1 fi

Re: [Libreoffice] [PATCH] Simple fix for fontconfig.cxx to review (from cppcheck report)

Hi Mat, 15.01.2012 03:29, Mat M пишет: Hello Le Sat, 14 Jan 2012 16:00:31 +0100, julien2412 a écrit: Hello, cppcheck reported this : core/vcl/generic/fontmanager/fontconfig.cxx 196 duplicateExpression style Same expression on both sides of '-' class SortFont : public ::std::binary_function

Re: [Libreoffice] [PUSHED][PATCH] Bug 33794 - The "Open..." button of the initial screen needs more room for localization fdo#33794

14.01.2012 03:30, Tomcsik Bence Tibor пишет: I send the new patch. Ok, pushed to the master branch and cherry-picked to libreoffice-3-5: http://cgit.freedesktop.org/libreoffice/core/commit/?id=1f628c7bf8361086be2044d0d6aa8bbf3f128162 http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreo

[Libreoffice] [REVIEW 3-5, 3-4] fdo#43193: fix rotation of shapes in imported MS documents

Hello, I want to push the following commit to 3-5 and to 3-4: http://cgit.freedesktop.org/libreoffice/core/commit/?id=005d6524977bd51ce2f859b5ae5352a2fba68dd0 It fixes: https://bugs.freedesktop.org/show_bug.cgi?id=43193 partially reverting: http://cgit.freedesktop.org/libreoffice/core/commit/?id

Re: [Libreoffice] [REVIEW 3-4] fdo#43193: fix rotation of shapes in imported MS documents

17.01.2012 16:49, Thorsten Behrens пишет: Seen pushed on -3-5 Great, thanks! -3-4 is still pending. Ivan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] minutes of ESC call ...

dubious quality though :) - attaching it. So, I either have to reassign the bug to Thorsten or have to ask how to make the patch better. :) Thorsten, are you working on this already? Best Regards, Ivan >From 186a015831027d5a8c77a0110b49b3e4614ac38d Mon Sep 17 00:00:00 2001 From: Ivan Tim

Re: [Libreoffice] [PUSHED][PATCH] proposed fix for fdo#44283

11.01.2012 22:15, Lionel Elie Mamane пишет: On Wed, Jan 11, 2012 at 04:22:59PM +, Caolán McNamara wrote: Looks good to me on the surface anyway. Go for it I say for master and 3.5. Lionel ? are we right here ? Yes, that patch is right. I committed (and pushed) a slightly extended version o

Re: [Libreoffice] [REVIEW] fdo#44915 missing MSI localizations

Hi Andras, 20.01.2012 02:33, Andras Timar пишет: http://cgit.freedesktop.org/libreoffice/core/commit/?id=5d2f27834abd9ea13556387ffa7f773587edbebc #offtopic: My native windows build had failed on that call to msiinfo.exe, it would be nice to build with your patch again... Cheers, Ivan __

[Libreoffice] [REVIEW 3-5] fdo#43705: fix incomplete updating of the page preview pane in Draw

Hi, https://bugs.freedesktop.org/show_bug.cgi?id=43705 (regression since 3.4) The fix for review: http://cgit.freedesktop.org/libreoffice/core/commit/?id=799f2de5d1085d845ec498af0a7932965c42ed68 Thanks, Ivan ___ LibreOffice mailing list LibreOffice@li

Re: [Libreoffice] [PUSHED] send-feedback patch

Hi Thorsten, 23.01.2012 15:40, Thorsten Behrens пишет: Sorry for the lag - patch is fine as-is I think, let's add the startcenter icon etc. as/when they arrive. Thanks for reviewing/pushing! I was afraid that the hard-coded url is not fine, because I saw another urls in instsetoo_native/util

Re: [Libreoffice] [REVIEW] fdo#43932: try to fix paper tray settings

17.01.2012 16:05, Caolán McNamara пишет: On Fri, 2012-01-13 at 22:22 +0400, Ivan Timofeev wrote: Hi there, https://bugs.freedesktop.org/show_bug.cgi?id=43932 this patch partially reverts http://cgit.freedesktop.org/libreoffice/core/commit/?id=4cc5448ed82f13bb107695b65f39589df1e46cb9 because

Re: [Libreoffice] [REVIEWED] fdo#43932: try to fix paper tray settings

24.01.2012 15:56, David Tardon пишет: Oops, sorry... It seems it does not work: the tray setting is always reset to 'Auto' again. Oh, well then my patch is wrong. I'm sorry for my fallacy... No another idea on this bug, and no idea of testing patches without a multitray printer, I'll reset as

Re: [Libreoffice] LibreOffice Code Cleanup Patch

27.01.2012 08:55, Muthu Subramanian K пишет: @Alex: Forgot to mention one more thing: We follow (normally) space after '(' and before ')' if there are parameters. Sometimes, we would be tempted to remove the space in cases like foo( param1, param2 ); as well ;) ( I am always tempted in such cases

Re: [Libreoffice] Duplicate expression in sd/source/ui/view/outlview.cxx

Hi Julien, 28.01.2012 11:12, julien2412 пишет: So either the duplicated part (obviously "mpOutliner != NULL") could be simply removed or perhaps the author thought about this : mpOutlineViewShell != NULL mpOutlineViewShell is initialized and dereferenced in the ctor, and keeps its value al

Re: [Libreoffice] [PUSHED][PATCH] Remove unused code

Hi Santiago, 28.01.2012 02:02, Santiago Martinez пишет: This patch removes unused code as listed in unusedcode.easy Pushed, thank you! http://cgit.freedesktop.org/libreoffice/core/commit/?id=2b507836fc88f294ef55652174b66dc706125599 Cheers, Ivan ___

Re: [Libreoffice] [PATCH] fdo#45285 - Use more revealing error message for not allowed sheet names

28.01.2012 08:41, Korrawit Pruegsanusak пишет: Hello guys, Forwarding this to ux-advise. Could you please have a look? Thanks :-) On Sat, Jan 28, 2012 at 07:19, Albert Thuswaldner wrote: Hi, Here is a simple patch which includes a more informative error message when the user enters an invali

[Libreoffice] [PATCH] follow-up of fdo#30788: fix showing of unnecessary empty horizontal scrollbar

n Sep 17 00:00:00 2001 From: Ivan Timofeev Date: Sun, 29 Jan 2012 14:08:54 +0400 Subject: [PATCH] follow-up of fdo#30788: fix showing of unnecessary empty horizontal scrollbar --- sw/source/ui/uiview/scroll.cxx |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/sw/source/

Re: [Libreoffice] [Libreoffice-ux-advise] [PATCH] [PUSHED] fdo#45285 - Use more revealing error message for not allowed sheet names

30.01.2012 13:07, Stefan Knorr (Astron) пишет: the idea sounds good, ... patch is simple, and the details seem to be correct now. Thus, I've taken the liberty to replace "can" by "may" and then push to master. just added ':' to the sequence of characters http://cgit.freedesktop.org/libreoffice/

Re: [Libreoffice] [PUSHED][PATCH] Removed unused ImplSalLogFontToFontA()

31.01.2012 15:15, Noel Power пишет: Hi Christina On 31/01/12 10:43, Chr. Rossmanith wrote: Hi, ImplSalLogFontToFontA() seems to be unused. I don't have a Windows build environment I couldn't test whether it really builds after removing the method. But I don't see why it shouldn't... Christina

Re: [Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector

31.01.2012 18:22, Noel Power пишет: On 30/01/12 13:54, Noel Grandin wrote: Attached patch converts SdCustomShow to use std::vector. I hate these remove list etc. type patches as they tend to be tricky and time consuming to look at ;-) . The patch looked ok for me, hopefully if I missed somethin

Re: [Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector

31.01.2012 19:42, Noel Grandin пишет: So I should be calling maPages.erase( std::find(maPages.begin(), maPages.end(), pOldPage) ); ?? maPages.erase( std::remove(maPages.begin(), maPages.end(), pOldPage), maPages.end() ); I'll fix that. Ivan ___ Li

Re: [Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector

31.01.2012 19:55, Ivan Timofeev пишет: I'll fix that. Hum; guys, what about - mpSdCustomShow->Remove(pPage->GetSdrPage()); + ::std::remove(mpSdCustomShow->PagesVector().begin(), mpSdCustomShow->PagesVector().end(), + pPage->GetSdrPage()); mpSdCustomShow->R

Re: [Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector

31.01.2012 21:12, Noel Power пишет: should remove the first occurrence, care to fix ? so the exact equivalent of mpSdCustomShow->Remove(pPage->GetSdrPage()) will be: SdCustomShow::PageVec::iterator it = std::find( mpSdCustomShow->PagesVector().begin(), mpSdCustomShow->PagesVector().e

Re: [Libreoffice] [PUSHED][PATCH V2] convert SdCustomShow from tools/list to vector

31.01.2012 21:44, Noel Power пишет: hey I've already proved my (non) STL credentials :-) , but.. if we are to believe the old code then mpSdCustomShow->Remove(pPage->GetSdrPage()); would call Container::Remove( void* p ) which would call Container::Remove( Container::GetPos( p ) ) which afaics de

Re: [Libreoffice] [Libreoffice-ux-advise] [PATCH] [PUSHED] fdo#45285 - Use more revealing error message for not allowed sheet names

Hi Eike, 31.01.2012 17:41, Eike Rathke пишет: Yup, good catch. Technically there's also the limitation that a ' single quote character is not allowed as the very first or last character. The message would get quite lengthy though if we added "and not the character ' at the beginning or end". I

Re: [Libreoffice] [PATCH] follow-up of fdo#30788: fix showing of unnecessary empty horizontal scrollbar

Hi Caolán, 30.01.2012 21:08, Caolán McNamara пишет: The original code with... git show 7b0b5cdf source/ui/inc/scroll.hxx source/ui/uiview/scroll.cxx it seems that this SwScrollbar had its own SwScrollbar::Show method and inherits from Window which has a Window::Show method as well. The Window::S

Re: [Libreoffice] [PUSHED][PATCH] Removed unused ImplSalLogFontToFontA()

Hello Cor, 03.02.2012 23:56, Cor Nouws пишет: Do I see a contradiction below? Ivan Timofeev wrote (31-01-12 12:16) I've just pushed it. Caolán McNamara wrote (31-01-12 14:21) Its windows only code, and callcatcher can only see what gets compiled as its just a compiler wrapper and I r

Re: tail_build is a discouraging PITA

Hi Olivier, 05.02.2012 02:13, Olivier Hallot пишет: it is now 3 days I cannot build master because of tail_build. editeng/source/editeng/edtspell.cxx:508: #ifdef DBG_UTIL sal_Bool WrongList::DbgIsBuggy() const { ... } #endif remove the surrounding ifdef and then the linker should find thi

[PUSHED][PATCH] Remove unused code

Hi Elton, thanks for your patch; I tweaked it a bit and then pushed. Notes: 1. ScVbaWorksheet( const css::uno::Reference< ov::XHelperInterface >& xParent, const css::uno::Reference< css::uno::XComponentContext >& xContext ); is *not* unused, we can see it at least in sc/source/ui/vba/vbawork

[PUSHED][PATCH] Remove unused code (2)

Pushed, thanks; however I have returned ScSubTotalDescriptorBase::GetData(ScSubTotalParam&) const ScSubTotalDescriptorBase::PutData(ScSubTotalParam const&) back to the header, because these functions are is pure virtual, and the implementations in ScSubTotalDescriptorBase is unused, not the all

[PUSHED][PATCH] Remove unused code (3)

pushed this one after all. SfxMedium::GetHdl() seems to be used for now (in tools/inc/tools/ref.hxx), maybe we can remove all of those macro definitions... I also removed 'using SfxControllerItem::GetCoreMetric;' statement from sfx2/inc/sfx2/unoctitm.hxx, and then the build has succeeded.

Re: tail_build is a discouraging PITA

05.02.2012 15:15, Ivan Timofeev пишет: remove the surrounding ifdef and then the linker should find this function. I committed this change. Don't know why I didn't commit it at that time. %-| By the way... 05.02.2012 02:13, Olivier Hallot пишет: All fail in tail_build, a module

Re: [PATCH] Reduced duplicate code (simian) / l10ntools

Hi Christina, 05.02.2012 20:26, Chr. Rossmanith пишет: there were three blocks of nearly identical code. Awful! Thanks for working on this task. I've moved them to a method ResData2Output(). Please review. Looks nice. All of the differences seem to be handled... > bWriteNoSlash seems to b

Re: [PATCH] Reduced duplicate code (simian) / l10ntools

05.02.2012 23:37, Chr. Rossmanith пишет: I've moved them to a method ResData2Output(). Please review. Looks nice. All of the differences seem to be handled... Oh, oh, oh! No, we must pass all the different values as paramerers to the function. Because it was if ( pEntry && pResData->bText

Re: [PATCH reworked] Reduced duplicate code (simian) / l10ntools

06.02.2012 00:13, Chr. Rossmanith пишет: I've added a third parameter nType to ResData2Output() (s. reworked attached patch) The following string concatenation argument have to be passed as a parameter as well. +if ( pResData->bText ) +sOutput += pResData->sTextTy

Re: [Libreoffice] [REVIEW]Bug 34425 - [EasyHack] formatting background color toolbar button

06.02.2012 11:36, Winfried Donkers пишет: Please open bugs for each of these, you can put me as assignee. There is the one for Background Colour in Writer... https://bugs.freedesktop.org/show_bug.cgi?id=44611 - the only that I remember. Ivan ___ Libr

Re: [PATCH reworked] Reduced duplicate code (simian) / l10ntools

On 06.02.2012 13:34, Chr. Rossmanith wrote: I have replaced parameter ResData *pResData (which became ununsed) with parameter rtl::OString sTextType. Or should it be rtl::OString& sTextType instead? A reference is better, however it is not really performance-critical I think. But if so, refere

Re: [ANNOUNCE] Changes to the build system: Env.Host.sh is dead so is the need to source the environment

Hi Norbert, great work, thank you very much! I noted some new points: * 'make dev-install' does not create install/program * 'make' does not run autogen.sh automatically after 'make clean' Regards, Ivan ___ LibreOffice mailing list LibreOffice@lists.f

Re: [ANNOUNCE] Changes to the build system: Env.Host.sh is dead so is the need to source the environment

* 'make' does not run autogen.sh automatically after 'make clean' why would autogen.sh be necessarily ran after a make clean ? make clean is not suppose to remove config_host.mk or any configure.in generated file. Oops, now all work fine, the first time I cleaned the tree and then ran 'make' i

[PUSHED] Reduced duplicate code (simian) / l10ntools

Ok, pushed, the patch is simply brilliant now! ;) I think we can defy the tests after all. I apologize for my hair-splitting while reviewing it. Thanks, Ivan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/m

Re: [PATCH] follow-up of fdo#30788: fix showing of unnecessary empty horizontal scrollbar

there is no any visual effect, no any right border. What fun! :) Best Regards, Ivan >From 7130fb70b63e076c493932966b3b4139ae236b6d Mon Sep 17 00:00:00 2001 From: Ivan Timofeev Date: Thu, 9 Feb 2012 21:06:06 +0400 Subject: [PATCH] always use the *real* visibility of the SwScrollbar ---

Re: [Libreoffice] [PUSHED-partially][PATCH]a better about dialog

On 08.02.2012 23:49, Stephan Bergmann wrote: On 02/08/2012 07:13 PM, Ivan Timofeev wrote: I didn't try German, but see how it looks in Russian in the attached screenshot. The problem is that the new links start with '=' and are quoted. Looks like a bug somewhere. That looks su

Re: [PATCH] Remove unused code (5)

On 10.02.2012 18:24, Elton Chung wrote: This patch removes 5 unused methods. Pushed, thank you. Regards, Ivan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] avoid Possible null pointer dereference in linguistic/source/spelldsp.hxx

Hi Julien, On 11.02.2012 19:21, julien2412 wrote: Cppcheck reports this : [spelldsp.hxx:138]: (error) Possible null pointer dereference: pCache - otherwise it is redundant to check if pCache is null at line 136 Here are the lines : 134 inline linguistic::SpellCache& SpellCheckerDispatcher

Re: [PATCH] avoid Possible null pointer dereference in linguistic/source/spelldsp.hxx

On 11.02.2012 20:13, julien2412 wrote: What about the Riccardo's suggestion ? Oh, it is better then mine wrt cheating cppcheck :) But I hate the hacks like ((SpellCheckerDispatcher *) this)->... A type cast from const to non-const looks like a black magic to me. Regards, Ivan __

Re: [PATCH] fdo#37775 - EasyHack: Recent Documents not updated by Save & Save As...

On 08.02.2012 17:06, Muhammad Haggag wrote: Bug: https://bugs.freedesktop.org/show_bug.cgi?id=37775 Patch link: https://bugs.freedesktop.org/attachment.cgi?id=56740 Patch Review: https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=37775&attachment=56740 Changes (copied from patch): This

Re: [PATCH] convert table.hxx use in editeng/inc/editeng/forbiddencharacterstable.hxx

Hi Noel, On 10.02.2012 10:56, Noel Grandin wrote: Convert tools/table.hxx usage in editeng/inc/editeng/forbiddencharacterstable.hxx to boost::ptr_map ForbiddenCharactersInfo is simple wrapper for ForbiddenCharacters. It only adds the bTemporary flag. But bTemporary seems to be write-only, i.

Re: [PATCH] convert table.hxx use in editeng/source/editeng/editdoc.hxx

Hi Noel, On 10.02.2012 13:42, Noel Grandin wrote: Convert tools/table.hxx usage in editeng/source/editeng/editdoc.hxx to boost::ptr_map Your patch looks good to me. But... let's look at the usages of the SvxFontTable class. All of them are in editeng/source/editeng/impedit4.cxx. ImpEditEngin

Re: [REVIEW][3-5] Header/Footer and PageBreak indicators to be hidden in RO mode

Hi Cedric, Kendy, On 13.02.2012 14:24, Cedric Bosdonnat wrote: Could someone (kendy?) review and cherry-pick -s in -3-5 the following commit: http://cgit.freedesktop.org/libreoffice/core/commit/?id=beb8a85796c78d4cdcf6497b6725fce8f7141d75 What about hiding the indicators in the web layout mode

Re: [REVIEW][3-5] Header/Footer and PageBreak indicators to be hidden in RO mode

On 13.02.2012 18:26, Caolán McNamara wrote: On Mon, 2012-02-13 at 17:56 +0400, Ivan Timofeev wrote: Hi Cedric, Kendy, On 13.02.2012 14:24, Cedric Bosdonnat wrote: Could someone (kendy?) review and cherry-pick -s in -3-5 the following commit: http://cgit.freedesktop.org/libreoffice/core/commit

Re: [REVIEW 3-5] follow-up of fdo#30788: fix showing of unnecessary empty horizontal scrollbar

On 13.02.2012 18:20, Caolán McNamara wrote: So I've pushed it now :-) Thanks!! Is it worth being in 3-5? :) ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PUSHED] Remove unused code (8)

Hi Elton, Michael, On 13.02.2012 20:04, Michael Meeks wrote: On Sat, 2012-02-11 at 00:50 +0800, Elton Chung wrote: This patch removes 10 unused methods. Lovely; if you 'git grep bNetLock' - I think we can remove that item from the header, and it's remaining initialization too now (cou

Re: Tinderbox failure, last success: 2012-02-13 15:48:45

On 13.02.2012 21:08, nthieb...@gmail.com wrote: Hi folks, One of you broke the build of LibreOffice with your commit :-( Please commit and push a fix ASAP! [...] /Volumes/Raid0/core/solver/unxmacxi.pro/inc/svtools/ctrlbox.hxx: In member function 'void FontSizeBox::SetUserValue(sal_Int64)': /V

Re: [REVIEW 3-5] Fix for a crasher during copy-n-paste from Excel.

Hi Kohei, On 13.02.2012 21:40, Kohei Yoshida wrote: The problem happened when calc was not able to compile the formula string for whatever reason, in which case pCode would remain NULL after the Compile is called in one of its constructors. Sorry, I did not test the bug, but... ScFormulaCell:

Re: [PUSHED 3-5] Fix for a crasher during copy-n-paste from Excel.

On 13.02.2012 22:22, Kohei Yoshida wrote: Hi Ivan, On Mon, Feb 13, 2012 at 1:13 PM, Ivan Timofeev wrote: [...] A crash will be right here, inside Compile?.. No it does not. Oh, pardon, did not noticed one-line if - return: if ( pDocument->IsClipOrUndo() ) return; I dared to p

Re: [ANN] Referencing bugs in commits

On 14.02.2012 19:31, Michael Meeks wrote: On Tue, 2012-02-14 at 16:16 +0100, Jan Holesovsky wrote: Markus has implemented a nice feature that should help keeping the bugs up to date: whenever you are committing / pushing to git, and you ooh ! really lovely :-) Great work Mark

javadep.c & Java 7

Hi, I found soltools/javadep/javadep.c that contains a very simple parser for java class files. The problem is that it is old, at least it does not handle the class files generated by Java 7: as far as I remember, java guys added the new types of constant pool entries, but... javadep.c:520:

Re: javadep.c & Java 7

On 15.02.2012 20:41, Stephan Bergmann wrote: Apparently only remaining use is in the old build system (see solenv/inc/rules.mk, where it is called STARDEP). So I would not bother to invest any time in it -- as long as its shortcomings do not actually cause problems (which I don't quite get from y

Re: [PUSHED][PATCH] convert table.hxx use in editeng/inc/editeng/forbiddencharacterstable.hxx

Hi Noel, On 15.02.2012 19:01, Noel Grandin wrote: Updated patch implementing Ivan's suggestion. Passes make and make check. Convert tools/table.hxx usage in editeng/inc/editeng/forbiddencharacterstable.hxx to std::map Looks good to me, pushed (without GetCharInfo - it was unused): http://cgit

Re: [PUSHED][PATCH] convert table.hxx use in editeng/inc/editeng/forbiddencharacterstable.hxx

Whoa, I seem to be too naive for patch-reviewing... Is it a safe code? pForbiddenCharacters = &maMap[ nLanguage ]; return pForbiddenCharacters; Will pForbiddenCharacters point to the deleted object, after the return? Terribly sorry for such a question... Regards, Ivan

Re: [PUSHED][PATCH] convert table.hxx use in editeng/inc/editeng/forbiddencharacterstable.hxx

On 17.02.2012 00:20, Kohei Yoshida wrote: As far as I know those STL methods that return its element are guaranteed to return a reference to the stored instance, not its copy. Ah, great, I was not sure of that. On 17.02.2012 01:01, Michael Meeks wrote: I guess :-) I imagine the real p

Re: [OUTDATED][PATCH]fdo#44516 improved label and business card document creation (2/3)

Marking this as [OUTDATED] for convenience, I don't know what is the preferred tag for the outdated patches. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] [core/vcl/source/window/splitwin.cxx:2047] ->[core/vcl/source/window/splitwin.cxx:2045]:(style) Found duplicate branches for if and else.

On 18.02.2012 17:29, Mariusz Dykierek wrote: I have a 'replacement' patch that actually replaces most of if...else if...else chains with switches. Great! They are more legible and seem natural when choosing branches depending on the same variable. On the other hand, the evaluated expressi

Re: [PUSHED][PATCH] Remove unused code (14)

On 18.02.2012 19:35, Elton Chung wrote: This patch is an addendum to commit 600c27470380f80445fecb4b5691e0d11060494d. Yeah, nice catch. Thanks, pushed. Ivan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/m

Re: [PUSHED][PATCH] Remove unused code (15)

On 19.02.2012 12:25, Elton Chung wrote: This patch removes 5 unused methods. Pushed, thank you! Ivan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PUSHED][PATCH] Remove unused code (16)

On 19.02.2012 12:28, Elton Chung wrote: This patch removes 4 unused methods from basegfx. Pushed, thanks. Ivan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PUSHED][PATCH] Remove unused code

On 19.02.2012 03:13, Petr Vorel wrote: I removed a little bit of unused code (unusedcode.easy). Thank you! Ivan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PUSHED][PATCH] Get rid of size() == 0 (1)

On 19.02.2012 16:01, Elton Chung wrote: This patch converts some size() == 0 usage to empty() for performance reasons. Pushed partially... I dropped changes in sc/qa/unit/ucalc.cxx - there are no appropriate empty() function; and in soltools/giparser/st_gilrw.cxx - but luckily this stuff was

Re: [PATCH] convert svxrtf.hxx in editeng module from table.hxx to std::map

Hi Noel, On 14.02.2012 15:25, Noel Grandin wrote: Note that I tried converting these usages to boost::ptr_map, but I ran into entirely undecipherable C++ template errors. Sorry for the late review... :( What line produces that error? I suppose we should do use ptr_map, because even you forgo

Re: [PATCH] convert svxrtf.hxx in editeng module from table.hxx to std::map

On 20.02.2012 19:12, Noel Grandin wrote: The error was sourced several levels down in the boost stuff, and the originating point was everywhere I tried to assign into ptr_map. I think it had something to with the copyability of the Font class. Did you try to use 'insert(key, value)' instead of

Re: [PUSHED][PATCH] convert svxrtf.hxx in editeng module from table.hxx to std::map

On 21.02.2012 15:09, Noel Grandin wrote: Thanks, that was just the suggestion I needed! Converted patch to use boost:ptr_map. Great! Pushed, thanks for it. Could you prepare your future patches using 'git format-patch', please? Best Regards, Ivan __

Re: [PATCH] convert SV_DECL_PTRARR_DEL to boost::ptr_vector in sc/inc/viewuno.hxx

Hi Noel, From: Noel Grandin Do you really want to be @ubuntu.(none)? If not, use $ git config --global user.email -for ( sal_uInt16 n=0; nactiveSpreadsheetChanged( aEvent ); +(*it)->activeSpreadsheetChanged( aEvent ); } catch( uno::Exceptio

[PUSHED]fdo44516 improved label and business card document creation (final)

Marking as [PUSHED]: http://cgit.freedesktop.org/libreoffice/core/commit/?id=a99083d233d0d5c5a09941ec2ee7164bc63c61db Ivan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PUSHED] Remove unused code (19)

Hi Elton, On 26.02.2012 14:42, Elton Chung wrote: Sorry, please revert the removal of line 416-500 in the original patch which I overlooked. http://cgit.freedesktop.org/libreoffice/core/commit/?id=0499a44cddae31dff5ce1959aba8aa64119dea90 Cheers, Ivan __

[REVIEW 3.5; 3.5.1 (?)] fdo#46144: "Distributy Columns Evenly" does not work with the selected columns

Hi, thanks to Josh Heidenreich and his comment: https://bugs.freedesktop.org/show_bug.cgi?id=46144#c8 http://cgit.freedesktop.org/libreoffice/core/commit/?id=996f44c310520e3d7868c62d336aaec7bb0f845a Fixed invalid conversion from SvUShorts to std::vector... *sigh* Please, pick to the appropria

[PATCH][REVIEW 3-4] fdo#31966: do not create an empty slide when printing handouts

pository is attached. Sorry if it is insignificant for that branch. Thanks, Ivan >From 57acc16017ec7313b047066b1177a088aecaa2ed Mon Sep 17 00:00:00 2001 From: Ivan Timofeev Date: Mon, 27 Feb 2012 16:26:39 +0400 Subject: [PATCH] fdo#31966: do not create an empty slide when printing handouts

Re: [PATCH] Replace getLength() with isEmpty() where appropriate

Hi Christina, On 27.02.2012 12:22, Chr. Rossmanith wrote: some more getLength() -> isEmpty() replacements. Would be nice if someone could review the patch. at least, aTextHtml and aData from your patch are 'Sequence's, Sequence has not the isEmpty method IIRC, only the string classes have it.

Re: [PATCH] Replace getLength() with isEmpty() where appropriate

On 27.02.2012 16:59, Ivan Timofeev wrote: Hi Christina, On 27.02.2012 12:22, Chr. Rossmanith wrote: some more getLength() -> isEmpty() replacements. Would be nice if someone could review the patch. at least, aTextHtml and aData from your patch are 'Sequence's, Sequence has no

Re: [REVIEW 3.5.1 (?)] fdo#46144: "Distributy Columns Evenly" does not work with the selected columns

On 27.02.2012 19:01, Michael Meeks wrote: Having said that I'm not hyper-happy with not initialising the vector's contents - don't we really want: std::vector aWish( aTablCols.Count() + 1, 0 ), aMins( aTabCols.Count() + 1, 0 ); Hmm, no... From

Re: [PATCH] [3.5.1 and MASTER] Fix dialog controls size and position in the file preperties dialog

On 28.02.2012 02:51, Riccardo Magliocchetti wrote: Hello, Il 27/02/2012 23:22, willubuntu ha scritto: Hello guys, I took also the opportunity to fix some indentation to get a consistent look in code. Usually is better to separate the behaviour changes from the whitespace cleanup othwerwis

Re: [PATCH] Convert SvPtrarr and tools/table.hxx usage in sw module.

Hi, > -DECLARE_TABLE( SwBookmarkNodeTable, SvPtrarr* ) > +typedef std::multimap SwBookmarkNodeTable; ... > +SwBookmarkNodeTable aBkmkNodePos; ... > -SvPtrarr* pArr = (m_pImpl->pBkmkNodePos) ? > -m_pImpl->pBkmkNodePos->Get( nNd ) : 0; > -if( pArr ) > +SwBookmarkNodeTabl

Re: [PUSHED][PATCH] convert SV_DECL_PTRARR_DEL to boost::ptr_vector in sc/inc/viewuno.hxx

Hi Noel, On 29.02.2012 15:24, Noel Grandin wrote: New patch with recommended fixes attached. Great! Pushed, thanks. I wonder, would it not be better to convert this type of listener-list thing to boost::ptr_set? - no chance of accidentally adding duplicates Objects are created right before

<    1   2   3   4   5   6   >