[PATCH] Resolves: fdo#55367 wrong convertion factor for tspm

2012-10-09 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/849 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/49/849/1 Resolves: fdo#55367 wrong convertion factor for tspm Change-Id: If37ef46ab009b9886fefd0ca071bd81dd68e25fc --- M

[PATCH] Change in core[libreoffice-3-6]: Resolves: fdo#55367 wrong convertion factor for tspm

2012-10-10 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/855 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/55/855/1 Resolves: fdo#55367 wrong convertion factor for tspm Change-Id: I80fd050e1bbdc0386c13e0afbeeb404e14b2694b

[PATCH] coverity#738979 Use after free

2013-03-15 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2766 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/66/2766/1 coverity#738979 Use after free Change-Id: I843556f18542ac601fd7e16c6f51218ef913de31 --- M

[PATCH] coverity#988428 Missing break in switch

2013-03-16 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2775 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/75/2775/1 coverity#988428 Missing break in switch Change-Id: I7f127409c65f692c2eec3684c79b40b11e7ce240 --- M

[PATCH] coverity#735382 Copy-paste error

2013-03-19 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2854 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/54/2854/1 coverity#735382 Copy-paste error Change-Id: I7f033b189feee848dff1e3682be04a9b2f76fae8 --- M

[PATCH] coverity#735383 Copy-paste error

2013-03-19 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2855 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/55/2855/1 coverity#735383 Copy-paste error Change-Id: I2449c7b71d2bc575f92e064ff5438c56dd238af4 --- M

[PATCH] coverity#735389 Copy-paste error

2013-03-19 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2858 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/58/2858/1 coverity#735389 Copy-paste error Change-Id: I74098cd2b58a64ff231d86549812d5a565835bed --- M

[PATCH] coverity#704590 Explicit null dereferenced

2013-03-19 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2860 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/60/2860/1 coverity#704590 Explicit null dereferenced Change-Id: I787a39959a1558fe4f284bc1941194a841e2d600 --- M

[ABANDONED] coverity#735383 Copy-paste error

2013-03-20 Thread Julien Nabet (via Code Review)
Julien Nabet has abandoned this change. Change subject: coverity#735383 Copy-paste error .. Patch Set 1: Abandoned I was not sure at all for this one. You confirmed my doubts so I can abandon this patch and set false positive

[PATCH] coverity#704618 Explicit null dereferenced

2013-03-20 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2866 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/66/2866/1 coverity#704618 Explicit null dereferenced Change-Id: I9f3befc235b0fb7933294be4a97d168ef203a79c --- M

[PATCH] coverity#704622 Explicit null dereferenced

2013-03-20 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2867 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/67/2867/1 coverity#704622 Explicit null dereferenced Change-Id: I3328390799a87f2acff6ee689879325e4aa4357e --- M

[PATCH] coverity#704628/704629/704630 Explicit null dereferenced

2013-03-20 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2869 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/69/2869/1 coverity#704628/704629/704630 Explicit null dereferenced + return early if no whichid or after default case

[PATCH] coverity#704774 Explicit null dereferenced

2013-03-20 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2870 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/70/2870/1 coverity#704774 Explicit null dereferenced Change-Id: Ief63d63233d11015f64f5e6a19544889f0389ca3 --- M

[PATCH] Related to coverity#704822 (Explicit null dereference)

2013-03-20 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2872 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/72/2872/1 Related to coverity#704822 (Explicit null dereference) aSlotIds.push_back(0) = aSlotIds can't be empty =

[PATCH] coverity#704931 Explicit null dereferenced

2013-03-20 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2881 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/81/2881/1 coverity#704931 Explicit null dereferenced Change-Id: I03fe61ace1ab408d51e93f1e447591bb4eb9449c --- M

[ABANDONED] coverity#704622 Explicit null dereferenced

2013-03-21 Thread Julien Nabet (via Code Review)
Julien Nabet has abandoned this change. Change subject: coverity#704622 Explicit null dereferenced .. Patch Set 1: Abandoned Thank you Lionel for your feedback. I'm really hesitating about all this, the more I think about this

[PATCH] Related coverity#441160 Logically dead code

2013-03-23 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2929 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/29/2929/1 Related coverity#441160 Logically dead code Change-Id: Ibb4cff2b9a53eb1d9f4ea6043ed2b1b2deba1e2b --- M

[PATCH] Related coverity#704213/704214/704215 Logically dead code

2013-03-23 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2930 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/30/2930/1 Related coverity#704213/704214/704215 Logically dead code Change-Id: I80c119b2287ff0c4f2e467943be6a7682914934a

[PUSHED] Related coverity#704213/704214/704215 Logically dead code

2013-03-23 Thread Julien Nabet (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2930 -- To view, visit https://gerrit.libreoffice.org/2930 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

[PATCH] coverity#704243 Logically dead code

2013-03-23 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2942 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/42/2942/1 coverity#704243 Logically dead code Change-Id: Ie1140a90a6c9723582fa5e18ca0cf1dc1f918742 --- M

[PATCH] coverity#704245 Logically dead code

2013-03-23 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2949 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/49/2949/1 coverity#704245 Logically dead code Change-Id: I34d642f383b7fd323b4d5cbd1e8e7e726f83e32f --- M

[PATCH] coverity#704247 Logically dead code

2013-03-23 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2952 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/52/2952/1 coverity#704247 Logically dead code Change-Id: Iaefddeb816d36d4a07234d903fafab3d6b83e1d2 --- M

[PATCH] coverity#704300 Logically dead code

2013-03-24 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2976 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/76/2976/1 coverity#704300 Logically dead code Change-Id: I05bf1fc737896d99419597850b70a5ca156e1b8a --- M

[PATCH] coverity#704302 Logically dead code

2013-03-24 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2977 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/77/2977/1 coverity#704302 Logically dead code Change-Id: Ibdea2ca5225ac13e80b0a76cd0fd79e463c32e37 --- M

[PATCH] coverity#704334/704335/704336 Logically dead code

2013-03-25 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3045 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/45/3045/1 coverity#704334/704335/704336 Logically dead code Change-Id: Ieaa3c8ed735692a16c40ff01ea1dec52c2a29f31 --- M

[PATCH] coverity#704341 Logically dead code

2013-03-25 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3046 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/46/3046/1 coverity#704341 Logically dead code Change-Id: I5a097afe1c582eab023cecadc0b1cc77faf774a1 --- M

[PATCH] coverity#704345 Logically dead code

2013-03-25 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3047 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/47/3047/1 coverity#704345 Logically dead code Change-Id: I72360ada3abedc75b2718742e8a038eb6d214f0c --- M

[PATCH] coverity#704348 Logically dead code

2013-03-25 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3048 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/48/3048/1 coverity#704348 Logically dead code Change-Id: I8c97042c07e3eb66468591fa9c486998ffb1e37f --- M

[PATCH] coverity#982290 Logically dead code

2013-03-26 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3067 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/67/3067/1 coverity#982290 Logically dead code Change-Id: Ia684369faa5fd0eb854d204ac7e8dbf74f032606 --- M

[PATCH] coverity#704453 Non-array delete for scalars

2013-03-26 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3069 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/69/3069/1 coverity#704453 Non-array delete for scalars Change-Id: I3bc1c8c0d0cfb0df1cb059982ffa9ad10de0ccc4 --- M

[ABANDONED] coverity#704453 Non-array delete for scalars

2013-03-26 Thread Julien Nabet (via Code Review)
Julien Nabet has abandoned this change. Change subject: coverity#704453 Non-array delete for scalars .. Patch Set 1: Abandoned Sorry Markus, I missed the fact you had assigned yourself. -- To view, visit

[PATCH] coverity#704145 Resource leak in object

2013-03-26 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3071 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/71/3071/1 coverity#704145 Resource leak in object Change-Id: Ia676d215cf8ef4830e31a1caf4153e33af84c200 --- M

[PATCH] Simplify a bit

2013-03-30 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3123 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/23/3123/1 Simplify a bit Change-Id: I77cb2b08b1d92f3c8ad406bb1ebd2d080cdbfa1a --- M

[PATCH] coverity#983561: Arguments in wrong order

2013-03-30 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3126 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/26/3126/1 coverity#983561: Arguments in wrong order Change-Id: I3035457e93a659fe09cfe383735328f2854e5871 --- M

[ABANDONED] coverity#704300 Logically dead code

2013-03-31 Thread Julien Nabet (via Code Review)
Julien Nabet has abandoned this change. Change subject: coverity#704300 Logically dead code .. Patch Set 1: Abandoned -- To view, visit https://gerrit.libreoffice.org/2976 To unsubscribe, visit

[ABANDONED] coverity#704245 Logically dead code

2013-03-31 Thread Julien Nabet (via Code Review)
Julien Nabet has abandoned this change. Change subject: coverity#704245 Logically dead code .. Patch Set 1: Abandoned -- To view, visit https://gerrit.libreoffice.org/2949 To unsubscribe, visit

[ABANDONED] coverity#983561: Arguments in wrong order

2013-03-31 Thread Julien Nabet (via Code Review)
Julien Nabet has abandoned this change. Change subject: coverity#983561: Arguments in wrong order .. Patch Set 1: Abandoned -- To view, visit https://gerrit.libreoffice.org/3126 To unsubscribe, visit

[PATCH] coverity#704129: Operands don't affect result

2013-03-31 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3141 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/41/3141/1 coverity#704129: Operands don't affect result Change-Id: I6faf86c3a41296ba4a267a58d7d0814e526b85a8 --- M

[PATCH] Try to optimize a bit

2013-04-01 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3153 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/53/3153/1 Try to optimize a bit Change-Id: I36a529ef29b93ee46e4a3ff6823fbce15d176c27 --- M

[PATCH] coverity#984440: Use after free

2013-03-01 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2496 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/96/2496/1 coverity#984440: Use after free Change-Id: Ia6d62ce5421d51fe4fc0128f60e9b39ab736276b --- M

[PATCH] coverity#705110: out-of-bounds write

2013-03-01 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2498 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/98/2498/1 coverity#705110: out-of-bounds write Change-Id: I0edc69928d57eb9ff03a0004b10ca70e55988e68 --- M

[PATCH] coverity#982797: Out-of-bounds write

2013-03-01 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2499 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/99/2499/1 coverity#982797: Out-of-bounds write Change-Id: I58f2040ffc7d56e8e4418a29de0dd4d263defbd2 --- M

[ABANDONED] coverity#705110: out-of-bounds write

2013-03-01 Thread Julien Nabet (via Code Review)
Julien Nabet has abandoned this change. Change subject: coverity#705110: out-of-bounds write .. Patch Set 2: Abandoned Wrong commit message, I wanted to amend it again but I must have done something wrong since I created

[PATCH] coverity#982283: Resource leak in object

2013-03-01 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2500 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/00/2500/1 coverity#982283: Resource leak in object Change-Id: Iedf1c0ec56064dbeaa20bb75114fb86a19c38ed9 --- M

[PATCH] coverity#982283: Resource leak in object

2013-03-01 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2502 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/02/2502/1 coverity#982283: Resource leak in object Change-Id: I55fb144adf9c823226dbed31b6ccc92567a7f8bc --- M

[PATCH] coverity#982282: Resource leak in object

2013-03-02 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2511 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/11/2511/1 coverity#982282: Resource leak in object Change-Id: Ia7d936c90d7afd4ffa4e22a86289aba47956f576 --- M

[ABANDONED] coverity#982283: Resource leak in object

2013-03-02 Thread Julien Nabet (via Code Review)
Julien Nabet has abandoned this change. Change subject: coverity#982283: Resource leak in object .. Patch Set 1: Abandoned Replaced by https://gerrit.libreoffice.org/#/c/2511 (If someone knows how to change commit message

[PATCH] coverity#983009: Resource leak

2013-03-04 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2550 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/50/2550/1 coverity#983009: Resource leak Just moving pArr block should be ok Change-Id:

[PATCH] coverity#440777: Resource leak in object

2013-03-04 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2551 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/51/2551/1 coverity#440777: Resource leak in object Change-Id: Ib183032f305b11c759e02e122487e0ac989690fd --- M

[ABANDONED] coverity#440777: Resource leak in object

2013-03-04 Thread Julien Nabet (via Code Review)
Julien Nabet has abandoned this change. Change subject: coverity#440777: Resource leak in object .. Patch Set 1: Abandoned Thank you Eike for your feedback. Indeed, I hadn't check there could be a ref count somewhere. I'll

[PATCH] coverity#704143: Resource leak in object

2013-03-12 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2686 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/86/2686/1 coverity#704143: Resource leak in object Change-Id: I6bf9fc6e65de857d4d05df0c7be64dc6ec38dc07 --- M

[PATCH] coverity#704153: Resource leak in object

2013-03-12 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2687 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/87/2687/1 coverity#704153: Resource leak in object Change-Id: I24fe7c8f7667bc4d847d025106673255813ddaf6 --- M

[PATCH] coverity#705734: Resource leak

2013-03-12 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2689 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/89/2689/1 coverity#705734: Resource leak Change-Id: I04eba87de232958650c649c6ec18acb6b699b0ff --- M

[ABANDONED] coverity#704153: Resource leak in object

2013-03-12 Thread Julien Nabet (via Code Review)
Julien Nabet has abandoned this change. Change subject: coverity#704153: Resource leak in object .. Patch Set 1: Abandoned Thank you for your quick feedback Caolán. -- To view, visit https://gerrit.libreoffice.org/2687 To

[PATCH] coverity#705733: Resource leak

2013-03-13 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2711 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/11/2711/1 coverity#705733: Resource leak + Fix if format Change-Id: Iafd46d21e5b9ed21d7c7c338502d780be9f0c222 --- M

[PATCH] coverity#705748: Resource leak

2013-03-14 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2734 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/34/2734/1 coverity#705748: Resource leak Change-Id: I3178b1301db389b76f514b5a2bf2d18dae78ae01 --- M

[PATCH] coverity#705747: Resource leak

2013-03-14 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2736 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/36/2736/1 coverity#705747: Resource leak Change-Id: Ifc071261ce5697355b904fbd12272b27c04183e4 --- M

[PATCH] coverity#708921: Use after free

2013-03-15 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2738 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/38/2738/1 coverity#708921: Use after free Change-Id: I446fa717dfd11fc5d6045cb1e8dc3eaf8861262e --- M

[PATCH] test on the return of pOleObject-Close

2013-01-07 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1567 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/67/1567/1 test on the return of pOleObject-Close Change-Id: Iee64f6f369e2312d479fa81e7a59fb962ed8d90e --- M

[PATCH] Modify constructor, remove setters + unused define

2013-01-13 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1665 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/65/1665/1 Modify constructor, remove setters + unused define Change-Id: Ibf878c44ae761e59a04b6d5023296c5918cbf85e --- M

[PATCH] Resolves: fdo#49784 CRASH when FILEOPEN particular doc conta...

2013-01-20 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1788 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/88/1788/1 Resolves: fdo#49784 CRASH when FILEOPEN particular doc containing .svm Change-Id:

[PATCH] Change in core[libreoffice-4-0]: Resolves: fdo#49784 CRASH when FILEOPEN particular doc conta...

2013-01-25 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1850 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/50/1850/1 Resolves: fdo#49784 CRASH when FILEOPEN particular doc containing .svm Change-Id:

[PATCH] Change in core[libreoffice-3-6]: Resolves: fdo#49784 CRASH when FILEOPEN particular doc conta...

2013-01-25 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1851 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/51/1851/1 Resolves: fdo#49784 CRASH when FILEOPEN particular doc containing .svm Change-Id:

[PATCH] Change in core[libreoffice-3-6]: Resolves: fdo#49784 CRASH when FILEOPEN particular doc conta...

2013-01-25 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1852 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/52/1852/1 Resolves: fdo#49784 CRASH when FILEOPEN particular doc containing .svm Change-Id:

[PATCH] Change in core[libreoffice-4-0]: Resolves: fdo#49784 CRASH when FILEOPEN particular doc conta...

2013-01-25 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1853 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/53/1853/1 Resolves: fdo#49784 CRASH when FILEOPEN particular doc containing .svm Change-Id:

Change in core[libreoffice-4-0]: Resolves: fdo#49784 CRASH when FILEOPEN particular doc conta...

2013-01-25 Thread Julien Nabet (via Code Review)
Julien Nabet has abandoned this change. Change subject: Resolves: fdo#49784 CRASH when FILEOPEN particular doc containing .svm .. Patch Set 1: Abandoned Dup -- To view, visit https://gerrit.libreoffice.org/1853 To

Change in core[libreoffice-3-6]: Resolves: fdo#49784 CRASH when FILEOPEN particular doc conta...

2013-01-25 Thread Julien Nabet (via Code Review)
Julien Nabet has abandoned this change. Change subject: Resolves: fdo#49784 CRASH when FILEOPEN particular doc containing .svm .. Patch Set 1: Abandoned Dup -- To view, visit https://gerrit.libreoffice.org/1852 To

Change in core[libreoffice-4-0]: export page/cell anchoring for xls drawing objects fdo#58360

2013-01-26 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1877 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/77/1877/1 export page/cell anchoring for xls drawing objects fdo#58360 Change-Id:

[ABANDONED] Really use 'nCategoriesLength'

2013-04-17 Thread Julien Nabet (via Code Review)
Julien Nabet has abandoned this change. Change subject: Really use 'nCategoriesLength' .. Patch Set 1: Abandoned Let's drop it. -- To view, visit https://gerrit.libreoffice.org/3161 To unsubscribe, visit

[PATCH] fdo#63197, Remove Zip_launcher part

2013-04-17 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3436 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/36/3436/1 fdo#63197, Remove Zip_launcher part Change-Id: I3d14cf90ec4d745a8fb70db8319a3a3042e93306 --- M

[PATCH] Remove unused launcher wizard

2013-04-17 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3437 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/37/3437/1 Remove unused launcher wizard Change-Id: I6c071f00eef88d3f56e76efddf6f0c71aa56b089 --- M

[PATCH] Remove unused web wizard

2013-04-17 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3438 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/38/3438/1 Remove unused web wizard Change-Id: I76ed89c4a46e5a7b6a639e2c2717bc53d9b68bc9 --- M wizards/Module_wizards.mk D

[PATCH] fdo#63197: convert wizards

2013-04-17 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3439 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/39/3439/1 fdo#63197: convert wizards Change-Id: Ic7fa577fbdb527a75643c4e2919e0527432d5536 --- M

[PATCH] fdo#63197, convert sysui osxicons

2013-04-17 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3440 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/40/3440/1 fdo#63197, convert sysui osxicons Change-Id: Iab9cb3704385c115e1d25189a3d8833bd6721e24 --- M

[PATCH] fdo#63197: convert psprint_config files

2013-04-17 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3442 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/42/3442/1 fdo#63197: convert psprint_config files Change-Id: I8e3046a6ed30ac8ee60940844b8ceda6ec1ffd39 --- M

[PATCH] fdo#63197: convert psprint_config files

2013-04-17 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3443 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/43/3443/1 fdo#63197: convert psprint_config files Change-Id: I99660704931c7341a72fe303fae47f984f968ecb --- M

[ABANDONED] fdo#63197: convert psprint_config files

2013-04-17 Thread Julien Nabet (via Code Review)
Julien Nabet has abandoned this change. Change subject: fdo#63197: convert psprint_config files .. Patch Set 1: Abandoned I tested logerrit resubmit but i must have missed something since it created

[PATCH] fdo#63197, convert accessoriesgallerydrawspeople

2013-04-17 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3444 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/44/3444/1 fdo#63197, convert accessoriesgallerydrawspeople Change-Id: I9743fd98691695f831fa282a64482b23178f0026 --- A

[PATCH] fdo#63197, convert some accessories

2013-04-18 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3449 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/49/3449/1 fdo#63197, convert some accessories Change-Id: I0b406734603ad61d7a00ea2f6114103e10f265ed --- A

[PATCH] fdo#63197: convert the rest of accessoriesgallery*

2013-04-18 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3454 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/54/3454/1 fdo#63197: convert the rest of accessoriesgallery* Change-Id: Ib664ba3f208c87570db284b5fc38fa58d8d8a679 --- A

[PATCH] fdo#63197: convert 3 out 4 from scripting part

2013-04-18 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3470 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/70/3470/1 fdo#63197: convert 3 out 4 from scripting part Change-Id: Ie359d0ef00f62dd3c2d1f1dfd86e115409438e76 --- M

[PATCH] fdo#63197: convert fontunxafm

2013-04-28 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3648 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/48/3648/1 fdo#63197: convert fontunxafm Change-Id: Ib382319a4916b711c820c06ba57928ca11d0b804 --- R

[PATCH] fdo#63197: convert helpxsl

2013-04-28 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3649 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/49/3649/1 fdo#63197: convert helpxsl Change-Id: Icd436733b47d7883209fe73dc1d0099dc87db089 --- M

[PATCH] fdo#63197: convert liblangtag_data

2013-04-28 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3650 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/50/3650/1 fdo#63197: convert liblangtag_data Change-Id: I0727b800c715962a88e256b30046c9e13d6bd2a9 --- A

[PATCH] fdo#63197: convert osxres

2013-04-28 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3652 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/52/3652/1 fdo#63197: convert osxres Change-Id: I969217263fdda3e61b38dc16f0a9251b745de885 --- M

[PATCH] Forgot with_dir

2013-04-29 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3688 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/88/3688/1 Forgot with_dir Change-Id: I1457f5619984671e8cb88173d204d3157d3cb883 --- M

[PATCH] fdo#60265 Really fixes Basic problem

2013-05-01 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3729 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/29/3729/1 fdo#60265 Really fixes Basic problem GetFilterName function in FilesModul.xba needs the extension be repeated

[PATCH] Resolves: fdo#38193 WRITER, DRAW: Media Player is missing in...

2012-10-27 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/931 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/31/931/1 Resolves: fdo#38193 WRITER, DRAW: Media Player is missing in Tools menu Change-Id:

[PATCH] Resolves: fdo#56473 IDE: Crash when inserting a simple macro

2012-10-27 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/932 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/32/932/1 Resolves: fdo#56473 IDE: Crash when inserting a simple macro Change-Id: I4390f63ddc491c3bb561cd9a2aea53735bcafb64

Resolves: fdo#56473 IDE: Crash when inserting a simple macro

2012-10-27 Thread Julien Nabet (via Code Review)
Julien Nabet has abandoned this change. Change subject: Resolves: fdo#56473 IDE: Crash when inserting a simple macro .. Patch Set 1: Abandoned I forgot to replace m_xParagraphs-begin() + nFirst by aItBound2 -- To view, visit

[PATCH] Resolves: fdo#56473 IDE: Crash when inserting a simple macro

2012-10-27 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/933 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/33/933/1 Resolves: fdo#56473 IDE: Crash when inserting a simple macro Change-Id: I7bb6fe0005b9afa2d853a13a30d5b0c48ba8bdf2

[PUSHED] Resolves: fdo#56473 IDE: Crash when inserting a simple macro

2012-10-28 Thread Julien Nabet (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/933 -- To view, visit https://gerrit.libreoffice.org/933 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

[PUSHED] Resolves: fdo#38193 WRITER, DRAW: Media Player is missing in...

2012-10-28 Thread Julien Nabet (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/931 -- To view, visit https://gerrit.libreoffice.org/931 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

[PATCH] Convert UniString - OUString

2012-11-03 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/978 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/78/978/1 Convert UniString - OUString Change-Id: I0b49286e6aabc11708556af15fa3faed6a619222 --- M svl/inc/svl/inettype.hxx

Convert UniString - OUString

2012-11-03 Thread Julien Nabet (via Code Review)
Julien Nabet has abandoned this change. Change subject: Convert UniString - OUString .. Patch Set 1: Abandoned svtools module doesn't compile -- To view, visit https://gerrit.libreoffice.org/978 To unsubscribe, visit

[PATCH] Convert some UniString to OUString

2012-11-04 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/982 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/82/982/1 Convert some UniString to OUString Change-Id: I527e818fa7f3ec0ee8dc8ba0103071cea8b6d4ca --- M

Convert some UniString to OUString

2012-11-04 Thread Julien Nabet (via Code Review)
Julien Nabet has abandoned this change. Change subject: Convert some UniString to OUString .. Patch Set 1: Abandoned No problem for not submitting it. Thank you for your feedback Ivan. -- To view, visit

Convert some UniString to OUString

2012-11-11 Thread Julien Nabet (via Code Review)
Julien Nabet has restored this change. Change subject: Convert some UniString to OUString .. Patch Set 1: Restored I'll try to put a revision change -- To view, visit https://gerrit.libreoffice.org/982 To unsubscribe, visit

[PATCH] Convert some UniString to OUString (improved)

2012-11-11 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1038 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/38/1038/1 Convert some UniString to OUString (improved) Change-Id: I0775b74f34a4014c08305adc5d20b34cb70d16e0 --- M

Convert some UniString to OUString

2012-11-11 Thread Julien Nabet (via Code Review)
Julien Nabet has abandoned this change. Change subject: Convert some UniString to OUString .. Patch Set 2: Abandoned Since now there's https://gerrit.libreoffice.org/1038. Thought it'll be a revision of this one... -- To

  1   2   >