How do I report?
--
Regards,
Mariusz Dykerek
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Performance improvement unlikely yet readability/intent clearer + cppcheck
satisfied.
--
Regards,
Mariusz Dykerek
>From 3fa7c19cfa1a844a926221d2d0235e4c9737c86c Mon Sep 17 00:00:00 2001
From: Mariusz Dykierek
Date: Sun, 19 Feb 2012 17:21:55 +0100
Subject: [PATCH 1/2] Using empty() instead
On 2012-02-18 14:41, Ivan Timofeev wrote:
> On 18.02.2012 17:29, Mariusz Dykierek wrote:
>> I have a 'replacement' patch that actually replaces most of if...else
>> if...else chains with
>> switches.
>
> Great!
>
>> They are more legible and se
ed ;).
Two declarations of unused variable removed by-the-way.
Anyway, all started with cppcheck warning about duplicate branches for if-else.
Question I have, is how do I submit the patch:
- as a reply to this thread, or
- a new patch in a new thread?
Regards,
Marius
On 2012-02-16 10:02, Stephan Bergmann wrote:
> On 02/16/2012 09:35 AM, Riccardo Magliocchetti wrote:
>> Otherwise you can simplify it even more:
>>
>> sal_Bool bLeft = (meAlign == WINDOWALIGN_TOP || meAlign ==
>> WINDOWALIGN_LEFT) ? sal_False : sal_True;
>
> ... which of course reduces to
>
>> bool
--
Regards,
Mariusz Dykerek
diff --git a/editeng/source/items/borderline.cxx b/editeng/source/items/borderline.cxx
index b617ff4..1677141 100644
--- a/editeng/source/items/borderline.cxx
+++ b/editeng/source/items/borderline.cxx
@@ -492,29 +492,20 @@ bool SvxBorderLine::HasPriority( const SvxBor
--
Regards,
Mariusz Dykerek
diff --git a/cli_ure/source/uno_bridge/cli_bridge.h b/cli_ure/source/uno_bridge/cli_bridge.h
index 0306e4d..b9297d0 100644
--- a/cli_ure/source/uno_bridge/cli_bridge.h
+++ b/cli_ure/source/uno_bridge/cli_bridge.h
@@ -96,7 +96,7 @@ struct Bridge
System::Object*
+ some simplification
--
Regards,
Mariusz Dykerek
diff --git a/vcl/source/window/splitwin.cxx b/vcl/source/window/splitwin.cxx
index f5da206..09ad468 100644
--- a/vcl/source/window/splitwin.cxx
+++ b/vcl/source/window/splitwin.cxx
@@ -2035,17 +2035,9 @@ void SplitWindow::ImplDrawFadeIn( sal_Bool
--
Pozdrawiam,
Mariusz Dykerek
diff --git a/linguistic/source/dlistimp.cxx b/linguistic/source/dlistimp.cxx
index e824888..316d86d 100644
--- a/linguistic/source/dlistimp.cxx
+++ b/linguistic/source/dlistimp.cxx
@@ -608,7 +608,7 @@ void SAL_CALL
pDicEvtLstnrHelper->DisposeAndClear(
--
Regards,
Mariusz Dykerek
diff --git a/dtrans/source/win32/dtobj/FmtFilter.cxx b/dtrans/source/win32/dtobj/FmtFilter.cxx
index c012115..4093e92 100644
--- a/dtrans/source/win32/dtobj/FmtFilter.cxx
+++ b/dtrans/source/win32/dtobj/FmtFilter.cxx
@@ -482,7 +482,7 @@ typedef Sequence ByteSequence_t
--
Pozdrawiam,
Mariusz Dykerek
diff --git a/dtrans/source/win32/dtobj/FetcList.cxx b/dtrans/source/win32/dtobj/FetcList.cxx
index 3bb3beb..3599da8 100644
--- a/dtrans/source/win32/dtobj/FetcList.cxx
+++ b/dtrans/source/win32/dtobj/FetcList.cxx
@@ -120,7 +120,7 @@ sal_Bool CFormatEtcContainer::ha
--
Pozdrawiam,
Mariusz Dykerek
diff --git a/fpicker/source/win32/filepicker/asynceventnotifier.cxx b/fpicker/source/win32/filepicker/asynceventnotifier.cxx
index a155f8b..748e5ac 100644
--- a/fpicker/source/win32/filepicker/asynceventnotifier.cxx
+++ b/fpicker/source/win32/filepicker/asynceventn
These should not (as they were actually removed in the source).
As for the others, mentioned in other patch:
"[PATCH] Removed nonexistent items from unusedcode.easy"
A simple "grep -v suppress.list in.txt > unusedcode.easy" should do the trick.
One more file to maintain, but false positives would
I guess this is what author intended.
The other solution is to remove the copy.
--
Mariusz Dykerek
diff --git a/svtools/source/misc/filechangedchecker.cxx b/svtools/source/misc/filechangedchecker.cxx
index 514841f..7a99f15 100644
--- a/svtools/source/misc/filechangedchecker.cxx
+++ b/svtools/sou
Subject explains almost everything.
--
Mariusz Dykerek
diff --git a/sc/source/filter/starcalc/scflt.cxx b/sc/source/filter/starcalc/scflt.cxx
index 1d30ea2..2086bf5 100644
--- a/sc/source/filter/starcalc/scflt.cxx
+++ b/sc/source/filter/starcalc/scflt.cxx
@@ -1708,7 +1708,7 @@ void Sc10Import::L
Attached patch fixes a copy-paste error in the condition.
Seconds used twice instead of Hours.
--
Pozdrawiam,
Mariusz Dykerek
diff --git a/sdext/source/presenter/PresenterTimer.cxx b/sdext/source/presenter/PresenterTimer.cxx
index 6c5f8d9..3757bd0 100644
--- a/sdext/source/presenter/PresenterTim
Attached patch removes
NfCurrencyEntry::ApplyVariableInformation(NfCurrencyEntry const&) as
listed in unusedcode.easy.
--
Mariusz Dykerek
diff --git a/svl/inc/svl/zforlist.hxx b/svl/inc/svl/zforlist.hxx
index aa68fc1..ac387d4 100644
--- a/svl/inc/svl/zforlist.hxx
+++ b/svl/inc/svl/zforlist.hxx
Hi,
Attached patch removes:
- LineListBox::GetEntryLine1
- LineListBox::GetEntryLine2
- LineListBox::GetEntryDistance
- LineListBox::GetSelectEntryLine1
- LineListBox::GetSelectEntryLine2
- LineListBox::GetSelectEntryDistance
and corresponding entries in unusedcode.easy.
--
Pozdrawiam,
Mar
Hi,
Attached patch removes from "unusedcode.easy" a number of methods that cannot
be found in the
sources within the "core" directory.
Can someone more experienced than I am confirm that items:
- CIcc*::*
- boost::gregorian::*
are really supposed to be enumerated in the "unusedcode.easy"?
--
Hi All,
All my previous and future contributions to the LibreOffice project are
licensed under the terms of
the LGPLv3+ / MPL.
--
Best regards,
Mariusz Dykerek
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.o
Was to read:
FormulaToken::IsMatrixFunction() const
On 2012-01-19 00:15, Mariusz Dykierek wrote:
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Code is contributed under the LGPLv3+ / MPL
Regards,
Mariusz Dykierek
diff --git a/formula/inc/formula/token.hxx b/formula/inc/formula/token.hxx
index 738caa1..2beed8d 100644
--- a/formula/inc/formula/token.hxx
+++ b/formula/inc/formula/token.hxx
@@ -114,7 +114,6 @@ public:
inline void
Code is contributed under the LGPLv3+ / MPL
diff --git a/unusedcode.easy b/unusedcode.easy
index b906bb9..bc78775 100644
--- a/unusedcode.easy
+++ b/unusedcode.easy
@@ -1,4 +1,4 @@
-AtomDocument::AtomDocument(AtomPubSession*, std::basic_string, std::allocator >)
+### AtomDocument::AtomDocument(At
Code is contributed under the LGPLv3+ / MPL
--
Regards,
Mariusz Dykerek
diff --git a/vcl/source/control/field.cxx b/vcl/source/control/field.cxx
index 1538287..51c4ee2 100644
--- a/vcl/source/control/field.cxx
+++ b/vcl/source/control/field.cxx
@@ -387,20 +387,6 @@ const AllSettings& FormatterBa
24 matches
Mail list logo