[Libreoffice] [PATCH] Docuview code cleanup

2011-11-13 Thread Matteo Casalin
f9427c431d2bd7160058ba85ab9cb7b6436a271c Mon Sep 17 00:00:00 2001 From: Matteo Casalin matteo.casa...@poste.it Date: Sun, 13 Nov 2011 19:19:27 +0100 Subject: [PATCH] Decoview code cleanup Fixed DrawSymbol color selection Cleaned up many ImplDrawSymbol cases, reducing number of calls to drawing functions Removed

Re: [Libreoffice] [PARTIALLY PUSHED] [PATCH] Docuview code cleanup

2011-11-14 Thread Matteo Casalin
Noel Power nopo...@suse.com wrote: (14/11/2011 16:46) [...] Personally I am not a ui or vcl person so I only pushed the final couple of hunks relating to fixing the colour selection. Thanks for reviewig! But you seem to have done a great job getting into drawing stuff ( as you can see

Re: [Libreoffice] [PUSHED] Docuview code cleanup

2011-11-23 Thread Matteo Casalin
the new patch (with picture) ASAP. Thanks Matteo -- Michael Meeks michael.me...@suse.com wrote: (23/11/2011 16:02) Hi Matteo, On Sun, 2011-11-13 at 19:54 +0100, Matteo Casalin wrote: my name's Matteo and this is my first contribution [attempt

Re: [Libreoffice] [PUSHED] Docuview code cleanup

2011-11-24 Thread Matteo Casalin
did some internet research about checkmarks in RTL, without results. Unless the original bug report is found, this issue should/could eventually be clarified with some RTL people. Thanks again Matteo -- Matteo Casalin matteo.casa...@poste.it wrote

Re: [Libreoffice] Remember the RTL interface

2011-11-29 Thread Matteo Casalin
Hi all, just a quick reply until I can sit in front of my own pc. As Michael said, I'm (slowly) cleaning up decoview, and I can see two points related to this issue: 1) Wrong direction of arrow: actually, the arrow depicted in Lior's screenshot does not seem to be drawn by decoview's

Re: [Libreoffice] Remember the RTL interface

2011-11-29 Thread Matteo Casalin
On 11/29/2011 12:03 PM, Khaled Hosny wrote: On Tue, Nov 29, 2011 at 11:12:36AM +0100, Matteo Casalin wrote: 2) Mirroring of checkmarks: in decoview there's a strange bug-related comment which says roughly don't mirror checkmarks in RTL, following by code that actually mirrors them. My questions

[Libreoffice] [PATCHES] Decoview cleanup - remove unneeded header

2011-12-04 Thread Matteo Casalin
From: Matteo Casalin matteo.casa...@poste.it Date: Sun, 27 Nov 2011 09:58:48 +0100 Subject: [PATCH 1/4] Removed unused header --- vcl/source/window/decoview.cxx |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/vcl/source/window/decoview.cxx b/vcl/source/window/decoview.cxx

[Libreoffice] [PATCH] Decoview cleanup #4 - embed support function

2011-12-04 Thread Matteo Casalin
Hi, please find attached a patch which rewrites the DrawButton function. The attached patch is contributed under LGPL3+/MPL1.1 license. Matteo From 2c0dde2798b800ee3fb95c4e54fa9b7f693727cb Mon Sep 17 00:00:00 2001 From: Matteo Casalin matteo.casa...@poste.it Date: Sun, 4 Dec 2011 12:18:49

[Libreoffice] [PATCH] Decoview cleanup #5 - embed (erroneusly) external support function

2011-12-04 Thread Matteo Casalin
. Matteo From d485e0fcd8132ddd503f5acb20dd9c0864f08cc5 Mon Sep 17 00:00:00 2001 From: Matteo Casalin matteo.casa...@poste.it Date: Sun, 4 Dec 2011 15:25:04 +0100 Subject: [PATCH 3/4] DecoView cleanup - Embed OutputDevice::ImplDraw2ColorFrame --- vcl/inc/vcl/outdev.hxx |1 - vcl

[Libreoffice] [PATCH] Decoview cleanup #6 - take advantage of cleanup #5 for more cleanups

2011-12-04 Thread Matteo Casalin
Hi, please find attached a patch that takes advantage of previous patch to cleanup the code calling ImplDraw2ColorFrame. The attached patch is contributed under LGPL3+/MPL1.1 license. Matteo From e0167dc0598f011f22728fb77e5b23be2f273781 Mon Sep 17 00:00:00 2001 From: Matteo Casalin

[Libreoffice] License statement: Matteo Casalin

2011-12-04 Thread Matteo Casalin
All of my present and future contributions to LibreOffice are available under the terms of the LGPLv3+/MPL licenses, until further notice. Matteo Casalin ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org

[Libreoffice] Decoview cleanup #7 - Remove unused button styles

2011-12-04 Thread Matteo Casalin
The attached patch removes from DecorationView some unused (according to grep -r BUTTON_DRAW_ *, performed at top level) button styles with the related code. Matteo From e5097ddf0c1753b44b2a23dcfb51ba761b899adf Mon Sep 17 00:00:00 2001 From: Matteo Casalin matteo.casa...@poste.it Date: Sun, 4

[Libreoffice] Decoview: improve comment about checkmark mirroring

2011-12-04 Thread Matteo Casalin
into account that, according to RTL people [1], checkmarks are drawn the same in LTR/RTL languages. Matteo [1] Lior Kaplan and Khaled Hosny in the thread Remember the RTL interface, dated 11/29/2011. From b94d39b77efb96d20a94292f4e842bdb87223ae4 Mon Sep 17 00:00:00 2001 From: Matteo Casalin matteo.casa

Re: [Libreoffice] PATCH: menues - menus

2011-12-07 Thread Matteo Casalin
Hi all, I'm not a reviewer (nor I'm pretending to be), I just want to highlight a possible issue: this patch also changes solenv/gbuild/extensions/post_BuildplTargets.mk (lines from 99 to 111) which has no menues in it. It also changes menues occurrences in some comments that are still in

Re: [Libreoffice] build error

2011-12-09 Thread Matteo Casalin
Hi Winfried, please find my comments below. On 12/09/2011 05:10 PM, Winfried Donkers wrote: Hello all, I have just got a new computer, which should make LibO much faster than my old machine does :) . Unfortunately, I get a make error: .../core/solver/unxlngi6.pro/bin/cppunit/cppunittester:

[Libreoffice] [PATCH] Decoview cleanup #9 - ImplDrawFrame

2011-12-09 Thread Matteo Casalin
9ed12c989a64306e1503edf2943e6bd5d60d3140 Mon Sep 17 00:00:00 2001 From: Matteo Casalin matteo.casa...@poste.it Date: Fri, 9 Dec 2011 21:13:58 +0100 Subject: [PATCH] DecoView cleanup: rework ImplDrawFrame --- vcl/source/window/decoview.cxx | 398 +++- 1 files

[Libreoffice] [RFC] COMPRESSMODE_FULL

2011-12-15 Thread Matteo Casalin
Hi everybody, some days ago I stumbled upon vcl Rectangle SvStream and operators (gen.cxx). Their implementation handles the case that the stream is compressed as COMPRESSMODE_FULL (and can surely be improved). For better understanding I opengrok'ed this COMPRESSMODE_FULL and it turns

Re: [Libreoffice] [RFC] COMPRESSMODE_FULL

2011-12-16 Thread Matteo Casalin
Hi Thorsten Thorsten Behrens t...@documentfoundation.org wrote: (16/12/2011 01:55) Matteo Casalin wrote: set: /binfilter/binfilter/bf_svtools/source/filter.vcl/filter/svt_filter.cxx /core/svtools/source/filter/filter.cxx Both can go. From my understanding, if we remove these 2 calls

Re: [Libreoffice] [PATCH] [RFC] COMPRESSMODE_FULL

2011-12-17 Thread Matteo Casalin
Hi Thorsten, On 12/16/2011 11:52 AM, Thorsten Behrens wrote: Matteo Casalin wrote: From my understanding, if we remove these 2 calls that set te COMPRESSMODE_FULL flag then there is no reason to keep the code that depend on that, unless the svstream acquires the flag from the stream itself

Re: [Libreoffice] [RFC] COMPRESSMODE_FULL

2011-12-17 Thread Matteo Casalin
On 12/16/2011 04:48 PM, Tommy wrote: On Fri, 16 Dec 2011 00:08:26 +0100, Matteo Casalin matteo.casa...@poste.it wrote: Hi, this is off-topic, however since you are the only italian active code developer of LibO (Italo Vignoli is not involved into coding but into marketing), I'm inviting you

Re: [Libreoffice] [PUSHED] [PATCH] [RFC] COMPRESSMODE_FULL

2011-12-22 Thread Matteo Casalin
need to be of type long? Rectangle, for example, are widely used, and type long doubles their size in 64-bit machines. On 12/19/2011 10:01 PM, Thorsten Behrens wrote: Matteo Casalin wrote: Here are the patches for *completely* removing COMPRESSMODE_FULL support. Applied as-is, good work

[Libreoffice-commits] .: 2 commits - cui/source vcl/source

2012-07-21 Thread Matteo Casalin
cui/source/dialogs/cuigrfflt.cxx |1 - vcl/source/app/sound.cxx | 12 2 files changed, 4 insertions(+), 9 deletions(-) New commits: commit ad6b352bffdba5c45fa0915c7fdf8f5460409fc3 Author: Matteo Casalin matteo.casa...@gmx.com Date: Sat Jul 14 18:46:58 2012 +0200

My first experience on Gerrit

2012-07-29 Thread Matteo Casalin
Hi all, just my first impressions about gerrit, hoping it could be useful to improve the developer experience. * Registration with OpenID: no all providers are accepted: openid.org (first choice, seen suggested on a mail for initial announce), was not. It could be useful to add a list

Copyright (was: Re: How to change zoom from sfx2 appserv?)

2012-06-11 Thread Matteo Casalin
Hi all, a possibly silly question, but I'm wondering why new code files (e.g. sfx2/inc/sfx2/zoomitem.hxx) say: + * Copyright 2000, 2010 Oracle and/or its affiliates. + * + * OpenOffice.org - a multi-platform office productivity suite + * + * This file is part of OpenOffice.org Is this

Re: Copyright

2012-06-12 Thread Matteo Casalin
On 06/08/2012 05:42 PM, Caolán McNamara wrote: On Fri, 2012-06-08 at 15:59 +0200, Matteo Casalin wrote: Hi all, a possibly silly question, but I'm wondering why new code files (e.g. sfx2/inc/sfx2/zoomitem.hxx) say: cause I just moved it from svx, its not a new file, just a moved old file

Re: [Patch] Removed repeated calls in for loops in swnewtable.cxx

2012-07-09 Thread Matteo Casalin
Hi all, just a minor hint from my side: in the original code nBox was incremented only when pBox == rBoxes[nBox], while in the new one it happens unconditionally. I don't know if this could be an issue or not. To preserve the original behaviour a single conditional if ( nBox nBoxCnt

Re: [Patch] Removed repeated calls in for loops in swnewtable.cxx

2012-07-09 Thread Matteo Casalin
if ( nBox nBoxCnt pBox == rBoxes[nBox] ) { could be used. Should I send a new patch? or will the reviewers make the change before pushing? Sorry, I really don't know which is the preferred way to proceed for such short patches. - Jesso Clarence Thanks for you contribution Matteo

Re: [PUSHED] Decrease header files dependencies

2012-07-12 Thread Matteo Casalin
Hi all, On 07/11/2012 05:27 PM, Bjoern Michaelsen wrote: Hi, On Wed, Jul 11, 2012 at 10:38:42AM +0100, Michael Meeks wrote: Found pushed; did I miss a gerrit mail mentioning that ? Thats http://code.google.com/p/gerrit/issues/detail?id=1465 if one pushed directly to master, gerrit

Re: [PATCH] [core/vcl/source/window/splitwin.cxx:2047] -[core/vcl/source/window/splitwin.cxx:2045]:(style) Found duplicate branches for if and else.

2012-02-16 Thread Matteo Casalin
Hi all, -- Mariusz Dykierek mariuszdykie...@gmail.com wrote: (16/02/2012 11:46) On 2012-02-16 10:02, Stephan Bergmann wrote: On 02/16/2012 09:35 AM, Riccardo Magliocchetti wrote: Otherwise you can simplify it even more: sal_Bool bLeft =

[UX ADVICE] Key navigation in ValueSet controls

2012-02-29 Thread Matteo Casalin
Hi all, lately I've been working on ValueSet code, which is used in several controls (e.g. color selection, color configuration, columns selection in writer...), doing some cleanups. When the code will be more manageable I plan to fix some little bugs (selection/focus). Looking at the

[UX advise] Key navigation in ValueSet controls

2012-02-29 Thread Matteo Casalin
Hi all, lately I've been working on ValueSet code, which is used in several controls (e.g. color selection, color configuration, columns selection in writer...), doing some cleanups. When the code will be more manageable I plan to fix some little bugs (selection/focus). Looking at the

Re: [UX advise] Key navigation in ValueSet controls

2012-03-04 Thread Matteo Casalin
Hi Astron, On 03/03/2012 04:07 PM, Stefan Knorr (Astron) wrote: Hi Matteo, so, took me a while to find the courage to read that :) But good observations these are. Yeah, I was quite afraid of the length of my email :) Thanks for reading it all! Anyway, ... Is this behavior the

Re: [UX advise] Key navigation in ValueSet controls

2012-03-19 Thread Matteo Casalin
Hi Astron, thanks for you feedback. Before beginning to modify the behavior of key navigation, I'd like to recap the things that I should do, as from my understanding of our discussion. Would you mind confirming them (yes/no will suffice)? * left/right keys should not wrap around from top

Re: [UX advise] Key navigation in ValueSet controls

2012-03-23 Thread Matteo Casalin
and try to add some thoughts. Sorry if it is a bit too late. Matteo Casalin wrote (03-03-12 18:54) On 03/03/2012 04:07 PM, Stefan Knorr (Astron) wrote: * left/right motion should not wrap around from first to last (or last to first) item. Moving through lines is fine (behavior similar to moving

Re: [UX advise] Key navigation in ValueSet controls

2012-04-03 Thread Matteo Casalin
selected by normal key navigation (no special keys). Next steps: fix the code that handles item selection. Looking forward to your feedback Matteo On 03/24/2012 12:31 AM, Cor Nouws wrote: Matteo Casalin wrote (23-03-12 21:30) On 03/21/2012 01:23 PM, Cor Nouws wrote: One could say

Question about intended behaviour in UpdateTags (sd, annotationmanager.cxx)

2013-01-03 Thread Matteo Casalin
Hi all, and my best wishes for 2013! While browsing through code, I noticed that sd/source/ui/annotations/annotationmanager.cxx presents poor indentation. I have a doubt on the following function, line 832: 825 void AnnotationManagerImpl::UpdateTags( bool bSynchron ) 826 { 827 if(

Always getting Moderator approval notification

2013-01-03 Thread Matteo Casalin
) spam in the list, which kind of makes this thing funny. Thanks in advance Matteo Casalin ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Crash during Traditional Chinese - Simplified Chinese conversion

2013-01-03 Thread Matteo Casalin
Hi all, I've been lately struggling with crash in conversion from Traditional to Simplified Chinese in Writer. After some debugging, I tracked the problem to access to released memory, but I don't know ho to proceed to solve the issue since it involves a deeper knowledge than I have about

Re: Always getting Moderator approval notification

2013-01-03 Thread Matteo Casalin
Hi Eike, On 01/03/2013 07:35 PM, Eike Rathke wrote: Hi Matteo, On Thursday, 2013-01-03 11:34:16 +0100, Matteo Casalin wrote: when posting to this list I always get a notification for moderator approval. Could this be due to my (not so recent) change of email address? Ho hum.. indeed

Re: why are we catching std::bad_alloc ?

2013-01-04 Thread Matteo Casalin
On 01/04/2013 08:53 AM, Noel Grandin wrote: Why are we catching std::bad_alloc all over the place? git grep 'catch.*bad_alloc' | wc -l 68 Surely we should just let it crash? Or have a single handler for the whole process that at least attempts to provide some debugging data? I

Re: Crash during Traditional Chinese - Simplified Chinese conversion

2013-01-04 Thread Matteo Casalin
Hi Michael, On 01/03/2013 10:52 PM, Michael Stahl wrote: On 03/01/13 19:26, Matteo Casalin wrote: Hi all, I've been lately struggling with crash in conversion from Traditional to Simplified Chinese in Writer. After some debugging, I tracked the problem to access to released memory, but I

Re: Crash during Traditional Chinese - Simplified Chinese conversion

2013-01-04 Thread Matteo Casalin
On 01/04/2013 01:07 PM, Matteo Casalin wrote: Hi Michael, On 01/03/2013 10:52 PM, Michael Stahl wrote: On 03/01/13 19:26, Matteo Casalin wrote: Hi all, I've been lately struggling with crash in conversion from Traditional to Simplified Chinese in Writer. After some debugging, I tracked

Re: Doing massive source changes

2013-01-04 Thread Matteo Casalin
Hi, On 01/04/2013 03:12 PM, Lubos Lunak wrote: Hello, I have a patch that is 32M big and I rather wonder when to commit it. The patch specifically is string rtl:: prefix removal. These changes regularly show up in gerrit patches for review, but I think we have somewhat better EasyHacks

Re: Crash during Traditional Chinese - Simplified Chinese conversion

2013-02-05 Thread Matteo Casalin
Hi Cedric, On Tue, 05 Feb 2013 15:01:36 +0100 Cedric Bosdonnat cbosdon...@suse.com wrote: On Mon, 2013-02-04 at 12:27 +0100, Michael Stahl wrote: On 03/02/13 10:54, Cedric Bosdonnat wrote: Hi Matteo, On Fri, 2013-01-04 at 14:58 +0100, Matteo Casalin wrote: Obviously, this would

[Libreoffice-commits] core.git: editeng/source

2013-04-21 Thread Matteo Casalin
editeng/source/editeng/textconv.cxx |7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) New commits: commit 8e73c8ebcb4110e09d386927ffbe95a49ac5565c Author: Matteo Casalin matteo.casa...@yahoo.com Date: Sun Apr 21 19:05:34 2013 +0200 Avoid multiple appends on OUString

[Libreoffice-commits] core.git: editeng/source

2013-04-22 Thread Matteo Casalin
editeng/source/misc/hangulhanja.cxx |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) New commits: commit d1f99bdf2abf591994b6efb2e73dcd31fdee8384 Author: Matteo Casalin matteo.casa...@yahoo.com Date: Sun Apr 21 17:38:39 2013 +0200 bDocumentDone is always false Change

[Libreoffice-commits] core.git: editeng/source

2013-04-22 Thread Matteo Casalin
editeng/source/editeng/textconv.cxx | 148 +--- editeng/source/editeng/textconv.hxx | 36 2 files changed, 91 insertions(+), 93 deletions(-) New commits: commit 43513fec9c74d70da83a71c9a06e191db3f02d40 Author: Matteo Casalin matteo.casa...@yahoo.com

[Libreoffice-commits] core.git: editeng/source

2013-04-22 Thread Matteo Casalin
editeng/source/editeng/textconv.cxx |7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) New commits: commit e7bfe847114d7fd95e6820db01ca9ee876468fbe Author: Matteo Casalin matteo.casa...@yahoo.com Date: Sun Apr 21 18:38:40 2013 +0200 Do not store return value for later, just

Re: Killing the gerrit to dev-list spam ...

2013-05-02 Thread Matteo Casalin
Hi, On Thu, 02 May 2013 06:58:50 +0200 Jean-Baptiste Faure jbf.fa...@sud-ouest.org wrote: Hi, Le 01/05/2013 21:33, Bjoern Michaelsen a écrit : [...] So, is there anyone who is _not_ a sponsored developer opposing to kill the mail spammage? If so: [...] Opinions? Even

[Libreoffice-commits] core.git: editeng/source

2013-05-02 Thread Matteo Casalin
editeng/source/misc/hangulhanja.cxx |3 --- 1 file changed, 3 deletions(-) New commits: commit 485b1ac04c567d9d11cd395cf0a62cc43cabd8ad Author: Matteo Casalin matteo.casa...@yahoo.com Date: Sun Apr 28 23:21:35 2013 +0200 This method is not implemented Change-Id

[Libreoffice-commits] core.git: 2 commits - sw/source

2013-05-12 Thread Matteo Casalin
sw/source/ui/uiview/viewport.cxx | 30 +- 1 file changed, 17 insertions(+), 13 deletions(-) New commits: commit 0e540d7e393b05b3813206ed60be2c51a8d80aa2 Author: Matteo Casalin matteo.casa...@yahoo.com Date: Sun May 12 17:37:22 2013 +0200 Fix indentation

Re: [Libreoffice-commits] core.git: desktop/source

2013-02-20 Thread Matteo Casalin
Hi all, I may be completely wrong and I really don't know this code and what it is aimet to, but I'm worried that if (nBytes 0) { pReceiveBuffer[nBytes-1] = 0; } overwrites a received character (that could be '\0' or not). If I understand correctly, the target is to

Re: [Libreoffice-commits] core.git: desktop/source

2013-02-20 Thread Matteo Casalin
On Wed, 20 Feb 2013 15:32:10 +0100 Matteo Casalin matteo.casa...@gmx.com wrote: Hi all, I may be completely wrong and I really don't know this code and what it is aimet to, but I'm worried that if (nBytes 0) { pReceiveBuffer[nBytes-1] = 0; } overwrites

[Libreoffice-commits] core.git: sw/source

2013-02-23 Thread Matteo Casalin
sw/source/core/txtnode/ndtxt.cxx |8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) New commits: commit 09a015e64e0433652beaca2d5294162c20d97a8b Author: Matteo Casalin matteo.casa...@yahoo.com Date: Sat Feb 23 22:55:15 2013 +0100 Slight simplification of loop Change

[Libreoffice-commits] core.git: sw/source

2013-12-15 Thread Matteo Casalin
sw/source/core/unocore/unoportenum.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit a9c7de326b9e405a9fb4447627ce1cd9883280e5 Author: Matteo Casalin matteo.casa...@yahoo.com Date: Sun Dec 15 10:12:03 2013 +0100 Fix comparison between signed/unsigned

[Libreoffice-commits] core.git: sw/source

2013-12-16 Thread Matteo Casalin
sw/source/core/text/SwGrammarMarkUp.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 42aec34a5d83d863e050da85f88b31417c44b698 Author: Matteo Casalin matteo.casa...@yahoo.com Date: Mon Dec 16 22:34:42 2013 +0100 Fix a previous commit Thanks

[Libreoffice-commits] core.git: 2 commits - sw/source

2013-12-18 Thread Matteo Casalin
sw/source/core/table/swtable.cxx |4 ++-- sw/source/filter/ww1/fltshell.cxx |6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) New commits: commit 65e6d651ceef55f569521a4f4e609f7e5e88847b Author: Matteo Casalin matteo.casa...@yahoo.com Date: Tue Dec 17 00:12:03 2013 +0100

[Libreoffice-commits] core.git: sw/inc sw/source

2013-12-19 Thread Matteo Casalin
insertions(+), 25 deletions(-) New commits: commit 79932eccec436efbff41d5352c58d8ab224b0581 Author: Matteo Casalin matteo.casa...@yahoo.com Date: Mon Dec 16 22:30:41 2013 +0100 Do not expose TXTNODE_MAX and cleanup related code/comments Change-Id: Ia114688ebbdf81122b81183456924c6b9cff835d

[Libreoffice-commits] core.git: sw/inc sw/source

2013-06-07 Thread Matteo Casalin
|2 +- 5 files changed, 48 insertions(+), 48 deletions(-) New commits: commit 4af491df711510369f423d45565b4d744e637238 Author: Matteo Casalin matteo.casa...@yahoo.com Date: Fri Jun 7 09:15:44 2013 +0200 sal_Bool to bool Change-Id: I73bc2cbf3abf8de041302b6342b49275fb3c2ce6 diff

[Libreoffice-commits] core.git: sw/inc sw/qa sw/source

2013-06-10 Thread Matteo Casalin
Author: Matteo Casalin matteo.casa...@yahoo.com Date: Sun Jun 9 11:47:16 2013 +0200 String to OUString Change-Id: I89f228b64c85b5844b3049206bf97877473a04d3 Reviewed-on: https://gerrit.libreoffice.org/4212 Reviewed-by: Miklos Vajna vmik...@suse.cz Tested-by: Miklos Vajna

String to OUString and SDIs

2013-06-10 Thread Matteo Casalin
Hi all, I'm currently working in String to OUString conversion. Randomly, I started converting include/svl/poolitem.hxx (just removing an unused #include tools/string.hxx), and this started a long sequence of files to be fixed. In these, I found that some classes are referred by SDI files

Re: String to OUString and SDIs

2013-06-11 Thread Matteo Casalin
- Original Message - From: Stephan Bergmann sberg...@redhat.com To: libreoffice@lists.freedesktop.org Cc: Sent: Tuesday, June 11, 2013 2:20 PM Subject: Re: String to OUString and SDIs On 06/11/2013 10:32 AM, Matteo Casalin wrote: From: Stephan Bergmann sberg...@redhat.com

[Libreoffice-commits] core.git: sw/inc sw/source

2013-06-12 Thread Matteo Casalin
(+), 6 deletions(-) New commits: commit c4ebd00813f0f9ac333546db9d87d2da2563f2fb Author: Matteo Casalin matteo.casa...@yahoo.com Date: Sun Jun 9 10:20:17 2013 +0200 include cleanup Change-Id: I7818fe1f6acedc40b1bdd59cfa7e8fe23a6c685e Reviewed-on: https://gerrit.libreoffice.org

OUString concatenation vs OUStringBuffer append

2013-06-14 Thread Matteo Casalin
Hi all,    in a recent patch [1] for String to OUString conversion I replaced the construction of an OUString from a sequence of OUStringBuffer.append to a single concatenation of OUString/constant strings [2]. Noel Power (whom I thank for the careful review, and is here in copy), correctly

[Libreoffice-commits] core.git: sw/inc sw/source

2013-07-15 Thread Matteo Casalin
sw/inc/fldbas.hxx|2 -- sw/source/core/fields/fldbas.cxx |7 ++- 2 files changed, 6 insertions(+), 3 deletions(-) New commits: commit 02c1f4128b2011ceea6e4a0ceb054ec74315ec54 Author: Matteo Casalin matteo.casa...@yahoo.com Date: Sun Jun 23 23:46:05 2013 +0200

[Libreoffice-commits] core.git: sw/inc sw/source

2013-07-15 Thread Matteo Casalin
sw/inc/fldbas.hxx|4 ++-- sw/source/core/fields/fldbas.cxx | 27 +-- sw/source/core/fields/usrfld.cxx |5 ++--- 3 files changed, 17 insertions(+), 19 deletions(-) New commits: commit 67db35da5d7a3b117a0e0035c17c2fb58e5f23e6 Author: Matteo Casalin

Re: long paras + tools/string.hxx

2014-01-21 Thread Matteo Casalin
Hi all, On Tue, 21 Jan 2014 12:10:40 + Caolán McNamara caol...@redhat.com wrote: The 16 bit length limitation in writer is now removed towards 4.3. The 16 bit paragraph length limit in editeng still remains, editeng mixes freely sal_uInt16 with xub_StrLen and has a pile of hard-coded

[CLOSED] Re: OUString concatenation vs OUStringBuffer append

2013-06-15 Thread Matteo Casalin
- Original Message - From: Matteo Casalin matteo.casa...@yahoo.com To: libreoffice-dev LibreOffice@lists.freedesktop.org Cc: Noel Power nopo...@suse.com Sent: Friday, June 14, 2013 3:19 PM Subject: OUString concatenation vs OUStringBuffer append Hi all,    in a recent patch [1

[Libreoffice-commits] core.git: sw/source

2013-06-16 Thread Matteo Casalin
sw/source/core/crsr/pam.cxx | 48 ++-- 1 file changed, 25 insertions(+), 23 deletions(-) New commits: commit 21e43f598eb8ff7347876d8a61d7b2de29b8e7fe Author: Matteo Casalin matteo.casa...@yahoo.com Date: Sun Jun 9 12:05:10 2013 +0200 Simplify

[Libreoffice-commits] core.git: sw/source

2013-06-19 Thread Matteo Casalin
sw/source/ui/docvw/edtwin.cxx | 26 +++--- 1 file changed, 11 insertions(+), 15 deletions(-) New commits: commit 4bb1b555c533493799d780f18c1ab602677ef88a Author: Matteo Casalin matteo.casa...@yahoo.com Date: Sun Jun 9 13:17:42 2013 +0200 Rework code after

Re: Failures in sw/source/core/doc/doccomp.cxx(2122)

2013-11-15 Thread Matteo Casalin
On Fri, 15 Nov 2013 11:11:22 + Caolán McNamara caol...@redhat.com wrote: On Thu, 2013-11-14 at 10:03 +0100, Matteo Casalin wrote: This is my fault, unluckily I won't be able to work on that until this late evening. If someone can work on that, the (untested) fix for line 2122

[Libreoffice-commits] core.git: sw/source

2013-11-23 Thread Matteo Casalin
sw/source/filter/ww8/ww8par.cxx | 26 +++--- 1 file changed, 11 insertions(+), 15 deletions(-) New commits: commit e3b7e62b0dc34787f66c504230252b2c5edd18c3 Author: Matteo Casalin matteo.casa...@yahoo.com Date: Sat Nov 23 15:34:09 2013 +0100 Remove STRING_MAXLEN

[Libreoffice-commits] core.git: 10 commits - sw/source

2013-11-24 Thread Matteo Casalin
/source/core/undo/untbl.cxx | 12 +++ sw/source/filter/ascii/ascatr.cxx | 17 +- 13 files changed, 72 insertions(+), 88 deletions(-) New commits: commit 5cad3ba0bf5cb2e77ac565ca855ccf39626297d7 Author: Matteo Casalin matteo.casa...@yahoo.com Date: Sun Nov 24 14:34:45

Re: xub_StrLen and = 64k paragraphs

2013-11-28 Thread Matteo Casalin
On Thu, 28 Nov 2013 16:02:06 + Caolán McNamara caol...@redhat.com wrote: So now UniString is gone we have the chance to make use of OUString for = 64k paragraphs (#i17171#) but we basically have to decide what to do with places that currently return STRING_LEN/STRING_MAXLEN in xub_Strlen

[Libreoffice-commits] core.git: 6 commits - sw/inc sw/source

2013-12-02 Thread Matteo Casalin
/unotextmarkup.cxx | 12 - 16 files changed, 228 insertions(+), 237 deletions(-) New commits: commit 5170b4e49afd113567d4bbdd8f7b6be9eaa66888 Author: Matteo Casalin matteo.casa...@yahoo.com Date: Sun Dec 1 18:04:38 2013 +0100 Move functions to right file, prefer sal_Int32 to sal_uInt32

[Libreoffice-commits] core.git: sw/source

2013-07-30 Thread Matteo Casalin
sw/source/ui/misc/glosdoc.cxx | 126 -- 1 file changed, 60 insertions(+), 66 deletions(-) New commits: commit c3967de41502f973104b8d42c53f9faf932e2bd7 Author: Matteo Casalin matteo.casa...@yahoo.com Date: Sun Jul 21 16:06:38 2013 +0200 Bail out

[Libreoffice-commits] core.git: sw/source

2013-07-30 Thread Matteo Casalin
sw/source/ui/misc/glosdoc.cxx | 50 -- 1 file changed, 24 insertions(+), 26 deletions(-) New commits: commit 636f90327f4452eca9bf16c84b6cff0239c222a0 Author: Matteo Casalin matteo.casa...@yahoo.com Date: Sun Jul 21 19:04:12 2013 +0200 String

[Libreoffice-commits] core.git: unotools/source

2013-07-30 Thread Matteo Casalin
unotools/source/config/cmdoptions.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 7afc29809ec9db8c5064d5b5857f64db9bd843be Author: Matteo Casalin matteo.casa...@yahoo.com Date: Tue Jul 30 14:06:51 2013 +0200 Typos in debug messages Change-Id

[Libreoffice-commits] core.git: editeng/source include/editeng sw/inc sw/source

2013-07-30 Thread Matteo Casalin
/SwXMLBlockListContext.cxx |8 sw/source/core/swg/SwXMLTextBlocks.cxx |6 +++--- sw/source/core/swg/SwXMLTextBlocks1.cxx|4 ++-- 12 files changed, 43 insertions(+), 38 deletions(-) New commits: commit 73a136945d50a207c9e1c552d02c90d5c862c470 Author: Matteo Casalin

[Libreoffice-commits] core.git: sw/source

2013-07-30 Thread Matteo Casalin
sw/source/core/unocore/unobkm.cxx |7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) New commits: commit 5f7860bc2735bad3cd27552867ce25096835dcbb Author: Matteo Casalin matteo.casa...@yahoo.com Date: Sun Jul 28 13:20:56 2013 +0200 OUString: remove unnecessary casts

[Libreoffice-commits] core.git: sw/source

2013-07-30 Thread Matteo Casalin
sw/source/ui/dochdl/selglos.cxx |6 ++ sw/source/ui/inc/selglos.hxx| 12 +--- 2 files changed, 7 insertions(+), 11 deletions(-) New commits: commit 38e54583bcf07a71974777d13d2cf98519c8635b Author: Matteo Casalin matteo.casa...@yahoo.com Date: Sun Jul 28 00:14:47 2013

[Libreoffice-commits] core.git: editeng/qa editeng/source include/editeng sw/inc sw/source

2013-07-30 Thread Matteo Casalin
: commit 31ab7f0c7d20f1d7be5ce818d0d99b6bd5a8edde Author: Matteo Casalin matteo.casa...@yahoo.com Date: Sun Jul 28 16:40:20 2013 +0200 String to OUString Change-Id: I8d4f62b473ad43807621a9dbb826ed33857b737e Reviewed-on: https://gerrit.libreoffice.org/5189 Reviewed-by: LuboÅ¡ LuÅ

[Libreoffice-commits] core.git: sw/inc sw/source

2013-07-31 Thread Matteo Casalin
+--- sw/source/ui/misc/glossary.cxx | 56 +++--- sw/source/ui/uno/unoatxt.cxx | 18 - 13 files changed, 115 insertions(+), 122 deletions(-) New commits: commit e1c2cb7dc89753c81618a6e4ce95dd9b0d43782f Author: Matteo Casalin

[Libreoffice-commits] core.git: sw/inc sw/source

2013-07-31 Thread Matteo Casalin
+-- sw/source/ui/misc/glosdoc.cxx|2 sw/source/ui/uno/unoatxt.cxx |4 - 11 files changed, 213 insertions(+), 206 deletions(-) New commits: commit 734295ee6081686b62a4521dacf4975240e1109e Author: Matteo Casalin matteo.casa...@yahoo.com Date: Sat Jul 27 12:56

[Libreoffice-commits] core.git: sw/source

2013-07-31 Thread Matteo Casalin
sw/source/ui/misc/glosbib.cxx | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) New commits: commit de7529b38f8ea9ee8198de1d82525a68cc6e89b8 Author: Matteo Casalin matteo.casa...@yahoo.com Date: Thu Jul 25 20:31:37 2013 +0200 Do not use deprecated comphelper

[Libreoffice-commits] core.git: sw/inc sw/source

2013-07-31 Thread Matteo Casalin
sw/inc/SwStyleNameMapper.hxx | 10 sw/source/core/doc/SwStyleNameMapper.cxx | 388 +++ 2 files changed, 146 insertions(+), 252 deletions(-) New commits: commit 85992e23e734dd728919b72bfa0632c1bf940c28 Author: Matteo Casalin matteo.casa...@yahoo.com

Re: Multiple identities on Gerrit?

2013-08-01 Thread Matteo Casalin
Thanks Norbert for looking into this, I'm PM'ing you the details. Kind regards Matteo On Thu, 1 Aug 2013 08:49:38 -0500 Norbert Thiebaud nthieb...@gmail.com wrote: On Thu, Aug 1, 2013 at 3:37 AM, Matteo Casalin matteo.casa...@yahoo.com wrote: Hi all, yesterday I had problems logging

[Libreoffice-commits] core.git: 2 commits - sw/source

2013-08-03 Thread Matteo Casalin
sw/source/core/crsr/callnk.cxx |2 +- sw/source/core/crsr/crossrefbookmark.cxx | 12 2 files changed, 9 insertions(+), 5 deletions(-) New commits: commit 2d275be83f905f88c8c4ec982165af9102e3a920 Author: Matteo Casalin matteo.casa...@yahoo.com Date: Wed Jul 31 08:00

[Libreoffice-commits] core.git: sw/source

2013-08-10 Thread Matteo Casalin
sw/source/core/doc/doctxm.cxx |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) New commits: commit 0b6ad716d1fbae7523359fdaf1d6a716eae9a891 Author: Matteo Casalin matteo.casa...@yahoo.com Date: Fri Aug 9 23:15:28 2013 +0200 Remove redundant conditions Change-Id

[Libreoffice-commits] core.git: sw/source

2013-08-10 Thread Matteo Casalin
sw/source/filter/ww8/wrtw8nds.cxx | 47 -- 1 file changed, 21 insertions(+), 26 deletions(-) New commits: commit 8cb156a67b987981efbda3640e503d601c40d88b Author: Matteo Casalin matteo.casa...@yahoo.com Date: Fri Aug 9 23:13:43 2013 +0200 String

[Libreoffice-commits] core.git: sw/source

2013-08-10 Thread Matteo Casalin
sw/source/ui/dbui/mmaddressblockpage.cxx | 35 --- 1 file changed, 14 insertions(+), 21 deletions(-) New commits: commit 32447330e6b62a2e886a5758fc35e844a7f5f28f Author: Matteo Casalin matteo.casa...@yahoo.com Date: Sat Aug 10 23:25:07 2013 +0200 String

[Libreoffice-commits] core.git: sw/inc sw/source

2013-08-11 Thread Matteo Casalin
sw/inc/doc.hxx|2 sw/source/core/doc/doctxm.cxx | 139 -- sw/source/core/tox/tox.cxx|2 3 files changed, 82 insertions(+), 61 deletions(-) New commits: commit 026de9b0aef2143ae9457088aa80444ec1b7cdbb Author: Matteo Casalin

Gerrit patch pushed by accident

2013-08-12 Thread Matteo Casalin
Hi all, I just submitted a patch to gerrit, forgot to nextchange, made a small unrelated typo fix and pushed it to master, which resulted in pushing to master also the patch which was standing in gerrit :( That patch (namely: https://gerrit.libreoffice.org/5372 ) passes make check, so

[Libreoffice-commits] core.git: sw/inc sw/source

2013-08-13 Thread Matteo Casalin
sw/inc/cellfml.hxx| 44 ++--- sw/source/core/fields/cellfml.cxx | 124 +++--- 2 files changed, 84 insertions(+), 84 deletions(-) New commits: commit fa78b33a10ceb46b11caa726512a0862b9775b56 Author: Matteo Casalin matteo.casa...@yahoo.com

[Libreoffice-commits] core.git: sw/inc sw/source

2013-08-14 Thread Matteo Casalin
e32a74ca1ba5c89f97b5741f376ae6a2c2ee32d4 Author: Matteo Casalin matteo.casa...@yahoo.com Date: Tue Aug 13 20:22:13 2013 +0200 String to OUString Change-Id: Ib185c067c52bb8c65441c30d4c61be24b0950afd Reviewed-on: https://gerrit.libreoffice.org/5394 Reviewed-by: Tor Lillqvist t...@iki.fi Tested-by: Tor Lillqvist

[Libreoffice-commits] core.git: sw/source

2013-08-14 Thread Matteo Casalin
/source/filter/ww8/docxfootnotes.hxx | 22 +- 6 files changed, 10 insertions(+), 17 deletions(-) New commits: commit 8ae46066e6b03e70901bbacf972e6965a43f3c53 Author: Matteo Casalin matteo.casa...@yahoo.com Date: Tue Aug 13 22:51:49 2013 +0200 Cleanup #include

[Libreoffice-commits] core.git: sw/inc sw/source

2013-08-14 Thread Matteo Casalin
sw/inc/unostyle.hxx | 18 ++--- sw/source/core/unocore/unostyle.cxx | 115 +--- 2 files changed, 64 insertions(+), 69 deletions(-) New commits: commit 6050cf2e100eb18d8638cf61f545ba7a0ec41b69 Author: Matteo Casalin matteo.casa...@yahoo.com Date

[Libreoffice-commits] core.git: sw/inc sw/source

2013-08-14 Thread Matteo Casalin
deletions(-) New commits: commit 5b827d6c75cc12623d35487a8769768a0cfe40a6 Author: Matteo Casalin matteo.casa...@yahoo.com Date: Wed Aug 14 15:49:14 2013 +0200 String to OUString, data member prefix, some formatting Change-Id: Ieab44a1b8e53b4144836e8f406f522b1febffe92 Reviewed-on: https

[Libreoffice-commits] core.git: sw/source

2013-08-14 Thread Matteo Casalin
sw/source/ui/inc/insfnote.hxx | 13 ++--- sw/source/ui/misc/insfnote.cxx | 19 +-- 2 files changed, 15 insertions(+), 17 deletions(-) New commits: commit cb34d10ec875cb538d9d8d41faa995f7469ae89f Author: Matteo Casalin matteo.casa...@yahoo.com Date: Wed Aug 14 09:53

[Libreoffice-commits] core.git: sw/inc sw/source

2013-08-14 Thread Matteo Casalin
/source/filter/ww8/ww8par2.cxx |2 - sw/source/ui/docvw/edtwin2.cxx |4 +- sw/source/ui/misc/insfnote.cxx |2 - 18 files changed, 88 insertions(+), 81 deletions(-) New commits: commit cafcf33915fe30af693a94f4224fedd5cb9f9a55 Author: Matteo Casalin

  1   2   3   4   5   6   7   >