[Libreoffice] gdb: info mutex

2011-10-18 Thread Michael Stahl
have just found a great python command for GDB by Tom Tromey called info mutex: http://www.cygwin.com/ml/archer/2010-q3/msg00024.html looks very helpful for debugging a deadlock: (gdb) info mutex Mutex 0x264fbb0: * Owned by thread 25481 Thread 27391 Mutex 0xbd4370: Owned by thread

[Libreoffice] [PUSHED] Re: [REVIEW-3.5] Handling ordering problem when properties are set one by one

2012-01-24 Thread Michael Stahl
On 24/01/12 16:12, Lubos Lunak wrote: On Tuesday 24 of January 2012, Michael Stahl wrote: On 23/01/12 21:31, Lubos Lunak wrote: It seems to be quite a common way for LO code to use this let's-push-all-the-data-as-properties-one-by-one approach, so I wonder what the common way of avoiding

[Libreoffice] bootstrap repos (was: Re: Problem with clipboard paste in 3.5)

2012-01-24 Thread Michael Stahl
On 24/01/12 17:19, Korrawit Pruegsanusak wrote: Hello Petr, On Mon, Jan 23, 2012 at 17:29, Petr Cisar petr.ci...@ericsson.com wrote: I did some tests, I tried to put some debug printouts to file clone/libs-gui/dtrans/source/generic/clipboardmanager.cxx, but never seen one while running

Re: [Libreoffice] LibreOffice / openIndiana ...

2012-01-25 Thread Michael Stahl
On 25/01/12 22:29, Gary wrote: On Wed, Jan 25, 2012 at 12:03 PM, Michael Meeks wrote: Anyhow - please do ask questions etc. here - hopefully we're a friendly lot :-) I'd really recommend building from the libreoffice-3-5 code-branch, that is feature frozen and about to get released,

Re: [Libreoffice] [REVIEW][3-5][3.5.0][3-4] invalid cast from BoderLine to BorderLine2

2012-01-26 Thread Michael Stahl
On 26/01/12 15:56, Michael Meeks wrote: On Thu, 2012-01-26 at 14:45 +0100, Eike Rathke wrote: Please review and cherry-pick to 3-5, 3.5.0 and 3-4 http://cgit.freedesktop.org/libreoffice/core/commit/?id=97c66b3b13528cc50f271217663718b3d6681bd9 looks good to me for -3-5 and -3-5-0. me

Re: [Libreoffice] LibreOffice / openIndiana ...

2012-01-26 Thread Michael Stahl
On 26/01/12 17:42, Norbert Thiebaud wrote: On Thu, Jan 26, 2012 at 10:14 AM, Jonathan Adams t12nsloo...@gmail.com wrote: good to hear you're making some progress there :) files soltools/adjustvisibility/makefile.mk soltools/mkdepend/makefile.mk soltools/util/makefile.pmk: (probably not

Re: [Libreoffice] [REVIEW][3.5.0][3-5][3-4] fdo#38595 Calc cell borders lost in ODF import

2012-01-26 Thread Michael Stahl
On 26/01/12 14:20, Eike Rathke wrote: Hi, please review and cherry-pick to 3-5, 3.5.0 and 3-4 http://cgit.freedesktop.org/libreoffice/core/commit/?id=34315e7ec4062f9521cd19951b5f7f6ad9ce0d2e Resolves https://bugs.freedesktop.org/show_bug.cgi?id=38595 ooh, Calc also has this kind of

Re: [Libreoffice] [REVIEW]Fix for annoying bug fdo#35669

2012-01-26 Thread Michael Stahl
On 26/01/12 16:21, Cedric Bosdonnat wrote: Hi all, Could someone review and cherry-pick this commit to -3-5, -3-5-0 and -3-4? http://cgit.freedesktop.org/libreoffice/core/commit/?id=5e51960dede5015b862df05b7b16f02884647889 your fix looks good to me, except for the line: sal_uInt16

Re: [Libreoffice] [REVIEW]Fix for annoying bug fdo#35669

2012-01-26 Thread Michael Stahl
On 26/01/12 19:30, Michael Stahl wrote: On 26/01/12 16:21, Cedric Bosdonnat wrote: Hi all, Could someone review and cherry-pick this commit to -3-5, -3-5-0 and -3-4? http://cgit.freedesktop.org/libreoffice/core/commit/?id=5e51960dede5015b862df05b7b16f02884647889 your fix looks good to me

Re: [Libreoffice] Libreoffice On OPENINDIANA

2012-01-26 Thread Michael Stahl
On 26/01/12 16:46, Paolo Marcheschi wrote: If you want to run the smoketest, issue: make check but I had no luck, when i do a make, I receive the following error: make: Fatal error in reader: Makefile, line 35: Unexpected end of line seen Current working directory

Re: [Libreoffice] [REVIEW] revert sw list styles cleanup

2012-01-27 Thread Michael Stahl
On 27/01/12 13:14, Cedric Bosdonnat wrote: Hi all, if happens that the changes I made a few months ago aren't really mature and will need more love. I reverted them in master, and it would be cool if someone could review / cherry-pick it in 3.5 and 3.5.0.

Re: [Libreoffice] minutes of ESC call ...

2012-01-27 Thread Michael Stahl
On 27/01/12 16:44, Markus Mohrhard wrote: Hey, * unit test framework issues (Markus) + we are missing an important feature + cppunit development appears dead/stalled for 2+ yrs + but we support system-cppunit + can we not just declare ourselves the new

[Libreoffice] [REVIEW][3-*] Writer table border bugs fdo#38542 etc.

2012-01-27 Thread Michael Stahl
these commits fix ODF import bugs described in fdo#38542 (regressions from LO 3.3) and were already backported to libreoffice-3-5 by Cedric; they want to be in libreoffice-3-5-0 and libreoffice-3-4 as well:

Re: [Libreoffice] [REVIEW:3-5-0] use the correct application icon of Writer/Web under Windows

2012-01-30 Thread Michael Stahl
On 30/01/12 12:01, Noel Power wrote: On 27/01/12 18:42, Andras Timar wrote: Hi, I made a typo in my soffice.bin/soffice.exe icon reduction patch, so Writer/Web has the wrong application icon under Windows in rc2. The following commit fixes it.

Re: [Libreoffice] [REVIEW 3-5, 3-5-0]

2012-01-30 Thread Michael Stahl
On 28/01/12 13:53, Fridrich Strba wrote: Hello, a little safe patch that prevents that compatibility symbol we added for backward compatibility with older versions of Duden Korrektor from landing in the uwinapi.lib import library. This assures that no accidental linking with it will happen

Re: [Libreoffice] [REVIEW] fdo#43965 fix RTF import of page break symbol

2012-01-30 Thread Michael Stahl
On 30/01/12 21:44, Miklos Vajna wrote: Hi, See http://cgit.freedesktop.org/libreoffice/core/commit/?id=2aa3d43a3746c797391afb1a08c024d512976006 Could somebody sign-off and push to -3-5, please? (Technically this is a new feature in the tokenizer but it's a regression from LO-3.4, so I do

Re: [Libreoffice] [REVIEW]Fix for annoying bug fdo#35669

2012-01-30 Thread Michael Stahl
On 30/01/12 18:16, Cedric Bosdonnat wrote: Fixed in http://cgit.freedesktop.org/libreoffice/core/commit/?id=458d56d9b35f2ecb2eea2589737079390b10ee26 looking better... Would be nice to cherry-pick these two commits to -3-5, -3-4 and 3-5-0 (if it's not too late). pushed to libreoffice-3-5

[Libreoffice] [PUSHED^2] Re: [REVIEWED] Fix reading .doc comments (fdo#45255)

2012-01-30 Thread Michael Stahl
On 30/01/12 21:19, Caolán McNamara wrote: On Mon, 2012-01-30 at 19:52 +, Michael Meeks wrote: Looks lovely to me; pushed to -3-5, Caolan are you happy for 3.5.0 ? we had busted comment interop with .docx in 3.4 (so people used .doc) :-) Yeah, makes sense to me. +1 C. doesn't

[Libreoffice] [PUSHED] Re: [PATCH] [REVIEW:3-5, 3-5-0] fdo#34432 ODBC crash on 64 bits

2012-01-30 Thread Michael Stahl
On 30/01/12 15:43, Lionel Elie Mamane wrote: I attach here the less invasive variant originally meant for libreoffice-3-5. However, if people are happy with cherry-picking the (more invasive) master commit, by all means, cherry-pick it. This would have the advantage of not forking these

[Libreoffice] tracking ODF compliance issues

2012-01-31 Thread Michael Stahl
hi all, i'd like to have some easier way to track bugs related to ODF compliance in the bugzilla. what would be the best way to do this: - a new keyword, say odf or odf_validation - a tracking bug, that depends on all indidual ODF related bugs the OpenOffice.org issuezilla used a odf_validation

Re: [Libreoffice] Simplified C++ configuration access

2012-01-31 Thread Michael Stahl
On 31/01/12 15:06, Lubos Lunak wrote: On Tuesday 31 of January 2012, Stephan Bergmann wrote: To get a property's value, all that is needed is to call the wrapper class's static officecfg::Foo::Bar::Baz::Whatever::get member function, which requires the XComponentContext as argument (use

Re: [Libreoffice] [REVIEW 3-5, 3-5-0] fdo#42543: Empty wizard page in reportdesign

2012-01-31 Thread Michael Stahl
On 31/01/12 17:31, Lubos Lunak wrote: On Tuesday 31 of January 2012, Jan Holesovsky wrote: As a fix, I propose this: http://cgit.freedesktop.org/libreoffice/core/commit/?id=03e17a141fbb4e1242d e9d9979b5b699e6840454 Just get rid of the background image; in my opinion, it even looks better

[Libreoffice] default build verbosity

2012-01-31 Thread Michael Stahl
hi all, a recurring problem with remote debugging newbie build problems is that the default build is silent. i wonder if it would make sense to change that: with default configure invocation, build system outputs the full command to the terminal/log, and there is an explicit configure option to

Re: [Libreoffice] l10ntools clean-up?

2012-02-01 Thread Michael Stahl
On 01/02/12 10:55, Andras Timar wrote: Hi Stephan, 2012/2/1 Stephan Bergmann sberg...@redhat.com: Unless there's someone who screams but all this should go away in the next couple months, anyway! I would therefore go ahead and clean that code up, ridding it of any tools dependencies

Re: [Libreoffice] l10ntools clean-up?

2012-02-01 Thread Michael Stahl
On 01/02/12 12:29, Noel Grandin wrote: on rewriting things from scratch, see here: http://www.joelonsoftware.com/articles/fog69.html yes, and what a complete disaster that re-write was for Mozilla -- imagine how much of the market Firefox would have today if they had stuck with the

Re: [Libreoffice] l10ntools clean-up?

2012-02-01 Thread Michael Stahl
On 01/02/12 12:42, Stephan Bergmann wrote: On 02/01/2012 12:01 PM, Michael Stahl wrote: actually regressions should be easy to prevent here: just build 2 full trees with all options, e.g. enable all extensions, help, all languages; then diff the files produced by the tools. In principle

[Libreoffice] [REVIEW][3-{4, 5}] fdo#45446 fdo#45449 fdo#45450 fdo#45534: various invalid ODF problems

2012-02-02 Thread Michael Stahl
hi all, these fixes for invalid ODF produced by LO should go into libreoffice-3-4 and libreoffice-3-5: fdo#45449 0b7bba10208d198471cbdb56c2007e5cdb00a6ac fdo#45450 790365e79d28e2c2a41140707ac126dbf6966e38 fdo#45534 6c15b856242127ddca766da72489ba287e21 this one should go into -3-5, i'm

[Libreoffice] [REVIEW][3-{4, 5}] fdo#37024 forms web layout regression

2012-02-02 Thread Michael Stahl
hi all, these 2 patches should fix regression fdo#37024 so that forms open in web layout again: this one is from an OOo 3.4 CWS and is in 3-5 already, should fix the edit mode half-way, proposed for libreoffice-3-4: 2b39501b8ec6affb8afa9c6b93dff434b075e211 this is necessary for both open and

[PUSHED] Re: [REVIEW][3-4][3-5][3-5-0] resolve fdo#42784 BorderLine with only InnerLineWidth set does not work

2012-02-03 Thread Michael Stahl
On 02/02/12 19:38, Eike Rathke wrote: Hi, I'd like to have 971f826a96f0938bfcfd8dfe26edd50d8e031bb4 cherry-picked to 3-4, 3-5 and 3-5-0 if we do another rc. Resolves https://bugs.freedesktop.org/show_bug.cgi?id=42784 a BorderLine with only InnerLineWidth set does not result in a border.

Re: Question about iterator management in sw/source/core/fields/cellfml.cxx

2012-02-03 Thread Michael Stahl
On 03/02/12 14:01, Stephan Bergmann wrote: On 02/02/2012 09:08 PM, julien2412 wrote: Would this patch better ? (I kept the for loop) Unfortunately that still has a problem. After rBoxes.erase(toErase), it (which is the same as toErase) is invalidated, so incrementing it (up in the

Re: Question about iterator management in sw/source/core/fields/cellfml.cxx

2012-02-03 Thread Michael Stahl
On 03/02/12 17:21, Stephan Bergmann wrote: On 02/03/2012 04:18 PM, Michael Stahl wrote: On 03/02/12 14:01, Stephan Bergmann wrote: The standard idiom is for (iterator i = m.begin(); i != m.end();) { if (doErase) { m.erase(i++); } else { ++i

Re: Question about iterator management in sw/source/core/fields/cellfml.cxx

2012-02-03 Thread Michael Stahl
On 03/02/12 18:17, Terrence Enger wrote: Stephan, I am sorry to question your expertise, but I wonder ... is your reassurance based on knowledge of the language standard, or is based on observed behaviour of C++ compilers? hahaha, i believe that among all the developers who ever worked on

[REVIEW][3-{4,5}] fdo#45115 double table border API regression

2012-02-03 Thread Michael Stahl
hi all, proposing 2 commits to fix bug in Writer and Calc for libreoffice-3-5 and libreoffice-3-4: http://cgit.freedesktop.org/libreoffice/core/commit/?id=ef9881001e4ddfa6bfbe7d83f482393bb76d926a http://cgit.freedesktop.org/libreoffice/core/commit/?id=697743161a6047902ee880851b23c9aef1bfa392

[PUSHED] Re: [REVIEW][3-5][3.5.0][3-4] invalid cast from BoderLine to BorderLine2

2012-02-03 Thread Michael Stahl
On 26/01/12 14:45, Eike Rathke wrote: Hi, Please review and cherry-pick to 3-5, 3.5.0 and 3-4 http://cgit.freedesktop.org/libreoffice/core/commit/?id=97c66b3b13528cc50f271217663718b3d6681bd9 Fixes an invalid cast that caused an arbitrary memory access. Thanks Eike as just noted in

Re: [PATCH] convert SdPresLayoutDlg from tools/list.hxx to std::map

2012-02-04 Thread Michael Stahl
On 01/02/12 12:58, Noel Power wrote: Hi Noel On 31/01/12 14:24, Noel Grandin wrote: sorry, that should be converted to std::vector you mean boost::ptr_vector I think :-) Hope I didn't miss anything this time, I made some minor changes ( see attached patch ) e.g. I removed the

[PUSHED] Re: [REVIEW] fdo#42656 fix RTF export of picture frame shape type

2012-02-06 Thread Michael Stahl
On 05/02/12 14:41, Miklos Vajna wrote: Hi, See http://cgit.freedesktop.org/libreoffice/core/commit/?id=32fa7e9208b2053d2ff7743b88b0c0edacb8a7e7 Could somebody sign-off and push to -3-5, please? pushed (plus a follow up to replace mysterious 75 with ESCHER_ShpInst_PictureFrame)

Re: How far can the LO file's contents be stretched?

2012-02-06 Thread Michael Stahl
On 06/02/12 22:30, Johannes Sixt wrote: Am 06.02.2012 10:39, schrieb Michael Meeks: On Sun, 2012-02-05 at 21:50 +0100, Johannes Sixt wrote: 3) Can the styles listed in an office:automatic-styles section be renamed? For example: I believe the names are arbitrary and can be replaced

[PUSHED] Re: [PATCH] Including glib

2012-02-06 Thread Michael Stahl
On 06/02/12 17:24, Mihályi Dániel wrote: Hi! This patch corrects one line including a glib header not correctly. Regards, Dani thanks for the patch, pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=80f96ca6b5bd8a491275c5e192196642854a885c could you please

[PUSHED 4/4] Re: [PATCH 0/4] Remove some unused methods

2012-02-06 Thread Michael Stahl
On 06/02/12 23:05, Greg Kroah-Hartman wrote: Here are 4 patches removing some unused methods in the tree. All of these patches are contributed under the LGPLv3+ / MPL. great! Note, I also removed the line in the unusedcode.easy file at the same time, if I shouldn't have done that, let me

[REVIEW][3-4][3-5] fdo#38745 redline undo regression

2012-02-07 Thread Michael Stahl
hi all, the fix for this ridiculous bug from the why C++ is not my favourite language series needs to go into libreoffice-3-5 and libreoffice-3-4: http://cgit.freedesktop.org/libreoffice/core/commit/?id=13424b43c25389e303774c3fb2f2beb3e20ceae5 ___

Re: [REVIEW][3-{4, 5}] fdo#37024 forms web layout regression

2012-02-07 Thread Michael Stahl
On 07/02/12 12:39, Noel Power wrote: Hi Michael On 02/02/12 13:56, Michael Stahl wrote: hi all, these 2 patches should fix regression fdo#37024 so that forms open in web layout again: this one is from an OOo 3.4 CWS and is in 3-5 already, should fix the edit mode half-way, proposed

[PUSHED] Re: [REVIEW 3-5] fdo#45045 fix context sensitive help for Word Count dialog

2012-02-07 Thread Michael Stahl
On 06/02/12 16:18, Andras Timar wrote: Hi, I fixed https://bugs.freedesktop.org/show_bug.cgi?id=45045, help now jumps to the correct page either when I press F1, or when I press the Help button. However, the fix looks a bit hackish to me, help for old modal dialog worked well in 3.4 without

Re: How far can the LO file's contents be stretched?

2012-02-08 Thread Michael Stahl
On 08/02/12 10:16, Michael Meeks wrote: On Mon, 2012-02-06 at 23:32 +0100, Michael Stahl wrote: flat ODF filters don't support all features of package-based ODF (which is i guess the reason why OOo never shipped a flat ODF filter out of the box); also your images and embedded objects

[PUSHED] Re: [REVIEW][3-5][3-4]Fix for fdo#35669

2012-02-08 Thread Michael Stahl
On 08/02/12 14:30, Cedric Bosdonnat wrote: Hi all, Could someone review, cherry-pick -s the following commit in 3-5 and 3-4? http://cgit.freedesktop.org/libreoffice/core/commit/?id=44f971506c0ed37928c48e55d8007f24b0c43a5f makes sense; pushed to libreoffice-3-5:

Re: [REVIEW]Fix for annoying bug fdo#35669

2012-02-08 Thread Michael Stahl
On 08/02/12 15:05, Cedric Bosdonnat wrote: Hi Kendy, all, On Tue, 2012-01-31 at 15:50 +0100, Jan Holesovsky wrote: Looked fine. Worked reasonable = pushed into 3-5-0, see http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5-0id=4632a18dae5e1770aa1da4ac55719a09c1ae461b

Re: PATCH build errors on Ubuntu 10.04

2012-02-08 Thread Michael Stahl
On 08/02/12 16:58, Rene Engelhard wrote: Hi, On Wed, Feb 08, 2012 at 04:44:00PM +0100, Alexander Bergmann wrote: which are enabled by default, but can be disabled pretty safely. Some of them --disable-epm, --without-junit and --without-java were documented in the wiki:

Re: [PATCH] [REVIEW:3-5] postgresql compatibility with 8.4

2012-02-08 Thread Michael Stahl
On 08/02/12 13:51, Lionel Elie Mamane wrote: Attached patch restores compatibility of PostgreSQL-SDBC with PostgreSQL server version 8.4. LibO 3.5.0 accidentally works only with 9.0 and later. (9.0 came after 8.4, there is no 8.5.) Basically, it replaces try to be extra-smart and look

Re: OK to merge the fw? libraries in framework?

2012-02-08 Thread Michael Stahl
On 08/02/12 18:10, Tor Lillqvist wrote: While trying to find easy ways to lower the number of (shared) libraries, which is more or less on the critical path for the Android work (the stupid run-time linker on Android has a low (from our perverse perspective) limit on the number of shared

Re: [PUSHED 4/4] Re: [PATCH 0/4] Remove some unused methods

2012-02-08 Thread Michael Stahl
On 08/02/12 17:59, Greg Kroah-Hartman wrote: On Tue, Feb 07, 2012 at 01:26:18AM +0100, Michael Stahl wrote: patches to remove the tools/fsys trainwreck completely and adapt callers to use osl/file.hxx would be appreciated of course :) I've started to look into this. great :) It is safe

Re: GNU make version

2012-02-10 Thread Michael Stahl
which are never added directly by gb_LinkTarget_add_*Object. commit dfde3d1f8bd347c79b1f69ac9dac487229af6357 Author: Michael Stahl m...@openoffice.org Date: Fri Apr 15 17:27:07 2011 + gnumake4: #i117845#: LinkTarget.mk: refactor dep-files: [hg:371ab623e90d] replacing

Re: Adding Extension for Experimental Thai Spelling

2012-02-13 Thread Michael Stahl
On 11/02/12 17:23, Richard Wordingham wrote: As I understand it, the lack of a usable Thai spell-checker for LibreOffice (unlike, say, a Khmer spell-checker) is due to the Thai break iterator. (I had expected Thai and Khmer to face similar problems, for neither has a visible word separator

Re: OK to get rid of scaddins?

2012-02-13 Thread Michael Stahl
On 13/02/12 12:31, Tor Lillqvist wrote: Do we really need to keep analysis and date as separate shared libraries? Would it be OK to move their source code over to the sc module, and merge their objects into the sc library, and their ..component files into sc.component? is that really

[REVIEW][3-5][3-4] fdo#41712 SwFlowFrm::pPrecede regression

2012-02-13 Thread Michael Stahl
apparently a SwFlowFrm::pPrecede was introduced, turning the SwFlowFrm list from a singly linked list to a doubly linked list, without much thought given to the additional invariants that need to be maintained; these patches should fix that up and should go into libreoffice-3-4 and

Re: OK to get rid of scaddins?

2012-02-13 Thread Michael Stahl
On 13/02/12 15:47, Michael Meeks wrote: On Mon, 2012-02-13 at 12:38 +0100, Michael Stahl wrote: the sc, sd, sw libraries already take forever to link with full debug, You link with full debug ? :-) well i was actually surprised once that i do, but soon found out that somebody has

linking performance (was: Re: OK to get rid of scaddins?)

2012-02-14 Thread Michael Stahl
On 14/02/12 11:52, Michael Meeks wrote: Hi Michael, On Mon, 2012-02-13 at 16:06 +0100, Michael Stahl wrote: (of course i don't care if you do it for a special merged libs mode, but C++ development is already a sufficiently unproductive activity that we shouldn't make it even more so

Re: [PATCH] Help - minor updates

2012-02-14 Thread Michael Stahl
On 14/02/12 12:51, Radek Doulik wrote: Hi Stanislav, thanks for your patches! One thing I noticed, is it possible to replace StarOffice with LibreOffice instead of OpenOffice in patch #3? uhmm, those are compatibility options for ancient versions of SO/OOo, unless you have plans to release a

Re: faster java compilation (was Re: linking performance

2012-02-14 Thread Michael Stahl
On 14/02/12 13:30, Noel Grandin wrote: On 2012-02-14 14:22, Michael Meeks wrote: Perhaps; could it also be that we like to compile with gcc in some eight way parallel way, but when it comes to linking, we -really- don't want to bog our machine down in that way ? I wonder if we could

Re: Need help (mentor) while fixing an issue

2012-02-14 Thread Michael Stahl
On 13/02/12 15:19, Jan Holesovsky wrote: Hi Dag, Dag Wieers píše v Pá 10. 02. 2012 v 16:36 +0100: I found a bug in LibreOffice causing style:rel-width and style:rel-height not to accept scale as a possible value. In fact the behavior seems to be to default to 100% if anything except

[PUSHED] Re: [REVIEW 3-5] Adapt SDK to changed paths in LO installation

2012-02-14 Thread Michael Stahl
On 14/02/12 10:48, Stephan Bergmann wrote: Please review and cherry-pick to libreoffice-3-5 the commit http://cgit.freedesktop.org/libreoffice/core/commit/?id=bcdadc2e9f3f6a400438cbbefffc60bf02baa0f1 Resolves rhbz#789622: Adapt SDK to changed paths in LO installation. pushed to

[PUSHED][3-5] Re: [PATCH] [REVIEW:3-5,3-4] api documentation error

2012-02-14 Thread Michael Stahl
On 14/02/12 15:46, Lionel Elie Mamane wrote: I corrected an error (bad link/reference) in the API documentation for com::sun::star::sdbc::XDatabaseMetaData. Do we backport that kind of things? It would suck somewhat for our on-line version to be wrong until after the release of 3.6. So I

[PUSHED] Re: [REVIEW] fix RTF import of text frames with exact height

2012-02-14 Thread Michael Stahl
On 14/02/12 11:35, Miklos Vajna wrote: Hi, See http://cgit.freedesktop.org/libreoffice/core/commit/?id=e0328096dc21ce12d15db2045074e7860872570f Could someone review and cherry-pick to -3-5, please? makes sense; ah, that's one of those controls that encode an extra bit into the sign of the

[PUSHED] Re: [PATCH] [REVIEW:3-5,3-4] odbc 64 bits crash

2012-02-14 Thread Michael Stahl
On 14/02/12 15:37, Lionel Elie Mamane wrote: Yet another odbc on 64 bit crash because of wrong buffer size. This is supposed to be a SQLLEN but was hardcoded as 4 bytes. You can see that e.g. in connectivity/source/drivers/odbcbase/OPreparedStatement.cxx, OPreparedStatement::setNull:

Re: .: bin/get-bugzilla-attachments-by-mimetype

2012-02-15 Thread Michael Stahl
On 21/11/11 11:18, Caolán McNamara wrote: On Mon, 2011-11-21 at 02:04 +0100, Miklos Vajna wrote: On Mon, Nov 14, 2011 at 02:37:07AM -0800, Caolán McNamara cao...@kemper.freedesktop.org wrote: add script to download documents from various bugzillas i've pimped it a bit and it can now

Re: linking performance

2012-02-15 Thread Michael Stahl
send it to you separately.) On Tue, Feb 14, 2012 at 01:07:20PM +0100, Michael Stahl wrote: On 14/02/12 11:52, Michael Meeks wrote: On Mon, 2012-02-13 at 16:06 +0100, Michael Stahl wrote: [snip] Lubos was talking of using some more magic / smaller debug option in the past: -gdwarf-4

[PUSHED] Re: [REVIEW-3-5] Fix for fdo#45779

2012-02-15 Thread Michael Stahl
On 15/02/12 11:32, Thorsten Behrens wrote: Hi there, could someone please review cherry-pick http://cgit.freedesktop.org/libreoffice/core/commit/?id=d37abad97d72bae0fd0269de12e94c7a7d3fd7e1 for -3-5? hmm.. dividing by 0 considered harmful indeed

Re: .: 2 commits - configure.in sw/source

2012-02-15 Thread Michael Stahl
On 13/02/12 09:39, Tor Lillqvist wrote: commit b7980663f0866629e7c54a085f31dba3d9c26b26 Author: Tor Lillqvist tlillqv...@suse.com Date: Mon Feb 13 09:42:39 2012 +0200 WaE: type name first seen using 'class' now seen using 'struct' IMHO this is an utterly pointless warning, because

Re: .: 2 commits - configure.in sw/source

2012-02-15 Thread Michael Stahl
On 15/02/12 19:28, Tor Lillqvist wrote: I completely fail to see what actual problem could be caused by this. And how is that relevant? By the same logic, you could write code that just knows that ints are always 32 bits and whatnot. but no applicable standard requires ints to be 32 bits,

Re: Building LibreOffice on Windows

2012-02-16 Thread Michael Stahl
On 16/02/12 16:17, Noel Grandin wrote: Hi If at all possible, rather run Ubuntu (or some other Linux distro) inside a VMWare virtual machine on your Windows desktop. It's much easier, speaking as someone who does just that, after spending too long fighting with building under Windows.

Re: [REVIEW][3-5] Re: Bug 45530 - Accessibility does not work

2012-02-17 Thread Michael Stahl
hi Masataka, it seems you sent this only to me, not to the mailing list, most likely because this mailing list does not change the reply-to header (which means you need to use Reply to all or Reply to list in your mail client); i'll forward it there... On 15/02/12 15:19, Masataka Shinke wrote:

[REVIEW][3-5] misc fixes for -3-5

2012-02-17 Thread Michael Stahl
some misc commits, mostly crashes fixed while loading ~2000 presumed ODT documents (looking at actual patches reveals expecting people to set bug attachment mime types correctly is unrealistic), proposed for libreoffice-3-5: plugin crashes:

[PATCH] Re: R: R: cygwin 1.7.10 - LO-3-5-0 - build fails - my git problem ?

2012-02-20 Thread Michael Stahl
of the description for the reportbuilder extension. please try if the (untested) attachment fixes it. also, you could contribute a translation of the extension description :) regards, michael From 521ca8def4020015dbfc01c06d72f29ab0733e99 Mon Sep 17 00:00:00 2001 From: Michael Stahl mst...@redhat.com Date

Re: comphelper dep of officecfg

2012-02-20 Thread Michael Stahl
On 20/02/12 17:50, Norbert Thiebaud wrote: On Mon, Feb 20, 2012 at 10:20 AM, Stephan Bergmann sberg...@redhat.com wrote: [including LO ML on cc, hope you don't mind; context for new readers: no problem. Does anybody have an idea how to solve this elegantly? One solution might be to undo

[NAK] Re: [REVIEW 3-5] fdo#39006 Layout loop fixed

2012-02-21 Thread Michael Stahl
On 08/02/12 20:40, Cedric Bosdonnat wrote: Hi all, I just fixed a nasty layout loop. Could someone review and cherry-pick this commit to 3-5 branch? http://cgit.freedesktop.org/libreoffice/core/commit/?id=2a22e664811e10ca58ec66ba8fd10b1a6185c178 FYI, I tested the change also with the

Re: Has the time come to get rid of the delivering of public headers?

2012-02-21 Thread Michael Stahl
On 21/02/12 15:41, Tor Lillqvist wrote: Maybe we need a new directory for exported header files. $MODULE/exported Well, isn't that what $MODULE/inc is *supposed* to be? Are there many cases where also private headers (which don't get delivered) are in $MODULE/inc ? I honestly don't know;

Re: Has the time come to get rid of the delivering of public headers?

2012-02-22 Thread Michael Stahl
On 22/02/12 15:09, Lubos Lunak wrote: On Tuesday 21 of February 2012, Michael Stahl wrote: I wonder how bad the alternative of adding -I$S/svx/inc -I$S/vcl/inc etc. etc. is for command-line length ? would need to try that out on Windows, but my guess is that even if it doesn't blow out

[REVIEW 3-5] frame duplication regressions fdo#40599 fdo#46482 plus fix anchor handling in SwXText::convertToTextFrame()

2012-02-23 Thread Michael Stahl
On 20/02/12 10:47, Miklos Vajna wrote: Hi, See http://cgit.freedesktop.org/libreoffice/core/commit/?id=9592f56323de27f9e1d890ee6259a5f4f328cbd3 It's an issue in the Writer UNO API, so it affects at least docx and RTF import, an RTF reproducer is attached. If some importer already worked

Re: MinGW-Port: Problems with UnoUrlResolver

2012-02-23 Thread Michael Stahl
On 23/02/12 11:07, Helmar Spangenberg wrote: What came to my mind: Since I moved the LibreOffice directories, could it be possible that I have to adjust one or more ini-files? Furthermore, which environment variables are used setting up the local context? Until now I did some experiments

Re: const*const - what is the purpose of this?

2012-02-23 Thread Michael Stahl
On 23/02/12 13:15, Stephan Bergmann wrote: On 02/23/2012 11:23 AM, Jesús Corrius wrote: On Thu, Feb 23, 2012 at 9:04 AM, Noel Grandinn...@peralex.com wrote: I'm seeing declarations like this scattered around the SW module: e.g. in sw/inc/swtable.hxx at line 301 static SwTable * FindTable(

Re: .: 14 commits - binaryurp/source comphelper/inc comphelper/Library_comphelp.mk comphelper/prj comphelper/source configmgr/source cui/Library_cui.mk cui/prj cui/source dbaccess/source desktop/Libra

2012-02-23 Thread Michael Stahl
the attached patch? From cf22e569d485d050a535b3e598d7e255aed98597 Mon Sep 17 00:00:00 2001 From: Michael Stahl mst...@redhat.com Date: Thu, 23 Feb 2012 14:53:56 +0100 Subject: [PATCH] salhelper::Thread::launch: check create() failure The assumption in the comment is clearly wrong, as osl::Thread

Re: .: bin/get-bugzilla-attachments-by-mimetype

2012-02-23 Thread Michael Stahl
On 15/02/12 11:15, Caolán McNamara wrote: On Wed, 2012-02-15 at 11:06 +0100, Michael Stahl wrote: that's the only thing that's still missing... should i file an easy hack? :) Indeed, that probably makes sense. https://bugs.freedesktop.org/show_bug.cgi?id=46538

ODF bugzilla keywords (was: Re: minutes of ESC call ...)

2012-02-24 Thread Michael Stahl
On 16/02/12 18:12, Michael Meeks wrote: * ODF issues (Michael Stahl) + use the whiteboard for issues related to ODF documented here: + http://wiki.documentfoundation.org/BugTriage because it is apparently too difficult to add keywords, added odf and odf_validation

Re: [REVIEW:3-5-1] PostgreSQL regression wrt 3.5.0: privileges via groups

2012-02-27 Thread Michael Stahl
On 27/02/12 14:16, Michael Meeks wrote: On Mon, 2012-02-27 at 13:45 +0100, Lionel Elie Mamane wrote: Forgot to regenerate the patch after last-minute fix before sending email... Missing closing parenthesis in previous patch. New patch attached. :-) so, since you're the expert here,

Re: [PATCH] [3.5.1 and MASTER] Fix dialog controls size and position in the file preperties dialog

2012-02-28 Thread Michael Stahl
On 27/02/12 23:51, Riccardo Magliocchetti wrote: Hello, Il 27/02/2012 23:22, willubuntu ha scritto: Hello guys, I took also the opportunity to fix some indentation to get a consistent look in code. Usually is better to separate the behaviour changes from the whitespace cleanup

Re: Disabling Temporary Files?

2012-02-28 Thread Michael Stahl
On 28/02/12 19:46, Marc-André Laverdière wrote: Hello, I need to ensure that data confidentiality. i don't believe that the completely undisciplined use of temp files in the historic OpenOffice.org code base is conductive to this goal; it would probably be a good idea to investigate encrypted

Re: python gdb plugin traceback: No type named sal_uInt16.

2012-02-29 Thread Michael Stahl
On 29/02/12 12:48, Michael Meeks wrote: Hi Riccardo, On Wed, 2012-02-29 at 09:23 +0100, Riccardo Magliocchetti wrote: i have this traceback every time i open a core. It does not harm but it is a bit annoying. Does anyone have a clue on how to fix that? I guess the code is in

[PUSHED] Re: [REVIEW 3-5][PATCH] Fix leap year calculation

2012-02-29 Thread Michael Stahl
On 29/02/12 04:10, Kohei Yoshida wrote: Hi there, The attached patch fixes a bug in our current leap year calculation code. It is based on the algorithm posted on wikipedia[1], and seems to correctly identify year 2000 as a leap year. Without this, Calc would convert 2000-2-29 into

[REVIEW][3-5][3-5-1] fdo#46340 add more insanity to SdrGrafObj::getInputStream so it doesn't crash as much

2012-02-29 Thread Michael Stahl
just restores the aspects of the previous mis-design that accidentally prevent the crash. On 29/02/12 22:37, Michael Stahl wrote: svx/source/svdraw/svdograf.cxx |8 1 file changed, 8 insertions(+) New commits: commit 0c6d89941118368ccbb596362a545db5d3a07dbe Author: Michael Stahl

[REVIEW][3-5][3-4] more problems in SwRootFrm dtor

2012-02-29 Thread Michael Stahl
due to CWS swlayoutrefactoring there is another problem in SwRootFrm destruction, which has been found with valgrind: the children of the root frame are only destroyed by the base class destructors, so since every layout frame has a pointer to the SwRootFrm they may access its members after the

[REVIEW][3-5] fix STL assertion in vcl graphite code

2012-02-29 Thread Michael Stahl
this patch fixes a STL assertion in GraphiteLayout::expandOrCondense; since i don't know how the multitude of arrays in there are supposed to be used, i thought it's probably a good idea to check the size of the array that will be indexed in the next line, as opposed to one that isn't mentioned

[REVIEW][3-5] i#115684 SfxItemPool performance regression

2012-02-29 Thread Michael Stahl
the following fixes a performance regression in OOo 3.4; i have actually fixed this before in OOo times but the fix somehow got lost in the CWS process overhead... ah, the issue for it was this: https://issues.apache.org/ooo/show_bug.cgi?id=115684

[PUSHED] Re: [REVIEW -3-5] RTF import of drwaing objects regressions

2012-03-01 Thread Michael Stahl
On 01/03/12 12:06, Miklos Vajna wrote: On Wed, Feb 29, 2012 at 05:05:01PM +0100, Miklos Vajna vmik...@suse.cz wrote: http://cgit.freedesktop.org/libreoffice/core/commit/?id=bbef8b4 and As Michael Stahl pointed out on IRC, a null pointer check was missing in popState(), fixed with 456a59b

Re: Using a real parser generator to parse numbers (and dates)

2012-03-01 Thread Michael Stahl
On 01/03/12 12:14, Stephan Bergmann wrote: On 02/29/2012 06:41 PM, Lionel Elie Mamane wrote: On Wed, Feb 29, 2012 at 02:57:09PM +0100, Stephan Bergmann wrote: Note that the stable sal interface historically stays clear of boost, because of differences in the various boost versions available

Re: [REVIEW 3-5][REVIEW 3-5-1 ?] fix crash using edit instance from xforms Data navigator dialog

2012-03-01 Thread Michael Stahl
On 01/03/12 13:20, Noel Power wrote: http://cgit.freedesktop.org/libreoffice/core/commit/?id=7b860d4970604f08ebd2e818bfd63891dd940804 should fix the problem, it seems that commit f7f47366ea78a71853fcaca2fa402bef667d9cce introduced a 'delete(pPage);' ( it seems from the comment to silence

Re: [REVIEW] [REVIEWED 3-5] fix crash in importSheets

2012-03-01 Thread Michael Stahl
On 01/03/12 19:10, Kohei Yoshida wrote: On Thu, 2012-03-01 at 12:15 +0100, Markus Mohrhard wrote: Hey, could you please cherry-pick the attached patch to 3-5 and if still possible 3-5-1. Pushed to the 3-5 branch with my sign-off. I too recommend we push this to the 3-5-1 branch since

Re: [REVIEW] [REVIEWED 3-5] fix crash when deleting db range in formula

2012-03-01 Thread Michael Stahl
On 01/03/12 19:12, Kohei Yoshida wrote: On Thu, 2012-03-01 at 13:07 +0100, Markus Mohrhard wrote: Hey, [1] fixes a crash if you try to delete a database range in a formula. IMHO this patch is extremely safe and it would be great if we could push it to 3-5 and maybe 3-5-1. Regards, Markus

Re: minutes of ESC call ...

2012-03-01 Thread Michael Stahl
On 01/03/12 22:25, Michael Meeks wrote: On Thu, 2012-03-01 at 20:47 +0100, Stephan Bergmann wrote: AA: + l/strace-alike for UNO (Stephan) On a more constructive note ;) the above already exists, in the form of http://wiki.services.openoffice.org/wiki/Uno/Spec/Log_Environment.

Re: minutes of ESC call ...

2012-03-02 Thread Michael Stahl
On 02/03/12 10:32, Michael Meeks wrote: On Fri, 2012-03-02 at 09:29 +0100, Stephan Bergmann wrote: Micheal, I think I still don't understand what you are up to here. What does logging have to do with XUnoTunnel ? Correct me if I'm wrong, but as soon as we start doing bridging -

[REVIEW][3-*] fdo#39694, fdo#42073 Writer field expansion regression bugs

2012-03-05 Thread Michael Stahl
hi all, some time ago i noticed that some text fields in writer can only be expanded properly in the text formatting, and so tried to prevent expansion of fields in lots of other places (in CWS sw34bf01); it seems that that went a bit past the mark, and some API methods now fail if they are

Re: LibreOffice / openIndiana ...

2012-03-05 Thread Michael Stahl
On 05/03/12 12:08, Jonathan Adams wrote: anyone got a quick fix for all the version-script code in gcc (using SUN ld)? -Wl,--version-script ../unxsoli/misc/store_store.map Making:libstore.so.3 ld: fatal: unrecognized option '--' ld: fatal: use the -z help option for usage

[PUSHED] Re: [REVIEW -3-5] RTF import of non-box paragraph borders

2012-03-05 Thread Michael Stahl
On 05/03/12 10:34, Miklos Vajna wrote: Hi, See http://cgit.freedesktop.org/libreoffice/core/commit/?id=343b52e Test document attached, regression from 3.4. pushed to libreoffice-3-5 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

<    3   4   5   6   7   8   9   10   11   12   >