[Libreoffice-commits] core.git: vcl/win

vcl/win/source/window/salframe.cxx | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) New commits: commit f4dc53cb33c7f6b10bb6709dea5f8195bf95d4b5 Author: Noel Grandin Date: Thu Sep 18 10:36:13 2014 +0200 Use vcl::Font Change-Id

[Libreoffice-commits] core.git: drawinglayer/source

drawinglayer/source/primitive2d/textlayoutdevice.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit d7510f79edd0b97839ebffc4c4284650452b4d00 Author: Noel Grandin Date: Thu Sep 18 11:59:42 2014 +0200 use vcl::Font Change-Id

[Libreoffice-commits] core.git: vcl/ios

vcl/ios/iosinst.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit a1740a682a6c46c57dc6a356299f6c9a92eb4af6 Author: Noel Grandin Date: Thu Sep 18 14:44:39 2014 +0200 use vcl::Font Change-Id: I22fd5c1340ca0c646725d9fce77304c10d9eb5d5 diff --git a

Re: HarfBuzz performance problem

On 2014-04-16 05:02, Kohei Yoshida wrote: This bug https://bugs.freedesktop.org/show_bug.cgi?id=75665 reveals that our HarfBuzz based text rendering is quite expensive. I tried to do what I could on the Calc side to lessen the impact of this problem. I've made some improvement, but I've hit m

[Libreoffice-commits] core.git: include/svtools svtools/source

include/svtools/unoevent.hxx|6 +++--- svtools/source/uno/unoevent.cxx |4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) New commits: commit 532acfde021fb78de64faefeb561632b333931a2 Author: Noel Grandin Date: Thu Apr 24 11:37:21 2014 +0200 make

[Libreoffice-commits] core.git: filter/source

filter/source/graphicfilter/icgm/cgm.cxx | 31 --- filter/source/graphicfilter/icgm/cgm.hxx |6 +- 2 files changed, 1 insertion(+), 36 deletions(-) New commits: commit a3abc602578270582ab7d8df9ef34ef9503234de Author: Noel Grandin Date: Fri Apr 25 16:00:39

[Libreoffice-commits] core.git: basctl/source include/svtools sc/source sd/source svtools/source

: commit 883481fd200510f5ae62e7ab7cd18f7d925c2c47 Author: Noel Grandin Date: Fri Apr 25 12:49:17 2014 +0200 Improve TabBar return types DeactivatePage() goes from returning long to returning bool. StartRenaming goes from returning long to returning bool. AllowRenaming goes from

[Libreoffice-commits] core.git: include/svtools svtools/source

include/svtools/tabbar.hxx| 21 - svtools/source/control/tabbar.cxx | 18 +++--- 2 files changed, 3 insertions(+), 36 deletions(-) New commits: commit 2554d0ab4e293c2e68477c1b390367c15353234e Author: Noel Grandin Date: Fri Apr 25 15:39:59 2014 +0200

[Libreoffice-commits] core.git: sdext/source

sdext/source/minimizer/optimizerdialogcontrols.cxx | 50 ++--- 1 file changed, 25 insertions(+), 25 deletions(-) New commits: commit 8306e6cfb4504c6a08f877df88a5ea5ca2ad8b00 Author: Noel Grandin Date: Wed Apr 30 09:01:07 2014 +0200 sdext, fix sal_Bool->bool convers

[Libreoffice-commits] core.git: sw/source

sw/source/core/layout/calcmove.cxx |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit 82e8c6a6990571a558e13ebff85edb3b5d511866 Author: Noel Grandin Date: Wed Apr 30 11:07:50 2014 +0200 -Werror=parentheses introduced in commit

[Libreoffice-commits] core.git: basegfx/source connectivity/source dbaccess/source editeng/source fpicker/source mysqlc/source qadevOOo/testdocs sc/source svx/source sw/source vcl/source vcl/unx write

(+), 34 deletions(-) New commits: commit 794f09f195a449e387ebfbd53eb1b693803c95e7 Author: Noel Grandin Date: Tue May 6 07:44:11 2014 +0200 simplify ternary conditions "xxx ? true : yyy" Look for code like: xxx ? true : yyy; Which can be simplified to:

Re: Questions about getCppuType

On 2014-05-07 23:48, julien2412 wrote: In fact, my primary goal was to clean this use of getCppuType because it was reported by cppcheck (when they were used in if/else if blocks) Then I wanted to remove all of them. The problem is there are 33 Opengrok pages of these and I don't know enough abou

[Libreoffice-commits] core.git: forms/source include/vcl reportdesign/source vcl/source

+ reportdesign/source/ui/dlg/GroupsSorting.cxx | 16 vcl/source/app/dbggui.cxx|2 +- 7 files changed, 23 insertions(+), 15 deletions(-) New commits: commit ff1a7a59434f5f793d4044aad615bcf78148e963 Author: Noel Grandin Date: Mon May 5 08:00:36 2014 +0200 RFC

[Libreoffice-commits] core.git: sal/osl

sal/osl/unx/security.cxx |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) New commits: commit bdfcc8c92947b7c1629c3b7f3a0326ed01c4cf17 Author: Noel Grandin Date: Thu May 8 12:08:55 2014 +0200 fix MACOS build after commit 78b9537 "various: sal_Bool-

[Libreoffice] build error unders Windows 7

Hi I'm getting the following build error under Windows7. I'm running the bash shell with Administrator privileges, so it has enough privileges. Is there something else I need to do, or is there a way to bypass this problem? Thanks, No

gmake instructions for running an individual unit test appear to be out of date

HI The instructions for running an individual unit test appear to be out of date e.g. one of my tests says: to rerun just this failed test without all others, run: make /home/noel/libo/workdir/unxlngx6/JunitTest/sfx2_complex/done When it should actually say something like (I gues

Re: gmake instructions for running an individual unit test appear to be out of date

On 2013-03-12 17:09, Matúš Kukan wrote: Indeed, thanks. Fixed in "gbuild: correct instructions for running an individual junit test" Thanks! Disclaimer: http://www.peralex.com/disclaimer.html

Re: PATCH

You forgot to remove the method from the class definition in the header file. Was this even compile tested? On Tue, Mar 12, 2013 at 7:44 PM, Vishal Subbiah wrote: > > > ___ > LibreOffice mailing list > LibreOffice@lists.freedesktop.org > http://lists.f

Re: PATCH

This patch is garbage. It will not even compile. And I'm not talking about the fact that he attached the wrong thing, I mean that I looked inside it and Vishal does not appear to understand C++ at all. ___ LibreOffice mailing list LibreOffice@lists.free

Re: About coverity 705746 (pormulti.cxx from sw module)

On 2013-03-14 21:20, julien2412 wrote: Hello, Scan coverity detected this: 27. overwrite_var: Overwriting "pMarg" in "pMarg = new SwMarginPortion(0)" leaks the storage that "pMarg" points to (http://opengrok.libreoffice.org/xref/core/sw/source/core/text/pormulti.cxx#738) 738 if( nLeft

Re: About coverity 705746 (pormulti.cxx from sw module)

On 2013-03-15 10:30, julien2412 wrote: Noel Grandin wrote I would guess that someone meant to move line 742 inside the first "if" statement, but only did half the job. Hello Noël, Perhaps I'm too sleepy this morning but I don't see the interest to duplicate the "n

Re: About coverity 705746 (pormulti.cxx from sw module)

On 2013-03-15 12:03, julien2412 wrote: Oups, I was wrong , if they're not exclusive, "new" line is required for each block Sorry Noël and Riccardo for the noise. Can you push a patch about this and update coverity? If not, I'll do it but only during week-end because I won't have much time. Thank

Re: #ifdef vs #if for feature checks

On Fri, Mar 15, 2013 at 5:58 PM, Lubos Lunak wrote: > > The problem with this change is that there still may be some cases where > #ifdef is used, either because some system #defines work that way (so those > would be valid but different), or people would still use #ifdef out of > habbit > I li

Re: rtl::OUString::compareToAscii is dangerous

On Tue, Mar 19, 2013 at 6:54 PM, Stephan Bergmann wrote: > > * compareToAscii(char cosnt * asciiStr, sal_Int32 maxLength) does a > shortened comparison of only up to maxLength characters of *this and the > given asciiStr. > Maybe this one should be renamed to something like "compareLeftToAscii" ?

[Libreoffice-commits] core.git: offapi/com

offapi/com/sun/star/drawing/XGraphicExportFilter.idl |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 542d45df30a78e937f17156aac56d7cc649bbc82 Author: Noel Grandin Date: Wed Mar 20 07:54:30 2013 +0200 fix spelling mistake in @since tag Change-Id

Re: #ifdef vs #if for feature checks

On 2013-03-20 12:16, Thomas Arnhold wrote: Yes, but our internal RSC doesn't support #pragma once ;) Maybe we could make that a "Medium Hack" project? Disclaimer: http://www.peralex.com/disclaimer.html ___ LibreOffice mailing list LibreOffice@lists

Re: LibreOffice for Android (how the overcome the problem with the 50 MB limit)

On 2013-03-22 14:01, Tobias Kuban wrote: Looking forward to use it on Android so long. I recently read an interview where the "50 MB limit" would be a huge challenge. According to http://android-developers.blogspot.de/2012/03/android-apps-break-50mb-barrier.html this limit doesn't exist anymor

Re: ScChangeTrackingExportHelper, SvNumberFormatter

On 2012-11-30 11:51, Michael Meeks wrote: On Thu, 2012-11-29 at 22:49 +0100, Eike Rathke wrote: A pointer wouldn't change much, defaulting to NULL wouldn't make sense anyway as then the caller wouldn't know what number type was detected and what format index to apply. Sigh - I guess so

Re: [API] Some more cleanup ideas

Sunday, 2 December 2012, Michael Stahl wrote: > > what i'd really like to have though is a C++ keyword with semantics of > "just use the same > exception specification as the base class method" ... plus "error if > there is not actually a base class method with that parameter > signature", while we

Re: [API] Some more cleanup ideas

d the keyword to existing source code. http://clang-developers.42468.n3.nabble.com/add-override-specifier-example-tool-td4025070.html So perhaps we should define a new macro "SAL_OVERRIDE", which expands to the correct keyword on new enough versions of those compilers? Regard

Re: About numbertext

ien Hi Julien This is something that needs to be fixed upstream. László Németh, are you the current maintainer? Perhaps you can help Julien submit his changes to the numbertext extension? Thanks, Noel Grandin Disclaimer: http://www.p

Re: [PATCH] Introduce SAL_DELETE

Maybe give it a more explicit name? Without looking, it's not clear at all what the macro does. Perhaps SAL_DELETE_MEMBER or SAL_CPP11_DELETE ?? On 2012-12-11 17:00, Stephan Bergmann (via Code Review) wrote: Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1299 To

RFC: adding some IDL syntax sugar

much much easier on the eyes. Regards, Noel Grandin Disclaimer: http://www.peralex.com/disclaimer.html ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: RFC: adding some IDL syntax sugar

On Wednesday, 12 December 2012, Thorsten Behrens wrote: > > I'd like to add some IDL syntax sugar, so that instead of doing this: > > > > module com { module sun { module star { module formula { > > }; }; }; }; > > > > we can do this: > > > > module com::sun::star::formula { >

Re: is 'make check' supposed to work on ~master ?

In theory it should work, in practice it's been flakely in the last few weeks. I think it's just a case of nobody has had the time to track down the problems, which mostly seem to be in the Java-based unit tests, which are, not coincidentally, the hardest to debug :-( On 2012-12-12 19:36, Jo

Re: Anti-aliasing via GPU

a Direct2D backend for Cairo, but I can't seem to find out if it was ever integrated back into the main Cairo library (cairographics.org is currently unreachable for me). -- Noel Grandin. Disclaimer: http://www.peralex.com/disclaimer.html

Re: is 'make check' supposed to work on ~master ?

On 2012-12-13 11:35, Stephan Bergmann wrote: In general, the online update mechanism spawns threads that it doesn't properly join again before exit, which is a notorious problem with tests (that often run quickly enough to terminate soffice.bin while the online update check is still in progr

what's with Rectangle::GetHeight() and GetWidth() in gen.hxx

GetHeight() const; } inline long Rectangle::GetWidth() const { . } Firstly, there seems to be a missing inline statement in the class header section. Secondly, given that there __is__ an inline modifier, why would the windows compiler be trying to link this function externally?

Re: is 'make check' supposed to work on ~master ?

On 2012-12-13 11:53, Stephan Bergmann wrote: On 12/13/2012 10:37 AM, Noel Grandin wrote: On 2012-12-13 11:35, Stephan Bergmann wrote: In general, the online update mechanism spawns threads that it doesn't properly join again before exit, which is a notorious problem with tests (that ofte

Re: what's with Rectangle::GetHeight() and GetWidth() in gen.hxx

On 2012-12-13 14:31, Lubos Lunak wrote: it. I've pushed a fix for this. Thanks. Disclaimer: http://www.peralex.com/disclaimer.html ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoff

Re: is 'make check' supposed to work on ~master ?

On 2012-12-13 19:28, John Smith wrote: Conditional jump or move depends on uninitialised value(s) That looks like you have valgrind enabled, and I don't think all of our unit tests have been made valgrind-safe yet. Disclaimer: http://www.peralex.com/disclaimer.html _

Re: Anti-aliasing via GPU

On 2012-12-14 11:52, Michael Meeks wrote: Why not increase it's visibility ? last I looked it was beautiful and helpful :-) I I think what he is saying is that he's happy if you take and check it in, but he doesn't want to take any responsibility for maintaining such a thing. AFAIR there ar

Re: Anti-aliasing via GPU

On 2012-12-14 13:32, Michael Meeks wrote: OK; interesting - if you don't think it's suitable that's fine - I had assumed that with the reasonably demanding SVG / HTML5 canvas requirements of the browser that it might be a reasonable fit (at least to investigate). It might be. I'm just

Re: typographic freaks: footnotes not vertically aligned to last line of body text in following page (as in good typographic style)

This is a developers mailing list, for discussing actually implementing fixes and changes. If you want to help actual make the fixes, then you're welcome here, and we will point you in the right direction. Otherwise please take this to us...@global.libreoffice.org. On 2012-12-19 13:43, sir

opengrok feature request: correcting links to .hxx files

link for the following include: #include "AsyncronousLink.hxx" which incorrectly points to the file AsyncronousLink.h Thanks, Noel Grandin ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.o

Re: [Libreoffice-commits] replaceAll

On 2013-01-31 02:58, Michael Meeks wrote: We could deprecate it. Do we have a nice macro wrapped around some magic gcc: "really warn if return value unused" attribute - I assume there is one of those - that might help make it more sane ? Maybe we need a SAL_ERROR_IF_UNUSED macro

Re: [Libreoffice-commits] replaceAll

On 2013-01-31 10:32, Stephan Bergmann wrote: You missed my point, which was not the gotcha of ignoring the return value (which is already addressed with SAL_WARN_UNUSED_RESULT anyway), but the gotcha that a sequence of replaceAll calls to replace multiple placeholders with corresponding repl

[Libreoffice-commits] core.git: fpicker/source

fpicker/source/aqua/FPentry.mm|3 +-- fpicker/source/aqua/SalAquaFilePicker.hxx |5 + fpicker/source/aqua/SalAquaFilePicker.mm |6 +++--- 3 files changed, 5 insertions(+), 9 deletions(-) New commits: commit a1609205604f74440c046166b09ee96f088e437b Author: Noel

[Libreoffice-commits] core.git: 2 commits - fpicker/source

(+), 20 deletions(-) New commits: commit a315af8ef47c2a9c774f3ffd7820091368a9aa5b Author: Noel Grandin Date: Tue Feb 12 13:33:02 2013 +0200 use a typedef to reduce code duplication Change-Id: I915b88ad0683cecaf2018a529fb904753a4f27c0 diff --git a/fpicker/source/aqua

[Libreoffice-commits] core.git: fpicker/source

fpicker/source/aqua/FPentry.mm |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) New commits: commit a5d63b94137d4ce93fdda28734606b83fb86e3af Author: Noel Grandin Date: Tue Feb 12 13:49:07 2013 +0200 fix unused parameter warning Change-Id

[Libreoffice-commits] core.git: fpicker/source

fpicker/source/aqua/SalAquaFilePicker.mm | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) New commits: commit ee8dc096aa5e3700985b5ad619edc6c565b5787b Author: Noel Grandin Date: Tue Feb 12 14:01:20 2013 +0200 fix ambiguous base-class problem Change-Id

Re: Help with fdo#60471

I tried using the catch/throw stuff in GDB for debugging, gave up, and now simply set a breakpoint in the constructor of the Exception object :-) Works for me. On 2013-02-13 03:11, Marcos Souza wrote: I tried to get the error message from uno::Exception using a SAL_WARN, but this is the mess

generated UNO code for service constructors

? Or perhaps we can change the error message in the last block to: throw DeploymentException( "component context supplied a service FilePicker, but the service does not implement interface XFilePicker3" ), the_context); Which would be less confusing to my rather

[Libreoffice-commits] core.git: vcl/unx

vcl/unx/gtk/fpicker/SalGtkFilePicker.cxx | 11 +-- vcl/unx/gtk/fpicker/SalGtkFilePicker.hxx | 21 - 2 files changed, 9 insertions(+), 23 deletions(-) New commits: commit 3164966103b7d5c19197b7e94040d585e5af04ac Author: Noel Grandin Date: Fri Feb 15 07:58:04

Re: generated UNO code for service constructors

On 2013-02-15 11:24, Stephan Bergmann wrote: On 02/14/2013 02:54 PM, Noel Grandin wrote: I just ran into a weird bug where I could see that the service was being correctly instantiated, but then as a traced it back up the call tree, the reference was suddenly empty! (https

Re: I know I shouldn't but I'll do it anyway....

On Fri, Feb 15, 2013 at 7:57 PM, Olivier Hallot < olivier.hal...@documentfoundation.org> wrote: > > suggest to replace the start center with a grid of recent files > thumbnails... > > Whoever opened an Office 2013 application with no document loaded knows > what I am talking about. And we can do b

using backtrace() in exception throwing?

data, and then modifying the exception printing code to call backtrace_symbols() when writing out the exception? For me personally, this would really speed up tracking down the source of bugs. Regards, Noel Grandin ___ LibreOffice mailing list L

broken build on latest master?

Hi Looks like the build got broken inside the postprocess module by one of this weekend's commits? Regards, Noel Grandin = (9/9) Building module postprocess = Entering /home/noel/libo/postprocess/prj gbuild module /home/noel/libo/postprocess: make -f Makefile

Re: using backtrace() in exception throwing?

On 2013-02-18 15:39, Lubos Lunak wrote: This could be very useful ('catch throw' is so cumbersome in gdb), but I think the first thing to check is if it would actually work. Last time I checked, "recent" features like -fvisibility make backtrace() very often generate call traces that are next t

Re: broken build on latest master?

On 2013-02-18 15:36, Matúš Kukan wrote: On 18 February 2013 14:16, Noel Grandin wrote: packimages: ERROR: no such directory: '/home/noel/libo/solver/unxlngx6/res/img' This is because all relevant dmake modules are now converted and no one creates OUTDIR/res/img directory. Thanks

Re: using backtrace() in exception throwing?

On Mon, Feb 18, 2013 at 7:09 PM, Tom Tromey wrote: > > "Lubos" == Lubos Lunak writes: > > Lubos> This could be very useful ('catch throw' is so cumbersome in > Lubos> gdb), > > Is there something we could do to improve it? > > Would be nice if gdb could actually do "catch throw XXXException

make dev-install not issuing any helpful instructions anymore

Hi Once upon a time, "make dev-install" would helpfully indicate how and where to run the resulting binary. Any ideas what happened to that? Thanks, Noel Grandin ___ LibreOffice mailing list LibreOffice@lists.freedeskto

Re: building headless on master

On 2013-02-19 09:45, Jonathan Aquilina wrote: Hey guys I have a server im using as a build machine for the master branch, it always seems to fail for me in tail_build is anyone else experiencing this? what do the logs say? Disclaimer: http://www.peralex.com/disclaimer.html

Re: using backtrace() in exception throwing?

On 2013-02-18 19:30, Tom Tromey wrote: "Noel" == Noel Grandin writes: Noel> Would be nice if gdb could actually do "catch throw XXXException" like Noel> the documentation says - perhaps the documentation was modified Noel> prematurely? Yeah, I think it was.

[Libreoffice-commits] core.git: 2 commits - fpicker/source writerfilter/source

503ee06fb843ac4ace017fde1b8a10c3c0501bc6 Author: Noel Grandin Date: Tue Feb 19 10:34:46 2013 +0200 fix up some of my fdo#46808 changes ... It turns out removing XInitialisation was a bad idea. Change-Id: I6a08f3f769ffc9017e94e8463a97cb18d39aa677 diff --git a/fpicker/source/aqua/SalAquaFilePicker.hxx b

Re: using backtrace() in exception throwing?

On 2013-02-19 10:23, Miklos Vajna wrote: On Tue, Feb 19, 2013 at 10:13:15AM +0200, Noel Grandin wrote: While we're on the subject of GDB improvements, I personally would find a "step return" command very useful. i.e. continue until we leave the current stack frame very use

Re: LO not launched successfully after git pull

On 2013-02-19 10:33, Prashant Pandey wrote: Hi , I did 'git pull' then 'make', followed by 'make dev-install -o build' and finally './install/program/soffice'. LibreOffice main screen comes up, but as soon as i select any one feature : Spreadsheet, Text Document, etc. The LO screen crashes an

[Libreoffice-commits] core.git: fpicker/source

fpicker/source/aqua/SalAquaFilePicker.hxx |1 + fpicker/source/win32/filepicker/FilePicker.hxx |1 + 2 files changed, 2 insertions(+) New commits: commit a413832fe2df559df589760e687e8352ffc1bddb Author: Noel Grandin Date: Tue Feb 19 10:44:12 2013 +0200 and let's try act

[Libreoffice-commits] core.git: fpicker/source

fpicker/source/aqua/SalAquaFilePicker.hxx |1 - 1 file changed, 1 deletion(-) New commits: commit d7f9b7693968f2e2ff7a8d15830a5633d5999ee0 Author: Noel Grandin Date: Tue Feb 19 11:02:08 2013 +0200 fix mid-air collision of commits Change-Id

[Libreoffice-commits] core.git: 4 commits - dbaccess/source extensions/source offapi/com offapi/UnoApi_offapi.mk

905501b635db939874b3c8787b7c0677afcbd9ab Author: Noel Grandin Date: Mon Mar 11 18:13:51 2013 +0200 fdo#46808, convert sdb::CommandDefinition to new-style the service already existed, it just needed an IDL file Change-Id: I99c08b4e3a3ee0131b6fd904803efe7273cd1694 diff --git a/dbaccess/source

Re: unusedcode some step further

Another way is to use a clang plugin to generate a more accurate list of definitions and call sites. That's what I would do, because clang would handle all of the macro and language parsing. On Monday, 1 April 2013, Thomas Arnhold wrote: > Hi, > > there are several unused methods in the source wh

Re: Help on the bug#59071

There is already quite a bit of explanation in bugzilla. What parts exactly do you require help with Janit? On Mon, Apr 1, 2013 at 4:44 PM, Janit Anjaria wrote: > Hey! > I have been working on quite a few features/bugs and now i have taken this > up : > > https://bugs.freedesktop.org/show_bug.cgi

unit test failure in forms module, something do with com.sun.star.form.control.FixedText

trol") Grepping through the source code, "com.sun.star.form.control.FixedText" is only found in forms/source/inc/services.hxxx but the global constants declared there are not used anywhere else (confirmed by removing them and rebuilding). Nothing seems to actually implement this service. Any ideas? Reg

Re: unit test failure in forms module, something do with com.sun.star.form.control.FixedText

On 2013-04-03 14:33, Thomas Arnhold wrote: Hi Noel, maybe this grepping for "control\.FixedText" helps you: stardiv.vcl.control.FixedText com.sun.star.form.control.FixedText So there is toolkit/source/helper/servicenames.cxx which uses szServiceName_UnoControlFixedText[] = "stardiv.vcl.contro

Re: yet another unit test framework? -- was fdo#55814: unit test is missing

I'm extremely grateful to anyone willing to work on improving our unit test infrastructure. However... On 2013-04-04 10:24, David Ostrovsky wrote: I am not going to provide the huge advantages of dynamic type languages in general here, but while python is very impressive it *is* truly read-w

Re: yet another unit test framework? -- was fdo#55814: unit test is missing

On 2013-04-04 10:53, Bjoern Michaelsen wrote: Well, IMHO the main problem with the unoapi tests wrt this is that they 'centralized' a lot of the expectations on the UNO-Api -- which made them hard to quickly rewrite in C++. If this leads to more reliable tests of any kind, which will turn into

Re: unit test failure in forms module, something do with com.sun.star.form.control.FixedText

On 2013-04-04 12:04, Noel Power wrote: yup, I've looked and you're right, nothing implementing that, question is where is the "com.sun.star.form.control.FixedText" comming from, is it something injected from the test code or test document or... ? It seems to be coming from the forms unit test

Re: unit test failure in forms module, something do with com.sun.star.form.control.FixedText

On 2013-04-04 12:44, Noel Power wrote: me neither, its from complextests or subsequenttests or ? How do you run the tests ? make JunitTest_forms_unoapi This is just too weird. After hitting this problem for 4 days in a row, it suddenly starts working on this machine. And no I did not do a

Re: unit test requirements ...

On 2013-04-04 13:13, Bjoern Michaelsen wrote: Debugability is mostly a red herring if you have good locality (just like a good bibisect makes fixing regressions a lot easier). For you maybe. Not for someone like me, trying to make cleanup changes and running the unit tests to confirm that I h

Re: unit test failure in forms module, something do with com.sun.star.form.control.FixedText

On 2013-04-04 13:54, Bjoern Michaelsen wrote: Just for completeness: The Java code for that would be in qadevOOo. And yes, its a PITA to debug. Best, Bjoern Excellent! Thank you! Well, that means that the problem originates in the following file qadevOOo/objdsc/forms/com.sun.star.comp.forms.O

Re: [PUSHED] fdo#46808, convert sdb::QueryDesigner to new style

"new style". It is published because the (already existing) QueryDefinition service is published, and the rules of IDL say that a published service can only use published interfaces. HTH, Noel Grandin. ___ LibreOffice mailing list LibreOff

Re: new gerrit-builds & unit tests ...

On 2013-04-05 17:36, Norbert Thiebaud wrote: 24 hours window.. the limiting factor being windows that take ~2 hours for a successful build, the 2 others take about 15 minutes. What is the limiting factor with Windows? CPU or IO? If it's IO, maybe the machines need a small SSD for the build dire

Re: claims of python unit test un-debugability considered somewhat exaggerated

On 2013-04-05 23:44, Michael Stahl wrote: so i spent the day trying to understand soffice bootstrap and moving the proposed Python unit tests in-process to see if that makes this more acceptable for people. I consider this acceptable. So you can consider my objection to python unit tests withd

[Libreoffice-commits] core.git: comphelper/source

comphelper/source/property/opropertybag.hxx | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) New commits: commit 5c0f6c6f6d3a708a82e80820f53870cb8a490e37 Author: Noel Grandin Date: Mon Apr 8 14:31:50 2013 +0200 fix windows build diff --git a/comphelper/source

[Libreoffice-commits] core.git: embedserv/source

embedserv/source/embed/docholder.cxx |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) New commits: commit 84373a71d6eeac0d29500ed717ffd906bac4 Author: Noel Grandin Date: Mon Apr 8 14:56:27 2013 +0200 fix windows build diff --git a/embedserv/source/embed/docholder.cxx

[Libreoffice-commits] core.git: embedserv/source

embedserv/source/embed/docholder.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit d95fb607c2ac9b04bdfa9d7a79248229dba6f769 Author: Noel Grandin Date: Mon Apr 8 15:24:17 2013 +0200 fix windows build diff --git a/embedserv/source/embed/docholder.cxx b

[Libreoffice-commits] core.git: include/vcl padmin/source sw/inc sw/source vcl/generic vcl/inc vcl/source

changed, 17 insertions(+), 265 deletions(-) New commits: commit 0fd4d12c6233da2ac1936cd89838b006ffec5192 Author: Noel Grandin Date: Wed May 8 08:27:27 2013 +0200 Remove code associated with psprint::CompatMetricOverride service We don't actually have any implementations of

anybody know about the com::sun::star::awt::ExtToolkit service

being used, it casts the service to XToolkit. Regards, Noel Grandin Disclaimer: http://www.peralex.com/disclaimer.html ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: qadevOOo/runner qadevOOo/tests

deletions(-) New commits: commit d702dd4396161f8e2e7396f5c24554088b752fcb Author: Noel Grandin Date: Thu May 16 11:39:40 2013 +0200 Java cleanup, AccessibilityTools.. was using a global variable. Yuck. Fix it to use a local variable. Not perfect, but better. Change-Id

[Libreoffice-commits] core.git: 2 commits - sc/CppunitTest_sc_filters_test.mk svx/source writerfilter/qa

895c1bcc811813ba32d865974b7172cb288074dc Author: Noel Grandin Date: Tue May 21 10:12:31 2013 +0200 fdo#46808, fix unit test ...after my PrimitiveFactory2D changes Change-Id: I994d2dd0aebed67643f749dc43bcd4e744601885 diff --git a/sc/CppunitTest_sc_filters_test.mk b/sc

[Libreoffice-commits] core.git: include/tools tools/source

include/tools/diagnose_ex.h | 44 -- tools/source/debug/debug.cxx | 49 +++ 2 files changed, 54 insertions(+), 39 deletions(-) New commits: commit 863d38fbfa4fb4861e476828c46410602100919e Author: Noel Grandin Date

[Libreoffice-commits] core.git: 6 commits - connectivity/Library_jdbc.mk connectivity/Library_mork.mk connectivity/Library_sdbc2.mk extensions/Library_log.mk include/oox include/tools offapi/com offap

|1 xmlscript/Library_xmlscript.mk|1 44 files changed, 325 insertions(+), 130 deletions(-) New commits: commit 02021163dbbcc8904da0b2138c8b53684dcc8ab4 Author: Noel Grandin Date: Tue May 21 13:52:07 2013 +0200 fdo#46808, Convert oox

[Libreoffice-commits] core.git: 3 commits - connectivity/Library_kab1.mk filter/source framework/inc framework/source

|2 9 files changed, 43 insertions(+), 53 deletions(-) New commits: commit 884217479de20e2ff5217a0829d678f416fb8505 Author: Noel Grandin Date: Tue May 21 14:45:48 2013 +0200 fdo#46808, Convert more XMultiServiceFactory to XComponentContext Change-Id

[Libreoffice-commits] core.git: chart2/source offapi/com

chart2/source/model/main/Title.cxx |8 chart2/source/model/main/Title.hxx |8 offapi/com/sun/star/chart2/XTitle2.idl |5 +++-- 3 files changed, 11 insertions(+), 10 deletions(-) New commits: commit 03c3cd90930d6fb7d0f498e4b21871b1746d9b2d Author: Noel

[Libreoffice-commits] core.git: framework/source

framework/source/dispatch/closedispatcher.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 9fa7dd98ccf91a2862f4c61d5d94aff2a1bbe4bf Author: Noel Grandin Date: Wed May 22 15:46:15 2013 +0200 fix Mac build Change-Id

[Libreoffice-commits] core.git: Branch 'libreoffice-4-1' - chart2/source offapi/com

chart2/source/model/main/Title.cxx |8 chart2/source/model/main/Title.hxx |8 offapi/com/sun/star/chart2/XTitle2.idl |5 +++-- 3 files changed, 11 insertions(+), 10 deletions(-) New commits: commit ab554c32e705ccdd6d67fceb215d18257399023c Author: Noel

Re: Gerrit submissions

On 2013-05-23 13:02, Fridrich Strba wrote: However, if you have a submission in Gerrit that is having negative review and you are not planning to work on that patch or that patch is obsolete, please consider abandoning it in Gerrit, since now there are ~3/4 of patches in this state. That will als

[Libreoffice-commits] core.git: include/toolkit offapi/com scripting/source toolkit/source

/dlgprov/dlgprov.cxx |6 +- toolkit/source/controls/dialogcontrol.cxx|8 6 files changed, 7 insertions(+), 17 deletions(-) New commits: commit 2ce6828bbbf6ba181bb2276adeec279e74151ef6 Author: Noel Grandin Date: Thu May 23 16:38:15 2013 +0200

fdo#46808, Convert awt::UnoControlDialogModel to new style problem

Hi OK, so it turns out that my change fdo#46808, Convert awt::UnoControlDialogModel to new style http://cgit.freedesktop.org/libreoffice/core/commit/?id=6c61b20a8d4a6dcac28801cde82a211fb7e30654 has been causing some problems, notably around getting and setting properties. Miklos did all of

[Libreoffice-commits] core.git: dbaccess/source

dbaccess/source/sdbtools/connection/connectiontools.cxx | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) New commits: commit 73a809cba87eefbb495c5ba53f89b48d671f8230 Author: Noel Grandin Date: Thu May 30 08:18:16 2013 +0200 Bug 64984 - EDITING: Creating table with GUI

<    1   2   3   4   5   6   7   8   9   10   >