Re: New line break attribute "clear"

2022-03-29 Thread Regina Henschel
Hi Miklos, Regina Henschel schrieb am 28.03.2022 um 12:33: I will write a JIRA ticket for it and post the number then. The ticket is in https://issues.oasis-open.org/browse/OFFICE-4124 Kind regards, Regina

Re: New line break attribute "clear"

2022-03-28 Thread Regina Henschel
Hi Miklos, Miklos Vajna schrieb am 28.03.2022 um 10:09: Hi Regina, On Thu, Mar 17, 2022 at 12:16:42PM +0100, Miklos Vajna wrote: No, so far I only added layout for the "all" case, and tested only with top->bottom left->right. But I'll take a look at RTL once the plain left/right clear types

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - include/oox oox/qa oox/source sd/qa sw/qa sw/source

2022-03-28 Thread Regina Henschel (via logerrit)
6bd85136efe3d3668b59a596d692f65bf0a4982c Author: Regina Henschel AuthorDate: Fri Mar 18 18:31:05 2022 +0100 Commit: Miklos Vajna CommitDate: Mon Mar 28 11:38:26 2022 +0200 tdf#147978 export subpaths individually in custGeom ...and implement export of all missing commands

[Libreoffice-commits] core.git: include/oox oox/qa oox/source sd/qa sw/qa sw/source

2022-03-25 Thread Regina Henschel (via logerrit)
2029b2f6dd0109c5892e5ac5640022b31fe42fd2 Author: Regina Henschel AuthorDate: Fri Mar 18 18:31:05 2022 +0100 Commit: Miklos Vajna CommitDate: Fri Mar 25 14:00:23 2022 +0100 tdf#147978 export subpaths individually in custGeom ...and implement export of all missing commands

Mapping OOXML camera to our camera model

2022-03-24 Thread Regina Henschel
Hi all, I have asked Microsoft about details about their camera. Find the answer in https://docs.microsoft.com/en-us/answers/questions/769795/how-to-get-distance-of-view-point-to-xy-plane-for.html Kind regards, Regina

Improve WriteCustomGeometry in oox export; review of patch

2022-03-24 Thread Regina Henschel
Hi Miklos, hi all, the patch in https://gerrit.libreoffice.org/c/core/+/131837 is now ready for review. It is a change in the way a custGeom element is generated. I have dropped the export via PolyPolygon. Instead our path commands are directly mapped to oox path commands. That is a larger

Re: New line break attribute "clear"

2022-03-16 Thread Regina Henschel
Hi Miklos, Miklos Vajna schrieb am 16.03.2022 um 10:43: Hi Regina, On Wed, Mar 16, 2022 at 10:18:44AM +0100, Regina Henschel wrote: I wonder about the new attribute. Could you please explain it a bit (perhaps on dev list?). Yes, let me copy the dev list. I know a "clear" attr

Re: How to get started with contribution

2022-03-12 Thread Regina Henschel
Hi Siva Sankar, welcome to the LibreOffice community. Siva Sankar schrieb am 12.03.2022 um 14:04: Respected Sir/Madam I am Siva Sankar A, a Computer science undergrad, I am in my second year at Amrita Vishwa Vidya Peetham, Amritapuri. I am new to open source contributions but I am well

Store properties of OOXML 3D-shapes in ODF

2022-03-09 Thread Regina Henschel
Hi Miklos, hi all, I have started a discussion in the ODF TC how ODF could be enhanced to be able to store properties which are needed to render OOXML 3D-shapes (I mean the normal shapes in 3D-mode, not the new "3D Model" of MS Office). I have collected all the problems I see in the attached

Re: Ideas for improving DevGuide

2022-03-08 Thread Regina Henschel
Hi Hossein, Hossein Nourikhah schrieb am 08.03.2022 um 13:05: Hello, As you may already know, with the efforts from Ilmari, DevGuide is now imported as multi-page chapters into the TDF Wiki. There were some performance and formatting problems that are now resolved, or will be fixed soon

[Libreoffice-commits] core.git: svx/source

2022-03-06 Thread Regina Henschel (via logerrit)
svx/source/tbxctrls/extrusioncontrols.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit b4e9eb5b977e53e86abb3a6a3bb530d3a5ac7368 Author: Regina Henschel AuthorDate: Sun Mar 6 20:00:54 2022 +0100 Commit: Regina Henschel CommitDate: Sun Mar 6 23:22:33 2022

Re: Test LibreOffice

2022-03-06 Thread Regina Henschel
Hello Ysmériane, you can download the latest developer version from https://dev-builds.libreoffice.org/daily/master/ This version can be installed in parallel with a regular version. If you encounter problems, please write a bug report https://wiki.documentfoundation.org/QA/BugReport/fr If

[Libreoffice-commits] core.git: include/xmloff schema/libreoffice xmloff/inc xmloff/qa xmloff/source

2022-02-24 Thread Regina Henschel (via logerrit)
/ximpcustomshape.cxx |9 + xmloff/source/token/tokens.txt |1 10 files changed, 108 insertions(+), 7 deletions(-) New commits: commit c893c0e359b82be71107e064bd2266c6daff81d7 Author: Regina Henschel AuthorDate: Mon Feb 21 23:08:10 2022 +0100

Info about OOXML light rig of type Legacy*

2022-02-23 Thread Regina Henschel
Hi all, I had a discussion about OOXML light rig of type Legacy* with the MS Team for specifications. I think, that those who work on graphic import filter might be interested in it: https://docs.microsoft.com/en-us/answers/questions/741802/what-is-keylightoffset-and-filllightoffset.html

[Libreoffice-commits] core.git: svx/qa svx/source

2022-02-17 Thread Regina Henschel (via logerrit)
deletions(-) New commits: commit 4c0b033ece143b6f398157e812ff1c6b22e2855d Author: Regina Henschel AuthorDate: Thu Feb 17 22:13:54 2022 +0100 Commit: Regina Henschel CommitDate: Thu Feb 17 23:56:37 2022 +0100 tdf#147409 tdf#146866 use SetPropertyValue for toggle The toggles

Unit test for debug build?

2022-02-17 Thread Regina Henschel
Hi all, Currently a debug build fails assert in SfxItemPool::PutImpl in itempool.cxx#679 if applying uno.FontworkSameLetterHeights or uno:ExtrusionToggle. I know how to fix it. But I don't know whether such fix has to be accompanied by a unit test and if yes, how to do it. The problem is

[Libreoffice-commits] core.git: filter/source include/xmloff offapi/com offapi/UnoApi_offapi.mk schema/libreoffice svx/qa svx/source svx/uiconfig xmloff/inc xmloff/qa xmloff/source

2022-02-17 Thread Regina Henschel (via logerrit)
insertions(+), 182 deletions(-) New commits: commit 157b027c4cfca2582b1c1bdb66992560084ac008 Author: Regina Henschel AuthorDate: Thu Jan 13 13:26:25 2022 +0100 Commit: Regina Henschel CommitDate: Thu Feb 17 14:14:01 2022 +0100 tdf#145700 Improve lighting in extruded custom shapes

Re: tdf#145700 Improve lighting in extruded custom shapes

2022-02-16 Thread Regina Henschel
Hi all, Regina Henschel schrieb am 14.02.2022 um 17:45: Hi all, my patch is ready now. It makes some principle changes. So if you have some time please have a look. https://gerrit.libreoffice.org/c/core/+/124337 No reaction yet. In case you want to review it, but had no time yet, please

tdf#145700 Improve lighting in extruded custom shapes

2022-02-14 Thread Regina Henschel
Hi all, my patch is ready now. It makes some principle changes. So if you have some time please have a look. https://gerrit.libreoffice.org/c/core/+/124337 Kind regards Regina

Re: Material preset "Metal" for extruded custom shapes

2022-02-10 Thread Regina Henschel
Hi Miklos, hi all, Miklos Vajna schrieb am 08.02.2022 um 08:30: And a second question is the data type of the internal (and API) property. In the current state of the patch it is "MetalColored" with data type Boolean. If you have an ODF attribute with a number of possible values, then that

Re: Material preset "Metal" for extruded custom shapes

2022-02-08 Thread Regina Henschel
Hi Mike, Mike Kaganski schrieb am 08.02.2022 um 08:35: On 08.02.2022 10:30, Miklos Vajna wrote: On Mon, Feb 07, 2022 at 08:55:10PM +0100, Regina Henschel wrote: The attribute itself will be with prefix 'loext' till it is integrated in ODF. But what namespace prefix (and associated namespace

Re: Material preset "Metal" for extruded custom shapes

2022-02-07 Thread Regina Henschel
Hi Miklos, hi all, I have discussed the problem with the OASIS TC today. Their advise is, to not use Boolean as data type but a string and have namespaced values. That way it is more flexible in allowing further different ways to implement a 'metal' rendering. So I will change that. The

Re: Material preset "Metal" for extruded custom shapes

2022-02-07 Thread Regina Henschel
Hi Miklos, hi all, Miklos Vajna schrieb am 07.02.2022 um 09:54: Hi Regina, On Wed, Feb 02, 2022 at 11:46:29PM +0100, Regina Henschel wrote: LO has only a 'metal' from my last commit, which I now think has errors. It is clear, that MS Office renders it using the material color. Besides

Re: Value range of c3DSpecularAmt

2022-02-05 Thread Regina Henschel
Miklos Vajna schrieb am 04.02.2022 um 08:57: Hi Regina, On Sun, Jan 30, 2022 at 11:28:09PM +0100, Regina Henschel wrote: When the shape is rendered, the product of light intensity and specularity is converted to a gray color for the 3D-Scene attribute D3DMaterialSpecularIntensity. Because

Re: Material preset "Metal" for extruded custom shapes

2022-02-02 Thread Regina Henschel
Hi Miklos, Miklos Vajna schrieb am 02.02.2022 um 08:50: Hi Regina, On Sun, Jan 30, 2022 at 11:20:33PM +0100, Regina Henschel wrote: I want to make rendering similar to actual rendering in MSO in case we have an import from MSO. MSO uses for the attribute c3DDiffuseAmt the special value

Re: Material preset "Metal" for extruded custom shapes

2022-02-02 Thread Regina Henschel
Hi Armin, Armin Le Grand schrieb am 02.02.2022 um 09:57: Hi Regina, I remember that we did 'metal' *before* other competitor(s), so that same name is/must be just coincidence. I don't think it was before MS Office. The presets "Plastic", "Matte", "Metal" and "Wireframe" for extruded custom

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - sw/qa sw/source

2022-02-02 Thread Regina Henschel (via logerrit)
b3f426bc7ff75820c2487f1a7f9d0117b5d53831 Author: Regina Henschel AuthorDate: Tue Feb 1 20:38:07 2022 +0100 Commit: Xisco Fauli CommitDate: Wed Feb 2 13:54:34 2022 +0100 tdf#107727 disable border in RTF export if not drawn A border of a text frame is not drawn, if it is really disabled

[Libreoffice-commits] core.git: sw/qa sw/source

2022-02-01 Thread Regina Henschel (via logerrit)
9877a0190e43241f4a5102e5d9cc7181f91d5a6f Author: Regina Henschel AuthorDate: Tue Feb 1 20:38:07 2022 +0100 Commit: Miklos Vajna CommitDate: Wed Feb 2 08:38:11 2022 +0100 tdf#107727 disable border in RTF export if not drawn A border of a text frame is not drawn, if it is really disabled

Re: Making a light 'soft' in a 3D scene

2022-01-31 Thread Regina Henschel
Hi Armin, hi all, Regina Henschel schrieb am 25.01.2022 um 17:59: Armin Le Grand schrieb am 25.01.2022 um 10:13: [..] HTH for the moment, Yes. It shows me, that it is better to continue with my approach to use additional lights. The extruded shape has only two lights in its file

Value range of c3DSpecularAmt

2022-01-30 Thread Regina Henschel
Hi all, hi Miklos, MS Office uses value 8/65536 ≈ 1.22 for attribute c3DSpecularAmt. The specification reads, "c3DSpecularAmt (4 bytes): A value of type FixedPoint, as specified in [MS-OSHARED] section 2.2.1.6, that specifies the ratio of incident to specular light that is reflected on a

Material preset "Metal" for extruded custom shapes

2022-01-30 Thread Regina Henschel
Hi all, hi Miklos, the UI of Microsoft Office provides a material preset "Metal". Our UI provides that too. Both ODF and MSO standards have a Boolean attribute whether "Metal" has to be used or not. But the way "Metal" is actually rendered in MSO [3] is different from how ODF specifies it [1]

Re: Making a light 'soft' in a 3D scene

2022-01-25 Thread Regina Henschel
Hi Armin, thank you for looking at the problem. [comments inline] Armin Le Grand schrieb am 25.01.2022 um 10:13: Hi Regina, On 1/24/22 15:51, Regina Henschel wrote: Hi Armin, hi all, a light can be 'harsh' or 'not harsh' (that means 'soft') in an extruded custom shape. This is independent

Making a light 'soft' in a 3D scene

2022-01-24 Thread Regina Henschel
Hi Armin, hi all, a light can be 'harsh' or 'not harsh' (that means 'soft') in an extruded custom shape. This is independent from the material property 'specular'. A 'soft' light is rendered in MS Office, as if the light has a wider emitting area in real world. The UI of our 3D-Scenes does

Re: Mapping c3DShininess to property 'Shininess'

2022-01-20 Thread Regina Henschel
Hi Miklos, Miklos Vajna schrieb am 20.01.2022 um 11:18: Hi Regina, On Wed, Jan 19, 2022 at 06:38:05PM +0100, Regina Henschel wrote: I'm going to use API 'Shininess' = 10 * c3DShininess. That maps MS default 5 to ODF default 50%. It would imply, that for rendering an ODF document

Mapping c3DShininess to property 'Shininess'

2022-01-19 Thread Regina Henschel
Hi Miklos, hi all, I'm going to implement 'Shininess' for extruded custom shapes. The chain is MS c3DShininess | | import ↓ API 'Shininess' = ODF 'draw:extrusion-shininess' | | rendering ↓ SDRATTR_3DOBJ_MAT_SPECULAR_INTENSITY From experiments I know

Re: Problems with lighting of extruded custom-shapes

2022-01-14 Thread Regina Henschel
Hi Miklos, I have put it into code now, see https://gerrit.libreoffice.org/c/core/+/128449 That makes it perhaps easier to discuss the problems. My changes give good results for import of MS binary formats, especially if the user has chosen to illuminate the object from front or if the user

Re: Problems with lighting of extruded custom-shapes

2022-01-07 Thread Regina Henschel
Hi all, (Hi Miklos, I repeat here my answer to you for the list, because CC didn't work because the attachment was too large.) Miklos Vajna schrieb am 07.01.2022 um 14:30: Hi Regina, On Thu, Jan 06, 2022 at 10:33:54PM +0100, Regina Henschel wrote: If the OOXML 'scene3d' and 'sp3d

Re: Problems with lighting of extruded custom-shapes

2022-01-07 Thread Regina Henschel
Hi Miklos, Miklos Vajna schrieb am 07.01.2022 um 14:30: Somewhat related, if you have some RTF document where these properties are not imported, but the DOC version of it is imported correctly, I would be interested to look at that -- could you please file a bug and CC me? Bug for RTF import

Problems with lighting of extruded custom-shapes

2022-01-06 Thread Regina Henschel
Hi all, I want to improve lighting for extruded custom-shapes. I have examined how MS Office (MSO) does lighting of those shapes. Now I try to map that to the attributes of 3D scene and objects, which are used to render extruded custom-shapes. I see some problems and things incompatible with

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - svx/qa

2021-12-17 Thread Regina Henschel (via logerrit)
Author: Regina Henschel AuthorDate: Thu Dec 16 19:47:05 2021 +0100 Commit: Xisco Fauli CommitDate: Fri Dec 17 11:57:06 2021 +0100 tdf#145904,tdf#145956 unit test extrusion of shapes These tests belongs to commit 453c5b6, improve extrusion of custom shapes. Change-Id

[Libreoffice-commits] core.git: svx/qa

2021-12-16 Thread Regina Henschel (via logerrit)
Author: Regina Henschel AuthorDate: Thu Dec 16 19:47:05 2021 +0100 Commit: Regina Henschel CommitDate: Fri Dec 17 01:32:38 2021 +0100 tdf#145904,tdf#145956 unit test extrusion of shapes These tests belongs to commit 453c5b6, improve extrusion of custom shapes. Change

Adding item to ReleaseNotes

2021-12-16 Thread Regina Henschel
Hi all, I have added an item to https://wiki.documentfoundation.org/ReleaseNotes/7.3 But that is a multilingua page and I don't know what to do now. Kind regards, Regina

Review list of bugs with ODF relationship to be covered by a TDF tender

2021-12-16 Thread Regina Henschel
Hi all, hi Florian, TDF is planning a tender "Cleanup & further improve ODF conformance". In case you have not noticed it, the call for comments had been on https://listarchives.documentfoundation.org/www/board-discuss/2021/msg00253.html I have been asked to review relevant bugs. The

Re: Need a help

2021-12-15 Thread Regina Henschel
Hi Rajeev, Rajeev Kumar schrieb am 14.12.2021 um 19:28: Hi everyone, I have a doubt. when we import ppt in LibreOffice. It extracts and parses all the xml files to layout. ? If you import ppt, then there is no XML. It you have XML, then you are likely importing pptx. ppt and pptx are

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - filter/source svx/qa svx/source

2021-12-15 Thread Regina Henschel (via logerrit)
svx/source/customshapes/EnhancedCustomShape3d.cxx | 310 ++ svx/source/customshapes/EnhancedCustomShape3d.hxx | 31 -- 7 files changed, 201 insertions(+), 204 deletions(-) New commits: commit 90b925307da4066cd18fcbf31b903e948fa55e82 Author: Regina Henschel AuthorDate

[Libreoffice-commits] core.git: filter/source svx/qa svx/source

2021-12-14 Thread Regina Henschel (via logerrit)
svx/source/customshapes/EnhancedCustomShape3d.cxx | 310 ++ svx/source/customshapes/EnhancedCustomShape3d.hxx | 31 -- 7 files changed, 201 insertions(+), 204 deletions(-) New commits: commit 453c5b6214654b440fe1d3e926cddfb695e17f10 Author: Regina Henschel AuthorDate

Re: [Libreoffice-qa] ESC meeting agenda: 2021-12-09 16:00 Berlin time

2021-12-08 Thread Regina Henschel
Hi Miklos, Miklos Vajna schrieb am 08.12.2021 um 16:37: * Pending Action Items:     + reach out to Regina regarding the ODF tender spec (Michael S) Michael Stahl has contacted me. I had already a list of about 80 relevant bugs from my comment on the tender. I have agreed and already

Re: ESC meeting agenda: 2021-12-09 16:00 Berlin time

2021-12-08 Thread Regina Henschel
Hi Miklos, Miklos Vajna schrieb am 08.12.2021 um 16:37: * Pending Action Items:     + reach out to Regina regarding the ODF tender spec (Michael S) Michael Stahl has contacted me. I had already a list of about 80 relevant bugs from my comment on the tender. I have agreed and already

How update projection when transformation matrix is applied to a 3D scene?

2021-12-07 Thread Regina Henschel
Hi all, I'm going to correct errors in custom shape extrusion. That is in https://opengrok.libreoffice.org/xref/core/svx/source/customshapes/EnhancedCustomShape3d.cxx The current solution calculates a transformation matrix aNewTransform and applies it to the scene by pScene->NbcSetTransform in

Re: Another Windows configure issue: error: Could not figure out what C++ library this is

2021-11-27 Thread Regina Henschel
Hi Ilmari, Ilmari Lauhakangas schrieb am 27.11.2021 um 11:56: One of the three new devs who faced an issue of our configure not finding VS updated his Windows 8.1 and got one step further, but is now stuck with another issue. Any ideas on what to check? Ilmari user@computer ~/lode/dev/core

Re: Problems with item "RotationCenter" in item "Extrusion" in the property "CustomShapeGeometry"

2021-11-25 Thread Regina Henschel
Hi Miklos, Miklos Vajna schrieb am 25.11.2021 um 09:33: Hi Regina, On Wed, Nov 24, 2021 at 04:50:38PM +0100, Regina Henschel wrote: The situation is different. All specifications and our own description in API use "fraction of shape size", but our internal property "RotationC

Re: Problems with item "RotationCenter" in item "Extrusion" in the property "CustomShapeGeometry"

2021-11-24 Thread Regina Henschel
Hi Miklos, Miklos Vajna schrieb am 22.11.2021 um 08:21: Yes, if our doc model wants to work in fractions and MSO works in EMUs, then doing this mapping in the MSO import/export filters sounds good to me. The situation is different. All specifications and our own description in API use

Problems with item "RotationCenter" in item "Extrusion" in the property "CustomShapeGeometry"

2021-11-21 Thread Regina Henschel
Hi all, The current implementation of "RotationCenter" uses the three XYZ values as if they are in 1/100 Millimeter (Hmm). That is, if the values in ODF file are in Hmm, then the shape behaves as expected. But that does not fit the specifications. The "RotationCenter" appears in the

[Libreoffice-commits] core.git: svx/qa

2021-11-13 Thread Regina Henschel (via logerrit)
svx/qa/unit/svdraw.cxx | 26 ++ 1 file changed, 2 insertions(+), 24 deletions(-) New commits: commit 44f20abf66ce3f9806ad95522d7d9ae698350499 Author: Regina Henschel AuthorDate: Sat Nov 13 15:10:52 2021 +0100 Commit: Regina Henschel CommitDate: Sat Nov 13 18

[Libreoffice-commits] core.git: svx/qa

2021-11-12 Thread Regina Henschel (via logerrit)
+++ 5 files changed, 101 insertions(+) New commits: commit 87e5caca7d3133a32d92503bfa8e5a1409545187 Author: Regina Henschel AuthorDate: Wed Nov 10 22:34:07 2021 +0100 Commit: Regina Henschel CommitDate: Fri Nov 12 15:55:52 2021 +0100 tdf#143021 unit test enable 'matte

Re: Tests for improvement in rendering

2021-11-10 Thread Regina Henschel
schrieb am 10.11.2021 um 22:14: Hi Regina, On Tue, Nov 9, 2021 at 11:28 PM Regina Henschel <mailto:rb.hensc...@t-online.de>> wrote: Hi Tomaž, your dump works in principle. I can read the xml-file and build the assertXPath. For example, I am able to write a test about the

Re: Tests for improvement in rendering

2021-11-09 Thread Regina Henschel
Hi Tomaž, your dump works in principle. I can read the xml-file and build the assertXPath. For example, I am able to write a test about the material properties 'specular' and 'specularIntensity' of an object. Such is needed to verify correct values in case of material 'Metal'. But while

Re: Tests for improvement in rendering

2021-11-08 Thread Regina Henschel
Hi Tomaž, thank you for adding that part and providing an example. Tomaž Vajngerl schrieb am 08.11.2021 um 16:33: Hi Regina, On Fri, Nov 5, 2021 at 10:01 AM Tomaž Vajngerl > wrote: Hi Regina, I guess rendering the shape to primitives and then dumping the

[Libreoffice-commits] core.git: svx/source

2021-11-06 Thread Regina Henschel (via logerrit)
Henschel AuthorDate: Thu Nov 4 19:30:56 2021 +0100 Commit: Regina Henschel CommitDate: Sat Nov 6 15:35:46 2021 +0100 tdf#140321 enable 'matte', 'metal' extrusion surface The patch makes extrusion surface presets 'matte', 'plastic' and 'metal' look different from another. That has

Tests for improvement in rendering

2021-11-04 Thread Regina Henschel
Hi all, I have a first version of a patch for https://bugs.documentfoundation.org/show_bug.cgi?id=140321 "Fontwork: Change in surface has no effect" in Gerrit https://gerrit.libreoffice.org/c/core/+/124720 The improvements are about rendering. I'm looking for a partner, who can write tests for

[Libreoffice-commits] core.git: Branch 'libreoffice-7-2' - svx/qa svx/source

2021-10-22 Thread Regina Henschel (via logerrit)
264da4cc0b60e75884ff66ab25fd38952cc6020d Author: Regina Henschel AuthorDate: Thu Oct 21 16:09:44 2021 +0200 Commit: Xisco Fauli CommitDate: Fri Oct 22 14:50:06 2021 +0200 tdf#145245 correct relative position of extrusion ODF specifies for draw:extrusion-depth, 'The draw:extrusion-depth attribute

[Libreoffice-commits] core.git: svx/qa svx/source

2021-10-21 Thread Regina Henschel (via logerrit)
5ab21caf603ba0a1c95bbc94a29eebe3483d1599 Author: Regina Henschel AuthorDate: Thu Oct 21 16:09:44 2021 +0200 Commit: Regina Henschel CommitDate: Thu Oct 21 23:36:16 2021 +0200 tdf#145245 correct relative position of extrusion ODF specifies for draw:extrusion-depth, 'The draw:extrusion-depth

[Libreoffice-commits] core.git: Branch 'libreoffice-7-2' - oox/CppunitTest_oox_shape.mk oox/qa oox/source

2021-10-19 Thread Regina Henschel (via logerrit)
(-) New commits: commit 516a4a59b7d16fbd803f55c37c51564f46a29f7d Author: Regina Henschel AuthorDate: Sun Oct 17 23:49:17 2021 +0200 Commit: Xisco Fauli CommitDate: Tue Oct 19 11:37:02 2021 +0200 tdf#125582 use TextVerticalAlign_BOTTOM for textCircle PowerPoint aligns the bottom

[Libreoffice-commits] core.git: oox/CppunitTest_oox_shape.mk oox/qa oox/source

2021-10-18 Thread Regina Henschel (via logerrit)
(-) New commits: commit 9142d19ddc751e05041471aa1bbeca2f06729522 Author: Regina Henschel AuthorDate: Sun Oct 17 23:49:17 2021 +0200 Commit: Regina Henschel CommitDate: Mon Oct 18 19:13:42 2021 +0200 tdf#125582 use TextVerticalAlign_BOTTOM for textCircle PowerPoint aligns

[Libreoffice-commits] core.git: Branch 'libreoffice-7-2' - svx/qa svx/source

2021-10-18 Thread Regina Henschel (via logerrit)
460af321a84aae07f699e45700c212fcad50c38a Author: Regina Henschel AuthorDate: Sun Oct 17 00:15:04 2021 +0200 Commit: Xisco Fauli CommitDate: Mon Oct 18 12:34:26 2021 +0200 tdf#144988 correct font size in multiline Fontwork text The error happened if ScaleX in TextPath is true

[Libreoffice-commits] core.git: Branch 'libreoffice-7-2' - svx/qa svx/source

2021-10-18 Thread Regina Henschel (via logerrit)
164ebe08df1cb501235aff99722864556ee6fc2d Author: Regina Henschel AuthorDate: Fri Oct 15 02:00:30 2021 +0200 Commit: Xisco Fauli CommitDate: Mon Oct 18 10:51:26 2021 +0200 tdf#145111 evaluate nVertDiff for HORZADJUST_LEFT too In case of ScaleX=true in property TextPath, SDRTEXTVERTADJUST

[Libreoffice-commits] core.git: svx/qa svx/source

2021-10-17 Thread Regina Henschel (via logerrit)
3b922eb756d990c16944bbce42ae13142565a835 Author: Regina Henschel AuthorDate: Sun Oct 17 00:15:04 2021 +0200 Commit: Regina Henschel CommitDate: Sun Oct 17 14:04:29 2021 +0200 tdf#144988 correct font size in multiline Fontwork text The error happened if ScaleX in TextPath is true

Re: How to deal with dpi-dependent values in unit tests?

2021-10-16 Thread Regina Henschel
Hi Tomaž, Tomaž Vajngerl schrieb am 16.10.2021 um 15:35: Hi Regina, On Fri, Oct 15, 2021 at 1:29 PM Regina Henschel <mailto:rb.hensc...@t-online.de>> wrote: Hi all, the values of the bound rectangle of a Fontwork shape are dpi dependent (I don't know why). I could

[Libreoffice-commits] core.git: svx/qa svx/source

2021-10-15 Thread Regina Henschel (via logerrit)
64bacd4f2bd9c8e10e8c9a0b7d18516c77260df3 Author: Regina Henschel AuthorDate: Fri Oct 15 02:00:30 2021 +0200 Commit: Regina Henschel CommitDate: Sat Oct 16 01:15:21 2021 +0200 tdf#145111 evaluate nVertDiff for HORZADJUST_LEFT too In case of ScaleX=true in property TextPath, SDRTEXTVERTADJUST

How to deal with dpi-dependent values in unit tests?

2021-10-15 Thread Regina Henschel
Hi all, the values of the bound rectangle of a Fontwork shape are dpi dependent (I don't know why). I could increase the tolerance to cover more dpi settings as done in https://gerrit.libreoffice.org/c/core/+/123613 or I add if (!IsDefaultDPI()) return; as done in

[Libreoffice-commits] core.git: Branch 'libreoffice-7-2' - svx/qa svx/source

2021-10-13 Thread Regina Henschel (via logerrit)
9694118306cc733d08b590fffe7a176661534b7f Author: Regina Henschel AuthorDate: Fri Oct 8 22:10:35 2021 +0200 Commit: Xisco Fauli CommitDate: Wed Oct 13 15:57:57 2021 +0200 tdf#145004 remove fontwork text padding for case ScaleX=true The setting ScaleX=true in property TextPath

Re: Need help with patch for Fontwork shape

2021-10-13 Thread Regina Henschel
Hi Miklos, thank you for starting a next try to build. The build was now successful. Kind regards Regina Regina Henschel schrieb am 12.10.2021 um 17:00: Hi all, I need help with patch https://gerrit.libreoffice.org/c/core/+/123295 It passes Jenkins in Patchset 3. The only change

[Libreoffice-commits] core.git: svx/qa svx/source

2021-10-13 Thread Regina Henschel (via logerrit)
4e1f5b5eaddac6ff4b3028074edc8f6886d64c3f Author: Regina Henschel AuthorDate: Fri Oct 8 22:10:35 2021 +0200 Commit: Regina Henschel CommitDate: Wed Oct 13 13:27:58 2021 +0200 tdf#145004 remove fontwork text padding for case ScaleX=true The setting ScaleX=true in property TextPath

Need help with patch for Fontwork shape

2021-10-12 Thread Regina Henschel
Hi all, I need help with patch https://gerrit.libreoffice.org/c/core/+/123295 It passes Jenkins in Patchset 3. The only change was then a change in the commit message. But now it fails with always the same problem. I know Jenkins has a "hiccup" sometimes and tried a Rebase. But without

Re: Where have markers to be drawn in custom-shapes?

2021-09-21 Thread Regina Henschel
Hi Miklos, Miklos Vajna schrieb am 21.09.2021 um 08:35: Hi Regina, On Mon, Sep 13, 2021 at 07:35:10PM +0200, Regina Henschel wrote: I cannot determine where to draw markers for the draw:enhanced-path of a custom-shape. This question is not about path-objects and not about SVG, but only

Re: Improvement for Hebrew writing

2021-09-17 Thread Regina Henschel
Hi Simone, Simone Aiello schrieb am 16.09.2021 um 16:46: The software has problems with the integration of Latin text and Hebrew text. Would it be possible to make a change? Yes. It depends on your skills, how you can help. Or make a plugin to make things better? "plugin" ? Is there

Where have markers to be drawn in custom-shapes?

2021-09-13 Thread Regina Henschel
Hi all, I cannot determine where to draw markers for the draw:enhanced-path of a custom-shape. This question is not about path-objects and not about SVG, but only about custom-shapes. ODF has no rule for it yet. Examples A Consists of one sub-path, which is closed by command Z. M 25,10 L

[Libreoffice-commits] core.git: Branch 'libreoffice-7-2' - sc/qa sc/source

2021-09-07 Thread Regina Henschel (via logerrit)
sc/qa/unit/scshapetest.cxx | 84 sc/source/filter/xcl97/xcl97rec.cxx |8 ++- 2 files changed, 90 insertions(+), 2 deletions(-) New commits: commit 7ed532a2cbce52cd20b0801116d35ce713365f76 Author: Regina Henschel AuthorDate: Sun Sep 5 01:28

[Libreoffice-commits] core.git: sc/qa sc/source

2021-09-06 Thread Regina Henschel (via logerrit)
sc/qa/unit/scshapetest.cxx | 84 sc/source/filter/xcl97/xcl97rec.cxx |8 ++- 2 files changed, 90 insertions(+), 2 deletions(-) New commits: commit 84d6d704682a4d0e037a28895356b073e4f992a5 Author: Regina Henschel AuthorDate: Sun Sep 5 01:28

[Libreoffice-commits] core.git: Branch 'distro/nisz/libreoffice-7-1' - sc/qa sc/source

2021-09-02 Thread Regina Henschel (via logerrit)
003b821b03474f048d993dc3cee240cf25b9a7ea Author: Regina Henschel AuthorDate: Fri Jul 30 23:18:39 2021 +0200 Commit: Gabor Kelemen CommitDate: Thu Sep 2 10:27:14 2021 +0200 tdf#143619 validation circle anchor is special For usual drawing objects, maStart in its Calc user data means the cell address

[Libreoffice-commits] core.git: include/oox oox/qa oox/source

2021-08-27 Thread Regina Henschel (via logerrit)
| 23 +++-- oox/source/vml/vmlshapecontext.cxx | 57 +-- 6 files changed, 157 insertions(+), 10 deletions(-) New commits: commit c56178f0daf69abb362e6216f51b6e1f5aff1777 Author: Regina Henschel AuthorDate: Wed Aug 25 19:32:36 2021 +0200 Commit: Regina

Re: Why is PolyPolygonShape excluded from DML export?

2021-08-24 Thread Regina Henschel
Hi Miklos, hi all, Excluding polygon shapes from DML export (done as fix for tdf#75254) is no longer needed. But I'm still unsure whether to remove this restriction. Pro: Polygon shapes are already exported as DML in Impress and Calc. So the behavior would become consistent. Polygon shapes

[Libreoffice-commits] core.git: Branch 'libreoffice-7-1' - sc/qa sc/source

2021-08-18 Thread Regina Henschel (via logerrit)
ee749af6d3c742efdfc28d245db6422d461ed51b Author: Regina Henschel AuthorDate: Fri Jul 30 23:18:39 2021 +0200 Commit: Christian Lohmaier CommitDate: Wed Aug 18 19:43:00 2021 +0200 tdf#143619 validation circle anchor is special For usual drawing objects, maStart in its Calc user data means the cell address

[Libreoffice-commits] core.git: Branch 'libreoffice-7-2' - oox/source sw/qa

2021-08-17 Thread Regina Henschel (via logerrit)
commits: commit 58ba1b975d75225222a27ff404281b9bff133143 Author: Regina Henschel AuthorDate: Sun Aug 15 18:48:32 2021 +0200 Commit: Xisco Fauli CommitDate: Tue Aug 17 09:38:44 2021 +0200 tdf#143860 non-primitive needs custGeom not prstGeom Error was, that for a custom shape

Re: Problems with filtering by font color

2021-08-16 Thread Regina Henschel
Hi Caolán, Caolán McNamara schrieb am 16.08.2021 um 23:00: On Mon, 2021-08-16 at 21:32 +0200, Regina Henschel wrote: How do you think filtering by font color should be specified in the ODF standard? FWIW we have extras/source/palettes/html.soc which lists the color- names of https://www.w3

Problems with filtering by font color

2021-08-16 Thread Regina Henschel
Hi all, LibreOffice has got the new feature in 7.3 to filter by font color (strings and numbers) in Calc. Such color can be determined by a) direct style assignment, including direct formatting b) by number-format, e.g. red for negative numbers c) by conditional formatting Filtering is not

Re: Why is PolyPolygonShape excluded from DML export?

2021-08-16 Thread Regina Henschel
and can try it? Background is, that in case Word 2010 does not show it, the exclusion of DML for PolyPolygon-shapes needs to be kept for docx version 12. Otherwise I would simple remove that part from DocxSdrExport::Impl::isSupportedDMLShape() Kind regards Regina Regina Henschel schrieb am

[Libreoffice-commits] core.git: oox/source sw/qa

2021-08-15 Thread Regina Henschel (via logerrit)
commits: commit 24a8e3209b1d7c2f4f13d5cc3f69726253af9eff Author: Regina Henschel AuthorDate: Sun Aug 15 18:48:32 2021 +0200 Commit: Regina Henschel CommitDate: Sun Aug 15 21:40:07 2021 +0200 tdf#143860 non-primitive needs custGeom not prstGeom Error was, that for a custom

[Libreoffice-commits] core.git: include/oox oox/qa oox/source

2021-08-14 Thread Regina Henschel (via logerrit)
changed, 120 insertions(+), 2 deletions(-) New commits: commit 925fa608d65a5970f966d45e33cccf04e2318060 Author: Regina Henschel AuthorDate: Thu Aug 12 19:19:19 2021 +0200 Commit: Regina Henschel CommitDate: Sat Aug 14 17:15:28 2021 +0200 tdf#142605 use frame size in oox export

[Libreoffice-commits] core.git: sw/qa sw/source

2021-08-13 Thread Regina Henschel (via logerrit)
| 435 ++ 8 files changed, 372 insertions(+), 147 deletions(-) New commits: commit 61ef73bb9e06ac7325abc26698314d7e35c164cc Author: Regina Henschel AuthorDate: Sun Aug 8 01:05:09 2021 +0200 Commit: Miklos Vajna CommitDate: Fri Aug 13 16:00:35 2021 +0200 tdf#143432

Review for: tdf#143432 and more, improve wrap contour export

2021-08-11 Thread Regina Henschel
Hi all, this is about patch: "tdf#143432 and more, improve wrap contour export" https://gerrit.libreoffice.org/c/core/+/120169 The patch is ready for now. I would be happy about a review. In case, please let me know, that you want to have a look at the patch. The patch still contains some

[Libreoffice-commits] core.git: Branch 'libreoffice-7-2' - sc/qa sc/source

2021-08-09 Thread Regina Henschel (via logerrit)
a1791f7e2503ca1d0868a0a607ff4717cd1fddeb Author: Regina Henschel AuthorDate: Fri Jul 30 23:18:39 2021 +0200 Commit: Xisco Fauli CommitDate: Mon Aug 9 19:42:44 2021 +0200 tdf#143619 validation circle anchor is special For usual drawing objects, maStart in its Calc user data means the cell address of left

[Libreoffice-commits] core.git: oox/source sw/qa writerfilter/source

2021-08-04 Thread Regina Henschel (via logerrit)
/GraphicImport.cxx|6 8 files changed, 96 insertions(+), 19 deletions(-) New commits: commit 4fb5817ecb614bd0c83afb3627d7caadbfe8c082 Author: Regina Henschel AuthorDate: Thu Jul 29 22:02:25 2021 +0200 Commit: Miklos Vajna CommitDate: Wed Aug 4 14:39:34 2021 +0200

[Libreoffice-commits] core.git: sc/qa sc/source

2021-08-02 Thread Regina Henschel (via logerrit)
0cff1aa48453ee0c05bafcac5360329fb6bf9557 Author: Regina Henschel AuthorDate: Fri Jul 30 23:18:39 2021 +0200 Commit: Regina Henschel CommitDate: Mon Aug 2 19:22:10 2021 +0200 tdf#143619 validation circle anchor is special For usual drawing objects, maStart in its Calc user data means the cell address

Re: How to create a lockedCanvas in MSWord?

2021-07-30 Thread Regina Henschel
is imported, it would be good, if you review it. Kind regards Regina Miklos Vajna schrieb am 27.07.2021 um 08:56: Hi Regina, On Mon, Jul 26, 2021 at 02:21:51AM +0200, Regina Henschel wrote: does someone know, how to create a document in MSWord, which uses a lockedCanvas? Or is that only

Re: How to create a lockedCanvas in MSWord?

2021-07-28 Thread Regina Henschel
Hi Miklos, Miklos Vajna schrieb am 27.07.2021 um 08:56: Hi Regina, I attach a sample I just created this way in MSO 2007. Can you please make a lockedCanvas example for me, containing a small image and a straight line? Perhaps attach it to

Re: How to create a lockedCanvas in MSWord?

2021-07-27 Thread Regina Henschel
Hi Miklos, Miklos Vajna schrieb am 27.07.2021 um 08:56: Hi Regina, On Mon, Jul 26, 2021 at 02:21:51AM +0200, Regina Henschel wrote: does someone know, how to create a document in MSWord, which uses a lockedCanvas? Or is that only possible via macro? It would be good to be able to generate

[Libreoffice-commits] core.git: sw/qa sw/source writerfilter/source

2021-07-26 Thread Regina Henschel (via logerrit)
: Regina Henschel AuthorDate: Sun Jul 25 18:04:53 2021 +0200 Commit: Regina Henschel CommitDate: Tue Jul 27 01:34:02 2021 +0200 tdf#143475 consider Word 2007 rotated image speciality Usually Word relates effectExtent to a rectangle with swapped width and height, if the object

How to create a lockedCanvas in MSWord?

2021-07-25 Thread Regina Henschel
Hi all, does someone know, how to create a document in MSWord, which uses a lockedCanvas? Or is that only possible via macro? It would be good to be able to generate own test documents. Kind regards Regina ___ LibreOffice mailing list

[Libreoffice-commits] core.git: writerfilter/qa writerfilter/source

2021-07-23 Thread Regina Henschel (via logerrit)
insertions(+), 4 deletions(-) New commits: commit 17cfd3d3e2e6f807eb1faf07436c7e96e15157a7 Author: Regina Henschel AuthorDate: Wed Jul 21 20:43:53 2021 +0200 Commit: Regina Henschel CommitDate: Fri Jul 23 18:05:01 2021 +0200 tdf#143455 exclude diagram from pos and margin adaptions

<    1   2   3   4   5   6   7   8   9   10   >