Re: Why is PolyPolygonShape excluded from DML export?

Hi Miklos, thank you for pointing me to that bug report. Miklos Vajna schrieb am 21.07.2021 um 08:46: Hi Regina, On Tue, Jul 20, 2021 at 12:08:30AM +0200, Regina Henschel wrote: Is it possible, that the exclusion was only forgotten to remove, or is there a valid reason? This was added

Why is PolyPolygonShape excluded from DML export?

Hi all, this is about export ODF shape -> OOXML. bool DocxSdrExport::Impl::isSupportedDMLShape(const uno::Reference& xShape) { uno::Reference xServiceInfo(xShape, uno::UNO_QUERY_THROW); if (xServiceInfo->supportsService("com.sun.star.drawing.PolyPolygonShape") ||

[Libreoffice-commits] core.git: writerfilter/source

writerfilter/source/dmapper/GraphicImport.cxx | 27 ++ 1 file changed, 19 insertions(+), 8 deletions(-) New commits: commit 4f93234639101fd018aba3f6e6f091f0470e0407 Author: Regina Henschel AuthorDate: Fri Jul 16 02:09:10 2021 +0200 Commit: Miklos Vajna

[Libreoffice-commits] core.git: sw/qa sw/source writerfilter/source

insertions(+), 16 deletions(-) New commits: commit af99c01570adc0c9205e1650d10866f80bb8118a Author: Regina Henschel AuthorDate: Mon Jul 5 22:21:23 2021 +0200 Commit: Miklos Vajna CommitDate: Wed Jul 14 11:34:43 2021 +0200 tdf#143219 improve docx import/export of contour wrap

[Libreoffice-commits] core.git: Branch 'libreoffice-7-2' - oox/qa oox/source sw/qa

/shapes.cxx| 17 sw/qa/extras/ooxmlexport/ooxmlexport6.cxx | 11 +-- 6 files changed, 91 insertions(+), 6 deletions(-) New commits: commit d9cee5d4f71a6484dce650ea8dd8195debe7b343 Author: Regina Henschel AuthorDate: Sun Jul 11 15:31:58 2021

[Libreoffice-commits] core.git: oox/qa oox/source sw/qa

/shapes.cxx| 17 sw/qa/extras/ooxmlexport/ooxmlexport6.cxx | 13 +-- 6 files changed, 91 insertions(+), 8 deletions(-) New commits: commit b33634a5c07c8f7032967d8e939100a50e0152ae Author: Regina Henschel AuthorDate: Sun Jul 11 15:31:58 2021

[Libreoffice-commits] core.git: writerfilter/qa writerfilter/source

72541a46aa26194b751785cd56185c8d3db0c9e9 Author: Regina Henschel AuthorDate: Tue Jul 6 00:03:25 2021 +0200 Commit: Regina Henschel CommitDate: Tue Jul 6 14:02:15 2021 +0200 tdf#143208 set property ContourOutside in docx import The property value was correctly read from wrapTight

[Libreoffice-commits] core.git: sw/source

sw/source/filter/ww8/docxsdrexport.cxx |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) New commits: commit 4d2e44104d0d08f0efab9a51f4561ab42316 Author: Regina Henschel AuthorDate: Fri Jul 2 16:35:25 2021 +0200 Commit: Regina Henschel CommitDate: Fri Jul 2 20:38:24

[Libreoffice-commits] core.git: sw/qa sw/source

commits: commit a020f2c3993fd8b625cee07ed73949982e719fca Author: Regina Henschel AuthorDate: Thu Jul 1 22:05:48 2021 +0200 Commit: Regina Henschel CommitDate: Fri Jul 2 10:16:58 2021 +0200 tdf#123569 correct position of rotated Writer image Error was, that the position

Re: Review of 'Improve wrap margins in docx filters'

Hi Miklos, thank you for looking at it. Kind regards Regina Miklos Vajna schrieb am 28.06.2021 um 09:52: Hi Regina, On Wed, Jun 16, 2021 at 06:55:47PM +0200, Regina Henschel wrote: this is about patch https://gerrit.libreoffice.org/c/core/+/115668 From my point of view, the patch is now

[Libreoffice-commits] core.git: oox/source sw/qa sw/source writerfilter/qa writerfilter/source

| 2 18 files changed, 671 insertions(+), 247 deletions(-) New commits: commit 3262fc5ef3bde5b158909d11ccb008161ea95519 Author: Regina Henschel AuthorDate: Sat May 15 23:40:34 2021 +0200 Commit: Miklos Vajna CommitDate: Mon Jun 28 09:49:00 2021 +0200 tdf#142304 a.o. Improve

Re: Default set to save like office extension is not working

Hi Ulisses, this is a mailing list for developers, who want to contribute to the code. So it is wrong for your questions. Find the mailing lists for Portuguese at https://wiki.documentfoundation.org/Language/LocalMailingLists#Brazilian_Portuguese Or use an internatinal support channels as

Review of 'Improve wrap margins in docx filters'

Hi Miklos, hi all, this is about patch https://gerrit.libreoffice.org/c/core/+/115668 From my point of view, the patch is now ready. But it is quite big and has deeper changes, so I would appreciate it if you take a look at the patch. There are still parts missing, but they can be added

[Libreoffice-commits] core.git: Branch 'libreoffice-7-2' - oox/source sw/qa

1c0c11defaf6a83870725902825b1931f8ef50e5 Author: Regina Henschel AuthorDate: Tue Jun 15 01:47:44 2021 +0200 Commit: Xisco Fauli CommitDate: Wed Jun 16 09:29:30 2021 +0200 tdf#142361 export: prevent shadow to rotate with shape OOXML has the feature to rotate a shadow together

[Libreoffice-commits] core.git: oox/source sw/qa

58eeec036c3780188feccb0e1a752cfdee90a49b Author: Regina Henschel AuthorDate: Tue Jun 15 01:47:44 2021 +0200 Commit: Regina Henschel CommitDate: Tue Jun 15 18:26:50 2021 +0200 tdf#142361 export: prevent shadow to rotate with shape OOXML has the feature to rotate a shadow together

Re: Problems with unittest testEffectExtentInline

Hi Miklos, Miklos Vajna schrieb am 11.06.2021 um 09:50: Hi Regina, On Thu, Jun 10, 2021 at 03:12:32PM +0200, Regina Henschel wrote: The problem is more general. What should happen, if the Word document contains settings, that cannot (yet) be represented in LibreOffice? That would

Re: Problems with unittest testEffectExtentInline

Hi Miklos, Miklos Vajna schrieb am 10.06.2021 um 09:30: Hi Regina, On Wed, Jun 09, 2021 at 03:33:59PM +0200, Regina Henschel wrote: I'm currently working on https://gerrit.libreoffice.org/c/core/+/115668 WIP improve wrap margins in docx filters My current state is, that distances needed

Problems with unittest testEffectExtentInline

Hi Miklos, hi all, I'm currently working on https://gerrit.libreoffice.org/c/core/+/115668 WIP improve wrap margins in docx filters My current state is, that distances needed for shadow and glow, for rotation and for fat stroke/border are read from docx, and they are written to docx from docx

Re: SdrObject from SwFrameFormat

Hi Miklos, Miklos Vajna schrieb am 02.06.2021 um 08:53: Hi Regina, On Wed, Jun 02, 2021 at 12:48:59AM +0200, Regina Henschel wrote: in DocxSdrExport::startDMLAnchorInline() in sw/source/filter/ww8/docxsdrexport.cxx I can get the SdrObject of an object with SdrObject* pObject = pFrameFormat

SdrObject from SwFrameFormat

Hi all, in DocxSdrExport::startDMLAnchorInline() in sw/source/filter/ww8/docxsdrexport.cxx I can get the SdrObject of an object with SdrObject* pObject = pFrameFormat->FindRealSdrObject(); Do you know a Scenario, when pObject does not exist when startDMLAnchorInline() is used? Kind regards

[Libreoffice-commits] core.git: Branch 'libreoffice-7-1' - oox/qa oox/source

0cc664f82535eb33b811e23fa3229b10f2c2bf95 Author: Regina Henschel AuthorDate: Mon May 24 23:25:58 2021 +0200 Commit: Xisco Fauli CommitDate: Tue May 25 14:15:47 2021 +0200 tdf#137314 apply conversion from vml angle unit 'fd' Fixes wrong rotation in tdf#109129 and tdf#142432 too, but they have

[Libreoffice-commits] core.git: oox/qa oox/source

a312837a1a4d0b9628d5c587c8ab5ec68179a051 Author: Regina Henschel AuthorDate: Mon May 24 23:25:58 2021 +0200 Commit: Regina Henschel CommitDate: Tue May 25 11:22:41 2021 +0200 tdf#137314 apply conversion from vml angle unit 'fd' Fixes wrong rotation in tdf#109129 and tdf#142432 too

Intended behavior for wrap "parallel" for custom shapes?

Hi all, this is a question about correct way of wrap around a shape. The question is connected to bug 142305 "FILEOPEN DOCX wrap is tight in LibreOffice but not in Word". Take a text, insert a custom shape "Circle Pie", and set the wrap mode to "Parallel". Make sure, "Contour" is off. The

Re: Trouble with unittests testDmlTextshape and testDmlTextshapeB

reas and the general direction is correct. Kind regards Regina Miklos Vajna schrieb am 17.05.2021 um 09:28: Hi Regina, On Sun, May 16, 2021 at 08:03:18PM +0200, Regina Henschel wrote: May I remove the positioning parts from these unittests? If the test fails and your manual testing confirms

[Libreoffice-commits] core.git: Branch 'libreoffice-7-1' - include/oox oox/qa oox/source

deletions(-) New commits: commit ac0eb504a38321849b854889598a28d0687196ea Author: Regina Henschel AuthorDate: Mon May 10 00:47:13 2021 +0200 Commit: Xisco Fauli CommitDate: Mon May 17 21:02:27 2021 +0200 tdf#141463 avoid skew in shape group in ooxml import .. and implement

Trouble with unittests testDmlTextshape and testDmlTextshapeB

Hi all, I'm currently working on improving the import of group shapes in docx, see https://gerrit.libreoffice.org/c/core/+/115668 In that the unittests testDmlTextshape and testDmlTextshapeB in sw/qa/extras/ooxmlexport/ooxmlexport6.cxx fail. But I think, the problem is not my patch but an

[Libreoffice-commits] core.git: include/oox oox/qa oox/source

deletions(-) New commits: commit 36499d8bf6cd5c6af7b2ceb6071baf5c7421bd0a Author: Regina Henschel AuthorDate: Mon May 10 00:47:13 2021 +0200 Commit: Miklos Vajna CommitDate: Tue May 11 17:19:34 2021 +0200 tdf#141463 avoid skew in shape group in ooxml import .. and implement

[Libreoffice-commits] core.git: Branch 'libreoffice-7-1' - oox/source sw/qa writerfilter/qa writerfilter/source

(-) New commits: commit e72b36434dc299d0fb3ecc97045fbb9ca2b9abf8 Author: Regina Henschel AuthorDate: Sun Apr 11 13:03:27 2021 +0200 Commit: Xisco Fauli CommitDate: Fri May 7 00:07:54 2021 +0200 tdf#141540 fix docx import of group or line with rotation ... and fix case wrap

Re: Parameter for addShape for a child of a group in oox import

Hi Miklos, answer below. Miklos Vajna schrieb am 03.05.2021 um 15:47: Hi Regina, On Fri, Apr 30, 2021 at 04:39:41PM +0200, Regina Henschel wrote: So I still need a way to transport the values from the group to its children. Besides my first idea to put all group infos into a struct and use

Re: Parameter for addShape for a child of a group in oox import

Hi Miklos, Miklos Vajna schrieb am 30.04.2021 um 10:19: Hi Regina, On Thu, Apr 29, 2021 at 11:03:14AM +0200, Regina Henschel wrote: Overnight, I found a much easier way. I only need to apply the rotation of the child shape around its center after applying the parent transformation. Please

Re: [Solved] Parameter for addShape for a child of a group in oox import

Hi all, Overnight, I found a much easier way. I only need to apply the rotation of the child shape around its center after applying the parent transformation. Please excuse me for bothering you with this problem. Kind regards Regina ___

Parameter for addShape for a child of a group in oox import

Hi all, if a child shape in a group is rotated, then it is currently imported wrongly. The visual effect of the wrong import is, that the shape might be skewed. The correct behavior would be: 1. Build transformation matrix Mg for the unrotated group shape. Would use "off" and "ext" from

Re: Gradient background for Calc cells

Hi, I would like to point out that the current ODF 1.3 file format does neither allow gradients for cells nor for complete tables. Therefore, whoever wants to implement gradients must -ideally before implementation- develop a concept of how the file format can be extended in a meaningful

Re: Playing ping pong with ODF version; does it pose a danger to the end user.

Hi Drew, Drew Jensen schrieb am 22.04.2021 um 18:59: Howdy, Recently I exchanged a few documents between a number of ODF editors: LO 7.1 (all documents were created here with default settings) Google Docs Microsoft Office 365 Apache OpenOffice In the case of all Google and MSO the files open

[Libreoffice-commits] core.git: oox/source sw/qa writerfilter/qa writerfilter/source

(-) New commits: commit 2a70cfb09c4d89154d229b6a95cf076e8bd76798 Author: Regina Henschel AuthorDate: Sun Apr 11 13:03:27 2021 +0200 Commit: Miklos Vajna CommitDate: Thu Apr 22 10:12:32 2021 +0200 tdf#141540 fix docx import of group or line with rotation ... and fix case wrap

Re: Fix docx import of wrap 'Square' for groups

eded for Writer. Impress uses the same resulting shape from oox without any scaling. Nevertheless I suggest to use the patch unless someone has concerns. Kind regards Regina Miklos Vajna schrieb am 16.04.2021 um 09:31: Hi Regina, On Fri, Apr 16, 2021 at 12:42:28AM +0200, Regina Henschel wrot

Fix docx import of wrap 'Square' for groups

Hi Miklos (and you all), I write to you (list in CC) because you are often working in that area. I cannot continue my actual "3D extrusion" project because groups are being imported to Writer incorrectly. So I have tried to fix the import. The current state is in

[Libreoffice-commits] core.git: svx/qa xmloff/source

dev/null |binary svx/qa/unit/customshapes.cxx | 18 -- xmloff/source/draw/ximpcustomshape.cxx |9 - 3 files changed, 27 deletions(-) New commits: commit f1b55d3f8e963069fc798bcf559ae9af2bf18b64 Author: Regina Henschel

C++ help needed for table with constant values

Hi all, I'm currently working on import of MS 3D effects. For that I need a table of the property values, which are included in the camera presets of OOXML, and their corresponding property values in LO. The current state is in https://gerrit.libreoffice.org/c/core/+/113445 I have

[Libreoffice-commits] core.git: Branch 'libreoffice-7-1' - svx/qa xmloff/source

Author: Regina Henschel AuthorDate: Sat Mar 20 20:05:19 2021 +0100 Commit: Xisco Fauli CommitDate: Tue Mar 23 11:24:39 2021 +0100 tdf#141127 Use ODF default values for draw:extrusion-skew The default value for extrusion skew angle is 45 in ODF and -135 in binary MS Office

[Libreoffice-commits] core.git: svx/qa xmloff/source

Author: Regina Henschel AuthorDate: Sat Mar 20 20:05:19 2021 +0100 Commit: Regina Henschel CommitDate: Mon Mar 22 19:08:27 2021 +0100 tdf#141127 Use ODF default values for draw:extrusion-skew The default value for extrusion skew angle is 45 in ODF and -135 in binary MS

Re: oox import/export of custom shape extrusion

Hi Miklos, Miklos Vajna schrieb am 19.03.2021 um 14:36: Hi Regina, On Fri, Mar 19, 2021 at 02:20:54PM +0100, Regina Henschel wrote: It would indeed make the structure much easier, if only the situations "no grabBag" and "only grabBag" need to be handled. So that is f

Re: oox import/export of custom shape extrusion

Hi Miklos, Miklos Vajna schrieb am 19.03.2021 um 08:18: Hi Regina, On Thu, Mar 18, 2021 at 04:24:38PM +0100, Regina Henschel wrote: I want to work on getting oox import/export of custom shape extrusion. Great, much appreciated. In case a grabBag exists, it will be necessary to merge

oox import/export of custom shape extrusion

Hi all, I want to work on getting oox import/export of custom shape extrusion. In this context I have two questions: (A) In case a grabBag exists, it will be necessary to merge values from the internal "extrusion" property with values from the grabBag on export. In case no grabBag exists,

[Libreoffice-commits] core.git: Branch 'libreoffice-7-1' - svx/CppunitTest_svx_unit.mk svx/qa svx/source

(-) New commits: commit 8eb4bf3b4d94413cb6f10fecc878829f5d1995ec Author: Regina Henschel AuthorDate: Sun Mar 14 16:26:22 2021 +0100 Commit: Xisco Fauli CommitDate: Wed Mar 17 21:09:35 2021 +0100 tdf#141021 Correct sign in Origin in Extrusion North This is about customs shapes

[Libreoffice-commits] core.git: svx/CppunitTest_svx_unit.mk svx/qa svx/source

(-) New commits: commit fa8d00560bbfededec7f2c328f04eb2b369c00e2 Author: Regina Henschel AuthorDate: Sun Mar 14 16:26:22 2021 +0100 Commit: Regina Henschel CommitDate: Wed Mar 17 00:06:57 2021 +0100 tdf#141021 Correct sign in Origin in Extrusion North This is about customs shapes

Re: [Solved] Need help for unit test

Regina Henschel schrieb am 16.03.2021 um 02:58: Hi all, and again I need help for making a unit test. My idea for unit test for https://gerrit.libreoffice.org/c/core/+/112474 is to load a document with a custom shape in 3D mode. It has extrusion direction "Extrusion Backwards", w

Need help for unit test

Hi all, and again I need help for making a unit test. My idea for unit test for https://gerrit.libreoffice.org/c/core/+/112474 is to load a document with a custom shape in 3D mode. It has extrusion direction "Extrusion Backwards", which means, that no side faces are visible. Then I want let

Re: logerrit date: unknown option -- v

:45, Regina Henschel wrote: after   ./logerrit submit master I get the message   date: unknown option -- v Submit was successful nevertheless. It is related to 69959235c3094b811406f734e863a63fc61046c0 and 3646ab583736e6d5e2b3fb4d51857b4b6b777b45. Please check if https://git.libreoffice.org

logerrit date: unknown option -- v

Hi all, after ./logerrit submit master I get the message date: unknown option -- v Submit was successful nevertheless. Kind regards Regina ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

[Libreoffice-commits] core.git: Branch 'libreoffice-7-1' - oox/source sd/qa

files changed, 64 insertions(+) New commits: commit d1026ad7ad1562235b328bb5be2e00ceabd09475 Author: Regina Henschel AuthorDate: Mon Mar 8 17:28:27 2021 +0100 Commit: Xisco Fauli CommitDate: Thu Mar 11 11:03:21 2021 +0100 tdf#140865 roundtrip pptx wordart 3D, add sp3d

[Libreoffice-commits] core.git: oox/source sd/qa

files changed, 64 insertions(+) New commits: commit dbbb8cafcb801638bde3b21796eaebfc807acbdc Author: Regina Henschel AuthorDate: Mon Mar 8 17:28:27 2021 +0100 Commit: Regina Henschel CommitDate: Wed Mar 10 12:33:38 2021 +0100 tdf#140865 roundtrip pptx wordart 3D, add sp3d

Bug 140865 - FILEOPEN FILESAVE PPTX: Wordart 3D is lost on round trip

Hi all, I have a fix for it in https://gerrit.libreoffice.org/c/core/+/112185 But I'm not (yet) familiar with oox, so I would appreciate, if someone of you oox experts would have a look at it. Kind regards Regina ___ LibreOffice mailing list

Re: Integer overflow in Calc lcl_getSingleCellAddressFromXMLString nColumn computation

/03/2021 20:18, Regina Henschel wrote: Your problem with table:cell-range-address="PivotChart" might be related to bug https://bugs.documentfoundation.org/show_bug.cgi?id=112783 "PIVOT CHARTS: Save produces invalid file because of invalid cell address" Ah, thanks, that's a

Re: Integer overflow in Calc lcl_getSingleCellAddressFromXMLString nColumn computation

Hi Stephan, Your problem with table:cell-range-address="PivotChart" might be related to bug https://bugs.documentfoundation.org/show_bug.cgi?id=112783 "PIVOT CHARTS: Save produces invalid file because of invalid cell address" Kind regards Regina Stephan Bergmann schrieb am 08.03.2021 um

[Libreoffice-commits] core.git: Branch 'libreoffice-7-1' - sc/qa sc/source

: Regina Henschel AuthorDate: Tue Feb 23 21:39:00 2021 +0100 Commit: Adolfo Jayme Barrientos CommitDate: Wed Mar 3 09:22:19 2021 +0100 tdf#139763 set anchor type in meEditAs in all cases OOXML specifies a shape anchor type with xdr:absoluteAnchor and xdr:oneCellAnchor

[Libreoffice-commits] core.git: sc/qa sc/source

: Regina Henschel AuthorDate: Tue Feb 23 21:39:00 2021 +0100 Commit: Regina Henschel CommitDate: Wed Feb 24 00:40:15 2021 +0100 tdf#139763 set anchor type in meEditAs in all cases OOXML specifies a shape anchor type with xdr:absoluteAnchor and xdr:oneCellAnchor

Re: Inserting shapes in unittests

Hi Xisco, Xisco Fauli schrieb am 17.02.2021 um 15:49: Hello, Is there any reason why inserting shapes doesn't work in CppUnittests ? I got shapes inserted in Calc in scshapetest.cxx. See around #225, #322, #277, #503, #686, #746. There are different methods used. But I don't know whether

Re: problem with link error in unit test

Hi Noel, thank you for the help. It works now. Kind regards Regina Noel Grandin schrieb am 16.02.2021 um 08:37: On 2021/02/16 12:22 am, Regina Henschel wrote: Hi Noel, my local build on Windows 10 with VS2019 works, but gerrit_mac and gerrit_android_x86_64 complain. https

Re: [Solved] Unit test, with inserting a control?

Hi all, it is solved now. Solution is in https://gerrit.libreoffice.org/c/core/+/110959 Main idea is, to use the Dispatcher to bring ScTabView in "draw a push button" state and then use the MouseButtonDown, MouseMove and MouseButtonUp methods of FuConstUnoControl to actually draw the push

[Libreoffice-commits] core.git: sc/qa sc/source

: Regina Henschel AuthorDate: Mon Feb 15 22:07:41 2021 +0100 Commit: Regina Henschel CommitDate: Tue Feb 16 21:38:01 2021 +0100 tdf#140252 unit test Controls in Calc are always on layer 'controls' This is the missing unit test for the case of drag-created controls in the fix

Re: problem with link error in unit test

Hi Noel, my local build on Windows 10 with VS2019 works, but gerrit_mac and gerrit_android_x86_64 complain. https://gerrit.libreoffice.org/c/core/+/110959 I still need help. Kind regards Regina Noel Grandin schrieb am 14.02.2021 um 06:52: Hi You will need to annotate those methods with

Re: problem with link error in unit test

Hi Noel, Noel Grandin schrieb am 14.02.2021 um 06:52: Hi You will need to annotate those methods with SC_DLLPUBLIC to make them visible to the unit tests OK. That solves the link problem. But I wonder, why it is needed for FuConstUnoControl and not needed for FuConstCustomShape. Kind

problem with link error in unit test

Hi all, I have added a unit test ScShapeTest::testTdf134355_DragCreateCustomShape() in /sc/qa/unit/scshapetest.cxx https://git.libreoffice.org/core/+/02e4f6c44295004f5c7201a7aa2744fd0518ba9d Now I want to do the same with a form control. But I get link errors 'unresolved external symbol' about

Re: Unit test, with inserting a control?

Regina Xisco Fauli schrieb am 10.02.2021 um 22:03: Hi Regina, I see the patch contains a unittest. Could you eventually find a way to test it or do you also want to test something else ? Cheers On 9/2/21 15:11, Regina Henschel wrote: Hi all, this is about https://gerrit.libreoffice.org/c/core

[Libreoffice-commits] core.git: sc/CppunitTest_sc_shapetest.mk sc/qa sc/source

02e4f6c44295004f5c7201a7aa2744fd0518ba9d Author: Regina Henschel AuthorDate: Thu Feb 11 13:37:27 2021 +0100 Commit: Regina Henschel CommitDate: Sat Feb 13 18:11:44 2021 +0100 tdf#134355 custom shapes are never on layer 'controls' in Calc Custom shapes were erroneously put on layer 'controls' when drag

Re: Unit test, with inserting a control?

Hi Xisco, Regina Henschel schrieb am 11.02.2021 um 18:58: Hi Xisco, Regina Henschel schrieb am 10.02.2021 um 22:36: There will be the same problem in my upcoming fix for tdf#134355. There I will need to drag-create a custom-shape. And I have no idea, how to make a drag-create in a cppunit

Re: Unit test, with inserting a control?

Hi Xisco, Regina Henschel schrieb am 10.02.2021 um 22:36: There will be the same problem in my upcoming fix for tdf#134355. There I will need to drag-create a custom-shape. And I have no idea, how to make a drag-create in a cppunit test. The patch for tdf#134355 is now in https

Re: Unit test, with inserting a control?

want to get. Kind regards Regina On 9/2/21 15:11, Regina Henschel wrote: Hi all, this is about https://gerrit.libreoffice.org/c/core/+/110636, a fix for Bug 140252 - Form control is not in front of other shapes I would need to make a test with this: 1. Open toolbar "Form controls".

Re: Overview about items in settings.xml ?

Hi Micheal, Michael Stahl schrieb am 10.02.2021 um 21:09: On 10.02.21 20:00, Regina Henschel wrote: Hi all, exists an overview about the items in settings.xml? Problem: I have got a docx document and have converted it to odt. Then I start a new document and import all styles from

Overview about items in settings.xml ?

Hi all, exists an overview about the items in settings.xml? Problem: I have got a docx document and have converted it to odt. Then I start a new document and import all styles from the converted one. Then I mark all content from the converted one and copy it to the new one. Despite of

[Libreoffice-commits] core.git: Branch 'libreoffice-7-1' - sc/source

sc/source/core/data/drwlayer.cxx |2 ++ 1 file changed, 2 insertions(+) New commits: commit f21595cb5d9f978e11b23471671f11736c42e99d Author: Regina Henschel AuthorDate: Fri Feb 5 14:15:30 2021 +0100 Commit: Christian Lohmaier CommitDate: Wed Feb 10 14:35:11 2021 +0100 cid

[Libreoffice-commits] core.git: Branch 'libreoffice-7-1' - sc/inc sc/qa sc/source

|2 14 files changed, 374 insertions(+), 69 deletions(-) New commits: commit 7b2999ab91aa6fc6632dd87ca0bc950e5484c35a Author: Regina Henschel AuthorDate: Tue Jan 26 14:28:40 2021 +0100 Commit: Xisco Fauli CommitDate: Wed Feb 10 13:40:33 2021 +0100 tdf#137081, tdf137082 fixes shape

[Libreoffice-commits] core.git: sc/CppunitTest_sc_shapetest.mk sc/qa sc/source

1d53f3709de2956f14db31677b6c461f33843bd9 Author: Regina Henschel AuthorDate: Tue Feb 9 13:42:24 2021 +0100 Commit: Regina Henschel CommitDate: Wed Feb 10 13:14:40 2021 +0100 tdf#140252 Controls in Calc are always on layer 'controls' The ctor of SdDrawLayer had set the name

[Libreoffice-commits] core.git: Branch 'libreoffice-7-1' - sc/qa

sc/qa/unit/scshapetest.cxx | 422 - 1 file changed, 114 insertions(+), 308 deletions(-) New commits: commit 1c9ac8e8bf21832e313626b73c48f71ece1ba538 Author: Regina Henschel AuthorDate: Wed Jan 27 23:31:56 2021 +0100 Commit: Xisco Fauli

Unit test, with inserting a control?

Hi all, this is about https://gerrit.libreoffice.org/c/core/+/110636, a fix for Bug 140252 - Form control is not in front of other shapes I would need to make a test with this: 1. Open toolbar "Form controls". 2. Select a form control, e.g. the push button. 3. Drag create the button control

[Libreoffice-commits] core.git: sc/source

sc/source/core/data/drwlayer.cxx |2 ++ 1 file changed, 2 insertions(+) New commits: commit a0c689e1ad98bf3c47d189b8cc99c9f4bcc41a12 Author: Regina Henschel AuthorDate: Fri Feb 5 14:15:30 2021 +0100 Commit: Regina Henschel CommitDate: Sat Feb 6 02:52:05 2021 +0100 cid#1472783

[Libreoffice-commits] core.git: sc/inc sc/qa sc/source

|2 14 files changed, 375 insertions(+), 69 deletions(-) New commits: commit 65129e0bc5abfe7afc612eb46f1434e627265a7d Author: Regina Henschel AuthorDate: Tue Jan 26 14:28:40 2021 +0100 Commit: Regina Henschel CommitDate: Tue Feb 2 22:06:18 2021 +0100 tdf#137081, tdf137082 fixes

Shapes in RTL sheets

Hi all, since no one answered my question about what behavior is desirable for shapes on right-to-left sheets, I have now implemented it according to my ideas: On saving and loading the shapes are shifted between positive and negative part of the draw page regardless of anchoring type. It

[Libreoffice-commits] core.git: sc/qa

sc/qa/unit/scshapetest.cxx | 422 - 1 file changed, 114 insertions(+), 308 deletions(-) New commits: commit 66013201749df7d5ac5ddaf377a7b3732518a93b Author: Regina Henschel AuthorDate: Wed Jan 27 23:31:56 2021 +0100 Commit: Regina Henschel

Re: [Libreoffice-qa] ESC meeting agenda - Adding topic: Broken release process when fresh become still and when still become EOL'ed

Hi Timur, Timur Gadzo schrieb am 28.01.2021 um 19:56: On Thursday, January 28, 2021, Florian Effenberger mailto:flo...@documentfoundation.org>> wrote: > > William Gathoye (LibreOffice) wrote on 27.01.21 at 18:22: > >> Right now: 6.4 is EOL'ed[4] but it is still advertised on the

Re: Fwd: CppunitTest_sc_shapetest failing after cd966aac6e

Hi, That test has if (!IsDefaultDPI()) return; to skip it for other UI scaling. So it might be something different? Do you have execute the steps of the test in the GUI of running LibreOffice. Is the measure line there correct after loading? The difference in the test is about 2cm

[Libreoffice-commits] core.git: Branch 'libreoffice-7-1' - sc/qa sc/source

: Regina Henschel AuthorDate: Fri Jan 15 17:40:10 2021 +0100 Commit: Xisco Fauli CommitDate: Tue Jan 19 11:45:18 2021 +0100 tdf#139583 fix case rot 180deg for cell anchored shapes Method adjustAnchoredPosition() in ScDrawView::Notify() needs to distinguish whether

[Libreoffice-commits] core.git: Branch 'libreoffice-7-1' - sc/qa sc/source

/xml/xmlexprt.cxx| 104 ++- 5 files changed, 299 insertions(+), 21 deletions(-) New commits: commit ad2184eadafcb92ed196ecea69aa7b67bdefb3fc Author: Regina Henschel AuthorDate: Fri Dec 25 19:27:51 2020 +0100 Commit: Xisco Fauli CommitDate: Mon Jan 18 15:12:37

[Libreoffice-commits] core.git: sc/qa sc/source

: Regina Henschel AuthorDate: Fri Jan 15 17:40:10 2021 +0100 Commit: Regina Henschel CommitDate: Sat Jan 16 15:27:04 2021 +0100 tdf#139583 fix case rot 180deg for cell anchored shapes Method adjustAnchoredPosition() in ScDrawView::Notify() needs to distinguish whether

Jenkins fails with error: undefined reference to 'uscript_getScript_50' ?

Hi all, my patch https://gerrit.libreoffice.org/c/core/+/109386 fails with error message /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/linguistic/source/hhconvdic.cxx:57: error: undefined reference to 'uscript_getScript_50' That is unrelated to my patch. I have

[Libreoffice-commits] core.git: Branch 'libreoffice-7-1' - svx/source

svx/source/svdraw/svdpagv.cxx | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) New commits: commit 6bb252e26ce1aeb3949c64ec6f0bef502a6a459d Author: Regina Henschel AuthorDate: Fri Jan 8 18:26:38 2021 +0100 Commit: Xisco Fauli CommitDate: Thu Jan 14 08:35:36

[Libreoffice-commits] core.git: svx/source

svx/source/svdraw/svdpagv.cxx | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) New commits: commit 7635a475130a0e9e3b0dded853348659d07a00d7 Author: Regina Henschel AuthorDate: Fri Jan 8 18:26:38 2021 +0100 Commit: Regina Henschel CommitDate: Tue Jan 12 14:07

Re: How to test draw page grid lines?

n->GetBitmapEx(aEmptyPoint, pActiveWin->GetOutputSizePixel())); then I get a entire black bitmap. Does really nobody have an idea? Otherwise I will commit the patch without unit test. Kind regards Regina Regina Henschel schrieb am 08.01.2021 um 18:52: Hi all, I have a fix for bug "Gr

How to test draw page grid lines?

Hi all, I have a fix for bug "Grid does not work in RTL sheet" [https://bugs.documentfoundation.org/show_bug.cgi?id=137083] [https://gerrit.libreoffice.org/c/core/+/108989] But I have no idea how to test it. Error was, that the coordinates of the grid lines were wrongly calculated and so the

Problems with shapes on right-to-left sheets

Hi all, I'm investigating problems with shapes on right-to-left sheets. Currently we have; Save and reload of shapes on right-to-left sheets: (A1) cell anchored: shape keeps its orientation (A2) page anchored: shape is horizontal mirrored Toggle between right-to-left and left-to-right (menu

Re: understanding ImpForceLineAngle, aGeo and friends

Hi David, Dr. David Alan Gilbert schrieb am 02.01.2021 um 04:35: Hi, I'd appreciate some pointers on shape creation and in particular why ImpForceLineAngle exists. ImpForceLineAngle() exists from the beginning. I see it already in OOo1.1.5. You will find it as ImpForceLineWink() in the

Trouble with testTdf137576_LogicRectInDefaultMeasureline

Hi all, sc/qa/unit/scshapetest.cxx(145) had failed in testTdf137576_LogicRectInDefaultMeasureline on Mac. Caolán has disabled it for Mac with 5c6139ac36134a21345525c21e167a356b0892b9. Thank you, Caolán. But Mike Kaganski gets failures too on Windows, see discussion in

[Libreoffice-commits] core.git: sc/qa sc/source

/xml/xmlexprt.cxx| 104 ++- 5 files changed, 290 insertions(+), 21 deletions(-) New commits: commit cd966aac6ecd8ce606ac3f2ccd602e467114ba3f Author: Regina Henschel AuthorDate: Fri Dec 25 19:27:51 2020 +0100 Commit: Regina Henschel CommitDate: Mon Dec 28 15:05

Mirror shape on right-to-left sheet?

Hi all, Start Calc and set the sheet to right-to-left (complex text layout enabled, menu Format). Insert left-to-right arrow, one cell anchored, another page anchored. Save to .ods and open archive. Examine element draw:enhanced-geometry. There is no attribute 'draw:mirror-horizontal' which

[Libreoffice-commits] core.git: Branch 'libreoffice-7-1' - svx/qa svx/source

c6bc280fa986bac1b62726a4a19fd0be1c735fc0 Author: Regina Henschel AuthorDate: Tue Dec 15 20:20:55 2020 +0100 Commit: Xisco Fauli CommitDate: Thu Dec 17 11:16:38 2020 +0100 tdf#138945 update fObjectRotation for NbcResize SdrObjCustomShape::NbcResize uses the inherited SdrTextObj::NbcResize. But a SdrTextObj

[Libreoffice-commits] core.git: svx/qa svx/source

d4ca360f6632f03e9fb7e9af37aac40d23f1249a Author: Regina Henschel AuthorDate: Tue Dec 15 20:20:55 2020 +0100 Commit: Regina Henschel CommitDate: Wed Dec 16 13:59:14 2020 +0100 tdf#138945 update fObjectRotation for NbcResize SdrObjCustomShape::NbcResize uses the inherited SdrTextObj::NbcResize

Re: LO calc formulas

Hi Dante, the methods for the Calc functions are in files interpr*.cxx and interpre.hxx. Most methods are named kind ScFoo, ScSum for example. They do outer things like checking, that parameters are valid. From there you will easily find the calculating algorithm, often a local method. I

[Libreoffice-commits] core.git: Branch 'libreoffice-7-1' - vcl/win

vcl/win/gdi/gdiimpl.cxx | 35 +++ 1 file changed, 31 insertions(+), 4 deletions(-) New commits: commit d41d6768a17c65460565265f41a590f8e6982ad9 Author: Regina Henschel AuthorDate: Thu Dec 3 23:53:43 2020 +0100 Commit: Xisco Fauli CommitDate: Wed Dec 9

Re: Math/Formula visual editing

Hi Peter, LibreOffice has an in-line formula editor. But no one has improved it in the last seven years, so it is still an "experimental feature". You are welcome to bring it to the regular UI. With this editor you write the formula directly into the main window and the markup is

<    1   2   3   4   5   6   7   8   9   10   >