[Libreoffice-commits] core.git: vcl/win

2020-12-03 Thread Regina Henschel (via logerrit)
vcl/win/gdi/gdiimpl.cxx | 35 +++ 1 file changed, 31 insertions(+), 4 deletions(-) New commits: commit 24d770799660d3ec94ee7add435645794426042b Author: Regina Henschel AuthorDate: Thu Dec 3 23:53:43 2020 +0100 Commit: Noel Grandin CommitDate: Fri Dec 4

Re: how does arithmetic exactly work in Calc?

2020-12-03 Thread Regina Henschel
Hi Michel, for example look for ScAdd in https://opengrok.libreoffice.org/xref/core/sc/source/core/tool/interpr5.cxx and for the rtl::math things in https://opengrok.libreoffice.org/xref/core/include/rtl/math.hxx Kind regards Regina Michel Onoff schrieb am 03-Dec-20 um 13:48: Hi, I would

[Libreoffice-commits] core.git: Branch 'libreoffice-7-1' - sc/qa sc/source

2020-12-03 Thread Regina Henschel (via logerrit)
9706790b1e4d34d0fac5eb10a51770f9d62f802c Author: Regina Henschel AuthorDate: Tue Dec 1 00:05:43 2020 +0100 Commit: Xisco Fauli CommitDate: Thu Dec 3 10:18:06 2020 +0100 tdf#137576 Improve cell anchored measure line in Calc Measure lines do not always have a logic rectangle. It might be empty

[Libreoffice-commits] core.git: sc/qa sc/source

2020-12-02 Thread Regina Henschel (via logerrit)
d0921aa753c43600272865602df3c7c2a8f13196 Author: Regina Henschel AuthorDate: Tue Dec 1 00:05:43 2020 +0100 Commit: Regina Henschel CommitDate: Wed Dec 2 19:06:43 2020 +0100 tdf#137576 Improve cell anchored measure line in Calc Measure lines do not always have a logic rectangle. It might be empty

Re: Trouble with SdrMeasureObj (dimension line)

2020-12-01 Thread Regina Henschel
Hi Miklos, hi all, Regina Henschel schrieb am 20-Nov-20 um 11:46: Hi Miklos, Miklos Vajna schrieb am 19-Nov-20 um 09:22: Hi Regina, On Wed, Nov 18, 2020 at 11:56:01PM +0100, Regina Henschel wrote: Do you know examples for unit tests with "drag create" and for unit tests wi

Re: FastSaxParser ans XFastParser

2020-11-26 Thread Regina Henschel
Dante Doménech schrieb am 26-Nov-20 um 23:37: Hello. I'm sorry for asking stuff like this, but I'm not a full fledged developer and stuff like this is quite hard for me. Starmath mathml is supposed to use FastSaxParser (or I understand that). At least changes on FastSaxParserImpl will have

Re: Mathml XMLReader (starmath module)

2020-11-23 Thread Regina Henschel
Hi Dante, Dante Doménech schrieb am 22-Nov-20 um 15:27: Hello. I'm trying to add support for in mathml. The reason why actually isn't supported is because mathml is being loaded as XML. It is similar, but it isn't. That is why when XmlReader finds a mathml particular , it will throw an

Re: Trouble with SdrMeasureObj (dimension line)

2020-11-20 Thread Regina Henschel
Hi Miklos, Miklos Vajna schrieb am 19-Nov-20 um 09:22: Hi Regina, On Wed, Nov 18, 2020 at 11:56:01PM +0100, Regina Henschel wrote: Do you know examples for unit tests with "drag create" and for unit tests with "create default objects"? I'm not sure we have such tests.

[Libreoffice-commits] core.git: sc/qa sc/source

2020-11-20 Thread Regina Henschel (via logerrit)
bba0cd79984875124f8d43d05d4cdb7f63517e77 Author: Regina Henschel AuthorDate: Thu Nov 19 21:16:33 2020 +0100 Commit: Regina Henschel CommitDate: Fri Nov 20 10:17:17 2020 +0100 Replace matrix translate with object Move TR*BaseGeometry is faulty for SdrMeasureObj, fixing these methods is a larger

Trouble with SdrMeasureObj (dimension line)

2020-11-18 Thread Regina Henschel
Hi all, I have wondered why a SdrMeasureObj, which is anchored "to cell (resize with cell), does not work in Calc (e.g. tdf#137576). Problems detected so far: (A) TRGetBaseGeometry does not include a rotation angle. So a chain of TRGetBaseGeometry followed by TRSetBaseGeometry does not work.

[Libreoffice-commits] core.git: sc/qa sc/source

2020-11-15 Thread Regina Henschel (via logerrit)
Author: Regina Henschel AuthorDate: Fri Nov 13 18:29:20 2020 +0100 Commit: Regina Henschel CommitDate: Sun Nov 15 09:04:14 2020 +0100 Avoid changing anchor on visibility change of cell This is an addition to commit 1f0b3c7a40edfa81bbc7a58d123a6a2dfd83e4ca The following

[Libreoffice-commits] core.git: sc/qa

2020-11-13 Thread Regina Henschel (via logerrit)
sc/qa/unit/subsequent_filters-test.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 6532bdc0a27eb31dcacf02e3bb1a587270a48b6f Author: Regina Henschel AuthorDate: Fri Nov 13 01:15:04 2020 +0100 Commit: Mike Kaganski CommitDate: Fri Nov 13 11:15:51 2020

make sc.check fails in subsequent_filters-test in ScFiltersTest::testPreviewMissingObjLink()

2020-11-12 Thread Regina Henschel
Hi all, A "make sc.check" fails for me in current master in subsequent_filters-test in ScFiltersTest::testPreviewMissingObjLink() Line: CPPUNIT_ASSERT_MESSAGE("the ole object links to a missing file, but we should retain its preview", pGraphic); Some days ago, it had not failed. I use

Re: Problem with /core/sc/qa/unit/helper/qahelper.cxx

2020-11-12 Thread Regina Henschel
Hi Stephan, Stephan Bergmann schrieb am 12-Nov-20 um 21:34: [..] The line #192 is CPPUNIT_ASSERT_EQUAL_MESSAGE("font size should be 10", 200l, aFont.GetFontSize().getHeight()); that "200l" needs to be "tools::Long(200)" now; not sure why that hasn't been fixed yet, please go ahead and

Problem with /core/sc/qa/unit/helper/qahelper.cxx

2020-11-12 Thread Regina Henschel
Hi all, with current master and make sc.check I get the error D:/Build_forCommit/core/sc/qa/unit/helper/qahelper.cxx(192): error C2672: 'CppUnit::assertEquals': no matching overloade d function found D:/Build_forCommit/core/sc/qa/unit/helper/qahelper.cxx(192): error C2782: 'void

[Libreoffice-commits] core.git: sc/qa sc/source

2020-11-12 Thread Regina Henschel (via logerrit)
3238606c8470f3eaeada3fc601e186ec5cfac925 Author: Regina Henschel AuthorDate: Wed Nov 11 21:06:26 2020 +0100 Commit: Regina Henschel CommitDate: Thu Nov 12 13:41:38 2020 +0100 tdf138138 Apply shape shift also to NoRotatedAnchor The 'normal' anchor (as on screen) is connected

[Libreoffice-commits] core.git: sc/qa sc/source

2020-11-10 Thread Regina Henschel (via logerrit)
Author: Regina Henschel AuthorDate: Tue Nov 10 23:37:20 2020 +0100 Commit: Regina Henschel CommitDate: Wed Nov 11 00:20:07 2020 +0100 Correction to improve 'resize with cell' Error: A vertical flipped shape lost flip on loading. The error slipped in, when I have

[Libreoffice-commits] core.git: sc/qa sc/source

2020-11-10 Thread Regina Henschel (via logerrit)
1cb6bb9576871ff5d56c9810ff1791abc3dd64fd Author: Regina Henschel AuthorDate: Sat Nov 7 01:08:53 2020 +0100 Commit: Regina Henschel CommitDate: Tue Nov 10 12:12:43 2020 +0100 tdf#117948 Do not treat hidden rows as zero in ODF export The object geometry in ODF file format has values

[Libreoffice-commits] core.git: sc/qa

2020-11-04 Thread Regina Henschel (via logerrit)
804c1b77f26bd36895c77586ba4fb43a8b84bec8 Author: Regina Henschel AuthorDate: Tue Nov 3 19:51:51 2020 +0100 Commit: Regina Henschel CommitDate: Wed Nov 4 22:16:54 2020 +0100 Unit tests for: Improve 'resize with cell' handling These tests belong to commit

Re: pointer check in unit tests

2020-11-03 Thread Regina Henschel
+0100, Regina Henschel wrote: ScDocShellRef xDocSh = loadDoc("tdf137020_FlipVertical.", FORMAT_ODS); CPPUNIT_ASSERT_MESSAGE("Failed to load tdf137020_FlipVertical.ods", xDocSh.is()); ScDocument& rDoc = xDocSh->GetDocument(); ScDrawLayer* pDrawLayer = rDoc.GetDrawLaye

pointer check in unit tests

2020-11-02 Thread Regina Henschel
Hi all, In a unit test I have often sequences like this: ScDocShellRef xDocSh = loadDoc("tdf137020_FlipVertical.", FORMAT_ODS); CPPUNIT_ASSERT_MESSAGE("Failed to load tdf137020_FlipVertical.ods", xDocSh.is()); ScDocument& rDoc = xDocSh->GetDocument(); ScDrawLayer* pDrawLayer =

[Libreoffice-commits] core.git: sc/inc sc/qa sc/source test/source

2020-10-31 Thread Regina Henschel (via logerrit)
/xmlimprt.hxx |2 test/source/sheet/xsheetannotationshapesupplier.cxx |2 11 files changed, 362 insertions(+), 109 deletions(-) New commits: commit 1f0b3c7a40edfa81bbc7a58d123a6a2dfd83e4ca Author: Regina Henschel AuthorDate: Sat Oct 10 17:55:31 2020 +0200 Commit

Improve 'resize with cell'

2020-10-28 Thread Regina Henschel
Hi all, I want to change the way 'resize with cell' is handled, because the current way causes a lot of bugs. My intended patch is in https://gerrit.libreoffice.org/c/core/+/104643 A review would be nice. Especially - Do you agree with the changes in principle? - Do you see any problem,

Re: error detected by loplugin:staticaccess

2020-10-26 Thread Regina Henschel
Hallo Mike, hallo Caolán, thank you for helping me. Kind regards Regina Mike Kaganski schrieb am 25-Oct-20 um 17:03: Hi Regina, On 25.10.2020 17:12, Regina Henschel wrote: Hi all, I got an error in https://gerrit.libreoffice.org/c/core/+/104643 But I do not know, how to write it correctly

error detected by loplugin:staticaccess

2020-10-25 Thread Regina Henschel
Hi all, I got an error in https://gerrit.libreoffice.org/c/core/+/104643 But I do not know, how to write it correctly. Can you please help me? The other compilers are fine, with the way I have written it. Kind regards Regina ___ LibreOffice mailing

Re: Where are Calc functions implemented in libreoffce?

2020-10-22 Thread Regina Henschel
Hi Emmertt, you mean functions like LINEST or GCD? They belong to class ScInterpreter. You might have a look at https://wiki.openoffice.org/wiki/Hacking_Calc_-_The_First_Step and the very good guide written by Eike https://wiki.openoffice.org/wiki/Calc/Implementation/Spreadsheet_Functions If

[Libreoffice-commits] core.git: Branch 'libreoffice-7-0' - svx/source

2020-10-14 Thread Regina Henschel (via logerrit)
svx/source/svdraw/svdedtv1.cxx |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) New commits: commit f4e4c380c8aa89cedca5ab2aa2006e12461158a7 Author: Regina Henschel AuthorDate: Tue Oct 13 14:44:17 2020 +0200 Commit: Xisco Fauli CommitDate: Wed Oct 14 14:29:31 2020 +0200

Re: How to make a unit test which involves a dialog

2020-10-13 Thread Regina Henschel
the patch if you want to avoid the hassle of switching to Linux and building LibreOffice there. This is a great offer, which I gladly accept. Many thanks for such support. Kind regards Regina Regards On 13/10/20 18:36, Regina Henschel wrote: Hi Xisco, Xisco Fauli schrieb am 13-Oct-20 um 16:43

[Libreoffice-commits] core.git: svx/source

2020-10-13 Thread Regina Henschel (via logerrit)
svx/source/svdraw/svdedtv1.cxx |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) New commits: commit 94e6e140491de31c0788c91af855a75a3bb12709 Author: Regina Henschel AuthorDate: Tue Oct 13 14:44:17 2020 +0200 Commit: Regina Henschel CommitDate: Tue Oct 13 23:01:18 2020

Re: How to make a unit test which involves a dialog

2020-10-13 Thread Regina Henschel
rds Regina Regards On 13/10/20 15:02, Regina Henschel wrote: Hi all, the patch for which I want to make a unit test is in https://gerrit.libreoffice.org/c/core/+/104234 The error is produced, when you set a new width or height for a horizontal or vertical line in the Position dialog in Ca

How to make a unit test which involves a dialog

2020-10-13 Thread Regina Henschel
Hi all, the patch for which I want to make a unit test is in https://gerrit.libreoffice.org/c/core/+/104234 The error is produced, when you set a new width or height for a horizontal or vertical line in the Position dialog in Calc. So how can I use the Position dialog in a unit test? Is it

[Libreoffice-commits] core.git: Branch 'libreoffice-7-0' - svx/qa svx/source

2020-09-29 Thread Regina Henschel (via logerrit)
5e722a79387959195202903469af2138722eddc8 Author: Regina Henschel AuthorDate: Wed Sep 23 19:02:30 2020 +0200 Commit: Xisco Fauli CommitDate: Tue Sep 29 15:56:37 2020 +0200 tdf#136176 Correct update fObjectRotation in NbcShear Change-Id: I4a73a720845436d25fc1a02eb615dad47f17f96d Reviewed-on: https

Questions about ScDrawLayer::RecalcPos

2020-09-26 Thread Regina Henschel
Hi all, I want to fix tdf#137020 "FILEOPEN Vertical flipped, cell anchored shapes have wrong position on opening". The error happens in ScDrawLayer::RecalcPos in sc\source\core\data\drwlayer.cxx. Vertical flipped custom shapes have an additional 180deg rotation, which is not considered when

[Libreoffice-commits] core.git: svx/qa svx/source

2020-09-23 Thread Regina Henschel (via logerrit)
3b4198d4654e4cf569f9b82d87a2498dbbecb9ac Author: Regina Henschel AuthorDate: Wed Sep 23 19:02:30 2020 +0200 Commit: Regina Henschel CommitDate: Wed Sep 23 20:21:03 2020 +0200 tdf#136176 Correct update fObjectRotation in NbcShear Change-Id: I4a73a720845436d25fc1a02eb615dad47f17f96d Reviewed-on: https

[Libreoffice-commits] core.git: chart2/qa xmloff/source

2020-09-19 Thread Regina Henschel (via logerrit)
changed, 235 insertions(+), 31 deletions(-) New commits: commit 6d7a72ab1c044f7e1f30f7c4133dafdb214dfcbf Author: Regina Henschel AuthorDate: Thu Sep 10 14:42:55 2020 +0200 Commit: Regina Henschel CommitDate: Sat Sep 19 14:27:24 2020 +0200 tdf#135366 Save line and fill of data labels

chart data label size

2020-09-18 Thread Regina Henschel
Hi all, seeing all OOXML import trouble with data label position and wrong word wrap caused by wrong label size, wouldn't it be better to introduce a height and width of data labels as properties? All current ersatz by taken some percent from whatever will have examples, where it doesn't

[Libreoffice-commits] core.git: Branch 'libreoffice-7-0' - chart2/CppunitTest_chart2_geometry.mk chart2/Module_chart2.mk chart2/qa chart2/source oox/source

2020-09-15 Thread Regina Henschel (via logerrit)
/chart/objectformatter.cxx | 6 oox/source/export/drawingml.cxx | 23 16 files changed, 435 insertions(+), 20 deletions(-) New commits: commit 2b218729b8332fa2bc8a20480c8ba701e1bca361 Author: Regina Henschel AuthorDate

Bringing line and fill style of data labels to ODF

2020-09-11 Thread Regina Henschel
Hi NISZ LibreOffice Team, hi all, I have started to bring the line and fill properties of data labels to ODF. Currently they are implemented in loext-Attributes in the styles of and . But ODF needs elements and have them as ordinary line and fill attribute in the data label styles. My

[Libreoffice-commits] core.git: chart2/qa xmloff/source

2020-09-05 Thread Regina Henschel (via logerrit)
(+), 80 deletions(-) New commits: commit 87d1ebeb11a00301745ee3c3c03fffb7033ab59d Author: Regina Henschel AuthorDate: Sat Aug 22 23:03:02 2020 +0200 Commit: Regina Henschel CommitDate: Sat Sep 5 17:49:15 2020 +0200 tdf#135366 ODF import of line and fill of data labels LibreOffice

Re: Problems with data labels in charts

2020-08-29 Thread Regina Henschel
Hi Miklos, Miklos Vajna schrieb am 18-Aug-20 um 09:19: Given it's there since 2014, I think there is benefit in not breaking that. I would rather add the remaining missing LabelFoo properties and keep the existing API working than the other way around. Besides missing unit tests, import is

Re: Make constant array accessible from different places

2020-08-28 Thread Regina Henschel
Hi Stephan, thanks. I'll do it as you have suggested. Kind regards Regina Stephan Bergmann schrieb am 28-Aug-20 um 19:16: On 28/08/2020 18:53, Regina Henschel wrote: I have a constant array const std::pair aApiToLabelFooPairs[] = {  {"LineStyle", "LabelBorderS

Make constant array accessible from different places

2020-08-28 Thread Regina Henschel
Hi all, I need some technical help. I have a constant array const std::pair aApiToLabelFooPairs[] = { {"LineStyle", "LabelBorderStyle"}, etc. } for to map draw object fill and line property names to data-label related properties of series and points in a chart on ODF import. I

Re: XML-Questions

2020-08-28 Thread Regina Henschel
Hi Manfred, Manfred Rebentisch schrieb am 28-Aug-20 um 06:45: Why is the "h" separated? T6 is: If I will work on the XML-files directly, I avoid to write officeooo:rsid. That attribute makes the file unnecessary complex. The setting is in Tools > Options > Writer >

Re: Problems with data labels in charts

2020-08-22 Thread Regina Henschel
Hi Miklos, hi all, Miklos Vajna schrieb am 18-Aug-20 um 09:19: Hi Regina, On Mon, Aug 17, 2020 at 08:19:37PM +0200, Regina Henschel wrote: So you suggest to keep the internal structure? That would mean, we will get about 18 additional "LabelFoo" properties over the time for

Re: Problems with data labels in charts

2020-08-17 Thread Regina Henschel
Hi Miklos, Miklos Vajna schrieb am 17-Aug-20 um 10:08: Hi Regina, On Sun, Aug 16, 2020 at 05:27:07PM +0200, Regina Henschel wrote: So there are discrepancies between what LibreOffice writes and reads and what exists in ODF. What to do? Regarding data label fill style, I think Gulsah added

Problems with data labels in charts

2020-08-16 Thread Regina Henschel
Hi all, as far as I understand, we have currently this situation: Graphic properties -- A data label is created as css.drawing.TextShape and as such it can have FillProperties, LineProperties and ShadowProperties. In ODF, a data label is a element and its style can have

Problems with new Writer feature "Page-content-bottom vertical relation "

2020-08-16 Thread Regina Henschel
Hi all, Miklos has brought a proposal to the ODF TC, which is now 'resolved' https://issues.oasis-open.org/browse/OFFICE-4073 (Proposal and resolution are in the issue.) This specifies the bottom edge of the page content area as basis for the alignments "from top", "top", "middle", "bottom"

[Libreoffice-commits] core.git: chart2/qa sd/qa

2020-08-11 Thread Regina Henschel (via logerrit)
/unit/export-tests-ooxml1.cxx | 120 -- 5 files changed, 193 insertions(+), 138 deletions(-) New commits: commit a6704e6dc53d64bc1442d337f7bfb8deb03f4145 Author: Regina Henschel AuthorDate: Mon Aug 10 23:26:54 2020 +0200 Commit: Regina Henschel CommitDate

[Libreoffice-commits] core.git: include/oox oox/source sd/qa

2020-08-09 Thread Regina Henschel (via logerrit)
: Regina Henschel AuthorDate: Mon Jul 27 00:31:04 2020 +0200 Commit: Regina Henschel CommitDate: Sun Aug 9 12:15:54 2020 +0200 tdf#128345 PPTX: add transparence gradient for fill in chart Export cases: Add transparence gradient on solid color fill by treating the color fill

tdf#128345 PPTX: add transparence gradient for fill in chart

2020-08-07 Thread Regina Henschel
Hi all, the patch https://gerrit.libreoffice.org/c/core/+/99464 tdf#128345 PPTX: add transparence gradient for fill in chart brings transparency gradients to charts. It is a follow up to https://gerrit.libreoffice.org/c/core/+/98792 tdf#128345 pptx export: add transparence gradient in

[Libreoffice-commits] core.git: Branch 'libreoffice-7-0' - oox/source sd/qa

2020-08-07 Thread Regina Henschel (via logerrit)
855420811e13d620dd1d0f016ac4f7da9535954c Author: Regina Henschel AuthorDate: Tue Jul 14 22:52:56 2020 +0200 Commit: Miklos Vajna CommitDate: Fri Aug 7 13:44:19 2020 +0200 tdf#128345 pptx export: add transparence gradient in solid fill In case of solid color fill a transparence gradient was not saved

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - oox/source sd/qa

2020-08-07 Thread Regina Henschel (via logerrit)
0ff6f5ad44a5fb9903c9a905d2ec55248ee75315 Author: Regina Henschel AuthorDate: Tue Jul 14 22:52:56 2020 +0200 Commit: Miklos Vajna CommitDate: Fri Aug 7 10:29:11 2020 +0200 tdf#128345 pptx export: add transparence gradient in solid fill In case of solid color fill a transparence gradient was not saved

[Libreoffice-commits] core.git: chart2/CppunitTest_chart2_geometry.mk chart2/Module_chart2.mk chart2/qa chart2/source oox/source

2020-08-06 Thread Regina Henschel (via logerrit)
/chart/objectformatter.cxx | 6 oox/source/export/drawingml.cxx | 23 16 files changed, 435 insertions(+), 20 deletions(-) New commits: commit 74be8bb787a44464957e5d3105c8de6d36e81b4a Author: Regina Henschel AuthorDate

Re: Need help for unit tests

2020-08-04 Thread Regina Henschel
Regina Henschel schrieb am 27-Jul-20 um 01:17: I have seen in https://opengrok.libreoffice.org/xref/core/chart2/qa/extras/chart2import.cxx 2541  Reference xDataPointLabel1(getShapeByName(xShapes, 2542 "CID/MultiClick/CID/D=0:CS=0:CT=0:Series=0:DataLabels=:DataLabel=0"), UNO

Re: Need help for unit tests

2020-07-28 Thread Regina Henschel
Hi Miklos, Miklos Vajna schrieb am 27-Jul-20 um 09:20: Hi Regina, I guess the problem is that static counter in oox/source/export/shapes.cxx:1970 This could be improved to do the same way as the DOCX export does in sw/source/filter/ww8/docxattributeoutput.cxx:5165 i.e. do not have a static

Need help for unit tests

2020-07-26 Thread Regina Henschel
Hi all, I need again help in unit tests. I'm working on https://gerrit.libreoffice.org/c/core/+/99464. That is continuation for https://bugs.documentfoundation.org/show_bug.cgi?id=128345 FILESAVE: PPTX: transparency gradient on solid fill is not considered in export This part is about

[Libreoffice-commits] core.git: oox/source sd/qa

2020-07-22 Thread Regina Henschel (via logerrit)
: commit 51e5afb0042bc6a10f0cd02af5733079b42fa0f7 Author: Regina Henschel AuthorDate: Tue Jul 21 15:46:51 2020 +0200 Commit: Regina Henschel CommitDate: Wed Jul 22 11:54:04 2020 +0200 tdf#134969 Add solid transparence in color gradient Converts a 'FillTransparence' percent value

[Libreoffice-commits] core.git: oox/source sd/qa

2020-07-18 Thread Regina Henschel (via logerrit)
d187f22b7ff73954e1da39fb954c64bc315298cb Author: Regina Henschel AuthorDate: Tue Jul 14 22:52:56 2020 +0200 Commit: Regina Henschel CommitDate: Sat Jul 18 16:29:37 2020 +0200 tdf#128345 pptx export: add transparence gradient in solid fill In case of solid color fill a transparence gradient was not saved

[Libreoffice-commits] core.git: include/oox oox/source sd/qa

2020-07-09 Thread Regina Henschel (via logerrit)
commits: commit 005f5db47b8e1bbd7ebddee92009be072e835fd5 Author: Regina Henschel AuthorDate: Sat Jul 4 15:11:03 2020 +0200 Commit: Thorsten Behrens CommitDate: Fri Jul 10 00:57:22 2020 +0200 tdf#100348 add fill to fontwork in export to pptx This patch adds fill to the characters

Re: Review for gerrit 98187 : tdf#100348 add fill to fontwork in export to pptx

2020-07-08 Thread Regina Henschel
Hi all, hi Thorsten, Regina Henschel schrieb am 07-Jul-20 um 14:48: I know, that unit tests are missing. I have added unit tests. So from my point of view it is finished now. Kind regards Regina ___ LibreOffice mailing list LibreOffice

Review for gerrit 98187 : tdf#100348 add fill to fontwork in export to pptx

2020-07-07 Thread Regina Henschel
Hi all, I have continued to work on Fontwork. It brings fill, outline and effects from LO to pptx. The patch is in https://gerrit.libreoffice.org/c/core/+/98187 It has the following limitations: Not for docx No import Has no solution for character properties like "bold", which are ignored in

Re: Question about class DrawingML

2020-07-01 Thread Regina Henschel
Hi Stephan, thank you. Kind regards Regina Stephan Bergmann schrieb am 01-Jul-20 um 13:43: On 01/07/2020 13:38, Regina Henschel wrote: Is it possible to set a default value for a parameter const css::uno::Reference< css::beans::XPropertySet >& rXShapePropSet   const css::uno:

Re: Question about class DrawingML

2020-07-01 Thread Regina Henschel
Hi, Noel Grandin schrieb am 29-Jun-20 um 18:01: On Mon, 29 Jun 2020 at 13:14, Regina Henschel <mailto:rb.hensc...@t-online.de>> wrote: (1) add a member to class DrawingML (2) extend the parameter lists in the calling chain extending the parameter list is generally a be

Question about class DrawingML

2020-06-29 Thread Regina Henschel
Hi all, I have restart looking how to export fill of a Fontwork-shape to pptx. I know in principle, what has to be done. The problem is, that I need shape properties in DrawingML::WriteRunProperties(). There exists this calling chain in DrawingML: WriteText() -> WriteParagraph() ->

[Libreoffice-commits] core.git: Branch 'libreoffice-7-0' - oox/source sd/qa

2020-06-23 Thread Regina Henschel (via logerrit)
insertions(+), 16 deletions(-) New commits: commit 1cbdc101c72309a97e9ee09c77f4fd36fbd71314 Author: Regina Henschel AuthorDate: Sat Jun 20 15:08:12 2020 +0200 Commit: Adolfo Jayme Barrientos CommitDate: Tue Jun 23 16:58:18 2020 +0200 tdf#134053 tweak dash and space length for ooxml

[Libreoffice-commits] core.git: oox/source sd/qa

2020-06-22 Thread Regina Henschel (via logerrit)
insertions(+), 16 deletions(-) New commits: commit 3f3b50015e4fd9efc3459612a70409fca49cf390 Author: Regina Henschel AuthorDate: Sat Jun 20 15:08:12 2020 +0200 Commit: Regina Henschel CommitDate: Mon Jun 22 10:43:08 2020 +0200 tdf#134053 tweak dash and space length for ooxml OOXML

[Libreoffice-commits] core.git: Branch 'libreoffice-7-0' - svx/qa svx/source

2020-06-16 Thread Regina Henschel (via logerrit)
changed, 120 insertions(+), 45 deletions(-) New commits: commit 6eaa80f5c40619d8d27c1e5dc180bd2289bd3559 Author: Regina Henschel AuthorDate: Wed Jun 10 20:58:54 2020 +0200 Commit: Xisco Fauli CommitDate: Tue Jun 16 13:15:16 2020 +0200 tdf#103474 handle edge cases in ARCANGLETO

[Libreoffice-commits] core.git: svx/qa svx/source

2020-06-14 Thread Regina Henschel (via logerrit)
changed, 120 insertions(+), 45 deletions(-) New commits: commit 6de8d3109dffa7d4d0cc06f319cca70134f0a8f3 Author: Regina Henschel AuthorDate: Wed Jun 10 20:58:54 2020 +0200 Commit: Regina Henschel CommitDate: Sun Jun 14 16:06:54 2020 +0200 tdf#103474 handle edge cases in ARCANGLETO

[Libreoffice-commits] core.git: Branch 'libreoffice-7-0' - svx/qa svx/source

2020-06-10 Thread Regina Henschel (via logerrit)
a7eef5557060504e6e185e8cd8d9acaf6431cd16 Author: Regina Henschel AuthorDate: Sun Jun 7 23:54:20 2020 +0200 Commit: Xisco Fauli CommitDate: Wed Jun 10 21:52:56 2020 +0200 tdf#103474 handle quarter angles before using atan2 sin(basegfx::deg2rad(fEAngleDeg)) does not result in 0 for fEAngleDeg=180 because

[Libreoffice-commits] core.git: svx/qa svx/source

2020-06-08 Thread Regina Henschel (via logerrit)
91f06123298bb8870cd6fa4e19d3aea9909f8e5b Author: Regina Henschel AuthorDate: Sun Jun 7 23:54:20 2020 +0200 Commit: Regina Henschel CommitDate: Mon Jun 8 13:36:06 2020 +0200 tdf#103474 handle quarter angles before using atan2 sin(basegfx::deg2rad(fEAngleDeg)) does not result in 0 for fEAngleDeg=180

ODF: gradient fill on paragraphs, i.a.

2020-06-05 Thread Regina Henschel
Hi all, currently we have (invalid) draw:fill for header/footer and containing draw:fill for paragraphs. And there are several requests to get gradient fill for tables. I would like to make a proposal for the ODF TC. But the solution is not straight forward, therefore I want your opinion

Re: Update of https://odfvalidator.org/

2020-06-04 Thread Regina Henschel
Hi Michael, Michael Stahl schrieb am 04-Jun-20 um 19:38: hi Regina, [..] you can run the validator from the command prompt; the easiest way is to make sure you have --with-export-validation in autogen.input, then on a master recent enough to have ODF 1.3 changes "make fetch" will download

Re: Update of https://odfvalidator.org/

2020-06-04 Thread Regina Henschel
Hi Guilhem, Guilhem Moulin schrieb am 04-Jun-20 um 20:19: Hi there, On Thu, 04 Jun 2020 at 19:38:29 +0200, Michael Stahl wrote: On 04.06.20 16:58, Regina Henschel wrote: Michael has listed in his summary of ODF 1.3 implementation some changes for the validator, especially I read "Suppor

Update of https://odfvalidator.org/

2020-06-04 Thread Regina Henschel
Hi all, Michael has listed in his summary of ODF 1.3 implementation some changes for the validator, especially I read "Support 1.3 in web validator". But https://odfvalidator.org/ has no item for ODF 1.3 and automatic detection fails for ODF 1.3 too. When is support for ODF 1.3 supposed to

Re: Status of ODF 1.3 implementation in LibreOffice 7.0

2020-06-03 Thread Regina Henschel
Hi Michael, thank you for the summary. Michael Stahl schrieb am 03-Jun-20 um 13:16: * Unimplemented ODF 1.3 features: We found just 2 new features that are not or only partially implemented in LO, and have filed enhancement bugs for these: * OFFICE-2117 chart data-label-series  

Re: How to register .otm files for LibreOffice 7.0 on Windows 10

2020-05-22 Thread Regina Henschel
Hi Miklos, Miklos Vajna schrieb am 22-May-20 um 09:20: Hi Regina, On Thu, May 21, 2020 at 10:24:52PM +0200, Regina Henschel wrote: But the "Type" in Windows Explorer has still "OTM File" (would expect something like 'OpenDocument Master Template') Searching for ODT in

How to register .otm files for LibreOffice 7.0 on Windows 10

2020-05-21 Thread Regina Henschel
Hi all, I have installed LibreOffice Version: 7.0.0.0.alpha1+ (x64) Build ID: 0f855cc3f01fc77937e82738192fae4ee8325227 CPU threads: 8; OS: Windows 10.0 Build 18362; UI render: Skia/Vulkan; VCL: win; Locale: de-DE (en_US); UI: en-US Calc: CL I have tried right-click > Open with > More apps In

Re: Guidance to where in the codebase the Menu structure is built

2020-05-20 Thread Regina Henschel
KKing schrieb am 20-May-20 um 08:55: Thankyou both. Will investigate both approaches and may also consider writing a satellite program that reads the registrymodifications.xcu file for the recent file entries and spawn LO with a selected file. For using macros you find ideas in

Re: Guidance to where in the codebase the Menu structure is built

2020-05-18 Thread Regina Henschel
KKing schrieb am 18-May-20 um 16:13: I have pulled code for Libreoffice 7.0.0.0 and have built it on Debian 10 and seems to run fine. I would like to look at modifying the default Menu structure potentially dependant on the user or a startup parameter. Could someone point me to where in the

Re: How to use running slideshow in unit test?

2020-05-15 Thread Regina Henschel
Hi Thorsten, Thorsten Behrens schrieb am 14-May-20 um 23:28: Hi Regina, better late than never - Regina Henschel wrote: xPresentation2->start(); CPPUNIT_ASSERT(xPresentation2->isRunning()); But the assertion fails. Many slideshow activities happen timer-based, that also in

[Libreoffice-commits] core.git: sd/qa sd/source slideshow/source xmloff/source

2020-04-25 Thread Regina Henschel (via logerrit)
+++ slideshow/source/engine/slideshowimpl.cxx | 27 +++--- xmloff/source/draw/layerimp.cxx |9 ++ 6 files changed, 94 insertions(+), 10 deletions(-) New commits: commit eb2d669af61b8808d5819b16157c59d3c6c3e03b Author: Regina Henschel

How to use running slideshow in unit test?

2020-04-19 Thread Regina Henschel
Hi all, to make a unit test for tdf#129898 (https://gerrit.libreoffice.org/c/core/+/92502), I would need a running slideshow in full screen mode, and then use mouse to paint something. How do I get a running slideshow? I have not found any test, which uses a running slideshow. I have

Re: ESC meeting minutes: 2020-04-16

2020-04-16 Thread Regina Henschel
Miklos Vajna schrieb am 16-Apr-20 um 16:33: * Tenders for budget 2020 (Miklos, Thorsten) + voting deadline was ideally today + still chasing a few people to vote (Thorsten) + propose to wait till the end of the call + tonight: hand over to the board, board meeting tomorrow Where

Need help with views in Impress

2020-04-12 Thread Regina Henschel
Hi all, if you check "Mouse pointer as pen" in "Slide Show Settings", then the graphics, which you paint during running slideshow, are kept when the slideshow is stopped and available in edit mode. The problem is, that they are not visible in the edit window (bug 129898). Such graphics are

Re: remove attribute table:cell-range-address at element in ODF 1.4

2020-04-03 Thread Regina Henschel
Hi Eike, thank you for looking at it. Eike Rathke schrieb am 02-Apr-20 um 14:50: Hi Regina, On Tuesday, 2020-03-31 16:56:59 +0200, Regina Henschel wrote: Does anyone know, whether there exists a scenario (besides sx* import filter) where it makes a difference for LibreOffice, whether

Re: remove attribute table:cell-range-address at element in ODF 1.4

2020-04-01 Thread Regina Henschel
Hi Alex, Alexander Thurgood schrieb am 01-Apr-20 um 12:21: Le 31/03/2020 à 16:56, Regina Henschel a écrit : Hi Regina, Does anyone know, whether there exists a scenario (besides sx* import filter) where it makes a difference for LibreOffice, whether the attribute exists or not? I don't

remove attribute table:cell-range-address at element in ODF 1.4

2020-03-31 Thread Regina Henschel
Hi all, the ODF TC is going to remove table:cell-range-address as attribute from the element. This attribute is already marked as "deprecated" in ODF 1.2. [1] I have made some tests in Calc, Impress and Writer, where I have removed the attribute manually from the files. I have found no

Re: GSoC Propsal: Styles Inspector

2020-03-30 Thread Regina Henschel
Hi Harshit Jain, Please excuse, that you do not have got a response on this list. Your topic touches the user interface. Therefore I suggest, that you sent a mail to the design mailing list too. https://wiki.documentfoundation.org/Design/Mailing_List Besides that, I cannot help you further,

Re: GSoC Project Proposal: Multi-color gradient

2020-03-26 Thread Regina Henschel
Hi Pranesh, Pranesh Ulleri schrieb am 26-Mar-20 um 17:21: [..] For this Google Summer of Code, I would like to contribute to the "Multi-color gradient". This is the link to the proposal that I have drafted. [ Link To The Draft ]

Re: RFC: Sane rectangle class

2020-03-20 Thread Regina Henschel
Hi, Tomaž Vajngerl schrieb am 20-Mar-20 um 18:13: Hi, Do you know a specific case where that actually matters? My personal position on integers is "use int, unless you explicitly need something else". We are dealing with 100th-mm or twip units, which can get quite big (in

Re: RFC: Sane rectangle class

2020-03-20 Thread Regina Henschel
Hi Luboš, Luboš Luňák schrieb am 19-Mar-20 um 16:13: Hello, yes, this is about the tools::Rectangle nightmare of an API (in case you don't know, it's this [1] ). I'm hunting an off-by-one error somewhere in VCL, and it's hard to find it when I can't even tell which parts of the code are

Re: ODF 1.2, xml:id attribute

2020-03-04 Thread Regina Henschel
Hi Olivier, what do you want to do with 'xml:id'? Its value is unique in a document, but it need not be stable in the lifetime of a document. Kind regards Regina Olivier Hallot schrieb am 03-Mar-20 um 22:42: Hi Is there a widget in the user interface or API to assign the xml:id [1]

[Libreoffice-commits] core.git: sd/qa svx/source

2020-03-04 Thread Regina Henschel (via logerrit)
a33484276ed16af7599a59653677f21f051c97e8 Author: Regina Henschel AuthorDate: Tue Mar 3 18:12:36 2020 +0100 Commit: Regina Henschel CommitDate: Wed Mar 4 14:22:49 2020 +0100 tdf#131033 consider 20° tilt of 3D in 2D projection Error was, that the default 20° tilt of a newly created 3D scene

[Libreoffice-commits] core.git: sd/qa svx/source

2020-02-29 Thread Regina Henschel (via logerrit)
Author: Regina Henschel AuthorDate: Fri Feb 28 18:09:34 2020 +0100 Commit: Regina Henschel CommitDate: Sat Feb 29 13:10:24 2020 +0100 tdf#130988 add y-axis up<->down in create 3D obj Creating the matrix aLatheMat uses a coordinate system with y-axis point

[Libreoffice-commits] core.git: sd/qa svx/qa svx/source xmloff/source

2020-02-26 Thread Regina Henschel (via logerrit)
++-- xmloff/source/draw/ximpshap.cxx| 67 + 6 files changed, 162 insertions(+), 41 deletions(-) New commits: commit b4a6977e05d87fe0a79b266ec30e4f403404f1b4 Author: Regina Henschel AuthorDate: Sat Dec 21 22:32:55 2019 +0100 Commit

Re: Looking for review for "tdf#129532 tdf#98839 fixes for mirror of custom shapes"

2020-02-26 Thread Regina Henschel
Hi all, no one interested? Kind regards Regina Regina Henschel schrieb am 17-Feb-20 um 17:35: Hi all, I'm looking for review for tdf#129532 tdf#98839 fixes for mirror of custom shapes https://gerrit.libreoffice.org/c/core/+/85670 If you test it, you will find, that Calc still has problems

Re: Merge Conflict on Gerrit

2020-02-23 Thread Regina Henschel
Hi Julien, hi Mike, thank you. So I will stop review until the author has adapt his patch. Kind regards Regina julien2412 schrieb am 23-Feb-20 um 14:22: Hi Regina, I gave it a try and it seems the conflict is due to the patch

Merge Conflict on Gerrit

2020-02-22 Thread Regina Henschel
Hi all, where can I see in the new UI to which patch there is a merge conflict. Example: Merge Conflict of https://gerrit.libreoffice.org/c/core/+/89125/3 Kind regards Regina ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Looking for review for "tdf#129532 tdf#98839 fixes for mirror of custom shapes"

2020-02-17 Thread Regina Henschel
Hi all, I'm looking for review for tdf#129532 tdf#98839 fixes for mirror of custom shapes https://gerrit.libreoffice.org/c/core/+/85670 If you test it, you will find, that Calc still has problems with mirrored and rotated shapes. I think, that can only be addressed, if the underlying parts

Re: How to build only changed files

2020-02-12 Thread Regina Henschel
Hi, mohamed sameh schrieb am 12-Feb-20 um 20:46: Hello, I have a question. if I change one or more files and want to run 'make' to check that the project still builds, do I have to run a complete build everytime which takes a lot of time or is there a way to only build the affected files only

<    1   2   3   4   5   6   7   8   9   10   >