[Libreoffice-commits] core.git: svx/source

svx/source/customshapes/EnhancedCustomShapeGeometry.cxx | 20 1 file changed, 10 insertions(+), 10 deletions(-) New commits: commit d2702aea99a93f6d3de498fda97cc1ca4f642356 Author: Regina Henschel AuthorDate: Sun Jun 2 22:52:52 2019 +0200 Commit: Regina Henschel

Re: tdf#120047 Support attribute harpoon/wideharpoon in Math

Hi Takeshi, Regina Henschel schrieb am 01-Jun-19 um 17:53: Hi Takeshi, can you please provide the changed OpenSymbol font? For example attach it to the bug report? I have found it there. Currently the symbol is not only the harpoon, but the placeholder dotted circle in addition, see

Re: tdf#120047 Support attribute harpoon/wideharpoon in Math

Hi Takeshi, can you please provide the changed OpenSymbol font? For example attach it to the bug report? Currently the symbol is not only the harpoon, but the placeholder dotted circle in addition, see attachment. I would like to test it with your version of the font. Kind regards Regina

[Libreoffice-commits] core.git: svx/qa

svx/qa/unit/customshapes.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit bfd26fd04ba06d0eac3fb516c6548a1e6eacc6df Author: Regina Henschel AuthorDate: Sat May 25 16:48:09 2019 +0200 Commit: Regina Henschel CommitDate: Sat May 25 18:21:12 2019 +0200

FYI: Improve handles of DrawingML preset shapes

Hi all, you might have noticed, that I have been working on improvements for the handles of DrawingML preset shapes. That is finished for now. I have put some background information into an article in the Wiki.

[Libreoffice-commits] core.git: svx/source

svx/source/customshapes/EnhancedCustomShape2d.cxx | 185 +- 1 file changed, 115 insertions(+), 70 deletions(-) New commits: commit 24e0134c946e780d4439836c799459bcb0c415a4 Author: Regina Henschel AuthorDate: Wed May 22 18:03:59 2019 +0200 Commit: Regina Henschel

Re: CppUnit SdMiscTest::testTdf119956 Failing on Windows with 150% scale factor

Hi Luke, I get curious results. If I run the single test using /opt/lo/bin/make CppunitTest_sd_misc_tests CPPUNIT_TEST_NAME="testTdf119956" CPPUNITTRACE=TRUE or /opt/lo/bin/make CppunitTest_sd_misc_tests CPPUNIT_TEST_NAME="testTdf119956" it does _not_ fail. If I run the test among other

[Libreoffice-commits] core.git: svx/qa

svx/qa/unit/data/tdf115813_HandleMovementOOXMLPresetShapes.pptx |binary 1 file changed New commits: commit 9345ef1cbd14411b7b5b328423fca1d443e623eb Author: Regina Henschel AuthorDate: Mon May 20 18:45:19 2019 +0200 Commit: Regina Henschel CommitDate: Mon May 20 20:35:01 2019 +0200

[Libreoffice-commits] core.git: 2 commits - dtrans/source oox/source

: commit 500a70ba19d9c1207fd9121531950e55a70fd940 Author: Regina Henschel AuthorDate: Sun May 19 14:27:36 2019 +0200 Commit: Thorsten Behrens CommitDate: Sun May 19 21:47:55 2019 +0200 tdf#125181 maxY is 5 in prstGeom for star24 and star32 The presetShapeDefinitions.xml has 'pin

Re: Update of file oox-drawingml-cs-presets

Hi Miklos, Miklos Vajna schrieb am 17-May-19 um 17:53: Hi Regina, On Fri, May 17, 2019 at 05:00:02PM +0200, Regina Henschel wrote: to fix https://bugs.documentfoundation.org/show_bug.cgi?id=125181 it is needed to correct the file oox/source/drawingml/customshapes/presetShapeDefinitions.xml

[Libreoffice-commits] core.git: include/svx svx/qa svx/source

| 51 +- 4 files changed, 120 insertions(+), 12 deletions(-) New commits: commit 4ca556d041b3e27c4aeebf7434814eb8a4350203 Author: Regina Henschel AuthorDate: Mon May 13 14:21:05 2019 +0200 Commit: Regina Henschel CommitDate: Fri May 17 21:16:24 2019 +0200 tdf#115813 unit test

Update of file oox-drawingml-cs-presets

Hi all, to fix https://bugs.documentfoundation.org/show_bug.cgi?id=125181 it is needed to correct the file oox/source/drawingml/customshapes/presetShapeDefinitions.xml. But in addition the script oox/source/drawingml/customshapes/README needs to run for to generate an updated version of

Removing SVX_DLLPRIVATE from GetInteractionHandles() and from DragMoveCustomShapeHdl()

Hi all, for my ask for help in https://lists.freedesktop.org/archives/libreoffice/2019-May/082739.html Stephan has mentioned three ways for getting my unit test work - using a different way --- I have no better idea. - use gb_CppunitTest_use_library_objects --- That does not work. - remove

Re: Struggling with unit test

Hello, Stephan, many thanks for your support, competent and understandable, as always :) Kind regards Regina Stephan Bergmann schrieb am 14-May-19 um 17:19: On 14/05/2019 17:05, Regina Henschel wrote: The technically preferred solution would be if you can somehow avoid calling those

Re: Struggling with unit test

Hi Stephan, Stephan Bergmann schrieb am 14-May-19 um 09:30: On 14/05/2019 02:32, Regina Henschel wrote: I need help again. I try to write a unit test https://gerrit.libreoffice.org/#/c/72229/ It works with Windows10. But Jenkins fails on Mac with message https://ci.libreoffice.org/job

Struggling with unit test

Hi all, I need help again. I try to write a unit test https://gerrit.libreoffice.org/#/c/72229/ It works with Windows10. But Jenkins fails on Mac with message https://ci.libreoffice.org/job/gerrit_mac/32803/ Undefined symbols for architecture x86_64:

[Libreoffice-commits] core.git: svx/source

svx/source/customshapes/EnhancedCustomShape2d.cxx | 242 +++--- 1 file changed, 209 insertions(+), 33 deletions(-) New commits: commit 332138fbfe4d40f6d871f1e6fa900de8e0f3116f Author: Regina Henschel AuthorDate: Sun May 5 22:59:46 2019 +0200 Commit: Regina Henschel

Re: Unit Tests fail. But why?

Hi Miklos, Miklos Vajna schrieb am 06-May-19 um 17:14: Hi Regina, On Mon, May 06, 2019 at 04:36:57PM +0200, Regina Henschel wrote: The expected text '\nText 1: Caption' means, that it will always fail on Windows. Where is the place, that disables this test for Windows? It's

What is shape property 'AnchorPosition' ?

Hi all, If you inspect the shape properties using a Basic macro, you will see the read only property 'AnchorPosition'. What is the meaning of this property? I do not find such property in the API. It seems to be related to the left/top of the center window. A document with macro is attached

Review for tdf#125126 Use individual methods for polar handles in OOXML shapes

Hi all, It would be nice to get a review for https://gerrit.libreoffice.org/71831. Kind regards Regina ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Unit Tests fail. But why?

Hi Stephan, Stephan Bergmann schrieb am 06-May-19 um 15:48: On 06/05/2019 15:26, Regina Henschel wrote: it is about https://gerrit.libreoffice.org/71831 Unit tests fail in Jenkins. But I have no idea, what is wrong. The tests are from sw and my changes have nothing to do with sw. My patch

Unit Tests fail. But why?

Hi all, it is about https://gerrit.libreoffice.org/71831 Unit tests fail in Jenkins. But I have no idea, what is wrong. The tests are from sw and my changes have nothing to do with sw. My patch is about calculating of adjustment values from handle position. Kind regards Regina

Re: help!

Hi Adrien, Adrien Ollier schrieb am 02-May-19 um 21:32: Hi everybody, All of my commits fail at Jenkins tests: [..} https://gerrit.libreoffice.org/#/c/71652/ Wrong syntax for the boolean operator. http://www.cplusplus.com/doc/tutorial/operators/ But the changes are very simple and on my

[Libreoffice-commits] core.git: svx/source

svx/source/customshapes/EnhancedCustomShape2d.cxx | 324 -- 1 file changed, 307 insertions(+), 17 deletions(-) New commits: commit 89ce0ef3744572127a75fbe82c2fc194ce63b702 Author: Regina Henschel AuthorDate: Wed Apr 24 22:08:37 2019 +0200 Commit: Regina Henschel

Looking for review for patch for tdf#115813

Hi all, I'm still working on https://bugs.documentfoundation.org/show_bug.cgi?id=115813 Position shifted while moving the handle of OOXML Callout shape My solution is now in https://gerrit.libreoffice.org/#/c/71258/ The patch handles only the case of XY-handles in preset OOXML-shapes. I

[Libreoffice-commits] core.git: svx/source

svx/source/customshapes/EnhancedCustomShape2d.cxx | 12 svx/source/customshapes/EnhancedCustomShapeGeometry.cxx | 15 ++- 2 files changed, 14 insertions(+), 13 deletions(-) New commits: commit 951282a27a9dd4c64fc206fcbdd805b4cb602816 Author: Regina Henschel

[Libreoffice-commits] core.git: svx/qa svx/source

f0d07c5b84300e508d49dfceb968cb6a0dae436c Author: Regina Henschel AuthorDate: Mon Apr 15 16:15:25 2019 +0200 Commit: Regina Henschel CommitDate: Tue Apr 16 12:05:43 2019 +0200 tdf#124740 Handle position is already scaled for ooxml-foo shapes If a 'ooxml-foo' shape has a path internal

Re: Faulty handle position in shapes imported from MS Office (continued)

Hi all, and here is a version without switch, but with a sequence of "if" statements: https://gerrit.libreoffice.org/70712 Still the same question, what way to go and where to put the parts? Kind regards Regina Regina Henschel schrieb am 13-Apr-19 um 01:33: Hi all, I have

Faulty handle position in shapes imported from MS Office (continued)

Hi all, I have mentioned in the previous thread, that I'll make a proposal, so that discussing a solution is easier. For my first ideas, see now https://gerrit.libreoffice.org/70689. Please take a look at the proposal. Is the way suitable in principle? I am so indecisive, because both

Re: Faulty handle position in shapes imported from MS Office

Hi Mark, Mark Hung schrieb am 11-Apr-19 um 13:21: The equation should hold: (adj1-adj0) = (y1-y0) * 10 / height. I think this should cover lots of cases already. [..] I think the patterns of the formula is much less than the number of types. Maybe worthy of identify them? Yes, I'm

Re: Faulty handle position in shapes imported from MS Office

Miklos Vajna schrieb am 11-Apr-19 um 09:59: Hi Regina, I might be wrong, but I would expect that the evaluation of the formulas don't depend on the shape type. If it does, it feels we don't understand the general rule, so we work the problem around with evaluating a formula in different ways

Re: Faulty handle position in shapes imported from MS Office

Hi Miklos, hi others, Miklos Vajna schrieb am 10-Apr-19 um 10:20: It feel like the correct place to fix this is where we interpret the formulas. If it can be done without taking the shape type into account, that sounds ideal. But I did not look into this personally. The needed calculation

Re: Faulty handle position in shapes imported from MS Office

Hi Miklos, Miklos Vajna schrieb am 09-Apr-19 um 09:30: Hi Regina, On Tue, Apr 09, 2019 at 01:06:12AM +0200, Regina Henschel wrote: What to do? In principle you can get the needed operations from the presets as defined in the standard. But how to organize that, so that it can be done step

Re: Faulty handle position in shapes imported from MS Office

Hi Mark, Mark Hung schrieb am 09-Apr-19 um 11:27: Hi Regina, Regina Henschel <mailto:rb.hensc...@t-online.de>> 於 2019年4月9日 週二 上午7:06寫道： Hi all, I'm looking at https://bugs.documentfoundation.org/show_bug.cgi?id=115813 "Position shifted while moving the h

Faulty handle position in shapes imported from MS Office

Hi all, I'm looking at https://bugs.documentfoundation.org/show_bug.cgi?id=115813 "Position shifted while moving the handle of OOXML Callout shape". Unfortunately not only the Callout shape is affected. There are 106 shapes in MS Office, which have handles. 38 are OK with the current

[Libreoffice-commits] core.git: sw/qa sw/source

+ 4 files changed, 64 insertions(+) New commits: commit 421e6fc3cd2e6fe37afbef341e2d0ad7b8edde37 Author: Regina Henschel AuthorDate: Tue Apr 2 21:36:57 2019 +0200 Commit: Thorsten Behrens CommitDate: Sun Apr 7 01:14:31 2019 +0200 tdf#118375, tdf#70838 correct position of rotated shape

Re: compiling Libreoffice with internationalization

Hi Adrien, Adrien Ollier schrieb am 04-Apr-19 um 12:36: Hello everybody, I am a French C++ developper and I want to contribute to Libreoffice. I downloaded the Libreoffice source code and compiled it on my Ubuntu desktop computer with is configured in French but all the text in the menus is

Review for rotated shape import/export with doc-format

Hi all, I'm looking for a reviewer for https://gerrit.libreoffice.org/70152. It is for Bug 118375 - FILEOPEN: wrong position of rotated shapes in DOC Bug 70838 - FILESAVE: doc: wrong size and position exporting rotated shapes Kind regards Regina ___

[Libreoffice-commits] core.git: filter/source svx/qa

5c725eb7dee248c6d1792a9b9b9a9c813ca627e6 Author: Regina Henschel AuthorDate: Wed Mar 27 14:24:49 2019 +0100 Commit: Thorsten Behrens CommitDate: Mon Apr 1 11:51:45 2019 +0200 tdf#124029 Force correct import pos of mso_sptArc shape mso_sptArc uses the current pos of the sector as frame rectangle LO has used

Re: Problems with import of shape type 'arc' from binary MS Office

Hi all, Regina Henschel schrieb am 10-Mar-19 um 23:11: Hi all, I consider to change the import so, that the viewbox only includes the current sector not the entire ellipse. What do you think? I have gone further and elaborated the idea to a proposal https://gerrit.libreoffice.org/69829

Re: How to write a unit test for dragging an adjust handle

Hi Miklos, Miklos Vajna schrieb am 20-Mar-19 um 09:28: Hi Regina, On Tue, Mar 19, 2019 at 08:22:44PM +0100, Regina Henschel wrote: it is about bug https://bugs.documentfoundation.org/show_bug.cgi?id=124212 Adjustment handle reacts wrongly, if custom shape has a non default viewBox A fix

How to write a unit test for dragging an adjust handle

Hi all, it is about bug https://bugs.documentfoundation.org/show_bug.cgi?id=124212 Adjustment handle reacts wrongly, if custom shape has a non default viewBox A fix is in https://gerrit.libreoffice.org/69439 But I have no idea how to make a unit test for it. Perhaps you? Kind regards Regina

Re: Problems with import of shape type 'arc' from binary MS Office

Hi Mark, hi all, Mark Hung schrieb am 13-Mar-19 um 12:45: Hi Regina, In your first mail you mentioned that MSO has viewbox size 43200x43200, that is the size of the full ellipse, not of the viewbox. while LibreOffice has viewbox size 21600x21600. And MSO viewbox only contains the current

Re: Problems with import of shape type 'arc' from binary MS Office

Hi Mark, Mark Hung schrieb am 12-Mar-19 um 15:59: Regina Henschel <mailto:rb.hensc...@t-online.de>> 於 2019年3月11日 週一 上午6:11寫道： Hi all, It is not possible to change the outer position to set the sector to the original position, because that might result in position

Re: Problems with import of shape type 'arc' from binary MS Office

Hi Miklos, Miklos Vajna schrieb am 12-Mar-19 um 09:05: Hi Regina, On Sun, Mar 10, 2019 at 11:11:11PM +0100, Regina Henschel wrote: I consider to change the import so, that the viewbox only includes the current sector not the entire ellipse. What do you think? [MS-ODRAW] from <ht

remove unused columns in list of LibreOffice ODF Extensions

Hi all, the table in https://wiki.documentfoundation.org/Development/ODF_Implementer_Notes/List_of_LibreOffice_ODF_Extensions has the columns 'ODF Version(s) Extended' and 'False Positive Validation Errors'. These columns have no entries. Because the table is already very wide, I'm going to

Problems with import of shape type 'arc' from binary MS Office

Hi all, I'm currently working on bug tdf#122899. It is about import of the shape 'arc' (= mso-spt19 = mso_sptArc). I have already found one error and made https://gerrit.libreoffice.org/68941. This mail is about an additional 'position' problem. MS Office uses for the ellipse a size of

Re: logerrit error

Hi, shubham goyal schrieb am 05-Mar-19 um 08:34: Hey, I want to submit my patches in Gerrit for review. But here are some errors.  ./logerrit test First you made your changes. Then use git add to tell git which files you want to commit Then use git commit -m " your

Re: git Push to online project

Regina Henschel schrieb am 04-Mar-19 um 01:36: Hi Ahmed, do you have the correct email in .gitconfig ? I have got a global file in my home directory with a section [user] and items name = Regina Henschel and email = rb.hensc...@t-online.de https://www.atlassian.com/git/tutorials/setting-up

Re: git Push to online project

Hi Ahmed, do you have the correct email in .gitconfig ? I have got a global file in my home directory with a section [user] and items name = Regina Henschel and email = rb.hensc...@t-online.de https://www.atlassian.com/git/tutorials/setting-up-a-repository/git-config Kind regards Regina

Re: How to get a bitmap of page or shape in a unit test?

remainder --> reminder ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: How to get a bitmap of page or shape in a unit test?

Hi, Michael Stahl schrieb am 28-Feb-19 um 10:54: On 28.02.19 01:31, Regina Henschel wrote: The shape members mXRenderedCustomShape and  mxCustomShapeEngine are empty. I have tried to generate them by calling GetSdrObjectFromCustomShape(). It sets

Re: How to get a bitmap of page or shape in a unit test?

Hallo Miklos, Miklos Vajna schrieb am 27-Feb-19 um 09:22: (Or just do the same using the UI: open the document in question, close it, and see the preview metafile in the start center.) Saving in the UI creates the Thumbnails folder with the preview. But when I use "save" (that from

Re: How to get a bitmap of page or shape in a unit test?

Hi Miklos, Miklos Vajna schrieb am 25-Feb-19 um 09:44: Hi Regina, On Mon, Feb 25, 2019 at 01:13:00AM +0100, Regina Henschel wrote: I have tried to do it the same as in SdImportTest::testTdf93124 in import-tests.cxx in sd/qa/unit. But I only get a bitmap of the page without the shape

How to get a bitmap of page or shape in a unit test?

Hi all, the current implementation of custom shape commands U and T (angleellipse) is wrong in the way, that for a command U with a series parameter groups only the first it treated as command U but the second as command T. Thus a line is drawn, where no line should be. My patch fixes this.

Re: tdf#121845 rework custom shape path command U and T

Hi Miklos, hi Thorsten, Miklos Vajna schrieb am 21-Feb-19 um 13:46: Hi Regina, On Tue, Feb 19, 2019 at 08:58:56PM +0100, Regina Henschel wrote: (1) My opinion, how the commands U and T should work, see comments in https://bugs.documentfoundation.org/show_bug.cgi?id=121845. The description

Re: build break in svx/source/dialog/srchdlg.cxx(337)

Hi Stephan, Stephan Bergmann schrieb am 20-Feb-19 um 14:22: On 20/02/2019 14:03, Regina Henschel wrote: D:/Build_forCommit/core/svx/source/dialog/srchdlg.cxx(337): error C3083: 'FindReplaceRememberedSearches': the symbol to the left of a '::' must be a type That would presumably be the line

build break in svx/source/dialog/srchdlg.cxx(337)

Hi all, I get a build break D:/Build_forCommit/core/svx/source/dialog/srchdlg.cxx(337): error C3083: 'FindReplaceRememberedSearches': the symbol to the left of a '::' must be a type D:/Build_forCommit/core/svx/source/dialog/srchdlg.cxx(337): error C2440: '=': cannot convert from

warning treated as error problem in interpr3.cxx

Hi all, I get a "warning treated as error" problem: D:/Build_diverses/core/sc/source/core/tool/interpr3.cxx(4927): error C2220: warning treated as error - no 'object' file generated D:/Build_diverses/core/sc/source/core/tool/interpr3.cxx(4927): warning C4334: '<<': result of 32-bit shift

tdf#121845 rework custom shape path command U and T

Hi all, I have submitted https://gerrit.libreoffice.org/68029 for discussion. It has no unit tests yet. I would like your opinion on the changes before putting time into unit tests. Critical parts are (1) My opinion, how the commands U and T should work, see comments in

Re: How to include in a unit test?

Hi Stephan, thank you. That solves the problem. Kind regards Regina Stephan Bergmann via LibreOffice schrieb am 12-Feb-19 um 15:51: On 12/02/2019 15:33, Regina Henschel wrote: So I have added the include #include in sd/qa/unit/misc-tests.cxx too. But I get the error:   fatal error C1083

How to include in a unit test?

Hi all, I have introduced this user config item: oor:nillable="false"> If 'true', the config items VisibleLayers, PrintableLayers and LockedLayers are written to 'office:settings' element, otherwise not. Since LO 6.2 the ODF attributes of 'draw:layer' element are

Re: no pagenumbers on a specific number of first pages

Hi Thomas, libreoffice@lists.freedesktop.org is the wrong mailing list for user questions. It is a list for developers who will work on the code. Please use us...@global.libreoffice.org. Kind regards Regina ___ LibreOffice mailing list

Re: HowTo load a file in unit test in xmloff?

Hi Tomaž, Tomaž Vajngerl schrieb am 27-Jan-19 um 20:57: Hi Regina, On Sat, Jan 26, 2019 at 8:43 PM Regina Henschel wrote: Hi all, HowTo load a file in unit test in xmloff? Actually I wonder why not just add the test as a import/export test into sd/qa or svx/qa (which already has

Re: header footer background images don't display on file reopen

Hi Jim, Jim Raykowski schrieb am 27-Jan-19 um 02:17: Greetings All, Trying to make header and footer background images redisplay on opening. I noticed draw:fill="bitmap" in style:header-footer-properties in a .fodt test file. ... fo:margin-bottom="0.1965in" draw:fill="bitmap"

HowTo load a file in unit test in xmloff?

Hi all, I try to write a unit test in xmloff for https://gerrit.libreoffice.org/66888. I would need to load a file and examine, whether it is rendered correctly. My idea was to use loadFromDesktop() from unotest::MacrosTest. I have tried to mimic what I have seen elsewhere, but it does not

enhanced-path command M with multiple pairs of coordinates

Hi, this is about https://gerrit.libreoffice.org/66888. I have put it to Gerrit for discussion. The spec says, "If a moveto is followed by multiple pairs of coordinates, they are treated as lineto." LibreOffice does not honor this, Karbon does it. My patch transforms a path like "M 0 0 5 10

Bringing command 'arcangleto' (G) to ODF

Hi all, some years ago Radek Doulik has implemented a commant 'G' for the enhanced-path of a custom shape. Such path is written in drawooo namespace. I have not found any documentation about it and it is not mentioned in

Re: Problems with custom-shape path commando angle-ellipseto

Hi Miklos, Miklos Vajna schrieb am 15-Jan-19 um 09:46: Hi Regina, On Sun, Jan 13, 2019 at 12:43:03AM +0100, Regina Henschel wrote: Do you know other apps, not based on LibreOffice, which can read .odg or .odp files? An obvious candidate would be Microsoft Office, recent versions even ask

Problems with custom-shape path commando angle-ellipseto

Hi all, I'm going to fix problems with custom shape commands U (angle-ellipse) and T (angle-ellipseto). The main problems currently are, that y-values are mirrored and negative angles are set to 0. https://bugs.documentfoundation.org/show_bug.cgi?id=121845 My work will only handle the case

No Opengrok for core?

Hi all, I cannot use https://opengrok.libreoffice.org for "core". It is not listed in the projects and therefore I get no search fields. Any hints? Kind regards Regina ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: Contributing for GSoC 2019

Hi Rajprakash, please excuse, that you not have got immediately answer. rajprakash sahoo schrieb am 19-Dec-18 um 08:15: Hello, I'm a 1st year computer science student of International Institute of Information Technology, Bhubaneswar,India.I explored all the organisations for open source

Re: GSOC 2019 - Costin Visan

Hi Costin, please excuse, that you not have got immediately answer. costin visan schrieb am 18-Dec-18 um 14:41: Hello! I'm really interested in participating this year at gsoc as part of your team. I'm writting you this email to get your attention and maybe to get a hint for this year's

Re: improvements on ellipticalquadrant in enhanced path of custom shape

Hi Noel, hi Armin, hi all, my new solution is in https://gerrit.libreoffice.org/#/c/65203/ Noel Grandin schrieb am 09-Dec-18 um 07:42: On Sat, 8 Dec 2018 at 20:25, Regina Henschel mailto:rb.hensc...@t-online.de>> wrote: Problem A The current implementation has a method Ge

improvements on ellipticalquadrant in enhanced path of custom shape

Hi all, I'm working on tdf#121761 and tdf#121952. The current state is in https://gerrit.libreoffice.org/#/c/64817/. It works in principle, but there are still some problems. Problem A The current implementation has a method GetPoint, which returns a tools::Point; and such has integer

Where starts an ellipse?

Hi all, I want to work on bug 121305. I know already, that I have to replace EnhancedCustomShape2d#1691-1725 with a solution with more segments. My idea is to use a 12-segment solution from basegfx. That works in principle as I have tested already. My question is, where the ellipse should

Re: Marker problems for high resolution screen

Hi Tomaž, Tomaž Vajngerl schrieb am 28-Oct-18 um 09:46: Hi Regina, [..] Right, I extracted the markers to single files just because of that reason. Multiple markers in one image file makes it hard - not only for HiDPI, but also for SVG icons, and there are practically no benefits to have them

Marker problems for high resolution screen

Hi all, I want to tell you, what I have found so far, so that if someone will actually fix the problem, can use this information. The problem: If someone has a higher resolution screen and therefore uses an OS scaling of e.g. 150%, the markers for resizing and rotation, the anchor and the

Re: text frame selection

Hi Samuel, Samuel Mehrbrodt schrieb am 26-Oct-18 um 10:59: I thought I had fixed this with https://bugs.documentfoundation.org/show_bug.cgi?id=116342 but maybe I was missing something... The presentation objects title and subtitle, and the graphic object text box are OK. But the presentation

Re: problems with LayerTabBar in unit tests

Hi Thorsten, Thorsten Behrens schrieb am 10-Oct-18 um 23:20: Hi Regina, Regina Henschel wrote: So I still need to investigate what is missing. If you can make it - perhaps something to look into for the Munich Hackfest? https://wiki.documentfoundation.org/Hackfest/Muenchen2018 I

Re: unit test LayerTabBar, now linker problem

uld change something. https://gerrit.libreoffice.org/#/c/61545/7 Kind regards Regina Michael Stahl schrieb am 15-Oct-18 um 15:45: On 15.10.18 14:56, Regina Henschel wrote: Hallo Michael, Michael Stahl schrieb am 14-Oct-18 um 13:49: On 13/10/2018 21:04, Regina Henschel wrote: linker cannot fin

Re: unit test LayerTabBar, now linker problem

Hallo Michael, Michael Stahl schrieb am 14-Oct-18 um 13:49: On 13/10/2018 21:04, Regina Henschel wrote: Hi all, the patch in https://gerrit.libreoffice.org/61545 works fine on my PC, but I get an error message from Jenkins Build Failed https://ci.libreoffice.org/job/gerrit_master/16732

unit test LayerTabBar, now linker problem

Hi all, the patch in https://gerrit.libreoffice.org/61545 works fine on my PC, but I get an error message from Jenkins Build Failed https://ci.libreoffice.org/job/gerrit_master/16732/ : FAILURE linker cannot find typeinfo for sd::GraphicViewShell (

Re: problems with LayerTabBar in unit tests

Hello all, Markus Mohrhard schrieb am 08-Oct-18 um 22:42: Hello Regina, On Mon, Oct 8, 2018 at 7:54 PM Regina Henschel mailto:rb.hensc...@t-online.de>> wrote: Hi all, does no one has an idea? I have put the problem as patch to Gerrit https://gerrit.libreoffice.org/61545. P

Re: problems with LayerTabBar in unit tests

her window sizes have suspicious values. Especially the LayerTabBar has width 0, and therefore a click on it is not possible. But that would be needed for the unit test. How to get the correct window sizes? Kind regards Regina Regina Henschel schrieb am 04-Oct-18 um 14:42: Hi all, I'm sti

Re: Unittest fail because of 125% screen resolution on Windows 10

Hi Oliver, Oliver Brinzing schrieb am 06-Oct-18 um 17:03: Hi Regina, if I set my PC to 100% screen resolution, the unit tests work. If I set my PC to 125%, unit tests fail. 125% results in 120dpi, that is below the threshold for scaling. if have win10 with 125% (120DPI / 1920x1080) and can

Unittest fail because of 125% screen resolution on Windows 10

Hi all, if I set my PC to 100% screen resolution, the unit tests work. If I set my PC to 125%, unit tests fail. 125% results in 120dpi, that is below the threshold for scaling. The failing tests are in CppunitTest_sw_ooxmlexport4 the test testFDO74215::Import_Export_Import with Expected:

problems with LayerTabBar in unit tests

Hi all, I'm still working on a unit test for bug tdf#119956. My current state is, that the odg test document really opens in Draw. [On master it opens in Impress.] But the layer tab bar has width 0. So simulating a click on the layer tab bar is not possible, which is needed in case of bug

Re: Struggling with LayerTabBar in unit test

regards Regina Stephan Bergmann schrieb am 24-Sep-18 um 14:45: On 24/09/2018 14:24, Regina Henschel wrote: void SdMiscTest::testTdf119956() { sd::DrawDocShellRef xDocShRef = Load(m_directories.getURLFromSrc("/sd/qa/unit/data/tdf119956.odg"), ODG); CPPUNIT_ASSERT_MESSAGE( "

Struggling with LayerTabBar in unit test

Hi all, I try to write a unit test for tdf#119956, but fail to work with LayerTabBar. My start is: void SdMiscTest::testTdf119956() { sd::DrawDocShellRef xDocShRef = Load(m_directories.getURLFromSrc("/sd/qa/unit/data/tdf119956.odg"), ODG); CPPUNIT_ASSERT_MESSAGE( "Failed to load

Re: Why is syntax error 'assert(false, "some text")' not discovered by Visual Studio?

Hi, Tor Lillqvist schrieb am 19-Sep-18 um 08:04: But even if assert(e) expands to nothing, the compiler should report an error if you pass two arguments to the assert macro that takes just one. At least Clang on macOS and gcc on Linux do: assert.cpp:5:17: error: too many arguments provided to

Deleting standard layers by macro

Hi all, if you use a macro, you can delete a standard layer. When you save the document, close it and reopen it then, the standard layer is recreated. As expected it is empty. Is a macro developer expected to take care himself of not deleting standard layers, or is this a bug and

Why is syntax error 'assert(false, "some text")' not discovered by Visual Studio?

Hi all, I had the line assert(false, "Standard layer may not be deleted."); But Visual Studio 2017 does not detect the syntax error. Is there something wrong with my environment? Kind regards Regina ___ LibreOffice mailing list

Re: How to make unokywds.hxx from module sd usable for svdlayer.cxx in module svx?

Hallo Tor, Tor Lillqvist schrieb am 18-Sep-18 um 17:21: On the other hand, do we really consider what sd/source/ui/inc/unokywds.hxx exhibits to be good style? My personal impression has been that we want to eventually get rid of stuff like this and just use literal strings as such in the code,

Re: How to make unokywds.hxx from module sd usable for svdlayer.cxx in module svx?

Hallo Stephan, Stephan Bergmann schrieb am 18-Sep-18 um 16:53: On 18/09/2018 16:21, Regina Henschel wrote: The file unokywds.hxx containes a lot of string definitions. My case is about sUNO_LayerName_controls, which is "controls". The ctor of LayerAdmin in svdlayer.cxx has the

How to make unokywds.hxx from module sd usable for svdlayer.cxx in module svx?

Hi all, The file unokywds.hxx containes a lot of string definitions. My case is about sUNO_LayerName_controls, which is "controls". The ctor of LayerAdmin in svdlayer.cxx has the wrong text "Controls" instead of "controls". I have now simple set the correct text to verify that is solved the

Review for "tdf#67248 Use localized layer name only for display in UI"

Hi all, this is about https://gerrit.libreoffice.org/60507 The problem described in "Bug 67248 - FILEOPEN Layer with reserved name vanishes when changing UI language" has its reason in the fact, that LO uses localized layer names internally. So when you use a layer "Hintergrund" in an

Re: Need help on how to insert a layer into a Draw document in a unit test

Hi all, I have found suitable methods. I can use InsertNewLayer() and SetLayerVisible(). Kind regards Regina Regina Henschel schrieb am 06-Sep-18 um 01:10: Hi all, I'm working on https://bugs.documentfoundation.org/show_bug.cgi?id=119392. I have a solution for it. Now I need a unit test. I

Need help on how to insert a layer into a Draw document in a unit test

Hi all, I'm working on https://bugs.documentfoundation.org/show_bug.cgi?id=119392. I have a solution for it. Now I need a unit test. I need to do: 1. Load a Draw document, which has two user defined layers with non-default settings for visible/printable/locked. 2. Insert a new layer between

Precedence between fo:line-height and style:line-height-at-least

Hi all, the ODF specification has only for value "normal" a rule for the precedence between the attributes fo:line-height [3] and style:line-height-at-least [1] and style:line-spacing [2]. So I want to extend the description. Unfortunately LibreOffice behaves so, that the attribute order

<    3   4   5   6   7   8   9   10   11   12   >