Re: [Libreoffice] [PATCH] Mark ecx register as clobbered (in cpp_uno/gcc3_macosx_intel)

2011-10-18 Thread Stephan Bergmann
On 10/15/2011 01:25 AM, Kristian Rietveld wrote: Without this patch, Cpp bridgetest on a Clang-compiled UNO runtime will not complete successfully. Btw, pushing some clang-related patches, mainly based on abandoned work I did earlier this year. Your go at this gave me fresh enthusiasm. :)

Re: [Libreoffice] Trying to diagnose base running extremely slowly

2011-10-19 Thread Stephan Bergmann
On 10/19/2011 04:10 PM, John Talbut wrote: What I notice is that there is a set of lines starting with read(72 and ending with close(72) (the number is not always 72) that is repeated more or less identically some 12,000 times in the 7 minute run. Since each set appears to take around .02

Re: [Libreoffice] Trying to diagnose base running extremely slowly

2011-10-19 Thread Stephan Bergmann
On 10/19/2011 05:07 PM, Michael Meeks wrote: On Wed, 2011-10-19 at 16:34 +0200, Stephan Bergmann wrote: (the number is not always 72) that is repeated more or less identically some 12,000 times in the 7 minute run. Since each set appears to take around .02 seconds that alone would account

Re: [Libreoffice] Trying to diagnose base running extremely slowly

2011-10-20 Thread Stephan Bergmann
On 10/19/2011 07:17 PM, Andrew Haley wrote: On 10/19/2011 05:57 PM, Michael Meeks wrote: On Wed, 2011-10-19 at 17:32 +0200, Stephan Bergmann wrote: What the LibO hsqldb code does a lot is call JNI's Attach/DetachCurrentThread. Googling around, http://bugs.sun.com/bugdatabase/view_bug.do

Re: [Libreoffice] Fwd: Re: patch for scan-diialog

2011-10-20 Thread Stephan Bergmann
On 10/19/2011 10:30 PM, Rob Snelders wrote: I tried to add the XScannerManager2. But when I try with this patch then the menu-items are disabled. I have tried to search where the problem was but I can´t find it. Can you help me? Hi Rob, The new file

Re: [Libreoffice] make experts: progress information?

2011-10-20 Thread Stephan Bergmann
On 10/20/2011 07:35 AM, Kevin Hunter wrote: Beyond myself, are others interested in having a finer-grained indication of where is the build currently in the whole process?? Honestly, I'm not. Please don't add too much magic to make the build output nicer. It does get in your way, sooner or

Re: [Libreoffice] [PUSHED] Fwd: Re: patch for scan-diialog

2011-10-20 Thread Stephan Bergmann
On 10/20/2011 08:37 PM, Rob Snelders wrote: Here are 3 patches that together make the code for adding the scan-button to the sanedlg. These patches are submitted under the LGPLv3+/MPL-licence. Pushed now as

[Libreoffice] Python on Windows

2011-10-20 Thread Stephan Bergmann
I must confess that in http://cgit.freedesktop.org/libreoffice/core/commit/?id=fecde94354a46463d346a1a78962f39a5a6f9eb8 Undo basis/brand split: moved Python from basis to brand. I did some blind changes to Windows-only code in pyuno/zipcore/python.cxx. (Did I mention I still did not succeed

Re: [Libreoffice] minutes of tech. steering call ...

2011-10-21 Thread Stephan Bergmann
On 10/21/2011 02:06 AM, Kevin Hunter wrote: At 4:52pm -0400 Thu, 20 Oct 2011, Michael Meeks wrote: http://wiki.documentfoundation.org/Development/LibreOffice4 + getting stuck into Windows / mingw build etc. From the wiki page, one of the concerns is binary incompatibility. I assume this

Re: [Libreoffice] Python on Windows

2011-10-21 Thread Stephan Bergmann
On 10/21/2011 01:20 AM, Miklos Vajna wrote: On Thu, Oct 20, 2011 at 11:21:52PM +0200, Stephan Bergmannsberg...@redhat.com wrote: (c) pyuno as run from an external python process might no longer work. An easy way to test that is to start the interactive python executable from the LibO program

Re: [Libreoffice] minutes of tech. steering call ...

2011-10-21 Thread Stephan Bergmann
On 10/21/2011 11:08 AM, Kevin Hunter wrote: At 4:11am -0400 Fri, 21 Oct 2011, Stephan Bergmann wrote: On 10/21/2011 02:06 AM, Kevin Hunter wrote: 5. That API definition will be a *lot* of work, but hopefully somewhat thought out already through only a mild reengineering of the current binary

Re: [Libreoffice] minutes of tech. steering call ...

2011-10-21 Thread Stephan Bergmann
On 10/21/2011 10:39 AM, Michael Meeks wrote: Hi Kevin, On Thu, 2011-10-20 at 20:06 -0400, Kevin Hunter wrote: From the wiki page, one of the concerns is binary incompatibility. I assume this is in reference to extensions? Sure; of course we only export a reasonably small ABI, the

Re: [Libreoffice] comprehensive binfilter tests?

2011-10-21 Thread Stephan Bergmann
On 10/21/2011 02:38 PM, Caolán McNamara wrote: On Wed, 2011-09-28 at 21:58 +0200, Andras Timar wrote: In rsc/doku/feinkonz.43 there are 3 sdw files, LibreOffice 3.4.x crashes on all of them under Linux/Windows. I did not try master. 3.3 is OK. master crashes for me alright,

Re: [Libreoffice] [PUSHED] String::CompareIngoreCaseToAscii

2011-10-21 Thread Stephan Bergmann
On 10/21/2011 11:13 AM, Michael Meeks wrote: Hi August, On Thu, 2011-10-20 at 15:01 -0400, August Sodora wrote: On Tue, Oct 18, 2011 at 3:01 PM, August Sodoraaug...@gmail.com wrote: I've attached a new patch that includes some tests for the BASIC scanner. Most of the test cases are just to

Re: [Libreoffice] IDL hyper / Java long

2011-10-21 Thread Stephan Bergmann
Marcin, hope you don't mind I bring this back to the public mailing list. I'm no expert with Calc add-ins, so we should make sure I'm not telling nonsense: On 10/21/2011 05:42 PM, MarcinGutman wrote: Sorry, not sure what you want to tell me with the above. If you create Java Calc Add-In

Re: [Libreoffice] minutes of tech. steering call ...

2011-10-21 Thread Stephan Bergmann
On 10/21/2011 03:57 PM, Michael Meeks wrote: On Fri, 2011-10-21 at 14:51 +0200, Stephan Bergmann wrote: That would of course mean shipping some duplicate legacy MSVC++ compiled libraries, but ... surely do-able. It would not suffice to ship them, one would also need to build them. Kind

Re: [Libreoffice] [PUSHED] String::CompareIngoreCaseToAscii

2011-10-23 Thread Stephan Bergmann
On 10/21/2011 10:17 PM, Michael Meeks wrote: On Fri, 2011-10-21 at 18:16 +0200, Stephan Bergmann wrote: Unfortunately, this breaks the build, as basic now has a (missing) dependency on sfx2, which already depends on basic. Fair enough, my mistake. I dropped sfx from the link line

Re: [Libreoffice] [PATCH] [PUSHED] Match the correct function template specialization (in autodoc)

2011-10-24 Thread Stephan Bergmann
On 10/22/2011 11:37 AM, Kristian Rietveld wrote: My understanding of the issue is that when the EV_TokenId typedef is expanded, the resulting E_TokenId part is ambiguous. Therefore, fully specifying the E_TokenId fixes the problem. Yes. Thanks, Stephan

Re: [Libreoffice] [PATCH] [PUSHED] Put neq-operator for awt::Size in correct namespace (in chartapiwrapper)

2011-10-24 Thread Stephan Bergmann
On 10/22/2011 11:39 AM, Kristian Rietveld wrote: If not done, Clang will not find the operator overload. Yeah, thanks. Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] compilation error in binfilter/bf_svx/

2011-10-24 Thread Stephan Bergmann
On 10/24/2011 12:25 PM, Jean-Baptiste Faure wrote: Compiling: binfilter/bf_svx/source/xoutdev/svx_xattr.cxx /home/jbf/LibO/master/clone/binfilter/binfilter/bf_svx/source/xoutdev/svx_xattr.cxx: In member function 'virtual binfilter::SfxPoolItem* binfilter::XFillAttrSetItem::Create(SvStream,

Re: [Libreoffice] [PATCH] Also use .NET2003 build fix for Clang (in toolkit)

2011-10-24 Thread Stephan Bergmann
On 10/22/2011 11:47 AM, Kristian Rietveld wrote: By far the quickest is to use the already existing fix for .NET2003 for clang as well. In the future, this is something that possibly should be avoided in the class hierarchy, there are more classes in the code base that expose a similar problem.

Re: [Libreoffice] [PATCH] [PUSHED] Also use .NET2003 build fix for Clang (in toolkit)

2011-10-24 Thread Stephan Bergmann
On 10/24/2011 01:26 PM, Stephan Bergmann wrote: Pushed, thanks. [had forgotten to add the PUSHED marker] ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] [PUSHED] Argument to setTitle cannot be const (in fpicker/aqua)

2011-10-24 Thread Stephan Bergmann
On 10/22/2011 11:41 AM, Kristian Rietveld wrote: This fixes the following warning: /source/libo/libo/fpicker/source/aqua/ControlHelper.cxx:244:39: error: cannot initialize a parameter of type 'NSString *' with an lvalue of type 'const NSString *' I did not see another solution so quickly than

Re: [Libreoffice] [PATCH] [PUSHED] SystemFlavor NSStrings should not be const (in vcl/aqua/.../dtrans/)

2011-10-24 Thread Stephan Bergmann
On 10/22/2011 11:43 AM, Kristian Rietveld wrote: This fixes an issue where const NSString* is assigned to a non-const NSString* field in FlavorMap. The NSString cannot be const when passed to an objective-C method expecting a non-const value (the NSStrings from flavor map are passed to such

Re: [Libreoffice] [PATCH] [PUSHED] Use NSString in template specification instead of objc_object (in macosxspell)

2011-10-24 Thread Stephan Bergmann
On 10/22/2011 11:45 AM, Kristian Rietveld wrote: This fixes the following warnings: /source/libo/libo/lingucomponent/source/spellcheck/macosxspell/macspellimp.cxx:176:39: error: reference to type 'const value_type' (aka 'objc_object *const') could not bind to an rvalue of type 'id'

Re: [Libreoffice] [PATCH] [PUSHED] Eliminate ambiguous conversion to cppu::OWeakObject (in reportdesign)

2011-10-24 Thread Stephan Bergmann
On 10/22/2011 11:48 AM, Kristian Rietveld wrote: This fixes the following error: /source/libo/libo/reportdesign/source/core/sdr/ReportDrawPage.cxx:96:24: error: ambiguous conversion from derived class 'SvxShapeControl' to base class 'cppu::OWeakObject': class SvxShapeControl - class

Re: [Libreoffice] [PATCH] [PUSHED] Eliminate ambiguous conversion to cppu::OWeakObject (in svx/form)

2011-10-24 Thread Stephan Bergmann
On 10/22/2011 11:52 AM, Kristian Rietveld wrote: Similar to the previous patch. pushed, too Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] IDL hyper / Java long

2011-10-24 Thread Stephan Bergmann
On 10/24/2011 08:46 PM, Eike Rathke wrote: Why, however, it should work if the .idl file instead uses unsigned hyper I do not know. Wild guess: may it be that the .idl parser takes 'unsigned' of 'unsigned hyper' and ignores the 'hyper', effectively mapping that to an unsigned 32-bit value and

Re: [Libreoffice] [Libreoffice-qa] error checking in Base ODBC

2011-10-24 Thread Stephan Bergmann
On 10/24/2011 05:59 PM, Terrence Enger wrote: I shall proceed with that. And, unless somebody tells me otherwise, I shall indulge myself with OSL_ENSURE() on the return values. Note that OSL_ENSURE, OSL_ASSERT, and OSL_FAIL should only be used for logic errors (i.e., the program detects that

Re: [Libreoffice] [Libreoffice-commits] .: writerperfect/source

2011-10-25 Thread Stephan Bergmann
On 10/25/2011 04:04 AM, Kevin Hunter wrote: At 9:48pm -0400 Mon, 24 Oct 2011, Kevin Hunter wrote: At 7:24pm -0400 Mon, 24 Oct 2011, Fridrich Štrba wrote: for (std::mapWPXString, FontStyle *, ltstr::const_iterator iter = mHash.begin(); - iter != mHash.end(); ++iter) + iter != mHash.end();

Re: [Libreoffice] [PATCH] [PUSHED] Match the correct function template specialization (in autodoc)

2011-10-25 Thread Stephan Bergmann
Kris, The patches you sent are great; if you would want to apply for direct commit access (http://wiki.documentfoundation.org/Development#Getting_and_using_commit_access) -- go ahead, I'd say! Stephan ___ LibreOffice mailing list

Re: [Libreoffice] SmART Gallery as integrated part of LibreOffice core

2011-10-26 Thread Stephan Bergmann
On 10/25/2011 10:50 PM, Kálmán „KAMI” Szalai wrote: We (my friend Tibusz and me) are thinking about to integrate SmART into LibreOffice suite. I hope you saw the ligtning talk about SmART. What you think about this extension? What is your opinion about the integration? We know this is currently

Re: [Libreoffice] SmART Gallery as integrated part of LibreOffice core

2011-10-26 Thread Stephan Bergmann
(don't get me wrong, folks; I have nothing against adding it into the core, was just wondering what the benefits of the rewrite would be) Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [Libreoffice] Dumping to valgrind.log from soffice shell script needed?

2011-10-26 Thread Stephan Bergmann
On 10/26/2011 01:55 PM, Petr Mladek wrote: What is your preferred way of use? What exactly do you hate and/or miss? One problem is output of multiple (batched, like make subsequentcheck) valgrind'ed invocations of soffice.bin is lost. Another problem is attaching a debugger

Re: [Libreoffice] semantics of ScBaseCell* lclCloneCell

2011-10-27 Thread Stephan Bergmann
On 10/27/2011 07:10 AM, Kevin Hunter wrote: I'm nosing around ScBaseCell in sc/source/core/data/cell.cxx, and I'm curious about the semantics of the function lclCloneCell. Specifically, when would that function ever return a NULL pointer? Does Calc not know about all its cell types? Perhaps

Re: [Libreoffice] compilation issues of apple_remote

2011-10-27 Thread Stephan Bergmann
On 10/27/2011 08:36 AM, Jonathan Aquilina wrote: I will give these a shot i have symbols enabled and at a certain point its complaining about missing 64bit symbols. How come for users on 10.7 we dont have a native 64bit build as 10.7 runs as 64bit out of the box? Jonathan, just for

Re: [Libreoffice] (real) Windows build, needs help.

2011-10-27 Thread Stephan Bergmann
On 10/26/2011 09:52 PM, Kohei Yoshida wrote: C:/libo/core-master/solenv/gbuild/Package.mk:33: *** gb_Deliver_deliver: file does not exist in solver, and cannot be delivered: /cygdrive/c/libo/core-master/solver/wntmsci12.pro/bin/soffice_bin.exe.manifest. Voreppe Win32 tinderbox fails with the

Re: [Libreoffice] [REVIEW-3-4-4] )one more needed) fix ole automation bridge handling of SAFEARRAY (fdo#38441)

2011-10-27 Thread Stephan Bergmann
On 10/27/2011 11:58 AM, Noel Power wrote: and like the subject says. one more needed for 3.4.4 With the same caveat like the other reviewers -- I'm rather illiterate with COM/OLE -- the change does look reasonable to me. So go ahead! Stephan

Re: [Libreoffice] Mac OSX daily build 26/10/2011 - Base Report Builder, Beanshell, and Javascript extensions disabled

2011-10-28 Thread Stephan Bergmann
On 10/28/2011 10:07 AM, Alexander Thurgood wrote: I can also confirm this with my own build from master from this morning 28/10/2011, build ID : I'm having a look. Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [Libreoffice] Mac OSX daily build 26/10/2011 - Base Report Builder, Beanshell, and Javascript extensions disabled

2011-10-28 Thread Stephan Bergmann
On 10/27/2011 05:33 PM, Alexander Thurgood wrote: In the daily build from 26/10/2011 the following extensions are present, but disabled/non-functional. If you inspect the list of installed extensions these appear greyed out. [...] See : https://bugs.freedesktop.org/show_bug.cgi?id=42312

Re: [Libreoffice] Mac OSX daily build 26/10/2011 - Base Report Builder, Beanshell, and Javascript extensions disabled

2011-10-28 Thread Stephan Bergmann
On 10/28/2011 10:07 AM, Alexander Thurgood wrote: I can also confirm this with my own build from master from this morning 28/10/2011, build ID : [...] --enable-ext-barcode Kami, can you help me? Just asked on #libreoffice-dev: does anybody know anything about the barcode extension?

Re: [Libreoffice] Replace (Byte|Uni|Xub_)String with O(U)String: Fill() method is missing

2011-10-31 Thread Stephan Bergmann
On 10/29/2011 10:18 PM, Chr. Rossmanith wrote: the deprecated string classes have a Fill(n,c) method which fills a string with a single character c repeated n times. I found ~50 occurrences of Fill() using git grep, so it might be worth to add a Fill() method to OUString. Maybe the name of the

Re: [Libreoffice] Debug build compilation fail

2011-10-31 Thread Stephan Bergmann
On 10/31/2011 02:20 PM, Rafael Dominguez wrote: I tried to compile all the project with debug flags enabled ( --enable-dbgutil --enable-debug ) , and im getting this error Compiling: connectivity/source/drivers/mozab/bootstrap/MNSINIParser.cxx In file included from

Re: [Libreoffice] gravity of raised assertions?

2011-10-31 Thread Stephan Bergmann
On 10/31/2011 03:31 PM, Terrence Enger wrote: There has been a lot of discussion in the past about raised assertions and how seriously they should be treated. Is there a current concensus? I raise the question again for no better reason than that even a newbie like me can see a raised

Re: [Libreoffice] Mac OSX daily build 26/10/2011 - Base Report Builder, Beanshell, and Javascript extensions disabled

2011-11-02 Thread Stephan Bergmann
On 11/01/2011 10:33 PM, Kálmán „KAMI” Szalai wrote: I not tested Barcode on current master. I will do it in this week. I hope I can provide the right extnsion soon. Great. Let me know if you have any trouble. The included barcode-loader.py apparently still uses active registration, but does

Re: [Libreoffice] [PUSHED-3-4] another build break in 3.4.x

2011-11-02 Thread Stephan Bergmann
On 11/01/2011 08:59 PM, Andreas Radke wrote: osl_Security.cxx:216:Assertion Test name: N12osl_Security10getHomeDirE::getHomeDir_001 assertion failed - Expression: ( sal_True == strHomeDirectory.equals( strHome ) ) ( sal_True == bRes ) - #test comment#: getHomeDir and compare it with the info we

Re: [Libreoffice] gravity of raised assertions?

2011-11-02 Thread Stephan Bergmann
On 11/01/2011 05:50 PM, Lubos Lunak wrote: On Monday 31 of October 2011, Stephan Bergmann wrote: For me at least, this implies that all occurrences of firing assertions should be tracked and fixed. (For me at least, this also implies that assertions---OSL_ASSERT, OSL_ENSURE, OSL_FAIL

Re: [Libreoffice] Replace (Byte|Uni|Xub_)String with O(U)String: Fill() method is missing

2011-11-02 Thread Stephan Bergmann
On 11/01/2011 07:50 PM, Eike Rathke wrote: Wouldn't they benefit/suffer from the stable ABI requirement then, whereas in comphelper they don't? Or am I mislead? Yup, that was the original rationale for introducing comphelper/string.hxx, see the comment at the start of the file. Stephan

Re: [Libreoffice] Replace (Byte|Uni|Xub_)String with O(U)String: Fill() method is missing

2011-11-03 Thread Stephan Bergmann
On 11/02/2011 05:21 PM, Michael Meeks wrote: The benefits of the stable ABI requirement are somewhat unclear to me. Mostly for the benefit of (external) client code. Also, as a secondary effect, striving for a stable API probably tends to make the authors of the API work harder to

Re: [Libreoffice] String-rtl::OUString and removed unused code in vcl

2011-11-03 Thread Stephan Bergmann
On 11/03/2011 01:40 AM, August Sodora wrote: It seems to me that class ApplicationAddress in vcl/svapp.hxx is unused and that ApplicationEvent has two useless fields, one for the application address and another string that is always empty and never compared against or modified. I've attached a

[Libreoffice] Registering UNO services/types of optional modules

2011-11-03 Thread Stephan Bergmann
http://cgit.freedesktop.org/libreoffice/core/commit/?id=8524330a746da6bd26ca5676b48cdce6bb722380 Simplify addition of optional components to URE_MORE_{SERVICES,TYPES}. brings the following change: The URE_MORE_SERVICES and URE_MORE_TYPES bootstrap variables now understand new syntax to not

Re: [Libreoffice] Registering UNO services/types of optional modules

2011-11-03 Thread Stephan Bergmann
On 11/03/2011 11:08 AM, Michael Meeks wrote: Of all the .component files currently lumped together into the single LibO services.rdb (see postprocess/packcomponents/makefile.mk), quite a number belong to optional modules and should thus go into discrete .rdbs. There's clean up work ahead... ;)

Re: [Libreoffice] [PUSHED] String-rtl::OUString and removed unused code in vcl

2011-11-04 Thread Stephan Bergmann
On 11/03/2011 09:30 AM, Stephan Bergmann wrote: On 11/03/2011 01:40 AM, August Sodora wrote: It seems to me that class ApplicationAddress in vcl/svapp.hxx is unused and that ApplicationEvent has two useless fields, one for the application address and another string that is always empty

[Libreoffice] Extension dependencies

2011-11-04 Thread Stephan Bergmann
Hi all, As already mentioned briefly in my talk at LOCon, we need to make up our mind how to handle LO extension dependencies. Each .oxt extension can carry any number of dependencies, specifying conditions that need to be met by the hosting LO installation for the extension to be

Re: [Libreoffice] [REVIEW] 3-4 cherry-pick fix to build with gcj 1.5.0

2011-11-04 Thread Stephan Bergmann
On 11/04/2011 12:41 PM, Caolán McNamara wrote: i.e. com.sun.org.apache.xerces.internal.parsers.DOMParser is a sun/oracle-only java api. Commit http://cgit.freedesktop.org/libreoffice/core/commit/?id=04c5a36ab8d514cfbe8e40f4493787b2ab392ab5 (attached) I believe does the right thing, definitely

Re: [Libreoffice] [REVIEW] 3-4 cherry-pick fix to build with gcj 1.5.0

2011-11-04 Thread Stephan Bergmann
On 11/04/2011 02:53 PM, Caolán McNamara wrote: On Fri, 2011-11-04 at 14:01 +0100, Stephan Bergmann wrote: That is, the call to DocumentBuilderFactory.newInstance() within OfficeDocumentReportTarget would need to be wrapped Erm... http://opengrok.libreoffice.org/search?q

Re: [Libreoffice] [REVIEW] 3-4 cherry-pick fix to build with gcj 1.5.0

2011-11-04 Thread Stephan Bergmann
On 11/04/2011 04:55 PM, Caolán McNamara wrote: On Fri, 2011-11-04 at 16:23 +0100, Stephan Bergmann wrote: Anyway, you have been warned. ;) Pfff, seems a sure route to madness to have to second guess every possible java api over and above its documentation in case it uses some

Re: [Libreoffice] gcc bug on Debian packages ?

2011-11-06 Thread Stephan Bergmann
On 11/06/2011 08:04 PM, julien2412 wrote: #2 0xb7c01d42 in *__GI_abort () at abort.c:92 #3 0xb7c3eaeb in malloc_printerr (action=2, str=0x6Address 0x6 out of bounds, ptr=0xb7e72950) at malloc.c:6288 #4 0xb7c43446 in *__GI___libc_free (mem=0x6) at malloc.c:3699 #5 0xb7e3cabf in operator

[Libreoffice] [PATCH] fix libreoffice-3-4 after make the 3D transitions work again

2011-11-07 Thread Stephan Bergmann
-of-ogltrans.component.patch would fix that for me. Please sign-off and commit. Stephan From 8ded95d08c34ab0253530f855b4e6a77d3c8c356 Mon Sep 17 00:00:00 2001 From: Stephan Bergmann sberg...@redhat.com Date: Mon, 7 Nov 2011 21:23:24 +0100 Subject: [PATCH] Fix build of ogltrans.component ...now

[Libreoffice] SolidMarkHandles

2011-11-08 Thread Stephan Bergmann
Hi all, Looks like http://cgit.freedesktop.org/libreoffice/core/commit/?id=ec4f69493b50c15861b0cdcc290ecedd00efb51d removed Simple Handles option removed support for SolidMarkHandles property from sw/source/ui/uno/unomod.cxx while it is still listed in

Re: [Libreoffice] Extension dependencies

2011-11-09 Thread Stephan Bergmann
On 11/04/2011 01:33 PM, Eike Rathke wrote: On Friday, 2011-11-04 13:02:02 +0100, Thorsten Behrens wrote: I'd tend to give the fine-grained dependencies a try. That won't work in practice, unless those can be (semi-)automatically generated. Experience shows that all programmers are lazy, and

Re: [Libreoffice] SolidMarkHandles

2011-11-10 Thread Stephan Bergmann
On 11/08/2011 10:29 PM, Stephan Bergmann wrote: Given that SolidMarkHandles is listed in com.sun.star.text.ViewSettings, it is unclear to me whether it should indeed be removed? From private replies I received, I gather that the above was probably not phrased clearly enough to get my point

Re: [Libreoffice] Extension dependencies

2011-11-10 Thread Stephan Bergmann
On 11/10/2011 12:24 PM, Cor Nouws wrote: b. Will it be necessary with the new LibreOffice-minimal-version dependency to have separate extensions for LibreOffice and OpenOffice or will that be optional? As long as a given extension works fine with both LO and OOo, there's no need to add a

[Libreoffice] New LO_{LIB, JAVA}_DIR make special inbuild component handling superfluous

2011-11-10 Thread Stephan Bergmann
http://cgit.freedesktop.org/libreoffice/core/commit/?id=c1bd2a254b4a22a02d515b084dabafe963f175ff does away with the need for specially crafted *.inbuild.component files. It replaces the $BRAND_BASE_DIR/program[/classes] paths in the component files with ones based on new bootstrap varialbes

Re: [Libreoffice] build fail in scripting/Jar/aportisdoc

2011-11-10 Thread Stephan Bergmann
On 11/11/2011 08:03 AM, Noel Grandin wrote: c:\libreoffice\libo\scripting\java\com\sun\star\script\framework\provider\java\ScriptProviderForJava.java:50: package com.sun.star.script.framework.container does not exist import com.sun.star.script.framework.container.ScriptMetaData; We used to

Re: [Libreoffice] Dumping to valgrind.log from soffice shell script needed?

2011-11-11 Thread Stephan Bergmann
On 10/26/2011 09:00 PM, Stephan Bergmann wrote: On 10/26/2011 01:55 PM, Petr Mladek wrote: What is your preferred way of use? What exactly do you hate and/or miss? One problem is output of multiple (batched, like make subsequentcheck) valgrind'ed invocations of soffice.bin is lost. Another

[Libreoffice] [PATCH/REVIEW-3-4] Backport reading AES-encrypted ODF 1.2 documents (as genereated by LibO 3.5)

2011-11-11 Thread Stephan Bergmann
With LO 3.5 by default using (new in ODF 1.2) AES encryption for password-protected documents (instead of Blowfish as used in older versions), people still using LO 3.4 would be unable to open such documents. (And what's really ugly, all they would get is an incomprehensible error box Format

[Libreoffice] Make .component files directly usable within UNO_SERVICES

2011-11-11 Thread Stephan Bergmann
http://cgit.freedesktop.org/libreoffice/core/commit/?id=f66ac2934303e789014741547a06c98ab5433ca0 makes tests a little simpler (but also requires another round of find */${INPATH?}/ -name \*.component -exec rm {} \; for non-clean builds): * solenv/bin/createcomponent.xslt now simply surrounds

Re: [Libreoffice] [PATCH/REVIEW-3-4] Backport reading AES-encrypted ODF 1.2 documents (as genereated by LibO 3.5)

2011-11-11 Thread Stephan Bergmann
On 11/11/2011 11:12 AM, Cor Nouws wrote: Stephan Bergmann wrote (11-11-11 10:50) is a patch (actually, four separate patches for the components, lib-core, lib-gui, and ure repos) to backport support for reading (but not writing) AES-encrypted ODF 1.2 documents to libreoffice-3-4. Is included

Re: [Libreoffice] Howto develop an extension with URE?

2011-11-13 Thread Stephan Bergmann
On 11/12/2011 12:43 PM, Michael Meeks wrote: It seems a nonsense to me to not ship the pre-built C++ headers in the sdk - particularly if that would make things easier for developers. Stephan - is there a really good reason for not doing that ? clearly the easier we make the sdk

Re: [Libreoffice] Howto develop an extension with URE?

2011-11-14 Thread Stephan Bergmann
On 11/12/2011 03:09 PM, Christian Ehrlicher wrote: Ok, next step - is it correct that I don't need a custom rdb anymore? The example formerly created an own rdb but is now using offapi.rdb from basis- link/program The old rdb creation procedure also used some libs which are not there anymore -

Re: [Libreoffice] [PATCH] Replace command domainname by getdomainname() on Unix

2011-11-14 Thread Stephan Bergmann
On 11/13/2011 03:42 PM, Lionel Elie Mamane wrote: On Sun, Nov 13, 2011 at 03:04:57PM +0100, Arnaud Versini wrote: I've seen it is used by using gdb on _osl_getFullQualifiedDomainName. I don't remember how but I could provide you the bt after the build. It's not directly but

Re: [Libreoffice] Updating external to new version: mysqlcppconn

2011-11-14 Thread Stephan Bergmann
On 11/13/2011 02:41 AM, Lionel Elie Mamane wrote: 2) The tarball downloaded from mysql.com unpacks into mysql-connector-c++-1.1.0, not mysql-connector-cpp. Am I supposed to repackage the tarball so that it unpacks into mysql-connector-cpp or to change makefile.mk to adapt to the new

Re: [Libreoffice] compile fails: solver/unxlngx6.pro/xml/ure/services.rdb not created

2011-11-14 Thread Stephan Bergmann
On 11/13/2011 01:28 PM, Luc Castermans wrote: So I read 2 different names: uno_services.rdb and service.rdb; should they be identical? No, those two files are unrelated. Your initial problem (missing solver/unxlngx6.pro/xml/ure/services.rdb is odd). What does . Env.Host.sh cd

Re: [Libreoffice] compile fails: solver/unxlngx6.pro/xml/ure/services.rdb not created

2011-11-14 Thread Stephan Bergmann
On 11/13/2011 10:11 PM, Chr. Rossmanith wrote: So it's save to remove .component files because they are regenerated during building LibO? And the same is valid for .rdb's? Removing .component files in the output should always be safe. For .rdb files, some of them (the services ones) are

Re: [Libreoffice] [Bug 42865] New: MySQL native driver: free() on non-heap pointer; in debug mode abort()

2011-11-14 Thread Stephan Bergmann
Lionel, I must admit I'm confused. On my system, ~ objdump -T /usr/lib64/libstdc++.so.6 | grep _ZNSs4_Rep20_S_empty_rep_storageE 003e504f45a0 gDO .bss 0020 GLIBCXX_3.4 _ZNSs4_Rep20_S_empty_rep_storageE ~ objdump -T /usr/lib64/libmysqlcppconn.so | grep

Re: [Libreoffice] [PUSHED] add sqlite path to library path for unit tests

2011-11-15 Thread Stephan Bergmann
On 11/14/2011 11:49 PM, Markus Mohrhard wrote: could someone without system libsqlite give the following patch a try. Apply and rebuild sc. In theory the testPassword test should work without a problem. Checked on Linux with system libsqlite3.so removed. I tweaked the patch a little,

Re: [Libreoffice] [PUSHED] add sqlite path to library path for unit tests

2011-11-15 Thread Stephan Bergmann
On 11/15/2011 10:14 AM, Thorsten Behrens wrote: Stephan Bergmann wrote: I noticed that many of the recently introduced solenv/gbuild/platform/OS_CPU_COMPILER.mk hardcode the value of gb_CppunitTest_CPPTESTPRECOMMAND, instead of going through gb_Helper_set_ld_path where applicable... Sounds

Re: [Libreoffice] Extension dependencies

2011-11-15 Thread Stephan Bergmann
On 11/09/2011 09:45 AM, Stephan Bergmann wrote: So, I think I will just introduce a new LibreOffice-minimal-version dependency after all. http://cgit.freedesktop.org/libreoffice/core/commit/?id=8a993919377f0b602b7db88d1de6696b21a11cbf does that, see https://wiki.documentfoundation.org

Re: [Libreoffice] Extension dependencies

2011-11-15 Thread Stephan Bergmann
On 11/15/2011 01:39 PM, Christophe Strobbe wrote: At 09:59 4-11-2011, Stephan Bergmann wrote: Each .oxt extension can carry any number of dependencies, specifying conditions that need to be met by the hosting LO installation for the extension to be successfully deployable (see http

Re: [Libreoffice] Extension dependencies

2011-11-15 Thread Stephan Bergmann
On 11/15/2011 04:53 PM, Christophe Strobbe wrote: Ah, yes. I was hoping to find some information on the Others item in the list of child elements at http://wiki.services.openoffice.org/wiki/Documentation/DevGuide/Extensions/Description_of_XML_Elements#Element_.2Fdescription.2Fdependencies. My

Re: [Libreoffice] [Libreoffice-commits] .: sc/inc sc/source

2011-11-15 Thread Stephan Bergmann
On 11/16/2011 06:45 AM, Kohei Yoshida wrote: I would encourage you to not do this style of implicit inlining in your code, sure, but I wouldn't want you go wild and start editing a bunch of headers just for the sake of it. While we are at it: Not inlining functions can be especially

Re: [Libreoffice] Extension dependencies

2011-11-15 Thread Stephan Bergmann
On 11/15/2011 05:33 PM, Christophe Strobbe wrote: Actually, the first times I tried to install the extension, I got an empty error dialog (I assumed it was an error dialog), and the system froze. More recently, I tried a more recent version of the extension, and this time I got the error dialog

Re: [Libreoffice] uno discoverability

2011-11-16 Thread Stephan Bergmann
On 11/16/2011 11:25 AM, Michael Meeks wrote: IMHO we need to make that code efficient by having a var-args style helper: throw FooException(Failure loading file '%S' code %d, aOUStr.pData, nCode); That would also be fairly code size efficient

Re: [Libreoffice] [Libreoffice-commits] .: testtools/source

2011-11-16 Thread Stephan Bergmann
On 11/17/2011 12:38 AM, Jan Holesovsky wrote: testtools/source/bridgetest/makefile.mk |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 4f11d0aa461537efa2705e7b49bc2c828a700e43 Author: Jan Holesovskyke...@suse.cz Date: Wed Nov 16 22:57:28 2011 +0100

Re: [Libreoffice] [PATCH/REVIEW-3-4] Backport reading AES-encrypted ODF 1.2 documents (as genereated by LibO 3.5)

2011-11-17 Thread Stephan Bergmann
On 11/11/2011 12:01 PM, Stephan Bergmann wrote: On 11/11/2011 11:12 AM, Cor Nouws wrote: Is included in the patch, that when a encrypted document is opened in 3.4.n and saved again, people are informed about the change in encryption? No. I see. When you modify and save an encrypted

Re: [Libreoffice] [Libreoffice-qa] [REVIEWED] Backport reading AES-encrypted ODF 1.2 documents (as genereated by LibO 3.5)

2011-11-17 Thread Stephan Bergmann
On 11/17/2011 12:42 PM, Michael Meeks wrote: On Thu, 2011-11-17 at 10:30 +, Caolán McNamara wrote: On Thu, 2011-11-17 at 10:10 +, Michael Meeks wrote: Out of interest - has Fedora shipped this yet ? and what was the feedback like ? It's in rawhide, i.e. will-be-F17, so its

Re: [Libreoffice] Unable to build moz

2011-11-17 Thread Stephan Bergmann
On 11/16/2011 05:23 PM, Marc-André Laverdière wrote: My autogen options now are: --with-num-cpus=4 --with-system-libs --with-system-headers --with-system-dicts --enable-lto Maybe --enable-lto is not a good idea. Stephan ___ LibreOffice mailing list

Re: [Libreoffice] unable to pass tests ...

2011-11-17 Thread Stephan Bergmann
On 11/17/2011 05:16 PM, Kevin Hunter wrote: - file://[...]/libreoffice/workdir/unxlngx6.pro/ComponentTarget/uno xml/source/rdf/unordf.component: component has empty uri attribute Looks like you fell victim to the component file mess (where last round of mess there was that a make clean in one

Re: [Libreoffice] [PATCH/REVIEW-3-4] Backport reading AES-encrypted ODF 1.2 documents (as genereated by LibO 3.5)

2011-11-18 Thread Stephan Bergmann
On 11/17/2011 10:37 PM, Cor Nouws wrote: Stephan Bergmann wrote (17-11-11 09:02) On 11/11/2011 11:12 AM, Cor Nouws wrote: Is included in the patch, that when a encrypted document is opened in 3.4.n and saved again, people are informed about the change in encryption? No. I see. When you

Re: [Libreoffice] [PUSHED, partial] Remove NULL checks from delete

2011-11-18 Thread Stephan Bergmann
On 11/10/2011 12:05 AM, Andrew Douglas Pitonyak wrote: I would feel safer if pointers were set to NULL (or nullptr if we support C++11) since it is not safe to delete a pointer twice. I would rather argue that adding redundant p = 0; following a delete p; makes our code worse, not better

Re: [Libreoffice] Build fail in binfilter on Ubuntu 11.10

2011-11-18 Thread Stephan Bergmann
On 11/17/2011 08:16 PM, Alex Thurgood wrote: If I disable the binfilter compilation, the build completes. This is with the latest pulls from master, and even after a make clean. But you also pulled the binfilter repo (./g pull), right? Stephan ___

Re: [Libreoffice] [PATCH/REVIEW-3-4] Backport reading AES-encrypted ODF 1.2 documents (as genereated by LibO 3.5)

2011-11-18 Thread Stephan Bergmann
On 11/18/2011 02:21 PM, Cor Nouws wrote: So I have to interpret it as: an encrypted document from 3.5 opened in 3.4 will be saved with the old encryption, without notice? Yes. Sorry for my unclear muttering. Stephan ___ LibreOffice mailing list

Re: [Libreoffice] [REVIEWED] [PUSHED] Backport reading AES-encrypted ODF 1.2 documents (as genereated by LibO 3.5)

2011-11-18 Thread Stephan Bergmann
On 11/17/2011 01:41 PM, Stephan Bergmann wrote: Yes, I can do the inclusion into -3-4. AFAIU, Michael Stahl was also just looking at the patch, will wait until he gives a green light, too. Pushed as http://cgit.freedesktop.org/libreoffice/components/commit/?h=libreoffice-3-4id

Re: [Libreoffice] [PATCH/REVIEW-3-4] Backport reading AES-encrypted ODF 1.2 documents (as genereated by LibO 3.5)

2011-11-20 Thread Stephan Bergmann
On 11/19/2011 09:40 AM, Cor Nouws wrote: So for the release notes something as follows would be appropriate: 3.4.5 In LibreOffice 3.5 a new stronger encryption will be introduced. As consequence files encrypted in LibreOffice 3.5 can not be opened by LibreOffice 3.4.4 and earlier. LibreOffice

Re: [Libreoffice] URE bootstrap - error establishing connection ?

2011-11-21 Thread Stephan Bergmann
On 11/18/2011 08:51 PM, Christian Ehrlicher wrote: When I try to connect to libreoffice over a uno socket (com.sun.star.bridge.UnoUrlResolver) in most cases I need to try at least two times because the socket is not (yet) open: Cannot establish a connection using

Re: [Libreoffice] uno discoverability

2011-11-21 Thread Stephan Bergmann
On 11/17/2011 06:55 PM, Michael Meeks wrote: On Wed, 2011-11-16 at 14:16 +0100, Stephan Bergmann wrote: throw FooException(Failure loading file '%S' code %d, ... This (as well as cooking something up using OSL_FORMAT) would have the disadvantage that it potentially converts data from

Re: [Libreoffice] Assertions and Logging

2011-11-21 Thread Stephan Bergmann
On 11/21/2011 01:30 PM, Caolán McNamara wrote: On Fri, 2011-11-18 at 15:25 +0100, Stephan Bergmann wrote: Alright, so we end up with use assert if you want an assert SAL_WARN if you want to warn about something odd, but which isn't necessarily definitely wrong SAL_INFO for verbose logging

Re: [Libreoffice] Assertions and Logging

2011-11-21 Thread Stephan Bergmann
On 11/21/2011 04:14 PM, Terrence Enger wrote: On Mon, 2011-11-21 at 14:30 +0100, Stephan Bergmann wrote: (One thing we could IMO improve though, is to not rely on trying to save open documents from within a signal handler, but instead rely

Re: [Libreoffice] Assertions and Logging

2011-11-21 Thread Stephan Bergmann
On 11/21/2011 04:50 PM, Michael Meeks wrote: Until then, I think we need to stick with the signal handler, sadly, it is truly ugly, and I assume it can deadlock too if the signal happens at certain places wrt. holding mutex', remarkably few posix calls are signal-safe. One indeed

  1   2   3   4   5   6   7   8   9   10   >