Re: [Libreoffice] [PUSHED][PATCH] Refactoring for WMF Loading

2011-10-06 Thread Stephan Bergmann
On 10/05/2011 03:03 PM, Caolán McNamara wrote: Only micro-nit is can leave an argument unnamed rather than self-assign it to avoid an unused parameter warnings, e.g. void foo(int a, int, int c) { } rather than void foo(int a, int b, int c) { b = b; } See also

Re: [Libreoffice] Undoing basis/brand split in 3.5

2011-10-06 Thread Stephan Bergmann
On 09/20/2011 03:11 PM, Stephan Bergmann wrote: As recently announced on #libreoffice-dev, I consider undoing the basis/brand layer split. Historically, this was introduced at Sun to make it possible for various products (plain OpenOffice.org, Brasilian BrOffice re-branding, Sun's proprietary

Re: [Libreoffice] Questions about push access

2011-10-07 Thread Stephan Bergmann
On 10/06/2011 08:22 PM, Ivan Timofeev wrote: 2. What changes should I avoid in my commits? I mean, what changes are unwanted, needless, etc. One thing to watch out for is to avoid pushing accidental merge commits. (It does happen, and is harmless, but also easily avoided.) That is, if you

Re: [Libreoffice] --with-alloc setting

2011-10-07 Thread Stephan Bergmann
On 10/06/2011 07:04 PM, Michael Meeks wrote: Hi Neil, On Thu, 2011-10-06 at 13:45 -0300, Neil Leathers wrote: In running through my build settings I was trying to decide which value to use for --with-alloc=???. Wow - that's a blast from the past. Intel did some work to enable

Re: [Libreoffice] masterbuild 2011-10-03.. Linux x86: oosplash not found

2011-10-07 Thread Stephan Bergmann
On 10/07/2011 10:29 PM, Michael Meeks wrote: On Thu, 2011-10-06 at 17:52 +0200, Cor Nouws wrote: ls oo* No such file or folder... of course copying from an other installation makes the office run... Ho hum; yet your ls output shows it as there: -rwxr-xr-x 1 cono cono

Re: [Libreoffice] masterbuild 2011-10-03.. Linux x86: oosplash not found

2011-10-07 Thread Stephan Bergmann
On 10/07/2011 11:53 PM, Cor Nouws wrote: Cor Nouws wrote (06-10-11 17:52) Now some more fun :-D I installed as followes: - unpacked and ran dpkg-deb in a tmp folder - moved the whole opt to ~/path - changed bootstraprc: ~/LibreOffice/master20111003/lo-dev/program$ emacs bootstraprc

Re: [Libreoffice] Fwd: Re: patch for scan-diialog

2011-10-13 Thread Stephan Bergmann
On 10/12/2011 06:32 PM, Rob Snelders wrote: Can somebody add this patch to the git? Hi Rob, sorry for stepping in so late, just apparently missed your great patch somehow. One thing I'm uneasy with is changing (published) XScannerManager.idl incompatibly. The standard routine for doing

Re: [Libreoffice] [PATCH] Mark ecx register as clobbered (in cpp_uno/gcc3_macosx_intel)

2011-10-15 Thread Stephan Bergmann
On 10/15/2011 01:25 AM, Kristian Rietveld wrote: Without this patch, Cpp bridgetest on a Clang-compiled UNO runtime will not complete successfully. Hm, but the asm code in question does not use ecx at all?!? -Stephan ___ LibreOffice mailing list

Re: [Libreoffice] masterbuild 2011-10-03.. Linux x86: oosplash not found

2011-10-15 Thread Stephan Bergmann
On 10/14/2011 06:00 PM, Cor Nouws wrote: Same with masterbuild 2011-10-13 http://dev-builds.libreoffice.org/daily/Linux_x86_Release_Configuration/master/current/master~2011-10-13_13.16.12_LibO-Dev_OOO350m1_Linux_x86_install-deb_en-US.tar.gz (see the other mail in this thread for how I

Re: [Libreoffice] [PATCH] Mark ecx register as clobbered (in cpp_uno/gcc3_macosx_intel)

2011-10-16 Thread Stephan Bergmann
On 10/15/2011 12:03 PM, Kristian Rietveld wrote: On 10/15/11 10:44 AM, Stephan Bergmann wrote: On 10/15/2011 01:25 AM, Kristian Rietveld wrote: Without this patch, Cpp bridgetest on a Clang-compiled UNO runtime will not complete successfully. Hm, but the asm code in question does not use ecx

Re: [Libreoffice] [PATCH] [PUSHED] Mark ecx register as clobbered (in cpp_uno/gcc3_macosx_intel)

2011-10-17 Thread Stephan Bergmann
On 10/16/2011 03:55 PM, Kristian Rietveld wrote: On 10/16/11 12:02 PM, Stephan Bergmann wrote: Btw, if this is your first patch, please state what license it is under---preferably the LGPLv3+/MPL 1.1 combo---and add yourself to http://wiki.documentfoundation.org/Development/Developers

Re: [Libreoffice] Errors during my first build attempts

2011-10-17 Thread Stephan Bergmann
On 10/16/2011 12:37 PM, Beemen Beshara wrote: Dear all I have been trying to the a full build of LibreOffice on windows XP over the last week. Following the instructions on http://wiki.documentfoundation.org/index.php?title=Development/Native_Build, I finally managed to reach the last step

[Libreoffice] OSL_FORMAT: printf-style assertion messages

2011-10-17 Thread Stephan Bergmann
FYI, recently added OSL_FORMAT to ols/diagnose.h that lets you have printf-style messages in C++ OSL_ENSURE, OSL_FAIL, DBG_ASSERT, etc. To be used a la OSL_ENSURE(i == 5, OSL_FORMAT(i should be 5 but is %d, i)); -Stephan ___ LibreOffice mailing

[Libreoffice] recent push requires ~fresh rebuild

2011-10-18 Thread Stephan Bergmann
http://cgit.freedesktop.org/libreoffice/core/commit/?id=fd1db0b8eba8e86c5a7e1a3c685e76975d21d93c Undo basis/brand split: move program/classes/ from basis to brand. requires manual tweaking in a rebuild, as it changes content of generated .component files based on changes in the central

Re: [Libreoffice] [Libreoffice-commits] .: officecfg/registry

2012-01-24 Thread Stephan Bergmann
On 01/24/2012 04:22 PM, Fridrich Strba wrote: officecfg/registry/data/org/openoffice/VCL.xcu |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 86bf32c487852f4e466b27320e3724266cb53dba Author: Fridrich Štrbafridrich.st...@bluewin.ch Date: Tue Jan 24 16:22:15 2012

Re: [Libreoffice] Database of areas for SAL_INFO etc.

2012-01-24 Thread Stephan Bergmann
On 01/24/2012 04:40 PM, Lubos Lunak wrote: I intend to put just a short note to the documentation in sal/log.hxx pointing to this file (so that additions wouldn't trigger rebuilds), but I'm not sure where to put the file itself. I've been thinking sal/DEBUG , but that doesn't look very good to

Re: [Libreoffice] Database of areas for SAL_INFO etc.

2012-01-24 Thread Stephan Bergmann
On 01/24/2012 06:01 PM, Stephan Bergmann wrote: like log-documentation.txt ... or log-areas.txt ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Storage of user's configuration

2012-01-24 Thread Stephan Bergmann
On 01/24/2012 04:22 PM, Martin Richard wrote: I'm hacking the cross-platform filepicker (in fpicker/source/office). I added a Places (bookmarks) list on the left and I would like to save the entries that the user bookmarked . Cedric Bosdonnat told me to look at xcu and xcs files, but I'm a bit

Re: [Libreoffice] [Libreoffice-commits] .: vcl/source fix rendering of metafiles embedded in emf+

2012-01-24 Thread Stephan Bergmann
Radek, bisecting showed me that it is this commit that causes my machine to become unresponsive (as the involved soffice.bin process keeps growing in size, apparently without limit) when executing the forms_unoapi test (during make check) -- and it is also most likely this commit that causes

Re: [Libreoffice] [Libreoffice-commits] .: vcl/android WaE: unused parameter 'nType'

2012-01-24 Thread Stephan Bergmann
On 01/25/2012 12:15 AM, Tor Lillqvist wrote: WaE: unused parameter 'nType' diff --git a/vcl/android/androidinst.cxx b/vcl/android/androidinst.cxx index 91971e6..08c01ae 100644 --- a/vcl/android/androidinst.cxx +++ b/vcl/android/androidinst.cxx @@ -68,6 +68,7 @@ void

Re: [Libreoffice] [PATCH] Reduced duplicate code detected by simian

2012-01-24 Thread Stephan Bergmann
On 01/24/2012 10:32 PM, Christina Roßmanith wrote: Could someone please review it? It builds successfully but I'm unsure about where to use const... In short, marking a member function const can (and should) be done whenever the function does not modify its object, and does not itself call

Re: [Libreoffice] [Libreoffice-commits] .: vcl/source fix rendering of metafiles embedded in emf+

2012-01-25 Thread Stephan Bergmann
On 01/25/2012 09:33 AM, Radek Doulik wrote: I have reverted the patch and will try to replicate the problem and fix it. Thanks for info and sorry for the trouble. Looks like it is a memory leak in ImplPlayWithRenderer, just having a look there myself right now. Stephan

Re: [Libreoffice] [Libreoffice-commits] .: vcl/source fix rendering of metafiles embedded in emf+

2012-01-25 Thread Stephan Bergmann
On 01/25/2012 09:53 AM, Stephan Bergmann wrote: On 01/25/2012 09:33 AM, Radek Doulik wrote: I have reverted the patch and will try to replicate the problem and fix it. Thanks for info and sorry for the trouble. Looks like it is a memory leak in ImplPlayWithRenderer, just having a look

Re: [Libreoffice] [Libreoffice-commits] .: vcl/source fix rendering of metafiles embedded in emf+

2012-01-25 Thread Stephan Bergmann
One thing I did notice with the first hunk of your patch is that it moved pAction = NextAction(); outside the for loop -- but that looks irrelevant to the problem at hand, as ImplPlayWithRenderer appears to always return true in the newly introduced if here. Also, forms_unoapi now triggers

Re: [Libreoffice] Wrong cast to css.table.BorderLine2

2012-01-25 Thread Stephan Bergmann
On 01/25/2012 09:48 AM, Cedric Bosdonnat wrote: Hum, I'll have a look at that... but my problem with BorderLine and BorderLine2 is that the second one should be used everywhere... and that sometimes isn't the case. You apparently need a css.table.TableBorder2 that has members of type

Re: [Libreoffice] Changing list setup to not add to subject

2012-01-25 Thread Stephan Bergmann
On 01/25/2012 12:04 PM, Lubos Lunak wrote: if I wanted to get all those useless duplicates of replies to my mails, I would have said so. This might be a controversial issue. While I too feel I don't require to receive a personal to/cc in a response to a mail I sent to the list, I already

[Libreoffice] More information in tinderbox failure mails.

2012-01-25 Thread Stephan Bergmann
http://cgit.freedesktop.org/libreoffice/contrib/buildbot/commit/?id=718756193736a7b0918b6ed3c62a5680b51614f2 adds more information to tinderbox failure mails, which should (hopefully) make it easier for people to understand what's going on: * The name of the tinderbox and of the branch (i.e.,

Re: [Libreoffice] [REVIEW] NetBSD fixes

2012-01-26 Thread Stephan Bergmann
On 01/25/2012 08:24 PM, Francois Tigeot wrote: I've just pushed two small fixes to -master and I'd like to have them cherry-picked to the 3.5 and 3.5.0 branches: * Ensure Env.Host.sh always return a zero exit code

Re: [Libreoffice] [Libreoffice-commits] .: vcl/source fix rendering of metafiles embedded in emf+

2012-01-26 Thread Stephan Bergmann
On 01/26/2012 09:55 AM, Radek Doulik wrote: I am unable to reproduce it here. Do you have some other way to reproduce it other then make check? No, only way I'm aware of is to run forms_unoapi check and watch system's memory consumption grow obsessively (first slowly but steadily, then

Re: [Libreoffice] LibreOffice / openIndiana ...

2012-01-26 Thread Stephan Bergmann
On 01/26/2012 10:52 AM, Norbert Thiebaud wrote: humm... we don't need stlport these day... we only build it for external extensions that may still need it... but surely for OpenSolaris existing base of extension is probably not a critical issue ...and any existing C++ extensions for

Re: [Libreoffice] UNO make me crazy

2012-01-26 Thread Stephan Bergmann
On 01/26/2012 11:22 AM, Execute SARL wrote: I'm always with my Delphi URP client I've made this test 1) start soffice on local host on port 8001 2) start an office proxy of mine on port 8000 that redirect everything to port 8001 and record everything to disk 3) start a python script to load a

Re: [Libreoffice] [REVIEW-3-5-0]

2012-01-26 Thread Stephan Bergmann
On 01/26/2012 10:00 AM, Fridrich Strba wrote: I received a report last night about some WordPerfect documents not being imported (encoded text dialog pops up). I tracked it and this is the fix: http://cgit.freedesktop.org/libreoffice/core/commit/?id=79299dcae534943f6107afc99542ddf028d20117

Re: [Libreoffice] [LibreOffice] [39428] Remove SvStream operator/

2012-01-26 Thread Stephan Bergmann
On 01/26/2012 12:40 PM, Keith McRae wrote: I've removed all the operator/ from SvStream and replaced with Read/Write[sal_type] functions. Great. While fixing up the references I noticed the template'd functions below: templatetypename prefix rtl::OString

Re: [Libreoffice] LibreOffice / openIndiana ...

2012-01-26 Thread Stephan Bergmann
On 01/26/2012 05:56 PM, Caolán McNamara wrote: I see that there *is* one for solaris sparc and gcc (I had to blink a few times when I saw that there was one), i.e. bridges/source/cpp_uno/gcc3_solaris_sparc so you might be incredibly lucky and that's actually buildable and works fine. There's

Re: [Libreoffice] [ANNOUNCE] Branch libreoffice-3-5-0 created

2012-01-26 Thread Stephan Bergmann
On 01/24/2012 09:11 PM, Petr Mladek wrote: there have been created the libreoffice-3-5-0 branch. It will be used for fine tuning of the 3.5.0 release. It is based on the tag libreoffice-3.5.0.2 for 3.5.0-rc2 release. The following rules apply: + only cherry-picking from libreoffice-3-5

Re: [Libreoffice] LibreOffice / openIndiana ...

2012-01-26 Thread Stephan Bergmann
On 01/26/2012 06:55 PM, Michael Meeks wrote: On Thu, 2012-01-26 at 16:52 +, Jonathan Adams wrote: I'm coming to the conclusion that the system doesn't believe I'm using GCC ... nss keeps trying to build with -KPIC, rather than -fPIC ... any suggestions and I'll eagerly try them :)

Re: [Libreoffice] [PUSHED 3-5][REVIEW-3-5-0] Danish dictionary 2.0

2012-01-26 Thread Stephan Bergmann
On 01/26/2012 10:52 PM, Eike Rathke wrote: One thing spotted though: in dictionaries/da_DK/description.xml we have version value=2012.01.14 / Is that really supposed to be '.' separator and not ISO 8601 '-'? Yes, see

Re: [Libreoffice] LibreOffice / openIndiana ...

2012-01-26 Thread Stephan Bergmann
On 01/26/2012 11:17 PM, Norbert Thiebaud wrote: as for the dmake side of thing (solenv/inc/sol*4.mk) something like .IF $(COM)$(OS)$(CPU) == GCCSOLARISX (for intel x86_64 ) or GCCSOLARISI for x86, etc... .INCLUDE : uxnsolg[x|i|..].mk and create such a file based on similar unxix build... look

Re: [Libreoffice] LibreOffice Code Cleanup Patch

2012-01-26 Thread Stephan Bergmann
On 01/27/2012 05:49 AM, Muthu Subramanian K wrote: Its nice to see those patches. But, it will be nice to see/use the tools/scripts directly? Especially if they can be hooked to git (like the current white space/tabs removal ones)? @lubos: Alexander is good with scripts, so as a starter he

Re: [Libreoffice] LibreOffice Code Cleanup Patch

2012-01-26 Thread Stephan Bergmann
On 01/27/2012 07:54 AM, Ivan Timofeev wrote: ... but we have no strong rule about this kind of formatting. The Code Conventions page[1] we refer to in our Development wiki page[2] contains nothing about foo( bar ); vs foo(bar); vs foo (bar); Personally I prefer the second variant, but usually

Re: [Libreoffice] [REVIEW] Revert of UNO interface publishing

2012-01-27 Thread Stephan Bergmann
On 01/27/2012 06:34 AM, Lionel Elie Mamane wrote: On Thu, Jan 26, 2012 at 10:24:52PM +0100, Thorsten Behrens wrote: Michael Meeks wrote: AA: + do the easiest roll-back possible to cleanup the canvas publishing issue in 3.5.0 (Thorsten) Anyway - commit on master is here:

Re: [Libreoffice] problems with encryption if thunderbird is installed

2012-01-27 Thread Stephan Bergmann
On 01/27/2012 12:11 AM, Markus Mohrhard wrote: - the problem is in connectivity/source/drivers/mozab/bootstrap/MNSInit.cxx:228-235 -- the loop is sleeping for 1 ms and therefore running a thousand times per second without doing any real work because there are no events Since this also affects

Re: [Libreoffice] [REVIEW-3-5-0] Revert of UNO interface publishing

2012-01-27 Thread Stephan Bergmann
On 01/27/2012 09:46 AM, Norbert Thiebaud wrote: in the original commit by thorsten 9and not 'fixed by Stephan's) --- a/offapi/com/sun/star/drawing/framework/ConfigurationChangeEvent.idl +++ b/offapi/com/sun/star/drawing/framework/ConfigurationChangeEvent.idl @@ -35,8 +35,9 @@ module com { module

Re: [Libreoffice] PDF converter cross compilation general questions

2012-01-30 Thread Stephan Bergmann
On 01/30/2012 10:25 AM, andrzej.pacanow...@tieto.com wrote: 4) Are the libraries loaded on demand by soffice process or they need to be reachable at the start? If they would be demanded on load it would give us opportunity to remove unnecessary libs. Some are directly linked against while

Re: [Libreoffice] [REVIEW: 3-5-0] fix configuration migration on Linux

2012-01-30 Thread Stephan Bergmann
On 01/30/2012 11:56 AM, Noel Power wrote: pushed ( or will be when the git gc finishes ) to 3-5. extra reviews etc. needed for 3-5-0 Patch looks OK to me for inclusion in -3-5-0. One more review needed. Stephan ___ LibreOffice mailing list

Re: [Libreoffice] [PATCH] [REVIEW:3-5, 3-5-0] fdo#34432 ODBC crash on 64 bits

2012-01-30 Thread Stephan Bergmann
On 01/29/2012 09:36 PM, Lionel Elie Mamane wrote: Attached patch fixes fdo#34432, a crash with some ODBC drivers. The bug report is about Firebird SQL. The attached 0001-fdo-44025-repair-dbaccess-ORowSetCache-isLast-after-.patch appears to be completely unrelated? Stephan

Re: [Libreoffice] [REVIEW:3-5-0][PUSHED] use the correct application icon of Writer/Web under Windows

2012-01-30 Thread Stephan Bergmann
On 01/30/2012 12:04 PM, Michael Stahl wrote: On 30/01/12 12:01, Noel Power wrote: On 27/01/12 18:42, Andras Timar wrote: I made a typo in my soffice.bin/soffice.exe icon reduction patch, so Writer/Web has the wrong application icon under Windows in rc2. The following commit fixes it.

Re: [Libreoffice] LibreOffice / openIndiana ...

2012-01-30 Thread Stephan Bergmann
On 01/27/2012 05:09 PM, Jonathan Adams wrote: I managed to hack together a solaris.mk file (by copying unxgcc.mk and making a few SUN changes) and that got me a little further ... Are we talking new build system solenv/gbuild/platform/{solaris,unxgcc}.mk (where a solaris.mk already exists,

Re: [Libreoffice] [PATCH] [REVIEW:3-5, 3-5-0] fdo#34432 ODBC crash on 64 bits

2012-01-30 Thread Stephan Bergmann
On 01/30/2012 03:43 PM, Lionel Elie Mamane wrote: I attach here the less invasive variant originally meant for libreoffice-3-5. My SQL knowledge is actually zero. For example, I have no idea where to look to verify that for some SQL_ATTR_CURSOR_TYPE, say, SQLGetStmtAttr expects to find a

Re: [Libreoffice] [REVIEW 3-5-0][PUSHED] Updated License document

2012-01-30 Thread Stephan Bergmann
On 01/30/2012 04:32 PM, Petr Mladek wrote: One more approval needed for 3-5-0. Approved and pushed. Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Storage of user's configuration

2012-01-30 Thread Stephan Bergmann
On 01/24/2012 09:38 PM, Stephan Bergmann wrote: One thing that's already there, though, is that if you can indeed go with a single string-list property (lets assume you add it as org.openoffice.Office.Common/Misc/FilePickerBookmarks), you can #include officecfg/Office/Common.hxx and read

Re: [Libreoffice] Duplicate branches for if and else in store/source/storlckb.cxx

2012-01-30 Thread Stephan Bergmann
On 01/30/2012 10:35 PM, julien2412 wrote: Cppchecks reports this : core/store/source/storlckb.cxx 74 duplicateBranch style Found duplicate branches for if and else. Here are the lines : 67 OStoreLockBytes::~OStoreLockBytes (void) 68 { 69 if (m_xManager.is())

Re: [Libreoffice] Simplified C++ configuration access

2012-01-31 Thread Stephan Bergmann
On 01/31/2012 12:23 PM, Michael Meeks wrote: Sounds like a great cleanup, I vaguely advertised it in my blog. Would it be possible to have a simple convert just one-key patch to some old code so newbies can get their cookie cutters correctly calibrated :-)

Re: [Libreoffice] Simplified C++ configuration access

2012-01-31 Thread Stephan Bergmann
On 01/31/2012 11:31 AM, Stephan Bergmann wrote: At the next level, the new unotools/configuration.hxx header provides type-safe C++ wrappers for the various configuration entities on top of the lower level UNO services. For example, the utl::ConfigurationProperty class template can be used

Re: [Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector

2012-01-31 Thread Stephan Bergmann
On 01/31/2012 03:22 PM, Noel Power wrote: I hate these remove list etc. type patches as they tend to be tricky and time consuming to look at ;-) . The patch looked ok for me, hopefully if I missed something ( 'cause these really are tricky ) then someone else will spot it. Anyway thanks again

Re: [Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector

2012-01-31 Thread Stephan Bergmann
On 01/31/2012 05:19 PM, Noel Grandin wrote: I ran make check at the global level - does that not invoke the individual modules check targets? It does. Strange anyway. This failure is consistently reproducible for me and looks suspiciously like the remove problem discussed in this thread...

Re: [Libreoffice] Simplified C++ configuration access

2012-01-31 Thread Stephan Bergmann
On 01/31/2012 03:06 PM, Lubos Lunak wrote: How usual is the case that one does not want to pass comphelper::getProcessComponentContext() to all these functions? Or in other words, why not simply make it the default argument value? Default value indeed looks like a smart move. (In principle,

Re: [Libreoffice] Simplified C++ configuration access

2012-01-31 Thread Stephan Bergmann
On 01/31/2012 04:25 PM, Michael Stahl wrote: default argument would make officecfg depend on comphelper, so you couldn't use the new headers from comphelper implementation. I just moved configuration.hxx from unotools to comphelper today (to then be able to use the officecfg headers in

Re: [Libreoffice] getopt in sal/osl

2012-01-31 Thread Stephan Bergmann
On 02/01/2012 05:14 AM, Norbert Thiebaud wrote: Looking at gbuildifying idlc, I noticed the glibc hack to get a getopt implementation on platform that don't have a native one. so, I wrote a gnu-compatile implementation based on http://www.kernel.org/doc/man-pages/online/pages/man3/getopt.3.html

[Libreoffice] l10ntools clean-up?

2012-02-01 Thread Stephan Bergmann
Hi all, Trying to make comphelper depend on officecfg (to be able to use the new simplified configmgr API in comphelper), this currently fails due to officecfg depending on translations, translations depending on l10ntools, and l10ntools in turn depending on tools (which is pretty high up in

Re: [Libreoffice] minutes of ESC call ...

2012-02-01 Thread Stephan Bergmann
On 01/27/2012 04:44 PM, Markus Mohrhard wrote: * unit test framework issues (Markus) + we are missing an important feature + cppunit development appears dead/stalled for 2+ yrs + but we support system-cppunit + can we not just declare ourselves the new

Re: [Libreoffice] l10ntools clean-up?

2012-02-01 Thread Stephan Bergmann
On 02/01/2012 12:01 PM, Michael Stahl wrote: actually regressions should be easy to prevent here: just build 2 full trees with all options, e.g. enable all extensions, help, all languages; then diff the files produced by the tools. In principle at least (and I'll surely do tests along these

Re: [Libreoffice] getopt in sal/osl

2012-02-01 Thread Stephan Bergmann
On 02/01/2012 04:04 PM, Norbert Thiebaud wrote: I can add in somewhere else... is sounded like sal was a natural... on the other hand it could be re-used in a couple of soltools executable so, maybe I could put it there, as a static lib Note that getopt is used in idlc and rscdep and partially

Re: [Libreoffice] l10ntools clean-up?

2012-02-01 Thread Stephan Bergmann
On 02/01/2012 03:16 PM, Caolán McNamara wrote: On Wed, 2012-02-01 at 09:26 +0100, Stephan Bergmann wrote: Unless there's someone who screams but all this should go away in the next couple months, anyway! I would therefore go ahead and clean that code up, ridding it of any tools dependencies

Re: [Libreoffice] Simplified C++ configuration access

2012-02-01 Thread Stephan Bergmann
On 02/02/2012 08:31 AM, David Tardon wrote: Why don't you generate two overloads of the set function--one taking explicit context argument and the other not? Then the context could remain as the first argument. Yeah, but in some cases there are already overloaded functions (the get functions

Re: [Libreoffice] Question about iterator management in sw/source/core/fields/cellfml.cxx

2012-02-02 Thread Stephan Bergmann
On 02/01/2012 11:40 PM, julien2412 wrote: Cppcheck reports this : core/sw/source/core/fields/cellfml.cxx 970 StlMissingComparisonstyle Missing bounds check for extra iterator increment in loop. Here are the lines : 961 // dann mal die Tabellenkoepfe raus: 962

Re: [Libreoffice] Question about iterator management in sw/source/core/fields/cellfml.cxx

2012-02-02 Thread Stephan Bergmann
On 02/02/2012 10:13 AM, Marcel Metz wrote: If the box that is represented by `it` should be deleted you could use. 970 it = rBoxes.erase( it ); Unfortunately, this is only C++11, not C++03. Stephan ___ LibreOffice mailing list

Re: [Libreoffice] Question about iterator management in sw/source/core/fields/cellfml.cxx

2012-02-02 Thread Stephan Bergmann
On 02/02/2012 11:26 AM, Lubos Lunak wrote: I agree with all the points, but in Julien's defense, I remember exactly this same approach was pushed in recently as a fix to the same issue elsewhere. Might well be, I probably didn't notice. And this is in no way meant to criticize Julien --

Re: [Libreoffice] Question about iterator management in sw/source/core/fields/cellfml.cxx

2012-02-02 Thread Stephan Bergmann
On 02/02/2012 02:06 PM, Lubos Lunak wrote: I definitely didn't mean to get formal here, I simply meant a description of how to actually handle this, as it turns up now and then, and STL doesn't make this trivial. In which case the answer should be to read Item 9 Choose carefully among

Re: [Libreoffice] [REVIEW] [3-5][3-5-0] problems with encryption if thunderbird is installed

2012-02-02 Thread Stephan Bergmann
On 02/02/2012 04:56 PM, Kohei Yoshida wrote: Pushed to 3-5 with my sign-off. We need 2 more sign-off's for 3-5-0. Are we still pushing to -3-5-0? In which case, you have my sign-off. Stephan ___ LibreOffice mailing list

Re: New tool for better understanding the codebase, to complement the wiki.

2012-02-03 Thread Stephan Bergmann
On 02/03/2012 03:56 AM, Josh Heidenreich wrote: Now of course all we need is to add more README files. module configmgr has configmgr/source/README, so either improve the script or move the file... :) Stephan ___ LibreOffice mailing list

Re: TINDERBOX operators: kerberos 5 devel packages

2012-02-03 Thread Stephan Bergmann
On 02/03/2012 07:27 AM, Lionel Elie Mamane wrote: I fear it is more subtle than that For the record, c16027de8423cdb6b33ce5f5f9e13fdc25b9dbeb Fix order in which postgresql searches for libs should fix that. Stephan ___ LibreOffice mailing list

Re: Question about iterator management in sw/source/core/fields/cellfml.cxx

2012-02-03 Thread Stephan Bergmann
On 02/02/2012 09:08 PM, julien2412 wrote: Would this patch better ? (I kept the for loop) Unfortunately that still has a problem. After rBoxes.erase(toErase), it (which is the same as toErase) is invalidated, so incrementing it (up in the for(...;...;...) part) has undefined behavior. The

Re: [Libreoffice] LibO 3.5RC2: terminate called after throwing an instance of 'com::sun::star::registry::InvalidRegistryException'

2012-02-03 Thread Stephan Bergmann
On 02/03/2012 11:52 AM, Dag Wieers wrote: I have a problem using the python UNO interface as shipping with LibO 3.5RC2, I do not have the same problem using LibO 3.4.5 or previous versions (going back to OpenOffice 3.2.1). When running the shipped python binary with the shipped

Re: [Libreoffice-commits] .: configure.in Ensure AC_CHECK_LIB/AC_SEARCH_LIBS do not poison LIBS

2012-02-03 Thread Stephan Bergmann
need this. Like Ubuntu below). I did not find any mention of @LIBS@ in our code base (outside of dmake, which has its own configure). Stephan On 02/03/2012 04:23 PM, Stephan Bergmann wrote: configure.in | 49 + 1 file changed, 33

Re: Question about iterator management in sw/source/core/fields/cellfml.cxx

2012-02-03 Thread Stephan Bergmann
On 02/03/2012 04:18 PM, Michael Stahl wrote: On 03/02/12 14:01, Stephan Bergmann wrote: The standard idiom is for (iterator i = m.begin(); i != m.end();) { if (doErase) { m.erase(i++); } else { ++i; } } but doesn't that have the same problem? i

Re: Question about iterator management in sw/source/core/fields/cellfml.cxx

2012-02-03 Thread Stephan Bergmann
On 02/03/2012 05:31 PM, Michael Stahl wrote: ah, that's surprising. that's shocking ;) see, that is why i almost always write the i++ as an extra statement, i'm never quite exactly sure what it does, and when :) There is a sequence point (in C++03 parlance; the nomenclature changed

Re: [Libreoffice] LibO 3.5RC2: terminate called after throwing an instance of 'com::sun::star::registry::InvalidRegistryException'

2012-02-03 Thread Stephan Bergmann
On 02/03/2012 04:46 PM, Dag Wieers wrote: [dag@moria ~]$ /opt/libreoffice3.5/program/python Python 2.6.1 (r261:67515, Feb 1 2012, 15:06:46) [GCC 4.2.4] on linux2 Type help, copyright, credits or license for more information. import uno terminate called after throwing an instance of

Re: [Libreoffice] LibO 3.5RC2: terminate called after throwing an instance of 'com::sun::star::registry::InvalidRegistryException'

2012-02-03 Thread Stephan Bergmann
On 02/03/2012 06:43 PM, Stephan Bergmann wrote: On 02/03/2012 04:46 PM, Dag Wieers wrote: [dag@moria ~]$ /opt/libreoffice3.5/program/python Python 2.6.1 (r261:67515, Feb 1 2012, 15:06:46) [GCC 4.2.4] on linux2 Type help, copyright, credits or license for more information. import uno terminate

Re: [Libreoffice] LibO 3.5RC2: terminate called after throwing an instance of 'com::sun::star::registry::InvalidRegistryException'

2012-02-05 Thread Stephan Bergmann
On 02/05/2012 04:28 PM, Dag Wieers wrote: On Fri, 3 Feb 2012, Stephan Bergmann wrote: Apart from that, Dag, the only safe solution, in principle, is to use a version of LO that is specificially built for the machine it is run on (i.e., use a LO installation provided by the respective distro

Re: l10ntools: GetXrmFile() nearly equal to GetCfgFile()

2012-02-06 Thread Stephan Bergmann
On 02/05/2012 09:09 PM, Chr. Rossmanith wrote: simian detected 21 duplicate lines in the following files: l10ntools/source/xrmmerge.cxx l10ntools/source/cfgmerge.cxx But as far as I can see the methods GetXrmFile() and GetCfgFile() seem to be copypasted with minor modifications for ByteString

Re: How far can the LO file's contents be stretched?

2012-02-06 Thread Stephan Bergmann
On 02/05/2012 09:50 PM, Johannes Sixt wrote: 1. Is the order of the files in the ZIP archive important? Yes. http://docs.oasis-open.org/office/v1.2/os/OpenDocument-v1.2-os-part3.html#__RefHeading__752809_826425813: The 'mimetype' file shall be the first file of the zip file. Stephan

Re: [PUSHED] Fix for a compile issue I was having in l10ntools (GCC 4.4.3, Ubuntu)

2012-02-06 Thread Stephan Bergmann
On 02/06/2012 03:36 AM, Josh Heidenreich wrote: I had some trouble compiling LibO the other day, a syntax error. I found someone had had a similar problem in the list archvies, so I did a fix in the same way they did theirs. Thanks, pushed. Stephan

Re: PATCH build errors on Ubuntu 10.04

2012-02-06 Thread Stephan Bergmann
On 02/05/2012 07:05 PM, Gert van Valkenhoef wrote: 1) Compile error in l10ntools/source/lngex.cxx (see below) Fixed with Josh's fix now (which came in concurrently). Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: PATCH build errors on Ubuntu 10.04

2012-02-06 Thread Stephan Bergmann
On 02/05/2012 10:18 PM, Norbert Thiebaud wrote: On Sun, Feb 5, 2012 at 12:05 PM, Gert van Valkenhoef g.h.m.van.valkenh...@rug.nl wrote: Dear LibreOffice developers, 2) There is no build-dep on doxygen (ppa libreoffice), but LibreOffice won't build without it it will if you specify

Re: [Libreoffice] LibO 3.5RC2: terminate called after throwing an instance of 'com::sun::star::registry::InvalidRegistryException'

2012-02-06 Thread Stephan Bergmann
On 02/06/2012 10:00 AM, Petr Mladek wrote: Stephan Bergmann píše v Pá 03. 02. 2012 v 22:10 +0100: Petr, the best approach might be to build the official Linux LO installation sets with explicit --with-system-stdlibs, so that the installation sets do not bring along their own libgcc_s.so.1

Re: [PATCH][PUSHED] Remove unused System V oslSemaphore implementation

2012-02-06 Thread Stephan Bergmann
On 02/05/2012 07:21 PM, Francois Tigeot wrote: sal/osl/unx/semaphor.c contains two separate implementations of the osl*Semaphore synchronization functions: - a pthread one (used by default) - an alternative one based on System V semaphores The alternative System V implementation is only used

Re: [LibreOffice] [Bug 39428] audit / remove SvStream long operators

2012-02-06 Thread Stephan Bergmann
On 02/06/2012 11:09 AM, Keith McRae wrote: Sorry for the delay in replying. I have changed the return types from Stream to be the same as the parameter type and a return of 0 indicates failure. Currently working through tools/ As this is quite a large change, should I submit patches as I

Re: [Libreoffice] LibO 3.5RC2: terminate called after throwing an instance of 'com::sun::star::registry::InvalidRegistryException'

2012-02-06 Thread Stephan Bergmann
On 02/06/2012 02:25 PM, Dag Wieers wrote: But the issue deserves a bugzilla entry, so here it is: https://bugs.freedesktop.org/show_bug.cgi?id=45696 Finally solved the mystery; see https://bugs.freedesktop.org/show_bug.cgi?id=45696#c3. Stephan

Re: [ANNOUNCE] Changes to the build system: Env.Host.sh is dead so is the need to source the environment

2012-02-06 Thread Stephan Bergmann
On 02/06/2012 02:59 PM, Norbert Thiebaud wrote: make clean is not suppose to remove config_host.mk Why not? At least I would naively have expected that it does. Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: Issue about Failed symbol dependency from 21-1

2012-02-06 Thread Stephan Bergmann
On 02/06/2012 02:19 PM, Cor Nouws wrote: Since some weeks, there is Bug 45074 - Failed symbol dependency from builtin libstc++ DSO thanks for bringing it to our attention -- nicely fits current discussions (see update in the bug) Stephan ___

Re: [ANNOUNCE] Changes to the build system: Env.Host.sh is dead so is the need to source the environment

2012-02-06 Thread Stephan Bergmann
On 02/06/2012 03:49 PM, Miklos Vajna wrote: On Mon, Feb 06, 2012 at 03:33:52PM +0100, Stephan Bergmannsberg...@redhat.com wrote: On 02/06/2012 02:59 PM, Norbert Thiebaud wrote: make clean is not suppose to remove config_host.mk Why not? At least I would naively have expected that it does.

Re: [ANNOUNCE] Changes to the build system: Env.Host.sh is dead so is the need to source the environment

2012-02-06 Thread Stephan Bergmann
On 02/07/2012 02:37 AM, Norbert Thiebaud wrote: make check should work again... It appears the check target no longer implicitly depends on the default target (i.e., make check no longer builds all through instsetoo_native, but instead now only starts with building smoketestoo_native; to

Re: [REVIEW][3-4][3-5][PUSHED] fdo#38745 redline undo regression

2012-02-07 Thread Stephan Bergmann
On 02/07/2012 11:23 AM, Michael Stahl wrote: the fix for this ridiculous bug from the why C++ is not my favourite language series needs to go into libreoffice-3-5 and libreoffice-3-4: http://cgit.freedesktop.org/libreoffice/core/commit/?id=13424b43c25389e303774c3fb2f2beb3e20ceae5 :) Pushed

Re: [PATCH V2] more conversion of tools/Table.hxx to std::map in editeng, sc and sw modules

2012-02-07 Thread Stephan Bergmann
On 02/08/2012 07:59 AM, Noel Grandin wrote: This I don't understand - maCharInfoMap is not declared const, so how can I make it mutable? In a const member function, all data members of this are implicitly treated as const, unless they are explicitly marked mutable. Stephan

Re: basegfx::fround and friends seems needed in windows build

2012-02-08 Thread Stephan Bergmann
On 02/08/2012 10:30 AM, Korrawit Pruegsanusak wrote: What should we do next? (partially) revert it? or ...? :-) Yes, please just revert what is used by Windows-only canvas/source/directx but got erroneously removed. Stephan ___ LibreOffice mailing

Re: basegfx::fround and friends seems needed in windows build

2012-02-08 Thread Stephan Bergmann
On 02/08/2012 06:31 PM, Michael Meeks wrote: And of course, it'd be good to add some #ifndef UNX stuff around that I suppose, so it is not compiled and doesn't re-appear on the unusedcode.easy list in future :-) I guess one can argue both ways here. A feature-complete basegfx library

Re: Typo: com.sum.star...

2012-02-08 Thread Stephan Bergmann
On 02/08/2012 08:10 PM, Tor Lillqvist wrote: http://opengrok.libreoffice.org/search?q=com.sumproject=coredefs=refs=path=hist= Can this be fixed, or is it stable API? Implementation names should not be considered stable API, so changing this should be pretty safe. (And it looks dubious

Re: [Libreoffice] [PUSHED-partially][PATCH]a better about dialog

2012-02-08 Thread Stephan Bergmann
On 02/08/2012 07:13 PM, Ivan Timofeev wrote: I didn't try German, but see how it looks in Russian in the attached screenshot. The problem is that the new links start with '=' and are quoted. Looks like a bug somewhere. That looks suspiciously like a bug I introduced recently on master when

Re: basegfx::fround and friends seems needed in windows build

2012-02-08 Thread Stephan Bergmann
On 02/08/2012 09:30 PM, Caolán McNamara wrote: So there are some alternatives options to hide something from callcatcher. [...] write unit tests that call it [...] I somehow like that solution best. :) Stephan ___ LibreOffice mailing list

<    6   7   8   9   10   11   12   13   14   15   >