Re: WaE in filter/source/svg/svgreader.cxx

2012-05-08 Thread Stephan Bergmann
On 05/08/2012 11:31 AM, julien2412 wrote: If either i put a static_cast with sal_Int32 or sal_uInt32 for xChildren-item(i)-getNodeType(), compilation works. But I read this link http://www.parashift.com/c++-faq-lite/newbie.html#faq-29.19 and NodeType is an enumeration if I don't mistake. So

[Libreoffice-commits] .: swext/Extension_wiki-publisher.mk

2012-05-09 Thread Stephan Bergmann
swext/Extension_wiki-publisher.mk |7 +++ 1 file changed, 7 insertions(+) New commits: commit 29b7738085c4fb272b845900ef908f621d02cd68 Author: Stephan Bergmann sberg...@redhat.com Date: Wed May 9 11:16:33 2012 +0200 fdo#46509: xsltml .xsl files missing from wiki-publisher.oxt

[Libreoffice-commits] .: officecfg/registry sfx2/source sw/source tools/inc tools/Library_tl.mk tools/Package_inc.mk tools/source

2012-05-09 Thread Stephan Bergmann
9 files changed, 4 insertions(+), 188 deletions(-) New commits: commit 2b0244db8b223780e9d740ac600b7e25a2c11d93 Author: Stephan Bergmann sberg...@redhat.com Date: Wed May 9 13:46:19 2012 +0200 Removed unnecessary SvLibrary Change-Id

Re: Need help with debugging LO freeze

2012-05-09 Thread Stephan Bergmann
On 05/09/2012 02:53 PM, Michael Meeks wrote: I guess; in general it'd be rather nice to have a nice, pretty, boost UNO components changed signal - that denotes that a new component has been installed / removed - so we could throw away some of these caches :-) Stephan - is there anything

[Libreoffice-commits] .: sfx2/inc sfx2/sdi sfx2/source

2012-05-10 Thread Stephan Bergmann
/view/impviewframe.hxx |1 sfx2/source/view/viewfrm.cxx |9 --- sfx2/source/view/viewfrm2.cxx | 94 -- 9 files changed, 3 insertions(+), 172 deletions(-) New commits: commit d16c1b9290e11ca31850523a2b01426bca0937a3 Author: Stephan Bergmann sberg

[Libreoffice-commits] .: i18nutil/source

2012-05-10 Thread Stephan Bergmann
i18nutil/source/utility/paper.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit a50a33c3a7505f78d1ab82b746f1234f404e411e Author: Stephan Bergmann sberg...@redhat.com Date: Thu May 10 13:45:10 2012 +0200 Fix fdo#49720: Dropped unnecessary sh -c from popen

[Libreoffice-commits] .: framework/inc framework/source

2012-05-10 Thread Stephan Bergmann
framework/inc/framework/titlehelper.hxx |8 +++ framework/source/fwe/helper/titlehelper.cxx | 31 +++- 2 files changed, 17 insertions(+), 22 deletions(-) New commits: commit b43f5ccb6b09493daee401d2dd1f907e23ad6c3e Author: Stephan Bergmann sberg

Re: hidden visibility on mac (Re: [PUSHED][3-5] Re: [REVIEW 3-5] fdo#37044 crash on mac with transliteration)

2012-05-10 Thread Stephan Bergmann
On 05/10/2012 01:06 PM, Tor Lillqvist wrote: i'm not all that familiar with how MachO linker works (other than its fancy install_names :). You mean the weird @__ stuff? I think that is something we can get rid of once we stop supporting 10.4.

Re: hidden visibility on mac (Re: [PUSHED][3-5] Re: [REVIEW 3-5] fdo#37044 crash on mac with transliteration)

2012-05-10 Thread Stephan Bergmann
On 05/10/2012 01:56 PM, Tor Lillqvist wrote: Interestingly enough, the reason why in my 10.4 Mac build tree (using Xcode 3, and thus gcc 4.0.1 and the 10.4 SDK), HAVE_VISIBILITY_FEATURE gets unset is that the checking if STL headers are visibility safe test fails. The earlier checking whether

[Libreoffice-commits] .: 2 commits - extensions/Configuration_updchk.mk extensions/source postprocess/packregistry solenv/gbuild

2012-05-11 Thread Stephan Bergmann
++ solenv/gbuild/Configuration.mk |2 5 files changed, 43 insertions(+), 20 deletions(-) New commits: commit 3f5ddf2e873b76abe3e166089fac2cfcb358d346 Author: Stephan Bergmann sberg...@redhat.com Date: Fri May 11 13:08:51 2012 +0200 Fix updchk xcu

[Libreoffice-commits] .: postprocess/packregistry

2012-05-11 Thread Stephan Bergmann
postprocess/packregistry/makefile.mk |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit f35b5d0903d270da04a5a3262ab1f6a513cd9fb6 Author: Stephan Bergmann sberg...@redhat.com Date: Fri May 11 13:23:31 2012 +0200 Stray line-joining backslash Change-Id

Re: failed unit test: sal_osl_file

2012-05-11 Thread Stephan Bergmann
On 05/09/2012 11:17 PM, Terrence Enger wrote: I am trying to build master commit id 5c2c0e3, pulled 2012-05-08, on ubuntu-natty (11.04), and it is failing in unit test sal_osl_file. I saw this exact same strange error with the Linux-RHEL6-x86_64@14-with-check tinderbox recently, and assume it

Re: [Libreoffice-commits] .: Fix updchk xcu data after gbuild'ification

2012-05-11 Thread Stephan Bergmann
On 05/11/2012 01:11 PM, Stephan Bergmann wrote: commit 3f5ddf2e873b76abe3e166089fac2cfcb358d346 Author: Stephan Bergmannsberg...@redhat.com Date: Fri May 11 13:08:51 2012 +0200 Fix updchk xcu data after gbuild'ification For one, install:module was missing from xcu files

[Libreoffice-commits] .: sfx2/inc

2012-05-11 Thread Stephan Bergmann
sfx2/inc/sfx2/sfxcommands.h |1 - 1 file changed, 1 deletion(-) New commits: commit d8321bd0651c89fc158859a2b2ee5903533921ed Author: Stephan Bergmann sberg...@redhat.com Date: Fri May 11 16:38:58 2012 +0200 Looks like CMD_SID_FRAMETITLE can go ...now that SID_FRAMETITLE

[Libreoffice-commits] .: test/inc

2012-05-12 Thread Stephan Bergmann
test/inc/test/beans/xpropertyset.hxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit f941184568634e578ce0421908b9000a20eab54a Author: Stephan Bergmann sberg...@redhat.com Date: Sat May 12 16:37:50 2012 +0200 Explicitly export nested struct (needed on Mac OS X

Re: hidden visibility on mac (Re: [PUSHED][3-5] Re: [REVIEW 3-5] fdo#37044 crash on mac with transliteration)

2012-05-14 Thread Stephan Bergmann
On 05/10/2012 06:18 PM, Tor Lillqvist wrote: This patch makes visibility detection work for me in my 10.4 tree. The build is still going so I can't say if the result will work;) Tried a 10.4 build over the weekend, and it worked fine again for me. Thanks, Stephan

[Libreoffice-commits] .: svtools/source

2012-05-14 Thread Stephan Bergmann
svtools/source/filter/FilterConfigCache.hxx |7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) New commits: commit eda52d5e73d8918f354036cf7db3acfab43b36d7 Author: Stephan Bergmann sberg...@redhat.com Date: Mon May 14 16:14:02 2012 +0200 FilterConfigCache not used outside

[Libreoffice-commits] .: cppuhelper/source

2012-05-14 Thread Stephan Bergmann
cppuhelper/source/defaultbootstrap.cxx | 16 1 file changed, 16 insertions(+) New commits: commit 3b1798a55bf7c193b911ce23e280e6a0e1e4314a Author: Stephan Bergmann sberg...@redhat.com Date: Mon May 14 18:20:30 2012 +0200 Work around extension factories not implementing

[Libreoffice-commits] .: cppuhelper/source

2012-05-14 Thread Stephan Bergmann
cppuhelper/source/defaultbootstrap.cxx |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) New commits: commit d8ade3ccf6d7832b672edd57ec688515240413b3 Author: Stephan Bergmann sberg...@redhat.com Date: Mon May 14 18:48:22 2012 +0200 Added link to LanguageTool.oxt issue

[Libreoffice-commits] .: sw/source

2012-05-15 Thread Stephan Bergmann
sw/source/core/doc/tblrwcl.cxx | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) New commits: commit cdf783872af1df9389353803dc64ccab0c8f033e Author: Stephan Bergmann sberg...@redhat.com Date: Tue May 15 09:54:26 2012 +0200 Work around signed/unsigned warning (old GCC

[Libreoffice-commits] .: solenv/gbuild

2012-05-15 Thread Stephan Bergmann
solenv/gbuild/Library.mk |2 ++ 1 file changed, 2 insertions(+) New commits: commit 47ba662ce60d89572a2269523d07034f16edf33c Author: Stephan Bergmann sberg...@redhat.com Date: Tue May 15 11:22:44 2012 +0200 Explicitly initialize target-specific variables ...so they do

Re: [PATCH-3-5] fdo#35270 - kill first-use grammar checker freeze ...

2012-05-15 Thread Stephan Bergmann
On 05/14/2012 03:52 PM, Michael Meeks wrote: Having said that, testing is rather hard since master rejects LanguageTool installs (and potentially doesn't work even with the default installed one - Stephan is looking at that IIRC). Fixed with

[Libreoffice-commits] .: 2 commits - framework/source sfx2/source

2012-05-15 Thread Stephan Bergmann
framework/source/fwe/helper/titlehelper.cxx | 11 +++ sfx2/source/doc/sfxbasemodel.cxx| 14 ++ 2 files changed, 9 insertions(+), 16 deletions(-) New commits: commit 1d7d99e9aa74cb5ee11649b76e35c5a03263c889 Author: Stephan Bergmann sberg...@redhat.com Date

Re: Unopkg fails to register extension (com.sun.star.registry.CannotRegisterImplementationException)

2012-05-15 Thread Stephan Bergmann
On 05/15/2012 05:39 PM, Sebastian Humenda wrote: Stephan Bergmannsberg...@redhat.com schrieb am 07.05.2012, 10:59 +0200: Looking into AccessODF.oxt as included in http://crustulus.de/accessodf_0.1-1_all.deb, the actively registered accessodf-addon.jar uses classes from lib/accessodf.jar

Re: [ languagetool-Bugs-3526635 ] SingletonFactory should implement XServiceInfo

2012-05-16 Thread Stephan Bergmann
On 05/16/2012 12:13 AM, SourceForge.net wrote: -- Comment By: Daniel Naber (dnaber) Date: 2012-05-15 15:13 Message: Thank you for the patch, I have just committed it so it will be in LT 1.8 (and upcoming daily snapshots, of

[Libreoffice-commits] .: 2 commits - svtools/source unotools/inc unotools/Package_inc.mk unotools/source

2012-05-16 Thread Stephan Bergmann
/historyoptions.cxx | 34 --- unotools/source/config/useroptions.cxx | 75 - 6 files changed, 93 insertions(+), 132 deletions(-) New commits: commit e3633f60b349022994e291aa3d1a0c90c3403b2e Author: Stephan Bergmann sberg...@redhat.com Date: Wed May 16 09:32:51

Re: oo-buildsrv2

2012-05-16 Thread Stephan Bergmann
--safe is worrying---it caused at least on subsequentcheck failure, and who knows what else... Therefore the attempt to build with the given GCC 4.1.2 but -fvisiblity=hidden enabled nonetheless.] On 05/15/2012 06:38 PM, Stephan Bergmann wrote: Quick update before I go for the evening: * Commented

Re: --enable-debug vs --enable-symbols (Re: [Libreoffice-commits] .: 12 commits - config_host.mk.in configure.in filter/source oox/source sal/inc sc/source solenv/gbuild toolkit/source xmlhelp/source)

2012-05-16 Thread Stephan Bergmann
On 05/16/2012 03:09 PM, Lubos Lunak wrote: Now --enable-debug=-sc/ means that sc/ is built without -g and with -O2. In other words, the compiler spends extra time working on code I don't care about at all. There was a reason why OPT flags was empty in --enable-debug build - as soon as I do a

Re: --enable-debug vs --enable-symbols (Re: [Libreoffice-commits] .: 12 commits - config_host.mk.in configure.in filter/source oox/source sal/inc sc/source solenv/gbuild toolkit/source xmlhelp/source)

2012-05-16 Thread Stephan Bergmann
On 05/16/2012 04:07 PM, Lubos Lunak wrote: On Wednesday 16 of May 2012, Stephan Bergmann wrote: On 05/16/2012 03:09 PM, Lubos Lunak wrote: Now --enable-debug=-sc/ means that sc/ is built without -g and with -O2. In other words, the compiler spends extra time working on code I don't care

[Libreoffice-commits] .: binaryurp/source cppu/source

2012-05-16 Thread Stephan Bergmann
commits: commit d015384e1d98fe77fd59339044f58efb1ab9fb25 Author: Stephan Bergmann sberg...@redhat.com Date: Wed May 16 22:09:21 2012 +0200 Fixed ThreadPool (and dependent ORequestThread) life cycle At least with sw_complex test under load, it happened that an ORequestThread could

[Libreoffice-commits] .: sc/source

2012-05-18 Thread Stephan Bergmann
sc/source/ui/view/viewdata.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit abb26f51eea0399754cc8f5b7d7a7d648d68f630 Author: Stephan Bergmann sberg...@redhat.com Date: Fri May 18 09:06:30 2012 +0200 One more -Werror=sign-compare Change-Id

[Libreoffice-commits] .: Branch 'libreoffice-3-5-4' - unotools/source

2012-05-18 Thread Stephan Bergmann
unotools/source/config/historyoptions.cxx | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) New commits: commit 12e49e422e5244173d97bcf61f5354fd90d7fab3 Author: Stephan Bergmann sberg...@redhat.com Date: Wed May 16 09:32:51 2012 +0200 fdo#46074 fdo#49948 Ignore

Re: [PUSHED-3-5-4] recent documents corruption fix

2012-05-18 Thread Stephan Bergmann
On 05/16/2012 11:47 AM, Michael Stahl wrote: On 16/05/12 11:02, Michael Meeks wrote: On Wed, 2012-05-16 at 09:47 +0200, Stephan Bergmann wrote: Please review and consider for backporting to libreoffice-3-5 and libreoffice-3-5-4. Looks great to me; cherry-picked to -3-5, we need

Re: --enable-debug vs --enable-symbols (Re: [Libreoffice-commits] .: 12 commits - config_host.mk.in configure.in filter/source oox/source sal/inc sc/source solenv/gbuild toolkit/source xmlhelp/source)

2012-05-18 Thread Stephan Bergmann
On 05/16/2012 05:01 PM, Lubos Lunak wrote: - non-debug/dbgutils (i.e. also the default) - -O2 - symbols - -g (probably even -g1, if this is actually meant for release builds with debug info sufficient mainly for backtraces) - debug/dbgutils - -g, making sure it overrides -g1 from symbols -

Re: operator new no longer routes through rtl_AllocMemory in libsalcpprt under gbuild link rules

2012-05-18 Thread Stephan Bergmann
On 05/18/2012 03:38 PM, Arnaud Versini wrote: I checked on Linux and Windows, the memory after a massive allocation and a massive deallocation is really freed, so currently la raison d'être of our internal allocator is gone (need to be checked on Mac Os X). About performance I don't know.

[Libreoffice-commits] .: sc/source

2012-05-18 Thread Stephan Bergmann
sc/source/ui/view/viewdata.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 9455c44d3f43d17b1d9150a1cd6c6f34e696c6ed Author: Stephan Bergmann sberg...@redhat.com Date: Fri May 18 16:24:45 2012 +0200 Yet another -Werror=sign-compare Change-Id

Re: operator new no longer routes through rtl_AllocMemory in libsalcpprt under gbuild link rules

2012-05-18 Thread Stephan Bergmann
On 05/18/2012 04:23 PM, Michael Stahl wrote: checking a massive allocation doesn't really tell us all that much, because allocators typically operate in 2 modes: - for large objects, directly request zero-backed memory via mmap - for small objects, maintain elaborate data structures to allocate

Re: --enable-debug vs --enable-symbols (Re: [Libreoffice-commits] .: 12 commits - config_host.mk.in configure.in filter/source oox/source sal/inc sc/source solenv/gbuild toolkit/source xmlhelp/source)

2012-05-18 Thread Stephan Bergmann
On 05/18/2012 04:05 PM, Lubos Lunak wrote: On Friday 18 of May 2012, Stephan Bergmann wrote: On 05/16/2012 05:01 PM, Lubos Lunak wrote: - non-debug/dbgutils (i.e. also the default) - -O2 - symbols - -g (probably even -g1, if this is actually meant for release builds with debug info

Re: [REVIEW][3-5] gcc 4.7 UNO bridges fixes

2012-05-18 Thread Stephan Bergmann
On 05/18/2012 05:13 PM, Michael Stahl wrote: so it seems that the C++ UNO bridges, when built with gcc 4.7, crash and burn in the bridges test in testtools. fortunately Stephan has fixed this problem on master, at least as far as i can see, applying the attached patches in a x86_64

[Libreoffice-commits] .: vcl/unx

2012-05-18 Thread Stephan Bergmann
vcl/unx/generic/printer/cupsmgr.cxx | 76 +++- 1 file changed, 15 insertions(+), 61 deletions(-) New commits: commit ef48b58387fdc04050c3362440ffe3ca0037d8d0 Author: Stephan Bergmann sberg...@redhat.com Date: Fri May 18 20:52:15 2012 +0200 Revert fix

[REVIEW-3-5] Fixed ThreadPool (and dependent ORequestThread) life cycle

2012-05-18 Thread Stephan Bergmann
/16/2012 10:21 PM, Stephan Bergmann wrote: binaryurp/source/bridge.cxx | 52 -- binaryurp/source/bridge.hxx |4 +- cppu/source/threadpool/threadpool.cxx | 24 +++ cppu/source/threadpool/threadpool.hxx |4 +- 4 files

[REVIEW-3-5] Revert fix for #i86306# prepare against really broken CUPS installations...

2012-05-18 Thread Stephan Bergmann
-Revert-fix-for-i86306-prepare-against-really-broken-.patch. Thanks, Stephan On 05/18/2012 09:12 PM, Stephan Bergmann wrote: vcl/unx/generic/printer/cupsmgr.cxx | 76 +++- 1 file changed, 15 insertions(+), 61 deletions(-) New commits: commit

Re: Branch 'feature/gbuild_testtools' - review request

2012-05-21 Thread Stephan Bergmann
On 05/19/2012 11:44 AM, David Ostrovsky wrote: Then of course we have to preserve them! I just pushed another iteration. With new CustomTarget_bridgetest.mk all those batch file are generated now and run without error, magic ;-) Thanks. Works great, yes. I need a decision here: to merge it

Re: [REVIEW][3-5] codemaker: write Java 1.5 class files

2012-05-21 Thread Stephan Bergmann
On 05/18/2012 05:53 PM, Michael Stahl wrote: for this reason i'm in favor of immediately dropping support for anything older than Java 1.5 on master, and also on libreoffice-3-5. (i don't actually know what our official Java baseline is, perhaps it is already 1.5?) +1 on requiring a baseline

Re: 5729da1 fdo#42865: privatized unique empty string symbol - change of addsym.awk breaks the build on Mac/PPC

2012-05-21 Thread Stephan Bergmann
On 05/20/2012 05:06 PM, Christian Lohmaier wrote: print _ZNSs4_Rep20_S_empty_rep_storageE*; doesn't break the build. What could also be the problem is that the mangled name is slightly different for Mac OS X PPC. Does nm show any symbol name containing _S_empty_rep_storage, say? Then, a

Re: loader.loadComponentFromURL works slow when we are restoring CALC sheet from byte array | loader.loadComponentFromURL

2012-05-21 Thread Stephan Bergmann
On 05/21/2012 10:28 AM, Michael Meeks wrote: I assume this is from C++ (?) anything else would of course cause tons of bridging overhead in the streams. From the code, it looks more like they are using Java, presumably from a remote process. So any data from the buffer needs to be

Re: 5729da1 fdo#42865: privatized unique empty string symbol - change of addsym.awk breaks the build on Mac/PPC

2012-05-21 Thread Stephan Bergmann
On 05/21/2012 12:32 PM, Christian Lohmaier wrote: On Mon, May 21, 2012 at 12:08 PM, Michael Stahlmst...@redhat.com wrote: On 21/05/12 11:46, Stephan Bergmann wrote: On 05/20/2012 05:06 PM, Christian Lohmaier wrote: print _ZNSs4_Rep20_S_empty_rep_storageE*; [...] also, you'd have to check

Re: --enable-debug vs --enable-symbols (Re: [Libreoffice-commits] .: 12 commits - config_host.mk.in configure.in filter/source oox/source sal/inc sc/source solenv/gbuild toolkit/source xmlhelp/source)

2012-05-21 Thread Stephan Bergmann
On 05/21/2012 05:10 PM, Lubos Lunak wrote: On Friday 18 of May 2012, Stephan Bergmann wrote: Ah, you wanted --enable-dbgutil to disable -O2, the same way that --enable-debug does. Had missed that point. Hm, as I said, I prefer my --enable-dbgutil --disable-debug builds to be -O2. What

Re: main in libsofficeapp ...

2012-05-22 Thread Stephan Bergmann
On 05/21/2012 11:16 PM, Michael Stahl wrote: On 21/05/12 23:08, Michael Meeks wrote: commit c7458a4a71a1e875e03772b0f6e8ad9e1a982006 Author: Michael Stahlmst...@redhat.com Date: Mon Mar 12 16:24:34 2012 +0100 desktop: libsofficeapp shouln't need a main() Is that a random

[Libreoffice-commits] .: sc/source xmloff/inc xmloff/source

2012-05-22 Thread Stephan Bergmann
c452fcfb32d9265d8f2ab1cafe8d5765106ca718 Author: Stephan Bergmann sberg...@redhat.com Date: Tue May 22 13:28:21 2012 +0200 -Werror=unused-parameter Change-Id: I06dc09d57821ac729182764882558fa079b5ed37 diff --git a/sc/source/filter/xml/xmlexprt.cxx b/sc/source/filter/xml/xmlexprt.cxx

Re: building master against mac 10.7.4 using the 10.6 SDK

2012-05-22 Thread Stephan Bergmann
On 05/22/2012 02:07 PM, d.ostrov...@idaia.de wrote: I could look at 64-bit MacOSX build, if i had mac resources ... Or may be you (or your thinderbox) can compile for me and I would try to do it without mac ;-)? Remember that support for Mac OS X x86_64 would require a dedicated C++ UNO

Re: --enable-debug vs --enable-symbols (Re: [Libreoffice-commits] .: 12 commits - config_host.mk.in configure.in filter/source oox/source sal/inc sc/source solenv/gbuild toolkit/source xmlhelp/source)

2012-05-22 Thread Stephan Bergmann
On 05/22/2012 03:19 PM, Lubos Lunak wrote: On Monday 21 of May 2012, Stephan Bergmann wrote: On 05/21/2012 05:10 PM, Lubos Lunak wrote: On Friday 18 of May 2012, Stephan Bergmann wrote: Ah, you wanted --enable-dbgutil to disable -O2, the same way that --enable-debug does. Had missed

Re: --enable-debug vs --enable-symbols (Re: [Libreoffice-commits] .: 12 commits - config_host.mk.in configure.in filter/source oox/source sal/inc sc/source solenv/gbuild toolkit/source xmlhelp/source)

2012-05-22 Thread Stephan Bergmann
On 05/22/2012 04:02 PM, Lubos Lunak wrote: On Tuesday 22 of May 2012, Stephan Bergmann wrote: On 05/22/2012 03:19 PM, Lubos Lunak wrote: On Monday 21 of May 2012, Stephan Bergmann wrote: On 05/21/2012 05:10 PM, Lubos Lunak wrote: On Friday 18 of May 2012, Stephan Bergmann wrote: Ah, you

[Libreoffice-commits] .: binaryurp/source cppu/inc cppu/Library_cppu.mk cppu/source cpputools/source

2012-05-23 Thread Stephan Bergmann
++-- cppu/source/threadpool/threadpool.hxx | 43 ++- cpputools/source/unoexe/unoexe.cxx|4 13 files changed, 372 insertions(+), 282 deletions(-) New commits: commit 2fa2660b55a34a5780f9ea8dbbbe92d05dc9a818 Author: Stephan Bergmann sberg...@redhat.com Date: Wed May 23 09

[REVIEW-3-5] Better fix for ThreadPool/ORequestThread life cycle

2012-05-23 Thread Stephan Bergmann
On 05/19/2012 09:57 PM, Caolán McNamara wrote: On Fri, 2012-05-18 at 23:04 +0200, Stephan Bergmann wrote: I'd like to get this reviewed and backported to libreoffice-3-5. As the commit message explains, only part of it is strictly necessary to fix the bug, so fair enough, won't pretend

Re: build time optimization

2012-05-24 Thread Stephan Bergmann
On 05/24/2012 09:23 AM, David Ostrovsky wrote: I'm thinking about another magic configure option, like --with-external-lib-directory=/opt/libo this would install all dependend libs to this directory during first build and this would *survive* the make clean call, so the next time all external

[Libreoffice-commits] .: svtools/source

2012-05-24 Thread Stephan Bergmann
svtools/source/contnr/templwin.cxx |2 +- svtools/source/contnr/templwin.hxx |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) New commits: commit 226b81d0f300a62da9351d1fc011b88f93f0b2b0 Author: Stephan Bergmann sberg...@redhat.com Date: Thu May 24 10:58:31 2012 +0200

[Libreoffice-commits] .: sc/source

2012-08-14 Thread Stephan Bergmann
sc/source/core/data/colorscale.cxx |2 -- 1 file changed, 2 deletions(-) New commits: commit 480dc0740cf5112b595902dc44d5640899c40d85 Author: Stephan Bergmann sberg...@redhat.com Date: Tue Aug 14 16:18:46 2012 +0200 warning C4702: unreachable code Change-Id

Re: Solarmutex Deadlock when Closing Calc which contains functions with XVolatileResult return values

2012-08-14 Thread Stephan Bergmann
On 08/14/2012 03:20 PM, anwen wrote: In addition, from the link (http://www.openoffice.org/api/docs/common/ref/com/sun/star/sdb/OfficeDatabaseDocument.html), I saw that both OnPrepareUnload and OnUnload events are synchronously broadcaster. Does it mean SolarMutex protection again? I really hope

[Libreoffice-commits] .: binaryurp/source

2012-08-15 Thread Stephan Bergmann
binaryurp/source/bridge.cxx | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) New commits: commit edaf3e8cd146f5dadb73f1aebdf990f8a2656bc3 Author: Stephan Bergmann sberg...@redhat.com Date: Wed Aug 15 11:37:34 2012 +0200 fdo#43433: Binary URP works gracefully

[Libreoffice-commits] .: 3 commits - idl/inc idl/source io/source sal/osl

2012-08-15 Thread Stephan Bergmann
idl/inc/database.hxx|2 -- idl/source/prj/database.cxx |1 - io/source/stm/opipe.cxx |2 -- sal/osl/unx/signal.c|6 +++--- 4 files changed, 3 insertions(+), 8 deletions(-) New commits: commit f25b78bd99a1eb0d81ce9993f514d0a625aaa776 Author: Stephan Bergmann

[Libreoffice-commits] .: svtools/bmpmaker svtools/inc svtools/source

2012-08-15 Thread Stephan Bergmann
3a54474c408d40e768c19e9ceef2da8b550d8f77 Author: Stephan Bergmann sberg...@redhat.com Date: Wed Aug 15 15:18:48 2012 +0200 -Werror,-Wunused-private-field (Clang towards 3.2) Change-Id: I1341170e8ca43e23723a88ec05d826981e4473ee diff --git a/svtools/bmpmaker/bmpcore.hxx b/svtools/bmpmaker/bmpcore.hxx index fb8a555..9230b29

Re: Solarmutex Deadlock when Closing Calc which contains functions with XVolatileResult return values

2012-08-16 Thread Stephan Bergmann
On 08/15/2012 04:58 PM, anwen wrote: A brief summary of this discussion: My purpose is to develop a Calc extension based on LibreOffice environment. As an extension, it registers itself as a UNO component and provides some add-in functions which retrieve streaming data. This extension object

[Libreoffice-commits] .: 5 commits - avmedia/inc editeng/inc editeng/source sd/source svx/inc svx/source ucb/source unoxml/source

2012-08-16 Thread Stephan Bergmann
|4 +--- unoxml/source/dom/notationsmap.hxx|4 +--- 51 files changed, 30 insertions(+), 135 deletions(-) New commits: commit a7ba47243cb70b78c8d8674558ed6db35b79da99 Author: Stephan Bergmann sberg...@redhat.com Date: Thu Aug 16 11:39:58 2012 +0200 -Werror,-Wunused-private

[Libreoffice-commits] .: svx/source

2012-08-16 Thread Stephan Bergmann
svx/source/items/clipfmtitem.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit e413403590c3fb68a62db6d34d202e320fd99017 Author: Stephan Bergmann sberg...@redhat.com Date: Thu Aug 16 12:51:21 2012 +0200 fdo#53061: Work around boost::ptr_vector.insert

[Libreoffice-commits] .: instsetoo_native/util Makefile.top

2012-08-16 Thread Stephan Bergmann
Makefile.top |8 instsetoo_native/util/makefile.mk |9 - 2 files changed, 8 insertions(+), 9 deletions(-) New commits: commit 19990a9c5c5761687f757456015cb26d46d4830b Author: Stephan Bergmann sberg...@redhat.com Date: Thu Aug 16 14:44:37 2012 +0200

[Libreoffice-commits] .: sfx2/source

2012-08-16 Thread Stephan Bergmann
sfx2/source/doc/objserv.cxx |5 + 1 file changed, 5 insertions(+) New commits: commit 4e923fb5a293ce570974e620b87ff84ccb6a139b Author: Stephan Bergmann sberg...@redhat.com Date: Thu Aug 16 17:53:45 2012 +0200 fdo#53280: Reset read-only UI after successful Save As Change

Re: [PUSHED 3-6][REVIEW 3-6-1] fdo#53280: Reset read-only UI after successful Save As

2012-08-16 Thread Stephan Bergmann
On 08/16/2012 06:13 PM, Michael Meeks wrote: Looks sensible :-) pushed to -3-6 (though I personally loathe burning two lines of non-renewable vspace for no good reason ;-). The { and } lines you mean? I /do/ consider them helpful; spent a long time scratching my head just the other

Re: Bug 38840 - Adding coverage analysis to unit tests

2012-08-20 Thread Stephan Bergmann
On 08/19/2012 09:14 PM, John Smith wrote: When I run 'make help' I get this : unitcheckrun unit tests slowcheckrun slow unit tests subsequentcheck run system tests (requires full installation) checkrun unit tests and if in toplevel

[REVIEW 3-6][REVIEW 3-6-1] fdo#53252: File Open on C: crash

2012-08-20 Thread Stephan Bergmann
http://cgit.freedesktop.org/libreoffice/core/commit/?id=e642eec333b9a80b04a9c19290d959de1f0ae5ff fdo#53252: _toupper is unreliable is a rather trivial fix for 3.6 MAB https://bugs.freedesktop.org/show_bug.cgi?id=53252 UI: CRASH when edit LibO File Dialog Path Pane. Please verify for

Re: [PUSHED][PATCH] Fix TDE VCL interface

2012-08-20 Thread Stephan Bergmann
On 08/20/2012 01:41 PM, Caolán McNamara wrote: On Sun, 2012-08-19 at 03:44 -0500, Timothy Pearson wrote: This patch restores the TDE VCL and filepicker interfaces to full functionality in LO 3.6.0:

Re: [PUSHED][PATCH] Fix TDE VCL interface

2012-08-20 Thread Stephan Bergmann
On 08/20/2012 05:51 PM, Timothy Pearson wrote: Can you please post the generated kdefilepicker.moc.cxx file? I am somewhat surprised that moc is failing to generate valid code in this case. attached Stephan / **

Re: [PUSHED 3-6][REVIEW 3-6-1] fdo#53280: Reset read-only UI after successful Save As

2012-08-21 Thread Stephan Bergmann
On 08/16/2012 06:56 PM, Michael Meeks wrote: Sure - everyone's spent time doing that; like looking for: if (a); { always_happens(); } ...which contemporary compilers warn about, anyway. -- But sure, they could warn about the other case, too:

Re: [PUSHED][PATCH] fix dead code and fields in Java code

2012-08-21 Thread Stephan Bergmann
On 08/20/2012 05:37 PM, Caolán McNamara wrote: On Fri, 2012-08-17 at 17:15 +0200, Noel Grandin wrote: These patches remove various bits of dead code in the Java files. With one trivial change built and passed make check for me, pushed now With Java's reflection mechanisms, it is hard to

Re: [GSOC] PDF Signing Support - Final

2012-08-21 Thread Stephan Bergmann
On 08/20/2012 11:59 PM, Gökçen Eraslan wrote: At the end of the day, however, Adobe acroread shows the PDF signatures as invalid for some reason. But, it shows the certificate details correctly (which was not the case when I have used the old NSS PKCS7 API). So it seems DER/HEX encodings and the

[REVIEW 3-6][REVIEW 3-6-1] FileStatus can have fewer fields than requested

2012-08-21 Thread Stephan Bergmann
Looking into MAB https://bugs.freedesktop.org/show_bug.cgi?id=46249 CRASH when browse to HD root directory in FILEOPEN Template dialog (which apparently is crashing for yet another, unrelated reason, however), I noticed a regression introduced into LO 3.6.0 due to a misunderstanding of how

[REVIEW 3-6][REVIEW 3-6-1] fdo#53655: removing extensions\bundled fails on Win XP

2012-08-21 Thread Stephan Bergmann
One more from the oh no, not one more department: http://cgit.freedesktop.org/libreoffice/core/commit/?id=a8cdce148c76c93c5d41820610d6e6ac175e03a7 fdo#53655: Ignore failure to remove directories (as happens on Windows XP) fixes https://bugs.freedesktop.org/show_bug.cgi?id=53655 Install 3.6.1

[REVIEW 3-6] missing in fdo#53655: removing extensions\bundled fails on Win XP

2012-08-21 Thread Stephan Bergmann
On 08/21/2012 06:14 PM, Stephan Bergmann wrote: One more from the oh no, not one more department: http://cgit.freedesktop.org/libreoffice/core/commit/?id=a8cdce148c76c93c5d41820610d6e6ac175e03a7 fdo#53655: Ignore failure to remove directories (as happens on Windows XP) fixes https

gettext (was: (great) widget layout progress)

2012-08-22 Thread Stephan Bergmann
On 08/22/2012 05:55 PM, khagaroth wrote: How much work would it be to make this directly use gettext? I thought the long term goal was to switch from custom translation formats to gettext, so using yet another custom translation format for something like this seems a bit odd. Seeing gettext

Re: 'make check' failure

2012-08-23 Thread Stephan Bergmann
On 08/23/2012 07:58 AM, Noel Grandin wrote: On 2012-08-22 20:07, John Smith wrote: I just ran into this error when running 'make check'. Should I file a bug report on that ? It's better to be really sure - especially if you're running on master, these kinds of errors can be quite transient.

Re: [Libreoffice-commits] Revert installer: Use hashref for replace_all_ziplistvariables_in_rtffile

2012-08-23 Thread Stephan Bergmann
On 08/23/2012 09:59 AM, Libreoffice Gerrit user wrote: commit 52755d6d2cf1c6addaf3c91b93bb86d66b730409 Author: Stephan Bergmann sberg...@redhat.com Date: Thu Aug 23 09:47:13 2012 +0200 Revert installer: Use hashref for replace_all_ziplistvariables_in_rtffile This reverts commit

Re: 'make check' failure

2012-08-23 Thread Stephan Bergmann
On 08/23/2012 09:22 AM, John Smith wrote: On Thu, Aug 23, 2012 at 9:14 AM, Stephan Bergmann sberg...@redhat.com wrote: you should always run those tests with (bash etc.:) 'ulimit -c unlimited'; the gbuild logic will automatically print backtraces in case of a crash then (if your system is set

Re: 'make check' failure

2012-08-24 Thread Stephan Bergmann
On 08/23/2012 06:20 PM, John Smith wrote: On Thu, Aug 23, 2012 at 11:45 AM, Michael Stahl mst...@redhat.com wrote: reading the log you posted no you don't get a core file because soffice.bin didn't actually crash. Ok, so how do we go about getting more detailed info that can assist in solving

Re: 'make check' failure

2012-08-24 Thread Stephan Bergmann
On 08/24/2012 11:55 AM, John Smith wrote: On Fri, Aug 24, 2012 at 10:46 AM, Stephan Bergmann sberg...@redhat.com wrote: The unoapi tests involving anything related to accessibility have historically been very fragile (things like expecting a certain GUI element has focus at a certain moment

Re: No output from ./autogen.sh --help and other getting started issues (Ubuntu)

2012-08-24 Thread Stephan Bergmann
On 08/24/2012 11:47 AM, B.J. Herbison wrote: Issue 3: The Libux dependency page says Get upstream Junit at OK, I got the file, what do I do now? I presume it needs to go somewhere other than my downloads directory. Call autogen.sh with --with-junit=absolute path to JUnit 4 jar (the

Re: Bug 38840 - Adding coverage analysis to unit tests

2012-08-24 Thread Stephan Bergmann
On 08/24/2012 12:41 PM, John Smith wrote: I did have one test fail. See the 'make check failure' thread: http://nabble.documentfoundation.org/make-check-failure-td4002979.html Could that explain the omission ? of course it could, i wasn't connecting those threads :) Thats good. Well then at

Re: Bug 38840 - Adding coverage analysis to unit tests

2012-08-24 Thread Stephan Bergmann
On 08/19/2012 09:14 PM, John Smith wrote: - First you run a plain make in the top level directory to build LO (with analysis stuff enabled). - then you create a 'baseline' with lcov (sort of create a 'before snapshot' of LO) - *then* you run all your tests (whatever they may be) - then you

Re: make_installer 'touching' files in solver ?

2012-08-27 Thread Stephan Bergmann
On 08/25/2012 10:42 AM, Matúš Kukan wrote: I was doing --enable-epm build (it was probably mistake) and had problems with 'make check' something seems to be 'touching' version libraries in solver. (libuno_sal.so.3 libuno_salhelpergcc3.so.3 libstore.so.3 ...) My accumulated autogen.lastrun

Re: Bug 38840 - Adding coverage analysis to unit tests

2012-08-27 Thread Stephan Bergmann
On 08/24/2012 06:31 PM, John Smith wrote: On Fri, Aug 24, 2012 at 5:28 PM, Stephan Bergmann sberg...@redhat.com wrote: In a sense, even during the tests, very much of our code is executed by accident rather than due to dedicated test code calling it: Especially the subsequentcheck stuff

Re: using syslog instead of console for messages

2012-08-27 Thread Stephan Bergmann
On 08/26/2012 12:34 PM, Riccardo Magliocchetti wrote: while in headless mode i'd like to have messages delivered to syslog instead of stderr / stdout, looking at the SAL_* implementation it looks like what i want is to substitute the std::fputs in osl/all/log.cxx::log() with syslog() plus some

--enable-lomenubar (was: Master failed to compile on framework module)

2012-08-28 Thread Stephan Bergmann
On 08/28/2012 08:18 AM, julien2412 wrote: I runned make clean make this morning and here are the details. [ build LNK ] Library/libxstor.so /home/julien/compile-libreoffice/libo/framework/source/lomenubar/FrameHelper.cxx: In member function ‘void FrameHelper::dispatchCommand(rtl::OUString)’:

Re: using syslog instead of console for messages

2012-08-28 Thread Stephan Bergmann
On 08/27/2012 08:04 PM, Riccardo Magliocchetti wrote: So here's a quick patch, not even compile tested because i have few questions to resolve before considering it ready for review: - what about errors? it looks like SAL does not have a level for errors. I'd like to have the errors in

Re: [PUSHED] java cleanup patches

2012-08-28 Thread Stephan Bergmann
On 08/27/2012 01:43 PM, Noel Grandin wrote: These patches remove various bits of dead code, and perform some mild cleanup. The change to jurt/com/sun/star/lib/uno/environments/remote/Job.java in 0006 was unsound. The rest looked good. Stephan ___

Re: [PUSHED] java cleanup patches

2012-08-29 Thread Stephan Bergmann
On 08/28/2012 04:24 PM, Noel Grandin wrote: The change to Job.java was OK, because 3 lines up we had already checked the exception field for null, so it was not possible for it to be null at that point. Ach, of course. Didn't look closely enough. Pushed now, too. Stephan

Status of master mingw nss?

2012-08-29 Thread Stephan Bergmann
Trying a mingw cross build of current master on Fedora 17, it fails in module nss. First problem should be fixable with diff --git a/nss/makefile.mk b/nss/makefile.mk index 8603fbb..ecd7e22 100644 --- a/nss/makefile.mk +++ b/nss/makefile.mk @@ -134,8 +134,7 @@ BUILD_ACTION +=

Re: ld -z build failures on master

2012-08-30 Thread Stephan Bergmann
On 08/30/2012 08:03 AM, Noel Grandin wrote: There is now a -z option passed to ld? Getting build failures on master when building under Ubuntu Oneiric. Meanwhile fixed with http://cgit.freedesktop.org/libreoffice/core/commit/?id=b888512fcbff5bf5ae4d30e82ed51a792ceb1839 Fix -Wl,-z,origin

Re: [Libreoffice-commits] .: Branch 'feature/killsdf' - l10ntools/source

2012-08-30 Thread Stephan Bergmann
On 08/29/2012 09:06 PM, Libreoffice Gerrit user wrote: commit ecfa813595cb577781668219d9e17a0494f92bea Author: Zolnai Tamás zolnaitamas2...@gmail.com Date: Wed Aug 29 12:58:29 2012 +0200 Some cleanup Use normal integer types when it's unecessary to use sal_int types.

Re: most efficient way to keep in sync with configuration data ?

2012-08-30 Thread Stephan Bergmann
On 08/30/2012 01:09 PM, Caolán McNamara wrote: What's the most efficient way to repeatedly get an up-to-date configuration value ? Just do sal_Int32 nFoo = officecfg::Office::Writer::Foo::get(); every time you need Foo, or request Foo once and register some listener of some kind on Foo

Re: [PATCH] Change in core[feature/killsdf]: More cleanup aka clean up cleanup

2012-08-30 Thread Stephan Bergmann
On 08/30/2012 01:17 PM, Zolnai Tamás wrote: I submit a patch, which uses types more thoughtfully. I hope that it meets all the requirements. Thanks -- and no big deal anyway. (I had just been afraid of an upcoming bulk replacement that could have caused trouble.) Stephan

Re: [Libreoffice-commits] Make Regexpr class safer

2012-08-31 Thread Stephan Bergmann
On 08/31/2012 03:59 PM, Libreoffice Gerrit user wrote: New commits: commit 574ddaba5315816a5629550a0a12f9c694b79370 Author: Zolnai Tamás zolnaitamas2...@gmail.com Date: Fri Aug 31 14:40:14 2012 +0200 Make Regexpr class safer Make copy constructor and copy operator private

<    3   4   5   6   7   8   9   10   11   12   >