[PUSHED] Remove xml2cmp leftovers: Remove FlatXmlFilter_cpp.uno.xml f...

2012-12-14 Thread Stephan Bergmann (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1336 Approvals: Stephan Bergmann: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1336 To unsubscribe,

[PATCH] Change in core[libreoffice-3-6]: Take extra cache/uno_packages/*.tmp_/*properties files into ...

2012-12-13 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1313 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/13/1313/1 Take extra cache/uno_packages/*.tmp_/*properties files into account ...when migrating user extensions from an

[PUSHED] startup: more reliable startup of multiple instances

2012-12-13 Thread Stephan Bergmann (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1089 -- To view, visit https://gerrit.libreoffice.org/1089 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

[PATCH] Introduce SAL_DELETE

2012-12-11 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1299 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/99/1299/1 Introduce SAL_DELETE Change-Id: I7ac7392646ea34fb2e6a9f15990aca05a2c1e484 --- M sal/inc/rtl/ustrbuf.hxx M

[PUSHED] Introduce SAL_DELETE

2012-12-11 Thread Stephan Bergmann (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1299 -- To view, visit https://gerrit.libreoffice.org/1299 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

-Werror,-Wtautological-constant-out-of-range-compare

2012-12-07 Thread Stephan Bergmann (via Code Review)
Stephan Bergmann has abandoned this change. Change subject: -Werror,-Wtautological-constant-out-of-range-compare .. Patch Set 1: Abandoned -- To view, visit https://gerrit.libreoffice.org/1255 To unsubscribe, visit

[PUSHED] Change in core[libreoffice-3-6]: Resolves: fdo#51638 In unopkg gui dispose component contex...

2012-12-07 Thread Stephan Bergmann (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1263 -- To view, visit https://gerrit.libreoffice.org/1263 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

[PATCH] Change in core[libreoffice-3-6]: fdo#57927: Clarify msi installer only installs subset of dic...

2012-12-06 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1254 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/54/1254/1 fdo#57927: Clarify msi installer only installs subset of dicts by default ...since this was changed with

[PATCH] -Werror,-Wtautological-constant-out-of-range-compare

2012-12-06 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1255 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/55/1255/1 -Werror,-Wtautological-constant-out-of-range-compare ...so assuming this was meant instead? Change-Id:

[PATCH] Change in core[libreoffice-3-6]: -Werror=unused-parameter

2012-12-03 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1228 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/28/1228/1 -Werror=unused-parameter Change-Id: If1aad98965a90ac6b2e5488f21fe0d84c9b4af47 (cherry picked from commit

[PATCH] Change in core[libreoffice-3-6]: --without-system-libpng for universal Linux builds

2012-12-03 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1229 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/29/1229/1 --without-system-libpng for universal Linux builds ...so that e.g. Fedora 17 does not require installation of

[PUSHED] Do not override the message of an underlying PropertyVetoExc...

2012-11-30 Thread Stephan Bergmann (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1198 -- To view, visit https://gerrit.libreoffice.org/1198 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

[PUSHED] Change in core[libreoffice-3-6]: fdo#57611 do not crash when setting too small size

2012-11-30 Thread Stephan Bergmann (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1197 -- To view, visit https://gerrit.libreoffice.org/1197 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

[PUSHED] add SAL_WARN_UNUSED_RESULT in OString and OUString where app...

2012-11-28 Thread Stephan Bergmann (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1186 -- To view, visit https://gerrit.libreoffice.org/1186 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

[PUSHED] Change in core[libreoffice-3-6]: Resolves: fdo#53909 STG_FREE sector locations rejected

2012-11-22 Thread Stephan Bergmann (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1150 Approvals: Stephan Bergmann: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1150 To

[PATCH] Change in core[libreoffice-3-6]: fdo#57224: Preserve disabled-state across reinstallDeployedE...

2012-11-19 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1115 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/15/1115/1 fdo#57224: Preserve disabled-state across reinstallDeployedExtensions Change-Id:

Change in core[libreoffice-3-6]: fdo#57224: Preserve disabled-state across reinstallDeployedE...

2012-11-19 Thread Stephan Bergmann (via Code Review)
Stephan Bergmann has abandoned this change. Change subject: fdo#57224: Preserve disabled-state across reinstallDeployedExtensions .. Patch Set 1: Abandoned doesn't work after all -- To view, visit

[PATCH] Change in core[libreoffice-3-6-4]: fdo#57224: Preserve disabled-state across reinstallDeployedE...

2012-11-19 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1120 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/20/1120/1 fdo#57224: Preserve disabled-state across reinstallDeployedExtensions (cherry picked from commit

[PATCH] Change in core[libreoffice-3-6]: fdo#57224: Preserve disabled-state across reinstallDeployedE...

2012-11-19 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1119 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/19/1119/1 fdo#57224: Preserve disabled-state across reinstallDeployedExtensions (cherry picked from commit

[PUSHED] Drop the check for unordered_map.hxx

2012-11-15 Thread Stephan Bergmann (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1075 -- To view, visit https://gerrit.libreoffice.org/1075 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

[PATCH] Change in core[libreoffice-3-6]: Enable NPP_Initialize/Shutdown again

2012-11-13 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1042 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/42/1042/1 Enable NPP_Initialize/Shutdown again ...calling which had erroneously been dropped in

[PUSHED] add indexOf family of function to OUStringBuffer

2012-11-09 Thread Stephan Bergmann (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1006 -- To view, visit https://gerrit.libreoffice.org/1006 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

[PATCH] Change in core[libreoffice-3-6]: fdo#55138: Do not double-expand bootstrap variables

2012-11-06 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/994 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/94/994/1 fdo#55138: Do not double-expand bootstrap variables For some reason that escapes me now, the old code

Change in core[libreoffice-3-6]: fdo#53474: Fix Windows Java Accessibility Bridge

2012-10-26 Thread Stephan Bergmann (via Code Review)
Stephan Bergmann has abandoned this change. Change subject: fdo#53474: Fix Windows Java Accessibility Bridge .. Patch Set 1: Abandoned has already been integrated into libreoffice-3-6 as

[PATCH] Change in core[libreoffice-3-6]: fdo#49517: Revert fdo#46102: Load Java scripts with class l...

2012-10-26 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/922 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/22/922/1 fdo#49517: Revert fdo#46102: Load Java scripts with class loaders [...] This reverts commit

[PATCH] Change in core[libreoffice-3-6]: fdo#53474: Fix Windows Java Accessibility Bridge

2012-10-25 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/906 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/06/906/1 fdo#53474: Fix Windows Java Accessibility Bridge ...by folding the contents of java_accessibility.jar back into

[PATCH] Change in core[libreoffice-3-6-3]: fdo#53474: Fix Windows Java Accessibility Bridge

2012-10-25 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/907 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/07/907/1 fdo#53474: Fix Windows Java Accessibility Bridge ...by folding the contents of java_accessibility.jar back into

[PUSHED] WaE: 'xChartType$D57056$_pInterface' may be used uninitializ...

2012-10-25 Thread Stephan Bergmann (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/911 Approvals: Stephan Bergmann: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/911 To unsubscribe,

[PUSHED] Change in core[libreoffice-3-6-3]: fdo#55800: fix hex color conversion

2012-10-23 Thread Stephan Bergmann (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/897 Approvals: Markus Mohrhard: Looks good to me, but someone else must approve Stephan Bergmann: Verified; Looks good to me, approved

[PATCH] Change in core[libreoffice-3-6]: fdo#46071: Do not hide windows based on nil Visible proper...

2012-10-05 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/773 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/73/773/1 fdo#46071: Do not hide windows based on nil Visible property This appears to be messy: The

[PATCH] Change in core[libreoffice-3-6]: fdo#52022: Simple/LargeControlPoints actually can have nil v...

2012-10-04 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/765 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/65/765/1 fdo#52022: Simple/LargeControlPoints actually can have nil values ...in old LO 3.5 registrymodifications.xcu,

[PATCH] Change in core[libreoffice-3-6]: No dictionaries were preselected for en_US langpack

2012-09-27 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/707 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/07/707/1 No dictionaries were preselected for en_US langpack ...as gm_Langpack_r_en_US was explicitly excluded from

[PATCH] Change in core[libreoffice-3-6]: Clean up option processing

2012-09-26 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/700 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/00/700/1 Clean up option processing * Support --version on non-UNX, too. * Consistently show the first unknown option and

[PUSHED] Change in core[libreoffice-3-6-2]: fdo#54385: Displaying help/version early on UNX requires ser...

2012-09-25 Thread Stephan Bergmann (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/695 Approvals: Stephan Bergmann: Verified Tor Lillqvist: Looks good to me, approved David Tardon: Looks good to me, approved Fridrich

[PATCH] Change in core[libreoffice-3-6]: fdo#55019: Cope with empty TrustedAuthor entries

2012-09-25 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/696 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/96/696/1 fdo#55019: Cope with empty TrustedAuthor entries Change-Id: I9c01c1c718897a4be992150170a6ed9b5bd8a0a0 (cherry

[PATCH] Change in core[libreoffice-3-6]: rhbz#836827: SQLFeatureNotSupportedException only in Java 6

2012-09-24 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/690 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/90/690/1 rhbz#836827: SQLFeatureNotSupportedException only in Java 6 ...so if the patched hsqldb.jar is compiled with Java

[PATCH] Change in core[libreoffice-3-6]: fdo#54385: Displaying help/version early on UNX requires ser...

2012-09-24 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/694 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/94/694/1 fdo#54385: Displaying help/version early on UNX requires service manager This regression was introduced with

[PATCH] Change in core[libreoffice-3-6-2]: fdo#54385: Displaying help/version early on UNX requires ser...

2012-09-24 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/695 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/95/695/1 fdo#54385: Displaying help/version early on UNX requires service manager This regression was introduced with

[PATCH] Change in core[libreoffice-3-6]: Properly check cmdline args in oosplash

2012-09-21 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/666 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/66/666/1 Properly check cmdline args in oosplash ...so that e.g. --headless (starting with a h) is not also mistaken as -h

[PATCH] Change in core[libreoffice-3-6]: Don't access broken service mgr during bootstrap failure

2012-09-20 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/654 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/54/654/1 Don't access broken service mgr during bootstrap failure ...so that displaying a (non-translated) error box upon

[PATCH] Change in core[libreoffice-3-6]: Add RPATH to liblangtag

2012-09-20 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/661 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/61/661/1 Add RPATH to liblangtag ...so that it consistenly uses the LO versions of libxml2/glibc libs at runtime.

[PATCH] Change in core[libreoffice-3-6]: Do not call xmlCleanupParser from liblangtag

2012-09-20 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/662 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/62/662/1 Do not call xmlCleanupParser from liblangtag Despite its name, it is a cleanup function for libxml2 that must

[PATCH] Change in core[libreoffice-3-6]: Make rtl::O[U]String::isEmpty return true bool

2012-09-19 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/650 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/50/650/1 Make rtl::O[U]String::isEmpty return true bool ...instead of sal_Bool, to work around MSVC warning C4805: unsafe

[PUSHED] fdo#54858: fix UNO service conversion

2012-09-17 Thread Stephan Bergmann (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/628 -- To view, visit https://gerrit.libreoffice.org/628 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

[PUSHED] add osl_atomic_* api to allow for inlined atomic increment/d...

2012-09-17 Thread Stephan Bergmann (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/631 -- To view, visit https://gerrit.libreoffice.org/631 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

[PUSHED] fix bug fdo#53520, pt-PT and pt-BR better split

2012-09-11 Thread Stephan Bergmann (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/592 -- To view, visit https://gerrit.libreoffice.org/592 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

<    1   2