[Libreoffice-commits] dev-tools.git: ciabot/bugzilla ciabot/libreoffice-bugzilla2.py

2019-06-18 Thread Thorsten Behrens (via logerrit)
 ciabot/bugzilla/base.py |8 ++--
 ciabot/libreoffice-bugzilla2.py |   25 -
 2 files changed, 14 insertions(+), 19 deletions(-)

New commits:
commit fb1f2fee35b1ed9dd24a6f3cefe431cdd8e14dea
Author: Thorsten Behrens 
AuthorDate: Tue Jun 18 18:12:52 2019 +0200
Commit: Thorsten Behrens 
CommitDate: Tue Jun 18 18:14:12 2019 +0200

Sync ciabot with in-production copy

diff --git a/ciabot/bugzilla/base.py b/ciabot/bugzilla/base.py
index d9b4e28..81dffb4 100644
--- a/ciabot/bugzilla/base.py
+++ b/ciabot/bugzilla/base.py
@@ -253,10 +253,6 @@ class RequestsTransport(Transport):
 # xmlrpclib fails to escape \r
 request_body = request_body.replace(b'\r', b'')
 
-# Needed for python-requests < 2.0 with python3, otherwise we get
-# Content-Type error later for the POST request
-request_body = request_body.decode('utf-8')
-
 return self._request_helper(url, request_body)
 
 
@@ -944,8 +940,8 @@ class BugzillaBase(object):
 if self._supports_getbug_extra_fields:
 getbugdata["extra_fields"] = extra_fields
 
-log.debug("Calling Bug.get_bugs with: %s", getbugdata)
-r = self._proxy.Bug.get_bugs(getbugdata)
+log.debug("Calling Bug.get with: %s", getbugdata)
+r = self._proxy.Bug.get(getbugdata)
 
 if self.bz_ver_major >= 4:
 bugdict = dict([(b['id'], b) for b in r['bugs']])
diff --git a/ciabot/libreoffice-bugzilla2.py b/ciabot/libreoffice-bugzilla2.py
index 626a7d6..17c88f0 100644
--- a/ciabot/libreoffice-bugzilla2.py
+++ b/ciabot/libreoffice-bugzilla2.py
@@ -37,8 +37,8 @@ import bugzilla
 from bugzilla import Bugzilla
 from bugzilla.base import _BugzillaToken
 
-master_target = "6.1.0"
-bug_regex = "(?:tdf|fdo)#(\d+)"
+master_target = "6.4.0"
+bug_regex = "\\b(?:bug|fdo|tdf|lo)[#:]?(\\d+)\\b"
 dry_run = False
 
 class FreedesktopBZ:
@@ -48,7 +48,7 @@ class FreedesktopBZ:
 
 def connect(self):
 config = ConfigParser.ConfigParser()
-config.read('/home/ciabot/prod/config.cfg')
+config.read('/srv/home/ciabot/prod/config.cfg')
 url = config.get('bugzilla', 'url')
 user = config.get('bugzilla', 'user')
 password = config.get('bugzilla', 'password')
@@ -75,10 +75,8 @@ class FreedesktopBZ:
 new_whiteboard = old_whiteboard + "target:" + new_version
 bug.setwhiteboard(new_whiteboard)
 
-cgiturl = "http://cgit.freedesktop.org/libreoffice/%s/commit/?id=%s; 
%(repo_name, commit.hexsha)
-if branch is not None and branch != "master":
-cgiturl = cgiturl + "=" + branch
-else:
+cgiturl = "https://git.libreoffice.org/%s/+/%s%%5E%%21; % (repo_name, 
commit.hexsha)
+if branch is None:
 branch = "master"
 
 comment_msg = """%s committed a patch related to this issue.
@@ -94,9 +92,9 @@ It has been pushed to "%s":
 It will be available in %s.
 
 The patch should be included in the daily builds available at
-http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
+https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
 information about daily builds can be found at:
-http://wiki.documentfoundation.org/Testing_Daily_Builds
+https://wiki.documentfoundation.org/Testing_Daily_Builds
 
 Affected users are encouraged to test the fix and report feedback.""" 
%(new_version)
 
@@ -167,7 +165,8 @@ def get_commit(repo, commit_id):
 commit = repo.commit(commit_id)
 return commit
 
-def find_bugid(commit):
+def find_bugid(repo, commit_id):
+commit = get_commit(repo, commit_id)
 summary_line = commit.summary
 regex = re.compile(bug_regex)
 m = regex.findall(summary_line)
@@ -179,7 +178,7 @@ def find_bugid(commit):
 
 def read_repo(repo_name):
 config = ConfigParser.ConfigParser()
-config.read('/home/ciabot/prod/config.cfg')
+config.read('/srv/home/ciabot/prod/config.cfg')
 path = config.get(repo_name, 'location')
 repo = git.repo.base.Repo(path)
 return repo
@@ -219,9 +218,9 @@ def main(argv):
 
 target_version = find_target_version(repo, branch)
 
-commit = get_commit(repo, commit_id)
+bug_ids = find_bugid(repo, commit_id)
 
-bug_ids = find_bugid(commit)
+commit = get_commit(repo, commit_id)
 
 if target_version is None:
 print("missing target version")
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'distro/cib/libreoffice-6-1' - 7 commits - basctl/uiconfig brand/cib chart2/uiconfig configure.ac dbaccess/source dbaccess/uiconfig download.lst extensions/uicon

2019-06-17 Thread Thorsten Behrens (via logerrit)
Rebased ref, commits from common ancestor:
commit 19c369ce16149b521a55e430d8eb1bd87f0c9655
Author: Thorsten Behrens 
AuthorDate: Mon Jun 17 13:04:19 2019 +0200
Commit: Thorsten Behrens 
CommitDate: Mon Jun 17 13:17:22 2019 +0200

Bump version to 6.1.7.1

Final 1st release LibreOffice powered by CIB 6.1

Change-Id: I51c6dc30f3456b238c361db91c0a2772d7907f6d

diff --git a/configure.ac b/configure.ac
index 915c2b143757..4097dd565e50 100644
--- a/configure.ac
+++ b/configure.ac
@@ -9,7 +9,7 @@ dnl in order to create a configure script.
 # several non-alphanumeric characters, those are split off and used only for 
the
 # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no 
idea.
 
-AC_INIT([LibreOffice powered by 
CIB],[6.1.7.0.0+],[],[],[http://libreoffice.cib.eu/])
+AC_INIT([LibreOffice powered by 
CIB],[6.1.7.1],[],[],[https://libreoffice.cib.eu/])
 
 AC_PREREQ([2.59])
 
commit 8599ef0a300904f581bb7c2fc6144bdec4ea1ff3
Author: Xisco Fauli 
AuthorDate: Wed May 29 11:19:57 2019 +0200
Commit: Thorsten Behrens 
CommitDate: Mon Jun 17 13:17:21 2019 +0200

tdf#114596 dbaccess: fix mysterious dataloss bug (part 2)

Same problem as in 96ae2a3300811897c24cccb20f8c2faf382483df

Regression from 497e40ad03c27837978551ba15491c3fb2a0bf53

Change-Id: I00e7bf3559e688e7fbc5429ace2b5c18221c9890
Reviewed-on: https://gerrit.libreoffice.org/73146
Reviewed-by: Michael Stahl 
Tested-by: Jenkins
(cherry picked from commit 58f121ef2e680697e10453add43bab9b771d153a)
Reviewed-on: https://gerrit.libreoffice.org/73153
(cherry picked from commit ebae54a6fde07a08e0b666b56dbd654691e5c416)
Reviewed-on: https://gerrit.libreoffice.org/73543
Tested-by: Michael Stahl 

diff --git a/dbaccess/source/core/api/TableDeco.cxx 
b/dbaccess/source/core/api/TableDeco.cxx
index a57883ba2ba2..c80f6974be9e 100644
--- a/dbaccess/source/core/api/TableDeco.cxx
+++ b/dbaccess/source/core/api/TableDeco.cxx
@@ -553,7 +553,7 @@ void ODBTableDecorator::refreshColumns()
 OContainerMediator* pMediator = new OContainerMediator( pCol, 
m_xColumnDefinitions );
 m_xColumnMediator = pMediator;
 pCol->setMediator( pMediator );
-m_pColumns = pCol;
+m_pColumns.reset(pCol);
 }
 else
 m_pColumns->reFill(aVector);
diff --git a/dbaccess/source/core/inc/TableDeco.hxx 
b/dbaccess/source/core/inc/TableDeco.hxx
index 5a964e79401d..52d6fb05e0bb 100644
--- a/dbaccess/source/core/inc/TableDeco.hxx
+++ b/dbaccess/source/core/inc/TableDeco.hxx
@@ -71,10 +71,11 @@ namespace dbaccess
 css::uno::Reference< css::sdbc::XDatabaseMetaData >   m_xMetaData;
 css::uno::Reference< css::util::XNumberFormatsSupplier >  
m_xNumberFormats;
 
-// 
+// 
 mutable sal_Int32 
m_nPrivileges;
-// 
-rtl::Reference<::connectivity::sdbcx::OCollection>   m_pColumns;
+// 
+// note: this thing uses the ref-count of "this", see 
OCollection::acquire()!
+std::unique_ptr<::connectivity::sdbcx::OCollection>   m_pColumns;
 
 // IColumnFactory
 virtual OColumn*createColumn(const OUString& _rName) const 
override;
commit 1e0848726c7caf916d7bcd4577453c176c10ec28
Author: Michael Stahl 
AuthorDate: Wed May 22 11:40:54 2019 +0200
Commit: Thorsten Behrens 
CommitDate: Mon Jun 17 13:17:21 2019 +0200

curl: upgrade to release 7.65.0

Fixes CVE-2019-5435. It looks like this is not a problem on 32-bit
Windows because fortunately we don't use /LARGEADDRESSAWARE flag
to set IMAGE_FILE_LARGE_ADDRESS_AWARE... but on 32-bit Linux
the user-space VM is 3GB so an exploit might be possible.

Apparently there's no code in LO that uses the CURLU_URLENCODE flag.

The other one, CVE-2019-5436, doesn't matter because we disable tftp.

Change-Id: I0d4f087befa5a3c4fb21ec36761dad68932425d9
Reviewed-on: https://gerrit.libreoffice.org/72732
Tested-by: Jenkins
Reviewed-by: Michael Stahl 
(cherry picked from commit edb01616ac176401650c35d938c75c6c5558a47e)

diff --git a/download.lst b/download.lst
index e84baea4995e..b0f60e13e5bd 100644
--- a/download.lst
+++ b/download.lst
@@ -29,8 +29,8 @@ export CPPUNIT_SHA256SUM := 
3d569869d27b48860210c758c4f313082103a5e58219a7669b52
 export CPPUNIT_TARBALL := cppunit-1.14.0.tar.gz
 export CT2N_SHA256SUM := 
71b238efd2734be9800af07566daea8d6685aeed28db5eb5fa0e6453f4d85de3
 export CT2N_TARBALL := 
1f467e5bb703f12cbbb09d5cf67ecf4a-converttexttonumber-1-5-0.oxt
-export CURL_SHA256SUM := 
cb90d2eb74d4e358c1ed1489f8e3af96b50ea4374ad71f143fa4595e998d81b5
-export CURL_TARBALL := curl-7.64.0.tar.gz
+export CURL_SHA256SUM := 
7766d263929404f693905b5e5222aa0f2bdf8c66ab4b8758f0c0820a42b966cd
+export CURL_TARBALL := curl-7.65.0.tar.xz
 export EBOOK_SHA256SUM := 
7e8d8ff34f27831aca3bc6f9cc53

[Libreoffice-commits] core.git: Branch 'distro/cib/libreoffice-6-1' - basctl/uiconfig chart2/uiconfig dbaccess/uiconfig extensions/uiconfig framework/uiconfig reportdesign/uiconfig sc/uiconfig sd/uico

2019-06-16 Thread Thorsten Behrens (via logerrit)
 basctl/uiconfig/basicide/menubar/menubar.xml   |2 --
 chart2/uiconfig/menubar/menubar.xml|2 --
 dbaccess/uiconfig/dbapp/menubar/menubar.xml|2 --
 dbaccess/uiconfig/dbquery/menubar/menubar.xml  |2 --
 dbaccess/uiconfig/dbrelation/menubar/menubar.xml   |2 --
 dbaccess/uiconfig/dbtable/menubar/menubar.xml  |2 --
 dbaccess/uiconfig/dbtdata/menubar/menubar.xml  |2 --
 extensions/uiconfig/sbibliography/menubar/menubar.xml  |2 --
 framework/uiconfig/startmodule/menubar/menubar.xml |2 --
 reportdesign/uiconfig/dbreport/menubar/menubar.xml |2 --
 sc/uiconfig/scalc/menubar/menubar.xml  |2 --
 sc/uiconfig/scalc/popupmenu/notebookbar.xml|1 -
 sc/uiconfig/scalc/ui/notebookbar.ui|7 ---
 sc/uiconfig/scalc/ui/notebookbar_groupedbar_full.ui|7 ---
 sd/uiconfig/sdraw/menubar/menubar.xml  |2 --
 sd/uiconfig/sdraw/popupmenu/notebookbar.xml|1 -
 sd/uiconfig/simpress/menubar/menubar.xml   |2 --
 sd/uiconfig/simpress/popupmenu/notebookbar.xml |1 -
 sd/uiconfig/simpress/ui/notebookbar.ui |7 ---
 sd/uiconfig/simpress/ui/notebookbar_groupedbar_full.ui |7 ---
 starmath/uiconfig/smath/menubar/menubar.xml|2 --
 sw/uiconfig/sglobal/menubar/menubar.xml|2 --
 sw/uiconfig/sweb/menubar/menubar.xml   |2 --
 sw/uiconfig/swform/menubar/menubar.xml |2 --
 sw/uiconfig/swreport/menubar/menubar.xml   |2 --
 sw/uiconfig/swriter/menubar/menubar.xml|2 --
 sw/uiconfig/swriter/popupmenu/notebookbar.xml  |1 -
 sw/uiconfig/swriter/ui/notebookbar.ui  |7 ---
 sw/uiconfig/swriter/ui/notebookbar_groupedbar_full.ui  |7 ---
 sw/uiconfig/swxform/menubar/menubar.xml|2 --
 30 files changed, 86 deletions(-)

New commits:
commit b27735dc2baed2a0811ad6b5cb80b4e3f09110b2
Author: Thorsten Behrens 
AuthorDate: Mon Jun 17 02:41:36 2019 +0200
Commit: Thorsten Behrens 
CommitDate: Mon Jun 17 02:42:14 2019 +0200

Remove Help menu donate entry for LTS version

Change-Id: I78db5b1989dee9ab10d670f26d08237335ffcc29

diff --git a/basctl/uiconfig/basicide/menubar/menubar.xml 
b/basctl/uiconfig/basicide/menubar/menubar.xml
index 54accb5691db..429c6e544958 100644
--- a/basctl/uiconfig/basicide/menubar/menubar.xml
+++ b/basctl/uiconfig/basicide/menubar/menubar.xml
@@ -165,8 +165,6 @@
 
 
 
-
-
 
 
 
diff --git a/chart2/uiconfig/menubar/menubar.xml 
b/chart2/uiconfig/menubar/menubar.xml
index 65cef6328d37..145ac10a63d3 100644
--- a/chart2/uiconfig/menubar/menubar.xml
+++ b/chart2/uiconfig/menubar/menubar.xml
@@ -164,8 +164,6 @@
 
 
 
-
-
 
 
 
diff --git a/dbaccess/uiconfig/dbapp/menubar/menubar.xml 
b/dbaccess/uiconfig/dbapp/menubar/menubar.xml
index 9c6b619a4ed6..bf01936f26c6 100644
--- a/dbaccess/uiconfig/dbapp/menubar/menubar.xml
+++ b/dbaccess/uiconfig/dbapp/menubar/menubar.xml
@@ -148,8 +148,6 @@
 
 
 
-
-
 
 
 
diff --git a/dbaccess/uiconfig/dbquery/menubar/menubar.xml 
b/dbaccess/uiconfig/dbquery/menubar/menubar.xml
index 7d2a633d29ed..fde03bb553bd 100644
--- a/dbaccess/uiconfig/dbquery/menubar/menubar.xml
+++ b/dbaccess/uiconfig/dbquery/menubar/menubar.xml
@@ -102,8 +102,6 @@
 
 
 
-
-
 
 
 
diff --git a/dbaccess/uiconfig/dbrelation/menubar/menubar.xml 
b/dbaccess/uiconfig/dbrelation/menubar/menubar.xml
index ac109df9185b..56d95b922427 100644
--- a/dbaccess/uiconfig/dbrelation/menubar/menubar.xml
+++ b/dbaccess/uiconfig/dbrelation/menubar/menubar.xml
@@ -85,8 +85,6 @@
 
 
 
-
-
 
 
 
diff --git a/dbaccess/uiconfig/dbtable/menubar/menubar.xml 
b/dbaccess/uiconfig/dbtable/menubar/menubar.xml
index b64ea8fd86ba..3018f1156b4f 100644
--- a/dbaccess/uiconfig/dbtable/menubar/menubar.xml
+++ b/dbaccess/uiconfig/dbtable/menubar/menubar.xml
@@ -86,8 +86,6 @@
 
 
 
-
-
 
 
 
diff --git a/dbaccess/uiconfig/dbtdata/menubar/menubar.xml 
b/dbaccess/uiconfig/dbtdata/menubar/menubar.xml
index 485416e34a29..450c070cfb33 100644
--- a/dbaccess/uiconfig/dbtdata/menubar/menubar.xml
+++ b/dbaccess/uiconfig/dbtdata/menubar/menubar.xml
@@ -94,8 +94,6 @@
 
 
 
-
-
 
 
 
diff --git

[Libreoffice-commits] core.git: Branch 'distro/cib/libreoffice-6-1' - configure.ac instsetoo_native/inc_ooohelppack instsetoo_native/util

2019-06-16 Thread Thorsten Behrens (via logerrit)
 configure.ac|2 +-
 instsetoo_native/inc_ooohelppack/windows/msi_templates/Property.idt |7 
+++
 instsetoo_native/util/openoffice.lst.in |   10 
+-
 3 files changed, 9 insertions(+), 10 deletions(-)

New commits:
commit bd1314fbde12cd8d90903fa520edc0f0458d347e
Author: Thorsten Behrens 
AuthorDate: Sun Jun 16 17:09:46 2019 +0200
Commit: Thorsten Behrens 
CommitDate: Sun Jun 16 17:11:43 2019 +0200

Bump version to 6.1.7.1, cleanup product links

Final 1st release LibreOffice powered by CIB 6.1

Change-Id: Ife79b1bec111a7a67a280482ea1c73dcf7a59f7b

diff --git a/configure.ac b/configure.ac
index 7cdabf456c3e..eb496653b5f9 100644
--- a/configure.ac
+++ b/configure.ac
@@ -9,7 +9,7 @@ dnl in order to create a configure script.
 # several non-alphanumeric characters, those are split off and used only for 
the
 # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no 
idea.
 
-AC_INIT([LibreOffice Powered by 
CIB],[6.1.7.0.0+],[],[],[http://libreoffice.cib.eu/])
+AC_INIT([LibreOffice Powered by 
CIB],[6.1.7.1],[],[],[https://libreoffice.cib.eu/])
 
 AC_PREREQ([2.59])
 
diff --git 
a/instsetoo_native/inc_ooohelppack/windows/msi_templates/Property.idt 
b/instsetoo_native/inc_ooohelppack/windows/msi_templates/Property.idt
index b44bdd11887b..1e78c7476822 100644
--- a/instsetoo_native/inc_ooohelppack/windows/msi_templates/Property.idt
+++ b/instsetoo_native/inc_ooohelppack/windows/msi_templates/Property.idt
@@ -8,10 +8,9 @@ ApplicationUsers   AllUsers
 ALLUSERS   1
 ARPCOMMENTSARPCOMMENTSTEMPLATE
 ARPCONTACT CIB software GmbH
-ARPHELPLINKhttp://libreoffice.cib.eu
-ARPHELPTELEPHONE libreoff...@cib.de
-ARPURLINFOABOUThttp://libreoffice.cib.eu
-ARPURLUPDATEINFO   http://libreoffice.cib.eu
+ARPHELPLINKhttps://libreoffice.cib.eu
+ARPURLINFOABOUThttps://libreoffice.cib.eu
+ARPURLUPDATEINFO   https://libreoffice.cib.eu
 DefaultUIFont  Tahoma8
 DialogCaption  Windows Installer
 DiskPrompt [1]
diff --git a/instsetoo_native/util/openoffice.lst.in 
b/instsetoo_native/util/openoffice.lst.in
index 5b5f62bd0d75..7c8daf33f52f 100644
--- a/instsetoo_native/util/openoffice.lst.in
+++ b/instsetoo_native/util/openoffice.lst.in
@@ -70,7 +70,7 @@ LibreOfficePoweredByCIB
 CHANGETARGETDIR 1
 PATCHCODEFILE ooo_patchcodes.txt
 STARTCENTER_ADDFEATURE_URL http://extensions.libreoffice.org/
-STARTCENTER_INFO_URL http://libreoffice.cib.eu
+STARTCENTER_INFO_URL https://libreoffice.cib.eu
 STARTCENTER_TEMPLREP_URL http://templates.libreoffice.org/
 DICT_REPO_URL http://extensions.libreoffice.org/dictionaries/
 STARTCENTER_HIDE_EXTERNAL_LINKS 0
@@ -81,7 +81,7 @@ LibreOfficePoweredByCIB
 downloadname   
LibreOfficePoweredByCIB_{productversion}_{os}_install_{languages}
 langpackdownloadname   
LibreOfficePoweredByCIB_{productversion}_languagepack_{os}_install_{languages}
 helppackdownloadname   
LibreOfficePoweredByCIB_{productversion}_helppack_{os}_install_{languages}
-include  
{installscriptdir},{customtargetpath}/readlicense_oo/readme,{customtargetpath}/sysui/{pkgtype},{customtargetpath}/setup_native,{filelistpath}/PackageSet,{filelistpath}/GeneratedPackage,{filelistpath}/Package,{filelistpath}/ExtensionPackage,{extensionsdir},{licensepath},{customtargetpath}/readlicense_oo/license,{packinfopath}
+include 
{installscriptdir},{customtargetpath}/readlicense_oo/readme,{customtargetpath}/sysui/{pkgtype},{customtargetpath}/setup_native,{filelistpath}/PackageSet,{filelistpath}/GeneratedPackage,{filelistpath}/Package,{filelistpath}/ExtensionPackage,{filelistpath}/CustomTarget/helpcontent2/help3xsl/filelists,{extensionsdir},{licensepath},{packinfopath}
 }
 }
 
@@ -123,7 +123,7 @@ LibreOfficePoweredByCIBDev
 CODEFILENAME codes_ooodev.txt
 LOCALUSERDIR $ORIGIN/..
 STARTCENTER_ADDFEATURE_URL https://extensions.libreoffice.org/
-STARTCENTER_INFO_URL http://libreoffice.cib.eu
+STARTCENTER_INFO_URL https://libreoffice.cib.eu
 STARTCENTER_TEMPLREP_URL https://templates.libreoffice.org/
 DICT_REPO_URL https://extensions.libreoffice.org/dictionaries/
 }
@@ -164,7 +164,7 @@ LibreOfficePoweredByCIB_SDK
 CHANGETARGETDIR 1
 DONTUSESTARTMENUFOLDER 1
 STARTCENTER_ADDFEATURE_URL https://extensions.libreoffice.org/
-STARTCENTER_INFO_URL http://libreoffice.cib.eu
+STARTCENTER_INFO_URL https://libreoffice.cib.eu
 STARTCENTER_TEMPLREP_URL https://templates.libreoffice.org/
 DICT_REPO_URL https://extensions.libreoffice.org/dictionaries/
 }
@@ -209,7 +209,7 @@ LibreOfficePoweredByCIBDev_SDK
 CHANGETARGETDIR 1

[Libreoffice-commits] core.git: Branch 'distro/cib/libreoffice-6-1' - solenv/bin

2019-06-10 Thread Thorsten Behrens (via logerrit)
Rebased ref, commits from common ancestor:
commit d7341319aae973b3b4a7fe601add79dca8f9e69e
Author: Thorsten Behrens 
AuthorDate: Tue Jun 11 01:51:23 2019 +0200
Commit: Thorsten Behrens 
CommitDate: Tue Jun 11 06:31:15 2019 +0200

Hack to make rpmbuild get a proper build root

Otherwise rpm BUILDROOT will contain spaces, and things break
at various places during packaging

Change-Id: I20229ce533913fa000978aa84b1a2a5d998da14d

diff --git a/solenv/bin/modules/installer/download.pm 
b/solenv/bin/modules/installer/download.pm
index 63103816e89f..c1776053ec1e 100644
--- a/solenv/bin/modules/installer/download.pm
+++ b/solenv/bin/modules/installer/download.pm
@@ -290,7 +290,7 @@ sub get_downloadname_productname
 
 my $start = "";
 
-$start = $allvariables->{'PRODUCTNAME'};
+$start = $allvariables->{'PRODUCTNAME'}; $start =~ s/ /_/g;
 
 return $start;
 }
diff --git a/solenv/bin/modules/installer/setupscript.pm 
b/solenv/bin/modules/installer/setupscript.pm
index 6eefe01f0bd5..4a5a1003cb3e 100644
--- a/solenv/bin/modules/installer/setupscript.pm
+++ b/solenv/bin/modules/installer/setupscript.pm
@@ -166,7 +166,7 @@ sub add_lowercase_productname_setupscriptvariable
 $newline = "\%MASKEDPRODUCTNAME " . $value . "\n";
 push(@{$variablesref} ,$newline);
 $value = $original;
-$value =~ s/\s/\_/g;
+$value =~ s/\s//g;
 $newline = "\%UNIXPRODUCTNAME " . lc($value) . "\n";
 push(@{$variablesref} ,$newline);
 $newline = "\%SYSTEMINTUNIXPACKAGENAME " . lc($value) . "\n";
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'distro/cib/libreoffice-6-1' - 2 commits - instsetoo_native/CustomTarget_install.mk instsetoo_native/CustomTarget_setup.mk solenv/bin

2019-06-10 Thread Thorsten Behrens (via logerrit)
 instsetoo_native/CustomTarget_install.mk |2 +-
 instsetoo_native/CustomTarget_setup.mk   |2 +-
 solenv/bin/modules/installer/download.pm |2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

New commits:
commit ad40492c5d8d9438e3495eeec6bb5b8c7e8d82d2
Author: Thorsten Behrens 
AuthorDate: Tue Jun 11 01:51:23 2019 +0200
Commit: Thorsten Behrens 
CommitDate: Tue Jun 11 01:53:54 2019 +0200

Hack to make rpmbuild get a proper build root

Otherwise rpm BUILDROOT will contain spaces, and things break
at various places during packaging

Change-Id: I20229ce533913fa000978aa84b1a2a5d998da14d

diff --git a/solenv/bin/modules/installer/download.pm 
b/solenv/bin/modules/installer/download.pm
index 63103816e89f..c1776053ec1e 100644
--- a/solenv/bin/modules/installer/download.pm
+++ b/solenv/bin/modules/installer/download.pm
@@ -290,7 +290,7 @@ sub get_downloadname_productname
 
 my $start = "";
 
-$start = $allvariables->{'PRODUCTNAME'};
+$start = $allvariables->{'PRODUCTNAME'}; $start =~ s/ /_/g;
 
 return $start;
 }
commit 375ed9b83aa182c3d080b0ff6ea6d5fcdc74ed30
Author: Thorsten Behrens 
AuthorDate: Tue Jun 11 01:24:26 2019 +0200
Commit: Thorsten Behrens 
CommitDate: Tue Jun 11 01:53:27 2019 +0200

Use productname w/o space for config dir

And also save us the duplicate work

Change-Id: I64cb50ffe925b03648514b68a719a593e0fec898

diff --git a/instsetoo_native/CustomTarget_install.mk 
b/instsetoo_native/CustomTarget_install.mk
index 016fbbd03abd..bd8a0f657cbd 100644
--- a/instsetoo_native/CustomTarget_install.mk
+++ b/instsetoo_native/CustomTarget_install.mk
@@ -59,7 +59,7 @@ export LOCAL_COMMON_OUT := $(instsetoo_OUT)
 
 instsetoo_native_WITH_LANG := en-US $(filter-out en-US,$(gb_WITH_LANG))
 
-PRODUCTNAME_no_spaces := $(subst $(WHITESPACE),,$(PRODUCTNAME))
+PRODUCTNAME_no_spaces := $(PRODUCTNAME_WITHOUT_SPACES)
 
 ifeq (WNT,$(OS))
 define instsetoo_native_msitemplates
diff --git a/instsetoo_native/CustomTarget_setup.mk 
b/instsetoo_native/CustomTarget_setup.mk
index ec31d718a6a0..4d47d8d894e8 100644
--- a/instsetoo_native/CustomTarget_setup.mk
+++ b/instsetoo_native/CustomTarget_setup.mk
@@ -40,7 +40,7 @@ $(call 
gb_CustomTarget_get_workdir,instsetoo_native/setup)/$(call gb_Helper_get_
&& echo 'InstallMode=' \
&& echo 'ProductKey=$(PRODUCTNAME) $(PRODUCTVERSION)' \
$(if $(ENABLE_RELEASE_BUILD),\
-   && echo 'UserInstallation=$$SYSUSERCONFIG/$(if 
$(filter-out MACOSX WNT,$(OS)),$(shell echo $(PRODUCTNAME) | tr "[:upper:]" 
"[:lower:]"),$(shell echo $(PRODUCTNAME) | sed -e 's/ /%20/g'))/4', \
+   && echo 'UserInstallation=$$SYSUSERCONFIG/$(if 
$(filter-out MACOSX WNT,$(OS)),$(shell echo $(PRODUCTNAME_WITHOUT_SPACES) | tr 
"[:upper:]" "[:lower:]"),$(PRODUCTNAME_WITHOUT_SPACES))/4', \
&& echo 'UserInstallation=$$ORIGIN/..') \
) > $@
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'distro/cib/libreoffice-6-1' - 26 commits - configure.ac desktop/source download.lst external/libxslt filter/source fpicker/source icon-themes/colibre icon-theme

2019-05-31 Thread Thorsten Behrens (via logerrit)
Rebased ref, commits from common ancestor:
commit ebe224bed7995331b764176baa39cfb24f2f3493
Author: Thorsten Behrens 
AuthorDate: Wed Jul 18 18:06:44 2018 +0200
Commit: Thorsten Behrens 
CommitDate: Fri May 31 15:06:30 2019 +0200

Default OpenGL to off on all platforms

Change-Id: Ide04d3b37b9fabb64d514fd87acbdfe9e49e6727

diff --git a/officecfg/registry/data/org/openoffice/Office/Common.xcu 
b/officecfg/registry/data/org/openoffice/Office/Common.xcu
index 26d1ba053a1e..1e001efd4a12 100644
--- a/officecfg/registry/data/org/openoffice/Office/Common.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/Common.xcu
@@ -59,9 +59,7 @@
   
   
 
-  false
-  false
-  true
+  false
 
   
   
commit e54fc33f35cbc43a6e8d7d8fe80714d92eee62f4
Author: Samuel Mehrbrodt 
AuthorDate: Thu Jan 12 16:46:45 2017 +0100
Commit: Thorsten Behrens 
CommitDate: Fri May 31 15:06:30 2019 +0200

Disable crash reporter UI

Change-Id: I8106ec674080ede7072581dab2e6700040de5828
(cherry picked from commit b981aa30c3eb5ddd0cf6c35e4c37ab687667f71b)

diff --git a/desktop/source/app/app.cxx b/desktop/source/app/app.cxx
index c83d424f8a30..e7a4f82ba081 100644
--- a/desktop/source/app/app.cxx
+++ b/desktop/source/app/app.cxx
@@ -913,7 +913,8 @@ bool crashReportInfoExists()
 #if HAVE_FEATURE_BREAKPAD
 void handleCrashReport()
 {
-static const char SERVICENAME_CRASHREPORT[] = 
"com.sun.star.comp.svx.CrashReportUI";
+// Don't show the dialog since we don't offer upload - only want the dumps
+/*static const char SERVICENAME_CRASHREPORT[] = 
"com.sun.star.comp.svx.CrashReportUI";
 
 css::uno::Reference< css::uno::XComponentContext > xContext = 
::comphelper::getProcessComponentContext();
 
@@ -927,7 +928,7 @@ void handleCrashReport()
 css::util::URL aURL;
 css::uno::Any aRet = xRecoveryUI->dispatchWithReturnValue(aURL, 
css::uno::Sequence< css::beans::PropertyValue >());
 bool bRet = false;
-aRet >>= bRet;
+aRet >>= bRet;*/
 }
 #endif
 
commit bfd0e0ae0431dfa499c917217f660916a9b384c3
Author: Katarina Behrens 
AuthorDate: Wed Feb 10 14:42:18 2016 +0100
Commit: Thorsten Behrens 
CommitDate: Fri May 31 15:06:30 2019 +0200

Branded images for msi installer

The sizes are 122 x 234, 374 x 44 installed units respectively, according to

http://msdn.microsoft.com/de-de/library/windows/desktop/aa369490%28v=vs.85%29.aspx

it is 163x312, 499x58 pixels at 96 dpi. I bumped dpi to 120 and it still 
looks pixelated,
but it's as good as it gets.

For better results, we need different graphics, with less fine details 
given the very limited
space

Change-Id: I4a7eafed16fd79f377d27afa8151cfab614b464b

diff --git 
a/instsetoo_native/inc_common/windows/msi_templates/Binary/Banner.bmp 
b/instsetoo_native/inc_common/windows/msi_templates/Binary/Banner.bmp
index 5a163cf86c23..471eea4c22e6 100644
Binary files 
a/instsetoo_native/inc_common/windows/msi_templates/Binary/Banner.bmp and 
b/instsetoo_native/inc_common/windows/msi_templates/Binary/Banner.bmp differ
diff --git a/instsetoo_native/inc_common/windows/msi_templates/Binary/Image.bmp 
b/instsetoo_native/inc_common/windows/msi_templates/Binary/Image.bmp
index b4210d131ba2..2703670952bd 100644
Binary files 
a/instsetoo_native/inc_common/windows/msi_templates/Binary/Image.bmp and 
b/instsetoo_native/inc_common/windows/msi_templates/Binary/Image.bmp differ
commit 72bf9fcbc655d2a4c25be80940c85505d4c47faa
Author: Katarina Behrens 
AuthorDate: Tue Feb 9 11:09:30 2016 +0100
Commit: Thorsten Behrens 
CommitDate: Fri May 31 15:06:30 2019 +0200

Branded application icons

sadly, this doesn't replace Windows taskbar icon, that must be living 
somewhere
else. It works on Linux though.

 Conflicts:
icon-themes/galaxy/res/main128.png
icon-themes/galaxy/res/mainapp_16.png
icon-themes/galaxy/res/mainapp_16_8.png
icon-themes/galaxy/res/mainapp_32.png
icon-themes/galaxy/res/mainapp_32_8.png
icon-themes/galaxy/res/mainapp_48_8.png

Change-Id: I028fc68d96f02113622c5e1ec3ed830ac797be0b

diff --git a/icon-themes/galaxy/res/main128.png 
b/icon-themes/galaxy/res/main128.png
new file mode 100644
index ..818b7330c25b
Binary files /dev/null and b/icon-themes/galaxy/res/main128.png differ
diff --git a/icon-themes/galaxy/res/mainapp_48_8.png 
b/icon-themes/galaxy/res/mainapp_48_8.png
new file mode 100644
index ..562ea23e89c2
Binary files /dev/null and b/icon-themes/galaxy/res/mainapp_48_8.png differ
diff --git a/icon-themes/tango/res/mainapp_16.png 
b/icon-themes/tango/res/mainapp_16.png
index 4a96735b6bb6..13945eeadfd4 100644
Binary files a/icon-themes/tango/res/mainapp_16.png and 
b/icon-themes/tango/res/mainapp_16.png differ
diff --git a/icon-themes/tango/res/mainapp_16_8.png 
b/icon-themes/tango/res/ma

[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-5-2+backports' - sc/qa sc/source

2019-05-28 Thread Thorsten Behrens (via logerrit)
 sc/qa/unit/subsequent_filters-test.cxx |1 +
 sc/source/core/data/drwlayer.cxx   |4 ++--
 2 files changed, 3 insertions(+), 2 deletions(-)

New commits:
commit 5845eee5c0b45e85d55b120eb555b312cb8bbc8e
Author: Thorsten Behrens 
AuthorDate: Tue May 28 16:08:58 2019 +0200
Commit: Thorsten Behrens 
CommitDate: Wed May 29 00:21:22 2019 +0200

sc: fix WaE

Change-Id: I68aaeb638df6bb4858371adc81f80f4228be8ac9

diff --git a/sc/qa/unit/subsequent_filters-test.cxx 
b/sc/qa/unit/subsequent_filters-test.cxx
index a5a276ea055d..75173251efaf 100644
--- a/sc/qa/unit/subsequent_filters-test.cxx
+++ b/sc/qa/unit/subsequent_filters-test.cxx
@@ -3533,6 +3533,7 @@ void ScFiltersTest::testAutoheight2Rows()
 
 // We will do relative comparison, because calculated autoheight
 // can be different on different platforms
+(void)nHeight2;
 CPPUNIT_ASSERT_MESSAGE("Row #3 shoud be thinner than #1", nHeight3 < 
nHeight1);
 
 xDocSh->DoClose();
diff --git a/sc/source/core/data/drwlayer.cxx b/sc/source/core/data/drwlayer.cxx
index eb471d300b07..e875e92ffd08 100644
--- a/sc/source/core/data/drwlayer.cxx
+++ b/sc/source/core/data/drwlayer.cxx
@@ -1480,8 +1480,8 @@ void ScDrawLayer::DeleteObjectsInSelection( const 
ScMarkData& rMark )
  pObjData->maStart.Row()));
 if (bObjectInMarkArea || bObjectAnchoredToMarkedCell)
 {
-ScRange aRange = pDoc->GetRange( nTab, aObjRect );
-if (rMark.IsAllMarked(aRange))
+ScRange aRange2 = pDoc->GetRange( nTab, aObjRect );
+if (rMark.IsAllMarked(aRange2))
 ppObj[nDelCount++] = pObject;
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'feature/cib_contract57b' - solenv/gbuild

2019-05-25 Thread Thorsten Behrens (via logerrit)
 solenv/gbuild/platform/com_MSC_defs.mk |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 68bad2aaa61859d444cd9b722c77fc48c7d5a551
Author: Thorsten Behrens 
AuthorDate: Sat May 25 11:12:18 2019 +0200
Commit: Thorsten Behrens 
CommitDate: Sat May 25 11:12:18 2019 +0200

Disable warning C4005 for Vista-compatible SDK 7.1A builds

No point in pulling in all warning fixes from 5.4

Change-Id: I926b2b41628d7059ec9187918ac9df9c1160dfe6

diff --git a/solenv/gbuild/platform/com_MSC_defs.mk 
b/solenv/gbuild/platform/com_MSC_defs.mk
index 424dad3686d9..30a3dbcafe65 100644
--- a/solenv/gbuild/platform/com_MSC_defs.mk
+++ b/solenv/gbuild/platform/com_MSC_defs.mk
@@ -152,6 +152,7 @@ gb_CFLAGS := \
-nologo \
-W4 \
-wd4091 \
+   -wd4005 \
$(if $(filter 0,$(gb_DEBUGLEVEL)),-wd4100) \
-wd4127 \
$(if $(filter 0,$(gb_DEBUGLEVEL)),-wd4189) \
@@ -194,6 +195,7 @@ gb_CXXFLAGS := \
-nologo \
-W4 \
-wd4091 \
+   -wd4005 \
$(if $(filter 0,$(gb_DEBUGLEVEL)),-wd4100) \
-wd4127 \
$(if $(filter 0,$(gb_DEBUGLEVEL)),-wd4189) \
@@ -259,7 +261,6 @@ gb_PCHWARNINGS = \
-we4651 \
-we4652 \
-we4653 \
-   -we4005 \
 
 gb_STDLIBS := \
advapi32.lib \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: [ABANDONED] Re: Build fail on Libgpg-error on Windows with gawk 5.0

2019-05-22 Thread Thorsten Behrens
Hi Luke,

slacka wrote:
> Can we update this tarball so that new LODE installs can work again?
>
I've uploaded the tarball to
https://dev-www.libreoffice.org/src/libgpg-error-1.36.tar.bz2 - want
to have a go at updating the reference in download.lst (and
potentially tweaking a few patches)?

Cheers,

-- Thorsten


signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Converting Python Tuples / Lists into Any in PyUNO

2019-05-17 Thread Thorsten Behrens
Stephan Bergmann wrote:
> On 16/05/2019 14:41, Thomas Viehmann wrote:
> > 2. If 1. is yes, would investigating github projects featuring "import
> > uno" and checking whether and how they use "Any" interfaces be an OKish
> > assessment method?
> 
> Lets hope that somebody else with an actual interest in PyUNO steps in for
> the above.
> 
Well mostly a user for that one - that said, perhaps this github
research could inform further discussions (e.g. if we find many
instances, it's probably a non-starter. if we don't, could tip the
balance to do a low-impact cleanup)?

Alternatively, we could consider collecting breaking changes in an
experimental mode, and at some stage pull a 'python2 -> python3' alike
move.

Cheers,

-- Thorsten


signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: minutes of ESC call ...

2019-05-17 Thread Thorsten Behrens
Stephan Bergmann wrote:
> Whenever I recently happened to look at Gerrit/Jenkins builds that
> hadn't finished yet, it was the Mac build that was still
> outstanding, so I think we do have a bottleneck there after all.
>
Yeah, same anecdotal evidence here. Is the assumption we don't need
more Mac build power based on hard data?

Cheers,

-- Thorsten


signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: improving empty handling in tools::Rectangle

2019-05-08 Thread Thorsten Behrens
Hi Noel, *,

Noel Grandin wrote:
> What I'm doing here is making its behaviour in the empty case more reasonable,
> and adding asserts that will flush out some of the existing dodgy code.
>
Yep, on balance I think that's beneficial.

> I'd be happy to be proven wrong, but I'm not aware of any mechanical
> fixes.
>
Right, and I'm afraid those would obfuscate things even more.

The plan back in the day was to either use float ranges (where - for
graphics - this half vs. closed interval question usually becomes
moot), or B2IBox and B2IRange respectively. And then gradually move
code over to use basegfx & drawinglayer.

From how I see this, that change is best done manual.

Cheers,

-- Thorsten


signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: sw/qa

2019-05-05 Thread Thorsten Behrens (via logerrit)
 sw/qa/extras/inc/swmodeltestbase.hxx   |   18 +
 sw/qa/extras/ooxmlexport/ooxmlexport11.cxx |   56 ++---
 2 files changed, 30 insertions(+), 44 deletions(-)

New commits:
commit 3b1b3728cae244e8d079a3c5d6ed67e933ead389
Author: Thorsten Behrens 
AuthorDate: Fri May 3 18:54:05 2019 +0200
Commit: Thorsten Behrens 
CommitDate: Sun May 5 12:25:19 2019 +0200

sw: make ooxml export tests fail when re-reading doc fails

Bit odd to bail a unit test when reading back the document
doesn't succeed for whatever reasons.

Since there are tests that also check the initial loading
of a docx (even for ooxml export tests), leave those
untouched.

Change-Id: Iede4b360eecf3ff2c864a5d565d21120fd0e1020
Reviewed-on: https://gerrit.libreoffice.org/71503
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens 

diff --git a/sw/qa/extras/inc/swmodeltestbase.hxx 
b/sw/qa/extras/inc/swmodeltestbase.hxx
index 2a34875c91fa..2475c5edcf71 100644
--- a/sw/qa/extras/inc/swmodeltestbase.hxx
+++ b/sw/qa/extras/inc/swmodeltestbase.hxx
@@ -83,8 +83,26 @@ using namespace css;
 CPPUNIT_TEST_SUITE_REGISTRATION(TestName); \
 void TestName::verify()
 
+#define DECLARE_SW_EXPORTONLY_TEST(TestName, filename, password, BaseClass) \
+class TestName : public BaseClass { \
+protected:\
+virtual OUString getTestName() override { return OUString(#TestName); } \
+public:\
+CPPUNIT_TEST_SUITE(TestName); \
+CPPUNIT_TEST(Import_Export_Import); \
+CPPUNIT_TEST_SUITE_END(); \
+\
+void Import_Export_Import() {\
+executeImportExportImportTest(filename, password);\
+}\
+void verify() override;\
+}; \
+CPPUNIT_TEST_SUITE_REGISTRATION(TestName); \
+void TestName::verify()
+
 #define DECLARE_OOXMLIMPORT_TEST(TestName, filename) 
DECLARE_SW_IMPORT_TEST(TestName, filename, nullptr, Test)
 #define DECLARE_OOXMLEXPORT_TEST(TestName, filename) 
DECLARE_SW_ROUNDTRIP_TEST(TestName, filename, nullptr, Test)
+#define DECLARE_OOXMLEXPORT_EXPORTONLY_TEST(TestName, filename) 
DECLARE_SW_EXPORTONLY_TEST(TestName, filename, nullptr, Test)
 #define DECLARE_RTFIMPORT_TEST(TestName, filename) 
DECLARE_SW_IMPORT_TEST(TestName, filename, nullptr, Test)
 #define DECLARE_RTFEXPORT_TEST(TestName, filename) 
DECLARE_SW_ROUNDTRIP_TEST(TestName, filename, nullptr, Test)
 #define DECLARE_ODFIMPORT_TEST(TestName, filename) 
DECLARE_SW_IMPORT_TEST(TestName, filename, nullptr, Test)
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport11.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport11.cxx
index 52068e385454..42677b6de0eb 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport11.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport11.cxx
@@ -136,12 +136,9 @@ DECLARE_OOXMLEXPORT_TEST(testTdf121456_tabsOffset, 
"tdf121456_tabsOffset.odt")
 }
 
 // tdf#121561: make sure w:sdt/w:sdtContent around TOC is written during 
ODT->DOCX conversion
-DECLARE_OOXMLEXPORT_TEST(testTdf121561_tocTitle, "tdf121456_tabsOffset.odt")
+DECLARE_OOXMLEXPORT_EXPORTONLY_TEST(testTdf121561_tocTitle, 
"tdf121456_tabsOffset.odt")
 {
 xmlDocPtr pXmlDoc = parseExport();
-if (!pXmlDoc)
-return;
-
 assertXPathContent(pXmlDoc, 
"/w:document/w:body/w:sdt/w:sdtContent/w:p/w:r/w:t", "Inhaltsverzeichnis");
 assertXPathContent(pXmlDoc, 
"/w:document/w:body/w:sdt/w:sdtContent/w:p/w:r/w:instrText", " TOC \\f \\o 
\"1-9\" \\h");
 assertXPath(pXmlDoc, 
"/w:document/w:body/w:sdt/w:sdtPr/w:docPartObj/w:docPartGallery", "val", "Table 
of Contents");
@@ -158,11 +155,9 @@ DECLARE_OOXMLEXPORT_TEST(testTdf124106, "tdf121456.docx")
 CPPUNIT_ASSERT_EQUAL(sal_Int32(-1), text->getString().indexOf('y'));
 }
 
-DECLARE_OOXMLEXPORT_TEST(testTdf121561_tocTitleDocx, 
"tdf121456_tabsOffset.odt")
+DECLARE_OOXMLEXPORT_EXPORTONLY_TEST(testTdf121561_tocTitleDocx, 
"tdf121456_tabsOffset.odt")
 {
 xmlDocPtr pXmlDoc = parseExport();
-if (!pXmlDoc)
-return;
 
 // get TOC node
 uno::Reference xIndexSupplier(mxComponent, 
uno::UNO_QUERY);
@@ -216,11 +211,9 @@ DECLARE_OOXMLEXPORT_TEST(testTdf82065_Ind_start_strict, 
"tdf82065_Ind_start_stri
 CPPUNIT_ASSERT_EQUAL_MESSAGE("IndentAt defined", true, bFoundIndentAt);
 }
 
-DECLARE_OOXMLEXPORT_TEST(testTdf76683_negativeTwipsMeasure, 
"tdf76683_negativeTwipsMeasure.docx")
+DECLARE_OOXMLEXPORT_EXPORTONLY_TEST(testTdf76683_negativeTwipsMeasure, 
"tdf76683_negativeTwipsMeasure.docx")
 {
 xmlDocPtr pXmlDoc = parseExport("word/document.xml");
-if (!pXmlDoc)
-return;
 assertXPath(pXmlDoc, "/w:document/w:body/w:sectPr/w:cols/w:col", 2);
 sal_uInt32 nColumn1 = getXPath(pXmlDoc, 
"/w:document/w:body/w:sectPr/w:cols/w:col[1]", "w").toUInt32();
 sal_uInt32 nColumn2 = getXPath(pXmlD

[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-6-1+backports' - 12 commits - configure.ac download.lst external/libxslt filter/source include/vcl jvmfwk/inc jvmfwk/plugins jvmfwk/sourc

2019-05-03 Thread Thorsten Behrens (via logerrit)
 configure.ac  |2 
 download.lst  |4 
 external/libxslt/UnpackedTarball_libxslt.mk   |1 
 external/libxslt/e03553605b45c88f0b4b2980adfbbb8f6fca2fd6.patch.1 |  120 
 filter/source/msfilter/msdffimp.cxx   |6 
 include/vcl/graphicfilter.hxx |3 
 jvmfwk/inc/fwkbase.hxx|   11 
 jvmfwk/inc/libxmlutil.hxx |4 
 jvmfwk/inc/vendorplugin.hxx   |   94 
 jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.cxx   |  109 
 jvmfwk/plugins/sunmajor/pluginlib/util.cxx|7 
 jvmfwk/plugins/sunmajor/pluginlib/vendorlist.cxx  |   17 
 jvmfwk/plugins/sunmajor/pluginlib/vendorlist.hxx  |5 
 jvmfwk/source/elements.cxx|4 
 jvmfwk/source/framework.cxx   |  275 -
 jvmfwk/source/fwkbase.cxx |   18 
 jvmfwk/source/libxmlutil.cxx  |2 
 readlicense_oo/license/CREDITS.fodt   | 2572 
+-
 solenv/clang-format/blacklist |4 
 svx/source/svdraw/svdundo.cxx |8 
 translations  |2 
 vcl/source/filter/graphicfilter.cxx   |6 
 22 files changed, 1631 insertions(+), 1643 deletions(-)

New commits:
commit e615ed01b0cbc052fb848e1ab9ff6cd166971430
Merge: b787fb79ecc0 5b3765f4d881
Author: Thorsten Behrens 
AuthorDate: Fri May 3 11:03:51 2019 +0200
Commit: Thorsten Behrens 
CommitDate: Fri May 3 11:03:51 2019 +0200

Merge branch 'libreoffice-6-1'

into distro/lhm/libreoffice-6-1+backports

Change-Id: I6b21f26c55149b5ac59b65d403612a4612ece58b

commit 5b3765f4d881e7ddefd0c4aad6886a46f000b4fc
Author: Michael Stahl 
AuthorDate: Thu May 2 10:59:01 2019 +0200
Commit: Thorsten Behrens 
CommitDate: Thu May 2 14:57:13 2019 +0200

libpng: upgrade to release 1.6.37

Fixes CVE-2019-7317.

Change-Id: I3374f5cbd6552e2c1569d63ee680d0c1d9389621
Reviewed-on: https://gerrit.libreoffice.org/71663
Tested-by: Jenkins
Reviewed-by: Michael Stahl 
(cherry picked from commit e2abbc0062398ea67cb13cb5b0b7bfdce78e652c)
Reviewed-on: https://gerrit.libreoffice.org/71669
Reviewed-by: Thorsten Behrens 

diff --git a/download.lst b/download.lst
index 24059c694d3c..e84baea4995e 100644
--- a/download.lst
+++ b/download.lst
@@ -204,8 +204,8 @@ export PDFIUM_SHA256SUM := 
80331b48166501a192d65476932f17044eeb5f10faa6ea50f4f17
 export PDFIUM_TARBALL := pdfium-3426.tar.bz2
 export PIXMAN_SHA256SUM := 
21b6b249b51c6800dc9553b65106e1e37d0e25df942c90531d4c3997aa20a88e
 export PIXMAN_TARBALL := e80ebae4da01e77f68744319f01d52a3-pixman-0.34.0.tar.gz
-export LIBPNG_SHA256SUM := 
2f1e960d92ce3b3abd03d06dfec9637dfbd22febf107a536b44f7a47c60659f6
-export LIBPNG_TARBALL := libpng-1.6.34.tar.xz
+export LIBPNG_SHA256SUM := 
505e70834d35383537b6491e7ae8641f1a4bed1876dbfe361201fc80868d88ca
+export LIBPNG_TARBALL := libpng-1.6.37.tar.xz
 export POPPLER_SHA256SUM := 
92e09fd3302567fd36146b36bb707db43ce436e8841219025a82ea9fb0076b2f
 export POPPLER_TARBALL := poppler-0.74.0.tar.xz
 export POSTGRESQL_SHA256SUM := 
db61d498105a7d5fe46185e67ac830c878cdd7dc1f82a87f06b842217924c461
commit 03dbe11013579575afab7b7c39469c1ab06693c3
Author: Christian Lohmaier 
AuthorDate: Thu May 2 13:37:34 2019 +0200
Commit: Gerrit Code Review 
CommitDate: Thu May 2 13:49:41 2019 +0200

Update git submodules

* Update translations from branch 'libreoffice-6-1'
  - update translations for 6.1.6 rc3

and force-fix errors using pocheck

Change-Id: I360802d2255a94fe829e15b72f8f388445e8b740

diff --git a/translations b/translations
index 0826186d866c..e1047f2e97de 16
--- a/translations
+++ b/translations
@@ -1 +1 @@
-Subproject commit 0826186d866cf27a320914b2fe01090aa0647477
+Subproject commit e1047f2e97de220159c6f82ee927dbc0e0b63021
commit 3b69a91bf7b3ccf665c55373121f78f921408009
Author: Caolán McNamara 
AuthorDate: Sat Apr 27 11:52:11 2019 +0100
Commit: Michael Stahl 
CommitDate: Mon Apr 29 11:47:04 2019 +0200

ofz#14469 null deref

since...

commit af84fc9d906626255aaf136eefc5e55236e0e8a6
Date:   Tue Apr 23 15:48:41 2019 +0200

lazy image loading shouldn't read the entire .xls file (tdf#124828)

nLength is just an unchecked value in the dff stream, it might not be sane
so limit it to the max len of the stream

Change-Id: Ia8a2830478952afe1317b5cd795f35059d9b380a
Reviewed-on: https

Re: SystemDependentDataBuffer bits ...

2019-04-26 Thread Thorsten Behrens
Hi Michael,

let me jump in for the moment -

Michael Meeks wrote:
>   It seems odd that just typing in writer should be so rapidly creating
> and destroying these cached items.
>
Right - IIRC that was very trivial hairlines there, not much value in
buffering that -

>   * should we not disable the SystemDependentDataBuffer ie.
> remove:
> 
> if(maEntries.empty() && maTimer)
> maTimer->Stop();
> 
> from there we can stop ourselves in the timeout if necessary.
> 
Not sure I get the question - surely disabling the timer helps to get
scheduler load down? As this code is already inside implTimeoutHdl().

>   Armin - any thoughts on whether this is truly necessary for
>   simple polylines ? (is it to cache the winding / self
>   intersection stuff ? )
> 
Yeah, let's cut off trivial cases from being buffered - but that
should be easy to do in the vcl sal layer. There's already some code
to estimate byte size of the buffered item, can perhaps be extended
with other metrics, and then have some limit below that we simply
don't care.

Just a bit concerned we'd flip-flop between optimizing for different
cases here - some perf test rig would be ideal I guess..

Cheers,

-- Thorsten


signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [ABANDONED] Re: Build fail on Libgpg-error on Windows with gawk 5.0

2019-04-23 Thread Thorsten Behrens
Hi Julien,

Julien Nabet wrote:
> Gerrit failed on it. I had the same on Linux but thought it was something
> else. Since I got no idea of the pb and don't want to waste some time on it,
> let's wait next release of libgpg-error.
> 
Ugh - so it seems that there are breaking changes in gawk 5.0 then?

Didn't find much else beyond this announcement on hacker news:

  https://news.ycombinator.com/item?id=19671983

, but at any rate there's apparently older gawk packages still
available for cygwin:

  https://cygwin.com/packages/x86_64/gawk/

Cheers,

-- Thorsten

signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Build fail on Libgpg-error on Windows with gawk 5.0

2019-04-23 Thread Thorsten Behrens
Hi Julien,

julien2412 wrote:
> It's been fixed upstream (see
> https://github.com/gpg/libgpg-error/commit/7865041c77f4f7005282f10f9bb19072fbdf)
> but the last release hasn't included yet this fix.
> 
> I fixed Windows build locally by taking parts of the patch.
>
Thx a lot - then let's please carry that patch in LibreOffice until
upstream has included it in a release - we patch libgpg-error anyway,
see external/libgpg-error/UnpackedTarball_libgpg-error.mk - could you
add it there?

Cheers,

-- Thorsten


signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Properly notify gpgme about spawn executable location on Windows

2019-04-21 Thread Thorsten Behrens
Hi Mike,

Kaganski Mike wrote:
> On 21.04.2019 0:22, Thorsten Behrens wrote:
> > Hmm - so the uitests are rigging the office in a very specific way,
> > using subprocess.Popen to spawn a child soffice process from python
> > (which calls CreateProcess on Windows). Code for that is in
> > uitest/libreoffice/connection.py, Python3 help blurb is
> > 
> >   https://docs.python.org/3/library/subprocess.html#subprocess.Popen
> > 
> > It is a tad surprising that this would somehow 'think' it is still the
> > main python executable on Windows, perhaps there's a way to
> > parameterize the Popen call differently to rectify that?
> 
> I am quite sure that's python.exe process that I debug in VS here (path: 
> C:\lo\src\core\instdir\program\python-core-3.5.5\bin\python.exe, 
> launched by python.exe in C:\lo\src\core\instdir\program); with a 
> command line like this:
> 
No idea where I got the impression you were talking about uitests -
you didn't mention it anywhere. :/

Anyway, what I say above is a nonsense, as you're referencing pyuno's
own unittests here, which are even more special (and exhibit the
behaviour you describe). ;)

That stuff pulls in test module's libtest (via dlopen from
initTestEnvironment (in pyuno_module.cxx)), which in turn rigs up a
very minimal office suitable for unit tests (see test/Library_test.mk
for what's linked into that).

So this is an artificial environment, that -- except for python-based
unit tests -- is not going to happen in the wild. With that, your
change is only strictly needed if there would be python tests
exercising xmlsecurity functionality.

Cheers,

-- Thorsten

signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Properly notify gpgme about spawn executable location on Windows

2019-04-20 Thread Thorsten Behrens
Hi Mike,

Kaganski Mike wrote:
> However, I suppose that it's possible in theory that some user python 
> script could ultimately need initializing gpgme. In that case, the 
> problem would hit the user. Having a modal dialog waiting on a possibly 
> headless server is not a correct behavior :-)
> 
Hmm - so the uitests are rigging the office in a very specific way,
using subprocess.Popen to spawn a child soffice process from python
(which calls CreateProcess on Windows). Code for that is in
uitest/libreoffice/connection.py, Python3 help blurb is

 https://docs.python.org/3/library/subprocess.html#subprocess.Popen

It is a tad surprising that this would somehow 'think' it is still the
main python executable on Windows, perhaps there's a way to
parameterize the Popen call differently to rectify that?

> My questions are:
> 
> 1. First of all - do I understand it correctly that the problem is real 
> - so there are possible scenarios involving e.g. python (or another 
> process which executable is not in LO's instdir/program), that might 
> need gpgme?
>
See above - but even for uitests, the issue might become relevant, so
I see at least no harm in keeping that fix (unless Popen can be fixed
to not have Windows inherit too much parent process attributes).

> 2. To find the executable, I use UNO_PATH envvar. As far as I can tell, 
> even directly running soffice.bin without having UNO_PATH set in 
> environment, sets the variable correctly, so this works as expected. But 
> is there a better way?
>
The canonical way seems to be something like:

OUString aProgramURL("$BRAND_BASE_DIR/" LIBO_LIBEXEC_FOLDER 
"/");
rtl::Bootstrap::expandMacros(aProgramURL);

> 3. The patch needs to add a gpgmepp wrapper for gpgme_set_global_flag 
> function,
> [snip]
> If there's no way to do that, then I'll create a pr to
> https://github.com/KDE/gpgmepp.
>
Yes please, that's how we did that in the past, too.

Thanks a lot for chasing this,

-- Thorsten

signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'feature/cib_contract57c' - vcl/source

2019-04-13 Thread Thorsten Behrens (via logerrit)
Rebased ref, commits from common ancestor:
commit da9ff87ad9e8831c29a40aa70924c5a50272f723
Author: Thorsten Behrens 
AuthorDate: Thu Apr 11 09:47:27 2019 +0200
Commit: Thorsten Behrens 
CommitDate: Sun Apr 14 00:17:14 2019 +0200

Fix appearance for checkboxes

Conflicts:
vcl/source/gdi/pdfwriter_impl.cxx

(cherry picked from commit 49cb0dc7d70fdb12fa6eb91c98d63f9e0cf0067c)

Change-Id: Id5028b0d062e0491b1cc9c36e2d9d4e4a7ab14a1

diff --git a/vcl/source/gdi/pdfwriter_impl.cxx 
b/vcl/source/gdi/pdfwriter_impl.cxx
index 1f8d1a1a31e9..fc734dc27d11 100644
--- a/vcl/source/gdi/pdfwriter_impl.cxx
+++ b/vcl/source/gdi/pdfwriter_impl.cxx
@@ -66,6 +66,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -4384,45 +4385,75 @@ void PDFWriterImpl::createDefaultCheckBoxAppearance( 
PDFWidget& rBox, const PDFW
 pop();
 
 OStringBuffer aDA( 256 );
+
+// tdf#93853 don't rely on Zapf (or any other 'standard' font)
+// being present, but our own OpenSymbol - N.B. PDF/A for good
+// reasons require even the standard PS fonts to be embedded!
+getReferenceDevice()->Push();
+getReferenceDevice()->SetFont(
+Font( OUString( "OpenSymbol" ), Size( 0, 500 ) ) );
+getReferenceDevice()->ImplNewFont();
+FontCharMapRef pMap;
+getReferenceDevice()->GetFontCharMap(pMap);
+const PhysicalFontFace* pDevFont = m_pReferenceDevice->mpFontInstance->
+GetFontFace();
+getReferenceDevice()->Pop();
+
+// make sure OpenSymbol is embedded, and includes our checkmark
+const sal_Unicode cMark=0x2713;
+const GlyphItem aItem(pMap->GetGlyphIndex(cMark), 0, 0,
+  Point(), 0, 0, 0);
+const std::vector aCodeUnits={ cMark };
+sal_uInt8 nMappedGlyph;
+sal_Int32 nMappedFontObject;
+registerGlyph(, pDevFont, aCodeUnits, nMappedGlyph, 
nMappedFontObject);
+
 appendNonStrokingColor( replaceColor( rWidget.TextColor, 
rSettings.GetRadioCheckTextColor() ), aDA );
-sal_Int32 nBest = getBestBuiltinFont( Font( "ZapfDingbats", 
aFont.GetFontSize() ) );
 aDA.append( ' ' );
-aDA.append( m_aBuiltinFonts[nBest].getNameObject() );
+aDA.append( "/F" );
+aDA.append( nMappedFontObject );
 aDA.append( " 0 Tf" );
+
+OStringBuffer aDR( 32 );
+aDR.append( "/Font " );
+aDR.append( getFontDictObject() );
+aDR.append( " 0 R" );
+rBox.m_aDRDict = aDR.makeStringAndClear();
 rBox.m_aDAString = aDA.makeStringAndClear();
 rBox.m_aMKDict = "/CA";
 rBox.m_aMKDictCAString = "8";
 rBox.m_aRect = aCheckRect;
 
 // create appearance streams
-sal_Char cMark = '8';
-sal_Int32 nCharXOffset = 
1000-m_aBuiltinFonts[13].m_aWidths[sal_Int32(cMark)];
+sal_Int32 nCharXOffset = 1000;
 nCharXOffset *= aCheckRect.GetHeight();
 nCharXOffset /= 2000;
-sal_Int32 nCharYOffset = 1000-
-(m_aBuiltinFonts[13].m_nAscent+m_aBuiltinFonts[13].m_nDescent); // 
descent is negative
+sal_Int32 nCharYOffset = 1000-(820-143); // metrics from Zapf
 nCharYOffset *= aCheckRect.GetHeight();
 nCharYOffset /= 2000;
 
+// write 'checked' appearance stream
 SvMemoryStream* pCheckStream = new SvMemoryStream( 256, 256 );
 beginRedirect( pCheckStream, aCheckRect );
 aDA.append( "/Tx BMC\nq BT\n" );
 appendNonStrokingColor( replaceColor( rWidget.TextColor, 
rSettings.GetRadioCheckTextColor() ), aDA );
 aDA.append( ' ' );
-aDA.append( m_aBuiltinFonts[nBest].getNameObject() );
+aDA.append( "/F" );
+aDA.append( nMappedFontObject );
 aDA.append( ' ' );
 m_aPages[ m_nCurrentPage ].appendMappedLength( sal_Int32( 
aCheckRect.GetHeight() ), aDA );
 aDA.append( " Tf\n" );
 m_aPages[ m_nCurrentPage ].appendMappedLength( nCharXOffset, aDA );
 aDA.append( " " );
 m_aPages[ m_nCurrentPage ].appendMappedLength( nCharYOffset, aDA );
-aDA.append( " Td (" );
-aDA.append( cMark );
-aDA.append( ") Tj\nET\nQ\nEMC\n" );
+aDA.append( " Td <" );
+appendHex( nMappedGlyph, aDA );
+aDA.append( "> Tj\nET\nQ\nEMC\n" );
 writeBuffer( aDA.getStr(), aDA.getLength() );
 endRedirect();
 rBox.m_aAppearances[ "N" ][ "Yes" ] = pCheckStream;
 
+// write 'unchecked' appearance stream
 SvMemoryStream* pUncheckStream = new SvMemoryStream( 256, 256 );
 beginRedirect( pUncheckStream, aCheckRect );
 writeBuffer( "/Tx BMC\nEMC\n", 12 );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: libreoffice-6.2.2.2 compiling "--with-system-gpgmepp" fails

2019-04-13 Thread Thorsten Behrens
Hi John,

John Frankish wrote:
> Using libreoffice-6.2.2.2, gpgme-1.9.0 and gcc-8.2.0
> 
> After copying gpgme headers from include/gpgme++ to include to allow
> compiling to progress, make fails with:
>
Needs a bit more background - internal gpgme is 1.9.0, too; and
e.g. debian is successfully building against system-gpgmepp.

Generally - if you pick non-standard build options, it is usually
expected that you fix possible issues yourself (and we'd be glad to
include any patches for that, of course).

Cheers,

-- Thorsten


signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'feature/cib_contract57c' - vcl/source

2019-04-11 Thread Thorsten Behrens (via logerrit)
 vcl/source/gdi/pdfwriter_impl.cxx |   49 +++---
 1 file changed, 40 insertions(+), 9 deletions(-)

New commits:
commit 49cb0dc7d70fdb12fa6eb91c98d63f9e0cf0067c
Author: Thorsten Behrens 
AuthorDate: Thu Apr 11 09:47:27 2019 +0200
Commit: Thorsten Behrens 
CommitDate: Thu Apr 11 15:42:36 2019 +0200

Fix appearance for checkboxes

Conflicts:
vcl/source/gdi/pdfwriter_impl.cxx

Change-Id: Id5028b0d062e0491b1cc9c36e2d9d4e4a7ab14a1

diff --git a/vcl/source/gdi/pdfwriter_impl.cxx 
b/vcl/source/gdi/pdfwriter_impl.cxx
index 1f8d1a1a31e9..58c08759e92f 100644
--- a/vcl/source/gdi/pdfwriter_impl.cxx
+++ b/vcl/source/gdi/pdfwriter_impl.cxx
@@ -66,6 +66,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -4384,45 +4385,75 @@ void PDFWriterImpl::createDefaultCheckBoxAppearance( 
PDFWidget& rBox, const PDFW
 pop();
 
 OStringBuffer aDA( 256 );
+
+// tdf#93853 don't rely on Zapf (or any other 'standard' font)
+// being present, but our own OpenSymbol - N.B. PDF/A for good
+// reasons require even the standard PS fonts to be embedded!
+Push();
+SetFont( Font( OUString( "OpenSymbol" ), Size( 0, 500 ) ) );
+FontCharMapRef pMap;
+GetFontCharMap(pMap);
+const LogicalFontInstance* pFontInstance = GetFontInstance();
+const PhysicalFontFace* pDevFont = pFontInstance->GetFontFace();
+Pop();
+
+// make sure OpenSymbol is embedded, and includes our checkmark
+const sal_Unicode cMark=0x2713;
+const GlyphItem aItem(pMap->GetGlyphIndex(cMark), 0, 0,
+  Point(), 0, 0, 0,
+  const_cast(pFontInstance));
+const std::vector aCodeUnits={ cMark };
+sal_uInt8 nMappedGlyph;
+sal_Int32 nMappedFontObject;
+registerGlyph(, pDevFont, aCodeUnits, nMappedGlyph, 
nMappedFontObject);
+
 appendNonStrokingColor( replaceColor( rWidget.TextColor, 
rSettings.GetRadioCheckTextColor() ), aDA );
 sal_Int32 nBest = getBestBuiltinFont( Font( "ZapfDingbats", 
aFont.GetFontSize() ) );
 aDA.append( ' ' );
-aDA.append( m_aBuiltinFonts[nBest].getNameObject() );
+aDA.append( "/F" );
+aDA.append( nMappedFontObject );
 aDA.append( " 0 Tf" );
+
+OStringBuffer aDR( 32 );
+aDR.append( "/Font " );
+aDR.append( getFontDictObject() );
+aDR.append( " 0 R" );
+rBox.m_aDRDict = aDR.makeStringAndClear();
 rBox.m_aDAString = aDA.makeStringAndClear();
 rBox.m_aMKDict = "/CA";
 rBox.m_aMKDictCAString = "8";
 rBox.m_aRect = aCheckRect;
 
 // create appearance streams
-sal_Char cMark = '8';
-sal_Int32 nCharXOffset = 
1000-m_aBuiltinFonts[13].m_aWidths[sal_Int32(cMark)];
+sal_Int32 nCharXOffset = 1000;
 nCharXOffset *= aCheckRect.GetHeight();
 nCharXOffset /= 2000;
-sal_Int32 nCharYOffset = 1000-
-(m_aBuiltinFonts[13].m_nAscent+m_aBuiltinFonts[13].m_nDescent); // 
descent is negative
+sal_Int32 nCharYOffset = 1000-(820-143); // metrics from Zapf
 nCharYOffset *= aCheckRect.GetHeight();
 nCharYOffset /= 2000;
 
+// write 'checked' appearance stream
 SvMemoryStream* pCheckStream = new SvMemoryStream( 256, 256 );
 beginRedirect( pCheckStream, aCheckRect );
 aDA.append( "/Tx BMC\nq BT\n" );
 appendNonStrokingColor( replaceColor( rWidget.TextColor, 
rSettings.GetRadioCheckTextColor() ), aDA );
 aDA.append( ' ' );
-aDA.append( m_aBuiltinFonts[nBest].getNameObject() );
+aDA.append( "/F" );
+aDA.append( nMappedFontObject );
 aDA.append( ' ' );
 m_aPages[ m_nCurrentPage ].appendMappedLength( sal_Int32( 
aCheckRect.GetHeight() ), aDA );
 aDA.append( " Tf\n" );
 m_aPages[ m_nCurrentPage ].appendMappedLength( nCharXOffset, aDA );
 aDA.append( " " );
 m_aPages[ m_nCurrentPage ].appendMappedLength( nCharYOffset, aDA );
-aDA.append( " Td (" );
-aDA.append( cMark );
-aDA.append( ") Tj\nET\nQ\nEMC\n" );
+aDA.append( " Td <" );
+appendHex( nMappedGlyph, aDA );
+aDA.append( "> Tj\nET\nQ\nEMC\n" );
 writeBuffer( aDA.getStr(), aDA.getLength() );
 endRedirect();
 rBox.m_aAppearances[ "N" ][ "Yes" ] = pCheckStream;
 
+// write 'unchecked' appearance stream
 SvMemoryStream* pUncheckStream = new SvMemoryStream( 256, 256 );
 beginRedirect( pUncheckStream, aCheckRect );
 writeBuffer( "/Tx BMC\nEMC\n", 12 );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: On backporting fix for tdf#124503 "LibreOffice doesn't detect JVM because of unexpected java.vendor property value"

2019-04-11 Thread Thorsten Behrens
Hi Stephan,

Stephan Bergmann wrote:
> If not, the question is whether to backport the above fix to
> libreoffice-6-1 (towards LO 6.1.6), libreoffice-6-2 (towards LO
> 6.2.4), and maybe even libreoffice-6-2-3. The fix isn't exactly
> small, so I would prefer to not backport it aggressively.  But I
> don't know how severely users would be affected by this issue.
>
I'd prefer a backport to both maintained branches - at the current
speed of new binary Java distros springing up (and the overall
trajectory of that ecosystem there), I'd expect more of those issues
down the road.

Cheers,

-- Thorsten


signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice-commits] core.git: forms/source framework/source include/osl

2019-04-09 Thread Thorsten Behrens
Hi Mike,

Mike Kaganski (via logerrit) wrote:
> [API CHANGE] Asserts to never clear already cleared guard
>
> ... which could help catch copy-paste errors when wrong guard is cleared
> second time.
>
The assert() is quite nice, but:

> --- a/include/osl/mutex.hxx
> +++ b/include/osl/mutex.hxx
> @@ -178,11 +178,9 @@ namespace osl
>  */
>  void clear()
>  {
> -if(pT)
> -{
> -pT->release();
> -pT = NULL;
> -}
> +assert(pT);
> +pT->release();
> +pT = NULL;
>  }
>  };
>
This will have unsuspecting consumers of our API crash if they don't
catch the assertion during development. I'm not sure that's a positive
thing to impose on our ecosystem (where LibreOffice support might
already not be a priority).

I'd be much happier with the pT check still present, but guarded by
!LIBO_INTERNAL_ONLY.

Cheers,

-- Thorsten


signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: vcl/source

2019-04-08 Thread Thorsten Behrens (via logerrit)
 vcl/source/gdi/pdfwriter_impl.cxx |   18 ++
 1 file changed, 10 insertions(+), 8 deletions(-)

New commits:
commit 69b5da392951fbd655912185434edab94f8ac0af
Author: Thorsten Behrens 
AuthorDate: Mon Apr 8 00:32:09 2019 +0200
Commit: Thorsten Behrens 
CommitDate: Mon Apr 8 13:46:05 2019 +0200

pdf: always write resource dict for content streams

Take out:
- revert i#42884 workaround for AR5: use implicit resources in
  transparency groups

Since verapdf complains with FAIL 6.2.2-2 in this case - missing
resource dict for content stream.

Change-Id: Ic186d2b4b393ac34f991a6747667332cf8f4658b
Reviewed-on: https://gerrit.libreoffice.org/70391
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens 

diff --git a/vcl/source/gdi/pdfwriter_impl.cxx 
b/vcl/source/gdi/pdfwriter_impl.cxx
index f4c620bd13da..57b156a14315 100644
--- a/vcl/source/gdi/pdfwriter_impl.cxx
+++ b/vcl/source/gdi/pdfwriter_impl.cxx
@@ -8126,16 +8126,14 @@ void PDFWriterImpl::writeTransparentObject( 
TransparencyEmit& rObject )
 {
 if( ! m_bIsPDF_A1 )
 {
+// 7.8.3 Resource dicts are required for content streams
+aLine.append( "/Resources " );
+aLine.append( getResourceDictObj() );
+aLine.append( " 0 R\n" );
+
 aLine.append( "/Group<>\n" );
 }
 }
-/* #i42884# the PDF reference recommends that each Form XObject
-*  should have a resource dict; alas if that is the same object
-*  as the one of the page it triggers an endless recursion in
-*  acroread 5 (6 and up have that fixed). Since we have only one
-*  resource dict anyway, let's use the one from the page by NOT
-*  emitting a Resources entry.
-*/
 
 aLine.append( "/Length " );
 aLine.append( static_cast(nSize) );
@@ -8207,7 +8205,11 @@ void PDFWriterImpl::writeTransparentObject( 
TransparencyEmit& rObject )
 appendFixedInt( rObject.m_aBoundRect.Bottom()+1, aMask );
 aMask.append( "]\n" );
 
-/* #i42884# see above */
+// 7.8.3 Resource dicts are required for content streams
+aMask.append( "/Resources " );
+aMask.append( getResourceDictObj() );
+aMask.append( " 0 R\n" );
+
 aMask.append( "/Group<>\n" );
 aMask.append( "/Length " );
 aMask.append( nMaskSize );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: questions about LibreOffice API version and jars available on https://mvnrepository.com

2019-04-08 Thread Thorsten Behrens
Hi Lorenzo,

LORENZO Vincent wrote:
>   Yes, of course, I could compile it myself, but I would prefer avoid 
> this step  :-).
>
Seems the maven repo got updated with the latest jars - e.g.
https://mvnrepository.com/artifact/org.libreoffice/jurt lists versions
up to and including 6.2

HTH,

-- Thorsten


signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'feature/cib_contract57c' - 33 commits - configure.ac download.lst external/python3 filter/source filter/uiconfig fpicker/source i18npool/source include/vcl offi

2019-04-07 Thread Thorsten Behrens (via logerrit)
Rebased ref, commits from common ancestor:
commit 6e43a2bcd6f774e81837653262395f2d764374c6
Author: Thorsten Behrens 
AuthorDate: Mon Apr 8 00:32:09 2019 +0200
Commit: Thorsten Behrens 
CommitDate: Mon Apr 8 01:28:16 2019 +0200

pdf: always write resource dict for content streams

Take out:
- revert i#42884 workaround for AR5: use implicit resources in
  transparency groups

Since verapdf complains with FAIL 6.2.2-2 in this case - missing
resource dict for content stream.

Change-Id: Ic186d2b4b393ac34f991a6747667332cf8f4658b

diff --git a/vcl/source/gdi/pdfwriter_impl.cxx 
b/vcl/source/gdi/pdfwriter_impl.cxx
index 108f9199ce4f..1f8d1a1a31e9 100644
--- a/vcl/source/gdi/pdfwriter_impl.cxx
+++ b/vcl/source/gdi/pdfwriter_impl.cxx
@@ -8579,16 +8579,14 @@ void PDFWriterImpl::writeTransparentObject( 
TransparencyEmit& rObject )
 {
 if( ! m_bIsPDF_A1 )
 {
+// 7.8.3 Resource dicts are required for content streams
+aLine.append( "/Resources " );
+aLine.append( getResourceDictObj() );
+aLine.append( " 0 R\n" );
+
 aLine.append( "/Group<>\n" );
 }
 }
-/* #i42884# the PDF reference recommends that each Form XObject
-*  should have a resource dict; alas if that is the same object
-*  as the one of the page it triggers an endless recursion in
-*  acroread 5 (6 and up have that fixed). Since we have only one
-*  resource dict anyway, let's use the one from the page by NOT
-*  emitting a Resources entry.
-*/
 
 aLine.append( "/Length " );
 aLine.append( static_cast(nSize) );
@@ -8661,7 +8659,11 @@ void PDFWriterImpl::writeTransparentObject( 
TransparencyEmit& rObject )
 appendFixedInt( rObject.m_aBoundRect.Bottom()+1, aMask );
 aMask.append( "]\n" );
 
-/* #i42884# see above */
+// 7.8.3 Resource dicts are required for content streams
+aMask.append( "/Resources " );
+aMask.append( getResourceDictObj() );
+aMask.append( " 0 R\n" );
+
 aMask.append( "/Group<>\n" );
 aMask.append( "/Length " );
 aMask.append( nMaskSize );
commit 4b50b27c75830f1a3c2debc231f6c8e214a910bc
Author: Samuel Mehrbrodt 
AuthorDate: Tue Mar 26 15:08:12 2019 +0100
Commit: Thorsten Behrens 
CommitDate: Mon Apr 8 01:28:05 2019 +0200

Fix windows build

After 54ac2b203a6dd974c0153996ba67b26d585e98e1

Change-Id: I805415dfa75568d843fceb5a79b637aac337ffd4

diff --git a/vcl/win/gdi/salfont.cxx b/vcl/win/gdi/salfont.cxx
index b0158f9154d5..f3d0cf97811e 100644
--- a/vcl/win/gdi/salfont.cxx
+++ b/vcl/win/gdi/salfont.cxx
@@ -932,6 +932,7 @@ void WinSalGraphics::SetFont( const FontSelectPattern* 
pFont, int nFallbackLevel
 // WinSalGraphics::GetEmbedFontData does not set mpFontInstance
 // since it is interested in font file data only.
 mpWinFontEntry[ nFallbackLevel ] = reinterpret_cast( 
pFont->mpFontInstance.get() );
+WinFontInstance *pFontInstance = 
static_cast(pFont->mpFontInstance.get());
 
 HFONT hOldFont = nullptr;
 HFONT hNewFont = pFontInstance ? pFontInstance->GetHFONT() : nullptr;
@@ -970,7 +971,6 @@ void WinSalGraphics::SetFont( const FontSelectPattern* 
pFont, int nFallbackLevel
 }
 if (mpWinFontEntry[i])
 {
-GetWinFontEntry(i)->Release();
 mpWinFontEntry[i] = nullptr;
 }
 mfFontScale[i] = 1.0;
@@ -1363,7 +1363,7 @@ void WinSalGraphics::ClearDevFontCache()
 
 bool WinSalGraphics::GetGlyphBoundRect(const GlyphItem& rGlyph, 
tools::Rectangle& rRect)
 {
-WinFontInstance* pFont = mpWinFontEntry[rGlyph.mnFallbackLevel];
+rtl::Reference pFont = 
mpWinFontEntry[rGlyph.mnFallbackLevel];
 HFONT hNewFont = pFont ? pFont->GetHFONT() : 
mhFonts[rGlyph.mnFallbackLevel];
 float fFontScale = pFont ? pFont->GetScale() : 
mfFontScale[rGlyph.mnFallbackLevel];
 
@@ -1572,7 +1572,7 @@ bool WinSalGraphics::GetGlyphOutline(const GlyphItem& 
rGlyph,
 // rescaling needed for the tools::PolyPolygon conversion
 if( rB2DPolyPoly.count() )
 {
-WinFontInstance *pFont = mpWinFontEntry[rGlyph.mnFallbackLevel];
+rtl::Reference pFont = 
mpWinFontEntry[rGlyph.mnFallbackLevel];
 float fFontScale = pFont ? pFont->GetScale() : 
mfFontScale[rGlyph.mnFallbackLevel];
 const double fFactor(fFontScale/256);
 
rB2DPolyPoly.transform(basegfx::utils::createScaleB2DHomMatrix(fFactor, 
fFactor));
commit b3f943ef3687daab3fe801bf5bb60dd39a07a4b5
Author: Samuel Mehrbrodt 
AuthorDate: Tue Mar 26 12:27:38 2019 +0100
Commit: Thorsten Behrens 
CommitDate: Mon Apr 8 01:28:05 2019 +0200

Add missing include

Fallout from 7f9dfae2f83f11cc7799110435

Re: Add AdjustX method to basegfx::B2DPoint

2019-04-05 Thread Thorsten Behrens
Hi Alex,

Alexander Farrow wrote:
> basegfx::B2DPoint
> 
> does not have such a method. So calls to AdjustX(nHorzMove) are
> being replaced by something like setX(getX() + nHorzMove).
>
tools::Point is not exactly a role model for a nicely designed class,
so I'd hesitate to take any literal bits out of that. ;)

Many places using AdjustX() also call AdjustY() just the next line, so
for that you could use basegfx::B2DPoint::operator+=(const B2DTuple&)

If you believe you *must* use a single-component modifier, please come
up with something that blends well with the b2dtuple/point
concept. Also ideally, you will maintain some amount of internal
consistency (e.g. compare how operator*, *= etc. all got added in
farious flavours, such that math with b2dtuples works like the
'canonical' way when done with skalars or various forms of vectors).

Cheers,

-- Thorsten


signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-6-1+backports' - sw/qa sw/source

2019-04-05 Thread Thorsten Behrens (via logerrit)
 sw/qa/extras/uiwriter/data/fdo114306.odt   |binary
 sw/qa/extras/uiwriter/data/fdo114306_2.odt |binary
 sw/qa/extras/uiwriter/uiwriter.cxx |   28 
 sw/source/core/layout/findfrm.cxx  |8 +++
 sw/source/core/layout/flowfrm.cxx  |9 +++
 sw/source/core/layout/tabfrm.cxx   |   67 +
 6 files changed, 91 insertions(+), 21 deletions(-)

New commits:
commit 956e80b5af61d2f5a0a294566ff2164b057fe474
Author: Thorsten Behrens 
AuthorDate: Fri Apr 5 16:18:36 2019 +0200
Commit: Thorsten Behrens 
CommitDate: Sat Apr 6 00:59:49 2019 +0200

Revert "tdf#114306: Revert commits fixing this issue ( 6.1 only )"

This reverts commit f15146021b722dda0cf10cb08de6e0a3c525168a.

Change-Id: Ibf5092630084a0137e5dc13b5b8ef0c654ff83c7
Reviewed-on: https://gerrit.libreoffice.org/70308
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 

diff --git a/sw/qa/extras/uiwriter/data/fdo114306.odt 
b/sw/qa/extras/uiwriter/data/fdo114306.odt
new file mode 100755
index ..5a7d2f9ca864
Binary files /dev/null and b/sw/qa/extras/uiwriter/data/fdo114306.odt differ
diff --git a/sw/qa/extras/uiwriter/data/fdo114306_2.odt 
b/sw/qa/extras/uiwriter/data/fdo114306_2.odt
new file mode 100755
index ..b4bebc58add5
Binary files /dev/null and b/sw/qa/extras/uiwriter/data/fdo114306_2.odt differ
diff --git a/sw/qa/extras/uiwriter/uiwriter.cxx 
b/sw/qa/extras/uiwriter/uiwriter.cxx
index b9c7231a3d96..ff1e4b1f4b94 100755
--- a/sw/qa/extras/uiwriter/uiwriter.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter.cxx
@@ -332,6 +332,8 @@ public:
 void testTdf112448();
 void testTdf113790();
 void testTdf108048();
+void testTdf114306();
+void testTdf114306_2();
 void testTdf113481();
 void testTdf115013();
 void testTdf114536();
@@ -526,6 +528,8 @@ public:
 CPPUNIT_TEST(testTdf112448);
 CPPUNIT_TEST(testTdf113790);
 CPPUNIT_TEST(testTdf108048);
+CPPUNIT_TEST(testTdf114306);
+CPPUNIT_TEST(testTdf114306_2);
 CPPUNIT_TEST(testTdf113481);
 CPPUNIT_TEST(testTdf115013);
 CPPUNIT_TEST(testTdf114536);
@@ -5482,6 +5486,30 @@ void SwUiWriterTest::testTdf72942()
 CPPUNIT_ASSERT_EQUAL(OUString("Liberation Sans"), 
getProperty(xRun4, "CharFontName"));
 }
 
+void SwUiWriterTest::testTdf114306()
+{
+load(DATA_DIRECTORY, "fdo114306.odt");
+xmlDocPtr pXmlDoc = parseLayoutDump();
+
+// There are 2 long paragraphs in cell A1.
+// A part of paragraph 2 should flow over to the second page but
+// *not* the whole paragraph. There should be 2 paragraphs on
+// page 1 and 1 paragraph on page 2.
+assertXPath(pXmlDoc, "/root/page[1]/body/tab[1]/row[1]/cell[1]/txt", 2);
+assertXPath(pXmlDoc, "/root/page[2]/body/tab[1]/row[1]/cell[1]/txt", 1);
+}
+
+void SwUiWriterTest::testTdf114306_2()
+{
+// tdf#114306 fix unexpected page break in row-spanned table
+// load regression document without writer crash
+load(DATA_DIRECTORY, "fdo114306_2.odt");
+
+// correct number of pages
+CPPUNIT_ASSERT_EQUAL(4, getPages());
+}
+
+
 // During insert of the document with list inside into the main document 
inside the list
 // we should merge both lists into one, when they have the same list properties
 void SwUiWriterTest::testTdf113877()
diff --git a/sw/source/core/layout/findfrm.cxx 
b/sw/source/core/layout/findfrm.cxx
index c327ebfcab2c..b720d9936a45 100644
--- a/sw/source/core/layout/findfrm.cxx
+++ b/sw/source/core/layout/findfrm.cxx
@@ -1340,8 +1340,14 @@ bool SwFrame::IsMoveable( const SwLayoutFrame* 
_pLayoutFrame ) const
   _pLayoutFrame->IsInDocBody() ||
   _pLayoutFrame->IsInFootnote() )
 {
+// If IsMovable() is called before a MoveFwd() the method
+// may return false if there is no NextCellLeaf. If
+// IsMovable() is called before a MoveBwd() the method may
+// return false if there is no PrevCellLeaf.
 if ( _pLayoutFrame->IsInTab() && !IsTabFrame() &&
- ( !IsContentFrame() || 
!const_cast(this)->GetNextCellLeaf() ) )
+ ( !IsContentFrame() || 
(!const_cast(this)->GetNextCellLeaf()
+  && 
!const_cast(this)->GetPrevCellLeaf()) )
+)
 {
 bRetVal = false;
 }
diff --git a/sw/source/core/layout/flowfrm.cxx 
b/sw/source/core/layout/flowfrm.cxx
index 34a3258e68b4..4366c98af710 100644
--- a/sw/source/core/layout/flowfrm.cxx
+++ b/sw/source/core/layout/flowfrm.cxx
@@ -2041,14 +2041,19 @@ bool SwFlowFrame::MoveBwd( bool  )
 const SwLayoutFrame* pUpperFrame = m_rThis.GetUpper();
 while ( pUpperFrame )
 {
-if ( pUpperFrame->IsTabFrame() )
+if ( pUpperFrame->IsTabFrame() || pUpp

[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-6-1+backports' - 14 commits - configure.ac download.lst external/python3 i18npool/source sc/source svl/source sw/qa sw/source toolkit/sou

2019-04-05 Thread Thorsten Behrens (via logerrit)
 configure.ac|2 
 dev/null|binary
 download.lst|4 
 external/python3/UnpackedTarball_python3.mk |1 
 external/python3/python-3.5.7-c99.patch.1   |   62 +++
 i18npool/source/calendar/calendar_gregorian.cxx |9 -
 i18npool/source/localedata/data/ja_JP.xml   |5 
 sc/source/ui/StatisticsDialogs/AnalysisOfVarianceDialog.cxx |3 
 svl/source/numbers/zformat.cxx  |3 
 sw/qa/extras/ooxmlexport/data/tdf121456.docx|binary
 sw/qa/extras/ooxmlexport/data/tdf123705.docx|binary
 sw/qa/extras/ooxmlexport/ooxmlexport11.cxx  |   10 +
 sw/qa/extras/ooxmlexport/ooxmlexport8.cxx   |4 
 sw/qa/extras/uiwriter/uiwriter.cxx  |   28 -
 sw/source/core/doc/notxtfrm.cxx |   29 -
 sw/source/core/layout/findfrm.cxx   |8 -
 sw/source/core/layout/flowfrm.cxx   |9 -
 sw/source/core/layout/tabfrm.cxx|   67 +++-
 sw/source/core/unocore/unostyle.cxx |3 
 sw/source/filter/ww8/docxattributeoutput.cxx|3 
 toolkit/source/controls/tabpagemodel.cxx|5 
 vcl/qa/cppunit/pdfexport/data/tdf121615.odt |binary
 vcl/qa/cppunit/pdfexport/pdfexport.cxx  |   58 ++
 vcl/source/app/salvtables.cxx   |7 +
 vcl/source/edit/textundo.cxx|   11 +
 vcl/source/filter/jpeg/JpegWriter.cxx   |5 
 vcl/source/gdi/bitmapex.cxx |2 
 writerfilter/source/dmapper/DomainMapper_Impl.cxx   |3 
 28 files changed, 230 insertions(+), 111 deletions(-)

New commits:
commit c4cb662635b22433e67a31eb75b75a7ac77ba7da
Merge: de89c8169cfb f15146021b72
Author: Thorsten Behrens 
AuthorDate: Fri Apr 5 16:17:02 2019 +0200
Commit: Thorsten Behrens 
CommitDate: Fri Apr 5 16:17:02 2019 +0200

Merge branch 'libreoffice-6-1'

into distro/lhm/libreoffice-6-1+backports

Change-Id: Id362bc8f781d752e6e14032fee8d9c7100e208ad

commit f15146021b722dda0cf10cb08de6e0a3c525168a
Author: Xisco Fauli 
AuthorDate: Tue Mar 26 00:48:12 2019 +0100
Commit: Michael Stahl 
CommitDate: Fri Apr 5 15:42:32 2019 +0200

tdf#114306: Revert commits fixing this issue ( 6.1 only )

Revert "tdf#114306 fix crash caused by special document 2"

This reverts commit d30eefb677b446886f7b5bab6de93d489ba63529.

Revert "tdf#114306 fix crash caused by special document"

This reverts commit e4400f4c4e267f8528df3a7d5a09623c888bd10c.

Revert "tdf#114306 fix unexpected page break in row-spanned table"

This reverts commit 18765b9fa739337d2d891513f6e2fb7c3ce23b50

Change-Id: Ifff799616f12ee428a3f923f6510b20059f5bc71
Reviewed-on: https://gerrit.libreoffice.org/69848
Tested-by: Jenkins
Reviewed-by: Michael Stahl 

diff --git a/sw/qa/extras/uiwriter/data/fdo114306.odt 
b/sw/qa/extras/uiwriter/data/fdo114306.odt
deleted file mode 100755
index 5a7d2f9ca864..
Binary files a/sw/qa/extras/uiwriter/data/fdo114306.odt and /dev/null differ
diff --git a/sw/qa/extras/uiwriter/data/fdo114306_2.odt 
b/sw/qa/extras/uiwriter/data/fdo114306_2.odt
deleted file mode 100755
index b4bebc58add5..
Binary files a/sw/qa/extras/uiwriter/data/fdo114306_2.odt and /dev/null differ
diff --git a/sw/qa/extras/uiwriter/uiwriter.cxx 
b/sw/qa/extras/uiwriter/uiwriter.cxx
index 6d1f2c51c684..8d0e194d7a65 100755
--- a/sw/qa/extras/uiwriter/uiwriter.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter.cxx
@@ -332,8 +332,6 @@ public:
 void testTdf112448();
 void testTdf113790();
 void testTdf108048();
-void testTdf114306();
-void testTdf114306_2();
 void testTdf113481();
 void testTdf115013();
 void testTdf114536();
@@ -528,8 +526,6 @@ public:
 CPPUNIT_TEST(testTdf112448);
 CPPUNIT_TEST(testTdf113790);
 CPPUNIT_TEST(testTdf108048);
-CPPUNIT_TEST(testTdf114306);
-CPPUNIT_TEST(testTdf114306_2);
 CPPUNIT_TEST(testTdf113481);
 CPPUNIT_TEST(testTdf115013);
 CPPUNIT_TEST(testTdf114536);
@@ -5482,30 +5478,6 @@ void SwUiWriterTest::testTdf72942()
 CPPUNIT_ASSERT_EQUAL(OUString("Liberation Sans"), 
getProperty(xRun4, "CharFontName"));
 }
 
-void SwUiWriterTest::testTdf114306()
-{
-load(DATA_DIRECTORY, "fdo114306.odt");
-xmlDocPtr pXmlDoc = parseLayoutDump();
-
-// There are 2 long paragraphs in cell A1.
-// A part of paragraph 2 should flow over to the second page but
-// *not* the whole paragraph. Th

[Libreoffice-commits] core.git: Branch 'distro/cib/libreoffice-6-1' - 16 commits - configure.ac desktop/source download.lst external/python3 i18npool/source icon-themes/colibre icon-themes/galaxy icon

2019-04-04 Thread Thorsten Behrens (via logerrit)
Rebased ref, commits from common ancestor:
commit d989d34834e09325b0eb305b00959e1589404c22
Author: Thorsten Behrens 
AuthorDate: Wed Jul 18 18:06:44 2018 +0200
Commit: Thorsten Behrens 
CommitDate: Fri Apr 5 00:12:36 2019 +0200

Default OpenGL to off on all platforms

Change-Id: Ide04d3b37b9fabb64d514fd87acbdfe9e49e6727

diff --git a/officecfg/registry/data/org/openoffice/Office/Common.xcu 
b/officecfg/registry/data/org/openoffice/Office/Common.xcu
index 26d1ba053a1e..1e001efd4a12 100644
--- a/officecfg/registry/data/org/openoffice/Office/Common.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/Common.xcu
@@ -59,9 +59,7 @@
   
   
 
-  false
-  false
-  true
+  false
 
   
   
commit 726bcf895a930fc8a8589677c8a8d6623b6217ad
Author: Samuel Mehrbrodt 
AuthorDate: Thu Jan 12 16:46:45 2017 +0100
Commit: Thorsten Behrens 
CommitDate: Fri Apr 5 00:12:36 2019 +0200

Disable crash reporter UI

Change-Id: I8106ec674080ede7072581dab2e6700040de5828
(cherry picked from commit b981aa30c3eb5ddd0cf6c35e4c37ab687667f71b)

diff --git a/desktop/source/app/app.cxx b/desktop/source/app/app.cxx
index c83d424f8a30..e7a4f82ba081 100644
--- a/desktop/source/app/app.cxx
+++ b/desktop/source/app/app.cxx
@@ -913,7 +913,8 @@ bool crashReportInfoExists()
 #if HAVE_FEATURE_BREAKPAD
 void handleCrashReport()
 {
-static const char SERVICENAME_CRASHREPORT[] = 
"com.sun.star.comp.svx.CrashReportUI";
+// Don't show the dialog since we don't offer upload - only want the dumps
+/*static const char SERVICENAME_CRASHREPORT[] = 
"com.sun.star.comp.svx.CrashReportUI";
 
 css::uno::Reference< css::uno::XComponentContext > xContext = 
::comphelper::getProcessComponentContext();
 
@@ -927,7 +928,7 @@ void handleCrashReport()
 css::util::URL aURL;
 css::uno::Any aRet = xRecoveryUI->dispatchWithReturnValue(aURL, 
css::uno::Sequence< css::beans::PropertyValue >());
 bool bRet = false;
-aRet >>= bRet;
+aRet >>= bRet;*/
 }
 #endif
 
commit 53346ed879a9aec0d4147e0bf0eb76452bbb748a
Author: Katarina Behrens 
AuthorDate: Wed Feb 10 14:42:18 2016 +0100
Commit: Thorsten Behrens 
CommitDate: Fri Apr 5 00:12:36 2019 +0200

Branded images for msi installer

The sizes are 122 x 234, 374 x 44 installed units respectively, according to

http://msdn.microsoft.com/de-de/library/windows/desktop/aa369490%28v=vs.85%29.aspx

it is 163x312, 499x58 pixels at 96 dpi. I bumped dpi to 120 and it still 
looks pixelated,
but it's as good as it gets.

For better results, we need different graphics, with less fine details 
given the very limited
space

Change-Id: I4a7eafed16fd79f377d27afa8151cfab614b464b

diff --git 
a/instsetoo_native/inc_common/windows/msi_templates/Binary/Banner.bmp 
b/instsetoo_native/inc_common/windows/msi_templates/Binary/Banner.bmp
index 5a163cf86c23..471eea4c22e6 100644
Binary files 
a/instsetoo_native/inc_common/windows/msi_templates/Binary/Banner.bmp and 
b/instsetoo_native/inc_common/windows/msi_templates/Binary/Banner.bmp differ
diff --git a/instsetoo_native/inc_common/windows/msi_templates/Binary/Image.bmp 
b/instsetoo_native/inc_common/windows/msi_templates/Binary/Image.bmp
index b4210d131ba2..2703670952bd 100644
Binary files 
a/instsetoo_native/inc_common/windows/msi_templates/Binary/Image.bmp and 
b/instsetoo_native/inc_common/windows/msi_templates/Binary/Image.bmp differ
commit f4cfc7cb72b00a1fc68ca6f98a8217ac592e3c8e
Author: Katarina Behrens 
AuthorDate: Tue Feb 9 11:09:30 2016 +0100
Commit: Thorsten Behrens 
CommitDate: Fri Apr 5 00:12:36 2019 +0200

Branded application icons

sadly, this doesn't replace Windows taskbar icon, that must be living 
somewhere
else. It works on Linux though.

 Conflicts:
icon-themes/galaxy/res/main128.png
icon-themes/galaxy/res/mainapp_16.png
icon-themes/galaxy/res/mainapp_16_8.png
icon-themes/galaxy/res/mainapp_32.png
icon-themes/galaxy/res/mainapp_32_8.png
icon-themes/galaxy/res/mainapp_48_8.png

Change-Id: I028fc68d96f02113622c5e1ec3ed830ac797be0b

diff --git a/icon-themes/galaxy/res/main128.png 
b/icon-themes/galaxy/res/main128.png
new file mode 100644
index ..818b7330c25b
Binary files /dev/null and b/icon-themes/galaxy/res/main128.png differ
diff --git a/icon-themes/galaxy/res/mainapp_48_8.png 
b/icon-themes/galaxy/res/mainapp_48_8.png
new file mode 100644
index ..562ea23e89c2
Binary files /dev/null and b/icon-themes/galaxy/res/mainapp_48_8.png differ
diff --git a/icon-themes/tango/res/mainapp_16.png 
b/icon-themes/tango/res/mainapp_16.png
index 4a96735b6bb6..13945eeadfd4 100644
Binary files a/icon-themes/tango/res/mainapp_16.png and 
b/icon-themes/tango/res/mainapp_16.png differ
diff --git a/icon-themes/tango/res/mainapp_16_8.png 
b/icon-themes/tango/res/mainapp_1

[Libreoffice-commits] core.git: Branch 'distro/cib/libreoffice-6-1' - 80 commits - configure.ac cui/source dbaccess/source desktop/source download.lst editeng/source external/apr external/cairo extern

2019-03-28 Thread Thorsten Behrens (via logerrit)
Rebased ref, commits from common ancestor:
commit 26edd27f129b0f5948825c5dd434f612e27619eb
Author: Thorsten Behrens 
AuthorDate: Wed Jul 18 18:06:44 2018 +0200
Commit: Thorsten Behrens 
CommitDate: Thu Mar 28 16:48:48 2019 +0100

Default OpenGL to off on all platforms

Change-Id: Ide04d3b37b9fabb64d514fd87acbdfe9e49e6727

diff --git a/officecfg/registry/data/org/openoffice/Office/Common.xcu 
b/officecfg/registry/data/org/openoffice/Office/Common.xcu
index 26d1ba053a1e..1e001efd4a12 100644
--- a/officecfg/registry/data/org/openoffice/Office/Common.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/Common.xcu
@@ -59,9 +59,7 @@
   
   
 
-  false
-  false
-  true
+  false
 
   
   
commit 9113c297808e3b00a0f97fee485b379b3fa1db95
Author: Samuel Mehrbrodt 
AuthorDate: Thu Jan 12 16:46:45 2017 +0100
Commit: Thorsten Behrens 
CommitDate: Thu Mar 28 16:48:48 2019 +0100

Disable crash reporter UI

Change-Id: I8106ec674080ede7072581dab2e6700040de5828
(cherry picked from commit b981aa30c3eb5ddd0cf6c35e4c37ab687667f71b)

diff --git a/desktop/source/app/app.cxx b/desktop/source/app/app.cxx
index c83d424f8a30..e7a4f82ba081 100644
--- a/desktop/source/app/app.cxx
+++ b/desktop/source/app/app.cxx
@@ -913,7 +913,8 @@ bool crashReportInfoExists()
 #if HAVE_FEATURE_BREAKPAD
 void handleCrashReport()
 {
-static const char SERVICENAME_CRASHREPORT[] = 
"com.sun.star.comp.svx.CrashReportUI";
+// Don't show the dialog since we don't offer upload - only want the dumps
+/*static const char SERVICENAME_CRASHREPORT[] = 
"com.sun.star.comp.svx.CrashReportUI";
 
 css::uno::Reference< css::uno::XComponentContext > xContext = 
::comphelper::getProcessComponentContext();
 
@@ -927,7 +928,7 @@ void handleCrashReport()
 css::util::URL aURL;
 css::uno::Any aRet = xRecoveryUI->dispatchWithReturnValue(aURL, 
css::uno::Sequence< css::beans::PropertyValue >());
 bool bRet = false;
-aRet >>= bRet;
+aRet >>= bRet;*/
 }
 #endif
 
commit 2e273fe7ca8d852e3d1999557ae02c43855c0ddd
Author: Katarina Behrens 
AuthorDate: Wed Feb 10 14:42:18 2016 +0100
Commit: Thorsten Behrens 
CommitDate: Thu Mar 28 16:48:48 2019 +0100

Branded images for msi installer

The sizes are 122 x 234, 374 x 44 installed units respectively, according to

http://msdn.microsoft.com/de-de/library/windows/desktop/aa369490%28v=vs.85%29.aspx

it is 163x312, 499x58 pixels at 96 dpi. I bumped dpi to 120 and it still 
looks pixelated,
but it's as good as it gets.

For better results, we need different graphics, with less fine details 
given the very limited
space

Change-Id: I4a7eafed16fd79f377d27afa8151cfab614b464b

diff --git 
a/instsetoo_native/inc_common/windows/msi_templates/Binary/Banner.bmp 
b/instsetoo_native/inc_common/windows/msi_templates/Binary/Banner.bmp
index 5a163cf86c23..471eea4c22e6 100644
Binary files 
a/instsetoo_native/inc_common/windows/msi_templates/Binary/Banner.bmp and 
b/instsetoo_native/inc_common/windows/msi_templates/Binary/Banner.bmp differ
diff --git a/instsetoo_native/inc_common/windows/msi_templates/Binary/Image.bmp 
b/instsetoo_native/inc_common/windows/msi_templates/Binary/Image.bmp
index b4210d131ba2..2703670952bd 100644
Binary files 
a/instsetoo_native/inc_common/windows/msi_templates/Binary/Image.bmp and 
b/instsetoo_native/inc_common/windows/msi_templates/Binary/Image.bmp differ
commit c2ea4faa7e77d66b8e9c00dd7b71dca97227dfea
Author: Katarina Behrens 
AuthorDate: Tue Feb 9 11:09:30 2016 +0100
Commit: Thorsten Behrens 
CommitDate: Thu Mar 28 16:48:48 2019 +0100

Branded application icons

sadly, this doesn't replace Windows taskbar icon, that must be living 
somewhere
else. It works on Linux though.

 Conflicts:
icon-themes/galaxy/res/main128.png
icon-themes/galaxy/res/mainapp_16.png
icon-themes/galaxy/res/mainapp_16_8.png
icon-themes/galaxy/res/mainapp_32.png
icon-themes/galaxy/res/mainapp_32_8.png
icon-themes/galaxy/res/mainapp_48_8.png

Change-Id: I028fc68d96f02113622c5e1ec3ed830ac797be0b

diff --git a/icon-themes/galaxy/res/main128.png 
b/icon-themes/galaxy/res/main128.png
new file mode 100644
index ..818b7330c25b
Binary files /dev/null and b/icon-themes/galaxy/res/main128.png differ
diff --git a/icon-themes/galaxy/res/mainapp_48_8.png 
b/icon-themes/galaxy/res/mainapp_48_8.png
new file mode 100644
index ..562ea23e89c2
Binary files /dev/null and b/icon-themes/galaxy/res/mainapp_48_8.png differ
diff --git a/icon-themes/tango/res/mainapp_16.png 
b/icon-themes/tango/res/mainapp_16.png
index 4a96735b6bb6..13945eeadfd4 100644
Binary files a/icon-themes/tango/res/mainapp_16.png and 
b/icon-themes/tango/res/mainapp_16.png differ
diff --git a/icon-themes/tango/res/mainapp_16_8.png 
b/icon-themes/tango/res/ma

[Libreoffice-commits] core.git: vcl/source

2019-03-27 Thread Thorsten Behrens (via logerrit)
 vcl/source/gdi/pdfwriter_impl.cxx |  390 --
 1 file changed, 390 deletions(-)

New commits:
commit b7bc2105d5093543058716c12e4d88dffb00b752
Author: Thorsten Behrens 
AuthorDate: Sun Mar 10 02:13:57 2019 +0100
Commit: Thorsten Behrens 
CommitDate: Wed Mar 27 16:40:47 2019 +0100

Remove stale testcode

Change-Id: I64a0b9cd4a727349016aa307d5c4835158a93109
Reviewed-on: https://gerrit.libreoffice.org/69822
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens 

diff --git a/vcl/source/gdi/pdfwriter_impl.cxx 
b/vcl/source/gdi/pdfwriter_impl.cxx
index e7a22e69ef56..f4c620bd13da 100644
--- a/vcl/source/gdi/pdfwriter_impl.cxx
+++ b/vcl/source/gdi/pdfwriter_impl.cxx
@@ -117,388 +117,6 @@ static bool g_bDebugDisableCompression = 
getenv("VCL_DEBUG_DISABLE_PDFCOMPRESSIO
 #define MAX_SIGNATURE_CONTENT_LENGTH 5
 #endif
 
-#ifdef DO_TEST_PDF
-class PDFTestOutputStream : public PDFOutputStream
-{
-public:
-virtual ~PDFTestOutputStream();
-virtual void write( const css::uno::Reference< css::io::XOutputStream >& 
xStream );
-};
-
-PDFTestOutputStream::~PDFTestOutputStream()
-{
-}
-
-void PDFTestOutputStream::write( const css::uno::Reference< 
css::io::XOutputStream >& xStream )
-{
-OString aStr( "lalala\ntest\ntest\ntest" );
-css::uno::Sequence< sal_Int8 > aData( aStr.getLength() );
-memcpy( aData.getArray(), aStr.getStr(), aStr.getLength() );
-xStream->writeBytes( aData );
-}
-
-// this test code cannot be used to test PDF/A-1 because it forces
-// control item (widgets) to bypass the structure controlling
-// the embedding of such elements in actual run
-void doTestCode()
-{
-static const char* pHome = getenv( "HOME"  );
-OUString aTestFile( "file://"  );
-aTestFile += OUString( pHome, strlen( pHome ), RTL_TEXTENCODING_MS_1252 );
-aTestFile += "/pdf_export_test.pdf";
-
-PDFWriter::PDFWriterContext aContext;
-aContext.URL= aTestFile;
-aContext.Version= PDFWriter::PDF_1_4;
-aContext.Tagged = true;
-aContext.InitialPage= 2;
-aContext.DocumentInfo.Title = "PDF export test document";
-aContext.DocumentInfo.Producer = "VCL";
-
-aContext.SignPDF= true;
-aContext.SignLocation   = "Burdur";
-aContext.SignReason = "Some valid reason to sign";
-aContext.SignContact= "sig...@example.com";
-
-css::uno::Reference< css::beans::XMaterialHolder > xEnc;
-PDFWriter aWriter( aContext, xEnc );
-aWriter.NewPage( 595, 842 );
-aWriter.BeginStructureElement( PDFWriter::Document );
-// set duration of 3 sec for first page
-aWriter.SetAutoAdvanceTime( 3 );
-aWriter.SetMapMode( MapMode( MapUnit::Map100thMM ) );
-
-aWriter.SetFillColor( COL_LIGHTRED );
-aWriter.SetLineColor( COL_LIGHTGREEN );
-aWriter.DrawRect( Rectangle( Point( 2000, 200 ), Size( 8000, 3000 ) ), 
5000, 2000 );
-
-aWriter.SetFont( Font( OUString( "Times" ), Size( 0, 500 ) ) );
-aWriter.SetTextColor( COL_BLACK );
-aWriter.SetLineColor( COL_BLACK );
-aWriter.SetFillColor( COL_LIGHTBLUE );
-
-Rectangle aRect( Point( 5000, 5000 ), Size( 6000, 3000 ) );
-aWriter.DrawRect( aRect );
-aWriter.DrawText( aRect, OUString( "Link annot 1" ) );
-sal_Int32 nFirstLink = aWriter.CreateLink( aRect );
-PDFNote aNote;
-aNote.Title = "A small test note";
-aNote.Contents = "There is no business like show business like no business 
i know. Everything about it is appealing.";
-aWriter.CreateNote( Rectangle( Point( aRect.Right(), aRect.Top() ), Size( 
6000, 3000 ) ), aNote );
-
-Rectangle aTargetRect( Point( 3000, 23000 ), Size( 12000, 6000 ) );
-aWriter.SetFillColor( COL_LIGHTGREEN );
-aWriter.DrawRect( aTargetRect );
-aWriter.DrawText( aTargetRect, "Dest second link" );
-sal_Int32 nSecondDest = aWriter.CreateDest( aTargetRect );
-
-aWriter.BeginStructureElement( PDFWriter::Section );
-aWriter.BeginStructureElement( PDFWriter::Heading );
-aWriter.DrawText( Point(4500, 9000), "A small structure test" );
-aWriter.EndStructureElement();
-aWriter.BeginStructureElement( PDFWriter::Paragraph );
-aWriter.SetStructureAttribute( PDFWriter::WritingMode, PDFWriter::LrTb );
-aWriter.SetStructureAttribute( PDFWriter::TextDecorationType, 
PDFWriter::Underline );
-aWriter.DrawText( Rectangle( Point( 4500, 1 ), Size( 12000, 6000 ) ),
- "It was the best of PDF, it was the worst of PDF ... or 
so. This is a pretty nonsensical text to denote a paragraph. I suggest you stop 
reading it. Because if you read on you might get bored. So continue on your on 
risk. Hey, you're still here ? Why do you continue to read this as it is of no 

[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-6-1+backports' - 9 commits - download.lst external/poppler i18npool/source sc/CppunitTest_sc_pdf_export.mk sc/Module_sc.mk sc/qa sc/sourc

2019-03-27 Thread Thorsten Behrens (via logerrit)
 download.lst|  
  4 
 external/poppler/0001-ImageStream-getLine-fix-crash-on-broken-files.patch.1 |  
 27 
 external/poppler/UnpackedTarball_poppler.mk |  
  1 
 external/poppler/poppler-config.patch.1 |  
 12 
 i18npool/source/localedata/data/kmr_Latn_TR.xml |  
 13 
 sc/CppunitTest_sc_pdf_export.mk |  
 97 +++
 sc/Module_sc.mk |  
  1 
 sc/qa/extras/scpdfexport.cxx|  
284 ++
 sc/source/ui/inc/printfun.hxx   |  
  5 
 sc/source/ui/unoobj/docuno.cxx  |  
  3 
 sc/source/ui/view/printfun.cxx  |  
 23 
 stoc/source/corereflection/criface.cxx  |  
  2 
 sw/source/core/text/itradj.cxx  |  
 11 
 sw/source/core/text/portxt.cxx  |  
  3 
 sw/source/core/txtnode/fntcache.cxx |  
  9 
 sw/source/ui/misc/outline.cxx   |  
 27 
 16 files changed, 485 insertions(+), 37 deletions(-)

New commits:
commit 3929f1d2150a4c02a12d849ec2dcc5af564ce247
Merge: bff470b5826b 078dbe815940
Author: Thorsten Behrens 
AuthorDate: Wed Mar 27 11:57:27 2019 +0100
Commit: Thorsten Behrens 
CommitDate: Wed Mar 27 11:57:27 2019 +0100

Merge branch 'libreoffice-6-1'

into distro/lhm/libreoffice-6-1+backports

Change-Id: Iad85f13e091b739e7df5cf273c14ba923b60f9cd

commit 078dbe815940018705a5c69ddb8ac9d1897689c1
Author: Eike Rathke 
AuthorDate: Mon Mar 25 22:33:03 2019 +0100
Commit: Adolfo Jayme Barrientos 
CommitDate: Tue Mar 26 17:13:08 2019 +0100

Assign [kmr-Latn-TR] TRY|₺ currency, TRY|YTL and TRL|TL are legacyOnly

This was done long ago for the tr-TR locale as well.

Change-Id: I5bf8595f6d49adb7fd76b3c4924c4d72b3b8ea5e
Reviewed-on: https://gerrit.libreoffice.org/69717
Reviewed-by: Eike Rathke 
Tested-by: Jenkins
(cherry picked from commit 4ca9db953d59d93ce8e3a54a36d23ed52b9c62a9)
Reviewed-on: https://gerrit.libreoffice.org/69723
Tested-by: Eike Rathke 
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/i18npool/source/localedata/data/kmr_Latn_TR.xml 
b/i18npool/source/localedata/data/kmr_Latn_TR.xml
index 2762df9e630f..a566c67170b9 100644
--- a/i18npool/source/localedata/data/kmr_Latn_TR.xml
+++ b/i18npool/source/localedata/data/kmr_Latn_TR.xml
@@ -52,7 +52,7 @@
 PN
 US
   
-  
+  
 M/D
 
   General
@@ -335,14 +335,21 @@
 
   
   
-
+
+  TRY
+  ₺
+  TRY
+  Türk Lirası
+  2
+
+
   TRY
   YTL
   TRY
   Yeni Türk Lirası
   2
 
-
+
   TRL
   TL
   TRL
commit be189bfc1709dce48111eed49d847c05ef82164e
Author: Khaled Hosny 
AuthorDate: Thu Mar 21 15:00:22 2019 +0200
Commit: Xisco Faulí 
CommitDate: Fri Mar 22 10:02:28 2019 +0100

tdf#124109: Revert "Only do kashida insertion with fonts that have non-zero 
width kashidas"

This reverts commit c45b23377bb2fe44c26f1287ff38495344e4ca50.

This commit breaks Kashida justification when a document is first opened 
(the
kashida justification will be disabled and spaces will be used untill the 
text
is changed). Probably it is checking for width of Kashida glyph too early. 
Also
I'm not sure what the reverted commit was trying to fix since we already do
kashida justification in fonts that has non-zero width Kashida and it has 
been
the case for a long time.

This does not fix the original issue in the document attched with the bug
report, but if fixes kashida not being applied when opening the document.

Change-Id: Ic95859bca94fa792793e3223d2adb465bc6d880f
Reviewed-on: https://gerrit.libreoffice.org/69509
Tested-by: Jenkins
Reviewed-by: Xisco Faulí 
(cherry picked from commit 0a8e9cc5c1782f1cd50ef338ec2aa4f6776a4c0e)
Reviewed-on: https://gerrit.libreoffice.org/69519
Reviewed-by: Khaled Hosny 

diff --git a/sw/source/core/text/itradj.cxx b/sw/source/core/text/itradj.cxx
index 8383292105bc..bacc39e348b1 100644
--- a/sw/source/core/text/itradj.cxx
+++ b/sw/source/core/text/itradj.cxx
@@ -113,9 +113,6 @@ void SwTextAdjuster::FormatBlock( )
 static bool lcl_CheckKashidaPositions( SwScriptInfo& rSI, SwTextSizeInfo& 
rInf, SwTextIter& rItr,
 sal_Int32& rKashidas, TextFrameIndex& nGluePortion)
 {
-if ( rInf.GetOut()->GetMinKashida() <= 0 )
-return false;
-
 // i60594 validate Kashida justification
 TextFrameIndex nIdx = 

Re: [GSOC] LibreOffice appliances idea

2019-03-27 Thread Thorsten Behrens
Hi Rasmus,

I presume you're talking about this:
https://wiki.documentfoundation.org/Development/GSoC/Ideas_without_a_mentor#LibreOffice_appliances
 ?

Rasmus Jonsson wrote:
> When you say "when connected/ disconnected to/ from LAN", are you
> envisioning a system where the Pi operator would plug in an Ethernet
> cable, visit the URL on the screen (accessible only on the local
> network), upload a file, and then pull out the cable? What about WiFi?
> Could there be a solution for both?
> 
Yep, exactly as you've described it - feel free to come up with good
ideas how to design interaction for e.g. Wifi or bluetooth - if you
got the hardware to implement that.

> Since you mention a Python's httplib, I'm assuming you're not
> envisioning this functionality as being part of the main LibreOffice
> program (HTTP server, file upload, detect network connection, cycle
> through presentations), but rather as a separate project which executes
> LibreOffice and controls it remotely. This is how I believe it should/
> would be done.
> 
Yep, no point in needlessly reimplementing the wheel. OTOH, there
_should_ be LibreOffice core work included in this task. ;)

> There is already a binary package available for Raspbian, and as far as
> I can tell there is already some functionality in LO/ Impress for
> remote control over TCP, although it is apparently only available in
> experimental mode so would require more work:
> 
> https://cgit.freedesktop.org/libreoffice/core/tree/sd/README_REMOTE
> https://cgit.freedesktop.org/libreoffice/core/tree/sd/source/ui/
> remotecontrol/Server.cxx
> 
Correct.

> Using this already-existing interface one could get all the requested
> features, it seems. Perhaps there are some other ways of controlling
> LibreOffice/ Impress externally that I don't know about.
> 
There's also bluetooth, but that's just a different transport for the
same protocol.

> As for uploading files, I think you're suggesting a simple website
> with file uploads for the "shop slide display", for the "conference
> display server" some slightly more complex playlist manager would
> be needed (add, remove, sort pdfs/odfs). All through a website
> interface?
> 
Yep, that would be easiest & most flexible - can't assume people would
have touch screens for that sort of setup (or they hang it from the
ceiling & its a pain to reach).

Consider me interested in mentoring that, I'm thorsten on IRC.

Cheers,

-- Thorsten


signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - sc/uiconfig sd/uiconfig sw/uiconfig

2019-03-26 Thread Thorsten Behrens (via logerrit)
 sc/uiconfig/scalc/ui/notebookbar.ui   |8 
 sc/uiconfig/scalc/ui/notebookbar_compact.ui   |   16 -
 sc/uiconfig/scalc/ui/notebookbar_groupedbar_compact.ui|8 
 sc/uiconfig/scalc/ui/notebookbar_groupedbar_full.ui   |   24 --
 sd/uiconfig/sdraw/ui/notebookbar.ui   |8 
 sd/uiconfig/sdraw/ui/notebookbar_groupedbar_compact.ui|8 
 sd/uiconfig/simpress/ui/notebookbar.ui|8 
 sd/uiconfig/simpress/ui/notebookbar_groupedbar_compact.ui |8 
 sd/uiconfig/simpress/ui/notebookbar_groupedbar_full.ui|   24 --
 sw/uiconfig/swriter/ui/notebookbar.ui |8 
 sw/uiconfig/swriter/ui/notebookbar_compact.ui |8 
 sw/uiconfig/swriter/ui/notebookbar_groupedbar_compact.ui  |8 
 sw/uiconfig/swriter/ui/notebookbar_groupedbar_full.ui |   16 -
 13 files changed, 152 deletions(-)

New commits:
commit 4b46adb58e843dacc0e5448fb1e598ed97c89e93
Author: Thorsten Behrens 
AuthorDate: Tue Mar 26 11:56:40 2019 +0100
Commit: Katarina Behrens 
CommitDate: Tue Mar 26 20:06:01 2019 +0100

tdf#122989 remove update check from notebookbar for the moment

Temp fix, since update check is an extension, and extensions can't
currently modify notebookbars.

This needs implementation of something like

https://wiki.openoffice.org/wiki/Framework/Article/Addon_Menu_Toolbar_Merging
for notebookbar popup menus. Such that Addons.xcs provide some merge
points with notebookbar menu IDs, we can then plug into existing popup
menus.

Change-Id: If30525fec1e7be0429e351588614618c5f56cdd4
Reviewed-on: https://gerrit.libreoffice.org/69735
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 
(cherry picked from commit 98174e163348ab44461f114142bc546e97720eec)
Reviewed-on: https://gerrit.libreoffice.org/69741
Reviewed-by: Katarina Behrens 
Tested-by: Katarina Behrens 

diff --git a/sc/uiconfig/scalc/ui/notebookbar.ui 
b/sc/uiconfig/scalc/ui/notebookbar.ui
index adeb29754cde..4d33af24f753 100644
--- a/sc/uiconfig/scalc/ui/notebookbar.ui
+++ b/sc/uiconfig/scalc/ui/notebookbar.ui
@@ -779,14 +779,6 @@
   
 
 
-  
-True
-False
-vnd.sun.star.job:alias=UpdateCheck
-_Check for Updates...
-  
-
-
   
 True
 False
diff --git a/sc/uiconfig/scalc/ui/notebookbar_compact.ui 
b/sc/uiconfig/scalc/ui/notebookbar_compact.ui
index ac6e9c0f97d9..1301829c7932 100644
--- a/sc/uiconfig/scalc/ui/notebookbar_compact.ui
+++ b/sc/uiconfig/scalc/ui/notebookbar_compact.ui
@@ -850,14 +850,6 @@
   
 
 
-  
-True
-False
-vnd.sun.star.job:alias=UpdateCheck
-_Check for Updates...
-  
-
-
   
 True
 False
@@ -1671,14 +1663,6 @@
   
 
 
-  
-True
-False
-vnd.sun.star.job:alias=UpdateCheck
-_Check for Updates...
-  
-
-
   
 True
 False
diff --git a/sc/uiconfig/scalc/ui/notebookbar_groupedbar_compact.ui 
b/sc/uiconfig/scalc/ui/notebookbar_groupedbar_compact.ui
index 836a1486898d..de5f1aff5f16 100644
--- a/sc/uiconfig/scalc/ui/notebookbar_groupedbar_compact.ui
+++ b/sc/uiconfig/scalc/ui/notebookbar_groupedbar_compact.ui
@@ -2493,14 +2493,6 @@
   
 
 
-  
-True
-False
-vnd.sun.star.job:alias=UpdateCheck
-_Check for 
Updates...
-  
-
-
   
 True
 False
diff --git a/sc/uiconfig/scalc/ui/notebookbar_groupedbar_full.ui 
b/sc/uiconfig/scalc/ui/notebookbar_groupedbar_full.ui
index 2711a049b315..6f8d64726a1c 100644
--- a/sc/uiconfig/scalc/ui/notebookbar_groupedbar_full.ui
+++ b/sc/uiconfig/scalc/ui/notebookbar_groupedbar_full.ui
@@ -1748,14 +1748,6 @@
   
 
 
-  
-True
-False
-vnd.sun.star.job:alias=UpdateCheck
-_Check for Updates...
-  
-
-
   
 True
 False
@@ -2455,14 +2447,6 @@
   
 
 
-  
-True
-False
-vnd.sun.star.job:alias=UpdateCheck
-_Check for Updates...
-  
-
-
   
 True
 False
@@ -2880,14 +2864,6 @@
   
 
 
-  
-True
-False
-vnd.sun.star.job:alias=UpdateCheck
-_Check for Updates...
-  
-
-
   
 True
 False
diff --git a/sd/uiconfig/sdraw/ui/notebookbar.ui 
b/sd/uiconfig/sdraw/ui/notebookbar.ui
index 95ac1e833e58..f3d9aff2aaf1 100644
--- a/sd/uiconfig/sdraw/ui/notebookbar.ui
+++ b/sd/uiconfig/sdraw/ui/notebookbar.ui
@@ -764,14 +764,6 @@
   
 
 
-  
-True
-False
-vnd.sun.star.job:alias=UpdateCheck
-_Check for Updates...
-  
-
-
   
 True
 False
diff --git a/sd/uiconfig

[Libreoffice-commits] core.git: sc/uiconfig sd/uiconfig sw/uiconfig

2019-03-26 Thread Thorsten Behrens (via logerrit)
 sc/uiconfig/scalc/ui/notebookbar.ui   |8 
 sc/uiconfig/scalc/ui/notebookbar_compact.ui   |   16 -
 sc/uiconfig/scalc/ui/notebookbar_groupedbar_compact.ui|8 
 sc/uiconfig/scalc/ui/notebookbar_groupedbar_full.ui   |   24 --
 sd/uiconfig/sdraw/ui/notebookbar.ui   |8 
 sd/uiconfig/sdraw/ui/notebookbar_groupedbar_compact.ui|8 
 sd/uiconfig/simpress/ui/notebookbar.ui|8 
 sd/uiconfig/simpress/ui/notebookbar_groupedbar_compact.ui |8 
 sd/uiconfig/simpress/ui/notebookbar_groupedbar_full.ui|   24 --
 sw/uiconfig/swriter/ui/notebookbar.ui |8 
 sw/uiconfig/swriter/ui/notebookbar_compact.ui |8 
 sw/uiconfig/swriter/ui/notebookbar_groupedbar_compact.ui  |8 
 sw/uiconfig/swriter/ui/notebookbar_groupedbar_full.ui |   16 -
 13 files changed, 152 deletions(-)

New commits:
commit 98174e163348ab44461f114142bc546e97720eec
Author: Thorsten Behrens 
AuthorDate: Tue Mar 26 11:56:40 2019 +0100
Commit: Thorsten Behrens 
CommitDate: Tue Mar 26 13:37:28 2019 +0100

tdf#122989 remove update check from notebookbar for the moment

Temp fix, since update check is an extension, and extensions can't
currently modify notebookbars.

This needs implementation of something like

https://wiki.openoffice.org/wiki/Framework/Article/Addon_Menu_Toolbar_Merging
for notebookbar popup menus. Such that Addons.xcs provide some merge
points with notebookbar menu IDs, we can then plug into existing popup
menus.

Change-Id: If30525fec1e7be0429e351588614618c5f56cdd4
Reviewed-on: https://gerrit.libreoffice.org/69735
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 

diff --git a/sc/uiconfig/scalc/ui/notebookbar.ui 
b/sc/uiconfig/scalc/ui/notebookbar.ui
index 678e0756c0c6..ee4435c6f4ba 100644
--- a/sc/uiconfig/scalc/ui/notebookbar.ui
+++ b/sc/uiconfig/scalc/ui/notebookbar.ui
@@ -779,14 +779,6 @@
   
 
 
-  
-True
-False
-vnd.sun.star.job:alias=UpdateCheck
-_Check for Updates...
-  
-
-
   
 True
 False
diff --git a/sc/uiconfig/scalc/ui/notebookbar_compact.ui 
b/sc/uiconfig/scalc/ui/notebookbar_compact.ui
index ac6e9c0f97d9..1301829c7932 100644
--- a/sc/uiconfig/scalc/ui/notebookbar_compact.ui
+++ b/sc/uiconfig/scalc/ui/notebookbar_compact.ui
@@ -850,14 +850,6 @@
   
 
 
-  
-True
-False
-vnd.sun.star.job:alias=UpdateCheck
-_Check for Updates...
-  
-
-
   
 True
 False
@@ -1671,14 +1663,6 @@
   
 
 
-  
-True
-False
-vnd.sun.star.job:alias=UpdateCheck
-_Check for Updates...
-  
-
-
   
 True
 False
diff --git a/sc/uiconfig/scalc/ui/notebookbar_groupedbar_compact.ui 
b/sc/uiconfig/scalc/ui/notebookbar_groupedbar_compact.ui
index 050b76b06fe0..b9b46f1bf409 100644
--- a/sc/uiconfig/scalc/ui/notebookbar_groupedbar_compact.ui
+++ b/sc/uiconfig/scalc/ui/notebookbar_groupedbar_compact.ui
@@ -2493,14 +2493,6 @@
   
 
 
-  
-True
-False
-vnd.sun.star.job:alias=UpdateCheck
-_Check for 
Updates...
-  
-
-
   
 True
 False
diff --git a/sc/uiconfig/scalc/ui/notebookbar_groupedbar_full.ui 
b/sc/uiconfig/scalc/ui/notebookbar_groupedbar_full.ui
index 2711a049b315..6f8d64726a1c 100644
--- a/sc/uiconfig/scalc/ui/notebookbar_groupedbar_full.ui
+++ b/sc/uiconfig/scalc/ui/notebookbar_groupedbar_full.ui
@@ -1748,14 +1748,6 @@
   
 
 
-  
-True
-False
-vnd.sun.star.job:alias=UpdateCheck
-_Check for Updates...
-  
-
-
   
 True
 False
@@ -2455,14 +2447,6 @@
   
 
 
-  
-True
-False
-vnd.sun.star.job:alias=UpdateCheck
-_Check for Updates...
-  
-
-
   
 True
 False
@@ -2880,14 +2864,6 @@
   
 
 
-  
-True
-False
-vnd.sun.star.job:alias=UpdateCheck
-_Check for Updates...
-  
-
-
   
 True
 False
diff --git a/sd/uiconfig/sdraw/ui/notebookbar.ui 
b/sd/uiconfig/sdraw/ui/notebookbar.ui
index 95ac1e833e58..f3d9aff2aaf1 100644
--- a/sd/uiconfig/sdraw/ui/notebookbar.ui
+++ b/sd/uiconfig/sdraw/ui/notebookbar.ui
@@ -764,14 +764,6 @@
   
 
 
-  
-True
-False
-vnd.sun.star.job:alias=UpdateCheck
-_Check for Updates...
-  
-
-
   
 True
 False
diff --git a/sd/uiconfig/sdraw/ui/notebookbar_groupedbar_compact.ui 
b/sd/uiconfig/sdraw/ui/notebookbar_groupedbar_compact.ui
index 58923f5f0b6a..f8f1da662c9e 100644
--- a/sd/uiconfig/sdraw/ui

Re: [Libreoffice-commits] core.git: vcl/source vcl/uiconfig

2019-03-26 Thread Thorsten Behrens
Hi Tomaž,

Libreoffice Gerrit user wrote:
>  vcl/uiconfig/theme_definitions/definition.xml |8 
>
Interesting work there! Very curious (also wrt. the gesture support
from more recent commits) about the general direction - would it be
possible to add a few lines to vcl/README for the new directories'
purpose?

Cheers,

-- Thorsten


signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: remove unused columns in list of LibreOffice ODF Extensions

2019-03-14 Thread Thorsten Behrens
Regina Henschel wrote:
> Any objections?
> 
None at all, thx for the cleanup!

Cheers,

-- Thorsten
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [BUILD FAILED] Failing when build Libreoffice source on Windows platform

2019-02-22 Thread Thorsten Behrens
Hi Duy Vu,

Duy Vu wrote:
> I was failed while executing "../../opt/bin/make". (*I attached build log
> and some related files*)
> 
> Can you please check this?
> 
Odd error - did you run make clean before doing your new build (or was
it in a completely new checkout anyway)?

The interesting piece from the build log is:

[build C  ] solenv/bin/concat-deps.c
[build DEP] LNK:Executable/makedepend.exe
[build LNK] Executable/makedepend.exe
cl : Command line warning D9025 : overriding '/Od' with '/O2'
/usr/bin/sh: 
C:/Projects/libreoffice/dev/core/workdir/LinkTarget/Executable/concat-deps.exe: 
No such file or directory
[build LNK] Executable/concat-deps.exe

Which looks like a race..

The concat-deps.exe.d you attached contains DOS lineends, which might
be a sideeffect of that race - since
https://gerrit.libreoffice.org/40452 those should be filtered out.

No good ideas here currently, perhaps problem is best solved
interactively on IRC. One more thing to try to get you unblocked is
running 'make soltools.clean; make soltools.build' manually, then run
'make' again. Does that get you further?

Cheers,

-- Thorsten

signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [BUILD FAILED] Failing when build Libreoffice source on Windows platform

2019-02-17 Thread Thorsten Behrens
Hi Duy Vu,

Duy Vu via LibreOffice wrote:
> I am following this guide:
> https://wiki.documentfoundation.org/Development/BuildingOnWindows
> 
Bit unclear from the link - are you using lode, or the manual setup?

If the latter, then please consider using lode
(https://wiki.documentfoundation.org/Development/lode), as this
results in a much better defined setup.

> Libassuan v has been configured as follows:
> 
> Revision:   ()
> Platform: i686-pc-mingw32
> 
Only thing that comes to mind - buiding a 64bit Windows version from a
32bit cygwin is no longer supported.

Cheers,

-- Thorsten


signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-qa] Minutes of the ESC call 2019-02-07

2019-02-07 Thread Thorsten Behrens
* Present:
+ Caolán, Eike, Kendy, Miklos, Cloph, Xisco, Sberg, Olivier,
  Michael W, Heiko, Thorsten, Michael S

* Completed Action Items:
+ mail BoD wrt. MS store update (Cloph) → now with the board

* Pending Action Items:
+ disable popups for release-build only in 6.2/.3 (Justin L)
  [ sent some code pointers ]
+ send code pointers to Olivier on UNO commands ↔ UI XML mapping (Kendy)
+ work with Mert to build an android l10n plan (Cloph)
  [ didn’t connect with him yet ]
+ add screenshot builder to basic build stats (Cloph)
  [ it fails with Japanese locale – but it’s not in the translation
can build with all of these – and build runs fine, but with just
ja it fails – needs further research  ]

* Release Engineering update (Christian)
+ 6.1.5 & 6.2.0
  announced earlier today! 
+ 6.2.1 rc1: this week
rc2: Feb 19
+ 6.1.6 rc1: April 9
+ 6.3 release schedule updated in the wiki
+ Remotes – no updates thus far
+ Android viewer
  + new builds planned for the stores this week.
+ Online

* Documentation (Olivier)
 + FOSDEM
 + Some Help pages on python usage with LO (LibreOfficiant)
 + Typos in Help pages (fitoshido)


* UX Update (Heiko)
+ Bugzilla (topicUI) statistics
251(251) (topicUI) bugs open, 265(265) (needsUXEval)
+ Updates:
BZ changes   1 week1 month   3 months   12 months
 added  5(-3) 11(-1)43(-6)  94(-3)
 commented 51(-20)   181(23)   421(-16)   1439(-12)
   removed  0(-1)  2(0) 11(0)   15(0)
  resolved  8(0)  28(5) 41(3)  122(3)
+ top 10 contributors:
  Tietze, Heiko made 86 changes in 1 month, and 564 changes in 1 year
  kompilainenn made 43 changes in 1 month, and 102 changes in 1 year
  Xisco Faulí made 35 changes in 1 month, and 283 changes in 1 year
  Kainz, Andreas made 29 changes in 1 month, and 170 changes in 1 year
  Foote, V Stuart made 28 changes in 1 month, and 219 changes in 1 year
  Cor Nouws made 20 changes in 1 month, and 75 changes in 1 year
  BogdanB made 18 changes in 1 month, and 33 changes in 1 year
  Aditya Sahu made 16 changes in 1 month, and 16 changes in 1 year
  Adolfo Jayme Barrientos made 15 changes in 1 month, and 29 changes in 
1 year
  Buovjaga made 15 changes in 1 month, and 122 changes in 1 year
New needsUXEval between Jan/24-Feb/06

   * Move above checkboxes in Autofilter window
 + https://bugs.documentfoundation.org/show_bug.cgi?id=122998
   * Corrupt PDF output when exporting from LibreOffice Math
 + https://bugs.documentfoundation.org/show_bug.cgi?id=123117
   * Image WrapOff default setting
 + https://bugs.documentfoundation.org/show_bug.cgi?id=123169
   * notebookbar additional settings for label arrangement
 + https://bugs.documentfoundation.org/show_bug.cgi?id=123171
   => NEW/in discussion

   * Shortcuts for shapes in Draw/Impress
 + https://bugs.documentfoundation.org/show_bug.cgi?id=122928
   * Confusing behavior with Direct Formatting with copy/paste
 + https://bugs.documentfoundation.org/show_bug.cgi?id=90568
   => NAB/WF

   * UI - Insert mode status activation and display
 + https://bugs.documentfoundation.org/show_bug.cgi?id=107918
 + https://design.blog.documentfoundation.org/2019/01/31/overwrite-on- 
macos/
 + show Insert on macOS at the statusbar
   * Image -> Add Caption -> No description => Can't change caption
 instantly afterwards
 + https://bugs.documentfoundation.org/show_bug.cgi?id=122950
   * EDITING: No INSERT ROWS ... (dialog box that allows adding a set number
 of rows)
 + https://bugs.documentfoundation.org/show_bug.cgi?id=80390
   => easyhack, needsdeveval

* Crash Testing (Caolan)
+ 1 (-2) import failures, 4(-18) export failures
  + all look like new redline related issues
+ ?? was 8(+0) coverity issues
  + coverity was not working with C++17
  + https://community.synopsys.com/s/article/Coverity-Scan-Update actually
now coverity is completely down for everybody with no ETA for
restoration, so lets wait until it comes back up to see what version it
will use if it comes back
  + read-only access restored, not possible to submit new builds yet
+ 4 (-8) Google / ossfuzz: 4 timeouts.
+ 0 serious
+ looking good.
+ ?? ForcePoint, round 9
+ two asserts/crashes on using crashtester over round 9
+ CVE issues in progress for Jan 2019
+ CVE-2018-16858 is announced as fixed in 6.0.7 and 6.1.3
+ CNA process fun
+ responded to mitre, awaiting reply

* Crash Reporting (Xisco)
+ http://crashreport.libreoffice.org/stats/version/6.1.3.2
 + 1399 (last 7 days) (-342)
+ http://crashreport.libreoffice.org/stats/version/6.1.4.2
 + 2054 (last 7 days) (+144)
+ 

Minutes of the ESC call 2019-02-07

2019-02-07 Thread Thorsten Behrens
* Present:
+ Caolán, Eike, Kendy, Miklos, Cloph, Xisco, Sberg, Olivier,
  Michael W, Heiko, Thorsten, Michael S

* Completed Action Items:
+ mail BoD wrt. MS store update (Cloph) → now with the board

* Pending Action Items:
+ disable popups for release-build only in 6.2/.3 (Justin L)
  [ sent some code pointers ]
+ send code pointers to Olivier on UNO commands ↔ UI XML mapping (Kendy)
+ work with Mert to build an android l10n plan (Cloph)
  [ didn’t connect with him yet ]
+ add screenshot builder to basic build stats (Cloph)
  [ it fails with Japanese locale – but it’s not in the translation
can build with all of these – and build runs fine, but with just
ja it fails – needs further research  ]

* Release Engineering update (Christian)
+ 6.1.5 & 6.2.0
  announced earlier today! 
+ 6.2.1 rc1: this week
rc2: Feb 19
+ 6.1.6 rc1: April 9
+ 6.3 release schedule updated in the wiki
+ Remotes – no updates thus far
+ Android viewer
  + new builds planned for the stores this week.
+ Online

* Documentation (Olivier)
 + FOSDEM
 + Some Help pages on python usage with LO (LibreOfficiant)
 + Typos in Help pages (fitoshido)


* UX Update (Heiko)
+ Bugzilla (topicUI) statistics
251(251) (topicUI) bugs open, 265(265) (needsUXEval)
+ Updates:
BZ changes   1 week1 month   3 months   12 months
 added  5(-3) 11(-1)43(-6)  94(-3)
 commented 51(-20)   181(23)   421(-16)   1439(-12)
   removed  0(-1)  2(0) 11(0)   15(0)
  resolved  8(0)  28(5) 41(3)  122(3)
+ top 10 contributors:
  Tietze, Heiko made 86 changes in 1 month, and 564 changes in 1 year
  kompilainenn made 43 changes in 1 month, and 102 changes in 1 year
  Xisco Faulí made 35 changes in 1 month, and 283 changes in 1 year
  Kainz, Andreas made 29 changes in 1 month, and 170 changes in 1 year
  Foote, V Stuart made 28 changes in 1 month, and 219 changes in 1 year
  Cor Nouws made 20 changes in 1 month, and 75 changes in 1 year
  BogdanB made 18 changes in 1 month, and 33 changes in 1 year
  Aditya Sahu made 16 changes in 1 month, and 16 changes in 1 year
  Adolfo Jayme Barrientos made 15 changes in 1 month, and 29 changes in 
1 year
  Buovjaga made 15 changes in 1 month, and 122 changes in 1 year
New needsUXEval between Jan/24-Feb/06

   * Move above checkboxes in Autofilter window
 + https://bugs.documentfoundation.org/show_bug.cgi?id=122998
   * Corrupt PDF output when exporting from LibreOffice Math
 + https://bugs.documentfoundation.org/show_bug.cgi?id=123117
   * Image WrapOff default setting
 + https://bugs.documentfoundation.org/show_bug.cgi?id=123169
   * notebookbar additional settings for label arrangement
 + https://bugs.documentfoundation.org/show_bug.cgi?id=123171
   => NEW/in discussion

   * Shortcuts for shapes in Draw/Impress
 + https://bugs.documentfoundation.org/show_bug.cgi?id=122928
   * Confusing behavior with Direct Formatting with copy/paste
 + https://bugs.documentfoundation.org/show_bug.cgi?id=90568
   => NAB/WF

   * UI - Insert mode status activation and display
 + https://bugs.documentfoundation.org/show_bug.cgi?id=107918
 + https://design.blog.documentfoundation.org/2019/01/31/overwrite-on- 
macos/
 + show Insert on macOS at the statusbar
   * Image -> Add Caption -> No description => Can't change caption
 instantly afterwards
 + https://bugs.documentfoundation.org/show_bug.cgi?id=122950
   * EDITING: No INSERT ROWS ... (dialog box that allows adding a set number
 of rows)
 + https://bugs.documentfoundation.org/show_bug.cgi?id=80390
   => easyhack, needsdeveval

* Crash Testing (Caolan)
+ 1 (-2) import failures, 4(-18) export failures
  + all look like new redline related issues
+ ?? was 8(+0) coverity issues
  + coverity was not working with C++17
  + https://community.synopsys.com/s/article/Coverity-Scan-Update actually
now coverity is completely down for everybody with no ETA for
restoration, so lets wait until it comes back up to see what version it
will use if it comes back
  + read-only access restored, not possible to submit new builds yet
+ 4 (-8) Google / ossfuzz: 4 timeouts.
+ 0 serious
+ looking good.
+ ?? ForcePoint, round 9
+ two asserts/crashes on using crashtester over round 9
+ CVE issues in progress for Jan 2019
+ CVE-2018-16858 is announced as fixed in 6.0.7 and 6.1.3
+ CNA process fun
+ responded to mitre, awaiting reply

* Crash Reporting (Xisco)
+ http://crashreport.libreoffice.org/stats/version/6.1.3.2
 + 1399 (last 7 days) (-342)
+ http://crashreport.libreoffice.org/stats/version/6.1.4.2
 + 2054 (last 7 days) (+144)
+ 

Getting rid of CentOS6 for x86? (was: Compiler baselines)

2019-02-04 Thread Thorsten Behrens
Hi *,

as briefly talked about in a FOSDEM lightning talk, we managed to get
-m32 cross builds on master going for CentOS with devtoolset-7.

There's an existing setup for CentOS6 (Dockerfile attached) with a
number of ugly hacks; I'm working on a CentOS7 setup that looks much
cleaner, but suffers from one killer bug: a missing
devtoolset-7-libstdc++-devel.i686 package.

This is reported for upstream CentOS already here:
https://bugs.centos.org/view.php?id=15452

Does anybody have good suggestions how to get that fixed (whom to
lobby, whether to roll a custom package via COPR like mlampe did for
CentOS6, or anything else)?

Cheers,

-- Thorsten
# Dockerfile - this is for LibreOffice >=6.2 32bit
FROM centos:centos6

# basic setup & packages
RUN rpm -ivh 
https://dl.fedoraproject.org/pub/epel/epel-release-latest-6.noarch.rpm
# update first, to prevent SSL issues below - touch is due to 
https://bugzilla.redhat.com/show_bug.cgi?id=1213602
RUN touch /var/lib/rpm/* && yum -y update
# pull in more build prerequisite repos
# devtoolset-7: need both repos for 64-bit compiler and 32-bit library/headers
RUN cd /etc/yum.repos.d && \
curl -sLO 
http://download.opensuse.org/repositories/home:/fstrba:/LibreOffice/CentOS_6/home:fstrba:LibreOffice.repo
 && \
curl -sLO 
https://copr.fedorainfracloud.org/coprs/mlampe/devtoolset-7/repo/epel-6/mlampe-devtoolset-7-epel-6.repo
 && \
sed -e 's/\[mlampe-devtoolset-7\]/\[mlampe-devtoolset-7-32bit\]/' -e 
's/$basearch/i386/' < mlampe-devtoolset-7-epel-6.repo > 
mlampe-devtoolset-7-epel-6-32bit.repo
# get build prereqs - touch is due to 
https://bugzilla.redhat.com/show_bug.cgi?id=1213602
RUN touch /var/lib/rpm/* && yum -y install fakeroot automake bison ccache dpkg 
dpkg-devel doxygen git devtoolset-7-gcc-c++ devtoolset-7-make gettext 
perl-Archive-Zip rpm-build zip screen tar nasm glibc-devel 
devtoolset-7-libstdc++-devel autoconf268 \
gnome-vfs2-devel.i686 cups-devel.i686 libffi-devel.i686 gstreamer-devel.i686 
gstreamer-plugins-base-devel.i686 gtk2-devel.i686 kdelibs-devel.i686 
avahi-devel.i686 devtoolset-7-libstdc++-devel.i686 glibc-devel.i686 
zlib-devel.i686 fontconfig-devel.i686 freetype-devel.i686 krb5-devel.i686 
libcom_err-devel.i686 openssl-devel.i686 libICE-devel.i686 libSM-devel.i686 
libXrender-devel.i686 libXau-devel.i686 dbus-glib-devel.i686 dbus-devel.i686 
glib2-devel.i686 pango-devel.i686 cairo-devel.i686 pixman-devel.i686 
libpng-devel.i686 gdk-pixbuf2-devel.i686 atk-devel.i686 libxml2-devel.i686 
mesa-libGL-devel.i686 qt-devel.i686 libX11-devel.i686 libxcb-devel.i686

# 32-bit JDK is only in 32-bit CentOS because it's not parallel-installable 
with 64-bit JDK
RUN sed -e 's/\[\(.*\)\]/\[\1-32\]/' -e 's/$basearch/i386/' < 
/etc/yum.repos.d/CentOS-Base.repo > /etc/yum.repos.d/CentOS-Base-32.repo && yum 
-y install java-1.7.0-openjdk-devel.i686 java-1.7.0-openjdk.i686

# std UID for builder user (for easier sharing on the host side)
RUN useradd -m -o -u 9001 -s /bin/bash builder

# self-built stuff, needed for versions >= LibO-5.3
RUN curl -sLO 
https://ftp.gnome.org/pub/gnome/sources/glib/2.50/glib-2.50.3.tar.xz && \
cd /home/builder && \
linux32 su - -c "tar -xf /glib-2.50.3.tar.xz ; cd glib-2.50.3 ; 
PKG_CONFIG_LIBDIR=/usr/lib/pkgconfig:/usr/share/pkgconfig 
CC=\"/opt/rh/devtoolset-7/root/usr/bin/gcc -m32\" ./configure 
--disable-libmount --with-pcre=internal --prefix=/home/builder/gst10-deps ; 
make -j3; make install" builder && \
rm -rf glib-2.50.3 /glib-2.50.3.tar.xz

# get a newer gperf (for LibreOffice 6.2 on)
RUN curl -sLO https://ftp.gnu.org/pub/gnu/gperf/gperf-3.1.tar.gz && \
cd /home/builder && \
su - -c "tar -xf /gperf-3.1.tar.gz ; cd gperf-3.1 ; ./configure --prefix 
/home/builder/deps CC=/opt/rh/devtoolset-7/root/usr/bin/gcc 
CXX=/opt/rh/devtoolset-7/root/usr/bin/g++ ; make -j3; make install" builder && \
rm -rf gperf-3.1 /gperf-3.1.tar.gz

# get a newer flex (for LibreOffice 6.2 on)
RUN curl -sLO 
https://github.com/westes/flex/releases/download/v2.6.4/flex-2.6.4.tar.gz && \
cd /home/builder && \
su - -c "tar -xf /flex-2.6.4.tar.gz ; cd flex-2.6.4 ; ./configure --prefix 
/home/builder/deps CC=/opt/rh/devtoolset-7/root/usr/bin/gcc 
CC_FOR_BUILD=/opt/rh/devtoolset-7/root/usr/bin/gcc ; make -j3; make install" 
builder && \
rm -rf flex-2.6.4 /flex-flex-2.6.4.tar.gz

# self-built stuff, needed for versions >= LibO-5.3
RUN curl -sLO 
https://gstreamer.freedesktop.org/src/gstreamer/gstreamer-1.8.3.tar.xz && \
cd /home/builder && \
linux32 su - -c "tar -xf /gstreamer-1.8.3.tar.xz ; cd gstreamer-1.8.3 ; 
PATH="/home/builder/deps/bin:${PATH}" 
CC=\"/opt/rh/devtoolset-7/root/usr/bin/gcc -m32\" 
PKG_CONFIG_PATH=/home/builder/gst10-deps/lib/pkgconfig ./configure  
--prefix=/home/builder/gst10-deps ; make -j3; make install" builder && \
rm -rf gstreamer-1.8.3 /gstreamer-1.8.3.tar.xz
RUN curl -sLO 
https://gstreamer.freedesktop.org/src/gst-plugins-base/gst-plugins-base-1.8.3.tar.xz
 && \
cd 

Re: [Bug 115747] Can't edit file on samba shares

2019-01-27 Thread Thorsten Behrens
Hi Mike,

Kaganski Mike wrote:
> My opinion is that only existing locks may be a reason to open files
> read-only. If you can't write lockfiles, it's not a reason to limit
> one's ability to edit files. That can lead to the problems that
> lockfiles were meant to workaround, but if a specific shared (!)
> filesystem has some special properties that it (1) has no good FS
> locking; and (2) blocks writing lockfiles, then no measures will
> mitigate the problem:
>
True, but that's a very special corner case, no?

Another corner case, that IIRC was part of the problem which led to
the bugfix under discussion, was a disk / quota full situation.

And a third case was the WebDAV problem, where a server might refuse
LOCK, or only permit it for authorized users.

In general, it's pretty hard for LibreOffice to guess the correct
thing to do, with this plurality of failing to write, or fully write,
a lockfile. So the right thing to do then, IMO, is for it to back off,
and take the only safe path: open the document read-only.

> But it happens that a user has to work in a directory where they are not
> allowed to create new files at all (directory-level permissions), but
> are allowed to edit a specific file (file-level permissions).
>
> Not all shared filesystems have unreliable FS locking; I had no problems
> with FS-level locking when administered a Windows domain.
>
Then the sensible thing to do is disable lockfiles in those
environments - if both conditions hold true? But that's something only
a local administrator can decide correctly.

> You cannot require that "either all file systems you use support
> lockfiles, or you disable their usage".
>
Well but what else can one do to ensure correct behaviour? If there's
a way to tell a specific filesystem apart from the path name, or OS
query functions, then of course another set of lock disable config can
be added. Problem is, IIRC that was not possible in all cases for
mapped / mounted network drives.

> My vision of this would me that if inability to create lockfiles
> needs to be handled specially at all, then at maximum a warning
> infobar telling that "no lockfile was created, so clashes are
> possible" could be shown, but not limiting user's ability to work
> (because technically nothing prevents users).
>
That appears backwards to me. My take is, software should always go
the safe path by default, and offer the dangerous one only after
explicit consent. So with the infobar idea, that would mean open
read-only, but perhaps provide the option to switch to edit mode while
keeping the filename?

> Anyway, we cannot treat our lockfiles as an ultimate guard, simply
> because LibreOffice only works with files also openable using many
> other applications (ODF is an ISO standard, you remember, and if we
> can open other formats, others can, too). And those other
> applications ignore our lockfiles.
>
Well, we always try to also use FS-native locks, so most of the above
cases are covered. But you're right, for those occasions the lockfiles
were invented for (unreliable/incomplete FS locking), that will break
down if e.g. MS Office has the file open, too. For that, the measure
of last resort is looking at the modification date just before saving
(which only helps for one half of that problem, obviously).

But the argument "lock files are not safe 100% of the time, so we
shouldn't insist on writing them" is a non sequitur - unless you then
conclude we should abandon them entirely.

I still maintain the current behaviour is the least worst, avoiding
silent errors in locking shared files (interestingly, the problematic
examples given were all _on network shares_, i.e. exactly the place
where previously locking was subtly faulty). If there's a way to give
local setups more fine-grained control over the LibreOffice locking
subsystem, or if perhaps the user experience can be improved (start of
brainstorming above), I'm eager to hear it!

Cheers,

-- Thorsten

signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: Bringing command 'arcangleto' (G) to ODF

2019-01-25 Thread Thorsten Behrens
Hi Regina,

Regina Henschel wrote:
> You know, that I'm hesitant to bring something new to ODF. But in this case
> the new command seems to be useful.
>
I agree.

> PowerPoint restricts the swing angle to [-360°;360°], but I do not find any
> such restriction in the OOXML spec. What to do for ODF about this? Currently
> it is not restricted in my proposal draft.
> 
I'd rather take the spec than the implementation as guidance here. But
perhaps something to bring up in the TC, Microsoft is represented there.

Cheers,

-- Thorsten


signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: enhanced-path command M with multiple pairs of coordinates

2019-01-25 Thread Thorsten Behrens
Hi Regina,

Regina Henschel wrote:
> My patch transforms a path like "M 0 0 5 10 10 0 N" on import in a command
> sequence, where an additional command L (=lineTo) is introduced. So when
> saving you get "M 0 0 L 5 10 10 0 N".
> 
Yes I think that's the best way to deal with this, as it writes svg path
statements on export that older versions import correctly.

Cheers,

-- Thorsten


signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice-qa] minutes of ESC call ...

2019-01-17 Thread Thorsten Behrens
Michael Meeks wrote:
> * GSOC 2019 (Xisco)
> AI: Submit proposal (Thorsten/Heiko/Xisco)
> 
Done.

Cheers,

-- Thorsten


signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice-qa] minutes of ESC call ...

2019-01-17 Thread Thorsten Behrens
Michael Meeks wrote:
> * GSOC 2019 (Xisco)
> AI: Submit proposal (Thorsten/Heiko/Xisco)
> 
Done.

Cheers,

-- Thorsten


signature.asc
Description: PGP signature
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Bug 115747] Can't edit file on samba shares

2019-01-12 Thread Thorsten Behrens
Hi Justin, Xisco,

moving this discussion to the dev list (wider audience, and we can
bikeshed as much as we like about technicalities w/o bothering end
users).

Context:
> https://bugs.documentfoundation.org/show_bug.cgi?id=115747
> 

I'd consider the below worth fixing:
> --- Comment #36 from Justin L  ---
> (In reply to Thorsten Behrens (CIB) from comment #35)
> > the question is, does setting UseDocumentOOoLockFile
> > to false constitute a valid workaround?
> 
> From a testing perspective, the result is that files can be saved
> (no warnings, just a save as normal). Opening files result in a
> warning and read-only mode.
>
My expectation would be that UseDocumentOOoLockFile=false does not
create those lockfiles, and therefore opens a file read-write. That's
a bug in my view.

Moderate re-order for clarity:
> Now we have at least 3 variables related to locking - how can
> anyone know what the implications of any of this are, especially when no
> definitions have been given?
> ...
> UseDocumentSystemFileLocking: Allows to specify whether the OOo document file
> locking mechanics should use the system file locking (default true).
> 
> UseDocumentOOoLockFile: Allows to specify whether the OOo document file 
> locking
> mechanics should use the lock file for locking (default true).
> 
> UseLocking: Allows to specify whether locking should be used at all. Use this
> setting only for debugging purpose (default true).
> 
> UseWebDAVFileLocking: Determines if WebDAV-specific file locking is used for
> documents on WebDAV shares. It is not recommended to set this option to 
> 'false'
> in scenarios where multi-user, concurrent read/write access to WebDAV share is
> required (default true).
> 
Yeah, filing locking is a known mess. Essentially _any_ change there
will unearth odd quirks & corner cases. See below for an attempt to
better define semantics.

> Based on comment 19, this is not a "rare" case, so it would be
> really hard to determine if preventing ANY use of a dotlock file is
> valid in every case.)
>
I somehow failed to find more examples on Ask, Xisco: do you recall
other cases?

> Because 
> A) this is a regression, 
> B) which already had an alternate solution (SystemLocking = false),
> C) and the description uses the terminology "Allow" instead of
> "Mandatory",
> D) involving an unnecessary file for normal operation,
> E) caused by undocumented rationale for the changed behaviour,
> 
> I suggest reverting this bit and introducing a MandatoryLocking variable to
> handle the very unique situations where locking files actually have any value.
> 
As always, one person's regression is another person's bugfix. Those
OOo lockfiles have a rather long-winded history, and were introduced
because especially on network shares, cross-platform system file
locking never quite worked.

Since the change is shipped in versions for almost a year, instead of
a revert I'd much prefer we take the occasion and better define
requirements and semantics for file locking. From my memory:

- until 2008, there was just system file locking, which led to
  problems in preventing overwrites on documents accessed from different
  platforms. https://bz.apache.org/ooo/show_bug.cgi?id=85794 has quite
  some details, and a specification document
- that change of course led to bugs, starting with:
  * https://bz.apache.org/ooo/show_bug.cgi?id=95809
(bring back system file locking)
  * https://bz.apache.org/ooo/show_bug.cgi?id=100123
(actually lockfiles _also_ break workflows, so add an option)
  * https://bz.apache.org/ooo/show_bug.cgi?id=102931
(cop-out, there's apparently still corner-cases left where _no_ locking
 happens)
- then proper locking on WebDAV shares was implemented via
  tdf#82744
  * which inevitably led to problems when a user couldn't write
  * so UseWebDAVFileLocking was added to disable it

(please amend the history, especially if StarOffice old hands remember
additional details)

Taking this all together, my mental model of the LibreOffice document
file locking requirements is:

* when opening read-write, make sure the file is locked (via a number
  of configurable means). Failing to take _any_ of those locks should
  lead to read-only opening.
* by default, use as many lock-signalling (system APIs plus lock
  files) as possible, so other programs have a chance to detect the
  access, too
* as a safety measure, when saving, check if the document access time
  has changed, and warn the user that potentially someone else
  accessed the document

For corner cases or historical setups that cannot accomodate change,
configuration options have been introduced (and I wouldn't object
continuing down that path).

Makes sense thus far?

Cheers,

-- Thorsten

signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-qa] Minutes of the ESC call 2019-01-10

2019-01-11 Thread Thorsten Behrens
* Present:
+ Sophie, Olivier, Michael W, Michael M, Miklos, Kendy, Stephan
  Michael S, Caolan, Thorsten, Christian, Heiko, Justin, Eike

* Completed Action Items:

* Pending Action Items:
+ send code pointers to Olivier on UNO commands ↔ UI XML mapping (Kendy)
+ work with Mert to build an android l10n plan (Christian)
  [ didn’t connect with him yet ]
+ mail BoD wrt. MS store update (Christian)
+ add screenshot builder to basic build stats (Christian)
  [ it fails with Japanese locale – but it’s not in the translation
can build with all of these – and build runs fine, but with just
ja it fails – needs further research  ]

* Release Engineering update (Christian)
+ 6.1.5 RC1 – tagged next week ...
+ 6.2 RC 2 – due week 3 ? – Jan 17th
  + tagged Tuesday evening – builds on the mirror network now
  + libreoffice-6-2-0 branch created
  + still require 1 review for libreoffice-6-2
  + and another 2 reviews for libreoffice-6-2-0
  + Late Features
 + red-lining paragraph attribute re-work (Michael S)
+ looking pretty solid; all in.
+ so far – just 1 bug from the Word file-format;
  forgot to adapt the filter → fix for RC3 if +1 review.
   + will take a look at the patch (Miklos)
→ considers it done (Thorsten)
 + Notebookbar → any update wrt. leaving enabled (Heiko)
+ decided to enable – and see if there are complaints.
+ not so many so far; some issues with l10n
   + German & other langs longer than English l10n
  + makes things bigger potentially in one variant.
  + relevant for all variants with strings when you turn it on
  + compact variants don’t have this issue.
=> ship with it and see what happens.
   + marketing is happy with promoting it.
   + not a problem for now, but think it through in future (Sophie)
  + could introduce a shorter label in the commands (Heiko)
 + but a terrible solution
 + or comment to l10n that name should be short (Sophie)
 + Updated Elementary icons (Heiko)
   + directional issues fixed even for 6.2 (a bug)
 https://bugs.documentfoundation.org/show_bug.cgi?id=115986
+ Remotes
+ Android viewer
  + will provide a new version to the app store but no up-loaded yet.
+ Online

* Project / Donate popups in stable (Justin Luth)
+ unhappy with annoying popups for get-involved & donate for several reasons
   + open-source desparation / EOL signifier ?
   + eg. Wikipedia – EOL ? (Heiko)
+ security things: ignore adverts in E-mail / popups etc.
   + if LibreOffice starts up – get an advert …
   + don’t follow it – didn’t start it to investigate it
  + do own searching with google instead.
   + different classes of people: who would want to see it ?
  + no user would ask for this.
  + would like to see it die.
   + made me question / want to quit.
+ point quite clear in Bugzilla – can disable toolbars fine.
  + also against infobars from a user-perspective (Heiko)
 + decided in TDF team - rely on donations
 + need to draw more attention.
 + download from an app-store, who never see our download page.
 + where we encourage people to donate.
 + project relies heavily on this; a good balance
 + 1 click to dismiss in exchange.
 + fully agree it is annoying.
  + correlation between download updater & donations in the past (Michael)
+ potential compromises
  + leave it in for fresh, not stable.
  + one problem – not targetted at all
  + in the debug version → “please get involved” is annoying.
 + concern. wrt. Amateurish.
  + the fresh people you want to target more anyway.
  + am a sysadmin for 30 machines
 + end-users are prolly more of a drain wrt get-involved.
  + created the extension – but had to create it; took 3 hrs.
 + despite being the guy who wrote the wiki page on this.
 + lots of work on a small scale.
  + patches all go into 6.2 (Heiko)
+ get-involved is in 6.1.x
+ agree it is annoying (Thorsten)
  + there is a problem, TDF can only go so far
without a stable donation stream
 + not wedded to the current solution.
  + perhaps not the best venue to discuss → community / UX’y
  + slightly afraid of blessing stable too much
+ easire decision – not a permanent idea for stable (Miklos)
  + but just 6.1 – and come up with a better proposal.
AI:   + propose remove it from 6.3 and 6.1-stable (Justin)
   + could make it an --enable-release-build thing for 6.3 (Miklos)
AI:   => disable for 6.1 for now & release-build-ize it for 6.2 & 6.3
   + and continue discussing elsewhere.

* 

Minutes of the ESC call 2019-01-10

2019-01-11 Thread Thorsten Behrens
* Present:
+ Sophie, Olivier, Michael W, Michael M, Miklos, Kendy, Stephan
  Michael S, Caolan, Thorsten, Christian, Heiko, Justin, Eike

* Completed Action Items:

* Pending Action Items:
+ send code pointers to Olivier on UNO commands ↔ UI XML mapping (Kendy)
+ work with Mert to build an android l10n plan (Christian)
  [ didn’t connect with him yet ]
+ mail BoD wrt. MS store update (Christian)
+ add screenshot builder to basic build stats (Christian)
  [ it fails with Japanese locale – but it’s not in the translation
can build with all of these – and build runs fine, but with just
ja it fails – needs further research  ]

* Release Engineering update (Christian)
+ 6.1.5 RC1 – tagged next week ...
+ 6.2 RC 2 – due week 3 ? – Jan 17th
  + tagged Tuesday evening – builds on the mirror network now
  + libreoffice-6-2-0 branch created
  + still require 1 review for libreoffice-6-2
  + and another 2 reviews for libreoffice-6-2-0
  + Late Features
 + red-lining paragraph attribute re-work (Michael S)
+ looking pretty solid; all in.
+ so far – just 1 bug from the Word file-format;
  forgot to adapt the filter → fix for RC3 if +1 review.
   + will take a look at the patch (Miklos)
→ considers it done (Thorsten)
 + Notebookbar → any update wrt. leaving enabled (Heiko)
+ decided to enable – and see if there are complaints.
+ not so many so far; some issues with l10n
   + German & other langs longer than English l10n
  + makes things bigger potentially in one variant.
  + relevant for all variants with strings when you turn it on
  + compact variants don’t have this issue.
=> ship with it and see what happens.
   + marketing is happy with promoting it.
   + not a problem for now, but think it through in future (Sophie)
  + could introduce a shorter label in the commands (Heiko)
 + but a terrible solution
 + or comment to l10n that name should be short (Sophie)
 + Updated Elementary icons (Heiko)
   + directional issues fixed even for 6.2 (a bug)
 https://bugs.documentfoundation.org/show_bug.cgi?id=115986
+ Remotes
+ Android viewer
  + will provide a new version to the app store but no up-loaded yet.
+ Online

* Project / Donate popups in stable (Justin Luth)
+ unhappy with annoying popups for get-involved & donate for several reasons
   + open-source desparation / EOL signifier ?
   + eg. Wikipedia – EOL ? (Heiko)
+ security things: ignore adverts in E-mail / popups etc.
   + if LibreOffice starts up – get an advert …
   + don’t follow it – didn’t start it to investigate it
  + do own searching with google instead.
   + different classes of people: who would want to see it ?
  + no user would ask for this.
  + would like to see it die.
   + made me question / want to quit.
+ point quite clear in Bugzilla – can disable toolbars fine.
  + also against infobars from a user-perspective (Heiko)
 + decided in TDF team - rely on donations
 + need to draw more attention.
 + download from an app-store, who never see our download page.
 + where we encourage people to donate.
 + project relies heavily on this; a good balance
 + 1 click to dismiss in exchange.
 + fully agree it is annoying.
  + correlation between download updater & donations in the past (Michael)
+ potential compromises
  + leave it in for fresh, not stable.
  + one problem – not targetted at all
  + in the debug version → “please get involved” is annoying.
 + concern. wrt. Amateurish.
  + the fresh people you want to target more anyway.
  + am a sysadmin for 30 machines
 + end-users are prolly more of a drain wrt get-involved.
  + created the extension – but had to create it; took 3 hrs.
 + despite being the guy who wrote the wiki page on this.
 + lots of work on a small scale.
  + patches all go into 6.2 (Heiko)
+ get-involved is in 6.1.x
+ agree it is annoying (Thorsten)
  + there is a problem, TDF can only go so far
without a stable donation stream
 + not wedded to the current solution.
  + perhaps not the best venue to discuss → community / UX’y
  + slightly afraid of blessing stable too much
+ easire decision – not a permanent idea for stable (Miklos)
  + but just 6.1 – and come up with a better proposal.
AI:   + propose remove it from 6.3 and 6.1-stable (Justin)
   + could make it an --enable-release-build thing for 6.3 (Miklos)
AI:   => disable for 6.1 for now & release-build-ize it for 6.2 & 6.3
   + and continue discussing elsewhere.

* 

Re: About Joining Libre Office

2019-01-06 Thread Thorsten Behrens
Hi Mohit,

Mohit Kumar wrote:
> hi, I want to solve the bugs. I only know the c++. Can I able to
> solve the bugs with this single language?
>
Absolutely, the LibreOffice core is written in c++.

Any specific easy hacks already on your radar? Got a build going yet?

Cheers,

-- Thorsten


signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: Which make binary to use for Windows?

2019-01-03 Thread Thorsten Behrens
Hi Mark,

Mark Hung wrote:
> Which version is expected?
>
For Windows, usually your best bet is to run with the LODE setup (that
also covers quite a bit more than just gnumake):

https://wiki.documentfoundation.org/Development/lode#Windows_Bootstrapping_.28Windows_user_only.29

(that's also what CI is using, and it's therefore quite well maintained)

HTH,

-- Thorsten


signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: @42 reboot?

2018-12-27 Thread Thorsten Behrens
Hi Luke,

Luke Benes wrote:
> ping
>
I'm away from the box, and after a Windows update / reboot, machine is
now unresponsive. Sorry for that, can look into this Jan 1st the
earliest. :/

Cheers,

-- Thorsten

signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: Libre Office Installation Error

2018-12-25 Thread Thorsten Behrens
Hi Komal,

Komal Bharadiya wrote:
> I would be really very grateful, if I could get help in this. I am
> totally stuck. I have tried lot many ways but couldn't resolve the
> errors.
>
Seems your initial issue was an interrupted download - try grabbing a
tarball of the git repo (that you can resume after connection
failures), from here:

https://dev-www.libreoffice.org/bundles/libreoffice-core.tar.bz2

HTH,

-- Thorsten


signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: Fw: [Libreoffice-commits] kde5: remove older kde/tde plugins, and references to that

2018-12-18 Thread Thorsten Behrens
Stephan Bergmann wrote:
> FYI, gandalf appears to still have issues, see
>  and following
> builds all done on gandalf this morning.
>
Yes, can't update gandalf currently, issues with the repos there.

Cheers,

-- Thorsten


signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


Fw: [Libreoffice-commits] kde5: remove older kde/tde plugins, and references to that

2018-12-17 Thread Thorsten Behrens
Hi,

with the below commit, I've removed the old kde4 backend from vcl
(plus some glue code across the code base) - we've talked about that
briefly I believe during the CentOS7 baseline discussion at the
in-person ESC meeting in Tirana.

There's now actually two contemporary KDE backends for vcl: the
gtk3_kde5 one, and the native kde5 version, both targetting KF5/Plasma
desktops.

I hope this change is broadly uncontroversial; KDE4 was released in
2008, with a final maintenance update in 2014, and only (if at all)
receives minimal legacy runtime support in recent distros.

I've also changed jenkins config defaults to 'on' for kde5 (with some
fallout apparently for tinderboxes; seems baseline support was missing
on a few of them - apologies if you got spammed inadvertently).

Cheers, Thorsten

- Forwarded message from Libreoffice Gerrit user 
 -

Date: Mon, 17 Dec 2018 17:33:37 + (UTC)
From: Libreoffice Gerrit user 
Subject: [Libreoffice-commits] core.git

 Repository.mk   |8 
 RepositoryExternal.mk   |   27 
 bin/check-elf-dynamic-objects   |4 
 bin/distro-install-file-lists   |6 
 config_host.mk.in   |6 
 config_host/config_kde4.h.in|   10 
 config_host/config_vclplug.h.in |1 
 configure.ac|  322 --
 cppuhelper/source/servicemanager.cxx|8 
 cui/Library_cui.mk  |1 
 cui/source/options/optgdlg.cxx  |6 
 distro-configs/Jenkins/LibreOfficeLinuxUpdater.conf |2 
 distro-configs/Jenkins/Linux_dev_master.conf|2 
 distro-configs/Jenkins/Linux_rel_master.conf|2 
 distro-configs/LibreOfficeCoverity.conf |2 
 distro-configs/LibreOfficeLinux.conf|2 
 distro-configs/LibreOfficeOpenBSD.conf  |3 
 distro-configs/LibreOfficeiOS.conf  |2 
 include/sal/log-areas.dox   |1 
 postprocess/Rdb_services.mk |3 
 scp2/InstallScript_setup_osl.mk |2 
 scp2/Module_scp2.mk |2 
 shell/Library_kde4be.mk |   32 
 shell/Module_shell.mk   |6 
 shell/source/backends/desktopbe/desktopbackend.cxx  |   16 
 shell/source/backends/kde4be/kde4access.cxx |  300 -
 shell/source/backends/kde4be/kde4access.hxx |   39 
 shell/source/backends/kde4be/kde4backend.cxx|  180 ---
 shell/source/backends/kde4be/kde4be1.component  |   25 
 solenv/gbuild/CppunitTest.mk|1 
 svtools/source/uno/fpicker.cxx  |   12 
 sysui/CustomTarget_share.mk |2 
 vcl/CustomTarget_kde4_moc.mk|   24 
 vcl/Library_vclplug_kde4.mk |   99 -
 vcl/Module_vcl.mk   |7 
 vcl/README  |6 
 vcl/README.scheduler|4 
 vcl/inc/vclpluginapi.h  |6 
 vcl/source/app/salplug.cxx  |5 
 vcl/source/opengl/OpenGLHelper.cxx  |2 
 vcl/unx/kde4/FPServiceInfo.hxx  |   28 
 vcl/unx/kde4/KDE4FilePicker.cxx |  823 
 vcl/unx/kde4/KDE4FilePicker.hxx |  258 -
 vcl/unx/kde4/KDEData.cxx|   68 -
 vcl/unx/kde4/KDEData.hxx|   37 
 vcl/unx/kde4/KDESalDisplay.cxx  |   91 -
 vcl/unx/kde4/KDESalDisplay.hxx  |   45 
 vcl/unx/kde4/KDESalFrame.cxx|  373 ---
 vcl/unx/kde4/KDESalFrame.hxx|   53 -
 vcl/unx/kde4/KDESalGraphics.cxx | 1025 
 vcl/unx/kde4/KDESalGraphics.hxx |   53 -
 vcl/unx/kde4/KDESalInstance.cxx |   66 -
 vcl/unx/kde4/KDESalInstance.hxx |   45 
 vcl/unx/kde4/KDEXLib.cxx|  426 
 vcl/unx/kde4/KDEXLib.hxx|  101 -
 vcl/unx/kde4/VCLKDEApplication.cxx  |   87 -
 vcl/unx/kde4/VCLKDEApplication.hxx  |   39 
 vcl/unx/kde4/main.cxx   |   89 -
 vcl/unx/kde4/tst_exclude_posted_events.hxx  |   67 -
 vcl/unx/kde4/tst_exclude_socket_notifiers.hxx   |   80 -
 vcl/unx/kde5/KDE5FilePicker2.cxx|3 
 vcl/unx/kde5/KDE5SalInstance.cxx|1 
 62 files changed, 30 insertions(+), 5016 deletions(-)

- End forwarded message -


signature.asc
Description: PGP signature

Re: [Libreoffice-qa] Weekly QA Report (W49-2018)

2018-12-13 Thread Thorsten Behrens
Hi Xisco,

Xisco Fauli wrote:
> Generated on 2018-12-11 based on stats from 2018-12-09. Note: Metabugs
> are ignored.
> 
Thx a bunch for the weekly stats, and the extra data on the blog
(https://qa.blog.documentfoundation.org/2018/12/04/qa-report-november-2018/).

As that question was asked from a number of people: any chance to add
a chart with the history of regressions, similar to the one for the
evolution of the unconfirmed bugs?

Cheers,

-- Thorsten


signature.asc
Description: PGP signature
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: Compiler baselines

2018-12-10 Thread Thorsten Behrens
Hi Moggi,

Markus Mohrhard wrote:
> Gandalf is not a CentOS based buildbot but the self-built gcc is now
> available under "/opt/rh/devtoolset-7/root/usr/bin/gcc" to reduce the
> differences between the different buildbots and make it easier to move jobs
> between different jenkins VMs.
>
Ah that's a very nice solution to the baseline problem, thx a lot!

Cheers,

-- Thorsten


signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice-qa] minutes of ESC call ...

2018-12-02 Thread Thorsten Behrens
Michael Meeks wrote:
> * Hackfests & Events (Thorsten)
>+ next year hackfests coming up:
>+ FOSDEM in February - 2 days before the conference expected.
>
Apologies, there's an off-by-one error:

tentative FOSDEM schedule is as follows:

Wednesday, January 30
 * Hackfest at betacowork

Thursday, January 31
 * Hackfest at betacowork
 * 1300-1800 board + ED meeting at betacowork

Friday, February 1
 * all day board + ED + MC + staff at betacowork

Cheers,

-- Thorsten


signature.asc
Description: PGP signature
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] minutes of ESC call ...

2018-11-30 Thread Thorsten Behrens
Michael Meeks wrote:
> * Hackfests & Events (Thorsten)
>+ next year hackfests coming up:
>+ FOSDEM in February - 2 days before the conference expected.
>
Apologies, there's an off-by-one error:

tentative FOSDEM schedule is as follows:

Wednesday, January 30
 * Hackfest at betacowork

Thursday, January 31
 * Hackfest at betacowork
 * 1300-1800 board + ED meeting at betacowork

Friday, February 1
 * all day board + ED + MC + staff at betacowork

Cheers,

-- Thorsten


signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: Changing old commit message

2018-11-14 Thread Thorsten Behrens
Jan-Marek Glogowski proposes:
> "Sponsored-by" [...]
> "Fixes: tdf#12345" [...]
> "Regression-from: "
>
+1

Cheers,

-- Thorsten


signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: your mail

2018-11-02 Thread Thorsten Behrens
Hi Francois,

Francois Botha wrote:
> Could you please direct me in the right direction to solve this problem? I
> couldn't find anything in
> 
First thing to check - your PATH environment variable. This is how it
looks for me on a rather virgin Windows install under cygwin bash:

# echo $PATH
/usr/local/bin:/usr/bin:/cygdrive/c/ProgramData/Oracle/Java/javapath:/cygdrive/c/Windows/system32:/cygdrive/c/Windows:/cygdrive/c/Windows/System32/Wbem:/cygdrive/c/Windows/System32/WindowsPowerShell/v1.0

HTH,

-- Thorsten


signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: LibreOffice Impress Presentation Server

2018-10-31 Thread Thorsten Behrens
Hi Sergi,

Sergi Baila wrote:
> Given all these requirements I'm thinking of something on the line
> of what I call a "LibreOffice Impress Presentation Server". A
> standalone app (LibreOffice impress) which can receive commands
> (REST?) regarding which information to show on the secondary
> screen. I am also open to any other alternative (like an embedded
> Java engine?).
>
Pretty much anything in LibreOffice can be remote-controlled from a
different process (even from a different box), via a protocol called
UNO (quite similar to COM).

Here's an example in python (but the UNO API calls are really quite
similar for Java):

https://stackoverflow.com/questions/33092424/control-libreoffice-impress-from-python

That leaves the question on how to dynamically generate slide content,
but that also works via UNO (you can even send Impress files over the
wire). There's documentation for that, e.g. Andrew's macro book linked
from the article above: http://www.pitonyak.org/oo.php

Hope that helps,

-- Thorsten


signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: "GpgME not installed correctly" in unit tests

2018-10-17 Thread Thorsten Behrens
Hi *,

Jan-Marek Glogowski wrote:
> Am October 17, 2018 5:52:18 AM UTC schrieb Kaganski Mike 
> :
> >---
> >GpgME not installed correctly
> >---
> >gpgme-w32spawn.exe was not found in the detected installation directory
> >
> >of GpgME
> > "C:\lo\src\core\workdir\LinkTarget\Executable"
> >
>
Ah - so it seems also LinkTarget\Executable needs a copy of that silly
program - can you try to add a line to

external/gpgmepp/ExternalPackage_gpgmepp.mk

that copies it there?

(there's already $(eval $(call
gb_ExternalPackage_add_file,gpgmepp,$(LIBO_LIB_FOLDER)/gpgme-w32spawn.exe,src/gpgme-w32spawn.exe))
- perhaps that is now redundant? Sorry, no finished master build right
now for me to test myself)

All the best,

-- Thorsten

signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice-qa] Minutes of 2018-10-11 ESC call

2018-10-15 Thread Thorsten Behrens
Stephan Bergmann wrote:
> >     + setup new CentOS7 baseline VM (Cloph)
> >   [ done for the 64bit builds, for 32bit we stick to the CentOS6 ]
>
Perhaps then time to start pondering deprecation of the Linux x86
platform?

Cheers,

-- Thorsten


signature.asc
Description: PGP signature
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] Minutes of 2018-10-11 ESC call

2018-10-14 Thread Thorsten Behrens
Stephan Bergmann wrote:
> >     + setup new CentOS7 baseline VM (Cloph)
> >   [ done for the 64bit builds, for 32bit we stick to the CentOS6 ]
>
Perhaps then time to start pondering deprecation of the Linux x86
platform?

Cheers,

-- Thorsten


signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: problems with LayerTabBar in unit tests

2018-10-10 Thread Thorsten Behrens
Hi Regina,

Regina Henschel wrote:
> So I still need to investigate what is missing.
> 
If you can make it - perhaps something to look into for the Munich
Hackfest?

https://wiki.documentfoundation.org/Hackfest/Muenchen2018

Cheers,

-- Thorsten


signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: layout.xml differs from parseDump(...)

2018-09-07 Thread Thorsten Behrens
Hi Patrick,

Patrick Jaap wrote:
> So, the first one is equal, but the other ones are shifted by 333.
> 
> How can this be caused? Is this a bug?
> 
Looks odd indeed. First thing that comes to mind: layouting continues
asynchronously after the load - perhaps a
Scheduler::ProcessEventsToIdle() helps. See uiwriter.cxx for a few
examples where that is used.

Other than that, all a bit speculative. Any code / patch yet to look
at?

Cheers,

-- Thorsten


signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: Missing w:separator attribute in OOXML file

2018-08-26 Thread Thorsten Behrens
Hi Patrick,

Patrick Jaap wrote:
> Has the behavior of Word changed? Reading the commit message, it seems like
> in the past Word does not show the separator when the attribute is missing.
> Word 2013 shows the line.
> 
Perhaps if you could share the word/settings.xml from the original
file, especially the  element contents?

(there used to be AnonODF, which perhaps could have served as a
starting point for something similar directed at OOXML, sadly
http://opendocument.xml.org/product/anonodfpy-hwd points into the void
now..)

Cheers,

-- Thorsten


signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: Compiler baselines (was: [Libreoffice-qa] minutes of ESC call ...)

2018-07-24 Thread Thorsten Behrens
Stephan Bergmann wrote:
> According to the feature matrix at
> , bumping to GCC 7 and
> MSVC 2017 15.7 would give us almost complete C++17 support, which would of
> course be a great step forward.
>
oh nice!

> For the TDF Linux builds on CentOS 6 with Developer Toolset (where we
> currently use Deverloper Toolset 2 with GCC 4.8.2, IIUC), my understanding
> would be that Developer Toolset 7 with GCC 7 should be available to use
> instead (searching the web I found
> )?
>
Two remarks - devtoolset-7 only seems to be available for x86_64, so
unless we invest some effort to get cross builds to work on linux (I
expect externals to be the real pain point here), this means
abandoning 32bit linux.

One of the upsides to not only update toolchain, but the entire
baseline builders (e.g. to CentOS 7) would be KF5 ('KDE5') support.

Cheers,

-- Thorsten


signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - sw/source

2018-07-12 Thread Thorsten Behrens
 sw/source/uibase/uno/unotxdoc.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 796ca86ce151b1887dd1dc2c6eac217d7835095d
Author: Thorsten Behrens 
Date:   Thu Jul 12 00:11:30 2018 +0200

Make setPagePrintSettings() accept IsLandscape again

Regression from 80c35d97b9b3b60a091aae77de0ffef38cbf531a - invert
the check for boost::optional validity.

Change-Id: If4e041e1fe349c1fcb2c74b2e5780bf57300486f
Reviewed-on: https://gerrit.libreoffice.org/57309
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens 
(cherry picked from commit 0853b05b1fabb231a7d57d811c5a06ee542d3295)
Reviewed-on: https://gerrit.libreoffice.org/57316

diff --git a/sw/source/uibase/uno/unotxdoc.cxx 
b/sw/source/uibase/uno/unotxdoc.cxx
index 0a22921c96e6..1db55d3c5831 100644
--- a/sw/source/uibase/uno/unotxdoc.cxx
+++ b/sw/source/uibase/uno/unotxdoc.cxx
@@ -1142,7 +1142,7 @@ void SwXTextDocument::setPagePrintSettings(const 
Sequence< beans::PropertyValue
 else if(sName == "IsLandscape")
 {
 auto b = o3tl::tryAccess(rVal);
-bException = bool(b);
+bException = !b;
 if (b)
 {
 aData.SetLandscape(*b);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: sw/source

2018-07-12 Thread Thorsten Behrens
 sw/source/uibase/uno/unotxdoc.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 0853b05b1fabb231a7d57d811c5a06ee542d3295
Author: Thorsten Behrens 
Date:   Thu Jul 12 00:11:30 2018 +0200

Make setPagePrintSettings() accept IsLandscape again

Regression from 80c35d97b9b3b60a091aae77de0ffef38cbf531a - invert
the check for boost::optional validity.

Change-Id: If4e041e1fe349c1fcb2c74b2e5780bf57300486f
Reviewed-on: https://gerrit.libreoffice.org/57309
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens 

diff --git a/sw/source/uibase/uno/unotxdoc.cxx 
b/sw/source/uibase/uno/unotxdoc.cxx
index 31650d253f7f..73e69275a698 100644
--- a/sw/source/uibase/uno/unotxdoc.cxx
+++ b/sw/source/uibase/uno/unotxdoc.cxx
@@ -1147,7 +1147,7 @@ void SwXTextDocument::setPagePrintSettings(const 
Sequence< beans::PropertyValue
 else if(sName == "IsLandscape")
 {
 auto b = o3tl::tryAccess(rVal);
-bException = bool(b);
+bException = !b;
 if (b)
 {
 aData.SetLandscape(*b);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: vcl/inc vcl/unx

2018-07-06 Thread Thorsten Behrens
 vcl/inc/unx/x11_cursors/null_curs.h |1 -
 vcl/inc/unx/x11_cursors/null_mask.h |1 -
 vcl/unx/generic/app/saldisp.cxx |3 +++
 vcl/unx/gtk/gtkdata.cxx |3 +++
 vcl/unx/gtk3/gtk3gtkdata.cxx|5 -
 5 files changed, 10 insertions(+), 3 deletions(-)

New commits:
commit ad955de670c822c5462990ef36a35608eac88480
Author: Thorsten Behrens 
Date:   Thu Mar 1 14:57:58 2018 +0100

WaE: -Wunused-variable

Change-Id: I58f012ddc2c5030b0e3e215b9cab4e89abf06c2b
Reviewed-on: https://gerrit.libreoffice.org/57066
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens 

diff --git a/vcl/inc/unx/x11_cursors/null_curs.h 
b/vcl/inc/unx/x11_cursors/null_curs.h
index d74b462cba9b..ebeee4e6ffc5 100644
--- a/vcl/inc/unx/x11_cursors/null_curs.h
+++ b/vcl/inc/unx/x11_cursors/null_curs.h
@@ -20,6 +20,5 @@
 #define nullcurs_height 4
 #define nullcurs_x_hot 2
 #define nullcurs_y_hot 2
-static unsigned char nullcurs_bits[] = { 0x00, 0x00, 0x00, 0x00 };
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/inc/unx/x11_cursors/null_mask.h 
b/vcl/inc/unx/x11_cursors/null_mask.h
index bc23e9c9729b..71f08a94afcf 100644
--- a/vcl/inc/unx/x11_cursors/null_mask.h
+++ b/vcl/inc/unx/x11_cursors/null_mask.h
@@ -18,6 +18,5 @@
  */
 #define nullmask_width 4
 #define nullmask_height 4
-static unsigned char nullmask_bits[] = { 0x00, 0x00, 0x00, 0x00 };
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/unx/generic/app/saldisp.cxx b/vcl/unx/generic/app/saldisp.cxx
index dff49c8e8b7c..ddce3f81da27 100644
--- a/vcl/unx/generic/app/saldisp.cxx
+++ b/vcl/unx/generic/app/saldisp.cxx
@@ -1494,6 +1494,9 @@ KeySym SalDisplay::GetKeySym( XKeyEvent*pEvent,
 }
 
 // Pointer
+static unsigned char nullmask_bits[] = { 0x00, 0x00, 0x00, 0x00 };
+static unsigned char nullcurs_bits[] = { 0x00, 0x00, 0x00, 0x00 };
+
 #define MAKE_BITMAP( name ) \
 XCreateBitmapFromData( pDisp_, \
DefaultRootWindow( pDisp_ ), \
diff --git a/vcl/unx/gtk/gtkdata.cxx b/vcl/unx/gtk/gtkdata.cxx
index 7c9a3d1e0fbc..689fa071ce5b 100644
--- a/vcl/unx/gtk/gtkdata.cxx
+++ b/vcl/unx/gtk/gtkdata.cxx
@@ -245,6 +245,9 @@ GdkCursor* GtkSalDisplay::getFromXBM( const unsigned char 
*pBitmap,
   , , nXHot, nYHot);
 }
 
+static unsigned char nullmask_bits[] = { 0x00, 0x00, 0x00, 0x00 };
+static unsigned char nullcurs_bits[] = { 0x00, 0x00, 0x00, 0x00 };
+
 #define MAKE_CURSOR( vcl_name, name ) \
 case vcl_name: \
 pCursor = getFromXBM( name##curs##_bits, name##mask##_bits, \
diff --git a/vcl/unx/gtk3/gtk3gtkdata.cxx b/vcl/unx/gtk3/gtk3gtkdata.cxx
index fd5b47f0b626..024dac2a5014 100644
--- a/vcl/unx/gtk3/gtk3gtkdata.cxx
+++ b/vcl/unx/gtk3/gtk3gtkdata.cxx
@@ -213,7 +213,10 @@ GdkCursor* GtkSalDisplay::getFromXBM( const unsigned char 
*pBitmap,
 return cursor;
 }
 
-#define MAKE_CURSOR( vcl_name, name ) \
+static unsigned char nullmask_bits[] = { 0x00, 0x00, 0x00, 0x00 };
+static unsigned char nullcurs_bits[] = { 0x00, 0x00, 0x00, 0x00 };
+
+#define MAKE_CURSOR( vcl_name, name )   \
 case vcl_name: \
 pCursor = getFromXBM( name##curs##_bits, name##mask##_bits, \
   name##curs_width, name##curs_height, \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-qa] Minutes of ESC call 2017-07-05

2018-07-05 Thread Thorsten Behrens
* Present:
  + Thorsten, Miklos, Heiko, Michael W, Sophie, Cloph, Xisco, Stephan,
Eike, Olivier

* Completed Action Items:
+ enable new help for tinderboxes (Christian) → in distro-config
+ disable HSQLDB auto-migration for now except for experimental (Tamas B)
+ provide distro name for MIMO branch (Jean-Sebastien)

* Pending Action Items:
+ on ESC share - “Budget2018” - add your ranking before this week’s call [!]

* Release Engineering update (Christian)
+ 6.0.6 – rc1 due next week (Jul 10)
+ 6.1.0 RC1
+ tagged on Wednesday,
  builds are on pre-releases and now being synced to mirrors
+ 6.1.0 RC2 with libreoffice-6-1-0 branch week after the next
  marks hard code freeze  (Jul 17)
+ from now on, commits to 6-1 branch need one mandatory review
+ also string freeze
+ also includes html help switch for distro branches
+ ATTENTION for distro branch maintainers – there was a prob
  with gerrit, submodule changes might not have created
  the correct auto-commit on core
  + this was a problem since last weekend, fixed now
+ 6.1 late features
+ calc threading default / fixing (Miklos)
   + *DONE*, just bugfixing from now on
   + Eike: question to disable precautiously?
   + Miklos: if needed can be done at the last moment
+ writer – red-lining re-factoring (Michael S)
   + merged and done, included in beta 2 → remove here
+ Help format (Stephan/Olivier)
   + done and working
   + small gbuild make pattern rule prob on Mac, fixed now
AI + Olivier will release-note it
+ Remotes
+ Android viewer
+ Online
+ simplifying iOS build re translations

* Documentation (Olivier)
+ New help
+ Testing in bug hunting session tomorrow (installs)
+ Small corrections in XSLT filter
+ tweaks in CSS by fitoshido – people start contributing
+ Help contents
+ cosmetic refactor by SophiaS
+ Contents for [NatNum12] by Lazlo Nemetz
+ Contents fixes (ohallot, fitoshido)
+ Guides
+ Assembling & revising GS 6.0
+ Extras
+ some tweaks in UI dialog after help review.

* UX Update (Heiko)
+ Bugzilla (topicUI) statistics
248(248) (topicUI) bugs open, 281(281) (needsUXEval) needs to be 
evaluated by the UXteam
+ Updates:
BZ changes   1 week1 month   3 months   12 months  
 added  1(-4) 7(-1) 16(-6)  80(-4) 
 commented 21(-17)   69(1) 258(-60)   1659(-30)
   removed  0(0)  0(0)   0(0)   10(0)  
  resolved  1(-2) 6(0)  21(-3) 170(-2) 
+ top 10 contributors:
  Tietze, Heiko made 31 changes in 1 month, and 728 changes in 1 year
  Buovjaga made 24 changes in 1 month, and 171 changes in 1 year
  Foote, V Stuart made 12 changes in 1 month, and 241 changes in 1 year
  Kainz, Andreas made 10 changes in 1 month, and 34 changes in 1 year
  Xisco Faulí made 8 changes in 1 month, and 322 changes in 1 year
  Henschel, Regina made 7 changes in 1 month, and 99 changes in 1 year
  *UNKNOWN* made 7 changes in 1 month, and 9 changes in 1 year
  Raal made 6 changes in 1 month, and 17 changes in 1 year
  kompilainenn made 6 changes in 1 month, and 26 changes in 1 year
  Thomas Lendo made 5 changes in 1 month, and 248 changes in 1 year 
+ cont’d the discussion around CTL/CJK tdf#104318
  + Suggestion is to remove the binding to languages completely,
which has bearing on default style
  + rethink default styles completely
  + Franklin and Khaled are involved in the thinking

+ positive feedback tdf#118516
  “And, I should have added my personal thanks and on behalf of the
   whole user base (if I may be so bold) to the whole LO team for
   the incredible work being done.”
+ German magazine compared LibreOffice vs. Softmaker, highlighting the
  Notebookbar/Ribbon interface
  + 
https://www.heise.de/ct/ausgabe/2018-14-LibreOffice-6-0-gegen-SoftMaker-Office-2018-fuer-Linux-4084433.html
  + discussion the German ML pointing out a few badly investigated
aspects
+ personal note: Heiko on vacation for the next two weeks

* Fuzz / Crash Testing (Caolan on vacation)
+ 60(-16) import failure, 3(+1) export failures
+ coverity
+ ??
+ forcepoint ??
+ oss-fuzz ?? (?? outstanding, ?? minor)
+ ODF validation has landed, validation errors will now show up in
  crashtesting logs – fixing howto on the dev list

* Crash Reporting (Xisco)
+ Update notification was enabled, incoming reports start to look
  better than for previous version

+ http://crashreport.libreoffice.org/stats/version/5.4.7.2
 + 489 (last 7 days) (-26)

 

Minutes of ESC call 2017-07-05

2018-07-05 Thread Thorsten Behrens
* Present:
  + Thorsten, Miklos, Heiko, Michael W, Sophie, Cloph, Xisco, Stephan,
Eike, Olivier

* Completed Action Items:
+ enable new help for tinderboxes (Christian) → in distro-config
+ disable HSQLDB auto-migration for now except for experimental (Tamas B)
+ provide distro name for MIMO branch (Jean-Sebastien)

* Pending Action Items:
+ on ESC share - “Budget2018” - add your ranking before this week’s call [!]

* Release Engineering update (Christian)
+ 6.0.6 – rc1 due next week (Jul 10)
+ 6.1.0 RC1
+ tagged on Wednesday,
  builds are on pre-releases and now being synced to mirrors
+ 6.1.0 RC2 with libreoffice-6-1-0 branch week after the next
  marks hard code freeze  (Jul 17)
+ from now on, commits to 6-1 branch need one mandatory review
+ also string freeze
+ also includes html help switch for distro branches
+ ATTENTION for distro branch maintainers – there was a prob
  with gerrit, submodule changes might not have created
  the correct auto-commit on core
  + this was a problem since last weekend, fixed now
+ 6.1 late features
+ calc threading default / fixing (Miklos)
   + *DONE*, just bugfixing from now on
   + Eike: question to disable precautiously?
   + Miklos: if needed can be done at the last moment
+ writer – red-lining re-factoring (Michael S)
   + merged and done, included in beta 2 → remove here
+ Help format (Stephan/Olivier)
   + done and working
   + small gbuild make pattern rule prob on Mac, fixed now
AI + Olivier will release-note it
+ Remotes
+ Android viewer
+ Online
+ simplifying iOS build re translations

* Documentation (Olivier)
+ New help
+ Testing in bug hunting session tomorrow (installs)
+ Small corrections in XSLT filter
+ tweaks in CSS by fitoshido – people start contributing
+ Help contents
+ cosmetic refactor by SophiaS
+ Contents for [NatNum12] by Lazlo Nemetz
+ Contents fixes (ohallot, fitoshido)
+ Guides
+ Assembling & revising GS 6.0
+ Extras
+ some tweaks in UI dialog after help review.

* UX Update (Heiko)
+ Bugzilla (topicUI) statistics
248(248) (topicUI) bugs open, 281(281) (needsUXEval) needs to be 
evaluated by the UXteam
+ Updates:
BZ changes   1 week1 month   3 months   12 months  
 added  1(-4) 7(-1) 16(-6)  80(-4) 
 commented 21(-17)   69(1) 258(-60)   1659(-30)
   removed  0(0)  0(0)   0(0)   10(0)  
  resolved  1(-2) 6(0)  21(-3) 170(-2) 
+ top 10 contributors:
  Tietze, Heiko made 31 changes in 1 month, and 728 changes in 1 year
  Buovjaga made 24 changes in 1 month, and 171 changes in 1 year
  Foote, V Stuart made 12 changes in 1 month, and 241 changes in 1 year
  Kainz, Andreas made 10 changes in 1 month, and 34 changes in 1 year
  Xisco Faulí made 8 changes in 1 month, and 322 changes in 1 year
  Henschel, Regina made 7 changes in 1 month, and 99 changes in 1 year
  *UNKNOWN* made 7 changes in 1 month, and 9 changes in 1 year
  Raal made 6 changes in 1 month, and 17 changes in 1 year
  kompilainenn made 6 changes in 1 month, and 26 changes in 1 year
  Thomas Lendo made 5 changes in 1 month, and 248 changes in 1 year 
+ cont’d the discussion around CTL/CJK tdf#104318
  + Suggestion is to remove the binding to languages completely,
which has bearing on default style
  + rethink default styles completely
  + Franklin and Khaled are involved in the thinking

+ positive feedback tdf#118516
  “And, I should have added my personal thanks and on behalf of the
   whole user base (if I may be so bold) to the whole LO team for
   the incredible work being done.”
+ German magazine compared LibreOffice vs. Softmaker, highlighting the
  Notebookbar/Ribbon interface
  + 
https://www.heise.de/ct/ausgabe/2018-14-LibreOffice-6-0-gegen-SoftMaker-Office-2018-fuer-Linux-4084433.html
  + discussion the German ML pointing out a few badly investigated
aspects
+ personal note: Heiko on vacation for the next two weeks

* Fuzz / Crash Testing (Caolan on vacation)
+ 60(-16) import failure, 3(+1) export failures
+ coverity
+ ??
+ forcepoint ??
+ oss-fuzz ?? (?? outstanding, ?? minor)
+ ODF validation has landed, validation errors will now show up in
  crashtesting logs – fixing howto on the dev list

* Crash Reporting (Xisco)
+ Update notification was enabled, incoming reports start to look
  better than for previous version

+ http://crashreport.libreoffice.org/stats/version/5.4.7.2
 + 489 (last 7 days) (-26)

 

[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-5-2+backports' - vcl/source

2018-07-05 Thread Thorsten Behrens
 vcl/source/window/status.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 01161d411e4dfacb36c8889a91430ed44161447c
Author: Thorsten Behrens 
Date:   Thu Jul 5 17:06:49 2018 +0200

vcl: fix -Werror=shadow

Change-Id: If8897bc7e7a20961b2a325f20351ae9b6942563e

diff --git a/vcl/source/window/status.cxx b/vcl/source/window/status.cxx
index 09ab700d7a5e..16350be3c052 100644
--- a/vcl/source/window/status.cxx
+++ b/vcl/source/window/status.cxx
@@ -226,7 +226,6 @@ void StatusBar::ImplInitSettings()
 
 void StatusBar::ImplFormat()
 {
-ImplStatusItem* pItem;
 longnExtraWidth;
 longnExtraWidth2;
 longnX;
@@ -312,6 +311,7 @@ void StatusBar::ImplFormat()
 nX += ImplGetSVData()->maNWFData.mnStatusBarLowerRightOffset;
 }
 
+ImplStatusItem* pItem;
 for (ImplStatusItem* i : *mpItemList) {
 pItem = i;
 if ( pItem->mbVisible ) {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-5-2+backports' - solenv/gbuild

2018-07-04 Thread Thorsten Behrens
 solenv/gbuild/platform/unxgcc.mk |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 52b85ab2adf74e82cb598d9273b1639b11c28270
Author: Thorsten Behrens 
Date:   Thu Jul 5 01:33:23 2018 +0200

gcc7: disable -Wdeprecated for dynamic excpt specs

gcc started to warn about c++11-deprecated dynamic exception
specifications thusly:

warning: dynamic exception specifications are deprecated in C++11 
[-Wdeprecated]

so disable this on the branch instead of a massive backport.

See https://en.cppreference.com/w/cpp/language/except_spec for a
discussion; this is still perfectly correct c++ code.

Change-Id: Iffbb82e4da24fb96fab57f233b8ebe41fbc850fa
Reviewed-on: https://gerrit.libreoffice.org/56981
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 

diff --git a/solenv/gbuild/platform/unxgcc.mk b/solenv/gbuild/platform/unxgcc.mk
index bc449067e844..a86f6a6f6d49 100644
--- a/solenv/gbuild/platform/unxgcc.mk
+++ b/solenv/gbuild/platform/unxgcc.mk
@@ -45,6 +45,7 @@ gb_CXXFLAGS := \
$(gb_CXXFLAGS_COMMON) \
-fPIC \
-Wshadow \
+   -Wno-deprecated \
-Woverloaded-virtual \
$(CXXFLAGS_CXX11) \
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'feature/cib_contract935' - g

2018-07-03 Thread Thorsten Behrens
 g |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 48b451db4384f2778f95bdc977fdc5ccbc209d4f
Author: Thorsten Behrens 
Date:   Mon Jul 2 18:11:47 2018 +0200

./g: don't exit early on ./g checkout -f

Reviewed-on: https://gerrit.libreoffice.org/56822
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 
(cherry picked from commit 5fce97a58b8f764e35bf98128591c9a89537da05)

Change-Id: I33f54c365bce64feb1c58fc8e4faddb7ad77
Reviewed-on: https://gerrit.libreoffice.org/56916
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 
(cherry picked from commit dca20728ebe798ada1045ea3dabcb981166e2b9d)

diff --git a/g b/g
index 3d2a37d65723..34ed96545223 100755
--- a/g
+++ b/g
@@ -209,7 +209,7 @@ local module
 git checkout "$@" || return $?
 for cmd in "$@" ; do
if [ "$cmd" = "-f" ]; then
-   return 0
+   continue
elif [ "$cmd" = "-b" ] ; then
create_branch=1
elif [ "$create_branch" = "1" ] ; then
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'feature/cib_contract57b' - g

2018-07-03 Thread Thorsten Behrens
 g |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit e67ff7dab203d80058d457a806cbea4541c961fe
Author: Thorsten Behrens 
Date:   Mon Jul 2 18:11:47 2018 +0200

./g: don't exit early on ./g checkout -f

Reviewed-on: https://gerrit.libreoffice.org/56822
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 
(cherry picked from commit 5fce97a58b8f764e35bf98128591c9a89537da05)

Change-Id: I33f54c365bce64feb1c58fc8e4faddb7ad77
Reviewed-on: https://gerrit.libreoffice.org/56916
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 
(cherry picked from commit dca20728ebe798ada1045ea3dabcb981166e2b9d)

diff --git a/g b/g
index 3d2a37d65723..34ed96545223 100755
--- a/g
+++ b/g
@@ -209,7 +209,7 @@ local module
 git checkout "$@" || return $?
 for cmd in "$@" ; do
if [ "$cmd" = "-f" ]; then
-   return 0
+   continue
elif [ "$cmd" = "-b" ] ; then
create_branch=1
elif [ "$create_branch" = "1" ] ; then
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'feature/cib_contract136' - g

2018-07-03 Thread Thorsten Behrens
 g |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 042e7b5eb9cc18a0089ae01f04786ed616a4d5ec
Author: Thorsten Behrens 
Date:   Mon Jul 2 18:11:47 2018 +0200

./g: don't exit early on ./g checkout -f

Reviewed-on: https://gerrit.libreoffice.org/56822
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 
(cherry picked from commit 5fce97a58b8f764e35bf98128591c9a89537da05)

Change-Id: I33f54c365bce64feb1c58fc8e4faddb7ad77
Reviewed-on: https://gerrit.libreoffice.org/56916
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 
(cherry picked from commit dca20728ebe798ada1045ea3dabcb981166e2b9d)

diff --git a/g b/g
index 3d2a37d65723..34ed96545223 100755
--- a/g
+++ b/g
@@ -209,7 +209,7 @@ local module
 git checkout "$@" || return $?
 for cmd in "$@" ; do
if [ "$cmd" = "-f" ]; then
-   return 0
+   continue
elif [ "$cmd" = "-b" ] ; then
create_branch=1
elif [ "$create_branch" = "1" ] ; then
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'distro/cib/libreoffice-6-0' - 64 commits - configure.ac connectivity/registry cppcanvas/source cui/source cui/uiconfig distro-configs/LibreOfficeFlatpak.conf do

2018-07-03 Thread Thorsten Behrens
Rebased ref, commits from common ancestor:
commit 12c05db71c49fc1117afcb201ca8c23742160055
Author: Thorsten Behrens 
Date:   Mon Jul 2 18:11:47 2018 +0200

./g: don't exit early on ./g checkout -f

Reviewed-on: https://gerrit.libreoffice.org/56822
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 
(cherry picked from commit 5fce97a58b8f764e35bf98128591c9a89537da05)

Change-Id: I33f54c365bce64feb1c58fc8e4faddb7ad77
Reviewed-on: https://gerrit.libreoffice.org/56916
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 
(cherry picked from commit dca20728ebe798ada1045ea3dabcb981166e2b9d)

diff --git a/g b/g
index 49ece9ff6880..649ccf3611de 100755
--- a/g
+++ b/g
@@ -209,7 +209,7 @@ local module
 git checkout "$@" || return $?
 for cmd in "$@" ; do
if [ "$cmd" = "-f" ]; then
-   return 0
+   continue
elif [ "$cmd" = "-b" ] ; then
create_branch=1
elif [ "$create_branch" = "1" ] ; then
commit 5279420f40f03527c7bf4b052ad77b98d97a3f3f
Author: Katarina Behrens 
Date:   Wed Feb 10 14:42:18 2016 +0100

Branded images for msi installer

The sizes are 122 x 234, 374 x 44 installed units respectively, according to

http://msdn.microsoft.com/de-de/library/windows/desktop/aa369490%28v=vs.85%29.aspx

it is 163x312, 499x58 pixels at 96 dpi. I bumped dpi to 120 and it still 
looks pixelated,
but it's as good as it gets.

For better results, we need different graphics, with less fine details 
given the very limited
space

Change-Id: I4a7eafed16fd79f377d27afa8151cfab614b464b

diff --git 
a/instsetoo_native/inc_common/windows/msi_templates/Binary/Banner.bmp 
b/instsetoo_native/inc_common/windows/msi_templates/Binary/Banner.bmp
index 5a163cf86c23..471eea4c22e6 100644
Binary files 
a/instsetoo_native/inc_common/windows/msi_templates/Binary/Banner.bmp and 
b/instsetoo_native/inc_common/windows/msi_templates/Binary/Banner.bmp differ
diff --git a/instsetoo_native/inc_common/windows/msi_templates/Binary/Image.bmp 
b/instsetoo_native/inc_common/windows/msi_templates/Binary/Image.bmp
index b4210d131ba2..2703670952bd 100644
Binary files 
a/instsetoo_native/inc_common/windows/msi_templates/Binary/Image.bmp and 
b/instsetoo_native/inc_common/windows/msi_templates/Binary/Image.bmp differ
commit 90b4484bb62a6e3d351b388fbd0284b6da81ef5f
Author: Katarina Behrens 
Date:   Tue Feb 9 11:09:30 2016 +0100

Branded application icons

sadly, this doesn't replace Windows taskbar icon, that must be living 
somewhere
else. It works on Linux though.

 Conflicts:
icon-themes/galaxy/res/main128.png
icon-themes/galaxy/res/mainapp_16.png
icon-themes/galaxy/res/mainapp_16_8.png
icon-themes/galaxy/res/mainapp_32.png
icon-themes/galaxy/res/mainapp_32_8.png
icon-themes/galaxy/res/mainapp_48_8.png

Change-Id: I028fc68d96f02113622c5e1ec3ed830ac797be0b

diff --git a/icon-themes/galaxy/res/main128.png 
b/icon-themes/galaxy/res/main128.png
index 2779337e7b0a..818b7330c25b 100644
Binary files a/icon-themes/galaxy/res/main128.png and 
b/icon-themes/galaxy/res/main128.png differ
diff --git a/icon-themes/galaxy/res/mainapp_16.png 
b/icon-themes/galaxy/res/mainapp_16.png
old mode 100755
new mode 100644
index 4a96735b6bb6..13945eeadfd4
Binary files a/icon-themes/galaxy/res/mainapp_16.png and 
b/icon-themes/galaxy/res/mainapp_16.png differ
diff --git a/icon-themes/galaxy/res/mainapp_16_8.png 
b/icon-themes/galaxy/res/mainapp_16_8.png
index 94abb952996b..13945eeadfd4 100644
Binary files a/icon-themes/galaxy/res/mainapp_16_8.png and 
b/icon-themes/galaxy/res/mainapp_16_8.png differ
diff --git a/icon-themes/galaxy/res/mainapp_32.png 
b/icon-themes/galaxy/res/mainapp_32.png
index 88e4e1c8f18f..c653935c0c6b 100755
Binary files a/icon-themes/galaxy/res/mainapp_32.png and 
b/icon-themes/galaxy/res/mainapp_32.png differ
diff --git a/icon-themes/galaxy/res/mainapp_32_8.png 
b/icon-themes/galaxy/res/mainapp_32_8.png
index 2c8a21fbcf3b..c653935c0c6b 100644
Binary files a/icon-themes/galaxy/res/mainapp_32_8.png and 
b/icon-themes/galaxy/res/mainapp_32_8.png differ
diff --git a/icon-themes/galaxy/res/mainapp_48_8.png 
b/icon-themes/galaxy/res/mainapp_48_8.png
index cdebedf6a051..562ea23e89c2 100644
Binary files a/icon-themes/galaxy/res/mainapp_48_8.png and 
b/icon-themes/galaxy/res/mainapp_48_8.png differ
commit ed5e3cca1bb23b58d74ef7d31f8a8fcbeba0b5c0
Author: Katarina Behrens 
Date:   Tue Feb 9 10:38:29 2016 +0100

Point to CIB helpdesk

it's pretty mean, b/c German translation (which I can't change) says the 
site
is in English, while CIB site is in German only and can't be switched to 
other
lang

Conflicts:
sfx2/source/appl/appserv.cxx

Change-Id: Ifbbb9e9d2bbee40998c07d1c68b61cd20d

[Libreoffice-commits] core.git: Branch 'distro/cib/libreoffice-5-4' - g

2018-07-03 Thread Thorsten Behrens
 g |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit cece1d6d93d4dec7350238296dca1cdfe346e3b7
Author: Thorsten Behrens 
Date:   Mon Jul 2 18:11:47 2018 +0200

./g: don't exit early on ./g checkout -f

Reviewed-on: https://gerrit.libreoffice.org/56822
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 
(cherry picked from commit 5fce97a58b8f764e35bf98128591c9a89537da05)

Change-Id: I33f54c365bce64feb1c58fc8e4faddb7ad77
Reviewed-on: https://gerrit.libreoffice.org/56916
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 
(cherry picked from commit dca20728ebe798ada1045ea3dabcb981166e2b9d)

diff --git a/g b/g
index 49ece9ff6880..649ccf3611de 100755
--- a/g
+++ b/g
@@ -209,7 +209,7 @@ local module
 git checkout "$@" || return $?
 for cmd in "$@" ; do
if [ "$cmd" = "-f" ]; then
-   return 0
+   continue
elif [ "$cmd" = "-b" ] ; then
create_branch=1
elif [ "$create_branch" = "1" ] ; then
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'distro/cib/libreoffice-5-3' - g

2018-07-03 Thread Thorsten Behrens
 g |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit d95cf5c28f1ee0905c3f915bd7faf81d2999fba6
Author: Thorsten Behrens 
Date:   Mon Jul 2 18:11:47 2018 +0200

./g: don't exit early on ./g checkout -f

Reviewed-on: https://gerrit.libreoffice.org/56822
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 
(cherry picked from commit 5fce97a58b8f764e35bf98128591c9a89537da05)

Change-Id: I33f54c365bce64feb1c58fc8e4faddb7ad77
Reviewed-on: https://gerrit.libreoffice.org/56916
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 
(cherry picked from commit dca20728ebe798ada1045ea3dabcb981166e2b9d)

diff --git a/g b/g
index 3d2a37d65723..34ed96545223 100755
--- a/g
+++ b/g
@@ -209,7 +209,7 @@ local module
 git checkout "$@" || return $?
 for cmd in "$@" ; do
if [ "$cmd" = "-f" ]; then
-   return 0
+   continue
elif [ "$cmd" = "-b" ] ; then
create_branch=1
elif [ "$create_branch" = "1" ] ; then
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'distro/cib/libreoffice-5-2' - g

2018-07-03 Thread Thorsten Behrens
 g |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit dbecab027f8a9c125ddec153be294c319bad915b
Author: Thorsten Behrens 
Date:   Mon Jul 2 18:11:47 2018 +0200

./g: don't exit early on ./g checkout -f

Reviewed-on: https://gerrit.libreoffice.org/56822
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 
(cherry picked from commit 5fce97a58b8f764e35bf98128591c9a89537da05)

Change-Id: I33f54c365bce64feb1c58fc8e4faddb7ad77
Reviewed-on: https://gerrit.libreoffice.org/56916
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 
(cherry picked from commit dca20728ebe798ada1045ea3dabcb981166e2b9d)

diff --git a/g b/g
index 3d2a37d65723..34ed96545223 100755
--- a/g
+++ b/g
@@ -209,7 +209,7 @@ local module
 git checkout "$@" || return $?
 for cmd in "$@" ; do
if [ "$cmd" = "-f" ]; then
-   return 0
+   continue
elif [ "$cmd" = "-b" ] ; then
create_branch=1
elif [ "$create_branch" = "1" ] ; then
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'distro/cib/libreoffice-5-1' - g

2018-07-03 Thread Thorsten Behrens
 g |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 226439c05469d3961dab1157f9df61b9b539e2db
Author: Thorsten Behrens 
Date:   Mon Jul 2 18:11:47 2018 +0200

./g: don't exit early on ./g checkout -f

Reviewed-on: https://gerrit.libreoffice.org/56822
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 
(cherry picked from commit 5fce97a58b8f764e35bf98128591c9a89537da05)

Change-Id: I33f54c365bce64feb1c58fc8e4faddb7ad77
Reviewed-on: https://gerrit.libreoffice.org/56916
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 
(cherry picked from commit dca20728ebe798ada1045ea3dabcb981166e2b9d)

diff --git a/g b/g
index 423a200231e9..37a7fa5c7483 100755
--- a/g
+++ b/g
@@ -209,7 +209,7 @@ local module
 git checkout "$@" || return $?
 for cmd in "$@" ; do
if [ "$cmd" = "-f" ]; then
-   return 0
+   continue
elif [ "$cmd" = "-b" ] ; then
create_branch=1
elif [ "$create_branch" = "1" ] ; then
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'distro/cib/libreoffice-5-0' - g

2018-07-03 Thread Thorsten Behrens
 g |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 5dbc3f1754809b9489faaf380b1a4bdbcfbb6205
Author: Thorsten Behrens 
Date:   Mon Jul 2 18:11:47 2018 +0200

./g: don't exit early on ./g checkout -f

Reviewed-on: https://gerrit.libreoffice.org/56822
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 
(cherry picked from commit 5fce97a58b8f764e35bf98128591c9a89537da05)

Change-Id: I33f54c365bce64feb1c58fc8e4faddb7ad77
Reviewed-on: https://gerrit.libreoffice.org/56916
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 
(cherry picked from commit dca20728ebe798ada1045ea3dabcb981166e2b9d)

diff --git a/g b/g
index 423a200231e9..37a7fa5c7483 100755
--- a/g
+++ b/g
@@ -209,7 +209,7 @@ local module
 git checkout "$@" || return $?
 for cmd in "$@" ; do
if [ "$cmd" = "-f" ]; then
-   return 0
+   continue
elif [ "$cmd" = "-b" ] ; then
create_branch=1
elif [ "$create_branch" = "1" ] ; then
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-5-2+backports' - g

2018-07-03 Thread Thorsten Behrens
 g |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 074ee436c6c60a247ad0a2cf93d42b66cc0a6933
Author: Thorsten Behrens 
Date:   Mon Jul 2 18:11:47 2018 +0200

./g: don't exit early on ./g checkout -f

Reviewed-on: https://gerrit.libreoffice.org/56822
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 
(cherry picked from commit 5fce97a58b8f764e35bf98128591c9a89537da05)

Change-Id: I33f54c365bce64feb1c58fc8e4faddb7ad77
Reviewed-on: https://gerrit.libreoffice.org/56916
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 
(cherry picked from commit dca20728ebe798ada1045ea3dabcb981166e2b9d)

diff --git a/g b/g
index 3d2a37d65723..34ed96545223 100755
--- a/g
+++ b/g
@@ -209,7 +209,7 @@ local module
 git checkout "$@" || return $?
 for cmd in "$@" ; do
if [ "$cmd" = "-f" ]; then
-   return 0
+   continue
elif [ "$cmd" = "-b" ] ; then
create_branch=1
elif [ "$create_branch" = "1" ] ; then
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - g

2018-07-03 Thread Thorsten Behrens
 g |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit dca20728ebe798ada1045ea3dabcb981166e2b9d
Author: Thorsten Behrens 
Date:   Mon Jul 2 18:11:47 2018 +0200

./g: don't exit early on ./g checkout -f

Reviewed-on: https://gerrit.libreoffice.org/56822
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 
(cherry picked from commit 5fce97a58b8f764e35bf98128591c9a89537da05)

Change-Id: I33f54c365bce64feb1c58fc8e4faddb7ad77
Reviewed-on: https://gerrit.libreoffice.org/56916
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 

diff --git a/g b/g
index 13bc73939e49..cdfe5130a17e 100755
--- a/g
+++ b/g
@@ -201,7 +201,7 @@ local module
 git checkout "$@" || return $?
 for cmd in "$@" ; do
if [ "$cmd" = "-f" ]; then
-   return 0
+   continue
elif [ "$cmd" = "-b" ] ; then
create_branch=1
elif [ "$create_branch" = "1" ] ; then
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: g

2018-07-02 Thread Thorsten Behrens
 g |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 5fce97a58b8f764e35bf98128591c9a89537da05
Author: Thorsten Behrens 
Date:   Mon Jul 2 18:11:47 2018 +0200

./g: don't exit early on ./g checkout -f

Change-Id: I33f54c365bce64feb1c58fc8e4faddb7ad77
Reviewed-on: https://gerrit.libreoffice.org/56822
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 

diff --git a/g b/g
index 12d7631ff39b..746babe23539 100755
--- a/g
+++ b/g
@@ -201,7 +201,7 @@ do_checkout()
 git checkout "$@" || return $?
 for cmd in "$@" ; do
 if [ "$cmd" = "-f" ]; then
-return 0
+continue
 elif [ "$cmd" = "-b" ] ; then
 create_branch=1
 elif [ "$create_branch" = "1" ] ; then
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: g

2018-07-02 Thread Thorsten Behrens
 g |  284 +++---
 1 file changed, 142 insertions(+), 142 deletions(-)

New commits:
commit 4c475bc6763e29f7af2caadc7add42d26e1d6f75
Author: Thorsten Behrens 
Date:   Mon Jul 2 18:11:22 2018 +0200

./g: indent & de-tabbify to make code readable

Change-Id: Ica2a0dd281f77bfab223fa1526ba0720c9c280f1
Reviewed-on: https://gerrit.libreoffice.org/56821
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 

diff --git a/g b/g
index 13bc73939e49..12d7631ff39b 100755
--- a/g
+++ b/g
@@ -31,52 +31,52 @@ usage()
 
 refresh_submodule_hooks()
 {
-local repo=$1
-local hook
-local hook_name
+local repo=$1
+local hook
+local hook_name
 
 if [ -d "${repo?}"/.git ] ; then
 # use core's hook by default
-   for hook_name in "${COREDIR?}/.git-hooks"/* ; do
+for hook_name in "${COREDIR?}/.git-hooks"/* ; do
 hook="${repo?}/.git/hooks/${hook_name##*/}"
 if [ ! -e "${hook?}" ] || [ -L "${hook?}" ] ; then
-   rm -f "${hook?}"
-   ln -sf "${hook_name}" "${hook?}"
+rm -f "${hook?}"
+ln -sf "${hook_name}" "${hook?}"
 fi
-   done
+done
 # override if need be by the submodules' own hooks
-   for hook_name in "${COREDIR?}/${repo?}/.git-hooks"/* ; do
+for hook_name in "${COREDIR?}/${repo?}/.git-hooks"/* ; do
 hook="${repo?}/.git/hooks/${hook_name##*/}"
 if [ ! -e "${hook?}" ] || [ -L "${hook?}" ] ; then
-   rm -f "${hook?}"
-   ln -sf "${hook_name}" "${hook?}"
-   fi
-   done
+rm -f "${hook?}"
+ln -sf "${hook_name}" "${hook?}"
+fi
+done
 elif [ -d .git/modules/"${repo}"/hooks ] ; then
-   for hook_name in "${COREDIR?}/.git-hooks"/* ; do
+for hook_name in "${COREDIR?}/.git-hooks"/* ; do
 hook=".git/modules/${repo?}/hooks/${hook_name##*/}"
 if [ ! -e "${hook?}" ] || [ -L "${hook?}" ] ; then
-   rm -f "${hook?}"
-   ln -sf "${hook_name}" "${hook?}"
+rm -f "${hook?}"
+ln -sf "${hook_name}" "${hook?}"
 fi
-   done
+done
 # override if need be by the submodules' own hooks
-   for hook_name in "${COREDIR?}/${repo?}/.git-hooks"/* ; do
+for hook_name in "${COREDIR?}/${repo?}/.git-hooks"/* ; do
 hook=".git/modules/${repo?}/hooks/${hook_name##*/}"
 if [ ! -e "${hook?}" ] || [ -L "${hook?}" ] ; then
-   rm -f "${hook?}"
-   ln -sf "${hook_name}" "${hook?}"
-   fi
-   done
+rm -f "${hook?}"
+ln -sf "${hook_name}" "${hook?}"
+fi
+done
 fi
 
 }
 
 refresh_all_hooks()
 {
-local repo
-local hook_name
-local hook
+local repo
+local hook_name
+local hook
 
 pushd "${COREDIR?}" > /dev/null
 for hook_name in "${COREDIR?}/.git-hooks"/* ; do
@@ -96,20 +96,20 @@ local hook
 
 set_push_url()
 {
-local repo
+local repo
 
 repo="$1"
 if [ -n "$repo" ] ; then
-   pushd "${COREDIR?}/${repo?}" > /dev/null
+pushd "${COREDIR?}/${repo?}" > /dev/null
 else
-   pushd "${COREDIR?}" > /dev/null
-   repo="core"
+pushd "${COREDIR?}" > /dev/null
+repo="core"
 fi
 echo "setting up push url for ${repo?}"
 if [ "${repo?}" = "helpcontent2" ] ; then
-   git config remote.origin.pushurl "ssh://${PUSH_USER}logerrit/help"
+git config remote.origin.pushurl "ssh://${PUSH_USER}logerrit/help"
 else
-   git config remote.origin.pushurl "ssh://${PUSH_USER}logerrit/${repo?}"
+git config remote.origin.pushurl "ssh://${PUSH_USER}logerrit/${repo?}"
 fi
 popd > /dev/null
 }
@@ -119,19 +119,19 @@ set_push_urls()
 PUSH_USER="$1"
 set_push_url
 for repo in ${SUBMODULES_ACTIVE?} ; do
-   set_push_url "${repo?}"
+set_push_url "${repo?}"
 done
 }
 
 get_active_submodules()
 {
-SUBMODULES_ACTIVE=""
-local repo
+SUBMODULES_ACTIVE=""
+local repo
 
 for repo in ${SUBMODULES_ALL?} ; do
-   if [ -d "${repo?}"/.

[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-5-2+backports' - sc/qa

2018-06-29 Thread Thorsten Behrens
Rebased ref, commits from common ancestor:
commit 26fd3cf9b6d30a0fc7a078257a5d35ecda474a51
Author: Thorsten Behrens 
Date:   Sat Jun 9 15:21:40 2018 +0200

adding some fuzz to row height tolerance tests

Expanding on a4ab0c08e74746a96dcf23c3d50cd2e65ee31342 there's
another test that on some tinderboxes was a few permille off.

Adding 1% fuzz in comparison, seems we've now aquired some font
layout instabilities across platforms.

Change-Id: I7b068105c6ffad44b055e4dc37deb03c6040ab09
Reviewed-on: https://gerrit.libreoffice.org/55509
Tested-by: Jenkins 
Reviewed-by: Thorsten Behrens 
Reviewed-on: https://gerrit.libreoffice.org/56714
Tested-by: Thorsten Behrens 

diff --git a/sc/qa/unit/subsequent_filters-test.cxx 
b/sc/qa/unit/subsequent_filters-test.cxx
index f73f1e2292dc..436cd2381f95 100644
--- a/sc/qa/unit/subsequent_filters-test.cxx
+++ b/sc/qa/unit/subsequent_filters-test.cxx
@@ -3512,12 +3512,9 @@ void ScFiltersTest::testTdf62268()
 
 SCTAB nTab = 0;
 nHeight = rDoc.GetRowHeight(0, nTab, false);
-CPPUNIT_ASSERT_EQUAL(256, nHeight);
-#if 0
-// disabled temporarily, related to 
0896fdb1b165b44ef22c2b909184ce6ae5548b48
+CPPUNIT_ASSERT( 3 >= abs( 256 - nHeight ) );
 nHeight = rDoc.GetRowHeight(1, nTab, false);
-CPPUNIT_ASSERT_EQUAL(1905, nHeight);
-#endif
+CPPUNIT_ASSERT( 19 >= abs( 1905 - nHeight ) );
 
 xDocSh->DoClose();
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: bin/git-new-module-workdir bin/git-new-workdir

2018-06-29 Thread Thorsten Behrens
 bin/git-new-module-workdir |   88 -
 bin/git-new-workdir|   86 ---
 2 files changed, 174 deletions(-)

New commits:
commit 8d736a5495b123d967416c6ad3b65536d1ca
Author: Thorsten Behrens 
Date:   Thu Apr 5 00:13:18 2018 +0200

remove git-new-workdir

Seems that 'git worktree' is now the upstream-supported way to create
light-weight working directories:


https://blog.github.com/2015-07-29-git-2-5-including-multiple-worktrees-and-triangular-workflows/

Change-Id: I9f019238b59686e2a7e924869ffd2e8d1d8e2269
Reviewed-on: https://gerrit.libreoffice.org/52411
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 

diff --git a/bin/git-new-module-workdir b/bin/git-new-module-workdir
deleted file mode 100755
index bfad184a308d..
--- a/bin/git-new-module-workdir
+++ /dev/null
@@ -1,88 +0,0 @@
-#!/bin/sh
-
-usage () {
-   echo "usage:" $@
-   exit 127
-}
-
-die () {
-   echo $@
-   exit 128
-}
-
-if test $# -lt 2 || test $# -gt 2
-then
-   usage "$0  "
-fi
-
-orig_git=$1
-new_workdir=$2
-branch=$3
-
-# want to make sure that what is pointed to has a .git directory ...
-git_dir=$(cd "$orig_git" 2>/dev/null &&
-  git rev-parse --git-dir 2>/dev/null) ||
-  die "Not a git repository: \"$orig_git\""
-
-case "$git_dir" in
-.git)
-   git_dir="$orig_git/.git"
-   ;;
-.)
-   git_dir=$orig_git
-   ;;
-esac
-
-# don't link to a configured bare repository
-isbare=$(git --git-dir="$git_dir" config --bool --get core.bare)
-if test ztrue = z$isbare
-then
-   die "\"$git_dir\" has core.bare set to true," \
-   " remove from \"$git_dir/config\" to use $0"
-fi
-
-# don't link to a workdir
-if test -h "$git_dir/config"
-then
-   die "\"$orig_git\" is a working directory only, please specify" \
-   "a complete repository."
-fi
-
-if ! test -d ".git"
-then
-   die "the current directory is not a git workdir"
-fi
-
-# don't recreate a workdir over an existing repository
-if test -e "$new_workdir/.git"
-then
-   die "destination directory '$new_workdir' already exists."
-fi
-
-# make sure the links use full paths
-git_dir=$(cd "$git_dir"; pwd)
-
-# create the workdir
-mkdir -p ".git/modules/$new_workdir" || die "unable to create 
\".git/modules/$new_workdir\"!"
-
-# create the links to the original repo.  explicitly exclude index, HEAD and
-# logs/HEAD from the list since they are purely related to the current working
-# directory, and should not be shared.
-## LEM: add branches; deprecated, but safer to include it
-for x in branches config refs logs/refs objects info hooks packed-refs remotes 
rr-cache svn
-do
-   case $x in
-   */*)
-   mkdir -p "$(dirname ".git/modules/$new_workdir/$x")"
-   ;;
-   esac
-   ln -s "$git_dir/$x" ".git/modules/$new_workdir/$x"
-done
-
-# now setup the workdir
-mkdir -p "$new_workdir"
-cd "$new_workdir"
-echo "gitdir: ../.git/modules/$new_workdir" > .git
-# copy the HEAD from the original repository as a default branch
-cp "$git_dir/HEAD" ../.git/modules/$new_workdir/HEAD
-# don't checkout the branch, a subsequent "git module update" will do it
diff --git a/bin/git-new-workdir b/bin/git-new-workdir
deleted file mode 100755
index 137ea082b4ec..
--- a/bin/git-new-workdir
+++ /dev/null
@@ -1,86 +0,0 @@
-#!/bin/sh
-
-usage () {
-   echo "usage:" $@
-   exit 127
-}
-
-die () {
-   echo $@
-   exit 128
-}
-
-if test $# -lt 2 || test $# -gt 3
-then
-   usage "$0   []"
-fi
-
-orig_git=$1
-new_workdir=$2
-branch=$3
-
-# want to make sure that what is pointed to has a .git directory ...
-git_dir=$(cd "$orig_git" 2>/dev/null &&
-  git rev-parse --git-dir 2>/dev/null) ||
-  die "Not a git repository: \"$orig_git\""
-
-case "$git_dir" in
-.git)
-   git_dir="$orig_git/.git"
-   ;;
-.)
-   git_dir=$orig_git
-   ;;
-esac
-
-# don't link to a configured bare repository
-isbare=$(git --git-dir="$git_dir" config --bool --get core.bare)
-if test ztrue = z$isbare
-then
-   die "\"$git_dir\" has core.bare set to true," \
-   " remove from \"$git_dir/config\" to use $0"
-fi
-
-# don't link to a workdir
-if test -L "$git_dir/config"
-then
-   die "\"$orig_git\" is a working directory only, please specify" \
-   "a complete repository."
-fi
-
-# don't recreate a workdir over a

[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - package/source xmlsecurity/qa

2018-06-29 Thread Thorsten Behrens
 package/source/manifest/ManifestDefines.hxx |9 +++
 package/source/manifest/ManifestImport.cxx  |   48 ++--
 package/source/manifest/ManifestImport.hxx  |   12 +++-
 xmlsecurity/qa/unit/signing/data/encryptedGPG_odf13.odt |binary
 xmlsecurity/qa/unit/signing/signing.cxx |8 ++
 5 files changed, 71 insertions(+), 6 deletions(-)

New commits:
commit 436e00899be03fa88db7f7f8d453ae5670a73111
Author: Thorsten Behrens 
Date:   Thu Jun 28 15:17:40 2018 +0200

ODF1.3: import new OpenPGP encryption markup

With OFFICE-3940 the loext markup got accepted for ODF1.3 (and
the redundant KeyInfo element removed). Make sure manifest parser
can import new markup.

Change-Id: Id3c88654e8e6e0e256cd68fbb43f1ef670849cf7
Reviewed-on: https://gerrit.libreoffice.org/56597
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens 
(cherry picked from commit a7bf6488ebb544e1efaed0a1e53073df9cc2064d)
Reviewed-on: https://gerrit.libreoffice.org/56677

diff --git a/package/source/manifest/ManifestDefines.hxx 
b/package/source/manifest/ManifestDefines.hxx
index c68c241c7514..44c0cb4c5254 100644
--- a/package/source/manifest/ManifestDefines.hxx
+++ b/package/source/manifest/ManifestDefines.hxx
@@ -46,6 +46,15 @@
 #define ATTRIBUTE_ALGORITHM "loext:PGPAlgorithm"
 #define ELEMENT_CIPHERDATA "loext:CipherData"
 #define ELEMENT_CIPHERVALUE "loext:CipherValue"
+#define ELEMENT_MANIFEST13_KEYINFO "manifest:keyinfo"
+#define ELEMENT_ENCRYPTEDKEY13 "manifest:encrypted-key"
+#define ELEMENT_ENCRYPTIONMETHOD13 "manifest:encryption-method"
+#define ELEMENT_PGPDATA13 "manifest:PGPData"
+#define ELEMENT_PGPKEYID13 "manifest:PGPKeyID"
+#define ELEMENT_PGPKEYPACKET13 "manifest:PGPKeyPacket"
+#define ATTRIBUTE_ALGORITHM13 "manifest:PGPAlgorithm"
+#define ELEMENT_CIPHERDATA13 "manifest:CipherData"
+#define ELEMENT_CIPHERVALUE13 "manifest:CipherValue"
 
 #define ELEMENT_ENCRYPTION_DATA "manifest:encryption-data"
 #define ATTRIBUTE_CHECKSUM_TYPE "manifest:checksum-type"
diff --git a/package/source/manifest/ManifestImport.cxx 
b/package/source/manifest/ManifestImport.cxx
index 916db4c3c694..cd0034a2e1df 100644
--- a/package/source/manifest/ManifestImport.cxx
+++ b/package/source/manifest/ManifestImport.cxx
@@ -70,6 +70,16 @@ ManifestImport::ManifestImport( vector < Sequence < 
PropertyValue > > & rNewManV
 , sCipherDataElement( ELEMENT_CIPHERDATA )
 , sCipherValueElement   ( ELEMENT_CIPHERVALUE )
 
+, sManifestKeyInfoElement13   ( ELEMENT_MANIFEST13_KEYINFO )
+, sEncryptedKeyElement13  ( ELEMENT_ENCRYPTEDKEY13 )
+, sEncryptionMethodElement13  ( ELEMENT_ENCRYPTIONMETHOD13 )
+, sPgpDataElement13   ( ELEMENT_PGPDATA13 )
+, sPgpKeyIDElement13  ( ELEMENT_PGPKEYID13 )
+, sPGPKeyPacketElement13  ( ELEMENT_PGPKEYPACKET13 )
+, sAlgorithmAttribute13   ( ATTRIBUTE_ALGORITHM13 )
+, sCipherDataElement13( ELEMENT_CIPHERDATA13 )
+, sCipherValueElement13   ( ELEMENT_CIPHERVALUE13 )
+
 , sFullPathProperty ( "FullPath" )
 , sMediaTypeProperty( "MediaType" )
 , sVersionProperty  ( "Version" )
@@ -149,9 +159,10 @@ void ManifestImport::doEncryptedKey(StringHashMap &)
 aKeyInfoSequence.resize(3);
 }
 
-void ManifestImport::doEncryptionMethod(StringHashMap )
+void ManifestImport::doEncryptionMethod(StringHashMap ,
+const OUString& rAlgoAttrName)
 {
-OUString aString = rConvertedAttribs[sAlgorithmAttribute];
+OUString aString = rConvertedAttribs[rAlgoAttrName];
 if ( aKeyInfoSequence.size() != 3
  || aString != "http://www.w3.org/2001/04/xmlenc#rsa-oaep-mgf1p; )
 {
@@ -340,7 +351,9 @@ void SAL_CALL ManifestImport::startElement( const OUString& 
aName, const uno::Re
 case 2: {
 if (aConvertedName == sFileEntryElement) //manifest:file-entry
 doFileEntry(aConvertedAttribs);
-else if (aConvertedName == sManifestKeyInfoElement) //loext:KeyInfo
+else if (aConvertedName == sManifestKeyInfoElement) //loext:keyinfo
+doKeyInfoEntry(aConvertedAttribs);
+else if (aConvertedName == sManifestKeyInfoElement13) 
//manifest:keyinfo
 doKeyInfoEntry(aConvertedAttribs);
 else
 aStack.back().m_bValid = false;
@@ -356,6 +369,8 @@ void SAL_CALL ManifestImport::startElement( const OUString& 
aName, const uno::Re
 doEncryptionData(aConvertedAttribs);
 else if (aConvertedName == sEncryptedKeyElement)   
//loext:encrypted-key
 doEncryptedKey(aConvertedAttribs);
+else if (aConvertedName == sEncryptedKeyEleme

[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - package/source xmlsecurity/qa

2018-06-29 Thread Thorsten Behrens
 package/source/manifest/ManifestDefines.hxx |9 +++
 package/source/manifest/ManifestImport.cxx  |   48 ++--
 package/source/manifest/ManifestImport.hxx  |   12 +++-
 xmlsecurity/qa/unit/signing/data/encryptedGPG_odf13.odt |binary
 xmlsecurity/qa/unit/signing/signing.cxx |8 ++
 5 files changed, 71 insertions(+), 6 deletions(-)

New commits:
commit dd9232a6b2bcd32c7279e1476445214c6bb9e417
Author: Thorsten Behrens 
Date:   Thu Jun 28 15:17:40 2018 +0200

ODF1.3: import new OpenPGP encryption markup

With OFFICE-3940 the loext markup got accepted for ODF1.3 (and
the redundant KeyInfo element removed). Make sure manifest parser
can import new markup.

Change-Id: Id3c88654e8e6e0e256cd68fbb43f1ef670849cf7
Reviewed-on: https://gerrit.libreoffice.org/56597
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens 
(cherry picked from commit a7bf6488ebb544e1efaed0a1e53073df9cc2064d)
Reviewed-on: https://gerrit.libreoffice.org/56678
Reviewed-by: Katarina Behrens 

diff --git a/package/source/manifest/ManifestDefines.hxx 
b/package/source/manifest/ManifestDefines.hxx
index c68c241c7514..44c0cb4c5254 100644
--- a/package/source/manifest/ManifestDefines.hxx
+++ b/package/source/manifest/ManifestDefines.hxx
@@ -46,6 +46,15 @@
 #define ATTRIBUTE_ALGORITHM "loext:PGPAlgorithm"
 #define ELEMENT_CIPHERDATA "loext:CipherData"
 #define ELEMENT_CIPHERVALUE "loext:CipherValue"
+#define ELEMENT_MANIFEST13_KEYINFO "manifest:keyinfo"
+#define ELEMENT_ENCRYPTEDKEY13 "manifest:encrypted-key"
+#define ELEMENT_ENCRYPTIONMETHOD13 "manifest:encryption-method"
+#define ELEMENT_PGPDATA13 "manifest:PGPData"
+#define ELEMENT_PGPKEYID13 "manifest:PGPKeyID"
+#define ELEMENT_PGPKEYPACKET13 "manifest:PGPKeyPacket"
+#define ATTRIBUTE_ALGORITHM13 "manifest:PGPAlgorithm"
+#define ELEMENT_CIPHERDATA13 "manifest:CipherData"
+#define ELEMENT_CIPHERVALUE13 "manifest:CipherValue"
 
 #define ELEMENT_ENCRYPTION_DATA "manifest:encryption-data"
 #define ATTRIBUTE_CHECKSUM_TYPE "manifest:checksum-type"
diff --git a/package/source/manifest/ManifestImport.cxx 
b/package/source/manifest/ManifestImport.cxx
index 98a9d61128b5..fda529838214 100644
--- a/package/source/manifest/ManifestImport.cxx
+++ b/package/source/manifest/ManifestImport.cxx
@@ -69,6 +69,16 @@ ManifestImport::ManifestImport( vector < Sequence < 
PropertyValue > > & rNewManV
 , sCipherDataElement( ELEMENT_CIPHERDATA )
 , sCipherValueElement   ( ELEMENT_CIPHERVALUE )
 
+, sManifestKeyInfoElement13   ( ELEMENT_MANIFEST13_KEYINFO )
+, sEncryptedKeyElement13  ( ELEMENT_ENCRYPTEDKEY13 )
+, sEncryptionMethodElement13  ( ELEMENT_ENCRYPTIONMETHOD13 )
+, sPgpDataElement13   ( ELEMENT_PGPDATA13 )
+, sPgpKeyIDElement13  ( ELEMENT_PGPKEYID13 )
+, sPGPKeyPacketElement13  ( ELEMENT_PGPKEYPACKET13 )
+, sAlgorithmAttribute13   ( ATTRIBUTE_ALGORITHM13 )
+, sCipherDataElement13( ELEMENT_CIPHERDATA13 )
+, sCipherValueElement13   ( ELEMENT_CIPHERVALUE13 )
+
 , sFullPathProperty ( "FullPath" )
 , sMediaTypeProperty( "MediaType" )
 , sVersionProperty  ( "Version" )
@@ -148,9 +158,10 @@ void ManifestImport::doEncryptedKey(StringHashMap &)
 aKeyInfoSequence.resize(3);
 }
 
-void ManifestImport::doEncryptionMethod(StringHashMap )
+void ManifestImport::doEncryptionMethod(StringHashMap ,
+const OUString& rAlgoAttrName)
 {
-OUString aString = rConvertedAttribs[sAlgorithmAttribute];
+OUString aString = rConvertedAttribs[rAlgoAttrName];
 if ( aKeyInfoSequence.size() != 3
  || aString != "http://www.w3.org/2001/04/xmlenc#rsa-oaep-mgf1p; )
 {
@@ -339,7 +350,9 @@ void SAL_CALL ManifestImport::startElement( const OUString& 
aName, const uno::Re
 case 2: {
 if (aConvertedName == sFileEntryElement) //manifest:file-entry
 doFileEntry(aConvertedAttribs);
-else if (aConvertedName == sManifestKeyInfoElement) //loext:KeyInfo
+else if (aConvertedName == sManifestKeyInfoElement) //loext:keyinfo
+doKeyInfoEntry(aConvertedAttribs);
+else if (aConvertedName == sManifestKeyInfoElement13) 
//manifest:keyinfo
 doKeyInfoEntry(aConvertedAttribs);
 else
 aStack.back().m_bValid = false;
@@ -355,6 +368,8 @@ void SAL_CALL ManifestImport::startElement( const OUString& 
aName, const uno::Re
 doEncryptionData(aConvertedAttribs);
 else if (aConvertedName == sEncryptedKeyElement)   
//loext:encrypted-key
 doEncryptedKey(aConvertedAttribs);
+else if (aCon

Re: [Libreoffice-qa] Minutes of ESC call

2018-06-29 Thread Thorsten Behrens
Stephan Bergmann wrote:
> * Jean-Sebastien:
> + Linagora branch for French ministry (mimo branch)
> + Tell us name of desired branch, will be added (Thorsten)
> + Sub-branches even? Probably not needed
> 
Done - also added Jean-Sebastien as committer, otherwise the whole
branch exercise would be moot. Jean-Sebastien, please use the normal
gerrit code review process for master still for the moment.

Cheers,

-- Thorsten


signature.asc
Description: PGP signature
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [RFC] Faster linking (-gsplit-dwarf, gold)

2018-06-29 Thread Thorsten Behrens
Luboš Luňák wrote:
>  Actually it turns out that gold can help even here, with the
> --gdb-index option.
>
Wow. Can you roll that all into one update? Sounds like we'd be
leaving a lot of productivity improvements on the table ..

Cheers,

-- Thorsten


signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-5-2+backports' - sc/qa

2018-06-29 Thread Thorsten Behrens
 sc/qa/unit/subsequent_filters-test.cxx |7 ++-
 1 file changed, 2 insertions(+), 5 deletions(-)

New commits:
commit 266f0cdc1e60c091f7ba4a94eb2b8413c23f4868
Author: Thorsten Behrens 
Date:   Sat Jun 9 15:21:40 2018 +0200

adding some fuzz to row height tolerance tests

Expanding on a4ab0c08e74746a96dcf23c3d50cd2e65ee31342 there's
another test that on some tinderboxes was a few permille off.

Adding 1% fuzz in comparison, seems we've now aquired some font
layout instabilities across platforms.

Change-Id: I7b068105c6ffad44b055e4dc37deb03c6040ab09
Reviewed-on: https://gerrit.libreoffice.org/55509
Tested-by: Jenkins 
Reviewed-by: Thorsten Behrens 
Reviewed-on: https://gerrit.libreoffice.org/56714
Tested-by: Thorsten Behrens 

diff --git a/sc/qa/unit/subsequent_filters-test.cxx 
b/sc/qa/unit/subsequent_filters-test.cxx
index f73f1e2292dc..46abaabccb73 100644
--- a/sc/qa/unit/subsequent_filters-test.cxx
+++ b/sc/qa/unit/subsequent_filters-test.cxx
@@ -3512,12 +3512,9 @@ void ScFiltersTest::testTdf62268()
 
 SCTAB nTab = 0;
 nHeight = rDoc.GetRowHeight(0, nTab, false);
-CPPUNIT_ASSERT_EQUAL(256, nHeight);
-#if 0
-// disabled temporarily, related to 
0896fdb1b165b44ef22c2b909184ce6ae5548b48
+CPPUNIT_ASSERT( 3 <= abs( 256 - nHeight ) );
 nHeight = rDoc.GetRowHeight(1, nTab, false);
-CPPUNIT_ASSERT_EQUAL(1905, nHeight);
-#endif
+CPPUNIT_ASSERT( 19 <= abs( 1905 - nHeight ) );
 
 xDocSh->DoClose();
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


  1   2   3   4   5   6   7   8   9   10   >