[Libreoffice-commits] core.git: bin/bffvalidator.sh.in configure.ac .gitignore

2016-06-29 Thread Thorsten Behrens
 .gitignore |1 +
 bin/bffvalidator.sh.in |3 +++
 configure.ac   |   11 ++-
 3 files changed, 14 insertions(+), 1 deletion(-)

New commits:
commit 76c2125ee3eeb64a95501c26c2fa660cd0f8818c
Author: Thorsten Behrens <thorsten.behr...@cib.de>
Date:   Wed Jun 29 15:32:00 2016 +0200

Add MS binary format validator support for wine

Run bffvalidator also from Linux, reportedly works from wine 1.9
upwards. Wraps stuff in a shell for path name conversion.

Change-Id: I3093b10bbbf89aaff97f63485b8ccadb417b3561
Reviewed-on: https://gerrit.libreoffice.org/26784
Reviewed-by: Thorsten Behrens <thorsten.behr...@cib.de>
    Tested-by: Thorsten Behrens <thorsten.behr...@cib.de>

diff --git a/.gitignore b/.gitignore
index 01e57e1..cbdc3e98 100644
--- a/.gitignore
+++ b/.gitignore
@@ -55,6 +55,7 @@
 /config_build_lang.mk
 /configure
 /lo.xcent
+/bin/bffvalidator.sh
 /Makefile
 /NEWS
 /TODO
diff --git a/bin/bffvalidator.sh.in b/bin/bffvalidator.sh.in
new file mode 100644
index 000..e435227
--- /dev/null
+++ b/bin/bffvalidator.sh.in
@@ -0,0 +1,3 @@
+#!/bin/sh
+
+wine @BFFVALIDATOR_EXE@ `winepath -w $1`
diff --git a/configure.ac b/configure.ac
index d99b4b4..39bc17f 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2796,7 +2796,14 @@ if test "$with_bffvalidator" != "no"; then
 else
 AC_MSG_ERROR([bffvalidator not found, but required by 
--with-bffvalidator])
 fi
-elif test -n "$BFFVALIDATOR" -a -e "$BFFVALIDATOR"; then
+elif test -n "$BFFVALIDATOR"; then
+# We are not in CygWin but need to run Windows binary with wine
+AC_PATH_PROGS(WINE, wine)
+
+# so swap in a shell wrapper that converts paths transparently
+BFFVALIDATOR_EXE="$BFFVALIDATOR"
+BFFVALIDATOR="$SRC_ROOT/bin/bffvalidator.sh"
+AC_SUBST(BFFVALIDATOR_EXE)
 AC_MSG_RESULT($BFFVALIDATOR)
 else
 AC_MSG_ERROR([bffvalidator not found, but required by 
--with-bffvalidator])
@@ -4657,6 +4664,7 @@ if test "$cross_compiling" = "yes"; then
 config_host_lang.mk.in \
 Makefile.in \
 lo.xcent.in \
+bin/bffvalidator.sh.in \
 instsetoo_native/util/openoffice.lst.in \
 config_host/*.in \
 sysui/desktop/macosx/Info.plist.in \
@@ -12991,6 +12999,7 @@ AC_CONFIG_FILES([config_host.mk
  config_host_lang.mk
  Makefile
  lo.xcent
+ bin/bffvalidator.sh
  instsetoo_native/util/openoffice.lst
  sysui/desktop/macosx/Info.plist
  ios/lo.xcconfig])
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


Re: chained editeng: Add TextChainFlow related files

2016-06-29 Thread Thorsten Behrens
Stephan Bergmann wrote:
> > +// XXX
> > +bMustMergeParaOF = true; // XXX: Experiment: no deep merging.
> 
> should that be removed?
> 
Unless Matteo feels strongly - yeah.

Cheers,

-- Thorsten


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: Branch 'libreoffice-5-1' - framework/source

2016-06-23 Thread Thorsten Behrens
 framework/source/dispatch/interceptionhelper.cxx |   21 ++---
 1 file changed, 14 insertions(+), 7 deletions(-)

New commits:
commit e2cc303ee8bbb0029dd095833ae93d84ec9d73c0
Author: Thorsten Behrens <thorsten.behr...@cib.de>
Date:   Wed Mar 2 15:28:36 2016 +0100

framework: avoid excessive queryDispatch calls

Make better use of the css::frame::XInterceptorInfo interface, to avoid
calling queryDispatch() pointlessly on interfaces that have explicitely
opted out. Since that already broadcasts which urls we're interested in
- so just don't bother calling entries who are not matching.

Change-Id: Id5e780568fd60c38f4cee4ee800d747d65a31dae
Reviewed-on: https://gerrit.libreoffice.org/25214
Tested-by: Jenkins <c...@libreoffice.org>
Reviewed-by: Thorsten Behrens <thorsten.behr...@cib.de>
(cherry picked from commit 27b6cdb5ab5af33dbba561923c8db81e144c88b9)
Reviewed-on: https://gerrit.libreoffice.org/26358
Reviewed-by: Katarina Behrens <katarina.behr...@cib.de>

diff --git a/framework/source/dispatch/interceptionhelper.cxx 
b/framework/source/dispatch/interceptionhelper.cxx
index ad707f3..fc3db65 100644
--- a/framework/source/dispatch/interceptionhelper.cxx
+++ b/framework/source/dispatch/interceptionhelper.cxx
@@ -54,16 +54,23 @@ css::uno::Reference< css::frame::XDispatch > SAL_CALL 
InterceptionHelper::queryD
 xInterceptor = pIt->xInterceptor;
 
 // b) No match by registration - but a valid interceptor list.
-//Use first interceptor everytimes.
-//Note: it doesn't matter, which direction this helper implementation 
use to ask interceptor objects.
-//Using of member m_aInterceptorList will starts at the beginning 
everytimes.
-//It depends from the filling operation, in which direction it works 
really!
+//Find first interceptor w/o pattern, so we need to query it
 if (!xInterceptor.is() && m_lInterceptionRegs.size()>0)
 {
-pIt  = m_lInterceptionRegs.begin();
-xInterceptor = pIt->xInterceptor;
+InterceptorList::const_iterator pIt2;
+for (pIt2=m_lInterceptionRegs.begin(); 
pIt2!=m_lInterceptionRegs.end(); ++pIt2)
+{
+if (!pIt2->lURLPattern.getLength())
+{
+// no pattern -> need to ask this guy!
+xInterceptor = pIt2->xInterceptor;
+break;
+}
+}
+// if we didn't find any non-pattern interceptor, there's no-one
+// registered for this command url (we already searched for matching
+// patterns above)
 }
-
 // c) No registered interceptor => use our direct slave.
 //This helper exist by design and must be valid everytimes ...
 //But to be more feature proof - we should check that .-)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: vcl/source

2016-06-21 Thread Thorsten Behrens
 vcl/source/gdi/pdfwriter_impl.cxx |   60 +++---
 vcl/source/outdev/font.cxx|9 +++--
 vcl/source/outdev/text.cxx|5 +--
 3 files changed, 39 insertions(+), 35 deletions(-)

New commits:
commit 406e39fad66c6f4b0f589dcc682c57464b230d69
Author: Thorsten Behrens <thorsten.behr...@cib.de>
Date:   Tue Jun 21 03:43:19 2016 +0200

vcl: fprintf -> SAL_INFO

Only touching dbglevel > 0 code here, so clearly only
informational..

Change-Id: Id6991c93f971bcc2a8badc809b98870a85322992
Reviewed-on: https://gerrit.libreoffice.org/26531
Tested-by: Jenkins <c...@libreoffice.org>
Reviewed-by: Thorsten Behrens <thorsten.behr...@cib.de>

diff --git a/vcl/source/gdi/pdfwriter_impl.cxx 
b/vcl/source/gdi/pdfwriter_impl.cxx
index f719e70..f29e8d1 100644
--- a/vcl/source/gdi/pdfwriter_impl.cxx
+++ b/vcl/source/gdi/pdfwriter_impl.cxx
@@ -2410,7 +2410,7 @@ const sal_Char* PDFWriterImpl::getAttributeTag( 
PDFWriter::StructAttribute eAttr
 
 #if OSL_DEBUG_LEVEL > 1
 if( it == aAttributeStrings.end() )
-fprintf( stderr, "invalid PDFWriter::StructAttribute %d\n", eAttr );
+SAL_INFO("vcl.pdfwriter", "invalid PDFWriter::StructAttribute " << 
eAttr);
 #endif
 
 return it != aAttributeStrings.end() ? it->second : "";
@@ -2455,7 +2455,7 @@ const sal_Char* PDFWriterImpl::getAttributeValueTag( 
PDFWriter::StructAttributeV
 
 #if OSL_DEBUG_LEVEL > 1
 if( it == aValueStrings.end() )
-fprintf( stderr, "invalid PDFWriter::StructAttributeValue %d\n", eVal 
);
+SAL_INFO("vcl.pdfwriter", "invalid PDFWriter::StructAttributeValue " 
<< eVal);
 #endif
 
 return it != aValueStrings.end() ? it->second : "";
@@ -2531,7 +2531,7 @@ OString PDFWriterImpl::emitStructureAttributes( 
PDFStructureElement& i_rEle )
 {
 OSL_FAIL( "unresolved link id for Link structure" );
 #if OSL_DEBUG_LEVEL > 1
-fprintf( stderr, "unresolved link id %" SAL_PRIdINT32 " for 
Link structure\n", nLink );
+SAL_INFO("vcl.pdfwriter", "unresolved link id " << nLink << " 
for Link structure");
 {
 OStringBuffer aLine( "unresolved link id " );
 aLine.append( nLink );
@@ -2638,7 +2638,7 @@ sal_Int32 PDFWriterImpl::emitStructure( 
PDFStructureElement& rEle )
 {
 OSL_FAIL( "PDFWriterImpl::emitStructure: invalid child 
structure element" );
 #if OSL_DEBUG_LEVEL > 1
-fprintf( stderr, "PDFWriterImpl::emitStructure: invalid 
child structure elemnt with id %" SAL_PRIdINT32 "\n", *it );
+SAL_INFO("vcl.pdfwriter", "PDFWriterImpl::emitStructure: 
invalid child structure elemnt with id " << *it);
 #endif
 }
 }
@@ -2647,7 +2647,7 @@ sal_Int32 PDFWriterImpl::emitStructure( 
PDFStructureElement& rEle )
 {
 OSL_FAIL( "PDFWriterImpl::emitStructure: invalid child structure 
id" );
 #if OSL_DEBUG_LEVEL > 1
-fprintf( stderr, "PDFWriterImpl::emitStructure: invalid child 
structure id %" SAL_PRIdINT32 "\n", *it );
+SAL_INFO("vcl.pdfwriter", "PDFWriterImpl::emitStructure: invalid 
child structure id " << *it);
 #endif
 }
 }
@@ -4022,7 +4022,7 @@ bool PDFWriterImpl::emitFonts()
 }
 else
 {
-fprintf( stderr, "PDF: CreateFontSubset result in not yet 
supported format=%d\n",aSubsetInfo.m_nFontType);
+SAL_INFO("vcl.pdfwriter", "PDF: CreateFontSubset result in 
not yet supported format=" << aSubsetInfo.m_nFontType);
 aLine.append( "0 >>\nstream\n" );
 }
 
@@ -4331,7 +4331,7 @@ bool PDFWriterImpl::appendDest( sal_Int32 nDestID, 
OStringBuffer& rBuffer )
 if( nDestID < 0 || nDestID >= (sal_Int32)m_aDests.size() )
 {
 #if OSL_DEBUG_LEVEL > 1
-fprintf( stderr, "ERROR: invalid dest %d requested\n", (int)nDestID );
+SAL_INFO("vcl.pdfwriter", "ERROR: invalid dest " << (int)nDestID << " 
requested");
 #endif
 return false;
 }
@@ -8178,8 +8178,10 @@ void PDFWriterImpl::sortWidgets()
 {
 SAL_WARN( "vcl", "wrong number of sorted annotations" );
 #if OSL_DEBUG_LEVEL > 0
-fprintf( stderr, "PDFWriterImpl::sortWidgets(): wrong number of 
sorted assertions on page nr %ld\n"
- "%ld sorted and %ld un

[Libreoffice-commits] core.git: vcl/osx vcl/quartz

2016-06-20 Thread Thorsten Behrens
 vcl/osx/salframeview.mm |3 ---
 vcl/quartz/salbmp.cxx   |6 +-
 2 files changed, 1 insertion(+), 8 deletions(-)

New commits:
commit 5d336fb1d515b0967bc730e47ac3e4b850cf9872
Author: Thorsten Behrens <thorsten.behr...@cib.de>
Date:   Tue Jun 21 03:41:48 2016 +0200

vcl: remove some commented-out code

Change-Id: Iac827fd102404ae615dfd1685886010e949ff653

diff --git a/vcl/osx/salframeview.mm b/vcl/osx/salframeview.mm
index 219c681..3dded25 100644
--- a/vcl/osx/salframeview.mm
+++ b/vcl/osx/salframeview.mm
@@ -1680,9 +1680,6 @@ private:
 {
 if( AquaSalFrame::isAlive( mpFrame ) )
 {
-#if OSL_DEBUG_LEVEL > 1
-// fprintf( stderr, "SalFrameView: doCommandBySelector %s\n", 
(char*)aSelector );
-#endif
 if( (mpFrame->mnICOptions & InputContextFlags::Text) &&
 aSelector != nullptr && [self respondsToSelector: aSelector] )
 {
diff --git a/vcl/quartz/salbmp.cxx b/vcl/quartz/salbmp.cxx
index 7c44fb2..86c4dab 100644
--- a/vcl/quartz/salbmp.cxx
+++ b/vcl/quartz/salbmp.cxx
@@ -751,13 +751,9 @@ const BitmapPalette& GetDefaultPalette( int mnBits, bool 
bMonochrome )
 
 BitmapBuffer* QuartzSalBitmap::AcquireBuffer( BitmapAccessMode /*nMode*/ )
 {
+// TODO: AllocateUserData();
 if (!m_pUserBuffer.get())
-//  || m_pContextBuffer.get() && (m_pUserBuffer.get() != 
m_pContextBuffer.get()) )
-{
-// fprintf(stderr,"ASB::Acq(%dx%d,d=%d)\n",mnWidth,mnHeight,mnBits);
-// TODO: AllocateUserData();
 return nullptr;
-}
 
 BitmapBuffer* pBuffer = new BitmapBuffer;
 pBuffer->mnWidth = mnWidth;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: vcl/unx

2016-06-20 Thread Thorsten Behrens
 vcl/unx/generic/app/i18n_ic.cxx|6 --
 vcl/unx/generic/app/randrwrapper.cxx   |2 +-
 vcl/unx/generic/glyphs/graphite_serverfont.cxx |7 +++
 vcl/unx/generic/printer/cupsmgr.cxx|2 +-
 vcl/unx/generic/printer/printerinfomanager.cxx |2 +-
 5 files changed, 6 insertions(+), 13 deletions(-)

New commits:
commit 0c1767d9466adf0729eb8e1f43ddb80a31886898
Author: Thorsten Behrens <thorsten.behr...@cib.de>
Date:   Tue Jun 21 03:12:12 2016 +0200

vcl: fix dbglevel>1 build

Change-Id: I94c35499d395d10a86a821a28e57ad3c1d8ec485

diff --git a/vcl/unx/generic/app/i18n_ic.cxx b/vcl/unx/generic/app/i18n_ic.cxx
index a67e589..585f891 100644
--- a/vcl/unx/generic/app/i18n_ic.cxx
+++ b/vcl/unx/generic/app/i18n_ic.cxx
@@ -511,12 +511,6 @@ SalI18N_InputContext::SupportInputMethodStyle( XIMStyles 
*pIMStyles )
 }
 }
 
-#if OSL_DEBUG_LEVEL > 1
-char pBuf[ 128 ];
-fprintf( stderr, "selected inputmethod style = %s\n",
- GetMethodName(mnPreeditStyle | mnStatusStyle, pBuf, sizeof(pBuf)) 
);
-#endif
-
 return (mnPreeditStyle != 0) && (mnStatusStyle != 0) ;
 }
 
diff --git a/vcl/unx/generic/app/randrwrapper.cxx 
b/vcl/unx/generic/app/randrwrapper.cxx
index 54b822f..0ae4027 100644
--- a/vcl/unx/generic/app/randrwrapper.cxx
+++ b/vcl/unx/generic/app/randrwrapper.cxx
@@ -169,7 +169,7 @@ void SalDisplay::processRandREvent( XEvent* pEvent )
 pWrapper->XRRFreeScreenConfigInfo( pConfig );
 
 #if OSL_DEBUG_LEVEL > 1
-fprintf( stderr, "screen %d changed to size %dx%d\n", 
(int)i, (int)pTargetSize->width, (int)pTargetSize->height );
+fprintf( stderr, "screen %d changed to size %dx%d\n", 
(int)nId, (int)pTargetSize->width, (int)pTargetSize->height );
 #endif
 }
 }
diff --git a/vcl/unx/generic/glyphs/graphite_serverfont.cxx 
b/vcl/unx/generic/glyphs/graphite_serverfont.cxx
index d2126b0..f07ce70 100644
--- a/vcl/unx/generic/glyphs/graphite_serverfont.cxx
+++ b/vcl/unx/generic/glyphs/graphite_serverfont.cxx
@@ -69,7 +69,7 @@ 
GraphiteServerFontLayout::GraphiteServerFontLayout(ServerFont& rServerFont) thro
 rServerFont.GetFontSelData().maTargetName, RTL_TEXTENCODING_UTF8 );
 #ifdef DEBUG
 printf("GraphiteServerFontLayout %lx %s size %d %f\n", (long unsigned 
int)this, name.getStr(),
-rServerFont.GetMetricsFT().x_ppem,
+rServerFont.GetFtFace()->size->metrics.x_ppem,
 rServerFont.GetFontSelData().mfExactHeight);
 #endif
 sal_Int32 nFeat = name.indexOf(grutils::GrFeatureParser::FEAT_PREFIX) + 1;
@@ -80,15 +80,14 @@ 
GraphiteServerFontLayout::GraphiteServerFontLayout(ServerFont& rServerFont) thro
 rServerFont.GetGraphiteFace()->face(), aFeat, aLang);
 #ifdef DEBUG
 if (mpFeatures)
-printf("GraphiteServerFontLayout %s/%s/%s %x language %d features 
%d errors\n",
+printf("GraphiteServerFontLayout %s/%s/%s %x language\n",
 OUStringToOString( 
rServerFont.GetFontSelData().GetFamilyName(),
 RTL_TEXTENCODING_UTF8 ).getStr(),
 OUStringToOString( rServerFont.GetFontSelData().maTargetName,
 RTL_TEXTENCODING_UTF8 ).getStr(),
 OUStringToOString( rServerFont.GetFontSelData().maSearchName,
 RTL_TEXTENCODING_UTF8 ).getStr(),
-rServerFont.GetFontSelData().meLanguage,
-(int)mpFeatures->numFeatures(), mpFeatures->parseErrors());
+rServerFont.GetFontSelData().meLanguage);
 #endif
 }
 else
diff --git a/vcl/unx/generic/printer/cupsmgr.cxx 
b/vcl/unx/generic/printer/cupsmgr.cxx
index 2da3bf9..6f000e4 100644
--- a/vcl/unx/generic/printer/cupsmgr.cxx
+++ b/vcl/unx/generic/printer/cupsmgr.cxx
@@ -670,7 +670,7 @@ bool CUPSManager::endSpool( const OUString& rPrintername, 
const OUString& rJobTi
 "option " << pOptions[n].name << "=" << pOptions[n].value);
 #if OSL_DEBUG_LEVEL > 1
 OString aCmd( "cp " );
-aCmd = aCmd + files.front();
+aCmd = aCmd + it->second.getStr();
 aCmd = aCmd + OString( " $HOME/cupsprint.ps" );
 system( aCmd.getStr() );
 #endif
diff --git a/vcl/unx/generic/printer/printerinfomanager.cxx 
b/vcl/unx/generic/printer/printerinfomanager.cxx
index be9149c..5e08f42 100644
--- a/vcl/unx/generic/printer/printerinfomanager.cxx
+++ b/vcl/unx/generic/printer/printerinfomanager.cxx
@@ -1156,7 +1156,7 @@ void SystemQueueInfo::run()
 OStringBuffer aCmdLine( 128 );
 aCmdLine.append( rParm.pQueueCommand );
 #if OSL_DEBUG_LEVEL > 1
-fprintf( stderr, "trying print queue command \"%s\&qu

Re: Upload libtommath

2016-06-18 Thread Thorsten Behrens
Bunth Tamás wrote:
> Could someone please upload it?
> 
Done.

Cheers,

-- Thorsten


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: Voting page in wiki

2016-06-17 Thread Thorsten Behrens
Norbert Thiebaud wrote:
> > Is that a page we actively use (if so, I need to give it more attention) ?
> 
> No.
>
I'd even say 'emphatically not'. :)

It's a bit dubious to have a page that's not widely published, since
the stats are heavily skewed then; and at the same time the reasons
_not_ to publicize it widely are good ones & similar to the fact we
don't have the feature in bugzilla...

Cheers,

-- Thorsten


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.1' - 19 commits - filter/source framework/inc framework/source sd/qa

2016-06-12 Thread Thorsten Behrens
 filter/source/svg/presentation_engine.js   |  852 ++---
 filter/source/svg/svgexport.cxx|  598 +++---
 filter/source/svg/svgfilter.cxx|4 
 filter/source/svg/svgfilter.hxx|   20 
 filter/source/svg/svgwriter.cxx|4 
 filter/source/svg/svgwriter.hxx|5 
 filter/source/xsltdialog/xmlfiltertabpagebasic.cxx |4 
 filter/source/xsltdialog/xmlfiltertabpagebasic.hxx |2 
 filter/source/xsltdialog/xmlfiltertabpagexslt.cxx  |4 
 filter/source/xsltdialog/xmlfiltertabpagexslt.hxx  |2 
 framework/inc/dispatch/interceptionhelper.hxx  |4 
 framework/source/dispatch/interceptionhelper.cxx   |   43 -
 sd/qa/unit/SVGExportTests.cxx  |   18 
 13 files changed, 925 insertions(+), 635 deletions(-)

New commits:
commit 187b7cd5c729b5ea7b08be5cedddf8830f066ceb
Author: Thorsten Behrens <thorsten.behr...@cib.de>
Date:   Fri May 20 16:48:00 2016 +0200

framework: last dispatchInterceptor gets asked first

Align implementation with API contract as spelled out in
offapi/com/sun/star/frame/XDispatchProviderInterception.idl -
no idea why this change happenend in 2003:

Date: Fri Apr 4 16:16:05 2003 +
INTEGRATION: CWS fwk01 (1.1.72); FILE MERGED
2003/04/01 12:40:09 as 1.1.72.1: #107642# change order of used interception 
objects

At any rate, with this change extensions actually get a chance to
see dispatch requests first, and process/ignore at will.

Change-Id: I58876150ee6d67e592f41b3e82a9ffc314e091a3
Reviewed-on: https://gerrit.libreoffice.org/25215
Tested-by: Jenkins <c...@libreoffice.org>
Reviewed-by: Thorsten Behrens <thorsten.behr...@cib.de>
(cherry picked from commit 08cf2fd01064306eef7fdbb5b62320947c4d1089)

diff --git a/framework/source/dispatch/interceptionhelper.cxx 
b/framework/source/dispatch/interceptionhelper.cxx
index 2a5be00..affce9a 100644
--- a/framework/source/dispatch/interceptionhelper.cxx
+++ b/framework/source/dispatch/interceptionhelper.cxx
@@ -136,20 +136,19 @@ void SAL_CALL 
InterceptionHelper::registerDispatchProviderInterceptor(const css:
 
 // b) OK - there is at least one interceptor already registered.
 //It's slave and it's master must be valid references ...
-//because we created it. But we have to look for the static bool which
-//regulate direction of using of interceptor objects!
+//because we created it.
 
-// insert it behind any other existing interceptor - means at the end 
of our list.
+// insert it before any other existing interceptor - means at the 
beginning of our list.
 else
 {
-css::uno::Reference< css::frame::XDispatchProvider >
xMasterD = m_lInterceptionRegs.rbegin()->xInterceptor;
-css::uno::Reference< css::frame::XDispatchProviderInterceptor > 
xMasterI (xMasterD, css::uno::UNO_QUERY);
+css::uno::Reference< css::frame::XDispatchProvider >
xSlaveD = m_lInterceptionRegs.begin()->xInterceptor;
+css::uno::Reference< css::frame::XDispatchProviderInterceptor > 
xSlaveI (xSlaveD , css::uno::UNO_QUERY);
 
-xInterceptor->setMasterDispatchProvider(xMasterD  );
-xInterceptor->setSlaveDispatchProvider (m_xSlave  );
-xMasterI->setSlaveDispatchProvider (aInfo.xInterceptor);
+xInterceptor->setMasterDispatchProvider(xThis );
+xInterceptor->setSlaveDispatchProvider (xSlaveD   );
+xSlaveI->setMasterDispatchProvider (aInfo.xInterceptor);
 
-m_lInterceptionRegs.push_back(aInfo);
+m_lInterceptionRegs.push_front(aInfo);
 }
 
 css::uno::Reference< css::frame::XFrame > xOwner(m_xOwnerWeak.get(), 
css::uno::UNO_QUERY);
commit 01499f93930c13e3f605b5c484cd5dcf3c1122bb
Author: Thorsten Behrens <thorsten.behr...@cib.de>
Date:   Wed Mar 2 15:28:36 2016 +0100

framework: avoid excessive queryDispatch calls

Make better use of the css::frame::XInterceptorInfo interface, to avoid
calling queryDispatch() pointlessly on interfaces that have explicitely
opted out. Since that already broadcasts which urls we're interested in
- so just don't bother calling entries who are not matching.

Change-Id: Id5e780568fd60c38f4cee4ee800d747d65a31dae
Reviewed-on: https://gerrit.libreoffice.org/25214
    Tested-by: Jenkins <c...@libreoffice.org>
Reviewed-by: Thorsten Behrens <thorsten.behr...@cib.de>
(cherry picked from commit 27b6cdb5ab5af33dbba561923c8db81e144c88b9)

diff --git a/framework/source/dispatch/interceptionhelper.cxx 
b/framework/source/dispatch/interceptionhelper.cxx
index ad746bb..2a5be00 100644
--- a/framework/source/dispatch/interceptionhelper.cxx
+++ b/framework/source/dispatch/interceptionhelper.cxx
@@ 

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.0' - 3 commits - framework/inc framework/source

2016-06-01 Thread Thorsten Behrens
 framework/inc/dispatch/interceptionhelper.hxx|4 --
 framework/source/dispatch/interceptionhelper.cxx |   43 ---
 2 files changed, 16 insertions(+), 31 deletions(-)

New commits:
commit 7283f2e2ddb7a2b7dac2d2a2417a1de866eb7124
Author: Thorsten Behrens <thorsten.behr...@cib.de>
Date:   Fri May 20 16:48:00 2016 +0200

framework: last dispatchInterceptor gets asked first

Align implementation with API contract as spelled out in
offapi/com/sun/star/frame/XDispatchProviderInterception.idl -
no idea why this change happenend in 2003:

Date: Fri Apr 4 16:16:05 2003 +
INTEGRATION: CWS fwk01 (1.1.72); FILE MERGED
2003/04/01 12:40:09 as 1.1.72.1: #107642# change order of used interception 
objects

At any rate, with this change extensions actually get a chance to
see dispatch requests first, and process/ignore at will.

Change-Id: I58876150ee6d67e592f41b3e82a9ffc314e091a3
Reviewed-on: https://gerrit.libreoffice.org/25215
Tested-by: Jenkins <c...@libreoffice.org>
Reviewed-by: Thorsten Behrens <thorsten.behr...@cib.de>
(cherry picked from commit 08cf2fd01064306eef7fdbb5b62320947c4d1089)

diff --git a/framework/source/dispatch/interceptionhelper.cxx 
b/framework/source/dispatch/interceptionhelper.cxx
index 4935e3d..6e5ff13 100644
--- a/framework/source/dispatch/interceptionhelper.cxx
+++ b/framework/source/dispatch/interceptionhelper.cxx
@@ -136,20 +136,19 @@ void SAL_CALL 
InterceptionHelper::registerDispatchProviderInterceptor(const css:
 
 // b) OK - there is at least one interceptor already registered.
 //It's slave and it's master must be valid references ...
-//because we created it. But we have to look for the static bool which
-//regulate direction of using of interceptor objects!
+//because we created it.
 
-// insert it behind any other existing interceptor - means at the end 
of our list.
+// insert it before any other existing interceptor - means at the 
beginning of our list.
 else
 {
-css::uno::Reference< css::frame::XDispatchProvider >
xMasterD = m_lInterceptionRegs.rbegin()->xInterceptor;
-css::uno::Reference< css::frame::XDispatchProviderInterceptor > 
xMasterI (xMasterD, css::uno::UNO_QUERY);
+css::uno::Reference< css::frame::XDispatchProvider >
xSlaveD = m_lInterceptionRegs.begin()->xInterceptor;
+css::uno::Reference< css::frame::XDispatchProviderInterceptor > 
xSlaveI (xSlaveD , css::uno::UNO_QUERY);
 
-xInterceptor->setMasterDispatchProvider(xMasterD  );
-xInterceptor->setSlaveDispatchProvider (m_xSlave  );
-xMasterI->setSlaveDispatchProvider (aInfo.xInterceptor);
+xInterceptor->setMasterDispatchProvider(xThis );
+xInterceptor->setSlaveDispatchProvider (xSlaveD   );
+xSlaveI->setMasterDispatchProvider (aInfo.xInterceptor);
 
-m_lInterceptionRegs.push_back(aInfo);
+m_lInterceptionRegs.push_front(aInfo);
 }
 
 css::uno::Reference< css::frame::XFrame > xOwner(m_xOwnerWeak.get(), 
css::uno::UNO_QUERY);
commit c87170c8d3c206722a5b2bb2c2eb826abac06608
Author: Thorsten Behrens <thorsten.behr...@cib.de>
Date:   Wed Mar 2 15:28:36 2016 +0100

framework: avoid excessive queryDispatch calls

Make better use of the css::frame::XInterceptorInfo interface, to avoid
calling queryDispatch() pointlessly on interfaces that have explicitely
opted out. Since that already broadcasts which urls we're interested in
- so just don't bother calling entries who are not matching.

Change-Id: Id5e780568fd60c38f4cee4ee800d747d65a31dae
Reviewed-on: https://gerrit.libreoffice.org/25214
    Tested-by: Jenkins <c...@libreoffice.org>
Reviewed-by: Thorsten Behrens <thorsten.behr...@cib.de>
(cherry picked from commit 27b6cdb5ab5af33dbba561923c8db81e144c88b9)

diff --git a/framework/source/dispatch/interceptionhelper.cxx 
b/framework/source/dispatch/interceptionhelper.cxx
index ca438ac..4935e3d 100644
--- a/framework/source/dispatch/interceptionhelper.cxx
+++ b/framework/source/dispatch/interceptionhelper.cxx
@@ -52,16 +52,23 @@ css::uno::Reference< css::frame::XDispatch > SAL_CALL 
InterceptionHelper::queryD
 xInterceptor = pIt->xInterceptor;
 
 // b) No match by registration - but a valid interceptor list.
-//Use first interceptor everytimes.
-//Note: it doesn't matter, which direction this helper implementation 
use to ask interceptor objects.
-//Using of member m_aInterceptorList will starts at the beginning 
everytimes.
-//It depends from the filling operation, in which direction it works 
really!
+//Find first interceptor w/o pattern, so we need to query it
 if (!xInterceptor.is() && m_lInterce

Re: Crash reporting for TDF builds

2016-05-29 Thread Thorsten Behrens
Markus Mohrhard wrote:
> so I managed to land the crash reporting that I presented during my FOSDEM
> talk finally in time for the 5.2 release.
>
Hey Moggi,

so first off - this is just awesome. Thanks a whole bloody lot!

> The idea is that you can add important information as key value pairs and
> they will be available together with the crash report on the server. Some
> information that area already part of the minidump are the OS, the CPU, the
> loaded modules. Keep in mind that you should only collect the information
> that are really necessary.
> 
> Some information that we might want to select in the future:
> 
> OpenCL info if OpenCL is use
> did we crash inside of our OpenGL code
> loaded extensions
> 
This indeed all sounds quite useful. Just a very quiet, cautionary
word of warning: I would sleep a bit better if we could all agree on a
four eyes principle (i.e. mandatory reviews) for anything that adds
new information to the crash report. It's sometimes not immediately
obvious, but e.g. extension & path names, font sets etc (and who knows
what else we'll come up with) can reveal quite intimate information
about an installation environment.

For the record, the feature & crash dumps as it is look perfectly
sane.

And again, thanks so much. This is a great addition to LibreOffice, I
used to use the Sun-internal crash reporter that unforunately went
down with that company, and it was invaluable.

Cheers,

-- Thorsten


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: framework/source

2016-05-23 Thread Thorsten Behrens
 framework/source/dispatch/interceptionhelper.cxx |   17 -
 1 file changed, 8 insertions(+), 9 deletions(-)

New commits:
commit 08cf2fd01064306eef7fdbb5b62320947c4d1089
Author: Thorsten Behrens <thorsten.behr...@cib.de>
Date:   Fri May 20 16:48:00 2016 +0200

framework: last dispatchInterceptor gets asked first

Align implementation with API contract as spelled out in
offapi/com/sun/star/frame/XDispatchProviderInterception.idl -
no idea why this change happenend in 2003:

Date: Fri Apr 4 16:16:05 2003 +
INTEGRATION: CWS fwk01 (1.1.72); FILE MERGED
2003/04/01 12:40:09 as 1.1.72.1: #107642# change order of used interception 
objects

At any rate, with this change extensions actually get a chance to
see dispatch requests first, and process/ignore at will.

Change-Id: I58876150ee6d67e592f41b3e82a9ffc314e091a3
Reviewed-on: https://gerrit.libreoffice.org/25215
Tested-by: Jenkins <c...@libreoffice.org>
Reviewed-by: Thorsten Behrens <thorsten.behr...@cib.de>

diff --git a/framework/source/dispatch/interceptionhelper.cxx 
b/framework/source/dispatch/interceptionhelper.cxx
index 9772e52..dfff234 100644
--- a/framework/source/dispatch/interceptionhelper.cxx
+++ b/framework/source/dispatch/interceptionhelper.cxx
@@ -136,20 +136,19 @@ void SAL_CALL 
InterceptionHelper::registerDispatchProviderInterceptor(const css:
 
 // b) OK - there is at least one interceptor already registered.
 //It's slave and it's master must be valid references ...
-//because we created it. But we have to look for the static bool which
-//regulate direction of using of interceptor objects!
+//because we created it.
 
-// insert it behind any other existing interceptor - means at the end 
of our list.
+// insert it before any other existing interceptor - means at the 
beginning of our list.
 else
 {
-css::uno::Reference< css::frame::XDispatchProvider >
xMasterD = m_lInterceptionRegs.rbegin()->xInterceptor;
-css::uno::Reference< css::frame::XDispatchProviderInterceptor > 
xMasterI (xMasterD, css::uno::UNO_QUERY);
+css::uno::Reference< css::frame::XDispatchProvider >
xSlaveD = m_lInterceptionRegs.begin()->xInterceptor;
+css::uno::Reference< css::frame::XDispatchProviderInterceptor > 
xSlaveI (xSlaveD , css::uno::UNO_QUERY);
 
-xInterceptor->setMasterDispatchProvider(xMasterD  );
-xInterceptor->setSlaveDispatchProvider (m_xSlave  );
-xMasterI->setSlaveDispatchProvider (aInfo.xInterceptor);
+xInterceptor->setMasterDispatchProvider(xThis );
+xInterceptor->setSlaveDispatchProvider (xSlaveD   );
+xSlaveI->setMasterDispatchProvider (aInfo.xInterceptor);
 
-m_lInterceptionRegs.push_back(aInfo);
+m_lInterceptionRegs.push_front(aInfo);
 }
 
 css::uno::Reference< css::frame::XFrame > xOwner(m_xOwnerWeak.get(), 
css::uno::UNO_QUERY);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: framework/source

2016-05-20 Thread Thorsten Behrens
 framework/source/dispatch/interceptionhelper.cxx |   21 ++---
 1 file changed, 14 insertions(+), 7 deletions(-)

New commits:
commit 27b6cdb5ab5af33dbba561923c8db81e144c88b9
Author: Thorsten Behrens <thorsten.behr...@cib.de>
Date:   Wed Mar 2 15:28:36 2016 +0100

framework: avoid excessive queryDispatch calls

Make better use of the css::frame::XInterceptorInfo interface, to avoid
calling queryDispatch() pointlessly on interfaces that have explicitely
opted out. Since that already broadcasts which urls we're interested in
- so just don't bother calling entries who are not matching.

Change-Id: Id5e780568fd60c38f4cee4ee800d747d65a31dae
Reviewed-on: https://gerrit.libreoffice.org/25214
Tested-by: Jenkins <c...@libreoffice.org>
Reviewed-by: Thorsten Behrens <thorsten.behr...@cib.de>

diff --git a/framework/source/dispatch/interceptionhelper.cxx 
b/framework/source/dispatch/interceptionhelper.cxx
index d205a53..9772e52 100644
--- a/framework/source/dispatch/interceptionhelper.cxx
+++ b/framework/source/dispatch/interceptionhelper.cxx
@@ -52,16 +52,23 @@ css::uno::Reference< css::frame::XDispatch > SAL_CALL 
InterceptionHelper::queryD
 xInterceptor = pIt->xInterceptor;
 
 // b) No match by registration - but a valid interceptor list.
-//Use first interceptor everytimes.
-//Note: it doesn't matter, which direction this helper implementation 
use to ask interceptor objects.
-//Using of member m_aInterceptorList will starts at the beginning 
everytimes.
-//It depends from the filling operation, in which direction it works 
really!
+//Find first interceptor w/o pattern, so we need to query it
 if (!xInterceptor.is() && m_lInterceptionRegs.size()>0)
 {
-pIt  = m_lInterceptionRegs.begin();
-xInterceptor = pIt->xInterceptor;
+InterceptorList::const_iterator pIt2;
+for (pIt2=m_lInterceptionRegs.begin(); 
pIt2!=m_lInterceptionRegs.end(); ++pIt2)
+{
+if (!pIt2->lURLPattern.getLength())
+{
+// no pattern -> need to ask this guy!
+xInterceptor = pIt2->xInterceptor;
+break;
+}
+}
+// if we didn't find any non-pattern interceptor, there's no-one
+// registered for this command url (we already searched for matching
+// patterns above)
 }
-
 // c) No registered interceptor => use our direct slave.
 //This helper exist by design and must be valid everytimes ...
 //But to be more feature proof - we should check that .-)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


Re: Project proposal accepted for GSoC 2016

2016-05-17 Thread Thorsten Behrens
Rosemary Sebastian wrote:
> Looking forward to an exciting summer hacking on LibreOffice!
> 
Hi Roses,

the pleasure is ours - happy to have you, and looking forward just as
well! :)

> [2] My blog 
> 
Just added to the planet.

Happy hacking,

-- Thorsten


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: multi-threading task under SolarMutex -> deadlock

2016-05-17 Thread Thorsten Behrens
Norbert Thiebaud wrote:
> The threaded work then raise() due to some memory problem and out
> signal handler try to acquire the solar mutex ->deadlock
> 
Eek, that's ugly. Then again, at the core is the OOM condition, which
needs solving independently. Per chance, is that happening on a box
with massive amounts of CPU threads?

Cheers,

-- Thorsten


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: Updating vcl EMF+ Renderer without using the cppcanvas metafile renderer

2016-05-12 Thread Thorsten Behrens
Aptitude Testing Team wrote:
> Thinking about it. I believe the best approach will be to use svgio as a
> framework (I will call it wmfio). Since svg (I believe) is the newest.
> Then in 4 stages, slowly port the WMF/EMF/EMF+ code
> 1) WMF
> 2) EMF
> 3) EMF+
> 4) Strip out the old code (If any remnants exist).
> 
Sounds great! :)

Cheers,

-- Thorsten


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: Updating vcl EMF+ Renderer without using the cppcanvas metafile renderer

2016-05-11 Thread Thorsten Behrens
Aptitude Testing Team wrote:
> To fix this, I believe that it should be possible to copy
> cppcanvas/source/mtrenderer/emfplus.cxx into vcl/source/filter/wmf
> and adapt it to use "class WinMtfOutput"
> 
I'd move it instead of copying. WinMtfOutput as-is won't cut it, you
need to extend it to cover more modern graphic operations. Caveat
emptor, that might require extensions to the internal StarView
metafile format then with some ripple-effects.

Another (IMO better) option is to convert it into a drawinglayer
primitive filter. Armin on Cc for further details on that topic.

> There was a comment in
> http://nabble.documentfoundation.org/Query-about-the-direction-of-EMF-EMF-pr
> ocessing-td4132203.html#a4132247 by Thorsten that suggests there are further
> issues.
> 
Nah, that was referring to dump cppcanvas - getting rid of EMF+ there
is a useful first step.

Cheers,

-- Thorsten


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: vcl/source

2016-05-05 Thread Thorsten Behrens
 vcl/source/gdi/wall.cxx |7 ---
 1 file changed, 4 insertions(+), 3 deletions(-)

New commits:
commit ee5850893e15acda1d7ce7cf17da7c80f2fa810a
Author: Thorsten Behrens <thorsten.behr...@cib.de>
Date:   Fri May 6 02:07:56 2016 +0200

vcl: save one heap alloc

Change-Id: I4557d643debbf47c10e1ccd2141f04680333a11d
Reviewed-on: https://gerrit.libreoffice.org/24685
Tested-by: Jenkins <c...@libreoffice.org>
Reviewed-by: Thorsten Behrens <thorsten.behr...@cib.de>

diff --git a/vcl/source/gdi/wall.cxx b/vcl/source/gdi/wall.cxx
index 7f81368..26b3448 100644
--- a/vcl/source/gdi/wall.cxx
+++ b/vcl/source/gdi/wall.cxx
@@ -202,9 +202,10 @@ Wallpaper::~Wallpaper()
 
 void Wallpaper::ImplSetCachedBitmap( BitmapEx& rBmp ) const
 {
-if( mpImplWallpaper->mpCache )
-delete const_cast< ImplWallpaper* >(mpImplWallpaper.get())->mpCache;
-const_cast< ImplWallpaper* >(mpImplWallpaper.get())->mpCache = new 
BitmapEx( rBmp );
+   if( !mpImplWallpaper->mpCache )
+  const_cast< ImplWallpaper* >(mpImplWallpaper.get())->mpCache = new 
BitmapEx( rBmp );
+   else
+  *const_cast< ImplWallpaper* >(mpImplWallpaper.get())->mpCache = rBmp;
 }
 
 const BitmapEx* Wallpaper::ImplGetCachedBitmap() const
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: chart2/source

2016-05-04 Thread Thorsten Behrens
 chart2/source/controller/chartapiwrapper/WrappedSeriesOrDiagramProperty.hxx |  
  2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 2cf939b2da466b33189de153a15c40485cee
Author: Thorsten Behrens <thorsten.behr...@cib.de>
Date:   Wed May 4 14:13:23 2016 +0200

-Werror=maybe-uninitialized

Change-Id: Id516aa921d13ff5c0085fb9cf76fefd56acb31ad

diff --git 
a/chart2/source/controller/chartapiwrapper/WrappedSeriesOrDiagramProperty.hxx 
b/chart2/source/controller/chartapiwrapper/WrappedSeriesOrDiagramProperty.hxx
index 7338994..c159dfd 100644
--- 
a/chart2/source/controller/chartapiwrapper/WrappedSeriesOrDiagramProperty.hxx
+++ 
b/chart2/source/controller/chartapiwrapper/WrappedSeriesOrDiagramProperty.hxx
@@ -141,7 +141,7 @@ public:
 if( m_ePropertyType == DIAGRAM )
 {
 bool bHasAmbiguousValue = false;
-PROPERTYTYPE aValue;
+PROPERTYTYPE aValue = PROPERTYTYPE();
 if( detectInnerValue( aValue, bHasAmbiguousValue ) )
 {
 if(bHasAmbiguousValue)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


Re: libcmis: Google Drive login no longer working

2016-05-03 Thread Thorsten Behrens
Miklos Vajna wrote:
> The git repo is , you can submit a
> patch at .
> 
Hi guys,

meanwhile libcmis upstream is here: https://github.com/tdf/libcmis

Cheers,

-- Thorsten


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: Project out of gsoc

2016-04-29 Thread Thorsten Behrens
Jan Iversen wrote:
> Unless the project is selected with another student then you are
> more than welcome to work on it, and I am sure there are developers
> willing to help you (including myself, though with limited knowledge
> about the actual code).
> 
Hi Mayank,

so this is about the slideshow physics engine idea - project is still
unassigned, so you're most welcome to work on it. Can't make any
promises though regarding mentor bandwidth, but will of course try to
help.

Cheers,

-- Thorsten


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: .gitignore

2016-04-09 Thread Thorsten Behrens
 .gitignore |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit 656f639dc3664437a491fa8dd5ecf44fd430fa27
Author: Thorsten Behrens <thorsten.behr...@cib.de>
Date:   Sat Apr 9 16:34:14 2016 +0200

Ignore lo.png output from make dump-deps-png

Change-Id: I9d968a14db440a54e3accefb12e2d0a5685d0b37

diff --git a/.gitignore b/.gitignore
index 2370081..01e57e1 100644
--- a/.gitignore
+++ b/.gitignore
@@ -140,6 +140,9 @@ DerivedData
 # doxygen output
 /docs
 
+# make dump-deps output
+/lo.png
+
 # gdb config
 /.gdbinit
 /.gdb_history
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


Re: Implementing SVG attribute "stroke-miterlimit" ( tdf#48066)

2016-03-30 Thread Thorsten Behrens
Regina Henschel wrote:
> (1) Change the type of maStrokeMiterLimit' to 'double' and change its name
> to 'mfStrokeMiterLimit'. That would loose the ability to track, whether the
> value was found in the file or set by LO. In case not set in the SVG file,
> it would be set to 4.0, as specified as initial value in SVG spec.
>
Why would knowing if it's the default or read from svg matter?

> (2) Extend the enum SvgUnit by an item 'Unit_none'. This likely requires
> changes in places where SvgUnit is used. The member mfNumber of class
> SvgNumber is already a 'double' and would fit.
> 
> My favorite is (2). What do you think?
> 
I think you know the code better than I do, so whatever you prefer. :)

Except if the question above has the 'does not matter' answer, then of
course (1) seems cleaner ...

Cheers,

-- Thorsten


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: Implementing SVG attribute "stroke-miterlimit" ( tdf#48066)

2016-03-28 Thread Thorsten Behrens
Regina Henschel wrote:
> The API has the struct "StrokeAttributes" in css::rendering. It has the
> element "MiterLimit". I do not know any UI for it and don't know, if and how
> it is usable at all. The service "LineProperties" in css::drawing does not
> provide such property.
> 
Yeah, the css::rendering API in general is more modern than the stuff
in css::drawing. But for svg import, UNO API is for the while not
relevant, no?

> So my question is, how to transport the "Miterlimit"-information?
> Add a member to class LineAttribute?
>
Sounds like the way to go (if you mean the drawinglayer attribute).

Cheers,

-- Thorsten


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: LibreOfficeKit and the UserInstallation

2016-03-23 Thread Thorsten Behrens
Miklos Vajna wrote:
> On Wed, Mar 23, 2016 at 03:30:50PM +0100, Stephan Bergmann 
>  wrote:
> > Therefore, I would like somebody overseeing the architecture of LOK to
> > explain how LOK intends to solve its "multiple processes per
> > UserInstallation" problem.
> 
> There are two main use-cases for LOK at the moment: Android and Online.
>
It's also quite convenient for e.g. document conversion. Having a
throw-away user config would therefore be quite nice (or some
in-memory or read-only version of it). I guess that would also
squarely fit gnome-document's use case.

Cheers,

-- Thorsten


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: filter/source sd/CppunitTest_sd_import_tests.mk sd/qa

2016-03-19 Thread Thorsten Behrens
 dev/null   |binary
 filter/source/msfilter/svdfppt.cxx |  126 ++---
 sd/CppunitTest_sd_import_tests.mk  |1 
 sd/qa/unit/import-tests.cxx|   51 --
 4 files changed, 90 insertions(+), 88 deletions(-)

New commits:
commit 3445fb9326fb632498cf2123aa1213be40e789c1
Author: Thorsten Behrens <thorsten.behr...@cib.de>
Date:   Sun Mar 20 01:12:56 2016 +0100

Revert "tdf#93124: Fix incorrect text fit in imported PPT"

Change broke autofit feature, see bugreport.

This reverts commit 5ca1f04976930c6fd656ebf89d667c80e2466897.

diff --git a/filter/source/msfilter/svdfppt.cxx 
b/filter/source/msfilter/svdfppt.cxx
index 7765dac..ebea1c2 100644
--- a/filter/source/msfilter/svdfppt.cxx
+++ b/filter/source/msfilter/svdfppt.cxx
@@ -893,6 +893,31 @@ SdrObject* SdrEscherImport::ProcessObj( SvStream& rSt, 
DffObjData& rObjData, voi
 eTHA = SDRTEXTHORZADJUST_LEFT;
 break;
 }
+// if there is a 100% use of following attributes, the 
textbox can been aligned also in vertical direction
+switch ( eTextAnchor )
+{
+case mso_anchorTopCentered :
+case mso_anchorMiddleCentered :
+case mso_anchorBottomCentered :
+case mso_anchorTopCenteredBaseline:
+case mso_anchorBottomCenteredBaseline:
+{
+// check if it is sensible to use the centered 
alignment
+sal_uInt32 nMask = 
PPT_TEXTOBJ_FLAGS_PARA_ALIGNMENT_USED_LEFT | 
PPT_TEXTOBJ_FLAGS_PARA_ALIGNMENT_USED_RIGHT;
+if ( ( nTextFlags & nMask ) != nMask )  // if the 
textobject has left and also right aligned pararagraphs
+eTVA = SDRTEXTVERTADJUST_CENTER;// the 
text has to be displayed using the full width;
+}
+break;
+
+default :
+{
+if ( nTextFlags == 
PPT_TEXTOBJ_FLAGS_PARA_ALIGNMENT_USED_LEFT )
+eTVA = SDRTEXTVERTADJUST_TOP;
+else if ( nTextFlags == 
PPT_TEXTOBJ_FLAGS_PARA_ALIGNMENT_USED_RIGHT )
+eTVA = SDRTEXTVERTADJUST_BOTTOM;
+}
+break;
+}
 nMinFrameWidth = rTextRect.GetWidth() - ( nTextLeft + 
nTextRight );
 }
 else
@@ -924,6 +949,31 @@ SdrObject* SdrEscherImport::ProcessObj( SvStream& rSt, 
DffObjData& rObjData, voi
 eTVA = SDRTEXTVERTADJUST_BOTTOM;
 break;
 }
+// if there is a 100% usage of following attributes, the 
textbox can be aligned also in horizontal direction
+switch ( eTextAnchor )
+{
+case mso_anchorTopCentered :
+case mso_anchorMiddleCentered :
+case mso_anchorBottomCentered :
+case mso_anchorTopCenteredBaseline:
+case mso_anchorBottomCenteredBaseline:
+{
+// check if it is sensible to use the centered 
alignment
+sal_uInt32 nMask = 
PPT_TEXTOBJ_FLAGS_PARA_ALIGNMENT_USED_LEFT | 
PPT_TEXTOBJ_FLAGS_PARA_ALIGNMENT_USED_RIGHT;
+if ( ( nTextFlags & nMask ) != nMask )  // if the 
textobject has left and also right aligned pararagraphs
+eTHA = SDRTEXTHORZADJUST_CENTER;// the 
text has to be displayed using the full width;
+}
+break;
+
+default :
+{
+if ( nTextFlags == 
PPT_TEXTOBJ_FLAGS_PARA_ALIGNMENT_USED_LEFT )
+eTHA = SDRTEXTHORZADJUST_LEFT;
+else if ( nTextFlags == 
PPT_TEXTOBJ_FLAGS_PARA_ALIGNMENT_USED_RIGHT )
+eTHA = SDRTEXTHORZADJUST_RIGHT;
+}
+break;
+}
 nMinFrameHeight = rTextRect.GetHeight() - ( nTextTop + 
nTextBottom );
 }
 
@@ -971,6 +1021,7 @@ SdrObject* SdrEscherImport::ProcessObj( SvStream& rSt, 
DffObjData& rObjData, voi
 }
 aTextObj.SetDestinationInstance( 
(sal_uInt16)nDestinationInstance );
 
+bool bAutoFit = false; // auto-scale text into shape box
 switch ( aTextObj.GetInstance() )
 {
 case TSS

Re: Proposal for using std::unique_ptr to signal transfer of ownership

2016-03-12 Thread Thorsten Behrens
Markus Mohrhard wrote:
> I hope that these are not really controversial [...]
>
Not at all - to state the obvious (and not let the mail linger
unanswered).

Cheers,

-- Thorsten


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: Gerrit supports inline edit feature now

2016-03-07 Thread Thorsten Behrens
David Ostrovsky wrote:
> Yesterday, the right Gerrit version was deployed on gerrit.l.o.
> 
Thanks a whole lot - to all of you for making this happen in the end.

Way cool! :)

Cheers,

-- Thorsten


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: Windows / font / text futures ...

2016-03-07 Thread Thorsten Behrens
Michael Meeks wrote:
>   I missed your mail; please do maintain the CC if you want a prompt
> reply =)
> 
Setting Reply-To would help me to remember that next time. ;)

>   Hmm; the dx array as I understand it is just a simplified form of
> glyph widths; we could use rectangles for those instead of
> non-linear selection handling to be more cute ? ultimately an
> intimate view of text seems quite inevitable to me in writer - but
> I'm no writer expert.
> 
Nah. The problem is that boxes-for-glyphs in a linear array are the
wrong abstraction (it gets quite funky for ltr-rtl and other complex
text layout mixes), and having them integer-only

a) gives you AA-bleed into the next glyph's box, and/or
b) ugly whitespace jumpiness for smaller font sizes (check a line of
   WaWaWaWaW with an 8pt font...)

The way it's implemented (Writer does the layout, passes DX array
down) also *really* kills the nicer font features like alternate
glyphs.

> > >   While we could switch to DirectWrite on windows, which may solve some
> > > of our problems; this will be in itself disruptive.
> >  
> > Incidentally - why that?
> 
>   Switching to DirectWrite ? its a better API cf. the link I gave, it is
> part of the Universal Windows Platform (UWP) - but note that using
> freetype/cairo for rendering is also UWP compatible ;-)
> 
Nah - I meant, why is that in itself disruptive? ;)

> > >   So - I believe that we should switch to using harfbuzz and freetype
> > > consistently everywhere. This would have the huge benefit of precise
> > > cross-platform font rendering and metric fidelity, give us a font and
> > > shaping stack that is fully introspectable, drop some legacy Windows API
> > > usage, and allow all development work and fixing on all platforms to
> > > share the same underlying code.
> > > 
> > I think that promise cannot be kept. 
> 
>   Curious - which promise ? the font rendering and metric fidelity across
> platforms ?
> 
The 'develop once, run everywhere' promise. ;)

> > Let's evaluate the merit of switching to some truly great floss libraries
> > based on other aspects - you're not even getting consistent floating point
> > math between different CPUs, let alone different operating systems...
> 
>   I would hope that the OS' impact on floating point math is rather
> small; I'm also extremely curious about the inconsistent floating point
> math problems people posit here.
>
You're getting different rounding even depending on the flags your OS
(or driver that happens to be in your process) sets. Seriously - I'm
too lazy to dig out references, but consider floating point math to be
inherently non-similar from one box to the next, *unless* you're
extremely careful across the entire calculation chain (which is the
case in Calc).

> IEE754 is pretty helpful - and when it comes to rendering rather
> small glyphs - and accumulating their metrics via a few adds &
> subtracts across any feasible page size - it seems incredible to me
> that this would cause issues.
>
C.f. chart2.

> For sure depending on how the compiler handles the FPU registers we
> could have only 23 bits of fraction instead of the 32 we'd expect to
> retain if left on the GPU - but really ... 2^23 is reasonably large
> for rendering a 40 pixel square glyph surely ? =)
> 
Unless you convert from register to mem and back for every calculation
step, you've no real portable control over intermediate values. And
the precision argument is moot, e.g. when facing catastrophic
cancellation.

>   Now of course for complex text, it's not just rendering simple, US
> ASCII strings - it's a font fallback / shaping nightmare =) but if the
> glyph rendering can work cross-platform, I'm optimistic the shaping can
> too. This underlies my confidence that we can do reliable layout unit
> test across platforms - assuming we can nail down shaping & font code.
> 
Ah well. That's really a re-hash of an old discussion - perhaps
something then for a non-email exchange of ideas. ;)

Anyway - as I wrote to Caolan, if there's a Uniscribe/DirectWrite code
path in your proposed solution, my concerns are moot (the above issues
will remain, but it's no worse than today).

> >  Since I guess for most complaints about layouting problems I hear about,
> > it's the different between MSO and LibreOffice, rather than between 
> > LibreOffice
> > on different platforms. ;)
> 
>   Sure; but unfortunately, the stack is such a mess now that fixing this
> (really non-intuitive) code and/or adding features multiple times and
> testing across  platforms is really a very long way from ideal.
> 
I'm afraid we're in for that regardless. Norbert, Khaled, Tor IIRC & a
number of other hackers all came to the conclusion that the vcl font
API / the way Writer is doing layout is in serious need for rework,
before any amount of font layouting/rendering happiness can be
attained.

Cheers,

-- Thorsten


signature.asc
Description: Digital signature

Re: Windows / font / text futures ...

2016-03-04 Thread Thorsten Behrens
Caolan McNamara wrote:
> On Windows, peer apps like firefox and chromium etc seem to follow
> the pattern of eventually rendering their harfbuzz layouted text
> with the DirectWrite apis, whether directly, or through skia or
> through a forked cairo, that *seems* be where things end up. So that
> seems to be a fairly well trodden route.
> 
Ah, that would address most of my concerns. Shame wrt. the forked
cairo though...

Cheers,

-- Thorsten


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: Physics Engine integration for Libre Office impress

2016-03-04 Thread Thorsten Behrens
Mayank Gupta wrote:
> I'm thinking of BOX2D but since it is only about 2D simulation and
> GSOC 2016 Idea for this project has suggested Bullet Physics too.
>
Nah, 2D is fine for the while.

Cheers,

-- Thorsten


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: Windows / font / text futures ...

2016-03-03 Thread Thorsten Behrens
Hi Michael,

you write:
>   Having looked at this heap; and worse - the two different heaps for
> Windows text rendering, and also the big pile of strange cross-platform
> issues with stacking diacritics, emojis etc. I'm pretty convinced that
> we cannot do a good job of consistent text shaping and/or rendering
> cross-platform while using the Windows font rendering infrastructure.
> 
Yeah, I suppose. But that alone won't fix the kind of issues you show
in your ascii art - as long as so much low-level layouting is still
happening in Writer (dx arrays, kashida filling etc).

>   While we could switch to DirectWrite on windows, which may solve some
> of our problems; this will be in itself disruptive.
> 
Incidentally - why that?

>   So - I believe that we should switch to using harfbuzz and freetype
> consistently everywhere. This would have the huge benefit of precise
> cross-platform font rendering and metric fidelity, give us a font and
> shaping stack that is fully introspectable, drop some legacy Windows API
> usage, and allow all development work and fixing on all platforms to
> share the same underlying code.
> 
I think that promise cannot be kept. Let's evaluate the merit of
switching to some truly great floss libraries based on other aspects -
you're not even getting consistent floating point math between
different CPUs, let alone different operating systems...

>   There will of course also be some corner-cases where we may simply not
> be able to replicate the tangled old layout behaviour - which is
> (anyway) inconsistent across platforms - but - I think this is a one-off
> risk that is well worth taking to get us to a fully consistent, Free
> Software rendering stack. It is interesting that Microsoft also used freetype
> for their Office / Mac rendering in the recent past =)
> 
Oh - got some reference for that? Since I guess for most complaints
about layouting problems I hear about, it's the different between MSO
and LibreOffice, rather than between LibreOffice on different
platforms. ;)

Cheers,

-- Thorsten


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: Perils of purpose UNO environments

2016-02-26 Thread Thorsten Behrens
Michael Stahl wrote:
> well that's what we have *today* - who knows what will be added (or
> "cleaned up") in the future, better add the asserts.
> 
Indeed. Please commit that fix, Stephan.

Cheers,

-- Thorsten


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [libreoffice-projects] minutes of ESC call ...

2016-02-23 Thread Thorsten Behrens
Chris Sherlock wrote:
> However, with the way things work currently what I have noticed is
> actually the thing that is using most space are the tag files. I
> don't quite know how to do things much better (have experimented a
> bit) but the script currently generates tag files and html for each
> module, then as each module is built it references the previously
> generated tag files for the previous modules. After the clew module
> is built I noticed that we start getting massive tag files, over
> 450MB of text.
> 
> I was thinking maybe there might be a way of reworking the script to
> generate a tag file for each module first, then do another pass that
> generates the html from the tag files.
> 
> I don't know if this is feasible: I'm no doxygen expert
> unfortunately. I got this idea from a comment from the doxygen
> creator though, which detailed on Stack Overflow:
> 
> http://stackoverflow.com/questions/8247189/doxygen-is-slow/8247993#8247993
> 
This article addresses the speed of doxygen generation (by
parallelizing the tag file generation). The way it's described I'm
pretty sure you'll end up with the exact same size for the tag files,
just quicker. ;)

Cheers,

-- Thorsten


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: configure.ac

2016-02-20 Thread Thorsten Behrens
 configure.ac |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit c37c82319f88e75ba28fd4b7bf26b5ea01846c17
Author: Thorsten Behrens <thorsten.behr...@cib.de>
Date:   Sat Feb 20 19:05:16 2016 +0100

wget: don't break on CentOS6 baseline

Where this fancy new no-use-server-timestamps is not yet known.

Change-Id: I481c44bb977620400a3dede6191889bbbe5ec74a
Reviewed-on: https://gerrit.libreoffice.org/22546
Tested-by: Jenkins <c...@libreoffice.org>
Reviewed-by: Thorsten Behrens <thorsten.behr...@cib.de>

diff --git a/configure.ac b/configure.ac
index b6f6f37..0a200e6 100644
--- a/configure.ac
+++ b/configure.ac
@@ -12010,9 +12010,9 @@ if test "$enable_fetch_external" != "no"; then
 CURL=`which curl 2>/dev/null`
 
 for i in wget /usr/bin/wget /usr/local/bin/wget /usr/sfw/bin/wget 
/opt/sfw/bin/wget /opt/local/bin/wget; do
-eval "$i --version" > /dev/null 2>&1
-ret=$?
-if test $ret -eq 0; then
+# wget new enough?
+$i --help 2> /dev/null | $GREP no-use-server-timestamps 2>&1 > /dev/null
+if test $? -eq 0; then
 WGET=$i
 break
 fi
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


Re: Problem Building Libreoffice on Linux

2016-02-16 Thread Thorsten Behrens
Hi Pranav,

you write:
> No core file identified in directory
> /mnt/D-Drive/LibreOffice/libreoffice/workdir/CppunitTest/svgio.test.core
> To show backtraces for crashes during test execution,
> enable core files with:
> 
>ulimit -c unlimited
> 
> [CUT] vcl_timer
> 
> Error: a unit test failed, please do one of:
> make CppunitTest_svgio CPPUNITTRACE="gdb --args"
> # for interactive debugging on Linux
> make CppunitTest_svgio VALGRIND=memcheck
> # for memory checking
> make CppunitTest_svgio DEBUGCPPUNIT=TRUE
> # for exception catching
> 
Did you try one of the above suggestions? There are usually three
reasons a unit test would fail:

* something is truly broken on master (compare with red tinderboxes on
  http://tinderbox.libreoffice.org/MASTER/status.html)
* you have a buggy setup (noticing D-Drive in your path above,
  building on a vfat partition from linux is generally not working)
* you are building on a system, or a particular configure switch
  combination, that is not yet supported & will need manual fixing

Your question does not provide enough context to guess which of the
cases you're hitting.

HTH,

-- Thorsten


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: Help on getting started contributing to Libreoffice

2016-02-14 Thread Thorsten Behrens
Jan Iversen wrote:
> I hope one of the our fellow developers have an idea of what can
> cause this Boost problem.
> 
Looks like you're using msvc 2012
(http://lists.boost.org/Archives/boost/2015/07/224122.php). LibreOffice
master requires at least msvc 2013 - if that's not written clearly
enough on
https://wiki.documentfoundation.org/Development/BuildingOnWindows,
please let us know.

Cheers,

-- Thorsten


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: Document with a zero-sized graphic - how to handle?

2016-02-14 Thread Thorsten Behrens
Chris Sherlock wrote:
> I’ve merged this, as it fixes a legitimate issue.
>
Nothing much to say on that, except that sticking zeros into something
that previously never had that & is not inconceivably used for
dividing might get us into some follow-up fun. ;)

> One interesting thing highlighted is that a 0x0 image might be being
> used as a tracker.
>
That's a red herring. Move the graphic off the page, make it all
white, or hide it behind something else, and you don't need zero-size
for tracking...

Cheers,

-- Thorsten


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] dev-tools.git: scripts/qawrangler-stats.py

2016-02-06 Thread Thorsten Behrens
 scripts/qawrangler-stats.py |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 496f22b0c6b9b774ae678f1d69a2cb422267a2a1
Author: Thorsten Behrens <thorsten.behr...@cib.de>
Date:   Sun Feb 7 01:20:14 2016 +0100

Make decode actually work on email archive

diff --git a/scripts/qawrangler-stats.py b/scripts/qawrangler-stats.py
index 8b1c52f..87b123a 100755
--- a/scripts/qawrangler-stats.py
+++ b/scripts/qawrangler-stats.py
@@ -66,7 +66,7 @@ def get_data(url):
 sys.exit(1)
 else:
 with gzip.GzipFile(fileobj=BytesIO(resp.read())) as f:
-return f.read().decode('us-ascii')
+return f.read().decode('utf-8')
 
 def get_entity_values(data, pattern, num):
 """Returns the first @num matches of a @pattern in the @data string. If
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


Re: GSoC application

2016-02-05 Thread Thorsten Behrens
Jan Iversen wrote:
> The window for mentor organizations to apply starts this monday (8th
> feb.). Who is making the Application ?
> 
On my radar.

> This also means that people with ideas should file them now at:
> https://wiki.documentfoundation.org/Development/GSoC/Ideas
> 
Please do *not* add topics there unless you're willing to mentor them
(or know someone who can). This page should stay a list of curated
tasks. New ideas that need vetting / mentor-signup should go here
instead:

https://wiki.documentfoundation.org/Development/GSoC/GenialIdeas

Cheers,

-- Thorsten


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: Program Committee for LibOCon

2016-02-03 Thread Thorsten Behrens
Sophie Gautier wrote:
> As each year, it's time to form the Program Committee. We need at least
> 3 or 4 persons available to review the talks proposed by the community,
> sort and organize them and then manage the conference program.
> 
> *Important note*: you need to be available during July and August as
> these are the months during which we set the program.
> 
I can help, as in the past. :)

Cheers,

-- Thorsten


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] voting.git: 3 commits - vote/2013-board vote/2014-mc vote/2015-board

2016-02-01 Thread Thorsten Behrens
 vote/2013-board/votes.blt |  131 
 vote/2014-mc/votes.blt|  163 ++
 vote/2015-board/votes.blt |  144 
 3 files changed, 438 insertions(+)

New commits:
commit 5bdb390f7536147b07c39aee55ebebe63808b4f1
Author: Thorsten Behrens <t...@documentfoundation.org>
Date:   Mon Feb 1 10:20:22 2016 +0100

Sticking ballot files to git for archival

diff --git a/vote/2015-board/votes.blt b/vote/2015-board/votes.blt
new file mode 100644
index 000..3ebdd5b
--- /dev/null
+++ b/vote/2015-board/votes.blt
@@ -0,0 +1,144 @@
+11 10
+1 2 7 9 3 6 11 4 10 5 1 0
+1 7 4 1 6 9 0
+1 10 4 5 9 0
+1 1 8 11 3 6 9 10 4 0
+1 3 11 6 10 4 9 5 0
+1 3 5 6 4 11 9 7 0
+1 9 10 5 1 3 4 2 11 6 7 0
+1 1 8 0
+1 1 8 11 6 3 4 10 9 5 2 0
+1 11 5 4 6 0
+1 4 10 6 11 1 3 5 8 7 9 0
+1 10 6 3 4 9 7 0
+1 4 9 6 3 5 8 7 2 11 1 0
+1 11 1 9 8 10 4 0
+1 3 9 5 6 0
+1 4 10 3 6 2 5 7 8 1 11 0
+1 5 3 9 4 1 6 11 7 10 0
+1 4 3 5 6 2 1 11 10 9 7 0
+1 1 8 11 6 3 4 10 9 5 2 0
+1 4 9 3 5 6 10 2 11 1 7 0
+1 1 4 11 3 7 6 9 8 10 2 0
+1 5 3 7 6 2 9 11 10 4 0
+1 9 4 6 7 3 10 1 5 2 11 0
+1 7 1 3 9 5 8 11 2 6 4 0
+1 10 1 3 6 4 2 5 9 8 7 0
+1 11 3 4 5 9 7 10 6 1 2 0
+1 4 3 9 5 6 1 8 11 7 10 0
+1 3 6 2 5 1 7 9 8 4 0
+1 3 6 9 5 1 2 11 0
+1 1 8 11 6 3 4 10 9 5 2 0
+1 10 3 6 7 1 0
+1 4 10 3 1 6 2 7 9 8 5 0
+1 5 3 2 1 4 6 9 11 10 7 0
+1 5 2 10 9 4 3 6 11 1 7 0
+1 4 10 5 3 11 6 9 2 1 8 0
+1 1 11 2 4 3 8 10 9 7 5 0
+1 6 3 7 9 1 8 5 2 11 4 0
+1 4 10 5 9 11 0
+1 3 6 5 7 9 2 4 1 11 8 0
+1 4 10 9 3 5 0
+1 1 8 11 6 3 4 10 9 5 2 0
+1 1 8 11 6 3 4 10 9 5 2 0
+1 11 4 3 9 5 6 1 2 10 7 0
+1 4 9 6 3 2 1 5 11 10 8 0
+1 8 1 3 11 4 6 7 5 2 9 0
+1 1 8 11 6 3 4 10 9 5 2 0
+1 7 1 8 2 5 4 3 10 11 9 0
+1 1 0
+1 7 10 3 8 9 6 5 4 0
+1 3 4 5 9 6 10 2 11 1 8 0
+1 1 0
+1 1 8 11 6 4 10 9 2 3 5 0
+1 11 1 8 6 4 9 3 10 2 5 0
+1 4 10 3 9 5 2 1 0
+1 3 10 5 4 9 2 6 7 11 1 0
+1 4 5 9 11 2 10 6 3 7 1 0
+1 3 6 7 11 0
+1 1 8 11 6 3 4 10 9 5 2 0
+1 5 4 2 3 0
+1 9 5 2 3 4 11 6 0
+1 4 9 3 11 7 5 10 0
+1 1 8 11 6 3 4 10 9 5 2 0
+1 11 7 3 10 9 4 6 0
+1 4 11 6 1 8 2 9 3 0
+1 4 10 5 2 9 11 1 0
+1 3 11 9 4 10 5 6 2 0
+1 5 4 1 2 9 10 11 8 7 3 0
+1 4 10 5 11 2 0
+1 1 3 11 2 4 8 10 5 6 7 0
+1 3 9 2 0
+1 3 6 7 2 9 1 5 4 8 0
+1 7 9 0
+1 3 8 11 5 6 4 9 2 10 7 0
+1 4 10 0
+1 4 10 3 7 6 1 5 11 2 8 0
+1 10 8 2 1 11 0
+1 1 8 11 6 3 4 10 9 5 2 0
+1 9 4 11 2 1 5 6 3 10 8 0
+1 7 3 6 4 2 10 0
+1 4 2 9 6 0
+1 1 8 11 3 6 4 0
+1 5 9 10 3 6 7 0
+1 3 9 5 0
+1 9 3 5 6 2 4 11 1 0
+1 1 8 11 3 9 5 6 4 10 2 0
+1 8 1 7 6 9 4 2 3 11 10 0
+1 6 3 4 9 0
+1 1 8 3 11 5 0
+1 3 4 2 10 6 9 1 11 0
+1 1 8 11 3 4 10 6 9 5 0
+1 7 3 6 4 0
+1 4 10 2 5 11 9 0
+1 3 4 6 5 9 10 0
+1 1 8 11 6 3 4 10 9 5 2 0
+1 4 5 1 3 8 11 0
+1 10 1 6 11 0
+1 9 6 5 3 1 2 8 10 4 0
+1 1 8 11 6 3 4 10 9 5 2 0
+1 11 3 4 10 6 9 1 0
+1 10 4 11 1 0
+1 3 6 11 8 1 4 7 10 9 5 0
+1 4 3 6 10 1 0
+1 4 2 10 3 11 6 0
+1 1 4 9 10 8 11 0
+1 9 6 5 8 4 10 11 3 0
+1 3 11 2 6 7 5 9 10 4 0
+1 9 8 7 0
+1 5 4 10 2 3 6 9 11 0
+1 11 3 6 1 10 8 5 2 9 7 0
+1 5 3 9 6 7 0
+1 7 9 6 3 0
+1 1 3 4 11 5 2 6 9 10 7 0
+1 3 9 6 7 5 2 10 4 0
+1 1 8 11 6 3 4 10 9 5 0
+1 3 4 10 1 7 6 0
+1 1 8 11 6 3 4 10 9 5 2 0
+1 9 3 5 2 6 10 11 4 0
+1 4 10 5 9 2 1 11 0
+1 4 11 2 1 10 5 6 3 7 9 0
+1 6 1 2 11 0
+1 5 10 11 3 0
+1 3 6 10 5 11 9 2 4 1 0
+1 4 0
+1 3 4 7 6 10 5 2 9 1 11 0
+1 11 1 4 3 9 6 10 5 8 0
+1 1 11 4 2 8 0
+1 4 11 1 6 8 10 3 5 9 7 0
+1 1 3 10 0
+1 10 3 4 5 6 7 11 9 2 1 0
+1 2 3 1 8 6 10 4 11 0
+0
+"Marina Latini"
+"Joel Madero"
+"Thorsten Behrens"
+"Michael Meeks"
+"Norbert Thiebaud"
+"Björn Michaelsen"
+"Andreas Mantke"
+"Osvaldo Gervasi"
+"Eike Rathke"
+"Jan Holešovský"
+"Simon Phipps"
+"2015 Board of Directors election"
commit 03a41b0d6770c5b9e00bc13b7fb0867f6c5a5af9
Author: Thorsten Behrens <t...@documentfoundation.org>
Date:   Mon Feb 1 10:19:59 2016 +0100

Sticking ballot files to git for archival

diff --git a/vote/2014-mc/votes.blt b/vote/2014-mc/votes.blt
new file mode 100644
index 000..2414e70
--- /dev/null
+++ b/vote/2014-mc/votes.blt
@@ -0,0 +1,163 @@
+15 7
+1 1 4 15 13 2 7 12 0
+1 2 4 6 12 1 9 0
+1 7 4 2 12 11 9 10 0
+1 4 12 5 9 10 7 8 0
+1 2 13 12 9 0
+1 10 1 9 4 0
+1 9 4 8 1 0
+1 1 13 8 3 9 4 5 0
+1 15 9 7 8 13 10 4 0
+1 13 8 14 7 10 0
+1 10 1 13 6 8 12 4 0
+1 12 5 1 0
+1 3 9 13 4 15 8 14 0
+1 15 9 7 10 8 5 13 0
+1 15 9 7 10 8 5 13 0
+1 1 10 7 14 4 8 13 0
+1 2 8 10 7 3 1 0
+1 15 9 7 3 4 0
+1 8 13 10 5 4 1 7 0
+1 9 1 10 3 5 0
+1 12 6 4 11 7 1 3 0
+1 7 11 0
+1 1 4 15 13 9 7 12 0
+1 2 6 12 1 5 4 9 0
+1 13 8 14 4 7 0
+1 7 9 11 8 14 4 2 0
+1 13 7 9 8 5 3 10 0
+1 9 4 5 10 8 7 3 0
+1 1 9 14 4 6 11 3 0
+1 14 9 13 0
+1 1 4 9 10 5 7 8 0
+1 15 9 13 7 10 5 8 0
+1 10 1 4 9 13 2 8 0
+1 1 6 15 3 7 8 4 0
+1 1 10 7 13 4 11 15 0
+1 4 9 10 13 8 7 5 0
+1 8 13 4 7 14 0
+1 5 4 2 15 10 3 11 0
+1 11 8 4 13 12 14 5 0
+1 1 14 13 8 0
+1 10 1 2 4 8 3 9 0
+1 13 7 8 4 3 11 1

[Libreoffice-commits] core.git: i18npool/Library_localedata_euro.mk

2016-01-22 Thread Thorsten Behrens
 i18npool/Library_localedata_euro.mk |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit a6c8b41c4df79183c5d2c1450c010768ac7d82f6
Author: Thorsten Behrens <thorsten.behr...@cib.de>
Date:   Sat Jan 23 01:23:58 2016 +0100

i18npool: fix build

Looks like 72c5e230f9cda8e18f63f7bbc6567487b4c5a5e0 missed the
makefile change.

Change-Id: I2d887ca6cb6c698fdb2d24029f38cce6050e0881

diff --git a/i18npool/Library_localedata_euro.mk 
b/i18npool/Library_localedata_euro.mk
index 9b5aaae..caece13 100644
--- a/i18npool/Library_localedata_euro.mk
+++ b/i18npool/Library_localedata_euro.mk
@@ -36,7 +36,7 @@ $(eval $(call 
gb_Library_add_generated_exception_objects,localedata_euro,\
CustomTarget/i18npool/localedata/localedata_dsb_DE \
CustomTarget/i18npool/localedata/localedata_el_GR \
CustomTarget/i18npool/localedata/localedata_et_EE \
-   CustomTarget/i18npool/localedata/localedata_eu \
+   CustomTarget/i18npool/localedata/localedata_eu_ES \
CustomTarget/i18npool/localedata/localedata_fi_FI \
CustomTarget/i18npool/localedata/localedata_fo_FO \
CustomTarget/i18npool/localedata/localedata_fr_BE \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


Re: [Libreoffice-commits] core.git: scp2/InstallModule_ooo.mk

2016-01-19 Thread Thorsten Behrens
Hi Pranav,

can you review the below commit - your scp2 changes broke Windows
packaging.

Thanks, Thorsten

libreoffice-comm...@lists.freedesktop.org wrote:
>  scp2/InstallModule_ooo.mk |4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> New commits:
> commit 8a99e4b0de7a516b8577d34dd39296afda604290
> Author: Thorsten Behrens <thorsten.behr...@cib.de>
> Date:   Wed Jan 20 01:47:37 2016 +0100
> 
> No LOKDocView packaging for Win/Mac for the while
> 
> This unbreaks Windows packaging after
> 85b46f51928dc17cda1bc974bca9159de9221b4d - I guess this should be
> Linux-only for the moment.
> 
> Change-Id: Ie19f7f3e4b611e2884e3fdb1a64c63927b018989
> 
> diff --git a/scp2/InstallModule_ooo.mk b/scp2/InstallModule_ooo.mk
> index 47c8cc6..2f4320b 100644
> --- a/scp2/InstallModule_ooo.mk
> +++ b/scp2/InstallModule_ooo.mk
> @@ -103,7 +103,9 @@ $(eval $(call gb_InstallModule_add_scpfiles,scp2/ooo,\
>   scp2/source/ooo/mingw_dlls \
>   ) \
>  scp2/source/ooo/module_filter \
> -scp2/source/ooo/module_libreofficekit \
> +$(if $(filter-out MACOSX WNT,$(OS)), \
> + scp2/source/ooo/module_libreofficekit \
> + ) \
>  ))
>  
>  $(eval $(call gb_InstallModule_add_localized_scpfiles,scp2/ooo,\


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: writerfilter/source

2016-01-19 Thread Thorsten Behrens
 writerfilter/source/dmapper/StyleSheetTable.cxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit b4f60e1c7c68a6e2a8b295aeffb85573b61ad045
Author: Thorsten Behrens <thorsten.behr...@cib.de>
Date:   Wed Jan 20 02:39:21 2016 +0100

writerfilter: fix VS2015 build

Change-Id: I9cde0ecf2c883b977df4f633e5106d39628444ca

diff --git a/writerfilter/source/dmapper/StyleSheetTable.cxx 
b/writerfilter/source/dmapper/StyleSheetTable.cxx
index c6d1ef3..428ba2b 100644
--- a/writerfilter/source/dmapper/StyleSheetTable.cxx
+++ b/writerfilter/source/dmapper/StyleSheetTable.cxx
@@ -25,6 +25,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: scp2/InstallModule_ooo.mk

2016-01-19 Thread Thorsten Behrens
 scp2/InstallModule_ooo.mk |4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit 8a99e4b0de7a516b8577d34dd39296afda604290
Author: Thorsten Behrens <thorsten.behr...@cib.de>
Date:   Wed Jan 20 01:47:37 2016 +0100

No LOKDocView packaging for Win/Mac for the while

This unbreaks Windows packaging after
85b46f51928dc17cda1bc974bca9159de9221b4d - I guess this should be
Linux-only for the moment.

Change-Id: Ie19f7f3e4b611e2884e3fdb1a64c63927b018989

diff --git a/scp2/InstallModule_ooo.mk b/scp2/InstallModule_ooo.mk
index 47c8cc6..2f4320b 100644
--- a/scp2/InstallModule_ooo.mk
+++ b/scp2/InstallModule_ooo.mk
@@ -103,7 +103,9 @@ $(eval $(call gb_InstallModule_add_scpfiles,scp2/ooo,\
scp2/source/ooo/mingw_dlls \
) \
 scp2/source/ooo/module_filter \
-scp2/source/ooo/module_libreofficekit \
+$(if $(filter-out MACOSX WNT,$(OS)), \
+   scp2/source/ooo/module_libreofficekit \
+   ) \
 ))
 
 $(eval $(call gb_InstallModule_add_localized_scpfiles,scp2/ooo,\
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


Re: VCL question

2016-01-18 Thread Thorsten Behrens
Tor Lillqvist wrote:
> Well the "sv" stands for StarView, I am fairly sure. The "p" might
> mean "pseudo" or "pixmap"?
> 
plugin.

Cheers,

-- Thorsten


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - svx/source

2016-01-13 Thread Thorsten Behrens
 svx/source/xml/xmlgrhlp.cxx |   28 +++-
 1 file changed, 27 insertions(+), 1 deletion(-)

New commits:
commit cb72051d70a844077363d52a1a54d083136cde03
Author: Thorsten Behrens <thorsten.behr...@cib.de>
Date:   Mon Dec 7 23:40:39 2015 +0100

Related: tdf#71622 compress more gfx in odf streams

Except for jpeg and png, most natively-stored image fileformats compress
rather well with zlib. adding a number of vector and pixel formats.

Change-Id: I97407a98f620520b0d11552911d2339bf004dc5b
Reviewed-on: https://gerrit.libreoffice.org/20461
Tested-by: Jenkins <c...@libreoffice.org>
Reviewed-by: Thorsten Behrens <thorsten.behr...@cib.de>
(cherry picked from commit ad0edc184792f3aa3f72e8d4ec8b76c3d1bf8479)
Reviewed-on: https://gerrit.libreoffice.org/20467
Reviewed-by: Michael Stahl <mst...@redhat.com>
Tested-by: Michael Stahl <mst...@redhat.com>
(cherry picked from commit 26f62c80aa3684301e29dd17f9efba1bcd68264d)
Reviewed-on: https://gerrit.libreoffice.org/21438

diff --git a/svx/source/xml/xmlgrhlp.cxx b/svx/source/xml/xmlgrhlp.cxx
index fa21c17..5c7b0ff 100644
--- a/svx/source/xml/xmlgrhlp.cxx
+++ b/svx/source/xml/xmlgrhlp.cxx
@@ -533,7 +533,33 @@ bool SvXMLGraphicHelper::ImplWriteGraphic( const OUString& 
rPictureStorageName,
 xProps->setPropertyValue( "MediaType", aAny );
 }
 
-const bool bCompressed = aMimeType.isEmpty() || aMimeType == 
"image/tiff" || aMimeType == "image/svg+xml";
+// picture formats that actuall _do_ benefit from zip
+// storage compression
+// .svm pics gets compressed via ZBITMAP old-style stream
+// option below
+static const char* aCompressiblePics[] =
+{
+"image/svg+xml",
+"image/x-wmf",
+"image/tiff",
+"image/x-eps",
+"image/bmp",
+"image/x-pict"
+};
+
+bool bCompressed = aMimeType.isEmpty();
+if( !bCompressed )
+{
+for( size_t i = 0; i < SAL_N_ELEMENTS(aCompressiblePics); ++i )
+{
+if( 
aMimeType.equalsIgnoreAsciiCaseAscii(aCompressiblePics[i]) )
+{
+bCompressed = true;
+break;
+}
+}
+}
+
 aAny <<= bCompressed;
 xProps->setPropertyValue( "Compressed", aAny );
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


Re: virus detection with GData

2016-01-06 Thread Thorsten Behrens
jan iversen wrote:
> OK I stand corrected, but my proposal is the same, because it still
> informs people, that this is not something to worry about.
> 
What would be your proposed naming scheme?

Cheers,

-- Thorsten


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: Stopping LibreOffice related activities

2016-01-06 Thread Thorsten Behrens
Cedric Bosdonnat wrote:
> You surely have remarked that I don't have much time for LibreOffice
> these times. I'm announcing you that I'm retiring from any LibreOffice
> activity since I couldn't handle them properly. That includes GSoC
> administration.
> 
> Continue the nice work and see you perhaps in an opensource event
> someday.
> 
Hi Cedric,

thanks so much for everything, including tedious GSoC admin stuff &
running after people (including me ;)) - always fair winds, and I'm
sure we'll meet again! :)

Looking forward to that, all the best,

-- Thorsten


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: Remove ActiveX from LibreOffice

2015-12-31 Thread Thorsten Behrens
Mark Hung wrote:
> A valid use case is to read the uploaded documents on SharePoint server in
> intranet.
> Eventually it obsoletes, but I prefer to consider this when facing some
> directly related event.
>  ( i.e EOL of Windows7, new toolchain ceasing ActiveX support, or security
> issue which lacks of engineer resource ) .
> 
Yeah. Unless this is not working anywhere anymore, let's keep it for
the while - seems it's useful at least in some cases. And the cost of
maintaining it is currently near zero, no?

Cheers,

-- Thorsten


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: Branch 'libreoffice-5-1' - javaunohelper/com

2015-12-21 Thread Thorsten Behrens
 javaunohelper/com/sun/star/comp/helper/Bootstrap.java |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit c40c24e9ce333924952d6b1c643a4cc9a3f859af
Author: Thorsten Behrens <thorsten.behr...@cib.de>
Date:   Tue Dec 22 02:27:08 2015 +0100

related tdf#86784: fix since string for new API

Change-Id: I36185eb04864da497d3c3ebf3fe95f732b36

diff --git a/javaunohelper/com/sun/star/comp/helper/Bootstrap.java 
b/javaunohelper/com/sun/star/comp/helper/Bootstrap.java
index 475b84b..17e0d6d 100644
--- a/javaunohelper/com/sun/star/comp/helper/Bootstrap.java
+++ b/javaunohelper/com/sun/star/comp/helper/Bootstrap.java
@@ -106,7 +106,7 @@ public class Bootstrap {
  *
  * @return an array of default commandline options
  * @see #bootstrap( String[] )
- * @since UDK 5.1.0
+ * @since LibreOffice 5.1
  */
 public static final String[] getDefaultOptions()
 {
@@ -289,7 +289,7 @@ public class Bootstrap {
  * @see #getDefaultOptions()
  * @return a bootstrapped component context.
  *
- * @since UDK 5.1.0
+ * @since LibreOffice 5.1
  */
 public static final XComponentContext bootstrap( String[] argArray )
 throws BootstrapException {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: javaunohelper/com

2015-12-21 Thread Thorsten Behrens
 javaunohelper/com/sun/star/comp/helper/Bootstrap.java |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 77a202cbbf3735a6007ceb09f96f5e9258ef6df2
Author: Thorsten Behrens <thorsten.behr...@cib.de>
Date:   Mon Dec 21 18:26:14 2015 +0100

related tdf#86784: new API got backported to 5.1

Change-Id: Id195e487a029424e490008915f0df513a32b22b0

diff --git a/javaunohelper/com/sun/star/comp/helper/Bootstrap.java 
b/javaunohelper/com/sun/star/comp/helper/Bootstrap.java
index 263398f..2f9b0d4 100644
--- a/javaunohelper/com/sun/star/comp/helper/Bootstrap.java
+++ b/javaunohelper/com/sun/star/comp/helper/Bootstrap.java
@@ -106,7 +106,7 @@ public class Bootstrap {
  *
  * @return an array of default commandline options
  * @see #bootstrap( String[] )
- * @since LibreOffice 5.2
+ * @since LibreOffice 5.1
  */
 public static final String[] getDefaultOptions()
 {
@@ -289,7 +289,7 @@ public class Bootstrap {
  * @see #getDefaultOptions()
  * @return a bootstrapped component context.
  *
- * @since LibreOffice 5.2
+ * @since LibreOffice 5.1
  */
 public static final XComponentContext bootstrap( String[] argArray )
 throws BootstrapException {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: solenv/maven

2015-12-20 Thread Thorsten Behrens
 solenv/maven/README.md |   35 +++
 1 file changed, 23 insertions(+), 12 deletions(-)

New commits:
commit 9317861e64175dd0b43e579aab57fca76e5c3393
Author: Thorsten Behrens <thorsten.behr...@cib.de>
Date:   Sun Dec 20 14:37:20 2015 +0100

solenv: clarify maven/buck/jar upload howto

Change-Id: Ia8897583ad88f30dfcfbbb36c8d37632bc2877ce

diff --git a/solenv/maven/README.md b/solenv/maven/README.md
index 6294568..3ff8a13 100644
--- a/solenv/maven/README.md
+++ b/solenv/maven/README.md
@@ -6,10 +6,11 @@ API to Maven Central or local Maven repository.
 To install LibreOffice API to local Maven repository or deploy the API
 to the Maven Central, extra build toolchain is required.
 
-`Ant` is used to bootstrap `Buck` build tool. `Buck` build tool is used to
-build sources and javadocs for the API and install or deploy the artifacts
-to Maven repository. `Maven` commands are invoked for that from within
-`Buck` driven build. To be able to upload the API to Maven Central, access
+`Ant` is used to bootstrap `Buck` build tool. `Buck` build tool is
+used to build sources and javadocs for the API and install or deploy
+the artifacts to Maven repository. `Maven` commands are invoked for
+that from within `Buck` driven build - so make sure you've maven
+installed, too. To be able to upload the API to Maven Central, access
 must be granted to LibreOffice project on OSSRH.
 
 
@@ -173,11 +174,15 @@ account to be able to upload artifacts to Maven Central.
 * Configure your Sonatype user and password in `~/.m2/settings.xml`:
 
 
-
-  sonatype-nexus-staging
-  USER
-  PASSWORD
-
+
+  
+
+ sonatype-nexus-staging
+ USER
+ PASSWORD
+   
+  
+
 
 
 * Request permissions to upload artifacts to the `org.libreoffice`
@@ -202,7 +207,9 @@ while until it is visible to the Sonatype server.
 The PGP key is needed to be able to sign the artifacts before the
 upload to Maven Central.
 
-The PGP passphrase can be put in `~/.m2/settings.xml`:
+The PGP passphrase can be put in `~/.m2/settings.xml`, or
+alternatively make gpg use the agent to provide and cache the
+credentials:
 
 
 
@@ -212,6 +219,8 @@ The PGP passphrase can be put in `~/.m2/settings.xml`:
   
 gpg2
 mypassphrase
+mykeynameoremail
+true
   
 
   
@@ -246,10 +255,12 @@ Build LibreOffice as usually, so that API JARs are 
created.
 
 == Publish the LibreOffice artifacts to local Maven repository
 
-Execute this command to install LibreOffice API to local Maven repository:
+Execute this command to install LibreOffice API to your local Maven
+repository. For troubleshooting, the environment variable `VERBOSE`
+can be set:
 
 
-  buck build api_install
+  VERBOSE=1 buck build api_install
 
 
 Once executed, he local Maven respoitory contains the LibreOffice API
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: cui/Library_cui.mk cui/source include/sfx2 sc/source sd/source sfx2/Library_sfx.mk sfx2/source svx/Library_svx.mk svx/source sw/source

2015-12-17 Thread Thorsten Behrens
 cui/Library_cui.mk |1 
 cui/source/dialogs/insdlg.cxx  |  127 --
 cui/source/factory/dlgfact.cxx |2 
 include/sfx2/docfilt.hxx   |1 
 sc/source/ui/drawfunc/fuins2.cxx   |   38 
 sd/source/ui/func/fuinsert.cxx |   39 
 sfx2/Library_sfx.mk|1 
 sfx2/source/appl/app.cxx   |1 
 sfx2/source/doc/plugin.cxx |  317 -
 svx/Library_svx.mk |1 
 svx/source/dialog/pfiledlg.cxx |  186 -
 sw/source/uibase/shells/textsh.cxx |   40 
 12 files changed, 754 deletions(-)

New commits:
commit 06726aa39eaeba71701742d28a1a81bd1574f883
Author: Thorsten Behrens <thorsten.behr...@cib.de>
Date:   Thu Dec 17 19:30:22 2015 +0100

[API CHANGE] Remove NPAPI-related UNO API

Follow-up to 4c18af27bf95b332ee2006cfc0bbf469fb1a84d4, related to
tdf#96398, removing more client code. The following published
interfaces are removed:

com::sun::star::mozilla::XPluginInstance
com::sun::star::mozilla::XPluginInstanceNotifySink
com::sun::star::mozilla::XPluginInstancePeer
com::sun::star::mozilla::XPluginInstanceSyncPeer
com::sun::star::mozilla::XPluginWindowPeer
com::sun::star::plugin::PluginDescription
com::sun::star::plugin::PluginException
com::sun::star::plugin::PluginManager
com::sun::star::plugin::PluginMode
com::sun::star::plugin::PluginVariable
com::sun::star::plugin::XPlugin
com::sun::star::plugin::XPluginContext
com::sun::star::plugin::XPluginManager

Change-Id: I3818a23e0f46fd01bfe9be11b57f6a551c013441
Reviewed-on: https://gerrit.libreoffice.org/20780
Reviewed-by: Thorsten Behrens <thorsten.behr...@cib.de>
    Tested-by: Thorsten Behrens <thorsten.behr...@cib.de>

diff --git a/cui/Library_cui.mk b/cui/Library_cui.mk
index 85a9bf0..86cc379 100644
--- a/cui/Library_cui.mk
+++ b/cui/Library_cui.mk
@@ -112,7 +112,6 @@ $(eval $(call gb_Library_add_exception_objects,cui,\
 cui/source/dialogs/newtabledlg \
 cui/source/dialogs/passwdomdlg \
 cui/source/dialogs/pastedlg \
-cui/source/dialogs/plfilter \
 cui/source/dialogs/postdlg \
 cui/source/dialogs/scriptdlg \
 cui/source/dialogs/sdrcelldlg \
diff --git a/cui/source/dialogs/insdlg.cxx b/cui/source/dialogs/insdlg.cxx
index f47208b..c85e392 100644
--- a/cui/source/dialogs/insdlg.cxx
+++ b/cui/source/dialogs/insdlg.cxx
@@ -359,133 +359,6 @@ uno::Reference< io::XInputStream > 
SvInsertOleDlg::GetIconIfIconified( OUString*
 return uno::Reference< io::XInputStream >();
 }
 
-IMPL_LINK_NOARG_TYPED(SvInsertPlugInDialog, BrowseHdl, Button*, void)
-{
-Sequence< OUString > aFilterNames, aFilterTypes;
-fillNetscapePluginFilters( aFilterNames, aFilterTypes );
-
-Reference< XComponentContext > xContext( 
::comphelper::getProcessComponentContext() );
-Reference< XFilePicker3 > xFilePicker = 
ui::dialogs::FilePicker::createWithMode( xContext, 
ui::dialogs::TemplateDescription::FILEOPEN_SIMPLE );
-
-// add the filters
-try
-{
-const OUString* pNames = aFilterNames.getConstArray();
-const OUString* pTypes = aFilterTypes.getConstArray();
-for( int i = 0; i < aFilterNames.getLength(); i++ )
-xFilePicker->appendFilter( pNames[i], pTypes[i] );
-}
-catch( IllegalArgumentException& )
-{
-DBG_ASSERT( false, "caught IllegalArgumentException when registering 
filter\n" );
-}
-
-if( xFilePicker->execute() == ExecutableDialogResults::OK )
-{
-Sequence< OUString > aPathSeq( xFilePicker->getSelectedFiles() );
-INetURLObject aObj( aPathSeq[0] );
-m_pEdFileurl->SetText(aObj.PathToFileName());
-}
-}
-
-
-
-SvInsertPlugInDialog::SvInsertPlugInDialog(vcl::Window* pParent,
-const uno::Reference < embed::XStorage >& xStorage)
-: InsertObjectDialog_Impl(pParent, "InsertPluginDialog", 
"cui/ui/insertplugin.ui", xStorage)
-, m_pURL(nullptr)
-{
-get(m_pEdFileurl, "urled");
-get(m_pBtnFileurl, "urlbtn");
-get(m_pEdPluginsOptions, "pluginoptions");
-m_pBtnFileurl->SetClickHdl(LINK(this, SvInsertPlugInDialog, BrowseHdl));
-}
-
-SvInsertPlugInDialog::~SvInsertPlugInDialog()
-{
-disposeOnce();
-}
-
-void SvInsertPlugInDialog::dispose()
-{
-delete m_pURL;
-m_pURL = nullptr;
-m_pEdFileurl.clear();
-m_pBtnFileurl.clear();
-m_pEdPluginsOptions.clear();
-InsertObjectDialog_Impl::dispose();
-}
-
-static void Plugin_ImplFillCommandSequence( const OUString& aCommands, 
uno::Sequence< beans::PropertyValue >& aCommandSequence )
-{
-sal_Int32 nEaten;
-SvCommandList aLst;
-aLst.AppendCommands( aCommands,  );
-
-const size_t nCount = aLst.size();
-aCommandSequence.realloc( nCount );
-f

[Libreoffice-commits] core.git: cui/source include/svx officecfg/registry sc/source sd/source sfx2/util slideshow/source sw/source vbahelper/inc

2015-12-17 Thread Thorsten Behrens
 cui/source/dialogs/insdlg.cxx   |1 
 cui/source/dialogs/plfilter.cxx |  117 
 cui/source/dialogs/plfilter.hxx |   34 ---
 include/svx/pfiledlg.hxx|   51 -
 officecfg/registry/data/org/openoffice/Office/Embedding.xcu |   14 -
 sc/source/ui/drawfunc/fuins2.cxx|1 
 sc/source/ui/view/tabvwshb.cxx  |2 
 sd/source/ui/func/fuinsert.cxx  |2 
 sd/source/ui/view/drviews7.cxx  |1 
 sfx2/util/sfx.component |4 
 slideshow/source/engine/shapes/shapeimporter.cxx|   18 -
 sw/source/uibase/shells/textsh.cxx  |1 
 vbahelper/inc/pch/precompiled_msforms.hxx   |1 
 13 files changed, 2 insertions(+), 245 deletions(-)

New commits:
commit 42645fe67cac22e9a96bc4b34c4f85c09185d9d2
Author: Thorsten Behrens <thorsten.behr...@cib.de>
Date:   Fri Dec 18 02:30:18 2015 +0100

related tdf#96398 pull out more NPAPI-related code

Fixup windows PCH plus pulling out more code now unused due to NPAPI
removal. Follow-up to 4c18af27bf95b332ee2006cfc0bbf469fb1a84d4.

Change-Id: I8ad42a28139ceeab0cae1f608d55beb28c159db3
Reviewed-on: https://gerrit.libreoffice.org/20783
Reviewed-by: Thorsten Behrens <thorsten.behr...@cib.de>
    Tested-by: Thorsten Behrens <thorsten.behr...@cib.de>

diff --git a/cui/source/dialogs/insdlg.cxx b/cui/source/dialogs/insdlg.cxx
index c85e392..3d8466d 100644
--- a/cui/source/dialogs/insdlg.cxx
+++ b/cui/source/dialogs/insdlg.cxx
@@ -33,7 +33,6 @@
 #include 
 
 #include "insdlg.hxx"
-#include 
 #include 
 #include 
 
diff --git a/cui/source/dialogs/plfilter.cxx b/cui/source/dialogs/plfilter.cxx
deleted file mode 100644
index cdb606f..000
--- a/cui/source/dialogs/plfilter.cxx
+++ /dev/null
@@ -1,117 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- *
- * This file incorporates work covered by the following license notice:
- *
- *   Licensed to the Apache Software Foundation (ASF) under one or more
- *   contributor license agreements. See the NOTICE file distributed
- *   with this work for additional information regarding copyright
- *   ownership. The ASF licenses this file to you under the Apache
- *   License, Version 2.0 (the "License"); you may not use this file
- *   except in compliance with the License. You may obtain a copy of
- *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
- */
-
-#include 
-#include 
-#include 
-
-#include 
-
-#include 
-#include 
-#include 
-#include 
-
-#include 
-
-using namespace std;
-using namespace com::sun::star::uno;
-using namespace com::sun::star::lang;
-using namespace com::sun::star::plugin;
-
-struct ltstr
-{
-bool operator()( const OUString& s1, const OUString& s2 ) const
-{
-return s1.compareTo( s2 ) < 0;
-}
-};
-
-typedef set< OUString, ltstr > StrSet;
-typedef map< OUString, StrSet, ltstr > FilterMap;
-
-
-
-void fillNetscapePluginFilters( Sequence< OUString >& rPluginNames, Sequence< 
OUString >& rPluginTypes )
-{
-Reference< XComponentContext > xContext = 
comphelper::getProcessComponentContext();
-Reference< XPluginManager > xPMgr( PluginManager::create(xContext) );
-
-FilterMap aMap;
-
-// sum up the mimetypes: one description, multiple extensions
-
-Sequence aDescriptions( xPMgr->getPluginDescriptions() 
);
-const PluginDescription * pDescriptions = aDescriptions.getConstArray();
-for ( sal_uInt32 nPos = aDescriptions.getLength(); nPos--; )
-{
-const PluginDescription & rDescr = pDescriptions[nPos];
-
-// consistency check for the do {} while loop below
-if (rDescr.Extension.isEmpty())
-continue;
-
-StrSet& rTypes = aMap[ rDescr.Description ];
-OUString aExtension( rDescr.Extension );
-
-sal_Int32 nIndex = 0;
-do
-{
-// no default plugins anymore
-const OUString aExt( aExtension.getToken( 0, ';', nIndex ) );
-if ( aExt != "*.*" )
-rTypes.insert( aExt );
-}
-while ( nIndex >= 0 );
-}
-
-rPluginNames = Sequence< OUString >( aMap.size() );
-rPluginTypes = Sequence< OUString >( aMap.size() );
-OUString* pPluginNames = rPluginNames.getArray();
-OUString* pPluginTypes = rPluginTypes.getArray();
-int nIndex = 

Re: Two svg import filters

2015-12-15 Thread Thorsten Behrens
Michael Stahl wrote:
> i don't claim to know anything about SVG, but i just noticed that
> filter/source/svg uses boost::spirit, and therefore i am +1 for
> removing it.
> 
That's so far the strongest case for removal here. ;)

Other than that, the two filters serve two very different purposes -
the document filter actually tries to map svg as well as possible to
ODF (it would work even better if LibreOffice's ODF filter would
support more of the syntax and semantics of SVG), to get *editable*
graphics.

As such, replacing the document importer with something that sticks
the image into a graphic object is missing the point IMO.

Cheers,

-- Thorsten


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: Branch 'libreoffice-5-1' - svx/source

2015-12-08 Thread Thorsten Behrens
 svx/source/xml/xmlgrhlp.cxx |   28 +++-
 1 file changed, 27 insertions(+), 1 deletion(-)

New commits:
commit 26f62c80aa3684301e29dd17f9efba1bcd68264d
Author: Thorsten Behrens <thorsten.behr...@cib.de>
Date:   Mon Dec 7 23:40:39 2015 +0100

Related: tdf#71622 compress more gfx in odf streams

Except for jpeg and png, most natively-stored image fileformats compress
rather well with zlib. adding a number of vector and pixel formats.

Change-Id: I97407a98f620520b0d11552911d2339bf004dc5b
Reviewed-on: https://gerrit.libreoffice.org/20461
Tested-by: Jenkins <c...@libreoffice.org>
Reviewed-by: Thorsten Behrens <thorsten.behr...@cib.de>
(cherry picked from commit ad0edc184792f3aa3f72e8d4ec8b76c3d1bf8479)
Reviewed-on: https://gerrit.libreoffice.org/20467
Reviewed-by: Michael Stahl <mst...@redhat.com>
Tested-by: Michael Stahl <mst...@redhat.com>

diff --git a/svx/source/xml/xmlgrhlp.cxx b/svx/source/xml/xmlgrhlp.cxx
index da12446..58cd9b4 100644
--- a/svx/source/xml/xmlgrhlp.cxx
+++ b/svx/source/xml/xmlgrhlp.cxx
@@ -534,7 +534,33 @@ bool SvXMLGraphicHelper::ImplWriteGraphic( const OUString& 
rPictureStorageName,
 xProps->setPropertyValue( "MediaType", aAny );
 }
 
-const bool bCompressed = aMimeType.isEmpty() || aMimeType == 
"image/tiff" || aMimeType == "image/svg+xml";
+// picture formats that actuall _do_ benefit from zip
+// storage compression
+// .svm pics gets compressed via ZBITMAP old-style stream
+// option below
+static const char* aCompressiblePics[] =
+{
+"image/svg+xml",
+"image/x-wmf",
+"image/tiff",
+"image/x-eps",
+"image/bmp",
+"image/x-pict"
+};
+
+bool bCompressed = aMimeType.isEmpty();
+if( !bCompressed )
+{
+for( size_t i = 0; i < SAL_N_ELEMENTS(aCompressiblePics); ++i )
+{
+if( 
aMimeType.equalsIgnoreAsciiCaseAscii(aCompressiblePics[i]) )
+{
+bCompressed = true;
+break;
+}
+}
+}
+
 aAny <<= bCompressed;
 xProps->setPropertyValue( "Compressed", aAny );
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


Re: Automation Test for LibreOffice

2015-12-08 Thread Thorsten Behrens
Michael Stahl wrote:
> uhm, isn't Selenium a tool to test web applications running in a
> browser, and nothing else?  how exactly do you suggest to use it for
> testing LO?
> 
https://github.com/cisco-open-source/qtwebdriver claims it's also
supporting Qt apps...

Cheers,

-- Thorsten


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: svx/source

2015-12-07 Thread Thorsten Behrens
 svx/source/xml/xmlgrhlp.cxx |   28 +++-
 1 file changed, 27 insertions(+), 1 deletion(-)

New commits:
commit ad0edc184792f3aa3f72e8d4ec8b76c3d1bf8479
Author: Thorsten Behrens <thorsten.behr...@cib.de>
Date:   Mon Dec 7 23:40:39 2015 +0100

Related: tdf#71622 compress more gfx in odf streams

Except for jpeg and png, most natively-stored image fileformats compress
rather well with zlib. adding a number of vector and pixel formats.

Change-Id: I97407a98f620520b0d11552911d2339bf004dc5b
Reviewed-on: https://gerrit.libreoffice.org/20461
Tested-by: Jenkins <c...@libreoffice.org>
Reviewed-by: Thorsten Behrens <thorsten.behr...@cib.de>

diff --git a/svx/source/xml/xmlgrhlp.cxx b/svx/source/xml/xmlgrhlp.cxx
index da12446..58cd9b4 100644
--- a/svx/source/xml/xmlgrhlp.cxx
+++ b/svx/source/xml/xmlgrhlp.cxx
@@ -534,7 +534,33 @@ bool SvXMLGraphicHelper::ImplWriteGraphic( const OUString& 
rPictureStorageName,
 xProps->setPropertyValue( "MediaType", aAny );
 }
 
-const bool bCompressed = aMimeType.isEmpty() || aMimeType == 
"image/tiff" || aMimeType == "image/svg+xml";
+// picture formats that actuall _do_ benefit from zip
+// storage compression
+// .svm pics gets compressed via ZBITMAP old-style stream
+// option below
+static const char* aCompressiblePics[] =
+{
+"image/svg+xml",
+"image/x-wmf",
+"image/tiff",
+"image/x-eps",
+"image/bmp",
+"image/x-pict"
+};
+
+bool bCompressed = aMimeType.isEmpty();
+if( !bCompressed )
+{
+for( size_t i = 0; i < SAL_N_ELEMENTS(aCompressiblePics); ++i )
+{
+if( 
aMimeType.equalsIgnoreAsciiCaseAscii(aCompressiblePics[i]) )
+{
+bCompressed = true;
+break;
+}
+}
+}
+
 aAny <<= bCompressed;
 xProps->setPropertyValue( "Compressed", aAny );
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


Re: Bad HTML output

2015-12-05 Thread Thorsten Behrens
Alexander wrote:
> Please, make just and good quality HTML output: or as be before, or
> remake with select HTML (html 4, xhtml, html5) versions and select
> by user embed/separate images with.  Embed images in HTML without
> select possibility -- it is wrong way.
> 
Hi Alexander,

this is the developer list - Regina already pointed out two bugs about
this issue, both referencing the commit that introduced it:

 
http://cgit.freedesktop.org/libreoffice/core/commit/?id=5dd1b3da57862a6577717544dde56482add89170

Is that enough of a code pointer to get you started? Note that we'd
want both ways to work going forward, so you'd want to hack up two
branches, controlled by a flag.

Cheers,

-- Thorsten


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: Automation Test for LibreOffice

2015-12-05 Thread Thorsten Behrens
Michael Meeks wrote:
>   I was wondering what state your nice re-work of a dogtail-alike thing
> to python vs. the UNO a11y API is; is the code somewhere ? potentially
> JanI could help mentor Karlan for the first few tests.
> 
Failing that - the Selenium approach is rather interesting,
i.e. getting a LibreOffice backend up for it...

Cheers,

-- Thorsten


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: minutes of ESC call ...

2015-12-03 Thread Thorsten Behrens
Riccardo Magliocchetti wrote:
> One group managed to post a patch that has been applied. Other
> groups got false positives. One participant posted a trivial patch
> on his own earlier this week. So we ended up with two new
> contributors :)
>
Hi Riccardo,

thanks a lot - for the update, and for running the show there, good
news! :)

Cheers,

-- Thorsten


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: Confused about make.

2015-11-28 Thread Thorsten Behrens
jan iversen wrote:
> I could not find a description of the make options in our wiki
> (maybe they are just hidden).
> 
'make help' should give you some input there.

Cheers,

-- Thorsten


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: vcl/opengl

2015-11-27 Thread Thorsten Behrens
 vcl/opengl/win/WinDeviceInfo.cxx |   36 
 1 file changed, 36 deletions(-)

New commits:
commit 2ebca292f96494a13a0d0baa8b19dd9010616abe
Author: Thorsten Behrens <thorsten.behr...@cib.de>
Date:   Fri Nov 27 11:41:48 2015 +0100

Revert "write a log file about OpenGL driver"

Caused enduring build breakage on Windows for gallery contents.

This reverts commit c0772f7037794e1cea578a8833c79730fbe448c2.

Change-Id: I4cd0d51b5dc88426cfef458e1b889c9d8abf9932

diff --git a/vcl/opengl/win/WinDeviceInfo.cxx b/vcl/opengl/win/WinDeviceInfo.cxx
index 7d1c837..5fa5aac 100644
--- a/vcl/opengl/win/WinDeviceInfo.cxx
+++ b/vcl/opengl/win/WinDeviceInfo.cxx
@@ -542,30 +542,6 @@ bool WinOpenGLDeviceInfo::FindBlocklistedDeviceInList()
 return match;
 }
 
-namespace {
-
-OUString getCacheFolder()
-{
-OUString url("${$BRAND_BASE_DIR/" LIBO_ETC_FOLDER "/" 
SAL_CONFIGFILE("bootstrap") ":UserInstallation}/cache/");
-rtl::Bootstrap::expandMacros(url);
-
-osl::Directory::create(url);
-
-return url;
-}
-
-OUString aCacheFolder = getCacheFolder();
-
-void writeToLog(SvStream& rStrm, const char* pKey, const OUString rVal)
-{
-rStrm.WriteCharPtr(pKey);
-rStrm.WriteCharPtr(": ");
-rStrm.WriteOString(OUStringToOString(rVal, RTL_TEXTENCODING_UTF8));
-rStrm.WriteChar('\n');
-}
-
-}
-
 bool WinOpenGLDeviceInfo::isDeviceBlocked()
 {
 SAL_INFO("vcl.opengl", maDriverVersion);
@@ -577,18 +553,6 @@ bool WinOpenGLDeviceInfo::isDeviceBlocked()
 SAL_INFO("vcl.opengl", maDeviceKey);
 SAL_INFO("vcl.opengl", maDeviceString);
 
-OUString aCacheFile(aCacheFolder + "/opengl_device.log");
-SvFileStream aOpenGLLogFile(aCacheFile, StreamMode::WRITE);
-
-writeToLog(aOpenGLLogFile, "DriverVersion", maDriverVersion);
-writeToLog(aOpenGLLogFile, "DriverDate", maDriverDate);
-writeToLog(aOpenGLLogFile, "DeviceID", maDeviceID);
-writeToLog(aOpenGLLogFile, "AdapterVendorID", maAdapterVendorID);
-writeToLog(aOpenGLLogFile, "AdapterDeviceID", maAdapterDeviceID);
-writeToLog(aOpenGLLogFile, "AdapterSubsysID", maAdapterSubsysID);
-writeToLog(aOpenGLLogFile, "DeviceKey", maDeviceKey);
-writeToLog(aOpenGLLogFile, "DeviceString", maDeviceString);
-
 // Check if the device is blocked from the downloaded blocklist. If not, 
check
 // the static list after that. This order is used so that we can later 
escape
 // out of static blocks (i.e. if we were wrong or something was patched, we
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: slideshow/source

2015-11-23 Thread Thorsten Behrens
 slideshow/source/engine/OGLTrans/generic/OGLTrans_Operation.cxx |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit f6bc5b79c31225c02e9500d0ced4bd26f998f82b
Author: Thorsten Behrens <thorsten.behr...@cib.de>
Date:   Tue Nov 24 02:03:13 2015 +0100

fix build "error C2065: ´M_PI´ : undeclared identifier"

Change-Id: I0ba164cdc1c473184b953bffd7d264d1ec8733b6

diff --git a/slideshow/source/engine/OGLTrans/generic/OGLTrans_Operation.cxx 
b/slideshow/source/engine/OGLTrans/generic/OGLTrans_Operation.cxx
index 3709f3a..c61209f 100644
--- a/slideshow/source/engine/OGLTrans/generic/OGLTrans_Operation.cxx
+++ b/slideshow/source/engine/OGLTrans/generic/OGLTrans_Operation.cxx
@@ -26,6 +26,8 @@
  *
  /
 
+#include 
+
 #include 
 #include 
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: slideshow/source

2015-11-23 Thread Thorsten Behrens
 slideshow/source/engine/OGLTrans/generic/OGLTrans_TransitionImpl.hxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit e5b3ec9683e4c5761633a1a3c4819a039e796b01
Author: Thorsten Behrens <thorsten.behr...@cib.de>
Date:   Tue Nov 24 02:21:01 2015 +0100

fix build: "warning C4305: truncation from 'double' to 'float'"

Change-Id: Ied01ccf789877c15080797de3723588e09fa6c7c

diff --git 
a/slideshow/source/engine/OGLTrans/generic/OGLTrans_TransitionImpl.hxx 
b/slideshow/source/engine/OGLTrans/generic/OGLTrans_TransitionImpl.hxx
index f1a595ef..c56e9c9 100644
--- a/slideshow/source/engine/OGLTrans/generic/OGLTrans_TransitionImpl.hxx
+++ b/slideshow/source/engine/OGLTrans/generic/OGLTrans_TransitionImpl.hxx
@@ -48,7 +48,7 @@ struct TransitionSettings
 TransitionSettings() :
 mbUseMipMapLeaving( true ),
 mbUseMipMapEntering( true ),
-mnRequiredGLVersion( 2.1 )
+mnRequiredGLVersion( 2.1f )
 {
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-qa] Fw: findings from the plugfest

2015-11-20 Thread Thorsten Behrens
Hi guys,

below a list of question / issues with the ODF support - any
volunteers to convert those not being obvious test or ODF standard bugs
into bugzilla reports?

Thanks a lot, Thorsten

- Forwarded message from Jos van den Oever  
-

Date: Thu, 19 Nov 2015 08:39:17 +
From: Jos van den Oever 
Subject: findings from the plugfest

Hello dear LibreOffice developers,

At the last ODF plugfest, LibreOffice was put under quite some scrutiny, as
were the other office suites.
The findings were written down in a report:
 http://odfplugfest.org/2015-thehague/report.html
The number of bugs found can be seen at the bottom of the page. The individual
bugs for LibreOffice are prepended with 'Bug: LibreOffice'.

The names in bugs relate to the tests at
  http://autotests.opendocumentformat.org/

I hope you find the report useful in improving LibreOffice. At the next
plugfest we will be running and evaluating the tests again.

Best regards,
Jos van den Oever

-- 
Jos van den Oever
co-chair OpenDocument Format Technical Committee
.
Ministry of the Interior and Kingdom Relations
Center for Standards | Logius
Wilhelmina van Pruisenweg 52 | 2595 AN | Den Haag
Postbus 96810 | 2509 JE | Den Haag
.
M +31(0)6-54715404
jos.vanden.oe...@logius.nl
www.logius.nl
www.oasis-open.org/committees/office/
.
___
LibreOffice mailing list
libreoff...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

- End forwarded message -



signature.asc
Description: Digital signature
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

[Libreoffice-commits] core.git: solenv/gbuild

2015-11-09 Thread Thorsten Behrens
 solenv/gbuild/gbuild.help.txt |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 6540c288372c3cbb94a30daa5a40e97690cb0ea5
Author: Thorsten Behrens <thorsten.behr...@cib.de>
Date:   Mon Nov 9 15:58:53 2015 +0100

Remove misleading 'make build' line from gbuild help

Change-Id: If389e2dc6f5af07662e6ab8aa94e0e9ce8e30f5b
Reviewed-on: https://gerrit.libreoffice.org/19865
Reviewed-by: Thorsten Behrens <thorsten.behr...@cib.de>
    Tested-by: Thorsten Behrens <thorsten.behr...@cib.de>

diff --git a/solenv/gbuild/gbuild.help.txt b/solenv/gbuild/gbuild.help.txt
index 9364994..35b97c7 100644
--- a/solenv/gbuild/gbuild.help.txt
+++ b/solenv/gbuild/gbuild.help.txt
@@ -28,7 +28,6 @@ IMPORTANT OPTIONS
 
 AVAILABLE TARGETS
all  build product and run unit tests (default goal)
-   buildbuild product
unitcheckrun unit tests
slowcheckrun slow unit tests
subsequentcheck  run system tests (requires full installation)
@@ -43,6 +42,7 @@ AVAILABLE TARGETS
 NOTE: needs graphviz to work
showmodules  shows all registered modules
 build the named module
+   .build   build the named module without running unittests
.check   run unittests of the named module
.clean   clean the named module
.all build the named module and the pre-requisite modules 
for it
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


Re: tdf#51165 -> code pointer needed

2015-11-08 Thread Thorsten Behrens
Christina Roßmanith wrote:
> Then for the mixed case the problem could be solved by iterating
> over the polypolygon and calling writePathShape() with each
> individual subpolygon. Or are there reasons not to proceed this way?
> 
Ah, good point - indeed that would be the best way around this. There
are other workarounds / compat fixes already in the filter.

Cheers,

-- Thorsten


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: tdf#51165 -> code pointer needed

2015-11-07 Thread Thorsten Behrens
Christina Roßmanith wrote:
> I'm revisiting tdf#51165. It looks like rendering is the problem,
> not importing the SVG file. To continue I'd need some code pointers
> where rendering is implemented.
> 
Hi Christina,

oh, this is an interesting corner case - the polypolygon in the bugdoc
has both closed and open polygons, therefore
B2DPolyPolygon::isClosed() will yield false. Thusly
xmloff/source/draw/ximpshap.cxx:1514 and following will pick the open
shape service.

The case at hand can be fixed, the problem in general is that LibO
cannot handle mixed open & closed polygons within a *single* shape.

HTH,

-- Thorsten


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: canvas/source

2015-11-02 Thread Thorsten Behrens
 canvas/source/tools/spriteredrawmanager.cxx |7 ---
 1 file changed, 4 insertions(+), 3 deletions(-)

New commits:
commit 368b657f4ba4200e3f38fec58450c396ca73b729
Author: Thorsten Behrens <thorsten.behr...@cib.de>
Date:   Mon Nov 2 13:42:50 2015 +0100

Partial revert 'for_each -> range-based'

There was a subtle change in semantics, the earlier loop was only
iterating until aEnd, covering only unique elements of the vector.

This partially reverts commit c04fd82433e9155ad61ebd92ca7b43a729a87890

Change-Id: I75c5f1b343c3fa8855f6d7f8f706b9259bc9f6df

diff --git a/canvas/source/tools/spriteredrawmanager.cxx 
b/canvas/source/tools/spriteredrawmanager.cxx
index fa06ace..345c3cd 100644
--- a/canvas/source/tools/spriteredrawmanager.cxx
+++ b/canvas/source/tools/spriteredrawmanager.cxx
@@ -265,9 +265,10 @@ namespace canvas
 // for each unique sprite, check the change event vector,
 // calculate the update operation from that, and add the
 // result to the aUpdateArea.
-SpriteUpdater aSpriteUpdater( rUpdateAreas, maChangeRecords);
-for (auto const& aUpdatableSprite : aUpdatableSprites)
-aSpriteUpdater( aUpdatableSprite);
+::std::for_each( aUpdatableSprites.begin(),
+ aEnd,
+ SpriteUpdater( rUpdateAreas,
+maChangeRecords) );
 
 // TODO(P2): Implement your own output iterator adapter, to
 // avoid that totally superfluous temp aUnchangedSprites
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


Re: [Libreoffice-qa] [libreoffice-projects] minutes of ESC call ...

2015-10-30 Thread Thorsten Behrens
Michael Meeks wrote:
> AI: + kind offer to setup an MSVC2015 tinderbox vs. master (Thorsten)
> + community edition ? (Jmux)
> + is that also 2015 ?
> + also available (Cloph)
>
VS2015 Community Edition now building on tb@42, nightlies here:

 http://dev-builds.libreoffice.org/daily/master/Win-x86@42

Cheers,

-- Thorsten


signature.asc
Description: Digital signature
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [libreoffice-projects] minutes of ESC call ...

2015-10-30 Thread Thorsten Behrens
Michael Meeks wrote:
> AI: + kind offer to setup an MSVC2015 tinderbox vs. master (Thorsten)
> + community edition ? (Jmux)
> + is that also 2015 ?
> + also available (Cloph)
>
VS2015 Community Edition now building on tb@42, nightlies here:

 http://dev-builds.libreoffice.org/daily/master/Win-x86@42

Cheers,

-- Thorsten


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: lessons learned from hackfests

2015-10-25 Thread Thorsten Behrens
Riccardo Magliocchetti wrote:
> Given such a short time frame how is this time better spent from
> your own experience?
>
Hi Riccardo,

as others said, try to push as much deliberation/setup/preps in front
of the event. TDF provides a number of cloud VMs with a pre-built
libreoffice for hackfests, so don't waste time with that during the
event. Try to have them pre-select an Easy Hack beforehand, or pick
one for them if you have an idea about their skill sets.

For keeping people involved, of course a working libreoffice compile
on their laptops is sortof nice, so this could be something to do in
the background while working on the cloud instances. Don't expect all
builds to be finished after 4 hours though...

> What do you think is more important to tackle?  helping people
> getting setting up their machines, explaining libo tools /
> development, going straight to easy hacks or something else?
> 
The gratification of having an Easy Hack submitted to gerrit & merged
is hard to beat. I'd go with that.

My 2 cents at least,

-- Thorsten


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: Icon theme licenses

2015-10-19 Thread Thorsten Behrens
Yousuf 'Jay' Philips wrote:
> I'm bringing up this issue as the designer of the Kalahari icon theme for
> LibreOffice, Mariano Gaudix, would like to upstream his work, as he has been
> actively working on it and had previously asked about including it in the
> past. The Kalahari icon theme comes in colored and monochrome versions and
> it includes work from GPL-licensed Human and Faenza.
> 
Hi guys,

how about discussing this on the ESC this week, if you can make it?
Personally, I'm not super-eager to deviate from this project's
established license practice (CC-BY/LGPL/MPL) - curiously, the
gnome-look page you link to even states Kalahari is MPL?

Cheers,

-- Thorsten


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: Compiling with clang 3.7: breaks in 'external/libwpd'

2015-10-12 Thread Thorsten Behrens
Giuseppe Castagno wrote:
> I set it, the first two lines of my configure script helper look like:
> 
> export CCACHE_CPP2=1
> ./autogen.sh CC=clang CXX=clang++ \
> 
And it works without ccache?

Cheers,

-- Thorsten


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Calc] Bad rendering performance of "selected copy" snake/circulation animation

2015-10-04 Thread Thorsten Behrens
Sylvain R wrote:
> Any comments?
> 
Disabling 'Use anti-aliasing' in Tools->Options->(generic) View should
use the fast path you described, without the need to modify the code.

HTH,

-- Thorsten


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: Should we make it harder to assign a bug to yourself?

2015-10-04 Thread Thorsten Behrens
Andrzej Hunt wrote:
> On 04/10/15 09:36, Tor Lillqvist wrote:
> > Should we make it harder to assign a bug to yourself?
> 
> FWIW Mozilla already block bug assignment privileges for new accounts - it
> doesn't seem like this has caused them any huge problems, so I think copying
> their approach would probably be a good idea.
>
Hi guys,

I don't know, looks more like a social problem to me - and I think we
were faring rather well in the past with being permissive and keeping
red tape low (and checking things afterwards).

So perhaps we might want to include the below query to the ESC stats
stack, and try keeping the oldest entry newer than, say, 3-6 months:

https://bugs.documentfoundation.org/buglist.cgi?email1=libreoffice-bugs%40lists.freedesktop.org_to1=1=notsubstring_id=561999=changeddate%2Cpriority%2Cbug_severity_based_on=_format=advanced=---_whiteboard=easyhack_whiteboard_type=allwordssubstr

That also gives the opportunity to interact.

My 2 cents,

-- Thorsten


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: Branch 'feature/chained-text-boxes' - 19 commits - editeng/Library_editeng.mk editeng/source include/editeng include/svx officecfg/registry sd/source svx/inc svx/Librar

2015-09-20 Thread Thorsten Behrens
Rebased ref, commits from common ancestor:
commit 3a3c68aeafb1ed3c02dd863112d49e61727cf84c
Author: Thorsten Behrens <thorsten.behr...@cib.de>
Date:   Sun Sep 20 01:42:12 2015 +0200

chained editeng: Convert fprintf to SAL_INFO

Change-Id: I8e0cfedd34d7e0d70a30147a3bbf0f1cd8e6d3cc

diff --git a/editeng/source/editeng/impedit3.cxx 
b/editeng/source/editeng/impedit3.cxx
index 2298ecc..aef05f5 100644
--- a/editeng/source/editeng/impedit3.cxx
+++ b/editeng/source/editeng/impedit3.cxx
@@ -564,18 +564,13 @@ void ImpEditEngine::CheckAutoPageSize()
 
 void ImpEditEngine::CheckPageOverflow()
 {
-// FIXME(matteocam)
-/* fprintf( stderr, IsPageOverflow(aPaperSize, aPrevPaperSize)
-? "YES Overflow!\n"  : "NO Overflow!\n" ); */
-// setting overflow status
-
-fprintf(stderr, "[CONTROL_STATUS] AutoPageSize is %s",  ( 
aStatus.GetControlWord() & EEControlBits::AUTOPAGESIZE ) ? "ON\n" : "OFF\n" );
+SAL_INFO("editeng.chaining", "[CONTROL_STATUS] AutoPageSize is " << (( 
aStatus.GetControlWord() & EEControlBits::AUTOPAGESIZE ) ? "ON" : "OFF") );
 
 sal_uInt32 nBoxHeight = GetMaxAutoPaperSize().Height();
-fprintf(stderr, "[OVERFLOW-CHECK] Current MaxAutoPaperHeight is %d\n", 
nBoxHeight);
+SAL_INFO("editeng.chaining", "[OVERFLOW-CHECK] Current MaxAutoPaperHeight 
is " << nBoxHeight);
 
 sal_uInt32 nTxtHeight = CalcTextHeight(NULL);
-fprintf(stderr, "[OVERFLOW-CHECK] Current Text Height is %d\n", 
nTxtHeight);
+SAL_INFO("editeng.chaining", "[OVERFLOW-CHECK] Current Text Height is " << 
nTxtHeight);
 
 sal_uInt32 nParaCount = GetParaPortions().Count();
 sal_uInt32 nFirstLineCount = GetLineCount(0);
@@ -4638,7 +4633,7 @@ void 
ImpEditEngine::ImplUpdateOverflowingParaNum(sal_uInt32 nPaperHeight)
 if ( nY > nPaperHeight /*nCurTextHeight*/ ) // found first paragraph 
overflowing
 {
 mnOverflowingPara = nPara;
-fprintf(stderr, "[CHAINING] Setting first overflowing #Para#: 
%d\n", nPara);
+SAL_INFO("editeng.chaining", "[CHAINING] Setting first overflowing 
#Para#: " << nPara);
 ImplUpdateOverflowingLineNum( nPaperHeight, nPara, nY-nPH);
 return;
 }
@@ -4664,13 +4659,13 @@ void 
ImpEditEngine::ImplUpdateOverflowingLineNum(sal_uInt32 nPaperHeight,
 
 // Debugging output
 if (nLine == 0) {
-fprintf(stderr, "[CHAINING] First line has height %d\n", nLH);
+SAL_INFO("editeng.chaining", "[CHAINING] First line has height " 
<< nLH);
 }
 
 if ( nY > nPaperHeight ) // found first line overflowing
 {
 mnOverflowingLine = nLine;
-fprintf(stderr, "[CHAINING] Setting first overflowing -Line- to: 
%d\n", nLine);
+SAL_INFO("editeng.chaining", "[CHAINING] Setting first overflowing 
-Line- to: " << nLine);
 return;
 }
 }
diff --git a/editeng/source/outliner/outliner.cxx 
b/editeng/source/outliner/outliner.cxx
index f0c982f..1f077c2 100644
--- a/editeng/source/outliner/outliner.cxx
+++ b/editeng/source/outliner/outliner.cxx
@@ -2081,17 +2081,16 @@ NonOverflowingText *Outliner::GetNonOverflowingText() 
const
 
 // Defensive check: oveflowing para index beyond actual # of paragraphs?
 if ( nCount > GetParagraphCount()-1) {
-fprintf(stderr,
-"[Overflowing] Ops, trying to retrieve para %d when max index 
is %d\n",
-nCount,
-GetParagraphCount()-1);
+SAL_INFO("editeng.chaining",
+ "[Overflowing] Ops, trying to retrieve para "
+ << nCount << " when max index is " << GetParagraphCount()-1 );
 return NULL;
 }
 
  if (nCount < 0)
  {
-fprintf(stderr,
-"[Overflowing] No Overflowing text but GetNonOverflowinText 
called?!\n");
+SAL_INFO("editeng.chaining",
+ "[Overflowing] No Overflowing text but GetNonOverflowinText 
called?!");
 return NULL;
  }
 
@@ -2189,10 +2188,10 @@ OverflowingText *Outliner::GetOverflowingText() const
 
 // Defensive check: oveflowing para index beyond actual # of paragraphs?
 if ( pEditEngine->GetOverflowingParaNum() > GetParagraphCount()-1) {
-fprintf(stderr,
-"[Overflowing] Ops, trying to retrieve para %d when max index 
is %d\n",
-pEditEngine->GetOverflowingParaNum(),
-GetParagraphCount()-1);
+SAL_INFO("editeng.chaining",
+ "[Overflowing] Ops, trying 

[Libreoffice-commits] core.git: Branch 'feature/chained-text-boxes' - 25 commits - accessibility/inc accessibility/source avmedia/source basctl/source bin/gbuild-to-ide chart2/source editeng/Library_e

2015-09-20 Thread Thorsten Behrens
Rebased ref, commits from common ancestor:
commit 48c6545f62100c87e9f60a21de41be9953451147
Author: Thorsten Behrens <thorsten.behr...@cib.de>
Date:   Sun Sep 20 01:42:12 2015 +0200

chained editeng: Convert fprintf to SAL_INFO

Change-Id: I8e0cfedd34d7e0d70a30147a3bbf0f1cd8e6d3cc

diff --git a/editeng/source/editeng/impedit3.cxx 
b/editeng/source/editeng/impedit3.cxx
index 2298ecc..aef05f5 100644
--- a/editeng/source/editeng/impedit3.cxx
+++ b/editeng/source/editeng/impedit3.cxx
@@ -564,18 +564,13 @@ void ImpEditEngine::CheckAutoPageSize()
 
 void ImpEditEngine::CheckPageOverflow()
 {
-// FIXME(matteocam)
-/* fprintf( stderr, IsPageOverflow(aPaperSize, aPrevPaperSize)
-? "YES Overflow!\n"  : "NO Overflow!\n" ); */
-// setting overflow status
-
-fprintf(stderr, "[CONTROL_STATUS] AutoPageSize is %s",  ( 
aStatus.GetControlWord() & EEControlBits::AUTOPAGESIZE ) ? "ON\n" : "OFF\n" );
+SAL_INFO("editeng.chaining", "[CONTROL_STATUS] AutoPageSize is " << (( 
aStatus.GetControlWord() & EEControlBits::AUTOPAGESIZE ) ? "ON" : "OFF") );
 
 sal_uInt32 nBoxHeight = GetMaxAutoPaperSize().Height();
-fprintf(stderr, "[OVERFLOW-CHECK] Current MaxAutoPaperHeight is %d\n", 
nBoxHeight);
+SAL_INFO("editeng.chaining", "[OVERFLOW-CHECK] Current MaxAutoPaperHeight 
is " << nBoxHeight);
 
 sal_uInt32 nTxtHeight = CalcTextHeight(NULL);
-fprintf(stderr, "[OVERFLOW-CHECK] Current Text Height is %d\n", 
nTxtHeight);
+SAL_INFO("editeng.chaining", "[OVERFLOW-CHECK] Current Text Height is " << 
nTxtHeight);
 
 sal_uInt32 nParaCount = GetParaPortions().Count();
 sal_uInt32 nFirstLineCount = GetLineCount(0);
@@ -4638,7 +4633,7 @@ void 
ImpEditEngine::ImplUpdateOverflowingParaNum(sal_uInt32 nPaperHeight)
 if ( nY > nPaperHeight /*nCurTextHeight*/ ) // found first paragraph 
overflowing
 {
 mnOverflowingPara = nPara;
-fprintf(stderr, "[CHAINING] Setting first overflowing #Para#: 
%d\n", nPara);
+SAL_INFO("editeng.chaining", "[CHAINING] Setting first overflowing 
#Para#: " << nPara);
 ImplUpdateOverflowingLineNum( nPaperHeight, nPara, nY-nPH);
 return;
 }
@@ -4664,13 +4659,13 @@ void 
ImpEditEngine::ImplUpdateOverflowingLineNum(sal_uInt32 nPaperHeight,
 
 // Debugging output
 if (nLine == 0) {
-fprintf(stderr, "[CHAINING] First line has height %d\n", nLH);
+SAL_INFO("editeng.chaining", "[CHAINING] First line has height " 
<< nLH);
 }
 
 if ( nY > nPaperHeight ) // found first line overflowing
 {
 mnOverflowingLine = nLine;
-fprintf(stderr, "[CHAINING] Setting first overflowing -Line- to: 
%d\n", nLine);
+SAL_INFO("editeng.chaining", "[CHAINING] Setting first overflowing 
-Line- to: " << nLine);
 return;
 }
 }
diff --git a/editeng/source/outliner/outliner.cxx 
b/editeng/source/outliner/outliner.cxx
index f0c982f..1f077c2 100644
--- a/editeng/source/outliner/outliner.cxx
+++ b/editeng/source/outliner/outliner.cxx
@@ -2081,17 +2081,16 @@ NonOverflowingText *Outliner::GetNonOverflowingText() 
const
 
 // Defensive check: oveflowing para index beyond actual # of paragraphs?
 if ( nCount > GetParagraphCount()-1) {
-fprintf(stderr,
-"[Overflowing] Ops, trying to retrieve para %d when max index 
is %d\n",
-nCount,
-GetParagraphCount()-1);
+SAL_INFO("editeng.chaining",
+ "[Overflowing] Ops, trying to retrieve para "
+ << nCount << " when max index is " << GetParagraphCount()-1 );
 return NULL;
 }
 
  if (nCount < 0)
  {
-fprintf(stderr,
-"[Overflowing] No Overflowing text but GetNonOverflowinText 
called?!\n");
+SAL_INFO("editeng.chaining",
+ "[Overflowing] No Overflowing text but GetNonOverflowinText 
called?!");
 return NULL;
  }
 
@@ -2189,10 +2188,10 @@ OverflowingText *Outliner::GetOverflowingText() const
 
 // Defensive check: oveflowing para index beyond actual # of paragraphs?
 if ( pEditEngine->GetOverflowingParaNum() > GetParagraphCount()-1) {
-fprintf(stderr,
-"[Overflowing] Ops, trying to retrieve para %d when max index 
is %d\n",
-pEditEngine->GetOverflowingParaNum(),
-GetParagraphCount()-1);
+SAL_INFO("editeng.chaining",
+ "[Overflowing] Ops, trying 

[Libreoffice-commits] core.git: 15 commits - editeng/Library_editeng.mk editeng/source include/editeng include/svx sd/source svx/inc svx/Library_svxcore.mk svx/source xmloff/source

2015-09-20 Thread Thorsten Behrens
 editeng/Library_editeng.mk   |2 
 editeng/source/editeng/editeng.cxx   |   28 +
 editeng/source/editeng/impedit.hxx   |   24 +
 editeng/source/editeng/impedit3.cxx  |  102 +
 editeng/source/editeng/impedit4.cxx  |9 
 editeng/source/outliner/outlin2.cxx  |4 
 editeng/source/outliner/outliner.cxx |  168 
 editeng/source/outliner/outlvw.cxx   |   11 
 editeng/source/outliner/overflowingtxt.cxx   |  260 +
 include/editeng/editeng.hxx  |9 
 include/editeng/outliner.hxx |   22 +
 include/editeng/overflowingtxt.hxx   |  149 +++
 include/editeng/unoprnms.hxx |1 
 include/svx/sdr/attribute/sdrtextattribute.hxx   |9 
 include/svx/sdr/primitive2d/svx_primitivetypes2d.hxx |1 
 include/svx/svddef.hxx   |3 
 include/svx/svdedxv.hxx  |   10 
 include/svx/svdmodel.hxx |7 
 include/svx/svdotext.hxx |   45 ++
 include/svx/svdstr.hrc   |2 
 include/svx/textchain.hxx|  157 
 include/svx/textchaincursor.hxx  |   64 +++
 include/svx/textchainflow.hxx|  119 ++
 include/svx/unoshprp.hxx |1 
 sd/source/ui/view/drviewse.cxx   |5 
 sd/source/ui/view/outlview.cxx   |1 
 sd/source/ui/view/sdview.cxx |1 
 svx/Library_svxcore.mk   |3 
 svx/inc/sdr/primitive2d/sdrtextprimitive2d.hxx   |   37 +
 svx/source/sdr/attribute/sdrtextattribute.cxx|   39 +-
 svx/source/sdr/primitive2d/sdrattributecreator.cxx   |9 
 svx/source/sdr/primitive2d/sdrdecompositiontools.cxx |   13 
 svx/source/sdr/primitive2d/sdrtextprimitive2d.cxx|   42 ++
 svx/source/svdraw/svdattr.cxx|2 
 svx/source/svdraw/svdedxv.cxx|  144 +++
 svx/source/svdraw/svdmodel.cxx   |   27 +
 svx/source/svdraw/svdotext.cxx   |  223 +++
 svx/source/svdraw/svdotextdecomposition.cxx  |  194 ++
 svx/source/svdraw/svdotxed.cxx   |   79 +++-
 svx/source/svdraw/svdstr.src |6 
 svx/source/svdraw/textchain.cxx  |   68 +++
 svx/source/svdraw/textchaincursor.cxx|  210 +++
 svx/source/svdraw/textchainflow.cxx  |  356 +++
 svx/source/unodraw/unoshap2.cxx  |1 
 xmloff/source/draw/sdpropls.cxx  |1 
 xmloff/source/draw/ximpshap.cxx  |   27 +
 xmloff/source/draw/ximpshap.hxx  |1 
 47 files changed, 2664 insertions(+), 32 deletions(-)

New commits:
commit 3a3c68aeafb1ed3c02dd863112d49e61727cf84c
Author: Thorsten Behrens <thorsten.behr...@cib.de>
Date:   Sun Sep 20 01:42:12 2015 +0200

chained editeng: Convert fprintf to SAL_INFO

Change-Id: I8e0cfedd34d7e0d70a30147a3bbf0f1cd8e6d3cc

diff --git a/editeng/source/editeng/impedit3.cxx 
b/editeng/source/editeng/impedit3.cxx
index 2298ecc..aef05f5 100644
--- a/editeng/source/editeng/impedit3.cxx
+++ b/editeng/source/editeng/impedit3.cxx
@@ -564,18 +564,13 @@ void ImpEditEngine::CheckAutoPageSize()
 
 void ImpEditEngine::CheckPageOverflow()
 {
-// FIXME(matteocam)
-/* fprintf( stderr, IsPageOverflow(aPaperSize, aPrevPaperSize)
-? "YES Overflow!\n"  : "NO Overflow!\n" ); */
-// setting overflow status
-
-fprintf(stderr, "[CONTROL_STATUS] AutoPageSize is %s",  ( 
aStatus.GetControlWord() & EEControlBits::AUTOPAGESIZE ) ? "ON\n" : "OFF\n" );
+SAL_INFO("editeng.chaining", "[CONTROL_STATUS] AutoPageSize is " << (( 
aStatus.GetControlWord() & EEControlBits::AUTOPAGESIZE ) ? "ON" : "OFF") );
 
 sal_uInt32 nBoxHeight = GetMaxAutoPaperSize().Height();
-fprintf(stderr, "[OVERFLOW-CHECK] Current MaxAutoPaperHeight is %d\n", 
nBoxHeight);
+SAL_INFO("editeng.chaining", "[OVERFLOW-CHECK] Current MaxAutoPaperHeight 
is " << nBoxHeight);
 
 sal_uInt32 nTxtHeight = CalcTextHeight(NULL);
-fprintf(stderr, "[OVERFLOW-CHECK] Current Text Height is %d\n", 
nTxtHeight);
+SAL_INFO("editeng.chaining", "[OVERFLOW-CHECK] Current Text Height is " << 
nTxtHeight);
 
 sal_uInt32 nParaCount = GetParaPortions().Count();
 sal_uInt32 nFirstLineCount = GetLineCount(0);
@@ -4638,7 +4633,7 @@ void 
ImpEditEngine::ImplUpdateOv

[Libreoffice-commits] core.git: Branch 'feature/chained-text-boxes' - 5 commits - editeng/source include/svx sd/source svx/source

2015-09-20 Thread Thorsten Behrens
Rebased ref, commits from common ancestor:
commit e3387e02b340d8fe99f00a77364c9261b67c7713
Author: Thorsten Behrens <thorsten.behr...@cib.de>
Date:   Sun Sep 20 01:42:12 2015 +0200

chained editeng: Convert fprintf to SAL_INFO

Change-Id: I8e0cfedd34d7e0d70a30147a3bbf0f1cd8e6d3cc

diff --git a/editeng/source/editeng/impedit3.cxx 
b/editeng/source/editeng/impedit3.cxx
index 2298ecc..aef05f5 100644
--- a/editeng/source/editeng/impedit3.cxx
+++ b/editeng/source/editeng/impedit3.cxx
@@ -564,18 +564,13 @@ void ImpEditEngine::CheckAutoPageSize()
 
 void ImpEditEngine::CheckPageOverflow()
 {
-// FIXME(matteocam)
-/* fprintf( stderr, IsPageOverflow(aPaperSize, aPrevPaperSize)
-? "YES Overflow!\n"  : "NO Overflow!\n" ); */
-// setting overflow status
-
-fprintf(stderr, "[CONTROL_STATUS] AutoPageSize is %s",  ( 
aStatus.GetControlWord() & EEControlBits::AUTOPAGESIZE ) ? "ON\n" : "OFF\n" );
+SAL_INFO("editeng.chaining", "[CONTROL_STATUS] AutoPageSize is " << (( 
aStatus.GetControlWord() & EEControlBits::AUTOPAGESIZE ) ? "ON" : "OFF") );
 
 sal_uInt32 nBoxHeight = GetMaxAutoPaperSize().Height();
-fprintf(stderr, "[OVERFLOW-CHECK] Current MaxAutoPaperHeight is %d\n", 
nBoxHeight);
+SAL_INFO("editeng.chaining", "[OVERFLOW-CHECK] Current MaxAutoPaperHeight 
is " << nBoxHeight);
 
 sal_uInt32 nTxtHeight = CalcTextHeight(NULL);
-fprintf(stderr, "[OVERFLOW-CHECK] Current Text Height is %d\n", 
nTxtHeight);
+SAL_INFO("editeng.chaining", "[OVERFLOW-CHECK] Current Text Height is " << 
nTxtHeight);
 
 sal_uInt32 nParaCount = GetParaPortions().Count();
 sal_uInt32 nFirstLineCount = GetLineCount(0);
@@ -4638,7 +4633,7 @@ void 
ImpEditEngine::ImplUpdateOverflowingParaNum(sal_uInt32 nPaperHeight)
 if ( nY > nPaperHeight /*nCurTextHeight*/ ) // found first paragraph 
overflowing
 {
 mnOverflowingPara = nPara;
-fprintf(stderr, "[CHAINING] Setting first overflowing #Para#: 
%d\n", nPara);
+SAL_INFO("editeng.chaining", "[CHAINING] Setting first overflowing 
#Para#: " << nPara);
 ImplUpdateOverflowingLineNum( nPaperHeight, nPara, nY-nPH);
 return;
 }
@@ -4664,13 +4659,13 @@ void 
ImpEditEngine::ImplUpdateOverflowingLineNum(sal_uInt32 nPaperHeight,
 
 // Debugging output
 if (nLine == 0) {
-fprintf(stderr, "[CHAINING] First line has height %d\n", nLH);
+SAL_INFO("editeng.chaining", "[CHAINING] First line has height " 
<< nLH);
 }
 
 if ( nY > nPaperHeight ) // found first line overflowing
 {
 mnOverflowingLine = nLine;
-fprintf(stderr, "[CHAINING] Setting first overflowing -Line- to: 
%d\n", nLine);
+SAL_INFO("editeng.chaining", "[CHAINING] Setting first overflowing 
-Line- to: " << nLine);
 return;
 }
 }
diff --git a/editeng/source/outliner/outliner.cxx 
b/editeng/source/outliner/outliner.cxx
index f0c982f..1f077c2 100644
--- a/editeng/source/outliner/outliner.cxx
+++ b/editeng/source/outliner/outliner.cxx
@@ -2081,17 +2081,16 @@ NonOverflowingText *Outliner::GetNonOverflowingText() 
const
 
 // Defensive check: oveflowing para index beyond actual # of paragraphs?
 if ( nCount > GetParagraphCount()-1) {
-fprintf(stderr,
-"[Overflowing] Ops, trying to retrieve para %d when max index 
is %d\n",
-nCount,
-GetParagraphCount()-1);
+SAL_INFO("editeng.chaining",
+ "[Overflowing] Ops, trying to retrieve para "
+ << nCount << " when max index is " << GetParagraphCount()-1 );
 return NULL;
 }
 
  if (nCount < 0)
  {
-fprintf(stderr,
-"[Overflowing] No Overflowing text but GetNonOverflowinText 
called?!\n");
+SAL_INFO("editeng.chaining",
+ "[Overflowing] No Overflowing text but GetNonOverflowinText 
called?!");
 return NULL;
  }
 
@@ -2189,10 +2188,10 @@ OverflowingText *Outliner::GetOverflowingText() const
 
 // Defensive check: oveflowing para index beyond actual # of paragraphs?
 if ( pEditEngine->GetOverflowingParaNum() > GetParagraphCount()-1) {
-fprintf(stderr,
-"[Overflowing] Ops, trying to retrieve para %d when max index 
is %d\n",
-pEditEngine->GetOverflowingParaNum(),
-GetParagraphCount()-1);
+SAL_INFO("editeng.chaining",
+ "[Overflowing] Ops, trying 

[Libreoffice-commits] core.git: Branch 'feature/chained-text-boxes' - 15 commits - editeng/Library_editeng.mk editeng/source include/editeng include/svx sd/source svx/inc svx/Library_svxcore.mk svx/so

2015-09-19 Thread Thorsten Behrens
Rebased ref, commits from common ancestor:
commit 50468cb6b08c64b98fc9134c8f4a61495a3e5214
Author: Thorsten Behrens <thorsten.behr...@cib.de>
Date:   Sun Sep 20 01:42:12 2015 +0200

chained editeng: Convert fprintf to SAL_INFO

Change-Id: I8e0cfedd34d7e0d70a30147a3bbf0f1cd8e6d3cc

diff --git a/editeng/source/editeng/impedit3.cxx 
b/editeng/source/editeng/impedit3.cxx
index 70072a2..74eb16d 100644
--- a/editeng/source/editeng/impedit3.cxx
+++ b/editeng/source/editeng/impedit3.cxx
@@ -564,18 +564,13 @@ void ImpEditEngine::CheckAutoPageSize()
 
 void ImpEditEngine::CheckPageOverflow()
 {
-// FIXME(matteocam)
-/* fprintf( stderr, IsPageOverflow(aPaperSize, aPrevPaperSize)
-? "YES Overflow!\n"  : "NO Overflow!\n" ); */
-// setting overflow status
-
-fprintf(stderr, "[CONTROL_STATUS] AutoPageSize is %s",  ( 
aStatus.GetControlWord() & EEControlBits::AUTOPAGESIZE ) ? "ON\n" : "OFF\n" );
+SAL_INFO("editeng.chaining", "[CONTROL_STATUS] AutoPageSize is " << (( 
aStatus.GetControlWord() & EEControlBits::AUTOPAGESIZE ) ? "ON" : "OFF") );
 
 sal_uInt32 nBoxHeight = GetMaxAutoPaperSize().Height();
-fprintf(stderr, "[OVERFLOW-CHECK] Current MaxAutoPaperHeight is %d\n", 
nBoxHeight);
+SAL_INFO("editeng.chaining", "[OVERFLOW-CHECK] Current MaxAutoPaperHeight 
is " << nBoxHeight);
 
 sal_uInt32 nTxtHeight = CalcTextHeight(NULL);
-fprintf(stderr, "[OVERFLOW-CHECK] Current Text Height is %d\n", 
nTxtHeight);
+SAL_INFO("editeng.chaining", "[OVERFLOW-CHECK] Current Text Height is " << 
nTxtHeight);
 
 sal_uInt32 nParaCount = GetParaPortions().Count();
 sal_uInt32 nFirstLineCount = GetLineCount(0);
@@ -4636,7 +4631,7 @@ void 
ImpEditEngine::ImplUpdateOverflowingParaNum(sal_uInt32 nPaperHeight)
 if ( nY > nPaperHeight /*nCurTextHeight*/ ) // found first paragraph 
overflowing
 {
 mnOverflowingPara = nPara;
-fprintf(stderr, "[CHAINING] Setting first overflowing #Para#: 
%d\n", nPara);
+SAL_INFO("editeng.chaining", "[CHAINING] Setting first overflowing 
#Para#: " << nPara);
 ImplUpdateOverflowingLineNum( nPaperHeight, nPara, nY-nPH);
 return;
 }
@@ -4662,13 +4657,13 @@ void 
ImpEditEngine::ImplUpdateOverflowingLineNum(sal_uInt32 nPaperHeight,
 
 // Debugging output
 if (nLine == 0) {
-fprintf(stderr, "[CHAINING] First line has height %d\n", nLH);
+SAL_INFO("editeng.chaining", "[CHAINING] First line has height " 
<< nLH);
 }
 
 if ( nY > nPaperHeight ) // found first line overflowing
 {
 mnOverflowingLine = nLine;
-fprintf(stderr, "[CHAINING] Setting first overflowing -Line- to: 
%d\n", nLine);
+SAL_INFO("editeng.chaining", "[CHAINING] Setting first overflowing 
-Line- to: " << nLine);
 return;
 }
 }
diff --git a/editeng/source/outliner/outliner.cxx 
b/editeng/source/outliner/outliner.cxx
index 77bb66a..040bc6e 100644
--- a/editeng/source/outliner/outliner.cxx
+++ b/editeng/source/outliner/outliner.cxx
@@ -2094,17 +2094,16 @@ NonOverflowingText *Outliner::GetNonOverflowingText() 
const
 
 // Defensive check: oveflowing para index beyond actual # of paragraphs?
 if ( nCount > GetParagraphCount()-1) {
-fprintf(stderr,
-"[Overflowing] Ops, trying to retrieve para %d when max index 
is %d\n",
-nCount,
-GetParagraphCount()-1);
+SAL_INFO("editeng.chaining",
+ "[Overflowing] Ops, trying to retrieve para "
+ << nCount << " when max index is " << GetParagraphCount()-1 );
 return NULL;
 }
 
  if (nCount < 0)
  {
-fprintf(stderr,
-"[Overflowing] No Overflowing text but GetNonOverflowinText 
called?!\n");
+SAL_INFO("editeng.chaining",
+ "[Overflowing] No Overflowing text but GetNonOverflowinText 
called?!");
 return NULL;
  }
 
@@ -2202,10 +2201,10 @@ OverflowingText *Outliner::GetOverflowingText() const
 
 // Defensive check: oveflowing para index beyond actual # of paragraphs?
 if ( pEditEngine->GetOverflowingParaNum() > GetParagraphCount()-1) {
-fprintf(stderr,
-"[Overflowing] Ops, trying to retrieve para %d when max index 
is %d\n",
-pEditEngine->GetOverflowingParaNum(),
-GetParagraphCount()-1);
+SAL_INFO("editeng.chaining",
+ "[Overflowing] Ops, trying to retrieve

[Libreoffice-commits] core.git: Branch 'feature/chained-text-boxes' - editeng/source svx/source

2015-09-19 Thread Thorsten Behrens
Rebased ref, commits from common ancestor:
commit a99fa0a3c9a4833f7b30d1b4eaa2ac7fc7246cf6
Author: Thorsten Behrens <thorsten.behr...@cib.de>
Date:   Sun Sep 20 01:42:12 2015 +0200

chained editeng: Convert fprintf to SAL_INFO

Change-Id: I8e0cfedd34d7e0d70a30147a3bbf0f1cd8e6d3cc

diff --git a/editeng/source/editeng/impedit3.cxx 
b/editeng/source/editeng/impedit3.cxx
index 70072a2..74eb16d 100644
--- a/editeng/source/editeng/impedit3.cxx
+++ b/editeng/source/editeng/impedit3.cxx
@@ -564,18 +564,13 @@ void ImpEditEngine::CheckAutoPageSize()
 
 void ImpEditEngine::CheckPageOverflow()
 {
-// FIXME(matteocam)
-/* fprintf( stderr, IsPageOverflow(aPaperSize, aPrevPaperSize)
-? "YES Overflow!\n"  : "NO Overflow!\n" ); */
-// setting overflow status
-
-fprintf(stderr, "[CONTROL_STATUS] AutoPageSize is %s",  ( 
aStatus.GetControlWord() & EEControlBits::AUTOPAGESIZE ) ? "ON\n" : "OFF\n" );
+SAL_INFO("editeng.chaining", "[CONTROL_STATUS] AutoPageSize is " << (( 
aStatus.GetControlWord() & EEControlBits::AUTOPAGESIZE ) ? "ON" : "OFF") );
 
 sal_uInt32 nBoxHeight = GetMaxAutoPaperSize().Height();
-fprintf(stderr, "[OVERFLOW-CHECK] Current MaxAutoPaperHeight is %d\n", 
nBoxHeight);
+SAL_INFO("editeng.chaining", "[OVERFLOW-CHECK] Current MaxAutoPaperHeight 
is " << nBoxHeight);
 
 sal_uInt32 nTxtHeight = CalcTextHeight(NULL);
-fprintf(stderr, "[OVERFLOW-CHECK] Current Text Height is %d\n", 
nTxtHeight);
+SAL_INFO("editeng.chaining", "[OVERFLOW-CHECK] Current Text Height is " << 
nTxtHeight);
 
 sal_uInt32 nParaCount = GetParaPortions().Count();
 sal_uInt32 nFirstLineCount = GetLineCount(0);
@@ -4636,7 +4631,7 @@ void 
ImpEditEngine::ImplUpdateOverflowingParaNum(sal_uInt32 nPaperHeight)
 if ( nY > nPaperHeight /*nCurTextHeight*/ ) // found first paragraph 
overflowing
 {
 mnOverflowingPara = nPara;
-fprintf(stderr, "[CHAINING] Setting first overflowing #Para#: 
%d\n", nPara);
+SAL_INFO("editeng.chaining", "[CHAINING] Setting first overflowing 
#Para#: " << nPara);
 ImplUpdateOverflowingLineNum( nPaperHeight, nPara, nY-nPH);
 return;
 }
@@ -4662,13 +4657,13 @@ void 
ImpEditEngine::ImplUpdateOverflowingLineNum(sal_uInt32 nPaperHeight,
 
 // Debugging output
 if (nLine == 0) {
-fprintf(stderr, "[CHAINING] First line has height %d\n", nLH);
+SAL_INFO("editeng.chaining", "[CHAINING] First line has height " 
<< nLH);
 }
 
 if ( nY > nPaperHeight ) // found first line overflowing
 {
 mnOverflowingLine = nLine;
-fprintf(stderr, "[CHAINING] Setting first overflowing -Line- to: 
%d\n", nLine);
+SAL_INFO("editeng.chaining", "[CHAINING] Setting first overflowing 
-Line- to: " << nLine);
 return;
 }
 }
diff --git a/editeng/source/outliner/outliner.cxx 
b/editeng/source/outliner/outliner.cxx
index 77bb66a..040bc6e 100644
--- a/editeng/source/outliner/outliner.cxx
+++ b/editeng/source/outliner/outliner.cxx
@@ -2094,17 +2094,16 @@ NonOverflowingText *Outliner::GetNonOverflowingText() 
const
 
 // Defensive check: oveflowing para index beyond actual # of paragraphs?
 if ( nCount > GetParagraphCount()-1) {
-fprintf(stderr,
-"[Overflowing] Ops, trying to retrieve para %d when max index 
is %d\n",
-nCount,
-GetParagraphCount()-1);
+SAL_INFO("editeng.chaining",
+ "[Overflowing] Ops, trying to retrieve para "
+ << nCount << " when max index is " << GetParagraphCount()-1 );
 return NULL;
 }
 
  if (nCount < 0)
  {
-fprintf(stderr,
-"[Overflowing] No Overflowing text but GetNonOverflowinText 
called?!\n");
+SAL_INFO("editeng.chaining",
+ "[Overflowing] No Overflowing text but GetNonOverflowinText 
called?!");
 return NULL;
  }
 
@@ -2202,10 +2201,10 @@ OverflowingText *Outliner::GetOverflowingText() const
 
 // Defensive check: oveflowing para index beyond actual # of paragraphs?
 if ( pEditEngine->GetOverflowingParaNum() > GetParagraphCount()-1) {
-fprintf(stderr,
-"[Overflowing] Ops, trying to retrieve para %d when max index 
is %d\n",
-pEditEngine->GetOverflowingParaNum(),
-GetParagraphCount()-1);
+SAL_INFO("editeng.chaining",
+ "[Overflowing] Ops, trying 

[Libreoffice-commits] core.git: Branch 'feature/chained-text-boxes' - 811 commits - accessibility/inc accessibility/source android/source avmedia/source basctl/inc basctl/source basebmp/source basegfx

2015-09-19 Thread Thorsten Behrens
Rebased ref, commits from common ancestor:
commit 98d911f7a692f52d2487aa6905e3a29975197e8a
Author: Thorsten Behrens <thorsten.behr...@cib.de>
Date:   Sun Sep 20 01:42:12 2015 +0200

chained editeng: Convert fprintf to SAL_INFO

Change-Id: I8e0cfedd34d7e0d70a30147a3bbf0f1cd8e6d3cc

diff --git a/editeng/source/editeng/impedit3.cxx 
b/editeng/source/editeng/impedit3.cxx
index 2298ecc..aef05f5 100644
--- a/editeng/source/editeng/impedit3.cxx
+++ b/editeng/source/editeng/impedit3.cxx
@@ -564,18 +564,13 @@ void ImpEditEngine::CheckAutoPageSize()
 
 void ImpEditEngine::CheckPageOverflow()
 {
-// FIXME(matteocam)
-/* fprintf( stderr, IsPageOverflow(aPaperSize, aPrevPaperSize)
-? "YES Overflow!\n"  : "NO Overflow!\n" ); */
-// setting overflow status
-
-fprintf(stderr, "[CONTROL_STATUS] AutoPageSize is %s",  ( 
aStatus.GetControlWord() & EEControlBits::AUTOPAGESIZE ) ? "ON\n" : "OFF\n" );
+SAL_INFO("editeng.chaining", "[CONTROL_STATUS] AutoPageSize is " << (( 
aStatus.GetControlWord() & EEControlBits::AUTOPAGESIZE ) ? "ON" : "OFF") );
 
 sal_uInt32 nBoxHeight = GetMaxAutoPaperSize().Height();
-fprintf(stderr, "[OVERFLOW-CHECK] Current MaxAutoPaperHeight is %d\n", 
nBoxHeight);
+SAL_INFO("editeng.chaining", "[OVERFLOW-CHECK] Current MaxAutoPaperHeight 
is " << nBoxHeight);
 
 sal_uInt32 nTxtHeight = CalcTextHeight(NULL);
-fprintf(stderr, "[OVERFLOW-CHECK] Current Text Height is %d\n", 
nTxtHeight);
+SAL_INFO("editeng.chaining", "[OVERFLOW-CHECK] Current Text Height is " << 
nTxtHeight);
 
 sal_uInt32 nParaCount = GetParaPortions().Count();
 sal_uInt32 nFirstLineCount = GetLineCount(0);
@@ -4638,7 +4633,7 @@ void 
ImpEditEngine::ImplUpdateOverflowingParaNum(sal_uInt32 nPaperHeight)
 if ( nY > nPaperHeight /*nCurTextHeight*/ ) // found first paragraph 
overflowing
 {
 mnOverflowingPara = nPara;
-fprintf(stderr, "[CHAINING] Setting first overflowing #Para#: 
%d\n", nPara);
+SAL_INFO("editeng.chaining", "[CHAINING] Setting first overflowing 
#Para#: " << nPara);
 ImplUpdateOverflowingLineNum( nPaperHeight, nPara, nY-nPH);
 return;
 }
@@ -4664,13 +4659,13 @@ void 
ImpEditEngine::ImplUpdateOverflowingLineNum(sal_uInt32 nPaperHeight,
 
 // Debugging output
 if (nLine == 0) {
-fprintf(stderr, "[CHAINING] First line has height %d\n", nLH);
+SAL_INFO("editeng.chaining", "[CHAINING] First line has height " 
<< nLH);
 }
 
 if ( nY > nPaperHeight ) // found first line overflowing
 {
 mnOverflowingLine = nLine;
-fprintf(stderr, "[CHAINING] Setting first overflowing -Line- to: 
%d\n", nLine);
+SAL_INFO("editeng.chaining", "[CHAINING] Setting first overflowing 
-Line- to: " << nLine);
 return;
 }
 }
diff --git a/editeng/source/outliner/outliner.cxx 
b/editeng/source/outliner/outliner.cxx
index f0c982f..1f077c2 100644
--- a/editeng/source/outliner/outliner.cxx
+++ b/editeng/source/outliner/outliner.cxx
@@ -2081,17 +2081,16 @@ NonOverflowingText *Outliner::GetNonOverflowingText() 
const
 
 // Defensive check: oveflowing para index beyond actual # of paragraphs?
 if ( nCount > GetParagraphCount()-1) {
-fprintf(stderr,
-"[Overflowing] Ops, trying to retrieve para %d when max index 
is %d\n",
-nCount,
-GetParagraphCount()-1);
+SAL_INFO("editeng.chaining",
+ "[Overflowing] Ops, trying to retrieve para "
+ << nCount << " when max index is " << GetParagraphCount()-1 );
 return NULL;
 }
 
  if (nCount < 0)
  {
-fprintf(stderr,
-"[Overflowing] No Overflowing text but GetNonOverflowinText 
called?!\n");
+SAL_INFO("editeng.chaining",
+ "[Overflowing] No Overflowing text but GetNonOverflowinText 
called?!");
 return NULL;
  }
 
@@ -2189,10 +2188,10 @@ OverflowingText *Outliner::GetOverflowingText() const
 
 // Defensive check: oveflowing para index beyond actual # of paragraphs?
 if ( pEditEngine->GetOverflowingParaNum() > GetParagraphCount()-1) {
-fprintf(stderr,
-"[Overflowing] Ops, trying to retrieve para %d when max index 
is %d\n",
-pEditEngine->GetOverflowingParaNum(),
-GetParagraphCount()-1);
+SAL_INFO("editeng.chaining",
+ "[Overflowing] Ops, trying 

[Libreoffice-commits] core.git: Branch 'feature/chained-text-boxes' - 15 commits - editeng/Library_editeng.mk editeng/source include/editeng include/svx sd/source svx/inc svx/Library_svxcore.mk svx/so

2015-09-19 Thread Thorsten Behrens
Rebased ref, commits from common ancestor:
commit 133498a53c9b639c29eb7c2f90dec6feb8dd476e
Author: Thorsten Behrens <thorsten.behr...@cib.de>
Date:   Sun Sep 20 01:42:12 2015 +0200

chained editeng: Convert fprintf to SAL_INFO

Change-Id: I8e0cfedd34d7e0d70a30147a3bbf0f1cd8e6d3cc

diff --git a/editeng/source/editeng/impedit3.cxx 
b/editeng/source/editeng/impedit3.cxx
index 70072a2..74eb16d 100644
--- a/editeng/source/editeng/impedit3.cxx
+++ b/editeng/source/editeng/impedit3.cxx
@@ -564,18 +564,13 @@ void ImpEditEngine::CheckAutoPageSize()
 
 void ImpEditEngine::CheckPageOverflow()
 {
-// FIXME(matteocam)
-/* fprintf( stderr, IsPageOverflow(aPaperSize, aPrevPaperSize)
-? "YES Overflow!\n"  : "NO Overflow!\n" ); */
-// setting overflow status
-
-fprintf(stderr, "[CONTROL_STATUS] AutoPageSize is %s",  ( 
aStatus.GetControlWord() & EEControlBits::AUTOPAGESIZE ) ? "ON\n" : "OFF\n" );
+SAL_INFO("editeng.chaining", "[CONTROL_STATUS] AutoPageSize is " << (( 
aStatus.GetControlWord() & EEControlBits::AUTOPAGESIZE ) ? "ON" : "OFF") );
 
 sal_uInt32 nBoxHeight = GetMaxAutoPaperSize().Height();
-fprintf(stderr, "[OVERFLOW-CHECK] Current MaxAutoPaperHeight is %d\n", 
nBoxHeight);
+SAL_INFO("editeng.chaining", "[OVERFLOW-CHECK] Current MaxAutoPaperHeight 
is " << nBoxHeight);
 
 sal_uInt32 nTxtHeight = CalcTextHeight(NULL);
-fprintf(stderr, "[OVERFLOW-CHECK] Current Text Height is %d\n", 
nTxtHeight);
+SAL_INFO("editeng.chaining", "[OVERFLOW-CHECK] Current Text Height is " << 
nTxtHeight);
 
 sal_uInt32 nParaCount = GetParaPortions().Count();
 sal_uInt32 nFirstLineCount = GetLineCount(0);
@@ -4636,7 +4631,7 @@ void 
ImpEditEngine::ImplUpdateOverflowingParaNum(sal_uInt32 nPaperHeight)
 if ( nY > nPaperHeight /*nCurTextHeight*/ ) // found first paragraph 
overflowing
 {
 mnOverflowingPara = nPara;
-fprintf(stderr, "[CHAINING] Setting first overflowing #Para#: 
%d\n", nPara);
+SAL_INFO("editeng.chaining", "[CHAINING] Setting first overflowing 
#Para#: " << nPara);
 ImplUpdateOverflowingLineNum( nPaperHeight, nPara, nY-nPH);
 return;
 }
@@ -4662,13 +4657,13 @@ void 
ImpEditEngine::ImplUpdateOverflowingLineNum(sal_uInt32 nPaperHeight,
 
 // Debugging output
 if (nLine == 0) {
-fprintf(stderr, "[CHAINING] First line has height %d\n", nLH);
+SAL_INFO("editeng.chaining", "[CHAINING] First line has height " 
<< nLH);
 }
 
 if ( nY > nPaperHeight ) // found first line overflowing
 {
 mnOverflowingLine = nLine;
-fprintf(stderr, "[CHAINING] Setting first overflowing -Line- to: 
%d\n", nLine);
+SAL_INFO("editeng.chaining", "[CHAINING] Setting first overflowing 
-Line- to: " << nLine);
 return;
 }
 }
diff --git a/editeng/source/outliner/outliner.cxx 
b/editeng/source/outliner/outliner.cxx
index 77bb66a..040bc6e 100644
--- a/editeng/source/outliner/outliner.cxx
+++ b/editeng/source/outliner/outliner.cxx
@@ -2094,17 +2094,16 @@ NonOverflowingText *Outliner::GetNonOverflowingText() 
const
 
 // Defensive check: oveflowing para index beyond actual # of paragraphs?
 if ( nCount > GetParagraphCount()-1) {
-fprintf(stderr,
-"[Overflowing] Ops, trying to retrieve para %d when max index 
is %d\n",
-nCount,
-GetParagraphCount()-1);
+SAL_INFO("editeng.chaining",
+ "[Overflowing] Ops, trying to retrieve para "
+ << nCount << " when max index is " << GetParagraphCount()-1 );
 return NULL;
 }
 
  if (nCount < 0)
  {
-fprintf(stderr,
-"[Overflowing] No Overflowing text but GetNonOverflowinText 
called?!\n");
+SAL_INFO("editeng.chaining",
+ "[Overflowing] No Overflowing text but GetNonOverflowinText 
called?!");
 return NULL;
  }
 
@@ -2202,10 +2201,10 @@ OverflowingText *Outliner::GetOverflowingText() const
 
 // Defensive check: oveflowing para index beyond actual # of paragraphs?
 if ( pEditEngine->GetOverflowingParaNum() > GetParagraphCount()-1) {
-fprintf(stderr,
-"[Overflowing] Ops, trying to retrieve para %d when max index 
is %d\n",
-pEditEngine->GetOverflowingParaNum(),
-GetParagraphCount()-1);
+SAL_INFO("editeng.chaining",
+ "[Overflowing] Ops, trying to retrieve

Re: Impact of merging feature/chained-text-boxes to master

2015-09-16 Thread Thorsten Behrens
Matteo Campanelli wrote:
> this is to describe some changes (in code and behavior) that should occur
> merging branch  "feature/chained-text-boxes" to master.
>
Hi Matteo,

thanks a lot for the heads-up -

> What may/will be affected
> ---
> NOTE: The vast majority of the code above should only affect  LO behavior
> for docs that have the tag in (4) set to something sensible.
> 
Yep - so I'd like to switch that live on master, but possibly disable
it / make it experimental-only if we hit issues getting closer to 5.1.

> commit 54b576c3b3bf3d67c5ffd4ae391f6c03e3647dc1
> Author: matteocam 
> Date:   Mon Sep 7 20:01:35 2015 +0200
> 
> Handle chaining for cutting and pasting
> 
That at least works for me. ;)

> commit 731000696b282f457a7e003297d4f158849825d4
> Author: matteocam 
> Date:   Mon Sep 7 19:58:16 2015 +0200
> 
> Handle DEL key for chaining
> 
Same there - almost impossible to unwind why those things were not
uniformly done ...

> commit 1a86da45320faf5f644c1a82c07bd9b522a2a351
> Author: matteocam 
> Date:   Mon Sep 7 16:37:56 2015 +0200
> 
> Enable chaining after a key is pressed
> 
That looks innocent if no chaining happens.

> commit 3748019d58154b2851999c3ea9f2ab223c8e3bc3
> Author: matteocam 
> Date:   Mon Sep 7 12:44:37 2015 +0200
> 
> Change EndTextEdit behavior to support recursive overflow
> 
Can't see any harm in that one either.

Unless there are objections in the ESC tomorrow, let's merge this (I
have one or two smallish cleanups still on my list), and then notify
QA with a similar heads-up, outlining the areas this affects (all
EditEngine clients - most prominently Calc, but also text in draw
shapes inside Writer). Let's hope there's no need for a whiteboard
keyword. ;)

Cheers,

-- Thorsten


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: --show still see GUI

2015-09-01 Thread Thorsten Behrens
Jerry Geis wrote:
> When I use the command line switch --show on linux
> I still see the GUI... the progress loading is what I'm talking about.
> 
> Any way to not see that ? just have a blank/black screen while loading ?
> 
Hi Jerry,

nothing like that existing yet. This being the developer list -
interested to hack up a fix for this? Happy to provide you with code
pointers then.

Cheers,

-- Thorsten


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: Question to Bug 93052 - When save, generate unused list-styles in context.xml

2015-09-01 Thread Thorsten Behrens
Juergen Funk Mailinglist wrote:
> Can anyone help me, for solve or understand this right?
> 
Looks like it's fixed just fine with
d9305ae68bf3707242a96fb1b697c36d6eaf91c4

Cheers,

-- Thorsten


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: vcl/source

2015-08-31 Thread Thorsten Behrens
 vcl/source/opengl/OpenGLContext.cxx |5 -
 1 file changed, 5 deletions(-)

New commits:
commit 751c5f5b75ed27359d8bd8410e5a19ee638b175c
Author: Thorsten Behrens <thorsten.behr...@cib.de>
Date:   Mon Aug 31 15:49:17 2015 +0200

Revert "werror: fix build in vcl"

This reverts commit 5191fcb11688ef8f4ec312293e57e151762c6952.
Earlier, better fix was 831c69f9397ed813364235dddf465996d361d0a8

diff --git a/vcl/source/opengl/OpenGLContext.cxx 
b/vcl/source/opengl/OpenGLContext.cxx
index 70a6cbc5..8253241 100644
--- a/vcl/source/opengl/OpenGLContext.cxx
+++ b/vcl/source/opengl/OpenGLContext.cxx
@@ -785,13 +785,9 @@ bool OpenGLContext::ImplInit()
 glXSwapInterval( 1 );
 
 if( errorTriggered )
-{
 SAL_WARN("vcl.opengl", "error when trying to set swap 
interval, NVIDIA or Mesa bug?");
-}
 else
-{
 VCL_GL_INFO("vcl.opengl", "set swap interval to 1 (enable 
vsync)");
-}
 }
 }
 
@@ -1363,7 +1359,6 @@ void OpenGLContext::makeCurrent()
 
 // move the context to the end of the contexts list
 static int nSwitch = 0;
-(void) nSwitch; // -Werror=unused-variable
 VCL_GL_INFO("vcl.opengl", "*** CONTEXT SWITCH " << ++nSwitch << " 
*");
 if( mpNextContext )
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


Re: My work

2015-08-30 Thread Thorsten Behrens
Jack wrote:
 Due my slow internet connection, I am unable to upload my patches
 the regular way, so i am sending you my work in the
 attachment.

Hi Jack,

unfortunately no attachments made it through with your email.

 The file fix.cxx contains only the two functions, the file
 PropertyMap.cxx contains the whole patched file.
 
 The docx-files are my test cases, they look different in LibreOffice
 than in Word. Failure_2 should be fixed with my patch.
 
Please commit your changes locally, and extract them from git via 'git
format-patch -1'.

 These files may be used under any licence.
 
To expedite matters, the much preferred way is to use stock wording
for licensing. Please see
https://wiki.documentfoundation.org/Development/Developers#Example_Statement
for examples  howto.

Thanks a lot,

-- Thorsten


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: vcl/source

2015-08-29 Thread Thorsten Behrens
 vcl/source/opengl/OpenGLContext.cxx |5 +
 1 file changed, 5 insertions(+)

New commits:
commit 5191fcb11688ef8f4ec312293e57e151762c6952
Author: Thorsten Behrens thorsten.behr...@cib.de
Date:   Sun Aug 30 00:33:49 2015 +0200

werror: fix build in vcl

Change-Id: I30f9e1858c90943e1d369aeea02e10d8037a4ca8

diff --git a/vcl/source/opengl/OpenGLContext.cxx 
b/vcl/source/opengl/OpenGLContext.cxx
index 8253241..70a6cbc5 100644
--- a/vcl/source/opengl/OpenGLContext.cxx
+++ b/vcl/source/opengl/OpenGLContext.cxx
@@ -785,9 +785,13 @@ bool OpenGLContext::ImplInit()
 glXSwapInterval( 1 );
 
 if( errorTriggered )
+{
 SAL_WARN(vcl.opengl, error when trying to set swap 
interval, NVIDIA or Mesa bug?);
+}
 else
+{
 VCL_GL_INFO(vcl.opengl, set swap interval to 1 (enable 
vsync));
+}
 }
 }
 
@@ -1359,6 +1363,7 @@ void OpenGLContext::makeCurrent()
 
 // move the context to the end of the contexts list
 static int nSwitch = 0;
+(void) nSwitch; // -Werror=unused-variable
 VCL_GL_INFO(vcl.opengl, *** CONTEXT SWITCH   ++nSwitch   
*);
 if( mpNextContext )
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


Re: [Libreoffice-commits] core.git: accessibility/source basctl/source basic/source canvas/source chart2/source comphelper/source dbaccess/source framework/source include/o3tl include/sfx2 sc/inc sc/s

2015-08-29 Thread Thorsten Behrens
Daniel Robertson wrote:
 --- a/include/o3tl/cow_wrapper.hxx
 +++ b/include/o3tl/cow_wrapper.hxx
 @@ -199,7 +199,10 @@ int cow_wrapper_client::queryUnmodified() const
  void release()
  {
  if( m_pimpl  !MTPolicy::decrementCount(m_pimpl-m_ref_count) )
 -boost::checked_delete(m_pimpl), m_pimpl = nullptr;
 +{
 +delete m_pimpl;
 +m_pimpl = nullptr;
 +}
  }

Hi Stephan, all,

Daniel reduced boost dependencies a bit with the above, nominally w/o
losing functionality.

I find -Werror=delete-incomplete for gcc and -Wdelete-incomplete for
clang - that's supposedly a much more universal way of catching the
issues checked_delete was there for?

What's the best way to enable that in tinderboxes, I'm afraid
gbuild-wide enabling might fail on older compilers?

Cheers,

-- Thorsten


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: vcl/qa

2015-08-27 Thread Thorsten Behrens
 vcl/qa/cppunit/timer.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit ad3d4a94e5dda6aa2ae39d903f0f9d13c9f85ef7
Author: Thorsten Behrens thorsten.behr...@cib.de
Date:   Thu Aug 27 14:50:57 2015 +0200

vcl: increase timeout for timertest hang by some

Change-Id: I7e61051ca8d7ae2314514e60097ff86481d4ceae

diff --git a/vcl/qa/cppunit/timer.cxx b/vcl/qa/cppunit/timer.cxx
index 2ec940a..76db8a8 100644
--- a/vcl/qa/cppunit/timer.cxx
+++ b/vcl/qa/cppunit/timer.cxx
@@ -46,7 +46,7 @@ public:
 }
 };
 
-static WatchDog aWatchDog( 12 /* 12 secs should be enough */);
+static WatchDog aWatchDog( 120 ); // random high number in secs
 
 class TimerTest : public test::BootstrapFixture
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: vcl/qa

2015-08-25 Thread Thorsten Behrens
 vcl/qa/cppunit/timer.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 6bdd93e3562d0871b7b7179689f01601b5d10538
Author: Thorsten Behrens thorsten.behr...@cib.de
Date:   Tue Aug 25 11:04:38 2015 +0200

vcl: disable randomly failing timer unit tests

Change-Id: Iab26a2b55586fc824c5edbea519c4f68ba4a548f

diff --git a/vcl/qa/cppunit/timer.cxx b/vcl/qa/cppunit/timer.cxx
index 85dc9ac..e89a28f 100644
--- a/vcl/qa/cppunit/timer.cxx
+++ b/vcl/qa/cppunit/timer.cxx
@@ -23,7 +23,7 @@
 
 // #define TEST_WATCHDOG
 // Comment if UT fails randomly.
-#define TEST_TIMERPRECISION
+//#define TEST_TIMERPRECISION
 
 /// Avoid our timer tests just wedging the build if they fail.
 class WatchDog : public osl::Thread
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: include/vcl vcl/source

2015-08-18 Thread Thorsten Behrens
 include/vcl/salbtype.hxx  |   20 
 vcl/source/gdi/pdfwriter_impl.hxx |   47 --
 2 files changed, 1 insertion(+), 66 deletions(-)

New commits:
commit e0b0501452e6a72ba800ae9f536d766f8111ed78
Author: Thorsten Behrens thorsten.behr...@cib.de
Date:   Tue Aug 18 18:36:51 2015 +0200

vcl: kill 'special member functions' the compiler generates

No need to spell out otherwise auto-generated functions.

Change-Id: I1d2aec552df197f6656b0a495cef22696667dc4b
Reviewed-on: https://gerrit.libreoffice.org/17846
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com

diff --git a/include/vcl/salbtype.hxx b/include/vcl/salbtype.hxx
index 673c285..9528ffa 100644
--- a/include/vcl/salbtype.hxx
+++ b/include/vcl/salbtype.hxx
@@ -105,7 +105,6 @@ private:
 public:
 
 inline  BitmapColor();
-inline  BitmapColor( const BitmapColor rBitmapColor );
 inline  BitmapColor( sal_uInt8 cRed, sal_uInt8 cGreen, 
sal_uInt8 cBlue );
 inline  BitmapColor( const Color rColor );
 explicit inline BitmapColor( sal_uInt8 cIndex );
@@ -114,7 +113,6 @@ public:
 
 inline bool operator==( const BitmapColor rBitmapColor ) const;
 inline bool operator!=( const BitmapColor rBitmapColor ) const;
-inline BitmapColor operator=( const BitmapColor rBitmapColor );
 
 inline bool IsIndex() const;
 
@@ -276,14 +274,6 @@ inline BitmapColor::BitmapColor( sal_uInt8 cRed, sal_uInt8 
cGreen, sal_uInt8 cBl
 {
 }
 
-inline BitmapColor::BitmapColor( const BitmapColor rBitmapColor ) :
-mcBlueOrIndex   ( rBitmapColor.mcBlueOrIndex ),
-mcGreen ( rBitmapColor.mcGreen ),
-mcRed   ( rBitmapColor.mcRed ),
-mbIndex ( rBitmapColor.mbIndex )
-{
-}
-
 inline BitmapColor::BitmapColor( const Color rColor ) :
 mcBlueOrIndex   ( rColor.GetBlue() ),
 mcGreen ( rColor.GetGreen() ),
@@ -312,16 +302,6 @@ inline bool BitmapColor::operator!=( const BitmapColor 
rBitmapColor ) const
 return !( *this == rBitmapColor );
 }
 
-inline BitmapColor BitmapColor::operator=( const BitmapColor rBitmapColor )
-{
-mcBlueOrIndex = rBitmapColor.mcBlueOrIndex;
-mcGreen = rBitmapColor.mcGreen;
-mcRed = rBitmapColor.mcRed;
-mbIndex = rBitmapColor.mbIndex;
-
-return *this;
-}
-
 inline bool BitmapColor::IsIndex() const
 {
 return mbIndex;
diff --git a/vcl/source/gdi/pdfwriter_impl.hxx 
b/vcl/source/gdi/pdfwriter_impl.hxx
index aa941d9..43081aa 100644
--- a/vcl/source/gdi/pdfwriter_impl.hxx
+++ b/vcl/source/gdi/pdfwriter_impl.hxx
@@ -182,15 +182,6 @@ public:
 
 BitmapID() : m_nSize( 0 ), m_nChecksum( 0 ), m_nMaskChecksum( 0 ) {}
 
-BitmapID operator=( const BitmapID rCopy )
-{
-m_aPixelSize= rCopy.m_aPixelSize;
-m_nSize = rCopy.m_nSize;
-m_nChecksum = rCopy.m_nChecksum;
-m_nMaskChecksum = rCopy.m_nMaskChecksum;
-return *this;
-}
-
 bool operator==( const BitmapID rComp ) const
 {
 return (m_aPixelSize == rComp.m_aPixelSize 
@@ -701,7 +692,7 @@ private:
 // graphics state
 struct GraphicsState
 {
-vcl::Font   m_aFont;
+vcl::Fontm_aFont;
 MapMode  m_aMapMode;
 Colorm_aLineColor;
 Colorm_aFillColor;
@@ -741,42 +732,6 @@ private:
 m_nFlags( PushFlags::ALL ),
 m_nUpdateFlags( 0x )
 {}
-GraphicsState( const GraphicsState rState ) :
-m_aFont( rState.m_aFont ),
-m_aMapMode( rState.m_aMapMode ),
-m_aLineColor( rState.m_aLineColor ),
-m_aFillColor( rState.m_aFillColor ),
-m_aTextLineColor( rState.m_aTextLineColor ),
-m_aOverlineColor( rState.m_aOverlineColor ),
-m_aClipRegion( rState.m_aClipRegion ),
-m_bClipRegion( rState.m_bClipRegion ),
-m_nAntiAlias( rState.m_nAntiAlias ),
-m_nLayoutMode( rState.m_nLayoutMode ),
-m_aDigitLanguage( rState.m_aDigitLanguage ),
-m_nTransparentPercent( rState.m_nTransparentPercent ),
-m_nFlags( rState.m_nFlags ),
-m_nUpdateFlags( rState.m_nUpdateFlags )
-{
-}
-
-GraphicsState operator=(const GraphicsState rState )
-{
-m_aFont = rState.m_aFont;
-m_aMapMode  = rState.m_aMapMode;
-m_aLineColor= rState.m_aLineColor;
-m_aFillColor= rState.m_aFillColor

Re: [Libreoffice-commits] core.git: slideshow/source

2015-08-18 Thread Thorsten Behrens
Daniel Robertson wrote:
 Author: Daniel Robertson danlrobertso...@gmail.com
 Date:   Sun Aug 16 13:55:51 2015 -0400
 
 slideshow: replace for_each with range-based for
 [etc...]

Hi Daniel,

thanks a lot for the nice cleanup task you did, great job - your stats
so far:

94 insertions(+), 485 deletions(-), -391 net

Things got *much* more readable with the above! :)

Anything on your mind yet what to do next? Want to continue in other
modules? Otherwise, if templates  reducing code bloat is your thing,
perhaps I could pique your further interest with
https://bugs.documentfoundation.org/show_bug.cgi?id=62525 ?

Cheers,

-- Thorsten


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: Changes to 'private/bubli/lhm-4-1-6-backports'

2015-08-17 Thread Thorsten Behrens
New branch 'private/bubli/lhm-4-1-6-backports' available with the following 
commits:
commit 9531d6f899cdff7cc143f9935cfb88a16ad9
Author: Thorsten Behrens thorsten.behr...@cib.de
Date:   Mon Aug 17 10:40:44 2015 +0200

Validate and re-indent mailmerge speedup fix

Seems on master, e0ad036eed6b151ea81311fcf9ba46f1726b103c was
mis-merged, fixed by Caolan via
af8f938531909122ff7a056c2206af857324fdf3. It's actually correct here,
just the indent was off.

Change-Id: I457150cbebd09b7f1663f03a9ca144ca47532145

commit 8f8d70070f437d37bdcb827faa1ea99c82dbd09f
Author: Thorsten Behrens thorsten.behr...@cib.de
Date:   Thu Aug 13 17:17:22 2015 +0200

tdf#44388: handle the NULL clip correctly for pdf output

With the rework to use basegfx polygon clipping (a334752), the case
'fully clipped away', aka NULL clip, aka nothing visible, stopped
working.

Manifests itself as an empty clip polygon, but with m_bClipRegion being
true. Explicitely write out as zero-surface clip polygon.

i#65128 is related.

Change-Id: I57389fcd057d75dfa4e0de9ebb86794437c70b55
(cherry picked from commit 86b47f5138c0c5b882359a48052a796bc91a5afb)

commit 17b50306f2dc637ec704996e205bf3029ebe70c1
Author: Katarina Behrens katarina.behr...@cib.de
Date:   Thu Aug 13 13:38:29 2015 +0200

tdf#92256: Don't force CalcA1 syntax on all !Microsoft xlsx docs

in other words, don't override user's configuration of string ref
syntax

Change-Id: I58e6d1fbc67ce11299dd0a61d8057d39652a1bb6

commit d63d83f95c36d4db3817ea78bf5d0cd3e687de58
Author: Katarina Behrens katarina.behr...@cib.de
Date:   Thu Aug 13 13:33:55 2015 +0200

tdf#92256: Save ref syntax when different from native one

that is, CalcA1 for ODF and ExcelA1 for OOXML

Change-Id: Ibbfd58aad7513bc9e946be26d4aec685c5896708

commit 48940f96532febfd8985bc0811d48942d4b990a7
Author: Katarina Behrens katarina.behr...@cib.de
Date:   Thu Aug 13 13:25:14 2015 +0200

tdf#92256: Make sure ref syntax of Excel docs gets saved

SetStringRefSyntax guarantees that, as it sets also ScCalcConfig -
mbHasStringRefSyntax to true

Change-Id: Ibe7ec017dcaedbd5f7d6e02e2774be5046439c36

commit eedb1608870a74af2570a061b88ae0b2d602c5df
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date:   Tue May 19 02:24:30 2015 +0200

use XL_A1 as ref string syntax for excel produced documents

Conflicts:
sc/inc/document.hxx
sc/source/filter/oox/workbookhelper.cxx

Change-Id: Ieed3521674ef713d9c09313cd41d1edd6ba3dcc5

commit ecaa5447d6f52fa231883bed33582148464615df
Author: Markus Mohrhard markus.mohrh...@collabora.co.uk
Date:   Mon Feb 23 02:19:32 2015 +0100

import the document properties before the document

That allows us to potentially change the import depending on the
producer of the document.

This becomes necessary to handle MSO 2007 chart drawingml streams
correctly.

Conflicts:
sc/source/filter/oox/excelfilter.cxx

Change-Id: I9be8b019fae69cd206203591982a89648965692f

commit 0fa5a941f9e872e5230d4bff609ead0706c51479
Author: Katarina Behrens katarina.behr...@cib.de
Date:   Mon Jul 27 15:12:26 2015 +0200

tdf#92256: Improved interop of INDIRECT function, OOXML part

Change-Id: I46bb65fb620c376d43d8a53396c7b0bab1c00c7a

commit b469180dc07d4b0bbd3c303fc2160cb0e2dd4171
Author: Katarina Behrens katarina.behr...@cib.de
Date:   Mon Jul 27 13:36:34 2015 +0200

tdf#92256: Improved interop of INDIRECT function

backport of core/interpreter changes and ODF export/import

Change-Id: Ibac7aed67edaf524e5c594d12aa0abefe465baea

commit 5f366715a0cb8b23d025515db44733702ef19486
Author: Eike Rathke er...@redhat.com
Date:   Fri Mar 14 23:00:25 2014 +0100

some formula interpreter options are document specific

Ideally they'd even be stored as document options. Future work?

Conflicts:
sc/inc/document.hxx
sc/qa/unit/ucalc.cxx
sc/qa/unit/ucalc_formula.cxx
sc/source/core/data/documen2.cxx
sc/source/core/data/document10.cxx
sc/source/core/tool/interpr4.cxx
sc/source/core/tool/interpr5.cxx

Change-Id: Ida126a441ca88c35406fb66ea3722d6335e6e8e2

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: basctl/inc basctl/source canvas/source chart2/source connectivity/source dbaccess/source extensions/source forms/inc forms/source include/o3tl o3tl/README reportdesign/

2015-08-17 Thread Thorsten Behrens
 basctl/inc/pch/precompiled_basctl.hxx |2 
 basctl/source/dlged/dlgedobj.cxx  |2 
 canvas/source/factory/cf_service.cxx  |2 
 chart2/source/controller/accessibility/AccessibleBase.cxx |2 
 chart2/source/controller/chartapiwrapper/ChartDocumentWrapper.cxx |2 
 chart2/source/inc/ContainerHelper.hxx |2 
 chart2/source/model/template/ChartTypeManager.cxx |2 
 connectivity/source/commontools/TSortIndex.cxx|2 
 connectivity/source/commontools/TTableHelper.cxx  |2 
 dbaccess/source/core/dataaccess/documentevents.cxx|2 
 dbaccess/source/ui/browser/genericcontroller.cxx  |2 
 dbaccess/source/ui/dlg/DbAdminImpl.cxx|2 
 extensions/source/propctrlr/eformshelper.cxx  |2 
 extensions/source/propctrlr/eventhandler.cxx  |2 
 extensions/source/propctrlr/genericpropertyhandler.cxx|2 
 forms/inc/pch/precompiled_frm.hxx |2 
 forms/source/xforms/convert.cxx   |2 
 forms/source/xforms/datatyperepository.cxx|2 
 include/o3tl/compat_functional.hxx|   65 
--
 include/o3tl/functional.hxx   |   65 
++
 o3tl/README   |7 -
 reportdesign/source/ui/inspection/GeometryHandler.cxx |2 
 sd/inc/pch/precompiled_sd.hxx |2 
 sd/source/ui/tools/PropertySet.cxx|1 
 svx/inc/pch/precompiled_svxcore.hxx   |2 
 svx/source/form/formcontroller.cxx|2 
 26 files changed, 91 insertions(+), 91 deletions(-)

New commits:
commit ad1f0d1f1a195a00cf2ec2848745fdc6186bfbb1
Author: Thorsten Behrens thorsten.behr...@cib.de
Date:   Mon Aug 17 14:40:17 2015 +0200

o3tl: rename compat_functional header

After the cleanup, the stuff there really stands on its own (and the
remaining usage of select1st/2nd is more descriptive than lambdas).

Change-Id: I0aba131d5dc550189f8130d167dc94167e404540
Reviewed-on: https://gerrit.libreoffice.org/17806
Reviewed-by: Thorsten Behrens thorsten.behr...@cib.de
Tested-by: Thorsten Behrens thorsten.behr...@cib.de

diff --git a/basctl/inc/pch/precompiled_basctl.hxx 
b/basctl/inc/pch/precompiled_basctl.hxx
index ec4fc38..0ae4276 100644
--- a/basctl/inc/pch/precompiled_basctl.hxx
+++ b/basctl/inc/pch/precompiled_basctl.hxx
@@ -112,7 +112,7 @@
 #include framework/documentundoguard.hxx
 #include initializer_list
 #include map
-#include o3tl/compat_functional.hxx
+#include o3tl/functional.hxx
 #include officecfg/Office/Common.hxx
 #include osl/diagnose.h
 #include osl/file.hxx
diff --git a/basctl/source/dlged/dlgedobj.cxx b/basctl/source/dlged/dlgedobj.cxx
index f43879c..9e4ab9b 100644
--- a/basctl/source/dlged/dlgedobj.cxx
+++ b/basctl/source/dlged/dlgedobj.cxx
@@ -39,7 +39,7 @@
 #include com/sun/star/lang/WrappedTargetRuntimeException.hpp
 #include com/sun/star/script/XScriptEventsSupplier.hpp
 #include com/sun/star/table/CellAddress.hpp
-#include o3tl/compat_functional.hxx
+#include o3tl/functional.hxx
 #include unotools/sharedunocomponent.hxx
 #include vcl/svapp.hxx
 
diff --git a/canvas/source/factory/cf_service.cxx 
b/canvas/source/factory/cf_service.cxx
index 9d1d2b2..3a8130d 100644
--- a/canvas/source/factory/cf_service.cxx
+++ b/canvas/source/factory/cf_service.cxx
@@ -38,7 +38,7 @@
 #include cppuhelper/supportsservice.hxx
 #include osl/mutex.hxx
 #include osl/process.h
-#include o3tl/compat_functional.hxx
+#include o3tl/functional.hxx
 
 using namespace ::com::sun::star;
 using namespace ::com::sun::star::uno;
diff --git a/chart2/source/controller/accessibility/AccessibleBase.cxx 
b/chart2/source/controller/accessibility/AccessibleBase.cxx
index d092640..c14f9da 100644
--- a/chart2/source/controller/accessibility/AccessibleBase.cxx
+++ b/chart2/source/controller/accessibility/AccessibleBase.cxx
@@ -48,7 +48,7 @@
 #include vcl/window.hxx
 #include vcl/graph.hxx
 #include vcl/settings.hxx
-#include o3tl/compat_functional.hxx
+#include o3tl/functional.hxx
 
 #include algorithm
 
diff --git a/chart2/source/controller/chartapiwrapper/ChartDocumentWrapper.cxx 
b/chart2/source/controller/chartapiwrapper/ChartDocumentWrapper.cxx
index d89abcc..d356bea 100644
--- a/chart2/source/controller/chartapiwrapper/ChartDocumentWrapper.cxx
+++ b/chart2/source/controller/chartapiwrapper/ChartDocumentWrapper.cxx
@@ -66,7 +66,7 @@
 #include vector
 #include algorithm
 #include functional
-#include o3tl/compat_functional.hxx
+#include o3tl/functional.hxx
 
 using namespace ::com::sun

<    1   2   3   4   5   6   7   8   9   10   >