About recent commits for C++11 building

2014-09-14 Thread julien2412
Hello, Following last commits for MacOs which increases compatibility with C++11, I'd like to know if: 1) we can replace all the workaround about the erase iterator management for some containers (with a temp iterator) and directly use for every case for eg: it = itcontainer.erase(it); 2) we can

[ABANDONNED] Re: About recent commits for C++11 building

2014-09-14 Thread julien2412
Ok we're still not compatible C++11, see http://ci.libreoffice.org/job/buildbot/2477/ Sorry for the noise. Julien -- View this message in context: http://nabble.documentfoundation.org/About-recent-commits-for-C-11-building-tp4122219p413.html Sent from the Dev mailing list archive at

Building pb OTools.cxx in MacOs (connectivity part)

2014-09-14 Thread julien2412
Hello, On Mac OS 10.9 and master sources updated about 2 days ago, I've got this building problem: lo/core/connectivity/source/drivers/odbc/OTools.cxx:462:23: error: no matching member function for call to 'append' aData.append(waCharArray, nReadChars);

Re: Missing image warning

2014-09-11 Thread julien2412
Hello Chris, You might be interested in this bugtracker: https://bugs.freedesktop.org/show_bug.cgi?id=83315 Other: could not load image svx/res/notcertificate_16.png :-) Julien -- View this message in context: http://nabble.documentfoundation.org/Missing-image-warning-tp4121972p4122004.html

Cppcheck:Logical disjunction always evaluates to true in svdotextdecomposition.cxx (svx module)

2014-09-06 Thread julien2412
Hello, Cppcheck reported this: 1237incorrectLogicOperator style Logical disjunction always evaluates to true: nRepeat||!nRepeat. in svx/source/svdraw/svdotextdecomposition.cxx Indeed, we've got this: 1236 // loop. In loop, move through 1237 if(nRepeat || 0L == nRepeat)

Re: Suggestion for the use of pre-written responses

2014-08-20 Thread julien2412
jphilipz wrote .. So i'd like to propose the creation a wiki page of pre-written responses that we can all use. I have created the wiki page at https://wiki.documentfoundation.org/QA/BugTriage/Pre-Written_Responses and will be adding entries to it, though i have very little knowledge of

Re: Suspicious loop: any idea?

2014-08-17 Thread julien2412
Just to check more quickly, here's the link: http://opengrok.libreoffice.org/xref/core/sw/source/core/frmedt/feshview.cxx#720 I agree with you, this part is strange: SdrObject *pO = pLst-GetMark( 0 )-GetMarkedSdrObj(); Shouldn't it be this? SdrObject *pO = pLst-GetMark( j )-GetMarkedSdrObj();

Re: May I know where is intro image and how to link it?

2014-08-10 Thread julien2412
You should find some answers here: https://wiki.documentfoundation.org/Development and more precisely here if you build on Linux: https://wiki.documentfoundation.org/Development/BuildingOnLinux To answer your question, when I want to launch LO from built sources, I do: cd LO root

[PUSHED] Re: [PATCH] typo: and - an

2014-08-04 Thread julien2412
Thank you Jan for your patch, I pushed it on master sources (future 4.4.0), see http://cgit.freedesktop.org/libreoffice/core/commit/?id=04a65e2704ee80701ca750f2e7c8c0565d2aa830 Could you please send a license mail to libreoffice@lists.freedesktop.org as described on this page:

Re: Suspicious attribute style:repeat=scale

2014-07-30 Thread julien2412
After some Googling, I only found this: https://wiki.openoffice.org/wiki/User:Frank_Sch%C3%B6nheit/ODF_Proposals/Image_Control_Scale -- View this message in context: http://nabble.documentfoundation.org/Suspicious-attribute-style-repeat-scale-tp4117240p4117258.html Sent from the Dev mailing

Re: Some dialogs don't work in OS X (master branch)

2014-07-26 Thread julien2412
I could reproduce this with master sources updated today and MacOs 10.9.4. Would it be possible you submit a new bugtracker by using this link: https://www.libreoffice.org/get-help/bug/ ? Julien -- View this message in context:

Re: additional dictionaries

2014-07-23 Thread julien2412
JE G wrote ... What are the requirements to get a word list like this into a specialized spelling dictionary? Is there software to do it or a special format? Hello, There's this https://wiki.documentfoundation.org/Development/Dictionaries about dictionaries but I don't think it would help in

Re: I need to better understand our css::uno::Reference

2014-06-23 Thread julien2412
Hello, Sorry for this certainly naive and humble (because I wouldn't be able at all to help here) question, but just by curiosity, is there some plan to rewrite partly/clean UNO in order to: - not depend on vtables implementation - avoid to use of reinterpret_cast (and therefore possibly detect

[SOLVED] Re: Build fails on CppunitTest_svl_qa_cppunit

2014-06-19 Thread julien2412
Solved thanks to Lionel and Isamu (see http://nabble.documentfoundation.org/fdo-44286-unittest-fails-in-non-English-locale-td4112845.html) -- View this message in context: http://nabble.documentfoundation.org/Build-fails-on-CppunitTest-svl-qa-cppunit-tp4112827p4112855.html Sent from the Dev

Build fails on CppunitTest_svl_qa_cppunit

2014-06-18 Thread julien2412
Hello, With master sources updated today, the build fails with this console logs: /home/julien/compile-libreoffice/libreoffice/svl/qa/unit/svl.cxx:403:(anonymous namespace)::Test::testFdo44286 equality assertion failed - Expected: 1902-04-22 - Actual : -04-DD svl.cxx:403:Assertion Test

Re: Access2Base - New release

2014-06-16 Thread julien2412
Hi, I read the whole thread and tried to understand, tried because I'm not enough fluent in these technical/internal LO part. Why A2B must be quickly (I mean without waiting for next LO version) upgradable? Either it's stable and so we don't absolutely need to upgrade it quickly or it's unstable

Re: Build fail with MacOs in connectivity part

2014-06-09 Thread julien2412
Indeed Norbert is right, I got this: /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.8.sdk/usr/include/odbcinst.h and SQLWCHAR is defined as Norbert indicated. I suppose it's 64 bits since config.log displays this: build='x86_64-apple-darwin13.2.0'

Re: Build fail with MacOs in connectivity part

2014-06-09 Thread julien2412
Thank you Tor for these advice, I removed them. About Ant, Autoconf and Automake, I used brew. Concerning Junit, I disabled it. About 64 bits, indeed I hadn't put --enable-64-bits, I added it. Finally about Windows, I'm aware there's a pb with 64 build. I did try 1 or 2 years ago to build (just

Build fail with MacOs in connectivity part

2014-06-08 Thread julien2412
Hello, I gave a try to a MacOs build and had this error: [build CXX] connectivity/source/drivers/odbc/OTools.cxx /lo/core/connectivity/source/drivers/odbc/OPreparedStatement.cxx:338:9: error: static_assert failed sizeof(SQLWCHAR) == 2 BOOST_STATIC_ASSERT( sizeof(SQLWCHAR)== 2 );

Re: Build fail with MacOs in connectivity part

2014-06-08 Thread julien2412
Trying to unwind, I found this: http://opengrok.libreoffice.org/xref/core/external/unixODBC/inc/odbc/sqltypes.h#112 112 #ifdef SQL_WCHART_CONVERT 113 typedef wchar_t WCHAR; 114 #else 115 typedef unsigned short WCHAR; 116 #endif After a test, I confirm that

Re: Build fail with MacOs in connectivity part

2014-06-08 Thread julien2412
Sorry Lionel, I had just checked my emails, not the forum. I'll take a look Julien -- View this message in context: http://nabble.documentfoundation.org/Build-fail-with-MacOs-in-connectivity-part-tp4111804p4111817.html Sent from the Dev mailing list archive at Nabble.com.

Some checkings related to

2014-06-01 Thread julien2412
Hello, Taking a look at https://bugs.freedesktop.org/show_bug.cgi?id=79499, I opengroked xub_StrLen and found some references. Most of them are just comments but there are associated checks See http://opengrok.libreoffice.org/search?q=xub_StrLenproject=coredefs=refs=path=hist= I wonder if these

Re: [SOLVED] Re: Strange part in connectivity/source/drivers/jdbc/tools.cxx

2014-05-30 Thread julien2412
Lionel Elie Mamane wrote ...or, of course, even better yet, pBegin-Name != JavaDriverClass ... Yes, Julien, this one is IMHO worth doing. It makes the code that much more readable :) Done now on master, see

Re: avoiding cppunit zerodiv correction

2014-05-30 Thread julien2412
Matteo Casalin-3 wrote ... I don't have any comment about your proposal, but just would like to add that unless we know for sure that nHeight!=0 at that point, in both codes the check should be if( nHeight = 0 ) in order to solve the division by 0 completely. You're right of course.

LibreOffice, about avoiding attempt to erase from container with a past-the-end iterator

2014-05-28 Thread julien2412
Hello, I noticed this interesting change http://cgit.freedesktop.org/libreoffice/core/commit/?id=72827968e606adcdf8c16e5381b887180975ae46 (Try to avoid attempt to erase from container with a past-the-end iterator) I tried to search similar cases in Opengrok and found some of them (because quite

[SOLVED] Re: LibreOffice, about avoiding attempt to erase from container with a past-the-end iterator

2014-05-28 Thread julien2412
Thank you Stephan for your feedback, so I'll let this as it is. Julien -- View this message in context: http://nabble.documentfoundation.org/LibreOffice-about-avoiding-attempt-to-erase-from-container-with-a-past-the-end-iterator-tp4110615p4110679.html Sent from the Dev mailing list archive at

Strange part in connectivity/source/drivers/jdbc/tools.cxx

2014-05-28 Thread julien2412
Hello, I noticed this part: 113 // this is a special property to find the jdbc driver 114 if ( pBegin-Name.compareToAscii( JavaDriverClass ) 115 pBegin-Name.compareToAscii( JavaDriverClassPath ) 116 pBegin-Name.compareToAscii(

About removing Browser Plugin

2014-05-27 Thread julien2412
Hello, Following https://bugs.freedesktop.org/show_bug.cgi?id=45071, it seems Browser plugin can be removed from 4.4 To do this, I thought git removing core/extensions/source/plugin/, + tune some mk file in core/extensions and finally core/configure.ac should be ok. 1) Is it ok? Am I forgetting

Re: Questions about getCppuType

2014-05-23 Thread julien2412
After lots of changes, there are still Sequence cases + things like: ::getCppuType(m_sFilter)); just to be sure, should it replaced by cppu::UnoType type of m_sFilter ::get(); ? Also, are there special cases to take into account for these? Julien -- View this message in context:

[SOLVED] Re: Wrong copy paste in ucbcmds.cxx? (ucb module)

2014-05-20 Thread julien2412
sberg wrote ... I wonder if line 254 could be a wrong copy paste and should be: cppu::UnoType ucb::CheckinArgument ::get() ); Yes, that's wrong. (See UniversalContentBroker::execute in ucb/source/core/ucb.cxx, where CHECKIN_HANDLE/CHECKIN_NAME expects to get a CheckinArgument, not a

Re: Questions about getCppuType

2014-05-18 Thread julien2412
I noticed there are a lot of Reference without prefix. Is there a way to be sure it's ok to replace these occurences by cppu::UnoType... ? -- View this message in context: http://nabble.documentfoundation.org/Questions-about-getCppuType-tp4106361p4109226.html Sent from the Dev mailing list

Re: Questions about getCppuType

2014-05-18 Thread julien2412
Athomas: indeed, I hope there's another way because I'm running a simple regexp to replace the occurences:-) -- View this message in context: http://nabble.documentfoundation.org/Questions-about-getCppuType-tp4106361p4109260.html Sent from the Dev mailing list archive at Nabble.com.

[SOLVED] Re: Question unoType for getXmlToken (dbaccess/reportdesign module)

2014-05-17 Thread julien2412
Thank you Lionel for your detailed feedback! I quoted you for the comment, see http://cgit.freedesktop.org/libreoffice/core/commit/?id=f62de9113a4866f7152acbe0e8221c594b7a7b68 Julien -- View this message in context:

Question unoType for getXmlToken (dbaccess/reportdesign module)

2014-05-16 Thread julien2412
Hello, I noticed this: s_aTypeNameMap[GetXMLToken( XML_FLOAT)] = ::cppu::UnoTypedouble::get(); present at 2 locations: See http://opengrok.libreoffice.org/search?q=%22GetXMLToken%28+XML_FLOAT%29%22project=coredefs=refs=path=hist= Why shouldn't be this: s_aTypeNameMap[GetXMLToken( XML_FLOAT)] =

Wrong copy paste in ucbcmds.cxx? (ucb module)

2014-05-16 Thread julien2412
Hello, I noticed this part: 236 CommandProcessorInfo::CommandProcessorInfo() 237 { 238 m_pInfo = new uno::Sequence ucb::CommandInfo ( 2 ); 239 240 (*m_pInfo)[ 0 ] 241 = ucb::CommandInfo( 242 OUString( GETCOMMANDINFO_NAME ), // Name 243

Re: Questions about getCppuType

2014-05-16 Thread julien2412
I noticed that if I did this: diff --git a/cppu/qa/test_unotype.cxx b/cppu/qa/test_unotype.cxx index bbea200..f0d2b03 100644 --- a/cppu/qa/test_unotype.cxx +++ b/cppu/qa/test_unotype.cxx @@ -271,8 +271,8 @@ void Test::testUnoType() { void Test::testGetTypeFavourUnsigned() {

[SOLVED] Re: About removing macros

2014-05-13 Thread julien2412
About DECL_PROP1IMPL, DECL_PROP0 and others, patches pushed on master (eg: http://cgit.freedesktop.org/libreoffice/core/commit/?id=aa214079b4e9df493b57fbf815460b7164225f2b http://cgit.freedesktop.org/libreoffice/core/commit/?id=0fadbdbbdbd55cf60f9a202f1cf7b1d60517078c) Julien -- View this

Re: Questions about getCppuType

2014-05-11 Thread julien2412
As you may have seen, I've begun to replace occurences. Just to be sure, is Sequence always a shortcut of css::uno::Sequence or could it be something else sometimes? (I mean something not related to css::uno) Idem for Reference, could it be something else that css::uno::Reference? Julien --

Re: Questions about getCppuType

2014-05-07 Thread julien2412
Thank you Stephan for these information. In fact, my primary goal was to clean this use of getCppuType because it was reported by cppcheck (when they were used in if/else if blocks) Then I wanted to remove all of them. The problem is there are 33 Opengrok pages of these and I don't know enough

Re: [patch] [solved] build failure

2014-05-06 Thread julien2412
Sorry Terrence, my fault here :-( Thanks to Kohei, I could fix these at the beginning of the morning (UTC+2) It could be useful to force building in C++98 or at least put an option in autogen.input. Julien -- View this message in context:

[SOLVED] Re: Questions about getCppuType

2014-05-05 Thread julien2412
sberg wrote ... With cppu::UnoType, instead use cppu::UnoUnsignedShortType and cppu::UnoCharType as template arguments, respectively. (And do get rid of the useless const in the template arguments.) Thank you Stephan for your feedback, I'll use these and remove const for all the

Question about debugging cppunit tests

2014-05-04 Thread julien2412
Hello, I'm trying to run gdb on cppunit failing by following this: to rerun just this failed test without all others, run: make JunitTest_chart2_unoapi cd into the module dir to run the tests faster Or to do interactive debugging (non-Windows), run two shells with: make debugrun

About glyph fallback message (vcl module)

2014-05-02 Thread julien2412
Hello, On pc Debian x86-64 with master source updated yesterday, I've got this message on console when going to Options/Language Settings/Languages: warn:vcl:26860:1:vcl/generic/fontmanager/fontconfig.cxx:868: In glyph fallback throwing away the language property of en because the detected script

[SOLVED] Re: About Svgreader

2014-05-01 Thread julien2412
Thank you Christina for your feedback, I used it for http://cgit.freedesktop.org/libreoffice/core/commit/?id=1cb924de8a6f03827ae34aa2d66137b6b5e34112 Julien -- View this message in context: http://nabble.documentfoundation.org/About-Svgreader-tp4107050p4107174.html Sent from the Dev mailing

About Svgreader

2014-04-30 Thread julien2412
Hello, Reading bugtrackers about SVG, I noticed there were 2 locations with svgreader: - filter/source/svg/svgreader.cxx - svgio/source/svgreader (there's also svgio/source/svguno) There's no README for svgio/ and the README of filter isn't detailed. Someone to explain (perhaps update/add

[SOLVED] Re: About ANIMATIONMODE_VIEW in slideshow module

2014-04-27 Thread julien2412
Thorsten Behrens wrote Julien Nabet wrote: Ok to remove ANIMATIONMODE_VIEW or did I miss something? Yep, looks fine to me. Thank you Thorsten for your feedback, I pushed the patch on master (see http://cgit.freedesktop.org/libreoffice/core/commit/?id=916cbd94d1c848bc69166915b96ff89ac380c913)

About removing macros

2014-04-27 Thread julien2412
Hello, I noticed the use of macros like DECL_PROP1IMPL, DECL_PROP0 (see http://opengrok.libreoffice.org/search?q=DECL_PROP1IMPLproject=coredefs=refs=path=hist=). Does it worth it to remove them? More generally, what macros could/should be removed? Julien -- View this message in context:

About ANIMATIONMODE_VIEW in slideshow module

2014-04-26 Thread julien2412
Hello, Just taking a look at slideshow module, I searched about ANIMATIONMODE_VIEW to understand the difference between it and ANIMATIONMODE_SHOW. Here is the result: - once in the enum - once in a test so it seems no var can have this value see

Cppcheck reports Deallocation of an auto-variable results in undefined behaviour in vcl part

2014-04-26 Thread julien2412
Hello, Cppcheck reported this: [vcl/source/gdi/bitmap4.cxx:229]: (error) Deallocation of an auto-variable results in undefined behaviour 137 long(*pKoeff)[ 256 ] = new long[ 9 ][ 256 ]; ... 229 delete[] pKoeff; See

Re: Questions about getCppuType

2014-04-25 Thread julien2412
sberg wrote ... getCppuType is not without flaws though, and cppu::UnoType should be used instead. ... What cast are you talking about? The one in the typical usage like getCppuType((T*)0)? Sure, nothing keeps you from writing that as getCppuType(static_castlt;T*gt;(0)), or better yet,

Re: Questions about getCppuType

2014-04-25 Thread julien2412
I've begun to replace some parts and had this when I've changed this: else if ( pType == ::getCppuType((const sal_uInt16*)0) ) into this: else if ( pType == cppu::UnoTypeconst sal_uInt16::get() ) : cd /home/julien/compile-libreoffice/libreoffice/sfx2 make -j 4 -rs [build CXX]

Questions about getCppuType

2014-04-24 Thread julien2412
Hello, Seeing the number of times getCppuType is used, I've got several questions about this: - what's the use of it? It resembles at the first look to typeid but I suppose it's not this. - could there be an alternative? (eg a more native/straightforward C++ way)? - if it still must be used,

[SOLVED] Re: About cpplint

2014-04-22 Thread julien2412
Thank you Stephan for your feedback, so let's drop it. Julien -- View this message in context: http://nabble.documentfoundation.org/About-cpplint-tp4105821p4106051.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing

Dead code in escherex.cxx (filter module)

2014-04-22 Thread julien2412
Hello, Taking a look to this part: 4442 if ( nErrCode == ERRCODE_NONE ) 4443 { p_EscherBlibEntry-meBlibType = ( eGraphicType == GRAPHIC_BITMAP ) ? PNG : EMF; 4445 aStream.Seek( STREAM_SEEK_TO_END ); 4446

Äbout cpplint

2014-04-20 Thread julien2412
Hi, I gave a try to cpplint (http://google-styleguide.googlecode.com/svn/trunk/cpplint/cpplint.py) with some changes so it scan subdirectories. Except pure formatting warnings, it reports things like this: 1) ./drawinglayer/source/primitive2d/polygonprimitive2d.cxx:274: Consider using

Build fail on master

2014-04-18 Thread julien2412
Hi, On pc Debian x86-64 with master sources updated today + make clean, I've got this: In file included from /home/julien/compile-libreoffice/libo/basic/source/runtime/methods1.cxx:41:0: /home/julien/compile-libreoffice/libo/basic/source/inc/runtime.hxx: In function ‘void

Re: HarfBuzz performance problem

2014-04-16 Thread julien2412
Hi, Just taking a look to Harfbuzz releases, I noticed there was a 0.9.27 version, current download.lst indicates 0.9.23 (see http://opengrok.libreoffice.org/xref/core/download.lst). Even if changelog indicates only micro optim, perhaps it could be interesting to give it a try. If it doesn't

Re: Searching help to build LibreOffice

2014-04-12 Thread julien2412
Hi, Here's the main page for developpers: https://wiki.documentfoundation.org/Development and for LO building on Linux: https://wiki.documentfoundation.org/Development/BuildingOnLinux Now which sources are you trying to build? (master, 4.2 branch, ...) Julien -- View this message in context:

What encoding is used?

2014-04-12 Thread julien2412
Hello, The use of cppcheck-htmlreport to convert raw cppcheck reports errors to html fails for some files because of the encodings. Here's an example message: cppcheck/htmlreport/cppcheck-htmlreport, line 287, in module content = input_file.read() File /usr/lib/python2.7/codecs.py, line

Build fails (-Werror=deprecated-declarations), vcl module

2014-04-09 Thread julien2412
Hello, On pc Debian x86-64 with master sources updated today, I got this: /home/julien/compile-libreoffice/libo/vcl/unx/gtk/a11y/atkimage.cxx: In function ‘void image_get_image_position(AtkImage*, gint*, gint*, AtkCoordType)’:

[SOLVED] Re: Build fails (-Werror=deprecated-declarations), vcl module

2014-04-09 Thread julien2412
Thank you Stephan for your patch. Julien -- View this message in context: http://nabble.documentfoundation.org/Build-fails-Werror-deprecated-declarations-vcl-module-tp4104605p4104688.html Sent from the Dev mailing list archive at Nabble.com. ___

Re: About using sdk

2014-04-08 Thread julien2412
Ok I finally gave a new try and I put result here: https://bugs.freedesktop.org/show_bug.cgi?id=77028#c2 I could open the pptx then export to PDF manually but not open pptx + export pdf automatically, ie without opening LO With soffice --nofirststartwizard --nologo --headless --norestore

Re: About using sdk

2014-04-07 Thread julien2412
Thank you Stephan for your feedback. But then I don't know how to launch the example of fdo#77028. I mean I don't know where I must put test.pptx from the fdo and what I should change to load pptx + ask pdf conversion. Indeed, if I run make DocumentLoader.run, it'll load test.ods not test.pptx.

About using sdk

2014-04-05 Thread julien2412
Hello, Reading https://bugs.freedesktop.org/show_bug.cgi?id=77028, I haven't found the way to launch sdk from the built sources. I added --enable-odk in autogen.input and run make (without a make clean before). ls instdir/sdk/bin gives this: cppumaker idlc javamaker regcompare ucpp

Re: About parts in ODatabaseMetaData.cxx (connectivy module/odbc part)

2014-04-05 Thread julien2412
Thank you Lionel for your feedback. Here's a proposed patch here: https://gerrit.libreoffice.org/#/c/8863/ Julien -- View this message in context: http://nabble.documentfoundation.org/About-parts-in-ODatabaseMetaData-cxx-connectivy-module-odbc-part-tp4104005p4104182.html Sent from the Dev

Re: About parts in ODatabaseMetaData.cxx (connectivy module/odbc part)

2014-04-05 Thread julien2412
Lionel Elie Mamane wrote It would seem to me that indeed the ownDeletesAreVisible is wrong. OTOH, it was == and it was changed in (by Ocke Janssen, not Olivier Bolte, who as far as I understand has done the merge): ... So I would like to be cautious there. I cannot find any definite source

Cppcheck reports 'else if' condition matches previous condition (svx)

2014-04-05 Thread julien2412
Hello, Cppcheck reported this svx/source/unodraw/unomod.cxx 492 multiCondition style Expression is always false because 'else if' condition matches previous condition at line 460. Remark: It's a new kind of cppcheck detection and there are quite a lot of false positives (at least for LO)

Cppcheck reports 'else if' condition matches previous condition (vcl)

2014-04-05 Thread julien2412
Hello, Cppcheck reported this: vcl/source/gdi/impimage.cxx 300 multiCondition style Expression is always false because 'else if' condition matches previous condition at line 298. Indeed we have: 296 else 297 { 298 if(

About parts in ODatabaseMetaData.cxx (connectivy module/odbc part)

2014-04-03 Thread julien2412
Hello, Taking a look at connectivity/source/drivers/odbc/ODatabaseMetaData.cxx without particular reason, I noticed this: 1044 sal_Bool SAL_CALL ODatabaseMetaData::supportsOrderByUnrelated( ) throw(SQLException, RuntimeException, std::exception) 1045 { 1046 OUString aValue; 1047

Re: About parts in ODatabaseMetaData.cxx (connectivy module/odbc part)

2014-04-03 Thread julien2412
Re reading part 1), i was obviously wrong. SQL_ORDER_BY_COLUMNS_IN_SELECT indicates if columns contained in order by clause must be in Select part. So it's normal supportsOrderByUnrelated must test this value equal to 'N' I found another part however: 1622 sal_Bool SAL_CALL

Cppcheck reports Using 'memset' on class that contains ... (sw module)

2014-03-29 Thread julien2412
Hello, Cppcheck reported this: sw/source/filter/ww8/ww8scan.cxx 5158memsetClass error Using 'memset' on class that contains a virtual method. 5158memsetClass error Using 'memset' on class that contains a reference. 5158memsetClass error Using 'memset' on class that

Cppcheck reports Same expression on both sides of '' (sc module)

2014-03-29 Thread julien2412
Hello, Cppcheck reported this: sc/source/core/opencl/op_statistical.cxx 3221duplicateExpression style Same expression on both sides of ''. 3233duplicateExpression style Same expression on both sides of ''. 3245duplicateExpression style Same expression on both sides

Re: Bunch of error messages related to gio_content.cxx

2014-03-25 Thread julien2412
Hi Stephan, sberg wrote On my different sources (master, 4.2 and 4.1), I noticed these logs: warn:ucb.ucp.gio:5217:1:ucb/source/ucp/gio/gio_content.cxx:378: ignoring GError L'emplacement indiqué n'est pas pris en charge for lt;vnd.sun.star.job:alias=UpdateCheckgt; [...] Those should be

Bunch of error messages related to gio_content.cxx

2014-03-24 Thread julien2412
Hello, On my different sources (master, 4.2 and 4.1), I noticed these logs: warn:ucb.ucp.gio:5217:1:ucb/source/ucp/gio/gio_content.cxx:378: ignoring GError L'emplacement indiqué n'est pas pris en charge for vnd.sun.star.job:alias=UpdateCheck

Re: About SwSortedObjs

2014-03-22 Thread julien2412
Hi Miklos, Miklos Vajna-4 wrote Isn't the difference between std::set and std::map that the key is separated from the value, i.e. it has an operator[] what you want here? The [] operator is to retrieve the nth element of the sorted vector. I don't figure out how map would replace vector here?

Cppcheck reports Division by zero in new.cxx (sfx2 module)

2014-03-22 Thread julien2412
Hello, Cppcheck reported this: sfx2/source/doc/new.cxx 81 zerodiv error Division by zero. Indeed we have this: 74 #define FRAME 4 75 long nWidth = pWindow-GetOutputSize().Width() - 2*FRAME; 76 long nHeight = pWindow-GetOutputSize().Height() - 2*FRAME; 77 if(

[SOLVED] Re: About SwSortedObjs

2014-03-22 Thread julien2412
Thank you Miklos for the explanation. Julien -- View this message in context: http://nabble.documentfoundation.org/About-SwSortedObjs-tp4102571p4102615.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list

Trying to understand a part of autoform.cxx (sc module)

2014-03-22 Thread julien2412
Hello, I noticed this in http://opengrok.libreoffice.org/xref/core/sc/source/core/tool/autoform.cxx#640 649 // do not insert empty CJK font 650 const SvxFontItem rCJKFont = rField.GetCJKFont(); 651 if (!rCJKFont.GetStyleName().isEmpty()) 652 {

About SwSortedObjs

2014-03-21 Thread julien2412
Hello, Taking a look again at fdo#42371 (see https://bugs.freedesktop.org/show_bug.cgi?id=42371), I wonder if SwSortedObjs could be implemented with a set instead of the vector. The goal would be to sort automatically the container and insert/remove more easily+quickly. Of course, the pb is

Re: Connection to SharePoint and/or Microsoft OneDrive GSOC 2014 Project

2014-03-16 Thread julien2412
Hi, About gsoc: - https://wiki.documentfoundation.org/Development/GSoC - https://wiki.documentfoundation.org/Development/GSoC/Ideas About Dev: - https://wiki.documentfoundation.org/Development Julien -- View this message in context:

Re: Question about version

2014-03-02 Thread julien2412
Hi, Here's the url about 4.2 release plan: https://wiki.documentfoundation.org/ReleasePlan#4.2_release Julien -- View this message in context: http://nabble.documentfoundation.org/Question-about-version-tp4099715p4099716.html Sent from the Dev mailing list archive at Nabble.com.

Re: Fix for a crash test?

2014-02-25 Thread julien2412
I submitted a patch here: https://gerrit.libreoffice.org/#/c/8307/ The goal was just to fix the crash + use a by default value for SvxULSpaceItem + fix a wrong copy paste For the rest, I must say I don't know how it should be fixed. Julien -- View this message in context:

About nowiki in mediawiki export xslt

2014-02-22 Thread julien2412
Hello, Following some bugs like, https://bugs.freedesktop.org/show_bug.cgi?id=74875, https://bugs.freedesktop.org/show_bug.cgi?id=75308 I just wonder if it could be more practical to throw away nowiki and replace characters used by mediawiki by ascii code (eg: * by #42;) in the xsl (see

Fix for a crash test?

2014-02-22 Thread julien2412
Hello, On pc Debian x86-64 with master sources updated yesterday, I reproduced the crash fdo51430-1.doc. The bt shows a failing assert because of the line 2423 of this block: 2415 else 2416 { 2417 //What I do here, is that I examine the attributes, and if

Re: No effect after changing source code

2014-02-02 Thread julien2412
Hi Harsh, It could be interesting you submit a patch by following these guidelines https://wiki.documentfoundation.org/Development/Patch_Handling_Guidelines or attach your patch here. Julien -- View this message in context:

Re: Cppcheck reports

2014-02-01 Thread julien2412
Just for information (I don't remember having done it already), I put cppcheck html reports here: http://dev-builds.libreoffice.org/cppcheck_reports/master/ I'm trying to update them from time to time (about once every 2 weeks or once per month when quite busy). Now I could update them more

Cppcheck redundantAssignment gridcell.cxx (svx module)

2014-02-01 Thread julien2412
Hello, Cppcheck reported this: svx/source/fmcomp/gridcell.cxx 2150redundantAssignment style Variable 'sValue' is reassigned a value before the old one has been used. if ( !_rxField-wasNull() ) { _rField.SetValue( fValue );

Cppcheck Same expression on both sides of '|' in PresenterPaneBorderManager.cxx (sdext)

2014-01-31 Thread julien2412
Hello, Cppcheck reported this: sdext/source/presenter/PresenterPaneBorderManager.cxx 171 duplicateExpression style Same expression on both sides of '|'. switch (nCode) { case mnOutside | mnOutside:--- Same expression on both sides of '|'. case mnOutside | mnLeft:

Re: OpenGL on Linux

2014-01-11 Thread julien2412
Hello Markus, With pc Debian testing x86-64 updated today I attached the file. Debian_3.12-1-amd64_glxinfo.txt http://nabble.documentfoundation.org/file/n4091753/Debian_3.12-1-amd64_glxinfo.txt Julien -- View this message in context:

ucb/source/ucp/webdav/SerfPropFindReqProcImpl.cxx seems unused

2014-01-04 Thread julien2412
Hello, Cppcheck reported this: ucb/source/ucp/webdav/SerfPropFindReqProcImpl.cxx 123 syntaxError error Invalid number of character (() when these macros are defined: ''. Indeed we have: 123 aBodyText = prop + aBodyText + /prop ); See

cppcheck: Duplicate branch if/else in op_statistical.cxx (sc/../opencl)

2013-12-14 Thread julien2412
Hello, Cppcheck reported this: [sc/source/core/opencl/op_statistical.cxx:5103] - [sc/source/core/opencl/op_statistical.cxx:5099]: (style) Found duplicate branches for 'if' and 'else' Indeed, we have: 5095 if (!pCurDVR-IsStartFixed() pCurDVR-IsEndFixed()) 5096 {

cppcheck: Same expression in chartexport.cxx (oox module)

2013-12-13 Thread julien2412
Hello, Cppcheck reported this: [oox/source/export/chartexport.cxx:1822] - [oox/source/export/chartexport.cxx:1822]: (style) Same expression on both sides of '=='. Indeed we have: 1822 if (aValues[i] == aValues[i]) 1823 pFS-write( aValues[i] ); see

cppcheck: Same expression in edtwin.cxx (sw module)

2013-12-13 Thread julien2412
Hello, Cppcheck reported this: [sw/source/ui/docvw/edtwin.cxx:3322] - [sw/source/ui/docvw/edtwin.cxx:3322]: (style) Same expression on both sides of '' Indeed we have: 3319 // if the cursor position was corrected or if a Fly 3320 // was

LO, scan coverity 708945 (non virtual destructor in parent class)

2013-12-07 Thread julien2412
Hi, I took a look to https://scan5.coverity.com:8443/reports.htm#v22002/p10276/fileInstanceId=47958646defectInstanceId=14481124mergedDefectId=708945 32class SbxVarEntry : public SbxVariableRef { 33public: 34OUString* pAlias; 35SbxVarEntry() : SbxVariableRef(), pAlias( NULL ) {} CID

Re: LO, scan coverity 708945 (non virtual destructor in parent class)

2013-12-07 Thread julien2412
Similarly, there's CID#708952 (see https://scan5.coverity.com:8443/reports.htm#v22002/p10276/fileInstanceId=47973599defectInstanceId=14481123mergedDefectId=708952). Here, there's no consequence, since there's no specific destructor in SfxListUndoAction. But if there's one in the future, it won't

Connection refused ooo.itc.hu

2013-11-30 Thread julien2412
Hello, Perhaps an already known issue but ooo.itc.hu is unreachable. I'm trying to build 4.2 sources and here's what I got (since several days): cd /home/julien/compile-libreoffice/libo_4_2/src/tmp wget --progress=dot:mega -Q 0 -P . -l 0 -nd -nH -N

Wizard use in Calc changes format

2013-11-30 Thread julien2412
Hello, On pc Debian x86-64 with master sources updated today, I noticed that if I use wizard (with any function) on Calc for a cell, the format of cell is: - font Times New Roman - size 6.8 (instead of Arial/10) If I directly put the formula without using wizard, no problem. Before filling a

[SOLVED] Re: About assignment operators cppcheck warning

2013-11-04 Thread julien2412
Thank you for your feedback Stephan, I'll try to find some time to update all the occurences in the next days. Julien -- View this message in context: http://nabble.documentfoundation.org/About-assignment-operators-cppcheck-warning-tp4081208p4081366.html Sent from the Dev mailing list archive

About assignment operators cppcheck warning

2013-11-03 Thread julien2412
Hello, Cppcheck reported some cases like this: const Player operator=( const Player other );--- 'Player::operator=' should return 'Player '. see http://dev-builds.libreoffice.org/cppcheck_reports/master/3.html#line-36 Here is the explanation about this choice from cppcheck guys:

HttpClient - HttpComponents

2013-10-26 Thread julien2412
Hello, Seeing red TB + lots of messages about deprecated parts in Apache httpclient, I've taken a look to Apache website here: http://hc.apache.org/httpclient-3.x/ and read this: The Commons HttpClient project is now end of life, and is no longer being developed. It has been replaced by the

<    1   2   3   4   5   6   7   8   9   10   >