About red TB, I just noticed /apache-commons (since now
apache-commons is in external) and it builds ok.
--
View this message in context:
http://nabble.documentfoundation.org/HttpClient-HttpComponents-tp4079943p4079976.html
Sent from the Dev mailing list archive at Nabble.com.
_
Hello,
Seeing red TB + lots of messages about deprecated parts in Apache
httpclient, I've taken a look to Apache website here:
http://hc.apache.org/httpclient-3.x/
and read this:
" The Commons HttpClient project is now end of life, and is no longer being
developed. It has been replaced by the Apac
Thank you Rodolfo for having noticed the lack of a "break" in the first part.
Don't hesitate to answer on forum+ (in addition with private email) next
time :-)
Anyway, any opinion about the patch?
Julien
--
View this message in context:
http://nabble.documentfoundation.org/About-bRdFlag-in-Sg
Hello,
Cppcheck reported this:
468 variableScope style The scope of the variable 'bRdFlag' can be
reduced.
Indeed: (see
http://opengrok.libreoffice.org/xref/core/vcl/source/filter/sgfbram.cxx#460)
462 bool SgfVectFilter(SvStream& rInp, GDIMetaFile& rMtf)
463 {
464 sal_uLo
Already in dev-list Michael and about Igalia/Suse person, no problem of
course :-)
BTW, Stephan improved what I did with this commit:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=9c5a34edeee63c4d512bb47d116313469bba960d
Julien
--
View this message in context:
http://nabble.documen
For the moment, i workaround this with pragram diagnostic ignored (see
http://cgit.freedesktop.org/libreoffice/core/commit/?id=d73acee01885fae5465fa9c7c1d88be683d60e98)
Julien
--
View this message in context:
http://nabble.documentfoundation.org/atk-focus-tracker-notify-deprecated-tp4077259p40
Hello,
On pc Debian x86-64 with master sources updated today, I got this:
/home/julien/compile-libreoffice/libo/vcl/unx/gtk/a11y/atklistener.cxx: In
function ‘gint idle_defunc_state_change(AtkObject*)’:
/home/julien/compile-libreoffice/libo/vcl/unx/gtk/a11y/atklistener.cxx:81:13:
error: ‘void atk_
Hi Stephan,
I'm trying to build clang from svn trunk to give a try to MemorySanitizer.
So I followed, http://clang.llvm.org/get_started.html
but I don't know what to put in my autogen.input
Either I get this:
* WARNING : Cannot find Clang headers to build compiler plugins, plugins
disabled
or I ge
Hi,
If StartColor and EndColor have been reversed, perhaps it was the same for
qa part? So what about this patch?
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport.cxx
b/sw/qa/extras/ooxmlexport/ooxmlexport.cxx
index f771ef9..8fdb7fb 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport.cxx
+++ b/sw/q
Building with clang succeeded, it's the first time that I can build LO with
clang! :-)
Thank you!
However trying to launch LO with:
./instdir/unxlngx6/program/soffice
gives:
ERROR 4 forking process
A Google search about this message gives urls from OOo in 2008!
However I gave a try to strace and
Thank you Thomas and Jan for your feedback.
Jan Holesovsky-4 wrote
> ...
> If you run it like
>
> LANG=C soffice --backtrace
>
> then it applies only to the soffice itself, and won't persist.
> ...
> Not sure - sometimes we have language-specific problems too... Do you
> have an example where
Hello,
I thought about changing wiki page
https://wiki.documentfoundation.org/QA/BugReport/Debug_Information#GNU.2FLinux:_How_to_get_a_backtrace
to add LANG=C before getting backtrace and so replace:
run soffice --backtrace
by this:
LANG=C;run soffice --backtrace
The goal is to have all messages
Thank you for the hints both of you.
I added these lines in my autogen.input:
CC=/usr/lib/llvm-3.2/bin/clang
CXX=/usr/lib/llvm-3.2/bin/clang++
CLANGBUILD=/usr/lib/llvm-3.2
CLANGDIR=/usr/lib/llvm-3.2
+ I created symlink for clang and clang++ since they're present in /usr/bin
With master sources u
Hello,
On pc Debian x86-64 testing updated today, I tried to build with clang.
But I got this warning after autogen.sh
Cannot find Clang headers to build compiler plugins, plugins disabled
Checking in configure.ac, I found this:
5625 CPPFLAGS="$CPPFLAGS -I$CLANGDIR/include
-I$CLANGDIR/
Hello,
About commit 30e72a9a36750b7326803fa8fa1b8d40648e7e89 and, in particular,
to:
- sal_Int32 nWindowWidth = ::std::max( nMinWidth, nBrowserWidth );
- nWindowWidth = ::std::min( nMaxWidth, nBrowserWidth );
+ sal_Int32 nWindowWidth = ::std::min( nMaxWidth, nBrowserWidth );
Matteo Casalin thoug
Hello,
Cppcheck reported this:
sc/source/core/tool/interpr7.cxx
94 duplicateBranch style Found duplicate branches for 'if' and 'else'.
87 if(pNodeSet->nodeTab[0]->type ==
XML_NAMESPACE_DECL)
88 {
89
About devs and bugs, perhaps it could be interesting to indicate in
https://wiki.documentfoundation.org/FindTheExpert if we want to be warned or
not about every bug (concerning module associated to the dev)? (or perhaps
ping only for important bugs)
Julien
--
View this message in context:
http
Hi,
I noticed some weird things in SwTable::CheckConsistency(), eg:
2102 std::list< RowSpanCheck > aRowSpanCells;
2103 std::list< RowSpanCheck >::iterator aIter = aRowSpanCells.end();
then I see ++aIter several times some lines later.
How can it work since:
aRowSpanCells isn't initi
Just to say that I removed "writeDBLoaderInfo" in:
dbaccess/source/ui/browser/dbloader.cxx
dbaccess/source/ui/browser/dbloader2.cxx
and dbaccess/source/ui/misc/uiservices.cxx
(See
http://cgit.freedesktop.org/libreoffice/core/commit/?id=fd636fe7222bf4193245be2e7bdf179b534171df)
Julien
--
View t
Hi Pedro,
I've just read about this comment:
https://bugs.freedesktop.org/show_bug.cgi?id=67556#c2
In brief, 4.1 will be proposed via update checking when 4.1.3 or 4.1.4 will
be released (see release plan here:
https://wiki.documentfoundation.org/ReleasePlan#4.1_release)
Julien
--
View this me
Lionel Elie Mamane wrote
> ...
> On the gripping hand, I can't find where the "//Loader" key is used
> afterwards either, so maybe my search-fu simply failed me. Or maybe
> the whole function is pointless. As an added bonus remark, it seems
> weird (but maybe innocuous) that it goes to extra pains
Hello,
cppcheck reported this:
dbaccess/source/ui/browser/dbloader.cxx
167 redundantAssignment style Variable 'xNewKey' is reassigned a value
before the old one has been used
Here's the function:
153 extern "C" void SAL_CALL writeDBLoaderInfo(void* pRegistryKey)
154 {
155
Jan Holesovsky wrote
> ...
> If I am not mistaken, unordered_map is a _Hashtable, with end() defined
> as const_iterator(nullptr), so it is constant, and your change was
> actually fine. Then again, I am no C++ expert, so probably better to be
> safe, and just check against m_aChildren.end() ;-) -
Hello,
I'm taking a look to the use of erase on iterators.
I found this example:
289 void OHierarchyElement_Impl::RemoveElement( const ::rtl::Reference<
OHierarchyElement_Impl >& aRef )
290 {
291 {
292 ::osl::MutexGuard aGuard( m_aMutex );
293 OHierarchyElem
Just for the record, Lionel wrote a very useful quick tutorial, see
https://wiki.documentfoundation.org/QA/FAQ#How_do_I_check_whether_a_given_.28e.g._daily.29_build_contains_a_specific_commit.3F
It may be a good replacement to a file giving the list, so put this thread
to SOLVED.
Thank you again Li
Jan Holesovsky wrote
> ...
>> I thought perhaps it could be interesting to have a file in addition to
>> build info (or perhaps inside it?) which gives the list of commits
>> retrieved since the previous build.
>> I read too https://bugs.freedesktop.org/show_bug.cgi?id=65653#c30 which
>> indicate
Hello,
I read this https://bugs.freedesktop.org/show_bug.cgi?id=65653#c31, I'll
quote:
"It seems a little strange that ordinary users, such as myself, who raise a
bug report and are keen to help reasonably early testing, can't find out for
themselves whether a daily release has a fix or not."
I th
Hello,
Cppcheck reported this:
988 sal_Int32 edt1Id = edt1;
989
990 // under W2k the there is a combobox instead
991 // of an edit field for the file name edit field
992 // the control id of this box is cmb13 and not
993 // edt1 as
Hello,
Cppcheck reported these:
[source/filter/xml/dbloader2.cxx:626] ->
[source/filter/xml/dbloader2.cxx:629]: (performance) Variable 'xNewKey' is
reassigned a value before the old one has been used.
[source/ui/browser/dbloader.cxx:166] ->
[source/ui/browser/dbloader.cxx:170]: (performance) Varia
Hello,
Cppcheck reported this:
[source/core/dataaccess/documentdefinition.cxx:211] ->
[source/core/dataaccess/documentdefinition.cxx:212]: (performance,
inconclusive) Variable 'm_bInChangingState' is reassigned a value before the
old one has been used if variable is no semaphore variable
Indeed:
I just added --with-system-boost=no
Sorry for the noise
Julien
--
View this message in context:
http://nabble.documentfoundation.org/clang-scan-build-error-boost-date-time-tp4059087p4059102.html
Sent from the Dev mailing list archive at Nabble.com.
_
Hello,
I wanted to give a try to Clang code
https://wiki.documentfoundation.org/Development/Clang_Code_Analysis but now
am stuck to the step "Run ./configure.sh" because of this error:
configure: error: Could not link against boost_date_time !
I noticed that when I installed libmdds-dev, it unins
Hi,
I agree with Joren. I know that the earlier you solve a bug (in master
instead of in 3.6 versions for example), the better/more simple it is (no
need to cherry-pick, etc.). But, for some people the highest priority may
be:
- unconfirmed regressions (because it's very frustrating to have been
a
Ok I solved this by running a "ccache -C".
Sorry for the noise.
Julien
--
View this message in context:
http://nabble.documentfoundation.org/Build-fails-with-File-truncated-error-tp4057540p4057543.html
Sent from the Dev mailing list archive at Nabble.com.
__
Hello,
Since yesterday, I've got this:
config.status: creating tools/gensprep/gensprep.8
/usr/bin/make[3]: Making `all' in `icuinfo'
(deps)icuinfo.cpp
ccache... icuinfo.cpp
/usr/bin/make[3]: Making `all' in `genccode'
(deps)genccode.c
ccache... genccod
Hi Oscar,
Here is the dev mailing list where language is English. About Android,
there's an experimental version of LibreOffice.
You can take a look to daily master builds here:
http://dev-builds.libreoffice.org/daily/master/
If you want to participate to LibreOffice development, you should begin
Hello,
I've just heard about "lock-free programming and leafed through
http://preshing.com/20120612/an-introduction-to-lock-free-programming +
http://en.wikipedia.org/wiki/Non-blocking_algorithm
I suppose the concept has its limits (as any concept) but it may bring
interesting rules to follow
I'm
Stephan Bergmann-2 wrote
> ...
> This leaves us with completely unmaintainable ("where do I need to lock
> SolarMutex?"---"nobody knows for sure") and broken (cf.
> SolarMutexReleaser) code.
> ...
Should/can "SolarMutex" be removed?
If yes, I suppose it's not simple and perhaps there's a lot of
Indeed, I hadn't noticed it was a virtual function and had just read the
function in the same file svxrectctaccessiblecontext.cxx which returned 0.
I don't know if cppcheck could take this into account.
Anyway, thank you Stephan for your respond.
Julien
--
View this message in context:
http:/
Philipp Riemer wrote
> ...
> Can someone give me a pointer to the related reporting script/ whatever
> reports the number of errors, so that I can try removing these false
> positive cases?
I don't know but in full log, I noticed this:
Reading autogen.lastrun. Please rename it to autogen.input to
Hello,
cppcheck reported this:
Indeed we have in this file that:
610 void SvxRectCtlAccessibleContext::checkChildIndex( long nIndex )
throw( lang::IndexOutOfBoundsException )
611 {
612 if( nIndex < 0 || nIndex >= getAccessibleChildCount() )
613 throw lang::IndexOutOfB
A bunch of similar warnings here:
These always have part like this:
491 ref:
492 aTmp.eType = SbxDataType( p->eType & 0x0FFF );
493 p = &aTmp; goto start;
whereas the function is like this:
sal_Int64 ImpGetInt64( const SbxValues* p )
This on
Hello,
Cppcheck reported this an useless assignment in
sdext/source/pdfimport/wrapper/wrapper.cxx, line 475
462 int Parser::parseFontCheckForString( const sal_Unicode* pCopy, const
char* s, sal_Int32& nLen,
463 FontAttributes& aResult, bool bItalic, bool bBold)
464 {
465
Hello,
Cppcheck reported exception thrown in destructor in
shell/source/sessioninstall/SyncDbusSessionHelper.cxx, line 39
28 class GErrorWrapper
29 {
30 GError* m_pError;
31 public:
32 GErrorWrapper(GError* pError) : m_pError(pError) {}
Hello Alex,
I've made some changes on this lately and noticed a typo in
scripting/Package_ScriptsPython.mk
The third line shows "Scripting" instead of "scripting".
Badfully i don't have access to my laptop to change this.
Could Anyone do it?
Julien
--
View this message in context:
http://nabb
Hello Sameer,
Could you submit a bug here: https://www.libreoffice.org/get-help/bug/ ?
Here is the dev mailing list, so it's about patches, building issues, etc.
Julien
--
View this message in context:
http://nabble.documentfoundation.org/Error-while-running-a-Daily-Build-tp4050136p4050154.
https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=fa0faf3f04882b55a8ef2524f66b00371857
(add missing semi colons) should fix this.
Sorry for the noise.
Julien
--
View this message in context:
http://nabble.documentfoundation.org/Help-needed-about-failing-build-same-pb-as-Clan
Hello,
Clang tinderbox fails with :
ERROR: Can´t copy file: ->
/home/tinderbox/master-build/solver/unxlngi6/installation/opt/ No such file
or directory at
/home/tinderbox/master-build/solenv/bin/modules/installer/worker.pm line
376.
The problem comes from or is triggered by this commit
http://cg
After having retrieved last fixes, I get this now:
/home/julien/compile-libreoffice/libo/workdir/unxlngx6/CxxObject/sc/source/filter/orcus/xmlcontext.o:
In function `populateTree':
/home/julien/compile-libreoffice/libo/sc/source/filter/orcus/xmlcontext.cxx:94:
undefined reference to
`orcus::xml_str
On pc Debian x86-64 with master sources updated today (commit
42e57f463ed46c64560e6b27a75cc1e9ad519743), I've got the same problem as
Arnaud.
I did a "make clean && make dev-install".
Here's my autogen.input:
--with-system-odbc
--enable-ext-barcode
--enable-ext-diagram
--enable-ext-google-docs
--e
Hello,
Windows Tinderbox shows this:
283 Incremental build, no cleaning
284
/cygdrive/c/cygwin/home/tinderbox/master-build/pyuno/Library_pyuno.mk:27:
warning: overriding recipe for target
`C:/cygwin/home/tinderbox/master-build/workdir/wntmsci13.pro/LinkTarget/Library/pyuno.pyd´
Lionel Elie Mamane wrote
>> ...
>>1778 for(sal_Int32 nPos = 0;aIter != aEnd;++aIter,++nPos)
>>...
> Which variable is not incremented? I don't see what is not
> incremented; both aIter and nPos are incremented, by the statement
> "++aIter,++nPos"
> ...
How could I miss it ?!! Sometimes I
Hello,
Cppcheck reported this:
sfx2/source/doc/docfile.cxx
2626redundantAssignment style Variable 'nEncoding' is reassigned a
value
before the old one has been used.
2610 sal_uInt32 SfxMedium::CreatePasswordToModifyHash( const
::rtl::OUString& aPasswd, sal_Bool bWriter )
2611 {
Hello,
There are a lot of iterators stuff in
core/basegfx/source/polygon/b3dpolygon.cxx, I tried to fix 'prefix ++/--
operators for non-primitive types' errors (provided by cppcheck) but I saw
several iterator things I'm not sure, eg:
274 BColorArray(const BColorArray& rOriginal, sal_uInt3
Hi Regina,
I knew I was right to submit this patch for review and not push it directly
:-)
In fact, I just picked up a coverity report and took a look to Opengrok (see
http://opengrok.libreoffice.org/search?q=getPointFromCartesian&project=core&defs=&refs=&path=&hist=).
Ovbiously, I know nothing ab
Idem with coverity#441021
http://cgit.freedesktop.org/libreoffice/core/commit/?id=761af309529d877e1b365fdcdb2fee4bb9ee377f
--
View this message in context:
http://nabble.documentfoundation.org/About-coverity-441020-templdlg-cxx-in-sfx2-tp4047124p4047129.html
Sent from the Dev mailing list arch
Hello,
coverity scan reported this:
CID 441020 (#1 of 1): Dereference after null check (FORWARD_NULL)6.
var_deref_model: Passing null pointer "pOldStyleSheetPool" to function
"SfxListener::StartListening(SfxBroadcaster &, sal_Bool)", which
dereferences it.
Indeed:
2650if ( pOldStyleShee
Hello,
I noticed that a variable wasn't incremented in this loop:
1772 void OResultSet::clearInsertRow()
1773 {
...
1778 for(sal_Int32 nPos = 0;aIter != aEnd;++aIter,++nPos)
1779 {
1780 ORowSetValueDecoratorRef& rValue = (*aIter);
1781 if ( rValue->isBou
Thank you Stephan for your feedback.
If I remove these cases in the switch, I've got this:
/home/julien/compile-libreoffice/libo/registry/source/keyimpl.cxx: In member
function ‘RegError ORegKey::getValue(const rtl::OUString&, RegValue) const’:
/home/julien/compile-libreoffice/libo/registry/source
Hello,
Scan coverity reported this:
dead_error_begin: Execution cannot reach this statement "case 5:"
dead_error_begin: Execution cannot reach this statement "case 6:"
dead_error_begin: Execution cannot reach this statement "case 7:"
See
http://opengrok.libreoffice.org/xref/core/registry/source/k
grr, forgot to mark this as "solved".
--
View this message in context:
http://nabble.documentfoundation.org/cppcheck-Variables-reassigned-before-the-old-one-has-been-used-vcl-kde4-part-tp4044235p4044604.html
Sent from the Dev mailing list archive at Nabble.com.
_
All of the sudden my 2 neurons connected :-)
I pushed the patch on master.
See
http://cgit.freedesktop.org/libreoffice/core/commit/?id=91c8b357ee2a27e50da0e99386e53d351e55cfda
Thank you Lubos!
Julien
--
View this message in context:
http://nabble.documentfoundation.org/cppcheck-Variables-rea
Hi Lubos,
But which ones are the useless?
QPalette::WindowText and QPalette::Window
or
QPalette::ButtonText and QPalette::Button
Julien
--
View this message in context:
http://nabble.documentfoundation.org/cppcheck-Variables-reassigned-before-the-old-one-has-been-used-vcl-kde4-part-tp4044235p
Hello,
Scan coverity detected this:
CID 988424 (#1 of 1): Logically dead code (DEADCODE)dead_error_line:
Execution cannot reach this expression "nExtBuInd + nExtParaNibble <
aStyleTextProp9->size()" inside statement "if (nExtParaNibble && nExtB...".
Indeed, we have these lines:
5026 if (
Hello,
Cppcheck reported this:
[KDESalFrame.cxx:301] -> [KDESalFrame.cxx:304]: (performance) Variable
'aMenuFore' is reassigned a value before the old one has been used.
[KDESalFrame.cxx:302] -> [KDESalFrame.cxx:305]: (performance) Variable
'aMenuBack' is reassigned a value before the old one has
Hello,
Scan coverity detected this:
22. pass_freed_arg: Passing freed pointer "pAnchoredObj" as an argument to
function "SwSortedObjs::Remove(SwAnchoredObject &)".
This problem appears twice in the file:
576 SwAnchoredObject* pAnchoredObj =
(*pFrm->GetDrawObjs())[0];
577
Caolán McNamara wrote
> Pushed the agreed fix (I agree too) and updated coverity.
Thank you Caolán! One additional fix on LO and one coverity scan report less
to deal :-)
Julien
--
View this message in context:
http://nabble.documentfoundation.org/About-coverity-705746-pormulti-cxx-from-sw-mo
Oups, I was wrong , if they're not exclusive, "new" line is required for each
block
Sorry Noël and Riccardo for the noise. Can you push a patch about this and
update coverity?
If not, I'll do it but only during week-end because I won't have much time.
Thank you for having very patiently answered t
Noel Grandin wrote
> I would guess that someone meant to move line 742 inside the first "if"
> statement, but only did half the job.
Hello Noël,
Perhaps I'm too sleepy this morning but I don't see the interest to
duplicate the "new" part. Any hint?
Julien
--
View this message in context:
h
Hello,
Scan coverity detected this:
27. overwrite_var: Overwriting "pMarg" in "pMarg = new SwMarginPortion(0)"
leaks the storage that "pMarg" points to
(http://opengrok.libreoffice.org/xref/core/sw/source/core/text/pormulti.cxx#738)
738 if( nLeft || nRight )
739 {
740
Thorsten, Caolán,
Following your respective feedback about this, thank you for this, I thought
about "gerrit submitting" on master as it is since Caolán seems quite
confident and it may allow an easier review.
In general, in bug triaging, cppcheck and very recently scan coverity, my
purpose is to
Hello,
Scan coverity reported this:
leaked_storage: Variable "pText1" going out of scope leaks the storage it
points to.
See
http://opengrok.libreoffice.org/xref/core/svx/source/svdraw/svdundo.cxx#1137
1137 void SdrUndoObjSetText::Redo()
1138 {
1139 // copy text for Undo, because the
The following discussion is interesting but shows that it's not a quick
and/or easy fix for casual contributor like me. So I let the experts keep on
about this and determine if there's something to change or not.
Thank you for your feedback about this Michael, Tor and Matúš
Julien
--
View this
Hello,
Scan coverity detected this:
leaked_storage: Variable "lib" going out of scope leaks the storage it
points to. line 236
(see
http://opengrok.libreoffice.org/xref/core/javaunohelper/source/javaunohelper.cxx#236)
I just thought adding
osl_unloadModule(lib) just before line 235, so last line
Hello,
Scan coverity detected this:
Resource leak in object (CTOR_DTOR_LEAK)1. alloc_fn: Calling allocation
function "osl_createCondition()". [show details]
(see
http://opengrok.libreoffice.org/xref/core/filter/source/xsltfilter/XSLTFilter.cxx#164)
osl_createCondition in unx part calls a malloc f
Lionel Elie Mamane wrote
> Thanks Stephan, good catch!
>
> Short version: this was, and should remain, an equality test and not a
> "string begins with, but can continue with anything" test.
> ...
Lionel, could this point explain these logs I had put in
https://bugs.freedesktop.org/show_bug.cgi?i
Hello Ivan,
Thank you for the patch but license is not exactly this, it's dual license
MPL/LGPLv3+
Could you send a post to dev mailing list by taking example to
http://nabble.documentfoundation.org/License-statement-td4042388.html?
Julien
--
View this message in context:
http://nabble.docume
Hello,
Scan coverity allows to fix a lot of bugs but all of them are on Master
sources only. Just being curious, is a "big cherry-pick" planned to bring
these on 4.0 branch (since most of them contain "coverity" in commit
message, they can be detected easily )?
Julien
--
View this message in c
Caolán McNamara wrote
> On Tue, 2013-02-12 at 05:58 -0800, julien2412 [via Document Foundation
> Mail Archive] wrote:
>> Caolán McNamara wrote
>> So, unless Rafael has other plans, it looks to me that you can
>> remove the bContainsDate lines,
Hello Rainer,
About @6, "Win-x86_6" might be ok once current building done thanks to
Andras' commit
(https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=b4e8f99a253ee20cba0718d042ca17cca2e8dcb5)
About @7, I don't know.
Julien
--
View this message in context:
http://nabble.documen
Hola adrivero,
Debes preguntar in inglés porque es un inglés dev mailing list.
Gracias.
(translation: you must ask in English because it's an English dev mailing
list)
--
View this message in context:
http://nabble.documentfoundation.org/hola-tp4037870p4039915.html
Sent from the Dev mailing
Hello,
I don't know if you commited your changes in local but you should update
your local repo. I pushed some fixes about these typos.
(see https://gerrit.libreoffice.org/gitweb?p=core.git;a=summary)
Julien
--
View this message in context:
http://nabble.documentfoundation.org/Question-Regard
Thank you Caolán for your feedback.
I pushed a fix on master (see
http://cgit.freedesktop.org/libreoffice/core/commit/?id=93b8b04ae0125a85d92ad0c414969c12e49b301e).
But I didn't remove completely these variables since they're used.
--
View this message in context:
http://nabble.documentfoundat
Norbert Thiebaud wrote
> On Wed, Feb 20, 2013 at 7:54 AM, julien2412 <
> serval2412@
> > wrote:
>>
>> Yes I meant it, why? Is it wrong?
>> if "pReceiveBuffer" is initialized with 0 for the (sc_nCSASeqLength + 1)
>> elements thanks to = {0} init
Hello,
Since all compilers aren't ready for C++11, would it be relevant to include
by default "-std=c++98" in CXXFLAGS ?
The goal is, for beginners like me, to avoid submitting things like
https://gerrit.libreoffice.org/2302 :-)
Julien
--
View this message in context:
http://nabble.documentfo
Lubos Lunak wrote
>> Lubos Lunak wrote
> Sorry, I did not realize that = { 0 } actually clears the rest of the
> array.
> And I do not quite understand why clearing an entire array is supposed to
> be
> a good way to initialize it when just setting the last one to 0 is enough.
> ...
>> Why "pRec
Lubos Lunak wrote
> On Tuesday 19 of February 2013, Julien Nabet wrote:
>> diff --git a/desktop/source/app/officeipcthread.cxx
>> b/desktop/source/app/officeipcthread.cxx index 8db7946..445ccb4 100644
>> --- a/desktop/source/app/officeipcthread.cxx
>> +++ b/desktop/source/app/officeipcthread.cxx
>>
Hello,
Cppcheck reported this:
vcl/coretext/salcoretextlayout.cxx
569 unreadVariable style Variable 'is_vertical_run' is assigned a value
that
is never used.
565 bool is_vertical_run = false;
566 CFDictionaryRef aDict = CTRunGetAttributes( r
Hello,
Cppcheck reported this:
cppuhelper/source/servicemanager.cxx
1578eraseDereferenceerror Iterator 'i' used after element has
been erased.
(+ this but I don't know if we can do something:
1216unusedScopedObject error Instance of 'Parser' object is destroyed
immediate
Hello,
Cppcheck reported this:
sc/source/ui/view/tabview2.cxx
970 unreadVariable style Variable 'bMark' is assigned a value that is
never
used.951 void ScTabView::PaintBlock( bool bReset )
952 {
953 ScMarkData& rMark = aViewData.GetMarkData();
954 SCTAB nTab = aView
I pushed a patch to remove all these macros, see
http://cgit.freedesktop.org/libreoffice/core/commit/?id=2b5fedb54a7f9569b817c24c1a9b16c17c09cfd9.
Julien
--
View this message in context:
http://nabble.documentfoundation.org/About-macro-VALIDTAB-sc-module-tp4036946p4037097.html
Sent from the De
Hello Jean-Noël,
About STRING_NOTFOUND, you can take a look to "getToken" function in
tools/source/string/tustring.cxx since this function is called line 388:
385 while ( nIndex != STRING_NOTFOUND )
386 {
387 xub_StrLen nPrevIndex = nIndex;
Hello,
Getting this with cppcheck:
sc/source/core/data/document.cxx
760 syntaxError error syntax error
Here are the lines:
755 bool ScDocument::RenameTab( SCTAB nTab, const rtl::OUString& rName,
bool /* bUpdateRef */,
756 bool bExternalDocument )
757 {
758 bo
Hello,
Cppcheck reported this:
drawinglayer/source/primitive2d/sceneprimitive2d.cxx
196 unreadVariable style Variable 'fViewSizeX' is assigned a value that
is
never used.
197 unreadVariable style Variable 'fViewSizeY' is assigned a value that
is
never used.193
Hi Marcos,
About code pointers, I can't help but here are some docs:
http://api.libreoffice.org/
+ this:
https://wiki.documentfoundation.org/Development#General_Programming_Guidelines
Julien
--
View this message in context:
http://nabble.documentfoundation.org/Help-with-fdo-60471-tp4036825p40
Hello,
Cppcheck reports this:
svtools/source/dialogs/filedlg2.cxx
558 unreadVariable style Variable 'nMaxWidth' is assigned a value that is
never used.
544 if( nMaxWidth > aSize.Width() )
545 {
546 Size aDlgSize = GetPathDialog()->GetOutputSizePixel();
547
Hello,
Cppcheck reported this:
sfx2/source/control/thumbnailview.cxx
293 unreadVariable style Variable 'nTotalItems' is assigned a value that
is
never used.
See
http://opengrok.libreoffice.org/xref/core/sfx2/source/control/thumbnailview.cxx#280
Searching in git history, I noticed the val
Caolán McNamara wrote
> On Sun, 2013-01-27 at 14:02 -0800, julien2412 wrote:
>>...
>> Should line 129 just be removed or bContainsDate should be used in some
>> way
>> or bContainsDate shouldn't be a new variable for each while loop?
>
> Hmm, not alone is bC
Hello,
Cppcheck reported this:
basic/source/comp/sbcomp.cxx
600 unassignedVariable style Variable 'TimeBuffer' is not assigned a
value.
Here are the lines:
600 char TimeBuffer[200];
601 #ifdef DBG_TRACE_PROFILING
602 if( bPrintTimeStamp )
603 {
604
Hello,
Cppcheck reported this:
sc/source/core/data/fillinfo.cxx
507 variableScope style The scope of the variable 'bEmbed' can be
reduced.
Here are the lines:
507 bool bEmbed = false;
508
509 if (bScenario)
501 - 600 of 1039 matches
Mail list logo
