Re: [Libreoffice] Export OLE objects as PDF / graphics
Hi, it seems that the RTL_CONSTASCII_USTRINGPARAM is (completly ? mostly ?) finished so I'm back to PDF Export * Misc issues + Formula objects + no PDF exported :-) In fact they do export as do other objects. But none of them exports when anchor is 'As Character'. Checking that... * Potentially pasting the objects as a GDI meta-file something we can easily do already for OLE objects gives a better result. + Hopefully we could do this more uniformly for all objects, and export formats: PDF, PNG, JPEG etc. + Indeed, if we could go directly from that GDI meta-file to an image (without the temporary draw) document life would be a lot better I think. + Thorsten any ideas on that path ? :-) Checking that too... Regards. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Enable build of ure and extension
Hi, thank you very much for checking them. Well, after a good night of sleep, I have just realized that since the change to the new build system my root directory is a real mess. For sure, I did not do it the right way and then focussed on the patches ready before the upgrade. Thanks for your patience. Regards. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Enable build of ure and extension
Hi, Still working on the 'RTL_CONSTASCII_USTRINGPARAM' task and I have some problems. I've some changes left in : 'clone/ure', 'clone/extension', 'clone/filters/binfilter/bf_sd', 'clone/filters/binfilter/bf_svx' and 'clone/filters/binfilter/bf_xmloff' The problem is that, build is disabled in those directories, and I can not test hand-made changes. (I've pushed some patches without compilation and one of them was bad, so no doubt compilation test is important for me). I don't find any '--with-*' or '--enable-*' that applies in 'configure'. Could someone give me an hint please. Thank you very much. Regards ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] (no subject)
Hi, @Wol thanks for your answer. I've already configured with '--enable-binfilter'. binfilter builds except some sub-dirs 'bf_sd', 'bf_svx' and 'bf_xmloff' (and some others) and I have changes ready in there but not tested. For 'extension', make simply answers 'Presenter Screen build disabled' and things like that. For 'ure' I have a 400k+ patch which concerns many sub-dirs and make does not see any change in those... Regards. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] SW build error
Hi, I get a build error in sw : with : 'sw/source/filter/rtf/rtffly.cxx' 1311 error: 'PictPropertyNameValuePairs' has not been declared PictPropertyNameValuePairs is only a typedef in ' libs-core/editeng/inc/editeng/svxrtf.hxx' It seems it due to the last commit in writer. Regards. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Export OLE objects as PDF / graphics
Selon Caolán McNamara caol...@redhat.com: It looks good to me anyway. Just need to handle more gracefully hitting cancel IMO and I reckon we could pretty much stuff it in as is. C. Hi, yes of course, checks must be added, it's just 'raw code'. Whatever,this function is expected in calc to. I'm coding it in calc for a test, it's the same. But, even if I've been reading a lot of code (thanks to the 'RTL_CONSTASCII_USTRINGPARAM' easy Hack) I've not still completely figured out how to (and where) share the code for both apps. Working on that. (The source code is a really big town, I've no map, and all that 'uno' stuff is also completely new to me) Regards. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Duplicate ids in 'writer/sw/inc/cmdid.h'
Selon Caolán McNamara caol...@redhat.com: Hmm, one of the + 129 is FN_NEW_PAGE_STYLE and appears (according to opengrok) unused the FN_PAGE_STYLE_SET_LR_MARGIN and FN_PAGE_STYLE_SET_UL_MARGIN i.e. one version of the + 130 and + 131 are only mentioned in basesh.cxx as false not implemented. So I reckon those three should go entirely to avoid the duplicate ids. Hi, yes, I checked that too. Do you think that can be left untouched ? Regards. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Export OLE objects as PDF / graphics
Hi, Following the hints of Michael Meeks in : 'https://bugs.freedesktop.org/show_bug.cgi?id=30944', here a first try in writer. It's 'raw code' : just wondering if it satisfies the required functionality. Regards. export_4.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Easy Hacks : RTL_CONSTASCII_USTRINGPARAM in libs-core 3
HI, here are some more in libs-core Regards. 10_libs-core.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Duplicate ids in 'writer/sw/inc/cmdid.h'
Hi, just wondering if someone knows why there are duplicate ids in 'writer/sw/inc/cmdid.h' (FN_FORMAT + 129) , (FN_FORMAT + 130), (FN_FORMAT + 131) at line 537. Regards. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Styles and Formatting
Selon Cedric Bosdonnat cedric.bosdonnat@free.fr: So Hierarchical as default would not be my choice. Default is more then enough. Hi, I must admit that even if I been using OpenOffice for nearly 10 years, I never use that dialog so I've maybe not made a good choice for my first jump in the source... I have to understand the exact expectations. So let's go : A) with a clean build (no patch) and a clean 'registry' (.libreoffice erased in home), I see : 1) I fire writer and open the dialog -- Automatic 2) I select, for example, Index Style, close and reopen the dialog -- Index Style 3) I close writer and open it again -- Index Style 4) I fire calc -- All styles 5) I close writer and open it again -- Index Style 6) I choose Custom styles in calc -- Custom styles 7) I open an other calc -- Custom styles B) with a patched build and a clean 'registry' I see : 1) I fire writer and open the dialog -- Automatic 2) I select, for example, Index Style, close and reopen the dialog -- Index Style 3) I close writer and open it again -- Index Style 4) I fire calc -- All styles 5) I close writer and open it again -- Index Style 6) I choose Custom styles in calc -- Custom styles 7) I open an other calc -- Custom styles All the same. 8) I choose Hierarchical in writer and close the dialog -- Hierarchical 9) I close the dialog in calc and open it -- All styles 10)I open the dialog in writer -- Hierarchical 11)I close writer and open it again -- Hierarchical 12)I close calc and open it again -- All styles 13)I close both and open calc -- All styles 14)I open writer -- Hierarchical 15)I choose Applied styles in calc -- Applied styles 16)I close calc and open it again -- Applied styles 17)I open an other calc -- Applied styles etc... My question : is the problem in 11) and 14) ? Regards. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Styles and Formatting
Hi, Do we want the Hierarchical view to be the default one for all apps? Should we enhance the filters values to make it configurable for the different apps? Well, in fact, there were some changes remaining from my previous attempts. Maybe something simpler is enough ? Regards templdlg_2.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Some hints about git please...
Selon Sebastian Spaeth sebast...@sspaeth.de: If you work in rawbuild and make from there, you can directly go into the directory, make changes, git add files that you have changed, git commit, and extract the patch with git format-patch HEAD^1. Hope that helps, I am sure there are even more efficient workflows. Sebastian Hi, thanks. I started a new build as in http://wiki.documentfoundation.org/Development/How_to_build; ~12 hours ago. Still 3-4 hours and it should be good. Regards. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Some hints about git please...
Hi, with http://wiki.documentfoundation.org/Development/How_to_build;, linux part, all is ok. Very complete howto. Thanks. Regards. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Easy Hacks : Use RTL_CONSTASCII_USTRINGPARAM macro 8
Hi, this may be the last for module 'writer'. Remains 'sw/source/ui/vba/vbacheckbox.cxx:78'. When I google I find : #define ECMA_FORMCHECKBOX_CHECKED checked in '/xmloff/inc/xmloff/ecmaflds.hxx' but don't find it in clone. So I let that one. Regards. createFromAscii_11.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Styles and Formatting
Hi, I have erased the line : m_aActionTbL.SetHelpId( HID_TEMPLDLG_TOOLBOX_LEFT ); in the patch file 2. A pastecopy error... Regards. templdlg_3.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] (no subject)
Hi, a little bit more... regards. createFromAscii_8.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Easy Hacks : Use RTL_CONSTASCII_USTRINGPARAM macro 6
Hi, some more in impress Regards. createFromAscii_9.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Re: [PATCH] Easy Hacks : Use RTL_CONSTASCII_USTRINGPARAM macro 4
Selon Caolán McNamara caol...@redhat.com: Mostly good, though createFromAscii_7.patch has... OUString::createFromAscii( GetWindowState( WINDOWSTATE_MASK_POS ).GetBuffer() ) ); that one can't be changed to use RTL_CONSTASCII_USTRINGPARAM because GetWindowState is a method rather than a string literal, so that one is best left alone. Dropped that part, but otherwise pushed. C. oops !!! Regards. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] EasyHack RTL_CONSTASCII_USTRINGPARAM 3
Hi, I'am not sure of my previous mail... Regards. createFromAscii_5.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] EasyHack RTL_CONSTASCII_USTRINGPARAM 3
Hi, Quote : I'am not sure of my previous mail. I sent it 3 hours ago but it did not appear (and it's in my 'sent-mail' directory) : maybe some problem with my ISP because of the end of DST this night... Regards. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Re: [PATCH] Easy Hacks : Use RTL_CONSTASCII_USTRINGPARAM macro
Selon Caolán McNamara caol...@redhat.com: You have two typos in there however, i.e. - com.sun.star.chart.BarDiagram + com.sun.star.chart.BarDiagra - com.sun.star.chart2.ScatterChartType + com.sun.star.chart2.ScatterChartTyp in those two cases the trailing letter of the original string got removed !, eek that was close ;-). So I fixed up those two and committed and pushed this change. Thanks. C. Ah yes, sorry. Can see it with compilation... I've got 2388 files with 'createFromAscii'. That's a lot. The wiki says that this macro is 'faster'. Does it mean at running time ? Regards. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Re: [PATCH] Easy Hacks : Use RTL_CONSTASCII_USTRINGPARAM macro
OK, thanks. Now, this only works when you can compute the length of the string at compile time, i.e. its a string literal, so OUString::createFromAscii(foo) can be trivially replaced, while OUString::createFromAscii(pSomething) should be left alone. C. Yes, of course, I was just outlining that files must be checked. And for example in 'writer/sw/source/ui/vba/vbalisthelper.cxx':85, you get msStyleName = rtl::OUString::createFromAscii( WORD_BULLET_GALLERY ); and at line 43 : static const char WORD_BULLET_GALLERY[] = WdBullet; That's ok too ? Regards. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Styles and Formatting
Hi, I've been working on the Styles and Formatting window does not remember hierarchical view bug. It seems I got it. I've noticed that, the window does not remember the Frame Styles but reverts to Paragraph Styles. Is that an another bug or a feature ? (The same in openoffice) Regards. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Export OLE objects as PDF / graphics
Hi, I'm studying the Export OLE objects as PDF / graphics feature and it reminds me of an other... When you import a picture in writer : you can't rotate it. It's a picture : style Graphics. When you import a picture in draw : you can't rotate it. If you copy it back in writer, it's a Drawing Object and then you can rotate it. I've heard many people complaining about that : open in draw and then copy to writer is a pain !. Any hint about that feature ? Regards. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Cppcheck
Hi, I've been running 'Cppcheck 1.44' on the whole source 27/10/10 10 GTM (I have a slow machine) : I join the raw output sorted by 'Error Type'. I run it too with '--enable=unusedFunctions' : I got 3195 matches... looks enormous. I'll check part of this output. Do I send the file ? I've been looking at the (so-called) Easy to solve bug : Styles and Formatting window does not remember hierarchical view. Well, the source is so huge... Regards.[/mnt/sdb6/libreoffice-build-3.2.99.2/clone/bootstrap/dmake/dbug/malloc/testmem.c:167]: (error) Buffer access out-of-bounds: one [/mnt/sdb6/libreoffice-build-3.2.99.2/clone/bootstrap/dmake/dbug/malloc/testmem.c:171]: (error) Buffer access out-of-bounds: one [/mnt/sdb6/libreoffice-build-3.2.99.2/clone/bootstrap/dmake/dbug/malloc/testmem.c:177]: (error) Buffer access out-of-bounds: one [/mnt/sdb6/libreoffice-build-3.2.99.2/clone/bootstrap/dmake/dbug/malloc/testmem.c:182]: (error) Buffer access out-of-bounds: one [/mnt/sdb6/libreoffice-build-3.2.99.2/clone/bootstrap/dmake/dbug/malloc/testmem.c:185]: (error) Buffer access out-of-bounds: one [/mnt/sdb6/libreoffice-build-3.2.99.2/clone/bootstrap/dmake/dbug/malloc/testmem.c:188]: (error) Buffer access out-of-bounds: one [/mnt/sdb6/libreoffice-build-3.2.99.2/clone/bootstrap/dmake/msdos/dirlib.c:202]: (error) Buffer access out-of-bounds: nd.dd_name [/mnt/sdb6/libreoffice-build-3.2.99.2/clone/bootstrap/dmake/msdos/dirlib.c:206]: (error) Buffer access out-of-bounds: nd.dd_name [/mnt/sdb6/libreoffice-build-3.2.99.2/clone/bootstrap/dmake/msdos/dirlib.c:209]: (error) Buffer access out-of-bounds: nd.dd_name [/mnt/sdb6/libreoffice-build-3.2.99.2/clone/libs-gui/rsc/source/rscpp/cpp6.c:817]: (error) Buffer access out-of-bounds: file.buffer [clone/bootstrap/dmake/unix/arlib.c:151]: (error) Resource leak: f [clone/bootstrap/dmake/unix/arlib.c:183]: (error) Resource leak: f [clone/bootstrap/soltools/adjustvisibility/adjustvisibility.cxx:249]: (error) Resource leak: fd [clone/sdk/odk/source/unoapploader/win/unoapploader.c:413]: (error) Resource leak: ferr [clone/ure/sal/rtl/source/alloc.c:115]: (error) Resource leak: fd [clone/calc/sc/source/ui/attrdlg/scdlgfact.cxx:1628]: (error) Null pointer dereference [clone/filters/binfilter/bf_svtools/source/items1/svt_itemset.cxx:155]: (error) Null pointer dereference [clone/filters/binfilter/bf_svx/source/editeng/svx_editobj.cxx:285]: (error) Null pointer dereference [clone/filters/binfilter/bf_svx/source/svdraw/svx_svdobj.cxx:2365]: (error) Null pointer dereference [clone/filters/binfilter/bf_sw/source/core/doc/sw_SwStyleNameMapper.cxx:482]: (error) Null pointer dereference [clone/filters/binfilter/bf_sw/source/core/doc/sw_SwStyleNameMapper.cxx:494]: (error) Null pointer dereference [clone/filters/binfilter/bf_sw/source/core/doc/sw_SwStyleNameMapper.cxx:506]: (error) Null pointer dereference [clone/filters/binfilter/bf_sw/source/core/doc/sw_SwStyleNameMapper.cxx:518]: (error) Null pointer dereference [clone/filters/binfilter/bf_sw/source/core/doc/sw_SwStyleNameMapper.cxx:530]: (error) Null pointer dereference [clone/filters/binfilter/bf_sw/source/core/doc/sw_SwStyleNameMapper.cxx:542]: (error) Null pointer dereference [clone/filters/binfilter/bf_sw/source/core/doc/sw_SwStyleNameMapper.cxx:556]: (error) Null pointer dereference [clone/filters/binfilter/bf_sw/source/core/doc/sw_SwStyleNameMapper.cxx:568]: (error) Null pointer dereference [clone/filters/binfilter/bf_sw/source/core/doc/sw_SwStyleNameMapper.cxx:582]: (error) Null pointer dereference [clone/filters/binfilter/bf_sw/source/core/doc/sw_SwStyleNameMapper.cxx:596]: (error) Null pointer dereference [clone/filters/binfilter/bf_sw/source/core/doc/sw_SwStyleNameMapper.cxx:610]: (error) Null pointer dereference [clone/filters/binfilter/bf_sw/source/core/except/sw_errhdl.cxx:111]: (error) Null pointer dereference [clone/filters/writerfilter/qa/cppunittests/xxml/testXXML.cxx:141]: (error) Null pointer dereference [clone/libs-core/editeng/source/editeng/editobj.cxx:392]: (error) Null pointer dereference [clone/libs-gui/canvas/source/vcl/canvas.cxx:119]: (error) Null pointer dereference [clone/libs-gui/svl/source/items/itemset.cxx:152]: (error) Null pointer dereference [clone/libs-gui/tools/source/debug/debug.cxx:311]: (error) Null pointer dereference [clone/sdk/autodoc/source/parser_i/idl/parsenv2.cxx:200]: (error) Null pointer dereference [clone/writer/sw/source/core/crsr/crossrefbookmark.cxx:73]: (error) Null pointer dereference [clone/writer/sw/source/core/doc/SwStyleNameMapper.cxx:487]: (error) Null pointer dereference [clone/writer/sw/source/core/doc/SwStyleNameMapper.cxx:499]: (error) Null pointer dereference [clone/writer/sw/source/core/doc/SwStyleNameMapper.cxx:511]: (error) Null pointer dereference [clone/writer/sw/source/core/doc/SwStyleNameMapper.cxx:523]: (error) Null pointer dereference [clone/writer/sw/source/core/doc/SwStyleNameMapper.cxx:535]: (error) Null pointer dereference
