[PATCH] Slightly simplify loop

2013-04-21 Thread Matteo Casalin (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3539 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/39/3539/1 Slightly simplify loop Change-Id: If44e86ceecd4a407d3b4e294a03a84ad010f95e1 --- M

[PATCH] Prefer standard prefix for data members

2013-04-21 Thread Matteo Casalin (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3540 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/40/3540/1 Prefer standard prefix for data members Change-Id: Ic0d0cdc88ee17bdeeb53855162085c30b25f9004 --- M

[PATCH] Do not store return value for later, just exit

2013-04-21 Thread Matteo Casalin (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3541 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/41/3541/1 Do not store return value for later, just exit Change-Id: If71398ee5a29652303ae492d23e3910526307d3c --- M

[PATCH] bDocumentDone is always false

2013-04-21 Thread Matteo Casalin (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3538 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/38/3538/1 bDocumentDone is always false Change-Id: Ifde4d9235d3eacf0317b19885f5ea57e1c695cb3 --- M

[PATCH] OUString: remove namespace and chained appends

2013-01-25 Thread Matteo Casalin (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1833 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/33/1833/1 OUString: remove namespace and chained appends Change-Id: I1eb7e61f3151c0469db26c69439e16be0f7063df --- M

[PATCH] Remove unneeded #include

2013-01-11 Thread Matteo Casalin (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1637 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/37/1637/1 Remove unneeded #include Change-Id: Ic0c82079aeb586af97c864aebf966f01643ebfd6 --- M

[PATCH] Use member initializer list in constructor

2013-01-11 Thread Matteo Casalin (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1640 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/40/1640/1 Use member initializer list in constructor Change-Id: I8d4f8b95909b91917b456f49d7a3ac270703cc96 --- M

[PATCH] Remove unused class members

2013-01-11 Thread Matteo Casalin (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1638 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/38/1638/1 Remove unused class members Change-Id: I44fe6ad3dacc65e28256aca98588b7dfe92d73ae --- M sw/inc/hhcwrp.hxx M

[PATCH] Character conversion: do not destroy sequence while iteratin...

2013-01-11 Thread Matteo Casalin (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1636 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/36/1636/1 Character conversion: do not destroy sequence while iterating on it Change-Id:

[PATCH] Remove unused #define

2013-01-11 Thread Matteo Casalin (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1641 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/41/1641/1 Remove unused #define Change-Id: Ic92663d13892d7e4978b5f3a10ed7f473e091835 --- M sw/source/ui/lingu/hhcwrp.cxx

[PATCH] Use forward declaration instead of (doubled) #include

2013-01-11 Thread Matteo Casalin (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1642 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/42/1642/1 Use forward declaration instead of (doubled) #include Change-Id: I1cfb65a809e5dd56fb395c2f801bce5e5d75acfe ---

[PATCH] Prefix class data members

2013-01-11 Thread Matteo Casalin (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1639 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/39/1639/1 Prefix class data members Change-Id: I6734df58b589088809c712c3906f0cee3fd6a103 --- M sw/inc/hhcwrp.hxx M

[PATCH] Avoid unnecessary operations on an OUString

2013-01-03 Thread Matteo Casalin (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1537 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/37/1537/1 Avoid unnecessary operations on an OUString Change-Id: I1820711664a6aa18587e1e4a3d74a8e4cbfcc07e --- M

[PATCH] Cleanup: #include tools/gen.hxx

2012-12-25 Thread Matteo Casalin (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1484 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/84/1484/1 Cleanup: #include tools/gen.hxx Change-Id: Ic547b4a59102afc8bdbc85ec95ac312e32ef2530 --- M

[PATCH] Kill set_oenv remnants (by just renaming the required timest...

2012-11-10 Thread Matteo Casalin (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1026 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/26/1026/1 Kill set_oenv remnants (by just renaming the required timestamp file) Change-Id:

[PATCH] sal_Bool to bool

2012-11-04 Thread Matteo Casalin (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/979 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/79/979/1 sal_Bool to bool Change-Id: I8a4890c6b0e466417387a09259e32dff57c640d6 --- M sw/inc/txatritr.hxx M

[PATCH] Remove unnecessary #include

2012-11-04 Thread Matteo Casalin (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/980 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/80/980/1 Remove unnecessary #include Change-Id: I3c33ce1eecad649c3d23719b51d51057d41d9a2e --- M

[PATCH] Make HangulHanjaConversion an abstract class

2012-11-04 Thread Matteo Casalin (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/987 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/87/987/1 Make HangulHanjaConversion an abstract class Change-Id: Ie39801fc14a66af8b338188c74af9f6e52031e60 --- M

[PATCH] Don't play dirty tricks for const objects

2012-11-03 Thread Matteo Casalin (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/973 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/73/973/1 Don't play dirty tricks for const objects Change-Id: I92c2362b71cf3614b091c893c0fdb3248edb3ddd --- M

[PATCH] Enforce information hiding on gen.hxx structures

2012-10-28 Thread Matteo Casalin (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/936 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/36/936/1 Enforce information hiding on gen.hxx structures Change-Id: Icd1b2937fdeaba6de1877258731f53ddf996002e --- M