[PUSHED] fdo#60924 autoinstall - gbuild/scp2: Move more libs to OOO

2013-08-26 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/5631 Approvals: LibreOffice gerrit bot: Verified Michael Stahl: Looks good to me, approved -- To view, visit

[PATCH] gbuild: update included dep-targets as side effect of target...

2013-07-16 Thread Michael Stahl (via Code Review)
Hello LibreOffice gerrit bot, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/4904 to look at the new patch set (#2). Change subject: gbuild: update included dep-targets as side effect of targets

[PUSHED] gbuild: update included dep-targets as side effect of target...

2013-07-16 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4904 -- To view, visit https://gerrit.libreoffice.org/4904 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

[PATCH] gbuild: consolidate ULF copypaste in gb_CustomTarget_ulfex_r...

2013-07-16 Thread Michael Stahl (via Code Review)
Michael Stahl has uploaded a new patch set (#2). Change subject: gbuild: consolidate ULF copypaste in gb_CustomTarget_ulfex_rule .. gbuild: consolidate ULF copypaste in gb_CustomTarget_ulfex_rule Change-Id:

[PATCH] gbuild: consolidate ULF copypaste in gb_CustomTarget_ulfex_r...

2013-07-16 Thread Michael Stahl (via Code Review)
Michael Stahl has uploaded a new patch set (#3). Change subject: gbuild: consolidate ULF copypaste in gb_CustomTarget_ulfex_rule .. gbuild: consolidate ULF copypaste in gb_CustomTarget_ulfex_rule Change-Id:

[PATCH] gbuild: consolidate ULF copypaste in gb_CustomTarget_ulfex_r...

2013-07-16 Thread Michael Stahl (via Code Review)
Michael Stahl has uploaded a new patch set (#4). Change subject: gbuild: consolidate ULF copypaste in gb_CustomTarget_ulfex_rule .. gbuild: consolidate ULF copypaste in gb_CustomTarget_ulfex_rule Change-Id:

[PUSHED] i#108348: support DateTimeWithTimezone in user defined Docum...

2013-07-15 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4834 -- To view, visit https://gerrit.libreoffice.org/4834 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

[PATCH] i#108348: support DateTimeWithTimezone in user defined Docum...

2013-07-15 Thread Michael Stahl (via Code Review)
Hello LibreOffice gerrit bot, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/4834 to look at the new patch set (#3). Change subject: i#108348: support DateTimeWithTimezone in user defined Document Properties

[PATCH] SvStream: remove the error prone operator/(sal_Int64)

2013-07-02 Thread Michael Stahl (via Code Review)
Hello LibreOffice gerrit bot, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/4639 to look at the new patch set (#3). Change subject: SvStream: remove the error prone operator/(sal_Int64)

[PUSHED] SvStream: remove the error prone operator/(sal_Int64)

2013-07-02 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4639 -- To view, visit https://gerrit.libreoffice.org/4639 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

[PUSHED] Replace more characters functions with rtl/character.hxx

2013-06-24 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4447 Approvals: LibreOffice gerrit bot: Verified Michael Stahl: Looks good to me, approved -- To view, visit

[PUSHED libreoffice-4-1] fdo#55315 Added simple Trie lookup tree for autocomplete wor...

2013-06-17 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4237 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4237 To unsubscribe,

[PUSHED] PyUno fixed crash in function isInstanceOfStructOrException(...

2013-06-16 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4309 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4309 To unsubscribe,

[PUSHED] Simplify SwPaM::GetTxt

2013-06-16 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4213 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4213 To unsubscribe,

[PUSHED] cppcheck: fix duplicateExpression

2013-06-16 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4279 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4279 To unsubscribe,

[PUSHED] fdo#65014 Fix backwards/forwards search change of direction.

2013-06-04 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4061 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4061 To unsubscribe,

[PATCH libreoffice-4-0] jvmfwk: de-Pascalize do_msvcr71_magic

2013-06-02 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4135 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/35/4135/1 jvmfwk: de-Pascalize do_msvcr71_magic The uninitialized Module variable causes the smoketest to fail when built

[PATCH libreoffice-4-0] libcdr: fix build with MSVC2008

2013-05-30 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4109 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/09/4109/1 libcdr: fix build with MSVC2008 Change-Id: I70731e13ab4ef0d6eadd803b8f6a24f565be5346 --- M

[PATCH libreoffice-4-0] fix copying of MSVC2008 runtime DLLs

2013-05-30 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4110 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/10/4110/1 fix copying of MSVC2008 runtime DLLs (regression from d7b428453b07f48b56e7d83f05d81fae91b921c8) Change-Id:

[PATCH libreoffice-4-0] fdo#57079: SvxSuperContourDlg: unregister configuration list...

2013-05-17 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3937 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/37/3937/1 fdo#57079: SvxSuperContourDlg: unregister configuration listener ... in destructor. Otherwise it will access

[PATCH libreoffice-4-0] fdo#62965: fix crash in Edit Contour dialog

2013-05-17 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3936 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/36/3936/1 fdo#62965: fix crash in Edit Contour dialog The pObjList is 0, so use pObj's GetModel() which should be the

[PATCH libreoffice-3-6] fdo#62965: fix crash in Edit Contour dialog

2013-05-17 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3940 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/40/3940/1 fdo#62965: fix crash in Edit Contour dialog The pObjList is 0, so use pObj's GetModel() which should be the

[PATCH libreoffice-3-6] fdo#57079: SvxSuperContourDlg: unregister configuration list...

2013-05-17 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3941 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/41/3941/1 fdo#57079: SvxSuperContourDlg: unregister configuration listener ... in destructor. Otherwise it will access

[PUSHED] Remove code associated with psprint::CompatMetricOverride se...

2013-05-16 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3824 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3824 To unsubscribe,

[PUSHED] configure: check libjpeg having JERR_BAD_CROP_SPEC defined

2013-05-16 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3796 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3796 To unsubscribe,

[PUSHED libreoffice-4-0] fdo#64577, CMIS: fixed crasher in libcmis

2013-05-16 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3921 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3921 To unsubscribe,

[PATCH libreoffice-3-6] fdo#60967: re-enable deletion of paragraph following table

2013-05-16 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3927 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/27/3927/1 fdo#60967: re-enable deletion of paragraph following table This was actually a documented feature, so removing

[PATCH libreoffice-4-0] fdo#60967: re-enable deletion of paragraph following table

2013-05-16 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3928 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/28/3928/1 fdo#60967: re-enable deletion of paragraph following table This was actually a documented feature, so removing

[PUSHED] gbuild: gcc platforms: link with C compiler if no C++ files

2013-05-10 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3828 -- To view, visit https://gerrit.libreoffice.org/3828 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

[PATCH] zlib: remove ExternalPackage_zlib

2013-05-08 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3826 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/26/3826/1 zlib: remove ExternalPackage_zlib Change-Id: I5bce88b2044279a6563fd68c35f9c1ac824c8850 --- M

[PATCH] gbuild: unxgcc: link with C compiler if no C++ files

2013-05-08 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3828 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/28/3828/1 gbuild: unxgcc: link with C compiler if no C++ files In 5589c72b88e502bfca045ae38af16c854afdd401 a problem due

[PUSHED] zlib: remove ExternalPackage_zlib

2013-05-08 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3826 -- To view, visit https://gerrit.libreoffice.org/3826 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

[PUSHED libreoffice-4-0] fdo#54087 refactor/fix browser plugin detection on Windows

2013-05-06 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3784 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3784 To unsubscribe,

[PUSHED libreoffice-3-6] fdo#54087 refactor/fix browser plugin detection on Windows

2013-05-06 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3785 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3785 To unsubscribe,

[PUSHED libreoffice-4-0] fdo#33091 a NULL value of float type is not NaN

2013-04-26 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3599 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3599 To unsubscribe,

[PUSHED] fix WaE with system libhunspell

2013-04-26 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3618 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3618 To unsubscribe,

[PATCH] gbuild: MSVC: only re-link libraries if exported symbols cha...

2013-04-25 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3612 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/12/3612/1 gbuild: MSVC: only re-link libraries if exported symbols change Implement commit

[PATCH libreoffice-4-0-3] fdo#60280: sw: restore anti-aliasing for all OLE objects

2013-04-24 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3594 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/94/3594/1 fdo#60280: sw: restore anti-aliasing for all OLE objects The OLE case in SwNoTxtFrm::PaintPicture() was

[PATCH libreoffice-4-0] fdo#62147: sw: ODF import: apply styles in cells with string...

2013-04-23 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3575 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/75/3575/1 fdo#62147: sw: ODF import: apply styles in cells with string-value Apply the table-cell-style to paragraphs

[PATCH libreoffice-4-0] fdo#60280: sw: restore anti-aliasing for all OLE objects

2013-04-23 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3589 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/89/3589/1 fdo#60280: sw: restore anti-aliasing for all OLE objects The OLE case in SwNoTxtFrm::PaintPicture() was

[PATCH] gbuild: drop unneeded package

2013-04-23 Thread Michael Stahl (via Code Review)
Hello LibreOffice gerrit bot, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/3504 to look at the new patch set (#2). Change subject: gbuild: drop unneeded package .. gbuild: drop unneeded

[PUSHED] gbuild: drop unneeded package

2013-04-23 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3504 -- To view, visit https://gerrit.libreoffice.org/3504 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

[PUSHED] replace python-core zip built in pyuno with direct use of Pa...

2013-04-22 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3525 Approvals: LibreOffice gerrit bot: Verified Michael Stahl: Looks good to me, approved -- To view, visit

[PUSHED libreoffice-4-0] rhbz#954991 Avoid static data (causing trouble at exit)

2013-04-22 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3556 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3556 To unsubscribe,

[PUSHED libreoffice-3-6] rhbz#954991 Avoid static data (causing trouble at exit)

2013-04-22 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3557 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3557 To unsubscribe,

[PUSHED] clean up PythonTests

2013-04-22 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3478 -- To view, visit https://gerrit.libreoffice.org/3478 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

[PUSHED libreoffice-4-0-3] Revert svformatter already accept OUString input, fdo#6330...

2013-04-22 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3469 Approvals: Andras Timar: Looks good to me, but someone else must approve Michael Stahl: Verified; Looks good to me, approved Fridrich

[PATCH] replace python-core zip built in pyuno with direct use of Pa...

2013-04-21 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3525 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/25/3525/1 replace python-core zip built in pyuno with direct use of Package - python3: deliver files to INSTDIR, with

[PATCH] replace python-core zip built in pyuno with direct use of Pa...

2013-04-21 Thread Michael Stahl (via Code Review)
Hello LibreOffice gerrit bot, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/3525 to look at the new patch set (#2). Change subject: replace python-core zip built in pyuno with direct use of Package

[PATCH] pyuno_loader::CreateInstance: delete the initial PyThreadSta...

2013-04-18 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3452 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/52/3452/1 pyuno_loader::CreateInstance: delete the initial PyThreadState Don't see how it could be used again, it appears

[PATCH] python3: disable check in PyThreadState_Swap

2013-04-18 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3453 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/53/3453/1 python3: disable check in PyThreadState_Swap This check is triggered by nested pyuno PyThreadAttach instances.

[PATCH libreoffice-4-0] curl: link against the internal NSS if SYSTEM_NSS=NO

2013-04-18 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3463 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/63/3463/1 curl: link against the internal NSS if SYSTEM_NSS=NO This is somewhat non-obvious since there is no way to

[PATCH] run PythonTests with internal python too

2013-04-18 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3471 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/71/3471/1 run PythonTests with internal python too ... and use PYTHON_FOR_BUILD in the system python case. Change-Id:

[PATCH libreoffice-4-0] python3: re-enable both debug symbols and optimization

2013-04-18 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3472 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/72/3472/1 python3: re-enable both debug symbols and optimization These were apparently accidentally disabled on all

[PUSHED] Convert usage of SfxPtrArray to std::vector

2013-04-16 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3356 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3356 To unsubscribe,

[PUSHED] Convert SfxPtrArray to std::vector in SfxTabDialogItem

2013-04-16 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3358 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3358 To unsubscribe,

[PUSHED] Convert SfxObjectUIArr_Impl from SfxPtrArr to std::vector

2013-04-16 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3359 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3359 To unsubscribe,

[PUSHED] Convert SfxViewFactoryArr_Impl from SfxPtrArray to std::vect...

2013-04-16 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3360 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3360 To unsubscribe,

[PUSHED] Convert SfxChildList_Impl from SfxPtrArr to std::vector

2013-04-16 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3388 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3388 To unsubscribe,

[PUSHED] Convert SfxChildWindows_Impl from SfxPtrArr to std::vector

2013-04-16 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3390 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3390 To unsubscribe,

[PUSHED] Convert SfxShellStack_Impl from SfxPtrArr to std::vector

2013-04-16 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3394 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3394 To unsubscribe,

[PUSHED] remove dead code minstack.hxx

2013-04-16 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3397 Approvals: Thomas Arnhold: Looks good to me, but someone else must approve Michael Stahl: Verified; Looks good to me, approved -- To

[PUSHED] remove dead class SfxPtrAr and it's header sfx/inc/sfx2/mina...

2013-04-16 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3399 Approvals: Thomas Arnhold: Looks good to me, but someone else must approve Michael Stahl: Verified; Looks good to me, approved -- To

[PUSHED] Convert SmFontPickList from SfxPtrArr to std::vector

2013-04-16 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3398 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3398 To unsubscribe,

[PUSHED] Convert SwDrawTextInfo.pText from XubString to OUString

2013-04-16 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3417 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3417 To unsubscribe,

[PUSHED libreoffice-3-6] Resolves: fdo#47209 and rhbz#927223 syntax highlighter crash

2013-04-16 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3415 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3415 To unsubscribe,

[PUSHED libreoffice-4-0] Resolves: fdo#47209 and rhbz#927223 syntax highlighter crash

2013-04-16 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3414 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3414 To unsubscribe,

[PUSHED] gbuild: LinkTarget: only re-link libraries if exported symbo...

2013-04-15 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3272 -- To view, visit https://gerrit.libreoffice.org/3272 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

[PATCH libreoffice-4-0] odk: fix packaging of purpenvhelper import lib on WNT

2013-04-10 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3307 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/07/3307/1 odk: fix packaging of purpenvhelper import lib on WNT This import lib was apparently renamed in LO 3.6 and the

[PATCH libreoffice-3-6] odk: fix packaging of purpenvhelper import lib on WNT

2013-04-10 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3308 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/08/3308/1 odk: fix packaging of purpenvhelper import lib on WNT This import lib was apparently renamed in LO 3.6 and the

[PATCH] gbuild: LinkTarget: only re-link libraries if exported symbo...

2013-04-08 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3272 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/72/3272/1 gbuild: LinkTarget: only re-link libraries if exported symbols change Write out the exported symbols of a

[PATCH] set up python unit test infrastructure

2013-04-05 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3214 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/14/3214/1 set up python unit test infrastructure Extract boostraping code from convwatch.py to unotest.py. Use python

[PATCH] move Python tests in-process

2013-04-05 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3215 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/15/3215/1 move Python tests in-process This is nice to make them more easily debuggable. A series of crude hacks are

[PUSHED] remove -dylib_file mappings that are not needed anymore

2013-04-04 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3192 Approvals: LibreOffice gerrit bot: Verified Michael Stahl: Looks good to me, approved -- To view, visit

[PUSHED] fdo#42781 WaE: C4101 unreferenced local variable

2013-04-04 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3204 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3204 To unsubscribe,

[PUSHED] Easter Bunny brings new redland tarballs

2013-04-03 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3154 Approvals: LibreOffice gerrit bot: Verified Michael Stahl: Looks good to me, approved -- To view, visit

[PUSHED] Use OUString in ImplGetEllipsisString()

2013-04-03 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3159 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3159 To unsubscribe,

[PATCH] Easter Bunny brings new redland tarballs

2013-04-02 Thread Michael Stahl (via Code Review)
Hello LibreOffice gerrit bot, I'd like you to reexamine a rebased change. Please visit https://gerrit.libreoffice.org/3154 to look at the new rebased patch set (#3). Change subject: Easter Bunny brings new redland tarballs

[PUSHED] Get rid of the slots.cfg mechanism

2013-04-02 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3118 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3118 To unsubscribe,

[PUSHED] Use OUString and sal_Int32 in GetTextWidth() (2)

2013-04-02 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3158 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3158 To unsubscribe,

[PATCH] Easter Bunny brings new redland tarballs

2013-04-01 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3154 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/54/3154/1 Easter Bunny brings new redland tarballs upgrade raptor to 2.0.9, rasqal to 0.9.30, redland to 1.0.16: - stop

[PATCH] Easter Bunny brings new redland tarballs

2013-04-01 Thread Michael Stahl (via Code Review)
Michael Stahl has uploaded a new patch set (#2). Change subject: Easter Bunny brings new redland tarballs .. Easter Bunny brings new redland tarballs upgrade raptor to 2.0.9, rasqal to 0.9.30, redland to 1.0.16: - new raptor

[PATCH libreoffice-4-0] fdo#60513: SwCrsrShell::Push(): take position from table cur...

2013-03-27 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3100 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/00/3100/1 fdo#60513: SwCrsrShell::Push(): take position from table cursor If there is a table cursor, store its

[PATCH libreoffice-4-0] fdo#61429: Stylist: save selection of Hierarchical entry

2013-03-26 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3056 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/56/3056/1 fdo#61429: Stylist: save selection of Hierarchical entry This is unfortunately rather ugly because that one is

[PATCH libreoffice-3-6-6] fdo#58071: .dot files sometimes rejected by writer

2013-03-22 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2918 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/18/2918/1 fdo#58071: .dot files sometimes rejected by writer because CWW8 appears twice, once for normal .doc and once

[PATCH libreoffice-4-0] fdo#61952: sw: fix left/right-only page styles and first-pag...

2013-03-15 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2764 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/64/2764/1 fdo#61952: sw: fix left/right-only page styles and first-page - remove PD_FIRST and GetFirstFmt: This flag

[PUSHED libreoffice-4-0] Package fonts to the fonts subpackage

2013-03-12 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2683 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2683 To unsubscribe,

[PUSHED libreoffice-4-0] Resolves: #i119658#, some Chinese numbering formats not supp...

2013-03-12 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2682 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2682 To unsubscribe,

[PATCH libreoffice-4-0] fdo#60886: _SetGetExpFlds: use the custom operator

2013-03-01 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2504 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/04/2504/1 fdo#60886: _SetGetExpFlds: use the custom operator The calls to upper_bound in SwDoc::FldsToExpand and

[PATCH libreoffice-3-6] fdo#61000: writerfilter: filter out unsupported list tab sto...

2013-02-28 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2465 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/65/2465/1 fdo#61000: writerfilter: filter out unsupported list tab stops Change-Id:

[PATCH libreoffice-4-0] fdo#61016: sw::marks::MarkManager: delay deletion of text fi...

2013-02-28 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2466 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/66/2466/1 fdo#61016: sw::marks::MarkManager: delay deletion of text fieldmarks There is a STL assertion in deleteMarks

[PATCH libreoffice-4-0] sw: remove CH_TXT_ATR_FORMELEMENT when CheckboxFieldmark is ...

2013-02-28 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2467 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/67/2467/1 sw: remove CH_TXT_ATR_FORMELEMENT when CheckboxFieldmark is deleted Change-Id:

[PUSHED] Fix typo persistant - persistant

2013-02-28 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2347 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2347 To unsubscribe,

[PUSHED libreoffice-4-0] we need system libcmis 0.3.1 now

2013-02-27 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2442 Approvals: Niko Rönkkö: Looks good to me, but someone else must approve Michael Stahl: Verified; Looks good to me, approved -- To

[PATCH] remove dmake, build.pl, deliver.pl and zipdep.pl

2013-02-27 Thread Michael Stahl (via Code Review)
Michael Stahl has uploaded a new patch set (#5). Change subject: remove dmake, build.pl, deliver.pl and zipdep.pl .. remove dmake, build.pl, deliver.pl and zipdep.pl This is writing history: LibreOffice builds in ONE

[PATCH libreoffice-4-0] SwDoc::Overwrite: probably a bad idea to overwrite fieldmark...

2013-02-15 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2175 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/75/2175/1 SwDoc::Overwrite: probably a bad idea to overwrite fieldmarks Change-Id:

[PATCH libreoffice-4-0] sw: do not crash when it's not possible to insert fly

2013-02-15 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2176 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/76/2176/1 sw: do not crash when it's not possible to insert fly Change-Id: Idfcf54013107ba6b7ce3de0d0bddbef306698f33

[PATCH libreoffice-4-0] fdo#60842: sw ODF import: support value-type=string on cel...

2013-02-15 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2177 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/77/2177/1 fdo#60842: sw ODF import: support value-type=string on cells: According to ODF 1.2 part 1 19.385

[PATCH libreoffice-3-6] fdo#60732: SwTxtNode: limit to less than STRING_LEN chars

2013-02-15 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2178 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/78/2178/1 fdo#60732: SwTxtNode: limit to less than STRING_LEN chars It's not a good idea to have STRING_LEN characters in

[PATCH libreoffice-4-0] fdo#60732: SwTxtNode: limit to less than STRING_LEN chars

2013-02-15 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2179 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/79/2179/1 fdo#60732: SwTxtNode: limit to less than STRING_LEN chars It's not a good idea to have STRING_LEN characters in

  1   2   3   >