Re: perf.libreoffice.org and Callgrind TB working again

2019-02-13 Thread Noel Grandin via LibreOffice
On 2019/02/14 2:33 AM, Markus Mohrhard via LibreOffice wrote: the Callgrind tinderbox is after several updates (F20->F29) working again and seems to produce results again. The first round of results have been published on perf.libreoffice.org again. Thanks

Re: export doesn't allow overwriting current document (?)

2019-02-07 Thread Noel Grandin
On 2019/02/07 2:28 PM, Caolán McNamara wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1673198 points out that if you import a pdf document and then try and re-export that pdf to overwrite the original, the overwrite is not allowed. (Though there is no such general problem with save/save-as

Re: Temporarily yielding SolarMutex to another thread

2019-02-02 Thread Noel Grandin
Assuming that there is no other way to accomplish this, how could it work to allow multiple child widgets to "own" the SolarMutex simultaneously? We just need one of those threads to trigger an update to something like a cache, and one of the other threads is likely to crash because of a stale

Re: Temporarily yielding SolarMutex to another thread

2019-02-01 Thread Noel Grandin
On Fri, 1 Feb 2019 at 17:11, Luboš Luňák wrote: > - Calc threading - the Interpret() call may spawn several threads to > compute > This case smells like this functionality should be using a different mutex instead of the SolarMutex, then the main thread could hold some kind of InterpretMutex,

Re: Building LibreOffice on MacOS mojave

2019-01-31 Thread Noel Grandin
the easiest fix is probably --disable-odk it seems like configure.ac is not currently extracting the version of your jdk, and consequently is passing a -source option to javadoc that is not supported by your version of java. ___ LibreOffice mailing

Re: HTML import filter very (too) basic

2019-01-09 Thread Noel Grandin
On Wed, 9 Jan 2019 at 10:25, Jens Tröger wrote: > > > On Jan 9, 2019, at 16:06, Noel Grandin wrote: > > > > Nobody owns it, and you're welcome to file a bug, but there are already > a ton of HTML import bugs, our support is really very basic. > > Well I’ve

Re: OpenGrok for core

2019-01-07 Thread Noel Grandin
On Mon, 7 Jan 2019 at 10:41, Noel Grandin wrote: > Note that the new opengrok does not seem to work very well on chrome (Version > 71.0.3578.98 (Official Build) (64-bit)) > > this seems to have been some kind of stale cache prob

Re: OpenGrok for core

2019-01-07 Thread Noel Grandin
Note that the new opengrok does not seem to work very well on chrome (Version 71.0.3578.98 (Official Build) (64-bit)) specifically, pages like https://opengrok.libreoffice.org/xref/core/include/vcl/vclptr.hxx?r=2e83a62f do not show a scrollbar, so I can't scroll to most of the file.

Re: improvements on ellipticalquadrant in enhanced path of custom shape

2018-12-08 Thread Noel Grandin
On Sat, 8 Dec 2018 at 20:25, Regina Henschel wrote: > Problem A > The current implementation has a method GetPoint, which returns a > tools::Point; and such has integer coordinates. This introduces > > I would say you should change GetPoint() to return a basegfx::B2Point. You can't have two

Re: Windows build failure - C2131: expression did not evaluate to a constant

2018-12-03 Thread Noel Grandin
I'm seeing the following build failure on Windows 32-bit release build: D:/core/vcl/source/bitmap/BitmapTools.cxx(1078): error C2131: expression did not evaluate to a constant D:/core/vcl/source/bitmap/BitmapTools.cxx(1097): error C2131: expression did not evaluate to a constant make[1]: ***

Re: Proposed XHP extensions

2018-10-22 Thread Noel Grandin
Hi Seems like a nice idea in general. Just a couple of notes: Should localize=true not just be the default? so it only needs to be specified for the occasional chunk of text that is lanuage-neutral? Similarly, should xml-lang="en-US" not just be specified in some tag near the root of

Re: After loplugin:staticvar in sw, Jenkins_Windows_Dbg failing

2018-10-21 Thread Noel Grandin
I had a fix in progress, but I see sberg beat me to it with c0dcf426d258bc0b605b4097833729eb9ed05025 :-) On Sat, 20 Oct 2018 at 18:18, Luke Benes wrote: > After >

Re: Tinderbox @71 now failing with undefined reference to `SvMemoryStream::remainingSize()´

2018-10-17 Thread Noel Grandin
workaround pushed as commit 4b5e8066e230b4fcbadb39b306f7c272865b0245 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Upstream clang compiler plugins, licensing

2018-10-07 Thread Noel Grandin
IANAL, obviously, but possibly you could pick the plugins you want and ask all the people who worked on that plugin to re-license their work (there are not that many, and they are mostly still around) For the record, for anything in compilerplugins/ that I have touched, I grant you permission to

Re: CppunitTest_sc_filters_test now failing on Jenkins_MacOSX

2018-10-06 Thread Noel Grandin
attempted fix on its way with https://gerrit.libreoffice.org/61464 no idea what std::vector is doing to make this unreliable on macOS only ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: PythonTest_sw_python failure

2018-10-05 Thread Noel Grandin
On 2018/10/04 8:13 AM, Kaganski Mike wrote: Since commit 4a290888580474f9542f185091bb2a6fcf4e9a53, PythonTest_sw_python fails on Windows (with VS 15.8.6) in SvtBroadcaster::~SvtBroadcaster() on line 102 while (dest != maDestructedListeners.end() && (*dest < *it)) fixed now with

Re: Calc: Further cache simulation results

2018-10-03 Thread Noel Grandin
On 2018/10/01 2:19 PM, Kohei Yoshida wrote: On October 1, 2018 at 5:31 AM Michael Meeks wrote: Kohei poked at a chunk of profiles like this in the past; probably worth getting his input; any thoughts ? So, I believe when I reworked the internals of SvlListener & SvlBroadcaster to

Re: Resources on writing import/export file filters for Writer

2018-09-27 Thread Noel Grandin
On 2018/09/27 11:10 AM, Jens Tröger wrote: I’ve been poking through the HTML reader (rather superficially, I admit) in search for the code that expands HTML entities to Unicode. I did that to Probably HTMLParser::ScanText at svtools/source/svhtml/parhtml.cxx:394

Re: Intermittent Unit Test Failure: VclComplexTextTest::testArabic

2018-09-27 Thread Noel Grandin
On Thu, 27 Sep 2018 at 08:28, Noel Grandin wrote: > > > On Wed, 26 Sep 2018 at 23:58, Jan-Marek Glogowski > wrote: > >> For me it looks like a multi-threaded problem, where something isn't >> correct processed in order. I can reproduce crashes when I run a very &

Re: Intermittent Unit Test Failure: VclComplexTextTest::testArabic

2018-09-27 Thread Noel Grandin
On Wed, 26 Sep 2018 at 23:58, Jan-Marek Glogowski wrote: > For me it looks like a multi-threaded problem, where something isn't > correct processed in order. I can reproduce crashes when I run a very > parallel make check often, but never was able to get something in a > debugger... > > mst

Re: Hunspell probably breaks build on macOS

2018-09-25 Thread Noel Grandin
try doing a make clean. Check that (if you're using LODE) that your LODE install is up to date (do a git pull in the root LODE folder, then run setup again), which will update things like cmake and autotools ___ LibreOffice mailing list

Re: Jenkins_Callgrind failing on CppunitTest_sw_layoutwriter and CppunitTest_sw_uiwriter

2018-09-15 Thread Noel Grandin
thanks, fixed now with https://cgit.freedesktop.org/libreoffice/core/commit/?id=203f7320950346841931cc2525155f817987e279 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice-commits] core.git: clang-tidy performance-move-const-arg

2018-09-07 Thread Noel Grandin
On Fri, 7 Sep 2018 at 14:25, Stephan Bergmann wrote: > For my taste, that approach is too tightly tied to a class's current > implementation details, something that may change over time. Imagine a > > Yeah, I agree, the particular clang-tidy plugin did not generate useful results: revert

Re: make check fails in [build JCS]

2018-08-29 Thread Noel Grandin
On 2018/08/29 11:06 AM, Stephan Bergmann wrote: investigating deeper into the issue.  (Apparently, Java no longer accepts file:... URLs there, at least on Windows, and won't accept full pathnames starting with a drive letter like C:/..., but does accept ("drive-absolute") pathnames like /...;

Re: Error on First Run in Windows: Solar Mutex not owned

2018-08-17 Thread Noel Grandin
thanks, should be fixed soon with https://gerrit.libreoffice.org/59245 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [comment libreoffice-6-1] Access2Base - Fix Filter arg not applied in OpenForm

2018-08-14 Thread Noel Grandin
Our build infrastructure glitches sometimes. I see that it has auto-restarted and your change is now verified. ​ ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: broken radio/checkboxes in LibreOffice 6.1 (was: Re: UI regressions in "gen" plugin with LibreOffice 6.1)

2018-08-12 Thread Noel Grandin
​ ​Don't the icon themes have weird links files that allow each icon theme to copy icons from other themes? Perhaps just a matter of updating those files so those other themes get the necessary checkbox, etc icons?​ ___ LibreOffice mailing list

Re: Error on First Run in Windows: Solar Mutex not owned

2018-08-11 Thread Noel Grandin
can you get a stacktrace? ​ ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Minutes of ESC call: 2018-08-02

2018-08-08 Thread Noel Grandin
On 2018/08/06 11:06 AM, Michael Stahl wrote: On 02.08.2018 20:25, Jan Holesovsky wrote:     + tests that failed more than twice in last 7 days:    3 CppunitTest_sw_filters_test    3 CppunitTest_sw_htmlimport    3 CppunitTest_vcl_complextext    3 CppunitTest_vcl_fontfeature

Re: Windows Debug builds failure: 'DbgGUIInitSolarMutexCheck': identifier not found

2018-08-06 Thread Noel Grandin
On 2018/08/05 10:32 PM, Caolán McNamara wrote: On Sun, 2018-08-05 at 16:48 +, Luke Benes wrote: Noel, That fix and subsequent fixes are not enough. Windows debug builds are still failing. Currently they fail on CppunitTest_services: This is the bt... thanks for the bt caolan. Should

Re: Segfault compiling master

2018-08-03 Thread Noel Grandin
On 2018/08/02 5:23 PM, Regina Henschel wrote: I hope, that helps to find the reason. I think caoloan has fixed this with https://cgit.freedesktop.org/libreoffice/core/commit/?id=653394fb199fae2d9e39f681fc72b35fe7f3 ___ LibreOffice mailing

Re: Is there a way to know if a dispatch command opens a dialog?

2018-08-02 Thread Noel Grandin
On 2018/08/02 9:57 AM, Miklos Vajna wrote: On Wed, Aug 01, 2018 at 04:52:14PM +0530, Saurav Chirania wrote: There are dispatch commands (like .uno:FontDialog) which open a dialog when executed. There are other dispatch commands (like .uno:GoDown) which don't open a dialog when executed. Do

Re: Windows Debug builds failure: 'DbgGUIInitSolarMutexCheck': identifier not found

2018-07-31 Thread Noel Grandin
On 2018/07/31 5:54 AM, Luke Benes wrote: Noel, Ever since: https://cgit.freedesktop.org/libreoffice/core/commit/?id=9cceba9a make DBG_TESTSOLARMUTEX available in assert builds Windows builds with "--enable-debug" are failing with the following error: D:/core/vcl/source/app/svmain.cxx(371):

[Libreoffice-commits] core.git: basic/source compilerplugins/clang

2018-07-13 Thread Noel Grandin
dbf8ad9bc385411c349095dfa66345464b4215d6 Author: Noel Grandin Date: Fri Jul 13 10:50:22 2018 +0200 loplugin:useuniqueptr in SbUnoStructRefObject now that we have upgraded to VS2017, we can use std::unique_ptr in std::map Change-Id

[Libreoffice-commits] core.git: sc/source

2018-07-13 Thread Noel Grandin
sc/source/ui/dbgui/scuiasciiopt.cxx |6 +++--- sc/source/ui/inc/scuiasciiopt.hxx |2 +- 2 files changed, 4 insertions(+), 4 deletions(-) New commits: commit a5c04cbf2309ddb1d3ee80f2f2674df38b52df80 Author: Noel Grandin Date: Thu Jul 12 16:33:23 2018 +0200 loplugin:useuniqueptr

[Libreoffice-commits] core.git: sw/source

2018-07-13 Thread Noel Grandin
sw/source/core/inc/UndoDelete.hxx |4 ++-- sw/source/core/undo/undel.cxx | 14 ++ 2 files changed, 8 insertions(+), 10 deletions(-) New commits: commit 41e2cbc157ce70ea4db67be1a77f61810089b840 Author: Noel Grandin Date: Thu Jul 12 17:05:52 2018 +0200

[Libreoffice-commits] core.git: 2 commits - sw/source

2018-07-13 Thread Noel Grandin
0673411c58529e6c4252b7973a16afae1f4363f1 Author: Noel Grandin Date: Thu Jul 12 17:01:48 2018 +0200 loplugin:useuniqueptr in SwUndoSplitNode Change-Id: Ib77b31a7558b5d3c928d774d3c6bdaeff26c177d Reviewed-on: https://gerrit.libreoffice.org/57366 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git

[Libreoffice-commits] core.git: 2 commits - compilerplugins/clang sw/source

2018-07-13 Thread Noel Grandin
insertions(+), 31 deletions(-) New commits: commit c79bd83818dbd49dfd77ab82457057eff6a5d3d7 Author: Noel Grandin Date: Thu Jul 12 16:57:07 2018 +0200 loplugin:useuniqueptr in SwUndoInsTable Change-Id: If3f0f51415d0cae910fded9f1391219a8b5b7309 Reviewed-on: https

[Libreoffice-commits] core.git: sc/source

2018-07-13 Thread Noel Grandin
sc/source/filter/inc/XclExpChangeTrack.hxx |8 sc/source/filter/xcl97/XclExpChangeTrack.cxx | 17 - 2 files changed, 12 insertions(+), 13 deletions(-) New commits: commit 281f1281edbd0063b1d1d9151bcbfc1299a0082e Author: Noel Grandin Date: Thu Jul 12 16:38:14

[Libreoffice-commits] core.git: sc/source

2018-07-13 Thread Noel Grandin
sc/source/ui/inc/instbdlg.hxx |2 +- sc/source/ui/miscdlgs/instbdlg.cxx |6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) New commits: commit 77a015f160d544827d298fd42b16418ace6a43c0 Author: Noel Grandin Date: Thu Jul 12 16:40:47 2018 +0200 loplugin:useuniqueptr

[Libreoffice-commits] core.git: editeng/source include/editeng include/svx sc/source

2018-07-13 Thread Noel Grandin
: commit ddef60b9c26b1d2990c6c49dbbda73e7831f21fb Author: Noel Grandin Date: Wed Jul 11 21:53:47 2018 +0200 pass SvxFieldData around by std::unique_ptr Change-Id: I9c826547d348000dd6c80e45d833e048caae0ed8 Reviewed-on: https://gerrit.libreoffice.org/57308 Tested-by: Jenkins

[Libreoffice-commits] core.git: sc/source

2018-07-13 Thread Noel Grandin
sc/source/filter/inc/XclExpChangeTrack.hxx |2 +- sc/source/filter/xcl97/XclExpChangeTrack.cxx |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) New commits: commit 1ea64c9d0d73daec926390c87afc543d54e71fb0 Author: Noel Grandin Date: Thu Jul 12 16:34:49 2018 +0200

[Libreoffice-commits] core.git: basctl/source chart2/source cui/source dbaccess/source desktop/source editeng/source framework/source include/editeng include/framework include/sfx2 include/svl include

2018-07-13 Thread Noel Grandin
2d71dd52b6d91660cda6cb8f9457463439f56e20 Author: Noel Grandin Date: Thu Jul 12 09:42:07 2018 +0200 merge IUndoManager into SfxUndoManager SfxUndoManager is the only implementation of the IUnderManager "interface", and it lives in the same header. Plus this way we can get rid of some

[Libreoffice-commits] core.git: solenv/gbuild

2018-07-12 Thread Noel Grandin
solenv/gbuild/CppunitTest.mk |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit d45a158f2d9114069870469e9004f3f7ed1f3636 Author: Noel Grandin Date: Thu Jul 12 15:47:56 2018 +0200 improve message when running perfcheck without valgrind installed Change

[Libreoffice-commits] core.git: compilerplugins/clang

2018-07-12 Thread Noel Grandin
|2 ++ compilerplugins/clang/virtualdown.py |4 +++- 6 files changed, 14 insertions(+), 2 deletions(-) New commits: commit 85cf4d25a3df3da86840c69bc035d58212a9672c Author: Noel Grandin Date: Thu Jul 12 11:14:13 2018 +0200 loplugin:mergeclasses fix ignoring some

[Libreoffice-commits] core.git: 2 commits - icon-themes/colibre sc/source

2018-07-12 Thread Noel Grandin
icon-themes/colibre/links.txt |2 +- sc/source/filter/inc/rtfparse.hxx |2 +- sc/source/filter/rtf/rtfparse.cxx | 14 +++--- 3 files changed, 9 insertions(+), 9 deletions(-) New commits: commit 0d7193bd2cd2f1bd24232095d7617f0764c58a9b Author: Noel Grandin Date: Wed Jul

[Libreoffice-commits] core.git: sc/source

2018-07-12 Thread Noel Grandin
sc/source/filter/html/htmlpars.cxx | 49 - sc/source/filter/inc/htmlpars.hxx |8 +++--- 2 files changed, 26 insertions(+), 31 deletions(-) New commits: commit 510033783a9921eef507d424fc5adf6e2696bc4a Author: Noel Grandin Date: Wed Jul 11 12:46:41

[Libreoffice-commits] core.git: sc/source

2018-07-12 Thread Noel Grandin
sc/source/filter/inc/XclImpChangeTrack.hxx |4 ++-- sc/source/filter/xcl97/XclImpChangeTrack.cxx |4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) New commits: commit 7d710ee08fbaecd376a8b731965e805ad0f4c59a Author: Noel Grandin Date: Wed Jul 11 12:29:58 2018 +0200

[Libreoffice-commits] core.git: sc/source

2018-07-12 Thread Noel Grandin
sc/source/filter/inc/XclExpChangeTrack.hxx |4 ++-- sc/source/filter/xcl97/XclExpChangeTrack.cxx | 11 +-- 2 files changed, 7 insertions(+), 8 deletions(-) New commits: commit 592eb9217a52632e4271db3628c5aafb0cefbee8 Author: Noel Grandin Date: Wed Jul 11 12:24:18 2018 +0200

[Libreoffice-commits] core.git: sc/source

2018-07-12 Thread Noel Grandin
bf9d2c6f208faa18b17c8962e47de3a26ac40497 Author: Noel Grandin Date: Wed Jul 11 11:30:12 2018 +0200 loplugin:useuniqueptr in RootData Change-Id: Ibb053d17a1da6e3db74b97b4f66a4ad03147b3bc Reviewed-on: https://gerrit.libreoffice.org/57297 Tested-by: Jenkins Reviewed-by: Noel

[Libreoffice-commits] core.git: sw/inc sw/source

2018-07-12 Thread Noel Grandin
sw/inc/undobj.hxx |2 +- sw/source/core/undo/undobj.cxx | 10 -- 2 files changed, 5 insertions(+), 7 deletions(-) New commits: commit 807d5f11f4e4895a74c999b5f81b42c1a6743060 Author: Noel Grandin Date: Wed Jul 11 15:51:20 2018 +0200 loplugin:useuniqueptr

[Libreoffice-commits] core.git: sw/source

2018-07-12 Thread Noel Grandin
sw/source/core/text/redlnitr.cxx |6 +++--- sw/source/core/text/redlnitr.hxx |2 +- 2 files changed, 4 insertions(+), 4 deletions(-) New commits: commit b1a15e7f5b5680b33bd25956479dc30209a79078 Author: Noel Grandin Date: Wed Jul 11 14:34:24 2018 +0200 loplugin:useuniqueptr

[Libreoffice-commits] core.git: sw/source

2018-07-12 Thread Noel Grandin
+--- 5 files changed, 16 insertions(+), 18 deletions(-) New commits: commit 478d967eeb7ef8247033918da09d022427593f68 Author: Noel Grandin Date: Wed Jul 11 14:05:42 2018 +0200 loplugin:useuniqueptr in SwGrammarContact Change-Id: I13b346751a001871fe2db04c0b40a0201d55352b Reviewed

[Libreoffice-commits] core.git: sc/source

2018-07-12 Thread Noel Grandin
sc/source/filter/inc/extlstcontext.hxx |2 +- sc/source/filter/oox/extlstcontext.cxx |7 +++ 2 files changed, 4 insertions(+), 5 deletions(-) New commits: commit 816bfa206b0347ad375a804a2ffe8481f6a573d6 Author: Noel Grandin Date: Wed Jul 11 12:35:43 2018 +0200

[Libreoffice-commits] core.git: sc/source

2018-07-12 Thread Noel Grandin
sc/source/filter/inc/lotattr.hxx |6 +++--- sc/source/filter/lotus/lotattr.cxx | 22 -- 2 files changed, 11 insertions(+), 17 deletions(-) New commits: commit 65c5a18e2708ba28f225bf98e4d2972e4e549ea5 Author: Noel Grandin Date: Wed Jul 11 12:24:32 2018 +0200

[Libreoffice-commits] core.git: sc/source

2018-07-12 Thread Noel Grandin
sc/source/filter/excel/tokstack.cxx |4 +--- sc/source/filter/inc/tokstack.hxx |4 ++-- 2 files changed, 3 insertions(+), 5 deletions(-) New commits: commit 9a238644f21014cef085b7124ebc3d1397e85870 Author: Noel Grandin Date: Wed Jul 11 11:20:27 2018 +0200 loplugin:useuniqueptr

[Libreoffice-commits] core.git: sc/source

2018-07-12 Thread Noel Grandin
sc/source/filter/excel/fontbuff.cxx | 10 +- sc/source/filter/inc/lotfntbf.hxx | 36 2 files changed, 13 insertions(+), 33 deletions(-) New commits: commit f37f83e9e879926568bf1f508ad554a20076100d Author: Noel Grandin Date: Wed Jul 11 11:16

[Libreoffice-commits] core.git: include/sot sd/source sot/source

2018-07-12 Thread Noel Grandin
include/sot/storage.hxx|2 +- sd/source/filter/eppt/eppt.cxx |4 ++-- sot/source/sdstor/storage.cxx |8 +++- 3 files changed, 6 insertions(+), 8 deletions(-) New commits: commit acde273ea8b105ed5cc7adec98110b822a1b4490 Author: Noel Grandin Date: Wed Jul 11 17:14:09

[Libreoffice-commits] core.git: sw/source

2018-07-11 Thread Noel Grandin
ba2a084d0e133faefadfe329fb1c28aa8c4f2a32 Author: Noel Grandin Date: Tue Jul 10 14:57:15 2018 +0200 loplugin:useuniqueptr in SwAttrIter Change-Id: I204250a02ac88cc36267b79ef1d70cd361230752 Reviewed-on: https://gerrit.libreoffice.org/57245 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git

[Libreoffice-commits] core.git: sax/source

2018-07-11 Thread Noel Grandin
sax/source/fastparser/fastparser.cxx | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) New commits: commit bd394492c165d27c96a44495d9ca694a242acb8f Author: Noel Grandin Date: Wed Jul 11 09:58:30 2018 +0200 tdf#79878 perf loading docx file, improve threading heuristic

[Libreoffice-commits] core.git: comphelper/source package/source sot/source ucbhelper/source ucb/source unotools/source xmlhelp/source

2018-07-11 Thread Noel Grandin
commits: commit 00850e3fa71cc9ebeacad65f54a98b9a79a8b183 Author: Noel Grandin Date: Wed Jul 11 09:57:47 2018 +0200 clean up UNO available() implementations There seems to be some confusion here. available() is actually the number of bytes that can be read without blocking, but most

[Libreoffice-commits] core.git: sax/source

2018-07-11 Thread Noel Grandin
sax/source/fastparser/fastparser.cxx | 16 1 file changed, 8 insertions(+), 8 deletions(-) New commits: commit 7d5c8923284b1ea8f82e30b7e8b2435e929e6c45 Author: Noel Grandin Date: Tue Jul 10 13:34:41 2018 +0200 tdf#79878 perf loading docx file, more sax

[Libreoffice-commits] core.git: ucb/source

2018-07-11 Thread Noel Grandin
ucb/source/ucp/file/filinpstr.cxx |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit 2e6afbe65c75c919665927f62efa21140a020d46 Author: Noel Grandin Date: Wed Jul 11 08:13:48 2018 +0200 tdf#79877 perf loading docx file, activate SAX threading our nice

[Libreoffice-commits] core.git: sc/source

2018-07-11 Thread Noel Grandin
+-- sc/source/ui/view/tabvwshc.cxx |2 sc/source/ui/view/tabvwshe.cxx |2 sc/source/ui/view/tabvwshh.cxx |2 8 files changed, 86 insertions(+), 92 deletions(-) New commits: commit 877362dadf34c910365490ce53b2dcf902dab8cc Author: Noel Grandin Date

[Libreoffice-commits] core.git: 2 commits - sc/inc sc/source

2018-07-11 Thread Noel Grandin
72eb6f7e47d7c8c19c76cea67330464af47648f1 Author: Noel Grandin Date: Tue Jul 10 13:04:24 2018 +0200 loplugin:useuniqueptr in ScPrintFunc Change-Id: I135c0a333633bbdc362fb80699c6d009a80b23a5 Reviewed-on: https://gerrit.libreoffice.org/57243 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git

[Libreoffice-commits] core.git: include/tools writerfilter/inc writerfilter/Library_writerfilter.mk writerfilter/source

2018-07-10 Thread Noel Grandin
| 90 ++-- writerfilter/source/rtftok/rtfvalue.hxx | 10 78 files changed, 655 insertions(+), 720 deletions(-) New commits: commit 0fb5ca6cc9cc55a4436a36c533461769b1fc8526 Author: Noel Grandin Date: Thu Jul 5 14:29:11 2018 +0200 tdf#79877 perf loading docx

[Libreoffice-commits] core.git: sw/inc sw/source

2018-07-10 Thread Noel Grandin
/source/uibase/inc/fldmgr.hxx |5 - 38 files changed, 183 insertions(+), 196 deletions(-) New commits: commit 1a33947a91685808fd5f6d4903b6ae896686066d Author: Noel Grandin Date: Wed Jul 4 10:07:46 2018 +0200 pass SwField around by std::unique_ptr Fix leak

[Libreoffice-commits] core.git: sc/inc sc/source

2018-07-10 Thread Noel Grandin
sc/inc/cellsuno.hxx |2 +- sc/source/ui/unoobj/cellsuno.cxx |8 +++- 2 files changed, 4 insertions(+), 6 deletions(-) New commits: commit 02329510d45395422556ff2ac0a0e52892aecb77 Author: Noel Grandin Date: Mon Jul 9 16:04:37 2018 +0200 loplugin:useuniqueptr

[Libreoffice-commits] core.git: 2 commits - sc/source

2018-07-10 Thread Noel Grandin
sc/source/ui/inc/prevwsh.hxx |2 +- sc/source/ui/unoobj/docuno.cxx | 12 ++-- sc/source/ui/view/prevwsh.cxx |7 +++ 3 files changed, 10 insertions(+), 11 deletions(-) New commits: commit 5c8f9d0d83127df1017e41d3512a629627527a82 Author: Noel Grandin Date: Wed Jul 4 12

[Libreoffice-commits] core.git: 2 commits - sw/source

2018-07-10 Thread Noel Grandin
6b8a1a6fa77f910a2537958799bbdbac96e0bb57 Author: Noel Grandin Date: Wed Jul 4 10:51:01 2018 +0200 loplugin:useuniqueptr in SwDropPortion Change-Id: I42381af772d545206fc7facb0b893f7a1c8625bf Reviewed-on: https://gerrit.libreoffice.org/57200 Tested-by: Jenkins Reviewed-by: Noel Grandin diff

[Libreoffice-commits] core.git: 2 commits - cui/source dbaccess/source desktop/source filter/source forms/source framework/source include/svtools include/unotools include/vcl sax/qa sc/source sd/sourc

2018-07-10 Thread Noel Grandin
(+), 196 deletions(-) New commits: commit 62cf9b479232c72648dbca426aff1309b897dc7a Author: Noel Grandin Date: Wed Jul 4 10:45:32 2018 +0200 loplugin:useuniqueptr in SwFootnoteSave Change-Id: If70990222a6a59cede90bb52413f22540dd06a75 Reviewed-on: https://gerrit.libreoffice.org

[Libreoffice-commits] core.git: 2 commits - solenv/gbuild sw/inc sw/source uitest/test_main.py

2018-07-10 Thread Noel Grandin
acb7c06ab171d4201842d8183eefeeca2d28c3f5 Author: Noel Grandin Date: Mon Jul 9 14:33:20 2018 +0200 use std::uniqueptr in HandledTextToken fixing a memory leak Change-Id: Ic7754bb88a11855a308d39c6c4c66b89652422a0 Reviewed-on: https://gerrit.libreoffice.org/57186 Tested

[Libreoffice-commits] core.git: cppcanvas/source extensions/source sc/source sd/source sfx2/source svtools/source svx/source sw/source unotools/source vcl/unx writerfilter/source

2018-07-09 Thread Noel Grandin
1501da01092d4ad4e5f3c8499fd8d1e18f87bc0c Author: Noel Grandin Date: Sat Jul 7 09:08:23 2018 +0200 loplugin:oncevar Change-Id: Id295dc0db174a448ef73db9de34f2de07d47f09a Reviewed-on: https://gerrit.libreoffice.org/57108 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git

[Libreoffice-commits] core.git: include/sax sax/source writerfilter/source

2018-07-08 Thread Noel Grandin
insertions(+), 26 deletions(-) New commits: commit a2193f8f33565cc896592acb9d3ab65c756d97fb Author: Noel Grandin Date: Thu Jul 5 12:33:51 2018 +0200 tdf#79878 perf loading docx file, sax improvements these are the smaller improvements, they make about 5% worth of difference

[Libreoffice-commits] core.git: cui/source include/svl include/svtools include/svx include/test include/vcl sc/source svx/source sw/source test/source

2018-07-08 Thread Noel Grandin
/xdocumentauditing.cxx |3 +-- 20 files changed, 31 insertions(+), 29 deletions(-) New commits: commit 40b1e5d40667e5863aa213a31fa1b06085bd407a Author: Noel Grandin Date: Fri Jul 6 19:00:38 2018 +0200 loplugin:passstuffbyref Change-Id: I6e6c47020073ec183c6c8ff9cd026a0bec23b177 Reviewed

[Libreoffice-commits] core.git: include/svx svx/source sw/source

2018-07-07 Thread Noel Grandin
/dflyobj.hxx |2 +- 40 files changed, 67 insertions(+), 65 deletions(-) New commits: commit 363146254bd44ab82d657f2ca0293d03bd111280 Author: Noel Grandin Date: Sat Jul 7 09:29:38 2018 +0200 use std::unique_ptr fo CreateObjectSpecificProperties Change-Id

[Libreoffice-commits] core.git: desktop/source

2018-07-07 Thread Noel Grandin
desktop/source/pkgchk/unopkg/unopkg_misc.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit d4b1f51f99fcb2a6d550f667df14e99983ab9d8c Author: Noel Grandin Date: Sat Jul 7 09:12:41 2018 +0200 fix vecUnaccepted check in printf_packages regression from commit

[Libreoffice-commits] core.git: sc/source

2018-07-06 Thread Noel Grandin
-on: https://gerrit.libreoffice.org/57090 Reviewed-by: Noel Grandin Tested-by: Noel Grandin diff --git a/sc/source/ui/inc/tabview.hxx b/sc/source/ui/inc/tabview.hxx index 52f838705a13..cc8dd64568c9 100644 --- a/sc/source/ui/inc/tabview.hxx +++ b/sc/source/ui/inc/tabview.hxx @@ -148,7 +148,10

[Libreoffice-commits] core.git: vcl/inc vcl/qt5

2018-07-06 Thread Noel Grandin
3fc8179c7ac33616008513e4182f86cd77743151 Author: Noel Grandin Date: Fri Jul 6 13:12:05 2018 +0200 various loplugin in qt5 loplugin:includeform loplugin:staticaccess loplugin:loopvartoosmall loplugin:redundantcast Change-Id: Ibd4848f0c6076d5ae95fff2853e1f6e0ba1c083b diff --git a/vcl/inc

[Libreoffice-commits] core.git: sc/source

2018-07-06 Thread Noel Grandin
sc/source/ui/inc/viewdata.hxx |9 +- sc/source/ui/view/viewdata.cxx | 146 ++--- 2 files changed, 42 insertions(+), 113 deletions(-) New commits: commit 106a544f1e1e84481151df18020da8c58d61f346 Author: Noel Grandin Date: Fri Jul 6 08:55:34 2018 +0200

[Libreoffice-commits] core.git: sc/source

2018-07-06 Thread Noel Grandin
| 48 6 files changed, 45 insertions(+), 53 deletions(-) New commits: commit df8589bd49d7eb1bb42ae78abcb91d33cf9255ce Author: Noel Grandin Date: Thu Jul 5 15:01:31 2018 +0200 loplugin:useuniqueptr in XclExpObjList Change-Id

[Libreoffice-commits] core.git: sc/inc sc/source

2018-07-05 Thread Noel Grandin
| 105 ++--- sc/source/core/data/document10.cxx | 12 +-- sc/source/core/data/documentimport.cxx |2 8 files changed, 75 insertions(+), 98 deletions(-) New commits: commit b8335d6b5b6b0184ed7c5d141c6a956187bcf9cf Author: Noel Grandin Date: Wed Jul 4 15:35:54

[Libreoffice-commits] core.git: sc/source

2018-07-04 Thread Noel Grandin
sc/source/core/tool/chartlis.cxx | 86 --- 1 file changed, 19 insertions(+), 67 deletions(-) New commits: commit 44137151dfd719ed921aece504eb11c5e098492c Author: Noel Grandin Date: Wed Jul 4 13:49:05 2018 +0200 simplify ScChartListenerCollection

[Libreoffice-commits] core.git: sc/inc sc/source

2018-07-04 Thread Noel Grandin
sc/inc/dptabres.hxx |2 +- sc/source/core/data/dptabres.cxx | 29 ++--- 2 files changed, 15 insertions(+), 16 deletions(-) New commits: commit f0d007b7b70e2845df082d11f023e4fca9ac947f Author: Noel Grandin Date: Wed Jul 4 13:53:15 2018 +0200

[Libreoffice-commits] core.git: sc/inc sc/source

2018-07-04 Thread Noel Grandin
sc/inc/chart2uno.hxx |2 +- sc/source/ui/unoobj/chart2uno.cxx |8 2 files changed, 5 insertions(+), 5 deletions(-) New commits: commit f91705bf48f4675838452c92f261867600f27bf7 Author: Noel Grandin Date: Tue Jul 3 09:22:53 2018 +0200 loplugin:useuniqueptr

[Libreoffice-commits] core.git: sc/source

2018-07-04 Thread Noel Grandin
| 38 +++--- sc/source/ui/view/tabvwsh2.cxx| 24 +--- 7 files changed, 51 insertions(+), 59 deletions(-) New commits: commit c7f762973d21118ce3f5b0baab8850dc89bc4765 Author: Noel Grandin Date: Tue Jul 3 11:09:03 2018 +0200

[Libreoffice-commits] core.git: sc/inc sc/source

2018-07-04 Thread Noel Grandin
aab78c06f42fea5662c32d842e513bd212aa9c31 Author: Noel Grandin Date: Tue Jul 3 09:40:40 2018 +0200 loplugin:useuniqueptr in ScCellTextData Change-Id: I60a0ffe27b2bbd7d2661fc0fa288730cb71be0b2 Reviewed-on: https://gerrit.libreoffice.org/56904 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git

[Libreoffice-commits] core.git: sc/inc sc/source

2018-07-04 Thread Noel Grandin
sc/inc/cellsuno.hxx |2 +- sc/source/ui/unoobj/cellsuno.cxx |9 - 2 files changed, 5 insertions(+), 6 deletions(-) New commits: commit fa1028a0cd2b50d7077e4d3f7e3ae2ea96f19a53 Author: Noel Grandin Date: Tue Jul 3 13:02:16 2018 +0200 loplugin:useuniqueptr

[Libreoffice-commits] core.git: sc/source

2018-07-04 Thread Noel Grandin
sc/source/ui/inc/output.hxx |6 +++--- sc/source/ui/view/output.cxx |9 +++-- 2 files changed, 6 insertions(+), 9 deletions(-) New commits: commit 13eb18a3874fe2bfdba4b93e8035494fd83563bf Author: Noel Grandin Date: Tue Jul 3 10:38:46 2018 +0200 loplugin:useuniqueptr

[Libreoffice-commits] core.git: sc/inc sc/source

2018-07-04 Thread Noel Grandin
sc/inc/cellsuno.hxx | 12 ++-- sc/source/ui/unoobj/cellsuno.cxx | 25 - 2 files changed, 18 insertions(+), 19 deletions(-) New commits: commit 7b6411d0160ea9b714607274aa89ad3b09c09cae Author: Noel Grandin Date: Tue Jul 3 10:45:07 2018 +0200

[Libreoffice-commits] core.git: 2 commits - sc/source

2018-07-04 Thread Noel Grandin
a618f06d1f6c480d46eb0630f82e25963c654a35 Author: Noel Grandin Date: Tue Jul 3 10:31:15 2018 +0200 loplugin:useuniqueptr in ScPreview Change-Id: I081066d34ed6b134b5354f8df7f9801356ef181c Reviewed-on: https://gerrit.libreoffice.org/56907 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/sc

[Libreoffice-commits] core.git: sc/source

2018-07-04 Thread Noel Grandin
sc/source/ui/inc/notemark.hxx |2 +- sc/source/ui/view/notemark.cxx |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) New commits: commit ac49eb6ef947e21504d7f20d2d5e9fea4dbd263f Author: Noel Grandin Date: Tue Jul 3 09:42:47 2018 +0200 loplugin:useuniqueptr

[Libreoffice-commits] core.git: 2 commits - comphelper/source compilerplugins/clang drawinglayer/source include/comphelper package/inc package/qa package/source sc/inc sc/source sw/source vcl/source

2018-07-04 Thread Noel Grandin
38733c7daab85793a8d88c58808f8e35d3d25887 Author: Noel Grandin Date: Tue Jul 3 09:36:24 2018 +0200 loplugin:useuniqueptr in ScSimpleEditSourceHelper Change-Id: Iebe62753d9e6f83f985e4c55fb938d5861613898 Reviewed-on: https://gerrit.libreoffice.org/56903 Tested-by: Jenkins

[Libreoffice-commits] core.git: dbaccess/source include/svtools svtools/source

2018-07-03 Thread Noel Grandin
79cb267812f0c22919fddc4d60d381fa649f8d05 Author: Noel Grandin Date: Tue Jul 3 10:19:21 2018 +0200 no need to switch models in the SvTreeListBox since we're replacing it completely anyhow. which means we can remove DisconnectFromModel Change-Id: I2f31d93eb95a641f3364d715111e70817c7e5087 Reviewed

[Libreoffice-commits] core.git: include/svx svx/source sw/inc sw/source

2018-07-03 Thread Noel Grandin
Author: Noel Grandin Date: Sun Jul 1 22:04:20 2018 +0200 use std::unique_ptr for CreateObjectSpecificViewContact Change-Id: I0fed54d345a43fe0bc21ebbe424e6fdc7eac9523 Reviewed-on: https://gerrit.libreoffice.org/56823 Reviewed-by: Noel Grandin Tested-by: Noel Grandin

[Libreoffice-commits] core.git: sw/source

2018-07-03 Thread Noel Grandin
sw/source/core/text/pordrop.hxx |8 sw/source/core/text/txtdrop.cxx |6 +++--- 2 files changed, 7 insertions(+), 7 deletions(-) New commits: commit 24218c21712bc900a6641bd1844878f07b173df7 Author: Noel Grandin Date: Mon Jul 2 14:45:07 2018 +0200 loplugin:useuniqueptr

[Libreoffice-commits] core.git: 2 commits - sc/inc sc/source sw/source

2018-07-03 Thread Noel Grandin
/text/wrong.cxx | 77 ++-- sw/source/core/txtnode/SwGrammarContact.cxx | 20 +++ 7 files changed, 66 insertions(+), 85 deletions(-) New commits: commit 3769a6271120e0e856b53f906654bc2c593804fe Author: Noel Grandin Date: Mon Jul 2 16:56:17 2018 +0200

[Libreoffice-commits] core.git: accessibility/source basctl/source cui/source dbaccess/source include/svtools reportdesign/source sc/source sd/source sfx2/source svtools/source svx/source sw/source

2018-07-03 Thread Noel Grandin
|2 - 33 files changed, 90 insertions(+), 113 deletions(-) New commits: commit 904c97bbdf4c76709dbcacb11292668b98a9efd8 Author: Noel Grandin Date: Mon Jul 2 17:23:59 2018 +0200 move SvTreeList::*Sibling to SvTreeListEntry since they don't depend on SvTreeList at all

[Libreoffice-commits] core.git: 2 commits - sw/source

2018-07-03 Thread Noel Grandin
Author: Noel Grandin Date: Mon Jul 2 14:36:54 2018 +0200 loplugin:useuniqueptr in SwGrfNumPortion Change-Id: I87f60bc3b6dc11246202801f39cbc7cf464e1890 Reviewed-on: https://gerrit.libreoffice.org/56829 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/sw/source

[Libreoffice-commits] core.git: 3 commits - include/svtools sc/inc sc/source svtools/source

2018-07-03 Thread Noel Grandin
+++--- svtools/source/contnr/treelist.cxx|7 --- svtools/source/contnr/treelistbox.cxx |5 ++--- 8 files changed, 15 insertions(+), 15 deletions(-) New commits: commit 0df31898281a771821d62ad419c7343da72cfb51 Author: Noel Grandin Date: Mon Jul 2 11:02:59 2018 +0200

  1   2   3   4   5   6   7   8   9   10   >